Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --verbose as an alias of --log-mach-level debug #14619

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make --verbose as an alias of --log-mach-level debug #14619

wants to merge 7 commits into from

Conversation

qiuzhong
Copy link
Contributor

Add a new option --verbose to ./wpt run command line as an alias
of --log-mach-level debug.
Fix: #7846

@wpt-pr-bot wpt-pr-bot added infra wpt wptrunner The automated test runner, commonly called through ./wpt run labels Dec 20, 2018
jgraham
jgraham requested changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works if we are using the mach logger. In case we aren't it will cause an error, so something else is needed.

@gsnedders
Copy link
Member

See also the comments earlier in #7846

@qiuzhong
Make --verbose as an alias of --log-mach-level debug
8d8aeb1 
Add a new option `--verbose` to `./wpt run` command line as an alias
of `--log-mach-level debug`.
Fix: web-platform-tests#7846
@qiuzhong qiuzhong force-pushed the issue-7846 branch 2 times, most recently from e543135 to 5caeb87 Compare December 29, 2018 12:17
@qiuzhong
Copy link
Contributor Author

@jgraham , @gsnedders , please take a look at the new commits for issue #7846. --verbose option should be able to support all types of loggers now, not just for the mach logger.

@frivoal frivoal removed the css-text label Apr 23, 2019
@gsnedders gsnedders removed their assignment Jan 31, 2020
@annevk annevk removed the fetch label Oct 14, 2022
@annevk annevk removed their request for review October 14, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham requested changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@alvestrand alvestrand Awaiting requested review from alvestrand

@AmeliaBR AmeliaBR Awaiting requested review from AmeliaBR

@bert-github bert-github Awaiting requested review from bert-github

@beverloo beverloo Awaiting requested review from beverloo

@chrishtr chrishtr Awaiting requested review from chrishtr

@clelland clelland Awaiting requested review from clelland

@dbaron dbaron Awaiting requested review from dbaron

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@domenic domenic Awaiting requested review from domenic

@domfarolino domfarolino Awaiting requested review from domfarolino

@fantasai fantasai Awaiting requested review from fantasai

@foolip foolip Awaiting requested review from foolip

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2dcontext background-fetch certs clipboard-apis CSS2 css-contain css-multicol css-sizing dom feature-policy filter-effects html infra mediaqueries quirks testharness.js vendor-imports wg-css wg-das wg-html wg-webplatform wpt wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ./wpt run --verbose as an alias of --log-mach-level debug
7 participants
@qiuzhong @gsnedders @jgraham @frivoal @dontcallmedom @annevk @wpt-pr-bot