Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone blog broken on Insiders #5922

Closed
4 tasks done
StarfallProjects opened this issue Aug 29, 2023 · 6 comments
Closed
4 tasks done

Standalone blog broken on Insiders #5922

StarfallProjects opened this issue Aug 29, 2023 · 6 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@StarfallProjects
Copy link
Contributor

StarfallProjects commented Aug 29, 2023

Context

No response

Bug description

I am using Insiders to build a standalone blog site. I just realised my latest builds aren't actually generating the blog: the blog posts aren't getting added to the nav or displayed on the site.

Related links

Reproduction

9.2.5+insiders.4.40.1-insiders-blog-borked.zip

Steps to reproduce

  1. Create a fresh project and fresh virtual env, per the reproduction guide
  2. Install the latest Insider with pip install git+https://${GH_TOKEN}@github.com/squidfunk/mkdocs-material-insiders.git (replace token with your token)
  3. Set the site up to be a standalone blog site:
plugins:
  - blog:
      blog_dir: .

My full mkdocs.yml:

site_name: My Docs
theme:
  name: material
plugins:
  - info
  - blog:
      blog_dir: .
nav:
  - index.md
  1. Run locally with mkdocs serve

Result is the site builds. It warns you the blog posts aren't included in the navigation, and they do not appear on the site.

Python version 3.11.2 when creating the reproduction, but have seen the issue on 3.10.x as well. Issue has occurred both locally and on my live site built with Cloudflare Pages. Worth noting I updated to a newer Python version as a fix for another issue (which I believe has already been reported here: #5916)

This issue only appeared recently, but I can't pinpoint when exactly (I have a horrible feeling my blog has been down a couple of days without me noticing) As a temporary fix I replaced Insiders with normal Material, and that's working fine (also worked fine with the minimal reproduction)

The issue only seems to affect standalone blogs. When I changed the minimal repro to use the default blog directory, it worked.

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting and for the detailed analysis! Looking into it.

@squidfunk squidfunk added the bug Issue reports a bug label Aug 30, 2023
@squidfunk
Copy link
Owner

Fixed in a0280cb. I've taken the time and did a refactoring, unifying how views and pages are constructed. There might still be issues, as it's still a ground up rewrite of what we had before, but I feel that we made a big leap in the right direction!

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Aug 30, 2023
@squidfunk
Copy link
Owner

squidfunk commented Aug 30, 2023

By the way, I'm very sorry for the troubles and inconvenience this has caused. We really try hard not to break functionality for Insiders, but sometimes things are hard to foresee. Big refactorings are hard. Luckily, there's always a version to get back to when things go wrong, and we try to fix things as quickly as we possibly can.

@StarfallProjects
Copy link
Contributor Author

@squidfunk no big deal, at least as far as I'm concerned: it was a hobby-blog that broke, not my personal-professional site, let alone n8n's :-) So all good here. I just had a slightly panicky hour or so trying to narrow down why my content had vanished (was it the Python version? Cloudflare build image? Me doing something daft? etc. 😅) These things happen.

@squidfunk
Copy link
Owner

The problem was directly related to an attempt to fix custom index pages, more specifically:

Those should now work again as expected. I'm still finishing the last tests and will issue a new release later today.

@squidfunk
Copy link
Owner

Released as part of 9.2.6+insiders-4.40.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants