Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rollup merge of #78934 - DeveloperC286:issue_60302_vec, r=m-ou-se" #80814

Closed
wants to merge 1 commit into from

Conversation

rylev
Copy link
Member

@rylev rylev commented Jan 8, 2021

This is the second attempt to find the cause of the perf regression in the rollup #80530. It reverts #78934.

r? @ghost

This reverts commit 242a252, reversing
changes made to 507bff9.

…ec, r=m-ou-se"

This reverts commit 242a252, reversing
changes made to 507bff9.
@rylev
Copy link
Member Author

rylev commented Jan 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 8, 2021

⌛ Trying commit e816079 with merge 16af6f17ca2d426cb8a8883fdb0c083de796ffac...

@bors
Copy link
Contributor

bors commented Jan 8, 2021

☀️ Try build successful - checks-actions
Build commit: 16af6f17ca2d426cb8a8883fdb0c083de796ffac (16af6f17ca2d426cb8a8883fdb0c083de796ffac)

@rust-timer
Copy link
Collaborator

Queued 16af6f17ca2d426cb8a8883fdb0c083de796ffac with parent 3d8608a, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 8, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (16af6f17ca2d426cb8a8883fdb0c083de796ffac): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 8, 2021
@rylev
Copy link
Member Author

rylev commented Jan 8, 2021

Screenshot 2021-01-08 at 17 14 43

This seems to be the likely culprit.

@Mark-Simulacrum
Copy link
Member

Yeah, I'm guessing this is something we should just led slide for now - seems to be CGU partitioning and I don't think it's worth reverting.

@rylev
Copy link
Member Author

rylev commented Jan 8, 2021

I think we should investigate the cause of the perf issues, but I agree there's no reason to actually revert this change.

@rylev rylev closed this Jan 8, 2021
@rylev rylev deleted the revert-78934 branch January 8, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants