Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Iterator::array_chunks to Iterator::chunks #104969

Conversation

rossmacarthur
Copy link
Contributor

The most logical way to yield chunks from an iterator is with arrays. Originally I named this to align with slice::array_chunks but I think chunks makes more sense for iterators and it aligns with the next_chunk method.

Related #100450

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2022

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

The most logical way to yield chunks from an iterator is with arrays.
Originally I named this to align with `slice::array_chunks` but I think
`chunks` makes more sense for iterators and it aligns with the
`next_chunk` method.
@jdahlstrom
Copy link

jdahlstrom commented Nov 29, 2022

I would expect chunks to be reserved for a possible future method that takes a runtime size and returns an iterator over subiterators. Ie. what Itertools::chunks does.

@rossmacarthur
Copy link
Contributor Author

Yeah, good point 🤔, I wonder if next_chunk is better called next_array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants