Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch-pc-windows-msvc should support hardware floating point by default. #66701

Closed
smj389 opened this issue Nov 24, 2019 · 0 comments · Fixed by #66711
Closed

aarch-pc-windows-msvc should support hardware floating point by default. #66701

smj389 opened this issue Nov 24, 2019 · 0 comments · Fixed by #66711
Labels
C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@smj389
Copy link

smj389 commented Nov 24, 2019

When I cross-compile a project to aarch64-pc-windows-msvc using an x64-pc-windows-msvc toolchain, the output uses software floating point. I am building using this command

cargo build --target aarch64-pc-windows-msvc --release

I am on the latest nightly.

When I add target-feature=+fp-armv8, I get hardware floating point.

According to the Microsoft Documentation:

The ARM64 version of Windows presupposes that it's running on an ARMv8 or later architecture at all times. Both floating-point and NEON support are presumed to be present in hardware.

Therefore, I would suggest that target-feature=+fp-armv8,+neon should be the default for this target.
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2019
@mattico mattico mentioned this issue Nov 24, 2019
Merged
@bors bors closed this as completed in 9e2802b Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hardware floating point features to aarch64-pc-windows-msvc mattico/rust
2 participants
@jonas-schievink @smj389