Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0002 needs to be updated to new format #35495

Closed
sophiajt opened this issue Aug 8, 2016 · 5 comments
Closed

E0002 needs to be updated to new format #35495

sophiajt opened this issue Aug 8, 2016 · 5 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 8, 2016

From: src/test/compile-fail/E0002.rs

Errror E0002 needs a label and help moved to a simple help, updating it from:

error[E0002]: non-exhaustive patterns: type std::option::Option<i32> is non-empty
  --> src/test/compile-fail/E0002.rs:14:5
   |
14 |     match x { } //~ ERROR E0002
   |     ^^^^^^^^^^^
   |
help: Please ensure that all possible cases are being handled; possibly adding wildcards or more match arms.
  --> src/test/compile-fail/E0002.rs:14:5
   |
14 |     match x { } //~ ERROR E0002
   |     ^^^^^^^^^^^

To:

error[E0002]: non-exhaustive patterns: type std::option::Option<i32> is non-empty
  --> src/test/compile-fail/E0002.rs:14:5
   |
14 |     match x { } //~ ERROR E0002
   |     ^^^^^^^^^^^ not all cases are handled
   |
   = note: this may be fixed by possibly adding wildcards or more match arms.
@srdja
Copy link

srdja commented Aug 8, 2016

I can work on this.

edit: I see it has already been assigned. I guess I'll have to find something else to work on. :)

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 8, 2016
@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2016

This error is basically a hack and should be merged into E0004.

@bstrie
Copy link
Contributor

bstrie commented Sep 25, 2016

I've opened #36724 to address @arielb1's comment. In the meantime, I'm leaving it up to @jonathandturner as to whether this issue should be addressed as normal or if we should close this outright. In the meantime, I'm operating under the assumption that this will remain open, and am offering it to anyone as a part of #35233 .

@jfirebaugh
Copy link
Contributor

#36909 has been merged and E0002 is now unused (modulo #37058), so this can be closed.

@sophiajt
Copy link
Contributor Author

sophiajt commented Oct 9, 2016

Let's go ahead and close those. We'll likely end up doing a sweep over the errors once the last errors are update and we move many of the compile-fail tests over to ui tests.

@sophiajt sophiajt closed this as completed Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

5 participants