Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UB in Collect:: reserve_get_tail_slice #851

Closed
erickt opened this issue Apr 28, 2021 · 1 comment · Fixed by #852
Closed

UB in Collect:: reserve_get_tail_slice #851

erickt opened this issue Apr 28, 2021 · 1 comment · Fixed by #852

Comments

@erickt
Copy link

erickt commented Apr 28, 2021

It appears that Collect::reserve_get_tail_slice might have undefined behavior. The code is reserving uninitialized space, then creating a mutable reference to it. This us UB according to this documentation.
@erickt erickt mentioned this issue Apr 28, 2021
Open
5 tasks
@cuviper
Copy link
Member

cuviper commented Apr 28, 2021 •
edited
Loading

I thought the validity of having uninitialized data behind references hasn't been decided yet (UCG#77), but I guess we could probably use &mut [MaybeUninit<T>] here.

@cuviper cuviper mentioned this issue Apr 28, 2021
Merged
@bors bors bot closed this as completed in aacced8 Apr 29, 2021
@erickt erickt mentioned this issue Apr 29, 2021
Closed
@cuviper cuviper mentioned this issue Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use &mut [MaybeUninit<T>] in iter::collect cuviper/rayon
2 participants
@cuviper @erickt