Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate en-es Ref [es] Spanish folder localization docs/kubernetes #5644

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Victorsesan
Copy link

@Victorsesan Victorsesan commented Nov 20, 2024

@Victorsesan Victorsesan requested a review from a team as a code owner November 20, 2024 14:54
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team November 20, 2024 14:54
@Victorsesan
Copy link
Author

👋@theletterf this good?

@chalin chalin changed the title Translate en-es Ref [es] Spanish folder localization docs/kubernetes #5227 Translate en-es Ref [es] Spanish folder localization docs/kubernetes Nov 20, 2024
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks for having resubmitted the PR over a branch other than main. Let's run some fix commands now.

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

/fix:text

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:text was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Victorsesan - as you can see from https://github.com/open-telemetry/opentelemetry.io/actions/runs/11939002432/job/33278536370, there are some links to fix and/or missing heading IDs to be added:

> npm run check:links
...
tmp/bin/htmltest --log-level 1
htmltest started at 05:58:01 on public
========================================================================
running in concurrent mode, this is experimental
es/docs/zero-code/python/operator/index.html
  hash does not exist --- es/docs/zero-code/python/operator/index.html --> /es/docs/kubernetes/operator/automatic/#annotations-python-musl
es/docs/kubernetes/collector/components/index.html
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#kubernetes-attributes-preset
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#kubelet-metrics-preset
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#logs-collection-preset
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#cluster-metrics-preset
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#cluster-metrics-preset
  hash does not exist --- es/docs/kubernetes/collector/components/index.html --> ../../helm/collector/#host-metrics-preset
========================================================================
✘✘✘ failed in 2m36.020725025s
7 errors in 1983 documents

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

fix:text was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Oops, /fix:text doesn't trigger run the fix script! Let's fix that.

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

@Victorsesan - this PR will need to be manually rebased from a refeshly pulled in main, since we can't do so using the Github web interface:

image

@open-telemetry/docs-approvers - after the rebase is done I'll test:

@opentelemetrybot opentelemetrybot requested a review from a team December 3, 2024 01:40
@opentelemetrybot opentelemetrybot requested a review from a team December 3, 2024 01:40
@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

@open-telemetry/docs-es-approvers PTAL!

@krol3
Copy link
Contributor

krol3 commented Dec 9, 2024

Hi @Victorsesan, It’s recommended to create only one PR per page to make it easier to review each page individually. we could schedule a time to resolve the issues. Ping me in slack please. Please try to divide in one only PR for each page, to be more easy to review.

@@ -3,7 +3,7 @@ title: OpenTelemetry con Kubernetes
linkTitle: Kubernetes
weight: 350
description: Usando OpenTelemetry con Kubernetes
default_lang_commit: d638c386ae327328ff35604df54fa6ddd8b51b65
default_lang_commit: f9893e13ba9ea10f1b5bcecb52cdd3d907bf0fd9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default_lang_commit: f9893e13ba9ea10f1b5bcecb52cdd3d907bf0fd9
default_lang_commit: d638c386ae327328ff35604df54fa6ddd8b51b65

@Victorsesan you only modify if you update the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants