Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMD implementations #10

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

SIMD implementations #10

wants to merge 5 commits into from

Conversation

Cryptex-github
Copy link
Collaborator

@Cryptex-github Cryptex-github commented Dec 23, 2022

Hello all,

This is a PR that introduces performance increase to RIL by utilizing platform specific instructions (otherwise known as SIMD).

Blockers

@Cryptex-github Cryptex-github added enhancement New feature or request perf Performance related labels Dec 23, 2022
@Cryptex-github Cryptex-github temporarily deployed to benchmarks December 23, 2022 06:13 — with GitHub Actions Inactive
Copy link
Owner

@jay3332 jay3332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypte's review

src/arch/manual.rs Outdated Show resolved Hide resolved
src/arch/mod.rs Outdated Show resolved Hide resolved
src/arch/x86.rs Show resolved Hide resolved
src/arch/x86.rs Outdated Show resolved Hide resolved
src/arch/x86.rs Outdated Show resolved Hide resolved
src/arch/x86.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/pixel.rs Outdated Show resolved Hide resolved
@Cryptex-github Cryptex-github temporarily deployed to benchmarks December 23, 2022 20:31 — with GitHub Actions Inactive
@Cryptex-github Cryptex-github temporarily deployed to benchmarks December 23, 2022 21:37 — with GitHub Actions Inactive
@Cryptex-github Cryptex-github temporarily deployed to benchmarks December 23, 2022 22:37 — with GitHub Actions Inactive
@Pandapip1
Copy link

What's the status of this?

@Cryptex-github
Copy link
Collaborator Author

What's the status of this?

Blocked by rust-lang/rust#86656. Portable SIMD is more optimized and less platform dependent than trying to create a custom solution. We might consider start implementing portable SIMD features under a nightly feature gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants