Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add command line args for OpenTelemetry Subscribe sample #1265

Merged
merged 2 commits into from
Sep 30, 2024
Merged

docs: Add command line args for OpenTelemetry Subscribe sample #1265

merged 2 commits into from
Sep 30, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Sep 30, 2024 •
edited
Loading

Add args to funnel from CLI to the sample

@mukund-ananthu mukund-ananthu requested review from a team as code owners September 30, 2024 03:47
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Sep 30, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Sep 30, 2024
@mukund-ananthu mukund-ananthu self-assigned this Sep 30, 2024
@mukund-ananthu
Copy link
Contributor Author

@hongalex PTAL

@mukund-ananthu mukund-ananthu merged commit 0ff7f2a into main Sep 30, 2024
27 checks passed
@mukund-ananthu mukund-ananthu deleted the add_args branch September 30, 2024 17:20
@release-please release-please bot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@engelke engelke Awaiting requested review from engelke engelke is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukund-ananthu @hongalex