-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementing Storage Billing model property to BQ Datasets #1643
feat: implementing Storage Billing model property to BQ Datasets #1643
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Thanks so much for the contribution @sriramsridhar ! |
@obada-ab Please review this pr and share your comments |
@tswast Please merge this PR |
google/cloud/bigquery/dataset.py
Outdated
@storage_billing_model.setter | ||
def storage_billing_model(self, value): | ||
if not isinstance(value, str) and value is not None: | ||
raise ValueError("Pass a string, or None") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing some unit tests for some of these branches:
google/cloud/bigquery/dataset.py 352 2 81 3 99% 780, 781->783, 784
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ETA on this ?
Is there an ETA on this feature? Our team is waiting on this to be able to set this attribute. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes Issue #1639 🦕