fix: corrects test for non-existent attribute #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Nov 1, 2022
tests/unit/test_table.py
Outdated
| @@ -1969,7 +1970,10 @@ def test_to_geodataframe(self): | |||
| df = row_iterator.to_geodataframe(create_bqstorage_client=False) | |||
| self.assertIsInstance(df, geopandas.GeoDataFrame) | |||
| self.assertEqual(len(df), 0) # verify the number of rows | |||
| self.assertIsNone(df.crs) | |||
| if version_info.major == 3 and version_info.minor > 7: | |||
| assert not hasattr(df, "crs") # used with Python == 3.7 | |||
There was a problem hiding this comment.
Looks like it.
Sigh.
Will go fix.
parthea
approved these changes
Nov 2, 2022
1 task
This was referenced Nov 8, 2022
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
* fix: corrects test for non-existent attribute * updates import statement to fix linting issue * updates a test to check for Python version * updates comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test was failing because we were attempting to access an attribute that does not exist (NOTE it is not supposed to exist for this test).
Our test was supposed to detect that the failing attribute did not exist by using an
assertIsNone()test method, when we should have been asserting that the attribute does not exist, because within theassertIsNone()method, if the attribute does not exist when you call it, it raises anAttributeErrorinstead of returningNone.