Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require protobuf >=3.19, < 5.0.0 #1311

Merged
merged 6 commits into from
Aug 12, 2022
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 11, 2022

fix(deps): require proto-plus >= 1.22.0

@parthea parthea requested a review from a team August 11, 2022 16:52
@parthea parthea requested a review from a team as a code owner August 11, 2022 16:52
@parthea parthea requested a review from prash-mi August 11, 2022 16:52
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 11, 2022
@parthea parthea changed the title fix(deps): allow protobuf < 5.0.0 fix(deps): require protobuf >=3.19, < 5.0.0 Aug 11, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1de7a52 into main Aug 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the allow-protobuf-4 branch August 12, 2022 17:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants