Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: truncated createReadStream through early end event #2056

Merged
merged 3 commits into from
Sep 1, 2022
Merged

fix: truncated createReadStream through early end event #2056

merged 3 commits into from
Sep 1, 2022

Conversation

danielbankhead
Copy link
Contributor

Fixes #2044 🦕
Fixes #2055 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 1, 2022
@danielbankhead danielbankhead marked this pull request as ready for review September 1, 2022 18:38
@danielbankhead danielbankhead requested review from a team as code owners September 1, 2022 18:38
shaffeeullah
shaffeeullah approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Dan!

@shaffeeullah shaffeeullah added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2022
@danielbankhead danielbankhead merged commit a4716a4 into main Sep 1, 2022
@danielbankhead danielbankhead deleted the fix-truncate-downloads branch September 1, 2022 19:50
@release-please release-please bot mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files occasionally being truncated when downloading v6.4.1 seems to introduce a bug with gzipped files
4 participants
@danielbankhead @shaffeeullah @yoshi-kokoro @d-goog