Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dual Region Support #1814

Merged
merged 26 commits into from
Apr 6, 2022
Merged

feat: Dual Region Support #1814

merged 26 commits into from
Apr 6, 2022

Conversation

danielbankhead
Copy link
Contributor

@danielbankhead danielbankhead commented Mar 14, 2022

[Internal] For details and coordination: go/gcs-dpe-dual-region-milestones

Fixes: #1820
Fixes: #1821

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 14, 2022
@snippet-bot
Copy link

snippet-bot bot commented Mar 15, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@danielbankhead danielbankhead changed the title feat: Custom Dual Region Support feat: Dual Region Support Mar 22, 2022
@danielbankhead danielbankhead marked this pull request as ready for review April 5, 2022 20:55
@danielbankhead danielbankhead requested review from a team as code owners April 5, 2022 20:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 5, 2022
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielbankhead danielbankhead merged commit caf7ee5 into main Apr 6, 2022
@danielbankhead danielbankhead deleted the custom-dual-region branch April 6, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sample for Dual Region Bucket Creation Add Support for Dual Region Buckets
3 participants