Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid TypeError if resp is undefined #1273

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Avoid TypeError if resp is undefined #1273

merged 6 commits into from
Sep 28, 2023

Conversation

nathantalewis
Copy link
Contributor

When resp is undefined, this error handling code will itself throw "TypeError: Cannot read properties of undefined (reading 'insertErrors')"

Instead of throwing, we can use optional chaining to allow the error message to be handled as expected.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1272

@nathantalewis nathantalewis requested review from a team as code owners September 13, 2023 20:54
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Sep 13, 2023
@alvarowolfx alvarowolfx mentioned this pull request Sep 13, 2023
Closed
@nathantalewis
fix: avoid TypeError if resp is undefined
b99897d 
When `resp` is undefined, this error handling code will itself throw "TypeError: Cannot read properties of undefined (reading 'insertErrors')"

Instead of throwing, we can use optional chaining to allow the error message to be handled as expected.
@loferris loferris self-assigned this Sep 27, 2023
@loferris loferris added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2023
@loferris loferris added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2023
@loferris loferris added the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
loferris
loferris approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loferris loferris merged commit ff51c1d into googleapis:main Sep 28, 2023
12 of 13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
@release-please release-please bot mentioned this pull request Sep 28, 2023
Merged
This was referenced Oct 3, 2023
Closed
Closed
Closed
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loferris loferris loferris approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@loferris loferris

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'insertErrors') thrown when processing errors
3 participants
@nathantalewis @loferris @yoshi-kokoro