fix: fix BidiBlobWriteSessionConfig to respect preconditions #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankyn
reviewed
Apr 1, 2024
| @Override | ||
| public Mapper<BidiWriteObjectRequest.Builder> bidiWriteObject() { | ||
| return b -> { | ||
| b.getObjectChecksumsBuilder().setCrc32C(val); |
There was a problem hiding this comment.
How did this get past tests? (unless it was part of the JUnit test issue you're working on)
There was a problem hiding this comment.
The tests that were added for bidi specifically didn't tests any preconditions. I'm adding some tests that will run for every BlobWriteSessionConfig to verify they all handle semantics similarly.
There was a problem hiding this comment.
It's subtle i would likely make the same mistake implementing options; thanks ben!
frankyn
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.