-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiplexed session for blind write with single use transaction #3229
Merged
pratickchokhani
merged 10 commits into
googleapis:main
from
pratickchokhani:blind-write
Sep 17, 2024
Merged
feat: support multiplexed session for blind write with single use transaction #3229
pratickchokhani
merged 10 commits into
googleapis:main
from
pratickchokhani:blind-write
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e use transaction.
…blind writes (writeAtLeastOnce)
product-auto-label
bot
added
size: l
Pull request size is large.
api: spanner
Issues related to the googleapis/java-spanner API.
labels
Jul 30, 2024
…o blind-write # Conflicts: # google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java
olavloite
changed the title
feat(spanner): support multiplexed session for blind write with single use transaction
feat: support multiplexed session for blind write with single use transaction
Aug 1, 2024
olavloite
reviewed
Aug 1, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClientImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClientImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClientImpl.java
Outdated
Show resolved
Hide resolved
...oud-spanner/src/main/java/com/google/cloud/spanner/DelayedMultiplexedSessionTransaction.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/com/google/cloud/spanner/MultiplexedSessionDatabaseClientMockServerTest.java
Show resolved
Hide resolved
…SPANNER_MULTIPLEXED_SESSIONS.
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: l
Pull request size is large.
labels
Aug 8, 2024
olavloite
approved these changes
Aug 19, 2024
olavloite
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 19, 2024
… into blind-write
…lind write. This flag will be used by systest.
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Sep 16, 2024
pratickchokhani
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 16, 2024
olavloite
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some minor nits on documentation.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
Outdated
Show resolved
Hide resolved
...-cloud-spanner-executor/src/main/java/com/google/cloud/spanner/SessionPoolOptionsHelper.java
Outdated
Show resolved
Hide resolved
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [6.75.0](https://togithub.com/googleapis/java-spanner/compare/v6.74.1...v6.75.0) (2024-09-19) ### Features * Support multiplexed session for blind write with single use transaction ([#3229](https://togithub.com/googleapis/java-spanner/issues/3229)) ([b3e2b0f](https://togithub.com/googleapis/java-spanner/commit/b3e2b0f4892951867715cb7f354c089fca4f050f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96
pushed a commit
that referenced
this pull request
Sep 19, 2024
…nsaction (#3229) * feat(spanner): support multiplexed session for blind write with single use transaction. * test(spanner): added test for the support of multiplexed session for blind writes (writeAtLeastOnce) * chore(spanner): lint * fix(spanner): updated the adoption for blind write into GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS. * chore: simplify code to make it easier to reuse for later additions * feat(spanner): added flag to control use of multiplexed session for blind write. This flag will be used by systest. * lint(spanner): javadoc fixes. --------- Co-authored-by: Knut Olav Løite <[email protected]>
lqiu96
pushed a commit
that referenced
this pull request
Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [6.75.0](https://togithub.com/googleapis/java-spanner/compare/v6.74.1...v6.75.0) (2024-09-19) ### Features * Support multiplexed session for blind write with single use transaction ([#3229](https://togithub.com/googleapis/java-spanner/issues/3229)) ([b3e2b0f](https://togithub.com/googleapis/java-spanner/commit/b3e2b0f4892951867715cb7f354c089fca4f050f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiplexed sessions, the client optimizes and runs multiple applicable requests concurrently on a single session. A single multiplexed session is sufficient to handle all concurrent writeAtLeastOnce requests.
Normal read/write transactions always use regular sessions.
The use of multiplexed sessions can be enabled through the environment variable
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS
.