feat: Add support for Table resource tags #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shollyman
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Would be great to update this PR's description with the Labels->Annotations refactor. I was initially confused by this PR until a I realized that Labels was a private class and not a type exposed to the user.
Also, it may be worth wiring in resource tags testing into the unit tests within TableInfoTest.java. It already appears to include labels testing.
|
Thanks for the review. Updated:
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.37.0](https://togithub.com/googleapis/java-bigquery/compare/v2.36.0...v2.37.0) (2024-01-25) ### Features * Add support for Table resource tags ([#3046](https://togithub.com/googleapis/java-bigquery/issues/3046)) ([7d61111](https://togithub.com/googleapis/java-bigquery/commit/7d61111d23282c7e2478ac31ba0d4e423330ec92)) * Add universe domain ([#3090](https://togithub.com/googleapis/java-bigquery/issues/3090)) ([b2814a2](https://togithub.com/googleapis/java-bigquery/commit/b2814a2f8e6601347d0489058e563878af40f301)) ### Dependencies * Update actions/upload-artifact action to v4.1.0 ([#3071](https://togithub.com/googleapis/java-bigquery/issues/3071)) ([3fbb2bb](https://togithub.com/googleapis/java-bigquery/commit/3fbb2bba7ad7bca245a8ca5eb59d999aead29ebd)) * Update actions/upload-artifact action to v4.2.0 ([#3081](https://togithub.com/googleapis/java-bigquery/issues/3081)) ([af81354](https://togithub.com/googleapis/java-bigquery/commit/af81354c342cdb2a790cb008fc9fe3460e62265b)) * Update actions/upload-artifact action to v4.3.0 ([#3091](https://togithub.com/googleapis/java-bigquery/issues/3091)) ([f4411b0](https://togithub.com/googleapis/java-bigquery/commit/f4411b09c4b681d2f3fb250ef133b291649f2865)) * Update arrow.version to v15 ([#3084](https://togithub.com/googleapis/java-bigquery/issues/3084)) ([4d4cbae](https://togithub.com/googleapis/java-bigquery/commit/4d4cbae00028f84c071f51e88d7ee976efdf04d5)) * Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.35.0 ([#3066](https://togithub.com/googleapis/java-bigquery/issues/3066)) ([48cdaa8](https://togithub.com/googleapis/java-bigquery/commit/48cdaa8a77935062cfe9ed8fb66f52f774bdd673)) * Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.36.0 ([#3093](https://togithub.com/googleapis/java-bigquery/issues/3093)) ([24456a3](https://togithub.com/googleapis/java-bigquery/commit/24456a361a39550e962ac68a79de3c7a9e912884)) * Update dependency com.google.apis:google-api-services-bigquery to v2-rev20240105-2.0.0 ([#3073](https://togithub.com/googleapis/java-bigquery/issues/3073)) ([f371d67](https://togithub.com/googleapis/java-bigquery/commit/f371d6709109acf07224ee0b2615de400fd90838)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.39.0 ([#3067](https://togithub.com/googleapis/java-bigquery/issues/3067)) ([6ff4f04](https://togithub.com/googleapis/java-bigquery/commit/6ff4f043905a6fe67bc3ed5cbbacc0f9eddd3172)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.40.0 ([#3094](https://togithub.com/googleapis/java-bigquery/issues/3094)) ([110bcc5](https://togithub.com/googleapis/java-bigquery/commit/110bcc506272b372fdd90ee718fad298c8ab7e19)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#3080](https://togithub.com/googleapis/java-bigquery/issues/3080)) ([a5b119c](https://togithub.com/googleapis/java-bigquery/commit/a5b119cdf6f8ce9d180a2d51a3a7a9aad50b1ea4)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#3096](https://togithub.com/googleapis/java-bigquery/issues/3096)) ([0933b34](https://togithub.com/googleapis/java-bigquery/commit/0933b34f30ade216dcf61767a771509ca07f294b)) * Update dependency com.google.oauth-client:google-oauth-client-java6 to v1.35.0 ([#3078](https://togithub.com/googleapis/java-bigquery/issues/3078)) ([2614df2](https://togithub.com/googleapis/java-bigquery/commit/2614df203b1f3c9800b8c8c23d32e7f22ec76253)) * Update dependency com.google.oauth-client:google-oauth-client-jetty to v1.35.0 ([#3079](https://togithub.com/googleapis/java-bigquery/issues/3079)) ([f03c4fc](https://togithub.com/googleapis/java-bigquery/commit/f03c4fc957ae5665fe0f98c0f06cc80eea7cec59)) * Update github/codeql-action action to v2.23.0 ([#3061](https://togithub.com/googleapis/java-bigquery/issues/3061)) ([0fbdfba](https://togithub.com/googleapis/java-bigquery/commit/0fbdfba1aecf18567fae95aea133b6504f050bd5)) * Update github/codeql-action action to v2.23.1 ([#3077](https://togithub.com/googleapis/java-bigquery/issues/3077)) ([e3f417c](https://togithub.com/googleapis/java-bigquery/commit/e3f417cec3bdd81040baac3f054d0270dde9d9f8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Table resource tags. This is accomplished by refactoring Labels to Annotation and using Annotation for resource tags.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3045 ☕️
This PR does not include integration tests for table resource tags due to the complexity of the setup outside. See BigQuery Go implementation for more details