Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery/storage/managedwriter): expose connection multiplexing as experimental #7673

Merged
merged 10 commits into from
Apr 7, 2023
Merged

feat(bigquery/storage/managedwriter): expose connection multiplexing as experimental #7673

merged 10 commits into from
Apr 7, 2023

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Mar 31, 2023 •
edited
Loading

This PR exposes the necessary options to control the new experimental multiplexing features within the managedwriter package, and attempts to document them sufficiently for correct consumption.

Towards: #7103

@shollyman
feat(bigquery/storage/managedwriter): expose connection multiplexing
0565b19 
This PR exposes the necessary options to control the new experimental
multiplexing features within the managedwriter package.
@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Mar 31, 2023
@shollyman shollyman marked this pull request as ready for review April 3, 2023 16:16
@shollyman shollyman requested review from a team as code owners April 3, 2023 16:16
@shollyman shollyman requested review from jainsahab and yirutang and removed request for jainsahab April 3, 2023 16:16
yirutang
yirutang approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description looks good to me.

@shollyman shollyman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 6, 2023
@shollyman shollyman requested a review from codyoss April 6, 2023 15:49
codyoss
codyoss approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one more consideration, but I am fine either way

bigquery/storage/managedwriter/options.go Outdated Show resolved Hide resolved
@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2023
@shollyman shollyman changed the title feat(bigquery/storage/managedwriter): expose connection multiplexing feat(bigquery/storage/managedwriter): expose connection multiplexing as experimental Apr 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3b8bfb4 into googleapis:main Apr 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 7, 2023
@shollyman shollyman deleted the expose-multiplexing branch April 7, 2023 16:24
@release-please release-please bot mentioned this pull request Apr 7, 2023
Merged
This was referenced Apr 25, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shollyman @codyoss @yirutang