feat(bigquery/storage/managedwriter): define append retry predicate #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR models the retry predicate we'll use for evaluating whether appends should be retried automatically.
yirutang
reviewed
Sep 10, 2022
yirutang
approved these changes
Sep 16, 2022
alvarowolfx
reviewed
Sep 16, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
🤖 I have created a release *beep* *boop* --- ## [1.42.0](bigquery/v1.41.0...bigquery/v1.42.0) (2022-09-21) ### Features * **bigquery/analyticshub:** Start generating apiv1 ([#6707](#6707)) ([feb7d7d](feb7d7d)) * **bigquery/datapolicies:** Start generating apiv1beta1 ([#6697](#6697)) ([f5443e8](f5443e8)) * **bigquery/reservation/apiv1beta1:** add REST transport ([f7b0822](f7b0822)) * **bigquery/storage/managedwriter:** Define append retry predicate ([#6650](#6650)) ([478b8dd](478b8dd)) * **bigquery/storage:** add proto annotation for non-ascii field mapping ([ec1a190](ec1a190)) * **bigquery:** Add reference file schema option for federated formats ([#6693](#6693)) ([3d26091](3d26091)) * **bigquery:** Add support for explicit query parameter type ([#6596](#6596)) ([d59b5b2](d59b5b2)), refs [#4704](#4704) ### Bug Fixes * **bigquery/connection:** integrate gapic-generator-python-1.4.1 and enable more py_test targets ([ec1a190](ec1a190)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the existing retry predicate used for evaluating reconnection, and also enables it to be used for evaluating whether appends can be retried. A future PR will plumb in append retry logic.
Towards internal b/245963141