feat(bigquery): improve error when reading null values #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shollyman
approved these changes
Aug 27, 2022
| @@ -455,6 +455,10 @@ func runOps(ops []structLoaderOp, vstruct reflect.Value, values []Value) error { | |||
| err = setRepeated(field, values[op.valueIndex].([]Value), op.setFunc) | |||
| } else { | |||
| err = op.setFunc(field, values[op.valueIndex]) | |||
| if errors.Is(err, errNoNulls) { | |||
| f := vstruct.Type().FieldByIndex(op.fieldIndex) | |||
| err = fmt.Errorf("bigquery: NULL cannot be assigned to field `%s` of type %s", f.Name, f.Type.Name()) | |||
There was a problem hiding this comment.
A thing to keep an eye on for the future is whether we should have a custom error type. My suspicion is this isn't a frequent enough failure to warrant custom errors at this point, nor is it super actionable unless you're dynamically rewriting things.
This was referenced Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message when reading NULL values from a query and trying to fit into a struct field.
Resolves #2612