feat(storage): add direct google access side-effect imports by default #10757
Conversation
storage/doc.go
Outdated
| _ "google.golang.org/grpc/balancer/rls" | ||
| _ "google.golang.org/grpc/xds/googledirectpath" | ||
| ) | ||
| If the application is running within GCP, users may get better performance with Direct Google Access (enabling requests to skip some proxy steps). |
There was a problem hiding this comment.
Let's rephrase this; users don't need to opt-in to Direct Google Access anymore so I don't think this is relevant.
How about:
Using the gRPC API inside GCP with a bucket in the same region can allow for Direct Google Access (enabling requests to skip some proxy steps and reducing response latency).
Also, will a warning be emitted if direct path is attempted and fails? If so we should explain this as well.
storage/doc.go
Outdated
| ) | ||
| If the application is running within GCP, users may get better performance with Direct Google Access (enabling requests to skip some proxy steps). | ||
|
|
||
| Dependencies for Direct Google Access can increase the size of resulting binary by ~16MiB if not used by another dependency and you can opt-out of these dependencies using build tag `disable_grpc_modules`. |
There was a problem hiding this comment.
This seems a little ambiguous as to who wants to use this build tag. I'd say something like:
Dependencies for the gRPC API may slightly increase the size of binaries for applications depending on this package. If you are not using gRPC, you can use the build tag
disable_grpc_modulesto opt out of these dependencies and reduce the binary size.
Add side-effect modules for gRPC DirectPath by default with an opt-out build tag:
disable_grpc_modulesGOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS=true