Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When applying database settings the values aren’t stringified resulting in error. #3228

Closed
misha-reyzlin-hier opened this issue Mar 24, 2021 · 1 comment · Fixed by #3217

Comments

@misha-reyzlin-hier
Copy link

[REQUIRED] Environment info

firebase-tools: 9.6.1

Platform: macOS

[REQUIRED] Test case

The problem is exactly as described in this StackOverflow question
https://stackoverflow.com/questions/65214056/how-to-perform-large-deletes-in-the-firebase-realtime-database#comment118044022_65214056

firebase database:settings:set defaultWriteSizeLimit unlimited

[REQUIRED] Steps to reproduce

Change into a directory with firebase project and run
firebase database:settings:set defaultWriteSizeLimit unlimited

This will return an error.

Expected behaviour is that it results in an updated database setting.

[REQUIRED] Expected behavior

Command returns:

✔ Successfully set setting.
✔ For database instance hierfoods-staging
defaultWriteSizeLimit = ""unlimited""

[REQUIRED] Actual behavior

The command returns: "Error: Unexpected error fetching configs at defaultWriteSizeLimit"

Patching the library in ./database/settings.js on line 23 from

return input;

to

return JSON.stringify(input);

Makes the problem go away.

@samtstern
Copy link
Contributor

Thanks for reporting! We're already working on a fix here:
#3217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants