-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
functions cannot get user's User-Agent when you call it from hosting emulator by using rewrites #2970
Labels
Comments
@dora1998 thanks for reporting this! Seems like a clear bug in our new |
Sorry I'm so slow in coming to these. Let me take a look. |
Well, that was pretty straight forward to fix. Assuming all goes well, watch for it in a new release of |
This was referenced Mar 9, 2021
Closed
Closed
Closed
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
[REQUIRED] Environment info
firebase-tools: 9.1.0
Platform: macOS
[REQUIRED] Test case
The reproducible sample is below.
https://github.com/dora1998/firebase-tools-ua-example
[REQUIRED] Steps to reproduce
git clone https://github.com/dora1998/firebase-tools-ua-example.git
yarn install && yarn serve --project YOUR_PROJECT_ID
http://localhost:5001/YOUR_PROJECT_ID/us-central1/checkUA
, then you'll see your user agent.FirebaseCLI/9.1.0
regardless of your User-Agent.I think this line set the User-Agent regardless of user's one.
https://github.com/firebase/firebase-tools/blob/master/src/apiv2.ts#L203
[REQUIRED] Expected behavior
Functions can get user's UA.
[REQUIRED] Actual behavior
Functions always get
FirebaseCLI/9.1.0
as User-Agent on local emulator.The text was updated successfully, but these errors were encountered: