Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkForNode8 is not a function #2944

Closed
brightsider opened this issue Dec 16, 2020 · 14 comments · Fixed by #2945 or #2946
Closed

checkForNode8 is not a function #2944

brightsider opened this issue Dec 16, 2020 · 14 comments · Fixed by #2945 or #2946
Assignees

Comments

@brightsider
Copy link

brightsider commented Dec 16, 2020

[REQUIRED] Environment info

firebase-tools: 9.0.0

Platform: macOS Big Sur

[REQUIRED] Test case

Deploy firebase functions

[REQUIRED] Steps to reproduce

firebase deploy --only functions

[REQUIRED] Expected behavior

deploy completed without errors

[REQUIRED] Actual behavior

✔ functions[testProcessManual(us-central1)]: Successful update operation.

Error: An unexpected error has occurred.

end of firebase-debug.log:

[debug] [2020-12-16T07:32:37.804Z] <<< HTTP RESPONSE 200 {"content-type":"application/json; charset=UTF-8","vary":"X-Origin, Referer, Origin,Accept-Encoding","date":"Wed, 16 Dec 2020 07:32:37 GMT","server":"ESF","cache-control":"private","x-xss-protection":"0","x-frame-options":"SAMEORIGIN","x-content-type-options":"nosniff","alt-svc":"h3-29=\":443\"; ma=2592000,h3-T051=\":443\"; ma=2592000,h3-Q050=\":443\"; ma=2592000,h3-Q046=\":443\"; ma=2592000,h3-Q043=\":443\"; ma=2592000,quic=\":443\"; ma=2592000; v=\"46,43\"","accept-ranges":"none","transfer-encoding":"chunked"}
[info] ✔  functions[testProcessManual(us-central1)]: Successful update operation.  
[debug] [2020-12-16T07:32:37.806Z] TypeError: checkForNode8 is not a function
    at /usr/local/lib/node_modules/firebase-tools/lib/deploy/functions/release.js:413:13
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:93:5)
[error] 
[error] Error: An unexpected error has occurred.
@muhammad-usman-anwar
Copy link

having Same issue

[REQUIRED] Environment info

firebase-tools: 9.0.0

Platform: Windows

@DavuluriHemanthChowdary

Same issue I've been facing since yesterday and firebasetools:- 9.0.0 is the version

@samtstern samtstern self-assigned this Dec 16, 2020
@samtstern
Copy link
Contributor

@brightsider thank you for reporting this, I'll investigate it now.

@DavuluriHemanthChowdary

[debug] [2020-12-16T10:21:21.415Z] ----------------------------------------------------------------------
[debug] [2020-12-16T10:21:21.417Z] Command: C:\Program Files\nodejs\node.exe C:\Users\heman\AppData\Roaming\npm\node_modules\firebase-tools\lib\bin\firebase.js deploy --only functions
[debug] [2020-12-16T10:21:21.417Z] CLI Version: 9.0.0
[debug] [2020-12-16T10:21:21.417Z] Platform: win32
[debug] [2020-12-16T10:21:21.417Z] Node Version: v15.4.0
[debug] [2020-12-16T10:21:21.419Z] Time: Wed Dec 16 2020 15:51:21 GMT+0530 (India Standard Time)
[debug] [2020-12-16T10:21:21.419Z] ----------------------------------------------------------------------

@samtstern
Copy link
Contributor

The fix is here:
#2945

We should hopefully be able to get 9.0.1 out today with a fix (once the San Francisco folks wake up!)

@DavuluriHemanthChowdary

The fix is here:
#2945

We should hopefully be able to get 9.0.1 out today with a fix (once the San Francisco folks wake up!)

Nice work! Sir

@worldofchris
Copy link

Have same issue

@jwoyo
Copy link

jwoyo commented Dec 16, 2020

Aaargh! Our CI crashed because it executed "npm install firebase-tools" and then "firebase deploy" – doing so we updated to firebase-tools 9.x automatically and it crashed.

Thank you for reporting & fixing this! ❤️
This issue helped me a lot locating the problem.

We will use a fixed version in our deployment script now. 😅

@andrewpolemeni
Copy link

andrewpolemeni commented Dec 16, 2020

I'm having the same issue:
[debug] [2020-12-16T16:33:35.375Z] Command: C:\Program Files\nodejs\node.exe C:\Users\Andrew\AppData\Roaming\npm\node_modules\firebase-tools\lib\bin\firebase.js deploy
[debug] [2020-12-16T16:33:35.375Z] CLI Version: 9.0.0
[debug] [2020-12-16T16:33:35.375Z] Platform: win32
[debug] [2020-12-16T16:33:35.375Z] Node Version: v12.1.0
[debug] [2020-12-16T16:33:35.376Z] Time: Wed Dec 16 2020 11:33:35 GMT-0500 (Eastern Standard Time)
[debug] [2020-12-16T16:33:42.384Z] TypeError: checkForNode8 is not a function
at C:\Users\Andrew\AppData\Roaming\npm\node_modules\firebase-tools\lib\deploy\functions\release.js:413:13
at processTicksAndRejections (internal/process/task_queues.js:89:5)
[error]
[error] Error: An unexpected error has occurred.

@samtstern
Copy link
Contributor

The fix has been merged and will be included in the next release (which should be very soon).

@sharkdevs
Copy link

sharkdevs commented Dec 16, 2020

facing the same issue. Hope to get the fix. So in the meanwhile do we downgrade?

@bkendall
Copy link
Contributor

San Francisco here: release is on the way out the door. Thanks for your patience! (Downgrading to v8.20 would be a fine workaround)

@rajprashanthr
Copy link

Thanks a lot

@bkendall
Copy link
Contributor

This has shipped in v9.0.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants