You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Rdatatable/data.table#4546, we changed all.equal.data.table() to run each column's all.equal() method, as appropriate. Our own suite was hiding some really glaring issues where previously integer64 columns were being compared on their double representation --> horribly wrong test.
At a glance, it looks like the new behavior will be welcome here as well.
This will be released to CRAN ~soon. Since I think the new behavior is strictly more correct, I would appreciate your help pushing a new version to avoid a clunky back-compatibility hack.
I am taking a look at reproducing & filing a PR now, but if the fix is immediately obvious to you, feel free to flag & take over.
Thanks!
The text was updated successfully, but these errors were encountered:
Rdatatable/data.table#6285
In Rdatatable/data.table#4546, we changed
all.equal.data.table()
to run each column'sall.equal()
method, as appropriate. Our own suite was hiding some really glaring issues where previously integer64 columns were being compared on their double representation --> horribly wrong test.At a glance, it looks like the new behavior will be welcome here as well.
This will be released to CRAN ~soon. Since I think the new behavior is strictly more correct, I would appreciate your help pushing a new version to avoid a clunky back-compatibility hack.
I am taking a look at reproducing & filing a PR now, but if the fix is immediately obvious to you, feel free to flag & take over.
Thanks!
The text was updated successfully, but these errors were encountered: