Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table update to do "correct" column dispatch in all.equal() breaks dtts #17

Closed
MichaelChirico opened this issue Jul 16, 2024 · 2 comments · Fixed by #18
Closed

Comments

@MichaelChirico
Copy link
Contributor

Rdatatable/data.table#6285

In Rdatatable/data.table#4546, we changed all.equal.data.table() to run each column's all.equal() method, as appropriate. Our own suite was hiding some really glaring issues where previously integer64 columns were being compared on their double representation --> horribly wrong test.

At a glance, it looks like the new behavior will be welcome here as well.

This will be released to CRAN ~soon. Since I think the new behavior is strictly more correct, I would appreciate your help pushing a new version to avoid a clunky back-compatibility hack.

I am taking a look at reproducing & filing a PR now, but if the fix is immediately obvious to you, feel free to flag & take over.

Thanks!

@eddelbuettel
Copy link
Owner

I am a bit tied up (as I presume @lsilvest is) so help with a PR would be appreciated, as always.

Otherwise: Ack. We stand pat to jump in as needed.

@eddelbuettel
Copy link
Owner

This is now fixed in the new CRAN version -- thanks again for the PR.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants