-
Notifications
You must be signed in to change notification settings - Fork 373
Comparing changes
Open a pull request
base repository: dotnet/templating
base: 5d43d89ab9da3a63359215c5abea86f63516e4f9
head repository: dotnet/templating
compare: 2aad6193928e85f0ecffa0590d55baa4b2f84323
- 11 commits
- 4 files changed
- 5 contributors
Commits on Jul 16, 2024
-
Avoid allocations from calls to CultureInfo.GetCultures
A local profile taken during running the vsixinstaller on roslyn indicated this call was allocating quite heavily in the "devenv /updateconfiguration" process the vsixinstaller kicks off. DirectoryBasedTemplate.ParseLocFileName was allocating 8.1% of all allocations in that devenv process, nearly all of which comes from the CultureInfo.GetCultures call. Instead of allocating all cultures and an array to hold them by calling CultureInfo.GetCultures, this code can use CultureInfo.GetCultureInfo with the requested culture name and use that result instead. Note that GetCultureInfo throws if the requested culture name isn't supported, so we need to catch the corresponding CultureNotFoundException.
Configuration menu - View commit details
-
Copy full SHA for 663a610 - Browse repository at this point
Copy the full SHA 663a610View commit details
Commits on Aug 7, 2024
-
Merge pull request #8232 from dotnet/backport/pr-8231-to-release/8.0.1xx
[release/8.0.1xx] Avoid allocations from calls to CultureInfo.GetCultures
Configuration menu - View commit details
-
Copy full SHA for 4a85a62 - Browse repository at this point
Copy the full SHA 4a85a62View commit details -
Merge pull request #8268 from dotnet/merge/release/8.0.1xx-to-release…
…/8.0.3xx [automated] Merge branch 'release/8.0.1xx' => 'release/8.0.3xx'
Configuration menu - View commit details
-
Copy full SHA for 60fbe5b - Browse repository at this point
Copy the full SHA 60fbe5bView commit details
Commits on Aug 8, 2024
-
Merge branch 'release/8.0.4xx' of https://github.com/dotnet/templating …
…into merge/release/8.0.3xx-to-release/8.0.4xx
Configuration menu - View commit details
-
Copy full SHA for fc472f2 - Browse repository at this point
Copy the full SHA fc472f2View commit details -
Merge pull request #8269 from dotnet/merge/release/8.0.3xx-to-release…
…/8.0.4xx [automated] Merge branch 'release/8.0.3xx' => 'release/8.0.4xx'
Configuration menu - View commit details
-
Copy full SHA for 3e4419f - Browse repository at this point
Copy the full SHA 3e4419fView commit details
Commits on Aug 9, 2024
-
Merge branch 'main' of https://github.com/dotnet/templating into merg…
…e/release/8.0.4xx-to-main
Configuration menu - View commit details
-
Copy full SHA for c02ed5f - Browse repository at this point
Copy the full SHA c02ed5fView commit details -
Merge pull request #8272 from dotnet/merge/release/8.0.4xx-to-main
[automated] Merge branch 'release/8.0.4xx' => 'main'
Configuration menu - View commit details
-
Copy full SHA for c1379d1 - Browse repository at this point
Copy the full SHA c1379d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c18a80b - Browse repository at this point
Copy the full SHA c18a80bView commit details
Commits on Aug 12, 2024
-
Update dependencies from https://github.com/dotnet/arcade build 20240…
…808.2 (#8274) [main] Update dependencies from dotnet/arcade
Configuration menu - View commit details
-
Copy full SHA for 132e112 - Browse repository at this point
Copy the full SHA 132e112View commit details -
Merge branch 'main' of https://github.com/dotnet/templating into merg…
…e/release/8.0.4xx-to-main
Configuration menu - View commit details
-
Copy full SHA for 971a349 - Browse repository at this point
Copy the full SHA 971a349View commit details -
Merge pull request #8275 from dotnet/merge/release/8.0.4xx-to-main
[automated] Merge branch 'release/8.0.4xx' => 'main'
Configuration menu - View commit details
-
Copy full SHA for 2aad619 - Browse repository at this point
Copy the full SHA 2aad619View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5d43d89ab9da3a63359215c5abea86f63516e4f9...2aad6193928e85f0ecffa0590d55baa4b2f84323