Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/templating
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5d43d89ab9da3a63359215c5abea86f63516e4f9
Choose a base ref
...
head repository: dotnet/templating
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2aad6193928e85f0ecffa0590d55baa4b2f84323
Choose a head ref
  • 11 commits
  • 4 files changed
  • 5 contributors

Commits on Jul 16, 2024

  1. Avoid allocations from calls to CultureInfo.GetCultures

    A local profile taken during running the vsixinstaller on roslyn indicated this call was allocating quite heavily in the "devenv /updateconfiguration" process the vsixinstaller kicks off. DirectoryBasedTemplate.ParseLocFileName was allocating 8.1% of all allocations in that devenv process, nearly all of which comes from the CultureInfo.GetCultures call.
    
    Instead of allocating all cultures and an array to hold them by calling CultureInfo.GetCultures, this code can use CultureInfo.GetCultureInfo with the requested culture name and use that result instead. Note that GetCultureInfo throws if the requested culture name isn't supported, so we need to catch the corresponding CultureNotFoundException.
    ToddGrun authored and github-actions committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    663a610 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge pull request #8232 from dotnet/backport/pr-8231-to-release/8.0.1xx

    [release/8.0.1xx] Avoid allocations from calls to CultureInfo.GetCultures
    Forgind authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a85a62 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8268 from dotnet/merge/release/8.0.1xx-to-release…

    …/8.0.3xx
    
    [automated] Merge branch 'release/8.0.1xx' => 'release/8.0.3xx'
    Forgind authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    60fbe5b View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge branch 'release/8.0.4xx' of https://github.com/dotnet/templating

    …into merge/release/8.0.3xx-to-release/8.0.4xx
    v-wuzhai committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fc472f2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8269 from dotnet/merge/release/8.0.3xx-to-release…

    …/8.0.4xx
    
    [automated] Merge branch 'release/8.0.3xx' => 'release/8.0.4xx'
    Forgind authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3e4419f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    c02ed5f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8272 from dotnet/merge/release/8.0.4xx-to-main

    [automated] Merge branch 'release/8.0.4xx' => 'main'
    v-wuzhai authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c1379d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c18a80b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Update dependencies from https://github.com/dotnet/arcade build 20240…

    …808.2 (#8274)
    
    [main] Update dependencies from dotnet/arcade
    dotnet-maestro[bot] authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    132e112 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    971a349 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #8275 from dotnet/merge/release/8.0.4xx-to-main

    [automated] Merge branch 'release/8.0.4xx' => 'main'
    v-wuzhai authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2aad619 View commit details
    Browse the repository at this point in the history
Loading