feat: Add parameter --min-sigterm-delay #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inimum number off seconds before shutting down the proxy.
enocom
reviewed
Jul 10, 2024
| case errors.Is(err, errQuitQuitQuit): | ||
| cmd.logger.Infof("/quitquitquit received request. Shutting down...") | ||
| time.Sleep(cmd.conf.WaitBeforeClose) |
There was a problem hiding this comment.
Shall we just add one of these right above the return statement below?
There was a problem hiding this comment.
No, because we don't want to delay in the case of the default error. We only want to delay if the exit process was somehow initiated by the user.
enocom
approved these changes
Jul 11, 2024
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-proxy-operator
that referenced
this pull request
Nov 22, 2024
…tion. The auth proxy added --min-sigterm-delay in GoogleCloudPlatform/cloud-sql-proxy#2266, This adds a matching configuration property to the operator's CRD.
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-proxy-operator
that referenced
this pull request
Nov 22, 2024
…tion. The auth proxy added --min-sigterm-delay in GoogleCloudPlatform/cloud-sql-proxy#2266, This adds a matching configuration property to the operator's CRD.
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-proxy-operator
that referenced
this pull request
Nov 22, 2024
…639) The auth proxy added the flag --min-sigterm-delay in GoogleCloudPlatform/cloud-sql-proxy#2266. This adds a matching configuration property to the operator's CRD. Fixes #627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the proxy continue to accept new connections for a period of time
after receiving the TERM signal.
Fixes #1640