Publish DEPS for 99.0.4844.27
Incrementing VERSION to 99.0.4844.27
Change-Id: I957d1ffd614270486183531b5bcb15778f7e84fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449153
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#370}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
M99: Add an entry for feed-pull-to-refresh IPH in In-Product Help Demo Mode
(cherry picked from commit 956d08ba5f15b13d749e415c64cfbd84b1351f08)
Bug: 1293462
Change-Id: I2f57848a766453162d2678d68b126c13d0b7c4ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433413
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967601}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446307
Auto-Submit: Jian Li <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#369}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[MERGE][VCN][RELAND] Add desktop iph bubble for virtual card option
-------- Revert-------
crrev.com/c/3320397
-------- Fix ---------
Previously I changed the widget of AutofillPopupBaseView to be a child
widget which was incorrect as only the top level widget would be able
to process events.
I did more exploration and found the root reason was that
WidgetDelegateView (parent of AutofillPopupBaseView) did not have a
widget which implemented the function GetThemeProvider. So calling
GetThemeProvider will always return nullptr.
The solution is to create a customized widget for AutofillPopupBaseView
and implement the GetThemeProvider.
I have tested to make sure that this time the AutofillPopupBaseView
will accept events and do autofill. PS2 is the original CL.
-------- Original CL description --------
The IPH will be shown at most three times in last 90 days,
and if the virtual card option has been selected by users at least
twice in the last 90 days it will not be shown either.
Mock: https://screenshot.googleplex.com/7yafJa5xSaE8fSZ
Screenshot: https://screenshot.googleplex.com/6jzKEm27hcRmAwX
(cherry picked from commit 9e4aba2c7e7b22d4931f9577bd7dd58dff1d43da)
Bug: 1293635
Change-Id: Ic9f146ebff5da3dac47000ce10a348709dc4f9ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3385497
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965354}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441458
Cr-Commit-Position: refs/branch-heads/4844@{#368}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.26
Change-Id: I6117e7ef67dc0f7054e816065bcd37570fa6d90e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449351
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#367}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[iOS] Stop NonModal Promo Coordinator with other browser coordinators
The nonModalPromoCoordinator should be stopped when the promo is
dismissed, but sometimes this link doesn't work. To prevent crashes,
stop the nonModalPromoCoordinator when the BrowserCoordinator is
shutting down just in case.
(cherry picked from commit fe1e0a3329b706c682a6dc4997a47da3089277ca)
Bug: 1241310
Change-Id: Ica4de8a9fde5cf2f590d5c0ff084aa81743a34c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433538
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966838}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448738
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#366}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Merge 99] Add FirstRun.Stage metrics to legacy FRE for A/B diffing
This covers the metrics that can be shared between the legacy FRE and
the new FRE, which are the following: kStart, kComplete,
kSyncScreenStart, kSyncScreenCompletionWithSync,
kSyncScreenCompletionWithoutSync.
----
Tested histograms for scenarios:
Each test gives the output of chrome://histograms/FirstRun.Stage
-
#1 Start => Welcome => Start Sync => Done
0 -o kStart
1 -o kComplete
2 -o kSyncScreenStart
3 -o kSyncScreenCompletionWithSync
4 o kSyncScreenCompletionWithoutSync
-
#2 Start => Welcome => Cancel Sync => Done
0 -o kStart
1 -o kComplete
2 -o kSyncScreenStart
3 o kSyncScreenCompletionWithSync
4 -o kSyncScreenCompletionWithoutSync
----
(cherry picked from commit 81eb20134fd1f9e0107f05a7fb6ae5bf54d83df3)
Bug: 1293792
Change-Id: Ie7d12559b5aa7f90a4a7f250d20d5cb2fb4ae671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441136
Auto-Submit: Vincent Boisselle <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967720}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448075
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#365}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
ios: Don't track empty tabs.
The realized/restored code path gracefully handles an invalid index
and nullptr item, but calls -TrackLocalNavigationId with an
uninitialized navigation entry. Instead, skip these tabs.
(cherry picked from commit d0a386b214d6d5b1822066093d9293a3d40ea4fb)
Bug: 1293880
Change-Id: Id46235938ea8f95d853a1593ab33a83952d80da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448069
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#968391}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448697
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#364}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Passwords] Report PasswordManager metrics for regular profiles only
[Merge to M99]
This CL makes sure that Password Store metrics are reported only for
regular user profiles (e.g. not for Incognito or System profiles)
In addition, metrics are now reported at most once per day.
The output of
python3 ./tools/metrics/histograms/print_histogram_names.py --diff origin/main
is in http://go/paste/6370328767889408
For context:
http://docs/document/d/1eC2jIeACjcNx0oxWg9xLMRJ2Z53TAZoMwI24-Q_68Rw?resourcekey=0-YJEfh-JUUi1cNX_IR3WmhA
(cherry picked from commit 30ca99c9e1d07c7b40b94a1db52423944bd37533)
Bug: 1259121
Change-Id: I25eff3091b0e36873ae3f85ee68d4d7a532d716a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423803
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966965}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447355
Reviewed-by: Ioana Pandele <[email protected]>
Reviewed-by: Maria Kazinova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#363}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Merge 99][ios][pandora2]Fix the contrast ratio of the sync info label
Grey600 gave a ratio below 4.5, using the secondary ratio gives a
sufficient ratio >= 4.5.
See http://shortn/_4pdXbcrJgK for more details.
(cherry picked from commit c84359a605c36d61bf3cc8ff6bc97d4560fcfd71)
Bug: 1294333
Change-Id: I5e03e6c0a36d4b96169c2eb82cb92981c38a8124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440876
Auto-Submit: Vincent Boisselle <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967712}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448735
Commit-Queue: Vincent Boisselle <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#362}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
M99: [unseasoned-pdf] Respect smooth scrolling setting.
Read Blink's IsScrollAnimatorEnabled() value when initializing the
plugin process, and send it to UI. The UI will then pass the appropriate
value when it calls window.scrollTo().
(cherry picked from commit 19a4e4bdbd87eb2d3895a70369f9307e4990ab0f)
Bug: 1291513
Change-Id: I0205e257af8092b3d927c3bad0a3b79844413236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435271
Reviewed-by: K. Moon <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967314}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448671
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#361}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644319307-4139165429e58c5d934c8ae67a31c87a9347ae64.profdata to chrome-win32-4844-1644342786-b1641773bf551481586d38061c6ae7d8259f513f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I1518e4ffab9d0e9fc64ab80a6f1e21f79d2e49c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448891
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#360}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[ios] Stop access ApplicationContext before creation
The ApplicationContext is created when the application enter the
InitStageBrowserObjectsForBackgroundHandlers (in MainController).
Before that point many Chrome objects are not available and cannot
be used.
When the OS decides to garbage collect "scenes" while the app is
not running, it sends -application:didDiscardSceneSessions: the
next time the application is started. This message is sent
before -sceneWillConnect: which means that the app may still not
be in InitStageBrowserObjectsForBackgroundHandlers (or above).
The ChromeIdentityService may not yet be accessible by that point
as it depends on the ApplicationContext being created. Since the
purpose of -application:didDiscardSceneSessions: is to allow the
application to clean up its state tied to those sessions, it is
fine if the deletion is delayed until the application has finished
correctly initialized.
Since observing the AppState's InitStage changing requires to be
an AppStateObserver, put the observation in MainApplicationDelegate
(observing AppState in AppState is an anti-pattern according to
a comment in AppState).
(cherry picked from commit 18154991c809c7e482d37ba5df0923a00941ee3a)
Fixed: 1292641
Change-Id: I75a378be3782d2da6c171dcfc926be3578382620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431645
Reviewed-by: Mark Cogan <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966660}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448072
Reviewed-by: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Auto-Submit: Harry Souders <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#359}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
ios: Unrealized WebState fixes to sync and commerce.
- Expose GetLastCommittedTimestamp for the commerce helper.
- Ignore IgnoreOverRealizationCheck for Preload controller.
- Always use session storage for sync.
(cherry picked from commit 50fe1e9548d9e891c5024aec36ed70368df634fa)
Fixed: 1293880
Change-Id: I70ed505fb0300a9361118f7d2eb13dbd2e12e5bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437576
Reviewed-by: Raj T <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967869}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448733
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#358}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll AFDO from 99.0.4840.0_rc-r1-merged to 99.0.4844.23_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia908e3d1bc7af7f2964b019a61b4c1d48a1f4f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448445
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#357}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Make missive client disconnectable.
DisconnectableClient is a wrapper on top of an abstract client which may
become available or unavailable at any moment. Calls made through the
client are rejected with error if the client is not available, and
cancelled immediately returning an error, if it becomes unavailable
while the call is in progress.
The wrapper is used for dBus connection to missive client in Chrome.
(cherry picked from commit 04b917579545768bc5b1f357f6b00ac0251c29bf)
(cherry picked from commit 235b8680ec74d8b28bec92ddff4608fdc160989a)
(cherry picked from commit 2a3c30b27a9a50de9cbe2bb82f3218818be77ffe)
Bug: b:205814822
Change-Id: Ia3883573ea7dea284b26c3c861bdd1f44ae37953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444549
Reviewed-by: Vignesh Shenvi <[email protected]>
Commit-Queue: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#356}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644319307-eee4acf3ddc7c815082ac1304fd97f1fad86d220.profdata to chrome-win64-4844-1644342786-5f4df51a1ca606bdc65a2088f22b78d6f98a44a6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Ia2174aaf7736cd1b2fca294ae6e687e021f5a0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448889
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#355}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4844-1644319307-558ac930ba5416802a5db54514e9fb9014efd0e1.profdata to chrome-linux-4844-1644342786-2e7896db481c85f948f0dbd40097df9171b1de42.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib429b52754b0ea3e4203b4b3372b7b703c631004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448893
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#354}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill] Record metric for missing shared-autofill.
(cherry picked from commit 7f5c539b79fb17cba4b9e9665ba0cf14395ac28a)
Bug: 1293495, 1275953
Change-Id: I5804d72eb5908e3430fb7dcd326bab0eeb79926e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432230
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439973
Reviewed-by: Matthias Körber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#353}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99][infra] Change the file extension of the properties file.
The properties file was being written out with the .textpb extension,
but it contains JSON and the bootstrapper expects JSON. This change
modifies it so that the file will be written out with a .json extension
instead and the bootstrap properties updated to read it from that
location.
To prevent infra failures due to the old files not existing before
buildbucket picks up the new property values, the .textpb file is also
still being written out with the same content. A later change will stop
the .textpb files from being generated.
(cherry picked from commit 9b85e6662c766b9ac7b97126f496a0cf7d89e663)
Bug: 1210566
Change-Id: I526efb3c3a2ee2919523058eb3c97489550f7c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447313
Auto-Submit: Garrett Beaty <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#968447}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448675
Cr-Commit-Position: refs/branch-heads/4844@{#352}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644319307-c8e7435e9cd89468bf3a2002760398dff973eb6b.profdata to chrome-mac-4844-1644342786-fdfde9ead82fd14a9a31b19c61fab09fc604ce81.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Idc63b32cc8b72571a8e95a6b8df2bf6cac86d34b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448448
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#351}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll ChromeOS Atom AFDO profile from 99-4815.0-1642417637-benchmark-99.0.4840.0-r1 to 99-4827.0-1643629123-benchmark-99.0.4844.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I6c2a272d9f74b21b383b95ff5bef159b74535190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448634
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#350}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll ChromeOS Bigcore AFDO profile from 99-4815.0-1642415760-benchmark-99.0.4838.0-r1 to 99-4827.0-1643628001-benchmark-99.0.4844.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I6490b20948fb3dccee8fcc71ffb4acb986f5e7ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448442
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#349}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Extend Grid and Group M5 and no auto group flag to M101
(cherry picked from commit 2543d7a734c34e757eff6e88b457b2a1f0a23708)
Change-Id: Ie53ff55dc7ccd0d6e691b49a3c82207fa790b477
Bug: 1294864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441389
Auto-Submit: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Wei-Yin Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967910}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444545
Reviewed-by: Mei Liang <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#348}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Cherry pick - Make Screenshot flow scrim responsive to the frame size change.
(cherry picked from commit 1d161f9d8a02505cdb40a260c8a37532793262e0)
Change-Id: I07ceb29cfa681fcd04afea0dd55f9eaa10b8c770
Bug: b/215555828
Bug: 1290365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428544
Reviewed-by: Travis Skare <[email protected]>
Commit-Queue: Yu Su <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966402}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448629
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#347}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Start] Fix the toolbar gone issue.
(cherry picked from commit e9a297f6cb9d8a58f26b039f09ee35feddd81f01)
Bug: 1293879
Change-Id: I94357857e1c3de3cf7f66c00142d90a06bbea32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437069
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967008}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442179
Cr-Commit-Position: refs/branch-heads/4844@{#346}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[PartitionAlloc] Implement malloc_zone_batch_{malloc,free}()
On macOS, there are optional batched (de)allocation functions, which
PartitionAlloc (and the shim layer) currently don't implement.
It turns out that these are *not* optional, as whenever
malloc_zone_batch_malloc(malloc_default_zone(), ...) is called, the
malloc_default_zone() zone will delegate to the current default zone,
and ends up calling a nullptr (through a tail call).
This shows up in crash reports on macOS 10.14, with allocations coming
from CoreData. Though we don't have access to CoreData's source code,
from crash reports this seems to be the root cause, and the
non-regression test added does indeed crash without the rest of this
patch.
For more details, see linked bug.
(cherry picked from commit d794f4018716c8a74c6b7f8837bbad37f2c7c5e6)
Bug: 1294219
Change-Id: I19de7002c755a43660402d4b407f28cb774fbadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440210
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967345}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447351
Reviewed-by: Egor Pasko <[email protected]>
Owners-Override: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#345}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644292851-b7041e0787d705ade3017d7639c9945eb6fa1276.profdata to chrome-win32-4844-1644319307-4139165429e58c5d934c8ae67a31c87a9347ae64.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ibf2976ab2db8ab7c901e7ce16212733b110ac87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446494
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#344}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644292851-dfe37c63d71525b8bcafa241027463e62a23681b.profdata to chrome-win64-4844-1644319307-eee4acf3ddc7c815082ac1304fd97f1fad86d220.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I10b12526795fd123b26f0afe3f7ccfd1fea24d7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446493
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#343}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644292851-306cde3a6891b4b1a0bbd9b47f86ff78c6c8edef.profdata to chrome-mac-4844-1644319307-c8e7435e9cd89468bf3a2002760398dff973eb6b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I99bc8c2ecfaf3cc4e6df14909bee77ddc83bf4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446492
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#342}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: Ief09d601275858305b9bf6b5f1df9bf280fdd228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447525
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#341}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4844-1644292851-b5118eeb96f1dffae04a8d67834464de1a1cd1ab.profdata to chrome-linux-4844-1644319307-558ac930ba5416802a5db54514e9fb9014efd0e1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: Ifa3d888efbd51298084d7fab4dcb91f9957fd9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445218
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#340}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Private Network Access] Merge: Fix handling of redirects after preflights.
(cherry picked from commit ec89b4e24357842649c67a36231e7320d720948d)
Fixed: chromium:1293891
Change-Id: Ibd11ee72df9d85356d1e788e2f8b4bb70317619f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439752
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Auto-Submit: Titouan Rigoudy <[email protected]>
Commit-Queue: Titouan Rigoudy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967386}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445761
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#339}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill Assistant] Fix UMA for onboarding fetcher.
(Cherry-pick)
The name was missing the Android. prefix. Moved to our other metrics,
such that subsequent refactorings will properly adjust all of our
metrics, not just some of them.
Bug: 1293365
b/209561294
(cherry picked from commit ca8ce081f966fc1532606583c82d197f3136c16b)
Change-Id: I8d850f6a8aa9e5f66d2831288584600014272918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427513
Commit-Queue: Clemens Arbesser <[email protected]>
Auto-Submit: Clemens Arbesser <[email protected]>
Reviewed-by: Sandro Maggi <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965652}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447344
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#338}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Allow ResumeDataPipeReading to proceed if it not interrupted with any
resume reason.
This addresses the problem of websocket being stuck if message is being
sent async over the channel, when OnSendDataFrameDone callback is effectively invoking OnReadable which uses kMojoPipe as a resume reason although the websocket is not interrupted.
(cherry picked from commit 997ead87ee6ef44d043b65baf64a3a18abc4a11a)
Bug: 1286909
Change-Id: I5695dbf9f0f07aee45a330e2eda0070f01bceda5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3404081
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#961746}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445541
Cr-Commit-Position: refs/branch-heads/4844@{#337}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Lookalike Urls] Measure latency of throttle's PerformChecks()
While analyzing traces via Chrometto, I found a trace where
LookalikeUrlService::OnUpdateEngagedSitesComplete() took 37 ms, with 23
ms of that coming from a call to GetDomainInfo(). One of the callsites
of LookalikeUrlService::ForceUpdateEngagedSites() that calls
GetDomainInfo() from within its callback is
LookalikeUrlNavigationThrottle::WillProcessResponse(). Specifically,
the call to GetDomainInfo() occurs from within
LookalikeUrlNavigationThrottle::PerformChecks() via
LookalikeUrlNavigationThrottle::IsLookalikeUrl().
As this call blocks navigation commit, this CL adds a histogram
measuring the latency of PerformChecks() on navigations that it directly
allows to proceed. We are not as interested in navigations that result
in interstitials being shown, as those navigations will be cancelled by
the throttle. Note that while we could track this for navigations that
are ultimately allowed to proceeded after a manifest check, doing so
would add code complexity and that feature is currently disabled by
default.
This CL also adds finer-granularity metrics to aid in determining where
to optimize in the case that optimization is needed. Similarly to the
above, these are restricted to navigations that PerformChecks() allows
to proceed.
- A metric that tracks the time that PerformChecks() spends in
invocations to IsLookalikeUrl().
- A metric that tracks the time that PerformChecks() spends in
invocations to GetDomainInfo() via IsLookalikeUrl().
(cherry picked from commit ef060844a7304c0bad4f5a3c8ad2465c6452f664)
Bug: 1292022
Change-Id: Ifee48bfad02e7b1149a04b3530abd97c453d4a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427022
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Joe DeBlasio <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966105}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442956
Cr-Commit-Position: refs/branch-heads/4844@{#336}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644273225-66380764e4d2a5db7a2f8298eb46c414a21fa378.profdata to chrome-win32-4844-1644292851-b7041e0787d705ade3017d7639c9945eb6fa1276.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ic0a7d795790e326914ba63b2438517b860457a33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446347
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#335}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644273225-b181580b2dd0c09ebe59d9147583b27e951aa860.profdata to chrome-win64-4844-1644292851-dfe37c63d71525b8bcafa241027463e62a23681b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I86be347733154a72b800b1d718eb8d6981cb09b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446344
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#334}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644273225-4a04063a2ceb4497f5b601c4fa8b92123ad2a2da.profdata to chrome-mac-4844-1644292851-306cde3a6891b4b1a0bbd9b47f86ff78c6c8edef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib95eec60e3b5a1ce695386dc21c9ce933398e941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446486
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#333}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4844-1644273225-962ae3a0cc01d5cb9295cde03c05bec53f039f10.profdata to chrome-linux-4844-1644292851-b5118eeb96f1dffae04a8d67834464de1a1cd1ab.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: Ied534ba8281423793a2d823b4a8c1bb238089027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446960
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#332}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.25
Change-Id: I6de3510d0f3fdf837591c1e6c28399c52cda73c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446083
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#331}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[iOS] Add feed header to view hierarchy fix
(cherry picked from commit ce64bac0073dc02a5579ed462d27d7ac2173e3ba)
Bug: 1293274
Change-Id: I512e127744941a8b3f09f6f8c43d2b10c6e5c8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440794
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445682
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#330}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644255955-390742af2a10ef75ce5bcee9807c6b21c2d61545.profdata to chrome-win32-4844-1644273225-66380764e4d2a5db7a2f8298eb46c414a21fa378.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I4cbda48d41fb76b5fe7bdbda0686d8244ad659ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445094
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#329}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644221955-eaaf4f7d997a3af095abeab8577939d70920b227.profdata to chrome-win64-4844-1644273225-b181580b2dd0c09ebe59d9147583b27e951aa860.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Ibb054280fe36068445c4b3e5e60213586d487a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445324
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#328}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Use scroll offset instead of scroll position for touch event coordinates
https://crrev.com/942942 had a mistake in ContentsOffset in
third_party/blink/renderer/core/input/touch.cc where GetScrollOffset
was incorrectly changed to ScrollPosition, resulting in incorrect
client{X,Y} values for touch events. For more information about the
difference between scroll offset and scroll position, see:
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/blink/renderer/core/layout/README.md#scroll-origin-vs_offset-vs_position
(cherry picked from commit 9dc39d361d0fa665955e7a626a9e52c6a8db279e)
Bug: 1292815
Change-Id: I8ecbfc18a2bb579d07bb1022e2b92059be9d1911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438125
Reviewed-by: Stefan Zager <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966905}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445088
Auto-Submit: Philip Rogers <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#327}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Ensure that DOMArrayBuffer `data_` hasn't been neutered.
Since Javascript may detach the underlying buffer, we need to check
to ensure they're still valid before using them.
(cherry picked from commit 7f575ab43a8ac1d9a98feb9e4261e5f22265bdb9)
Bug: 1293428
Change-Id: Iad38a90414685bbe378b2f55b6f1d0ffbee99b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436787
Reviewed-by: Piotr Bialecki <[email protected]>
Commit-Queue: Piotr Bialecki <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966981}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445403
Auto-Submit: Piotr Bialecki <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#326}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
M99: [unseasoned-pdf] Fix vertical scroll distance.
The scroll distance for page up, page down, scroll, and shift+scroll
should match the behavior of web content and the PPAPI PDF Viewer.
(cherry picked from commit 7b4e9b50122a1e7c2e053a34ece1536ceda0d329)
Bug: 1291940
Change-Id: Id156a95326d04e405eac5a3a5687f87fd4f14645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3424813
Reviewed-by: Hui Yingst <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965745}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444400
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Lei Zhang <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#325}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644255955-7a3e4f6ad8e381621b1a255044fa857925bf68df.profdata to chrome-mac-4844-1644273225-4a04063a2ceb4497f5b601c4fa8b92123ad2a2da.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I00981a509abb0354738d47a49be0cb9d629caded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445485
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#324}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4844-1644255955-4c04355acbf73e7508b90b3db18b2bc4f8778ca0.profdata to chrome-linux-4844-1644273225-962ae3a0cc01d5cb9295cde03c05bec53f039f10.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: If4ff0b0b2779ca2ec8e2ba7044920a42ee1f5679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445125
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#323}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.24
Change-Id: I0b3927d96c771fefbea400ceb553ee985309d1b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446263
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#322}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99] gpu: Minimum fixes for webview vulkan binding
WebView uses vulkan bindings from two different threads, with two
vkInstances and two vkDevices. Currently VulkanFunctionPointers
assumes it's used from one thread and vkInstance/vkDevice are
effectively global.
Properly fixing this requires extensive changes. This is the minimum
changes to avoid crashes. Note the CL is also kept small to allow
merging.
Correctness depends on the function addresses do not depend on the
particular vkInstance or vkDevice.
Add lock to various VulkanFunctionPointers::Bind* functions so they are
thread safe. Also update the points where webview accesses the
vulkan_loader_library pointer to be thread safe as well.
Update webview's BindUnassociatedFunctionPointers to ensure it checks
for vkGetInstanceProcAddr pointer being null, rather than the library
not being loaded yet.
Update VulkanInstance to not unload the library on destroy if initialize
is never called (ie on webview render thread).
(cherry picked from commit e5a8b573a6274165cd660d6d1b613a5ecb80a5fc)
Bug: 1293005
Change-Id: I386ae0deca3bd764d1cf6b397dbf863b99f8ac36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432632
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966326}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442437
Cr-Commit-Position: refs/branch-heads/4844@{#321}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
M99: Feed ghost cards: only add padding for Instant Start
The placeholder was originally made for Instant Start, and it needed to set its padding using ViewResizer to have a similar width to the feed. When using FeedPlaceholderLayout within the feed as the loading indicator, we shouldn't add padding because the placeholder already has the same width as its parent, the RecyclerView.
ViewResizer adds more padding on wide screens, making the "double padding" effect more noticeable or even reducing FeedPlacholderLayout's width to nothing.
Also, update the flag expiration milestone as it is still needed.
(cherry picked from commit 6c3d09ff77ff9a0cbdacba312bbe316315b49c57)
Bug: 1286146
Change-Id: I57d3e4374a2a20741d6319cb2b1d6348a2177d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430482
Reviewed-by: Jian Li <[email protected]>
Commit-Queue: Ian Wells <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966449}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433986
Auto-Submit: Ian Wells <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#320}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: I11a9fe8ba55fc6639cdf468b355ece03cd48b4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3446121
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#319}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Fix NavigationEarlyHintsManager::PreloadURLLoaderClient
After crrev.com/c/3410912 OnReceiveResponse() could pass `body`.
When `body` is passed and the loader fetched the response from the
network `body` should be drained.
(cherry picked from commit 50beef1b3e1d2b44ff7b5a4346b798c870a1aa28)
Bug: 1293677
Change-Id: I0ab8ea8c0b6ad20172a102d524bf7ed5a133f107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439230
Reviewed-by: Yutaka Hirano <[email protected]>
Auto-Submit: Kenichi Ishibashi <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967293}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443122
Auto-Submit: John Abd-El-Malek <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#318}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[ios, kSingleNtp] Log IOS.NTP.Impression in displayWebState:
[ContentSuggestionsCoordinator start] no longer executes every time
the NTP is shown in kSingleNtp since NTP classes are shared across
WebStates if possible.
(cherry picked from commit c4065a0605d5965851bfd1a9fdf03fde71c45230)
Bug: 1292161
Change-Id: I0ffe697be75c2fce667ca785ae40dc50fe755300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425517
Reviewed-by: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966244}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444145
Auto-Submit: Chris Lu <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#317}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644221955-14c706fc6a966757c38a146fc3b85e8aaff5e7df.profdata to chrome-win32-4844-1644255955-390742af2a10ef75ce5bcee9807c6b21c2d61545.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I31ca0121f3e394415c6ca34100a7c137cdd3a72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442549
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#316}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4844-1643216352-97a620e3689ad97f751f72a37aab485a59352233.profdata to chrome-linux-4844-1644255955-4c04355acbf73e7508b90b3db18b2bc4f8778ca0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: I1a52a48f40daddf14d297b2ac8edcf74f5614f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443303
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#315}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[base/allocator] Export aligned_alloc() on Linux
aligned_alloc() is "new" in C11, and its support in the allocator shim
was added to support VMA (Vulkan Memory Allocator) in
https://crrev.com/2392230. However this CL didn't add it to Chrome's
symbol map file, so aligned_alloc() was never actually exported.
This is causing issues as both VMA and TFLite use aligned_alloc(), and
end up on Linux to use glibc's malloc() for the allocation, but
PartitionAlloc's free() to deallocate. This comes from the fact that the
calls are made from dynamic libraries, not the main binary.
An additional layer of surprise is that this is working with glibc up to
2.33, but failing on 2.34. It is not entirely clear what caused this
change, but it's interesting to note that Chrome is exporting a global,
non-weak symbol for __libc_memalign() in its map, which is the internal
name for aligned_alloc(). So it is possible that the pre-2.34 behavior
was a happy accident.
(cherry picked from commit 16cfb89fcf0dd645413c4b5a5f4c520702a4042f)
Bug: 1292206
Change-Id: Ib02f849f1b06eac18c51b93bcc9bccab74db0997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431103
Reviewed-by: Egor Pasko <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966308}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443506
Reviewed-by: Thiabaud Engelbrecht <[email protected]>
Owners-Override: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#314}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99 Cherrypick] Respect ForceMajorToMinor in User-Agent utils metadata.
This change fixes an inconsistency in how --force-major-version-to-minor
and its associated enterprise policy are applied within user_agent_utils.
This change also introduces a new UserAgentOptions struct that will be
more widely adopted as part of follow-up crbug.com/1291612. The scope
of this change is minimized as it must be cherrypicked into M99.
(cherry picked from commit 6d570ea6860400c5b2d06e2ea2c3216aa1bef568)
Fixes: 1290902
Change-Id: I3ce2b27cb8ca389611b0a0c5bcbaad0b46397248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441653
Reviewed-by: Ali Beyad <[email protected]>
Commit-Queue: Nathan Eliason <[email protected]>
Auto-Submit: Nathan Eliason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#313}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99] viz: Add render pass for secondary cb readback
Vulkan Android WebView cannot support any features that requires reading
back the pixels of the framebuffer which is required by some filters. In
this case, lift the rendering scene into an offscreen buffer instead.
This is done in SurfaceAggregator which already has some code to append
render passes under some conditions. Note code is written so that
SkiaOutputDeviceVulkanSecondaryCBOffscreen can be merged into this
implementation in a subsequent CL.
(cherry picked from commit 89fc4f3e2b08d0713740391ada71f175081c6b98)
Bug: 1266409
Change-Id: I9cebe2869aa03e335ea3669a79d115a0e7380bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425222
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965932}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444300
Cr-Commit-Position: refs/branch-heads/4844@{#312}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644221955-cdfdbf228af7d24ac5457f9b7cba9e0461a3699a.profdata to chrome-mac-4844-1644255955-7a3e4f6ad8e381621b1a255044fa857925bf68df.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I4105d80791a51b8fc3fef4a421e71eda59559283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443145
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#311}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Handle nullopt request_initiator_origin
This CL fixes a crash report at
RegisterNonNetworkSubresourceURLLoaderFactories, by dereferencing
request_initiator_origin only when it is not nullopt.
(cherry picked from commit f5360b456a7dc9725d53eff3f59514725f2c895b)
Bug: 1287104
Change-Id: Ib21b2f35604f85f00802a21c577d39b8a71d5668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413438
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Ghazale Hosseinabadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966040}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443022
Auto-Submit: Ghazale Hosseinabadi <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#310}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[PCAS] Add model latency without threading delays for PageEntities.
This adds metrics for the PageEntities model without including any
threading delays (scheduling or hops).
(cherry picked from commit 1995ade60fe8bbca28250b1a3e257d150d5b12b7)
Bug: 1294311
Change-Id: I34986a8296f92a16b47f8fa49041168ffe1b7a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441178
Reviewed-by: Sophie Chang <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967493}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440551
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#309}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] weblayer: makes Browser.isRestoringPreviousState() handle minimal restore
Prior to this isRestoringPreviousState() only handled the case
of async persistence. This makes isRestoringPreviousState()
indicate if minimal restore is in progress as well. In the case
of minimal restore isRestoringPreviousState() will return true
from the time the fragment is created until the state is processed
(start).
BUG=1293152
TEST=covered by tests
(cherry picked from commit 665edc9b3a4a6111d19de3aebab224a662a74306)
Change-Id: I73aea2a3954473502224bb313fa1f4373c1d9767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428554
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966455}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443142
Auto-Submit: Scott Violet <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#308}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Private Network Access] Merge: Web Platform Tests for redirects.
(cherry picked from commit e4976b81d8b5e9805357e053097fec4fb4f9d644)
Bug: chromium:1293891
Change-Id: Ia22fe59ff99246db94cbbab99192597e716692d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439867
Auto-Submit: Titouan Rigoudy <[email protected]>
Reviewed-by: Arthur Hemery <[email protected]>
Commit-Queue: Titouan Rigoudy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967321}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440214
Cr-Commit-Position: refs/branch-heads/4844@{#307}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99] viz: Refactor append root pass
Factor out common code to append a root render pass in
SurfaceAggregator. There is no behavior change intended in this CL. This
is in preparation for the follow up which adds a 3rd condition to append
a root pass.
(cherry picked from commit a202f320dbb78611fb4b3c098fb4c25e8c8304ee)
Bug: 1266409
Change-Id: I54968aaee9c09c1077d6c779225bddc444b4fd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415565
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Bo Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965806}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442737
Cr-Commit-Position: refs/branch-heads/4844@{#306}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Unregister Accelerators when AccessiblePaneView is destroyed.
This CL makes sure that a focus change listener and all Accelerators are
unregistered when the AccessiblePaneView is going to be destroyed.
(cherry picked from commit 7125ad12cdfd41bce01723aa4769b853e655d8de)
Bug: 1284293
Change-Id: Icd11523be7ab5728e181148a8fd1baec5349513e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429899
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Illia Klimov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440398
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#305}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Private Network Access] Merge: Test redirects after preflights.
The change includes eagerly initializing test servers instead of lazily.
This allows the network process to see the same command-line switch as
the browser process, categorizing `b.test` in the `private` IP address
space correctly.
This exercises the bug, where the network service observes a different
IP address space during the preflight and after the redirect.
(cherry picked from commit e3b7ee5c549f348f384ac896e88e8345ddf1641a)
Bug: chromium:1293891
Change-Id: I806fa856ef1cf2f1b2cf0ce8d418eefa9ed20893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440006
Auto-Submit: Titouan Rigoudy <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#967181}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443384
Commit-Queue: Titouan Rigoudy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#304}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill] Require shared-autofill in main frames for cross-origin fill.
AutofillAcrossIframes supports two directions of cross-origin filling:
- When triggered on a non-main-origin field, main-origin fields may be
filled if they are non-sensitive.
- When triggered on a main-origin field, non-main-origin fields may be
filled if their frame has the "shared-autofill" feature enabled.
This CL strengthens the first condition in the following way:
- When triggered on a non-main-origin field, main-origin fields may be
filled if
- their frame has the "shared-autofill" feature and
- they are are non-sensitive.
With this change, "shared-autofill" is a necessary condition for
cross-origin filling.
By default, "shared-autofill" is enabled in the main frame, its
same-origin children, their same-origin children, etc.
(cherry picked from commit 125feb4a02d00c2285031d6794aaafb43fed73cb)
Bug: 1293379, 1187842
Change-Id: Ib8def16330c7a169cb7c89a9e96f3e69151b2472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432125
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966395}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440216
Auto-Submit: Christoph Schwering <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#303}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Start] Reset StartSurfaceUserData in onPause().
The crash may happen when the |mUnusedTabRestoredAtStartup| is still
true while another Tab is created by Custom Tab. As a result, the Tab
isn't reload, and ends up with an empty View. In this CL, we reset the
data if Chrome goes to the background without hiding the Start surface.
(cherry picked from commit 26d52487fea25d90b3678fe6f98e46737b55a0ef)
Bug: 1287950
Change-Id: Ia5505dde32e27d8568a5b8d8c261c8bc390166ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421149
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964134}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437116
Cr-Commit-Position: refs/branch-heads/4844@{#302}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99][Paint Preview] ANR fix by reducing IO work at startup
Seeing some ANRs for File#list when building pre-native cache. Instead
let's just check whether the file we want exists on demand.
Removing the check isn't feasible otherwise we will try to show a paint
preview that isn't available leading to excess work.
Also improve audit so that it runs more aggressively at startup to avoid
any edgecases where multiple previews are kept.
(cherry picked from commit c429c34e547912c6e613395ec4373a2d5a789417)
Bug: 1293447
Change-Id: I1c9408433982146d5bffdf5a0309b5c847644403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432605
Reviewed-by: Yashar Dabiran <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966340}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441092
Auto-Submit: Calder Kitagawa <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#301}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I1d84ee5dd8f36c0a0e243ee26c6cdb42649cda65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441036
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#300}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Fix Incognito Revamp NTP string in iOS.
This CL fixes the bug that shows extra <ul> tag on Incognito NTP
description.
(cherry picked from commit 4c08bf9c504593da5492b5bf24776e292743fad8)
Bug: 1293189
Change-Id: Ifc437f8bec946e98925313bc6a5908f30b3245ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436545
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Side YILMAZ <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966747}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439878
Cr-Commit-Position: refs/branch-heads/4844@{#299}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644200817-f4d995dd9ad0cb4210fa7f18ca931271069daf31.profdata to chrome-win32-4844-1644221955-14c706fc6a966757c38a146fc3b85e8aaff5e7df.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ibeb01d86b052af4292064abd88ff6ba0f21b393e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443209
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#298}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644182164-7b1cd08f32c9a1590b22c76e47e6f6a8664fb74a.profdata to chrome-win64-4844-1644221955-eaaf4f7d997a3af095abeab8577939d70920b227.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Iafe1b28b1b11707df63782ea19986aae9075bf5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442367
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#297}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644200817-8bb4a8fe6dcffd66240630d8dc448cc7b7038034.profdata to chrome-mac-4844-1644221955-cdfdbf228af7d24ac5457f9b7cba9e0461a3699a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ica94811a7fce6372089ccf8d7b53ffc35b2e5739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442368
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#296}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644182164-b8a55a20d62ab8e71d16821e2f99f5f1b9d7eedc.profdata to chrome-win32-4844-1644200817-f4d995dd9ad0cb4210fa7f18ca931271069daf31.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I3df8404f031b0caad3228d4ed82ebbdd8feb92f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443115
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#295}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644182164-de293b4801cae34031b22a85d36a778f71c7f850.profdata to chrome-mac-4844-1644200817-8bb4a8fe6dcffd66240630d8dc448cc7b7038034.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I7be2f426ff1d7d819f00616ddd462cf251e4ac71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441647
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#294}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644157454-ab55187c7fa51bcd885323fe473910f85b12c93c.profdata to chrome-mac-4844-1644182164-de293b4801cae34031b22a85d36a778f71c7f850.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ideb93321a8062cb474d90e491bbdd1eec4b90748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442622
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#293}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644157454-938281f6a6cfc224929b0497bb1d0b5ec71b9675.profdata to chrome-win32-4844-1644182164-b8a55a20d62ab8e71d16821e2f99f5f1b9d7eedc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Id54a279c73d10b00d079fffb1f2a00c7b144c9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441644
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#292}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644157454-cacb9a334466eae4fa1c39b887a094b56a6e9003.profdata to chrome-win64-4844-1644182164-7b1cd08f32c9a1590b22c76e47e6f6a8664fb74a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I34aae21928749aa9f67da2893a72d7bf6e2af219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442720
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#291}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.23
Change-Id: I5f27fd23841402f85c93500ddb2b99b01ce72e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442516
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#290}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644135184-7bba6745db1f13cd4e9641e32d316a64991ca04f.profdata to chrome-win32-4844-1644157454-938281f6a6cfc224929b0497bb1d0b5ec71b9675.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I338f51ce3f173e0708fce0afde14ebaf06cbc1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442794
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#289}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644135184-c193dcc5d0fe24437c07c3ab6c56f00c166988b1.profdata to chrome-win64-4844-1644157454-cacb9a334466eae4fa1c39b887a094b56a6e9003.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I5bdac08d377862aac41ca1f31aa4dc861a0bccb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439203
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#288}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644135184-8a84568661b6add6c0e45e70f91f2fd9640d5bb1.profdata to chrome-mac-4844-1644157454-ab55187c7fa51bcd885323fe473910f85b12c93c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I0e2eb631d0d0b88cfe79b76c3759ea8fbb7f164b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439197
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#287}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644113234-becb5d4aa413dfcba9998730f0b427c66b477bb3.profdata to chrome-mac-4844-1644135184-8a84568661b6add6c0e45e70f91f2fd9640d5bb1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I86390a64b58ec57263621926a73c012329399b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441670
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#286}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644113234-cfdbdd51ea1c3091b3923144ef617f2e6d81fb33.profdata to chrome-win32-4844-1644135184-7bba6745db1f13cd4e9641e32d316a64991ca04f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I715d5df111fb64e525fc047b5522810544583fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442132
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#285}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I716644a7c21ae44ee9747613aee5d7cb0468686a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441479
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#284}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644113234-e6d8d3cb2570a2d82b58c3d68c6e8e1175ad392b.profdata to chrome-win64-4844-1644135184-c193dcc5d0fe24437c07c3ab6c56f00c166988b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Ie69228113acc7054f92feeafb31e422b84d36d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441669
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#283}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644104794-94b3bf99b0fc16a1e2a60ad875f4a3f51f86a980.profdata to chrome-mac-4844-1644113234-becb5d4aa413dfcba9998730f0b427c66b477bb3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I392c24b4c18c0f2a23b4beedf38510294a7e3ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439003
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#282}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644104794-1237d3a2270a4775949d5152e1ac55833dc93d94.profdata to chrome-win32-4844-1644113234-cfdbdd51ea1c3091b3923144ef617f2e6d81fb33.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ib13c6aafc73c237c79119c93f3b189cce647ee66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439004
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#281}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644104794-935313abe29f659bbe980d599e75f5e81c3b0e2b.profdata to chrome-win64-4844-1644113234-e6d8d3cb2570a2d82b58c3d68c6e8e1175ad392b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I3586b13ce9420d864cc676dae0bd9f723341c1f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441655
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#280}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644049533-b17ce27bf24457ffde7ae3fd0530cec2f8759383.profdata to chrome-win64-4844-1644104794-935313abe29f659bbe980d599e75f5e81c3b0e2b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I3752ea0fcbd357a5dcd57d57fc1bc89ac5c31d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442143
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#279}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644077994-7a74d6654158ad35fc113c7314e13ab5e37d8d42.profdata to chrome-win32-4844-1644104794-1237d3a2270a4775949d5152e1ac55833dc93d94.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ibbab3b20a4190eb67c6cfaf551113c04d7283e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441900
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#278}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644077994-313950d33d2ec08d46de7d6f5532ab4829f653b7.profdata to chrome-mac-4844-1644104794-94b3bf99b0fc16a1e2a60ad875f4a3f51f86a980.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ia0aa713b91568dd9236d76590f15241a3aa96fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440687
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#277}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.22
Change-Id: I4d27fe049facd4dfb8ee2b34b55e6585e06b1c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441837
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#276}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Un-expire web feeds related feature flags
(cherry picked from commit d563f80c3f8b1d5017c4e49a7d3ee5fa9e6e2586)
Bug: 1292667
Change-Id: I65c071467cf2743e02b0b3339c5b371d94eb6464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427316
Commit-Queue: Carlos Knippschild <[email protected]>
Auto-Submit: Carlos Knippschild <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Commit-Queue: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965357}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430379
Reviewed-by: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#275}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644049533-cc14f464d3a8a5181ee1b64297820bb052c4707a.profdata to chrome-win32-4844-1644077994-7a74d6654158ad35fc113c7314e13ab5e37d8d42.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Icec77cc402790fb401d1d4f5bc6e0b1a9c477346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442166
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#274}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644049533-8f779b9ce1fc0bf917993ce11beb684840a50fa4.profdata to chrome-mac-4844-1644077994-313950d33d2ec08d46de7d6f5532ab4829f653b7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I72b78bbb108e87da7c10cf1350e8b7d92837ff08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441947
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#273}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll libxml from dea91c97 to eab86522
2022-01-31 [email protected] Make xmllint return an error if arguments
are missing
2022-01-28 [email protected] Avoid potential integer overflow in
xmlstring.c
2021-07-07 [email protected] xmlAddChild() and xmlAddNextSibling() may
not attach their second argument
2022-01-25 [email protected] Run CI tests with UBSan
implicit-conversion checks
2022-01-25 [email protected] Fix casting of line numbers in SAX2.c
2022-01-25 [email protected] Fix integer conversion warnings in hash.c
2022-01-25 [email protected] Add explicit casts in runtest.c
2022-01-25 [email protected] Fix integer conversion warning in
xmlIconvWrapper
2022-01-25 [email protected] Add suffix to unsigned constant in
xmlmemory.c
2022-01-25 [email protected] Add explicit casts in testchar.c
2022-01-25 [email protected] Fix integer conversion warnings in
xmlstring.c
2022-01-25 [email protected] Add explicit cast in xmlURIUnescapeString
2022-01-25 [email protected] Fix handling of ctxt->base in
xmlXPtrEvalXPtrPart
2022-01-20 [email protected] Remove wrong tarname from AC_INIT
2022-01-17 [email protected] Remove old devhelp format
2022-01-16 [email protected] Fix regression with PEs in external DTD
2022-01-16 [email protected] Fix xmllint --maxmem
2021-11-03 [email protected] Fix
Null-deref-in-xmlSchemaGetComponentTargetNs
2022-01-16 [email protected] Fix libxml2.doap
2021-08-26 [email protected] Added regression tests for
xmlReadFd() and htmlReadFd()
2021-07-27 [email protected] Fix htmlReadFd, which was using a
mix of xml and html context functions
2022-01-16 [email protected] Fix memory leak in xmlXPathCompNodeTest
2021-07-22 [email protected] setup.py.in: Try to import
setuptools
2021-07-22 [email protected] Python distutils: Make DLL packaging
more flexible
2021-07-22 [email protected] tstmem.py: Try importing from
libxmlmods.libxml2mod if needed
2021-03-30 [email protected] python: Port python 3.x module to
Windows
2021-11-03 [email protected] Fix random dropping of characters on
dumping ASCII encoded XML
2021-10-14 [email protected] Update URL for libxml++ C++ binding
2022-01-16 [email protected] Fix null pointer deref in
xmlStringGetNodeList
2021-08-06 [email protected] move current position before possible
calling of ctxt->sax->characters.
2021-07-29 [email protected] Correctly install the HTML examples into
their subdirectory.
2021-07-29 [email protected] Refactor the settings of $docdir
2021-07-26 [email protected] configure: remove unused checks for
functions
2021-07-26 [email protected] configure: remove unused checks for
libraries
2021-07-26 [email protected] cmake: remove unused checks
2021-07-26 [email protected] configure: remove unused checks for
headers
2021-07-26 [email protected] cmake: fix `ATTRIBUTE_DESTRUCTOR`
definition
2021-07-23 [email protected] Generate devhelp2 index file
2021-07-14 [email protected] Remove duplicated code in xmlcatalog
2021-07-14 [email protected] Fix leak in
__xmlOutputBufferCreateFilename
2021-07-14 [email protected] Fix memory leak in
xmlRelaxNGNewDocParserCtxt
2021-07-14 [email protected] Fix memory leak in
xmlRelaxNGParseData
2021-07-14 [email protected] Fix memory leak in
libxml_C14NDocSaveTo
2021-07-14 [email protected] Fix memory leak in libxml_saveNodeTo
2021-07-14 [email protected] Fix memory leak in
xmlNewInputFromFile
2021-07-14 [email protected] Fix memory leak in
xmlCreateIOParserCtxt
2021-07-14 [email protected] Fix memory leak in
xmlParseSGMLCatalog
2021-07-14 [email protected] Fix memory leak in
xmlParseCatalogFile
2021-07-14 [email protected] Fix memory leak in
xmlSAX2AttributeDecl
2021-07-14 [email protected] Fix memory leak in
xmlFreeParserInputBuffer
2021-07-07 [email protected] Fix parse failure when 4-byte character in
UTF-16 BE is split across a chunk
2021-07-05 [email protected] man: Mention XML_CATALOG_FILES is
space-separated
2021-07-05 [email protected] add documentaiton for xmllint exit
code 10
2021-06-28 [email protected] python/Makefile.am: use *_LIBADD, not
*_LDFLAGS for LIBS
2022-01-16 [email protected] Fix check for libtool in autogen.sh
2022-01-16 [email protected] Add myself to maintainers
2022-01-15 [email protected] Revert "Make schema validation fail with
multiple top-level elements"
2022-01-10 [email protected] Different approach to fix quadratic
behavior in HTML push parser
2022-01-10 [email protected] Fix regression when parsing invalid HTML
tags in push mode
2022-01-10 [email protected] Fix regression parsing public IDs
literals in HTML
(cherry picked from commit c5dea7aa38a3e22e5990a5b0b398dcc3e8727b3a)
Fixed: 1269999
Bug: 934413
Change-Id: I602a086b91d514cb80859237c48729d4c10cf83e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3422595
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965736}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440584
Auto-Submit: Joey Arhar <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#272}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I2c282909172b6fdf227fdc089569ea1a76063223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442035
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#271}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644033083-d52d955e0bb647e1920fe1c5ff118ba52f6f5164.profdata to chrome-win32-4844-1644049533-cc14f464d3a8a5181ee1b64297820bb052c4707a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Ib5995ed4a9e573d36a55971ad1785b3f830f775c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442074
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#270}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644033083-5c603852bac8c243830cc9b2345ea9101c9f0c32.profdata to chrome-mac-4844-1644049533-8f779b9ce1fc0bf917993ce11beb684840a50fa4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I8be8e9e4e69922a9b8ce130a888463de87fff4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439698
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#269}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644033083-6e457e2760391eed194c436245b64cde9afdff30.profdata to chrome-win64-4844-1644049533-b17ce27bf24457ffde7ae3fd0530cec2f8759383.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I14ce939c27b678c68b8d60d0e970bb4fb6d17603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441793
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#268}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1644014187-a61b206947f689df964ef51295142b2452bbb308.profdata to chrome-win32-4844-1644033083-d52d955e0bb647e1920fe1c5ff118ba52f6f5164.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I0e076c746f5e63beda39365b322ca8dd64c268b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441684
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#267}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1644014187-479b33b3098500c94531e205d670a8da8774001d.profdata to chrome-win64-4844-1644033083-6e457e2760391eed194c436245b64cde9afdff30.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I2d3459bdf495d182d6c0eed059d09f2fafa69041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439361
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#266}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1644014187-20eee7158b080b096af0cf3ac20259b77b46474a.profdata to chrome-mac-4844-1644033083-5c603852bac8c243830cc9b2345ea9101c9f0c32.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: If2902dc73f20e42855b9be732b64f52176ad80cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439360
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#265}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Add UMA for when web page information is requested from the renderer
Add a new histogram to track when the web feeds feature is requesting
information about the loadede web page, recording the reason why that
information is needed.
(cherry picked from commit 09aedeff550442625a1aaf92fc8c874cfc25662f)
Bug: 1292564, b/215714543
Change-Id: I9208054d1d6797f39091a293458363f4e4a1943a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423446
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Carlos Knippschild <[email protected]>
Auto-Submit: Carlos Knippschild <[email protected]>
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965429}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440579
Reviewed-by: Ian Wells <[email protected]>
Commit-Queue: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#264}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643985735-ecddbe8f65a045794af464ac025ae31238ab1065.profdata to chrome-win32-4844-1644014187-a61b206947f689df964ef51295142b2452bbb308.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I5c679eaace28c5e973fb8490834c2256aba2520e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441305
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#263}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643985735-09b231575174202ba8ae499972fec48c2227bc46.profdata to chrome-win64-4844-1644014187-479b33b3098500c94531e205d670a8da8774001d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I748448979fd4a68e47965ee22e68873f50c14d69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441401
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#262}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643985735-d19cc77cd4213729567a2113ab880837c44fd024.profdata to chrome-mac-4844-1644014187-20eee7158b080b096af0cf3ac20259b77b46474a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I83e6f5b816ad060ea352f49c866482e53b179e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441399
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#261}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.21
Change-Id: Ic4a548c34fe9f062a9c798d9a4913b41c5ea78a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441292
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#260}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Nearby] Check background scanning flag before starting cooldown timer
Previously, we were starting the fast initiation cooldown timer after a
successful transfer even if the background scanning feature flag was
disabled. This resulted in users being shown the background scanning
notification even when the feature was disabled. If the user clicked on
the notification, they would de-reference a null pointer and crash.
In this CL, we check that the background scanning feature is enabled
before starting the timer. As a failsafe, we add another feature state
check to InvalidateFastInitiationScanning(), and we early return if
the feature is disabled.
The cooldown timer addition landed in 99.0.4808.0.
(See https://crrev.com/c/3353887.)
(cherry picked from commit 3d8e74ffcc17ce0fb0c6cd080062120261a78238)
Bug: b/216160852
Change-Id: I5508621b65d157d573552d4294112656ebfec7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434568
Reviewed-by: Claude van der Merwe <[email protected]>
Auto-Submit: Josh Nohle <[email protected]>
Reviewed-by: Josh Nohle <[email protected]>
Commit-Queue: Josh Nohle <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966739}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441179
Reviewed-by: Michael Hansen <[email protected]>
Commit-Queue: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#259}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643963927-82eb10abf89c16e43e8c2808c68f5d6048a3ee0c.profdata to chrome-win32-4844-1643985735-ecddbe8f65a045794af464ac025ae31238ab1065.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I1bf05fe5c81e95e9be47f4a42be13efc95c7bfac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441117
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#258}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643963927-7aa1d981bb56a3184f1652bdca9c9ccb22f50051.profdata to chrome-win64-4844-1643985735-09b231575174202ba8ae499972fec48c2227bc46.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I27fb6f48c216ad79f55f1bdff5652b9be09885ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441115
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#257}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Speculative fix for crash when arc notification is added
Hard to reproduce this crash but I'm quite sure showing / hiding
the widget is to blame. Setting the visibility of the bubble_view_
instead to address the issue.
(cherry picked from commit 9aa9025ca7c219c9cf7bbb790cacf43d06bbee1c)
Bug: 1286690
Change-Id: I71fac626f94054121b4630b1d34e2fcc394876a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413900
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Ahmed Mehfooz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965422}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437263
Cr-Commit-Position: refs/branch-heads/4844@{#256}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] context-menu: flatten STTS options
This change:
1. Replaces the two different forms of STTS entry in the renderer
context menu with a single option which opens the STTS bubble
unconditionally
2. Removes STTS in the link context menu - this self-shares the
link without a preview flow; this flow is pending redesign from
the privacy side.
(cherry picked from commit 73a24181da838e634e2a8f2409f7dd07c5f1cda2)
Fixed: 1288843
Change-Id: Ia914a28d8da6a57580a45ec8230df0b91d3fc5a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3416335
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965444}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440441
Auto-Submit: Elly Fong-Jones <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#255}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643963927-b0625acd8ceae3b216887e77d41ac96d885ce9b6.profdata to chrome-mac-4844-1643985735-d19cc77cd4213729567a2113ab880837c44fd024.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I11a778bb20a35acf8ea6180220778a809653a802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441114
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#254}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Migrate and merge deprecated always translate languages prefs.
The pref name string of the always translate languages pref was
previously changed, but the migration of the old pref values to the new
was never actually called on iOS platforms. To solve this, this CL does
this migration in the constructor of TranslatePrefs itself, with the
intention of later removing the existing non-portable calls to migrate
this pref. Since now clients can have values in both the obsolete and
new prefs, the migration avoids migrating any of the old pref values
that conflict with the new prefs.
To expedite merging into iOS M98, this new migration is behind a Feature
flag. This new Feature flag will be removed once merging this code is no
longer a concern.
(cherry picked from commit b7ef979f98a3abb971c43d14f0bebda90d730aa9)
Bug: 1291356
Change-Id: I55c50f3129efa3ca8127324a0a4cdddc16b33695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423449
Auto-Submit: Scott Little <[email protected]>
Reviewed-by: Megan Jablonski <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964680}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440900
Reviewed-by: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#253}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Fuchsia] Always copy video frames to GMP in WebMediaPlayerMS
WebMediaPlayerMS uploads video frames to GPU memory buffers, except when
the player is suspended. Frames that are not copied to GMBs are rendered
using different code path that's currently broken on Fuchsia. As result
a green frame is shown on the screen when the player returns from the
suspended state. Work around that issue by always copying video frames
to GMBs on Fuchsia (this doesn't affect other platforms).
(cherry picked from commit 125d1af32aee6f5282aca6470b793633a25373d2)
Bug: 1293616
Change-Id: Ib4539fe1ca412db3d5b7f021813349efcd4ab348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435468
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Auto-Submit: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966847}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438137
Owners-Override: Srinivas Sista <[email protected]>
Auto-Submit: Srinivas Sista <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#252}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643931976-f6f27c8c990ae574cbcfa04125ff4c5df8e4a068.profdata to chrome-win32-4844-1643963927-82eb10abf89c16e43e8c2808c68f5d6048a3ee0c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I3b5be4b715a16b206e67f5b64305bf9463cad3f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440047
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#251}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: Ibcfcadc77f962852836899861ce7742c2b5415f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439109
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#250}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643944116-02d0fdeb114d847142c9c0be83d991d5beb6c278.profdata to chrome-win64-4844-1643963927-7aa1d981bb56a3184f1652bdca9c9ccb22f50051.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I76cca276b64c28210b394d2597dd38eea6d9de91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439618
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#249}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643944116-ff1c9976dea14c63ff94d1341fc9f81c765e83a3.profdata to chrome-mac-4844-1643963927-b0625acd8ceae3b216887e77d41ac96d885ce9b6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I9a4fea93774b68d4a115116b060df936106199cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439617
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#248}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643931976-ebddfbe6df7da6171c03643d664bb19924de76b9.profdata to chrome-win64-4844-1643944116-02d0fdeb114d847142c9c0be83d991d5beb6c278.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Ia08d84ca9f3d3f547695230c5aa2d4b4c008906e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439266
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#247}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643931976-3932329dcc0c5da282c528f5505af8bebbed3da4.profdata to chrome-mac-4844-1643944116-ff1c9976dea14c63ff94d1341fc9f81c765e83a3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Id630129172ef3db950586ce3e7cf3201a1f80b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3439546
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#246}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643911194-a8a1b6660ddfae1df4a74e7ad78e0b5b32d64170.profdata to chrome-win32-4844-1643931976-f6f27c8c990ae574cbcfa04125ff4c5df8e4a068.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I2ef4d70485f613041183f9e9092d81f647533208
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438688
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#245}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643911194-d215c979a7f331ff8a35b348b77c80d4d96f9ff1.profdata to chrome-win64-4844-1643931976-ebddfbe6df7da6171c03643d664bb19924de76b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I044b494583208dda7d10c61a86c8214d66a020d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437583
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#244}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Sheriff] Disable testShow_SingleAsHomepage and testShow_SingleAsHomepage_NoIncognitoSwitch
Disables StartSurfaceTest.testShow_SingleAsHomepage and
StartSurfaceTest.testShow_SingleAsHomepage_NoIncognitoSwitch which are
flaky on Marshmallow 64 bit Tester and test-n-phone.
(cherry picked from commit bb0589aea342c769782867afe6a084a7b3c8a7f8)
Bug: 1291957
Change-Id: Ie0ebc53baf8abb1954fc41deedff653250b5e7e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423847
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964553}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437728
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Owners-Override: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#243}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643911194-1335c774bef6255aa48e9d0f743c62db24d76e9a.profdata to chrome-mac-4844-1643931976-3932329dcc0c5da282c528f5505af8bebbed3da4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I6b6145cd8957098ecd6b5c27ad841e96bb5244d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437813
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#242}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Revert "Tentatively re-enable devtools tests"
This reverts commit 52c8fb08a4b6ae527e2ea859757b1d9d5221614e.
Reason for revert: http/tests/devtools/console/console-time.js keeps failing M99+
Original change's description:
> Tentatively re-enable devtools tests
>
> - http/tests/devtools/console/console-time.js
> - http/tests/devtools/tracing/console-timeline.js
>
> Bug: 1203169
> Change-Id: I9dfd4367495d0ad31b2db6ba278181d785094b8a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3378671
> Reviewed-by: Mathias Bynens <[email protected]>
> Commit-Queue: Yang Guo <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#960340}
Bug: 1203169
Change-Id: Iad60bf039091849d994b675d2506039728354fb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438706
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Owners-Override: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#241}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.20
Change-Id: I860ca73970d2e7953f295fe837dd7496b43c95d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438753
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#240}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Sheriff] Disable ChromeSmokeTest#testHello
(cherry picked from commit bacf5a537fc0156bb51ba1d4ab44c43bb2565bfa)
Bug: 1289733
Change-Id: I04c3c76a14807614c9545c8e2506012760d50abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3407735
Commit-Queue: Zhiyuan Cai <[email protected]>
Owners-Override: Zhiyuan Cai <[email protected]>
Auto-Submit: Zhiyuan Cai <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962007}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438415
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Owners-Override: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#239}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: I24d724784ad78d2bbc74bdbbd34f704951b3bd57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438647
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#238}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Shopping] Add PDP metrics for page navigation
This patch adds a metric to track whether a navigation is to a
PDP and then whether that PDP has a cluster ID. This metric is
not tracked if optimization guide can't be used to fetch the
information and currently only runs on android.
(cherry picked from commit c6506e12c05f0942bfb4dc58eb81ad2f789d3231)
Bug: 1285460
Change-Id: Iee2a73b8987208d182ea14846d5cd99c4ea98e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379083
Reviewed-by: Zhiyuan Cai <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Maunder <[email protected]>
Reviewed-by: Wei-Yin Chen <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Auto-Submit: Matthew Jones <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Camille Lamy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964506}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428621
Reviewed-by: Ayman Almadhoun <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#237}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Add a fuchsia branch type.
Fuchsia pins chrome milestones for their releases and will occasionally
changes made to the milestone. To support this, an additional branch
type is being added so that the CI/CQ configuration can be adjusted to
turn down unrelated builders. The fuchsia subset of resources that is
selected for standard branches and desktop extended stable have been
updated to also be selected for fuchsia lts.
(cherry picked from commit d12a779260d56a4731523f53d08ae01e33d5a473)
Bug: 1292621
Change-Id: Ic4f886b5699ec43e06cc353f8c34091a505e8c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432823
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966837}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436534
Auto-Submit: Garrett Beaty <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#236}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Add lacros-tracking-roller as known robots
lacros-tracking-roller is the service account of lacros-qa-qualified
-tracking-roller. It will generate cl to update chrome/
LACROS_QA_QUALIFIED_VERSION and auto-submit.
(cherry picked from commit 668bde99aa1d5a49ac68b3f0656603b3eb151a09)
Bug: 1271674
Change-Id: If7c0a80b0ff78edcb1b9b31be189a055a952fea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419658
Reviewed-by: Sven Zheng <[email protected]>
Reviewed-by: Mike Pinkerton <[email protected]>
Commit-Queue: Jieting Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964155}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421648
Cr-Commit-Position: refs/branch-heads/4844@{#235}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Disable 4 PRESUBMIT_test cases
- testGnPathsAndMissingOutputFlag
- testRelevantAndroidPyInNonAndroidCheckout
- testRelevantPyOneChange
- testRelevantPyTwoChanges
Found they are failing when working on a PRESUMBIT.py change.
Verified that they are also failing on main branch. So disabling them.
(cherry picked from commit 975c0c2607fd701ca922b22a5ed59c8fa2cc72ea)
Bug: 1289871
Change-Id: I37ff038b42cf5e86080a01f8e37276f8d1fb18c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3408275
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Shimi Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962147}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438130
Commit-Queue: Jieting Yang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#234}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I15b297f836a1f84b66c599f22b41be9477e99972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437465
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#233}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643878203-82aa32cbb98f7364eeb65719fc97e1435b263ce7.profdata to chrome-win32-4844-1643911194-a8a1b6660ddfae1df4a74e7ad78e0b5b32d64170.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I4f701e990971238e1f5f20edf981c04acf6f3f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437928
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#232}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643867582-3766935e581c534c645e084900e840c9256860e0.profdata to chrome-win64-4844-1643911194-d215c979a7f331ff8a35b348b77c80d4d96f9ff1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: Idf49acd0170733aa05f63a6ee619d2f37c68cad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436354
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#231}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[fuchsia] SysmemBufferCollection should always allow protected memory.
When setting constraints for VkBufferCollection, chromium should
always allow protected memory and let other clients determine if
protected memory will actually be used.
Note that this is a workaround to solve b/215196526 and it depends
on device supporting the protected optional flag. Instead we should
enable the flag only if protected memory is explicitly supported by
VkPhysicalDevice (see crbug.com/1289315).
(cherry picked from commit 0649fa31d9ce5c02ee43bbf737455141ec4a0123)
Bug: chromium:1293551
Bug: chromium:1285429
Bug: chromium:1289315
Bug: b/215196526
Change-Id: Ia938539080cbda4f10bde2a254b835ca849628f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3402770
Reviewed-by: David Dorwin <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Commit-Queue: Yilong Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#961664}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433995
Auto-Submit: David Song <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#230}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[infra] Update active set of LUCI experiments.
Remove buildbucket experiment "luci.use_realms",
it is a noop now.
Enable "crbug.com/1182002" required to support ongoing
LUCI Scheduler config migration.
BUG=1182002
[email protected]
Change-Id: Ia251c523a53e416314fd5909cc78154df5c3cdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437851
Commit-Queue: Vadim Shtayura <[email protected]>
Auto-Submit: Vadim Shtayura <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#229}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643878203-8cdb122d065427ec53f7e36a4dd1e429699ff7ef.profdata to chrome-mac-4844-1643911194-1335c774bef6255aa48e9d0f743c62db24d76e9a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic8ce76d69fbeb6ef580f1484b87cbe369b232a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437867
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#228}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Re-enable Mac for internal optimization guide
This also includes some instructions for what files need to get updated
if the build_with_internal_optimization_guide flag gets flipped for
various Desktop platforms
(cherry picked from commit 14b03ed65d1b5a430e9f39c16206cdfc17fdda69)
Bug: 1290461
Change-Id: I5d21eb4e35347cebec07f3146410e1eb1622977a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413680
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965294}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433707
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#227}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99] weblayer: Control swallow event only when visible
Looks like BrowserControlsContainerView remains in the layout and only
made View.INVISIBLE when hidden. In this case, it can still receive
touch events, which should be passed through to web content below.
(cherry picked from commit c1261da5f0b1efc4480428e8c59d3927c513778b)
Bug: 1282898
Change-Id: I11dc1cfe9c390c5ce62e4a5eae081ecbbe262535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427930
Commit-Queue: Bo Liu <[email protected]>
Auto-Submit: Bo Liu <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965854}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437266
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#226}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Merge M99] Only load navigation body early for text/html documents
There was a test failing when trying to enable EarlyBodyLoad in the
fieldtrial testing config that was loading an image file. The early body
load doesn't help much for non-HTML documents.
(cherry picked from commit b81e69ec965d3e95921fef9b7859ffbab0aac07b)
Bug: 1274867
Change-Id: I6c18c05ef8c54dcde2977c02bd1e898ea1156904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429780
Auto-Submit: Clark DuVall <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966004}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437288
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Ben Mason <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#225}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
android: ModernLinker: use local address on RELRO lookup
The crrev.com/964228 attempted to use the |load_address_| that was set
up in the current process instead of taking it from the
|mRemoteLibInfo|. It was done incorrectly because the checked
|load_address_| was taken from the other process anyway, just a few
moments before.
In this patch actually use the local load address from |mLocalLibInfo|.
This fix is still made under assumptions that the local library load
failed for the first time and switched back to no RELRO sharing. In this
case the load address should be equal to zero.
(cherry picked from commit e2b83b2ee59a8a2156b1c878dff658ae3443f27a)
Bug: 1278078
Change-Id: I5378fdf08b48d06fbbdfbdec50e23f05cc2b7256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427757
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Egor Pasko <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965858}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436414
Auto-Submit: Egor Pasko <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#224}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Subscriptions] Move metrics out of implicit tracking component
Some subscription metrics are for both explicit and implicit tracking so
we should move them out of the implicit component. The metrics are
recorded on app resume and at most once per day, which is similar to
implicit subscription initialization. To avoid duplicate
ChromePreferenceKey, we move related logic from implicit manager to the
service as well.
(cherry picked from commit 6684ffa01bad69a0d0ea5ee251703b28b44bc3e2)
Bug: 1289475, 1271234
Change-Id: I19915ac97f0429d340c3375145f1d6780697b5a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415036
Reviewed-by: Ayman Almadhoun <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434390
Cr-Commit-Position: refs/branch-heads/4844@{#223}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
android: ModernLinker: nocrash when RELRO arrives after loading fallback
Library loading fallback happens rarely, but often enough to be a
concern for crashes. The fallback is inline in the Linker.loadLibrary().
If loading the native library with relocation sharing support fails, the
mLocalLibInfo.mLoadAddress is zeroed out before attempting to make
another attempt.
Currently the crash seems to occur when the first attempt to load the
library in the GPU process fails. After the successful load on the
second attempt, everything works fine for some time. Until a valid
LibInfo arrives from the browser process. The RELRO lookup in the
current process looks at the load address in the _local_ LibInfo. That
address was zeroed out.
The previous attempt to fix it (http://crrev.com/951667) incorrectly
checked for mRemoteLibInfo.mLoadAddress instead of the one that was
zeroed out (i.e. 'remote', not 'local').
This change corrects it.
(cherry picked from commit 4896631ace573c3bbee91b5544ccd7d071b34b00)
Bug: 1278078
Change-Id: Ibd865359a1c7026b0347fca368944ea5c08b24f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3420499
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Egor Pasko <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964228}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436591
Auto-Submit: Egor Pasko <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#222}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Update the branch.matches code to accept multiple selectors.
The branches.matches function currently works with a single selector,
whether it's one of the basic selectors (MAIN, STABLE_BRANCHES,
DESKTOP_EXTENDED_STABLE_BRANCHES or CROS_LTS_BRANCHES) or one of the
compound selectors that is composed of multiple basic selectors.
However, if a list is passed that contains a compound selector, the
compound selector will never match because it is assumed that multiple
elements will all be basic selectors. This changes it so that an
iterable can be passed containing any selectors and it will be reduced
down to a list of basic selectors.
Fixing this will allow for marking a resource for desktop extended
stable and the fuchsia lts branch type that will be added in an upcoming
change.
(cherry picked from commit b3733d8d199fd794a7329ca34554bae1d7afa741)
Bug: 1292621
Change-Id: I5e3d46498acf8d158c4965e3594a85e69644fd7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432822
Auto-Submit: Garrett Beaty <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966517}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437745
Cr-Commit-Position: refs/branch-heads/4844@{#221}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Shopping] Gate access to SubscriptionsManager on feature flag
Accessing the SubscriptionsManager for a profile causes it to be
created if it hasn't been already. In turn this fetches subscriptions
from the server. This patch gates access (and therefore creation) of
the SubscriptionsManager unless a feature that uses it is enabled.
(cherry picked from commit 0c2b60e6ce53ed2f2574e240fdc48cb44f302e7f)
Bug: 1290918
Change-Id: I0f578ca5a2a6044d45d779e9ad7be8d186f0815d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3417239
Reviewed-by: Brandon Wylie <[email protected]>
Reviewed-by: Zhiyuan Cai <[email protected]>
Auto-Submit: Matthew Jones <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Theresa Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965913}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434111
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Ayman Almadhoun <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#220}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643867582-d7f46f30969d575f699babb40661aabb1dde82a6.profdata to chrome-win32-4844-1643878203-82aa32cbb98f7364eeb65719fc97e1435b263ce7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Icb6d4b3cdf71d0c63c2f49d7477ebaed164ff65a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3436365
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#219}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill Assistant] - m99 - Fix crash in ~ClientAndroid()
Merge to release branch.
The crash was caused by us moving the same casted pointer inside two
separate unique_ptr.
(cherry picked from commit 3a718582addd942046b6e8cfdbf1ecbe15a45bcf)
Bug: 1283013
Change-Id: Iafbce57091dcb14170d0ebcaab8a015b311dd82f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429169
Auto-Submit: Florian Gauger <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Florian Gauger <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965721}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429902
Commit-Queue: Clemens Arbesser <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#218}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643867582-827d8d63528ecc5f800c4b9dfee082ecceea6d65.profdata to chrome-mac-4844-1643878203-8cdb122d065427ec53f7e36a4dd1e429699ff7ef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic5cb5d6cff210b80d64991c1699d3d78116f1648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435077
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#217}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643845378-1a201a690f4ecaf95b2df961494c253991fe36c7.profdata to chrome-win32-4844-1643867582-d7f46f30969d575f699babb40661aabb1dde82a6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I09638220f3ac586547db7f677ea281060037eb0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435177
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#216}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643845378-ee454aab7699c9091a1abbf6773f6a6c3be20133.profdata to chrome-win64-4844-1643867582-3766935e581c534c645e084900e840c9256860e0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I5e3b807472d3a94b64f3b43d2a301f6eb1000f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435687
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#215}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643845378-8e27c99d6728750bc63404305dd89af89081ef9d.profdata to chrome-mac-4844-1643867582-827d8d63528ecc5f800c4b9dfee082ecceea6d65.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib146d683d1b0040a072115719d8f401c9765af2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435765
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#214}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Disable thread priority resetting on exec.
There was a deadlock found so temporarily disable this.
Note that there was another CL crrev.com/c/3412559 to do this,
but it turned out that there are two very similar classes,
one is used, and the other is not. The old CL disabled the unused
one, and this CL disable the correct one.
BUG=1289736
TEST=Build.
(cherry picked from commit 154c3dd49c6e5e124da07ae8512ed783e71ef53a)
Change-Id: I9b44b75afe0c6dff4e6f928fccc404d95e2b9c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429339
Auto-Submit: Hidehiko Abe <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965769}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435527
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Eriko Kurimoto <[email protected]>
Commit-Queue: Eriko Kurimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#213}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Merge M99] Revert "Enable support for WebRTC H.264 YUV444 decoding."
This reverts commit 5ae9244412a6501f19b6b8a914284d139355b48e.
Reason for revert: The CL that this CL depends on got reverted
(https://webrtc-review.googlesource.com/c/src/+/249791) and now the
webrtc.fyi bots are broken, preventing roll into chromium
Original change's description:
> Enable support for WebRTC H.264 YUV444 decoding.
>
> WebRTC now supports H.264 YUV444 decoding. This change adds code to
> Blink rtc_vide_decoder_factory.cc to enable that feature for use in
> Chromium.
>
> Bug: 1251096
> Change-Id: Ib801d1acf3b3679692016899a648dccf103e5856
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3398199
> Reviewed-by: Dale Curtis <[email protected]>
> Commit-Queue: Dale Curtis <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#960755}
(cherry picked from commit d4a26031be3438e586e58d82ea85088d1b100822)
Bug: 1251096, 1291956
Change-Id: I435a76589328003beac0e02e73b1b1c0a93e45f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427017
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965119}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432127
Cr-Commit-Position: refs/branch-heads/4844@{#212}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] add service account in OWNERS file
Add service account of lacros-qa-qualified-tracking-roller as the file
owner. It will submit the change of this file.
(cherry picked from commit a65c7985ba3f898e4bd9757ea72e8234dc59790b)
Bug: 1271674
Change-Id: I8c4202ff9a25cb4bbdb3c669234512b9dfbbac1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413743
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Jieting Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962749}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435267
Cr-Commit-Position: refs/branch-heads/4844@{#211}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Fix linux-ash-chromium-generator-rel
crrev.com/c/3248357 removed all the chromeos dev channel
from the files list. But our rule request dev channel
file list:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/BUILD.gn;l=9923;drc=9adf1d0da0289ca1538d9a71ccc5b6b5118add81
As a result, the ash builder build successfully, but
archive nothing, and succeeded update the zip file with
no files in it.
https://chrome-infra-packages.appspot.com/p/chromium/testing/linux-ash-chromium/x86_64/ash.zip/+/version:100.0.4862.0
The fix here is to create a cipd yaml file.
(cherry picked from commit f94a6b9911988c4342a72491b36fe2caee643b7e)
Bug: 1292672
No-Try: True
TEST: Tested locally.
Change-Id: I8343f2776375e8e652ae1056cc51e8a0be8af287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427923
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Sven Zheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965379}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433235
Cr-Commit-Position: refs/branch-heads/4844@{#210}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4844-1643824238-10886701c3330b50551db9a8096e25d59856cf9a.profdata to chrome-win32-4844-1643845378-1a201a690f4ecaf95b2df961494c253991fe36c7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: I53b54b14d380ce9f351641355648a19e3775af3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435088
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#209}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4844-1643824238-f53519fc8cd684b4af74da96e4dfa66312249af4.profdata to chrome-win64-4844-1643845378-ee454aab7699c9091a1abbf6773f6a6c3be20133.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I10a081caf1d3bbe4db5a7861580687aeacd03fbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434852
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#208}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Reland "Load rootfs lacros even if component updater reports and error."
This reverts commit a173d60715a0da0cfe01990807c62fa05f140d3d.
Reason for revert: There is LGKM update in the same run, and similar
failure found in before the original CL was landed.
Also, test failure is spread to most of tests.
Those three thing suggests this was not the cause.
Original change's description:
> Revert "Load rootfs lacros even if component updater reports and error."
>
> This reverts commit ae52c66908471b4ec2792f511c277a37698d36cd.
>
> Reason for revert: Speculative revert
> Suspected of causing multiple ash test to be expectedly skipped on Linux Chromium OS ASan LSan Tests (1)
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/41324/test-results
>
> BUG=1292957,1293344
>
> Original change's description:
> > Load rootfs lacros even if component updater reports and error.
> >
> > At the beginning, we should take a look at both rootfs/stateful Lacros
> > versions, and compare them simply to choose newer one.
> >
> > If Lacros is locally deployed, we bypass the check and recording.
> >
> > BUG=1292957
> > TEST=Tested on DUT.
> >
> > Change-Id: Ifd3c368a158f584d1ad45b452a350b3336950832
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412572
> > Reviewed-by: Erik Chen <[email protected]>
> > Reviewed-by: Stefan Kuhne <[email protected]>
> > Commit-Queue: Hidehiko Abe <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#966074}
>
> Bug: 1292957
> Change-Id: I3c59dd7d70a829febc8702f88cbc9277488b99d6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431445
> Reviewed-by: Christoph Schwering <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Christos Froussios <[email protected]>
> Commit-Queue: Christos Froussios <[email protected]>
> Owners-Override: Christos Froussios <[email protected]>
> Auto-Submit: Christos Froussios <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#966165}
(cherry picked from commit 43245ad654c9ffff7897ece94d91818635b9d662)
Bug: 1292957,1293344
Bug: 1292957
Change-Id: I022041643b3197d0fec0b6847b6046f3c3c33382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431625
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Hidehiko Abe <[email protected]>
Reviewed-by: Christos Froussios <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#966193}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434705
Reviewed-by: Stefan Kuhne <[email protected]>
Commit-Queue: Stefan Kuhne <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#207}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4844-1643824238-719c90be3523405a32453a7b163f0df3e929b2dd.profdata to chrome-mac-4844-1643845378-8e27c99d6728750bc63404305dd89af89081ef9d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: I296225397f9ac88c2ae997e1b30de7fa0042e8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434849
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#206}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1642673694-7347631494bb47853b7050913b3d09eaaa5cfff4.profdata to chrome-win32-4844-1643824238-10886701c3330b50551db9a8096e25d59856cf9a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win-chrome
Tbr: [email protected]
Change-Id: Id2b076c144f055b082d06b044c1c9b2828cc37c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434095
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#205}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1642701562-74736e1a1467504debb0f64c9745c095973f160e.profdata to chrome-win64-4844-1643824238-f53519fc8cd684b4af74da96e4dfa66312249af4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:win64-chrome
Tbr: [email protected]
Change-Id: I20f302b4449515092b77e5e3e23626c20821945c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433720
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#204}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1642701562-3dbb6159a0e28e97d4ecac6d8373fe18a4998a4a.profdata to chrome-mac-4844-1643824238-719c90be3523405a32453a7b163f0df3e929b2dd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie80fe6e483b6f71c7d4b612b2ecaa5e82055db77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433721
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#203}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.19
Change-Id: I05e9618248fe0e2df38651e3eb8c7b7cd6cdacf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434905
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#202}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1642636750-7bbac48c5f876fc30f123a0e90b3f405fa38f576.profdata to chrome-linux-4844-1643216352-97a620e3689ad97f751f72a37aab485a59352233.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome-m99.try:linux-chrome
Tbr: [email protected]
Change-Id: I33e7d8de4e81e41b4868156274a4fc658f1ea89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433719
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#201}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[linux] Fixed setting the insets for windows in unknown state.
When the window is only being set up, it does not receive the valid
state immediately. That affected configuring the window size when the
client-side decorations were used, and resulted in increasing the window
size on every restart.
This patch fixes the condition in setting the frame insets so that they
are configured properly for the new window.
(cherry picked from commit df1996daacf67cf69e83864b1088d746f9fe3757)
Bug: 1287212
Change-Id: Idb78047d44913043c1ce8aab96623638e2d2b401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405038
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Alexander Dunaev <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964746}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432487
Auto-Submit: Alexander Dunaev <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#200}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Speed up cookie access.
40% of the time was spent generating the cookie observer calls to the browser process, but we can do that after replying to the renderer.
Use the existing kFasterSetCookie feature flag for this.
Bug: 1290944
(cherry picked from commit bf391211a25e3f7a64897e000e6be84c143299ce)
Change-Id: I7ed4086b4798ba47ba2d63042e4745c8f591e5d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425174
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433626
Auto-Submit: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#199}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Temporary fix for rendering corruption on 4K or larger displays.
This change temporarily increases the compositor memory limit for
displays that are 4K or larger. The rendering was using up more memory
than expected, hitting the limit and causing parts of the UI to not be
rendered.
Tested with emulator with a large display size and confirmed the memory
limit was increased.
(cherry picked from commit 3fcfa32692cd6506ecb8ed3a5a5f492ed750ab8c)
Bug: 1261776
Change-Id: I502323d6098fda5d96cb28c76aad4debecd3d3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413653
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Addison Luh <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963721}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3426433
Auto-Submit: Addison Luh <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#198}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Roll src/third_party/breakpad/breakpad/ d55a5f3dc..08bd84459 (1 commit)
https://chromium.googlesource.com/breakpad/breakpad.git/+log/d55a5f3dcaf5..08bd844599bf
$ git log d55a5f3dc..08bd84459 --date=short --no-merges --format='%ad %ae %s'
2022-01-28 zequanwu Fix corner cases on Windows dump_syms
Created with:
roll-dep src/third_party/breakpad/breakpad
(cherry picked from commit e13e705ee88385246ccc5ad6aa42dd3c606c1cab)
Change-Id: Ib6494c13233fb5c2ab549d11d630c172cb78dba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425880
Commit-Queue: Zequan Wu <[email protected]>
Auto-Submit: Zequan Wu <[email protected]>
Reviewed-by: Joshua Peraza <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964901}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433230
Cr-Commit-Position: refs/branch-heads/4844@{#197}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Messages] Adjust horizontal threshold of swiping animation
The horizontal swiping dismissal is not paritcular reliable and so lower
the value to 10dp.
(cherry picked from commit 234aa9209b90de70dffca131a5487af6d9b54d8a)
Bug: 1289294
Change-Id: If1d8e917383291bf0d6c690e6f6c89d7ac6285ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425657
Reviewed-by: Aishwarya Rajesh <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432721
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#196}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Fix typo in Permissions.PredictionService.PredictionSource histogram name.
(cherry picked from commit 0f77393d9553ff3d0af487ee942941df22e7c096)
Bug: 1292941
Change-Id: I3ab51a216313713e86b7122f28c5bec60b929efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427601
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Ravjit Uppal <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965645}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433150
Auto-Submit: Ravjit Uppal <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#195}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Implement UMA collection for audio hardware output latency
This patch implements the metric collection of audio hardware output
latency on an AudioContext.
Relevant discussion: https://crbug.com/1258109#c77
(cherry picked from commit 01d1ead69cd5f2a778cb7d33ffe317769050578a)
Bug: 785409
Change-Id: I79c51e074fc5b1df204ad14727d373ba32e118c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413794
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Brian White <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965299}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428130
Auto-Submit: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#194}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Replace WidgetObserver::OnWidgetClosing() with OnWidgetDestroying()
In some cases, OnWidgetClosing() is not called when the widget is
closed, resulting an invalid pointer |widget_| stored in
WebContentsDisplayObserverView.
This CL replaces OnWidgetClosing() with OnWidgetDestroying(), which
is recommended in crbug.com/1240365
(cherry picked from commit 4535fe2334d0713535adb52b641a8cb34e11333c)
Bug: 1291728
Change-Id: I64fef8b30930f60220008809ee00f4385d6c3520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425473
Auto-Submit: Muyao Xu <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965431}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428150
Cr-Commit-Position: refs/branch-heads/4844@{#193}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[fuchsia] Prevent logging when log_level_ is set to 0
FUCHSIA_LOG_NONE is incorrectly defined as 0 (https://fxbug.dev/92441).
Add an explicit check for 0 to handle this. Since the definition will
be changed in the SDK, check for the literal.
(cherry picked from commit cc3bed092caefeee0621e79fd801766a9a84354a)
Bug: 1292187, 1292208, b/216556758
Change-Id: I6955e0f5ef85ea5651bef9d7f8b1ebbc134be5c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425671
Reviewed-by: David Dorwin <[email protected]>
Commit-Queue: David Song <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964853}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432266
Auto-Submit: David Song <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#192}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
CWVCreditCardVerifierTest.IsExpirationDateValid: Bump years
Seems that February came and the test started failing. Bumping for 4
years now.
(cherry picked from commit a146ffecb8bbf3221f611d8f2b628678effd7304)
Bug: none
Change-Id: I628ebed4100a44988a35ac5ed17fd1f37f97b664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429166
Commit-Queue: Fabian Sommer <[email protected]>
Reviewed-by: Fabian Sommer <[email protected]>
Commit-Queue: Roman Sorokin <[email protected]>
Owners-Override: Roman Sorokin <[email protected]>
Auto-Submit: Roman Sorokin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965651}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433088
Owners-Override: Justin Donnelly <[email protected]>
Auto-Submit: Justin Donnelly <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#191}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
m99: TtsService: Avoid calling into shutdown path during process teardown
R=[email protected]
(cherry picked from commit 92ae335e7d6f502806767eb56d4ffa8518877222)
Fixed: 1292538
Test: verify no crash on process shutdown
Change-Id: I3944850b759dca72cc5e691535bd7b4cb7d2fa2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428462
Reviewed-by: Josiah Krutz <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965755}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431946
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#190}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I778f551d712c317265d3e39f9f0345b40950b12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3431406
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#189}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Mac: Stop building universal binaries.
The universalizer bot will universalize these now.
Bug: 1279824, b/27730714
Change-Id: If474cd29f28f093f1938d208f104ebcb78b94256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423568
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#188}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Merge to M99][Messages] Re-show notification blocked dialog if necessary.
If user leaves page by clicking on "Learn more" link, re-show
the dialog when user returns to the original tab.
If user leaves page by clicking on "manage" button, re-show the dialog
after user closes the setting screen.
Demo: https://drive.google.com/file/d/1LexWTrIIxYP81PxARpDeg1eL7zr4OD7j/view?usp=sharing&resourcekey=0-aGWfwYk2bp5QSkTskkxfyg
(cherry picked from commit b05ef8942b2dd09ae39065929d8973682f747bee)
https: //drive.google.com/file/d/16LeviGB__LUQZoSjwuQR15jVl-GB8aFl/view?usp=sharing&resourcekey=0-YFAT4QYsreedMpvU8zqHqw
Bug: 1230927
Change-Id: Ib887a43a160405686d20e20d87619e8e197c159a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346240
Reviewed-by: Aishwarya Rajesh <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3422598
Cr-Commit-Position: refs/branch-heads/4844@{#187}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill Assistant] Onboarding experiment, fix copy/paste typo.
This is a 1:1 cherry-pick of the main branch.
(cherry picked from commit 85081ac8fd9e71751591691256206364e6c6a5fa)
Bug: 1292914
Bug: b/209561294
Change-Id: Icea75c993bf6ebd6638a7c19a8dd3b9285306751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427539
Commit-Queue: Clemens Arbesser <[email protected]>
Auto-Submit: Clemens Arbesser <[email protected]>
Reviewed-by: Sandro Maggi <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965253}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427773
Cr-Commit-Position: refs/branch-heads/4844@{#186}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Pass all PPS NALUs as data to the platform decoder
It helps in cases when there are more than one PPS in the buffer
Video Toolbox is smart enough to find and recognize them there.
Test: mac-h264.glitch.me
We'll have more testing once we switch Mac VEA to new API,
it generates multiple SPS and PPS.
(cherry picked from commit 4f58485b7a1e52c42db2e3a533afb01840885e16)
Bug: 1282056
Change-Id: Icdc98d10a4e90e2d20b38780973b05a2bea9de37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3407723
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962178}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430519
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#185}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.18
Change-Id: I2b749bf6a792b86a40ddc8ef5a49804de06bddc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430291
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#184}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
ios: Implement CheckForOverRealization for Realized WebStates.
With |kEnableUnrealizedWebStates|, detect improve usage of WebState
realization. Various bugs have triggered the realization of the entire
WebStateList. Detect this by checking for the realization of 3 WebStates
within one second. Only report this error once per launch.
(cherry picked from commit 62874e63dc866851ad81ae88e59fc6aab74247aa)
Change-Id: I05b6a5bc99b557a8ec1d7dd8f735389adf69da89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421833
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964982}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430520
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Auto-Submit: Harry Souders <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#183}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Incrementing VERSION to 99.0.4844.17
Change-Id: I2a6143d51d4c3c41a0aa993671a04bf40cf1f50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430289
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4844@{#182}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
ozone: Fix support for haptic touchpads
Because the linux input.h header file is updated in some but not all
kernel versions, Chromium may be built without the required header
definitions. In that case, HapticTouchpadHandler will not try to use the
updated UAPI, even though the kernel supports it. So, this CL adds the
definitions.
Note that none of these conditional definitions will be used unless we
are using a kernel with the updated UAPI. EventDeviceInfo's
HasHapticTouchpad method can only return true with the updated UAPI
because it depends on INPUT_PROP_HAPTIC_TOUCHPAD, which was added in the
same kernel patchset.
(cherry picked from commit 638b7b20808ed5e802e0aa555993fd0cb6288504)
Bug: b:204903440
Change-Id: I8b4b0d2776103b5cc775e89212fd52d473868c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3408190
Reviewed-by: Harry Cutts <[email protected]>
Commit-Queue: Sean O'Brien <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962326}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412812
Auto-Submit: Sean O'Brien <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#181}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
(M99 Merge) Adding a modal version of the Assistant voice search consent dialog.
To facilitate the multiple UI implementations, AssistantVoiceSearchConsentUi has been split into two parts:
- AssistantVoiceSearchConsentUi and its subclasses, which implement the modal and bottom sheet UIs.
- AssistantVoiceSearchConsentController, which implements the shared functionality (primarily preference updating and consent backoff).
Mocks: https://docs.google.com/document/d/1vgcyEV2obSDxZ3WyrPN3s3Q7Yv83waQnBskOSNJou9k/edit#
Screenshot: https://drive.google.com/file/d/1HN-28ENmjzZ06FtPmBjv9v50wpGdRNgK/view?usp=sharing&resourcekey=0-I1JTgA9sjTB3tlDsPB1Zwg
(cherry picked from commit ee2d18382b4f0773aaada045d306735622e5a92d)
Bug: 1289375
Change-Id: Id7aefeb7b9f119193a8228a8e8e41c98dc1a097d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405146
Reviewed-by: Trevor Perrier <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Josh Simmons <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964325}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428143
Cr-Commit-Position: refs/branch-heads/4844@{#180}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[ios, kSingleNtp] Update LogoVendor's WebState as NTPMediator does
If kSingleNtp is enabled, only one LogoVendor/NTPMediator will be used
for all NTPs, so as the active WebState showing the NTP changes,
the LogoVendor's WebState needs to be updated.
(cherry picked from commit 9130635112c446f7affe1f1fd7b8fe497f357eee)
Bug: 1286325
Change-Id: Ie70e26c57ca5155d765e31c53e395c60c9eadd26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3415658
Reviewed-by: Adam Arcaro <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964087}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425656
Auto-Submit: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#179}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Rename CastMediaSinkServiceImpl::RemoveSink()
This is a speculative fix for an issue we're seeing in which Cast
discovery is failing under certain conditions.
crrev.com/c/3325421 made CMSSI::RemoveSink() override the base method
and call CloseSocket(), and that changed the behavior for all the
callsites of RemoveSink() in CMSSI. This CL reverts that by naming the
method DisconnectAndRemoveSink() instead of overriding RemoveSink().
(cherry picked from commit 5c24013b2f55ce7b13ea074eba52ed861e67526f)
Bug: 1291679, b/215783755
Change-Id: I66ee7165741d45dab377caf6482d92e1e0b33442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421720
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964336}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428637
Auto-Submit: Takumi Fujimoto <[email protected]>
Commit-Queue: Mark Foltz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#178}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Better handle adding app list item to non-existent folder
When adding an app with a parent ID set, AppListSyncableService attempts
to create the app list folder before it adds the app to it. The folder
only gets created if the folder item exists in syncable data. Syncable
service had logic to handle non-existent folder when ensuring its
existence (it was clearing the app list item's folder ID), but the
calling method was not checking whether the folder actually existed
before adding the item (it was using the folder ID from before the
chrome app list item parent info was reset) - this fixes the issue, if
the folder does not exist, the item is now added to root apps grid.
Adds a test for this scenario (which causes a crash trying to access non
initialized list of folder items).
Also, add a couple of more tests that verify adding folder children with
invalid position ordinals works fine (as I was suspicious this may cause
issues while debugging the linked issue).
BUG=1292112,1259459
(cherry picked from commit f4da626bf6f177e87d5541a9d6ea2be4cf62ebe9)
Change-Id: I75b7abb776c579f670b81cda0f9edc0aefd2204f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425662
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3424874
Cr-Commit-Position: refs/branch-heads/4844@{#177}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[PCAS] Add a LRU cache for visit annotation requests based on the text.
This adds an in-memory cache of annotation requests in order to limit
how frequently models are executed, particularly if the result was
recently determined by the model. In particular, same-document
navigations can often have the same title, or content text.
(cherry picked from commit 7d56cae272b7df953e91e1e2be902f9613b2e556)
Bug: 1291275
Change-Id: Ib0759df63cb5c9860dbf1a218b33f97e708ab69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419661
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964261}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428287
Cr-Commit-Position: refs/branch-heads/4844@{#176}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Type check stored policy value before extracting it from PolicyMap.
Policies stored in PrefService have their type automatically checked
before their value is retrieved by the service. As a result, accessing
a boolean policy's stored value will always yield a boolean result.
On the other hand, policies which are accessed directly through
PolicyMap have no such guarantee. If a boolean policy has a non-boolean
value set, calling GetBool() fails, causing Chrome to crash.
This CL adds a safety check for boolean policies that are not stored in
PrefService to ensure that the policy value is retrieved only if the
stored value type matches the expected type.
(cherry picked from commit a04e69312e219f847284db4d31474abcafffee2e)
Bug: 1292150
Change-Id: Ib219ca1a0bfaa7c84d316bbc1119276955c92fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423312
Reviewed-by: Owen Min <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Commit-Queue: Igor Ruvinov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#965265}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423315
Cr-Commit-Position: refs/branch-heads/4844@{#175}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Enable the Extended Variations Safe Mode on 50% of dev.
Android Chrome only.
Things appear to be WAI on canary, so I intend to merge this to M99.
The expected metrics movement is significant although I'm not confident
this is accurate: http://shortn/_MDpQopPiUM.
(cherry picked from commit c1af44687361d0bc22a414a430c9c25a36b14a96)
Bug: 1269139, 1248239, 1292023
Change-Id: Id5f109001be72f91c814e0be77c5dcd0f4d4b292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418202
Auto-Submit: Caitlin Fischer <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964042}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421245
Commit-Queue: Caitlin Fischer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#174}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Autofill Assistant] Fix credit card bug
When selecting a credit card, we would send the update
for the card without sending the update for the address.
This would mean that the UI always sees the old address
for the current card. In native everything is ok, leading
to weird behaviour.
(cherry picked from commit 2306f114943794f89574848af84faf77749fdf52)
Bug: 1292454
Bug: b/216580821
Change-Id: I35ebb11f1b0e5cf4b1b2f2e428316f77b33012ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419916
Reviewed-by: Luca Hunkeler <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963958}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427753
Auto-Submit: Sandro Maggi <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#173}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Look at policy value preserved in feature flag on restart.
On restarting ash-chrome, the policy value is set up on Profile
creation. However, on restarting, BrowserDataMigrator needs to run
before the creation, and it requires to take a look at the value
in policy (LacrosAvailability).
To deal with the situation, now LacrosAvailability policy value is
preserved in session_manager as a pseudo feature flag.
So, this CL starts to take a look at the value, until policy is
properly initialized.
BUG=1286340
TEST=Ran on DUT.
(cherry picked from commit 238bb6bea188f58523bacc15532c95848afb2387)
Change-Id: Ib2ee4dd18b55431c61b5ac967d437af5e69b32c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412571
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962975}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3422109
Auto-Submit: David McMahon <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#172}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[M99] Remove DCHECK from ContentToVisibleTimeReporter
Partial cherry-pick of https://crrev.com/c/3410578, not including
changes to fieldtrial_testing_config.json and enums.xml that are only
used on the main branch.
Original description:
Remove DCHECK, add TabSwitchMetrics2 to fieldtrial testing config
There is a known issue where ContentToVisibleTimeReporter's TabWasShown
can be called twice without calling TabWasHidden between. The class has
a DCHECK for this, and a workaround that invalidates weakptrs if it
happens in production where the DCHECK is disabled, but the root cause
wasn't known. (The initial investigation of this was in
https://crbug.com/1121339.)
When the TabSwitchMetrics2 feature is enabled, the DCHECK is triggered
by GetDisplayMediaChangeSourceBrowserTest.ChangeSourceReject. This
blocks enabling the feature in fieldtrial_testing_config.json.
The good news is this reveals one cause of issue: TabWasHidden isn't
called when a frame has a visible capturer. Without TabSwitchMetrics2
the DCHECK failure is hidden by another bug that TabSwitchMetrics2 fixes
(TabWasShown not called when the frame has any capturer, hidden or
visible). The bad news is it's not obvious how to fix the issue, which
is filed as https://crbug.com/1289266.
So when TabSwitchMetrics2 is enabled, call the missed TabWasHidden to
clear state and log UMA for an incomplete tab switch, so that when this
occurs in production it's visible in metrics. The DCHECK and weakptr
workaround are left so that behaviour doesn't change when the feature is
disabled.
Also adds TabSwitchMetrics2 to fieldtrial_testing_config.json since the
browsertest no longer DCHECK's.
R=jonross
(cherry picked from commit 2ec267d9c59c86a5a243843631e12b8b6fe3be25)
Bug: 1164477
Change-Id: I99a801c216ed809c5352c1b72ea5d8fd1e9f4def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3410578
Reviewed-by: Jonathan Ross <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Joe Mason <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964195}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428246
Auto-Submit: Joe Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#171}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Start] Polish search box on Start surface.
In this CL, a new task_surface_search_box_layout.xml is added for the
layout of the search box on Start surface. We still use
SearchBoxCoordinator to control the view. We shrink the size of voice
button and lens button to align with the tab switcher button and the
menu icon on the top toolbar.
Before:
https://drive.google.com/file/d/1u45yt-f5Sj6fPSpJFtrTdj9AkW-zGOaZ/view?usp=sharing
After:
https://drive.google.com/file/d/15YpqQojfbQW3KAALByxysczJB_GG_oVM/view?usp=sharing
Bug: 1290360
Change-Id: I43fe43affcfd6404fd6afef8cc6a04f8abbb56f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3416310
Reviewed-by: Hao Dong <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964135}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427579
Cr-Commit-Position: refs/branch-heads/4844@{#170}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Updating XTBs based on .GRDs from branch 4844
Change-Id: I9da45545593193603f2c5937aa3b14be88461cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3429439
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#169}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Update raw_ptr_traits type to DelayTimerBase
TimerBase was split to DelayTimerBase in r959181
So the raw_ptr_traits needs to be updated
(cherry picked from commit 8394708c76611e79528b7d8c67c512366c9b9d46)
Bug: 1287151
Change-Id: Ib89ccfd0e129f86f4c7396c44ed4ebafeaf4903e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3414173
Reviewed-by: Bartek Nowierski <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#962855}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427979
Auto-Submit: Keishi Hattori <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#168}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[m99] Roll ICU to include additional locale data for CrOS
https://chromium.googlesource.com/chromium/deps/icu.git/+log/b9f6d0..609143a
609143a Add Afrikaans and Zulu to ICU on CrOS by mlcui · 2 weeks ago
0881a3c Remove debug logging in make_data_assembly.py by Nico Weber · 2 weeks ago
2c4f807 Add Icelandic to ICU on CrOS by mlcui · 3 weeks ago
aa0b81a Update whitespace in filters JSON by mlcui · 3 weeks ago
(cherry picked from commit 0661be42d9e26a4ecde9149c83adc0dc474c2115)
Bug: 1194261, b:183452275, b:216563898, 1291408
Change-Id: Iff0f86e8dfe48f674166878dcdb634414c2d6fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3417816
Reviewed-by: Jungshik Shin <[email protected]>
Reviewed-by: Michael Cui <[email protected]>
Commit-Queue: Frank Tang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963845}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3421044
Cr-Commit-Position: refs/branch-heads/4844@{#167}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
Fix DCHECK failure on chrome://flags.
The value is recently added by crrev.com/c/3406248.
There is DCHECK asserting the first entry is an empty value in
flags_ui::FlagsState::SanitizeList().
BUG=1286340, 1291483
TEST=Ran locally.
(cherry picked from commit 5713de8abdf386cc765415e8fa119234939107a3)
Change-Id: I28b4409fa7999d59108cc90da6a7f98cfb095869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419540
Auto-Submit: Hidehiko Abe <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#964614}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428400
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#166}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[ios, singlntp] only call ntpDidChangeVisibility: if NTP is active
This change, originally thought unnecessary, is important to accurately
calculate time spent on the NTP.
(cherry picked from commit e7c4adccd3faf6cfbc97f83a2deb6e6155477507)
Bug: 1290625
Change-Id: Ie5f690790d00df9296d8cba38c7a1eff40cc11bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413925
Reviewed-by: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963263}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425439
Auto-Submit: Chris Lu <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4844@{#165}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Subscriptions] Fetch offer id asynchronouly
We need offer id when subscribe/unsubscribe. If we try to fetch offer id
too early (before deferred startup) we may cause jank regressions. This
CL replaces ShoppingPersistedTabData#from(tab) method with the
asynchronous from(tab, callback) method to make sure the fetch process
goes well.
(cherry picked from commit 97a610e0ded55547bb4bbf15b443b35a184b6c3c)
Bug: 1277168
Change-Id: I5e707b28b9e441ec243868e24eb8c13c1b72fbf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3399730
Reviewed-by: David Maunder <[email protected]>
Reviewed-by: Ayman Almadhoun <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#961672}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418061
Cr-Commit-Position: refs/branch-heads/4844@{#164}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
[Subscriptions] Reset storage when user switches account or signs out
(cherry picked from commit 8701b90f08f3def5a03e6587f4b53aca624023bb)
Bug: 1289061
Change-Id: Ic2f0474057870676cac16a70de130c6dc146462c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3404378
Reviewed-by: Ayman Almadhoun <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#963197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418065
Cr-Commit-Position: refs/branch-heads/4844@{#163}
Cr-Branched-From: 007241ce2e6c8e5a7b306cc36c730cd07cd38825-refs/heads/main@{#961656}
