Publish DEPS for 96.0.4664.17
Incrementing VERSION to 96.0.4664.17
Change-Id: I810b153320bab0e99513a7822f8cec72f3230bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233315
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#231}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Web apps: Cease showing "Open in <app>" menu option for browser tab web apps
Browser tabs in the scope of a web app have an "Open in <app>" option
in the browser menu to open the current page in the web app.
"Open in <app>" is also present in the context menu of hypelinks that
target inside a web app scope.
Web apps that are configured to open in a browser tab should not be
shown the "Open in <app>" option as it always opens the page/link in
an app window contrary to the user setting.
(cherry picked from commit 0780d1b52646b51d77d7c1a5d8a483bbb3c63e2d)
Bug: 1258184
Change-Id: Ib81b107bb860793911337f5f5f37ad996c95a16a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225304
Reviewed-by: Filip Gorski <[email protected]>
Reviewed-by: Glen Robertson <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932388}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229405
Cr-Commit-Position: refs/branch-heads/4664@{#230}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][Extensions] Relax a renderer CHECK()
There's a CHECK() in the renderer that running some custom bindings
code returns a function. This *should* always be true, but may not be
if one of two things happened:
- The JS resource is corrupted. We know this can happen, and don't
generally accommodate it, but try to not crash.
- Some untrusted JS ran in the context before our code, and set up
hooks that are interfering with the custom bindings. I'm not sure
if this can easily happen (since this code runs in response to
context creation), but feasibly can in non-service worker contexts,
so may be a risk here, too.
Relax the CHECK() and make it a notreached + return (which we typically
don't like, but here makes sense).
(cherry picked from commit e218debad0faa1ad578112c1428c09dbe955bd02)
Bug: 1260773
Change-Id: I9fb088387251952e8dd88d306b29e23200bfac0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229671
Reviewed-by: Tim Judkins <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932678}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230222
Reviewed-by: David Bertoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#229}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Merge "SVG Text NG: Fix getIntersectionList()" to M96 branch
<text> with SVG Text NG wasn't included in the result of
getIntersectionList().
(cherry picked from commit f0e1e06686bac909bcc8b6b1a26fb8fe32a4b02f)
Bug: 1260438
Change-Id: I09ec6a3fe406510312b417359035d32eb94fc3b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226188
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932430}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230663
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#228}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Return error from PrimaryAccountMutator::SetPrimaryAccount()
Change SetPrimaryAccount() return value from bool to
PrimaryAccountMutator::PrimaryAccountError.
The returned value is used in CHECK() in iOS. Using an error (instead
of a bool) can help understanding why CHECK() fails, see
crbug.com/1256859.
(cherry picked from commit aa4b22c025701a011a5f4566b69e5301bd05f20f)
Bug: 1256859
Fixed: 1258596
Change-Id: I89c8b4c7a610e21f5a0a1f8a514e198ef48b0a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217462
Commit-Queue: Jérôme <[email protected]>
Auto-Submit: Jérôme <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222967
Cr-Commit-Position: refs/branch-heads/4664@{#227}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[lacros skew tests] Refresh skew tests for M94
This CL updates the ash version 94.0.4606.97 for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I01f347aee03819a496b4da93cceb8d052d445af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232480
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#226}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AutoDark] Implement dialog primary CTA
Implement primary CTA for the dialog that appears after N-disables of
the feature through the appmenu item. Uses field trial param to
determine if the primary CTA is entering the feedback flow or opening
theme settings.
(cherry picked from commit 55bdad9610f4bf0fda7fad9bb075b862ba3e567e)
Bug: 1255301
Change-Id: Id6acaef989ce3134d305b58aa85ca13b2c99d5ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207327
Commit-Queue: Neil Coronado <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932693}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231882
Auto-Submit: Neil Coronado <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#225}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96 Merge] WebUI Rebrand: Update card styles
(cherry picked from commit 024634c31d2c40e054112067a2a8b1984fadecc5)
Bug: 1225462
Change-Id: Iccb7053781e2ecec1a1136785e21e3d8fdc45217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212137
Reviewed-by: dpapad <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929765}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232637
Cr-Commit-Position: refs/branch-heads/4664@{#224}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] u2f: unbreak canMakeU2fApiRequest invocations during Chrome OS sign-in
canMakeU2fApiRequest has non-optional args for the tabId and frameId
making the original U2F API request. They are used to determine origin
trial enrollment status and show the deprecation prompt. Cryptotoken's
JS gets these values from the MessageSender object. But they can be
undefined if the request does not come from a tab.
This is the case if U2F API requests are made on the Chrome OS login
screen, as some SAML SSO providers do. In these cases, the
canMakeU2fApiRequest fails outright due to invalid arguments, and
the entire U2F request can't succeed as a result.
To address this, make the corresponding WebRequestSender fields
non-optional, filling dummy values if the original MessageSender values
are undefined. (This is a behavior change that affects things other
than canMakeU2fApiRequestmore, but I convinced myself that this is safe.)
On the browser side, if a request comes from a Chrome OS sign-in
context, immediately resolve canMakeU2fApiRequest with true. (This was
the intended effect of CL:3209886; but that CL by itself was not enough
to unbreak Chrome OS SAML sign-in due to the undefined parameters.)
(cherry picked from commit 26cbbc0155a56cf667d1dc6f89cc5ba02ec32c09)
Bug: 1257293,1224886
Change-Id: Ib3d148d6d8aff66f117661102db48a8181b54931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222182
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931751}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230424
Auto-Submit: Martin Kreichgauer <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#223}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
ExternallyManagedApp Notify on install
ExternallyManagedAppInstallTask::OnWebAppInstalled() now calls
WebAppRegistrar NotifyWebAppInstalledWithOsHooks()
when an app is installed.
Previously, NotifyWebAppInstalledWithOsHooks() would only
be called if a placeholder app was installed.
(cherry picked from commit 039123186801566a7e4de8fb7fd8c107c43c2e87)
Bug: 1260178
Change-Id: I43e961f239637ee850ed651f4c3986469cbadaa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222993
Auto-Submit: Eric Willigers <[email protected]>
Commit-Queue: Glen Robertson <[email protected]>
Reviewed-by: Glen Robertson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931793}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232915
Commit-Queue: Eric Willigers <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#222}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.16
Change-Id: I539a2097baffc5f983580554348efc3ba96704c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232437
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#221}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Power Bookmarks] Fix folder select icon background in dark mode
(cherry picked from commit 57b334f686b53e9a52a7e03ab75a5b2529cdb5af)
Bug: 1260030
Change-Id: If5bac6a0afbc9469bc8fbf9a5c06b3c2af067918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223981
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232469
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#220}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix null pointer crash in RecentTabsManager.calculatePromoState()
The crash is due to mForeignSessions being null in calculatePromoState()
method. mForeignSessions is populated by updateForeignSessions() method.
Moving calculatePromoState() call after updateForeignSessions() call
fixes the crash.
(cherry picked from commit 12a7db85c575d1226777eededf65a33f842e5e7e)
Bug: 1259507
Change-Id: I8c1ec9d2b63189464793281e35f2f5b6a8aa3243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220312
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931929}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232543
Reviewed-by: Prudhvi Kumar Bommana <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Auto-Submit: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#219}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][realbox] Treat suggestion answers as text without HTML markup
The current implementation assumes that suggestion answers contain HTML
markup and accounts for that when generating the a11y label for the
match. This is expensive and may expose security vulnerabilities. This
CL changes that assumption and treats the suggestion answers as text
without HTML markup.
This CL also makes sure that the client-side generated markup for the
match contents is used to render the suggestion answers. Note that the
match contents is a prefix of the answer's first line. Therefore the
match contents markup is applicable to the answer's first line.
For more info see crbug.com/1251541
(cherry picked from commit 10939d3c6653ef2cc8105bb4145db6a876c22e61)
Fixed: 1251541
Change-Id: I7352301c672691dd97681eed480f22f738f21ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218631
Commit-Queue: Moe Ahmadi <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Reviewed-by: dpapad <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930882}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229677
Cr-Commit-Position: refs/branch-heads/4664@{#218}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[CrOS Cellular] Only set AllowRoaming when flag is disabled.
This change updates the code responsible for propagating values for
Device.AllowRoaming and Device.PolicyAllowRoaming such that it only
propagates update values for Device.AllowRoaming when the per-network
cellular roaming feature flag is disabled.
This change was confirmed to fix the associated issue by:
- Disabling the feature flag.
- Allowing/disallowing cellular roaming via policy.
- Removing the pSIM.
- Clearing the Shill cache.
- Enabling the feature flag.
- Inserting the pSIM.
- Checking that cellular roaming enabled state for the pSIM defaulted
to the state from when the feature flag was disabled.
Additionally (eSIM):
- Disabling the feature flag.
- Disallowing cellular roaming via policy.
- Clearing the Shill cache.
- Enabling the feature flag.
- Allowing cellular roaming via policy.
- Installed new eSIM profile.
- Checked that roaming was disabled for new eSIM.
Additionally (powerwash):
- Removing the pSIM.
- Powerwashing the device via admin console.
- Enrolling the device.
- Allowing cellular roaming via policy.
- Inserting the pSIM.
- Checking that roaming was disabled for new pSIM.
(cherry picked from commit aca31f64cccbd2889d54d863586730be73133ac2)
Fixed: 1258227
Test: See above, and stepped through applicable CUJs.
Change-Id: Ifa20c7d8a6a22cfaac90efc29b17cc4d09b18b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222147
Commit-Queue: Chad Duffin <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932583}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230221
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#217}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AutoDark] Record UKM for AutoDark
Record when user disables AutoDark for a specific site through the app
menu item.
UKM Collection Review: http://shortn/_mJBXeVKt0C
(cherry picked from commit 4ec27d7cf2000a250ed5356d4204a620735738c2)
Bug: 1253992
Change-Id: I1897c9f07868fb308691c1fe430533dded7dec24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190919
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229724
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#216}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix Canvas PDF Printing failure for very large/many images
When users tries to draw very large/many images with canvas, it hits
the memory limit for canvas and caused the flush event. As a result,
it caused the printing failure for very large/many images. In this cl,
I disabled the memory check for flushing during printing.
Bug: 1259619
(cherry picked from commit 5864ce3c47bb02c5e223fe6ab28cd8e399ce01f5)
Change-Id: Ia3046020f46d984a5291353718acc15183f55f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225719
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Yi Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932096}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228641
Cr-Commit-Position: refs/branch-heads/4664@{#215}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Reland "[Coupon] Add IsUrlEligible function to CouponService"
This reverts commit 137bd7516b941e58a1e3b9372e111b3a0368ff7a.
Reason for revert: Disable the failing test for now.
Original change's description:
> Revert "[Coupon] Add IsUrlEligible function to CouponService"
>
> This reverts commit 50cd5eb0e706beba9d18b935e2cdea08bb84ae81.
>
> Reason for revert: New test is failing on bots;
> The PromoCodeOffer_FromCouponService test is failing on Lacros bots here:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/15759/overview
>
>
> Original change's description:
> > [Coupon] Add IsUrlEligible function to CouponService
> >
> > This CL adds IsIsUrlEligible to CouponService and expose it to
> > AutofillOfferManager to check eligibility for a URL in CouponService.
> > After this CL, the basic wiring for supporting FreeListing coupons
> > to show in infobar bubble is finished, and a browser test is added
> > to verify this.
> >
> > Bug: 1248524
> > Change-Id: Ic32f5311d9d77b79b1ad98beec36bf8b8fadf257
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209127
> > Reviewed-by: Jared Saul <[email protected]>
> > Reviewed-by: Caroline Rising <[email protected]>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
> > Commit-Queue: Yue Zhang <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#929309}
>
> Bug: 1248524, 1257777
> Change-Id: Ia3730ac97ab04ab65d45084b3e4c54a9887fa1b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212218
> Auto-Submit: Ian Clelland <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Ian Clelland <[email protected]>
> Owners-Override: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929395}
(cherry picked from commit 222597e7e23cd178697e9d05cd788337c7338bf0)
Bug: 1248524, 1257777
Change-Id: Ic865851e525df4e4a60b0f02f01df72724761c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213308
Reviewed-by: Caroline Rising <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929775}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229528
Cr-Commit-Position: refs/branch-heads/4664@{#214}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[GMNext][M96] Fix the touch target size for tab action button
Increase the button size and reduce the margin.
Screenshot from AS layout inspector:
https://screenshot.googleplex.com/8zgrjRfiSoDhUGU
Also includes the bug fix for the selectable button size from
crrev.com/c/3227693. (Diff: patchset#1 -> #2)
(cherry picked from commit da8489d1963ebb7d6ac7791fde3a7e1fe25fdabc)
Bug: 1258819, 1260486
Change-Id: Ie9e49e8c7b115f2f4653a0d67ddd7abf472786c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219580
Auto-Submit: Wenyu Fu <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931383}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230223
Cr-Commit-Position: refs/branch-heads/4664@{#213}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] u2f: Correctly attribute U2fSecurityKeyApi Origin Trial to iframes
Cryptotoken has historically allowed requests from cross-origin iframes.
But effects of the U2fSecurityKeyApi Origin Trial are, in some places,
only checked for the main frame. Specifically, the check to enable the
API was applied correctly on the frame that presents the trial token.
But in order to check whether the deprecation prompt should be
suppressed, browser-side cryptotoken code looked for a trial token on
the main frame. Hence the prompt wasn't suppresed if a child frame was
presenting the token.
Fix this by passing the sender frame ID in the canMakeU2fApiRequest
private API method and checking for tokens on the corresponding frame.
Also add a number of browser tests that assert whether the prompt is
shown in various configurations.
(cherry picked from commit 90aa90d887c1376ce222dd2835940031b29480e9)
Change-Id: I86b659ffc349c8a6494e91c81baf09a9a39cbf0f
Bug: 1258828,1224886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3215977
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930866}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224194
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#212}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[m96 merge] gpu: Check for D3D device before creating D3D backing factory
Using the backing factory without a D3D device causes crashes in the new
shared memory GMB path added for two copy canvas capture.
(cherry picked from commit 80c5d6d97f4863ba7cdf7e580c849d748a49f725)
Bug: 1259056
Change-Id: I209ee3c67487acf4440f0cc79cd03a32b53f146d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224235
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Auto-Submit: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229979
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#211}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.15
Change-Id: Ibf0f20f7f9ab72f683f2b601ffdd145507c3ce8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226987
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#210}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge][Android] Add max height to Modal Dialog
This CL adds a max height of 560dp to the ModalDialogs. This is inline
with the scaling and adaption Material guidelines[1] which specify a
maximum width and height of 560dp.
Changing the maximum height of ModalDialogs requires setting a new
baseline for all Skia Gold images in ModalDialogViewRenderTest. This
CL sets the revision for that test to 1.
[1] https://material.io/components/dialogs#behavior
(cherry picked from commit 3db199f899277e9dee762950d5074e02135aa249)
Bug: 1252548
Change-Id: Iab144f0c0661120f5ad919e798cc5c902a64a60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191673
Commit-Queue: Trevor Perrier <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931144}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229967
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Trevor Perrier <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#209}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Add ukm data to help with training ML models in the backend for permission predictions.
Added the following ukm metrics:
1. What % of prompts from the last 28 days did the user grant/deny/dismiss/ignore on average across all origins and permission types; and on average across all origins for the currently requested Permission type. Each rounded to the nearest 10%.
2. The total number of prompts across all origins and permission types, and across all origins for the currently requested Permission type seen by the user in the last 28 days. Exponentially bucketed.
Approval doc - go/permissions-crowd-consent-ukm
(cherry picked from commit 0dc2647458ec89a96f01265d39b6b30f8b41be11)
Bug: 1251602
Change-Id: I117ff4fbfd821bf050cfaa39351b644bc0beb9a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168882
Commit-Queue: Ravjit Singh Uppal <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931963}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226412
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Brian White <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#208}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Remove the use_gitiles_trigger experiment.
The codepath that was controlled by this experiment is now enabled
unconditionally.
(cherry picked from commit 79ff742c322381530db865e81f94545b143f55f0)
Bug: 1249938
Change-Id: Ie9ed1ac3f55e70b58b02ffbe385a06b1d3d8f405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230173
Auto-Submit: Garrett Beaty <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932726}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229840
Cr-Commit-Position: refs/branch-heads/4664@{#207}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Revert "Remove shutdown_delay_ref_count_ check from RPHI::FastShutdownIfPossible()."
This reverts commit bf4b32744df3cfb5115bbfaa4ebc785e3ca79256.
Reason for revert: speculative fix for https://crbug.com/1255268
Original change's description:
> Remove shutdown_delay_ref_count_ check from RPHI::FastShutdownIfPossible().
>
> Removing the check on shutdown_delay_ref_count_ from
> FastShutdownIfPossible(). In
> https://chromium-review.googlesource.com/c/chromium/src/+/3133707/
> we left it in to avoid any behavioral change in that CL, but
> it doesn't seem like it should be included as a check, so removing it
> here.
>
> Bug: 1148542
> Change-Id: I9552461354c2ac19dfce9cb2e7161c241aa3fd38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150110
> Commit-Queue: W. James MacLean <[email protected]>
> Reviewed-by: Alex Moshchuk <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#919447}
(cherry picked from commit 487400cac80bedbc3816b125f54d28d7e220efb6)
Bug: 1148542, 1255268
Change-Id: I76d1857bf95a5ad83a2a1ab1a8c261964f651c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216954
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Auto-Submit: W. James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930928}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228502
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#206}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge 96][VCN] Update virtual card manual fallback bubble texts
Updated title and the body label
Screenshot in bug comment #25
(cherry picked from commit a1cbdba13e30dabb5cc759c343e4db5d8f4b22a0)
Bug: 1259290
Change-Id: I36b2d7d7e6e1a3688e299ab9b9a71a6b88cc9769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214448
Commit-Queue: Siyu An <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229672
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#205}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.14
Change-Id: I3f05700a9177ceabda066a0220bac1521298c4c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227088
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#204}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AutoDark] Record SettingsChangeSource to correct histogram
Record SettingsChangeSource to correct histogram. Prefix should be
Android.DarkTheme.AutoDarkMode. not Android.DarkTheme.AutoDark.
(cherry picked from commit 9056bb2ded413a8344835d182d05213450d42d6c)
Bug: 1259305
Change-Id: I163ab856c1587aa4cba97d65ef96e8b1da18cb8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219516
Reviewed-by: Wenyu Fu <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930826}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229702
Auto-Submit: Neil Coronado <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#203}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Sheriff: Disable flaky test.
(cherry picked from commit 9d0249c72304a35a5594eaa6311e0155f0271c7a)
Change-Id: I66d5a4c1b4434db2270c6b30e4ffd6c6e3468962
Bug: 1257990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211627
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Owners-Override: Joshua Pawlicki <[email protected]>
Auto-Submit: Joshua Pawlicki <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230164
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#202}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[VirtualCards] Add JNI glue to authenticator selection dialog
(cherry picked from commit 35e14e1431873c2533dfdfb9169d92a85203a981)
Bug: 1260027
Change-Id: I3d59ceed76d30e2d6ba1517727bba4c56b07c261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192612
Commit-Queue: Kyle Zhou <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Elizabeth Popova <[email protected]>
Reviewed-by: Siddharth Shah <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931579}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227711
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Kyle Zhou <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#201}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Sheriff: Disable flaky test.
(cherry picked from commit f3febfab4a39a769b1f1b9712cbce2fe1f59d4b5)
Bug: 1258062
Change-Id: Ibe308ad369698525165f05688acd27cf43b3040f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214450
Owners-Override: Joshua Pawlicki <[email protected]>
Auto-Submit: Joshua Pawlicki <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929738}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229538
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#200}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Revert "Diagnostics: Enable networking in the Diagnostics App by default"
This reverts commit 6aeba5dc01aabad8d1e1f6fc4fcc8df4faef7b9f.
Reason for revert: Disable network diagnostics in M96 since it's being postponed to M97
Original change's description:
> Diagnostics: Enable networking in the Diagnostics App by default
>
> Flags enabled:
> - #diagnostics-app-navigation
> - #enable-networking-in-diagnostics-app
>
> - This change also updates the error page browser tests now that the
> flags are enabled by default.
>
> Bug: 1197335
> Change-Id: Ieabe87f0f643a7a20d152590997469a0d9f77087
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206091
> Commit-Queue: Michael Checo <[email protected]>
> Reviewed-by: Maksim Orlovich <[email protected]>
> Reviewed-by: Zentaro Kavanagh <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929385}
(cherry picked from commit e5dbd6946707f7eb1473c2377702b010f5a297e2)
Bug: 1259768
Change-Id: I7b5c5b0e9048dffe4020c921c760199cab3bb206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221441
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Zentaro Kavanagh <[email protected]>
Reviewed-by: Maksim Orlovich <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931294}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229539
Cr-Commit-Position: refs/branch-heads/4664@{#199}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Re-enable U2F deprecation prompt on ChromeOS
This enables the U2F deprecation prompt on for ChromeOS, except for
requests occurring in profiles that are not "regular", which includes
the SAML sign-in contexts that caused us to disable the prompt in
CL:3202571.
CL:3205644 already re-enabled the prompt for all other desktop OSes.
(cherry picked from commit fb3428dc652ee25b2663c89169228513024b17a5)
Bug: 1257293,1224886
Change-Id: I72c955c202fdd752cf2b4ce35bb0194838b2a9e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209886
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229679
Auto-Submit: Martin Kreichgauer <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#198}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Don't Record Timezone with Log Creation Timestamp
Only record timezone with log closing timestamp.
Apparently getting the timezone is expensive.
This reduces the number of timezone fetching calls.
Probably having the time zone come somewhere in the record,
even if it only appears in the closing timestamp and not
the creation timestamp, will still be useful.
(cherry picked from commit 416a6b24a7385ef6c4ae9d272d8ae9b88f1542c6)
Bug: 1258850,611137
Change-Id: Ic79fdda315a207e56d65f0f5223d1d4e71a20a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219843
Commit-Queue: Mark Pearson <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931306}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229862
Auto-Submit: Mark Pearson <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#197}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Revert "[Extensions] Replace NOTIFICATION_EXTENSION_REMOVED in ExternalInstallManager"
This reverts commit e7c77a1de6301faed4fd8fc3e82203e7516abe19.
Reason for revert: Likely caused crbug.com/1259043
Original change's description:
> [Extensions] Replace NOTIFICATION_EXTENSION_REMOVED in ExternalInstallManager
>
> NOTIFICATION_EXTENSION_REMOVED has issues:
> - It's deprecated (all legacy NOTIFICATION_-style events are)
> - It's unpredictable: it can be fired either when an extension is
> unloaded (which can happen for any number of reasons) *or* as part of
> uninstallation for crashed extensions (but not other extensions).
>
> ExternalInstallManager uses the notification to check if the removed
> extension was related to any of the active external install warnings
> shown to the user, and remove that warning if so. ExternalInstallManager
> also already observes ExtensionRegistryObserver::OnExtensionUninstalled,
> which is sufficient for this use. Move the handling to remove the error
> for the uninstalled extension to OnExtensionUninstalled, and stop
> listening for NOTIFICATION_EXTENSION_REMOVED.
>
> Code History:
> Why did the class observe these two methods? It originally observed
> NOTIFICATION_EXTENSION_REMOVED because it didn't listen for
> OnExtensionUninstalled. It at one point was going to listen for
> OnExtensionUnloaded, but that was insufficient (because disabled
> extensions were already unloaded), so it relied on the old notification.
> This was done in https://codereview.chromium.org/300853008/.
>
> Then, the class was refactored to pull in more logic from
> ExtensionService, and it began listening to OnExtensionUninstalled in
> https://codereview.chromium.org/308473002. The naive Chromium developer*
> who made those changes didn't realize that the notification could now be
> cleaned up, and it subsequently listened to both.
>
> *It was me.
>
> Bug: 1174736
> Change-Id: I5c83b19e90e913b33deedf3104ea179296f1c79f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209807
> Reviewed-by: Tim Judkins <[email protected]>
> Commit-Queue: Devlin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#928972}
(cherry picked from commit 24d5fcd24471442ac2717092f7c5d754e2adfb22)
Bug: 1174736
Change-Id: I148600f71a9e36db70794d89204849cd4e1a6287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219344
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930660}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229678
Reviewed-by: Tim Judkins <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#196}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Record a set of pseudo metrics for data validation
Add a set of UMA.Pseudo{Metrics} which are recorded alongside with their
mirrored histograms. The sample values of these metrics equal to the
values of the real metrics multiplied by a factor that is controlled by
a field trial experiment.
This is used for data validation. It's not meant to measure any state of
our clients and shouldn't have impact on them.
(cherry picked from commit ef3dd1af677e65e426b2df90c2715ce338e92353)
Bug: 1257484
Change-Id: I59206324249cadc3e547cd1dcffa74f9d5ec7710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211366
Reviewed-by: Annie Sullivan <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Weilun Shi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931243}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229460
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#195}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
WebAppUiManagerImpl: Register URLDataSource immediately
We avoid the possibility of flakes in
ChromeURLDataManagerWebUITrustedTypesTest.NoTrustedTypesViolation/chrome___web_app_internals
if there is a delay in the web app database being loaded.
The source for chrome://web-app-internals now registers immediately.
The implementation in WebAppInternalsSource waits for the web app system
to signal it is ready.
(cherry picked from commit b06047ed9f8ef2f965e3f2416093b298a5593c29)
Bug: 1257413
Change-Id: I0e2fd3c6d9d5d53e3ff07d9dc1f6bace2f6915af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223079
Auto-Submit: Eric Willigers <[email protected]>
Reviewed-by: Alan Cutter <[email protected]>
Commit-Queue: Eric Willigers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931876}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229825
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#194}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][unseasoned-pdf] Hook up find-in-page tickmarks display via pdf.mojom.
When the PPAPI-free PDF Viewer performs a find-in-page operation, the
tickmarks should be displayed. To make this work:
1) Add pdf::mojom::PdfFindInPage interface for PDF renderer to PDF
extension communication to set the tickmarks.
2) Add GetPdfFindInPage() to the existing pdf::mojom::PdfService
interface. This lets the PDF renderer use an existing interface to
request the new interface.
3) Add pdf::mojom::PdfFindInPageFactory interface, so the browser's
PdfService can talk to the PDF extension to hook up PdfFindInPage.
4) Implement PdfFindInPageFactory, which has an inner class that
implements PdfFindInPage to display the tickmarks.
(cherry picked from commit 3946042f403f833403c6f82e1d4f3209e0528e4d)
Bug: 1199999
Change-Id: I91482aa6b08f46495b83ae29d3878de6e1fcdfa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206526
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Daniel Hosseinian <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929534}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229535
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Auto-Submit: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#193}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96 merge][VCN] Wireup progress dialog with backend
(cherry picked from commit 23c4c16f9933c56bedf9ce56ff8a55cb1413c62f)
Bug: 1260123
Change-Id: I09dd5bcceb136c70937183e3ceccdd02daf47b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209681
Commit-Queue: Siyu An <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Siddharth Shah <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227183
Auto-Submit: Siyu An <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#192}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Power Bookmarks] Put the bookmarks visual refresh behind a param
This allows separate testing of the visual refresh and the app menu
changes.
(cherry picked from commit f203eee36e0ec71afe8541773a05867c24710db9)
Bug: 1241509
Change-Id: Ia73012d3bd1bffc2d353830a7552e1ba2e19e72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212871
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: bttk <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930303}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229804
Cr-Commit-Position: refs/branch-heads/4664@{#191}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[VCN] Enable feature on ToT
(cherry picked from commit 82c9e5f95e03c76ba5ba66a827fb1aa5f5522361)
Bug: 1259736
Change-Id: I3e644043fbb25fb6f726a6fbf64e2e488cbdd4b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152295
Commit-Queue: Siyu An <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Siddharth Shah <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223515
Auto-Submit: Siyu An <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#190}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[omnibox] Apply various changes to pedals batch3 after UI review
This CL updates various UI strings, icons, and trigger data for
some batch3 pedals. The changes came from UI review and are intended
to make the interaction experience clearer for users.
(cherry picked from commit fbc710b0a927d6009b56e647c1a8d2acf990ea5e)
Bug: 1260050
Skip-Translation-Screenshots-Check: True
Change-Id: Ieb9fefecdb307fc8c31a89889b9cf615233bb294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224233
Commit-Queue: Orin Jaworski <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228501
Auto-Submit: Orin Jaworski <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#189}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
FSA: Do not assume Value is a dict
The Value schema was changed in https://crrev.com/c/2645845 and the
migration logic was removed in https://crrev.com/c/3067252.
However, we should gracefully handle values from the old schema.
(cherry picked from commit cd60fff54cf3b09a699d924a2db52950ea1b4472)
Bug: 1259941
Change-Id: I99091e6c1759a212c8d698d2c1409f11a1219cb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224184
Commit-Queue: Austin Sullivan <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Auto-Submit: Austin Sullivan <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931700}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222865
Cr-Commit-Position: refs/branch-heads/4664@{#188}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
ElementTrackerMac - Remove spurious DCHECK
There are cases where a menu can be aborted before the initial show
message is processed; in this case we have to skip processing any
show/hide messages because we can't connect the menu item to the context
anymore.
Bug: 1253603
(cherry picked from commit 9399a85d6d07cd2e486a9c0022ab27fb94ab5dbd)
Change-Id: I2fb9125dab9cb0cfc2a3f2de77464327f74945c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3161409
Reviewed-by: David Pennington <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930350}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229810
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#187}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][unseasoned-pdf] Extend GetPdfElement() support for printing
Extend GetPdfElement() support to find the PDF object element in the
unseasoned PDF frame.
When printing the Unseasoned PDF viewer using browser commands, the
correct render frame is targeted as of crrev.com/928893. However, within
that render frame, the correct element isn't always targeted if the PDF
plugin doesn't hold focus.
(cherry picked from commit 742df8e18c86b7c772dcd3203cba9afb0e976e53)
Fixed: 1246187
Change-Id: Ib52dded62721f3e19a9dedd95d3e2cddb8e7fad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214635
Commit-Queue: Daniel Hosseinian <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929931}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229701
Auto-Submit: Daniel Hosseinian <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#186}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[VirtualCards] Add JNI glue for the OTP verification dialog
(cherry picked from commit 0ee248ea8ae012925f3c91738b6c33101b85bfa0)
Bug: 1260540
Change-Id: I945c4c46a0951628ca318a588f19f4a501b46f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205984
Commit-Queue: Siddharth Shah <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elizabeth Popova <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931160}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229821
Auto-Submit: Siddharth Shah <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#185}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[ntp][modules][photos] Fix typo in histogram logging
(cherry picked from commit 6443351df55f30b8a178611c56ff66f99297dee1)
Bug: 1260229
Change-Id: I0a91b2b72a1abf3d5d2348377b303d0e29b95c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224801
Commit-Queue: Jeremy Selier <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Jeremy Selier <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931855}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229459
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#184}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge M96] [tracing] Force a packet past-the-end of "File" async events.
Same as https://chromium-review.googlesource.com/c/chromium/src/+/3064300
but for async "File" events. Since this is an async event, there's no
higher level event englobing multiple File events like a running
thread did for tasks, so we have to emit it for each one here.
See https://crbug.com/1021571#c28 for screenshot of issue.
FileTracingProviderImpl::FileTracingDisable() called from
FileTracing::~ScopedEnabler() marks the end of the top-level events
on that async track.
(cherry picked from commit 4140559dc88697a6c05a3a612b0775ff5f243ae1)
Bug: 1021571
Change-Id: I92b0ed4629bf8d5159af19d1c2902ca45db04f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212886
Commit-Queue: Eric Seckler <[email protected]>
Auto-Submit: Gabriel Charette <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929664}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228474
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#183}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
M96: Revert "OOBE - Polymer3 Migration - EULA Screen"
This reverts commit 42952ffe415cc8ae3210ded167638ea5dba04b04.
Reason for revert: Breaks chromeos betty arc (https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-arc-r-chrome/9449)
Original change's description:
> OOBE - Polymer3 Migration - EULA Screen
>
> Migrate the EULA screen to ES6 class syntax and add
> directives to generate its modularised version.
>
> Bug: 1184731, 1252778
> Change-Id: Ifbfa03a0f76f33f4bbe3ffc3cee323166e635f2e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205362
> Commit-Queue: Renato Silva <[email protected]>
> Reviewed-by: Roman Sorokin [CET] <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929321}
(cherry picked from commit 034d40f1a06f645d25fe9c19603c148ceba5959d)
Bug: 1184731, 1252778, b/202871324
Change-Id: Id22af570acaa272c688ca67e0ff0b395d17c957d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212619
Auto-Submit: Joshua Pawlicki <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Owners-Override: Joshua Pawlicki <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929682}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227441
Commit-Queue: Renato Silva <[email protected]>
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#182}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Start] Set toolbar phone layout Gone instead of Invisible.
(cherry picked from commit 81193ea46bae03f825b59364551dcf7ce1bd688e)
Bug: 1251977
Change-Id: Ia0644953b216702780aaf1077f492bd80c82d988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214951
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Matt Jones <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932028}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225867
Cr-Commit-Position: refs/branch-heads/4664@{#181}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Use chrome-untrusted: for Print Preview content
Requests Print Preview content from chrome-untrusted://print, rather
than chrome://print. This improves the isolation of Print Preview
content, especially for the Pepper-free PDF plugin.
This doesn't work with Pepper due to the way subresource loaders are
configured for WebUI pages, so the Pepper PDF plugin will rewrite
requests to chrome-untrusted://print to use chrome://print instead; see
chrome_pdf::OutOfProcessInstance::RewriteRequestUrl() for details.
(cherry picked from commit ce0deb41c7de72d8b90ed764f5ad4be1a205a1fe)
Fixed: 1259185
Change-Id: I361611a5c0bc0116a240318d5717e5c2fced1bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223504
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931731}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224334
Cr-Commit-Position: refs/branch-heads/4664@{#180}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Start] Show non-incognito homepage when clicking back button on incognito tabs.
Before, on Start surface homepage -> open a tab in incognito mode ->
go to incognito grid tab switcher surface -> click that tab from gts ->
click back button, incognito Start surface will show.
This CL stops showing incognito start surface homepage when clicking
back button on incognito tabs.
If this incognito tab was opened from the non-incognito homepage,
clicking back button leads to non-incognito homepage and this tab is
closed; otherwise close the tab and stop chrome.
Video:
https://drive.google.com/file/d/1eQqZ-xH7anoLFAlLLHwbUaRSA31fgqB3/view?usp=sharing&resourcekey=0-0lbxjulcfXunkL4xGA79aQ
(cherry picked from commit 45fccf9d3f13a3dc40873cf2e7ddeba50303005c)
Bug: 1259081
Change-Id: Ib63fff1d02f6696a61891dd6449012e0c7a5d027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217678
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932000}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228634
Cr-Commit-Position: refs/branch-heads/4664@{#179}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Browser scheduling] Control startup tab preloading via its own feature
The kPrioritizeBootstrapTasks feature has 3 effects:
(1) It causes the C++ bootstrap task queue to be prioritized
- This queue is used in browser_main_loop.cc for the tasks that
are posted to StartupTaskRunner there
- This queue is also used for Java tasks that are posted with
UiThreadTaskTraits.BOOTSTRAP and are run after native has been
initialized
(2) It causes Java tasks posted with UiThreadTaskTraits.BOOTSTRAP
before native is initialized to be posted at the front of the
queue in the underlying Looper (via Handler), rather than the
default behavior of being posted at the back of the queue. This
is done by setting SingleThreadTaskRunnerImpl.java's
postTaskAtFrontOfQueue to true when the BOOTSTRAP task type is
set and the kPrioritizeBootstrapTasks feature is enabled
(3) It causes StartupTabPreloader to load tabs (otherwise it
short-circuits out).
- Note: This is totally independent from the other optimizations.
We wish to evaluate the impact of each of these optimizations
independently (see the bug for details). To that end, this CL splits
out (3) into being controlled by a separate feature that is exposed to
Java and cached to be available in pre-native startup, as the
kPrioritizeBootstrapTasks feature is. To ease evaluation of the impact
of turning off preloading of tabs at startup, we make the semantics of
the new feature such that it elides this preloading. The feature
defaults to disabled to preserve the current default behavior of doing
such preloading (i.e., this CL does not change production behavior).
A followup change will split (1) and (2) into being controlled by two
separate features.
(cherry picked from commit 7323c5a7a8103a77cb869637b778598ea5b0cded)
Bug: 1258621
Change-Id: I68719b3ae260292a2bc35b1044dcbf95503a838c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217649
Commit-Queue: Colin Blundell <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932068}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226369
Cr-Commit-Position: refs/branch-heads/4664@{#178}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix showing chooser dialog for specialized http/s URLs
https://chromium-review.googlesource.com/c/chromium/src/+/3198743
erroneously caused a chooser dialog to show up for URLs to apps with
specialized handlers that are not browsers (eg youtube). If an app with
a specialized handler can handle the outgoing navigation, treat it as
not targeting browsers even if a browser could also handle the URL.
(cherry picked from commit ecc68ebbf012d1a9cf88d32c7586292fa9717401)
Bug: 1249962
Change-Id: I00decb18492b989142e5c8cc229537ff0f4b5d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225421
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932010}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228635
Commit-Queue: Yaron Friedman <[email protected]>
Auto-Submit: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#177}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I53d03e14e660290713af31e31457b3680d3fd45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227341
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#176}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Deflaky a css-paint-api/ layout test
The root cause of the flakiness is that the layout test has a
text editing field, and at the end of the test when capturing
screenshot, the cursor is at the text field, and the cursor
will blink. So when the screenshot is captured, the cursor
may or may not show up in the result, which makes it flaky.
The solution to this is simple, simply adding a new
"selectAll" command at the end of the test such that the
cursor no longer stays at the text editing field.
I have tried this test locally, without this CL, it fails
about 50 out of 100 runs, and with this CL there is no
failure.
(cherry picked from commit 34e58741ee1dec00894192ed7fc41247c361c61a)
Bug: 1259804
Change-Id: I795a7c9205cd777bf2a0545262824bc87c901dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225904
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932139}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228473
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#175}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[VirtualCards] Dismiss progress dialog after confirmation
(cherry picked from commit 612f3f62d23069f483294ef387180c7da06ba0a5)
Bug: 1259702
Change-Id: I483b114f561a7f9f1cb74a4b46f4000bff0e40aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214443
Commit-Queue: Siddharth Shah <[email protected]>
Reviewed-by: Matthias Körber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931134}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224320
Auto-Submit: Siddharth Shah <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Matthias Körber <[email protected]>
Reviewed-by: Elizabeth Popova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#174}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Browser scheduler] Give Java BOOTSTRAP tasks USER_BLOCKING priority
In Java, tasks of type BOOTSTRAP currently have USER_VISIBLE priority,
whereas C++ tasks of type BOOTSTRAP have the default USER_BLOCKING
priority. This doesn't matter in the current implementation, as these
tasks are executed on a dedicated queue and their priority is ignored.
However, I'm shortly going to do an experiment to evaluate the benefits
of having this dedicated queue. To enable the experiment, this CL
changes Java tasks of type BOOTSTRAP to have USER_BLOCKING priority in
order to match their C++ counterparts. In particular, this change
ensures that bootstrap tasks are ordered correctly across Java and C++
when using the default priority-based ordering rather than a dedicated
queue.
To emphasize, this change is a no-op in the current production
implementation.
(cherry picked from commit 92b74dcece85a1f1c5d9d0140c7e8b7cfcaea427)
Bug: 1258621
Change-Id: I63f0217a5089e25b36be342eae2a16f10efa979a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217639
Commit-Queue: Colin Blundell <[email protected]>
Auto-Submit: Colin Blundell <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930472}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225938
Cr-Commit-Position: refs/branch-heads/4664@{#173}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge 96] Clear on Exit & Sync: Add metrics for COE & Sync events
Adds metrics for a set of events which relate to Sync, the sync paused
state, and the users clear on exit setting.
These metrics are recorded by the PrivacyMetricsService, which is
extended to observe the SyncService & IdentityManager so it is informed
of relevant changes.
(cherry picked from commit a7b1e1978f1a83f04983b786961897d66fe45042)
Bug: 1257959
Change-Id: I38454ec490a2e0d127aee2a9760aca9c8d858b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212196
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Rushan Suleymanov <[email protected]>
Reviewed-by: Sean Harrison <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931445}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226160
Cr-Commit-Position: refs/branch-heads/4664@{#172}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Check kPasswordsAccountStorageRevisedOptInFlow flag slightly earlier
In GetDefaultPasswordStore(), the value of the
kPasswordsAccountStorageRevisedOptInFlow flag is needed only if the
default store isn't explicitly set yet, and before this CL, that's
exactly when the flag was checked.
However, there's a slight difference between the experiment groups in
how often an explicit value is set for the default store. This was
causing some imbalance between the groups.
This CL fixes the issue by checking the feature flag slightly earlier,
before checking whether a default password store is set.
(cherry picked from commit 98ffc97ef08d3e58ab4cee58794f9d776ed9857e)
Bug: 1237836
Change-Id: Iaf8f976c99bacdb2d558f79bfbb81b200b1554b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218156
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930513}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229262
Auto-Submit: Marc Treib <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#171}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Browser scheduler] Make Java DEFAULT task priority parameterizable
This CL adds the ability to give Java tasks posted with
UiThreadTaskTraits.DEFAULT traits USER_BLOCKING priority rather than
USER_VISIBLE priority. The code invoking this change is controlled by
a base::Feature that defaults to off, preserving current behavior. The
goal is to evaluate the performance impact of having such tasks execute
with USER_BLOCKING priority, as C++ UI thread tasks do by default.
The feature added is cached in Java, as the change needs to be executed
before native initialization to realize the full performance impact.
Specifically, the change has two behavioral consequences:
- Such Java tasks that are run *before* native initialization will have
a higher thread priority
- Such Java tasks that are run *after* native initialization will be run
with USER_BLOCKING priority by the C++ scheduler
Implementation note: To do this I needed to expose a way to mutate the
priority of a TaskTraits object, since UiThreadTaskTraits.DEFAULT is
marked final and hence could not be reassigned to. As it seems
intentional that mutation of a TaskTraits object's priority is
currently *not* exposed, I added a very specifically-named method that
could not be mistaken for being general-purpose.
(cherry picked from commit e598b83d0b1cbae81b82d3334808c825b43b6dc1)
Bug: 1259560
Change-Id: Ia2f91c249b4eaee099caa2a14ec51b167b17076e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217998
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931937}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229265
Cr-Commit-Position: refs/branch-heads/4664@{#170}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix Use-After-Free in ForceSigninVerifier
See https://crbug.com/1259864 for details about the crash.
(cherry picked from commit 79772972a0d41572db52073e310711b5b2cac23f)
Fixed: 1259864
Change-Id: Ibb959201e948e11c752b95b5e1d0a1e9396f2248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226161
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#932072}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229263
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: David Roger <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#169}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[iOS] AuthenticationService needs to skip sync consent if already set
When sync is disabled by enterprise policy, the sync consent is not
removed.
Once the enterprise policy is removed, to turn sync back on,
AuthenticationService needs to skip the sync consent if it is already
set in order turn on sync.
(cherry picked from commit a4e6a243909ca21bf67a1600918e789fcaee7d8f)
Fixed: 1256791
Change-Id: I7152272b1c0204e8857f29245e7d6b8849973878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220478
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Commit-Queue: Jérôme <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226067
Auto-Submit: Jérôme <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#168}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Reland "ime: Confirm composition when a key is not handled by the IME."
This is a reland of f18a0d50b29cff031bd67357fc2c2b077cdda40b
CHANGES SINCE ORIGINAL: We now exclude modifier keys from this
behaviour. Verified by running Japanese Tast tests.
Original change's description:
> ime: Confirm composition when a key is not handled by the IME.
>
> Our IMEs used to rely on the surrounding text to determine whether to
> confirm the composition or not (e.g. if the user moves the cursor
> unexpectedly with arrow keys). However, surrounding text is not reliable
> for a lot of apps, and other platforms don't seem to use surrounding
> text.
>
> The OS already confirms the composition when the user moves the cursor
> by mouse/touch, so we just need to consider keys that could move the
> cursor. Instead of trying to figure out which keys can move the cursor
> and which can't, which is impossible to determine because different
> apps may handle keys differently, we simply confirm the composition
> whenever the user presses a key that is not handled by the IME.
>
> Bug: 1257847
> Change-Id: Ie9a1f4e49da8b5ec08fa7531f3db11a021d15d85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218921
> Reviewed-by: Keith Lee <[email protected]>
> Commit-Queue: Darren Shen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#930946}
(cherry picked from commit 463ca9a9155d5f1589247ea9f91f4c8b696fd796)
Bug: 1257847
Change-Id: Iadefe1ed3aafe84dfa5686d68870efb395f898db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220833
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: Keith Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931742}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226289
Auto-Submit: Darren Shen <[email protected]>
Reviewed-by: John Palmer <[email protected]>
Commit-Queue: John Palmer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#167}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][unseasoned-pdf] Fix PDF rotation from the context menu.
When Pepper-free PDF viewer is enabled, opening a context menu from
a PDF plugin area and choosing "rotate clockwise" or
"rotate counterclockwise" will fail to rotate the PDF. This issue can
happen for both top-level PDFs and the PDFs embedded in a web page.
This is because the a PDF plugin is no longer directly embedded in its
extension main frame. Instead, it's loaded in a subframe which is
embedded inside the extension main frame.
This CL detects whether the PDF plugin is loaded in such subframe so
that the plugin actions can be triggered from this subframe instead of
the main frame of the extension.
Since PDF plugin actions can be triggered from both `LocalMainFrame` and
`LocalFrame`, this CL removes the IsMainFrame() checks in
LocalFrameMojoHandler accordingly.
(cherry picked from commit ea0ea27fc53804b2c500fbbef6cc0dea6b8014c5)
Bug: 1238141
Change-Id: I07265e53b5c62e9236e70893de3d8d62c52b4311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180040
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Hui Yingst <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929742}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227523
Commit-Queue: Lei Zhang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#166}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: Ia51693c85125c609221f1015431ca03555017784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228461
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#165}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.13
Change-Id: I2d6104ce952e9df4504cdbe8b7c2e4f5868466b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228843
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#164}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][unseasoned-pdf] Print the correct RenderFrameHost using one WebContents
GetRenderFrameHostToUse() took two WebContents to apply its heuristics
for printing the right RenderFrameHost. The function assumed the
WebContents to use were that of a full page plugin if and only if it was
different than the "owning" WebContents.
That logic was faulty when the "owning" WebContents was that of a full
page plugin already, which is possible when the print operation is
targeted to the plugin's WebContents from the context menu.
Instead, directly check whether the WebContents to use is a full page
plugin, and dispose of the need to check using the "owning" WebContents.
(cherry picked from commit df5669fc540318935125150a0f3decb18124c2b4)
Fixed: 1259307
Change-Id: I36ee95f2385a457e18db43a24f853f9fd1bdbc1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219937
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Daniel Hosseinian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931850}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227066
Auto-Submit: Daniel Hosseinian <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#163}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[App Management] Add a / between host and path of supported links.
Add a "/" between the host and the path when displaying a list of
supported links.
(cherry picked from commit 440c642e78494d7f9c4ac497e09bb04b4b360b0d)
Bug: 1250180
Change-Id: If50ba7febf13cec1a6718175612d5d111732903d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218802
Commit-Queue: Jeevan Shikaram <[email protected]>
Auto-Submit: Jeevan Shikaram <[email protected]>
Reviewed-by: Tim Sergeant <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931770}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223602
Cr-Commit-Position: refs/branch-heads/4664@{#162}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
arc: bluetooth: Remove check of kGattReadPermission
In https://crrev.com/c/3193239, we turned a DCHECK for
kGattReadPermission into an if statement. It turns out that this DCHECK
is not correct and that change broke some functionality of ARC++ BT. See
the bug links for details.
(cherry picked from commit ca12a2da97a4d9c742908aa0b291c2df49d8a26d)
Bug: b:186866646, b:202998381
Test: Built and deployed chrome, cts verifier passed.
Change-Id: I7fdbe2dd385cf7209fa93e886a9707b1d1f39528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220880
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Sonny Sasaka <[email protected]>
Commit-Queue: Jie Jiang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931812}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226219
Auto-Submit: Jie Jiang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#161}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.12
Change-Id: I35753a2851c9410d7eca8453d58201a5ef33a8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228495
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#160}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I8a5e4786c842f718e43e544b4735b15627a7e9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226349
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#159}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I5e5149e4941e9937818f839e2a95a6de760ae763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226345
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#158}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] scanning: Enable multi-page scan flag by default
(cherry picked from commit 3d61fdb573f280babb611c2686ddacd19e00d3c3)
Bug: 1210271
Change-Id: I45724910eeea614f9e3dcf70c69bfdf2956e3112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205393
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929953}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226668
Auto-Submit: Gavin Williams <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#157}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.11
Change-Id: I14101ae7e2151248feeabd17e8e54116ef528db5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226729
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#156}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge to M96]Overview mode: Support expanding desks bar view while dragging starts
Remove the feature flag check for expanding desks bar view from zero
state to expanded state while normal dragging starts.
(cherry picked from commit 7cae895d1807b5504ee0041fd8b02f568b0b6caa)
Test: manual, unit-test
Change-Id: I9e861bbd65a66f13ab0fd2c9f6836ae2ebb04fa4
Fixed: 1260002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223135
Commit-Queue: Connie Xu <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931633}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223510
Cr-Commit-Position: refs/branch-heads/4664@{#155}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Video Tutorials] Fix try now bug crash
The crash was introduced in recent refactors when we accidentally
stopped supporting a nullable feature through UserEducationHelper.
This CL adds a feature for try now which will be default-enalbed,
so that UserEducationHelper always works with a non-null feature.
(cherry picked from commit 59f0ffb63d4a86065431e54957aea6ebfe627430)
Bug: 1259079
Change-Id: I45f3998ba7277c12e16bd49d14241f071a46469e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219384
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227039
Auto-Submit: Shakti Sahu <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#154}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Cherrypick] Control Device Trust Connector based on Feature Flag
Return false from DeviceTrustService::IsEnabled if the DeviceTrustConnectorEnabled feature flag is disabled. This will prevent the throttler from initiating the attestation flow regardless of whether the policy was set or not.
(cherry picked from commit 347ed744a4ff2ef7c52466c82c063dff467380e2)
Bug: 1259514
Change-Id: Ic6ec48d28968748799f65a37358aef1d3ad5faaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221021
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931283}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227003
Auto-Submit: Sebastien Lalancette <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#153}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Cherrypick] Show the ZeroTrustConnector tab based on the feature flag
The tab will only be shown (and trigger the underlying business logic) when the DeviceTrustConnectorEnabled feature flag is enabled.
(cherry picked from commit 5b07c246d08cc0e8c1e19e5d38c1bde5ae7ff7e6)
Bug: 1259514
Change-Id: Ib3a5279941235f3716daa3622212f0107366e0e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221016
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931490}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227004
Auto-Submit: Sebastien Lalancette <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#152}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][unseasoned-pdf] Extend SubmitForm() support to the Unseasoned viewer
This is a merge of reland of 799fe358070a3f5c8a9727389a46d7343a78b449
that disables PDFExtensionSubmitFormTest.SubmitForm on Windows.
Original change's description:
> [unseasoned-pdf] Extend SubmitForm() support to the Unseasoned viewer
>
> Allow the handling of relative form URLs. Add unit tests to verify
> relative URL handling.
>
> Migrate SubmitForm() to PdfViewPluginBase.
>
> Add browser tests to ensure that the form submission behavior is the
> same with and without the Unseasoned PDF feature enabled.
>
> Bug: 1255225
> Change-Id: Id1fc9c696b0ea54fd10486103a58f6c55d0103c3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214649
> Auto-Submit: Daniel Hosseinian <[email protected]>
> Commit-Queue: K. Moon <[email protected]>
> Reviewed-by: K. Moon <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#930925}
(cherry picked from commit c45ed5025ca9a0ab05e202e558024e20cd06dcdd)
Bug: 1255225
Change-Id: I455e63f1f58693655e549b429e2fd5526f15dedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223126
Commit-Queue: Daniel Hosseinian <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Auto-Submit: Daniel Hosseinian <[email protected]>
Reviewed-by: K. Moon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931580}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227526
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#151}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Read Later] min_version feature params shared with bookmarks
New feature params can be used to selectively disable feature flags
depending on whether the client was built with a future patch.
The new feature params are:
* BookmarksImprovedSaveFlow.bookmarks_improved_save_flow_min_version
* BookmarksRefresh.bookmarks_refresh_min_version
* ReadLater.read_later_min_version
(cherry picked from commit 9f06969815bf1301b48995aa13a2276fb2dcaee9)
Bug: 1257297
Change-Id: Id804ad6010d9645e6ccf0f757facac4587ae135a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214365
Commit-Queue: bttk <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930860}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224327
Commit-Queue: Filip Gorski <[email protected]>
Auto-Submit: bttk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#150}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[mojo] pass through invalid handles when relayed
This skips handle duplication in the broker process when taking incoming
handles for relay.
(cherry picked from commit 5d44e6646991fcdfcf46f794c54ef06cafd8d428)
Bug: 1239934
Change-Id: Id415ebd453c20b529df2151830259007f035b5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223421
Auto-Submit: Ken Rockot <[email protected]>
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931584}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227486
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#149}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[GMNext] Fix QR code dialog background
(cherry picked from commit f6195777f23b20df41c6c1e2ae6de54153dcf8a0)
Bug: 1259548
Change-Id: I313c58888938947310ff6a1016fd583d14d45858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221805
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931309}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227294
Commit-Queue: Theresa <[email protected]>
Auto-Submit: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#148}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Use correct sequence to update HMFT encoding frame rate dynamically.
Per https://docs.microsoft.com/en-us/windows/win32/medfound/handling-stream-changes,
HMFT may return MF_E_INVALIDMEDIATYPE if SetOutputType is called after
stream starts, blocking attempts to update the input/output frame rate.
On some devices this results in subsequent encoding failure or GPU
hang. This CL applies stream restart sequence when dynamically changing
encoding frame rate to resolve this issue.
(cherry picked from commit 2c9f1a30ddbafcee215f1e621ac03f5220522532)
Test: Manual with https://appr.tc/?debug=loopback&vsc=h264
Bug: webrtc:12932, 1252710
Change-Id: If7623274e3cd9e1b5841c8d7137ca26353d254e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3215394
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Eugene Zemtsov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930424}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227287
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#147}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Cherrypick] Create the DeviceTrustConnectorEnabled feature flag
This feature flag will be used to control the client-side portion of the Device Trust enterprise connector.
(cherry picked from commit 2e87dc4347586ab3e1cf7ace0374540dac98589c)
Bug: 1259514
Change-Id: I13a4d344bfb9f8c9a43b58b922a61855c29ff1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220861
Auto-Submit: Sebastien Lalancette <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Sebastien Lalancette <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931198}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226041
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#146}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AF] Add hovered/pressed and dark mode colors to PromoCodeLabelButton
Also moves the button setup from ctor to AddedToWidget() in order for
GetCascadingColor(~) to work properly.
Screenshots of [default, hovered, pressed] buttons for [light, dark]
themes below. Note that my gLinux themes differ a little from general
Mac/Windows themes so it's greyer/darker than mocks, but these are the
requested color sets.
https://screenshot.googleplex.com/C9FZbbamRnvzj7k.png
https://screenshot.googleplex.com/xM27VyJkKWNtGBF.png
https://screenshot.googleplex.com/7Vr2BUixwfqpuBS.png
https://screenshot.googleplex.com/SivDgLWnemFMv3e.png
https://screenshot.googleplex.com/6jKdYXuFYJG4Nyu.png
https://screenshot.googleplex.com/AoArdAhjf6utBpt.png
(cherry picked from commit fd8de18204e7291b0fb8187c5bafdd8dbca07579)
Bug: 1260038
Change-Id: I90f3880eae1271b674e42786d0813c7311ab86d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218385
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931082}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227184
Commit-Queue: Evan Stade <[email protected]>
Auto-Submit: Jared Saul <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#145}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AppMenu] Support tint the menu item icon to blue
Bug:1259490
(cherry picked from commit 8a3f39ac1040c2aa5221e1143f7194f120dfb19e)
Change-Id: I3a8762e4fc0e71479fece66bbc4d7a68327a5092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219955
Reviewed-by: Sinan Sahin <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931368}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227180
Auto-Submit: Brandon Wylie <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#144}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Use haveSearchBarControl() before getSearchBarControl()
Use haveSearchBarControl() before calling getSearchBarControl() to check
if SearchBarControl is created, otherwise we may create SearchBarControl
unexpected.
(cherry picked from commit ce50f6461e13fc962e75ad013ed65d78c0845efd)
Bug: 1259385
Change-Id: Ia841a37f0f8f9554847deaae68b40903324ab382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219564
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931365}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225143
Auto-Submit: Gang Wu <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#143}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
webfeed: fix scroll restore [M96 merge]
The fix here is to prevent binding the stream
while the streams are being added. See the
bug for more information.
Added a test to verify only the right stream is
bound.
(cherry picked from commit 8a8114e3424e103b4cdd2ee287a3a420b71c1646)
Bug: 1259194
Change-Id: I0e52a88eed37f4898535e7e00baf5794cbe9267e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219114
Reviewed-by: Cathy Li <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930736}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226635
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#142}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Rename the "Force Dark Mode" chrome://flag entry, adjust the defaults
(cherry picked from commit dcd5d965d9326cb8be386203daa5d509c9c14f23)
Bug: 1258588
Change-Id: I73aea221bb92841e07798a7ad730dd85c53d44a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217466
Reviewed-by: Philip Rogers <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Auto-Submit: Peter Beverloo <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930340}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226165
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#141}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge to M96 Responsiveness metrics normalization] Add a new UKM for
responsiveness metrics normalization.
Let N be the number of user interactions, we approximate a high
percentile in this way:
If N < 50, the value is the worst.
If 50 <= N < 100, the value is the 2nd worst.
If 100 <= N < 150, the value is the 3rd worst.
...
If 450 <= N <500, the value is the 10th worst.
If N >= 500, the value is still the 10 worst.
UKM privacy review: https://docs.google.com/document/d/1LpNRo-9Z9INyfmvyCSgbh1Ap4yGghxWWXPxwRB4ILyw/edit?usp=sharing
(cherry picked from commit 26b62869575f239455de3ff757d29a9385841b70)
Bug: 1252513
Change-Id: Ia67eeff5d81ccc6b4eba74adbe242e8cb8d74e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213187
Commit-Queue: Hongbo Song <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931192}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223662
Cr-Commit-Position: refs/branch-heads/4664@{#140}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Promo] Add total promo show count preference for Sync Promos
This cl adds a new pref to record the total number of times sync promos
are shown. This count takes into account promos shown in settings page,
new tab page, bookmark page and recent tabs page.
This count will be used to log sync promo interaction rates to get a
better understanding about how users interact with sync promos.
This cl also renames ChromeSharedPreference SIGNIN_PROMO_SHOW_COUNT
to SYNC_PROMO_SHOW_COUNT. This preference was introduced very recently
and was merged to M96 which is still not launched to Beta. This change
will also be merged to M96 so the shared preference will be overwritten.
Design doc: http://docs/document/d/1Ga3vWwj6-LsPHyLvLVLq3Jh_pdHeRMs3DTp4hzyqgPU?resourcekey=0-MlOT7NrM_9qUTTYmlvsz_A#heading=h.skkb3dw8qyvb
(cherry picked from commit ffe4b3871a3e5d1c8c30fda4522fe38d9d6e8e1e)
Bug: 1257126
Change-Id: I7fe4110858ac0029a692211c8894c59d24f0b285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207897
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930804}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226387
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#139}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[iOS] Stop showing location prompt after FRE
(cherry picked from commit 297b76f3faca5e4a46238b6e7feb022d449bbb8d)
Bug: 1258089
Change-Id: Ie07f4500eb7b991480cc25211a07f6e8b101b087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214392
Reviewed-by: Éric Noyau <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930256}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225924
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#138}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[iOS] Return early if BVC is being shutdown
-viewWillTransitionToSize:withTransitionCoordinator: can be called after
BVC is being shutdown, leading to a crash.
To avoid this crash, return early in the method when BVC has been
shutdown.
(cherry picked from commit 4d3e6d32a00801bf378bb4d65d2a4c86e33105c8)
Fixed: 1249400
Change-Id: I5d4ddf331324285f4d02917f38e88f967ec63e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220652
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931461}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226404
Commit-Queue: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#137}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Stop treating capture increments as webcontents activity
Calls to IncrementCaptureCount() of pages which are VISIBLE (say for
screen capturing tabs which are visible in other windows than the active
one) results in the last_active_time_ being incorrectly bumped. This
leads to an issue eg with the Screenshare tab picker dialog which sorts
tabs by their last active time, as navigating around the list will
cause this spurious active time bumping, meaning the list gets reordered.
(cherry picked from commit 0feb6603910eb293f83f9dc4d73ac0f3bf6a7b33)
Bug: 1256641
Change-Id: I63c80c2696f25378b66d31afeb3f733bd1f29bbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207871
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Elad Alon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931430}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226324
Auto-Submit: Elad Alon <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#136}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Promo] Save promo change state in a field for RecentTabsManager
We want to track how many times promos are shown in RecentTabsManager.
In order to do that we need to track changes in promo state changes
in RecentTabsManager. This cl introduces a member field that will store
the promo state in RecenTabsManager and update it when required.
This cl does not introduce any behavior changes.
(cherry picked from commit 8e152645569ff4347de6c44ab4f7cbf3bf518635)
Bug: 1257126
Change-Id: Id1dc52f635bf4480ed35b2b63ae88e8044a80f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212027
Commit-Queue: Tanmoy Mollik <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Auto-Submit: Tanmoy Mollik <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930204}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222842
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#135}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Promo] Fix Signin promo shown count for NTP page
This cl counts the Signin promo shown count for Ntp page only when
promo state changes from hidden to visible.
Currently the signin promo impression count is over-counted in settings
and ntp page. In order to fix them the usage of ImpressionTracker to
count promo will be deprecated.
This cl does not effect any existing histograms or user actions that are
overcounted. They will be deprecated in a separate cl.
(cherry picked from commit 81cc6d37820c57fe5145344647bfe751527ab05e)
Bug: 1254399
Change-Id: Ia36fdb454d25318047a2efdc9473fc186574bc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205195
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930105}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217535
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#134}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
DGAPI: Reject for Blink-side errors instead of returning null
Cherry Pick to M96
Reject with error/exception objects instead of just strings.
Extra return points were missed when switching browser-side errors to
reject instead of return null in crrev.com/c/3161918.
(cherry picked from commit 3b33a45294644ffeb273b94e3622727e7116957c)
Bug: 1248319
Change-Id: I5c3c872e2fa411be8fb83acb434d067171d0f8fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217488
Commit-Queue: Glen Robertson <[email protected]>
Auto-Submit: Glen Robertson <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931392}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225273
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#133}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[merge-m96] [CrOS] Update media_app to 1Qc63VbWUZ0x4_CDoIWELWLlPe4_HUw076AKmNWCmagC
Cherry-pick of change to fix A11y announcements
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/1Qc63VbWUZ0x4_CDoIWELWLlPe4_HUw076AKmNWCmagC
Release Notes: http://go/chrome-apps-backlight_202110070700_rc02
Bug: b:201355605
Test: Have two images. Turn on ChromeVox and open one. The filename should be announced when navigating left/right in Gallery.
Change-Id: I46d476bb610d69a8595d0b0364c6502fd71e14ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225262
Reviewed-by: Patti <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#132}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I07de8d9bbde709972c1f38fad29dd7f64886e7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223400
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#131}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge Back M96] Enable the feature of AdjustSplitViewForVK.
This CL enables the feature flag for the improvement of the portrait
mode split view with virtual keyboard.
(cherry picked from commit 909fef17e996b7f9dbae0fec36806d16596b03d5)
Bug: 997312
Change-Id: Ia77d8b54349ed4eecbe241ff2e1606b86e50455f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219371
Reviewed-by: Xiaodan Zhu <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Xiaodan Zhu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931221}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224562
Cr-Commit-Position: refs/branch-heads/4664@{#130}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fixing uninitialized error found by Linux MSan that is associated with
the addition of maldoca to download protection and relanding
finch trial config.
(cherry picked from commit a938888abe74885e58ecd4eff095a57108b1cc4c)
Bug: 1257078
Change-Id: I2074517cc9253bfd07d2f9d17376daf6fd044c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218865
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Olabode O. Anise II <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224120
Auto-Submit: Olabode O. Anise II <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#129}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.10
Change-Id: Ibe6da1f771ab6b162f07ef424a9c30b0d9fd47af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223843
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#128}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[omnibox] Added "and site search" to "Manage Search Engines" strings
This CL updates the "Manage Search Engines" string to "Manage Search
Engines and Site Search" on the right click context menu in the omnibox
as well as on the Search page and Search Engines page title.
These changes are currently gated behind the #omnibox-active-search-engines
flag.
Screenshots:
Flag off:
Right click menu: https://screenshot.googleplex.com/63HLJJWNvcXX3MP.png
Search engines page title: https://screenshot.googleplex.com/Aw3GYLiiDWVXYYy.png
Search page: https://screenshot.googleplex.com/6P2SXWmQMNCkYmP.png
Flag on:
Right click menu: https://screenshot.googleplex.com/BHoSyJkf9PFeCLu.png
Search engines page title: https://screenshot.googleplex.com/6EC4VH5PbkSMrgZ.png
Search page: https://screenshot.googleplex.com/76soxn47H6SCfBF.png
(cherry picked from commit 169aa8ffa0221482860e8facf850dda70c4911b2)
Bug: 1250567, 1213659, 1258793
Change-Id: I089b2a9bc84be6e461270eadf28d3cf7adf3db01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213007
Commit-Queue: Angela Yoeurng <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930216}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223425
Auto-Submit: Angela Yoeurng <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#127}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Lazily load extensions::IndividualSettings.
In a Chrome-branded release build on corp this reduces startup time by
half (1s->0.5s) and browser process memory by nearly a half (160MB->85MB).
Put this behind an enabled-by-default Finch experiment so we can:
1) measure the effectiveness from our users
2) disable it quickly if we see any issues
(cherry picked from commit 20abe8b3fa4758b2ea2030d0d981a8992c014d93)
Bug: 1256913, 1258809, 1257547
Change-Id: I92f3a3b35f87ba7b80a90d5e794c1f3b70b0c7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206863
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Devlin <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931228}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223513
Auto-Submit: John Abd-El-Malek <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#126}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Start] Show new tab button on the left.
This CL merges two changes:
https://chromium-review.googlesource.com/c/chromium/src/+/3203575
https://chromium-review.googlesource.com/c/chromium/src/+/3219350
(cherry picked from commit ea530faa6e4dfec81c6dfc999f7375f4d4fece43)
Bug: 1252417
Change-Id: I82ce707fe54e69238cd1e5344b8e32a6cd80e331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203575
Commit-Queue: Hao Dong <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929918}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223661
Cr-Commit-Position: refs/branch-heads/4664@{#125}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[96] WebCodecs: Fix AudioEncoder sampleRate metadata
AudioEncoderConfig.sampleRate describes the rate for input AudioData's.
Opus only supports a handful of rates, so we're often forced to resample
during encoding. The output medatada.decoderConfig.sampleRate should
indicate when such resampling has occurred.
(cherry picked from commit 0c9252b878ef54e7f2e14d7de3dd0d8145dfcdc1)
Bug: 1254496
Change-Id: I0c1e5858e76e970e9bb665ea7e944a98ff881167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214749
Auto-Submit: Chrome Cunningham <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929962}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223509
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#124}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][DesktopSharingHub] Change to 20dp 3P icons
We were using 16dp assets for 3P icons, which caused them to be fuzzy
at 1x. Changed to 20dp.
Screenshot: http://screen/3DRJrspxEPzUPKv.png
(cherry picked from commit feacd7cca719d82e414ef3cc5eb8e1026062bc91)
Bug: 1252572, 1252939
Change-Id: I174300645f1b3648aff48d41402c1d0be4fe7670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219665
Commit-Queue: Kristi Park <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930894}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223438
Auto-Submit: Kristi Park <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#123}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Always pass AffiliationService to CredentialProviderService.
This CL fixes a bug that disallowed some of the CredentialProvider
users from accessing AffiliationService after CL 3168886 landed.
Previously CredentialProviderService could access AffiliationService's
functions via accessing PasswordStore directly without
PasswordStoreInterface, that instantiated AffiliatedMatchHelper not
only for clients with kFillingAcrossAffiliatedWebsites feature
enabled, but now it accesses AffiliationService directly.
(cherry picked from commit 963ed0b59a506937140b4a7fd9dbb3ccbd7f30ce)
Bug: 1254283
Change-Id: I84eb03cc0cef91ea8dc3d9ac9ff9c045d994c241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211957
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Maria Kazinova <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930083}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222743
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#122}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Reland "Move navigation.js handling to NavigationJavaScriptFeature"
This is a reland of 5fda0a516f43682edb5291838841a0a20236004c
Original change's description:
> Move navigation.js handling to NavigationJavaScriptFeature
>
> This CL has no intentional functional changes. However, since
> JavaScriptFeature listens for messages at the BrowserState layer (rather
> than per WebState), the received messages are piped through to the
> CRWJSNavigationHandler through WebController. This allows for the
> removal of the CRWJSNavigationHandlerDelegate since the necessary
> objects can be directly passed from the web controller instance when
> necessary.
>
> Additionally, the main frame web bundle is removed as it is empty with
> this migration.
>
> Fixed: 1175913
> Change-Id: I81cb84dbd8637f5825c6a084eac6c36985bbe616
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209836
> Reviewed-by: Ali Juma <[email protected]>
> Commit-Queue: Mike Dougherty <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929317}
(cherry picked from commit aa2bd31392028bc67018daf89dcc4ea24c347ba1)
Change-Id: I83ec617225f68c0fd266c96c19f40546ec6ed564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214492
Reviewed-by: Ali Juma <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221112
Cr-Commit-Position: refs/branch-heads/4664@{#121}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Ship interactionId
Intent to Ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/a5cInmNh0Ro
(cherry picked from commit 5f47e34f2496faf699a18d19a58ceb4848773f56)
Bug: 1236758
Change-Id: Ifaf79755e61c015aa3c4ad216b4fbcfae7a26c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206750
Auto-Submit: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Yoav Weiss <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223919
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#120}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Return early if activity is not null for MixedContent dialog
We need to early return or otherwise it could cause the
callback to be called twice.
BUG=1258875
(cherry picked from commit 13ad9a53c644a25472ac7b9d1cc035037e96a99e)
Change-Id: Ia84e1835b4dec39b4fbbc29b9b63d014e57eec08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218119
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930911}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219947
Cr-Commit-Position: refs/branch-heads/4664@{#119}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Add renderer side trace event for user interaction latency
(cherry picked from commit b6277435d73927d4c3ec85eb9ab4e23f7e5627ae)
Bug: 1254486
Change-Id: I364ae9d07cbe7576a88572df4ed372acf4fa9d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212778
Auto-Submit: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Deep Roy <[email protected]>
Reviewed-by: Deep Roy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931072}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223899
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#118}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix crash in ActivityPicker when using resource obfuscation
Since the ActivityPicker relies on using the resource name instead of
the resource ID to get the icon for an app, we have to turn off
resource name obfuscation for the app icon or the ActivityPicker will
crash.
Given this is used by webview and the webview app may obfuscate its
resources we also have to detect when the ActivityPicker would crash
ourselves and use a blank icon in that case.
This cherry pick also merges in the followup change
https://chromium-review.googlesource.com/c/chromium/src/+/3217257
(cherry picked from commit 4e439fc7e82ba76e4be0dc5c33ddb916a6ecade2)
Bug: 1258094, 1249962
Change-Id: Id1ee2dc9767c5464bb8a83405b7fa009d2149465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213013
Commit-Queue: Michael Thiessen <[email protected]>
Commit-Queue: Yaron Friedman <[email protected]>
Auto-Submit: Michael Thiessen <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929946}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223660
Cr-Commit-Position: refs/branch-heads/4664@{#117}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[MerchantTrust] Show store icon when user dismisses bottom sheet
When user dismisses the bottom sheet which is opened from the message,
we need to show the store icon in omnibox. If the bottom sheet is opened
from the trusted surface, we don't need to show the store icon.
(cherry picked from commit e0bff1938a152f70778a9804f30ff38f57c16987)
Bug: 1252543
Change-Id: Ic9c9c972c26ec499d5966b85537ded0d8f0aa1ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212531
Reviewed-by: Ayman Almadhoun <[email protected]>
Commit-Queue: Zhiyuan Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930746}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221729
Cr-Commit-Position: refs/branch-heads/4664@{#116}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge to M96]Overview mode: Drag and drop existing window to New Desk in Overview
New Desk is not currently a drag and drop target in Overview. This CL
adds support to drag existing windows to it (similar to dragging to
existing desks) to create a new desk and populate it with that window.
(cherry picked from commit dc2d2502e07da22c02ecee86ed902fd6860f7913)
Test: manual, unit-test
Change-Id: I4217d839b5fc7c5da5f6f6ad29a6edb68d448508
Fixed: 1252455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180203
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929741}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221532
Cr-Commit-Position: refs/branch-heads/4664@{#115}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[AF] Add metrics for copy promo code button in offer notif bubble
(cherry picked from commit 8218c28477685c6e65812039b0c1ba8d2a580f93)
Bug: 1258862
Change-Id: I9623a0a55b724ce24325c802a7ba1787c9269465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207328
Commit-Queue: Jared Saul <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929807}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221853
Auto-Submit: Jared Saul <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#114}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
dpwas: Enable protocol handlers by default
Enables protocol handlers by default on Windows/MacOS/Linux.
(cherry picked from commit 6da7697299d922ec519b61921a19e987e3d10e94)
Bug: 1019239, 1082491, 1258805
Change-Id: I6194ac84f2145abbce88431042244012d81438c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176723
Auto-Submit: Mike Jackson <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929942}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217704
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Mike Jackson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#113}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I112ed587d0a82afb49debe4ee25b836b64fe9eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222785
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#112}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[iOS] Fix format of CPE keychain group
crrev.com/c/3205359 changed the format of CHROMIUM_BUNDLE_ID to include
IOS_BUNDLE_ID_PREFIX, but this usage was not updated.
(cherry picked from commit 571813291e07024b08969dc11d8112cae33a2cf6)
Bug: 1258120
Change-Id: Ia4b7888e99ca0a6928cdccbbcaae518fade0656c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214710
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930085}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222746
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Robbie Gibson <[email protected]>
Reviewed-by: David Jean <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#111}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge 96] Site Storage Controls: Fix dialog title line spacing
Adjust the dialog title line spacing to 20px, which aligns with other
dialogs of similar types, and allows for multi-line dialog titles.
(cherry picked from commit 6eaf28d084dfbda192a2b5f96998852e54b89937)
Bug: 1258590
Change-Id: I89da141cf55f45fb280c3bfb75e84ae995ac5728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217520
Reviewed-by: Sean Harrison <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930146}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218894
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Sean Harrison <[email protected]>
Auto-Submit: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#110}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Web apps: Don't show "open in" icon for non locally installed web apps
Non locally installed web apps are synced web apps that have not had
their web app specific features deployed (Windows/Mac/Linux only).
This CL updates their App Service representation as kDisabledByUser
and makes their effective scope empty so it doesn't get used
by app service related functionality like "open in" for browser tabs.
(cherry picked from commit 28e432898a62e41775f6220f07ec345aa3346c08)
Bug: 1252607, 1254110
Change-Id: I5f990b2718d27b473acc93812c1a1b486e3cbef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180921
Reviewed-by: Maggie Cai <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930059}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221714
Reviewed-by: Alan Cutter <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Commit-Queue: Maggie Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#109}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Fix inconsistencies in histogram naming for CLS2.
(cherry picked from commit 5d44fa53c54f21af2d4adf5cc1f0ccf768c88d1f)
Bug: 1230786
Change-Id: Ic853334cff3495e46ffff0fc4cb850a6117d6219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217837
Reviewed-by: Mike Wittman <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Annie Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930536}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221456
Auto-Submit: Annie Sullivan <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#108}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Merged: [wasm] Add implementation for the dynamic tiering origin trial
The origin trial flag is passed to V8 via a callback, as we did it in
the past already for other origin trials.
The feature counter is incremented in the callback because the callback
is called exactly once per WebAssembly compilation. This allows an
easier increment of the feature counter than to increment it in V8.
Bug: v8:12281, chromium:1259547
(cherry picked from commit 05f735995d3aa5dfa77507673bae78633088ccc4)
Change-Id: Id58608843146e1bf4316e7f418a2bd15239318db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221155
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#107}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[privacy_budget] Validate experiment params
This CL adds logic to validate the finch parameters for the
privacy_budget identifiability experiment. The study is disabled if
the parameters are not valid.
(cherry picked from commit d618eb2733d0a6f4a58a9255b2c092cd7fa4d226)
Bug: 1224752
Change-Id: I1964e46a837e2ae817cbd9c1a4d35fa4d2e09646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211987
Commit-Queue: Antonio Sartori <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930080}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218055
Auto-Submit: Antonio Sartori <[email protected]>
Commit-Queue: Asanka Herath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#106}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[lacros shelf] Check that the BrowserAppInstanceRegistry remote is available
Do not attempt to construct BrowserAppInstanceForwarder when the
BrowserAppInstanceRegistry remote is not available. This remote is not
available on older Ash versions, and attempting to get the remote will
crash.
(cherry picked from commit 8c70b9973e7a8001b532904b8785fffbc6ff1cd6)
Bug: 1203992
Bug: 1258580
Bug: 1259297
Change-Id: I116b03516c73b1b5e044869a06f0c15f2c00ad52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219019
Commit-Queue: Alexander Bolodurin <[email protected]>
Commit-Queue: Maggie Cai <[email protected]>
Auto-Submit: Alexander Bolodurin <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Reviewed-by: Maggie Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930871}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220935
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#105}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[lacros skew tests] Refresh skew tests for M97
This CL updates the ash version 97.0.4668.0 for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: Id2947ade2b4e3035979f9b9db1c1874473aff544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220962
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#104}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Reland "[Snooze IPH] Adding tests"
This is a reland of daf3f8564861174e5dd27587e655417aab171a66
Original change's description:
> [Snooze IPH] Adding tests
>
> Added unit test for backend.
>
> Added integration test for snooze UI.
>
> Bug: 1238924
> Change-Id: Ia6e5bb427a57897272ad1a42f6225d7f01d5dc31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202694
> Commit-Queue: Hailey Wang <[email protected]>
> Reviewed-by: David Trainor <[email protected]>
> Reviewed-by: Shakti Sahu <[email protected]>
> Reviewed-by: Matt Jones <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929493}
(cherry picked from commit a3aef2ecc3a1888a3fbd96fbd83278a7441d2f82)
Bug: 1238924
Change-Id: I45ac275cc6a860ffffd0a09b0feaae564c0effbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214451
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Hailey Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930264}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221540
Auto-Submit: Hailey Wang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#103}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.9
Change-Id: I5b60357de490eb93efa2ebd76e1015d01bdae28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221136
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#102}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[remoting] Remove DesktopResizerOzone.
This removes the special Ozone handling of the desktop-resizer, now
that Ozone is enabled by default.
On Linux platforms, there are now only 2 DesktopResizer implementations,
exactly one of which is compiled in:
DesktopResizerX11 is used on platforms where X11 is enabled, excluding
ChromeOS.
DesktopResizerLinux is used in all other cases (including ChromeOS),
and is a no-op stub, enabling compilation on ChromeOS and other
non-X11 platforms.
This also fixes the bug where the no-op Ozone version was being used
by the Linux desktop host.
(cherry picked from commit cd12d2e3bf1f252d5f5166815fddb5832098a9f8)
Bug: 1258884
Change-Id: Id69bb8e2b37eb8748bb064b85cdd0814a1c15307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218465
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930677}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222015
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#101}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Read Later] Final string updates for M96
(cherry picked from commit 14b40e16dd8e357caf017775c0419e6c78fc9e87)
Bug: 1259292
Change-Id: I1da1c84f682e72fe6a188084185f137025a158a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219418
Auto-Submit: bttk <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: bttk <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930773}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222017
Cr-Commit-Position: refs/branch-heads/4664@{#100}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Add new versions of CLS histograms with finer-grained bucketing.
Also remove/obsolete temporary histograms.
(cherry picked from commit 5ace6d480ac80499e041ce5478da7bb9d0645815)
Bug: 1230786
Change-Id: I4b7f1d1517a99d11883c4213e7f0ea7cb7bfee01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213526
Reviewed-by: Mike Wittman <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Auto-Submit: Annie Sullivan <[email protected]>
Commit-Queue: Annie Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220961
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#99}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Nearby] Uprev Nearby Connections to 51a19d24c164
Manually verified: https://docs.google.com/spreadsheets/d/1RnMjwDc4KkvxIY9fbjCJnborlawdlJOVfBJWejl6DZM/edit#gid=1824252742
-----------------------------------------------
Roll nearby-connections from dceb1e216bdd to 51a19d24c164 (6 revisions)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/dceb1e216bdd..51a19d24c164
2021-10-08 [email protected] Fix dereferencing of null channel
PiperOrigin-RevId: 401814449
2021-10-07 [email protected] Replace some C like syntax and add missing include files.
PiperOrigin-RevId: 401541156
2021-10-07 [email protected] PhoneHub hopes to keep a long lived connection (over 10 mins) between Android and ChromeOS. However, phone would go to deep sleep mode and not send out KeepAlive even when receiving KeepAlive from CrOS. Here we force a KeepAliveAck back to avoid KeepAlive timeout.
PiperOrigin-RevId: 401454742
2021-10-06 [email protected] The final fixes for the socket code allowing us to advertise and accept the connection.
PiperOrigin-RevId: 401317340
2021-10-06 [email protected] Internal Change
PiperOrigin-RevId: 401312277
2021-10-06 [email protected] These are the fixes thus far. Most involve whether we're using a pointer or not.
PiperOrigin-RevId: 401241518
(cherry picked from commit 0735385797764703c3c3dfa6b5f1b73ca1e39dde)
Fixed: 1257209
Change-Id: Ib925cd4905e083de3a9add3ae6dcda0bd7a0c20b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214369
Reviewed-by: Michael Hansen <[email protected]>
Commit-Queue: Josh Nohle <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930359}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221070
Auto-Submit: Josh Nohle <[email protected]>
Commit-Queue: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#98}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Incrementing VERSION to 96.0.4664.8
Change-Id: I38c9dc950245a80829fbc898af66b92f48a3af5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221397
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#97}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge to M96] Reland "Reland "[X11] Reset frame hints when using server side decorations""
This is a reland of 06943dc0afcb0023863edb98c233c4fdf3db766e
Original change's description:
> [X11] Reset frame hints when using server side decorations
>
> Some WMs get confused when frame hints are set on decorated windows, so
> this CL removes those hints when they're not needed.
>
> Bug: 1251382
> Change-Id: I5a74db36c9fe07549d314f6f8561df27e7a0a214
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199110
> Commit-Queue: Thomas Anderson <[email protected]>
> Auto-Submit: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#927501}
(cherry picked from commit d45b5992f2a1ce193ee188239a5b723a046ab9e0)
Bug: 1251382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209124
Auto-Submit: Thomas Anderson <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/main@{#928917}
Change-Id: I0593ca0db5eaebfe6a5af2e03aee8e563d1ee21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213449
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Maksim Sisov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929732}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221711
Cr-Commit-Position: refs/branch-heads/4664@{#96}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Reland "[AutoDark] Fix crash when attempting to send AutoDark message"
This is a reland of 44b2f9c7d3babc53a825c2c4319ab71bea1f9e29
Manual repro following steps in crbug.com/1258381 resulted in same crash
referenced in the bug.
Tracing back further shows that, when following those steps, the profile
returned by the profile supplier in TabbedRootUiCoordinator is null.
When this is passed in to the TrackerFactory, it appears to cause the
crash. This can be manually traced starting with the
GetForBrowserContext(...) call (http://shortn/_munpdacjXQ) which leads
to the KeyedServiceFactory::GetServiceForContext(void*, bool) from the
crash.
Original change's description:
> [AutoDark] Fix crash when attempting to send AutoDark message
>
> The AutoDark message gets its profile from webcontents. The webcontents
> come from the current tab. The current tab comes from a tab provider.
> When the tab provider returns null (no current tab), we hit a null
> pointer exception when trying to retrieve the webcontents.
>
> Use profilesupplier instead
>
> Bug: 1257879
> Change-Id: Ibe2b71d74a25730c59313e9e6cd80f190af9d258
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214605
> Commit-Queue: Neil Coronado <[email protected]>
> Reviewed-by: Theresa <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#929907}
(cherry picked from commit fb23b3605c44556dee629979cc312d68495ec744)
Bug: 1257879, 1258381
Change-Id: If79899da253ff460870360d580b7d37a5ad157fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218330
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930646}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221284
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#95}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Add histograms for page load token.
Add the following histograms:
SafeBrowsing.PageLoadToken.PasswordProtectionHasToken
SafeBrowsing.PageLoadToken.RealTimeCheckHasToken.Consumer
SafeBrowsing.PageLoadToken.RealTimeCheckHasToken.Enterprise
SafeBrowsing.PageLoadToken.TokenCount
(cherry picked from commit a4ca56aecf8890bb4fe1c3e40d54f10ed37a1799)
Bug: 1240403
Change-Id: I203a49a85282a44bc1f896a94a9d27c5647e128a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3215191
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930755}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221798
Auto-Submit: Xinghui Lu <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#94}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Forced dark with preferred light color-scheme
Forced darkening should be done with a dark preferred color-scheme. The
Android WebView has a mode for forced darkening FORCE_DARK_ONLY which
should always use forced darkening instead of preferred dark
color-scheme.
This mode has deteriorated over time. In particular, when we started to
use dark color-scheme for color-scheme:dark when the preferred
color-scheme was light, we started doing opt-out for FORCE_DARK_ONLY,
which was incorrect. This CL makes FORCE_DARK_ONLY never opt-out of
forced darkening, even for 'only light' values.
(cherry picked from commit b1bb295290fe9ba5570a3027bec06d52129f0eb5)
Bug: 1257528
Change-Id: Icbfd342c4ede1c37a59cc207ae016ed76428c4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217634
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930485}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220615
Cr-Commit-Position: refs/branch-heads/4664@{#93}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[unseasoned-pdf] Switch Print Preview to out-of-process plugin
Finishes converting Print Preview to use the out-of-process unseasoned
plugin, rather than creating the in-process plugin directly. Since Print
Preview doesn't use MimeHandlerView, this required changing
ChromePdfStreamDelegate to simulate the same behavior.
This change still requires additional fixes for crbug.com/1238829, but
should fix the sandbox-related crash issue on Windows by moving the PDF
content to a PDF-specific renderer.
Also needed to fix some logic related to Print Preview loading in
PdfViewPluginBase that was sensitive to races.
(cherry picked from commit 8395e65394409550f4b79763c4c0ba219904b47c)
Bug: 1237952
Fixed: 1253984
Change-Id: I2d64a24004774daaa3f9e7d031766fbd4a06767d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195191
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221591
Reviewed-by: Daniel Hosseinian <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#92}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[unseasoned-pdf] Propagate is_pdf to CanCommitOriginAndUrl()
Modifies RenderFrameHostImpl::ValidateURLAndOrigin() to propagate the
"is_pdf" bit from any supplied NavigationRequest to
CanCommitOriginAndUrl().
Without this change, PDF navigations to WebUI URLs are rejected solely
due to a process lock mismatch: The process lock (correctly) has the
is_pdf bit set, but the process lock derived from the UrlInfo passed to
CheckWebUIRendererDoesNotDisplayNormalURL() (incorrectly) does not.
(cherry picked from commit b012f393a553b555a8f6b482b542028b2bd484b1)
Bug: 1253984
Change-Id: If4760cf8a0fe7990aa3cef680395e49d1f9f7b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211368
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929554}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221531
Cr-Commit-Position: refs/branch-heads/4664@{#91}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[unseasoned-pdf] Add chrome-untrusted://print
Adds an untrusted WebUI at chrome-untrusted://print for serving Print
Preview pages from a less privileged origin than chrome://print.
(cherry picked from commit cc7753bcbe65e268ab62a4c13305ffa62ab5fbed)
Bug: 1238829, 1253984
Change-Id: Id039140c60dce98eb5a6096c7fae5ff207097626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213411
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929537}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221590
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#90}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Polish holding space item context menu.
A separator is added to the holding space item context menu to
separate pause/resume/cancel commands from other commands. If the user
selects multiple in-progress holding space items, only the pause/
resume/cancel commands will be shown (WAI) but the separator is also
shown (not-WAI).
This CL restructures context menu item creation to keep this from
happening and to make it easier to keep menu item creation clean
and consistent moving forward.
(cherry picked from commit b6959d03cf28e0e8167d3b72224d16cf66089612)
Bug: 1258933
Change-Id: Ie223a759933fdc1a3a4e88cfeee34e089952a389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218433
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931152}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221595
Auto-Submit: David Black <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#89}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[unseasoned-pdf] Allow PDF WebUI navigations to be intercepted
Allows PDF navigations to WebUI URLs to be intercepted, similar to
crrev.com/927104's treatment of blob: URLs. This allows
PdfUrlLoaderRequestInterceptor to work correctly for WebUI URLs.
This is needed to unblock navigating to PDFs hosted at URLs like
chrome-untrusted://print.
(cherry picked from commit 68ae9e92ec21e3b16d9d89d491339cab8875288d)
Bug: 1253984, 1255181
Change-Id: I3b8290c432e69c1832300b56be148b1046318104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209793
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929530}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221285
Commit-Queue: Alex Moshchuk <[email protected]>
Auto-Submit: K. Moon <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#88}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Roll src/third_party/libavif/src/ 0dd3a3a5d..6198acd0a (2 commits)
Merge to M96 branch:4664.
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/0dd3a3a5d216..6198acd0a1fd
$ git log 0dd3a3a5d..6198acd0a --date=short --no-merges --format='%ad %ae %s'
2021-10-08 wtc Require srcWidth,srcHeight <= 16384 for ScalePlane (#770)
2021-10-05 wtc ext: Checkout libaom v3.1.3
Created with:
roll-dep src/third_party/libavif/src
R=[email protected],[email protected]
(cherry picked from commit dd32207449d64126f0114ebf366244555fdc71cd)
Bug: 1258223
Change-Id: Ib31a4c7b83a10e62f6e31a5506527d9803f80597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214941
Reviewed-by: James Zern <[email protected]>
Commit-Queue: Wan-Teh Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221530
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Wan-Teh Chang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#87}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][STTS] Fix target device list not being updated often enough
Before:
SendTabToSelfBridge::{GetTargetDeviceInfoSortedList,HasValidTargetDevice}
would recompute (sort+dedupe) the target device list or not, based on
ShouldUpdateTargetDeviceInfoList(). The predicate turned out to return
false more often than it should, causing the bridge to expose an
outdated list.
[1] is the thread where this design got decided .
Now:
1. SendTabToSelfBridge observes DeviceInfoTracker and recomputes the
device list on every OnDeviceInfoChange().
2. {GetTargetDeviceInfoSortedList,HasValidTargetDevice} handle device
expiration. Note that (1) doesn't handle this: the "last used"
timestamps might stay the same, but will eventually be considered too
old.
This change means the worst-case time complexity of these methods is
now better.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1585944/comments/264f963d_33bde0f3
(cherry picked from commit 74b44f61fa33d67ca951e470ff9fa626eaf0691c)
Fixed: 1257573
Change-Id: I017d9ce69a759332096fbb72d4fe14afb353a247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217642
Commit-Queue: Victor Vianna <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930622}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220300
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#86}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] [Sheriff] Add failure expectation for virtual/gpu-rasterization/images/color-profile-animate.html
Test flaking on Mac 10.14 on M96
(cherry picked from commit 12cc4f6c0fde726036ad76b38e7c7d87ac22e4c7)
No-Try: true
Bug: 1259188
Change-Id: Ia2c3df24d5d27e7f67956b79f71a5a6bdfa401ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218593
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: François Doray <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930611}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221286
Commit-Queue: Elaine Chien <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Elaine Chien <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#85}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] [Sheriff] Failure expectation for virtual/threaded/external/wpt/scroll-animations/scroll-timelines/scroll-animation-inactive-timeline.html
Test is flaking on M96 Mac 10.13 builder
(cherry picked from commit 0bdeaf17a0c1003bbda13785ac910aa6b24991cc)
Bug: 1259167
Change-Id: I09bab34eeeece5b56a31b9777cebe772db82d2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216668
Auto-Submit: François Doray <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#931039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221271
Reviewed-by: Elly Fong-Jones <[email protected]>
Auto-Submit: Elaine Chien <[email protected]>
Commit-Queue: Elaine Chien <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#84}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Early return if activity is null for dangerous and duplicate dialog
If activity is null, we should early return rather than creating the
dialog. The crash could be caused by that the callback is invoked twice
from java side.
BUG=1255582
(cherry picked from commit 2848de0bc58c7363b93a3b349675f1d0c418b121)
Change-Id: I3d3dddebc47e16efe831b442d23b20a4da8e1d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217843
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930267}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221127
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#83}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Merge M96: Add a max queue length histogram for the RTC low-latency renderer
The max queue length is useful together with the average queue length
to determine how well the low-latency renderer is performing and how
well bursts of frames are handled.
(cherry picked from commit 60935eb69274fbf0eb5ba47ccfe1cc56771b08b6)
Bug: chromium:1258929
Change-Id: I347e3964df7961e4987e4129779c1e6e2dbc9305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218151
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930524}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220477
Reviewed-by: Evan Shrubsole <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#82}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[GridNG] Fix auto-placement with items spanning multiple rows (again)
Fixing an issue in the auto-placement algorithm where, if the current
position moved past the `EndOnPreviousMajorLine` of an overlapping item,
when calling `MoveToNextMajorLine` the major end line of such item would
not be taken into account because it will be removed from the vector by
the time its called. A similar issue was fixed previously, but at the
time were items are introduced to the overlapping item's heap.
Running a perf job showed that, as expected, no performance regression
is introduced since this CL only changes some conditionals performed at
the time of inserting/deleting any overlapping item.
A new test to cover the regression was also added to the WPT suite.
(cherry picked from commit 296e54039b6733a12686c31d501ff8c9da042e92)
Bug: 1255298
Change-Id: Id5a5db3e0b999832767cd512794c5eebdff17286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213920
Commit-Queue: Ethan Jimenez <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Ana Sollano Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930306}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219935
Cr-Commit-Position: refs/branch-heads/4664@{#81}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[ChromeCart] Make more heuristics Finch updatable
The following heuristics are made Finch configurable:
- Generic add-to-cart pattern
- Per-domain and generic cart URL pattern
- Generic checkout URL pattern
- Generic purchase button text pattern
(cherry picked from commit 059680613e96a623784b5cb063dd03a06cb30824)
Bug: 1258278
Change-Id: Id118258c174568bf254acc2490f33dd5834776a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211594
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Auto-Submit: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930255}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219389
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#80}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96][Coupon] Add browser test for FetchDiscountWorker
This CL adds browser test to cover the FL codeless discount code path,
and fix a bug.
(cherry picked from commit 06556c71cf84e6c03ed669400c8923ca49f2ff27)
Change-Id: I0e8446712461135f9329c53bb25be770933a9bf5
Bug: 1240341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3214926
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219113
Cr-Commit-Position: refs/branch-heads/4664@{#79}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
network_diagnostics: Fix parsing of failed ping
Currently GatewayCanBePinged routine is not checking if the ping was
successful and only checking presence of avg latency value and
considering the test passed. If the default gateway does not respond to
ping, the test should fail.
In this change, we're updating the response parsing to validate the
presence of recvd field in the JSON response object and verifying that
it is not zero.
--routine=gateway_can_be_pinged fails when gateway address is invalid
and succeeds when it is valid
(cherry picked from commit ca63081566dac8bf83e17e2534ba84c3929b02ae)
Bug: b:202451795
Test: unit_tests --gtest_filter='*GatewayCanBePinged*'
Test: cros-health-tool diag --action=run_routine
Change-Id: I34e89c9a55baf04e8ce7fb2f8974b1b7b7c71d07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213631
Commit-Queue: Muhammad Hasan Khan <[email protected]>
Reviewed-by: Hugo Benichi <[email protected]>
Reviewed-by: Kartik Hegde <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929696}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219782
Cr-Commit-Position: refs/branch-heads/4664@{#78}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Updating XTBs based on .GRDs from branch 4664
Change-Id: I4b2dff110093de7d1572bcdba75ae98a30bb7556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220855
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#77}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Merge M96: [wmp_ms] Add support for ARGB software frames to copy-on-pause
(cherry picked from commit 2bf77002c58a05e1c673e28f6cca5882fe4e7e97)
Fixed: chromium:1257891
Change-Id: I576b01d317b738f71989be7c6da2a77894bc0215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218052
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930514}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220612
Cr-Commit-Position: refs/branch-heads/4664@{#76}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Enable ACCEPT_CH HTTP/2 and HTTP/3 frame by default (M96 MERGE)
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/6EoEnqxqhsk/m/0-U7g3JlAgAJ
Bug: 1188199, 1258100
Fixed: 1258100
Change-Id: I5ebbd8c00a7747f60f8958b52f3aecb28d6d2596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3213749
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Aaron Tagliaboschi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#930139}
(cherry picked from commit 088c85d1226eac203c4bc0d3cd9ca195516c6ce7)
Change-Id: I5ebbd8c00a7747f60f8958b52f3aecb28d6d2596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218340
Commit-Queue: Aaron Tagliaboschi <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#75}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[Merge to 96] Change CHECK for rfh_restored_from_back_forward_cache_ to if condition
We're seeing some crashes where the failed bfcache restore NavigationRequest is not marked as
being restarted, but the bfcached RenderFrameHost is already gone. We should handle this case by
not expecting rfh_restored_from_back_forward_cache_ to be around even when a bfcache restore
navigation is not marked as being restarted.
(cherry picked from commit ea19ed268a588b3d1692fb88a9674b6608d8fdcc)
Bug: 1258523
Change-Id: I88b87f94caa12c184af6c851644a314a23b2312b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217471
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220893
Commit-Queue: Alexander Timin <[email protected]>
Auto-Submit: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#74}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96 merge] Settings: Fix error caused when searching, because $$() is missing.
As a result of migrating Settings away from WebUIListenerBehavior, the
$$() helper method stopped being implicitly inherited via the
LegacyElementMixin, and it needs to be explicitly inherited via
BaseMixin instead.
(cherry picked from commit 061b3316ecb49d6b0df730978bbf1d68f3ff5b4b)
Bug: 1258591
Change-Id: I878974595b1c4588044681a9c84f9f279c94cb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217870
Auto-Submit: dpapad <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930260}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220310
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: dpapad <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#73}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[lacros skew tests] Refresh skew tests for M97
This CL updates the ash version 97.0.4667.0 for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I9c96ea2f7408081d764753bbc082f4d60b3b3cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218596
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#72}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96 merge] [CrOSSettings] fix margin for rtl languages
Screenshot:
rtl: http://shortn/_3AfTOJauPy
ltr: http://shortn/_Z0XlIoeGzz
(cherry picked from commit 8af93bf7eab1e58be419f960c35d8deb92823a92)
Bug: 1258236
Change-Id: If66de98b4ea1a9f5d78e47aa0e737229ada700d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218510
Reviewed-by: Regan Hsu <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216501
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#71}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[M96] Check that DriveFS is available before starting the native host session
(cherry picked from commit 13a58702b99c281b0aed744f8fef8fa77e91aae1)
Bug: 1258485, b:202550647
Change-Id: Ifede8484614a63373af14f01b53ddfd93974c84a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216288
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Austin Tankiang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#930052}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218722
Auto-Submit: Austin Tankiang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#70}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Reland "[Nearby] Uprev nearby-connections to dceb1e216bdd"
This is a reland of 3b7a2ffdaae1a1386b05a6d6bed46921bdc579b3
Original change's description:
> [Nearby] Uprev nearby-connections to dceb1e216bdd
>
> Manually tested: https://docs.google.com/spreadsheets/d/1RnMjwDc4KkvxIY9fbjCJnborlawdlJOVfBJWejl6DZM/edit#gid=1998917521
>
> -----------
>
> Roll nearby-connections from f483110a8d92 to dceb1e216bdd (71 revisions)
>
> https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/f483110a8d92..dceb1e216bdd
>
> 2021-10-06 [email protected] Fix analytics recorder's version string type
> PiperOrigin-RevId: 401125543
>
> 2021-10-05 [email protected] Exporting symbols for consumers of the dll - and deleted old code
> PiperOrigin-RevId: 401098019
>
> 2021-10-05 [email protected] Added defs in build files for building windows dll
> PiperOrigin-RevId: 401062093
>
> 2021-10-05 [email protected] Changes to the Windows solution/projects for fixes for ConditionVariable, Mutex, ServerSocket, and started exporting symbols for the UI.
> PiperOrigin-RevId: 400983103
>
> 2021-10-05 [email protected] Branch BandwidthUpgradeManagerV2 to support the re-priority mechanism, separate the priority logic into BandwidthUpgradeProtocol to support below priority
> 1. 6GHz > 5GHz > 2.4 GHz
>
> 2. 80 MHz > 40 MHz > 20 MHz medium for 5GHz mediums(next CL)
>
> PiperOrigin-RevId: 400929119
>
> 2021-10-05 [email protected] analytics: 3p NC: Update Connections_log.proto
> PiperOrigin-RevId: 400862464
>
> 2021-10-04 [email protected] Fixed a few issues in WiFi LAN feature.
> PiperOrigin-RevId: 400786291
>
> 2021-10-04 [email protected] Fixed the issue to initialize an EndpointInfo instance in payload manager.
> PiperOrigin-RevId: 400624671
>
> 2021-09-29 [email protected] Replace proto.h includes with pb.h
> PiperOrigin-RevId: 399801411
>
> 2021-09-29 [email protected] [Nearby Connections][C++] Wake up keep-alive thread to unblock destruction
> PiperOrigin-RevId: 399693890
>
> 2021-09-29 [email protected] Add WiFi LAN medium on Windows
> PiperOrigin-RevId: 399587411
>
> 2021-09-29 [email protected] nearbyconnections : Refactor WifiLan.
> PiperOrigin-RevId: 399570712
>
> 2021-09-27 [email protected] Add more time buffer so that the alarm will be executed as expected in tests. It will fix the flaky EndpointIdRotateWhenHighVizAdvertisementAgainForAWhile test.
> PiperOrigin-RevId: 399248463
>
> 2021-09-24 [email protected] [Sharing][Analytics] Create a new failure type to indicate unknown response from remote side.
> Since these are not payloads failures, the connection is canceled by local device. FAILED_ATTACHMENT_TRANSMISSION_STATUS is reserved for payload failures.
>
> PiperOrigin-RevId: 398821851
>
> 2021-09-24 [email protected] [Analytics] Add proto and enum for establish_connection event.
> Set up the proto and enums in advance. No real logic.
>
> LOG_STORAGE_INCREASE(GB/week): 0.5
> Based on go/ns-analytics-worksheet
>
> PiperOrigin-RevId: 398810446
>
> 2021-09-24 [email protected] Add error codes for mediums being disabled on unsupported devices
> PiperOrigin-RevId: 398801753
>
> 2021-09-24 [email protected] Delete the windows specific count_down_latch and use the shared implementation
> PiperOrigin-RevId: 398772515
>
> 2021-09-24 [email protected] Add following information into metrics:
> 1. country code: where the device is located.
> 2. network operator: the telephony operator MCC/MNC value.
> 3. tdls status: the TDLS status of the WiFi Lan
> 4. AP frequency: the wifi frequency of the connected WiFi AP.
> 5. Tethering status: the enable status of the wifi Hotspot.
> 6. try counts: the try counds of the medium operation.
> 7. Tx/Rx speed: the MAX TX/RX speed of the WiFi network.
> 8. Channel width: the supported WiFi frequency MHz value. e.g. 20MHz or 40MHz for the WiFi Direct Client or WiFi Hotspot STA.
>
> Storage increase will be:
> 1.4 bytes connected_ap_frequency in advertising side
> 2.4 bytes connected_ap_frequency + 1 byte supports_extended_ble_advertisements in discover side.
> 3. Incoming or outgoing conection:
> 4 bytes wifi_channel_width
> So need 4*4 = 16 bytes in two directions initial connections and two directions bandwidth upgrades.
>
> So there are total 4+5+16 = 25 bytes grows in each share.
>
> (25 bytes in each sharing * 1072782 shares/daily * 7 days/week) / GB = about 0.175 GB)
> (1072782 was based on current daily activedevice on 20210906.)
>
> PiperOrigin-RevId: 398656656
>
> 2021-09-20 [email protected] Fixed a bug in BluetoothAdapter::SetName, that was causing the loss of the default name.
> PiperOrigin-RevId: 397871581
>
> 2021-09-20 [email protected] Clean up platform.cc Remove unnecessary namespace symbols to improve consistency.
> PiperOrigin-RevId: 397870990
>
> 2021-09-20 [email protected] Cleanup unit tests, and remove the loop that checks to make sure all jobs are run.
> PiperOrigin-RevId: 397869801
>
> 2021-09-19 [email protected] Internal change.
> PiperOrigin-RevId: 397581907
>
> 2021-09-16 [email protected] Refactor thread pool to support lazy initialization.
> PiperOrigin-RevId: 397152910
>
> 2021-09-16 [email protected] Fix for failing executor test.
> PiperOrigin-RevId: 396998512
>
> 2021-09-15 [email protected] Initial commit for bluetooth classic medium notified of adapter scan mode change.
> PiperOrigin-RevId: 396955416
>
> 2021-09-13 [email protected] Finish off SystemClock
> PiperOrigin-RevId: 396369189
>
> 2021-09-11 [email protected] analytics: 3p NC: Implement AnalyticsRecorder::OnErrorCode
> PiperOrigin-RevId: 396041619
>
> 2021-09-11 [email protected] Initial implementation of ScheduledExecutor
> PiperOrigin-RevId: 396036314
>
> 2021-09-10 [email protected] analytics: 3p NC: Implement ErrorCodeRecorder for AnalyticsRecorder.
> PiperOrigin-RevId: 395881244
>
> 2021-09-10 [email protected] BEGIN_PUBLIC
> [Sharing][Analytics] Add set_device_name_dialog and set_data_usage_dialog to launch activity event.
> END_PUBLIC
>
> 09-08 11:24:29.372 24761 24761 I NearbySharing: NearbySharingLog:ActivityName: device_name_dialog, TimestampMillis:3072 [CONTEXT service_id=194 ]
> 09-08 11:24:36.160 24761 24761 I NearbySharing: NearbySharingLog:ActivityName: data_usage_dialog, TimestampMillis:3250 [CONTEXT service_id=194 ]
>
> PiperOrigin-RevId: 395864574
>
> 2021-09-08 [email protected] Initial implementation of SubmittableExecutor
> PiperOrigin-RevId: 395576173
>
> 2021-09-08 [email protected] Update to winrt headers
> PiperOrigin-RevId: 395381851
>
> 2021-09-08 [email protected] Initial implementation of Executor
> PiperOrigin-RevId: 395381292
>
> 2021-09-04 [email protected] analytics: 3p NC: Implement BandwidthUpgradeAttempt.
> PiperOrigin-RevId: 394802558
>
> 2021-09-03 [email protected] [Sharing][Analytics] Adding logging for missing permission request status (BT/wifi/location/airplane mode).
> PiperOrigin-RevId: 394772766
>
> 2021-09-03 [email protected] [Sharing][Analytics]
> 1. Adding acceptance status logging for LAUNCH_CONSENT event.
> 2. add new consent type for device contact consent.
>
> PiperOrigin-RevId: 394745696
>
> 2021-09-03 [email protected] analytics: 3p NC: Implement Payload.
> PiperOrigin-RevId: 394695112
>
> 2021-09-03 [email protected] update nearby_connections: proto: analytics: BUILD file.
> PiperOrigin-RevId: 394663167
>
> 2021-09-03 [email protected] [Sharing][Analytics] Adding DeclineAgreement logging when user drop off in opt-in page.
> PiperOrigin-RevId: 394616282
>
> 2021-09-03 [email protected] analytics: 3p NC: Implement EstablishedConnections.
> PiperOrigin-RevId: 394582833
>
> 2021-09-02 [email protected] Somehow this change was dropped.
> PiperOrigin-RevId: 394501870
>
> 2021-09-02 [email protected] Initial implementation of CountDownLatch
> PiperOrigin-RevId: 394478506
>
> 2021-09-02 [email protected] Missed the copyright date on these
> PiperOrigin-RevId: 394477350
>
> 2021-09-02 [email protected] analytics: 3p NC: Implement internal class PendingPayload and LogicalConnection. This is pre-work for EstablishedConnections.
> PiperOrigin-RevId: 394404345
>
> 2021-09-01 [email protected] Check in BLE cal interface.
> PiperOrigin-RevId: 394298358
>
> 2021-09-01 [email protected] Initial implementation of ConditionVariable and Mutex
> PiperOrigin-RevId: 394293910
>
> 2021-09-01 [email protected] nearby_connections: proto: analytics: sync protos and add unit test for proto ConnectionsLog.
> PiperOrigin-RevId: 394164605
>
> 2021-08-31 [email protected] Added ServiceControllerRouter Init/Close function
> PiperOrigin-RevId: 393999592
>
> 2021-08-31 [email protected] Saving the payload files with the file name and parent folder, so that Sharing doesn't have to rename/move the file.
> PiperOrigin-RevId: 393929024
>
> 2021-08-31 [email protected] Fixes memory leak in AnalyticsRecorder.
> PiperOrigin-RevId: 393905139
>
> 2021-08-31 [email protected] Fixes access ponter after free in connection_info.channel->GetMedium()
> PiperOrigin-RevId: 393904932
>
> 2021-08-30 [email protected] [Windows] Fix build from GetTid removal
> PiperOrigin-RevId: 393795930
>
> 2021-08-30 [email protected] Updating the winrt headers
> After this C/L you must update your Windows SDK to 10.0.20348.0 in order to build on Visual Studio
>
> PiperOrigin-RevId: 393786833
>
> 2021-08-27 [email protected] Remove GetTid() since it is not used.
> PiperOrigin-RevId: 393453493
>
> 2021-08-27 [email protected] Updated core_adapter.h to match the change on core_adapter.cc
> PiperOrigin-RevId: 393430067
>
> 2021-08-26 [email protected] ios: nearbyConnections: Fixes the issue that can't Advertise and Discover for WifiLan.
> - The local WifilanSocket and WifilanService is local variable which will be invalid if out of scope. Move them to the member and let the WifiLanMedium control the life scope.
>
> PiperOrigin-RevId: 393133266
>
> 2021-08-25 [email protected] Final implementation of all BluetoothAdapter methods
> PiperOrigin-RevId: 393009194
>
> 2021-08-25 [email protected] analytics: 3p NC: Implement ConnectionAttempt.
> PiperOrigin-RevId: 392794192
>
> 2021-08-24 [email protected] No changes to public files
> PiperOrigin-RevId: 392585608
>
> 2021-08-20 [email protected] analytics: 3p NC: Defines interface EventLogger for Analytics logger.
> - this is the init cl.
>
> doc: go/nc-analytics-api
> PiperOrigin-RevId: 391901111
>
> 2021-08-18 [email protected] remove ending new line character in attomic_boolean_test.cc
> PiperOrigin-RevId: 391602715
>
> 2021-08-18 [email protected] Fixes bluetooth_medium is not supported then don't continue for BleDiscoveredHandler.
> PiperOrigin-RevId: 391418495
>
> 2021-08-13 [email protected] BluetoothClassicMedium::GetRemoteDevice and BluetoothClassicSocket::Close implmentations
> PiperOrigin-RevId: 390691122
>
> 2021-08-13 [email protected] Cleanup Items that I didn't want or otherwise didn't get in the last c/l
> PiperOrigin-RevId: 390507261
>
> 2021-08-12 [email protected] Initial implementation of BluetoothServerSocket
> PiperOrigin-RevId: 390461649
>
> 2021-08-12 [email protected] Fix for the broken build, the signature of core constructor was changed, so I changed the core_adapter accordingly
> PiperOrigin-RevId: 390458570
>
> 2021-08-12 [email protected] Fixes the bluetooth MAC address not contained in ble_advertisement if invalid. Add the reserved bytes.
> PiperOrigin-RevId: 390290878
>
> 2021-08-12 [email protected] For the purpose of better understanding of the WiFi technology device used during Nearby Sharing, We'll log the above parameters into ClearCut server.
> Storage increase will be:
> 1.Build version: take RQ3A.210805.001.A1 as example, it needs 18 bytes in one device, so need 36 bytes in two devices.
> 2.Incoming or outgoing conection (
> 4 bytes tech +
> 4 bytes band +
> 4 bytes channel +
> 6 bytes network_operator +
> 2 bytes country_code +
> 1 byte tdls +
> 4 bytes try_counts +
> 1 byte wifi_ap_status +
> 4 bytes max_tx_speed +
> 4 bytes max_rx_speed) = 34 bytes)
> So need 34*4 = 136 bytes in two directions initial connections and two directions bandwidth upgrades.
>
> So there are total 172 bytes grows in each share.
>
> (172 bytes in each sharing * 400000 shares/daily * 7 days/week) / GB = about 0.45 GB) (400000 was based on current shares/daily in Prod.)
>
> PiperOrigin-RevId: 390282437
>
> 2021-08-11 [email protected] Client is able to send payload when the connection unencrypted, for example, NC allow client to send payload to multiple endpoints when at least one endpoint encrypted, it's a security leak that sending data to other unencrypted endpoint. Reject to send unencrypted data in PayloadManager to fix this.
> PiperOrigin-RevId: 390047577
>
> 2021-08-06 [email protected] Initial commit of the CancellationFlag implementation
> PiperOrigin-RevId: 389276621
>
> 2021-08-06 [email protected] input and output stream implementation
> PiperOrigin-RevId: 389229126
>
>
> Bug: 1252010, 1222385
> Change-Id: I46c9a441b9926285102170704e63b0fe2591dc36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197531
> Commit-Queue: Josh Nohle <[email protected]>
> Auto-Submit: Josh Nohle <[email protected]>
> Reviewed-by: Claude van der Merwe <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#928880}
(cherry picked from commit 58a09444b081d0fb2f533b4352815cb63395f026)
Bug: 1252010, 1222385
Change-Id: Ib267aa7077f7d7b5b5bb5317ac8782be8dfe9a0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212368
Commit-Queue: Josh Nohle <[email protected]>
Reviewed-by: Claude van der Merwe <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#929728}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216053
Commit-Queue: Michael Hansen <[email protected]>
Auto-Submit: Josh Nohle <[email protected]>
Reviewed-by: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#69}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
[merge-m96] [CrOS] Update media_app to oB5hBDW6dCKRTWwGV0l90ZOzeSkl3vPUyLvLhvwsLPgC
Cherry-pick of change to add metrics for PDF sidebar
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/oB5hBDW6dCKRTWwGV0l90ZOzeSkl3vPUyLvLhvwsLPgC
Release Notes: http://go/media_app-x20/relnotes/Branch/media_app_202110070700_RC01.html
Bug: b:199106985
Change-Id: I960e49e451309ea561343f4c647b8f290db1939c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218425
Reviewed-by: Patti <[email protected]>
Commit-Queue: Joseph Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4664@{#68}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
