Publish DEPS for 87.0.4280.60
Incrementing VERSION to 87.0.4280.60
[email protected]
Change-Id: I1e2ea113086bed9ff27b6395fc3ba987aac6d077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533959
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1352}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1605069352-9a2add8a7921165efb0cc9cf8dd44aef3ca50e9e.profdata to chrome-win64-4280-1605113899-3e957add540ce362e441f86296f74e09a1bf9a21.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I0813e30a8fd02ebd82ad190408a3099a9c4387ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533474
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1351}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1605113899-949eb51c00c24f3f77a20aced55fff8ec3e5a293.profdata to chrome-linux-4280-1605138881-bbb3dd3f7ed635292f565c63f82f5676e3f8b28e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I1a2e994d4a1932461d75fc5618eb35e2ee4a865d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533913
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1350}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge "Disable position:sticky in FIELDSETs" to M87 branch
Currently it seems to result in invalid sticky state.
(cherry picked from commit 5fe83660d892f97e104cc86c6c2a7a2d2f7c4eb8)
Bug: 1128479, 1146925
Change-Id: I62f7b5519e2851d6d804be5937a8bded0a7985f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525468
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532021
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1349}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac: Fix out-of-bounds access in GetAlteredLibraryData.
With a chance of 1/256, we'd read past the end of kValidLiteralValues.
In practice, that read would return zeroes, which we'd write to
kTestLibData -- but zeroes aren't valid literal values, so that would
then make TestShader() crash when it tried to link the program.
Not sure if this is related to crbug.com/1051923, but it's in the
same area at least.
Add a components/metal_util:unit_tests target. Covering code is useful
even if the test doesn't verify a lot, because then the ASan bots can
find stuff like this for us. (...but in this case, asan doesn't find
the out-of-bounds read because we build with `-asan-globals=0` on
macOS because of https://crbug.com/352073 .
But the test also checks for non-0 and runs the code often enough
that the test consistently fails before the fix and consistently passes
with it.)
Drive-by no-op cleanups while here:
- Remove EXPORTs on enums, they don't have any effect
- Remove redundant is_ios block in components/BUILD.gn
TBR=ccameron
(cherry picked from commit 9969257bc42b4b621e26a4b869f942324c2c2e0e)
Bug: 1147027,1051923,1085899
Change-Id: Ia7f9735e450c70eb64b826a499dc60690714112e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526161
Auto-Submit: Nico Weber <[email protected]>
Reviewed-by: ccameron <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825730}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533739
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1348}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1605113899-7ceab9c31d67fcbba953cf9370aef78492d7c536.profdata to chrome-mac-4280-1605138881-ba0475eb003ec9faa6c6002f0cb2b8df4aac47f6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ica8452afa5aacd47c8a452d65c01a331129ba37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533152
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1347}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87 Merge > Ensure children changed in new input type=search
What's happening is that as the search field goes from empty to having
text, the shadow generic container inside of the input goes from not
being in the tree to being in the tree. But in
AXNodeObject::ChildrenChanged(), we use LastKnownIsIncludedInTree() and
we can't update it to a new value. So we think it's still not included
in the tree, and update the parent's children. But we also need to
update its children too.
Bug: 1146214
Change-Id: I7b6c7ec6780d63fbcb0206e1d682f719d51acac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530130
Reviewed-by: Aaron Leventhal <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1346}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
rename the v8 context snapshot on arm64 macOS builds
This is done so that the arm64 and x64 v8 context snapshots can
live side by side in a universal app build of a Chromium based
application. All other files can be Mach-O universal binaries
generated using "lipo" but these snapshot files have to be uniquely
named so that both can exist in the Resources folder at the same time
and the correct one is chosen at runtime.
(cherry picked from commit 26713999e7f979a6abaef50c60e1e7310a85d5d5)
Bug: 1142017
Change-Id: I8449b72ba3a36e7ce69b9d9ec7768bd80ecc3e3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490980
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821439}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533694
Cr-Commit-Position: refs/branch-heads/4280@{#1345}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: s/liboah/libRosetta/ s/oah_/rosetta_/g
FruitCo advises that the oah names are deprecated in favor of the
Rosetta ones.
(cherry picked from commit f0ee6cc1bb1cd43c77981def047f23c1160105e2)
Bug: 1145672, 1145792, 1142017
Change-Id: I55892a5d9904c718068ecbd2485e7909b57e9a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527964
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825535}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533311
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1344}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add the ability to request Rosetta installation
(cherry picked from commit 7ee639e9c95400ead73288e7c79ff5530a3786f9)
Bug: 1145672, 1145792, 1142017
Change-Id: Idfb5ddc8f64a4f55814c5cc67d6852ca2cf3af3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520521
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824970}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533805
Cr-Commit-Position: refs/branch-heads/4280@{#1343}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: treat app_mode-Info.plist as Info.plist in universalizer
universalizer.py has special processing for Info.plist files, by looking
for informational keys that identify the build host, toolchain, and SDK,
and removing them when they differ rather than allowing such trivia to
cause the merge to fail. This is important for the time being, because
we’re using different toolchain and SDK versions for x86_64 and arm64
builds. This processing is enabled for any files that differ between
architectures named Info.plist.
One Info.plist in our bundle is not named Info.plist: the template
Info.plist used for app mode loader apps. In our .app, it’s named
app_mode-Info.plist. universalizer fails because of differences in this
file, and does not attempt Info.plist rationalization as described
above, which would allow the files to merge successfully.
The differences between x86_64 and arm64 in 88.0.4316.3: DTSDKBuild
(10.15 vs. 11.0), DTSDKName (macosx10.15 vs. macosx11.0), DTXcode (1210
vs. 1220), and DTXcodeBuild (12A4703 vs. 12B5035g). With this one
change, universalizer completes successfully and merges each
architecture’s .app into a single universal .app for that version.
(cherry picked from commit 75711c0e763b9031de48c6e1a7040d34ea38b2ff)
Code-Word: calamity
Bug: 1142017
Change-Id: I11d006bc5b053483f7630970242e289a7a0b1178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522005
Auto-Submit: Mark Mentovai <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824697}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533310
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1342}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: Only use x86_64 Widevine if Rosetta is installed
Rosetta will not be installed by default on macOS 11.0. In order to
avoid reporting EME to the web and then having it fail when an attempt
to use it is made, detect whether Rosetta is installed when the Widevine
CDM is registered and an x86_64 version is proposed for use under
Rosetta translation.
This depends on https://chromium-review.googlesource.com/c/2518258.
(cherry picked from commit 23402bd99e00e317c160729ab805f941055d0c30)
Bug: 1142017, 1145672, 1145792
Change-Id: I86ffa11af58291c41f38872216181ea0bbe2c115
Code-Word: calamity
CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520519
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824496}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533422
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1341}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: Package universalizer and tools to ship to designated bot
This includes universalizer.py and the Widevine signing scripts.
Depends on:
https://chromium-review.googlesource.com/c/2515521
and
https://chrome-internal-review.googlesource.com/c/3383223
https://chrome-internal-review.googlesource.com/c/3380436 (DEPS)
https://chromium-review.googlesource.com/c/2520327 (DEPS)
(cherry picked from commit e0d6f6f01de9d67960de957c8eb17338fed979b3)
Code-Word: calamity
Bug: 1142017
Change-Id: I83bc47a2edbd031f4d7f291a6b4922d3c862f1eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518800
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Michael Moss <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824392}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533682
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1340}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac: Tolerate "universal" and "arm64" prefixes in KSProductID.
(cherry picked from commit 46ba0a69b04136b8967c59e64705af7e1f936de3)
Bug: 1147858,1116601,1142017
Change-Id: I1611af0945f340f704055bedb3e1bffd5765c8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533015
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#826366}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533179
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1339}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add Rosetta utilities.
New macOS capabilities, more utilities in Chromium.
(cherry picked from commit 64e40a70b5f13c655289a68394e0da2de9bf80a1)
Bug: 1145672, 1145792, 1142017
Change-Id: Ibd10501429aba40aacb4db7c751385428115941d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518258
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824329}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533734
Commit-Queue: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1338}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: Run x86_64 Widevine, if available, under Rosetta
On mac-arm64, allow the x86_64 Widevine content decryption module (CDM)
to run under Rosetta translation, even when running native arm64 Chrome.
This is necessary because there isn’t currently an arm64-native Widevine
CDM. It’s not necessary to run the rest of Chrome as x86_64 under
Rosetta translation. The isolated Widevine CDM runs in its own x86_64
utility process, and is IPC-compatible with the rest of Chrome. This
alleviates any performance impact on the rest of Chrome, and allows
crash reporting to work correctly for the rest of Chrome.
An ordinary build of Chrome for mac-arm64, even an official build, will
not include a bundled x86_64 Widevine CDM library (or, obviously, an
arm64 one, as it does not yet exist). The x86_64 Widevine library is
useless to an arm64 Chrome without an x86_64 process to host it.
However, if a universal build of Chrome is created by merging
same-version x86_64 and arm64 builds, the arm64 code will look for an
x86_64 Widevine CDM and, if found, launch an x86_64 helper process under
Rosetta translation to host it.
https://chromium-review.googlesource.com/c/2515521/ is a proposal for
creating such a universal build.
Implementation notes: if no Widevine CDM library is found in the arm64
platform-specific location, Chrome on mac-arm64 will look for one in the
x86_64 platform-specific location. This allows mac-arm64 Chrome to find
the x86_64-only bundled Widevine library. Separately, any Widevine
library found will be examined to determine its architecture. If it
contains x86_64 code and no arm64 code, an x86_64 helper will be
launched to host it. This is done because, although the Widevine library
bundled in Chrome is known to be x86_64-only and will only exist in the
x86_64 platform-specific location, it is expected that a future update
distributed by the component updater will support arm64 natively.
However, in the event that a component update is produced that supports
x86_64 but not yet arm64, it is likely that the x86_64 version
distributed to arm64 users as a component update will appear in the
arm64 platform-specific location, despite being x86_64 code. This means
that the platform-specific location path cannot be trusted to convey the
actual architecture of the library contained therein, and the
architecture must be determined by examining the library to be loaded.
No behavior change for non-mac-arm64 builds.
(cherry picked from commit dcfbb59cc22614ae318618824fccc5d446adcb12)
Bug: 1142017
Code-Word: calamity
Change-Id: Ib3f4a654f89f41c0fbf9239f99010387ea242763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493191
Commit-Queue: Mark Mentovai <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Auto-Submit: Mark Mentovai <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823801}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533695
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1337}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: Create a universal .app from same-version x86_64 and arm64
This creates a script, universalizer.py, which can create a universal
.app by combining same-version x86_64 and arm64 .apps.
(cherry picked from commit 7a3a2e15714388cc2fb760c387e6e64a1153d3a7)
Code-Word: calamity
Bug: 1142017
Change-Id: I758469759aa0d4b9bd4559878943cdab3e6d3eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515521
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824159}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533421
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1336}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.59
[email protected]
Change-Id: I29ed3c44f49aaba9b0bc91446e9f227eb9c58bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532991
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1335}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fixes NTP Modules not showing if there is no promo
Modules wait for the promo to be loaded before showing. The promo is
considered loaded when the ntp-middle-slot-promo has been fired by the
promo element. This event is expected to be fired whether or not there
is a promo data available. crrev.com/c/2505739 changed that behavior
causing NTP Modules to remain hidden when there is no promo data.
(cherry picked from commit 560008790bedac97b5d53c13ef7acca10d5bb7af)
Fixed: 1147257, 1143366
Change-Id: If0c14ec8ee142fd38cdbc1bf9249f3345db6ca82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527854
Commit-Queue: Moe Ahmadi <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825668}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532865
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1334}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.47-1604920588-benchmark-87.0.4280.56-r1 to 87-4280.47-1604920588-benchmark-87.0.4280.58-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic12573f8e242ae92a98c167b3fe38d9a0c8a5e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532881
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1333}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.47-1604918591-benchmark-87.0.4280.56-r1 to 87-4280.47-1604918591-benchmark-87.0.4280.58-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7faff3c3ad2d69aa48e22fb14ac4fd7f673e68de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533297
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1332}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.47-1604923708-benchmark-87.0.4280.56-r1 to 87-4280.47-1604923708-benchmark-87.0.4280.58-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9684d07029c87596c9e7ef78f1b4ee128f62f609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532986
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1331}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1605082998-1ce13663588beed2c840b6ec6c690347af7cb442.profdata to chrome-linux-4280-1605113899-949eb51c00c24f3f77a20aced55fff8ec3e5a293.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ibbfef355e2ec09451eec7c7f1297e9b5ced91cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532983
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1330}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't reset crash count if a fallback option is available
Vulkan to GL fallback doesn't work on Android if the crashes occur after
successful initialization or context creation. These events reset the
GPU crash count to account for the GPU process being killed to free up
memory.
Instead, avoid resetting the crash count if there is at least one
fallback option available.
(cherry picked from commit 229973fe8ad4df93020e7a7a2fdc1afa3d5800a1)
Bug: 1142914
Change-Id: I865bb8551a41f74e9779fe7b89c0d9f184820439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510375
Reviewed-by: Jonathan Backer <[email protected]>
Commit-Queue: Sean Gilhuly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825922}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532249
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1329}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update gcpw extension period to be 1 hour
(cherry picked from commit 18f2790fd9ad2b1d38a4ab9d791f62dd5b2102fd)
Bug: 1147244
Change-Id: Ib0931d9d8090c343483a1d2c0bcf98ddc2c7d18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527687
Reviewed-by: Rakesh Soma <[email protected]>
Commit-Queue: Yusuf Sengul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533402
Reviewed-by: Yusuf Sengul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1328}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1605082998-0638edaa988a6f0becaf3b9f3734f58946a58077.profdata to chrome-mac-4280-1605113899-7ceab9c31d67fcbba953cf9370aef78492d7c536.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: If741452a20df4a133a8c4ac33c4cea5fecb3a7ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532981
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1327}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ic749a89562abd645a8d3d7efdcb04943e43abd46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533276
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1326}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[bfcache] Do not lose CSP policy headers after bfcache restore
At the moment CSP headers are stored in FrameTreeNode and reset when
the document in the FTN changes.
This patch:
- Disables resetting CSP policies stored on RFH when it is restored from bfcache.
- Copies the policies stored on RFH to FTN's replication state during bfcache restore.
- Evicts the page from bfcache if it has frame policy headers.
R=[email protected],[email protected]
BUG=1146025
(cherry picked from commit 45b716c6abc60b857e76a9ef5fb4bff345814072)
Change-Id: I486c9bf30670a21e631ec70f7efc2ed305c96e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519460
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Auto-Submit: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824694}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527128
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1325}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.47-1604923708-benchmark-87.0.4280.54-r1 to 87-4280.47-1604923708-benchmark-87.0.4280.56-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic94fd73376a3755a7a09c338042e0997f173d499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533097
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1324}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1605069352-eb649807a8431fed3fbaf78c0fdb9176cda859f8.profdata to chrome-linux-4280-1605082998-1ce13663588beed2c840b6ec6c690347af7cb442.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I864a8d969479edfaea753f94ecdd3a372980f901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532813
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1323}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1605069352-23168fe66889f5009df55c7aedffc0144431bf3b.profdata to chrome-mac-4280-1605082998-0638edaa988a6f0becaf3b9f3734f58946a58077.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ibda7d2d74b43aac57a4e7b83b7cc36f8cd986f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532620
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1322}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1605051153-a49feb17bad5ddc8739eddcf1eda3093d6d321a1.profdata to chrome-win64-4280-1605069352-9a2add8a7921165efb0cc9cf8dd44aef3ca50e9e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I118684d0cbc71cae251a7a6c14959fd4001aa82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531733
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1321}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1605027700-29eb84aa332e3ded4a2647d18d5acbebf43ee0c7.profdata to chrome-win32-4280-1605051153-f78d03f6505fa652e9da1fbf78a25d01c56beeeb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Id5a2cf96c70c5ed08fd01d4fa7dd82f8b69b9b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531187
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1320}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1605051153-3e7cfd90bc278db4bb52bd6cc3b37413b7b61475.profdata to chrome-linux-4280-1605069352-eb649807a8431fed3fbaf78c0fdb9176cda859f8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I1af4b955be1bb27887387f37a3d77b09b60101a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530147
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1319}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1605051153-86823a02c6f65328be2aa1782462eec3284ed25a.profdata to chrome-mac-4280-1605069352-23168fe66889f5009df55c7aedffc0144431bf3b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ib23c7a30c460ae76dc21ecfcaa57c38fc3a024c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530324
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1318}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604942259-9c48ebeeb7f9db7fd1810f20fecf6a94838b8a84.profdata to chrome-win64-4280-1605051153-a49feb17bad5ddc8739eddcf1eda3093d6d321a1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I3d6585f1d2c6b64c7fbc4dc25a19f838bd66fb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530620
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1317}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
components/arc: enable VideoDecoder-backed decoder support in GAVDA
Make GpuArcVideoDecodeAccelerator able to leverage VideoDecoder-backed
VDA (i.e. VdVideoDecodeAccelerator) if the arc::kVideoDecoder feature is
enabled.
Bug: b:136716838
Bug: b:171683262
Test: ./video_decode_accelerator_tests test-25fps.h264 --use_vd_vda
passes on Kukui.
Test: Add argument "--enable-features=ArcVideoDecoder"
and check that VdVDA is used when using Youtube on Kukui.
(cherry picked from commit f6d569e527e53cb29f88c30150f751964c963263)
Change-Id: I9e94484f3f67240cbdba2f8b1a312a1a2407752e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923969
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526719
Reviewed-by: Chih-Yu Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1316}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Resubmit: Enforce login when user policies not found or stale.
Login enforcement for policies is done only when cloud policies is enabled.
This cl is the same as one reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/2503810
but which was reverted due to time out issues on win-asan build. This cl
refactors the tests to decrease the number of scenarios being tested.
(cherry picked from commit 2f808a40f2ed28706c02140cec18d61139e5f6da)
Bug: 1142903
Change-Id: I97508f69ebefb15d1129f775743c27a5dac1a3dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518267
Reviewed-by: Yusuf Sengul <[email protected]>
Commit-Queue: Robin Lewis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824770}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530899
Commit-Queue: Yusuf Sengul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1315}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[PTZ] Cache list of zooms when enumerating cameras
VideoCaptureDeviceFactoryAndroid was getting zoom support for each
device every time when enumerating devices. This was problematic on some
devices where opening a camera breaks existing stream for that camera.
This CL adds cache of zooms in VideoCaptureDeviceFactoryAndroid. This
allows to workaround the bug by getting zoom support only once for each
device.
(cherry picked from commit 3bd31fd1f1f4252da320a63080faf12cafb22006)
Bug: 1138608, 934063
Change-Id: I29b15cca45fe5936e0b00e1548e9f48654bf9834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517465
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824587}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531062
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1314}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604998253-81fe6550a2036a276fe0a320b8df2c8f0f5856f0.profdata to chrome-win32-4280-1605027700-29eb84aa332e3ded4a2647d18d5acbebf43ee0c7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I98ad3dc700892318d5a51a7d51b9777214c21bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530610
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1313}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/chromeos: include media_log.h in video decoder factory's header
The video decoder factory object needs to know the size of MediaLog in
order to be instantiated. Include the header containing its definition
so users don't have to do it.
(cherry-pick note: required otherwise crrev.com/c/2526719 does not build).
BUG=b:136716838
TEST=Chromium builds.
(cherry picked from commit d572a10f24468712b524edc20b5c9016662623f6)
Change-Id: Idce313f58565f0b71788453d443910b5cc0a3647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503912
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Reviewed-by: Chih-Yu Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821983}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531082
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1312}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1605027700-c4b1ad8664f5a379ec2fd58585a5796551d617e6.profdata to chrome-linux-4280-1605051153-3e7cfd90bc278db4bb52bd6cc3b37413b7b61475.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I5bf01639185665f2451b29ccf542ba128d2a5ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530223
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1311}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1605027700-d8bd19a95e91f3a36874ef3ce1ac9f9730c094dd.profdata to chrome-mac-4280-1605051153-86823a02c6f65328be2aa1782462eec3284ed25a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ia507b48998c115517d2ab8a952a0e12b629c6a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531238
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1310}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.58
[email protected]
Change-Id: I74a8bee4c2b560e70ee06abf55efd8b9874fed96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530655
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1309}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "Suppress TabStrip IPH when bottom sheet shows"
This reverts commit 3474d13661e7c11bfdf4bdb637084262463d6e5b.
Reason for revert: Try to fix the failed test.
Original change's description:
> Revert "Suppress TabStrip IPH when bottom sheet shows"
>
> This reverts commit fffc75e94d969f8762bdb938377a94bb7a85a01c.
>
> Reason for revert: New test consistently fails Marshmallow 64-bit Tester bot.
> See: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester
>
> Original change's description:
> > Suppress TabStrip IPH when bottom sheet shows
> >
> > This CL hides TabStrip IPH when bottom sheet shows and reshows IPH
> > right after bottom sheet hides. This CL is gated by Finch parameter
> > "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate
> > function TabUiFeatureUtilities#isLaunchBugFixEnabled.
> >
> > Bug: 1135926
> > Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618
> > Reviewed-by: Matthew Jones <[email protected]>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
> > Commit-Queue: Yue Zhang <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#823416}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: I942224058529eb3e2eda72ca531f30d61d984724
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1135926
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518083
> Reviewed-by: Tommy Nyquist <[email protected]>
> Commit-Queue: Tommy Nyquist <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#823643}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because this is a reland.
(cherry picked from commit 6eb1f2c1f37250bbea5ad0794a5d3efac811b0e6)
Bug: 1135926
Change-Id: I9dba86c6464f53ef76a8613af759258eee6f3931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518262
Reviewed-by: Yue Zhang <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527030
Cr-Commit-Position: refs/branch-heads/4280@{#1308}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Cache list of supported formats when enumerating cameras
VideoCaptureDeviceFactoryAndroid was enumerating list of supported
formats for each device every time when enumerating devices. This was
problematic on some devices where opening a camera breaks existing
stream for that camera. This CL adds cache of supported formats in
VideoCaptureDeviceFactoryAndroid. This allows to workaround the bug
by enumerating formats only once for each device. Also updated
VideoCaptureFactory.java to make it possible to get unique device
IDs, not just indices.
(cherry picked from commit bf271f16b1279fc1abb6d6b063a3d2ee522b2701)
Bug: 1138608
Change-Id: Ib397b6cbe1f3e343fbb1e2187e91859576b6acc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494030
Commit-Queue: Sergey Ulanov <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824190}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529117
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1307}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Ignore RenderFrameHostImpl::Detach() for speculative RFHs.
Currently, this all happens to work by chance, because the speculative
RFH or the entire FTN happens to be torn down before the browser process
ever processes a Detach() IPC for a speculative RFH.
However, there are a number of followup CLs that restructure how
provisional RenderFrames are managed and owned in the renderer process.
To simplify those CLs, explicitly branch in Detach() based on whether or
not the RFH is speculative. In the future, additional logic may be added
to the speculative branch (e.g. cancelling the navigation, if
appropriate).
(cherry picked from commit cf054220a2e1570a9149220494de8826c2e9d4db)
Bug: 1146709
Change-Id: I6490a90f7b447422d698676665b52f6f3a6f8ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524280
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530190
Reviewed-by: Adrian Taylor <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1306}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Pepper: Ensure weak pointer is still valid before use (M87).
[email protected]
(cherry picked from commit f24c213293752250db05e11c5e4b77adce002d38)
Bug: 1146675
Change-Id: I382dcb5c0b09a26e3c397ebef46947f626e2aef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527065
Reviewed-by: Bill Budge <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825558}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527536
Cr-Commit-Position: refs/branch-heads/4280@{#1305}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] omnibox: fix possible crash
This is a regression from:
https://chromium-review.googlesource.com/c/chromium/src/+/2483342
The case under which the crash happens is when the internal cache
(URLIndexPrivateData) is being rebuilt on the history thread and
GetMostRecentVisitsForURL() returns false. I believe that basically
only happens if there is a problem with the db.
I would have liked a test for this, but there is no way to
force the db to return false.
BUG=1146970
TEST=none
(cherry picked from commit e292898e2818deaa250a358a572b0957d0851a3d)
Change-Id: Ied6a7e1c75ef8fcc47043d231f4877a597757bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527006
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825464}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527516
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1304}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
remoting: Move setting two capabilities to client_session.cc
Previously, rtcLogTransfer and webrtcIceSdpRestartAction were appended
to the host capability set in me2me_desktop_environment.cc and
it2me_desktop_environment.cc, but not in desktop_session_proxy.cc. The
latter omission prevented the associated functionality from working with
me2me on Windows hosts. Rather than setting the capabilities in yet
another location, this change moves setting them to client_session.cc,
which applies to all hosts, and is also where the associated
functionality is hooked up.
(cherry picked from commit 026b2d3ca1d4da8623288d6a4e7ffdb60279fa74)
Change-Id: Ib534a52016b30382f40e6cbbee0c7376b684514d
Bug: 1147147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525239
Commit-Queue: Erik Jensen <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825437}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530254
Auto-Submit: Jamie Walch <[email protected]>
Reviewed-by: Erik Jensen <[email protected]>
Commit-Queue: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1303}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.47-1604918591-benchmark-87.0.4280.54-r1 to 87-4280.47-1604918591-benchmark-87.0.4280.56-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8672a15e2f87a411179b2c4134288ec34d92c267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530469
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1302}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604986033-87c3ca1f42cf4ae798a4cd1c1bfa737a7340801e.profdata to chrome-win32-4280-1604998253-81fe6550a2036a276fe0a320b8df2c8f0f5856f0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I251a1ca1b386919f031304e5cd96520bf748bab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529183
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1301}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.57
[email protected]
Change-Id: I95b0fd859eae66060edbab222d7a79398854f127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530351
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1300}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.47-1604920588-benchmark-87.0.4280.54-r1 to 87-4280.47-1604920588-benchmark-87.0.4280.56-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia4f68f45d1e37bd2c175d6e1d0e26ec2727ebb3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530232
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1299}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604998253-cb11b6a528dbe33924f95d024f790f4e76d0a8f0.profdata to chrome-linux-4280-1605027700-c4b1ad8664f5a379ec2fd58585a5796551d617e6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ib1c1c0e51e086b11a731e8533422fac58a3760a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530149
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1298}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.47-1604923708-benchmark-87.0.4280.54-r1 to 87-4280.47-1604923708-benchmark-87.0.4280.56-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I871670984b42d46136dd4d6a6417ff42c851d40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530230
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1297}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
android: Disable zoom support checks for legacy camera devices
In the Camera v1 API the camera must be opened to read parameters
including whether or not it supports zoom. Opening the camera to read
these parameters can cause a conflict in some hardware drivers which
prevents the call to android.hardware.Camera.open() in allocate() to
fail. It is most important that the camera be openable at all than to
detect whether zoom is supported.
(cherry picked from commit 44f78acb314f9e329c9c6167d7a5133fe6c15982)
Bug: 1138608
Change-Id: If22ec843cab964f70a656eb73f9c9d325e018bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493421
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#820081}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529361
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1296}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604998253-50383524d74e79c685b8b4c27e9d27dd54f3350e.profdata to chrome-mac-4280-1605027700-d8bd19a95e91f3a36874ef3ce1ac9f9730c094dd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I45e19c4cce35769592f50f27cbd509fc46836008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529871
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1295}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
content-visibility: Make the property not animatable.
This patch makes the property not animatable. This goes with the
proposed issue here:
https://github.com/w3c/csswg-drafts/issues/5708
[email protected], [email protected]
[email protected]
(cherry picked from commit fe3cf4eb26af735748be1f873cf999d2b99c6297)
Fixed: 1146181
Change-Id: Ia352f2c5aab324b1426dd68c00d4d92ea0e760c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526901
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: vmpstr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825393}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529669
Reviewed-by: vmpstr <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1294}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Safety check on Android: fixed metrics recording
* Recorded the Safety check start in the Interactions histogram
* Added missing non-error PasswordsResult values
* Fixed UpdatesResult to use UPDATED instead of UPDATING
Merge approved in crbug.com/1145123.
(cherry picked from commit 2ce926117779447d712c81b020467c9efeab6e93)
Bug: 1145123, 1070620
Change-Id: I5c00fc8a9f34d6f802ce47263a3a6d5ec39d98f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516224
Reviewed-by: Martin Šrámek <[email protected]>
Auto-Submit: Andrey Zaytsev <[email protected]>
Commit-Queue: Andrey Zaytsev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823515}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527780
Commit-Queue: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1293}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.38-1604315340-benchmark-87.0.4280.52-r1 to 87-4280.47-1604923708-benchmark-87.0.4280.54-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2dbd48debd29b76bc290be393102435ffa6b3712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527579
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1292}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[crossOriginIsolated] Correct the metrics for SAB construction.
Correcting an inversed condition for recording isolated vs non
isolated SharredArrayBuffer constructions.
(cherry picked from commit a34d0cc3086c71cc25c32ee012e09e94db23e8b7)
Bug: 1143191
Change-Id: Ibd51e5eb13a3228732c1dad34405101fe824eb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527059
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Arthur Hemery <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825776}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529355
Reviewed-by: Arthur Hemery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1291}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "gpu: Disable SurfaceControl on Samsung devices running Q."
This reverts commit cbf1dfc1abb1cd78e358ce3611013e75134f04bf.
Reason for revert: crbug.com/1144660
Original change's description:
> gpu: Disable SurfaceControl on Samsung devices running Q.
>
> A platform bug can result in transaction acks getting dropped which
> stalls all rendering. A fix for this will be released in an R update
> soon so this changes disables using this API in Q.
>
> This also reverts an earlier workaround which was added for samsung dex
> mode since its not necessary after this change.
>
> [email protected]
>
> (cherry picked from commit c8c228066609798d4fae1ed46307fde1e33bc4a8)
>
> Bug: 1131081
> Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401
> Commit-Queue: Khushal <[email protected]>
> Reviewed-by: Bo <[email protected]>
> Reviewed-by: Tommy Nyquist <[email protected]>
> Auto-Submit: Khushal <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#820511}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514177
> Reviewed-by: Khushal <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4280@{#1030}
> Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1131081
Change-Id: I5989fd9e145fd31c91aa04d2842e975c71dc5364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527126
Reviewed-by: Khushal <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1290}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "[WebLayer] Fix autofill popup positioning"
This CL reverts
https://chromium-review.googlesource.com/c/chromium/src/+/2218704. That
CL worked around an issue with Android autofill popup positioning by
placing autofill interaction in a separate View that was pushed down by
the height of the WebLayer top bar. However, that solution now appears
to be creating its own issue: on Android 11, changes to support autofill
suggestions appearing inline in the keyboard mean that the view doing
autofill interaction needs to be the same one that the IME is aware of
as having focus. With that not being the case in WebLayer, autofill does
not trigger automatically (see crbug.com/1135076). Interestingly, this
is true whether or not the autofill service/IME pair result in inline
suggestions being used or the pre-11 popup.
Reverting this fix locally resulted in autofill triggering automatically
on Android 11 in an emulator. I have not been able to test the fix on a
physical device where inline autofill is supported by the IME. By
landing this change we can verify that it fixes crbug.com/1135076 on
canary. We will then need to develop an alternative solution to
crbug.com/1085294, as that bug will be reopened. The likely alternative
solution is to add support for adjusting the y location of
autofill-related elements in Chromium's glue code (i.e.,
AutofillProvider.java), and make use of that in WebLayer. There is
relevant discussion of that approach in comments 6 and 7 of
crbug.com/1085294.
(cherry picked from commit 050ac3d10c779fa8741e7c772f2363e6dc26c559)
Bug: 1085294, 1135076
Change-Id: Icc2484cdae9def9a7af95b094ef7221bd91706eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517470
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Auto-Submit: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824450}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529167
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1289}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604986033-03c546c802ffb73515824c1bdba32dec94609323.profdata to chrome-linux-4280-1604998253-cb11b6a528dbe33924f95d024f790f4e76d0a8f0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I3a572f197fa99affa92ffe3028a233b6fe5da2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529175
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1288}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Convert RAILMode tracing to perfetto
Updates DEPS to include perfetto change
f4cf78e052c9427d8b6c49faf39ddf2a2e236069
and backports 2 CLs to chrome:
> [scheduler] Convert RAILMode tracing to perfetto
>
> Emit Scheduler.RAILMode as a proto
> (ChromeRendererSchedulerState.ChromeRAILMode) added in:
> https://android-review.googlesource.com/c/platform/external/perfetto/+/1454655
>
> Also updates services/tracing/perfetto/privacy_filtered_fields-inl.h so
> the new fields are not filtered out.
>
> Change-Id: I610648e87b017237e261478163b34757605c166b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466244
> Commit-Queue: Dan Elphick <[email protected]>
> Reviewed-by: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#818472}
(cherry picked from commit 216b0aaaded9b4e1c97b4e09898ec978d68b0252)
> perfetto: Write track descriptors for custom perfetto::Tracks
>
> Up to now, while it is possible to pass custom perfetto::Track objects
> to typed TRACE_EVENT macros, the TrackDescriptors for these tracks were
> not written to the trace.
>
> This patch hooks up typed macros to perfetto's TrackRegistry. For this
> purpose, it adds another delegation callback through which the layer in
> //base can request a new TracePacket (for the descriptor) from the
> event sink in services/tracing.
>
> TBR: [email protected]
> Bug: 1065905
> Change-Id: Iadc7c47b9840a3c18ab9372cb7e3361c9b78d3d5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455608
> Commit-Queue: Eric Seckler <[email protected]>
> Reviewed-by: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815131}
(cherry picked from commit 741afc0ef41560b2d2094c30d8e4d8e29defbf21)
Bug: 1145956
Change-Id: I4f4fdbd928fce3c9bad3cb54c7e9109cf3a40e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529110
Commit-Queue: Dan Elphick <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Auto-Submit: Dan Elphick <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1287}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604986033-6428cfdfd857df74f7a0f575d88891ddf738e458.profdata to chrome-mac-4280-1604998253-50383524d74e79c685b8b4c27e9d27dd54f3350e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I6318b1296b22dfba2524616a7fc32559ede02e5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529172
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1286}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604942259-cfccd303670c26abe3ae20a66179f2a82f098eff.profdata to chrome-win32-4280-1604986033-87c3ca1f42cf4ae798a4cd1c1bfa737a7340801e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I0ec167f6635391d6b6119c2c86c45fe7f7caf512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528728
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1285}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Fix post-first run tasks in multiwindow.
Due to a mistake in refactoring, the EULA was never marked as read, and
the location pop-up was never shown. Fix these by moving relevant code
to scene controller.
It seems like running this code multiple times (if multiwindow is used
in FRE) is safe and will not cause issues.
Bug: 1145063
Change-Id: If61e1fdb75b8cf6e1743c543d4570279f1f7a2d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517953
Auto-Submit: Stepan Khapugin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#824034}
(cherry picked from commit 21e4b95e7213f97a172d018c5e681aa33e79ea15)
[email protected]
Change-Id: I1bb11ede4f0b19905017d2418c1ab518c1d0cbb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529094
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1284}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604942259-aa232d4619f0e0a9800306874dfd77b04d5cf8ce.profdata to chrome-linux-4280-1604986033-03c546c802ffb73515824c1bdba32dec94609323.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Iac352cdf22840681e4993cabf49509a511e9d432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527694
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1283}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Make uninstallation of extension robust
(cherry picked from commit 0aefefcfa6223b67cf227b7bbca8b7165502d87e)
Bug: 1142584
Change-Id: Icdae6303b0b04df7c1f0ecc4abe6705cd85f3946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518450
Reviewed-by: Rakesh Soma <[email protected]>
Commit-Queue: Yusuf Sengul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824541}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528090
Reviewed-by: Yusuf Sengul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1282}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604942259-bedcc9d2a8222fe9539f08323b4752ce936aa48f.profdata to chrome-mac-4280-1604986033-6428cfdfd857df74f7a0f575d88891ddf738e458.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I92a39c52077b9d907e9f00c1718f5f3272d236f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528723
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1281}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] ScalerImpl::Execute: Don't assume what texture unit is active
This code assumed texture unit 0 was active. In fact, sometimes the
current texture unit is different; in this case, the active texture unit
was 2, because Skia set it here:
gpu::gles2::GLES2Implementation::ActiveTexture(unsigned int)
skia_bindings::GLES2ImplementationWithGrContextSupport::ActiveTexture(unsigned int)
GrGLFunction<void (unsigned int)>::GrGLFunction<GrGLFunction<void (unsigned int)> (anonymous namespace)::gles_bind<void, unsigned int>(void (gpu::gles2::GLES2Interface::*)(unsigned int), gpu::gles2::GLES2Interface*, gpu::ContextSupport*)::'lambda'(unsigned int)>(void)::'lambda'(void const*, unsigned int)::__invoke(void const*, unsigned int)
GrGLGpu::setTextureUnit(int)
GrGLGpu::bindTexture(int, GrSamplerState, GrSwizzle const&, GrGLTexture*)
_ZNSt4__Cr10__function16__policy_invokerIFvRK15GrTextureEffectEE11__call_implINS0_20__default_alloc_funcIZN11GrGLProgram12bindTexturesERK20GrPrimitiveProcessorPKPK14GrSurfaceProxyRK10GrPipelineE3$_1S5_EEEEvPKNS0_16__policy_storageES4_
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrFragmentProcessor::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrPipeline::visitTextureEffects(std::__Cr::function<void (GrTextureEffect const&)> const&) const
GrGLProgram::bindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
GrGLOpsRenderPass::onBindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
GrOpsRenderPass::bindTextures(GrPrimitiveProcessor const&, GrSurfaceProxy const* const*, GrPipeline const&)
(anonymous namespace)::FillRectOp::onExecute(GrOpFlushState*, SkRect const&)
GrOp::execute(GrOpFlushState*, SkRect const&)
GrOpsTask::onExecute(GrOpFlushState*)
GrDrawingManager::executeRenderTasks(int, int, GrOpFlushState*, int*)
GrDrawingManager::flush(GrSurfaceProxy**, int, SkSurface::BackendSurfaceAccess, GrFlushInfo const&, GrBackendSurfaceMutableState const*)
GrDirectContext::flush(GrFlushInfo const&)
media::VideoFrameYUVConverter::ConvertFromVideoFrameYUVSkia(media::VideoFrame const*, viz::RasterContextProvider*, unsigned int, unsigned int)
media::VideoFrameYUVConverter::ConvertFromVideoFrameYUVWithGrContext(media::VideoFrame const*, viz::RasterContextProvider*, gpu::MailboxHolder const&)
media::VideoFrameYUVConverter::ConvertYUVVideoFrame(media::VideoFrame const*, viz::RasterContextProvider*, gpu::MailboxHolder const&)
media::PaintCanvasVideoRenderer::CopyVideoFrameYUVDataToGLTexture(viz::RasterContextProvider*, gpu::gles2::GLES2Interface*, media::VideoFrame const&, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool)
blink::WebMediaPlayerMS::CopyVideoYUVDataToPlatformTexture(gpu::gles2::GLES2Interface*, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool, int, blink::WebMediaPlayer::VideoFrameUploadMetadata*)
non-virtual thunk to blink::WebMediaPlayerMS::CopyVideoYUVDataToPlatformTexture(gpu::gles2::GLES2Interface*, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, int, bool, bool, int, blink::WebMediaPlayer::VideoFrameUploadMetadata*)
blink::WebGLRenderingContextBase::TexImageHelperHTMLVideoElement(blink::SecurityOrigin const*, blink::WebGLRenderingContextBase::TexImageFunctionID, unsigned int, int, int, unsigned int, unsigned int, int, int, int, blink::HTMLVideoElement*, blink::IntRect const&, int, int, blink::ExceptionState&)
blink::WebGLRenderingContextBase::texImage2D(blink::ExecutionContext*, unsigned int, int, int, unsigned int, unsigned int, blink::HTMLVideoElement*, blink::ExceptionState&)
blink::WebGL2RenderingContextBase::texImage2D(blink::ExecutionContext*, unsigned int, int, int, unsigned int, unsigned int, blink::HTMLVideoElement*, blink::ExceptionState&)
(cherry picked from commit e06c7f412570503b67712a1e66e8990cca374782)
Bug: 1103385
Change-Id: I3a4bdd41613de448effcaa676870b60d7190cb64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522119
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825000}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528631
Reviewed-by: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1280}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix GPU hang in VulkanSwapChain::Destroy()
Because a mesa bug, the vulkan swapchain can hang with X11, fix the
hang by using a one second timeout with vkWaitForFences() call.
(cherry picked from commit 8da24db89e595d087b0e09b8c35265c2e2813651)
Bug: 1130495
Change-Id: Id9f36a3b087e9d7f6307e708a5cde41d631a9d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518949
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Auto-Submit: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824398}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527607
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1279}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604892531-4c2d2f9419aac8f4a19381c3803185c13fe2137c.profdata to chrome-win32-4280-1604942259-cfccd303670c26abe3ae20a66179f2a82f098eff.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Iea1d4338b5edf16886feab248e98eb2c72f8a0c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527669
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1278}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.56
[email protected]
Change-Id: I1a19d4f4a41b0ea1c12e8cad41f99895fce01028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527626
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1277}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] weblayer: adds Profile.destroyAndDeleteDataFromDiskSoon
This method immediately marks the profile for deletion, and calls
destroyAndDeleteDataFromDisk() when safe. Safe means no more browsers
reference the profile.
I kept most of the logic for this in the Java side, as I don't think
the C++ side needs this.
BUG=1142989
TEST=testDestroyAndDeleteDataFromDiskSoonWhenInUse and
DestroyFromOnBrowserRemoved
(cherry picked from commit 6acf9a27321be19bb314d88e7969249e563767d7)
Change-Id: Ic5322022ab49a515d6e0319159ff79c91249db7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519836
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824238}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528124
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1276}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Avoid too many tiles and out of tile memory for huge layer with tiny scale"
This reverts commit 26ce69a0d26a920ff8411cadb7a551093171da60.
Reason for revert: crbug.com/1146393, tiling issues caused by the CL.
Reverting in M87.
Original change's description:
> Avoid too many tiles and out of tile memory for huge layer with tiny scale
>
> Some web sites create huge layers with tiny scale. Previously because
> the scale was clamped to minimum scale, causing too many tiles with too
> big scale and out of tile memory.
>
> This CL contains the following changes:
>
> 1. Remove LayerTreeSettings::minimum_contents_scale. It was added when
> we used layer coordinates in PicturePile and needed to expand record /
> invalidation rects by 1/scale pixels to ensure all affected texels were
> covereda. The minimum scale avoided problems caused by too many pixels
> to expand when the ideal scale was too small. Now we use texel
> coordinates in PictureLayerTiling and all rects in layer coordinates
> will be mapped into texel coordinates by scaling the rect then getting
> the enclosing int rect, which ensures coverage of affected texels, so
> the minimum scale is no longer useful.
>
> 2. Adjust scale clamping for will-change:transform.
> a) If the ideal scale is much smaller than the native scale, don't clamp
> to the native scale;
> b) Update raster contents scale only if it's too small compared to the
> ideal contents scale. Without this, we would update tiny raster contents
> scale when the ideal scale changes which would defeat the optimization
> for will-change:transform.
>
> [email protected]
>
> (cherry picked from commit 3e50c687f35e8b20c083aae67ed4a7112d28c42d)
>
> Bug: 1132991
> Change-Id: I3a31f654fe4a5ccc925aaad3a2b75748c4e37164
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438756
> Reviewed-by: vmpstr <[email protected]>
> Commit-Queue: Xianzhu Wang <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#812867}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447650
> Reviewed-by: Xianzhu Wang <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4280@{#11}
> Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1132991
Change-Id: Iff09ed72514f8591223d3f7f36a0aa91590a41ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527769
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1275}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87][Signin][Android] Don't call OpenAccountPickerBottomSheet with null WindowAndroid
Fixes a crash when OpenAccountPickerBottomSheet would be invoked with
a null WindowAndroid when the accounts.google.com are prefetched in the
background.
(cherry picked from commit 674e62896d68b0a86ec2096325128362b3a076a0)
Bug: 1145031
Change-Id: I77278604fe9e825c0773facab9c6887a468da47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517451
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824444}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527423
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1274}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604919303-ecc1fd0411c30656145efdd6d4961f7ba2295117.profdata to chrome-win64-4280-1604942259-9c48ebeeb7f9db7fd1810f20fecf6a94838b8a84.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I7d224a3cc6860217da3d6f4cbf82af7832a6243b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527668
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1273}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: Call the callback function when the pause app dialog is closed.
SetAcceptCallback for the pause app dialog only quarantines the callback
function is called when the OK button is clicked. When press 'esc' to
dismiss the dialog, the callback is not called.
For the pause app dialog, the callback function should be called when:
1: the OK button is called
2: 'esc' is pressed to dismiss the dialog,
The dialog view needs 2 separate callback functions for Accept and Close
cases separately, however, we have 1 callback only. So we don't use the
dialog view's function, but create the local closed_callback_ variable,
and when the pause app dialog is destroyed, call the closed_callback_,
so both the above 2 scenarios can call the callback function.
The browser test is modified to test the above 2 scenarios.
BUG=1144386
(cherry picked from commit 9f3abedeb05ccf2478efcf14b0aec37d0d293942)
Change-Id: I5dd7accfd4e16fcafb7d019877c648b25d71b881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515864
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823872}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526704
Reviewed-by: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1272}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Disable visual detection if on Android.
Client side detection is currently enabled
on Android but there was no check to prevent
visual detection from being done and is
causing crashes in PaintPreviewTracker on beta.
(cherry picked from commit 9a12143ebc4af79d357a6db0a96373be93bea62a)
[email protected]
Bug: 1146121
Change-Id: Ieba3aae6defa53a1859389deb0d97c08858707bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521353
Commit-Queue: Bettina Dea <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824679}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527882
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1271}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] cert_provisioning: Fix invalidation handling
The invalidation topics in certificate provisioning are public, not
private.
Also, fix CertProvisioningWorker accidentally invalidating the weak
pointer it used to bind the OnShouldContinue callback.
Add a unit test for that case (fails without the fix).
(cherry picked from commit 86cbe826ba5c985bbd1d692fcf9bd15ffecc075c)
Bug: 1146410
Change-Id: Ib3024d977de3de2a2b75de0c0b279dd0c8764883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523208
Commit-Queue: Pavol Marko <[email protected]>
Reviewed-by: Michael Ershov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524481
Cr-Commit-Position: refs/branch-heads/4280@{#1270}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Enforce AllowFileSelectionDialogs on chrome://webrtc-internals/
(cherry picked from commit 0915ac94ccd5d05266009907215e94a8aab1baad)
Bug: 1137362
Change-Id: I41c4d316f614358ecb53a81f08216e00d0146081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508229
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Auto-Submit: Yann Dago <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824482}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527623
Reviewed-by: Yann Dago <[email protected]>
Commit-Queue: Yann Dago <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1269}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[merge M87] Fix text eliding for single-codepoint text with BiDi
This CL is fixing a corner case where RenderText::Elide(...) may
produce a text with more codepoints than the original one. This is
an issue since the breaklists are not resized and the overflow
will lead the render_text code to perfoarm an out-of-bound memory
access by deferencing breaks_.end() while rendering the text. This
is causing chrome to crash.
See crbug/1142020 for details.
The bug was happening when:
1) The text to elide was a single codepoint
2) The width of the glyph of the codepoint is larger than the width
of the ellipsis glyph
3) Eliding is set to ELIDING_TAIL
4) The display_rect width will trigger eliding
(smaller than codepoint width, but larger than ellipsis width)
5) The render text is set to RTL
A possible solution is to adjust the breaklist but this required
larger refactoring and cannot be a minimal patch to be merge on
other channels.
[email protected]
(cherry picked from commit e54920751871321474e0b953329c8aedcc8702c3)
Bug: 1142020
Change-Id: I9854651175562ec5f0d0bf7083a8da99fede0e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522892
Commit-Queue: Etienne Bergeron <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824878}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527545
Reviewed-by: Etienne Bergeron <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1268}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87] Don't treat failure in CreateSharedImageWithAHB as an error.
Some video frames could time out and would not be able to produce/render
the decoded data to an AImage. Hence no AHB would be available for those
frames.
If there is no AHB, then we should not treat it as error in
empty mailbox.
(cherry picked from commit 50da6598f95390e9742146152e1ba09091c5cfe1)
SharedImageStub: :CreateSharedImageWithAHB. Instead just return with the
Bug: 1141004
Change-Id: I07e3e966bf070787a230ef3f7a09a5182907f8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495600
Auto-Submit: vikas soni <[email protected]>
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#820416}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526630
Reviewed-by: vikas soni <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1267}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Remove incorrect check in MHTMLBodyLoaderClient::Detach.
(cherry picked from commit 899eea0a38587902dd261fb8d04995e4eba1e3e5)
Bug: 1131879
Change-Id: I12e46e7c7edcbf41a6c51b5f2210a3eaed1412ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521872
Reviewed-by: danakj <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824580}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525858
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1266}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.38-1604315340-benchmark-87.0.4280.53-r1 to 87-4280.47-1604923708-benchmark-87.0.4280.54-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I80671bf6967b72eab78ab58eb696d8f10bea306a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527561
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1265}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604919303-ad6215a901e87e77c5027126f571da940cf5f8f2.profdata to chrome-linux-4280-1604942259-aa232d4619f0e0a9800306874dfd77b04d5cf8ce.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ic82eb8eaa4b17a23fc453d976fe28fe93811ce1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527762
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1264}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.55
[email protected]
Change-Id: I46ee74869c955b860b06c8b1209149fbf38a3423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527603
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1263}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.24-1604317572-benchmark-87.0.4280.53-r1 to 87-4280.47-1604918591-benchmark-87.0.4280.54-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib4f3f457d5994812385d222eeca6e87e7d147a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527667
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1262}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.24-1604319793-benchmark-87.0.4280.53-r1 to 87-4280.47-1604920588-benchmark-87.0.4280.54-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I31d5dd481ee8b163b08a0deef384fc7d714cbb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527662
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1261}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] weblayer: adds support for multiple incognito profiles
BUG=1142989
TEST=twoFragmentsDifferentIncognitoProfiles twoFragmentsSameIncognitoProfile testMultipleIncognitoProfiles
(cherry picked from commit 1f1f459454fcd0d85d1193fa53ae7297e5171417)
Change-Id: I50ab97c20036466b697b88ca9e78e5d2cf5fed39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510731
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823652}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526169
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1260}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604919303-c13c78e3723c204ae5d098572b3af0b276a159a4.profdata to chrome-mac-4280-1604942259-bedcc9d2a8222fe9539f08323b4752ce936aa48f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Id91cd018933e40772b2779ee2e45ebdbc492bfc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525753
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1259}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[discardable] Fix setting task runner for Periodic Purge.
The task runner used to run the periodic periodic was not set properly,
causing DCHECKs to fail. This CL fixes this issue.
Periodic Purging continues to be disabled by default, so this CL causes
no change in functionality.
(cherry picked from commit af79a3bba1bf785c311327e80b394ac551b46b60)
Bug: 1131857
Change-Id: If3bd626e9f5ac3c52b7d9e181605882c134d115e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519032
Commit-Queue: Thiabaud Engelbrecht <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Reviewed-by: Benoit L <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527161
Commit-Queue: Benoit L <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1258}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M-87][Web Payment] Cancel pending database operations.
Before this patch, payment credential storage and retrieval did not
cancel database operations when secure payment confirmation was being
torn down, so the database operation callbacks could use secure payment
confirmation code path after free.
This patch cancels the payment credential storage and retrieval
operations during the tear down.
After this patch, there is no use-after-free errors when a database
operation is in flight during secure payment confirmation tear down.
(cherry picked from commit 9244d6d8ec3867d9b83ea93831e5fd2eedfdb49e)
Bug: 1136078
Change-Id: I2a02089f4ab5c3c8ae5ebed91304b11e1c1eaf36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518924
Reviewed-by: Nick Burris <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824186}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526927
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1257}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Autofill: Fix a AutofillProvider crash
(cherry picked from commit 8d58c51e6332e5375f505e687789d20574a6e9d4)
Bug: 1145964
Change-Id: I7cf1fbb239ec0a97e69e4d6ea2e15015ecb5fd3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521972
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Michael Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824953}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526623
Reviewed-by: Michael Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1256}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable flaky SyncTest
This CL disables the following test:
* org.chromium.chrome.browser.sync.SyncTest#testSignInAndOut
Because it's flaky on builder:
* android-arm-beta-tests
[email protected]
(cherry picked from commit 6a08b611326f8072ffce163d3d69083ee2f83951)
Bug: 1144221
Change-Id: I18fb396a0f54a5f2e351245a66b6c592b7b9e820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510611
Reviewed-by: Salvador Guerrero <[email protected]>
Commit-Queue: Salvador Guerrero <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822728}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525852
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1255}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604878061-50cd9fdcfe7ae1de4e4673491372a384c2c4637f.profdata to chrome-win64-4280-1604919303-ecc1fd0411c30656145efdd6d4961f7ba2295117.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Ia9eb4e9b192b2f870861b7deaec4667b2ca383df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526726
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1254}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.38-1604315340-benchmark-87.0.4280.51-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.52-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7112b71b55426d211f31fd795742bf87a64f6b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525743
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1253}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87] Record when text selection is in iframe
(cherry picked from commit 67883843f1c802bd5dcca3d8e1eb983a33ba6571)
Bug: 1139864
Change-Id: I489134eaa612308327ea87dc7fbab1409aeee6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513290
Commit-Queue: Gayane Petrosyan <[email protected]>
Reviewed-by: sebsg <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824048}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523542
Reviewed-by: Gayane Petrosyan <[email protected]>
Commit-Queue: sebsg <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1252}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[crossOriginIsolated] Adding ukm for non isolated SAB instantiation.
We are already recording instantiations of SharedArrayBuffer, recorded
for approximately 1.7% of page visits. SharedArrayBuffer is going to be
gated behind the crossOriginIsolated boolean in M91 and we'd like to
know of potential high profile breakages before going forward. To this
end, this patch does the following:
- Adds a Webfeature, recorded only when a SharedArrayBuffer is
instantiated without the appropriate isolation level.
- Adds this WebFeature to the list of WebFeatures to be URL-keyed.
This new metric would be strictly lower than 1.7% of page loads, close
to it at the beginning and progressively going to 0% before M91.
(cherry picked from commit 6965a25efadd15aec76dd751d7f1c7dadb834029)
Bug: 1143191
Change-Id: I4c093c791c75faf4b5c94ae9f7a5a21c99b3f81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509514
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Ulan Degenbaev <[email protected]>
Commit-Queue: Arthur Hemery <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824363}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521733
Reviewed-by: Arthur Hemery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1251}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604892531-3b679ac4c7b5f16d20f818c091e62cb7fd184fa2.profdata to chrome-linux-4280-1604919303-ad6215a901e87e77c5027126f571da940cf5f8f2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I66d087fe72a3de35b42f9a6bc62ad2b44f33dca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526723
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1250}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604892531-891ecd3dbc2fff9317fa4b16ff66d79bf3f304b3.profdata to chrome-mac-4280-1604919303-c13c78e3723c204ae5d098572b3af0b276a159a4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I48ad67a91324a158c6b4a596e091f266043467a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526376
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1249}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604852181-af3b6184070ff3d18a1097f130172cbdaf4b1c25.profdata to chrome-win32-4280-1604892531-4c2d2f9419aac8f4a19381c3803185c13fe2137c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Ic8dd28b919e53ea8603aa482259888e603ec420a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525662
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1248}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add ports 5060 and 5061 to the restricted list
Some NAT devices examine traffic on port 5060 to look for a valid SIP
message. If they find one, they will forward a port back to the origin
host. A carefully crafted HTTP request can trick these NAT devices into
forwarding an arbitrary port. See https://samy.pl/slipstream for more
details on the attack and sample code.
Block port 5060 for HTTP. Out of an abundance of caution, and to match
the Fetch standard (https://github.com/whatwg/fetch/pull/1109), also
block port 5061 (SIP over TLS).
Also reduce the whitespace before protocol description comments. This
was insisted on by clang-format and is not worth fighting.
BUG=1145680
(cherry picked from commit 90d1302aec437166b383eabc08af741bf24f7ea8)
Change-Id: I3a556fbbb4dc6099caa4418addaf1e89bf254ae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519174
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824254}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525474
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1247}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.38-1604315340-benchmark-87.0.4280.52-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia3ea094f4281e199e4e30735cf03bc098b72a02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525761
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1246}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604878061-dda6557a9f19cf8a9398d42e59c5e8dfd036f8bd.profdata to chrome-linux-4280-1604892531-3b679ac4c7b5f16d20f818c091e62cb7fd184fa2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I4079b60bfd8bc1b6f9e38306dfa74f121222dd6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525661
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1245}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604878061-a18e8469bfbb57827e912a88158191b17268aff2.profdata to chrome-mac-4280-1604892531-891ecd3dbc2fff9317fa4b16ff66d79bf3f304b3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ib03929c38519636e38bf1bfbb44299412d597453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524759
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1244}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Tab Search: Show Tab Search only on Normal browser windows
(cherry picked from commit 48844372b6f1252c3d16b2d2135b058f97240a2e)
Bug: 1140658
Change-Id: I2571a52f65ec79d7a62558c8af37fb10b7bcae59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495502
Reviewed-by: Taylor Bergquist <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#820418}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515795
Cr-Commit-Position: refs/branch-heads/4280@{#1243}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604852181-f99c4f564bd201cab652273abd6fd221017ab1da.profdata to chrome-win64-4280-1604878061-50cd9fdcfe7ae1de4e4673491372a384c2c4637f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Icbc65a614dfbfbb6201db1891e525a1cf4dce777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525267
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1242}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604852181-4e3e74f9e7f8b8960b48a7adb8743a5e7c30fa41.profdata to chrome-linux-4280-1604878061-dda6557a9f19cf8a9398d42e59c5e8dfd036f8bd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Id5e91c9af129b7c64fb9e5ff68fb3bf3e1912949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525164
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1241}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604852181-613dae63116ad5ec6e79677a3268a62b158236f6.profdata to chrome-mac-4280-1604878061-a18e8469bfbb57827e912a88158191b17268aff2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I9070befa706b41c4eabbb26b94c50e2da7074bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524893
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1240}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.54
[email protected]
Change-Id: I3226c55217246ecd4fc4bc83a85e0dc58d2c0efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524822
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1239}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable FST UIL by default
Bug: 1134364
Change-Id: I8ab9e7c9c2ef30c5ffa70d49067346d86e559335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524808
Commit-Queue: My Nguyen <[email protected]>
Reviewed-by: My Nguyen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1238}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[merge m87][extensions] Add feature param to control the delay to suspend an extension event page.
Intensive wake up throttling limits wake ups from Javascript timers to
1 per minute for pages that have been backgrounded for 5 minutes. A
side-effect of this change is that pages that used to cause frequent
extension messages (e.g. navigation commit) now cause extension messages
only once per minute. Because extension processes can be terminated after
15 seconds of inactivity, keeping most pages idle for 1-minute intervals
*increases* extension process churn (extensions processes that were
kept alive permanently by frequent messages are now recreated every
minute).
This CL adds a feature param to control the inactivity delay to
terminate an extension page. We plan to experiment with a 65 seconds
delay (slightly longer than the intensive wake up throttling delay) and
assess impact on resource consumption (CPU + memory + power).
(cherry picked from commit dd60a7b79734aff91f49a7f90f01d61fae8c063a)
Bug: 1144166
Change-Id: If7b797f375b4ad37c753b8b43e32898e197a91ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510431
Commit-Queue: François Doray <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823421}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524684
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1237}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Rebuild parent frame GraphicsLayers if a subframe has dirty root layer attachment
When a frame rebuilds its GraphicsLayer tree, we mark its root layer
attachment dirty. Previously when we updated GraphicsLayer tree of the
parent frame and saw a subframe had the flag, we forced rebuild of the
parent frame's GraphicsLayerTree. However, if the parent frame didn't
have any compositing update flag set, we wouldn't do GraphicsLayer tree
update, and the subframe's root layer would be left detached.
Now check child frame's root layer attachment dirty flag when we walk
the frame tree, which is unconditional, and set the parent layer
needing rebuild GraphicsLayer tree if any child frame has the flag set.
Haven't created a simple test case for the bug. It happens as the
following:
1. Some change in a subframe happens, requiring paint property update,
but not compositing input update.
2. During paint property update, we mark the subframe's compositor
needing compositing update.
3. During compositing update for the subframe, we rebuild the
GraphicsLayer subtree and set the root layer attachment dirty.
4. Previously, as the parent frame didn't have any compositing flag
set, the subframe's GraphicsLayer was left unattached.
Now we force the parent frame to rebuild GraphicsLayer tree.
Bug: 1142725
Change-Id: I11bd1839cf410aec4dd1e4ae87e9df32de9d210b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522877
Reviewed-by: Stefan Zager <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#825046}
(cherry picked from commit 511e3d5913cd42e0981024cbdd517c4c07f607b6)
[email protected]
Change-Id: Ida4922f35170051046327dad367ed8fcd97c5253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525224
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1236}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Stop removing WS_THICKFRAME style on full screen."
This reverts commit 00952e6e1f8f7756f1bb0f088143c2b6ddd309f9.
Reason for revert: <crbug.com/1141059>
Original change's description:
> Stop removing WS_THICKFRAME style on full screen.
>
> Also, change IsFullScreenWindowMode to not require the absence of
> WS_THICKFRAME when deciding if a window is full screen.
>
> This issue this fixes involves the glass_browser_frame_view when
> maximizing after going full screen - an extra 8 pixel bar gets drawn
> above a maximized window, and if there's another monitor
> above the one with chrome maximized, the bar gets drawn on
> the other monitor.
>
> Windows doc
> https://docs.microsoft.com/en-us/windows/win32/winmsg/window-styles
> claims that some styles can't be changed after the window is
> created, but also says that if you change frame styles, you
> need to call SetWindowPos with SWP_FRAMECHANGED, which we are doing.
>
> Not removing the WS_THICKFRAME style doesn't seem to have any visible
> effect on full screen windows.
>
> Bug: 1014720
> Change-Id: Ibfbd480c603fd7c3aca74081201e99e59fbbbecc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972258
> Reviewed-by: Peter Kasting <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Commit-Queue: David Bienvenu <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#791237}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 40351207e40888d64d3e02711287144ede7b4454)
Bug: 1014720
Change-Id: I4a35fccff45ba0994157939fe5fa95107ecb0334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522875
Reviewed-by: David Bienvenu <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824749}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525228
Cr-Commit-Position: refs/branch-heads/4280@{#1235}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604830586-176bd9ff48d3b93391fd5807db3af0fdbbb186e2.profdata to chrome-win32-4280-1604852181-af3b6184070ff3d18a1097f130172cbdaf4b1c25.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I8e2ddb3dba56deeaf669f748a801107e3706aae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525110
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1234}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604830586-efa77a8f590b232c627a0697ecaff0a5ae3c609e.profdata to chrome-win64-4280-1604852181-f99c4f564bd201cab652273abd6fd221017ab1da.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Idf2373aa46fa6cf8303ea9e62eb66f7eac20aa5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525162
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1233}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.24-1604317572-benchmark-87.0.4280.52-r1 to 87-4280.24-1604317572-benchmark-87.0.4280.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic18762a516db6048aec24fe7843d11f03e0c7083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525113
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1232}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.24-1604319793-benchmark-87.0.4280.52-r1 to 87-4280.24-1604319793-benchmark-87.0.4280.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id149914b26b1c2fec4966888e7563888f47b6a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525112
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1231}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604830586-66f57bf2bdb3c66e4ed5376f24c224758bf444ab.profdata to chrome-linux-4280-1604852181-4e3e74f9e7f8b8960b48a7adb8743a5e7c30fa41.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ib44c165e0ee6b670087bae2335dd9062577654c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525108
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1230}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604830586-60f606b823c8155b39a3935aa473425f15dea1d2.profdata to chrome-mac-4280-1604852181-613dae63116ad5ec6e79677a3268a62b158236f6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I9fddf5a2ac645b7e48b38b51e951f2228cd3c6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525161
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1229}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] android: disable sync when hiding navigations
This is a follow on to:
https://chromium-review.googlesource.com/c/chromium/src/+/2505698/
Without this patch, when signed in with history sync enabled,
chrome://history would still show visits from CCT. This patch makes it
so such visits are no longer pushed to sync and won't be
visible in chrome://history.
This is for an experiment, and only enabled for 1 parties if the right
intent extra is provided.
This code is temporary, and will be reverted once data from
experiment has been collected.
BUG=1145208
TEST=TabAndroidBrowserTest.SetHideFutureNavigationsPropagatesToSyncedTabDelegate
(cherry picked from commit 4d93009e275d932b12eade50b6783172bf6b4dbd)
Change-Id: I9008ea6c581c7e90737128e4643fd066105cc6dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518403
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823775}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524923
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1228}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604814065-218668c7df8462a909152c91c81b53b179ecc24e.profdata to chrome-win32-4280-1604830586-176bd9ff48d3b93391fd5807db3af0fdbbb186e2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Ie69b3e7c8f44e2b931e999ee2df29f83e9082eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524656
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1227}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604814065-30b0fe229c257336a943a19816df5b9bda7d2df3.profdata to chrome-win64-4280-1604830586-efa77a8f590b232c627a0697ecaff0a5ae3c609e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I3ba8e0f9c000a25baa64acd48793ead90da7307b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524654
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1226}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604814065-741475bd920fd44c6e14487b5c266950aa389c82.profdata to chrome-linux-4280-1604830586-66f57bf2bdb3c66e4ed5376f24c224758bf444ab.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I48d0c582a89fa248b07934f9e18ad4d879e5d7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524653
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1225}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604814065-7bd62e206fa594c1bffe5f339380de956e051ffe.profdata to chrome-mac-4280-1604830586-60f606b823c8155b39a3935aa473425f15dea1d2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I9619fe9d86db0519dbcf08f1247fb80b5a2592c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524652
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1224}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604778094-1805b21f778124f1cc7b215bd9726e5bf5156816.profdata to chrome-win32-4280-1604814065-218668c7df8462a909152c91c81b53b179ecc24e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I275c93f9aa4a8db37e931c5f09bd2d4b274894d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524647
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1223}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604719960-47705b3deaaabc291d6c19ff817e66439fea7853.profdata to chrome-win64-4280-1604814065-30b0fe229c257336a943a19816df5b9bda7d2df3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Ifc89287279f274810a74d48a157a453c91863a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524645
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1222}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.24-1604317572-benchmark-87.0.4280.51-r1 to 87-4280.24-1604317572-benchmark-87.0.4280.52-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ifc68b2cfbf58abd7cc3a12f3c81bbcb281d3e02e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524364
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1221}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Suggested files] Make ItemSuggests requests be BACKGROUND_REQUESTS
files still appear in the launcher.
(cherry picked from commit 2b448630856a9cd5b57d16bd4389e72df04e56bf)
Tested: manually. Request format is valid, itemsuggest returns 200, and
Bug: 1146254
Change-Id: I8f28e813af1c8453a54d8e8373ccf787420ad699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521978
Reviewed-by: Rachel Wong <[email protected]>
Commit-Queue: Tony Yeoman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824729}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524801
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1220}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.38-1604315340-benchmark-87.0.4280.51-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.52-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0c537645a9d1275f852778ca99618c31314c614a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524649
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1219}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.24-1604319793-benchmark-87.0.4280.51-r1 to 87-4280.24-1604319793-benchmark-87.0.4280.52-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iae243835dd9d061eb4c905ffc6b408b1ce1dc16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524648
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1218}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604778094-ab75c71b9e33af45656b9f99da1f7848ce6e391e.profdata to chrome-linux-4280-1604814065-741475bd920fd44c6e14487b5c266950aa389c82.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I8f1d6920c1a58ef96496c9c6d58c967b28edf9fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524931
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1217}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604778094-6b1a955457473a5bb455e9ca2502907d062bc6ac.profdata to chrome-mac-4280-1604814065-7bd62e206fa594c1bffe5f339380de956e051ffe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I07356b2afbacff48f2c9deedaad7f9e1fe5aaaaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524928
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1216}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604747664-37d30e7452bf63480fbb8a244d302e52890118bc.profdata to chrome-win32-4280-1604778094-1805b21f778124f1cc7b215bd9726e5bf5156816.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Ied145b2107c371ae54c56fc0f5db43082a00baa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524423
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1215}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] history: makes FROM_API_3 carry through to redirect chain end
When history adds a page with redirects the transition qualifier
is not applied to redirects. This resulted in FROM_API_3 being
dropped, and pages that should be hidden being shown.
This patch adds FROM_API_3 to CHAIN_END if FROM_API_3 was present
in the requested transition. It's only necessary to add for CHAIN_END,
as CHAIN_END must be present in order for the visit to be considered
visible.
BUG=1145208
TEST=HistoryBackendTest.AddPageWithRedirectsAndFromApi3IsNotVisible
(cherry picked from commit 70082341e63763ba054bfaf06652ab0f06de1393)
Change-Id: I4ac41e5385fe58b249532f1251612b6c1112005b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521833
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824582}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524924
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1214}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix classic inkdrop highlight for shelf app selection.
Dark/Classic shelf use light inkdrop highlights.
(cherry picked from commit f28ba47c53060a754556c16212aa86a25a3c63be)
Bug: 1144136
Change-Id: I5690f73458c623fc82e7f891bfb3bdda963cb386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515200
Reviewed-by: Min Chen <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#825098}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524922
Auto-Submit: Yulun Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1213}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604747664-3a74911cb08d446d2b852c39042ad74e6ef4b874.profdata to chrome-linux-4280-1604778094-ab75c71b9e33af45656b9f99da1f7848ce6e391e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I97e93f6b78b658a91f213ac959a5ba580ecb94c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524310
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1212}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604767658-faf5ddb922a02889130ece8fdaf6ac2ba6e9aeca.profdata to chrome-mac-4280-1604778094-6b1a955457473a5bb455e9ca2502907d062bc6ac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I127c9111d2ec92966a560e475b971641fffcca8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524309
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1211}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.53
[email protected]
Change-Id: Ie7c0d52df75cd2701170951c468a813151234f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524507
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1210}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604747664-ee8894217445a802867fbe74bd9ba58e923ee8db.profdata to chrome-mac-4280-1604767658-faf5ddb922a02889130ece8fdaf6ac2ba6e9aeca.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I2e0b8711d6fdc6170f73155e1c742eb0184af07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524288
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1209}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Prevent UB if a WeakPtr to an already-destroyed object is dereferenced.
If a WeakPtr references an already-destroyed object, operator-> and
operator* end up simply dereferencing nullptr. However, dereferencing
nullptr is undefined behavior and can be optimized in surprising ways
by compilers. To prevent this from happening, add a defence of last
resort and CHECK that the WeakPtr is still valid.
(cherry picked from commit 0b308a0e37b9d14a335c3b487511b7117c98d74b)
Bug: 817982
Change-Id: Ib3a025c18fbd9d5db88770fced2063135086847b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463857
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816701}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524522
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Adrian Taylor <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1208}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.38-1604315340-benchmark-87.0.4280.49-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I93f40b9a70cd43de75847c0d6c1d942e5ed46f70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524581
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1207}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604651335-3b2626b8b9d76525c999d48a31e9ce2359406064.profdata to chrome-win32-4280-1604747664-37d30e7452bf63480fbb8a244d302e52890118bc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Idb9e0f16be5d47fc964fbda6cd9bf96426ac3eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524190
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1206}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604719960-5ca9e1d3cf3ec4d0ab61e77bb4cbe4e684834dcf.profdata to chrome-linux-4280-1604747664-3a74911cb08d446d2b852c39042ad74e6ef4b874.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Idbd139227f77ffe801d992ad0659cfd73bc8987b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524189
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1205}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604719960-dd3f76f5f208da6f21a63933f0b8dfd427052b55.profdata to chrome-mac-4280-1604747664-ee8894217445a802867fbe74bd9ba58e923ee8db.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ic0735ec3b9062bce0740b8e82ce6160149977b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524187
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1204}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604683505-14ae6351bda5eae6590017fa0edcd48f153a4bc1.profdata to chrome-win64-4280-1604719960-47705b3deaaabc291d6c19ff817e66439fea7853.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Iaf451ffd0c276e39ccc1edd6a84adce99f32ec79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524014
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1203}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604706200-483f0ec0cab13e23746d177962ef5aba8b91ee1b.profdata to chrome-linux-4280-1604719960-5ca9e1d3cf3ec4d0ab61e77bb4cbe4e684834dcf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I8e20d80b579a52895a265fde9ba28b297dca4ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524013
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1202}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604706200-9a24e37adfa94a8e53f34f5cd31c6f45a3ea72b8.profdata to chrome-mac-4280-1604719960-dd3f76f5f208da6f21a63933f0b8dfd427052b55.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I9a8104b9b17095cc8fa53fb6682aa6775b9c8fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523636
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1201}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604683505-d5b3498ee2656b087614d32137eddcf039b7377b.profdata to chrome-linux-4280-1604706200-483f0ec0cab13e23746d177962ef5aba8b91ee1b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I679fd3e32d26cde31c239a3d7446a32d69d262aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523547
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1200}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't occlude web contents if WebXR session is active.
Adds a static method to XRRuntimeManager to return the web contents
displayed in an active WebXR session, if any. This is used to not hide
WebContents when occluded, if a session is active on the WebContents.
Bug: 1139083
Change-Id: Ieef4c9c5913e385323efae94171276f5760d869c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510349
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523728
Reviewed-by: David Bienvenu <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1199}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Fix losing the session on the iphone whe the session is renewed.
The problem was that when using the older session id after the session
is changed, we need to immedatily save the session in the new location.
because the user may close the app without any action that will save
the session.
(cherry picked from commit fff8448f8859d1f4e66312a95a350f0ec59e7278)
Bug: 1131031
Change-Id: Iec3dea294787643b214ec8b41b232ea0c7e20171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520084
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824459}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521247
Reviewed-by: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1198}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604683505-6a2ab261d6cee178eba4f4807c3e6087d1c8acb8.profdata to chrome-mac-4280-1604706200-9a24e37adfa94a8e53f34f5cd31c6f45a3ea72b8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I3bb53531a10a3b07e174a78af415af4b22e9b79e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523811
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1197}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.52
[email protected]
Change-Id: I76601536baa83c2ec9b31de1d1c313d1a5f14380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523442
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1196}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Trust Tokens: Remove an overzealous bad-renderer check in RFHI
Document.hasTrustToken is a JS method only available in secure contexts.
Its implementation involves getting a Mojo interface from the browser
and sending an IPC. In the browser-side code, in RenderFrameHostImpl,
where we handle requests from the renderer for this Mojo interface, we
perform a security check to make sure we aren't receiving requests for
the interface from unexpected places, which could indicate a bad
renderer. The current check makes sure that the request is coming from a
frame with a potentially trustworthy origin. However, this is not
exactly the same thing as a secure context: in particular, allow-scripts
sandboxed iframes can be secure but not have potentially trustworthy
frame origins. This leads to false positives in the check and unwanted
renderer kills.
This CL removes the check.
R=dcheng
(cherry picked from commit b950aadc4fa9bd70901bc9eb5b56fe47bb4dc1e8)
Bug: 1144057
Change-Id: I0e57669606effb15c672586297ef7dcf2711bc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511882
Commit-Queue: David Van Cleve <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Auto-Submit: David Van Cleve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823819}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523746
Cr-Commit-Position: refs/branch-heads/4280@{#1195}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604651335-85912f1c71b4c02ee36ea1fc297b43631ad70110.profdata to chrome-win64-4280-1604683505-14ae6351bda5eae6590017fa0edcd48f153a4bc1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I7939007d19f8708e4cfa79315247ec9a62d07f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523533
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1194}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Ignore unexpected RFH::OnAssociatedInterfaceRequest.
This is intended to be merged into M87 Beta M87.
This is actually the #3 crasher on 87.0.4280.38
I have no clue what the problem is here. This patch removes the
consequences of the bug, not the cause.
This is caused by receiving RFH::OnAssociatedInterfaceRequest() after
the process has called ResetIPC and the RenderFrameHost has called
InvalidateMojoConnection().
This patch just ignore the call when this happens, because it doesn't
expect receiving any call from the renderer anymore.
(cherry picked from commit 5449f59a969787ef830268c2f86147448b6bec82)
Bug: 1123438
Change-Id: I1ada1d3a27f53198afc84ec56f00e0a278fdbd90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517586
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517491
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1193}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
IPH: Overrides button outline color to white
Overrides button outline color to white as requested by UX. Currently
the outline is black under dark mode.
(cherry picked from commit 83218bb76002ff3f7efcc0f5ccfc2ba97ae813a1)
Bug: 1146259
Change-Id: I9d5a04bca5f094282b9e51d5f17aae08486b2b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522226
Reviewed-by: Collin Baker <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824923}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523415
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1192}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable DeveloperPrivateApiTest.InspectInactiveServiceWorkerBackground
on Linux
[email protected]
BUG=1134506
(cherry picked from commit 3f2bbafc4e1d196d8508adbcfc2f3e55ad420e68)
Change-Id: Id490ab99c96ea5eadf7dc4dfc564a23f7172e186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450953
Reviewed-by: Chris Sharp <[email protected]>
Commit-Queue: Chris Sharp <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813939}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523333
Commit-Queue: Jesse McKenna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1191}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Damage entire candidate quad rect on underlay promotion
Certain overlay candidates forward damage rects that are smaller than
the quad itself. This works perfectly fine in the case of composition
as it simply corresponds to a partial update within a quad.
However, in the case of underlays, the primary plane must have the
overlay candidate rect be FULLY replaced by a black "window" quad.
Currently the code fails to do this on promotion and will make no
attempt to do this after promotion. This change damages the entire quad
rect so that the "window" quad is fully composed on the primary plane.
The reason why this bug remains unreported (till this time) is because
it only occurs for candidates that have damage as a subset of the quad
rect. Basically, only in the case of Lacros underlays.
(cherry picked from commit f218524840e818a4ce07dafc9a686ba2b1716006)
Bug: 1130733, b/171236089
Change-Id: Ib4ecd77b105c5ad6e7b46d21e9edd5a8b802412f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468678
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Maggie Chen <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Reviewed-by: Kramer Ge <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818046}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521245
Reviewed-by: kylechar <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1190}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
views: fix initial style of LabelButton in activatable bubble on Mac
This is a quick fix for the bug on Mac that an activatable bubble
initially appears in inactive style even when it's in an active browser
window.
We generally want the inactive/active visual style to be in sync for all
widgets in a widget tree. Previously, PaintAsActiveLock partially
achieves this goal by having bubble widget lock its parent widget.
This solution has two caveats:
a) The lock is only on the parent widget, but not on other ancestors.
If we have a password bubble with an focused in-product help promo,
the password bubble will be in active style, but the browser window
will be in inactive style.
b) The lock does not lock sibling widgets.
This is the culprit of crbug/1112244 and is addressed by this CL,
but only for LabelButton (which is the only impacted control).
A holistic solution that locks all widgets in tree is WIP to address
both caveats.
(cherry picked from commit a32e702ab182a0b9673883834cdfb7f2314fdff3)
Bug: 1112244
Change-Id: I230e23d6880f44ab9b569fc1d57fb223d6a01ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508447
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521212
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1189}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Copy sinks before ReadyState change notification
MediaStreamVideoSinks may disconnect from a MediaStreamVideoTrack in
response to a OnReadyStateChanged() nofitication. This can lead to an
invalid iterator if the sinks disconnect synchronously.
This CL fixes the issue by iterating over a copy of sinks instead.
(cherry picked from commit 4e3687fc5c594b2fc4162ba701d090c031935f6a)
TBR: [email protected]
Bug: 1143213
Change-Id: I71fc43696d6b239f0bc4668b85474dc713e674b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505552
Auto-Submit: Thomas Guilbert <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822022}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522925
Reviewed-by: Thomas Guilbert <[email protected]>
Commit-Queue: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1188}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.24-1604317572-benchmark-87.0.4280.49-r1 to 87-4280.24-1604317572-benchmark-87.0.4280.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ice7276eea53bfd55209e62d8b1eb810bb7b8b0c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522964
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1187}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Cherrypick][iOS] Roll text-fragments-polyfill to silence unreachable code warning.
(cherry picked from commit 55872b13cc0f80bee781f58786d8b55ad863577a)
Bug: 1144024
Change-Id: I2caa0b769cc08dd071d55336ca9202548f0dc433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521705
Commit-Queue: Sebastien Lalancette <[email protected]>
Commit-Queue: sebsg <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Auto-Submit: Sebastien Lalancette <[email protected]>
Reviewed-by: sebsg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824905}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522917
Cr-Commit-Position: refs/branch-heads/4280@{#1186}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.24-1604319793-benchmark-87.0.4280.49-r1 to 87-4280.24-1604319793-benchmark-87.0.4280.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib5d6af5ddce6ed106144c3d4091e5bce4ed4a871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523626
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1185}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604651335-4bfda6d78a00ea1696815550ad83d66ab0f7556c.profdata to chrome-linux-4280-1604683505-d5b3498ee2656b087614d32137eddcf039b7377b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I5bc9900c3faa78b565cdbab10b8900e479d3c45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522626
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1184}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
mac-arm64: Update toolchain to Xcode 12.2rc (12B5044c)
This version of Xcode updates the macOS SDK to 11.0 20A5408a (closer to
11.0 than 11.0.1).
(cherry picked from commit 4e347175f444fde57b62b7c3a40effb8b4596e3a)
Bug: 1146419
CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel
Change-Id: I0bcfc826f5b64d90da8f33a9f840b3c962bce099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522003
Auto-Submit: Mark Mentovai <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824699}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522923
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1183}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.38-1604315340-benchmark-87.0.4280.49-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6b3f256b690802182779142bdb7ed2cb75ac8d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523535
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1182}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604651335-992f6e10043f501297bf0fac7e3ca2e9f066dd43.profdata to chrome-mac-4280-1604683505-6a2ab261d6cee178eba4f4807c3e6087d1c8acb8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I6ea4e754232ec0bc83ae7e1a1269f5cdfa3b2f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522959
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1181}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix mask-based clip-path with backdrop filter
Cc requires additional bookkeeping for the case, including setting the
mask layer as a backdrop mask layer, etc.
Also let CompositeAfterPaint composite the backdrop mask layer which is
also required by cc.
[email protected]
(cherry picked from commit 58c40a11b3569be6e52887ed9948b38315bfab1a)
Bug: 1144520
Change-Id: Id9be79d398c1c4b41aa97a7c8c3e23546ce87365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518440
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824041}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523056
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1180}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
views: Add Widget::parent()
The parent widget returned by this method is captured at widget
construction and reparenting.
This CL intentionally does not expose the underlying
NativeWidget/NativeView hierarchy to the widget level, because that
hierarchy is platform dependent and not consistent in various ways.
For examples of NativeWidget inconsistency on Aura,
- Usually, the root aura::Window of a NativeWidget has a parent.
- Yet, NativeWidgetAura will override parent to nullptr when
params.child is false. The parent-child relationship is instead
managed by TransientWindowManager.
- DesktopNativeWidgetAura will not attach child to its parent widget.
Yet, the actually os window (e.g. HWND) will keep the relationship.
(cherry picked from commit 4a7cabdab34eb7f12cd6e539c17a2a6a35c096a1)
Bug: 1112244
Change-Id: Id8bf0d393af4132b30f712e3274a100bfa5e8a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500461
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821783}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521708
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1179}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604641285-4292ea3f5b01fd4606fcc1e027d74b2dcfab8605.profdata to chrome-win32-4280-1604651335-3b2626b8b9d76525c999d48a31e9ce2359406064.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Iea3e83fc1437cca72fab50373ca12a0d24ef8168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523222
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1178}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604619430-f90d3bc216d7ed44c08d5d7cf0a417d6223641e7.profdata to chrome-win64-4280-1604651335-85912f1c71b4c02ee36ea1fc297b43631ad70110.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: Ic137dd3a5c702a2e86c199676e2a1eb82af4a0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523221
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1177}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.38-1604315340-benchmark-87.0.4280.47-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib420e5fb3a3bac0eb1925745faba31fbf63dc943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522624
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1176}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87][Android] Fix BottomSheet layout issues
Fixes the issue when BottomSheet would pass incorrect width to
View.measure, resulting in misaligned text views. More details:
https://crbug.com/1140983#c6.
(cherry picked from commit e6a92b9e77c9c70ab692e1d11875ea2ffc4672b4)
Bug: 1140983
Change-Id: Ic6824f7727555bfb1c8ecff61d7564197adf0150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494920
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821742}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521618
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1175}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604641285-4b57b323db362ed5b42a97b40e421c61ed24e040.profdata to chrome-linux-4280-1604651335-4bfda6d78a00ea1696815550ad83d66ab0f7556c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I7477344e462e204f44c39271d2f2c0b461998960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523218
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1174}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604641285-c11af0f780048f4a3a1d56ade4e5625773860a6b.profdata to chrome-mac-4280-1604651335-992f6e10043f501297bf0fac7e3ca2e9f066dd43.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I3f52518e6a31d0462eb6bb97af5f14926804af29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523232
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1173}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604619430-c5aa36fed45bd424e348edb5612a18fb6048460f.profdata to chrome-win32-4280-1604641285-4292ea3f5b01fd4606fcc1e027d74b2dcfab8605.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I748e7b682c7450d06e8fc0ae6ff0df047d96e13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523012
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1172}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604619430-dd0c6ed824a85f0dc65e999f89422e57ed54854d.profdata to chrome-linux-4280-1604641285-4b57b323db362ed5b42a97b40e421c61ed24e040.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I046618b476077532ae9f983f1da34bbf9e628323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521242
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1171}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604619430-47a19b70dc49d898f14fcb71741b7e12d6e20b53.profdata to chrome-mac-4280-1604641285-c11af0f780048f4a3a1d56ade4e5625773860a6b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ie80ffdccbefd33975c8f9eb4e954469e0b94db69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522686
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1170}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604598811-1c3e82e8c039e543f7e2a9230c4b804a1b8f4508.profdata to chrome-win32-4280-1604619430-c5aa36fed45bd424e348edb5612a18fb6048460f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Id78270f503045358722a4d9874c366e0c616ec3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522593
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1169}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604598811-98f14bf2ed48c6f03519d962739a7c91b7c56e17.profdata to chrome-win64-4280-1604619430-f90d3bc216d7ed44c08d5d7cf0a417d6223641e7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I90361b6c45c3fe12c8d693059b40ad664f485ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522613
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1168}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Reland "media/gpu/vaapiWrapper: Add WARN_UNUSED_RESULT to critical functions"
This is a reland of 8a1b573d50804d6289d616b4e4bee4665dee469a
Original change's description:
> media/gpu/vaapiWrapper: Add WARN_UNUSED_RESULT to critical functions
>
> This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose
> result should have the critical impact enough to regard its
> failure as video processing fatal.
> VaapiVideoDecoder actually doesn't handle the failure of
> VaapiWrapper::CreateContext. This CL also fixes it.
>
> Bug: b:171536540
> Test: Build media_unittest and vaapi_unittest
> Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742
> Commit-Queue: Hirokazu Honda <[email protected]>
> Reviewed-by: Andres Calderon Jaramillo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#820164}
(cherry picked from commit 71e87600cb3b0289c20b2d761bc2201868d20327)
Bug: b:171536540
Change-Id: Ia10cad9549d099d1823419647f0f6473b6bc24dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497964
Auto-Submit: Hirokazu Honda <[email protected]>
Commit-Queue: Jeffrey Kardatzke <[email protected]>
Reviewed-by: Jeffrey Kardatzke <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#820772}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522229
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1167}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604598811-ac9f2254e4c2f6b4bf7c2af4bcbab57ce6289c8b.profdata to chrome-linux-4280-1604619430-dd0c6ed824a85f0dc65e999f89422e57ed54854d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I3ef669713b323e56e7af31f257f1a0b4562bbd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522594
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1166}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604598811-dabd85ca8b1e579566e76f0e9d60a12b58cc9f03.profdata to chrome-mac-4280-1604619430-47a19b70dc49d898f14fcb71741b7e12d6e20b53.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ica56169fd5e6cec0f8eeb454a1386dd29a4f803d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521787
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1165}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.51
[email protected]
Change-Id: I248335e3ec30d5bf8c073ae1bbb39feb4b98142a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522612
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1164}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604574538-488d429c6c6dc36c991b20951e23fe1e4a424d77.profdata to chrome-win32-4280-1604598811-1c3e82e8c039e543f7e2a9230c4b804a1b8f4508.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I85b73a700cee156f3e12fd40d68cc35a90e80519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521228
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1163}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Fix AccountPicker RenderTests
Includes the necessary test changes from crrev.com/c/2490100 that
were omitted from crrev.com/c/2505131 for some reason.
Bug: 1140903, 1145732
Change-Id: I53501bfa582bbcbc056b3cac83f2b5756d0b1d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520078
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1162}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge 87] Fixes promos remaining hidden
crrev.com/c/2505739 makes the promos hidden by default until it is
decided whether the promo can be shown or not. Promos now remain hidden
until the promo loaded event or a window resize event is fired where
visibility of the promo is recalculated externally based on whether or
not it overlaps with the most-visited tiles.
This change coordinates these two steps by firing the promo loaded event
after the promo's visibility is determined internally. It also uses a
consistent mechanism for controlling the promo's visibility internally
and externally, i.e., 'hidden' attr aka 'display: none;'
(cherry picked from commit 279e732ac24229095ccb2a1031f76c60b5c575ff)
Fixed: 1144624, 1143366
Change-Id: I3b2d2d86e56e0baba3f8042077a07aa0b6ce20a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514667
Reviewed-by: Esmael Elmoslimany <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823311}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521105
Commit-Queue: Varun Khaneja <[email protected]>
Auto-Submit: Varun Khaneja <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1161}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update elapsed cc expiration date for test.
Test cc had date of 10/2020, which means it expired.
Setting exp year to use test::NextYear() so test can proceed.
(cherry picked from commit 97652c2a8cb5ccbb01f16a72d9b17ca359269bf9)
Bug: 1144598
Change-Id: I018787f8003f3d48a0d56715a613163ae7c3158d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515263
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Ian Struiksma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823398}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522116
Commit-Queue: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1160}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604552568-f773c0d2f3b0de82bab29288bf34d98318006edc.profdata to chrome-win64-4280-1604598811-98f14bf2ed48c6f03519d962739a7c91b7c56e17.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I63955a6ae989d6f2f77f57fb7635d7dd64135f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521772
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1159}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Sheriff] Disable test on Linux, Debug or ASAN
[email protected]
(cherry picked from commit 81faa4b3b8a46d3c6ff4637ff73aaa53053ae54a)
Bug: 1144598
Change-Id: I388de0ac068a023de69d804debcd2652c970cf79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513408
Reviewed-by: Melissa Zhang <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521103
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1158}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Do not apply text-underline-offset to overline decoration
M-87 merge.
Take into account swapping of underline and overline in vertical, when
using text-underline-position "right" and "left".
Add 3 WPT tests to ensure text-overline-offset is not applied to
overline and that the underline on the correct side is offset in
vertical.
(cherry picked from commit a2c417fa50bc1eb4f20e4077f0ca0235dcea1140)
Bug: 1143600
Change-Id: Idd52a5d2d953fc486050ef20a1960ab51145521c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510829
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Auto-Submit: Dominik Röttsches <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521102
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1157}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Promote DCHECK to if
Also ensure document guid is never empty.
(cherry picked from commit dd1aec2a929f6e0a73c697e8294f68548532d706)
Bug: 1143783
Change-Id: I5ec5e8a9a2198c75f2d26c71f63424dbaddb9314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508266
Commit-Queue: Calder Kitagawa <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822435}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521910
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1156}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604574538-43ef13795bef4eb4b99c2566d75c6a268d0b45e1.profdata to chrome-linux-4280-1604598811-ac9f2254e4c2f6b4bf7c2af4bcbab57ce6289c8b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ia69fe5ace3a021696bf97b6195461c1a6a4faa12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521991
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1155}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[PTZ] Hide page info camera if camera PTZ is granted or blocked
This CL makes sure "camera" in page info UI is hidden when camera PTZ is
granted or blocked, regardless the state of the "Experimental Web
Platform features" switch. This is needed anymore as the
MediaCapturePanTilt feature is now enabled by default.
(cherry picked from commit 0309b0c3adba6dd1ce62d049bb65011f7e5a6851)
Bug: 1144253
Change-Id: If212a72c00e4bede8ad1a0ebacb9a306a7d38409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516223
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823516}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521730
Reviewed-by: François Beaufort <[email protected]>
Commit-Queue: François Beaufort <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1154}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Allows checking whether a promo with a browser command should be shown
- Allows OneGoogle callouts to query the NTP whether or not to show a
promo with a browser command.
- Hides the middle slot promos if any of the promo's browser commands
cannot be shown.
- Gates the ESB promo on whether Safe Browsing prefs are managed or
the user is already opted in.
More info on the API: go/promos-deeplinking-settings
(cherry picked from commit e87569a5220b4ae0212bf5bcceae7a1c24280ea3)
Bug: 1143366
Change-Id: I33c5b36c69a42e6b0c562b8afa0ed8ab56801486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505739
Commit-Queue: Moe Ahmadi <[email protected]>
Commit-Queue: Esmael Elmoslimany <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Reviewed-by: Esmael Elmoslimany <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521197
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1153}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604574538-af141da27d7d15f4a5bab9e0a6ed1fd391931638.profdata to chrome-mac-4280-1604598811-dabd85ca8b1e579566e76f0e9d60a12b58cc9f03.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I942551fb8cc338486043d60e4b9f491a4b14976c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521433
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1152}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge: [XProto] Fix X11KeyboardImpl::ChangeKeyMapping
This fixes a regression after [1]. The issue is that
GetKeySymsForUnicode() doesn't handle all characters. This CL ports
the relevant part of XStringToKeysym() to match the behavior before the
regression.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2436787/5/remoting/host/linux/x11_keyboard_impl.cc#108
(cherry picked from commit f931255c0532e75cfc1a487db44a39be16aa7e4e)
Bug: 1144251
Change-Id: I91a3d42d0029e57c9e5a8cb8ee74b7bc76c00100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518282
Reviewed-by: Erik Jensen <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Erik Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823782}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521339
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1151}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update RLZ brand codes map for M87+
R=[email protected]
(cherry picked from commit 2713db4579212e92459ba4ee0d547622c3a75b54)
Bug: 1145347
Change-Id: Iac5603761900d5e006db6d78064c281b65fa779f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519805
Auto-Submit: Stephen Lin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Stephen Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#824062}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521336
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1150}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604552568-984cc2a80ff8e1606d4caddabf600cb11b40ae4a.profdata to chrome-win32-4280-1604574538-488d429c6c6dc36c991b20951e23fe1e4a424d77.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I391d05963375610e27279c14e15634fff4881a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520886
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1149}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CORS-RFC1918] Do not count main-frame navigations.
These requests are not blocked by content/, so there is no point in
counting them in Blink. When we get closer to having a plan for these
requests, we will want to revisit this so as to gather data.
(cherry picked from commit e5d45d8c0a13a219fc50d84ca9fd5cc5715adf20)
Bug: chromium:1129326
Change-Id: Ib5829385727db3a29955c5246aa9c0ce07d55f09
Fixed: chromium:1134601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489918
Commit-Queue: Steve Kobes <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Reviewed-by: Pâris Meuleman <[email protected]>
Auto-Submit: Titouan Rigoudy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#820759}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520835
Commit-Queue: Titouan Rigoudy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1148}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604552568-d420412ab22ecf86f507097fbde55f653862c5e9.profdata to chrome-linux-4280-1604574538-43ef13795bef4eb4b99c2566d75c6a268d0b45e1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ie4b839ea525200d31b70a4d58120b1086b6e36b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520877
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1147}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604552568-1cbeafcc3c55a1d88dd075d24ccfe0c655d1a023.profdata to chrome-mac-4280-1604574538-af141da27d7d15f4a5bab9e0a6ed1fd391931638.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Iaeb12812d5eb982048ec464c6144e31fda3437c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520393
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1146}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604532898-525a704146f015f9761bb9e95385ec8b23fa714a.profdata to chrome-win32-4280-1604552568-984cc2a80ff8e1606d4caddabf600cb11b40ae4a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I9ee58a9088d7097fb92b4108357dc02bb3fd0a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520524
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1145}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604447509-c857068bb36930fd11988ada8b90c6c368d9243a.profdata to chrome-win64-4280-1604552568-f773c0d2f3b0de82bab29288bf34d98318006edc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I5f78f909b8b517860b75f5481b4aa5184a19a077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520618
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1144}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604532898-65d013c62658fed611bf299c3b28eb52fcffa23e.profdata to chrome-linux-4280-1604552568-d420412ab22ecf86f507097fbde55f653862c5e9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ib956b45e1c3be7b231dc93522bd6c31a3f051001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520306
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1143}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604532898-fb3754630b8ce13e7a70268b589cac4cc18ee86f.profdata to chrome-mac-4280-1604552568-1cbeafcc3c55a1d88dd075d24ccfe0c655d1a023.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ie895554e8d448e017586470538b29f6097d23dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520616
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1142}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604510401-c942346997dfe3c851219ffea9a27daf88ec78fb.profdata to chrome-win32-4280-1604532898-525a704146f015f9761bb9e95385ec8b23fa714a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I3ec66ca324d52db758b65019f7f511eecd2668cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518708
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1141}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4280.38-1604315340-benchmark-87.0.4280.44-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.47-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I12f8badccf79e28492d4b6786f10b53481e7aad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520448
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1140}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604510401-ba49a748d7729767f1d56c8e64344d923c545214.profdata to chrome-linux-4280-1604532898-65d013c62658fed611bf299c3b28eb52fcffa23e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I3a9ed22dfb185d5fb565d86c68d71ea63ab1126f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519768
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1139}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604510401-9f493e24dee6ceae15679c9dde427f6c0528be22.profdata to chrome-mac-4280-1604532898-fb3754630b8ce13e7a70268b589cac4cc18ee86f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Id9dc448fd85f0c58ad1b77ad656566d091964261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518704
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1138}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.50
[email protected]
Change-Id: I36c7eaa42c3f3cae0c236cd628de1f1e545dbe59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518453
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#1137}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604477178-9a63ce0cd420884f0738cd0f1dd5823c91677604.profdata to chrome-win32-4280-1604510401-c942346997dfe3c851219ffea9a27daf88ec78fb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: Ifc3fa8cbdc0ad130154c9aa5632ee4d7ea15dd14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519591
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1136}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
crostini: Fix a race in setting the disk slider value.
The max value gets set automatically when we set the ticks on the
slider, but if the observer on slider ticks changing fires after the
observer on value changing, then the value gets clamped to the old max
meaning even if the user has a larger disk, we'll start the slider off
at tick 100. To fix this we explicitly set max, to ensure it's set to
the right value when the clamping happens.
(cherry picked from commit c8e5de6d3dd402f9671f7a94ee684ce874625fa9)
Bug: chromium:1139722
Test: Manual
Change-Id: Ic35d84ce17febdf83ae607e12e0288aa669d55aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497720
Reviewed-by: David Munro <[email protected]>
Reviewed-by: calamity <[email protected]>
Auto-Submit: David Munro <[email protected]>
Commit-Queue: calamity <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821112}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517204
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: Nic Hollingum <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1135}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Use visual overflow rect for layout shift tracking
(cherry picked from commit e9e1f3fde8646e7b4e150f7a348acc75b99abbe6)
Bug: 1141739
Change-Id: I3b41c6328bf328b6734c6eadc422c45534fe42da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503330
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#821511}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519197
Reviewed-by: Annie Sullivan <[email protected]>
Commit-Queue: Annie Sullivan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1134}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4280.24-1604317572-benchmark-87.0.4280.47-r1 to 87-4280.24-1604317572-benchmark-87.0.4280.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8e15db76dde3af5eec7793433d59c06204e134c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520034
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1133}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604477178-1ec9a66b5903f6d7c9387996bc9a426bd2556bbe.profdata to chrome-linux-4280-1604510401-ba49a748d7729767f1d56c8e64344d923c545214.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ie331e7747a8cf57c1c60e47d066f4edf23b64500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519585
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1132}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.24-1604319793-benchmark-87.0.4280.47-r1 to 87-4280.24-1604319793-benchmark-87.0.4280.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I81af9f98a865fc883a9a508c6b3280b2daf88e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519722
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1131}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Establish a strong virtual connection for mirroring
For Cast SDK sessions, a strong VC is made for the cast source's sender
ID, and for mirroring sessions, one is made for CastMessageHandler's
sender ID. This CL ensures that for mirroring started via Cast SDK, the
latter is strongly established.
(cherry picked from commit 12c3f476f9ed0b0a1b81ee309c1a99cd32460e8a)
Bug: 1144364, b/172094267
Change-Id: Ibf2eb3dc893d92b8f3de1e1f244354a35ff71e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514673
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519760
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1130}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.38-1604315340-benchmark-87.0.4280.47-r1 to 87-4280.38-1604315340-benchmark-87.0.4280.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I01c187ad88106dac56698a5b309435d26f22c2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519721
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1129}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604477178-be72d402a55630e565acca7e8a9df22652ea630f.profdata to chrome-mac-4280-1604510401-9f493e24dee6ceae15679c9dde427f6c0528be22.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: If043fcda0c270fba2789c25606bc67658c34ed99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518948
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1128}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I6bc8167479555d57450b9109932cffdc5339b5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519329
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1127}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to release branch: Add per-surface and per-type sampling
parameters for the Identifiability Study.
(cherry picked from commit 828932702391775d9b4696c8a5f67f749690fd39)
Bug: 973801, 1137081, 1143731
Change-Id: Icea646cab1b7e00a827919c86e691f20123d9096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492601
Auto-Submit: Chris Fredrickson <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822174}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517242
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1126}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604447509-be1b37930e906bb2d5d1466c259c7d08280010c1.profdata to chrome-win32-4280-1604477178-9a63ce0cd420884f0738cd0f1dd5823c91677604.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I6cc1868f554cac8fab580d6731fec6456dda28c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519163
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1125}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87][Signin][Android] Use Acivity for AccountPickerBottomSheetCoordinator ctor
Changes AccountPickerBottomSheetCoordinator argument from Context to
Activity. This ensures that the view is never inflated using an themeless
context. This is a tentative fix for an intermittent issue when
AccountPickerBottomSheetView rows don't have a ripple animation.
(cherry picked from commit 4e19c1801b9bee678e4e11aff6cd1c278ca0ca3e)
Bug: 1141000
Change-Id: Idc63fdac6dde06e912d57bcf8ef0bc1572ca968d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489904
Commit-Queue: Boris Sazonov <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#819792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517531
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1124}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604468137-a946903affd846bb8e94362e0c8ea38051890035.profdata to chrome-linux-4280-1604477178-1ec9a66b5903f6d7c9387996bc9a426bd2556bbe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: Ie4747593292305add9121b9869e6e9bbe9630acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519575
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1123}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604468137-afcd9dce51ea0fa411d78a7f02fb7e02e21ca0b5.profdata to chrome-mac-4280-1604477178-be72d402a55630e565acca7e8a9df22652ea630f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Ie5eb94a3f4025529505b95d6fa99a30262d5dac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519162
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1122}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-4280-1604447509-a2e4422fa082bca42e4e2a03f93f0d9ce6fb46f7.profdata to chrome-linux-4280-1604468137-a946903affd846bb8e94362e0c8ea38051890035.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I7a6b60eff8b5b0b667ece09533a7efdb9d4fa0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518908
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1121}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4280-1604447509-245bc6b347be682a1c6398ba9d0fd6df89197f24.profdata to chrome-mac-4280-1604468137-afcd9dce51ea0fa411d78a7f02fb7e02e21ca0b5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I13ebc7e8fd5b90025e7aaa451e5400f250ebf6fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518904
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1120}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-4280-1604425466-6b7e051fdb2e68c88629718fae205d4de40ef359.profdata to chrome-win32-4280-1604447509-be1b37930e906bb2d5d1466c259c7d08280010c1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome-beta
Tbr: [email protected]
Change-Id: I50095c27261ae7bd558a4ffd2bd3c0237ff37625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518643
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1119}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
CCA: Fix camera intent view cancel timer no result bug
Add check to early return from taking process of camera intent view if
the underlying camera view ends the take process earlier(e.g. timer
canceled) and produce no take result.
(cherry picked from commit fa79b41de3e8387df698adabcd28dceedfba526f)
Bug: b/171874692
Test: Manually
Change-Id: I7aa8c70680e6c59fa013a0ced4738a200388b30d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505321
Commit-Queue: Inker Kuo <[email protected]>
Auto-Submit: Inker Kuo <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#822076}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507149
Reviewed-by: Inker Kuo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1118}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-4280-1604425466-7066898a1d421ce2ae8319ff12a7ce98cb93194f.profdata to chrome-win64-4280-1604447509-c857068bb36930fd11988ada8b90c6c368d9243a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome-beta
Tbr: [email protected]
Change-Id: I1a3fe1981a35a16cbfd204df4e1c0aa0fc3ae692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518815
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1117}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87]dark_mode: Toast is dark themed by default.
[email protected]
(cherry picked from commit d1c3f8bbe94f0d0178fb99c0df62841acc321f81)
Bug: 1145255
Change-Id: I20b9a1352209948897d8174786a58122c3f5a37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518322
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#823676}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519033
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#1116}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
