Publish DEPS for 86.0.4240.111
Incrementing VERSION to 86.0.4240.111
[email protected]
Change-Id: Id4561c15c9f3324d1d6be28e86cbc96ac3bdeb55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485402
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1290}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Add finch kill switch for removal of default app protected storage
Release team strongly prefers a kill switch for merges to stable.
R=[email protected]
(cherry picked from commit 662a284aad5265de159f48e967e3343f66e09240)
(cherry picked from commit 55ce93c57c1d42bd0f816974481a892aad736b0c)
Bug: 1139902
Change-Id: I6b7f98c3d1032c1cf9098d2ded87413e89bdd530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486396
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818737}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486621
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#14}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486702
Reviewed-by: Prudhvi Kumar Bommana <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1289}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Mark for compositing inputs update after unthrottling.
A previous CL (*) made PaintLayerCompositor::CanBeComposited
depend on throttling state. CanBeComposited in turn affects compositing
inputs. Therefore when throttling state changes, compositing inputs
need to be re-computed.
(*) https://chromium-review.googlesource.com/c/chromium/src/+/2277332
Bug: 1139116
(cherry picked from commit 96f3048eb9194d8ab5ed157c46f549084bd103bb)
(cherry picked from commit 81eed342a1201a90a691dee3691ab79d299bf4fc)
Change-Id: I1152e447ade9f2f848707f992f9c4fc1574bba7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485438
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818625}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485625
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#11}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486390
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1288}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.110
[email protected]
Change-Id: I16737e0d5b57fd49ed8afa1ea83c3ca65a0fb213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485681
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1287}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll src/third_party/freetype/src/ 20186d1be6415d1..d7caaf8517fa6d (1 commit)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f9f6adb625c4..b977dff8c99b1
git log f9f6adb625c4..b977dff8c99b1 --date=short --no-merges --format='%ad %ae %s'
2020-10-19 [email protected] Test early to prevent overflow.
Change-Id: Ibb0c37644aa14e06a72dde21617bdfce5c4ecb75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486093
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1286}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Hardcode default apps to not have protected storage.
This fixes an issue I introduced in m85 here:
https://chromium-review.googlesource.com/c/chromium/src/+/2181827
during our migration of all "bookmark apps" off of the extensions system
and onto the WebAppProvider system.
Making YouTube no longer a 'bookmark app' (and back to a hosted app)
had the side effect of making its storage protected, because apparently
all hosted apps have their storage protected.
This change marks all potential default hosted apps as no longer
receiving protected storage.
The long term fix for this issue is to have the WebAppProvider system
support default apps, and migrate these old hosted apps (which is a
double-deprecated system) onto the WebApp platform:
https://bugs.chromium.org/p/chromium/issues/detail?id=1140122
R=[email protected]
(cherry picked from commit f800edbd1b50ecc13a0d3391f5f45ba9c84625be)
(cherry picked from commit 954e0815dff6f929a9d7c3f251a7143ed1a5a436)
Bug: 1139902
Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Chase Phillips <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818570}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485049
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#7}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485843
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1285}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.108-r1 to 86-4240.77-1603108500-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib68e101e8423e4c71b791a974ff24593dab99e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485610
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1284}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.108-r1 to 86-4240.77-1603101048-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I33e52a7bd809d915b4908442632af46bbbc772c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486137
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1283}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.108-r1 to 86-4240.77-1603112082-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3b70e94988efc6f836bf4e518b9c55f72cd50e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486134
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1282}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge to M86: Disable caret browsing toggle on Mac when web contents isn't focused.
This is a follow-up to http://crrev.com/c/2472897 - it turns
out that it's not sufficient to make the caret browsing toggle
do nothing, we have to actually disable the command in order for
it not to interfere with Japanese IMEs.
This required a bit of extra work to ensure that the command
enabled status is updated when focus changes.
Test in follow-up: https://crrev.com/c/2476910
(cherry picked from commit 14aea1a8a4defbfb4c40351c9fce4fb6ceb744d2)
Bug: 1138475
AX-Relnotes: Pressing F7 to toggle caret browsing no longer interferes with Japanese IMEs
Change-Id: I0497b377ee74f1916e0dd2ca9a5c4f1d24f1d332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476906
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817814}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485137
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1281}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Apply edits when closing the bookmarks bubble
Fixes regression where the dialog had to be explicitly accepted to apply
pending updates.
(cherry picked from commit 417603ce00e6dc879b85400d833e26f82fd867d6)
Bug: 1137491
Change-Id: I9c8166aa013714b08280eaf1d51c7831dcd6b9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476719
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485835
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1280}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge to M86: Don't toggle caret browsing on Mac unless web contents has focus.
Pressing F7 to toggle caret browsing was interfering with a Japanese
IME on Mac, but only when the omnibox has focus. There were no
conflicts when focus is in a web page. So to work around this issue,
ignore the F7 shortcut when focus is
It turns out Firefox has the same behavior: it ignores the F7 toggle
when focus is in its address bar. So that's good motivation that this
is the right fix.
There hasn't been any feedback about a similar issue on other
platforms, so scoping the fix to just Mac.
(cherry picked from commit 624eb0c056f51c70f16cbcf3a244b485f3a77a3f)
Bug: 1138475
Change-Id: I19b5ccaf9aec0b46c76e241887af60b0180a7338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472897
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817162}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485433
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1279}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Download: Fix a crash for removable SD card on Android R.
Only call DownloadManager.addCompletedDownload on Android version below
Q, since it's deprecated. On R it will cause a crash.
(cherry picked from commit 6fcac9a226e802cc99e31c025efc41c40f2512c1)
Bug: 1120233
Change-Id: I19951e2fcdd71b9de9facbc551c95fd275f46170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425168
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#809605}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485097
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1278}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Validate input of MediaStreamDispatcherHost::OpenDevice()
This method forwards to MediaStreamManager::OpenDevice(), which
DCHECKs for the stream type to be device video or audio capture
(i.e., webcam or mic). However, MSDH admits other stream types,
which cause MSM::OpenDevice to hit this DCHECK.
This CL ensures that a message containing an incorrect stream type,
which could be sent by a malicious renderer, results in killing the
renderer process.
(cherry picked from commit 229fdaf8fc05e0eeadad380d401c191afd822d92)
Bug: 1135018
Change-Id: I3884dde95d92c41f44966a8ab1dd7bdfd4b23b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472397
Auto-Submit: Guido Urdaneta <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817151}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485092
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1277}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix AtomicStringTable lowercase translator.
It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.
For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.
(cherry picked from commit 2f19541f156707c517f8bd2b3bdf9d8f729e2587)
(cherry picked from commit 486c4092effb4d632d3bef8f35b7d2832fb88552)
Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818060}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480731
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4294@{#8}
Cr-Original-Branched-From: 945a64b5e6cd310d9fb6863165edf69d808e0c74-refs/heads/master@{#817614}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481466
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1276}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.103-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If5e0b183ebd2f030d9204a6483e159d4691f6b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485595
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1275}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.109
[email protected]
Change-Id: I8d3d7693f6c7d0b3a470a9beb0a88435d390996b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484042
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1274}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.107-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2613c7ddee7d3451c634feec2515a9a2e220cb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483651
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1273}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.107-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0d56185cfbfbcf1cd368ce40c6ac2e6d9d24e9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483650
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1272}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.107-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I381ae01f001f6fdec5d12b5f0cd18961246629e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483493
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1271}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.103-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie9f1af087aa515051166a9b724b5556951a26f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481692
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1270}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.103-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I80281af92fa82fd03ea7afbf168fade2d3ea990f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481739
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1269}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.103-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I87ed9c19cce8237b62ab6c760fe7929e414ac652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482453
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1268}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.108
[email protected]
Change-Id: I837f3efd6d43449f6728dc89aeeaf44466ca6e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483042
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1267}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix NGLineBreaker hang
This is a regression in r796465 crrev.com/c/2344431 but the
issue reproduces only in M86.
This CL minimizes the change to make the merge easier. Clean
up CL will follow.
Bug: 1139513
Change-Id: Ie55ebd286534f27df245587f11f03b108b50305c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482623
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1266}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.102-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I54dc3947c287b71f1f28e64193e30c25b3787d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482053
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1265}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.107
[email protected]
Change-Id: I30adaa055e13105aa8014069e2a1f8679d0e40c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482203
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1264}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
bind-gen: Fix HTML{Embed,Object}Element's named definer
For a historical reason, HTML{Embed,Object}Element's named
definer depends on a fallback logic of the definer and also
the named property setter.
This patch fixes the bug with a minimal change so that it's
easy to backport it.
(cherry picked from commit 7895d48b4faf51d22ece2f75ff021c484e61e1cb)
(cherry picked from commit 1de53ad456499c03f57df16e005a7b9fd2368858)
Bug: 1137541
Change-Id: Ic3af70604a379814fae24970317868ab89f7c4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467744
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#816597}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473320
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4280@{#405}
Cr-Original-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481462
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1263}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.101-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9fbe2ed22ede54c0ff9aa695a2d2e70292fd0d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480620
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1262}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.102-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3ba460a4c46fe79cfa4d53da04f50d2839545d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481564
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1261}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.102-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4b35e1db862564a4c71d0e004ce1806cc9e97b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481421
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1260}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert "Remove TS_SS_TRANSITORY flag from TSF"
This reverts commit 5d66d2641816deb4aa942de069a7b2e0d6ee696f.
[email protected],[email protected]
(cherry picked from commit c581014e8ec5c7f5732fa4f6bf75649f88c625aa)
Bug: 1137267, 148355
Change-Id: Iba8a3cb59a12ddd4310849ee1cf877cb7ea8a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471881
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Anupam Snigdha <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817109}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480885
Cr-Commit-Position: refs/branch-heads/4240@{#1259}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Add workaround to avoid crashing when calling LocalBorderBoxProperties
In the presence of rare bugs, it is apparently possible to have a
graphics layer but no LocalBorderBoxProperties.
Bug: 1137883
(cherry picked from commit f907f3506b4b95d73d4363859eb5dfdb7dcc9e25)
Change-Id: I17d65c6ca04d15254efe9b2d13e3de905b59567e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474918
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817565}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480702
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1258}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.101-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic554ef2f1c48f1ecc1d44cdad1aa8398cec13b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480925
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1257}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.100-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3790aeb94c78d6fdb9351fe73940c8362fdebe45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478068
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1256}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Setting version to 86.0.4240.106
[email protected]
Change-Id: I19d626736ee1b0a6b4e415ac032842a2554d1eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476838
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1255}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.103
[email protected]
Change-Id: I3ae03be9472533c36145a709959b650dc7908f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476960
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1254}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Should notify input service about focus change for same input type.
We should call |ITfThreadMgr::SetFocus| to notify input service about
focus change even if the input type has not changed.
This issue is introduced by crrev.com/810350.
Bug: 1133474
Bug: 1124612
(cherry picked from commit 84c57c995bac4e942c9f56462f38aa74383a44c2)
Change-Id: I219fb624fb649b870bc081fbdac56373c1102d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438478
Reviewed-by: Siye Liu <[email protected]>
Reviewed-by: Yohei Yukawa <[email protected]>
Commit-Queue: Siye Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477598
Cr-Commit-Position: refs/branch-heads/4240@{#1253}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert change to notify input method about type change in omnibox during CJK tip.
The change to notify input method about type change in omnibox during
CJK TIP[1] causes regression that switching to a new tab will change JPN
TIP to English mode instead of Hiragana mode. The reason is that when
input method is notified about the text input type change, Windows input
service is also notified about the change. Therefore, the input mode is
changed from hiragana mode to English mode in JPN TIP.
We should only notify input service if the input type is changed to a
different value. We should also use the cached input type to find the
associated TSF document.
[1]: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3
fe7e213cecb91264a3bd1f6aed8da3495e158963
Bug: 1108845
Bug: 1124612
(cherry picked from commit b941cb149d9d8e9621f077b66ad7fe0e454d7564)
Change-Id: I9ec643c7d2058695e8bc396d764ba598d6235b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392415
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Siye Liu <[email protected]>
Reviewed-by: Yohei Yukawa <[email protected]>
Commit-Queue: Siye Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#810350}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477419
Cr-Commit-Position: refs/branch-heads/4240@{#1252}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.101-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Idc167c9dc279e930ba2501ac03a5f868e5a888d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477280
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1251}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.101-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iaf7cf5c045a196d9c950d29f887603e2d2a165c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477276
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1250}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Views: Fix tab controls to sit flush with the top of the tab strip
This CL updates the tab strip's UpdateNewTabButtonBorder() method to
apply the vertical border insets to the tab control buttons rather
than the tab controls container.
This is necessary as the NewTabButton will extend its targetable
area to the top of its bounds when the tab strip is in a condensed
state (i.e. the window is maximized). This is done to ensure the
tab strip controls comply with Fitt's law expectations.
(cherry picked from commit 022d70c762cc57f7037f84719be1bca368c2d165)
(cherry picked from commit ca6b4380d9b765a7fd6e47d4863ab1f073cfc5c2)
Bug: 1136557
Change-Id: I8b312363bdabbef358ec2689321bb30d7680953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463994
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#815821}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472602
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4280@{#388}
Cr-Original-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476393
Cr-Commit-Position: refs/branch-heads/4240@{#1249}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Reland] [Merge to M86] [XProto] Temporarily use libXkb to translate key events
This is a reland of [1] with [2] applied.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2473498
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2476716
> The current key translation code doesn't look at the XKB group encoded
> in the modifiers. This is causing an issue where accelerators don't
> work in environments that use groups to support multiple layouts.
>
> This is a minimal fix so that it can be merged back to M87 and M86. It
> temporarily reintroduces an Xlib function.
>
> R=sky
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815900}
R=sky
Bug: 1125886, 1136265, 1136248, 1136206
Change-Id: I719a3331e09b45550570e0745349f73131f9ccca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476562
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1248}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert "[Merge to M86] [XProto] Temporarily use libXkb to translate key events"
This reverts commit 65e39fbbead33eaeede9af7467678c19c82ca7df.
Reason for revert: Broke compile on over a dozen Linux, Fuschia and Android M86 branch builders. A sample:
https://ci.chromium.org/p/chromium-m86/builders/ci/linux-lacros-builder-rel/763
https://ci.chromium.org/p/chromium-m86/builders/ci/Fuchsia%20x64/702
https://ci.chromium.org/p/chromium-m86/builders/ci/Android%20arm64%20Builder%20%28dbg%29/313
Original change's description:
> [Merge to M86] [XProto] Temporarily use libXkb to translate key events
>
> > The current key translation code doesn't look at the XKB group encoded
> > in the modifiers. This is causing an issue where accelerators don't
> > work in environments that use groups to support multiple layouts.
> >
> > This is a minimal fix so that it can be merged back to M87 and M86. It
> > temporarily reintroduces an Xlib function.
> >
> > R=sky
> >
> > Bug: 1125886, 1136265, 1136248, 1136206
> > Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> > Commit-Queue: Thomas Anderson <[email protected]>
> > Reviewed-by: Scott Violet <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#815900}
>
> TBR=sky
>
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: I8923a25a8ea08c0e195388a7b242808e8db91be4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473498
> Reviewed-by: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4240@{#1244}
> Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[email protected],[email protected]
Change-Id: I943547230aeaf3cbbad3307fadd22abeb816b5a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1125886
Bug: 1136265
Bug: 1136248
Bug: 1136206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476677
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1247}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[WebLayer] Cherry pick MediaSession service fix.
Original description:
MediaSession service should abort if WebLayer isn't inited.
Currently, we crash.
[email protected]
(cherry picked from commit 9321a99a1a1ffd5898ac1b22653299ec6149ec58)
Bug: 1136823
Change-Id: Iceb2d113071cff1de54106577354af2827102a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462262
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Mugdha Lakhani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816289}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475816
Reviewed-by: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1246}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Cherry-pick of this original change:
Abort rather than crashing when MediaSessionService is started w/o WL.
When an intent attempts to start MediaSessionService but WebLayer has
not been loaded, the service will no-op instead of throwing an
exception.
(cherry picked from commit 52da2312555b0ad0d03eeb5ee86f69861cfdce98)
Bug: b/167388918
Change-Id: I0f191d0f620016c8ee072e0953d10ad1c257fa15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388404
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#803594}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474786
Reviewed-by: Mugdha Lakhani <[email protected]>
Commit-Queue: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1245}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Merge to M86] [XProto] Temporarily use libXkb to translate key events
> The current key translation code doesn't look at the XKB group encoded
> in the modifiers. This is causing an issue where accelerators don't
> work in environments that use groups to support multiple layouts.
>
> This is a minimal fix so that it can be merged back to M87 and M86. It
> temporarily reintroduces an Xlib function.
>
> R=sky
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815900}
TBR=sky
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 1125886, 1136265, 1136248, 1136206
Change-Id: I8923a25a8ea08c0e195388a7b242808e8db91be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473498
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1244}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.102
[email protected]
Change-Id: I87b9b6c0f06007d5220ce86c421bfc2596e8206b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473539
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1243}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.100-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I01dcc5085c6de40d314cac2eb19ae260670a3092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472632
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1242}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.100-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1b715579d758ffa4af704651c6c37f4e6d1ff9ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472628
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1241}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.100-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0d811d5fa727fd41b9aafac614bc146ffa66b3f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472633
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1240}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.95-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7009a8732ad15740bdae2e09840af4e4b3ff8e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472077
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1239}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[IntentHandling] Add metrics to record the preferred apps entry count.
This CL adds the metrics to record the preferred apps entry count that
was recorded in the disk. This value should be able to represent the
largest entry number before the user session stopped.
This CL also fixed a mistake I made for existing preferred apps metrics.
When I created "Apps.PreferredApps.UpdateAction" and
"Apps.PreferredApps.FileIOAction" metrics, I updated the scope in
the histograms.xml file, but forgot to update the scope in the UMA
recording function, causing a mismatch of the metrics name.
BUG=1134082, 853604
(cherry picked from commit 8117f92b5cc5104a8ec6d7cbb0fa8cb263235b22)
Change-Id: Ic00c7c78cdaba7268182122ead1877433c1fae61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442398
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Maggie Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469917
Reviewed-by: Maggie Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1238}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Image-Orientation] Implement WebGL image-orientation
M-86 merge.
When creating textures for WebGL, always orient images
with EXIF orientation data.
This change also corrects the transposed size reported by
ImageBitmap. And it removes superfluous arguments from
CopyImageData.
(cherry picked from commit f373458c504c2d115c42f31b29ff5c19674acbbc)
Bug: 1100470, 1125337
Change-Id: I79aa798327a3582939aa574723926b3325c80e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459400
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815359}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469776
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1237}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.101
[email protected]
Change-Id: I4148cfba501fc80635a280d962ae16a8dfb0e346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469876
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1236}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
M86: Prevent double deletion in PrintRenderFrameHelper.
(cherry picked from commit 6c2b1efa3d1ead8584489194a21183b954a3d184)
Tbr: [email protected]
Bug: 1134960
Change-Id: I765cc3f1463fce4b8d7c2ca99f429031566a4645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454732
Reviewed-by: Jesse Schettler <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814756}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469219
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1235}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.95-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibbf58b6f018adfa5fa8e3ec7a77df36ac887b8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468285
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1234}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.95-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Icee4f4603fcaa41860b217d02bf0dd9697894694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468711
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1233}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.95-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5ca2d545e3282dd4614b54c094dd5e08aeb23c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468385
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1232}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.93-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.95-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I290db27a7bcc929d45f1295cdc2ec8237286ffe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468279
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1231}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.100
[email protected]
Change-Id: I970afd353d82002b86f7c4adab6fda96e2c279e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466937
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1230}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.99
[email protected]
Change-Id: Iec92a73d0f0473a3ea5a681c90f6ad058e8eacb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463710
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1229}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
usb: Prevent parallel calls to UsbDevice::Open
This change adds a check to prevent a Mojo client from calling Open()
multiple times while the open is in progress.
(cherry picked from commit 1ed869ad4bb34e9868933cd2b20dc22ab83a5021)
Bug: 1135857
Change-Id: Ib467de9129673710b883d9e186c32c359f8592d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454846
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814940}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466345
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1228}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Implement LayoutSVGInlineText::InvalidateSubtreeLayoutForFontUpdates
M-86 Merge
If the font changes we need to invalidate the text metrics so that the
text layout data is updated.
(cherry picked from commit 1a75b44e946578747812badb7aaa484d7c176fac)
Fixed: 1133297
Change-Id: I13579257430e535e139ae57ca53990c053cf8d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439072
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812590}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456607
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1227}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll src/third_party/sqlite/src/ 5e8c30a1e..0324bd3ef (222 commits) (M86)
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/5e8c30a1e0e0..0324bd3ef1af
$ git log 5e8c30a1e..0324bd3ef --date=short --no-merges --format='%ad %ae %s'
2020-08-19 huangdarwin Amalgamations for release 3.33.0
2020-08-14 drh Version 3.33.0
2020-08-13 dan Fix "make test" handling of environment variable QUICKTEST_OMIT so that it can be used to exclude test files in other than the main test directory.
2020-08-12 drh Improvement on the previous fix.
2020-08-12 drh Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3.
2020-08-11 drh Fix harmless USAN warnings from gcc9.
2020-08-11 drh New test cases for the use of the ieee754 and decimal extensions in the CLI.
2020-08-11 dan Modify a test for corruption within the wal checkpoint code to account for the pending-byte page. And for the fact that test configurations might move the pending-byte page.
2020-08-11 drh Minor comment fixes. No changes to code.
2020-08-11 drh Remove an unused #define from sqliteInt.h.
2020-08-10 drh Simplify #ifdefs associated with Parse.eParseMode. Fix an #ifdef error associated with SQLITE_OMIT_AUTOVACUUM.
2020-08-10 dan Fix a problem causing test failures in corruptL.test for some permutations.
2020-08-10 dan Fix a problem building fts3 separately from the amalgamation.
2020-08-10 dan Fix a shell tool build error caused by some combinations of options.
2020-08-10 drh Fix harmless compiler warnings that surface in newer versions of GCC.
2020-08-10 dan Fix another test script problem in walvfs.test.
2020-08-10 dan Fix minor test script problems.
2020-08-09 drh Fix a harmless compiler warning.
2020-08-08 drh Fix the check-in at [41474548ef3f7454] so that it computes the pointer in time for error checking at the end of the routine in the case of a non-OOM error.
2020-08-08 dan Fix test script busy2.test so that it works with the inmemory-journal permutation.
2020-08-08 dan Changes to busy2.test, corruptL.test and fkey5.test so that new test cases pass with all test permutations.
2020-08-08 dan Fix a test script problem causing an error for SQLITE_ENABLE_OVERSIZE_CELL_CHECK builds in corruptL.test.
2020-08-08 drh Move a pointer computation until after OOM checks to avoid a nuisance USAN warning.
2020-08-08 dan Change the name of sqlite3SelectTrace to sqlite3_unsupported_selecttrace.
2020-08-08 drh Update requirement marks due to wording improvements in the documentation.
2020-08-08 drh Reorder declarations in the decimal extension for C89.
2020-08-07 drh Do the oversize-WAL corruption test before the size hint is issued.
2020-08-07 dan Fix a file-descriptor leak in test script corruptL.test.
2020-08-07 dan Return an SQLITE_CORRUPT error if the final expected size of the database when checkpointing is not reasonable - where reasonable is defined (basically) as the sum of the sizes of the database and wal files.
2020-08-07 drh Add the --checkpoint option to speedtest1.
2020-08-06 drh Fix the columnar output modes in the CLI so that they work with parameters. See [https://sqlite.org/forum/forumpost/17ba6aac24] for details of the problem fixed.
2020-08-04 mistachkin Fix compilation issues with MSVC.
2020-07-31 drh Back out a NEVER() that turns out to be reachable.
2020-07-31 drh Remove an ALWAYS() that turns out to be reachable.
2020-07-30 drh Test for schema corruption is reachable after all.
2020-07-30 drh Provide an alternative "guaranteed-safe" method for overwriting the WAL index on recovery, in case some platform is found for which memcpy() cannot do this safely.
2020-07-30 drh Fix compiler warnings in MSVC.
2020-07-30 drh Fix unreachable branches.
2020-07-29 drh Fix signed/unsigned compiler warnings.
2020-07-28 drh Earlier detection of out-of-range page numbers in the btree layer.
2020-07-28 drh Add an sqlite3FaultSim() to make an OOM case more accessible and remove the ALWAYS() on the conditional that is false when the OOM actually occurs.
2020-07-27 drh On recovery, always overwrite the old with the new, even if they are the same. Add ALWAYS() macros on branches currently thought to be unreachable, pending additional testing.
2020-07-27 dan Fix a couple of test scripts to match the new wal recovery behaviour on this branch.
2020-07-27 drh Improved error reporting if walLockExclusive() fails.
2020-07-25 dan Allow a wal mode recovery to proceed even if there are readers.
2020-07-24 drh Remove a surplus space from a comment
2020-07-24 drh Fix other potentiall pointer aliasing problems associated with subclassing of the sqlite3_file object for various VFS implementations.
2020-07-24 drh Fix pointer aliasing problem in the in-memory journal code. Ref: [https://sqlite.org/forum/forumpost/d44eb2fc44|forum post d44eb2fc44]
2020-07-23 drh Add the OMIT_ZLIB compile-time option to sessionfuzz.c. (Originally checked into the wrong branch.)
2020-07-23 drh Fix a typo in an error message.
(...)
2020-06-10 dan Ensure that the "push-down" optimization does not push constraints down into compound queries if any of the component queries uses window functions.
2020-06-10 drh Disable AggInfo consistency checks when unwinding after an OOM.
2020-06-09 drh Mark an always-true conditional with ALWAYS().
2020-06-09 dan Ensure that aggregate functions that (a) are part of SELECT statements with no FROM clause and (b) have one or more scalar sub-selects as arguments are assigned to the correct aggregate context.
2020-06-09 dan Modify a test file to avoid causing Tcl to allocate too much memory.
2020-06-09 drh Give the expression pointer fields of AggInfo distinctive names in order to simplify tracking of all their uses.
2020-06-09 drh Improved tree-view debugging output for aggregate functions.
2020-06-08 dan Fix a case where a corrupted fts3 record could cause an assert() failure, or spurious SQLITE_NOMEM error in builds with assert() disabled.
2020-06-07 drh Fix minor OOM problems.
2020-06-07 drh AggInfo objects might be referenced even after the sqlite3Select() function that created them has exited. So AggInfo cannot be a stack variable. And it must not be freed until the Parse object is destroyed.
2020-06-07 drh Alternative fix to ticket [c8d3b9f0a750a529]: Prior to deleting or modifying an Expr not that is referenced by an AggInfo, modify the AggInfo to get its own copy of the original Expr.
2020-06-05 drh In the debugging treeview output, change the name of "SELECT-expr" expression nodes to be "subquery-expr", so as to not confuse them with actual SELECT nodes.
2020-06-05 drh Always use ?...? to indicate optional arguments in the output of ".help" in the CLI. Change ".mode column" so that it automatically activates ".headers on" if headers have not been previously turned on or off.
2020-06-04 drh Add support for "box" mode in the CLI: Like "table" except that it uses unicode box-drawing characters instead of ascii-art.
2020-06-04 drh Improved display of ".mode table" output for empty result sets.
2020-06-04 dan Use __has_extension(c_atomic) instead of __has_feature(c_atomic) to detect support for atomic load and store operations with clang.
2020-06-04 dan Use AtomicStore() to set values in the wal-index hash table.
2020-06-04 drh Work around a bug in clang-11.0.0.
2020-06-03 drh Fix for ticket [810dc8038872e212]. Thank to user "Maxulite" for tracking down the problem!
2020-06-03 drh Simplification to the interrupt handling logic in sqlite3VdbeExec() saves a few bytes of code space.
2020-06-03 drh Improve the query planner so that it is better able to find full index scan plan when there is an INDEXED BY clause.
2020-05-30 drh Draw the dashes below the headers in "explain" mode in the CLI.
2020-05-30 drh Improved VDBE comments on the ANALYZE code generator. This change also fixes a harmless use of an uninitialized integer variable as an input to the %d format on a VDBE comment.
2020-05-29 mistachkin Enhancements to the incremental build support for MSVC.
2020-05-29 drh Remove a stray "&" character in the CLI, detected by a clang warning.
2020-05-29 drh Add the "shelltest" target to the MSVC makefile as well.
2020-05-29 drh Fix the ".import" command of the CLI to clean up better after errors. Add the new "shelltest" makefile target on unix platforms.
2020-05-29 drh Improvements to help text for the CLI.
2020-05-29 drh Fix a memory leak in the CLI when an unknown or unrecognized argument is given to the ".dump" command.
2020-05-29 drh Improvements to columnar output in the CLI. Columns automatically expand to contain the largest row.
2020-05-29 drh Space to hold the ".width" of columns in the CLI is now obtained from malloc() and hence is not limited in the number of columns supported.
2020-05-29 drh Incremental improvements to tabular output modes in the CLI. The "markdown" and "table" modes no have headers turned on by default.
2020-05-29 dan Expand upon a comment in os_unix.c. No changes to code.
2020-05-29 drh In the json output mode of the CLI, do correct quoting of escape characters. Also, show BLOBs as JSON strings, possibly with embedded \u0000 bytes.
2020-05-28 drh Progress toward adding new output modes to the CLI: json, table, and markdown.
2020-05-28 drh Enhance the ".quote" mode in the shell so that it honors .separator.
2020-05-28 drh When the sqlite_stat1 data is missing for some indexes of a table but is present for the table itself or for other indexes in the same table, then do not let the estimated number of rows in that table get too small, as doing so can deceive the query planner into ignoring a perfectly good index.
2020-05-27 drh Small performance improvement and size reduction in the expression code generator.
2020-05-27 drh Change a datatype from i16 to int to appease Converity and help eliminate a false-positive.
2020-05-26 drh Fix the cksumvfs extension so that it will not register itself more than once.
2020-05-26 drh Performance optimization in the transfer of error messages from statements to connections.
2020-05-26 drh Increase the version number to 3.33.0 to begin the next release cycle.
2020-05-26 drh Innocuous changes to help Coverity avoid false-positives.
2020-05-25 drh Attempt to work around a false-positive warning in the CGo compiler.
2020-05-01 dan Fix problems with UPDATE...FROM statements that modify rowid or primary-key values.
2020-04-30 dan Add OOM tests for the new code on this branch.
2020-04-30 dan Report an error if an UPDATE...FROM statement has an ORDER BY but no LIMIT clause. Add tests for multi-column primary keys.
2020-04-29 dan Fix problems with using LIMIT and FROM clauses as part of single UPDATE statement.
2020-04-29 dan Fix various bugs in new feature on this branch.
2020-04-27 dan Allow a FROM clause in UPDATE statements.
Created with:
roll-dep src/third_party/sqlite/src
[email protected]
(cherry picked from commit 9c2848796cc438e7d5a622f0f8ae2b4bf3bc3f50)
Bug: 1117367
Change-Id: Ie37ce39b80489b01ea8569eafea79e5bf8c54d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364964
Commit-Queue: Darwin Huang <[email protected]>
Reviewed-by: Chris Mumford <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#800336}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466502
Reviewed-by: Darwin Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1226}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Avoid TabGroupModelFilter casting exception(2)
This is a follow up of crrev.com/c/2442479. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception in
TabGroupUiCoordinator.recordSessionCount().
This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.
(cherry picked from commit 8dbcfb66710c833bcf92998a60219141c060e344)
Bug: 1133922
Change-Id: I830b6721e15b6ca558e79b66dcd7a1b783186f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443395
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466391
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1225}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[M86 merge] weblayer: fixs possible NPE if a11y enabled during Tab creation
If a11y is enabled, then Tab creation may trigger calling some
code paths that assume mBrowser was non-null.
BUG=1136596
TEST=TabPrivateTest.testCreateTabWithAccessibilityEnabledCrashTest
(cherry picked from commit 42745534dcdb1a92f4a3b8ecd52ebae7068a0af9)
Change-Id: I500fd70cb56b7d16c22284acb677c06ec57b536d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461714
Reviewed-by: Bo <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815357}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466344
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1224}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge M86: "Only zero out cross-origin audio that doesn't get played out."
Cross-origin audio is still allowed to play out, it just can't be
captured by the containing page.
Bug: 1128657, 1134679
Test: Unit tests added.
TBR=cassew
(cherry picked from commit 5dc1b1bce3d19309b937af96723584351186bead)
Change-Id: Id4c73e315072b8683e45a2ddf929d534f1da9928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450390
Auto-Submit: Dale Curtis <[email protected]>
Reviewed-by: Will Cassella <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813956}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466504
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1223}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.94-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.95-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I31f32815e828df615df7085e922e95b1df4c621e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466335
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1222}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
M86: Check RF is alive In PrintRenderFrameHelper::PreviewPageRendered().
Do not take an accessibility snapshot if the RenderFrame is gone.
(cherry picked from commit 30261f9de11e776b50dc8c726308b8495db4232c)
Tbr: [email protected]
Bug: 1133983
Change-Id: I612cc72936a1dcedc5180c24eae067e47237b09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442375
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812851}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466395
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1221}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.94-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.95-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9f26970825c1bcc63acb8ddd09da9dfe85e33894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466334
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1220}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Adding a driver check in PasswordGenerationPopupControllerImpl::
PasswordAccepted.
Having this check ensures there is no nullptr dereference in case the
driver is deleted and the browser process is not aware of it (i.e.
in case when the renderer is compromised).
(cherry picked from commit 2726c1afa88d130f3f8b9ec4e03c774f06af07a1)
Bug: 1133635
Change-Id: Ieee8c2200a4b323af39f730011e733b74e8bc911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440095
Commit-Queue: Maria Kazinova <[email protected]>
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812695}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465773
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1219}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[printing] Reuse AwPrintManager with introducing UpdateParam()
This CL introduces AwPrintManager::UpdateParam() which updates
|settings_|, |fd_|, and |pdf_writing_done_callback_| in order
to reuse AwPrintManager avoiding creating it every time.
It fixes a regression issue by crrev.com/c/2326857. The
problem is that WebContentsFrameReceiverSet is created always
along with AwPrintManager but WebContentsImpl::AddReceiverSet()
expects that it's called once for an each interface. So, this
CL doesn't create AwPrintManager always like other print
managers such as PrintViewManager or HeadlessPrintManager.
(cherry picked from commit 296bf0c33fad795257038482dad37ba57287a093)
(cherry picked from commit c4b2c26af2a405baa404fcd55e9bcf786e0fe1af)
Bug: 1137016
Change-Id: I11c176009ccdad643ebf495cc4b983209ba8b1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463270
Reviewed-by: Bo <[email protected]>
Commit-Queue: Julie Kim <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#816141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466101
Reviewed-by: Ben Mason <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4290@{#3}
Cr-Original-Branched-From: bd0384ad8c56398b073fd362c68b6be977531874-refs/heads/master@{#816033}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466341
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1218}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix use-after-free triggered from mojo::SyncEventWatcher DTOR
This is something I've found while running Vewd internal test suites on
top of chromium 86.0.4240.x. I haven't managed to reproduce this on
content_shell but since I believe I do understand the root cause pretty
well I can say this also potentially affects chrome.
What is also interesting about this is the fact that the test case which
reproduced this quite consistently stopped doing so when using ASAN
enabled build. This leads me to believe there has to be some timing
factor involved here.
As far as I can tell this was introduced recently by commit
4b7b326560c2cb64b38f207f34f32d1acf5d3d8f, "Convert SyncHandleRegistry to
use a CallbackList".
The problem happens sometimes when SyncEventWatcher is destroyed.
If we look at the declaration of this class we may notice that its
registry_ member variable will be destroyed before subscription_.
(NOTE: SyncEventRegistry::EventCallbackSubscription is a typedef to
SyncEventRegistry::Subscription). The instance of Subscription is created
in SyncEventRegistry::RegisterEvent. This function, among other things,
creates binding for "remove_closure" lambda function. This binding stores
a raw pointer to a EventCallbackList which is a raw pointer to a unique_ptr
value stored in SyncHandleRegistry::events_.
Given this information we can have the following scenario when the
SyncEventWatcher is destroyed:
1. SyncEventWatcher DTOR calls SyncEventRegistry DTOR.
2. SyncEventRegitry DTOR destroys its member variables and among them
events_ which destroys all the EventCallbackList values storred in
this map.
3. SyncEventWatcher DTOR calls SyncHandlerRegistry::Subscription DTOR
which in turn calls its remove_runner_ closure we created in
SyncHandleRegistry::RegisterEvent.
4. The remove closure function (lambda function defined in
SyncHandleRegistry::RegisterEvent) tries to use EventCallbackList
(first argument, stored in a binding) we destroyed in step 2 leading
to a use-after-free bug.
The simplest fix is to reorder registry_ and subscription_ variables in
SyncEventWatcher to ensure the registry is always destroyed after
subscription.
(cherry picked from commit 50cead337c3d2c6f1abded650655ec0933e02520)
Bug: 1133668
Change-Id: I35be7818b184308ccfb7a01895062de087233abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438399
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812176}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465513
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1217}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[WebLayer] Guard against duplicate tab destruction when launching intent
When the intent launching code determines that a tab should be closed
(e.g., because the initial navigation resulted in the launch of an
intent), it posts a task to the embedder to asynchronously close the
tab. We are seeing crashes in WebLayer indicating that in the interim
the tab is being closed for another reason. TabImpl does not guard
against its destroy() method being called multiple times, and the crash
results due to members being invoked and then nulled out in that method.
This CL adds a targeted fix for this flow, changing //weblayer's
InterceptNavigationDelegateClientImpl to short-circuit out of its
closeTab() method if it has already been destroyed. I avoided changing
TabImpl#destroy() to guard against multiple invocations as in general
we would regard any such flows as errors that should be detected and
fixed (like this one).
I investigated making a test for this case but so far have been unable
to program a flow where I can cause a tab opened via an intent launch
to be destroyed in the interim between the navigation starting and the
intent launching code destroying the tab. It is worth pointing out that
I still don't know what use case would result in this flow in production,
so this is a speculative fix. Nonetheless, it is a good change to make
in any case.
(cherry picked from commit 2da9cc92fa3fbcb71f63436da02bb99cb9ceba0a)
Bug: 1132983
Change-Id: I2b3c5a1598f6f13887f70bff90d822afbbd3f3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442626
Reviewed-by: Bo <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812682}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466500
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1216}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix a NPE in TabGroupUtils
This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.
(cherry picked from commit 9790b44edc2a5d8015e577c648075a154d74c51b)
Bug: 1133908
Change-Id: I90d4576a460303da137bb50ed53552c724628872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441934
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812526}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466360
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1215}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix TabGroupModelFilter casting exception
TabUiFeatureUtilities.isTabGroupsAndroidEnabled() does not guarantee
TabModelFilterProvider().getTabModelFilter() returns
TabGroupModelFilter. It can return null before
TabModelSelectorBase#initialize() is called. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception.
This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.
(cherry picked from commit bdbeca365c145f292174a50a8f02c42fffa14f92)
Bug: 1133922
Change-Id: I9766d4f0f54c954f8205866aa0c514b508d7a5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442479
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466390
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1214}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.94-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.95-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I368634579957067aed9da63a1f044763dd9c750d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465581
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1213}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[M86] sandbox: add feature flags to control Spectre v2 mitigation in sandbox_bpf
This CL adds two feature flags:
- spectre-v2-mitigation: Enabled by default
This flag can be used to control whether the mitigation is enabled
through sandbox_bpf. The per-platform settings can use this flag to
selectively disable the mitigation for performance.
- force-spectre-v2-mitigation: Disabled by default
This flag takes the highest priority and can be used to override the
above flag. Setting this flag to enable ensures that Spectre v2
mitigation is enabled regardless of the per-platform settings.
Bug: b:169104787
Test: Toggle chrome://flags#spectre-v2-mitigation and
chrome://flags#force-spectre-v2-mitigation and verify the sandbox
behavior.
(cherry picked from commit 3bd2754b567d962f0dd05f13d136f1f51051a3f2)
Change-Id: I3615c69e610c10d98c3495986ff8b673b6e20db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428298
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Reviewed-by: Brian Geffon <[email protected]>
Commit-Queue: Ricky Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814522}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462993
Reviewed-by: Ricky Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1212}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Don't report layout shift for visibility:hidden
BTW fixed a small invisible bug for anonymous LayoutObjects which just
affects performance a bit.
[email protected]
(cherry picked from commit 472f4e6477790719330e015050dac8ef250b0dce)
Bug: 1127474
Change-Id: I926bef2572a1d0099c2e106fdd4eb36756e99fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410816
Reviewed-by: Steve Kobes <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#807049}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466160
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1211}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Reland "Add callback to WebMediaPlayerImpl to notify when a redirect occurs"
This reverts commit bc58153181d6566a111816133b750dc276afc632.
Reason for revert: Fix available.
Original change's description:
> Revert "Add callback to WebMediaPlayerImpl to notify when a redirect occurs"
>
> This reverts commit 88f263f401b4b2f67d96f74fa2c6ce8119fb78c2.
>
> Reason for revert: Breaks played out audio too.
>
> Original change's description:
> > Add callback to WebMediaPlayerImpl to notify when a redirect occurs
> >
> > (cherry picked from commit 8b18bcfd9aa8096c4551ec34c0225b6017cd211e)
> >
> > Bug: 1128657
> > Change-Id: I9548e1f3bfe5693871a56e23c3373f45147e52e0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422091
> > Reviewed-by: Dale Curtis <[email protected]>
> > Reviewed-by: Guido Urdaneta <[email protected]>
> > Commit-Queue: Guido Urdaneta <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#809217}
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425223
> > Commit-Queue: Will Cassella <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/4240@{#993}
> > Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
>
> [email protected],[email protected],[email protected]
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1128657
> Change-Id: I0b2264a4078059a4aebd8117446e112565994f49
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450349
> Reviewed-by: Dale Curtis <[email protected]>
> Reviewed-by: Guido Urdaneta <[email protected]>
> Commit-Queue: Dale Curtis <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4240@{#1148}
> Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1128657
Change-Id: I258a10ea47e25ba4048d16a04de979a67c4d0af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466397
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1210}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix IsolatedPrerender misnamed canary check
(cherry picked from commit 9e6f7bbe7ae7f4b4db49e1bcf5d2bd4b0a08c484)
Bug: 1134643
Change-Id: Ia5fb8a67ae27436b8ec6bf6bbb5dd051944d3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446197
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813321}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465725
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1209}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Setting version to 86.0.4240.98
[email protected]
Change-Id: I1f45bffa04ce3954ed382adb82896840b8c42173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464429
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1208}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Clipboard: Add UMA metrics for content script reads without user activation. (M86).
The proportion of content script reads without user activation will
inform potential deprecation plan and messaging.
(cherry picked from commit 7d1795d455c8bd7459e970cb13f44c79b04ecc3c)
Bug: 1051198
Change-Id: Ie9c76a6d26ee78219729ef54da7237eb061c98f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440116
Reviewed-by: Weilun Shi <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813889}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464084
Commit-Queue: Weilun Shi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1207}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.93-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.94-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3928c467acc7bec14e790e8594d52ae9749b65c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465783
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1206}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.93-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.94-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I19d49a3ceea2799771fa3fde35f060e21dd23d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462734
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1205}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.93-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.94-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If0b703f6131d32182d023f2da674f2bf5bc14dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465782
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1204}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.95
[email protected]
Change-Id: I9441723f20e75342e1953de91c6724f3c5c7c35f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465303
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1203}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.81-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.93-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie15dff1eff060673feafa684b9a5fe9290ada7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465120
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1202}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.94
[email protected]
Change-Id: I1a5051fbf72fb6b6d94c0376980c49ef0ea21570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464904
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1201}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.81-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.93-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia1f32f3213b15dc58dda88ac79c66878128834a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464629
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1200}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.81-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.93-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I37f63eef1022a50912b3b1f7e064c4c032da26f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464755
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1199}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.81-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.93-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I32e68b5c79533db7e62f253a41c5a3d64121ea8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464756
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1198}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.78-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.81-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib4a8d4b15c69440cd9d5f173067bbe79f228a202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464472
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1197}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.93
[email protected]
Change-Id: Ia503198aeabbb4108926d48c233ec1e73d630847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464206
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1196}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.92
[email protected]
Change-Id: Ib4b1e45e4cdb48fba3f365a5f36baadc02051022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464009
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1195}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
ios: Speculative workaround for WebKit dispatchIncomingMessages crash.
Preload appears to trigger an edge-case crash in WebKit when a restore
is triggered and cancelled before it can complete. This isn't specific
to preload, but is very easy to trigger in preload. As a speculative
fix, if a preload is in restore, don't destroy it until after restore
is complete. This logic should really belong in WebState itself, so any
attempt to destroy a WebState during restore will trigger this logic.
Even better, this edge case crash should be fixed in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=217440.
The crash in WebKit appears to be related to IPC throttling. Session
restore can create a large number of IPC calls, which can then be
throttled. It seems if the WKWebView is destroyed with this backlog of
IPC calls, sometimes WebKit crashes.
See crbug.com/1032928 for an explanation for how to trigger this crash.
Note the timer should only be called if for some reason session
restoration fails to complete -- thus preventing a WebState leak.
(cherry picked from commit 8b215cc6f3668926de36b0600e24ca08621c21e9)
Bug: 1032928
Change-Id: I217918437d5cdc6f610f3331634791699dd678ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461571
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815667}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462394
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1194}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.79-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.81-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I15e47f4ca282413551a507d8e3bbde5f2b9c0554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463739
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1193}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.79-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.81-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ide4554c44762b9eab2a16bc30558e72e2f351db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463486
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1192}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.79-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.81-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I61bc1d3da5e461b0b01cd4b8b282e7fb534231a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463787
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1191}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Call ResumeLoadingCreatedWebContents during WillAttach.
window.open on webviews had their widgets left in half creation state
which is unexpected. The Init call is supposed to be called after
the Window/Widget is shown. This was not called due to the
ShouldResumeRequestsForCreatedWindow callback.
The ShouldResumeRequestsForCreatedWindow() is added because
we want to wait until the load is complete on the embedder page so
it has a chance to execute before the guest contents.
Since the RenderWidgetHostImpl::Init was never called it caused an
issue when input handler binding was moved to be performed during the
Init call.
BUG=1132643
(cherry picked from commit 807d457ff286d9c40391cbe0cb5fd10e61389b2b)
Change-Id: If8967d21bdbeb5dd9114eb918af793f88c4fe330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438477
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: James MacLean <[email protected]>
Reviewed-by: Lucas Gadani <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812354}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462488
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1190}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Setting version to 86.0.4240.91
[email protected]
Change-Id: I367949c44eae5b69468466b9f4a8f98d153c9586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462561
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1189}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.78-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.79-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I564b2e14ac1db75d0e30e910ed9aca18ac39ab91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463174
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1188}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.78-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.79-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I93f39a512fdb8bc8d410071964864e26d924ef82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463173
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1187}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.78-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.79-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3ab510277a815b160c36f490f18272b3ab38cee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463172
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1186}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.81
[email protected]
Change-Id: Idade5787f0b1e200ccaebd176771de351eeb2cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462045
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1185}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix the UIL blocking issues.
We found some issues with VK on UIL mode, there is a deep root cause
between Chrome and IME extension that requires more eng hours to fix
them thoroughly.
So we have to disable it before the stable launch.
TEST=Both QA and e14s team have tested it based on common test cases.
BUG=b/169893336
Change-Id: I6a0cf3b7ba6e09a58f9cf413d5a16be7b342e764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460549
Reviewed-by: Geo Hsu <[email protected]>
Reviewed-by: Leo Zhang <[email protected]>
Commit-Queue: Leo Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1184}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.80
[email protected]
Change-Id: Id163981bc2dddd3aeff1186530346d903ae7177c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461990
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1183}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.77-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.78-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1092f341e660aba3c20cdb1041e738fcafb82726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461250
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1182}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge "Stop recreating keychain item for SC private API"
Merge into M86
The chrome.enterprise.reporting_private.getPersistentSecret return
-25300(errSecItemNotFound). It's likely caused by keychain item
recreation. Disable the feature for now to relieve the issue on Stable.
Bug: 1136089
(cherry picked from commit 7697f17e6b7e9beb34e5f2ac0b092d389ca8ca3b)
Change-Id: Icbd96ce81a448e1069c3adee08bfca19a66b4bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456509
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814698}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460973
Cr-Commit-Position: refs/branch-heads/4240@{#1181}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[M86] OOBE: Make UserSessionManager more robust to shutdown during the login
* Use AsWeakPtr instead of base::Unretained in the WizardController
* Check chrome::IsAttemptingShutdown together with
browser_shutdown::IsTryingToQuit. IsAttemptingShutdown covers call to
chrome::AttemptUserExit() which is common in the Chrome OS login/policy
code.
(cherry picked from commit 13c9a810b7bf1189a53115cfbdfa16c4a42af36e)
Bug: 1132397
Change-Id: I6c0e28138918a998c94f82f5c9e7736df92e5ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450051
Reviewed-by: Thomas Tellier <[email protected]>
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813764}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460726
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1180}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Get supported formats before sandboxing
This CL fixes a bug that will cause camera failed to play the preview.
Bug: b/166850715
Test: Launch Chrome Camera app and preview is shown
(cherry picked from commit 4df0e8baa6c73a960a6a3e34d484135b95ef1d58)
Change-Id: If61d74dc9478bc6138389b9fa6c0dded5a6e8359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454592
Commit-Queue: Wei Lee <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814705}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459937
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1179}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.79
[email protected]
Change-Id: I4385e54764ae73673f3c1d18f65ac621d47ba2c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459639
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1178}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-4240-1600106121-4b753719bf4dabffe357a795fe2616ed4d2dd34a.profdata to chrome-mac-4240-1601639416-09736f545caac8e0b08864793b6e2b0f41a37f9f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: I84d19ae58ad26a8ff0c079c277c8ff58e9f85613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458026
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1177}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[ios] append disable_widevine_signing to official_goma_mac mb
official_goma_mac MB configuration is used by the mac-chrome,
mac-chrome-beta, and mac-chrome-stable trybots.
the trybots are still failing due to widevine signing, so appending
this disable_widevine_signing which will set
enable_widevine_cdm_host_verification = false according to the
suggestions from the GN failure.
Bug: 1135196
Change-Id: I18074973a08aa3ee4bd183472bd8354576686674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458772
Commit-Queue: Jeff Yoon <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1176}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.77-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.78-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0eaa69915c0be1852772a2ebda069eeac4438751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458948
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1175}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.77-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.78-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ife922c1c5003e12a51b0413170e6841741a3e7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458829
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1174}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.77-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.78-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I412c614c28783501688fa4a000e5c4bb7aeb0f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458830
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1173}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Update import_util.py to work from chrome/chrome_cleaner/internal
This prepares for a pending commit to the internal chrome_cleaner repo
which will delete the internal copy of import_util.py:
* Add separate GetChromiumRootDirectory and GetInternalRootDirectory
functions to clarify the ambiguous term "root directory" when called
from the internal repo mounted at //chrome/chrome_cleaner/internal.
* Move all the functions that depend on being called from inside the
chromium source tree to a separate import_paths.py script. (All the
current callers of these functions happen to be in
//chrome/chrome_cleaner/internal.)
* Delete code to find a local copy of find_depot_tools. It's no longer
supported to run this script without calling gclient sync, which will
update depot_tools.
R=proberge
(cherry picked from commit 1673a55ce9dfd635d021fd5b238f8b147d3ccc70)
Bug: 1004848
Change-Id: I829851f332975c950f1dcde59735ee96f34f295e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451810
Reviewed-by: proberge <[email protected]>
Commit-Queue: proberge <[email protected]>
Auto-Submit: Joe Mason <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814390}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457551
Reviewed-by: Joe Mason <[email protected]>
Commit-Queue: Joe Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1172}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.74-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.77-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic8fb036ea30682f629da7dde481082db329c9c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457287
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1171}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[ios] disable widevine for mac-chrome* trybots
The trybots for 4240 (mac-chrome-beta) are failing because of
widevine at compile time. Matching the status of ToT and adding
this in for mac-chrome* trybots.
Bug: 1135196
Change-Id: If34dd2dfce30d692a0f42f5bc001446b6b396c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450910
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Jeff Yoon <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1170}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Clear fast_ink GpuMemoryBuffer
The buffer contents may be uninitialized on some platforms. Ensure that
it is cleared before being displayed.
(cherry picked from commit 99835f16f61a424c5abde7d41360c416b17182e8)
Change-Id: I55007e0728852d38911515019a2a7a3640ef613c
Bug: b:168735625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413179
Commit-Queue: Drew Davenport <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813182}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450789
Cr-Commit-Position: refs/branch-heads/4240@{#1169}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[M86 merge] Unsubscribe from Drive invalidations when Drive shuts down
This is so that we don't stay subscribed to Drive invalidations in
Chrome when we switch to using DriveFS's invalidation stack.
(cherry picked from commit 6f52aa0cf46a32b7bf385c202b305b9868f7dc0a)
Bug: 1130427
Change-Id: I290f5ddacac20175a3e4845d8dc7c62f86315c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428286
Reviewed-by: Kazuhiro Inaba <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Commit-Queue: Austin Tankiang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812034}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454812
Reviewed-by: Austin Tankiang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1168}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.78
[email protected]
Change-Id: I2e69ac0567808cca7110b7fe89255cf9ada9e6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454851
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1167}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1601896070-benchmark-86.0.4240.74-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.77-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibae1caa8907034dfdf6c4fee6dc080790c7916a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454310
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1166}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601894579-benchmark-86.0.4240.74-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.77-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iceb5f9be517dc27e22c1630bd7a9b68b9dfee0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453510
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1165}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.68-1601891844-benchmark-86.0.4240.74-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.77-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I03725ad6d8f8fd30c74307d04455d3a1a47fa495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454152
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1164}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Messages: Re-enable feature for users that hit crbug/1131140.
This performs a one-time re-enabling of the Messages feature if the PWA
is installed but the feature is in the disabled state. This also
prevents showing the pairing lost notification if unpaired when
re-enabled.
(cherry picked from commit f28f656953a1be371a2aadc214ef6f3bf3ad6870)
Bug: 1131140
Change-Id: I1114cab793c9bad4387c6edf886bcbd735fa7ca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432109
Commit-Queue: Jon Mann <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Azeem Arshad <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#811598}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450410
Cr-Commit-Position: refs/branch-heads/4240@{#1163}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Messages: Wait for app registry to load before querying for PWA info.
Recent changes to the apps framework caused a delay in loading
app information during login. This requires that we wait for
WebAppProvider::on_registry_ready() before querying the apps
database for information on installed PWAs. This issue was resulting
in the Messages feature getting disabled after the app was perceived to
be uninstalled.
(cherry picked from commit 7e225a678edf91052005b8dfd1c46ef7bc9c21ec)
Bug: 1131140
Change-Id: Ie2448fed1d04a9525b5dd5a452cb0b000a29ce0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429527
Commit-Queue: Jon Mann <[email protected]>
Reviewed-by: Azeem Arshad <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#811565}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448290
Cr-Commit-Position: refs/branch-heads/4240@{#1162}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Ash Notification: Add SetPaintToLayer to stacked notification bar.
The regression bug below was caused by ff070b8 where we changed
SetPaintToLayer in TrayBubbleView. Added this to stacked notification
bar to fix the issue.
BUG=1116396
(cherry picked from commit 3382f12067dbf18f187e1499ea9a20e8ca4705c5)
Change-Id: Ied59608d5cce78396a8352faf9d583ca877de74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372103
Reviewed-by: Tim Song <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#801419}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448051
Cr-Commit-Position: refs/branch-heads/4240@{#1161}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.49-1601290298-benchmark-86.0.4240.73-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I19786fb09acc74c0eb894813b3a913aea8b2ae0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452870
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1160}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Merge-M86] Turn off Release notes suggestion chips.
These don't currently work the way we expect them to, so turn off for
now.
Bug: b/169711884
Change-Id: I4f248220623f6ad74fafd7ef9948cdefba56dc30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449871
Reviewed-by: Nancy Wang <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Rachel Carpenter <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1159}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Disable flaky external/wpt/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries.html [M86]
[email protected]
(cherry picked from commit 259a6a6a8cae40992d5f5145c1168db517214422)
Bug: 1126649
Change-Id: I1465651fe037270e70e6033b5a173bdde98b1e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402115
Reviewed-by: Evan Liu <[email protected]>
Commit-Queue: Evan Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#805540}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451552
Reviewed-by: Carlos Knippschild <[email protected]>
Commit-Queue: Carlos Knippschild <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1158}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[CrOs] Update supported version for display password button feature
The current value for this policy indicates that it applies to all ChromeOS versions after M84, however this wasn't right as that policy was not released by then: it was ready after a change I made in M86. This CL updates the 'supported_on' value to match what the product actually supports.
BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but
setting the correct value causes the policy checker to complain.
(cherry picked from commit 77ce7fd69e42d7de65f9def7b90920c792cea135)
Bug: b/169582602
Change-Id: I9c4d27a73f2ab78d13a95d6ab49dabc7d65c200d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435098
Commit-Queue: Thomas Tellier <[email protected]>
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Auto-Submit: Thomas Tellier <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812716}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440843
Reviewed-by: Thomas Tellier <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1157}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.77
[email protected]
Change-Id: I5bc6b2388e4b0195075dc9e6671e467ec5a5f9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451551
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1156}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.76
[email protected]
Change-Id: I701fc49fadc1777728700e4dfdad592e074270d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451320
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1155}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.49-1601290298-benchmark-86.0.4240.73-r1 to 86-4240.68-1601891844-benchmark-86.0.4240.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id2c3e99a41a7173fd5702cf114324fe9739632fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450705
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1154}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.49-1601291717-benchmark-86.0.4240.73-r1 to 86-4240.49-1601894579-benchmark-86.0.4240.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7315c5560446ec7b66a112eb70f7bd31898cbe0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451353
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1153}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Merge] [Siri Shortcuts] Add checks for old shortcut actions
It appears that in some rare cases that aren't fully understood yet, old
versions of intents are passed to Chrome instead of the new intents.
This makes it so any new intent parameter isn't there or is of the wrong
type, which can lead to crashes.
This CL attempts to prevent these crashes by adding type checks and null
checks for properties missing in old intent versions.
(cherry picked from commit 87402bb8f1b2cf8fd06014a47b6fa61940a05dfa)
Bug: 1133825
Change-Id: I55ec931ccdaf1afaf36ab31f73c405ac7c2b49b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441631
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Guillaume Jenkins <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813264}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448060
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1152}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.49-1601287891-benchmark-86.0.4240.73-r1 to 86-4240.68-1601896070-benchmark-86.0.4240.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6aeb16bec7645788e43347401127ddfcfc352778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450591
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1151}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Initialize WebStateListMetricsBrowser after SessionRestorationBrowser
WebStateListMetricsBrowser requires SessionRestorationBrowserAgent,
so it must be initialized earlier.
Also initialize WebStateListMetricsBrowser member variables that were
left uninitialized.
(cherry picked from commit c243c5e76e3eb37ce3c31609639f6556a2fa65da)
Bug: 1132784
Change-Id: I28b9d5afca58870a6273eb1c3b3418a45c9fcd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435344
Commit-Queue: Olivier Robin <[email protected]>
Auto-Submit: Olivier Robin <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#811236}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450011
Reviewed-by: Bindu Suvarna <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1150}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
