Publish DEPS for 85.0.4183.38
Incrementing VERSION to 85.0.4183.38
[email protected]
Change-Id: Ic04eedb89567f816c7df50b7f67cc0a9d4b6f6e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308923
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#779}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Query Tiles : Added a flag to run country based finch experiment
This CL adds an additional flag that will act as a gateway for query
tiles feature. Any current usage of query tiles will check for this
feature as well. This is required for running country based experiments
while not introducing crosstalk with other omnibox experiments.
Finch CL : https://critique-ng.corp.google.com/cl/321059391/
Bug: 1105246
Change-Id: Ic89ed0c0be462709fe99b58b680bcbc15b5fe087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296287
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Reviewed-by: Ender <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#788427}
(cherry picked from commit e259078d1c5281c630361ce8a22fabb9f76df31d)
[email protected]
Change-Id: I91f68e1dc90d882729a53709c41d8bebc6252ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308990
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#778}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595239274-081e253b6d4ef4b6ccdf78feea5b29df9a99dce7.profdata to chrome-win64-4183-1595267054-b1657a190a5ec4f16ad90168875491f040191920.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I6506d4e699a64381a34d89b75edb91913c88e6b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308271
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#777}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.37
[email protected]
Change-Id: I8291054fa081eec23b52db7aad91bee084833dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308919
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#776}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.36
[email protected]
Change-Id: Iab22977b75b02b5bf08705d8911de3c1e7266f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309001
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#775}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Clipboard API: Implement clipboard-read and clipboard-write Feature Policy (M85).
Complete and expose previously incomplete feature policy integration.
Also, use separate clipboard-read and clipboard-write feature policies,
as opposed to the previous single clipboard feature policy.
Previously, https://crrev.com/c/1913466 aimed to add Feature Policy
integration to the Clipboard API. Unfortunately, this integration wasn't
complete, so sites didn't have the option to allow cross-origin iframes
to access the clipboard at all after this change.
Complete the integration to allow sites to enable this feature policy.
Also, as feature and permission policies are being merged, use
clipboard-read and clipboard-write as feature policy names, so that the
feature policy and permission names match.
Verified by via automated WPTs, and also manually tested by running this
example[1], which fails without this CL, and succeeds with the CL.
Intent to prototype and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IDAapW6w4to/iSH1MXRFCgAJ
[1]: https://smart-flicker-baroness.glitch.me/
(cherry picked from commit 4016627965a85c035f1a0838469f4dc0e9c7eec6)
Bug: 1074489
Change-Id: I09125d74510ed6c868d84936df595d02326619b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164248
Commit-Queue: Darwin Huang <[email protected]>
Reviewed-by: Alex Russell <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786914}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304330
Cr-Commit-Position: refs/branch-heads/4183@{#774}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595259364-27873e2443bc91486a0058c15c17ca3442cabc98.profdata to chrome-win32-4183-1595267054-8874a1d224f6dfc926514ebba21b4b4cb7fd18b5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I79bccc5f0e6b9071113ed4eef842b0dd646259fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308365
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#773}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Omaha on Android: fixed the on-demand check not working due to an IllegalStateException
RequestGenerator::getNumSignedIn() made an incorrect assumption that it was running on the UI thread. Fixed it to match RequestGenerator::getNumGoogleAccountsOnDevice(), which posts the necessary code to the UI thread.
Tested manually by having OmahaBase::getRequestGenerator() return a custom version of MockRequestGenerator and checking "adb logcat".
(cherry picked from commit 5fc6538c822b6c8e6388b9d33498c1484da990af)
Bug: 1070620
Change-Id: Ib04e34ea0b2d7ca2fc64a209731013e6d43fd09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300384
Commit-Queue: Joshua Pawlicki <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Auto-Submit: Andrey Zaytsev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789033}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309230
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#772}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Don't crash when using 'revert' in var() fallback
CSS-wide keywords should not be allowed here in general, but they
currently are by Chrome and FF. (And WPT requires this behavior).
It would be easy to make revert-in-fallback actually behave as
'revert', but I don't want to ship this behavior since the spec doesn't
currently define how to handle this. So for now I'm just adding a unit
test that verifies that we don't crash.
(cherry picked from commit 88b1d19329dff67302e2c84008d9a7aaad758a00)
Bug: 1105635, 1105782
Change-Id: Ia8c9100484c3c351f67aada850211a0ff6d2367f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300079
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Oriol Brufau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308391
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#771}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.35
[email protected]
Change-Id: I58790c630b2e238ed7392aab058038fa492278c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308911
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#770}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Send not granted VM permissions in GetPermissions response
Instead of sending only permissions that have been granted, send also
the ones that have not been granted, but can potentially be granted.
Only suppress permissions completely disabled via either a Chrome
feature flag, or enterprise policy.
(cherry picked from commit d08776b9e575cf289db6d4f77b6e6d8e5c4d54b9)
Bug: 1071872
Change-Id: I00a9a11b00c908753e9d21d26b646ff204a5f958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304990
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Dmitry Torokhov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307151
Cr-Commit-Position: refs/branch-heads/4183@{#769}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595239274-266e970a63abc8980ae809999edb17fea659c754.profdata to chrome-mac-4183-1595267054-cc2f0b47052d2262ff3533330d26c23dea97df51.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia8739bf949ff6a91887ea184b260fe093812c300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308269
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#768}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Check for existence of 64-bit library.
Bug: 1023634
Change-Id: I72e977935e55c57df06fe8e21eaa14b8773fc833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308214
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#767}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll src/third_party/libavif/src/ f48a33827..01ee4caa5 (77 commits)
Merge to release branch 4183 for Chromium M85.
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/f48a33827db6..01ee4caa5ab5
$ git log f48a33827..01ee4caa5 --date=short --no-merges --format='%ad %ae %s'
2020-07-14 jdrago v0.8.0
2020-07-14 jdrago Update CHANGELOG
2020-07-14 jdrago Fix usages of rgb in README
2020-07-10 wtc Set encoder chroma sample position
2020-07-10 wtc avifenc: add --tilerowslog2 and --tilecolslog2
2020-07-10 jdrago Build nasm from source in GitHub the way it is built in Travis
2020-07-09 wtc Update avifBitsReadUleb128 with latest dav1d code
2020-07-09 wtc Do not set cfg.kf_mode = AOM_KF_DISABLED
2020-07-09 jdrago Remove monochrome from this new check
2020-07-09 jdrago Fix lossless monochrome checks; this needs another pass
(...)
2020-06-22 wtc avifImageRGBToYUV() cleanup
2020-06-22 jdrago Stub out a contrib directory for future PRs
2020-06-22 wtc Build LIB_FILENAME from CMake variables
2020-06-22 wtc avifRWStreamWriteFullBox() cleanup
2020-06-22 jdrago Avoid known crash in libaom's monochrome encoding, and simulate it with YUV420 as a fallback
2020-06-22 wtc Remove yShift out param from avifImageCalcAOMFmt()
2020-06-22 E.M.terHoeven Changelog.md: Add line for dav1d 0.7.1 update
2020-06-22 E.M.terHoeven Ext: Update to dav1d 0.7.1
2020-06-19 jdrago Partially fix my grammar in my run-on sentence
2020-06-19 jdrago Add some additional comments explaining the usage of ID 0 when calling avifDecoderDataFindMetadata()
Created with:
roll-dep src/third_party/libavif/src
[email protected]
(cherry picked from commit 026ca150e1066086e7e19a324f30c06eea903820)
Bug: 1105148
Change-Id: I59baa6b8b3e68fd59b52081e07922a76a467506f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300629
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Wan-Teh Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788854}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308169
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#766}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[iOS] Fix Context Menu on scrolled cross origin iframes
When presenting context menus for elements within iframes, page offsets
was only being being taken into account for same origin iframes. Cross
origin iframes were not adding the page offsets before searching for the
element at the point. This was split into two code paths because Context
Menu only worked on same origin iframes before the iframe messaging
system was in place.
Instead of handling cross-origin and same-origin iframes differently,
always send a postMessage to the child frame and account for the page
offsets when the message is received. As an additional benefit, this
allows tests to cover the now single code path.
(cherry picked from commit 112cdc64cc384ffbb706646b6d3a1a9a491dd87b)
Fixed: 1104265
Change-Id: I8ce71ae3fcf6ad04a1ac4f4761d74b8a143f55db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299524
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788951}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308189
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#765}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.33-r1 to 85-4183.25-1595242725-benchmark-85.0.4183.34-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5d764e8c69120092e845aec63a184922ce098f01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308360
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#764}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.33-r1 to 85-4183.25-1595239163-benchmark-85.0.4183.34-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic3f6ad02bedbad8ae56a2c0ed2aa4df534749c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308670
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#763}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.33-r1 to 85-4181.3-1595240962-benchmark-85.0.4183.34-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If94f74d519b766102cd70bbbb199f4b93bc5018a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308367
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#762}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Updating XTBs based on .GRDs from branch 4183
[email protected]
Change-Id: Ice317802424aa7dca682134abe7a17c514f54faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307443
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#761}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595248216-b822333241e2a35447b4e723827e0d785be9221a.profdata to chrome-win32-4183-1595259364-27873e2443bc91486a0058c15c17ca3442cabc98.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I07605f102bee9a12bd4fc28616e1df7ee9d0370b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307635
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#760}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[M85 Merge] PDF Viewer: Fix cr-action-menu to not scroll away after opening.
<dialog> instances by default are absolutely positioned with
respect to the <html> element. Moreover, it seems that setting
"position: relative" on any of its parents does not have any effect.
Using "position: fixed" fixes both issues (scroll position flashing
and action menu scrolling away after opening).
(cherry picked from commit 3da6383efae5978abe3c3ed17287ed9a374c066c)
Fixed: 1105643
Change-Id: I1b0a5ca653b37b5455c237b2917ca79e4556af1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302747
Auto-Submit: dpapad <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: dpapad <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789302}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307475
Cr-Commit-Position: refs/branch-heads/4183@{#759}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Add end() check to fix security bug
Fix the bug by checking we have not reached the
end before accessing.
BUG=1095560
(cherry picked from commit 1755fa3ec13735194ebc95b9c06052244040fdae)
Change-Id: I309237562ddd5058c3b3b99d58a03c526cf49b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276511
Commit-Queue: Becca Hughes <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784113}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307618
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#758}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Reland "Fix UAF in SelectType"
This is a reland of 72158deaf3751325f1983c87829f65441ee32de3
The only change made here is to add the new test to LeakExpectations,
pointing to crbug.com/1103082. Local testing shows that this leak
is triggered by the new test, both before and after this patch. And
since the patch fixes a UAF security bug, I'd like to land it with the
test, and then work on the leak.
[email protected]
Fixed: 1102408
Bug: 1103082
Original change's description:
> Fix UAF in SelectType
>
> This fixes the UAF detected by ClusterFuzz in [1], caused by [2].
> The test case added here is a minimized version of the clusterfuzz
> case, and I verified that it crashes (ASAN UAF) before this patch
> and no longer crashes after.
>
> [1] https://clusterfuzz.com/testcase-detail/6224868955193344
> [2] https://chromium-review.googlesource.com/c/chromium/src/+/1912682
>
> Fixed: 1102408
> Change-Id: Ieb6a9582ff5b9676596048920bbcff881fdc2eb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283901
> Commit-Queue: Mason Freed <[email protected]>
> Auto-Submit: Mason Freed <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#785970}
(cherry picked from commit e1c45006a8e5a97778eeed0010a7f57d86e70ca4)
Change-Id: I471cb4abc98a7627803de4e434e0453cb729c15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288372
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786562}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306554
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#757}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[85]MediaCapabilities: check gpu video acceleration for powerEfficient
Feature disabled by default. Enable with command line:
--enable-features=MediaCapabilitiesQueryGpuFactories
Historically info.powerEfficient was determined by the
VideoDecodePerfHistory DB. This patch instead queries the GpuFactories
(proxy for hw decode) for to ask the question directly.
The critical difference is that the DB requires some past data to
be correct, while GpuFactories will know the answer without ever having
played a video.
Change-Id: I402bc03d008c73fa1bccf61beb61609efaf42ddf
Bug: 1105258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295684
Commit-Queue: Chrome Cunningham <[email protected]>
Reviewed-by: Chrome Cunningham <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#788421}
(cherry picked from commit 2546f022d97a38cf246d2826a6671d05db0483d0)
[email protected]
Change-Id: I402bc03d008c73fa1bccf61beb61609efaf42ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307614
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#756}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix IsolatedPrerender NSP Crash
If the SubresourceManager is destroyed in the same stack as the
TabHelper's page_.reset(), then it seg faults because TabHelper::
OnPrerenderStop changes state on page_.
To fix, the handle should not be observed when it is cancelled due to
destruction of the SubresourceManager.
FWIW, I checked all other code paths to ensure this is the only place
where this bug can occur.
[email protected]
(cherry picked from commit d1c934c3255bd61589bd7c038a3e7ad295bf926d)
(cherry picked from commit 39ac546703fc32164076f5def5b922bba7bf8e18)
Bug: 1107168
Change-Id: Id8f74e2433e2cec2f9c4c2f4ada9a31790df8219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306549
Reviewed-by: Robert Ogden <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#789792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307529
Reviewed-by: Ben Mason <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4207@{#4}
Cr-Original-Branched-From: d3db9d996124c2e3cd070ea1f62bd97da413c45a-refs/heads/master@{#789768}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307416
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#755}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Reland "Merge tabs of multi-instance when display is changed."
Reland https://crrev.com/c/2272131
1. Enable only on P+
2. Use new Critical Helper API
(cherry picked from commit c9e173805a8c49615c453d26f5637b1b2a5b2dbb)
Bug: 1088202
Change-Id: I9d07ceee98d138a6468c6280266a14aea8e20b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290961
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787925}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304991
Cr-Commit-Position: refs/branch-heads/4183@{#754}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Allow RecyclerView to detect overscroll when list does not scroll.
This change pushes existing overscroll detection mode further up the
call chain to allow OmniboxSuggestionsRecyclerView to call up keyboard
on overscroll if the suggestions list does not contain enough elements
to be scrollable in full-screen mode.
(cherry picked from commit 3dc23a35f16dadb0e5f5f707f0e632fb964ee484)
Bug: 1106150
Change-Id: Icabd061b7a118516bdd9af6364f00761ab32edd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301180
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Ender <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789121}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307434
Reviewed-by: Ender <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#753}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix a bug in TabGridDialog animation setup
http://crrev.com/c/2119188 exposes two bugs in the setup introduced in
http://crrev.com/c/2143671, which jointly lead to a corner case where
the dialog animation is not setup correctly. This CL fixes this issue
by 1) restoring dialog view size and position after animation 2)
restoring the animation view alpha in the correct position.
This CL also revives a disabled test that could have caught this issue
by removing the flaky parts and add some bug-specific checkings.
(cherry picked from commit 96f0ee806b0da8a0ca1ee5d863c27381ff37030b)
Bug: 1075677, 1099563
Change-Id: Ie722d77f806dd556f69cb2df6b758500739cdc65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278923
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788801}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307530
Reviewed-by: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#752}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix crash when default app manage setting activity is not available
Add a new criteria to detect the situation in which a browser other
than chrome channel is default and default app setting activity is not
available
[email protected], [email protected]
(cherry picked from commit 6073e2a4cf8576d8dc35a612a568e88ba09b7937)
Bug: 1105370
Change-Id: I625aae775933fdff8c912c07a2253db35a34bb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296890
Commit-Queue: Lijin Shen <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788694}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306917
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#751}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Merge to 85] [omnibox] Unbold all ZeroSuggest search results
We currently classify ZeroSuggest search results against the current
omnibox text. This was a holdover from the Query in Omnibox experiment,
when we only did ZeroSuggest against the displayed query on SERP.
Now that Query in Omnibox is completely dead, and we are doing
ZeroSuggest against arbitrary page URLs, we want to change the behavior
to never classify ZeroSuggest search results, and leave them all
unbolded.
This patch is minimal and designed to be mergeable back to M85.
(cherry picked from commit 167a3682d41845c08134ceb07671d06b2ef56a1f)
Bug: 1095837, 1106096
Change-Id: Icceec38d9d8697b69999115af4db9ae3dabd32d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300990
Commit-Queue: Tommy Li <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789162}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307481
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#750}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595239274-b8632929c8faad0eb3edb7736dd468607e237a21.profdata to chrome-win32-4183-1595248216-b822333241e2a35447b4e723827e0d785be9221a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8cf756fc3faebb916bcc4b9019780c74c836b1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307474
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#749}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Orderfiles from 85-4181.3-1594639678-benchmark-85.0.4183.32-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8960873c5f8774da625f5fc94f6d6367213090ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307631
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#748}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[85][media] Provide async notification for GVAF codec support APIs.
The existing query APIs IsDecoderConfigSupported() and
GetVideoEncodeAcceleratorSupportedProfiles() are fallible because the
list of supported profiles may not have been retrieved from the GPU
process yet.
This CL adds APIs to check if the supported profiles have been fetched
and to register to be notified when they have been.
Bug: 1047994, 1105258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249103
Commit-Queue: Dan Sanders <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/master@{#788385}
(cherry picked from commit 6382962d572c90466aa4f0be106e2f39e99a898b)
Change-Id: I4173560f9e9caebc5aaa871543c97e8274ea482a
[email protected]
Change-Id: I4173560f9e9caebc5aaa871543c97e8274ea482a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307089
Commit-Queue: Chrome Cunningham <[email protected]>
Reviewed-by: Chrome Cunningham <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#747}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[LiteVideo] Clear user blocklist on browser history clear.
This change ensures that the user blocklist is emptied when the
browser history is cleared by the user.
(cherry picked from commit 1ced2b546ad88e668de686be5b700568b62cd3d1)
Bug: 1097798
Change-Id: Icdff342abc0aa226201333ac4f88338f1b026c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278610
Commit-Queue: Michael Crouse <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Auto-Submit: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786992}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303303
Reviewed-by: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#746}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix crash when map key is accessed without checking.
(cherry picked from commit e5bd0f736734e953266126987a7c280270c9cd65)
Bug: 1102937
Change-Id: Ib4ac8700bf147ec6aeff696c47f39592503f0447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303455
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789460}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306579
Cr-Commit-Position: refs/branch-heads/4183@{#745}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595223215-9a40497dfeaf482034fbd605595228af2d5a3a2f.profdata to chrome-win64-4183-1595239274-081e253b6d4ef4b6ccdf78feea5b29df9a99dce7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I80c03e1427e44bf12f50d3d549e12a32e09ef66e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307364
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#744}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595230300-ffd9b95e6d64a2eba2d4c6ec8d33386b0cab07aa.profdata to chrome-win32-4183-1595239274-b8632929c8faad0eb3edb7736dd468607e237a21.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4594a1e885f29c1e12a3d7d39b7b4c678314a6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307359
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#743}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Sync] Reupload bookmarks with empty GUID in specifics
Reupload will be performed for bookmarks on any remote update (initial
and incremental) for entities which don't have the GUID in bookmark
specifics.
This CL also applies reflection updates in case if remote entity has no
GUID in specifics and the reupload is enabled. It will make possible to
reupload bookmarks with populated GUID for single-device clients.
The whole new logic is behind the SyncReuploadBookmarkFullTitles feature
toggle.
Bug: 1104171
Change-Id: I6eaacf70b0fd19ba66caa6f6922883be60a8e342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297429
Commit-Queue: Rushan Suleymanov <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#789057}
(cherry picked from commit 7a63a3c776fc5bd19748a2ac4f66c1c70eb32eaa)
[email protected]
Change-Id: I111a8e26b67af52af77850eed9d92a68bd202edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307331
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#742}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595223215-3c24ffde2851199b6305acc466a2bec3bf7fee22.profdata to chrome-mac-4183-1595239274-266e970a63abc8980ae809999edb17fea659c754.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia4438a2ae4a14fb3f6ecd676dfebf71937adbe4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307360
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#741}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Always set the mojo ImageResource type.
Not setting an empty string explicitly is causing mojo validation
errors. More info in the bug.
(cherry picked from commit 2f69a0e46e4b945d1a2feb03498a0ba9af98cd55)
Bug: 1104853
Change-Id: Ia54bb4a73aa5d585382f4c13aab235a731451acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295140
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306256
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#740}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595217970-796ec3961b3286a4c2baa9e71dade6763a3d08f4.profdata to chrome-win32-4183-1595230300-ffd9b95e6d64a2eba2d4c6ec8d33386b0cab07aa.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia5c6261ac83f5a2061973bd6ed4a43fc149a1d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307135
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#739}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595201340-896869b59f5b9182d28de62aa1bf0b9f97a33fb3.profdata to chrome-win64-4183-1595223215-9a40497dfeaf482034fbd605595228af2d5a3a2f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If5442b3d7b31517e92b44569e9364035b7fb1b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307063
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#738}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
base/allocator: Make GigaCage return nullptr on allocation failures.
Currently, when CommitPages() fails in GigaCage, we crash "on the
spot". This is the right behavior, as there is not much we can do at
this level. However it short-circuits PartitionAlloc's regular OOM
handling, which confuses crash reports.
Let AddressPoolManager::Alloc() return nullptr, so that the higher
levels crash as usual.
(cherry picked from commit d7e1c30a33b96e008825cfb53a2cf2b59f21cb8b)
Bug: 1086388, 1101447
Change-Id: I91a25bad2ff595dca7722a12765c7b42155be600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279111
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Benoit L <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784814}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301535
Reviewed-by: Benoit L <[email protected]>
Commit-Queue: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#737}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595213028-948a7d7059651eb9c0fa7a844f629a4b1e797a4a.profdata to chrome-win32-4183-1595217970-796ec3961b3286a4c2baa9e71dade6763a3d08f4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If1363710865491c87a3cc95bd87271768d9b0d18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307051
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#736}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Updated extension dev console error message
Scheme wildcards are now allowed for exceptions defined for Plugins.
Updated the error message to reflect the change.
(cherry picked from commit 452a31466b3b4446ef8ac6a2413f5e8d8b917882)
Bug: 1073883, 1104815
Change-Id: I90827b7a9f5117afa0c232323fc7a608436aebc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292434
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Ravjit Singh Uppal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787704}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306030
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#735}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595201340-5113a859e3bd93217a887810c1f782f090df1294.profdata to chrome-mac-4183-1595223215-3c24ffde2851199b6305acc466a2bec3bf7fee22.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4eb37b7451cff1a8d49c3ee04f455d951c9bb838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307056
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#734}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595205421-823caaf3e5e9a93ef15f976100797dae27f11a9a.profdata to chrome-win32-4183-1595213028-948a7d7059651eb9c0fa7a844f629a4b1e797a4a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1d8ea3414dd792e59039e0ac0dcfe97fc2c129d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306970
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#733}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595201340-d3aa601904f1c6f3817a8b87482deca8222df477.profdata to chrome-win32-4183-1595205421-823caaf3e5e9a93ef15f976100797dae27f11a9a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8b1c85a097ec16f2e9cd013ecf519860aed5f8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306911
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#732}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595194807-26bf89db0e7bd8fd8b6c18572d478b57d2b46ff5.profdata to chrome-win32-4183-1595201340-d3aa601904f1c6f3817a8b87482deca8222df477.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I88f8edbae2c13eed62ffd7fcc09fa97fa9316f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306827
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#731}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595181001-9aacfb6f58d858d58a01dc99b703e1d1c9b59779.profdata to chrome-win64-4183-1595201340-896869b59f5b9182d28de62aa1bf0b9f97a33fb3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I43099d49e1c3464515d94b7748237d383fdb890f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306826
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#730}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595181001-5c91119e29e22ffa74a1184984dce7b7647a6f12.profdata to chrome-mac-4183-1595201340-5113a859e3bd93217a887810c1f782f090df1294.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I6a76de03658c383c50121b0d93eeb532cc647af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306822
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#729}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595187995-5b47dba402fe1367262af7d033453887dd3bbf26.profdata to chrome-win32-4183-1595194807-26bf89db0e7bd8fd8b6c18572d478b57d2b46ff5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Id8957d541d37a19f95fabe1b5798c437ad16fe60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306819
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#728}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.34
[email protected]
Change-Id: I30c2d2f42c99a787b737372fe344d9971ce71656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306378
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#727}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595181001-a20166900a54a6dfcbd4fd60b60ff2d3ac2273a0.profdata to chrome-win32-4183-1595187995-5b47dba402fe1367262af7d033453887dd3bbf26.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8626c2b80edfd6386027821c7887577e4e2d10d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306817
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#726}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Download later: Fix a bug that scheduled download can't be deleted.
This CL fixed an issue that scheduled download can't be deleted.
[email protected]
(cherry picked from commit 996b0a4136d5973a9d97c83d2b8b174462e299ff)
Bug: 1106368
Change-Id: If5c83452917dc6a77cffe5cae79f0422a4f4f892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303853
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789505}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306753
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#725}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Download later: Started download should not be marked as scheduled.
If the user scheduled a download that starts right away, or the
network condition met right away. Download schedule struct should be
cleared, or the download will be shown in the "scheduled for later"
section, but it's actually completed.
[email protected]
(cherry picked from commit 06bec5cec4f5718d3be9c975b63c83155382cbae)
Bug: 1106208,1078454
Change-Id: I70526221839d16c96a31b1409c28e5227cc9daa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301379
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789549}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306754
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#724}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595177721-713f2eca00f8f959f6e546500699ddd62eb78670.profdata to chrome-win32-4183-1595181001-a20166900a54a6dfcbd4fd60b60ff2d3ac2273a0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I53228c45b6f7e2a4dcf3aaf73a0e7b6a4a143753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306722
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#723}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.32-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9d9cb584f0d5c0c348cd141c9fda365113e8ca4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306809
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#722}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.32-r1 to 85-4181.3-1594634650-benchmark-85.0.4183.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1a9e531eaed9edf8c189359ba981cb378aec4c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306811
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#721}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595154846-43c3bbe0c9602ea023b97ed66d663e3d90c942c9.profdata to chrome-win64-4183-1595181001-9aacfb6f58d858d58a01dc99b703e1d1c9b59779.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iea5747b218d0042d8fb550e5181ff347686b5e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306720
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#720}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.32-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ica88ef9f04dd05de2bae738461431e77cf06fc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306723
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#719}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595168223-dedd2bd8d53e04313cf4095fef6d6f1a50e5aa5f.profdata to chrome-win32-4183-1595177721-713f2eca00f8f959f6e546500699ddd62eb78670.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icf9be1246c340a09fc17686f15b759ab4cf5e1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306717
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#718}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595154846-1168406596f00b655b5431ce75a697cb0d3f399e.profdata to chrome-mac-4183-1595181001-5c91119e29e22ffa74a1184984dce7b7647a6f12.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I876f8c00596f5edf1580183029287b408d5ca3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306719
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#717}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595165307-f563caa30ae98cec45af66b9e9f1a2d7291c85ae.profdata to chrome-win32-4183-1595168223-dedd2bd8d53e04313cf4095fef6d6f1a50e5aa5f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I9c307db2e10062abc2b4cf437ea59c40952e04c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306714
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#716}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Orderfiles from 85-4181.3-1594639678-benchmark-85.0.4183.30-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.32-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8876be3af6d468ef5d950ca16a71ed8850b23b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306715
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#715}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595161319-dabdd1abcba1f7b9d4e05a85332b8c200c39aa4f.profdata to chrome-win32-4183-1595165307-f563caa30ae98cec45af66b9e9f1a2d7291c85ae.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7874f4e6ba63f07d54ad2e3c0cb0d6b3eb4d0162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306713
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#714}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595151044-6faf21235803c5ad29c6e5585f7083780edd60a6.profdata to chrome-win32-4183-1595161319-dabdd1abcba1f7b9d4e05a85332b8c200c39aa4f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iece9a0f4b59e4668b73283fa87b61966add9d9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306711
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#713}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595115617-6600f3f43681d6b16dc7d8e6383f441bd4d40636.profdata to chrome-win64-4183-1595154846-43c3bbe0c9602ea023b97ed66d663e3d90c942c9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I83af0f4bfee9fc664402958b7e6d259aa80e769f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306709
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#712}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595138259-d329f9171d419dd21d77013e0d1bcb98fa30ceda.profdata to chrome-mac-4183-1595154846-1168406596f00b655b5431ce75a697cb0d3f399e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I535ba3803dd5e67d3dff2c10ae970133951b70a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306408
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#711}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595143492-d38abdc46cad953f6374e41ce842c3b5eff8eef3.profdata to chrome-win32-4183-1595151044-6faf21235803c5ad29c6e5585f7083780edd60a6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I91b96f8141343930d4b3da546ef01caa039e5eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306407
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#710}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge 4183: [FragmentItem] Add IsLayoutObjectDestroyedOrMoved check
This patch adds |IsLayoutObjectDestroyedOrMoved| check to
|NGBoxFragmentPainter::HitTestFloatingChildItems|.
|HitTestFloatingChildren| has one, but missed to add to this
FragmentItem variation.
This patch is speculative.
(cherry picked from commit 2559d4ee8edd1608dabe5e42f48b7fce38b96141)
Bug: 1104874
Change-Id: Ic31585f2c7405d0ae9e3b3aece1046334a5eb959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296771
Commit-Queue: Koji Ishii <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788132}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303343
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#709}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595138259-8daebbd0d6603522cb0956d96df9458373de8f9b.profdata to chrome-win32-4183-1595143492-d38abdc46cad953f6374e41ce842c3b5eff8eef3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I055b1a0e51ae4cb2d8a45d14ea0e5791fa93824a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306405
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#708}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
M85: Quota: Fix client accounting in QuotaManager helpers.
This CL cherry-picks https://crrev.com/c/2299466.
The automated cherry-pick didn't work, because
https://crrev.com/c/2281727 renamed the
QuotaManagerTest::GetHostUsageBreakdown() helper to
GetHostUsageWithBreakdown().
This CL renames the GetHostUsageWithBreakdown() callsites in the patch
to GetHostUsageBreakdown(). This was preferred to renaming the helper in
M85, because it limits the conflict resolution to the patch being
merged.
Original CL description below.
Quota: Fix client accounting in QuotaManager helpers
https://crrev.com/c/2241955 refactored how QuotaManager reasons about
QuotaClients. The new setup maintains separate lists of clients for each
StorageType (kTemporary, kPersistent, kSyncable). Unfortunately, the CL
did not correctly migrate all the QuotaManager helpers to iterate over
the per-StorageType lists instead of the global list.
This CL migrates QuotaManager helpers, and adds testing coverage to
prevent future regressions.
(cherry picked from commit 64690aaa84e19ceecfdeb1a4865562dbaa477a72)
Bug: 1100260
Change-Id: Ie788fc08ffc24cb1bb9d2b83524c21a9d9e296d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299466
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788871}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305719
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#707}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595128758-e545b1a6fbd2543776c3c2cd7876750885c77785.profdata to chrome-win32-4183-1595138259-8daebbd0d6603522cb0956d96df9458373de8f9b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I44e5eb7dfaef0f67c81f6efc7835d682a0898617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306403
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#706}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595115617-bf664c3dc36f630cfead19a03ee2b1aaa7fa8eee.profdata to chrome-mac-4183-1595138259-d329f9171d419dd21d77013e0d1bcb98fa30ceda.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7967bdf452621e089799065ffea4048f5e7da6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306401
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#705}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595124365-791f8bd96f26e79b5da3342c2d5388abed841847.profdata to chrome-win32-4183-1595128758-e545b1a6fbd2543776c3c2cd7876750885c77785.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1529714ef3235427904d6a0c9d21e8a0e33295c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306396
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#704}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Remove Loading Predictor preconnect for Prerenders
This has the potential to leak user information during an isolated
prerender and isn't otherwise beneficial in the context of a prerender.
[email protected]
(cherry picked from commit 7516d388b761fab81156aa6b3752197bf3f549ab)
Bug: 1103392
Change-Id: Ic1806bcdf3476bc2c864f91028125d380b0b1be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300805
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789562}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306551
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#703}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595121985-54a4a1f05fa6816da3616a5eee71eda5e67c9b4c.profdata to chrome-win32-4183-1595124365-791f8bd96f26e79b5da3342c2d5388abed841847.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5ccdb8d666757378fe1c9b401a5204b965861396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306395
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#702}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595119298-b46a54cc867419acfad0afd88032c5ea1547cb12.profdata to chrome-win32-4183-1595121985-54a4a1f05fa6816da3616a5eee71eda5e67c9b4c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1902ba2c5ff3b68a90c094e9d52af22f8ab7fc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306392
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#701}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595115617-bd95f551170e7e225f375daf5cc6be1766dbf008.profdata to chrome-win32-4183-1595119298-b46a54cc867419acfad0afd88032c5ea1547cb12.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I53913cacfd821b656b1d739cfce6a322ebc556d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305851
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#700}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595106122-1cf860231dffb6dce21cea957b840bfb9f4263ef.profdata to chrome-win32-4183-1595115617-bd95f551170e7e225f375daf5cc6be1766dbf008.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I36b69f77829bb6c57054793d98e823aa0d8fc4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306411
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#699}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595091684-71d1a72cae3016ff57fde92023a0e8423d782a19.profdata to chrome-win64-4183-1595115617-6600f3f43681d6b16dc7d8e6383f441bd4d40636.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I554e619f062e1a4e1eed44a34c62460f9048bb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306410
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#698}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595091684-11f23afd2ea1c252a86f19a7451add28cbcf83a0.profdata to chrome-mac-4183-1595115617-bf664c3dc36f630cfead19a03ee2b1aaa7fa8eee.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iecd395cc573e24eaf163622ac3f00db9997f8bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306409
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#697}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595105892-304b84cc4de317c547312c381231a6fbae1e93b2.profdata to chrome-win32-4183-1595106122-1cf860231dffb6dce21cea957b840bfb9f4263ef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ib3f47c14d33399f0c8ccc0ce6484a3d551ee36ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305718
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#696}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.33
[email protected]
Change-Id: Ia7395e4feecbaa84796cdc9bab62f4635335008e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306370
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#695}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[webui][ntp] Ensure MV titles of 3P themes are dark
Previously, the titles honored the theme setting. However, the title is
shown in a white pill and, therefore, was invisible if the theme set a
light color. Thus, this CL always sets the title color to dark. This is
also what the local NTP does.
Before: https://screenshot.googleplex.com/3W85KAw7sbv
After: https://screenshot.googleplex.com/d2pAxBWjRx9
(cherry picked from commit 26aef83547c48a4ceaa8cb6da3690d2e943e20ba)
Bug: 1105941
Change-Id: I4ca38bd3e70cf0e669ea2f5d23f6821ef822bf43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300662
Commit-Queue: Tibor Goldschwendt <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788827}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304662
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#694}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595100959-9e411771c538217c6861cdbe2f8eff70d8c6b07a.profdata to chrome-win32-4183-1595105892-304b84cc4de317c547312c381231a6fbae1e93b2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2fc1176544fa74bc2c6e1e392786c5991432a9c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306213
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#693}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595091684-4133ba44a18e60a918de258e01f13a08317bb6dc.profdata to chrome-win32-4183-1595100959-9e411771c538217c6861cdbe2f8eff70d8c6b07a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ica4704419d02edcb55cd45ff4ba9138b1e5e9e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306247
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#692}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595090258-aa1151f0129e6721f7baf14942b3e54d56ea936c.profdata to chrome-win32-4183-1595091684-4133ba44a18e60a918de258e01f13a08317bb6dc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1a723ffae0350f17c6daf387e3d2f23debb5c529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306238
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#691}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.30-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.32-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8886d4e039c6da4c3ebe8bf78dba78d0adbcf97b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306244
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#690}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.30-r1 to 85-4181.3-1594634650-benchmark-85.0.4183.32-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6ab32418408c24b85271271e15f9001a59ce0812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306241
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#689}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.30-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.32-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibc409fed74d58da253c02c80048ea7b1d06da0c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306242
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#688}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595051906-f3bfcc8bccf402039f71cea5eb21b4d824086808.profdata to chrome-win64-4183-1595091684-71d1a72cae3016ff57fde92023a0e8423d782a19.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I94abb3541c2d54a013f00db2add8fb1b214c1bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306237
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#687}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595084336-0781329b2454ed3253b0491dbff2aee8d66aa2db.profdata to chrome-win32-4183-1595090258-aa1151f0129e6721f7baf14942b3e54d56ea936c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I059041c7b662998f6ae4c7f4b35d60a0624f99fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306233
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#686}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595072976-5dd17a2fab65e10a76a5d2cd71e220efe7137099.profdata to chrome-mac-4183-1595091684-11f23afd2ea1c252a86f19a7451add28cbcf83a0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Id33e6036af62a5fa90e42ce4e1239289911d51d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306234
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#685}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595076235-f3fbfaf2259a63d75369dfec73c5ade4bd7afb37.profdata to chrome-win32-4183-1595084336-0781329b2454ed3253b0491dbff2aee8d66aa2db.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5a612494ba9ec0d803c663f632dee878f4ac2c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306229
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#684}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Orderfiles from 85-4181.3-1594639678-benchmark-85.0.4183.28-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.30-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6950f774c8f46303de342963b7dd6b632bbc3f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306230
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#683}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595068306-0d4904df38d24957aa3f3e0f1f44f119c73b7e2d.profdata to chrome-win32-4183-1595076235-f3fbfaf2259a63d75369dfec73c5ade4bd7afb37.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7ea3dbc879c29150f65b0e8b3a503cac1845f109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305747
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#682}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595060383-39ca894d3c8988353a85468d4bce68c0501ad22c.profdata to chrome-win32-4183-1595068306-0d4904df38d24957aa3f3e0f1f44f119c73b7e2d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ie055c828c3def8f0e73c6cc9b45e634921cadde3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306058
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#681}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595051906-85cb7237d816d37b03c2778f4a350c8133e5198b.profdata to chrome-mac-4183-1595072976-5dd17a2fab65e10a76a5d2cd71e220efe7137099.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7ed1e8d5b981c50d5fb4a3e84a0acda7e6ac6a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306056
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#680}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
CCA: Add sound effect to pause/resume UI
To add sound effect to pause/resume UI, new 'recording-ui-paused' state
is introduced to control the UI transition.
Bug: 1072706
Test: Run "tast run 'camera.CCAUIRecordVideo'", check if sound effect is
applied.
(cherry picked from commit 45aa77fa477d7840afbd0877a67f81ad5fbdbe52)
Change-Id: I7e6305e302cea55a14a1174b484a5dc24b06fabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296548
Reviewed-by: Wei Lee <[email protected]>
Commit-Queue: Kuo Jen Wei <[email protected]>
Auto-Submit: Kuo Jen Wei <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789405}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306129
Reviewed-by: Kuo Jen Wei <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#679}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595045069-14a9f5bd2133452f375326a81eaa04bf3852f6bc.profdata to chrome-win32-4183-1595060383-39ca894d3c8988353a85468d4bce68c0501ad22c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icb44eceadf1a2f6523ecaa976a01b31853ba7fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306054
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#678}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
CCA: Add disconnect event notifying tast Close of CCA window
This CL sync window close state with tast by adding new disconnect event
triggered when window finish close procedure for notifying tast it can
safely launch another window.
Bug: 1098652
Test: tast run "camera.CCA*"
(cherry picked from commit c709df282ede1235478069cd0dbae4e724b36abe)
Change-Id: Idc4674aad20b8c0c9918266e28512d1642101d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291513
Auto-Submit: Kuo Jen Wei <[email protected]>
Reviewed-by: Shik Chen <[email protected]>
Commit-Queue: Kuo Jen Wei <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787117}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306109
Reviewed-by: Kuo Jen Wei <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#677}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595037987-6989618b74168bfc371f0853a2b40991a23b7eb6.profdata to chrome-win32-4183-1595045069-14a9f5bd2133452f375326a81eaa04bf3852f6bc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I71469ac119a932042bee587c59d2c9f559417983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305716
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#676}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Updating XTBs based on .GRDs from branch 4183
[email protected]
Change-Id: I555d43c37639b20b38afb0dd95f73b81f0be568d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306010
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#675}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595029421-48cda66ea1bcb9288a3dd3885c34d6879597b6d1.profdata to chrome-win64-4183-1595051906-f3bfcc8bccf402039f71cea5eb21b4d824086808.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4a864eb868655b3edc0e8cd2e5d0753a1c877b63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305713
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#674}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[M85 Merge] Oobe: Read Rollback Restore from Config
In order to restore the enrollment state after rollback, the oobe
flow needs to execute the enrollment screen.
Currently, this is not happening because the fact that a rollback
took place is not read from the oobe configuration.
Reading the correct flag is added in two places: To recover the
enrollment and to restart chrome afterwards in order to get the device
policies.
(cherry picked from commit 91ef03171386058e4c821ab4ff544c168898e55f)
Bug: 1093928
Change-Id: Ib463dae4b1ac29e7f2ab870ae3b839f2018e11e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273159
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Commit-Queue: Miriam Polzer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783962}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302632
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#673}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595036765-47e2918a8c0c20e457112e17afbcf235a548261f.profdata to chrome-win32-4183-1595037987-6989618b74168bfc371f0853a2b40991a23b7eb6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I79dc326465b188a34bec7553d3aa929ca8ff631d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305731
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#672}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595029421-b82cfaa661367363ccbe73d7e93e356b7cacfb26.profdata to chrome-mac-4183-1595051906-85cb7237d816d37b03c2778f4a350c8133e5198b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I41f786a1b4119e2883c37ab3aae667f6b11489e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305739
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#671}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595020458-ffbff2a5af6d7de4e266da1ff7f2417ebc70a2f0.profdata to chrome-win32-4183-1595036765-47e2918a8c0c20e457112e17afbcf235a548261f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I29d1d1c14a3f245385f46027c5eeda381514a72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305792
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#670}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Orderfiles from 85-4181.3-1594639678-benchmark-85.0.4183.26-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.28-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib1c87215c8e3aaba7e3e21ad42a333ff8bedc3ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305795
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#669}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix narrator focus not triggering VK show.
This change fixes the issue on touch devices where the narrator sets
focus into an editable element and expect the VK to come up on double
tap. Here the touch/gesture events are handled by the narrator and thus
the events are not delivered to Chromium. This results in a pointer
type as "unknown" in |RenderWidgetHostViewAura| so it fails the check
where we decide to call the system API to display the VK.
Here if we are getting a text input state update which is of type
something other than none, there is a focused accessibility node, and
|show_ime_if_needed| flag is set, then we can call the system API to
show the VK.
Bug: 1100390
(cherry picked from commit aff9e4c837bf1785a7bcbb4df6147b175d80b39f)
Change-Id: I4c13474b4b4655f506429a724b3648efb81fec74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274865
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Alice Boxhall <[email protected]>
Commit-Queue: Anupam Snigdha <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786064}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305196
Reviewed-by: Anupam Snigdha <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#668}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1595007041-45b7becbbbb6c5b43700014ce4c444eda7704337.profdata to chrome-win64-4183-1595029421-48cda66ea1bcb9288a3dd3885c34d6879597b6d1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iadb726f293dba24c0342d17604e624078da17d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305475
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#667}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1595007041-9f24dcf181323aa8baaaa2e9b37eb6e92ccb0399.profdata to chrome-win32-4183-1595020458-ffbff2a5af6d7de4e266da1ff7f2417ebc70a2f0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ic94e40d18f836c31df29f620ebfe5ad56d333dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305489
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#666}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Download later: Add prompt status metrics.
This CL fixed an issue in download location prompt status metrics, also
adds a metrics for download later prompt status.
[email protected]
(cherry picked from commit c43f12aaa185d6207bb3a1039669553ef910c318)
Bug: 1106094,1078454
Change-Id: I17af189721e840a5e29ee7fc89e02506b2b9b689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300806
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Hesen Zhang <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789277}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305372
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#665}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1595007041-d675168e608df7fd27e79e3dc8a8281f13ff34bf.profdata to chrome-mac-4183-1595029421-b82cfaa661367363ccbe73d7e93e356b7cacfb26.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia9ab00c68c0d49ef3167735caf808f29a7b8be1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305241
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#664}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594985056-abbb3599bba20a27ff3881822b9f4be5125bdc82.profdata to chrome-win32-4183-1595007041-9f24dcf181323aa8baaaa2e9b37eb6e92ccb0399.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icb669f995265ea81a74d84b7071ccd27f6f12a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304976
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#663}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.32
[email protected]
Change-Id: Id3d34aff5787a868bc4b9618a65e3547dc69170e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305193
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#662}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Decrease size of Clear All History icon
Previously was set at the default size of 24px, this change
reduces its size to 20px.
(cherry picked from commit b47c163e170662a517b29b6b5695957d624f214d)
Bug: 1106551
Change-Id: I34f2faff0799b6125c05a683d9619b2c59579534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303231
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789312}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304722
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#661}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594985056-8ab9f8c131293bf11b78897f381249b7218f214b.profdata to chrome-win64-4183-1595007041-45b7becbbbb6c5b43700014ce4c444eda7704337.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I15ff59420217b6e32fd1d5a7ce0bcefb39206e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305061
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#660}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Merge M85][SharingHub] Make QrCode share tab a scroll view
Wrap the contents of the share tab (QrCode + Download button)
in a scroll view so everything can be seen on smaller devices.
(cherry picked from commit e3157a1f2971defd7dad701e8df11d6d86eb55c6)
Bug: 1105809
Change-Id: Iba3b85c5a6ef31beb24bb080a7b12942298a79cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300232
Reviewed-by: Tanya Gupta <[email protected]>
Commit-Queue: Kyle Milka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788788}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304999
Reviewed-by: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#659}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Remove anonymous block wrapper when inline continuation is removed.
Keeping empty anonymous blocks around is bad. The only known actual
problem is in multicol (but it may cause other issues too). Based on the
layout object tree, multicol creates anonymous LayoutMultiColumnSet and
LayoutMultiColumnSpannerPlaceholder objects, to keep track of what is
regular column content and what are spanners. Leaving a
LayoutMultiColumnSet around just for the sake of an empty anonymous
block (which may get cleaned up without notifying the multicol code)
will confuse multicol layout.
(cherry picked from commit 48919b7a63545c092d11d2424cb4058ffa0ef7c3)
Bug: 1102137
Change-Id: Ibfb46d0dc173ecfdb2e7903efee5a49de3da3ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283355
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304962
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#658}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge M85: "Enable AV1 hardware decoding by default. Prep workaround to disable."
We may have some cards that are capable and some that are not yet
ready to enable AV1 decoding, so this CL enables it by default but
leaves the option for adding a gpu workaround to disable it.
TBR=zmo
(cherry picked from commit cbdaab9941539bfb037e5fd198f8922661e623e1)
Bug: 1073252, 1092711
Change-Id: Id4327a382ec757dc70e07fbbf8207688e3a257d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298481
Commit-Queue: Dale Curtis <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Auto-Submit: Dale Curtis <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788437}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304953
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#657}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.28-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.30-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iafa3bda26dcd723553c689e5ccc544a7b0e3b516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304550
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#656}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.28-r1 to 85-4181.3-1594634650-benchmark-85.0.4183.30-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I56f2579eeb82ca7e2ad745951c392c987e3e0495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305060
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#655}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.28-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.30-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Icb694ff13a9b7a1c6aa2665e55f4a7925c9de9f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305095
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#654}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594985056-bcbdf0116606b417d96aea573024ee75261bd143.profdata to chrome-mac-4183-1595007041-d675168e608df7fd27e79e3dc8a8281f13ff34bf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I3e1636d236df2018c7fe9e845c618389d2df903f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304667
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#653}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Setting innerHTML in a template element in an inactive document should not crash.
(cherry picked from commit 80ff439168a28afadea7a17b26def389f4ad2432)
Bug: 1100176
Test: html/semantics/scripting-1/the-template-element/template-element/template-set-inner-html-in-inactive-document-crash.html
Change-Id: I1d2ad61aead0d8f14952ae9b8e49d855d773e86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273798
Auto-Submit: Nate Chapin <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783693}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303034
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#652}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge M85:Add Cros Recovery Tool to feedbackPrivate allowlist
BUG:1106125
TEST:Validate the Recovery App can send feedback using feedbackPrivate.
(cherry picked from commit d507e5d4a32d50556f2b5417e06732011ee58188)
Change-Id: I856737cdaacc0d65f7a42f9766ad7b4d3debf28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287951
Commit-Queue: Andrew Lassalle <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786559}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303993
Cr-Commit-Position: refs/branch-heads/4183@{#651}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
vulkan: fix a crash in SkiaOutputDeviceVulkan::OnPostSubBufferFinished
When vkAcquireNextImageKHR() may fail, and then VulkanSwapChian::acquired_image_
can be not initialized. In that case, access it will crash. Fix the problem by
checking the SwapBuffers() result before accessing it.
(cherry picked from commit 394eb5d154d3e40210672c7995a3928577e12faf)
Bug: 1106049
Change-Id: Idd400bef93e3bb46267f65a23454784e4f7e6680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300766
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789052}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303304
Reviewed-by: Peng Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#650}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
M85: Allow cloud print service to initialize broker.
(cherry picked from commit 9063bcd99392c66841e9183f0e9023e3342ed2bb)
Bug: 1102447
Change-Id: I9f19ff9903a88fa0ff01fa1c7f42e2772e49baa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298039
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Alex Gough <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788365}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302232
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#649}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[ios] Fix crash in download_manager_coordinator
Crash happens in downloadManagerTabHelper:decidePolicyForDownload:completionHandler:
after dereferencing self.downloadTask null pointer when attempting to
get WebState from DownloadTask. The method suppose to present
[Replace download?] confirmation dialog on WebState that requested the
download. self.dowloadTask->GetWebState is WebState for active tab, and
it might be a different from WebState that requested the dialog. This is
because there is one DownloadManagerCoordinator per BVC, not one per Tab
and with this architecture self.downloadTask always holds task for active
Tab.
This specific crash happens when background WebState requests the dialog
and foreground WebState does not have a download task.
This CL changes WebState lookup code to get WebState from |download|
arguemnt passed to decidePolicyForDownload:
(cherry picked from commit ab7cc5c94d494ee8c0c7c4ff2723addc6d8d18d6)
Bug: 1105791
TBR: [email protected]
Change-Id: I75d2408196806c0b5b8c89b1d46805e09f9c6bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300834
Auto-Submit: Eugene But <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304949
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#648}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[FlexNG] Fix %-relpos for a grandchild of a flexbox.
When we resolve %-based offsets for a relative position child, if its
parent is a flex-item we'll read the constraint-space used to generate
this fragment, and resolve the %-based offset using that block-size. I.e.
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_box.cc;l=4521;drc=3f50460dcc4c426eb876cd0a1d2838eb35472e18?originalUrl=https:%2F%2Fcs.chromium.org%2F
However flex can have two passes, one without a fixed block-size, and one
with. If we can determine ahead of time that these would result in the
same fragment we'll hit the cache, but the constraint space would
be the one without the fixed block-size.
In other words, if a flex-item remained the same size between the
measure, and layout passes, a relative position grandchild would resolve
its %-based offsets incorrectly.
This patch introduces *some* logic from another patch current WIP:
https://chromium-review.googlesource.com/c/chromium/src/+/2214608
which got reverted for unrelated reasons.
Effectively if we have a %-based grandchild like this, we'll miss the
cache, meaning that when we later read the constraint space fixed
block-size, it'll resolve against the correct size.
(cherry picked from commit 882a110267ca9b8c420767d5614ccb76e485b529)
Bug: 1106074
Change-Id: I5003e4c0903bda408c45f8fb608ad4106c8f22b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302231
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789058}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304659
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#647}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.31
[email protected]
Change-Id: Ic5dbbd54e6b86cf26bfb6a1f4ae6b00756aaf8ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304165
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#646}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Re-added menu accessibility logic.
This CL[1] removed the logic that allowed screen readers to focus into
menus. This[2] other CL re-added functionality for generic menu items.
However, buttons within menu items (like those in the Zoom MenuItemView)
weren't fixed.
This CL fixes hot button focus with screen readers. This only fixes the
issue with keyboard navigation, and not with mouse navigation. If you
use your mouse to navigate to a button, it will still select the entire
container.
Bug: 1105917
Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91
[1] c22c3a2aea6fabb50700d844fe6faec31d4ea305
[2] 7750c6d5dbb427726448ddef79ffe2c0444c8852
(cherry picked from commit 5bf8d88343383e85a83020e521c5f96d6f65c7a0)
Change-Id: I3ab23364f2e63f8429e4bc8eba2ace4467a0dd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295787
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789295}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304657
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#645}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Merge M85][QRCode] Prompt for storage permission
If the user hasn't granted storage permission prompt them for it
before downloading. If the user has asked to "don't ask again",
replace the Download button with a link to open settings.
(cherry picked from commit d5f1d692fa993ad93649d3be3daefa4d198ebcdb)
Bug: 1099426
Change-Id: Ib0e998b9c85ff6b15e764d90d923e062b4068406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276641
Reviewed-by: Travis Skare <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Kyle Milka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786845}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302732
Reviewed-by: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#644}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Reland "[LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back."
This is a reland of 6ea86d08f0bb549cbd9e96b27c890e0104b9ee85
The issue was the network condition checks which are now override by
a switch for these tests (see cl/2284978).
Original change's description:
> [LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back.
>
> This change prevents LiteVideos from being attempted when the
> navigation is a reload or forward-back page transition. It also
> adds an entry for host of the navigation to the user blocklist to
> allow users to soft opt-out of the optimization if they reload
> frequently on a host.
>
> A future change will clear the blocklist when the browser history
> is wiped.
>
> Bug: 1096796
> Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681
> Commit-Queue: Michael Crouse <[email protected]>
> Commit-Queue: Tarun Bansal <[email protected]>
> Auto-Submit: Michael Crouse <[email protected]>
> Reviewed-by: Tarun Bansal <[email protected]>
> Reviewed-by: Sophie Chang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#786127}
[email protected]
(cherry picked from commit 6f9ca96c4a2f36ec89a58949ceaeb94191c05cf2)
Bug: 1096796
Change-Id: I5164e510bfb06fc97e45ab9c82c482dc25529e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287380
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786432}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304175
Cr-Commit-Position: refs/branch-heads/4183@{#643}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix ContextMenuTests for release.
They were passing in debug because of fieldtrial config.
It's not read in release as per: https://source.chromium.org/chromium/chromium/src/+/master:testing/variations/README.md?originalUrl=https:%2F%2Fcs.chromium.org%2F
Add the appropriate flag enables.
(cherry picked from commit 581e63d71012d232ac90c6c2778bcd5774d1a966)
Change-Id: Ib3c42a739e1d43c2637defe1fbd955b0336f5746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290691
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787037}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303673
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#642}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Sheriff] Disable flaky ContextualSearchManagerTest#testTapWithLanguageDLD
[email protected]
(cherry picked from commit 8060175684a5dea78fa61b70c9b2a8b50daad246)
Bug: 1105488
Change-Id: I342bd468a30caf5ff0da6779b969accc8e16bb15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300829
Reviewed-by: Kristi Park <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Kristi Park <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788809}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304656
Cr-Commit-Position: refs/branch-heads/4183@{#641}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Delay expiration of force-color-profile to M89
TBR=mcasas
(cherry picked from commit d0a33f75ff3188b9cd06f2e7702cad721f0e3722)
Bug: 1105566
Change-Id: Ie07c3f3c2197faf77aefa5fd35090020fda204fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300085
Reviewed-by: ccameron <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788740}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303297
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#640}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594974431-f286a05f29ee3cb798d25123bd643d1af11fc24d.profdata to chrome-win32-4183-1594985056-abbb3599bba20a27ff3881822b9f4be5125bdc82.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If79d668305b6fbdd7c2577dfa86450e9078ce475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304671
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#639}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594920166-56bad2c64ea4e932b72e8ecbc96e50aa3d7c0feb.profdata to chrome-win64-4183-1594985056-8ab9f8c131293bf11b78897f381249b7218f214b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I760f68aa81cec4faf5fa339bfe43cb0acdf0306b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304673
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#638}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594963798-f7440cfe351f93e8370ff4a140ec27d7b2eae9cb.profdata to chrome-mac-4183-1594985056-bcbdf0116606b417d96aea573024ee75261bd143.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I9ea0172fd854646ee522a02c11e0677a580aeccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304407
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#637}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Revert "ios: Remove NSPhotoLibraryUsageDescription."
This reverts commit cef120344b2aeb17e78e6dd47b3ff69285079b97.
Reason for revert: Something in ChromeInternal.framework still requires the photos permission.
Original change's description:
> ios: Remove NSPhotoLibraryUsageDescription.
>
> This was necessary before iOS11 when using the UIImagePickerController.
> As of iOS 11, it is no longer necessary to request this permission.
>
> (cherry picked from commit 9a0dcbe48502ec530432141a009c4ff35a274acf)
>
> Bug: 1101058
> Change-Id: I70a1317c3666345db2da840bf4f6a394b2ded9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277974
> Reviewed-by: Nohemi Fernandez <[email protected]>
> Reviewed-by: Rohit Rao <[email protected]>
> Commit-Queue: Justin Cohen <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#785107}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292921
> Commit-Queue: Rohit Rao <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4183@{#399}
> Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1106571
Change-Id: I099e019265de688e2336bf9454a3d3d051943815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304299
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#636}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594963798-0ec4bc1de56430bcd281f62f62282bdf7fc3b3ef.profdata to chrome-win32-4183-1594974431-f286a05f29ee3cb798d25123bd643d1af11fc24d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I308484da5fc0bca074b91b6a7d79906118b74861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304399
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#635}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Parallelize robot auth codes fetch
On data restore after rollback, the device steps through oobe while
being enrolled. It still needs to re-create the robot account but
policy fetches are happening already and those should not cancel a
robot auth code fetch.
Allow for robot auth codes fetching to happen parallel to policy
fetches instead of a policy fetching silently cancelling a running
robot auth code fetch.
(cherry picked from commit 664c2f82b9db0f98c26e4e9a2ab3b57886206947)
Bug: 1102304
Change-Id: I70f48671cef4a86742468b8f623769e35ea98d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287476
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Miriam Polzer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788134}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302692
Commit-Queue: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#634}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594955563-18f360e7e48d44fc1b6209e8e983bafad10b5953.profdata to chrome-win32-4183-1594963798-0ec4bc1de56430bcd281f62f62282bdf7fc3b3ef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I657bfde5fcb5286fcc6c5b0f4b866562e2240d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304366
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#633}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge "Menulist SELECT: Update clip rectangle on padding changes" to M85 branch
Menulist SLEECT's clip rectangle is its content-box though usual
overflow clip rectangle is a padding-box. We should call
SetNeedsPaintPropertyUpdate() when control's padding is changed.
Before crrev.com/738834, we called SetNeedsPaintPropertyUpdate()
whenever SELECT's style was changed [1].
[1] See LayoutMenuList::UpdateInnerStyle() before crrev.com/738834
(cherry picked from commit d0b8aece460e21d9b5f94d4d02222962767c4c71)
Bug: 1103773
Change-Id: Id227a9a00c2695b066607f56ab97c4017532ac61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296546
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788078}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303338
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#632}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge "SELECT: The last selected OPTION should be selected when multiple selected OPTIONs are added by jQuery append()." to M85 branch
HTMLOptionElement::SetWasOptionInsertedCalled() had a silly bug.
(cherry picked from commit 094ec019ef7e2b1b0dd7c60b589256d6f9d3b423)
Bug: 1105672
Change-Id: Ic70572f297969d44bbe8f3d55fe05af796397f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298882
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302876
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#631}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Cherry-pick of crrev/c/2299624
[Autofill Assistant] Add missing icons.
We got a list of icons from UX per vertical, those are now added to
the client for easy use through local resources.
(cherry picked from commit 71a1bf0a4b29cde1752fee955eddccf9afa1f238)
Bug: 1106238
Bug: b/161337790
Change-Id: I118b4d2c2c9cb229165cfeccb058718f8580eece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299624
Commit-Queue: Sandro Maggi <[email protected]>
Reviewed-by: Marian Fechete <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788668}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302993
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#630}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594939775-403ad6f38506416c1d44e0fa8c03f407f7c8c647.profdata to chrome-mac-4183-1594963798-f7440cfe351f93e8370ff4a140ec27d7b2eae9cb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icc63584447738afea35b9e3a75798e044b3eb607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304354
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#629}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594946294-1bed9f73d7cd8f715d2d428642f0750959e15c47.profdata to chrome-win32-4183-1594955563-18f360e7e48d44fc1b6209e8e983bafad10b5953.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iee6a1259db3818950c16652031619e7a21af39af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304196
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#628}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594939775-97ffb9aab454f8b54f637bf197b57f2708fbffc6.profdata to chrome-win32-4183-1594946294-1bed9f73d7cd8f715d2d428642f0750959e15c47.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2b60e5ab79675199cd346de62e163674c05d827f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304142
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#627}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Change how 'New' badge is rendered to match UX redlines.
Code now tries to align the badge font with the center of the primary
menu item text (which actually aligns the "cap-height boxes" rather than
the whole font because of how fonts are rendered.
Values have been adjusted to meet redlines; see:
https://docs.google.com/presentation/d/1iERU69_-_PpQba5MAvSdxCX_wZrqMpCZOjHCSbFyZWY/edit#slide=id.g8abf29f0df_2_60
but also to look best on both Windows 10 and Linux with standard font-rendering
options. We may have to make some additional small tweaks for Mac.
This patch also consolidates code and moves more general computations
into text_utils at the request of some of the gfx/fonts owners.
(cherry picked from commit 9a2a5f619054ecb580091c545415409a39810a9a)
Bug: 1106081
Change-Id: I50fafa7291aad3131e16428f537bc0ed0266dae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285511
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Etienne Bergeron <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788738}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304249
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#626}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Track desktop touch mode metrics
TouchModeStatsTracker time actively spent in touch mode, where active
is defined by DesktopSessionDurationTracker.
The histogram it records is closely related to Session.TotalDuration
in that there is a 1:1 correspondence between samples, and every
sample is less than or equal to the corresponding
Session.TotalDuration sample.
(cherry picked from commit 069aa3d135864850af1d60becd0f0be4ef6c5080)
Bug: 1100706
Change-Id: I55c826e86a24f52807eb32b4f1bfae3cfc5c507a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275077
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Collin Baker <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787957}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303607
Reviewed-by: Collin Baker <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#625}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594932924-dd1a936e60b774bc25f034cb9bd294878700ade3.profdata to chrome-win32-4183-1594939775-97ffb9aab454f8b54f637bf197b57f2708fbffc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ib7a35df1ec54c7d7ec2bb3fa15931a3c89172a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303782
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#624}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Update Plugin VM installer illustration
This CL updates the illustration used in the Plugin VM installer to the
new asset.
Bug: b:158009852
Change-Id: I3edcc1ce4e920c97a9ab3876f1bf9e7ae4fae66d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263416
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Jason Lin <[email protected]>
Commit-Queue: Jason Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#788911}
(cherry picked from commit 4a206fe832882387bb044cb2c8a078927eab9d84)
[email protected]
Change-Id: Ie22c1c42ee64c91be3c8ddb746302eecdb8489ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302976
Reviewed-by: Jason Lin <[email protected]>
Commit-Queue: Jason Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#623}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594920166-37bfcd26d315d702ec1ddd89ae6ef809d8dd1982.profdata to chrome-mac-4183-1594939775-403ad6f38506416c1d44e0fa8c03f407f7c8c647.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iff81bf3dc3d590df1e3e7cad788ea4d8ef3c57de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303648
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#622}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Merge to 85] Fix "highlight object with keyboard focus" on large DPI screens.
with *2), Changing the "display size" in chrome://settings on a normal
DPI screen, Window with focus in various parts of the screen.
[email protected]
(cherry picked from commit e013137a86c66b3c5e3e9e073c5067584e5e1926)
Test: Normal DPI screen,High DPI screen (--ash-host-window-=bounds
AX-Relnotes: Fixes "highlight object with keyboard focus" on high DPI screens.
Bug: 1094217
Change-Id: If1a4f839522987bb14c324d33d5e5abb27bddc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288107
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786974}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303366
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#621}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594898002-18b02d2f6e9c3d8865a6a65292129f314b34e838.profdata to chrome-win32-4183-1594932924-dd1a936e60b774bc25f034cb9bd294878700ade3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4bd39894337a188f77a923ac6d2e5e22e5bc5d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303852
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#620}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.30
[email protected]
Change-Id: Ic7aa89f130aaba5b895aa392d13c48d8ef313d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303980
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#619}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
DrmDisplay: gate |is_hdr_capable_| on kUseHDRTransferFunction
ToT sets |is_hdr_capable_| based on the characteristics of the
monitor but we'd like to gate it on the feature flag as well,
so both compositor and DRM are coherently switched on and off.
(cherry picked from commit 606fdf1f5bc37ef584c0e0d35cf429ffb4a392dc)
Bug: b:158126931
Change-Id: I3f33bd98d89f40328dfcb6265540b8c72af61aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283969
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Jao-ke Chin-Lee <[email protected]>
Reviewed-by: Daniel Nicoara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#785600}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303780
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#618}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[AW] Fix Variations.SeedFreshness metric
crrev.com/c/2247154 introduced a regression that caused
SeedStore::RecordLastFetchTime to be given a null time rather than the
seed creation time because it attempted to read from the seed after it
had been std::moved. Variations.SeedFreshness is based on the last fetch
time, which is why it's be steadily climbing since that change landed.
(cherry picked from commit 7936b441f0e7ae418670048944c33859c7a8a65a)
Bug: 1103003
Change-Id: Id8bef58cc755473eb99fe6dc0090b998c5566492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285505
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787387}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302746
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#617}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594874869-e7748f0af639ac8b105f8e834344cb0844945ac8.profdata to chrome-win64-4183-1594920166-56bad2c64ea4e932b72e8ecbc96e50aa3d7c0feb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I91839a6b10c6b2a5e6f231d573419190dbe752bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302684
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#616}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[merge M85] [blink scheduler] Increase recent audio delay to 30 seconds.
On Youtube, some videos end with a few seconds of silence to recommend
other content (e.g. www.youtube.com/watch?v=yUBPLtSUNCw&list=UU-V8lFk4Pk5i_DErHS_UNVQ).
Also, after and ad plays, there is a countdown to let the user click
on a button (e.g. https://drive.google.com/file/d/1zCeLJZW9ghdI0l8W0MIvBGVThXrk_6m_/view?usp=sharing).
During this silence, the existing 5 seconds "recent audio delay" can
expire and throttling starts, delaying the load of the next video.
This is worse with intensive wake up throttling.
This CL increases the recent audio delay to 30 seconds. This will
ensure that sites can operate correctly if there is more than 5 seconds
of silence between playing different audio/video clips. Since most
pages don't play audio in background, this shouldn't affect performance
significantly.
(cherry picked from commit 92ce1bbe4047d232faa651d92c073c86bf4ab66c)
Bug: 1075553
Change-Id: I0c12b3703c1436bbb7aad8507da950d8ab8d604f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275488
Commit-Queue: François Doray <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784166}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303355
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#615}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.26-r1 to 85-4181.3-1594634650-benchmark-85.0.4183.28-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iba1a94dfdad56bdede36289701563c842bf9c454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303106
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#614}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.26-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.28-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I487cb095252fb1e4e5f2d2c4546daaa1a7dbd98d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303104
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#613}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Updating XTBs based on .GRDs from branch 4183
[email protected]
Change-Id: I684667db48085e43e6f29c60c7379167c991882c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302913
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#612}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fix GetFrameInfo for SurfaceView case
This CL fixes GetFrameInfo for cases when we do not have texture owner.
Previously it would work only if we start we texture_owner and then
switch to overlay.
(cherry picked from commit 85c890556b122476a2c4eb2e145aa9624c924600)
Bug: 1102377
Change-Id: Ib51c1df0572345b1f604517aa733b98a15bcf3aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280467
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#785486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303351
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#611}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[AW] Don't load empty variations seed files
crrev.com/c/2247154 introduced a regression that caused empty seed files
to be considered valid. When requesting a new seed from the service, we
create an empty 'new' seed file that will possibly get written to the by
the service at a later point. If the service doesn't write an updated
seed to the empty file, WebView is supposed to try the old seed file.
Because we now consider empty seed files valid, we don't fall back to
the old file anymore if there's an empty new file, which will be the
case any time a new seed has been requested.
(cherry picked from commit 44a0eccd7cbc73c4cd5fcec64ff1f1395fffdf94)
Test: out/aw/bin/run_webview_instrumentation_test_apk \
Test: --gtest_filter='*VariationsSeedLoaderTest#testHaveEmptyNewSeed'
Bug: 1103003
Change-Id: Ic34a685cb7623bf1d70823edc491346551e7a144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286271
Commit-Queue: Robbie McElrath <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786899}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302725
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#610}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.26-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.28-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5bda423af030955cee1a61fb635445aee82f872e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302686
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#609}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[merge M85] [blink scheduler] Inhibit intensive throttling on title/favicon update.
Some pages update the title/favicon to produce a "blinking" effect
that is meant to catch the user's attention. Once such an update
takes place the intensive timer throttling intervention should
be inhibited for a few seconds, to allow a timer to perform another
update, which will produce the "blinking" effect. The existing
1-second alignment is still applied while intensive throttling is
inhibited.
(cherry picked from commit 4511fd4547600a9cecf8f82793c342e02a8a5e54)
Bug: 1075553
Change-Id: Ie344c5880eb1cbe6037142297b5038a3fb7275ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259488
Commit-Queue: Oliver Li <[email protected]>
Commit-Queue: François Doray <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: François Doray <[email protected]>
Auto-Submit: Oliver Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784024}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302720
Reviewed-by: Oliver Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#608}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Cast MRP] Check is_dict() on media status dict Values
Calling Value::Find*() causes a crash if Value::is_dict() is false.
Make sure to check is_dict() before calling Find*().
This is a speculative fix for a crash.
(cherry picked from commit 4cb9f0cfb749283157f7c8319c95be4e3f26228b)
Bug: 1105640
Change-Id: I6b01c4b2567a79288a6f636388bd70ef7c1a022b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298582
Reviewed-by: Brandon Tolsch <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303360
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#607}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Enable SurfaceLayer video with VizForWebView
With VizForWebView enabled webview now supports embedding of the
surfaces. Unfortunately because of the order how we apply features
it's not possible to override DisableSurfaceLayerForVideo from the finch
config.
This CL modifies the check for disabling surface layer to take into
account VizForWebView experiment.
(cherry picked from commit a0c3a2a3f41a60b4704421a060d56bdde1346e4b)
Bug: 1103197
Change-Id: Ied5f9e85680e0fa151c79020a5b8de7ed92f2812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287809
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786436}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302934
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#606}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.29
[email protected]
Change-Id: I24d9cbea0a8fd9ac33b6b037adfdc1a860255671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303053
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#605}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Add a param for default browser promo to allow promo with url launching
1. Remove intent data if this intent is sent out by default browser
promo utils to prevent from launching a new tab.
2. Promo with different category and action if url is provided.
[email protected],[email protected]
(cherry picked from commit 6e9271bf13fc434ec599092fa6b4d26f55a4f38c)
Bug: 1090103
Change-Id: Icd982617d637f812511eb3872a005076f9882df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295207
Commit-Queue: Lijin Shen <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788186}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303029
Reviewed-by: Lijin Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#604}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594898002-1d96b70c2e1668bb0cfeb9fd96f5c68575bb0f4b.profdata to chrome-mac-4183-1594920166-37bfcd26d315d702ec1ddd89ae6ef809d8dd1982.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7d8e99e83feeae5ee79ad3962da64a295964f72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303117
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#603}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[LiteVideo] Add Chrome flags to enable LiteVideos.
This change adds Chrome flags for the LiteVideo optimization and to
force override the decision logic. This also adds a switch to ignore
just the network settings to make the testing now and in the future
easier.
(cherry picked from commit 1c9adba32124073dd0ab2d5197e51565fb193ff7)
Bug: 1102904
Change-Id: I47e6c005e434e729652998804fcb6233d42c370f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284978
Commit-Queue: Michael Crouse <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786358}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302233
Reviewed-by: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#602}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Update the top margin and input type for the nickname field.
Screenshot: https://screenshot.googleplex.com/1ynJ0MFDGbt
(cherry picked from commit 954d3c3fef26ade3d711d28d3fcaf853852c95e3)
Bug: 1082013
Change-Id: I3689de3ada2e772aff94376748e57097fe0359f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291530
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Siddharth Shah <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787939}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300403
Reviewed-by: Siddharth Shah <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#601}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Add support for selectable versions in QR encoder.
(cherry picked from commit f5e0fc56a507bc4b617008a2641dfcd446821c58)
Bug: 1088012
Change-Id: I5f09de4fb703864e13af8b67f6f4f130735f82fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238491
Commit-Queue: Travis Skare <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786083}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300227
Reviewed-by: Travis Skare <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#600}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[iOS][Credential-Provider] Add entitlement and plist key
Remove ios/chrome/app/resources/CredentialProvider.entitlements and add
Credential Provider entitlement directly to
ios/chrome/app/resources/Chrome.entitlements
Add UIRequiredDeviceCapabilities plist key to the extension.
(cherry picked from commit 899ae8f4c004431e6d74bc32a2363c0d407349d1)
Bug: 1106045
Change-Id: I4efe0371788e0a44742419ef2a2432e13a162682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302169
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789045}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302631
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#599}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[TTS] Don't send translation params that match.
Check for matching source/target parameters and don't send the
translation information if they match.
BUG=1076197
(cherry picked from commit ae216af9861720a0aefb37160f6ca872f6b62597)
Change-Id: Ie4ba9b9061d62512b348b0e47dd48bc2b2054c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298178
Commit-Queue: Jinsuk Kim <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788469}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299473
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#598}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Orderfiles from 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie1c66449f6c994b84199d6ec050c016205a73d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303112
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#597}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Fine-tune Windows parental controls web filter detection
Chrome was considering any present "Filter On" registry value to
indicate that web filtering was enabled, but it seems that in some
conditions (maybe some security software), the value is created but set
to zero, leaving web filtering still disabled.
(cherry picked from commit 429d7d0b75ef920529e5715b9486fe2d6aab1f0f)
Bug: 1103261
Change-Id: Ifa81ce263812a4bfaa36de1900a25edeb5f66149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289913
Auto-Submit: Eric Orth <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302709
Reviewed-by: Eric Orth <[email protected]>
Commit-Queue: Eric Orth <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#596}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Disable the segment heap by default and add a GN flag to control it.
There's some concern that the cost of the Segment heap doesn't justify
its cost (see crbug.com/1102281). This CL disable it by default and put
this feature behind a GN flag to let us keep experimenting with it.
[email protected]
(cherry picked from commit 919fb801bbaa5c02a0ed1cf2123298c4e531f2f0)
Bug: 1102281, 1014701
Change-Id: I411b61efc6927ba5d9f1496990a44c44ab8ea6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292824
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Bruce Dawson <[email protected]>
Commit-Queue: Sébastien Marchand <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787917}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302309
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#595}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594889709-21f03cb58c0359987d4d786dc6d56a892958a45b.profdata to chrome-win32-4183-1594898002-18b02d2f6e9c3d8865a6a65292129f314b34e838.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7387fc95a15d823e641452f3772352bdd7e94686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302330
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#594}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Revert "[iOS][Chrome-Guard] Merges chrome guard's flags."
This reverts commit 8e1b58d27c8c8e181ff48219d8f61554b7e8a19a.
Reason for revert: iOS 14 changes delays ChromeGuard's launch.
To launch Site Information, we have to have separate both flags.
Original change's description:
> [iOS][Chrome-Guard] Merges chrome guard's flags.
>
> This CL merges /#page-info-refactoring with /#improved-cookie-controls.
>
> Bug: 1063824
> Change-Id: If3578cd4413a0e171ce59932608913ecf3f6469f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247735
> Reviewed-by: Gauthier Ambard <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Commit-Queue: Gauthier Ambard <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#779368}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 987f3c1f443e4a1213ebe834ea5faa03deaeb7a2)
Bug: 1063824, 1103128
Change-Id: I368e1f0ad63cae4ea568d8828c8e1694503894ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270212
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783534}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299740
Cr-Commit-Position: refs/branch-heads/4183@{#593}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594870224-81e56b027fd0baf51626e9b99017ef5f751317dd.profdata to chrome-win32-4183-1594889709-21f03cb58c0359987d4d786dc6d56a892958a45b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I043a89fe53036d67ed560549039e18964429078d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301990
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#592}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594874869-ebb3af66fcd2c8cde5015c984c4f297ccb7e2f91.profdata to chrome-mac-4183-1594898002-1d96b70c2e1668bb0cfeb9fd96f5c68575bb0f4b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I20e7f32e56a01ef35436e435b609ecff54d3af6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301993
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#591}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594867931-e36df464864056352a33c3ee9273268845edb4ea.profdata to chrome-win32-4183-1594870224-81e56b027fd0baf51626e9b99017ef5f751317dd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I15c488a64c3d203ea98c5821d77d3c1c56cdbeb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301047
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#590}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594855163-f790043235ca52daaa30af638448d15b19e5e5fe.profdata to chrome-win64-4183-1594874869-e7748f0af639ac8b105f8e834344cb0844945ac8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia8a8a0f42897fbe735bbf13c287483bcfc6a5f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301434
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#589}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge to M85: Marks all text fields in Views as leaf nodes in accessibility
Text fields are considered leaf nodes in the accessibility trees of all supported platforms.
If a text field has static text descendants in the internal accessibility tree, they are used to compute
the field's value.
Otherwise, the value attribute is trusted.
This is now a uniform approach between Views and Web.
The reason that we prefer to compute the value of a text field from its descendants is that
the HTML value attribute doesn't always reflect all the text in the field, including all white space.
AX-Relnotes: Fixed regression with reading in the address bar and other text fields
in Views, e.g. Add Bookmark dialog. (Regression found only in Canary.)
R=[email protected], [email protected], [email protected]
(cherry picked from commit 4eec187a5b5b783916b15638267be785167c7688)
Change-Id: I664654beb16585fe555424d3f2e564da1084aed7
Bug: 1098056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264559
Commit-Queue: Nektarios Paisios <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Auto-Submit: Nektarios Paisios <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783430}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301770
Reviewed-by: Nektarios Paisios <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#588}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Make ComputeNGCaretPosition() not to crash when we can't get offset mapping
This patch is an experimental change of |ComputeNGCaretPosition()| to return
null-position when we can't get offset mapping, because we don't know exact
reason of losing offset mapping.
(cherry picked from commit 44f4053c89e09a26f43419f3093e0aefc861d88d)
Bug: 1100481
Change-Id: Id78ca7123d8ad77cc12dea0fd785ee54ade65d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288715
Auto-Submit: Yoshifumi Inoue <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786645}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301609
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#587}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[LayoutNG] Limit PositionForPointInInlineBox() to process inline boxes in it only
This patch changes |PositionForPointInInlineBox()| in |NGInlineCursor| and
|NGPaintFragment| to process inline boxes in it to avoid infinite self
recursive call.
(cherry picked from commit 6a1a920a08dbe3476c46648837b417e8dc4730eb)
Bug: 1103605
Change-Id: I20a20c512eb76885a38d2fe5f099111f50b80158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290482
Auto-Submit: Yoshifumi Inoue <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301531
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#586}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594855163-011e7a955b44b2fd2923660bf02cf8cc309880c5.profdata to chrome-win32-4183-1594867931-e36df464864056352a33c3ee9273268845edb4ea.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I2ead707f30d84a7f8fbd456a2fedcd3dd1955890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301314
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#585}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594855163-cdc24ee2afe94bd35c114dfe03623cbd7e3b13a5.profdata to chrome-mac-4183-1594874869-ebb3af66fcd2c8cde5015c984c4f297ccb7e2f91.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Id0f8fcbb5797922c56f3b5b68b33690a80da5f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301343
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#584}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Set the correct icon effects in OnAppIconUpdated.
The icon effect is reset to 0 in ArcApps::OnAppIconUpdated, so when the
icon's block or pause effects are lost. Modify ArcApps::OnAppIconUpdated
to call SetIconEffect to set the correct icon effects.
BUG=1103881
(cherry picked from commit dd43bc16c1639f4a1599ff61219a215957f6b885)
Change-Id: Ic70dfd7567efa855a7537129abbe9a85a4803e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269825
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783411}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299948
Cr-Commit-Position: refs/branch-heads/4183@{#583}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594832637-28c40544d938bbc667f23330d162782193397319.profdata to chrome-win32-4183-1594855163-011e7a955b44b2fd2923660bf02cf8cc309880c5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7a744b53f7bc3a37b9e4b0b7bcbdf1ca48ee35f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301279
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#582}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[Tab Groups Collapse] Merge to release branch fix for dragging.
Fix drag for collapsed groups.
The bug that makes it not possible to drag a tab to the right of a
collapsed group header is due to TabStrip::GetLastVisibleTab() clamping
the insertion index.
TabStrip::ShouldTabBeVisible is used for determining if a tab is visible
in the tabstrip due to space constraints. Moving the logic for collapsed
tabs into TabStrip::SetTabVisibility().
This should also make is slightly nicer and show less headers in the case
where the tabstrip is full of group headers and not visible tabs.
(cherry picked from commit 098893c6bcb28a7e0048c90e4f9aabb9f24cb12d)
Bug: 1099367
Change-Id: I3c9321ae0561dbeb4b81eac9b9105679688ad157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277381
Commit-Queue: Charlene Yan <[email protected]>
Reviewed-by: Connie Wan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786498}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300203
Reviewed-by: Charlene Yan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#581}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
arc-a11y: Clear node id mappings every time before handling the event
This changes AXTreeSourceArc::NotifyAccessibilityEvent to clear node id
mapping every time before handling the accessibility event.
This mappings are cleared at the end of this method, but sometimes this
method gets early returned. In that case, old mappings remain when the
next accessibility event is sent, and it invoked unexpected behaviours.
This is the same patch as the patchset 3 of CL:2291568.
That CL was merged after more changes were added, but it fixed the
chrome crash and want to be merged to the release branch.
So, instead of CL:2291568, this is a cherry-pickable change, and we'll
reland it later.
TBR: [email protected]
(cherry picked from commit b6672a075bab41f28306e9018c909802c959f4f6)
AX-Relnotes: N/a.
Bug: 935143
Test: follow the steps in the bug. No longer crash.
Test: AXTreeSourceArcTest.EnsureNodeIdMapCleared fails without this change.
Change-Id: I870090d9da026aebe2ff1702cb6f23a6fb12533b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297199
Reviewed-by: Sara Kato <[email protected]>
Commit-Queue: Hiroki Sato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788150}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299949
Reviewed-by: Hiroki Sato <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#580}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594813896-6f732e272bdcfe6b8e36679f8a200b3ffcfc35c6.profdata to chrome-win64-4183-1594855163-f790043235ca52daaa30af638448d15b19e5e5fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4c3c2dd0c3c91af987564b4beeeddacb2a9e5d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301089
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#579}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
(Merge to M85) Revert "Remove process consolidation shortcut in DetermineSiteInstanceForURL."
This reverts commit cf27abd2400e698a034f5ca921618d1d080b290d.
We thought that an outdated process model shortcut to avoid
unnecessary OOPIFs was no longer needed now that we have default
SiteInstances, but issue 1101214 showed that it is actually needed on
Android Webview in cases where default SiteInstances aren't yet used,
in particular with file: URLs. Hence, this CL brings the shortcut
removed in https://crrev.com/c/1876979 back along with better
documentation on why it's still needed.
(cherry picked from commit 7067506b51aa8fb9b2acf708f46db9d2a8fd36c7)
Bug: 1101214, 1103352, 1015882
Change-Id: I444700ca37670f47c9b7730ace1c7743ee408d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288382
Reviewed-by: Aaron Colwell <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300775
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#578}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594828215-f67ff0b3b974d4afa384e44760213af02c7f6e02.profdata to chrome-win32-4183-1594832637-28c40544d938bbc667f23330d162782193397319.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iad19e0346903175526bb544f8f350685027118aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301019
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#577}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594832637-b88ee7a1227a4c77bbdd9eade4ffaa1a46068c79.profdata to chrome-mac-4183-1594855163-cdc24ee2afe94bd35c114dfe03623cbd7e3b13a5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If1f6afded0a7c71ecd0e56fb105241eccc9347a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301159
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#576}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Enable load timing for Isolated Prerender prefetches
The connect-timing UMA isn't being populated, this is why.
[email protected]
(cherry picked from commit b146e755cb950897c780ef278a29c75ad40bdfa2)
Bug: 1105219
Change-Id: Ie59f81dd899e8ec5253b8885397dd6a15a351154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298165
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788360}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300580
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#575}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Improve performance of CSD visual feature extraction
This CL cherry picks https://chromium-review.googlesource.com/c/chromium/src/+/2289078
This CL makes two changes to improve the performance of client-side
phishing detection's (CSD) visual feature extraction, reducing renderer
hangs.
- Extract visual features for only the current viewport size, so we
don't have to render the whole page.
- Skip extraction of linked destinations. This has no impact on the
visual appearance, and required iterating through the entire document.
Bug: 1099808
Change-Id: I8306520ed8cb7a26d4e8b49eac347754a4e31013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289078
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: enne <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#787219}
(cherry picked from commit 30a7a98c23a85f1569570df2a81d7e86c1820ce8)
[email protected]
Change-Id: Ifaf5a9d839fb29dd2e46eeb2f8975b1c0e8bf82c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300624
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#574}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
IsolatedPrerender should ignore same document navigations.
See bug for more details.
[email protected]
(cherry picked from commit b4d8d038a5e7e76bd1b1cd103ab8c2fac358f7d9)
Bug: 1103383
Change-Id: I14dd854f8cb55b9cf9cbf8e2bf20ae37138b6442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295995
Auto-Submit: Robert Ogden <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788048}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299238
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#573}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.28
[email protected]
Change-Id: Iad8c81bc0a42899218496e87b5ef79f5f211a0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299537
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#572}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge to m85: Fix regression where Mac menus are not read by VoiceOver
Ensure that the focus is reported as the current menu item in all menus,
not just in autofill popups, by using the popup focus override, similar
to what's used for autofill popups.
(cherry picked from commit 7750c6d5dbb427726448ddef79ffe2c0444c8852)
AX-Relnotes: n/a
Bug: 1100230
Change-Id: I2eb8e657d3f2780b4e591fbeb9abe9fc09ee4098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284050
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787340}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300346
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#571}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Airmont AFDO profile from 85-4181.3-1594634650-benchmark-85.0.4183.25-r1 to 85-4181.3-1594634650-benchmark-85.0.4183.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib70a8983d499b700187fd23977463ecff1fbf7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300863
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#570}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594639678-benchmark-85.0.4183.25-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5b7f8fe401fc5a41915afd27cbbe81b4a15ce602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300733
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#569}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594819904-dc17d30173d7459d48a13fcfd5d50624ad73f4a2.profdata to chrome-win32-4183-1594828215-f67ff0b3b974d4afa384e44760213af02c7f6e02.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7f519d9a16c962f26b51771f7a212d174c28c887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300297
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#568}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Incrementing VERSION to 85.0.4183.27
[email protected]
Change-Id: Ied1814b168b899cf089f521c8e340496b960c958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300803
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#567}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594636122-benchmark-85.0.4183.25-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3b2c8ef8ff231d3c569402133bde3903b21d1458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300724
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#566}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594813896-4083d117f1c6fd3856698f081084971ce6844aa7.profdata to chrome-mac-4183-1594832637-b88ee7a1227a4c77bbdd9eade4ffaa1a46068c79.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ib2f265287b8deddf2b417cd07c38f4f5eaa06fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300295
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#565}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[TTS] Adjust the IPH pointer location: add gap.
Adds a gap between the IPH Bubble pointer's location and the tap
position. This improves the UX slightly.
Also predetermine whether the bubble should point up or down based
on the tap position so the gap can be above or below the bubble
as appropriate.
BUG=1103748
(cherry picked from commit 874a96338c141efb3c8a000cf57036b6393e156c)
Change-Id: I26e4a3f215bb1d067188d990fd439e7945527517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293426
Commit-Queue: Donn Denman <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Reviewed-by: Mehran Mahmoudi <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787955}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300660
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#564}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Download later: Fix a bug that cancel button will start the download.
When the user cancels the download later dialog triggered in download
infobar or download home, nothing should happen.
[email protected]
(cherry picked from commit 59d9f68283293a903a4c1bff32862723e084a0be)
Bug: 1105222,1078454
Change-Id: I24e165fce8eb7a9fa532c6f948f50f09da24d46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295936
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788221}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300659
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#563}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594813896-717cf1a0e29d907dd977ae7d647df76112f0d120.profdata to chrome-win32-4183-1594819904-dc17d30173d7459d48a13fcfd5d50624ad73f4a2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7082c59c032052b7a1a7de036d10c3198dc262c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300288
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#562}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Check for WebApp existence in AppSorting in OnWebAppInstalled
This should never happen, but it seems to be occurring for some users
(see bug). Until the root cause is found, do a manual check to make sure
WebApp is not a nullptr.
R=[email protected]
(cherry picked from commit 3eb1957384c303268e6b5bb1eba53f561d16247e)
Bug: 1101668
Change-Id: Ia6148a0335aaa4394d9e335763791280001a7dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284004
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Alexey Baskakov <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786460}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300501
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#561}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Merge to M85: Simpler fix for infinite loop in Views accessibility on Linux.
This restores things to how they were before
Reland "Consolidated some text helper methods in AXNode"
(http://crrev.com/2224224) with regards to what
ViewAXPlatformNodeDelegate::IsChildOfLeaf returned.
Later if we come up with a better fix for the endless loop we can
restore the proper implementation of IsChildOfLeaf for Views.
(cherry picked from commit 4b43bf39844a04d937ad7cda5cac751ad5709749)
Bug: 1100047
Change-Id: I8e34fed0e4dcfd4822386f90b3724dc4977ed5ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277502
Commit-Queue: Nektarios Paisios <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Auto-Submit: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784361}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300619
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#560}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[85 Merge][Payment][Android] Shipping Option bundle matches PR/PH spec.
This cl changes the ShippingOption bundle to match web payments spec[1]:
1- "ShippingOptionId" key has been changed to "id"
2- shipping cost is kept as a PaymentCurrencyAmount bundle rather than
being flattened to string values with "amountValue"/"amountCurrency"
keys.
[1] https://www.w3.org/TR/payment-request/#dom-paymentshippingoption-id
[email protected],[email protected]
(cherry picked from commit dc864d5b25e6652b632aabb8e99737fc78067a30)
Bug: 1103686
Change-Id: I05d0983a54e8795904dd5b1278c49bd858706b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289992
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Commit-Queue: Sahel Sharify <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787885}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300399
Cr-Commit-Position: refs/branch-heads/4183@{#559}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594803511-57f7a5bd234ab2c3c6097b34afc2b75ba20dd4c3.profdata to chrome-win32-4183-1594813896-717cf1a0e29d907dd977ae7d647df76112f0d120.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If7875c843d78bc1bafaa738032410c0120d03ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300135
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#558}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594792140-0a6d5526105180c307e194c8b9c8b715118ca395.profdata to chrome-win64-4183-1594813896-6f732e272bdcfe6b8e36679f8a200b3ffcfc35c6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ic2d84306f4014652c01ac3956b0787653e087216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300134
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#557}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[iOS] Disable omnibox ClipboardProvider on iOS
This CL disables the provider until a comprehensive solution can be
found to the new iOS 14 clipboard access notification. Currently this
appears every time the omnibox is opened.
(cherry picked from commit 792e3ee21ee88bc10ac81fa2ab1f326c210d41ca)
Bug: 1098722
Change-Id: I44b4a1fe8947226f4ef41ac6a5d074ace89ebacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289835
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786767}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299225
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#556}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594792140-ee5931aca283bfd6dfeaa9ebe2b9b12cf480c0e1.profdata to chrome-mac-4183-1594813896-4083d117f1c6fd3856698f081084971ce6844aa7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If61c7b254de8e35b30a627c27dbad683f4f30ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300129
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#555}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594792140-5931cd4954aaebe3af2279d6d84739d20d37da93.profdata to chrome-win32-4183-1594803511-57f7a5bd234ab2c3c6097b34afc2b75ba20dd4c3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5adcf249af4c58ad64a4ce843161b107f5c97c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300119
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#554}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
M85 Merge: Change Plugin VM file manager icon
According to UI we should be using the Windows icon instead of the
Parallels icon here.
(cherry picked from commit aeaeb44a2087113e7c0bc25c6b3c372cfc069095)
Bug: 1103116
Change-Id: I64fb8fd6e248e2a920350a5ac99fa161d03aaa6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291514
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787122}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299665
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#553}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Cherry-pick of crrev/c/2294799
[Autofill Assistant] Add full state name
Resolve the state name from the abbreviation to be available for
patterns.
(cherry picked from commit a3507057acb1eb7639c6ec010c4e5bc7513923c1)
Bug: 1105365
Bug: b/159309560
Change-Id: Idaabfb39f6f2b064df8ac02aa553b579730ff802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294799
Commit-Queue: Sandro Maggi <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787719}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299222
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#552}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
M85 Merge: Update Plugin VM SVG icon in file manager to 20px icon
Dependency for merging https://chromium-review.googlesource.com/c/chromium/src/+/2291514
(cherry picked from commit ed88156b82d77d375130d41f79b6369a928e93e8)
Bug: b:151096611
Change-Id: Id6f99845ec2c1b9b466e3731347ff9cdea9a5267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283034
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#785663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299942
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#551}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594783131-a2296a87e3aa595035c1921f43ef6996f5a4f153.profdata to chrome-win32-4183-1594792140-5931cd4954aaebe3af2279d6d84739d20d37da93.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I0f1c5d91e02c88d8811aada4bf356a4c24064485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299489
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#550}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Cherry-pick of crrev/c/2289779
[Autofill Assistant] Allow to clear RequiredFields
This CL allows to clear a field instead of filling it. It will behave
the same way as filling a field in regards to the |forced| flag, i.e.
if the field is already empty (and we don't force it) we don't do
anything.
The field is, in the end, checked for emptiness. Non empty fields with
the |clear_value| flag will fail the action.
The |clear_value| flag should only really be used for <input> fields.
It can work with <select> as well (setting the value attribute) but
this is not guaranteed to actually empty the field (if the default has
a different value). The flag does not work in combination with
|fallback_click_element| at all.
(cherry picked from commit 164dbb35faf8ca6d15fc7a817627eba05a53172f)
Bug: 1105363
Bug: b/160850266
Change-Id: Ib170ee0f3e6931ad5f09a1664548c492e260e52a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289779
Reviewed-by: Marian Fechete <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787680}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299221
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#549}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Cherry-pick of crrev/c/2283342 + crrev/c/2292470
[Autofill Assistant] Break on navigation during RUNNING
This adds new breaking conditions for navigations while in the
RUNNING state.
For non-renderer-initiated navigations the flow now breaks in RUNNING
where previously only PROMPT was breaking.
Full list of what is allowed and what isn't can be found in
content/public/browser/navigation_handle.h (IsRendererInitiated)
[Autofill Assistant] Fix the navigation action
The navigation action can break scripts, because its navigations are
not declared as |is_renderer_initiated|. This can break in PROMPT
(long standing issue) and now also breaks in RUNNING after
crrev/c/2283342.
(cherry picked from commit f106a7b07e2a6ea0f327dd9422681e56166d849e)
Bug: 1103122
Bug: b/159309621
Bug: b/160948417
Change-Id: I6b6055fd213ca48e0130c48c4d1daa606bdc0fe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283342
Commit-Queue: Sandro Maggi <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#785761}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290931
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#548}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Sheriff: Add web test failure expectations
(cherry picked from commit ec6ba4709edbd6e7b27df9cdb0f04250ed08e7a5)
Bug: 1100774, 1100783, 1100786, 1099657
Change-Id: I0836d580d0668c45844c7630a769658ec81b6286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274971
Commit-Queue: Hitoshi Yoshida <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Auto-Submit: Hitoshi Yoshida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#783865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299739
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#547}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Broadwell AFDO profile from 85-4181.3-1594031560-benchmark-85.0.4183.18-r1 to 85-4181.3-1594636122-benchmark-85.0.4183.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iccde7a68c8ee3f75063d56b706a62a25fc298ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299491
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#546}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll ChromeOS Silvermont AFDO profile from 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I897a2e10ae524b41d04fd6048312d3b6e7de12a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299492
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#545}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win64 PGO profile from chrome-win64-4183-1594749420-42c1e48a5856e3cacd3f686e3783fc7d133f85cb.profdata to chrome-win64-4183-1594792140-0a6d5526105180c307e194c8b9c8b715118ca395.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4b917b634b09ddd20ccdd07fd097d1f41da1e34a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299304
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#544}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594777245-a4afdf1b1e4e10aae28955b53b86f05da490b0e9.profdata to chrome-win32-4183-1594783131-a2296a87e3aa595035c1921f43ef6996f5a4f153.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I418a584156f87a15dc583f55181fdcbbfa0e396d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299064
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#543}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Make IDS_SETTINGS_PASSWORD_REMOVE_DIALOG_BODY translateable
(cherry picked from commit 137330d11b5bb34b02476afe3b05fdda5d86b7eb)
Bug: 1104131
Change-Id: I581793a544c0f370e7318a09cb95a20079a84059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291892
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787172}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297508
Commit-Queue: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#542}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594768348-1112c9b6a6f62034aa75d2fb349431c4c9e81835.profdata to chrome-mac-4183-1594792140-ee5931aca283bfd6dfeaa9ebe2b9b12cf480c0e1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I35fe42a78c277edece14e0caeb8ca29b88cb9488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298546
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#541}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594767170-854404b255d9bfbd1e3ce2d9ee09b158e9121fb2.profdata to chrome-win32-4183-1594777245-a4afdf1b1e4e10aae28955b53b86f05da490b0e9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: If1b335a1b547b0c00297ba8575f85990c4366365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298805
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#540}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Disable the ChromeOS MediaApp by default in m85. [branch CL]
(cherry picked from commit 756f405f731ba6d3d800b2d82c518db77dd6015b)
Bug: 1033185, 1105713, b/161203361
Change-Id: Ib6ed6621d544a45895b94eacc1a3f9a1bf1be493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297214
Reviewed-by: Bugs Nash <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#539}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Win32 PGO profile from chrome-win32-4183-1594755726-433b5fec3b84f0781eec8b6c57b90cd2d2ae8b06.profdata to chrome-win32-4183-1594767170-854404b255d9bfbd1e3ce2d9ee09b158e9121fb2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I9f7957428f8135b35df4243ddf2b0e9c7b116652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298462
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#538}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[M85] Use |registered_origins_| from SWStorage for GetInstalledRegistrationOrigins
The method GetInstalledRegistrationOrigins() currently uses
|registered_origins_| which is initialized on the UI thread in
ServiceWorkerContextWrapper, and thus should only be accessed from the UI
thread. This means that a task should also be posted to the UI thread.
However, the ServiceWorkerStorage also has |registered_origins_| which
can be used by calling ServiceWorkerStorage::GetRegisteredOrigins() from
ServiceWorkerContextWrapper::GetInstalledRegisteredOrigins() on the Core
thread. Hence, this was deemed to a better solution to the problem as
this avoids thread hopping. This CL implements this change.
(cherry picked from commit 0df295a1845cb585ff7b8e3f5dba4bd4df618ca5)
Bug: 807440
Change-Id: Ib6d9b2adee7daaf7b3560774caf17295e5d1a707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277689
Commit-Queue: Nidhi Jaju <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784766}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297006
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#537}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[M85] Remove ServiceWorkerObserver from IsolatedPrerenderTabHelper
This CL replaces the use of IsolatedPrerenderServiceWorkerObserver::
IsServiceWorkerRegisteredForOrigin() by directly calling ServiceWorker
Context::HasRegistrationForOrigin() in IsolatedPrerenderTabHelper::
CheckEligibilityOfURL. This can be done because this method
is called on the UI thread. By using HasRegistrationForOrigin(), we are
able to use the already existing |registered_origins_|, as it is not
necessary to retrieve all service registrations just to confirm if a
service worker is registered for a particular origin. Furthermore,
the IsolatedPrerenderServiceWorkerObserver class is also removed as it
is not needed anymore.
The motivation of this change is to eliminate unnecessary memory
allocations and data conversions GetAllOriginsInfo() performs
(see [1] for details). When the browser has many service worker
registrations for different origins, these allocations/conversions
have considerable performance impact.
[1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA
(cherry picked from commit d4393884b45ae28350b132613d026f6d18ad1dda)
Bug: 807440
Change-Id: I6081df48fd6b02850ca8276923134ee7c821b92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259677
Reviewed-by: Patrick Monette <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Nidhi Jaju <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#782802}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297007
Cr-Commit-Position: refs/branch-heads/4183@{#536}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Add annotation icon for personal info suggester.
Also change the variable name from show_tab to show_annotation since we
don't have tab icon now.
(cherry picked from commit aa8bf3d34e8507cee36d02eb66b250f3e183ea70)
Test: tested with Chrome on Linux
Bug: 1099498
Change-Id: I2d4cb00c6e329fd6b59aa730c2efb5827f99fb75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291918
Commit-Queue: Jing Wang <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291808
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#535}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
Roll Chrome Mac PGO profile from chrome-mac-4183-1594749420-23d7a7b72835ecab8ec06d1fb8d75674ce280331.profdata to chrome-mac-4183-1594768348-1112c9b6a6f62034aa75d2fb349431c4c9e81835.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4a576223d339830a6098cc1687557c7f100389b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298702
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#534}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
[TTS] Update metrics for M85 experiments.
Various updates to metrics recording for Contextual Search that are
needed for the M85 experiments in progress.
Some of the metrics are user actions that track the selection and
how it is being adjusted. Existing actions that track manual adjusting
of the selection was being done in the wrong part of the code making
it not useful for the experiment that we need them for.
Histograms for system resolve requests and responses are also added,
along with a histogram for translation. Sometimes a histogram is used
as a simple counter, but there doesn't seem to be a natural way to do
that so a boolean histogram is used (with a signal that may not be
very important).
The new metrics entries are all in our UMA file, and they present a
convenient bottleneck for future logging of selection adjustment for
Smart Selection since it needs to know if the selection was adjusted
by the system or the user.
Metrics additions:
UserAction: "ContextualSearch.SelectionEstablished"
UserAction: "ContextualSearch.ManualRefineSingleWord"
UserAction: "ContextualSearch.ManualRefineMultiWord"
Histogram: "Search.ContextualSearch.SelectionExpanded"
Histogram: "Search.ContextualSearch.ResolveRequested"
Histogram: "Search.ContextualSearch.ResolveReceived"
Histogram: "Search.ContextualSearch.TranslationNeeded"
Also fix the logging of the CardTag. A regression caused the mapping
from coca=>enum values to be called twice, which distorted the values.
BUG = 1102670, 966203
(cherry picked from commit f7fa8f0043240e13771568359204e5e87c5839c2)
Change-Id: I09f4941738e82c554f25ba9bfe0a7c417db9ba48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286480
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Theresa <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787416}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298109
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#533}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}