Publish DEPS for 84.0.4147.69
Incrementing VERSION to 84.0.4147.69
[email protected]
Change-Id: Ic62881db37d29c152507237dbcfeb1b59a39c5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261646
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#773}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.68
[email protected]
Change-Id: I5dad0d568b22a1f5d9743176235ba1ce35bf528e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260950
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#772}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
VaVDA: Use kReduced for H.264 on older boards.
CL:2246846 modified the VaapiVideoDecodeAccelerator to use
BufferAllocationMode::kNone for H.264 on Gemini Lake or later. However,
for older devices, it started using kSuperReduced mode which caused
widespread failures on resolution change tests.
This CL brings back the original fallback to kReduced for H.264 which
shouldn't have been removed in the previous CL anyway.
(cherry picked from commit 77c82386f389f0b3bf8809ca5b7b75ebafff82ac)
Bug: b:159661743, b:159659506, 910986, 1054097
Test: video.DecodeAccel.h264_resolution_switch on pyro & caroline.
Test: video.Seek.switch_h264_alt on pyro & caroline.
Change-Id: I3eb883b8d68c60469751db4a12049ab56e60a0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260937
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#781440}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260942
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#771}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.67
[email protected]
Change-Id: I3e9b32d794cf122daebf7845e7333e107604b3eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261227
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#770}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Revert "Don't reset computed 'float' for flex and grid items"
This reverts commit 906abd41e4f6c786a1927f6edd69d6926e20317b.
Reason for revert: A DCHECK was getting hit, causing a crash: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595#c4
Original change's description:
> Don't reset computed 'float' for flex and grid items
>
> Floated flex and grid items have their 'float' incorrectly computed to
> "none". This change fixes this by adjusting IsFloating() for flex and
> grid items inside LayoutBox::UpdateFromStyle() instead of inside
> StyleAdjuster::AdjustStyleForDisplay().
>
> Beyond this, legend elements are not allowed to be rendered legends
> if they are floating. However, if legends are flex items, we
> adjust IsFloating() to be false. This causes legends to be
> used as rendered legends when they are flex items, even if they
> were styled as a float.
>
> This is fixed by checking ComputedStyle::IsFloating() instead
> of LayoutObject::IsFloating() when finding the rendered legend in
> order to get its non-adjusted floating value.
>
> Bug: 875235,350505
> Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889
> Reviewed-by: Ian Kilpatrick <[email protected]>
> Reviewed-by: Morten Stenshorne <[email protected]>
> Reviewed-by: Christian Biesinger <[email protected]>
> Commit-Queue: Alison Maher <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#763988}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit c2add27d157d490be5800ad29e11503503b79749)
(cherry picked from commit 539b7fa25584189eca30c5128190796839904a4d)
Bug: 875235, 350505, 1097595
Change-Id: I5e5ff8a93d1e1e46908f9b640b9564e70345e9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256772
Reviewed-by: Alison Maher <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Alison Maher <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#780995}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258462
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4179@{#4}
Cr-Original-Branched-From: 92c9f5e66186f2762809a21e4315087f6169bf45-refs/heads/master@{#780781}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261182
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#769}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Speculative fix for SplashController#hideSplash() crash
This CL addresses the two potential reasons that
ChromeActivity#getCompositorViewHolder() == null when
SplashController#hideSplash() is called
Reason #1: ChromeActivity#onInitialLayoutInflationComplete() has not yet
been called
Reason #2: SplashController#hideSplash() is called after
ChromeActivity#onDestroy()
BUG=1096171
(cherry picked from commit 3a055f36a4177b7d4023a537b7c8e797e2aeb954)
Change-Id: If46daf4bcf007fab26c6c9066d355b3c4506eb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259483
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#781376}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261353
Reviewed-by: Ella Ge <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#768}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Android R: detect insets change and update suggestions list.
This change ensures that whenever keyboard height changes
on Android R and above, we consider not only the position
but also window insets to determine whether we should
perform a measure and layout pass for the Omnibox Suggestions
list.
(cherry picked from commit 0999bc0b02bae0fd3c2fe3c537d17a569bae4e7a)
Bug: 1091880, 158543110
Change-Id: I97cd3a5bb44d5a8880f60414331b499f5aa51927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255131
Commit-Queue: Ender <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#781007}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260954
Reviewed-by: Ender <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#767}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Merge "Remove stale profile tracking in ReportScheduler"
Merge into M84.
Removes the Enterprise.CloudReportingStaleProfileCount metric and code
around tracking stale profiles, since the metric is no longer needed.
This will also make it easier to move CBCM logic to components.
(cherry picked from commit a1f809c73344fab7adf10c30f4acbed73e3996ad)
Bug: 1091926, 1098326
Change-Id: I3224996f5a0c517ffacd2cec0603b5cc4153fd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238464
Commit-Queue: Guillaume Jenkins <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#777154}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261034
Reviewed-by: Guillaume Jenkins <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#766}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Updating XTBs based on .GRDs from branch 4147
[email protected]
Change-Id: I6b7a376aaaee3494dd3f7f8759ff412efc196554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261096
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#765}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Avoid memory allocation in AudioWorkletProcessor.process()
Based on the spec [1], the current implementation of
AudioWorkletProcessor needs to create a new data container
(i.e. WebIDL sequence<>) for input, output, and param arrays.
With the new spec change [2], this CL changes the overall design
of the audio processing callback:
1. Moves the processing call from AudioWorkletGlobalScope to
AudioWorkletProcessor object.
2. AudioWorkletProcessor now keeps the data container within
the object and allocate memory when it is needed.
The preliminary benchmark shows the sizable improvement in the
audio stream quality. The glitch score
(= buffer underrun/total callback) is improved by ~9x in the
low-tier machine. [3]
This is an API change [4], but the real world impact would be
negligible because there's no functionality change.
[1]: https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process-inputs-outputs-parameters-inputs
[2]: https://github.com/WebAudio/web-audio-api/issues/1933#issuecomment-616632754
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1086665#c2
[4]: https://chromestatus.com/feature/5647541725036544
(cherry picked from commit d37846207b92881d8946df588d991057cdc27b0b)
Bug: 1071085, 1086665
Change-Id: I3e664754973d4d86649d38c1807c6b9d7830fb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218702
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779052}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252598
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#764}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Fix UAF when closing tabs very quickly.
[email protected]
(cherry picked from commit ec2b409fc0b3bac329b02eafe6b9c5ba47c3fd90)
Bug: 1082755
Change-Id: Id8e174625f16e9a319000eb7427ec8659174c7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204259
Commit-Queue: Taylor Bergquist <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#770758}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261154
Reviewed-by: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#763}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Safety check UI: clear search term on navigation
* When navigating to a Settings subpage from safety check, clear the
search term so that content on the subpage is not hidden by it.
* This fix is the equivalent of crrev.com/c/2232863, customized to the
4147 branch. This customization is necessary as only 2 of the 3
safetycheck children affected by the original fix exist in the 4147
branch. The fix for those 2 children is equivalent to the one in the
original fix.
Bug: 1085422
Change-Id: Ief8be6ecb2ed160f6bb7f1e489624f0bd545ed78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245917
Reviewed-by: dpapad <[email protected]>
Commit-Queue: Rainhard Findling <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#762}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Add disable by default feature flag for login display password button
This CL reintroduces the submit button on the login / lock screen password textfield and disable the login display password button feature by default, by putting it under a feature flag.
(cherry picked from commit 88bbb61ef9bb6267290290aab9f062d66b683322)
Bug: 1090319
Change-Id: I521a19262726f7c0566d824b0efe5aa1c9abb7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247826
Commit-Queue: Thomas Tellier <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780311}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254146
Cr-Commit-Position: refs/branch-heads/4147@{#761}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[StartSurface] Make incognito description focusable
Before Android P, clearFocus of a view will cause request
refocus propagation,
https://android.googlesource.com/platform/frameworks/base/+/2e5f38e0bfe797f3be6ffff5ba070f4dc1b870c1/core/java/android/view/View.java#5237
If there is no other focusable view, then it will focus on the same view again.
So there are two ways to solve this problem:
1, have a dummy focusable view. which is not good for keyboard user.
2, make other view focusable.
Note that IncognitoNewTabPageView is focusable,
https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/res/layout/new_tab_page_incognito.xml;drc=0410e42b35dfdcbe7efd047c6284c07441590195;l=6?originalUrl=https:%2F%2Fcs.chromium.org%2F
See more discussion context
https://docs.google.com/document/d/1yBXMFc11uhZcvNN6yNm_a7wgwqlOXeE6mWznim6qjTU/edit?usp=sharing
(cherry picked from commit 42eac70e07783913eab618c11a6ab785c0d457f7)
Bug: 1097001
Change-Id: I5643049ea16caf102d75960764744be4e1c2101c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255382
Commit-Queue: Ganggui Tang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780557}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260418
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#760}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.66
[email protected]
Change-Id: I148bb596a0f9417cca4cf374284fde43c4de0e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260814
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#759}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Safety check: ensure JS is allowed before running checks
* When users click the "Run safety check" button, safety check has a 1s
delay before it runs the actual safety check. This is done to ensure
that the "running" state of safety check children is shown to users
for at least 1s.
* If users reload the Settings page in that 1s delay the browser
crashes with crbug.com/1096965.
* This fix makes safety check ensure that JS is still allowed after the
delay, before it runs the actual checks.
(cherry picked from commit 681b9b2f2de6d798cdc3303f4de145e48dfa44b9)
Bug: 1096965
Change-Id: I8ab45e4e561ba051a87019d41af3ac7a6c00162e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254138
Reviewed-by: Esmael Elmoslimany <[email protected]>
Commit-Queue: Rainhard Findling <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780397}
tbr: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254781
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#758}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Reland "[StartSurface] Switch to normal tab model on resume to V2 start surface"
This is a reland of 9b955d94b8a295dcb636f5b63b513ebc267d4936
Original change's description:
> [StartSurface] Switch to normal tab model on resume to V2 start surface
>
> This CL also solves the scroll issue of the incognito description.
>
> Screen records:
> Resume:
> https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing
>
> Scroll:
> https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing
>
> Bug: 1093506
> Change-Id: I5d7365daa530b23f897a19665076cbc32238224f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334
> Commit-Queue: Ganggui Tang <[email protected]>
> Auto-Submit: Ganggui Tang <[email protected]>
> Reviewed-by: Yusuf Ozuysal <[email protected]>
> Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#779878}
Bug: 1093506
Change-Id: Ie49546277d347eea6682064a41a859f52b882a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254578
Auto-Submit: Ganggui Tang <[email protected]>
Commit-Queue: Yusuf Ozuysal <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#780386}
(cherry picked from commit 9ac0ba4820fe9375ecdae76543f02d4dc4ac2085)
[email protected]
Change-Id: Ia6b575580eb751ac259a45ac79adf16a2f04b87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259573
Reviewed-by: Ganggui Tang <[email protected]>
Commit-Queue: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#757}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
OOR-CORS: each content:// should be assumed as an opaque origin
On Android Chrome, each content:// should be assumed as an opaque
origin, and should not allow CORS-enabled requests among content://
URLs. Also content:// can not load legacy worker scripts from
content:// URLs as the mode "same-origin" is not permitted too.
TEST=./out/a/bin/run_chrome_public_test_apk -A Feature=CORS
(cherry picked from commit c6e232163d52e4334f7227ef30634b707e44a903)
Bug: 1092449
Change-Id: I83d15f4c1e2f2d88e219032952a7da78f470c16a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247920
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779596}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259113
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#756}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Fix invalid iterator usage in crostini_manager
CrostiniManager::OnAbortRestartCrostini gets an iterator into
|restarters_by_id_| but dereferences it before checking if it is the
past-the-end iterator, potentially causing a crash. Change this method
to bail out early if the restarter being aborted has already stopped.
This was not caught by the test for this case
(CrostiniManagerRestartTest.DoubleAbortIsSafe) because it incorrectly
terminates as soon as the first abort finishes, instead of waiting for
the second. Fixing this causes the original code to crash under MSAN,
and passes with the new code.
(cherry picked from commit 542ed9ad258571a0f34e9c7799f795400616a387)
Bug: 1096979
Change-Id: I67322c5a8823dea4e517ba04d5fbf110b200e8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251644
Reviewed-by: Jason Lin <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780664}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257661
Cr-Commit-Position: refs/branch-heads/4147@{#755}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Updating XTBs based on .GRDs from branch 4147
[email protected]
Change-Id: Iaa62015a5aa0d8383dd6a48f0ade7c1350878fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255427
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#754}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.65
[email protected]
Change-Id: Ib71a8a41e57b53ed5b32220bd926711aa2386079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259553
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#753}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
cherry pick fix to vp9 resizer for realtime
e9c6cb64744f6df31ba52501d4759b50ba832df2
Bug: 1097494
Change-Id: If625f864fef907dffd3e5c0b8634feedf491d32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258779
Commit-Queue: James Zern <[email protected]>
Reviewed-by: James Zern <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#752}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Demo Mode: Install sample photos to My Files instead of Downloads
This works around the ARC++ Download folder bug in Managed Guest
Sessions, where the <shared storage>/Download mount in Android isn't
working correctly. This bug causes any reads of the Download directory
in ARC++ to fail, resulting in the sample photos not being readable from
Android apps - including the media scanner.
This CL moves the sample photos from Downloads to My Files, which allows
the Android media scanner to pick up on those photos. Most notably, this
allows Google Photos in Demo Mode to display the sample photos bundled
in Demo Mode, which was broken before this CL.
Note that we would still prefer the sample photos to be stored in the
Downloads directory, as most apps expect photos to be there instead of
My Files (such as the CrOS camera app and the "open file" dialog).
We should revert this CL once the aforementioned bug is fixed.
(cherry picked from commit c9d350e245098a7decb21e85d3796256a81141ea)
Bug: b/158053270
Change-Id: Id4f39c23ec3321bca424bed405281e42045a136d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228272
Commit-Queue: Michael Cui <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Reviewed-by: Patti <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#774899}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257467
Cr-Commit-Position: refs/branch-heads/4147@{#751}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.64
[email protected]
Change-Id: I3a870b214e0ab39bff1afac18d05dcba4220476e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259016
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#750}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Revert "mb_config and waterfall for 10.15"
This reverts commit 71e7e96f5220cfeae7fd28ce74e9f8a51789a80a.
Reason for revert: Still getting generate_buildfiles error, even with 'compile targets: all'. https://ci.chromium.org/p/chromium/builders/ci-m84/Mac%20Builder/616
Original change's description:
> mb_config and waterfall for 10.15
>
> milestone Mac Builder builders will run on 10.15, once infra/config
> changes land on master, and will need these cherry-picked changes
>
> Bug: 1066873
> Change-Id: I375882f4b4c60797ad7d5e9d0c757c5be8b419e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254356
> Reviewed-by: Garrett Beaty <[email protected]>
> Commit-Queue: Stephanie Kim <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4147@{#748}
> Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[email protected],[email protected]
Change-Id: I947929ecc59d344f2099f108e498f9c3fb1f0ea7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258313
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Stephanie Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#749}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
mb_config and waterfall for 10.15
milestone Mac Builder builders will run on 10.15, once infra/config
changes land on master, and will need these cherry-picked changes
Bug: 1066873
Change-Id: I375882f4b4c60797ad7d5e9d0c757c5be8b419e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254356
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Stephanie Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#748}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[iOS] Set "url_to_reload" in Safe Browsing interstitial load time data
This CL sets a reload URL in |load_time_data|, matching the
change made for SSL interstitials in crrev.com/c/2248450.
Not setting this value can break back/forward navigations
to a Safe Browsing warning page for the case where a page
has an unsafe subframe. A test for this case is being added
in crrev.com/c/2246995.
(cherry picked from commit 33059ba337c6df5db7aab4eaaa0e7a74e099d18f)
Bug: 1093510
Change-Id: I44e564343a683db66948d46b2cd3f514121dd9fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254581
Reviewed-by: Livvie Lin <[email protected]>
Commit-Queue: Ali Juma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780442}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258358
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#747}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Rollback protobuf lite runtime to 3.0.1
As a temporary fix for android webview regression b/157318961 this cl
rolls back the protobuf lite runtime to 3.0.1 using the codegen plugin.
This also includes the followup fix in crrev.com/c/2243256.
(cherry picked from commit 8a3e6a2898a3dd20e625cd5013a813982bc6bb63)
Binary-Size: This is temporary and there is not really much we could do.
Bug: 1093059, b/157318961
Change-Id: I2bbaf6d3b434221b667901423c4616e26a7550c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238872
Reviewed-by: Dan H <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Mohamed Heikal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#777495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255652
Reviewed-by: Mohamed Heikal <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#746}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[FlexNG] Multiplying by aspect ratio should ignore border/padding
Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.
So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.
(cherry picked from commit 98420506eef207370c0832855c58a853b042e8da)
Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251202
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780401}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258413
Reviewed-by: David Grogan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#745}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions] Fix unsafe variable access in set_icon.js
set_icon.js checked the `self` variable to determine whether the script
was running in a ServiceWorker (such as a ServiceWorker-backed
extension). However, this is unsafe because, unlike `window`, `self` can
be overwritten by other script. If an extension specified a value for
`self`, that would be used instead - and would subsequently crash if the
value didn't support the `in` operator (i.e., wasn't an Object).
When this happened, the custom bindings would fail to register any
hooks. This, then, would result in API calls to browserAction.setIcon()
in passing the arguments directly to the browser-side handling. When
this happened, the browser would classify it as a bad message (because
it didn't undergo the expected argument modifications), and would kill
the renderer.
Fix this by adding a native binding to return whether the script is
running in a ServiceWorker context. Add a regression test.
[email protected]
(cherry picked from commit bb686c7922639d306cf948d70e6ee9e35cb306e8)
Bug: 1087948
Change-Id: I1bb593af735dec6d7a2a25050e62677f23c23dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253284
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: David Bertoni <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780315}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258414
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#744}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Merge to M84: Don't show invert bubble in incognito windows
http://crrev.com/c/2118693 caused the invert bubble to start showing up
on Mac, but only in incognito windows, which is unintentional. The bubble
doesn't show up for non-incognito windows.
As a quick fix, disable the bubble for incognito windows since it should
never show up in one of those. Later we can follow up to address when it
should show up on Mac.
(cherry picked from commit 2591b39132fd681f73f1afdac296369eb4ec2400)
Bug: 1095855
Change-Id: I169f000b1657528e46fd9fc7e6786ef2834e27cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247407
Commit-Queue: Dominic Mazzoni <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Auto-Submit: Dominic Mazzoni <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779419}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258412
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#743}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[Merge to M-84] Overview: Fix DeskNameView context menu closing overview
OverviewController used to handle OnAttemptToReactivateWindow()
by treating the window "requested" for activation as if it's the
window that gained activation (while actually activation didn't
change). This lead to overview closing when the requested window
for activation is a context menu (which is not activateable in the
first place).
It seems that OverviewController doesn't need to handle this
event at all, so removing.
[email protected]
BUG=1056541
(cherry picked from commit c93346cef6674bc51389d765c1263f0e0027be61)
Change-Id: Ic7d395bf448ca547b9173d5b153e55b90e3e5210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249125
Reviewed-by: Mitsuru Oshima (slow:gardening) <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258572
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#742}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84 Merge] Blacklist the AMD Vulkan driver 1.0.54 for info collection on Windows
Majority of the Vulkan crashes on Windows have this driver version.
This version was accidentally excluded in the previous CL.
(cherry picked from commit eb28a2c5e73394bb54245e469590679df04300d6)
Bug: 850881
Change-Id: I0df2ea2e2ba4e5e7ce300e13ece2468f026ddab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253079
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Maggie Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780058}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257455
Reviewed-by: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#741}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Check if context menu feature is enabled in ShouldPreventElision
Makes sure that the URL remains elided if the context menu
option is removed, especially if the "Always Show Full URLs"
pref was previously turned on.
(cherry picked from commit 62bb214576679a8c180df4b25365182b540d10e4)
Bug: 1095975
Change-Id: Id5ab1d5c384483286bebb3e3e36cf5880db975d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252932
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Livvie Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780449}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257408
Reviewed-by: Livvie Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#740}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Remove unneeded strings from EDU coexistence setup flow
Two list items from 'G Suite for Education accounts' are removed:
* Info about child data
* Resources for schoolwork
This cl needs to be merged back to M84, so it will be followed by
a cleanup cl that removes string resources.
The new screen look: https://photos.app.goo.gl/FzJqSEu8YXvXg7Pg9
(cherry picked from commit 7a8b5f23c7b18df3203ba2ae0612d1dbba9f3aa2)
Bug: 1097371
Test: Manually
Change-Id: I8e4e23e7f6d19c52220ddaacf1d3690541ae1064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255027
Reviewed-by: Yilkal Abe <[email protected]>
Commit-Queue: Aga Wronska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256846
Reviewed-by: Aga Wronska <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#739}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions] Fix one path for bad arguments passed to action.setIcon()
If extension APIs get arguments that they don't think should be possible
from a renderer, the renderer will be killed for sending a bad message
(this is WAI). The [browserAction|pageAction].setIcon() API has been
killing renderers for sending invalid data.
Some early metrics added indicate that this happens when the arguments
passed include neither an iconIndex nor imageData key (which
theoretically shouldn't happen). After some investigation, it seems
this *could* happen if there are some tricky getters or settings on
the Object prototype, which would prevent us from construction an
object with the proper values.
Defend against this by using a gin::DataObjectBuilder in the renderer
(which uses v8::Object::CreateDataProperty() internally, which doesn't
hit the Object prototype), as well as assigning a null prototype to the
resulting arguments.
Also add a regression test.
[email protected]
(cherry picked from commit e1f2aebd87e6a4abb769592fca24b95c0a2d83fe)
Bug: 1087948
Change-Id: I45d34024f8f3066eb547b974d564c1e41f064993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246836
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778915}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257270
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#738}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Merge "SELECT element: Fix a regression on adding multiple selected OPTIONs to a single-selection SELECT" to M84 branch
This CL fixes a regression caused by crrev.com/745230.
Bug details:
Suppose that |select.innerHTML = '<option selected>Option1' +
'<option selected>Option2'| runs.
Before crrev.com/745230,
1. Option1 is appended to the SELECT.
2. HTMLOptionElement::InsertedInto() and |HTMLSelectElement::
OptionInserted()| are called for Option1.
3. SelectOption(Option1) is called.
4. DeselectItemsWithoutValidation(Option1) is called
5. Option2 is appended to the SELECT.
6. HTMLOptionElement::InsertedInto() and |HTMLSelectElement::
OptionInserted()| are called for Option2.
7. SelectOption(Option2) is called.
8. DeselectItemsWithoutValidation(Option2) is called. Option1's
selected state is cleared.
Since crrev.com/745230,
1. Option1 is appended to the SELECT.
2. Option2 is appended to the SELECT.
3. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement::
OptionInserted()| are called for Option1.
4. SelectOption(Option1) is called.
5. DeselectItemsWithoutValidation(Option1) is called. Option2's
selected state is cleared.
6. HTMLSelectElement::ChildrenChanged() and |HTMLSelectElement::
OptionInserted()| are called for Option2.
7. SelectOption(Option2) is NOT called because Option2's selected
state was cleared.
Fix:
DeselectItemsWithoutValidation() should not update 'selected' state of
OPTIONs for which OptionInserted() is not called yet. This CL adds a
boolean flag to HTMLOptionElement, it represents whether
OptionInserted() is called or not, and DeselectItemsWithoutValidation()
checks the flag before updating 'selected' state.
(cherry picked from commit 8f1505baae29541756ce8e140f84118109ce17c6)
Bug: 1095725
Change-Id: If19b28c3edb877549ca498b661647466d03e6d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253260
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780174}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257462
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#737}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions UI] Update button in settings overridden prompts
Instead of "Ignore", use "Keep it".
[email protected]
(cherry picked from commit 1a4b3bda0b8d2d44aed66f2dd3ffc70bbf6c962f)
Bug: 1079364
Tbr: [email protected] (per offline discussion)
Change-Id: I8905d3576b129a064d124007fa1ed9317c280ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253367
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780192}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254341
Cr-Commit-Position: refs/branch-heads/4147@{#736}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Query Tiles : Disable animations
This CL disables tile animations which fixes the crash. We will have a
better fix to handle stale animations correctly in M85.
(cherry picked from commit b28b3af7327585328868a60c566272777c0369b2)
Bug: 1096437
Change-Id: I5389707703c587aea0576699217f443ce6852953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252563
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780070}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257992
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#735}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[Merge to 84] Disabling Reader Mode test which flakes in M84.
Flakes are only occurring in M84 because a flake fix landed
after the 84 branch: crrev.com/c/2209281.
This change will be cherry-picked to M84 and then reverted in M85.
(cherry picked from commit f26312b0c10c6d67a7961c42c860351aa3610846)
Bug: 1064776
Change-Id: I6518458ac57f268b8c762097877b077e8852d833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250159
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779885}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252695
Cr-Commit-Position: refs/branch-heads/4147@{#734}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Merge M84: [Lock screen media controls] Hide when created in suspended state
> Hide the controls when the lock screen is created as a result of
> closing lid and in suspend state already.
>
> Bug: 1097101
> Change-Id: Ifb1f92bc054c7278992d95c13d5f5e5d750c94c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254468
> Commit-Queue: Xiyuan Xia <[email protected]>
> Commit-Queue: Roman Sorokin [CET] <[email protected]>
> Auto-Submit: Xiyuan Xia <[email protected]>
> Reviewed-by: Roman Sorokin [CET] <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#780425}
(cherry picked from commit 555545cd8b75cb8bc3414500b4c2118393ccf828)
Bug: 1097101
Change-Id: I6506fad810984c386db0d7902ff90cab5faf6310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256843
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#733}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Orderfiles from 84-4147.37-1592215428-benchmark-84.0.4147.53-r1 to 84-4147.37-1592215428-benchmark-84.0.4147.60-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id56f5430681ecbe5d200826e7cdaeaecd20a8f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257269
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#732}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[network] Allow passing null cookie observer.
Some users might want to pass NullRemote if they are not interested
in observing cookie-related notifications.
The network service already supports null remote, so update the mojom to
reflect that.
R=[email protected]
BUG=1095600
(cherry picked from commit e67aad4f8ac2924ccfd8b5edbc600358f4ee464e)
Change-Id: I8be8a319a6b06d18400c05b3d452fec44b20f024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250064
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256211
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#731}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.63
[email protected]
Change-Id: I4a4e447ab2d63227931213fe074ba4417b33335b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257541
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#730}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
OOBE: Refresh GAIA screen upon hide
(cherry picked from commit cdc08bbf0da46cc754e89e56499332f9a310dc8e)
Fixed: 1067210
Fixed: 1078325
Change-Id: I02b88009f8bf646efbc9d88d1b6e58273f90859c
Bug: 1067210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210235
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Auto-Submit: Denis Kuznetsov [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#770571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255476
Cr-Commit-Position: refs/branch-heads/4147@{#729}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
WizardController metrics: Move to use TimeTicks instead of Time.
Time is not guaranteed to always increase, this may cause mistakes in
metrics recording.
(cherry picked from commit 9a0e8d223a3a7ce7b342f9dbf242cac7adc1f890)
Bug: 1095058
Change-Id: I71e0333be9547c6b99e9e9c081754a5f8b20bb1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247891
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779281}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255601
Cr-Commit-Position: refs/branch-heads/4147@{#728}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.62
[email protected]
Change-Id: I28ff66c9abc793f512ca7dda66fe6dfa5cc9d87b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255626
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#727}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Broadwell AFDO profile from 84-4147.37-1592217301-benchmark-84.0.4147.53-r1 to 84-4147.37-1592217301-benchmark-84.0.4147.60-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I856c8a1c85da9c67576b0d51b60a09e9ba2c60ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256543
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#726}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Airmont AFDO profile from 84-4147.37-1592213859-benchmark-84.0.4147.53-r1 to 84-4147.37-1592213859-benchmark-84.0.4147.60-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I279e17499c665f8f9d3669aed85d8c9f53c583ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256540
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#725}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Silvermont AFDO profile from 84-4147.37-1592215428-benchmark-84.0.4147.53-r1 to 84-4147.37-1592215428-benchmark-84.0.4147.60-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I66501085c3d04d71fca5b51878989e61a0006e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256541
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#724}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.61
[email protected]
Change-Id: I0c6b2074a038b2205a67d762f47c49e726c0d463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256438
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#723}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Orderfiles from 84-4147.33-1591611589-benchmark-84.0.4147.48-r1 to 84-4147.37-1592215428-benchmark-84.0.4147.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7393b4303373e0aee9ff46bbea24fe2a28ec151c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255117
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#722}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.60
[email protected]
Change-Id: Ic80f915bb19aeabf6eced5e48acc9bd43745cd8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255040
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#721}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Set a reload URL in iOS interstitial page load time data
iOS interstitial pages get reloaded to prevent loading them from
cache, since that breaks JavaScript commands. For safety, set
the reload URL in |load_time_data| instead of relying on
window.location, which can have arbitrary URL params.
(cherry picked from commit b53647c43503ff78976b55413f1be11bcadeec8d)
Bug: 1087282
Change-Id: Idd3c8619371fd7e5ed5875579f4bd86eda2e42c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248450
Commit-Queue: Livvie Lin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779484}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255219
Reviewed-by: Bindu Suvarna <[email protected]>
Reviewed-by: Livvie Lin <[email protected]>
Commit-Queue: Bindu Suvarna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#720}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Merge-84: Fix crash on mousewheel scroll on login shelf
BUG=1096196
[email protected]
(cherry picked from commit 23bf28fba3c9d942f66b824b7ccb73cf32fea334)
Change-Id: I92bbcc8659b250500f711ff33ab210a370f42ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251203
Commit-Queue: Toni Baržić <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779957}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255031
Reviewed-by: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#719}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.59
[email protected]
Change-Id: I30d017b8edf427d3ac81463a51d36de606fd8c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255560
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#718}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Initialize OOPIF screen_info from root RenderWidgetHost().
Prior to this CL, when a CrossProcessFrameConnector is created for an
OOPIF, SetView() has not yet been called, so when the constructor calls
RenderWidgetHost::GetScreenInfo(), it defaults to calling
DisplayUtil::GetDefaultScreenInfo(), which will retrieve the information
for the primary display. If the primary display has a different
device_scale_factor than the display on which the OOPIF is rendering,
then (initially) the OOPIF will render with the wrong scale.
As noted in the associated issue, the OOPIF renders correctly after
OnSynchronizeVisualProperties() has been called ... this is because
it propagates the screen_info from the root view down to all the OOPIFs.
This CL makes a simple modification in forcing the constructor to
get its initial screen_info from the root RenderWidgetHost, which
presumably has a correctly attached view by the time OOPIFs are being
created.
(cherry picked from commit 8d50664f79250e4a047f3f7756430f2c858be9fb)
Bug: 1076450
Change-Id: Ic85f0b099e2a8fb7aa1e8b579dbcddcdcac3e757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247749
Commit-Queue: James MacLean <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254582
Reviewed-by: James MacLean <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#717}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84 Merge][Assistant Opt-in] Unblock Assistant opt-in flow when network disconnect
(cherry picked from commit f575894605b98c7d75acea014d47ed846ffd5d95)
Bug: b/158541058
Test: Manual Test
Change-Id: I74300ee103845a66b2acb8c61de59777c3495d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250463
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#780050}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253224
Reviewed-by: Yue Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#716}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Dynamically set up top margins for start surface
http://crrev.com/c/2247142 sets top margins for some sections in start
surface. However, setting top margin for some sections with
app:layout_scrollFlags="scroll" makes the scroll behaves weird for
variation with omnibox_scroll_mode = quick. Without digging into the
root cause, this CL fixes issue by dynamically setting the margins in
code and skip setting top margins for OMNIBOX_ONLY variations.
(cherry picked from commit 2adbb514e789e76bcffd5b16c43806cdd4b09636)
Bug: 1091988
Change-Id: I88e8b9b0524c148879262e0250adf9b3c57777c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250934
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779650}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254342
Reviewed-by: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#715}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
MacPWAs: Fix popup windows
At some point, popup RenderWidgetHostViews stopped being told
which process they should appear in. Fix this.
Note that popups are strange in that the RenderWidgetHostView
doesn't have a parent WebContentsView, rather, it is just
the content view for the NSWindow.
Add a sentinel remote_cocoa::kInvalidNSViewId to specify to
RenderWidgetHostViewMac::MigrateNSViewBridge to indicate
that we shouldn't mess with the app-side NSView hierarchy.
(cherry picked from commit 8cad06d146efdcf92a30aee903cc79c1cdb59a19)
Bug: 1091179
Change-Id: I905877e7b306c9f648734e4a433859f7d636356c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242851
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#777880}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254354
Reviewed-by: Chase Phillips <[email protected]>
Commit-Queue: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#714}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[Merge M84] Use a handler owned by the UserEducationHelper to post async calls
(cherry picked from commit fd4986e32049fcf9eb903dad6e56018effaecadb)
Bug: 1096130
Change-Id: I39407684996e68de23752973182de12ffdb38682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249065
Commit-Queue: Vincent Boisselle <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779372}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253938
Reviewed-by: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#713}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.58
[email protected]
Change-Id: I364df1ea5f375bf76312e4765f9e22d8a34f773d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253283
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#712}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[ios] Dismiss container banner when manager changes.
When the InfobarManager will change dismiss the current Banner being
presented in order to avoid the banner to be dismissed when the manager
has already changed leading to some crashes.
(cherry picked from commit ad3766c9af61cf3363deee919a944068600c1e68)
Bug: 1054024
Change-Id: Ia85b09b0bff300887a896b1a1c0e5887735edaa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248859
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: Sergio Collazos <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779198}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252693
Reviewed-by: Bindu Suvarna <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Bindu Suvarna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#711}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Notification: Fix a crash in NotificationPlatformBridge.
The Android IPC INotificationManager.enqueueNotificationWithTag()
might be corrupted when we processing web notifications.
This CL only catches the exception, the root cause is still unknown.
[email protected]
(cherry picked from commit 6557eaea93140be6b7b791ef2e8ad1678efe481f)
Bug: 1077027
Change-Id: I180ff015031d38cb1ae0abbbde05a732e22cd153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247539
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Richard Knoll <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779067}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252629
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#710}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Updating XTBs based on .GRDs from branch 4147
[email protected]
Change-Id: I6f1bcb7aacaea9533c13e77695f25a30e2726fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252647
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#709}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Return a null EventForwarder if the WebContents are detached
(cherry picked from commit 5604fba599b9fb8be606634b568ff8ace3b29c46)
Bug: 1091191
Change-Id: I02f4b3c8f4e34928d53c70772fe8ab50a271de7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246992
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778884}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252687
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#708}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
M84 - OOBE - Marketing - Enable double opt-in countries
Enables double opt-in countries by default on the marketing
opt-in screen during OOBE.
(cherry picked from commit a2d52b74c4a36ef42956e57bec35db155559ad24)
Fixed: 1096091
Bug: 1090724
Change-Id: I0bfbd2d54e96058ebf4c7fa5b5742e03c83c290c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249999
Auto-Submit: Renato Silva <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Commit-Queue: Renato Silva <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779869}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252164
Cr-Commit-Position: refs/branch-heads/4147@{#707}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Adjust margins for start surface
1) Add a 16dp margin between the omnibox and "continue browsing"
section.
2) Add a 16dp margin between the recent tab card and the feed section.
Note that for OMNIBOX_ONLY variation, the grid tab switcher uses the
same parent view as the feed section. Thus, we only set the top
margin for above section when we are not in OMNIBOX_ONLY.
3) Add a 12dp margin between the omnibox and MV tiles.
(cherry picked from commit 7f32b159cdf139b6ffe3d8b46740af4f5aae0d0b)
Bug: 1091988, 1081326
Change-Id: Iff61993f80032246b5212cab9ba8f02090605650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247142
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Ganggui Tang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779043}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250949
Cr-Commit-Position: refs/branch-heads/4147@{#706}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Edit Quick-Answers Dogfood link
The current https go-link is not getting redirected properly. As
suggested in go/faq#keep-the-presentation-clean1 as a best practice, the
go link should be prefixed by either http or a complete goto URL for the
https version.
(cherry picked from commit 6b2ca09b0ed5465506b6ad6abedf8df7601ccc21)
Bug: b:159237992
Test: Tested on Chrome OS VM and Atlas test device.
Change-Id: Icb1e60a1dc057b6f5b64f064ac485303ea09edf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250823
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Abhijeet Singh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#779531}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248582
Commit-Queue: Xiaohui Chen <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#705}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
cherry pick vp9 svc fix to m84
Bug: 1095953
Change-Id: I4f658052229165a97d2e9a3bd7ddd7c0277820d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250935
Commit-Queue: James Zern <[email protected]>
Reviewed-by: James Zern <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#704}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Broadwell AFDO profile from 84-4147.33-1591611096-benchmark-84.0.4147.48-r1 to 84-4147.37-1592217301-benchmark-84.0.4147.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0a5014fe7fff35571b127a3a5600ff8dfa753d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251720
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#703}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Airmont AFDO profile from 84-4147.33-1591613874-benchmark-84.0.4147.48-r1 to 84-4147.37-1592213859-benchmark-84.0.4147.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iedfff7e30ea6eadb03ef6022dac54d35551ffa67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251722
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#702}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Roll ChromeOS Silvermont AFDO profile from 84-4147.33-1591611589-benchmark-84.0.4147.48-r1 to 84-4147.37-1592215428-benchmark-84.0.4147.53-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5ca8a8b10504de8096977ec4ce08ce5abbca24cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251719
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#701}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Fix Notification card layout for M84 branch.
This is a mini-patch that fixes issue 1093145 in m84 branch.
Issue on master branch is fixed by http://crrev.com/c/2218036 which
also moves lot of files around, that might make merging other fixes
more complicated.
Bug: 1093145
Change-Id: I0cb856514cf56c88f348712951ae1f1ff194f943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249741
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#700}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Updating XTBs based on .GRDs from branch 4147
[email protected]
Change-Id: I23e33735a4d187b8865694c749b50cfca00906fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251398
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#699}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.57
[email protected]
Change-Id: I69e9bac8a3374ef955872d5a7d6a5f59a2606fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251306
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#698}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[ios] Fixes a crash in -[CRWWebViewScrollViewDelegateProxy forwardInvocation:].
-[NSInvocation getArgument:atIndex:] fills its argument into a void* and
therefore doesn't trigger an ARC-synthesized retain. If the argument is
stored into a strong pointer, release is called when the pointer goes
out of scope, which causes the object to be overreleased. Annotating the
pointer as __unsafe_unretained avoids this problem.
BUG=1092875
(cherry picked from commit 460396a71d05e32b59944fdd65c677a307af4859)
Change-Id: I990c3878b9ab7d828ff17f3a3cf530059f7f5c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235656
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#776508}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249081
Reviewed-by: Bindu Suvarna <[email protected]>
Commit-Queue: Bindu Suvarna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#697}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.56
[email protected]
Change-Id: Ibe7c33665549bff579cda58432fe6dcaa31257e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251064
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#696}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Query Tiles : Tile width adjustment
This CL tries to fix the tile width. If the tile is too small, it cuts
the words into multiline, and if too big, it might push out the feed.
With this CL, we try to keep the tile width close to the desired width.
(cherry picked from commit c8f8322999797a4a3b70aa7647eb2f9024d15e2d)
Bug: 1092953
Change-Id: Iaf4f7c163d5b74b0cf83481f4958354e23de8687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238999
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778226}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250701
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#695}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions UI] Squashed: CLs for settings overridden dialogs
This CL is a squashed version of the remaining CLs needed to implement
the extension settings overridden dialogs in M84. Specically, this is a
cherry-picking of the following patches:
https://crrev.com/c07e466529166f0b1d4c77842c02a59b819551df
[Extensions UI] Wire the new SettingsOverridden dialog for search
https://crrev.com/8a1f9360606b04e7a9972a78c9e2c201f3b4e5b5
[Extensions UI] Add icon support to the Settings Overridden dialogs
https://crrev.com/ac7675e6030fb19a12bf65ac200d207519d302a3
[Extensions UI] Update manifest.json for search override test extension
https://crrev.com/a4e55e2e618b5555061fd04d6977e371b20a98c5
[Extensions UI] Add an indication when prompts close without user action
https://crrev.com/9d570a2219a817fd7a6a36f850896a171d235388
[Extensions UI] Customize the NTP overridden prompt for the default case
https://crrev.com/34f1b63dcb039babd1d543ad427fddfcb272988d
[Extensions UI] Customize the search overridden prompt
https://crrev.com/c35396269627703d75ce27f13c8087ad7004cb9a
[Extensions UI] Put extension name in "quotes" in dialogs
https://crrev.com/10e90b3383aa5fdbcb83c9860eac6a18991ecf44
[Extensions UI] Omit http in URLs in the search overridden dialog
https://crrev.com/51bdbc6722b8f2c6d1a9906c6baa0c74b3e708d8
[Extensions UI] Don't show the (x) button in settings overridden dialogs
Bug: 1079364
[email protected]
Change-Id: Ia9f19ad007125574edd104fb4167546bb9cef8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250821
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#694}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.55
[email protected]
Change-Id: I2b60683e6b067b1bee3f9b61e4ee15d0e5f9264d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251102
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#693}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Fix UA String on some Windows architectures
The CPU Info part of the UA string was recently accidentally changed
from "(Windows NT)" to "(Windows NT; )" on Windows architectures where
we don't have a CPU type. This change fixes that and adds some UA
string unit tests to help detect similar changes in the future.
(cherry picked from commit 875bfc0d0700531cf0887e508f23798734635ec1)
Bug: 1093636
Change-Id: I4fb62cb00256936d0cb8d480b7f7297c65735e37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242083
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Nicolas Arciniega <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778385}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246871
Reviewed-by: Nicolas Arciniega <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#692}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[Merge M84][WebLayer] Prevent potential race condition when changing Safe Browsing enabled state
MERGE to M84
Prevent potential race condition for two member variables in
SafeBrowsingService and UrlCheckerDelegateImpl when calling
SafeBrowsingService::SetSafeBrowsingDisabled from a non-IO thread.
The call normally happens on the UI thread when called via
Profile.java.
The class member |safe_browsing_url_checker_delegate_| is created
on IO thread (in SafeBrowsingService). The |safe_browsing_disabled_|
variable is read on IO thread (via
UrlCheckerDelegateImpl::ShouldSkipRequestCheck).
This patch ensures that the variables are set/read on one thread
to prevent potential races.
BUG=1083376,1094371
(cherry picked from commit 3011d4a94d3904a20cacaa44617adfa076aa31ea)
Change-Id: Icf4171add896bae390bb1a020be94f636fee5ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243220
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Tim Volodine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778812}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250100
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#691}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[StartSurface] Match tab carousel and feed headers style
Screenshot:
https://drive.google.com/file/d/1_g3SYeCLpNEYzpbWOmw4H1MUguUf5n86/view?usp=sharing
(cherry picked from commit 9dc2f6b97c94a13fc7c0109f188230803d5d1979)
Bug: 1091986
Change-Id: Ic4b0d4042af97eab5fa922e8b308c32dcf8ee4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240958
Commit-Queue: Ganggui Tang <[email protected]>
Auto-Submit: Ganggui Tang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778401}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250782
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#690}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
VaVDA: Use BufferAllocationMode::kNone for H.264.
This CL enables H.264 decoding with BufferAllocationMode::kNone. The
main blocker for enabling this was increased CPU consumption due to busy
work when there is an available surface but the corresponding picture
buffer has not come back from the client (see [1]).
This CL does not eliminate this busy loop. Instead, it makes sure that
the number of requested buffers is at least 13 (picked to imitate the
value returned by VP9Decoder::GetRequiredNumOfPictures()). This makes it
more likely that the decoder can get a buffer without waiting on one to
come back from the client.
As validation, this is the output of dump_intel_rapl_consumption while
playing
http://crosvideo.appspot.com/?codec=h264&resolution=1080&loop=true on an
i7 eve (with the new VD disabled):
Before this CL:
========================================================================
package-0 core uncore dram psys
2.667667 1.359338 0.188050 0.860169 2.832958
1.492605 0.466284 0.179845 0.761450 1.859494
2.465552 1.333110 0.173884 0.826528 2.429251
1.836305 0.701381 0.175284 0.825935 2.083826
1.397930 0.331338 0.175203 0.764998 1.783907
1.453937 0.396079 0.175568 0.762897 1.804858
1.617633 0.551016 0.172171 0.770288 1.930921
1.398794 0.377560 0.178041 0.762288 1.761070
1.309214 0.300763 0.171568 0.748048 1.685083
4.094596 2.987037 0.221237 0.785434 3.152690
After forcing BufferAllocationMode::kNone without any other changes:
========================================================================
package-0 core uncore dram psys
10.091497 8.403499 0.137035 1.066655 6.793493
6.107595 4.291023 0.142334 1.282748 4.898286
4.173701 2.382291 0.132389 1.202908 3.855559
4.276854 2.500189 0.126471 1.216745 3.911385
4.716722 3.027957 0.134404 1.154900 4.138097
4.547350 3.342606 0.137797 0.721388 3.806403
5.852608 4.761959 0.133650 0.685367 4.167034
6.440512 5.366580 0.130992 0.692277 4.334328
6.471564 5.462571 0.135755 0.610058 4.239434
6.522625 5.574209 0.130200 0.602120 4.179017
After this CL:
========================================================================
package-0 core uncore dram psys
7.261862 5.491319 0.183383 1.410826 5.420041
5.723818 3.829009 0.142398 1.491444 4.720379
4.364147 2.652774 0.137776 1.144099 3.956767
1.597286 0.459902 0.141311 0.751768 2.134646
1.428828 0.465833 0.140055 0.718547 1.791793
2.307202 1.213556 0.141450 0.792714 2.334663
1.753186 0.647150 0.136820 0.764778 2.088220
1.276018 0.308548 0.134811 0.728569 1.546158
1.285961 0.308340 0.140440 0.719776 1.522937
1.579406 0.594378 0.131040 0.720050 1.698702
Note that according to top -d 0.5, the CPU usage of the GPU process
hovers at around 20%.
========================================================================
Therefore, increasing the number of required buffers allows us to enable
kNone without regressing on power consumption.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=910986#c32
(cherry picked from commit b6c6ab7409c935fbcfd3489996eb5eec139960c3)
Bug: 910986, 1054097
Test: dump_intel_rapl_consumption on eve while playing 1080p H.264.
Change-Id: Ib1aa566e2af54439d9c6c3339c522758c5f699a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246846
Reviewed-by: Miguel Casas <[email protected]>
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778890}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250781
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#689}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[Merge M84][WebLayer] Ensure version and thread checks for Profile.{set/get}BooleanSetting
MERGE to M84
Ensure API checks (M84) and UI thread checks for setBooleanSetting() and
getBooleanSetting() Profile methods.
BUG=1083376
(cherry picked from commit c9421ce7bcc8123008ea22a2509b633801a2efac)
Change-Id: I6addddd65a8d9b4074e06274d9d4615455d5df87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242081
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Tim Volodine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#777932}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250179
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#688}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Updating XTBs based on .GRDs from branch 4147
[email protected]
Change-Id: I23bf10e130af7e85ec6e9b47115b81d5363da348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250500
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#687}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions UI] Wire up a feature switch for settings overridden dialogs
Introduce a feature switch, kExtensionSettingsOverriddenDialogs, to
control using a dialog-based UI instead of a bubble-based UI for the
post-install confirmations related to settings overridden by extensions.
Wire this up for use with the NTP overridden flow, set to display at the
same time the bubble would normally show. The two are mutually exclusive
and perform the same actions: the user can acknowledge the extension,
disable the extension to go back to the old settings, or dismiss the
dialog without making a choice (which will cause the dialog to re-show
in a future session).
Update the browser UI test for the NTP overridden dialog to exercise
this flow (rather than force-displaying the dialog).
Bug: 1079364
Change-Id: Ic222f0db666856f0d5baa7156bf7e49e7c4de482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196645
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#769086}
(cherry picked from commit 5739bf0ac3fb8272c6be7ed7e47152bffd4aa3f7)
[email protected]
Change-Id: I07a86e69a79cc0e162eaf448129217590c9c4c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250085
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#686}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[iOS] Merge of: Simple mitigation for crash in -notifyForeground:
See the linked bug; under some circumstances, when the scene APIs are
*not* in use, [SceneController sceneState:transitionedToActivationLevel:]
is called with an SceneActivationLevelForegroundActive activation level
but without a the maininterface having a browser state (perhaps because
there is no main interface).
This simply bypasses the crashing call in this case (and the remainder
of the method is a no-op, since it all depends on the SceneState APIs
being used).
(cherry picked from commit 32b05b96ed5cd04adc5571466d9f40136575947a)
Bug: 1092326
Change-Id: Id0ab8427ba1d1a459345c2ebc20375ea19881bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246678
Auto-Submit: Mark Cogan <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778358}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249979
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#685}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
[M84][Extensions UI] Add an NTP-specific settings overridden dialog
Add a specialization of the settings overridden dialog for extensions
that override the New Tab Page. This involves adding a generic
controller for the settings overridden dialog to handle extension-
controlled settings (which will be re-used for additional controlled
settings) and an NTP-specific provider to handle the NTP bits.
Add unit tests for both the NTP-specific provider and the generic
extension-controlled settings dialog controller, and a UI browser
test for the NTP overridden dialog.
Currently, this is only used in testing; it is not hooked up to any
production codepaths.
[email protected]
(cherry picked from commit d6cd57f69e4c9f0ad832d80b7d86615a7af9c176)
Bug: 1079364
Change-Id: I1f360bd603b6514fb492acc0b065d1b6d5236a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186642
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#769024}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249395
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#684}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Revert "Restore mic gain on CrOS restart"
This reverts commit 5cafeca28d0c2bfd78c11d48634f9fc09e7d619b.
Reason for revert: regression - causing large mic gain
Original change's description:
> Restore mic gain on CrOS restart
>
> This change reapplies the mic gain value when the device starts up.
>
> Previously, the stored pref value was not applied on startup, so the UI
> and the underlying audio service were out of sync.
>
> Bug: 1083149
> Change-Id: I422beb14f439ddd0fc36737e677125a48a0c9bd6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208092
> Auto-Submit: Bailey Berro <[email protected]>
> Commit-Queue: Jenny Zhang <[email protected]>
> Reviewed-by: Jenny Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#769926}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit dd25682ccf7e5e7b2b60a620315766a55343412c)
Bug: 1083149, 158677629
Change-Id: I8dd419d50177b68db3c751016ceba5fade7f721e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245493
Reviewed-by: Hsinyu Chao <[email protected]>
Commit-Queue: Hsinyu Chao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#778196}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249240
Cr-Commit-Position: refs/branch-heads/4147@{#683}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Incrementing VERSION to 84.0.4147.54
[email protected]
Change-Id: I1a9af274d08c5eae9501ddbaebc76cab4b370e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249084
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4147@{#682}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
M84: Reland: Add a new PrintRasterizationMode policy.
Revert https://crrev.com/771643 to reland the PrintRasterizationMode
policy. This new Windows-only policy controls the
PrintWithReducedRasterization feature.
Speculatively fix the crash that triggered the revert.
(cherry picked from commit d4d328db95da1e8dc8acde66760ed9a409082cdc)
Tbr: [email protected]
Bug: 674771,1083911
Change-Id: Ie1dac04cfa18edb5c5f1e2cadf07060777e4cc82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232103
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#777392}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248723
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#681}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
Base browser width on tabstrip minimum width for Win7
[email protected]
(cherry picked from commit 237dd4a47c3212eb2e8f58ed71f404e085629c5a)
Bug: 1082513
Change-Id: Ic7b628f2a81b461bd9b7649e47f9d81619e21eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220700
Reviewed-by: Collin Baker <[email protected]>
Commit-Queue: Taylor Bergquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#773883}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248351
Reviewed-by: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/4147@{#680}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}
