Publish DEPS for 81.0.4044.43
Incrementing VERSION to 81.0.4044.43
[email protected]
Change-Id: Ie549c23a34f619770e3d1ca80ea26e36919c7cff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086054
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#620}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
media/gpu/vaapi: Fix compile error due to VA_FOURCC_NV12 type
crrev.com/c/2041382 can cause a type difference error on some
build environment. This fixes the compile error.
Bug: 1057857, 1050377
Test: Compile chrome
Change-Id: Ia4e20a3f19599f0b849d591ac07d043ce16ef84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082429
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#619}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Update UX text per feedback
(cherry picked from commit 2ca33333554cd632fba624587b6d26dfd8d5cc17)
Bug: 1055977
Change-Id: I1ae0c0bb08dd7ca7e995ab0190f52b019e7c6c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073005
Reviewed-by: Rakesh Soma <[email protected]>
Commit-Queue: Rakesh Soma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744911}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086651
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#618}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Media Router] Fixed auto-join for Cast sessions.
The previous code was written using the mistaken assumption that
only mirroring sessions should have a tab ID. This had the effect
of making it impossible to re-connect to a casting session after
refreshing the tab.
(cherry picked from commit 4c6d3365033abe508e965c9edfb2aaa727721d8b)
Bug: 1054491
Change-Id: Ic8ec2946af8ad28c8cea8c0698c1644c46ff5a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078795
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: John Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086298
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#617}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.42
[email protected]
Change-Id: Ia2c86139ba331a0de1e2bc86833237404b171dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086053
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#616}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[AW] Collect Variations.DownloadJobFetchResult from WebView's service.
This metric stores the same values as
Variations.FirstRun.SeedFetchResult, but stores results for all WebView
seed requests, rather than Clank's first-run request.
See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details.
(cherry picked from commit 6f9aed83200a2af7510f0cf6b817f4881381a9cb)
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'AwVariationsSeedFetcherTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedServerTest#*'
Test: Manually verified correct metrics were being recorded by adding
Test: logging when recording the metrics.
Bug: 1047536
Change-Id: I6fa65abdab6e22f5e5eaee173b6fbd67b5c30ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067275
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744443}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085841
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#615}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[AW] Collect Variations.DownloadJobInterval/DownloadJobQueueTime from WebView's service
This is a followup to crrev.com/c/2039812, which adds the
Variations.DownloadJobInterval and DownloadJobQueueTime metrics. See
doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw for more details.
(cherry picked from commit fc92516fe90a5a5e98171f740bda9bb6d6c1af0e)
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'AwVariationsSeedFetcherTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedServerTest#*'
Test: Manually verified correct metrics were being recorded by adding
Test: logging when recording the metrics.
Bug: 1047536
Change-Id: Icf8604eda3fe6c649cfcd9fb4f7135e16643417a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040052
Commit-Queue: Robbie McElrath <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085840
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#614}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[AW] Fix bucket distribution in Variations.DownloadJobFetchTime.
crrev.com/c/2039812 Added the Variations.DownloadJobFetchTime metric,
which was written via TimesHistogramSample. That class only supports
durations up to 10 seconds, which isn't sufficient for that metric. This
CL replaces that histogram with Variations.DownloadJobFetchTime2 (you
have to create a new metric when changing a histogram's bucket
distribution) that can store durations up to 20 minutes, which is twice
the time Android allows for jobs to execute.
(cherry picked from commit 12fea389221db65ca0cbe1d3d1071d80f55c6752)
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Bug: 1047536
Change-Id: If29da67690ba7ab10339cee76dac993f48581b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067546
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743403}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085698
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#613}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[AW] Collect Variations.DownloadJobFetchTime from WebView's service.
This CL makes WebView record a new Variations.DownloadJobFetchTime
metric from WebView's service via a new IVariationsSeedServerCallback
AIDL interface. See doc/1qNASRaqCeRdpbH84IpqsSPzR8R8U6M-sUyHeAZCVrzw
for more details.
(cherry picked from commit d9f30b4c6765579738af8b3ebbe6039f32526ad4)
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'AwVariationsSeedFetcherTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedLoaderTest#*'
Test: out/aw/bin/run_webview_instrumentation_test_apk -f \
Test: 'VariationsSeedServerTest#*'
Test: Manually verified correct metrics were being recorded by adding
Test: logging when recording the metrics.
Bug: 1047536
Change-Id: Id1d1e64424036de1cf51250d2d0f9f60b9ae4696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039812
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741702}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085839
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#612}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix for the Assistant voice search service being null
Returning early from the function if the service is null to guard
against a potential race condition affecting beta.
(cherry picked from commit f96a690f6bdc3df1afc4a8b485ba6e3692aae302)
Bug: 1055274
Change-Id: Ibb419037e67b2bce7cc31b3f0371ed1264ca01fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070823
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744450}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085603
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#611}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Hold source texture in SharedImageBackingEglImage
It seems like on NVidia keeping reference to eglImage itself is not
enough. When all siblings get deleted all future siblings texture
are corrupted (like driver reuses this texture memory).
This CL adds gpu driver workaround for NVidia to keep one sibling for
the time of SharedImage is kept alive by client. After client calls
DestroySharedImage this extra sibling is deleted allowing to clean up
memory. As SharedImageBacking is kept alive only by representations
after this moment there always will be at least one sibling inside them
to prevent bug to occur.
(cherry picked from commit 9435d5bf3fc0a144aac7614676398e0f97a048df)
Bug: 1052114
Change-Id: Ie1714e1f696e4e59cc5fba12c15e421f694f1a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080488
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#746076}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085693
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#610}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Check for view nullptr to prevent a crash
(cherry picked from commit ed77a1a86588f3be39d57fc6f5e84bcd7151cad4)
Bug: 1045954
Change-Id: I1a52383a4b3240fdb87d93e07dd312385bca0156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071285
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Navid Zolghadr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744838}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085834
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#609}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Make sure to init Mac's VideoToolBox before GL
Otherwise this leads to crashes in VTDecompressionSessionCreate.
The CL http://crrev.com/c/2013806 changed the order but
the intention was to fix an issue on Linux/Wayland. So
restore the previous behavior on Mac. Also restore the
previous behavior on other operating systems to make the
change safer. And guard the new order with OS_LINUX.
(cherry picked from commit 0edbea47b4cbbfd15f3a687cf539200590571152)
Bug: 1047643
Change-Id: I9637a684996ee095d32a336610cb65a7d0d20370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068207
Reviewed-by: Maggie Chen <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Julien Isorce <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744001}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085672
Commit-Queue: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#608}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Update Omnibox content with selected suggestion only.
This CL addresses a bug, where Omnibox content would occasionally get
updated with the inaccurate content when browsing the suggestions
using Keyboard.
(cherry picked from commit 6f807ad1afaa618950523cf124db7967b48cfa81)
Bug: 1054399
Change-Id: Ic00d8e2b6bbf6680de56ca78cfacf4a25d5f8b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081890
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Ender <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#746160}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085692
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#607}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
đ€ Fix launching TWAs from notifications.
While moving Chrome over to androidx.browser, Strings representing
package names were replaced with Tokens that represent package names
and their signature. Strings have hashCode overridden to provide value
equality whereas Tokens don't, so checking for the existence of an
equivalent Token in a Set of Tokens doesn't work.
This change manually looks through the set of Tokens and calls
Token#matches on each one.
(cherry picked from commit c06669aa7091c0c367682a77985cca1928121935)
Bug: 1052288
Change-Id: Ia2ad8bf3272853acbd07ae36aad33e9c78fb9e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078548
Commit-Queue: Peter Conn <[email protected]>
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745414}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085694
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#606}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: I53a6a74a5f4590b54f1586efc2a13801bd8f26c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085394
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#605}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Check 3rd-party cookie blocking in HaTS survey launching process
(cherry picked from commit af73aedef56acbf3ea2065f2ce2a338509e6537e)
Bug: 1055860
Change-Id: Iff0c883b02c9edf7c553db97ecf33692eed8ca24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074697
Commit-Queue: Huanzhong Huang <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Wei Li <[email protected]>
Reviewed-by: Martin Ć rĂĄmek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745607}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085256
Reviewed-by: Huanzhong Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#604}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
EndDrag should use weak_ptr for its arg
As WebContentsViewAura::EndDrag can be arbitrary delayed waiting for the
renderer process to perform asynchronous targetting, it should use a
weak pointer for the RenderWidgetHostImpl argument.
(cherry picked from commit 181802cc1c5d7e10460c122b3300976d0315492f)
Bug: 1034519
Change-Id: Ib8c785d3c54b448dc4b020b11112b65ced3d4261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978000
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Navid Zolghadr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744297}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085691
Cr-Commit-Position: refs/branch-heads/4044@{#603}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.31-1583149048-benchmark-81.0.4044.40-r1 to 81-4044.31-1583149048-benchmark-81.0.4044.41-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6affbf79a0a2f3e2703f0e3a172b1887ebccdfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085771
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#602}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.31-1583147710-benchmark-81.0.4044.40-r1 to 81-4044.31-1583147710-benchmark-81.0.4044.41-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0378a69f9daf31d6b0afef96f67e7bdefb0bbe77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085712
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#601}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.31-1583146927-benchmark-81.0.4044.40-r1 to 81-4044.31-1583146927-benchmark-81.0.4044.41-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic066455c1cf8ab39950ae24e5b478d0f61709b37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085613
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#600}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] Legacy TLS: Lookup control sites by eTLD+1
(cherry picked from commit fdf6c9682d5bdf3ed14927065a6b24f9c3a3eec0)
Bug: 1055906
Change-Id: I974c8cc5993299a6611c4bd14f515c865d9bef02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073218
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745226}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080894
Reviewed-by: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#599}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add more checks for subresource redirect
Adds checks for whether navigation is committed and only for http/https
navigations.
(cherry picked from commit 2175104286a730d55d641c8cdb013aa7bfe070ef)
Bug: 1055573
Change-Id: Ib65801efbe1cd66362c885e5b2f0442de65aa918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078784
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: rajendrant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745280}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085837
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#598}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland "Don't disable draw during resize"
This is a reland of 985a1f4190e3f7fbbe250bb73d332d233942d289. Also fix
an issue where SoftwareOutputDeviceWinProxy was crashing if we draw the
root RenderPass but never call SwapBuffers() as the |swap_ack_callback_|
wasn't set.
Original change's description:
> Don't disable draw during resize
>
> https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to
> also block draw instead of just swap. This had the side of effect of
> blocking draw when the browser window is minimized, which means we stop
> casting tab/window contents. Switch DisableSwapUntilResize() back to
> just block swap instead of draw+swap.
>
> Bug: 1054239, b/149923568
> Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642
> Commit-Queue: kylechar <[email protected]>
> Reviewed-by: Saman Sami <[email protected]>
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#744018}
[email protected]
(cherry picked from commit 00e1b9032aa98eec0634fe05dc2596f331de379c)
Bug: 1054239, b/149923568
Change-Id: I4f96bcb9547f4c4b24c020ffff728e4fa08d0ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078840
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745161}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082315
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#597}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] Special case CERT_STATUS_LEGACY_TLS in Page Info
This special-cases the LEGACY_TLS status in Page Info on Desktop so that
it doesn't cause the certificate to be marked as "Invalid". This also
updates the identity status logic to always check and mark legacy TLS
pages so that we use the more specific security summary text (which
refers to outdated security configurations specifically) for sites that
use legacy TLS.
(cherry picked from commit e8704be0f8569bf95f900636da2835bc3fe040d5)
Bug: 1056376
Change-Id: I399b79832ba6ffd0b82f8906bc09afe0576c198b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076517
Reviewed-by: Mustafa Emre Acer <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744883}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080892
Reviewed-by: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#596}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Merge to M81: Revert "Re-land: Fire live region events when a node is removed."
This reverts commit 16ce044f817f76400ae738157bb4b7d855c80932.
Reason for revert: crbug.com/1055393
Original change's description:
> Re-land: Fire live region events when a node is removed.
>
> Adds an AXLiveRegionTracker class to keep track of live regions
> in an AXTree. Uses it to fix a bug where we weren't firing the
> LIVE_REGION_CHANGED event on the live root when a node was removed,
> only when a node was added or changed.
>
> I'm going to follow this up with code that optionally computes
> the text of a live region change, that we can use on Android,
> Chrome OS, and some older versions of macOS. So AXLiveRegionTracker
> is simple now, but it will be a convenient place to put that
> logic.
>
> Originally landed as https://crrev.com/c/1464325, but reverted
> due to a UAF. The issue was that in LiveRegionTracker we were
> keeping track of a mapping from node to live region root, and
> when a node was deleted from the tree we were deleting it from
> the key of that map, but we also needed to delete it from the
> value. We do that now by temporarily keeping track of a set of
> deleted node IDs.
>
> Bug: 560599, 930763
> Change-Id: I2005656fb50a208b00f744def828ce8db2134be1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988742
> Commit-Queue: Dominic Mazzoni <[email protected]>
> Reviewed-by: Kevin Babbitt <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#737100}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 5f8592f7c985a5fd89d59537d4b016ffca242f12)
Bug: 560599, 930763, 1055393
Tbr: [email protected]
Change-Id: I444faccaa5e444ec4093967f2d974045c4a84b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071593
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744218}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082316
Cr-Commit-Position: refs/branch-heads/4044@{#595}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.25-1582542493-benchmark-81.0.4044.39-r1 to 81-4044.31-1583146927-benchmark-81.0.4044.40-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I25191b9f9f55fb4a91b5d20780ea3426a2a4fa4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085020
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#594}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[ios] Return early if Webstate is not valid in InfobarContainerMediator
If the webstate is nil or if it's not the active webstate, then
it is likely that the BadgeTabHelper is not valid, so return early.
This change also ensures that all InfobarCoordinator blocks
use weakSelf in calls of InfobarContainerMediator
[email protected]
(cherry picked from commit 0b0c1ea55c7b85f3558b03209a10cb51556cabc1)
Fixed: 1055908
Change-Id: Ic68ee9950ce928f1143981425cbac934057bbe64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075300
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745061}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081629
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#593}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Remove future flag from PrintingSendUsernameAndFilenameEnabled
(cherry picked from commit e298afd520c57dfbc8d75e026f9cf26906b40c81)
Bug: 1054425
Change-Id: I9365f76d33657c1208f735769a8b482a89d346f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066741
Commit-Queue: Vladislav Kuzkokov <[email protected]>
Commit-Queue: Sergey Poromov <[email protected]>
Auto-Submit: Vladislav Kuzkokov <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743144}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081423
Reviewed-by: Vladislav Kuzkokov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#592}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix hang-report field in hang crash reports.
hang-report field was done asynchronously and too late to be
consistently present in the crash reports.
It seems that the flag was only present in case of a second freeze.
Set the flag synchronously before generating the crash report.
(cherry picked from commit d95c1de3a85dd6d79ee1078789ad3aa939c08763)
Bug: 1056178
Change-Id: Ia7958c61a01dd9ffa592f3ba6b86481b50e8c89d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074220
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745478}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082920
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#591}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Disable FormControlsRefresh by default.
By request from Enterprise, this will re-disable the FormControlsRefresh
feature. (See [1] and [2].) FormControlsRefresh will now be launched
in M82.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1967608
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2063530
Fixed: 1057669
Change-Id: I8e531ac540240eb823284683b4abc9dee8b6a6ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083735
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#590}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[TTS] Add preserve-tap arm for the longpress exper
Adds another experiment arm for preserving the Tap gesture, in case
users get confused during the transition to long-press. This will
let us evaluate the difference between preserving and just switching.
This changes the default to ONLY recognize longpress rather than both.
Note that Privacy wants only one gesture to fully launch, so we are
doing this as a fallback in case both need to be supported during a
user-education timeframe.
BUG=956277, 1048827
(cherry picked from commit c0a33cbf2b91e59a55b4ac00dbcabaa4c016ed28)
Change-Id: I1b42d86bbd9cdc7e0a58bafb8a796601ae0cb353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076338
Auto-Submit: Donn Denman <[email protected]>
Commit-Queue: Theresa <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745051}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083625
Reviewed-by: Jinsuk Kim <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#589}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Merge "Speculative fix for crashes in ~FileChooserImpl()" to M81 branch
FileChooserImpl can outlive ListenerProxy. We should clear
FileChooserImpl::proxy_ on ~ListenerProxy().
This CL has no tests. We don't know how to reproduce crashes.
(cherry picked from commit 728c6deeffe1f266bd1639806dd9a27b79e81b1a)
Tbr: [email protected]
Bug: 1054260
Change-Id: I2be7a8957f2f725c51081961357ef09f6dabb823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067819
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Matthew Denton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082868
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#588}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Set the proper size of WallpaperViewShield
During the debug, I've just come to realize that the shield layer
of the wallpaper view is zero-sized; so it does not make any
visual effects. It needs to set bounds on creation.
(cherry picked from commit 610cb90e96fed195790f1d788f752e5238a783d0)
Bug: 1036804
Test: manually
Change-Id: Ifa2dea70424355db12741f7d4bf41b8b3ce8bffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080885
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745701}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082021
Reviewed-by: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#587}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.41
[email protected]
Change-Id: I10bd6c0c6f979938c0bbd69750a2bb2450124143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081840
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#586}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Properly update tab strip for tab selection
Currently, when user uses swipe gesture to switch from a single tab to
a tab in tab group, the tab strip doesn't show up. This is due to this
tab selection doesn't fire a reset tab strip event. This CL fixes this
issue and adds tests.
(cherry picked from commit dfa14881179ea4576d59d9c1999ad27f5057eeec)
Bug: 1048824
Change-Id: I05ad51709eb6274afc41f4fc6ddbd8ce396640a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037844
Reviewed-by: Wei-Yin Chen (éłćšć°č) <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738391}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083743
Reviewed-by: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#585}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Advertise a VideoFrame's visible size as the coded size.
This CL fixes the VaapiVideoDecodeAccelerator to advertise the visible
size as the coded size for decoded video frames. Here's the background:
CL:2011583 changed the VA-API decoding pipeline so that the EGLImage
backing a VideoFrame's service-side texture is created using the visible
size instead of the coded size. This is correct because the graphics API
does not care about the non-visible area. This was done to avoid a green
line error: making the size of the EGLImage equal to the visible size
allows the texture sampler to not sample beyond the visible area, so the
green line (part of the non-visible area) is avoided.
The problem is that the coded size of the VideoFrame sent to the client
still contained the non-visible area. This is arguably strange because
as far as the client is concerned, this non-visible area does not exist.
This was also causing problems when PaintCanvasVideoRenderer requested a
copy from the VideoFrame's texture: the coded size was bigger than the
visible size used to create the EGLImage. This caused black images to be
displayed some times (e.g., thumbnails of videos in the Camera Capture
App) because the GL commands sent from the client didn't pass validation
in the service side (e.g., "GL ERROR :GL_INVALID_VALUE :
glCopySubTextureCHROMIUM: source texture bad dimensions").
This CL changes VaapiVideoDecodeAccelerator so that the coded size of
the VideoFrame only includes visible data.
Additionally, it is possible for a decoded frame to end up as an overlay
plane. In that case, the size of the DRM framebuffer should match the
visible area of the frame. This is important so that the non-visible
area doesn't appear in the overlay path. Therefore, this CL plumbs the
desired framebuffer size all the way through Ozone.
There is a caveat, however: there is an unusual corner case where an
H.264 video includes information about a visible rectangle whose origin
is not at (0, 0). Therefore some of the top and left parts of the video
should not be displayed. However, Chrome does not currently deal well
with this case, and this CL doesn't change that (i.e., those non-visible
areas are still displayed).
Note: follow-up CLs will deal with V4L2 and the VideoDecoder interface
variations.
(cherry picked from commit f0148a8bc8c740b439144a2049e6662101b6c0c6)
Bug: 1045597
Test: Record video in nocturne's CCA and inspect thumbnail.
Change-Id: I92ef73310ff651deeb5c613f7c798d509f8d27d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056285
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744799}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083757
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#584}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Remove original content of SelectableItemView for SelectableTabGridView
http://crrev.com/c/2024495 makes SelectableItemView inflate
modern_list_item_view in its onFinishInflate(). However, even though
SelectableTabGridView extends SelectableItemView, it doesn't use the
views within it. Thus, this CL removes content from SelectableItemView
right after it is inflated to ensure the UI is correct.
(cherry picked from commit 1a8fd934e0423f3b4f3c2f4dfc60b6f1c4cd95c7)
Bug: 1047595
Change-Id: Ia4da1559c039be95a6463368c642b3c53f4f7c90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033805
Commit-Queue: Yue Zhang <[email protected]>
Auto-Submit: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (éłćšć°č) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738401}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083991
Commit-Queue: Wei-Yin Chen (éłćšć°č) <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#583}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: I0d418ac26416e74fb1a5700e64938fb5f2a73a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082090
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#582}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[merge m81] gpu: Avoid SharedImageBatchAccessManager deadlock
SharedImageBatchAccessManager has a lock, and
SharedImageBackingEglImage has a lock. There are cases where one lock is
acquired while trying to acquire the other, and the order is not
guaranteed, leading to deadlock in under the right circumstances. In
particular:
* On one thread, SharedImageBatchAccessManager::EndBatchReadAccess calls
SharedImageBackingEglImage::SetEndReadFence. This acquires the batch
lock first and the backing lock second.
* On another thread, SharedImageBackingEglImage::EndRead calls
SharedImageBatchAccessManager::IsDoingBatchReads, which acquires the
locks in the opposite order.
If the same backing is being read on two threads and both managed to
acquire the first lock, then this leads to a deadlock.
Fix by not holding the backing lock when calling into
SharedImageBatchAccessManager.
(cherry picked from commit bceafa430752c49702cb71be041639a70a5e8610)
Bug: 1043566,1046101
Change-Id: I6d6f8031443f41f775eb87287fdcebf28c4fc8e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078746
Reviewed-by: Khushal <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Khushal <[email protected]>
Commit-Queue: Bo <[email protected]>
Auto-Submit: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745518}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083592
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#581}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[m-81] Show back button when IME is showing
This was broken a while ago but went unnoticed.
We should show the back button, pointing downwards, so users can get out
of the ime VK.
Another change will be landed for M-82 (ToT as of this writing). The
M-82 change will be different because we have to account for removing
the navigation buttons, which is enabled in default in M-82.
Bug: 1056334
Change-Id: I170f1c24fc405d7ff322ada5a9816cde4e198078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079266
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Manu Cornet <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#580}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.39-r1 to 81-4044.31-1583147710-benchmark-81.0.4044.40-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8a8721c4609a53a7d71fe2eb57331b310a1e77b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083730
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#579}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[WebNFC] Enable feature flag by default for Origin Trial
For the WebNFC Origin Trial the feature flag needs to be enabled by
default and configured as "disable only" in runtime_features.cc so that
it can still be used as a kill switch but will not enable the feature
on sites which don't have a valid Origin Trial token.
(cherry picked from commit 22b25dd3ed41103f391b1df49a97603eeab19769)
Bug: 1035048
Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198
Commit-Queue: Reilly Grant <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743309}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083734
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#578}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.25-1582540974-benchmark-81.0.4044.39-r1 to 81-4044.31-1583149048-benchmark-81.0.4044.40-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic02850a0f6fa5d9ac280c1d6ff521f48883d94d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083793
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#577}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.39-r1 to 81-4044.31-1583146927-benchmark-81.0.4044.40-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6bbe048235133a87ad287307d8f4c0ddad4c1d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083792
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#576}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Allow CrowdDeny update checks over HTTP.
Integrity of the check is still guaranteed by CUP.
The check will no longer be confidential of the check.
Bug: 1057341
Change-Id: I0b3f31a5797c24294dc8f9a782bddf2d98d3dc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081238
Reviewed-by: Sorin Jianu <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#745761}
(cherry picked from commit 64aa728b59e5f71e617c16462346020539079653)
[email protected]
Change-Id: I0b3f31a5797c24294dc8f9a782bddf2d98d3dc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083054
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Joshua Pawlicki <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#575}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[WebNFC] Check if NFC Settings intent can be resolved
This CL fixes a crash on some samsung android devices where the link
between ACTION_NFC_SETTINGS and the NFC settings-menu is broken. NFC
settings intent is only returned from now on only if we're confident
activity can be opened, to prevent an android java exception
"android.content.ActivityNotFoundException".
See https://developer.android.com/guide/components/intents-common
(cherry picked from commit 6792f109d01d0b4954517489d3a5ab3fa70a1217)
Bug: 1035048, 1055216
Change-Id: Ibedd48cf9aded28def53753275747c4addaa220a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072158
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: François Beaufort <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745013}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083672
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#574}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[WebNFC] Re-check permissions in the browser process
This change adds an NFC permission check in NfcHost and ensures that the
Mojo connection passed to the renderer is scoped to the lifetime of the
RenderFrameHost which brokered it.
This ensures that if the renderer navigates or the tab is closed the NFC
connection will be broken immediately, even if for some reason the
NfcProxy in the render process is not garbage collected. The connection
is also closed immediately if the user revokes NFC permissions.
(cherry picked from commit afbe2244300a07412f1735a764be7342b2ad71ba)
Bug: 1035048, 1047838
Change-Id: I73d05c112674a82dd15146403e4ad03765ee1fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051384
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Oksana Zhuravlova <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743254}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081520
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#573}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
OOBE - Allow the status area for powerwash screen
Removed the powerwash/reset screen from the list of screens for which
the status area will be hidden. This issue only came to light once the
functionality of hiding/showing the status tray became possible for the
Mojo-based version of LoginDisplayHost -- LoginDisplayHostMojo. This
functionality was added in https://crrev.com/c/1926481
Hiding the status area prevents the user from accessing many options
that could be necessary, such as networking and accessibility.
(cherry picked from commit f16e4b9b36120317a9e5abbf54acbfea1e5165fb)
Fixed: 1045848, 1045851
Change-Id: Ib8b21c6be9587ef4c0c484c23bac0c1150afaa04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031039
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Commit-Queue: Renato Silva <[email protected]>
Auto-Submit: Renato Silva <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737808}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083144
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#572}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Android] Pass fully initialized view to accessory adapter or exit
As described in the linked bug, the adapter assumed WindowAndroid to
never be null which causes a crash.
With this CL, the view will be initialized early on and if WindowAndroid
is nullptr, the creation of the view (and the adapter) will be aborted.
To do that, the unused constructor parameters for label width and length
were removed.
(cherry picked from commit 310a7020eb3e6fe48ad1250378d7b22ee9f5076c)
Bug: 1048849, 1049090
Change-Id: I60151a560907a984ba4e45ee949624400b8f86da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037672
Commit-Queue: Friedrich [CET] <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738564}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083303
Reviewed-by: Friedrich [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#571}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland [ios] Prevents InfobarBanner from being dismissed twice.
We now are sending the animated parameter into
dismissViewControllerAnimated, and not YES.
Everytime a Banner is finished being presented bannerIsBeingDismissed
is set to NO, that way the only way to dismiss a Banner again is to
present a new one.
[email protected]
(cherry picked from commit bc609f25084fa806993e2edf754275e11eded01a)
Bug: 1049088
Change-Id: Id1bc2adc0bc84a417f2bb320ca815673830b7bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075658
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744888}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082089
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#570}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81][Enumerate Devices] Disable EnumerateDevicesHideDeviceIDs on Android.
It was noted that in the case of WebView the labels are not shown even
though the permission to access the devices were granted. After further
inspection, crrev.com/c/1964495 exposed an issue in permission checking
in the case of WebViews.
To give us time to look into the issue further and fix the actual
permission checking for WebViews, this CL disables by default the behavior
change of enumerateDevices on Android.
(cherry picked from commit 2f734e256852bb5ad86330758e6224a5e8a5f81b)
Bug: 1055770
Change-Id: I9dc557fed9961cf90794c87c4da4fa12213793f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078547
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745581}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083319
Cr-Commit-Position: refs/branch-heads/4044@{#569}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Allow more ViewGroup types as ViewAndroidDelegate's mContainerView
mContainerView is a ViewGroup, but some layout code assumed it was a
FrameLayout. Update that code to allow any kind of ViewGroup for which
the LayoutParams subclasses MarginLayoutParams (including FrameLayout,
RelativeLayout, etc).
It would be nice to add an assertion to setContainerView so that
failures are caught earlier, but I don't see a clean way to do so.
(cherry picked from commit f23086a9a3c1983f74c8bfb6b2d11eb0425dc88d)
Bug: 1054106
Change-Id: If45a16c2864ef200461a08b783b425ea42346f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067247
Commit-Queue: Bo <[email protected]>
Auto-Submit: Evan Stade <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083395
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#568}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Check SupervisedUserNavigationObserver exists before dereferencing.
This CL makes minor changes to check if the absence of
SupervisedUserNavigationObserver is the cause of crash in android
chrome in TabContentsSyncedTabDelegate::ShouldSync.
(cherry picked from commit f635948b9fd2218fa1097f453078c400815252a2)
Bug: 1048643
Change-Id: I8cdb18b30ba42ba781b09d0ba455fc8c26d101f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079004
Commit-Queue: Yilkal Abe <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745547}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079641
Cr-Commit-Position: refs/branch-heads/4044@{#567}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Clear UserData for AwContentsClientBridge on AwContents dtor
AwContentsClientBridge UserData was not being cleared from the
WebContents on AwContents destruction, which was causing a crash.
Test: This is covered by testDestroyWebViewWithInterstitialShowing
which will be re-enabled in a separate CL
[email protected]
(cherry picked from commit 9b8a799985e3feb9ab8819d86b02de5d6c2a78d6)
Bug: 1047527
Change-Id: Ic40bf3a0be8af35dbf85a8f27e6898a53462803c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071114
Reviewed-by: Bo <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744469}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083381
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#566}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.25-1582542493-benchmark-81.0.4044.38-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.39-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ie2d77c6cabb43bb2dfc564ad78772596f26148a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083451
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#565}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Send missing flag to backend.
This will let the backend know whether the UI was shown to the user or
not.
(cherry picked from commit b041d01c8c205f50f5dc53cfada4c56cf1f2f474)
Bug: 1056183
Change-Id: I836fba76d322fc5989919323ccb4a50947a498e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056545
Commit-Queue: Clemens Arbesser <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Auto-Submit: Clemens Arbesser <[email protected]>
Reviewed-by: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741400}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081414
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#564}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[iOS] Fix initialization bug in ActiveWebStateObservationForwarder
The bug occurs when an instance of ActiveWebStateObservationForwarder
is created while already in a WebStateActivatedAt callback. In this case,
the new instance is already observing the newly active webstate, but will
receive its own WebStateActivatedAt callback. Because it is already
observing the new webstate, it doesn't need to stop or start observation.
(cherry picked from commit 6fb456dc246a4d76ed67fa1ae06d0ba091795d6e)
Bug: none
Change-Id: I80826302e17c828874d49bc9cd6957c29eeb6f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059371
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741944}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078211
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#563}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix the crash of window.open() in ChromeWebView.
This CL only affects //ios/web_view which is not part of Chrome, so it has no impact on any Chrome releases.
When window.open() is called, we need to use the exact WKWebViewConfiguration provided by WebKit's delegate method in crw_wk_ui_handler to initialize the WKWebView inside CWVWebView.
This CL makes the WKWebView inside CWVWebView to be initialized lazily.
(cherry picked from commit e525a2895cbf7d4536851657916748b8a3cc4b41)
Bug: 1054276
Change-Id: I5e26c393bbaa667b43b43ba5f78a24b2cacaaede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061984
Commit-Queue: Jiajun Ou <[email protected]>
Reviewed-by: Hiroshi Ichikawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744924}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082418
Cr-Commit-Position: refs/branch-heads/4044@{#562}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface()
This is a workaround of the failure at 1080p video encoding
test on grunt.
Originally vaCreateImage is created with a coded frame size.
However, it causes SEGV_MAPERR on vaPutImage, which copies
vaImage to vaSurface.
As a result of experiments, the vaImage size needs to be the
same as va surface size. Since this is not stated in VA-API
document, so this might be a bug of AMD gallium driver.
Besides of the workaround, this CL copies visible size area
of VideoFrame to the VAImage.
(cherry picked from commit 95ad9e5a05acab4b62cc1d273aec114a7312640c)
Bug: 1048908
Bug: 1050377
Bug: b:148744040
Test: video.EncodeAcel.* on grunt, eve and soraka
Test: camera.* on grunt, eve and soraka
Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744953}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082215
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#561}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.40
[email protected]
Change-Id: I66a022e4c9d177168f79440985f7bd1c50b03f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082359
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#560}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.38-r1 to 81-4044.15-1582544201-benchmark-81.0.4044.39-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie06c72f7bba827f2ab28b33cc1ec40998ac89fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082588
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#559}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.25-1582540974-benchmark-81.0.4044.38-r1 to 81-4044.25-1582540974-benchmark-81.0.4044.39-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Icfce0096851faac7adefa7919c9b3c55c97815e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082585
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#558}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.38-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.39-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I96cafe0bc93d01027416e20ce9578a05ba6e6a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082582
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#557}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.25-1582542493-benchmark-81.0.4044.36-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.38-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ic16c6bc1205c61e7714d8d79ea3dad311f868382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081947
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#556}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.25-1582542493-benchmark-81.0.4044.33-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.36-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I5dbc48f9c0340d1a9846645d8a7dd04ad0a88adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081178
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#555}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.39
[email protected]
Change-Id: Ic587f5e7918b77dfdf755a3332d06f528f674dd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082012
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#554}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.25-1582540974-benchmark-81.0.4044.36-r1 to 81-4044.25-1582540974-benchmark-81.0.4044.38-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If20f595bfa667301f358acf56aef4cb37b258144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081913
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#553}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.36-r1 to 81-4044.15-1582544201-benchmark-81.0.4044.38-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2e03c40903b617700a23554f2c51bc224cd59e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081869
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#552}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.36-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.38-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I35969f9a61091b424b88e55f5de3eef702b117c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081870
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#551}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.38
[email protected]
Change-Id: I2f3c56c019f80541c2ec3bfb2736bf3241bb4b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081253
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#550}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "Compute omnibox background color from toolbar color."
This reverts commit 38ee3ee4ef96a7ba0557a514b8c6a4b0cc088e9f.
Reason for revert: UX would like a complete review before making this change.
Original change's description:
> Compute omnibox background color from toolbar color.
>
> This makes the omnibox/toolbar contrast ratio 1.3 by default.
> Theme authors can manually override the default colors.
>
> Bug: 878664
> Change-Id: I24b95e8d225fd375b573b48e403fbf147013e940
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986244
> Commit-Queue: Peter Kasting <[email protected]>
> Reviewed-by: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#730295}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit c878198d7a14e9580082bfdbb2be303cc1d50778)
Bug: 878664
Change-Id: I1fb8a3c7cfd1b8cd57a260cc9d7f00aa8131e024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070601
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744429}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080816
Cr-Commit-Position: refs/branch-heads/4044@{#549}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix url load params for StartupTabPreloader
Really, the code in StartupTabPreloader should be reusing the Tab
Creator code, but that's a bigger refactor and this needs to be merged
back (and also I don't want to do it :) ).
The initial preloader implementation forgot to set the transition type
for the LoadUrlParams, which happened to default to a value that mostly
works, but failed to record that we were coming from an intent, and so
it broke intent redirects.
The test for this case didn't catch it because the test extraneously
started Chrome to a blank page before running the test, as that's what
the test suite did.
(cherry picked from commit a941f0fe4272646e9a34c6cc3ba96488e12d2835)
Bug: 1039612
Change-Id: I38e918f6e6576a37f5b1c0c893497f3f1b488560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067246
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744532}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080812
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#548}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add null check before for loop using the list
Merge to release branch
[email protected]
The bug was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2032427
and code was moved to here by https://chromium-review.googlesource.com/c/chromium/src/+/2063037
(cherry picked from commit 6234106db31bd3831303f19678a167d9eb0f6ca5)
Bug: 1053790
Change-Id: I683351902f635ba329c14ccaec87540c36758cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075418
Reviewed-by: Gayane Petrosyan <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745076}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080199
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#547}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.25-1582540974-benchmark-81.0.4044.33-r1 to 81-4044.25-1582540974-benchmark-81.0.4044.36-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I33a8937c2f89042729eabe8edba0dcfe0bc81d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080718
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#546}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.33-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.36-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9173bd8b4e27c0d8fb4930d71e86e97da9867fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080716
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#545}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.33-r1 to 81-4044.15-1582544201-benchmark-81.0.4044.36-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4558f6cdba5943340dd62d436aba48ecc0485eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080717
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#544}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: I24dd2ff0779ab3a12c966ebfa535262e8cc1ee0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080192
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#543}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Disable Shared images for WebView by default
Few non-trivial problems were discovered with shared images on WebView.
For this reason we should disable feature by default and proceed with
launching it using finch when the problems will be addressed. Keeping
feature enabled by default is not safe for now.
VizForWebView depends on SharedImages, so this CL adds
EnableSharedImagesForWebView to fieldtrials_testing_config and
server-side finch config, but launching EnableSharedImageForWebview will
be blocker for VizForWebView.
(cherry picked from commit 4feb3e731d8838ea42fc8f163b3edbea64639455)
Bug: 1052114, 900973
Change-Id: I562500319dc5ae8b86781654a15aa4e8a8dd59cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079432
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745291}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080575
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#542}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland "[M81] Do not call OnStartSlowCheck when performing a full URL check."
This is a reland of 3ad0b03d82c6907bf8041ba559f1a2c41bba690c
Original change's description:
> [M81] Do not call OnStartSlowCheck when performing a full URL check.
>
> 1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and
> ResumeReadingBodyFromNet() were added with the assumption that
> Safe Browsing checks mostly return synchronously (except a tiny
> percentage) so calling PauseReadingBodyFromNet() in only those
> few cases was a good precautionary measure.
> 2. The "precaution" was against overzealous AVs that may warn the user
> if we cache an unsafe resource; note that the resource is not used
> until Safe Browsing confirms it is SAFE.
> 3. On mobile, since connection is usually slower, we did not enable
> this "precaution". That's a very good indication of how good this
> "precaution" is :)
> 4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage
> of navigations are going to hit PauseReadingBodyFromNet().
> 5. This would have been fine by itself but due to the special handling
> of PDFs and some other special types, as described in 1056696#c9,
> this completely breaks the loading of those types.
> 6. The "precaution" does not seem worth the breakage.
>
> See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12
> for full details.
>
> R=âxinghuilu
>
> (cherry picked from commit 35d42578e68217fda39c3a9037d1fef26281d54f)
>
> Bug: 1054978,1056696
> Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338
> Commit-Queue: Varun Khaneja <[email protected]>
> Auto-Submit: Varun Khaneja <[email protected]>
> Reviewed-by: Nathan Parker <[email protected]>
> Reviewed-by: Xinghui Lu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#745264}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079856
> Cr-Commit-Position: refs/branch-heads/4044@{#534}
> Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Bug: 1054978, 1056696
Change-Id: Iff8f000c7cda42002e0067d17f271478a3044c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080439
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#541}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Disable item animation for Duet-TabStrip Integration
Since fixes http://crrev.com/c/2036874 and http://crrev.com/c/2048988
don't eliminate all crashes caused by recycling detached item in popup
tab strip, this CL block the crashing path by disabling the item
animation for Duet-TabStrip integration to get rid of the crash.
Note that this CL is a band-aid fix in sacrifice of animation.
(cherry picked from commit 9f77846e563665cb394468b7b13b168fd4b2636b)
Bug: 1045944
Change-Id: I3301deed92e40f4fe2306d1ef1ff5ceadc3edbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064453
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (éłćšć°č) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080553
Commit-Queue: Wei-Yin Chen (éłćšć°č) <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#540}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
device/fido: appidExclude moot if nothing excluded.
If there are no excluded credentials then appidExclude shouldn't matter.
Previously we hit an assertion failure and crashed in this case. (See
bug.) This was introduced with M80.
BUG=1054499
(cherry picked from commit 407d81d0eda733dd409f6811baecd674199c2637)
Change-Id: I074ca094140feca599ab1bc59e59af1fbbcb88a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067387
Commit-Queue: Adam Langley <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Auto-Submit: Adam Langley <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743387}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080074
Reviewed-by: Adam Langley <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#539}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Trusted Types] Fix Trusted Types experiment check.
The current code (erroneously) checks for the 'experimental CSP features'
flag when processing Trusted Type related CSP directives, while the
majority of TT checks TrustedDOMTypes enabled/disabled. This patch
removes the extra check.
(This was introduced erroneously in crrev.com/c/1993351, when reworking
the TT CSP directives.)
[email protected]
(cherry picked from commit f4a9a31e36d4367f1d32414cffcb06f6a32f82cc)
Bug: 1054387
Change-Id: Iad04f0f80b30874c61e5819b6319b85358bd4631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066545
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743461}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080552
Reviewed-by: Daniel Vogelheim <[email protected]>
Commit-Queue: Daniel Vogelheim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#538}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.25-1582542493-benchmark-81.0.4044.29-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ib88d54a0ad30450af4e1e79524554d3bc24ffeea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080574
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#537}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M-81] Fix AccelerometerFileReader to keep reading when auto-rotation is on
Auto rotation depends on the tablet physical state of the device,
not the UI state. Therefore AccelerometerFileReader should keep
reading accelerometer data as long as the device is physically
a tablet (detached or flipped).
[email protected]
BUG=1056862
TEST=Manually on hatch.
(cherry picked from commit 1ac37d68f8d7d8afab85b2f006d2154033287c7b)
Change-Id: I96f6c8f1430fa2d50b20aaa97bd25e072bce098f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079618
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745284}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080469
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#536}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "[M81] Do not call OnStartSlowCheck when performing a full URL check."
This reverts commit 3ad0b03d82c6907bf8041ba559f1a2c41bba690c.
Reason for revert: vakh@ unintentionally bypassed CQ. Will reland this through CQ.
Original change's description:
> [M81] Do not call OnStartSlowCheck when performing a full URL check.
>
> 1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and
> ResumeReadingBodyFromNet() were added with the assumption that
> Safe Browsing checks mostly return synchronously (except a tiny
> percentage) so calling PauseReadingBodyFromNet() in only those
> few cases was a good precautionary measure.
> 2. The "precaution" was against overzealous AVs that may warn the user
> if we cache an unsafe resource; note that the resource is not used
> until Safe Browsing confirms it is SAFE.
> 3. On mobile, since connection is usually slower, we did not enable
> this "precaution". That's a very good indication of how good this
> "precaution" is :)
> 4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage
> of navigations are going to hit PauseReadingBodyFromNet().
> 5. This would have been fine by itself but due to the special handling
> of PDFs and some other special types, as described in 1056696#c9,
> this completely breaks the loading of those types.
> 6. The "precaution" does not seem worth the breakage.
>
> See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12
> for full details.
>
> R=ââxinghuilu
>
> (cherry picked from commit 35d42578e68217fda39c3a9037d1fef26281d54f)
>
> Bug: 1054978,1056696
> Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338
> Commit-Queue: Varun Khaneja <[email protected]>
> Auto-Submit: Varun Khaneja <[email protected]>
> Reviewed-by: Nathan Parker <[email protected]>
> Reviewed-by: Xinghui Lu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#745264}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079856
> Cr-Commit-Position: refs/branch-heads/4044@{#534}
> Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[email protected],[email protected]
Change-Id: I9f27bc715eb89998741af355147dd538cff1353b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054978, 1056696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080077
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#535}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] Do not call OnStartSlowCheck when performing a full URL check.
1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and
ResumeReadingBodyFromNet() were added with the assumption that
Safe Browsing checks mostly return synchronously (except a tiny
percentage) so calling PauseReadingBodyFromNet() in only those
few cases was a good precautionary measure.
2. The "precaution" was against overzealous AVs that may warn the user
if we cache an unsafe resource; note that the resource is not used
until Safe Browsing confirms it is SAFE.
3. On mobile, since connection is usually slower, we did not enable
this "precaution". That's a very good indication of how good this
"precaution" is :)
4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage
of navigations are going to hit PauseReadingBodyFromNet().
5. This would have been fine by itself but due to the special handling
of PDFs and some other special types, as described in 1056696#c9,
this completely breaks the loading of those types.
6. The "precaution" does not seem worth the breakage.
See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12
for full details.
R=âxinghuilu
(cherry picked from commit 35d42578e68217fda39c3a9037d1fef26281d54f)
Bug: 1054978,1056696
Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338
Commit-Queue: Varun Khaneja <[email protected]>
Auto-Submit: Varun Khaneja <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#745264}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079856
Cr-Commit-Position: refs/branch-heads/4044@{#534}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Do not fill field if it contains filled value.
Before this CL, if a field contains value X, and Password Manager wants
to fill the same value X, Password Manager sets this field in the state
Autofilled. Setting the field to be autofilled is not necessary, since
it doesn't add new information. Moreover it destroys information, that
this information came from website, not from Password Manager.
This CL makes Password Manager skips setting such field in Autofill
mode. More details how it breaks accounts.google.com on the bug.
Bug: 1055275
[email protected]
(cherry picked from commit b186361ae657cc11b4f03366fdceb69f00f32a55)
Change-Id: I741ec23b7947c3322fe719b256d94f7c00dd3a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072178
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744257}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080241
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#533}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add condition for adding container configuration obsever
During Crostini installation observer of container configuration was
always added (even where configuration step was not required). This CL
changes this behaviour so observer for container configuration is added
only when container configuration step is present.
added it is later removed
(cherry picked from commit a3053351b6ca2cf44ee3828c25fc2d3a87661e02)
Test: checked manually on device that in all scenarios if observer is
Bug: 1050736
Change-Id: I0999dc776d020965fd769c5daa1c290db88dcdbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056911
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: Olya Kalitova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078215
Reviewed-by: Olya Kalitova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#532}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Check for null WebContents in ContentSettingImageView::AnimationEnded.
While location bar user input in progress, GetContentSettingWebContents
will return nullptr, but ContentSettingImageView::AnimationEnded is
still invoked.
Add a check in the latter to make sure we are not checking on a null
WebContent if the promo should be shown.
(cherry picked from commit 86891cd21a09c09dbc0907dca1540a5194661b77)
Bug: 1054074
Change-Id: I261bceb410478360f6af2d84ddf5e01f5c9e6cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064968
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743025}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080234
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#531}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: Ia67a99023d9200ed223f43a01b4d6e7101addd0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079291
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#530}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.37
[email protected]
Change-Id: I5dab632d43826e1e8859a96a2fa34b638161123b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078743
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#529}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
media/gpu/v4l2VEA: Scale a given VideoFrame if needed
V4L2VEA has been able to work in Zero-Copy mode when a given
VideoFrame's dimension is the same as a resolution configured in
Initialize(). This is sufficient to enable Zero-Copy capture in
ARC++ case.
To enable Zero-Copy capture in chrome case, it is necessary to
scale VideoFrame for Simulcast case. This CL enables V4L2VEA
to scale VideoFrame by using ImageProcessor interface.
See https://tinyurl.com/frame-dimension-in-VEA
for how V4L2VEA works.
(cherry picked from commit 24156892076d86fbfbb2dfe606fd284e5b00759d)
Bug: chromium:1033799, chromium:982201
Test: Hangout Meet on scarlet (with crrev.com/c/1923767 and crrev.com/c/2007802)
Test: VEA test on kukui
Bug: b/147851828, b/147921968
Test: cts.EncodeDecodeTest on kukui
Change-Id: I07d5abfca0f5dd7c4adcfc10191316c5ba3021de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010466
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740587}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074843
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#528}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "[M81] Disable full url check for pdf files."
This reverts commit 1735fa857df7d2688cd188cd73fc89bd821c6962.
Reason for revert: The change doesn't cover all affected files and vakh@ created comprehensive patch: https://chromium-review.googlesource.com/c/chromium/src/+/2079792
Original change's description:
> [M81] Disable full url check for pdf files.
>
> (cherry picked from commit f493cb2e6af457df2cb7c8433aee33b23f0039ca)
>
> Bug: 1054978
> Change-Id: I6bcd7fe1b30134acd6dd123805c4ce283a707ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072591
> Commit-Queue: Xinghui Lu <[email protected]>
> Reviewed-by: Varun Khaneja <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#744488}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073268
> Cr-Commit-Position: refs/branch-heads/4044@{#485}
> Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1054978
Change-Id: I323b7a104e305979b0ac0a4b48bf25a8552eb7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079456
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#527}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
M81 Merge [ios] Fix NTP snapshot edge insets
There were two changes to NTP frame and inset calculation
that broke NTP snapshot insets and resulted in a snapshot
with a smaller frame than needed.
https://chromium-review.googlesource.com/c/chromium/src/+/1392956
https://chromium-review.googlesource.com/c/chromium/src/+/2019244
The NTP's fullscreen behavior is different from a regular
webpage in that the bottom toolbar stays fixed (in compact width
size class). Since the NTP's frame is always above the bottom
toolbar, there is no need to further inset the snapshot frame
on the bottom.
This CL fixes the snapshot inset.
[email protected]
(cherry picked from commit 0c7dc2884a41f242d2d57ac53e2541392287f250)
Fixed: 1040101
Change-Id: I0f5c0289b873a031ac66550d1c4aca1f5a3e73cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073011
Reviewed-by: edchin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744758}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076768
Cr-Commit-Position: refs/branch-heads/4044@{#526}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
M81 Merge [ios] Fix snapshotCache in tab grid mediator
crrev.com/c/2001849 broke snapshotCache in the tab grid mediator.
The snapshotCache needs the browserState to be set before
it is initialized.
This CL fixes the order of setting the browserState then initializing
the snapshotCache.
[email protected]
(cherry picked from commit 4e9b403fc58368733bef1a88b67e342b02b3b299)
Fixed: 1046349
Change-Id: Ie257b18c862e071a90dc67b12e4d39ebc429e28b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076446
Reviewed-by: edchin <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744925}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076064
Cr-Commit-Position: refs/branch-heads/4044@{#525}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.36
[email protected]
Change-Id: I4c939d6ed7623d9fd6d24be66ed084b81b8906b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079675
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#524}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[merge-m81] CrOS Gallery: Workaround new treatment of EXIF orientation in m81.
The Chrome OS Gallery is affected badly by Blink's new treatment of
EXIF orientation for <img> and <canvas> elements. With crrev.com/741635
(and crrev.com/725393), it's now necessary to add the "new Image()", and
the <canvas> element it is drawn into, to the page temporarily.
Without this, <img> and <canvas> elements attempt to respect any EXIF
orientation in the source bitmap. This conflicts with logic in
Gallery to support the earlier behavior of these elements.
This CL sets attributes to disable the new treatment, and performs the
necessary DOM machinations to ensure these attributes take effect.
The approach should be robust enough to function as expected whether
or not the new EXIF orientation treatment is actually taking effect.
Skip presubmit: A linter complains about changes outside the scope
of this CL. (OWNERS approval still sought).
[email protected]
(cherry picked from commit 0241e11903a9cc0e5d3eef858ba22f5ae2caa125)
No-Try: true
No-Presubmit: true
Bug: 1043561
Change-Id: Ib58c8bed9dd5589e3908a8336b4446eeb523170a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065688
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: Noel Gordon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743438}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078812
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#523}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
viz: GL_NEAREST instead of GL_LINEAR for non-scaling copy.
On GPUs that only supports FP16 arithmetic, just doing
a copy between the same size of large (>1024px) rectangles
already introduces some imprecision. Using GL_NEAREST in
such a case increases the quality and produces results
closer to pixel-perfect copying.
BUG=b:141898654
TEST=android.view.cts.SurfaceViewSyncTest#testSmallRect on kukui (ChromeOS)
(manual cherrypick from crrev.com/c/2076642; the file has moved to gpu/ on ToT.)
Change-Id: Ib891fbbaaf76537b5c5e081ae1f3f3abbcf4bdcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077320
Reviewed-by: Daniele Castagna <[email protected]>
Commit-Queue: Kazuhiro Inaba <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#522}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Tab Groups] Fix check for logging when a tab is switched into.
TabStrip::SelectTab is called when the mouse is released to handle
multi-select. Updating this to only log when the tab selected is not
already active.
(cherry picked from commit 2a3d0d8a8d9ee94d68e616e4361549d09945ff18)
Bug: 1040657, 1054016
Change-Id: Iee8db203fab8ca5f53955c4f95c5ea3b97d17fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063768
Reviewed-by: Connie Wan <[email protected]>
Commit-Queue: Charlene Yan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078734
Cr-Commit-Position: refs/branch-heads/4044@{#521}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Clearing container configured preference in Crostini remover
Clearing preference with container configuration state in Crostini remover
so when Crostini is reinstalled after removal it would be
considered not yet configured.
(cherry picked from commit 80cc98f25c3ca3d25314aaf08f3b0c2dd578029b)
Test: none
Bug: 1055503
Change-Id: Ibb83d2c1fc928a9816575f57437f6ce88d34832c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069335
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: Olya Kalitova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744237}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078435
Reviewed-by: Olya Kalitova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#520}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix dark mode widget delete button icon color
The ColorStateList needs to be different between the mic button and the
delete button.
(cherry picked from commit e90c17485d58fccf32d7ca061d55499c3b3fcd84)
Bug: 1054300
Change-Id: I97e88144c359e5c27cecfd7b99509051520a7808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067461
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744123}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079037
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#519}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
M81: overview: Disable ending overview while dragging split view divider
You shall not be able to end overview by pressing the overview button
with one finger, while dragging the split view divider with another
finger. It causes a DCHECK failure.
[email protected]
(cherry picked from commit 8f12da7d3049311c29403d4f1b0cdefcdf8823d9)
Test: manual
Change-Id: Ie48e19a9fe9a21e45313e16cc5a353adb9eada64
Fixed: 1052163
Bug: 1052163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055886
Commit-Queue: Avery Musbach <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741262}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079144
Reviewed-by: Avery Musbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#518}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.25-1582540974-benchmark-81.0.4044.31-r1 to 81-4044.25-1582540974-benchmark-81.0.4044.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I231e98ad3349a7807dc86d100b0dd15e8d945764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079278
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#517}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.31-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3f320d565d157281310481eecba4272254551428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078538
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#516}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Cache surface in SharedImageRepresentationSkiaGL
This CL caches SkSurface in SharedImageRepresentationSkiaGL. Creating
surface around texture requires creation FBO and is costly. This
change saves 100us in DrawToSwapUs in local telemetry run.
Bug: 1051195
(cherry picked from commit 1af80729ed6299425da56acba35fb247e15d59ae)
Change-Id: I5b5911c731b0a57710f0f9db0df8b25308704c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049911
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740441}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079008
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#515}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.31-r1 to 81-4044.15-1582544201-benchmark-81.0.4044.33-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I61cdd3ed2295c34ce088602c127b18baa56b194e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079283
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#514}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
M81: overview: Disable entering overview while dragging split view divider
You shall not be able to enter overview by pressing the overview button
with one finger, while dragging the split view divider with another
finger. See the video linked on Monorail.
[email protected]
(cherry picked from commit 32cf68a04b487ebde968ea6bbe47f6a34c39d3fd)
Test: manual
Change-Id: I779e20fcc951d44355ee4c05d71e5bac1c83024f
Fixed: 1051758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055735
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Avery Musbach <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741229}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079139
Reviewed-by: Avery Musbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#513}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4044.15-1581938983-benchmark-81.0.4044.29-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.29-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Id17399ab14f86871f81682bc616daccd39dbba3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078598
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#512}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
đ Move Client Data header out of ClientManager.
[email protected]
(cherry picked from commit fd1911394fe4c93b3b45bd8f5b6075e4bca3a225)
Bug: 1040143
Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208
Commit-Queue: Peter Conn <[email protected]>
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743100}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077931
Reviewed-by: Peter Conn <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#511}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
đ Create feature for CCT Client Data header.
(cherry picked from commit 921794e3ce76c290ff3f783d24d750ddef723336)
[email protected]
Bug: 1040143
Change-Id: I3a60e9c06277c5fe27582c39c648b87d93962592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060291
Auto-Submit: Peter Conn <[email protected]>
Commit-Queue: Michael van Ouwerkerk <[email protected]>
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741917}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077438
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#510}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.5-1581936963-benchmark-81.0.4044.29-r1 to 81-4044.25-1582540974-benchmark-81.0.4044.31-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ida02fe504284e966364d75fe90d90e4f7466bf99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077582
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#509}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4044.15-1582544201-benchmark-81.0.4044.29-r1 to 81-4044.15-1582544201-benchmark-81.0.4044.31-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2b81325e99b3a9f2bad5bf10fcd1d5e15258a4c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077583
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#508}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.25-1582542493-benchmark-81.0.4044.29-r1 to 81-4044.25-1582542493-benchmark-81.0.4044.31-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8169953bfa36cf2d114de9a5469a2d0665bd55ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077577
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#507}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
RtcVideoEncoderFactory: Create VideoEncoder if it's unknown whether the configured profile is supported
crrev.com/c/2035481 delays filling VEA supported profiles in
GpuVideoAcceleratorFactoriesImpl because it queries GPU process
the supported profiles, instead of referring cached info of
GpuInfo instance.
Therefore, it can be unknown whether the configured profile
on CreateVideoEncoder is supported. We create VideoEncoder
in the case, relying that the software encoder fallback
happens later if no hw encoder is capable of the profile.
(cherry picked from commit 7a0416e9b789c9b83355a7641670ba607c1b3a6c)
Bug: 2035481
Test: webrtc.RTCPeerConnection.* on soraka and kukui
Change-Id: I04334073769914005b6ec1a82170457d340f4a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035486
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742620}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076860
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#506}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
GpuVAFactories: Initialize VEA supported profiles by cached info of GpuInfo
crrev.com/c/2035481 delays filling VEA supported profiles in
GpuVideoAcceleratorFactoriesImpl because it queries GPU process
the supported profiles, instead of referring cached info of
GpuInfo instance.
If getVEASupportedProfiles() is called in flight, the function
reports as if the HW encoders support no profile. The issue due
to this timing problem happens in fact on some CrOS devices.
This CL mitigates the timing issue by setting the initialized
VEA supported profiles to ones based on cached info of GpuInfo
instance.
Besides, this clarifies a caller of getVEASupportedProfiles()
that the function returns nullopt if the factory hasn't got
the results from GPU process.
(cherry picked from commit a5554f1d9e8c4889b3f754a5d3092aed82426132)
Bug: b:147404923
Test: webrtc.RTCPeerConnection.* on soraka and kukui
Change-Id: Ie6867cb6f79934f66cf8550e2d41ec54671a5487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035461
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742619}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076817
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#505}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland "content/renderer/media: Query GPU process HW encoder capabilities"
This is a reland of 139567bab60054fe0f55f952e0f3aa6d500e95ed
Original change's description:
> content/renderer/media: Query GPU process HW encoder capabilities
>
> Originally GpuVideoAcceleratorFactoriesImpl get HW encoder
> capabilities by referencing values stored GpuInfo instance.
> However, the values are not updated after GPU process boots up.
> Even if a new hw encoder is available after GPU process is
> initialized, the hw encoder is not detected.
>
> This fixes the problem by querying GPU process the hw encoder
> capabilities when a render process is created. e.g. open the
> page.
>
> Bug: b:147404923
> Test: HW encoder is used at appr.tc
> Test: tast run webrtc.* on krane
> Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849
> Reviewed-by: Dominick Ng <[email protected]>
> Reviewed-by: Dan Sanders <[email protected]>
> Commit-Queue: Hirokazu Honda <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#735339}
(cherry picked from commit eb11e4a90bc5acdf63e1960393166755c683ab9b)
Bug: b:147404923
Change-Id: Ia5535e0d316c0418f15e1139d475af67f226ed14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035481
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742563}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074999
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#504}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
media/gpu/vaapi: Change the expected input coded size to be aligned one
The coded_size of input VideoFrame is always aligned by 2. For
instance, in the case the dimension to be encoded is 641x361,
the input VideoFrame's coded_size is 642x362 and visible_rect is
0, 0, 641x361.
This is against the expectation on which crrev.com/c/1997426 was
based; The coded size of input VideoFrame is the same as the
dimension to be encoded.
Additionally, this corrects the va surface size mismatched bugs
introduced in crrev.com/c/1997426.
(cherry picked from commit 55ebad2eb87f602075dfdaaf5f41314f17011d00)
Bug: 982201
Bug: b:148744040
Test: video.EncodeAccel.* on hatch, grunt and eve.
Test: VP8 Simulcast.
Test: https://appr.tc/?debug=loopback&vsc=vp8&video=maxWidth=361,maxHeight=481,minWidth=361,minHeight=481 on hatch
Change-Id: I68fe77b4e4f16879d76a7e84c3b06b73b07660b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037279
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739313}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076218
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#503}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.35
[email protected]
Change-Id: Ie83280e51f3347b34f3868c7da09f947b38482ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076553
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#502}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
chromeos: hack to check if we are Kohaku when launching demo mode
This is a change for M81 branch only which will support Kohaku's
custom demo mode attract loop, as demo mode Kohaku devices will never
be updated to M82.
This is a lot cleaner in M82, but we're 30+ CLs diff from making that
solution work in M81. So just check based on SMBIOS name.
Bug: 1050671
Test: Kohaku shows eve demo mode
Change-Id: I3f8a47ab824dac9676c7b0ada88bc0282cde3819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076532
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#501}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Don't clear the page's cached favicon URL when iframe navigations start
https://chromium-review.googlesource.com/c/chromium/src/+/1959334
upstreamed the favicon caching functionality of ContentFaviconDriver
into WebContentsImpl. One thing that it missed was making clearing
the favicon cache on navigation start conditional that the main frame
was being navigated.
This CL adds that conditional and fixes a bug where delayed iframe
loads would prevent "Create shortcut..." from working as it would wait
indefinitely for a favicon URL event when it saw there was none.
(cherry picked from commit ab48fc09bde27056d7ac48f88d7c141a7d3d58a2)
Bug: 1046883
Change-Id: I520531558dec2d2daa8817884a33701b75f017bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068266
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Kinuko Yasuda <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743907}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076637
Reviewed-by: Alan Cutter <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#500}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
media/gpu/VEAtest: Fix a wrong computation on offsets
VEA unittest computes several sizes like stride in bytes of
each plane and aligned linear buffer size so that it can
fills video frame buffer to aligned buffers.
This fixes a bug on the computation.
(cherry picked from commit 761372e66ffd654b88d2e03492f0d0230c32020f)
Bug: b:148744040
Test: video.EncodeAccel.* on hatch
Change-Id: I32a7a2e71e9d6269624d559a22abd3d47ac9996b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037295
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738813}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076717
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#499}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Use KeepSelfAlive on AudioContext to keep it alive until rendering stops
When an ExecutionContext is abruptly/unexpectedly destroyed (e.g.
shutting down of document or iframe), an AudioContext can also
go away. This type of shutdown can be problematic because the render
thread still might be touching resources in the AudioContext allocated
by the main thread.
This CL introduces a self-referencing pointer to the AudioContext,
and it is cleared after the underlying render thread is stopped. In
that way, the destruction of AudioContext can be done safely.
(cherry picked from commit 85f708fa7ab898c7ae678c0b8a270105be6bbb4e)
Test: Locally confirmed the repro case doesn't crash (UAP) after 1hr.
Bug: 1043446
Change-Id: I2e40b7d58ca9d647eed8a5971fc69dc87ee3d1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049912
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742338}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075478
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#498}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add UKM logging and ability to deactivate logging with finch feature param.
(cherry picked from commit 77c6a9b86256fa52bdfac76be4c1c4295e3e589f)
Bug: 1047029,994052
Change-Id: I9a63d5ffc0e5330736ef7d14d0fdc0526ed8ba01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029244
Commit-Queue: Ben Goldberger <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740423}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073364
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#497}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix crostini <-> task manager integration
Since crrev.com/c/1949703 a new flag was added to the vm launch which
caused our logic for determining which process was crostini to fail.
This changes the logic so that we once again correctly find the crostini
process and report it in the task manager.
See also crrev.com/c/2040592 for similar PluginVM bug.
(cherry picked from commit 597c6b21fd5e0204e87b8289a3096f6285605900)
Bug: 1047589
Change-Id: I28e6bfcc02f69d837df34e306a612fc29efb1547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041377
Reviewed-by: David Munro <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Nic Hollingum <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740100}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076457
Reviewed-by: Fergus Dall <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#496}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "Don't disable draw during resize"
This reverts commit d7faa67963d63a441c708d945b157b6eec08d87f.
Reason for revert: https://crbug.com/1055738
Original change's description:
> Don't disable draw during resize
>
> https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to
> also block draw instead of just swap. This had the side of effect of
> blocking draw when the browser window is minimized, which means we stop
> casting tab/window contents. Switch DisableSwapUntilResize() back to
> just block swap instead of draw+swap.
>
> [email protected]
>
> (cherry picked from commit 985a1f4190e3f7fbbe250bb73d332d233942d289)
>
> Bug: 1054239, b/149923568
> Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642
> Commit-Queue: kylechar <[email protected]>
> Reviewed-by: Saman Sami <[email protected]>
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#744018}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075051
> Reviewed-by: kylechar <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4044@{#494}
> Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[email protected],[email protected]
Change-Id: Icc00be27fd7e4dda46b91cee6140303ddfd95ffd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054239, b/149923568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076001
Reviewed-by: kylechar <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#495}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Don't disable draw during resize
https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to
also block draw instead of just swap. This had the side of effect of
blocking draw when the browser window is minimized, which means we stop
casting tab/window contents. Switch DisableSwapUntilResize() back to
just block swap instead of draw+swap.
[email protected]
(cherry picked from commit 985a1f4190e3f7fbbe250bb73d332d233942d289)
Bug: 1054239, b/149923568
Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744018}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075051
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#494}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
remoting: Initial Linux keyboard layout monitor implementation.
This still has a couple of rough edges:
* Some layouts lacking a keypad thousands separator will show a decimal
separator at both NumpadDecimal and NumpadComma.
* IntlBackslash will appear on layouts where it's not typically
present (usually generating '<').
* Japanese and Korean IME keys are not included even where applicable.
* When the user modifies the enabled keyboard layouts or settings,
several layout messages can end up being sent in rapid succession as
the changes are applied.
* Probably other things that will be revealed during testing.
(cherry picked from commit d4b3cbc2d6a060cbf5e421c443101b2082c4e2ba)
Bug: 1026029
Change-Id: Icb511db3d3b5715ab563a0f433443c977e5c805c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063850
Commit-Queue: Erik Jensen <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Reviewed-by: Gary Kacmarcik <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744150}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074940
Reviewed-by: Erik Jensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#493}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M-81] Night Light: Persist manual status changes during automatic schedules
When an automatic schedule is being used, users can toggle the status
of Night Light manually from the system tray or the system settings.
This manual setting used to get reverted, and the schedule used to get
reapplied in the following cases:
- Switching users.
- Resume from suspend.
- Receiving a new geoposition.
This CL makes it possible to remember manual toggles, and reapply
them if possible.
[email protected]
BUG=999397
TEST=Manually, added new tests.
(cherry picked from commit 543ebccd6d1172dc01e1bcdefd93af90da20bb9a)
Change-Id: Idb1b76cf24c95e0833a65542f0b0ffa341195c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049950
Commit-Queue: Ahmed Fakhry <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741569}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075066
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#492}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add a lock in AudioDestination to clarify state transition
This is a preparation work to implement the synchronous stopping
in AudioDestination::Stop().
(cherry picked from commit f3537ca2fd9cd78a4238bec491519c46094b88b7)
Bug: 1048351
Change-Id: Ib15da752f41e07ccdb810609140371dd9ee7a2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042368
Commit-Queue: Hongchan Choi <[email protected]>
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741512}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074808
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#491}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] Fix bindings for WebUI error pages that reload successfully.
WebUI bindings aren't granted to error pages, and we weren't granting
them when reloading a NavigationEntry that had earlier been an error
page.
To fix this, reset all sensitive state (including bindings) on the
NavigationRequest when the destination SiteInstance changes from what
the NavigationRequest expected it to be.
(cherry picked from commit 1bb82829e6a47a7991784f52743ec1b7f312382f)
Bug: 1046159
Change-Id: I2b004423ad2f1f7aecd86220be75d32f26404040
Fixed: 1046159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045143
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740557}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071288
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Ćukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#490}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[iOS] Reenable CallLoadURLWithParamsDuringSessionRestore
WKWebView was quite a lot crashy on iOS 13.1. It is possible that this
instability was making this test flaky.
As the bots were updated to iOS 13.3, it should be possible to
re-enable this test.
(cherry picked from commit 5425b0d9a7a48795aff3dbc41695e06e7e8ec5be)
Fixed: 1046576
Change-Id: I694daecb4c320bcd13dad12d27a1fa64bc0207e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047065
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740345}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074702
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#489}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Sync] Delete Password Sync Metadata when not readable
(cherry picked from commit 60d431f247813eb0d843c848a80cb8b00a7092a7)
Bug: 1044365
Change-Id: I9fd23b258c86f68e01be02f17c49d0adcbe7a1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064940
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#743087}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071020
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#488}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix ViewAndroidTest Observer usage.
This change:
https://chromium-review.googlesource.com/c/chromium/src/+/2065416
introduced an observer method that is called in the ViewAndroid
destructor, and thus all observer need to outlive the ViewAndroid
or be removed before it is destroyed. The test was not designed
for this, so this updates the tests and add some testing for
the destroy observer call as well.
[email protected]
BUG=1048851
(cherry picked from commit 0322c90b4c77ed7ed0d6e3cc843ef0b01b7860d9)
Change-Id: I9eb88eacf1badcd13df168dcf5b264b182ba5062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071107
Reviewed-by: Bo <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#744333}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073178
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#487}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}