Publish DEPS for 80.0.3987.78
Incrementing VERSION to 80.0.3987.78
[email protected]
Change-Id: Id33b9da8c8c7d6248a82700fb6f7a591ecb7a80a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026671
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#752}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: Ifde1513d6b329ecb9b2f9cc23242edb4a4965767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027130
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#751}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.77
[email protected]
Change-Id: Ia732bedefad5df4de5e35773453960d67782e8e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026472
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#750}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[merge to 80] overview: Fix selecting a minimized ARC app window.
Waits until ARC app is unminimized before activating. This is necessary
because ARC apps are unminimized async unlike chrome apps.
[email protected]
(cherry picked from commit 5e086d0fc39a454f82a40f01aacd2a45f8ae16b0)
Test: manual
Change-Id: I67d4b700483d3a391b3ef233127440783835c8e1
Fixed: 1031328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959342
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723904}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027168
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#749}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Announcement notification: Fix navigation to URL.
Currently when clicking on the "Review" button, on Mac, it will always
not navigate to the expected URL. On Debian, sometimes nothing happens.
On Mac, if the notification has no origin, then click event will not be
forwarded to NotificationHandler. This CL removes the origin check.
Also changed the URL navigation API used to open the URL.
[email protected], [email protected], [email protected]
(cherry picked from commit 77c4d4c42f406fe1541fdd145b8201ab78ff9651)
Bug: 1042124
Change-Id: Ife2c1a5e5949b1d933e4048dfa11a62144ba6bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023747
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735736}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026384
Cr-Commit-Position: refs/branch-heads/3987@{#748}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I11e9e29d63f8cf0d4197a757ab737e7e46cf9fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026266
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#747}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.76
[email protected]
Change-Id: I0b8881c3eca9cc5a688d6403ae4969da706ccf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026353
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#746}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fix crash when clicking on slide-out settings button of ARC notification.
Opening the inline settings now triggers another surface created event, which
is not currently expected by the ArcAccessibilityHelperBridge. If the
corresponding tree already exists, then we should just return early.
[email protected]
TEST=manually verified
BUG=1042554
(cherry picked from commit 92ed142a3e8ac70a7a22e405c98559091dcab5cc)
Change-Id: Ic689184f54c4a737ddd35d7ed05e42b09d3c21bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003197
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Tim Song <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734702}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026024
Reviewed-by: Tim Song <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#745}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Announcement notification: Finalize URL for M80.
This CL finalizes the URL for announcment notification.
[email protected], [email protected]
(cherry picked from commit 88d2d6b0f91738730556df1bf6f5db6c4fd73bd5)
Bug: 1042124
Change-Id: I713a7657c525038b5d4685373fc8155a9ae9c09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022342
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735306}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026487
Cr-Commit-Position: refs/branch-heads/3987@{#744}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Announcement notification for M80.
This CL finishes the implementation of announcement notification. This
feature targets M80.
We show a notification on browser start up on Android and desktops for
an important informational update.
[email protected], [email protected], [email protected], [email protected]
(cherry picked from commit 147807796e2bbd28853c41166a5611c2fd294d28)
Bug: 1042124
Change-Id: Ib422c789f06382adac4f25efe0b8c0275e128174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018718
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735208}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025971
Cr-Commit-Position: refs/branch-heads/3987@{#743}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Allow the IncreasedContrastThemeSupplier to Opt-Out of Most Incognito Colors
Previously, the IncreasedContrastThemeSupplier bypassed most of the
incognito colors. This worked fine as the colors it did specify worked
with non-incognito colors in incognito.
http://crrev.com/719713 removed this bypass, resulting in incognito
colors applied to the IncreasedContrastThemeSupplier and white-on-white
text as well as light-on-white controls.
This change reintroduces this opt-out as a workaround.
BUG=1045630
(cherry picked from commit 60c24709cb6658f732a2d2848f081fadd601eb65)
(cherry picked from commit e58f6beb40612d0ac7c8a98a654441246c4b269d)
Change-Id: Ib83172fbd90559bc72e94e850591ee66cd4ad4e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024468
Commit-Queue: Robert Liao <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Auto-Submit: Robert Liao <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#735723}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024918
Reviewed-by: Srinivas Sista <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4041@{#5}
Cr-Original-Branched-From: a096388e91ec302082e310d93900ecfd20b3a081-refs/heads/master@{#735712}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025972
Cr-Commit-Position: refs/branch-heads/3987@{#742}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
M80: Never show warning for sideloading at login screen
The warning should never show on M80 since the entry to turn on the
feature is not enabled (but the code path to show the warning is).
However, unexpected timeout in this code path triggers the warning.
As we're promoting M80 to Stable soon, this change simply force to
not display the warning.
Bug: 1046443
Test: build
Change-Id: Id53ef199653bed616f6416aa963733e6ccc55f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025970
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Victor Hsieh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#741}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Revert "gpu: Enable OOP-R by default on mac/cros."
This reverts commit ab2fcdc2b79ccd242ee460a32b8afc05c4da71d5.
Reason for revert: crbug.com/1046414
Original change's description:
> gpu: Enable OOP-R by default on mac.
>
> The only blocker for this is the input latency regression which we hope
> to recover with skbug.com/9455. But the regression is in the order of
> 4 to 11% at the 99th percentile, which is not severe enough to hold back
> the rollout.
>
> Bug: 757605
> Change-Id: I77618b2b1de99c9367e85fa10a445f387380b243
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929637
> Auto-Submit: Khushal <[email protected]>
> Reviewed-by: Victor Miura <[email protected]>
> Commit-Queue: Khushal <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#718965}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 757605
Change-Id: Id60f724e1641fe7702001b44a0b3f4fb03e05d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025692
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#740}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fixed crash in recycler view due to duplicate stable ids in download home
Sometimes we incorrectly create two Just Now sections in download home.
This leads to a crash in RecyclerView as stable IDs should be unique.
This happens especially when there are two downloads very close to midnight,
one before midnight and one after midnight. This CL fixes this issue
and places both of them in one Just Now section.
[email protected]
(cherry picked from commit 7865e3c402954f0c45eecf2798643960558db4fa)
Change-Id: I5af6560c29a7413f86a6245719859197d72268dd
Bug: 1020079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024068
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025492
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#739}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I02d4531ebeb16717b2d7f991bbf3920d24f3a92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025582
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#738}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[navigation] Do not swap BrowsingInstances when reloading error pages
This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/1929033.
Force reloads of error pages to always stay in the same browsing
instance.
The reason is the autoreload logic relies on the RenderFrame staying
the same (see crbug.com/1045524).
[email protected]
TBR=[email protected],[email protected]
CC=[email protected]
BUG=1043888
(cherry picked from commit c62747d784d3d9a036eb896e815b9d8812e828a2)
Change-Id: Ifd3ee23325c88a82a9008b80784ea5b0c7976b22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011924
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735564}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025352
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#737}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Announcement notification strings.
This CL adds the announcement notification strings for Android, and
desktops platforms.
The strings should be accessible through both i10n api in native and
R.string in Java.
This feature targets M80.
[email protected]
(cherry picked from commit bcb915621840f01cfdebcbc2ec1057a2e831b631)
Bug: 1042124
Change-Id: Ic1761f202ac94f965036e5a4baf3f28d0e135217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018458
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734812}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024983
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#736}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge M80 (2 of 2) [ios] Update TOS promo string
Previously, the string with IDS_IOS_REVIEW_UPDATED_CHROME_TOS
was made to differentiate between Chrome and Chromium.
This string should never refer to Chromium. It is only valid
with regards to Chrome. Therefore, the string should be defined
in the file ios_strings.grd.
This change was requested by Legal to ensure that no user is ever
told that Chromium TOS has changed.
This CL defines IDS_IOS_REVIEW_UPDATED_CHROME_TOS in ios_strings.grd,
and removes this ID from ios_chromium_strings.grd and
ios_google_chrome_strings.grd.
[email protected]
(cherry picked from commit 4dd179e09406fba7eb5fdc66f6d96c097bb94652)
Bug: 989351
Change-Id: Ideea557462946b93d1eae51dd14168d280231b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021165
Commit-Queue: edchin <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735223}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025787
Cr-Commit-Position: refs/branch-heads/3987@{#735}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Announcement notification: Add Finch parameter controlled notification.
This CL adds code to compare a version in Finch parameter and local
version cached in PrefService, and show a notification when the
version from Finch is newer.
The notification logic will be added in following CL.
[email protected]
(cherry picked from commit 7252b8dfe2d80b26d2fa8745594ceecf13d999cc)
Bug: 1042124
Change-Id: Ie2ab1250557517554abb142a0a0c5ee31eb95d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006418
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025571
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#734}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fix UAF crash in PermissionServiceContext::CreateServiceForWorker
This CL recreates the |permission_service_context_| on-demand in
RenderProcessHostImpl::CreatePermissionService to avoid accessing
the nullptr.
(cherry picked from commit 1522c9a7eeb4a961c66fb78276853a7277602cad)
Bug: 1036779
Change-Id: I1f464de70a6e4b281380b9b83fee06e012831236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014720
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Bo <[email protected]>
Commit-Queue: Miyoung Shin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735402}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024542
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#733}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
v8bindings: Patchwork the crash at LocalWindowProxy::Initialize
We've been observing crashes at LocalWindowProxy::Initialize
void LocalWindowProxy::Initialize() {
CHECK(!GetFrame()->IsProvisional());
...
}
through calls to ToScriptState. This patch patchworks to stop
the crash by checking frame->IsProvisional() beforehand.
This patch makes ToScriptState return nullptr when the frame is
provisional, and it'd potentionally cause crashes on the call
sites. (ToScriptState is designed to return nullptr in some
cases, so the call sites must have been checking the return
value.)
Anyway, Blink has been crashing in the case that this patch is
bailing out, thus the situation won't become worse.
Bug: 1037985, 578349, 1046282
Change-Id: I9497aa740d7b1d14e400c5e416d4a988ff8f488e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024189
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#735825}
(cherry picked from commit 72e777763f56480dcaf2a4f18cfe48ae5542a81e)
[email protected]
Change-Id: I9497aa740d7b1d14e400c5e416d4a988ff8f488e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025587
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#732}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Move ReadableStream requests onto the stack before iteration.
This might be subject to concurrent modification by script.
(cherry picked from commit 12310ed05f15fea5fa6824c6a6b5d86f81532e25)
Contributed-by: Sergei Glazunov <[email protected]>
Bug: 1045874
Change-Id: I27f75b8a4db924bb4fe471abca439cbbe7948c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023354
Commit-Queue: Jeremy Roman <[email protected]>
Commit-Queue: Domenic Denicola <[email protected]>
Auto-Submit: Jeremy Roman <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Tbr: [email protected]
Cr-Original-Commit-Position: refs/heads/master@{#735607}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025573
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#731}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[bfcache] Swap BrowsingInstances only when actually needed for bfcache
At the moment enabled bfcache fully enables proactive swap of browsing
instances.
Change this to swap browsing instances only when required by the
bfcache experiment settings.
TBR=[email protected]
[email protected],[email protected]
BUG=1046061
(cherry picked from commit d325f3ca961c0886dd67e9965a0008030760ebc0)
Change-Id: If3793853e8cbd8eefb02b2064d80ebe25aeaae8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023688
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735551}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025351
Commit-Queue: Krishna Govind <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#730}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Revert "Fixes click on inline element embedded in anchor inside <summary> breaks anchor."
This reverts commit 4eb4df63f17ee0f22cd17472fa6ae92311e49900.
Reason for revert: Caused crbug.com/1045433.
Original change's description:
> Fixes click on inline element embedded in anchor inside <summary> breaks anchor.
>
> Previous to this CL, clicking on an inline element embedded in an anchor placed
> inside a <summary> tag will expand the <details> section instead of navigating to
> the anchor's href. However, when the anchor is placed outside of <summary>,
> it behaves correctly.
>
> The error is caused by DOMActivate event generated by the inline element. As
> DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the
> <summary>, and is handled there. Once DOMActivate is handled, the original
> click event stops propagating and terminates. This behavior, however, differs
> from when the anchor tag is placed outside of the summary. DOMActivate isn't
> handled, and the original click event keeps bubbling up till it's handled by
> the anchor.
>
> DOMActivate event is deprecated:
> https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event.
> However, since blink still has code that depends on it, replacing it is outside
> of the scope for this fix. Instead, this fix is for the anchor element to
> handle the DOMActivate event as it bubbles up. The anchor event handler checks
> the underlying event of DOMActivate and handles it if it's a click.
>
> I also looked at an alternative fix by trying to prevent the DOMActivate event
> from bubbling up. But calling event.stopPropagation() doesn't work as the
> EventDispatcher::DispatchEventPostProcess doesn't check this status.
>
>
> Bug: 538283
> Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234
> Reviewed-by: Kent Tamura <[email protected]>
> Reviewed-by: Mason Freed <[email protected]>
> Commit-Queue: Yu Han <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#718552}
[email protected],[email protected],[email protected]
(cherry picked from commit b4cb14f3cacece63ea28e9a021a77c41867e0503)
Bug: 1045433
Change-Id: I14b369beb04171ef846cb3a79ebb3fe268cf5c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023267
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Yu Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735575}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024545
Cr-Commit-Position: refs/branch-heads/3987@{#729}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge M80 (1 of 2) [ios] Update TOS update promo string
This CL updates the TOS update promo string
with a finalized string.
[email protected]
(cherry picked from commit eb42cf8ff6ca7345f5c133f6c2a4f774f1d980f8)
Bug: 989351
Change-Id: I0a6dda7e8953b9ff88a6f1e90f9da68b9220750d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018422
Reviewed-by: edchin <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734775}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025527
Cr-Commit-Position: refs/branch-heads/3987@{#728}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[StartSurface] Add an omnibox-only variation
Omnibox-only is like tasks-only, with the following differences:
- No most-visited tiles
- New Tab Button is at the left
- Incognito switcher is only visible when there're incognito tabs
- Incognito switcher is at the center
[email protected]
(cherry picked from commit 97511e2cb4d41fa54d8886320cfc4ecd12dfc3b9)
Bug: 1042997
Change-Id: I93ed791cb0b3cabb87807de4362b2150a41a4c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006627
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ganggui Tang <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734731}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023863
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#727}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Apply privacyRedesign flag to os_settings_ui.cc
Due to large changes to the os_settings_ui.cc file between m80 and m81 I needed to perform a manual cherry pick to change the location where I added the AddBoolean call.
Change-Id: I4933295a0747348cb6fe618b9a29abf239c82ab0
Bug: 1045167
Manual Cherry Pick for:
>Add PrivacySettingsRedesign flag to chromeos settings
>Some chromeos OS settings pages use elements from the browser
>settings. However they do not copy the flags from settings_ui.cc,
>this flag needs to be duplicated over into the
>chromeos/os_settings_ui.cc file manually.
>Bug: 1045167
>Change-Id: I310b65886bbc6830b2d552085a1c2ab6cdadbc36
>Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019342
>Reviewed-by: Jochen Eisinger <[email protected]>
>Reviewed-by: Sean Harrison <[email protected]>
>Commit-Queue: Sean Harrison <[email protected]>
>Cr-Commit-Position: refs/heads/master@{#734938}
Change-Id: I4933295a0747348cb6fe618b9a29abf239c82ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023656
Commit-Queue: Sean Harrison <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#726}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Avoid Grid tab switcher from showing a broken blank page
When the last tab is closed outside of the Grid tab switcher UI, for
example, after tapping "close all incognito tabs" from Android
notification, exit clank to avoid staying in a broken state.
[email protected]
(cherry picked from commit 7d2d7ac4ea402f8baf8b650a8e569bca021e8f64)
Bug: 1028893
Change-Id: Id8a289f578430f330c0af44916d10c52e51404ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024275
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024414
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#725}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M80] Revert URLPattern wildcard to again match some invalid URLs
This is a partial revert of r715320, which changed
URLPattern::MatchesURL to decline to match all invalid
(!GURL::is_valid) URLs. This was an inadvertent behavior change;
it wasn't clear what the intended behavior was in this case.
Reverting this seems to resolve crbug.com/1041880, a bug involving
some PDF loads from blob: URLs getting stuck as gray boxes. While
r715320 was originally made to resolve a crash---namely, MatchesURL
would crash on URLs with empty paths---the follow-up commit r718423
adds logic that will still suffice to prevent this crash (this
is tested by ExtensionURLPatternTest.WildcardMatchesPathlessUrl and
ExtensionURLPatternTest.NonwildcardDoesntMatchPathlessUrl).
Changes:
- URLPattern: revert the behavior change and update documentation
to reflect that intended behavior is actually to allow the wildcard
'<all_urls>' pattern to match invalid URLs
- URLPattern tests: update to reflect the intended new behavior
Bug: 1041880
TBR=[email protected]
(cherry picked from commit 6fbca674993246cd03d7c32c57529596a4baa6c8)
Change-Id: I4f4571c70d0f0dbd7b52cdadbf96a7ea6854cfe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022251
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Devlin <[email protected]>
Commit-Queue: David Van Cleve <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#735510}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023858
Cr-Commit-Position: refs/branch-heads/3987@{#724}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.75
[email protected]
Change-Id: I0ba3a3a2599d59a08f0abe03a413d22469cfbeac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023951
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#723}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[media] CommandBufferHelper: Wait for SyncTokens with kHigh priority.
On Mac, expensive WebGL work blocks progress of video decoding by
preventing the buffers from being released. Scheduling the waits with
kHigh priority appears to work around the problem.
(cherry picked from commit b3e931debba172e4fed006a69a7aac4cfa33682c)
Tbr: [email protected]
Bug: 1035750
Change-Id: I0eeefc0bc256caf6f900b8cf1d32928ca4fca78a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018098
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Dan Sanders <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734736}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023349
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#722}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
M80 merge: Preserve scissor for RPDQs with filters
Cherry pick of https://chromium-review.googlesource.com/c/chromium/src/+/2019804
If the RPDQ has a filter, it's touched pixels are not actually restricted
to the visible rect of the quad. In that case it is incorrect to explicitly
clip the visible rect to the scissor and not set the scissor as a clipRect.
This CL makes it so the scissor is remembered and is applied post-filtering,
so effects like drop shadows are properly clipped to the window content.
Bug: 1035271
Change-Id: I138b1412c55489aa0068cc0ea1744a3248738716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023350
Reviewed-by: Jonathan Backer <[email protected]>
Commit-Queue: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#721}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I7f3546568eeebc61e41856b8208187f1043fd8e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023506
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#720}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.39-1579517256-benchmark-80.0.3987.73-r1 to 80-3987.58-1580123813-benchmark-80.0.3987.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I362a0a744eca0b2467c290ddffe4aca43cab8035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023177
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#719}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.39-1579519088-benchmark-80.0.3987.73-r1 to 80-3987.58-1580122619-benchmark-80.0.3987.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib1e0596d46f6798598cb896d811ed14471c6f5e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023208
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#718}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[HaTS] Don't show HaTS when incognito mode disabled
When incognito mode is disabled, creating an off-the-record profile will
run into a check to make sure incognito mode is enabled. If not, it
leads to immediate crash. Off-the-record profile is needed for showing
the HaTS web dialog. So, this CL adds a check to not show HaTS bubble
when incognito mode is disabled.
BUG=1032459
(cherry picked from commit 1112dc93057069482281b9dae513f0cfcd90bf4a)
Change-Id: I834f776c1239c8f163d6e7607767ba59f5a1d1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961212
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723972}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020896
Reviewed-by: Wei Li <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Commit-Queue: Wei Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#717}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.58-1579518182-benchmark-80.0.3987.73-r1 to 80-3987.67-1580121441-benchmark-80.0.3987.74-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib8660a804e3918cab26a570d4ec1626e18fe3e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023428
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#716}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: Ic12d421d5b8ac0700ed7df76ae6fda9208b40aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022620
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#715}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.39-1579519088-benchmark-80.0.3987.69-r1 to 80-3987.39-1579519088-benchmark-80.0.3987.73-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Idef5f8ac1168e7c07b296625ea34fa81db7572a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022609
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#714}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.58-1579518182-benchmark-80.0.3987.69-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.73-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3c78754e02519c754f04257b2555ce65b2567e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022603
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#713}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.39-1579517256-benchmark-80.0.3987.69-r1 to 80-3987.39-1579517256-benchmark-80.0.3987.73-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I70e134a937817d770c269ca4bc7c19b6b009c757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022602
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#712}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.74
[email protected]
Change-Id: If3212635986a797d1b0f89ce1d7f905cb5aa349d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022245
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#711}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.73
[email protected]
Change-Id: I35c8c49a4c8615f92a2a5c45b6c24b44b30fad09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020410
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#710}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3987.58-1579518182-benchmark-80.0.3987.67-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.69-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Iba484ad16bc9a8dd8c3df10b3d13f65a45344b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021433
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#709}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.72
[email protected]
Change-Id: Id4c18eed3628a7e52a611dfc26efa743aaa8c7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020757
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#708}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Chromoting] Update the heuristic that checks if Screen Capture is available
(cherry picked from commit 83c2b50728a2e30dc74780424586ca3ab3af9b3c)
[email protected]
BUG=1040198
Change-Id: I453e48c84bba191a63f524d81a3817c3c4f5a961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994673
Auto-Submit: Gary Kacmarcik <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730239}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020607
Cr-Commit-Position: refs/branch-heads/3987@{#707}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: Ib36e1088870e1461b41750547e9c2836f6f9df5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019935
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#706}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
sqlite: Backport bugfixes (M80).
(cherry picked from commit 4a9937c9bbbbe99b9c1ecd6b824cb26b2669177b)
Bug: 1042145, 1042578, 1042700
Change-Id: If611c01b0b4e507376d187292809d50b9c786932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006427
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732953}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018244
Cr-Commit-Position: refs/branch-heads/3987@{#705}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.71
[email protected]
Change-Id: I8c965a3119ee66b33d6c98fb029522a7d5aa6181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020303
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#704}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
CompositorView : Revert patch to fix issue with blank page after activity resumption
This CL reverts the changes for recreateTranslucentSurfaceForSurfaceControl.
There were multiple issues due to this change, one being the transition
between opaque and translucent surfaces doesn't happen correctly after
the app is backgrounded and the resulting page seems blank. Secondly
there is a flicker on the screen anytime text selection is used due
to transition between surfaces. Reverting the patch fixes this, although
it gives rise to the original issue in ThinWebView where it goes
transparent after main compositor surface recreation. The safest
thing to do now seems be to revert the changes and land a separate
fix for ThinWebView.
[email protected], [email protected]
(cherry picked from commit 2253339f87ee70eaf7c2e1f96b4a6c6c5a07ed89)
Bug: 1042344
Change-Id: I04dadf17c954c112b547e692f9b7fd1cf265881c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007940
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Khushal <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734177}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019605
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#703}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Introduce ChildProcessSecurityPolicyImpl::Handle.
Merging to M80 branch
This change introduces a Handle object so that Mojo services can
preserve the security state beyond the lifetime of the
RenderProcessHostImpl object. This allows consistent security
checks to occur even during the period when the renderer process is
shutting down and there are still pending Mojo operations in flight.
This will be used to remove all remaining uses of
ChildProcessSecurityPolicyImpl::HasSecurityState() in follow-up CLs.
- Implements new Handle object that allows security checks to provide
consistent results after ChildProcessSecurityPolicyImpl::Remove() is
called.
- Convert blob code to use Handle instead of the HasSecurityState()
workaround.
This is an updated version of https://crrev.com/c/1534368 . Further
discussion of the history and reasons for this CL can be found there.
(cherry picked from commit 4fcbe415172be634fee82ecb300e50f67b27f0b1)
Bug: 1035399, 943887
Change-Id: I6165fad4308643a1ddc845690443e8efceac65f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975165
Reviewed-by: Aaron Colwell <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Aaron Colwell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732296}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015725
Commit-Queue: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#702}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Always allocate extra space for alignment of AudioArrays
Instead of trying an allocation to see if it's aligned, just always
allocate extra space for alignment. We waste a bit of space, but this
should not be huge. Arrays are typically at least 128 floats or more
(the render size), and we need 16-byte alignment so we'll only waste
3% worst case. This simplifies the algorithm too.
This means we don't need the static int that leads to data races.
(cherry picked from commit 7760babc3a1cf49af1f12bad772abfdab2dcbfd8)
Bug: 1042879
Change-Id: I8ac368737ed7679efceae64e2ca867a4de7b493e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011132
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733672}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018254
Reviewed-by: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#701}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Avoid changing search result selection state in destructor
Updating search result selection state while result view is being
destructed does not achieve much (the internal state is about to be
reset either way), and in some paths might end up calling back into
destructing parent view/widget. Clearing the result_ observer should be
sufficient during SearchResultBaseView destruction.
Also, remove ClearResult() from SearchResultBaseView implementations'
destructors (as they all do it, the result can be just reset in the base
class).
BUG=1034630
[email protected]
(cherry picked from commit 71db3f041e38b76135b8dc4e73ca1d183ebfdce9)
Change-Id: Ia33387b6fec1af97045dcc1c69d075d9fda78c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989848
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Toni Baržić <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728994}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019468
Reviewed-by: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#700}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
tracing: Increase string pool block size to avoid crashes
This increases the string pool chunk size used during conversion of
performance traces to JSON on 64-bit machines, to make it less likely
to hit a bug in perfetto's trace processor, which occurs when more than
one string pool block is required.
Bug: 1041573
Change-Id: I0de5517f9b42c5a68fe7ce6f0af7155bb759228a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015050
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#699}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Sheriff] Annotate testTabSwitcherModeTriggeredBeyondThreshold flaky.
(cherry picked from commit 9efad7e43285e8678841a2c1c08b0cbeee891d9f)
Bug: 1040895
Change-Id: I50a839904a6307787f317df51a5a72ab79e3522c
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998404
Reviewed-by: Marina Ciocea <[email protected]>
Commit-Queue: Marina Ciocea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#731318}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019202
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#698}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Sheriff] Annotate testTabSwitcherModeTriggeredBeyondThreshold_WarmStart flaky.
(cherry picked from commit 953e22545cfc79542a30a3d33310829add6eba14)
Bug: 1040896
Change-Id: I6a309468be5c42747025208a73a33c287d6fcbc0
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998183
Reviewed-by: Marina Ciocea <[email protected]>
Commit-Queue: Marina Ciocea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#731315}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019125
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#697}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Speculative fix for a crash in AutofillPopupControllerImpl.
- AutofillPopupControllerImpl::UpdateDataListValues recreates all the view in
the dropdown.
- Later AutofillPopupControllerImpl::SetSelectedLine selects a new line and
passes the index of the previous one. It may not exist.
[email protected]
(cherry picked from commit 92baad33c0b2b8d4c7130304e10db633db70ed64)
Bug: 965025
Change-Id: Ie53b521803dcf33b02602357bda39a30b5ba0f4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995392
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Christos Froussios <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732366}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017371
Commit-Queue: Dominic Battré <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#696}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.70
[email protected]
Change-Id: I94853a4f26328c36e1526cfe4b7671a2a26b379d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017919
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#695}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.39-1579519088-benchmark-80.0.3987.67-r1 to 80-3987.39-1579519088-benchmark-80.0.3987.69-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2bdcf4b8f01c2cbeead8848d99d83f378c315f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017656
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#694}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I1c91d8ca1a2f229360f6c932106406ddd9f7b8f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017674
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#693}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge to M80: Fix issue where double-tap in ChromeVox doesn't open virtual keyboard.
r701284 (http://crrev.com/c/1825104) made a change that synced to the
selection's deep equivalent in editables. That had the side effect
that when linear-navigating to an editable text field, ChromeVox might
be synced to an element inside the editable text field, rather than
the element itself. That meant ChromeVox didn't trigger its logic to
force a click and open the virtual keyboard when getting a double-tap.
The fix is to ensure that logic runs anywhere inside editable text, not
just on the root editable text element.
See also b/143969599
(cherry picked from commit 1a8076b88b9943219c5f84f3b3d4611ecfd3848f)
Bug: 1042902
Tbr: [email protected]
Change-Id: Ib047ec5b5897653df8266517ac29e00c062c4cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007973
Commit-Queue: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733048}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017672
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#692}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.39-1579517256-benchmark-80.0.3987.67-r1 to 80-3987.39-1579517256-benchmark-80.0.3987.69-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I20b9f1ec050c1834e504a6c99d24d5b8eb967cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017651
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#691}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge M80] Revert "[Setup]: Use memory mapped files in LzmaUtilImpl."
This reverts commit f5886456f29378c533237338e6471971b221d3d4.
Reason for revert: Causes slow renderers on startup with bit9
(See issue 1021701).
Original change's description:
> [Setup]: Use memory mapped files in LzmaUtilImpl.
>
> This CL removes usage of LzmaFileAllocator and tries to write unpack
> result directly in the output file.
> When uncompressing a folder that maps directly to a file, this is
> possible and a memory mapping is used. In practice, this is always
> the case. Support for folder containing multiple files is kept as
> fallback and uses a pre-allocated file buffer, which is then copied in
> individual files.
>
> For running full setup install from chrome.packed.7z (Kb)
> Before:
> Setup.Install.PeakPagefileUsage 19748
> Setup.Install.PeakWorkingSetSize 250528
> GetCumulativeDiskUsageInBytes 761134
> After:
> Setup.Install.PeakPagefileUsage 19720
> Setup.Install.PeakWorkingSetSize 250512
> GetCumulativeDiskUsageInBytes 297818
>
> The difference in memory is not significant, but improvement
> are expected mostly for disk usage.
>
> Bug: 933975
> Change-Id: I26c1b118fc512d2caaa8112d3da37e6db460486b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845956
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#709940}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit dfbcf09bd3ad4b6a2431a7c596f7c0c9c0751d8d)
Bug: 933975, 1021701
Change-Id: I478cbb2464638096482601db533465062c4f5454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994905
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Reviewed-by: Etienne Pierre-Doray <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015605
Cr-Commit-Position: refs/branch-heads/3987@{#690}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.58-1579518182-benchmark-80.0.3987.67-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.69-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If0acd4b5ba9c54c200b1fe84720afeff090c0c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015965
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#689}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[DFM] Have doDeferredNativeRegistrations() called earlier.
For DFMs, Module.getImpl() loads native {libraries, resources} if they
exist. This needs Chrome's main library to load first. However, the VR
DFM calls getImpl() even earlier than that. The existing solution has
getImpl() defer native {libraries, resources} loading initially. Then
after Chrome's library loads, Module.doDeferredNativeRegistrations() is
called, causing all deferred native initialization to take place.
Between Chrome main library load and doDeferred...() call, any code that
calls getImpl() must NOT expect native {libraries, resources} to be
available. But this is what happens when a DevUI page is reloaded by
tab restore: getImpl() gets called, with the caller expecting resource
load to take place. But since doDeferred...() is not called yet, the
resources were not loaded, and failure ensues.
This CL fixes the bug by moving the doDeferredNativeRegistrations() call
to an earlier time.
[email protected]
(cherry picked from commit 5f39dcabb27264e45917a4e80d070bc9bcb544db)
Bug: 1036753
Change-Id: Ib326eba6b3206fd14efdd143635906e71dad654b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008326
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Fred Mello <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733682}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016324
Reviewed-by: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#688}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M80][Signin][Android] Mark sync setup flow as finished from ForcedSigninProcessor
This CL fixes ForcedSigninProcessor by marking the sync flow as
completed after a forced sign-in.
[email protected]
(cherry picked from commit c5404d69de1f939c0b26b97cf9568fdc8583ac26)
Bug: b/146775602, 1044661
Change-Id: I5ea64edb79a975ff37ec5d19650534b5ac8c2cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013100
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#734026}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017424
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#687}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3987.58-1579518182-benchmark-80.0.3987.64-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.67-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I765e8ea4bf7c0c34a5a926eb0cfbe9fa182bfd60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015964
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#686}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.69
[email protected]
Change-Id: I8feecd66107dbe69e4c3e64278606ddc148b8ed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015573
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#685}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add ChromeAppIconLoader back to Load icons for extensions in Shelf for M80.
There are some special extensions, e.g. hangouts, pen-as-Popup and
Speakeasy, opening windows when launch. But extensions are not managed
in AppService, so extensions icons are not added to Shelf when launch
those extensions.
Add ChromeAppIconLoader back to Load icons for extensions in Shelf.
Add LauncherExtensionAppUpdater to handle the extensions life-cycle
events.
BUG=1041493
BUG=b:147424621
(cherry picked from commit 0bd5b1a3d58e7e199bd7f3edf5e6e94e99cb8a45)
Change-Id: Ia30440568c0920060aac479ad92ee54f81fceb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006847
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733809}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015902
Cr-Commit-Position: refs/branch-heads/3987@{#684}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge to M80] x11: Fix regression in IME when arbitrary keycodes are used
After crrev.com/c/1789603, KeycodeConverter::DomCodeToNativeKeycode() is
used to translate back XKB hardware keycode out of DomCode. Such
function does not properly handle cases like the one described in
crbug.com/1033080, where xcape tool [1] is used in conjunction with
xmodmap to make an ordinary key act as an extra modifier.
This change fixes it by passing original XKeyEvent's keycode through
Event::Properties to GtkUi instead of trying to figure it out of Event's
DomCode value.
[1] https://github.com/alols/xcape
(cherry picked from commit 2f54c1d59fba13067078c5297ee27d1312066072)
Bug: 1033080
Change-Id: I0878eecdb9765b50111c08242aa96220d13d9216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003871
Commit-Queue: Nick Yamane <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732364}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014761
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#683}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M80 Merge] Check the Drive integration service is mounted before use
In guest mode, the Drive integration service exists, but it is not
mounted or enabled, meaning some operations on it will lead to a crash.
Use drive::util::GetIntegrationServiceByProfile instead of going through
the factory, as it also checks if drive is mounted.
(cherry picked from commit a6cc2f828952d8631018aaa2ab9dbe62667b16d5)
Bug: 1029477
Change-Id: I5f3e71ee7e788507613f5fe6f158db4e0c4add87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011467
Commit-Queue: Austin Tankiang <[email protected]>
Auto-Submit: Austin Tankiang <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733890}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015861
Reviewed-by: Austin Tankiang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#682}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I2b419502640c3d9e08c2f4187c3cadbebc100290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015225
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#681}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M80 merge] webgl: Resolve MSAA buffer for low latency
When using low latency MSAA resolve was gated by
swap chains. ChromeOS does not use swap
chains. Move the resolve to before checking
for swap chains.
Test: https://codepen.io/miguelao/pen/WKZaqd
(cherry picked from commit af7a33d94dddfdb0a9efede2319a30e0047bae74)
Bug: 1025747
Change-Id: I344c8576c16277348950836a3fc28a58f787a256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003073
Auto-Submit: Fritz Koenig <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732882}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015360
Cr-Commit-Position: refs/branch-heads/3987@{#680}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.39-1579519088-benchmark-80.0.3987.64-r1 to 80-3987.39-1579519088-benchmark-80.0.3987.67-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibbcb03a996df877ebc70842f0ce2ae3c9c146971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015541
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#679}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.39-1579517256-benchmark-80.0.3987.64-r1 to 80-3987.39-1579517256-benchmark-80.0.3987.67-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9c34d847c4c6654239330e0c42eeeb4e520ed6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015383
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#678}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.58-1579518182-benchmark-80.0.3987.64-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.67-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibe025618cedc12c727ab1334c7ceba2e5d4b1323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015382
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#677}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Disable Drive integration for incognito.
https://crrev.com/c/1926146 introduced a bug that
util::IsDriveEnabledForProfile() might return true for incognito
profiles that are associated with Gaia user that leads to crashes.
Previously such check existed in IsProfileAssociatedWithGaiaAccount()
but was mistakenly treated as redundant.
(cherry picked from commit bccbc7a538d901a8ab73b5c2ea415ac3e160067a)
Bug: 1034621
Change-Id: I041b418f16204db4680645e7cd8a3321da3ebc2d
Tests: Manual.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003852
Auto-Submit: Sergey Poromov <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732408}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014440
Reviewed-by: Sergey Poromov <[email protected]>
Commit-Queue: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#676}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3987.58-1579518182-benchmark-80.0.3987.63-r1 to 80-3987.58-1579518182-benchmark-80.0.3987.64-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I2122c221e4042e16fca6910d60f38981fe1ef316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015001
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#675}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Added a check against a race condition that would cause a request to...
... be removed before the bubble is shown.
The exact conditions that trigger the race condition are unknown, I've
not been able to reproduce the issue reliably enough to investigate.
It appears that before `ShowBubble` gets to run, something happens that
calls `FinalizeBubble` which removes the request. It happens so rarely
that the DCHECK we have in place has not surfaced the issue.
(cherry picked from commit 230cba31de3910fa60cb6eb46470b145874c4cb9)
[email protected]
Bug: 1041222
Change-Id: I0413fa70c77f2a24e17646b21d40ad9fa1cec69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000754
Commit-Queue: Andy Paicu <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013282
Reviewed-by: Andy Paicu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#674}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[merge-m80] Pass FilePath to auto_screen_brightness..::GetModelSavingSpecFromProfile()
Currently it takes a raw Profile* which creates a thread safety issue,
resulting in flaky browser_tests crashes on the official ChromeOS bot.
(cherry picked from commit e47a1e126cab9192ecf81d32dd1314156509131c)
Bug: 1041039
Change-Id: Ia80e317fda9c60690b5b9e444ded8b2c611a0542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999883
Reviewed-by: Jia Meng <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#731082}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012363
Commit-Queue: Jia Meng <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#673}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.68
[email protected]
Change-Id: I3bd972288e2d797a5840c0846f21551358e9a867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014121
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#672}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge M80] Fix incorrect escaping of LTR ShortFormModifiers text
On Mac, the shortcut text is created with:
shortcut = ApplyShortFormModifiers(...)
while on other platforms:
shortcut = ApplyLongFormModifiers(shortcut);
The ShortForm should *NOT* be processed by the RTL hack.
The fix made to shortcut text on MAC triggered the bug.
https://chromium-review.googlesource.com/c/chromium/src/+/1876468/2/ui/base/accelerators/accelerator.cc#b239
The size of the shortcut is no longer 2, but 1 insteaad.
For details of the bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1038321#c3
The bug fixed previously revealed an other bug here. :)
(cherry picked from commit 08bd13aeeb7e1356f95de303843c41f3b6742b65)
Bug: 1038321
Change-Id: I4762557d1ffdec783fde4f211c9484a23bddfd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990127
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729359}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003214
Cr-Commit-Position: refs/branch-heads/3987@{#671}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add thumbnail_aspect_ratio variation flags
This CL adopts the aspect ratio from Finch to thumbnail size. If the
JPEG has different aspect ratio, regenerate the JPEG file from the ETC1
file.
Integration with tab_grid_layout_android_new_tab_tile variation is also
added.
Everything introduced in this CL is gated by field trail under the
enable-tab-grid-layout flag. And most of the Java part is verified to be
behind the gating functions
FeatureUtilities.isTabThumbnailAspectRatioNotOne() and
FeatureUtilities.isAllowToRefetchTabThumbnail() by formal equivalence
checking tool here: http://crrev.com/c/1934235. Note: the tool does not
support native yet.
[email protected]
This is based on http://crrev.com/c/1990214/14.
(cherry picked from commit 7081986eb0bbfa4a8bcd237f2ae3d061f10972b3)
The cherry-pick to M80 is from http://crrev.com/c/2007946/8.
The change ID is: I5db65a72b7c56a4546491a13d43872b46ee6e55b
(cherry picked from commit e9fe5470bf44c1b7ce646102d005c1a4cd5d2eff)
Bug: 1041536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003825
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#732324}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006614
Reviewed-by: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3945@{#1054}
Cr-Original-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Change-Id: Ia2cd74d6ccfead1d9c9bb9db7750acb43f243e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014151
Cr-Commit-Position: refs/branch-heads/3987@{#670}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[cros-fuzzy-app] Enable fuzzy app search by default
This CL enables fuzzy app search by default.
[email protected], [email protected]
(cherry picked from commit 535cbeb73197d41a5694bde1017ff0435db4a7c1)
Bug: 1043670
Change-Id: I934aeb5f4290a4a4849936d53ba44567f2a69ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006988
Commit-Queue: Thanh Nguyen <[email protected]>
Reviewed-by: Jia Meng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#733007}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012373
Reviewed-by: Thanh Nguyen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#669}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add a range check when restoring tabs in TabListMediator
When user switches between light and dark mode, incognito tabs are
dumped and then restored. This exposes a missed range check in
TabListMediator. When restoring an incognito tab group, the tab is
added to TabModel but corresponding PropertyModel is not yet added to
TabListModel, which leads to a temporary async. This async is also
exposed in other cases where we try to sync TabListModel with TabModel
through restoring, e.g. exiting multi-window mode. This CL fixes this
issue.
[email protected]
(cherry picked from commit ba1e82db0e3d7d6427289fb12899b0a54b92c15b)
Bug: 1034385, 1034921
Change-Id: I3e712070cb3455a38d43cb7dae74adc68ebf65e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970735
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#731567}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013867
Reviewed-by: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#668}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
M80: Don't update PIP bounds when always on top is set
This is a cherry-pick to M80. As it's not a clean cherry-pick,
I manually resolved the merge conflict and confirmed PIP worked well.
CTS requires a PIP window to stay at the initial position that
Android calculates. However, Chrome sometimes adjusts the bounds
unexpectedly when always on top is set because setting always on
top triggers UpdatePipBounds, and depending on the density, the
initial bounds is adjusted by one pixel.
With this CL, PIP bounds update is deferred while always on top is set.
Other possible ways to fix this issue are:
- Don't update PIP bounds for WM_EVENT_ADDED_TO_WORKSPACE.
- Ignore bounds change for PIP if it's one (or a few) pixel difference.
Note, changing bounds calculation logic on either Android or Chrome
side so there's no gap between the bounds calculated by them doesn't
work because because DP -> pixels is not a surjection and Chrome may
be unable to place the PIP window in the place Android wants (and
vice versa).
BUG=b:147396441
BUG=b:145881485
TEST=atest android.server.am.ActivityManagerPinnedStackTests
TEST=#testEnterPictureInPictureSavePosition
(cherry picked from commit 2cfa2e41953ce67c52f431c1fcd79e8fd33a7865)
Change-Id: I60bfef4620459c0d3f604d3c1641864fc589c1a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969090
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Kazuki Takise <[email protected]>
Auto-Submit: Kazuki Takise <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006845
Reviewed-by: Stefan Kuhne <[email protected]>
Commit-Queue: Eliot Courtney <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#667}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.67
[email protected]
Change-Id: I24650da2050340a0620dcf813af1c5b073b40dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013868
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#666}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge M80 [ios] Fix tabgrid buttons when using VoiceOver
Previously, the "Close All" and "Done" buttons were not
being updated when using VoiceOver and switching panels
in the tab grid. Additionally, the incognito tabs were
not being hidden in the app switcher (when using VoiceOver).
The problem was that the buttons are being configured in
the scrollview animation completion code. VoiceOver turns
off animation, so the buttons are not being properly
configured when using VoiceOver. Same goes for the incognito
hiding code.
This CL fixes this issue by calling the button configuration
and incognito content visibility update methods from the
VoiceOver codepath.
[email protected]
(cherry picked from commit 59b8bcd3d85b7b6e063ffd247eba063cc4f31241)
Bug: 1038010
Change-Id: If76127096638f73283b54a0b1be952b0479d3b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001838
Reviewed-by: edchin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#731992}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013651
Cr-Commit-Position: refs/branch-heads/3987@{#665}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add new tab tile variation to GTS
This CL introduces a new tab tile that always shows in the end of tab
list in GTS. Clicking the new tab tile will create a new tab. New tab
tile does not support any gesture and exists for both normal and
incognito mode.
Everything introduced in this CL is gated by field trail under the
enable-tab-grid-layout flag.
Light mode: https://drive.google.com/a/google.com/file/d/1B-8y4P3Pg-gyv9Z1eJ8wRP2PqEOHy-bV/view?usp=sharing
Dark mode: https://drive.google.com/a/google.com/file/d/1DLwfIoDcfDfG2zyzLoiRigivYotauT87/view?usp=sharing
[email protected]
(cherry picked from commit 792dc650c131c4ffb4bc26ae0461c32dc372ca9a)
Bug: 1042304
Change-Id: Ia7bbb33ec8a93e0cd72e8d6e1c3663818c4ece8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003924
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3945@{#1053}
Cr-Original-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007872
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#664}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
AppIconLoader should refetch shelf item icons on user switch
When active user changes, the old app icon loaders are reset, and the
currently loaded app icons are discarded. This means that they have to
be refetched while rebuilding pinned icons for the new user.
Adds back ChromeLauncherController::OnAppUpdated (called from
UpdateAppLaunchersFromSync() during user switch), and re-purposes it
to ensure an icon is loaded for pinned apps.
BUG=1040486
[email protected]
(cherry picked from commit cfbde4a5cb94dc5b2b13819a951b4675881c75ec)
Change-Id: I553af66cd5fc2e1df9e285fff45290605eee58a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005228
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Commit-Queue: Toni Baržić <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#732973}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012364
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#663}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
