Publish DEPS for 80.0.3987.53
Incrementing VERSION to 80.0.3987.53
[email protected]
Change-Id: I5a98b5dd3fc4a97538bf1b1b67278cdc6477d8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999243
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#504}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Revert r702352 to fix issue with visual overflow recalc
The change in r702352 was causing issues in some situations,
when an inline element has some changes that cause an overflow
that should be visible in a scroller.
Problem is that we're no longer calling
MarkSelfPaintingLayerForVisualOverflowRecalc() after r702352
and the visual overflow is never recalculated.
This revert changes the call
in NGBlockNode::CopyFragmentDataToLayoutBox() to the original one,
to SetNeedsOverflowRecalc().
Due to that change we need to disable NeedsLayoutOverflowRecalc
unit test as it's now failing.
We added a new test case to prevent a similar regression in the future.
BUG=1036644,941180
TEST=fast/overflow/visual-overflow-recalc.html
(cherry picked from commit 20f5e5708d7d5da0b4450036051f8606f2bb3895)
Change-Id: If205d08281ca0186559715a788b132850e3cbdd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992423
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Manuel Rego <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729750}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998758
Reviewed-by: Manuel Rego <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#503}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge to M-80] Fix a crash on Windows when saving the stale content of an evicted app window
This is only supported on ChromeOS, so make it conditional and follow
the example of Browser::ShouldShowStaleContentOnEviction():
https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?dr=CSs&q=Browser::ShouldShowStaleContentOnEviction&g=0&l=1453
[email protected]
BUG=1036760
(cherry picked from commit f28943908ef06a5704d2b4a86d07ad1e989bc8d4)
Change-Id: Idcf003483600046a4e64ebe0b681bbdb30b8449a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992515
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729809}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998007
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#502}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Enable TextFragmentAnchor finch experiment for webview
Fixes the field trial config as required for cl/285264679
(cherry picked from commit 39f1d4c1e820c9386cb8779d7705626d32f9fe50)
Bug: 978139
Change-Id: Iade5a7f945d8363ca274a0f61cfe34e5a0bb0e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993942
Auto-Submit: Nick Burris <[email protected]>
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Brian White <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730232}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995701
Commit-Queue: Nick Burris <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#501}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Double-check signatures on verified chains
CryptoAPI allows third-parties to override a variety of functions,
potentially returning invalid chains. Add an extra signature check
to make sure the chain is reasonably sensible. This isn't perfect,
but is enough of a safety check until we switch to our verifier or
tighten down the blocking of 3P modules, even for CAPI.
[email protected]
(cherry picked from commit bd3442a4957d0a185bdeaf65649d15926f412add)
Bug: 1040772
Change-Id: I75ded0932e32b1abf23969d6c6bd9744b72f1a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994434
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730368}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998970
Cr-Commit-Position: refs/branch-heads/3987@{#500}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
cros: Fix tooltip color regression
http://crrev.com/c/1931756 has changed tooltip colors to match the
current theme (black text on white background with light theme) which
makes sense for browser tooltips, but not shelf tooltips.
This CL unlinks the shelf tooltip colors from the theme and uses
MD color values suggested by UX.
[email protected]
(cherry picked from commit f8397a142d38bd54b775613de7ab645cd956e6ba)
Bug: 1034936
Change-Id: I08e636e86cc9cff761ca53ab2c7a9b00f9852ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995934
Reviewed-by: Manu Cornet <[email protected]>
Commit-Queue: Vladislav Kaznacheev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730689}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997650
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#499}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.52
[email protected]
Change-Id: I348bf390d409567ace6a5fdd62b483713ffb033b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998969
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#498}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Use a WeakPtr in SpeechRecognizerImpl::AbortRecognition
It seems that during shutdown, the object can go away before the posted
task runs.
Thanks to Miyoung Shin for looking into this.
(cherry picked from commit 57f988dd7c1f63f59b44282efcc9e6f1e85ac19c)
Bug: 1018677
Change-Id: I1b3c7947eb3110ae6538249106a87f5c56f6238c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989069
Reviewed-by: Primiano Tucci <[email protected]>
Reviewed-by: Tommi <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Olga Sharonova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729694}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998316
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#497}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
overview: Ensure that the drop target is created on the correct display
The drop target shall be created on the root window of the dragged
window, instead of the root window matching the dragged window's bounds.
These two root windows are usually the same, but you can move a window
so that it belongs to one display and its bounds are mostly on another.
[email protected]
(cherry picked from commit 912f546dabfa1601320cc7aca99bf15a13a80f99)
Fixed: 1033605
Change-Id: Ic3adeb1d002d41646d3c9d32e70a9408c6337b73
Bug: 1033605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966491
Commit-Queue: Avery Musbach <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724833}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997648
Reviewed-by: Avery Musbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#496}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Revert "[AW] Always schedule variations seed download jobs when a seed is requested"
This reverts commit 5e8d35cfa876f922869833689a18ea426caf4562.
Reason for revert: Caused a possible seed freshness regression.
Original change's description:
> [AW] Always schedule variations seed download jobs when a seed is requested
>
> We don't currently schedule a seed download in WebView if the previous
> download occurred less than 24 hours ago, which can add an additional 24
> hours to the time between seed downloads. This CL reimplements the 24
> hour throttle to be a delay in the scheduled job, meaning a job will
> always be scheduled when a new seed is requested, but Android will only
> run the job once 24 hours have past since the last download.
>
> This CL also adds a missing hamcrest dependency to
> //aw/test:webview_instrumentation_test_apk
>
> Test: ninja -C out/aw webview_instrumentation_test_apk
> Test: out/aw/bin/run_webview_instrumentation_test_apk -f 'AwVariationsSeedFetcherTest#*'
> Bug: 979075
> Change-Id: I0ea1cc8197f66b77634e8de2b145fe4228c74067
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906121
> Reviewed-by: Changwan Ryu <[email protected]>
> Reviewed-by: Nate Fischer <[email protected]>
> Commit-Queue: Robbie McElrath <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#716305}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 414a8333061122c7f57d2e7f1c34db9da5b15cfe)
Bug: 979075
Change-Id: Iac6d048bdad48ae4bad004c5e6d27d37335cdb68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994645
Reviewed-by: Robbie McElrath <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730308}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997647
Cr-Commit-Position: refs/branch-heads/3987@{#495}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fix an issue that a new download can be started more than once
For download service, it could issue multiple DownloadUrl() calls to
the download system that have the same GUID at the same time.
This CL fixes the issue by checking the GUIDs that are already pending
or are already persisted in the DB, so that the same GUIDs cannot be
used to create a new download.
BUG=1029746
[email protected]
(cherry picked from commit 79deaaf29fb84b0c03e9f11846bdcf8b65d6c3b3)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980758
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728709}
Change-Id: I010c1cb742f21744fed87d5a4e3608a6aaaae5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993752
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#494}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fix a GPU watchdog V1 bug on X11
The GPU watchdog will not crash if we're not on the TTY of our host X11
server. But simply doing return without calling OnAcknowledge() will
stop the watchdog. Add OnAcknowledge() before return to fix this bug.
[email protected]
(cherry picked from commit 6ae1ff5b2c633e61bdef8eb73af8a06a05074db4)
Bug: 1036444
Change-Id: I6d6ce9ebf57a4d7fa2b6f88162afa3a2cb2689d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977307
Commit-Queue: Maggie Chen <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#726890}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998035
Reviewed-by: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#493}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.18-1578309343-benchmark-80.0.3987.50-r1 to 80-3987.39-1578913853-benchmark-80.0.3987.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I93d40502686e92a6880224c7d0706aa189849717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998225
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#492}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.18-1578306862-benchmark-80.0.3987.50-r1 to 80-3987.18-1578913620-benchmark-80.0.3987.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Idaa50efd2ee4f1d0cfccf379f55807fef816f414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998226
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#491}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.18-1578308706-benchmark-80.0.3987.50-r1 to 80-3987.39-1578912620-benchmark-80.0.3987.51-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Id8b7653364037522a197c249c2444f8a80c23bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998224
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#490}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Start Surface] Show on HomePage and Tabswitcher button.
Show HOMEPAGE, when entering Start Surface through Home button in top or bottom toolbar.
Show TABSWITCHER, when entering through Tabswitcher button in top or bottom toolbar.
Allow for switching between the HOMEPAGE and TABSWITCHER surfaces when both buttons are visible.
Not switching to Tabswitcher bottom bar in start surface.
Screenshots: https://drive.google.com/drive/folders/1E4VDh_QA8Ac3MJ3R3ORflMKFaampHnJu?usp=sharing
In follow up: New top tabswitcher toolbar for Start Surface.
Full UX design here: go/clank-start-ux
(cherry picked from commit ec1b4286a8554229ae77e5129d86310467514c09)
TBR: [email protected]
Bug: 1025296
Change-Id: Ib6058596355125f682ab18f30731c01effada667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956187
Commit-Queue: Mia Glaese <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#727604}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996992
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#489}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add a null check for preconnect client
This was causing some test crashes when turning on the feature. We
should merge it back if possible.
Also, treat occluded visibility state as hidden.
(cherry picked from commit 18bbf76df6e7957f94e3a319439856fb0f3fb05a)
Bug: 1040306
Change-Id: I407bf00d43e7e0df5f5bd00b00764aebb285391b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992806
Commit-Queue: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729606}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997843
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#488}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge to 80] [omnibox] Fix crash from logging selected_index == kNoMatch (-1)
This CL made it much more likely that OmniboxPopupModel::selected_line()
could return kNoMatch (-1):
https://chromium-review.googlesource.com/c/chromium/src/+/1906882
But when we put kNoMatch into a size_t index, we get the maximum value
size_t, i.e. 0xffffffff. That just overruns the results array and reads
garbage memory.
Instead we should ignore the popup when we are selecting a match that's
not from the popup (no default match case).
This CL does that, and adds a DCHECK to OmniboxLog to prevent this from
happening again.
(cherry picked from commit a55b91661d7290d6abe25dae772609df64874d6d)
Bug: 1034946
Change-Id: I989c139c9a9b9525555424987124627130f0a5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989517
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729801}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995959
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#487}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3987.18-1578308706-benchmark-80.0.3987.49-r1 to 80-3987.18-1578308706-benchmark-80.0.3987.50-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I43c24a85e41553202ca07cd5df1228baff161dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997620
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#486}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge to M80 release branch: Allow iframes on a different domain than the top-level to get desktop media through the Hangouts services extension.
This is based on the workaround found in issue 425344.
[email protected]
(cherry picked from commit 047d19151b4bbcbf3a5681074ee71a146fe040c3)
Bug: 1039351
Change-Id: I57cb33dc93af81f7f971d2b69edc582dfc243792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989026
Reviewed-by: Henrik Grunell <[email protected]>
Commit-Queue: Alex Zhao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729390}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995472
Commit-Queue: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#485}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
sqlite: Backport Bugfixes (M80).
(cherry picked from commit c9b98f55e822079f00266d0118a004be49e1fb89)
Bug: 1033461, 1037786, 1038213, 1038863
Change-Id: I22b98c909e9af632818bed4e49f96b028f1dcf28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990216
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995773
Cr-Commit-Position: refs/branch-heads/3987@{#484}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.51
[email protected]
Change-Id: Idbac6f2183ab564fd29af9b1256b6e6dac258c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996983
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#483}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.18-1578306862-benchmark-80.0.3987.49-r1 to 80-3987.18-1578306862-benchmark-80.0.3987.50-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I7c0c4e4e720371d3bffc9a93c9378636e4129b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996171
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#482}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.18-1578309343-benchmark-80.0.3987.49-r1 to 80-3987.18-1578309343-benchmark-80.0.3987.50-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Ib0451374836d6b51ed1af53689016fb38eb95c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996170
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#481}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.18-1578308706-benchmark-80.0.3987.49-r1 to 80-3987.18-1578308706-benchmark-80.0.3987.50-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I2f0de43990349e0d947040bb058ea16ffb5c4788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996169
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#480}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3987.18-1578308706-benchmark-80.0.3987.48-r1 to 80-3987.18-1578308706-benchmark-80.0.3987.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I36a04a529db8e426027eb868e123f691a22d14a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996050
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#479}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll ChromeOS orderfile from 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 to 80-3987.18-1578308706-benchmark-80.0.3987.48-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ia5bdf46e7d24d1a7e00a2c5d1344fe79a83dfabc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996519
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#478}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.50
[email protected]
Change-Id: Id66fae256bc2d439811b4b72a700fce28bb043a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994153
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#477}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3987.18-1578306862-benchmark-80.0.3987.48-r1 to 80-3987.18-1578306862-benchmark-80.0.3987.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I01269d051f7f3e2b624f641271498394056ffa98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995125
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#476}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3987.18-1578308706-benchmark-80.0.3987.48-r1 to 80-3987.18-1578308706-benchmark-80.0.3987.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Idc92ead12a4b21ab327e703bbac0dca9b791166e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995123
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#475}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3987.18-1578309343-benchmark-80.0.3987.48-r1 to 80-3987.18-1578309343-benchmark-80.0.3987.49-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I60b57d09f049d86d209e35859a902916b6f7e762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995122
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#474}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Revert "Prevent user from saving invalid printer configuration input"
This reverts commit 5c202a24d209669bed1e3b357c3946cb8475dfa2.
Reason for revert: Regression for printer selection dropdowns
http://crbug/1036242
Bug: 1036242
Original change's description:
> Prevent user from saving invalid printer configuration input
>
> -Add a flag to cr-searchable-dropdown so we can track whether the user's
> current text input in the dropdown matches the previously saved value.
> We use this flag to disable the printer add button if the user typed
> invalid input into either the Manufacturer or Model dropdown.
>
> Fixed: 950887
> Change-Id: I1f632b80fd8619718f13f8a5f5332ad7a62eb69e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880181
> Commit-Queue: Gavin Williams <[email protected]>
> Reviewed-by: Bailey Berro <[email protected]>
> Reviewed-by: Steven Bennetts <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#710888}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 42acfeb0e80264ed356ebb63e42ffc82b52f2384)
Change-Id: I8e99b10036de19bbcf02998b164a6702947a689c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994060
Commit-Queue: Gavin Williams <[email protected]>
Commit-Queue: Bailey Berro <[email protected]>
Reviewed-by: Bailey Berro <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#730298}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995936
Cr-Commit-Position: refs/branch-heads/3987@{#473}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[IndexedDB] Fix blob key generation
R=[email protected]
[email protected]
(cherry picked from commit c909462fb32555a3820c9c328d99c87c838eb092)
Bug: 1039446
Change-Id: Iac1a5e227639441831510c7fd74b5c74bf98fd4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989987
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: enne <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729144}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995750
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#472}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge M80] [Android WebAPKs] fix A2HS dialog maskable icon padding
A previous CL broke the proper masking of adaptive icon in add to
homescreen dialog from app banner. This CL fixes it.
The add to homescreen MVC refactoring has made it easy to merge the code
paths for masking icon from app banner and from app menu, so this CL also
merges the 2 (which is basically reverting
https://chromium-review.googlesource.com/c/chromium/src/+/1869151).
(cherry picked from commit 8cd1fd5d988706bcb3642d7374121f59ab8187c8)
Bug: 1040631
Change-Id: I9ba9a65009bfdf7cd611f2f3cdd8d2203e72d281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977822
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Henry Jian <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729109}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995479
Reviewed-by: Peter Kotwicz <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#471}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Refresh Public Suffix List to the latest version.
This updates from revision
c3a44bfc61dcf0feb1cc0e37a95fb281799d43c6 (2019-05-24)
to revision
d8985509a9df2c25f5118f9d1e41a24f9739bd1f (2019-12-09)
[email protected]
(cherry picked from commit c1dd1b8ee556b67adbbcdb72b77a83efd17feab8)
Bug: 1031894
Change-Id: If91aff8fc13c07703f3f0609f5a0860b8a0ce0cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959929
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723857}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993730
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#470}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.49
[email protected]
Change-Id: I23f04e5662c23f595ab4cade65663e8478f0a922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994145
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#469}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: I979042d749632e6608fa9327bcb03187c8cbea5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995476
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#468}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge M80] [base] Enable kNoPriorityInheritanceFromThreadPool by default
This is a safe change to make on trunk and merge to M80 to fix the
release-blocker. It was going to be a trunk change in November and has
been live 50/50 since. It was only an experiment to measure perf
impacts (which turned out to be nil).
Experiment results:
https://docs.google.com/document/d/13PIBPuSPJbrgHAgyRbY22EWAfH2narnxpa_CgBmZbSY/edit#heading=h.4fo2tzjehwu7
I will follow-up with the true code cleanup after since this CL is a
merge candidate for M80.
[email protected]
(cherry picked from commit 34ade6be0fef2183fc21099773ac60462019b477)
Bug: 1022972, 1039576
Change-Id: I7d3dc970ad02808d059865784067684573ece3d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992160
Auto-Submit: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: François Doray <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729766}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994429
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#467}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Always synchronize interrupted scroll animation bit
It happens sometimes that the |scroll_offset_animation_was_interrupted|
bit is set on a keyframe_effect at the same time that it's keyframe
models are removed. When this happens, the |interrupted| bit never gets
reset due to the early exit in PushPropertiesTo. This leads to the
scroll offset in the pending tree constantly clobbering the value in the
active tree, leading to scroll jumping.
This CL makes it so that we unconditionally push and reset this bit to
avoid this issue.
[email protected]
(cherry picked from commit ac59dc00a2ad94be8ae729be8bd8de865ef7d239)
Bug: 1038039
Change-Id: If0abc5c9b89444a9e4f8711c2441e0485c241b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985133
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729092}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995471
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#466}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge M80: "Neuter DefaultDecoderFactory after MediaFactory destruction."
Since we started allowing asynchronous stop of media::PipelineImpl, we
have released the DefaultDecoderFactory on the media thread assuming it
was safe to continue usage after ~MediaFactory. It turns out this is not
the case for the MojoDecoderFactory used by DefaultDecoderFactory.
To fix, we now neuter the DefaultDecoderFactory in ~MediaFactory to
prevent decoders from being created. This is done under a lock since the
decoder creation methods are called from the media thread and
~MediaFactory happens on the render thread at time of ~RenderFrame.
TBR=xhwang
(cherry picked from commit 7b100c28d219f682763522ed0a3e30e231c1176b)
Fixed: 1029865
Test: Existing tests all pass.
Change-Id: Ie214fb5eee12dd76a1d21e10497d2cb96ed0397a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990200
Auto-Submit: Dale Curtis <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995465
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#465}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll broadwell AFDO profile from 80-3945.42-1575284288-benchmark-80.0.3964.0-r2 to 80-3987.18-1578306862-benchmark-80.0.3987.48-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: If6526445568d447f0dac7fde1bc365f92ae79fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995591
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#464}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll silvermont AFDO profile from 80-3945.42-1575283012-benchmark-80.0.3964.0-r2 to 80-3987.18-1578308706-benchmark-80.0.3987.48-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Ide725ace54b42f5c1abbaa945010d178796a7210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995588
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#463}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Roll airmont AFDO profile from 80-3945.42-1575285749-benchmark-80.0.3964.0-r2 to 80-3987.18-1578309343-benchmark-80.0.3987.48-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: Ie1d3c50325514e43de1d0945992edf662559da60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995589
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#462}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Fix a crash in the leak detection dialog on dismissing it.
CredentialLeakDialogView::Accept nulls the controller and creates a new tab.
During tab creation the framework may call some methods on the view to get its
title or buttons. Previosuly that led to a crash.
It doesn't matter what to return in those methods because the dialog is being
destroyed anyway.
[email protected]
(cherry picked from commit 2ad906a85e5e4cd96ebd482da795fb10286b8650)
Bug: 1039452,1036422
Change-Id: I985b7e79ac78431e216d3f27de001683846a29b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991563
Reviewed-by: Friedrich [CET] <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729395}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995331
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#461}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add chromium-release-autoroll to AUTHORS bypass, clean up old entries
This is needed for rollers onto M80 branch.
(cherry picked from commit 66150e533e1f2c471a00584ee187ca459a6e2197)
Bug: skia:9730, chromium:1040070
Change-Id: I7677d424667ddbc3b35ab3823dddf3ef698bf8c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990205
Reviewed-by: Tiancong Wang <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Eric Boren <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729291}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990311
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Tiancong Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#460}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[Merge M80] Revert "Add BreakLists for layout text in RenderText"
This reverts commit ee7c76abc9016939e4f112615d6eec5ee9b5cbd7.
Bug: 1033194
Change-Id: Ie0dd12fd86a5266ca8d4671c39000a114431ea67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989063
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#459}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Avoid deleting NetworkHistory when using a whitelist
NetworkHistory doesn't support filters yet.
(cherry picked from commit 0f7c573854f06cb23f4e81a1beadc654ccb1aaab)
Tbr: [email protected]
Bug: 1040065
Change-Id: I38a0f5ff32cfcaf608f276d3f40932fff36a6afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985971
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729330}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993961
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#458}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Move browserProxy_ assignment in site_data.js to created instead of ready
site_settings/site_data.js has a simple property observer method that
is dependent on a local variable assignment (browserProxy_) that occurs
in the ready function. As per the Polymer documentation this occurs after
property values have been configured. As a simple observer is fired the
first time the property becomes defined, this occurs prior to the ready
function.
This CL moves the required assignment to the created function, which
fires before properties have been initialised. The assignment of the
browserProxy_ is not dependent on the Local DOM existing as thus is
appropriate for inclusion in the created function.
(cherry picked from commit 4003e4367ad3fb25860609a5471cf7b727f0ee52)
Bug: 1038873
Change-Id: I1fbc0291b2b34bc947e14f48a41ce8fa4f87f155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983177
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729273}
TBR: [email protected],[email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993354
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Martin Šrámek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#457}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
DevTools: check session can inspect URL we're about to navigate to
[email protected]
(cherry picked from commit 0788b1d419f78050f1114fffefd1f68cd88d1dab)
Bug: 1030411
Change-Id: I0696686982f1a089dc554013847ab4a2dafce83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956529
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723234}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992764
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#456}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.48
[email protected]
Change-Id: I99b9a91ee104a47f529061d3adad90cfc067da41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994051
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#455}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: Id96d5c35c17ee92c18d9d4356b4cdfd12300f6a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993393
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#454}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Close Assistant Web UI container when disabling Assistant.
Previously, it was possible to open the Assistant Web UI container and
then disable Assistant in the background which would cause our
container to persist when it should actually be destroyed.
[email protected]
(cherry picked from commit 7d3575663d77eb96aeae7fdb97fd79f3aae48ea9)
Bug: b:147344165
Change-Id: Ia65070fb4d108efb967232f767628e91454d9f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992312
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729481}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992986
Cr-Commit-Position: refs/branch-heads/3987@{#453}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge 3987: Revert LayoutInline::CollectLineBoxRects
This patch reverts |LayoutInline::CollectLineBoxRects| not to
use |NGInlineCursor|, by manually merging parts of r706815
<crrev.com/c/1862534> and r710694 <crrev.com/c/1888624>.
|NGInlineCursor| is rapidly changing that reverting is not
easy. This patch reverts not to use it for |getClientRects|
and a few other callers.
Testing more on culled inline box indicates that the phase 1
of LayoutNG regressed some cases from legacy, and
|NGInlineCursor| work regressed further. We might want to fix
when NGFragmentItem ships, but better not to change the
behavior until then.
(cherry picked from commit ad3134e801ec1a2437701acafb4ae331a8f1cbd2)
Bug: 1036358
Change-Id: I47a60f5d3a505d4b43eba0d8b5adc64e02cbcd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971632
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993362
Cr-Commit-Position: refs/branch-heads/3987@{#452}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Disable CECPQ2 by default for M80.
This change is for merging into M80 and cleanly disables CECPQ2 in TLS.
That'll give us some time to chase up some of the affected sites that we
have discovered and try again in a later release.
(cherry picked from commit 89773eb03b9bd219a20ebd32b337efc9805181ca)
Bug: 1028602
Change-Id: I367e2f9f7fbaa05710c36b83865dd98b93d1a39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989845
Auto-Submit: Adam Langley <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729096}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991749
Commit-Queue: Adam Langley <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: Eric Lawrence [MSFT] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#451}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M80] Propagate "isolated world origin" during CORS redirects.
After r694827 and r710554, request_initiator=website and the isolated
world origin is propagated separately. Correct propagation of the
isolated world origin is needed for 1) picking an allowlisted
URLLoaderFactory that might disable CORB and 2) for relaxing CORS based
on the isolated world origin (in addition to the request initiator
origin. Before this CL, such propagation did not correctly happen
for redirects handled by InBlink-CORS.
(cherry picked from commit d4cc9a7f9b873fae160362aceb94e19814c7cfe6)
Bug: 1034408, 940068
Tbr: [email protected], [email protected]
Change-Id: Ic4d20b2a8fea02e7bb07e4914240c5a6847e05bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974683
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#727587}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993421
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#450}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
CUPS Printing: Extend AdvancedPPDAttributes feature flag
(cherry picked from commit 9bd73b53fd9ee87fddcdd991261b9368ea276099)
Bug: 964919
Change-Id: I2122c17fac16f0ba01995402cf4a00fca15a31a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978010
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Nikita Podguzov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#726987}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992080
Reviewed-by: Nikita Podguzov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#449}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Updating XTBs based on .GRDs from branch 3987
[email protected]
Change-Id: If8424509bf0950fb4150c20853ba8776abfd9733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991984
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#448}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.47
[email protected]
Change-Id: I1d1e5a064e32ec543ea52e4860a2aae334ae3314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991812
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#447}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[M-80] Pepper: support GpuMemoryBuffer-based video capture
GpuMemoryBuffer-based video capture is enabled on selected Chrome OS
boards to reduce memory copies. This CL allows the Pepper video capture
host to convert the GpuMemoryBuffer-based VideoFrames to the I420 buffer
PPAPI supports.
https://onlinemictest.com/webcam-test-in-adobe-flash/
(cherry picked from commit 3aae1a800ee5e91e2b7809796b6f3d36b20828a6)
Bug: b:146938785
Test: Manually tested on Soraka and verify that camera works on
Change-Id: I13bbf857b50a900293706dc98ba6e51a8c985986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985832
Reviewed-by: Bill Budge <[email protected]>
Commit-Queue: Ricky Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728776}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989737
Reviewed-by: Ricky Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#446}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
[On-device adaptive brightness] Only start sys for signed-in users.
Controller will only create the adaptive brightness system after a user
session has started. The model will be personalized to the primary user
profile, ie. the first signed-in user.
(cherry picked from commit eec5111c9cbb3f6fa46f3fb4908ff624bbaa5e22)
Bug: 881215
Change-Id: Ib54fb5c8a05c2a47eec4ca1035d72e24e8183921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984794
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Jia Meng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728305}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990877
Reviewed-by: Jia Meng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#445}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Add more AssistantQuerySources for tracking in UMA.
Now we will distinctly track:
- kConversationStarters, and
- kWhatsOnMyScreen
Previously, both of these were lumped in with kSuggestionChip but these
are special kinds of suggestion chips that we want to track separately.
[email protected]
(cherry picked from commit 05058c0b65a74275617ebea494c8395d1b5fffab)
Bug: b:147234924
Change-Id: Idf0a37788dea6c902bf98a4ec1ef0e19d3bd32c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989697
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#729182}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992342
Cr-Commit-Position: refs/branch-heads/3987@{#444}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.46
[email protected]
Change-Id: Ibd9cf7749758cf97c7a2920cd8b705c78fc4ae3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991934
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#443}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Merge offline login fixes into M80 branch
Add back the failing unit tests for ReauthCredential
Bug: 1038351,1038339
Change-Id: I26655af730d065352379aaf6f3985ee2afd71636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988769
Commit-Queue: Rakesh Soma <[email protected]>
Reviewed-by: Tien Mai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#729048}
(cherry picked from commit fdd01fbc16b5f772a6883354e75a99ba52f8f85c)
Remove internet check to enable restrictions on offline login.
Note: This is an incremental change to [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1900159
(cherry picked from commit f5a411bd6000cfbb0d8723a99a9c689c7f75e3ef)
Change-Id: I401bf6ea8f30cf83b68a216e40bd1187ed9717a6
Bug: 1032807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961785
Commit-Queue: Rakesh Soma <[email protected]>
Reviewed-by: Tien Mai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724555}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990327
Commit-Queue: Yusuf Sengul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#442}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.45
[email protected]
Change-Id: I1d69f517c9623bb59b356bddc046b7881e5549c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991920
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#441}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.44
[email protected]
Change-Id: I691a9a08f698eb5b17693f4a56b48af9435b160b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991680
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#440}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Auto-dismiss TouchToFill if UI can't be shown.
Before this CL, TouchToFill assumed that BottomSheetController::requestShowContent always succeeds.
This is not the case if there is a BottomSheetContent currently being shown with higher priority.
In practice, this can happen when autofill_assistant (a high-priority bottom sheet content)
attempts to log-in on a website.
The problem surfaces because TouchToFill prevents the soft keyboard from being shown. Thus, in an
autofill_assistant flow, users would tap the login text input on the website, but the keyboard
would not appear.
After this CL TouchToFill UI is automatically dismissed if
BottomSheetController::requestShowContent fails.
(cherry picked from commit f792b938fdf928299f6d385a64573a2e2bb28512)
Bug: 1036362
Bug: b/145278496
Change-Id: Ifede88d513fc95692872ad001e538340f367f55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968993
Commit-Queue: Clemens Arbesser <[email protected]>
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Sandro Maggi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#725902}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985954
Reviewed-by: Mathias Carlen <[email protected]>
Reviewed-by: Friedrich [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#439}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Incrementing VERSION to 80.0.3987.43
[email protected]
Change-Id: Ia55519cde75cfe5f87700d482b8c16b3156208f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990479
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3987@{#438}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Rename GCPW top level registry name from gcp to gcpw
(cherry picked from commit 52ca34bf93607ac66b22fdbecf72219c17d03cdb)
Bug: 1039027
Change-Id: I3936986b390f414621df4d305b7ad8aa2f8bcbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986057
Commit-Queue: Yusuf Sengul <[email protected]>
Reviewed-by: Tien Mai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#728655}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989700
Cr-Commit-Position: refs/branch-heads/3987@{#437}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}