Publish DEPS for 79.0.3945.117
Incrementing VERSION to 79.0.3945.117
[email protected]
Change-Id: I2f748641986feed599bcc20d64701f9040dac00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986444
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1019}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.116
[email protected]
Change-Id: Ia871cf8476f6e4f1ff437cbfd6f3997eb1021624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986442
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1018}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
[Merge to M79] SurfaceControl: Use only valid region of pixels to calculate src rect.
SurfaceControl was currently using AHardwareBuffer dimensions as a valid
region of pixels to calculate src rect. This do not work always since
actual region of valid pixels could be smaller than the buffer dimensions.
Hence use valid region of pixel instead of buffer dimensions.
(cherry picked from commit d8809aa6ad730bcceb2fe5393b5fc12456143763)
Bug: 1027766
Change-Id: Ic289712b71b22be2fc645c771ddcb297b1c6687c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929632
Reviewed-by: Zhenyao Mo <[email protected]>
Reviewed-by: Khushal <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#719462}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988587
Reviewed-by: vikas soni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1017}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Add a missing guard for expensive size computation in FreeList::MoveFrom
NormalPage::FinalizeSweep calls this function for each page and assumes
the function is O(1). However currently the function performs O(n)
iteration over the free list items because of the missing DCHECK guard
for FreeListSize invocation. This makes the total complexity of
sweep finalization O(n*p), where n is the number of free list items
and p is the number of pages, and may lead to multisecond pauses for
large heaps reported in b/144085059.
Change-Id: I3ca609066d3ef790a88dc41ce512b5cd7a8ec065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972832
Auto-Submit: Ulan Degenbaev <[email protected]>
Reviewed-by: Anton Bikineev <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Ulan Degenbaev <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#725820}
(cherry picked from commit 0827bfec78adf51bddcf96573d39f2c807f0201b)
[email protected]
(cherry picked from commit e9a96cc61b3d764edc2c95b11ba009e2c8047c00)
Bug: 1035442
Change-Id: I351b628ebfe303cdac3f273d60ed50cdf741442b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976411
Reviewed-by: Ulan Degenbaev <[email protected]>
Commit-Queue: Ulan Degenbaev <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3987@{#284}
Cr-Original-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988201
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1016}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.115
[email protected]
Change-Id: Ia8082f61f2a30e4d4c113e1ce10f6516189be477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988212
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1015}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Delete PermissionServiceContext instance when shutting down RPHI.
The PermissionServiceContext holds PermissionSubscriptions originating
from service workers. These subscriptions observe the
PermissionControllerImpl that is owned by the Profile. When we delete
the profile, we terminate the RenderProcessHosts associated with
the profile first but however, in the OTR case, the RenderProcessHost
corresponding to PermissionControllerImpl is not deleted before
Profile.
The fix was to explicitly delete the PermissionServiceContext instance
when we call the RenderProcessHost::CleanUp method.
This CL also adds the regression test.
(cherry picked from commit 2045162fc4bd5ef1966dee183162cc1984941629)
Bug: 889276
Change-Id: I226647172b6f9cc36efbe2cddedaa921dbde4afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960458
Commit-Queue: Rohit Agarwal <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724643}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988158
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1014}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Introduce a Mutex for the rendering loop in BaseAudioContext
The render loop in Web Audio API is performed by the rendering thread,
and this thread can access the data storage that is allocated by
the main thread (Oilpan). This relationship is prone to cause
use-after-free error especially when the main thread objects gets
collected.
This newly introduced mutex will be able to lock up the data storage
when it is accessed by the render loop, so it can be protected even
when the GC attempts to collect the object.
We believe the performance implication from the mutex would be
negligible because it is locked only when Uninitialize() function
gets called. The lock within the render loop uses TryLock, so it
does not block the rendering thread.
Why introduces a new lock instead of using the existing graph lock?:
The graph lock is quite popular in various places in WebAudio,
thus it is supposed to be very contentious. Each conflict will
result in "silence" in the audio stream and we need to minimize
such instance. This new lock is solely dedicated to the tear-down
process, so we can guarantee that it will be locked from the main
thread only once. Therefore, there is no risk causing redundant
silence unless an AudioContext is getting collected.
the web tests without any problem.
(cherry picked from commit 417a58a838349c46dfce49bba04a9e956142975c)
Bug: 1029462
Test: Locally confirmed that it does not repro anymore, and also passed
Change-Id: I1fb7c302ff21c3d3ac763088a9d0bb4e8584b03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960083
Reviewed-by: Raymond Toy <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724249}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988157
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1013}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.113-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.114-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Iba6d3b3d7fdf6dc9f2b7a115dba0f970d548b719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988412
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1012}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.114
[email protected]
Change-Id: Ib2e2fb9fafcf7f8f988f100e51236130433f7ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986020
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1011}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.112-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.113-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I73e2519966cede71a0baa2361b6c18e76b2f84c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987699
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1010}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.113
[email protected]
Change-Id: I429d4d0f210de91e2a9336683a2e002dd9e77822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986433
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1009}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.111-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.112-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I589e7dc75e51658507b7a60d7fc9a20be404610f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987585
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1008}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.112
[email protected]
Change-Id: I40eaca7a25e2aeea2eda37e68d153a74582bf4d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986058
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1007}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Gracefully handle trustd failures on 10.13+
macOS 10.13+ switched to using trustd over XPC to verify
certificates, but can (for unknown reasons) occasionally
fail, affecting the legacy/non-built-in verifier
(CertVerifyProcMac).
When this happens, don't re-validate the same certificate
multiple times, since trustd will keep complaining.
[email protected]
(cherry picked from commit a7bdc8bfd0fdf679e8667e16c489c592ca973f37)
Bug: 1033260
Change-Id: I03267be80f486b1fee10a4207d42926951b82cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965834
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724437}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980504
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1006}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
[WebLayer] Fix black flash when keyboard shows
This was happening because compositor_->SetSurface() was being called
when the height changed.
Before: https://screenshot.googleplex.com/E5dJumgTkUo
After: https://screenshot.googleplex.com/0O6V5coCCEd
There's still a bit of an ugly black square when the keyboard hides, but
this is better than before.
(cherry picked from commit b6ce36413dfb2c2b8632ccac1ba036e2f73e1fe9)
Bug: 1033632
Change-Id: I4a96079df50f1c53cbd0948dff0af37da601f68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965995
Reviewed-by: Bo <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724427}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986910
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1005}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Fix crash in GetFontFallback on a corrupt font
The typeface can be nullptr when the font file cannot be parsed.
See crbug/1033434 for details.
(cherry picked from commit 514b4e240b1e151028c899cb1cbbcbe31d1526ab)
Bug: 1033434
Change-Id: Iff830eaa7509536c0b2c5b29be9e3971bc7b97d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965439
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724380}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986905
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1004}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.110-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.111-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I0c81ef3cc0c8e0188e00a6ef23a28b978f925e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986896
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1003}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Fix link highlight crash
Previously we updated fragments of link highlights during paint, and
called LocalFrameView::SetForeignLayerListNeedsUpdate() when we had
less fragments than before, but SetForeignLayerListNeedsUpdate()
should be called before paint because it deletes paint controller.
Now separate the work into a new step LinkHighlightImpl::UpdateAfterPrePaint()
to update the link highlight fragments and call
SetForeignLayerListNeedsUpdate() when the number of fragments changes.
[email protected]
(cherry picked from commit a072b7004cbd37855d60c77195ae03a13e27a547)
Bug: 1021470
Change-Id: I4d81a522844e957aebcb406fb36044297872ab55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899317
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#712809}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967098
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1002}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.111
[email protected]
Change-Id: I27a77f99ffc7f3cb1e0a9aa8b74a7acd953277ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983273
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#1001}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
[Flag] Update enable-experimental-kernel-vm-support flag
Extends the enable-experimental-kernel-vm-support flag lifetime until
M82.
BUG=b:146931629
TEST=Built 79.0.3945.110 + this patch for samus-kernelnext and verified that the enable-experimental-kernel-vm-support flag was present and that crostini was available when it was enabled.
(cherry picked from commit b7323e34d2c03c3b61928ef6d08055ef2487f115)
Change-Id: Ia66b829cc3bf47bc8d9f2017c6bf0db589cd96c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860530
Reviewed-by: Nicholas Verne <[email protected]>
Commit-Queue: Nicholas Verne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#708101}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986031
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: Ross Zwisler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#1000}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Merge to 79 (branch 3945) a one-liner fix:
[Contacts] Add null check for display name.
Make sure the displayName is not null, which might cause crashes.
Change-Id: Id98c778bba1354dd3e1a1def36f12082b49e5a07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916969
Auto-Submit: Rayan Kanso <[email protected]>
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/master@{#715379}
(cherry picked from commit cd449eddee05f7cc0a3a209dde990c28b99a3455)
[email protected]
Bug: 1038615
Change-Id: If9eb54d7e455fdd6653b89b9129e7e4386a8e40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985665
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#999}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.109-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.110-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: If48815d678d313bbc7b844c784db644d64c1c38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985698
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#998}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.108-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.109-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ifbaa6a97020ac6d5c6d4775dc3d9e50c9ae72950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981701
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#997}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.110
[email protected]
Change-Id: I948690c0a0cd9913da6ebc119fabcff77e08012f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981864
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#996}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.109
[email protected]
Change-Id: I10f964b5e6c49b7bd8d4d52fe95406c6d016f939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984643
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#995}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.107-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577706257-benchmark-79.0.3945.108-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I9905b15e13bcf1865e43525ea59449a67c9de2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984913
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#994}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.108
[email protected]
Change-Id: Icf1c36b2d8fb099cb46571c26ee013d3a82e9446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984080
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#993}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.106-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.107-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ideeb321471b98dd3901bd538a28d0952d389ae10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982146
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#992}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.107
[email protected]
Change-Id: I0958cc7b7b0e7ae143d98fa6e7873a4abb608ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984079
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#991}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.105-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.106-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ie4b2effa9c76442082564cc9ae06dc5a2b59203b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982673
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#990}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.91-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.86-1577099780-benchmark-79.0.3945.105-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: Ie458258748e6e59c97a25a569533419a2cb657ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983830
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#989}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.106
[email protected]
Change-Id: I14111dc4e7633d53dac04158eb6654c7a565861c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980482
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#988}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.105
[email protected]
Change-Id: I75c6b172b4ecb411a030db14ad9a485181e45d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981851
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#987}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.104
[email protected]
Change-Id: I6a04c7d1f5a0b3d55057d37c87851f913091b236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982626
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#986}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Fix 79 branch; the merge in r726454 collided with a rename in r713309.
[email protected]
Bug: 1037782
Change-Id: If0a40f60bdda8ddeb4b35ac0ec7ce6fe10fe1ae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980868
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#985}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.103
[email protected]
Change-Id: I6f3e172f96bc01e746efa9671024361fc07e4b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980495
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#984}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.102
[email protected]
Change-Id: I65b39d59dc6d1efb8920a8aa374282a6166eca8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981693
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#983}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.101
[email protected]
Change-Id: I9b603ea96b53c3d8ec0b8b131f25c7ff4549c245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980761
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#982}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Use default quota for WebLayer for indexeddb and service worker.
This matches Chrome & WebView, which fixes websites that use cache storage. This cl is meant to be small and self-contained so that it can be merged safely. I'll work on making this more generic in a followup.
(cherry picked from commit 31c1924e14ba7d63441da20e2200f1b88a9fc2b7)
Bug: 1035420
Change-Id: I692f685569427e0d5277c97d5fca658cd2b56897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976550
Auto-Submit: John Abd-El-Malek <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#726454}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980795
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#981}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.100
[email protected]
Change-Id: Id1eae73805df7d73b46b578628c71cbd15017444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980269
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#980}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.99
[email protected]
Change-Id: Ie519d10e6c9093de25a2d1a5088629737fbbb663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978950
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#979}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.98
[email protected]
Change-Id: Ia69aedd59dd7fcecc67f42fc293255d38ecfc95d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979649
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#978}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Internet: VPN Config: Elim policy indicator for provider type
When we switched to using an unmanaged enum for vpn.type (which is an
intrinsic / immutable property of a configured VPN), it broke the
policy indicator for the type selector, which assumes that the
'property' property will be a managed type (e.g. ManagedString).
Since the provider type can not be changed, it is not useful to
show the policy indicator for policy managed networks (the provider
type must be provided by the policy). Therefore we should just leave
'property' undefined for that network-config-select element.
(cherry picked from commit 6357cb84de01cff55451507f63fcc9ca87fb90af)
Bug: 1035581
Change-Id: I47704adff49fa1063eab5e93a8654645a2ec1893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976492
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#726476}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977744
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#977}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
[devtools] Remove restriction to eager (popover) evaluation.
This undoes
http://chromium-review.googlesource.com/c/chromium/src/+/1835357,
which limited the eager popover evaluation to the innermost scope, which
is the only scope for which we can produce reliable results right now.
For the outer scopes, it might still produce the right results, but we
can't guarantee that. But the feature is still very useful and so we are
restoring the behavior here, and will follow up with a proper fix and UX
later.
(cherry picked from commit 0a3fbd76a9e73fdadbd8a9702d34b77bb07efe75)
Tbr: [email protected],[email protected]
Bug: chromium:995036, chromium:1033022
Change-Id: I8bcc6d2b7b3604a882b00da18b8cbf773874c9a1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1971935
Reviewed-by: Mathias Bynens <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978636
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#976}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.97
[email protected]
Change-Id: I28448ee5c4e73260925e1ce6957705025362e0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977308
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#975}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Revert "device/bluetooth: Enable the use of btdispatch by default"
This reverts commit d85ee3b458cebd025d4dde7de924b94df1959487.
Reason for revert: b:145163508
Original change's description:
> device/bluetooth: Enable the use of btdispatch by default
>
> This sets the feature flag kNewblue to be enabled by default. The effect
> of this is that Chrome will by default communicate to Chrome OS'
> Bluetooth dispatcher (btdispatch) instead of BlueZ. Currently,
> btdispatch only forwards the D-Bus traffic to BlueZ without NewBlue
> enabled.
>
> Bug: 999676
> Change-Id: I7089225726ef52c1b8465f3a67b3fdbf01b01882
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783719
> Reviewed-by: Ryan Hansberry <[email protected]>
> Reviewed-by: Reilly Grant <[email protected]>
> Commit-Queue: Sonny Sasaka <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#693431}
[email protected],[email protected],[email protected],[email protected]
(cherry picked from commit 8b3b05083bc60c6d7ad714e788cb19555367fe74)
Bug: b:145163508,b:145317234
Change-Id: Iaa5ee6dd719ccc38bf31ce7adfd7ebfec1b08f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951128
Commit-Queue: Sonny Sasaka <[email protected]>
Reviewed-by: Sonny Sasaka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#721627}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977062
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Miao-chen Chou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#974}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
bluetooth: Ignore kNewblueDaemon feature flag
As part of undoing NewBlue, we want to remove the feature flag and this
patch starts with ignoring the flag value first before the bigger patch
to remove the feature flag.
(cherry picked from commit c2c86b1980dbfa0062e1ace6c44dc10b0a53106d)
Bug: b:145163508,b:145317234
Change-Id: I378852ac360c8841c9414617812bd472069c8ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972937
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Miao-chen Chou <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#725754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977061
Cr-Commit-Position: refs/branch-heads/3945@{#973}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Try fix flaky chrome_cleaner test failures
The underlying issue seems to be related to a sandboxed process failing
to open or truncate its log file. All the tests shared the same file,
leading to flaky issues despite the tests running with --single-process.
To avoid this issue, we now tell the
cleaner/reporter process and their spawned sandboxes to log to a
temporary folder.
(cherry picked from commit 738e180d3aa5bf80f89c60a1cbe6e584ec69f046)
Bug: 1030333
Change-Id: If339c623b148b8b458a32e4d974d6a642bc4f12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972494
Commit-Queue: Joe Mason <[email protected]>
Reviewed-by: Joe Mason <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#726142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976551
Cr-Commit-Position: refs/branch-heads/3945@{#972}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Merge to release branch
[wasm code caching] Eliminate weak reference to Context
- Removes context_ field on WasmStreamingClient, which held a weak
reference to the Context. This isn't used, and isn't thread-safe.
- Removes unused isolate parameter too.
[email protected]
(cherry picked from commit 602dd76b94772a206bb4fee2a28353e23598de67)
Bug: chromium:1018029
Change-Id: Iab4cbab2a710716860ab8931a7561239970051d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901592
Commit-Queue: Bill Budge <[email protected]>
Reviewed-by: Andreas Haas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#713140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975085
Reviewed-by: Bill Budge <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#971}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.96
[email protected]
Change-Id: Ia50ecebf33d75ec8a34f229fbbef54c1562b4842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974625
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#970}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.95
[email protected]
Change-Id: I03efdb8b1df6da824152caaf948cbf7e76de7660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973212
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#969}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Revert "Fix warning: Ignoring invalid file assets/snapshot_blob_32|64.bin"
This is a manual cherry-pick of bac4d2f614e63729fd3ca7a98befa55d01e0a589
from master which reverted 516c53cdd7941fd39abc6264ab63df9d0337a293.
516c53cdd794 modified content/public/app/v8_snapshot_overlay_manifest.cc,
but the revert (bac4d2f614e63) was a manual revert because the code
moved to content/browser/v8_snapshot_files.cc in between M79 and M80.
Instead this CL is a clean revert of the original change with no
conflicts.
Original change's description:
> Fix warning: Ignoring invalid file assets/snapshot_blob_32|64.bin
>
> On Android, V8 will need a snapshot file to speed up initialization, the
> Ninja will generate different snapshot files according to 32-bit or 64-bit
> systems, and only one of them is included in the Chrome apk. Therefore,
> only need to give the service access to the preloaded snapshot file it needs
> on startup.
[email protected]
This reverts commit 516c53cdd7941fd39abc6264ab63df9d0337a293.
Bug: 1034022
Change-Id: Ia8504e6071bd430092408af7fbc3bec2c87226ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970842
Reviewed-by: Bo <[email protected]>
Commit-Queue: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#968}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.94
[email protected]
Change-Id: Iff602379d7ef4aa7aab454d5e634fe9f19c873cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970853
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#967}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.93
[email protected]
Change-Id: I670549ef97ab4f208fb915bfe842dffd2bcace85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970690
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#966}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
webview: migrate missed profile data.
We missed migrating various data stores in the initial profile directory
migration, because many of them are not created until used. Run the
migration again and move all the missed files as well.
If any new data has been written to the new location already, we rename
it as a backup and then replace it with the old data, as we can't really
merge the data; it's more likely that the old state is useful as the
partial migration only just happened in the M79 rollout for most users.
(cherry picked from commit e6147459da1efa03898719db2b3718689042dbfc)
Bug: 1033655
Change-Id: Ib2b7267454f1d9ae896f13a45e01683871c0b764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966383
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#725282}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970630
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#965}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Revert "Migrate back context storage data to original location"
This reverts commit 40de74fc46854b016247f67b04c7196cf83137af.
Reason for revert: Not sufficient to fix issues.
Original change's description:
> Migrate back context storage data to original location
>
> The original CL
> https://chromium-review.googlesource.com/c/chromium/src/+/1793087
> caused local storage and database to be lost since they were
> not migrated together when the context storage root path was
> changed into Default/ subdirectory.
>
> Currently, M79 is rolled out at 50%, and there is new data that
> the user might have created. With this change, that new data will
> remain in Default/ subdirectory, and the old data from M78 will
> be picked up and used.
>
> For those who are not yet updated to M79, there shouldn't be any
> change when they update to the patched M79.
>
> In this CL, we revert the original commit, and also do the following:
>
> 1) Migrate data files back from 'Default' to the original location.
> 2) This also fixes 'pref_store' to be consistent with
> android_webview/browser/aw_feature_list_creator.cc
>
> Alternatives considered:
> - Migrate all the missed files and directories with the exception of
> a block list: this is risky and less maintainable.
> (https://chromium-review.googlesource.com/c/chromium/src/+/1968289/)
>
> --
>
> Revert "[aw] Reorganize profile data on disk."
>
> This reverts commit 3a2cf9c489ef354c296fde91bf81b1cb991c9515.
>
> directory.
> [email protected]
>
> (cherry picked from commit ff3405370d9ec469b11696ed3e085f45afae49f3)
>
> Tested: Checked that migrated data files move to the original
> Tested: Passes https://crbug.com/1033655#c29
> Bug: 1033655
> Change-Id: Ieb5ed390f2b659faf60beeda4f72bf3c3e5ed11a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968641
> Reviewed-by: Changwan Ryu <[email protected]>
> Commit-Queue: Changwan Ryu <[email protected]>
> Auto-Submit: Changwan Ryu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#725008}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965360
> Reviewed-by: Krishna Govind <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3945@{#961}
> Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
[email protected],[email protected],[email protected]
Change-Id: Ia0e1468939069bacb3d6b3f8e0fd353c865d762b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1033655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970078
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#964}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.90-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.91-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I31e8322d45db1542eb939141f1fcbe7ddafc12d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969247
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#963}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.92
[email protected]
Change-Id: I4bfcc3712359378b29caad972aca41db881030cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969020
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#962}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Migrate back context storage data to original location
The original CL
https://chromium-review.googlesource.com/c/chromium/src/+/1793087
caused local storage and database to be lost since they were
not migrated together when the context storage root path was
changed into Default/ subdirectory.
Currently, M79 is rolled out at 50%, and there is new data that
the user might have created. With this change, that new data will
remain in Default/ subdirectory, and the old data from M78 will
be picked up and used.
For those who are not yet updated to M79, there shouldn't be any
change when they update to the patched M79.
In this CL, we revert the original commit, and also do the following:
1) Migrate data files back from 'Default' to the original location.
2) This also fixes 'pref_store' to be consistent with
android_webview/browser/aw_feature_list_creator.cc
Alternatives considered:
- Migrate all the missed files and directories with the exception of
a block list: this is risky and less maintainable.
(https://chromium-review.googlesource.com/c/chromium/src/+/1968289/)
--
Revert "[aw] Reorganize profile data on disk."
This reverts commit 3a2cf9c489ef354c296fde91bf81b1cb991c9515.
directory.
[email protected]
(cherry picked from commit ff3405370d9ec469b11696ed3e085f45afae49f3)
Tested: Checked that migrated data files move to the original
Tested: Passes https://crbug.com/1033655#c29
Bug: 1033655
Change-Id: Ieb5ed390f2b659faf60beeda4f72bf3c3e5ed11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968641
Reviewed-by: Changwan Ryu <[email protected]>
Commit-Queue: Changwan Ryu <[email protected]>
Auto-Submit: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#725008}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965360
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#961}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.91
[email protected]
Change-Id: I587cba3186489935647e8b011b99ca1e1671f4cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969017
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#960}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.89-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.90-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: If6f5f5eb3f254bbca5b891c7bfc3a41e778b2e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968746
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#959}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Roll ChromeOS orderfile from chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.87-r1.orderfile.xz to chromeos-chrome-orderfile-field-79-3945.66-1575892287-benchmark-79.0.3945.89-r1.orderfile.xz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I34a517417ad39d24cd59ee065b46737d2d549794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968737
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#958}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.90
[email protected]
Change-Id: I805a61971e06e6fc4b4d568ccb5f1bc65ffcfabe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967979
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#957}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Incrementing VERSION to 79.0.3945.89
[email protected]
Change-Id: I9e29b0d9b86b55d0eed3f6f880b9725505b57060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966365
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3945@{#956}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
Signin: Close feedback form when login was performed.
Add removing feedback form at destructor of SigninScreenHandler which is
destroyed when the login is finished.
(cherry picked from commit cfffa47a235f541f5a34534cd4c77cac214de566)
Bug: 1033572
Change-Id: Idfb55003c238faa5c8d04d9e7c11861632b67156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967652
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Roman Aleksandrov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724743}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967247
Reviewed-by: Roman Aleksandrov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3945@{#955}
Cr-Branched-From: e4635fff7defbae0f9c29e798349f6fc0cce4b1b-refs/heads/master@{#706915}
