Publish DEPS for 76.0.3809.46
Incrementing VERSION to 76.0.3809.46
[email protected]
Change-Id: Icefee3cce480ee87d37e4c1e82c8315995963ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679435
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#607}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Gate sending ANDROID_APP as supported_proivder_types with a feature flag.
supported_proivder_type will be used to change the behavior of OPEN_APP action
and Android media action.
Currently, we always send ANDROID_APP as supported_provider_types which enables
launching media intent. The plan is to rollout in M77 instead of M76.
This changes will be cherrypicked into M76 to disable the feature in M76 and
enable with a finch experiment.
(cherry picked from commit 7fb9b3bbd76f9e5a6b21fb3e7af1b5f1dfb64abb)
Bug: b:135487605
Test: Manual
Change-Id: Ia07ccf425126be9433c7d4043f3780dd39107713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663396
Reviewed-by: Yue Li <[email protected]>
Commit-Queue: Li Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670132}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666565
Cr-Commit-Position: refs/branch-heads/3809@{#606}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disable picture-in-picture for touchless
This is unsupported so it should be flagged as such in the
manifest.
(cherry picked from commit 9de97ba77edccb423ea7760f1eb87ce5945f73e9)
Bug: 978851
Change-Id: I85055fb675195f3eafd6515aef831d052c5b11aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678280
Auto-Submit: Ian Vollick <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672594}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678681
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#605}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill] Fix regex for UPI VPA
- Adds additional formats of UPI VPA based.
- Allows more symbols in UPI name.
Changes are made based on the specification
(https://www.mpf.org.in/docs/08/NPCI%20Unified%20Payment%20Interface%20UPI%20Specifications,%20October%202015.pdf)
[email protected]
(cherry picked from commit 7ef1f265a96f46e32a3e1944797bf33c9356cf01)
Bug: 977377
Change-Id: I8f805e99e530e463717525e991c8d4f22680398e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672067
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Auto-Submit: Maxim Kolosovskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672204}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679409
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#604}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ui/gl: Gracefully handle failure to schedule the main overlay plane.
Each swap for a surfaceless surface must have at least one overlay plane,
for the OutputSurface, before SwapBuffers is issued. The SurfaceControl
surface assumes this and will crash in SwapBuffers if at least one plane
has not been scheduled.
Crash reports indicate that we have cases where
glScheduleOverlayPlaneCHROMIUM, presumably for the main plane, fails and
we end up crashing during CommitPendingTransaction as a result. Handle
this failure better by reporting a failed swap, which should always lose
the context and recreate the surface.
R=[email protected]
(cherry picked from commit a9513c89423fad8554e29ded6a6042fba71c3295)
Bug: 977812
Change-Id: I53028e5494d5da39d91d1f685913c46ec9a1bb4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673026
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Auto-Submit: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671757}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679243
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#603}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Set default font size for OffscreenCanvas to 10px
There's no hard standard on this, so we are matching the behavior
of detached canvas.
(cherry picked from commit 93aa97a3101cc7ebf879610d61df3bddd3151e3f)
Bug: 977876
Change-Id: I84f8e32000f290d6826722863bb6fb16116e2f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675911
Commit-Queue: Fernando Serboncini <[email protected]>
Reviewed-by: Yi Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672198}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678885
Reviewed-by: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#602}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
[email protected]
Change-Id: I0ec712f68551f76ad29308a6a3d00eee9464dc75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679220
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#601}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Integrate new tabstrip animations with DoLayout."
This reverts commit 78045bdf84d583dc8ef9bb3d19e859cef72dc9b5.
Revert "Cancel new-style tabstrip animations when an old-style animation begins."
This reverts commit fb4b7a37ba6a703cc83b83a714655242ffc7d190.
Bug: 969788
Change-Id: I55cd1278bb9822000426635aec913dbf973c1037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670316
Reviewed-by: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#600}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Disable "Add to my apps" context menu item from touchless
NTP and ES.
BUG=977156
R=[email protected]
(cherry picked from commit 59cd3cc1fefecb0f901612f49d88ac4f6835cc00)
Change-Id: I9eeaec544e61ed3505b9606ca71b6712dedcdcad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672210
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671729}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678172
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#599}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[modules] Fix install duration metrics
Play core sends the following status updates:
Successful install: PENDING -> DOWNLOADING -> INSTALLING -> INSTALLED.
SplitCompat not enabled, unsuccessful install: PENDING -> DOWNLOADING ->
INSTALLING -> DOWNLOADED.
(cherry picked from commit e9049df9064b3f729017ea2e36d80ea7f9dc1158)
Change-Id: I64300673dedda6c7b6d65d0c66642435bd3333e1
Bug: 977218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669847
Commit-Queue: Tibor Goldschwendt <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671419}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678169
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#598}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Correctly set ToolbarPhone visibility when hiding find-in-page
A previous CL changed the order in which ToolbarPhone is notified about
overview mode showing and the find-in-page toolbar hiding. Prior to that
CL, the find-in-page toolbar hiding notification came in first, followed
by the overview mode show. After the CL, the order was swapped causing
the ToolbarPhone visibility to be incorrectly set after the find-in-page
toolbar was hidden.
This CL updates ToolbarPhone#handleFindLocationBarStateChange to take
into account the current mTabSwitcherState.
BUG=977529
(cherry picked from commit 5abab6c41a333963ed197ce5b388a0e888203eb2)
Change-Id: Iec4d1a11e0a79b0ffad3fee707e739be2ed550b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674346
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671805}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678225
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#597}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Fix ic_check_circle selection highlight
(cherry picked from commit fd78dcf4cff97745e438136483745fe8a25fc3bf)
Bug: 977168
Change-Id: I2571bd8bb63eaa2049d8f80520c6d7f176ad2519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677066
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672249}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678231
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#596}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allow editing of title when 'adding to apps'
[email protected]
(cherry picked from commit a8776f11db4ef2256bb81edb40cf74d72d9c6b4a)
Bug: 976803
Change-Id: Ia076e9e97ce5d7bdadb8634cfa587e1e5996d757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674492
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672165}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678229
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#595}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Android Sync settings: (re)enable payments when sync-everything gets enabled
(cherry picked from commit bfb705fde49aa227203bf79c811120a12ee33f22)
Bug: 972863
Change-Id: I3f7821b769c8d678c33618acc7abb703114e018f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670868
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671604}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678180
Cr-Commit-Position: refs/branch-heads/3809@{#594}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Ignore layout shift due to viewport size change.
I tested this manually, both by resizing a Chrome window, and by
simulating mobile device rotation in devtools.
(cherry picked from commit fe125c154576def386ed42e225f4709849d69b06)
Change-Id: I69297b2501827070de4255b152d3099cb91ab11e
Bug: 958832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653609
Commit-Queue: Bryan McQuade <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669830}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678539
Reviewed-by: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#593}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[HTMLMediaElement] Do not fire timeupdate if currentTime has not advanced
The timeupdate notification is fired periodically every 250ms.
However, in some cases it is possible that the current time for a
playing element has not started advancing yet at the time of the first
notification. According to the spec, timeupdate should not be fired in
this case.
This CL adds as an additional condition for firing that, if the periodic
event has not been fired yet, the current time must not be zero.
[email protected]
(cherry picked from commit 822463553e0d0faf67cb1dc3789040c78d3b46a2)
Bug: 973769
Change-Id: I032c27ab4d02d3053ade4cf4ff7bcfd65767cd6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667307
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671222}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678364
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#592}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Pre-Unity Sync settings: Fix non-clickable row after dashboard reset
This fixes a regression in the pre-Unity version of Sync settings that
was introduced by https://crrev.com/c/1559176: In the case where Sync
was reset from the dashboard, the "Sync" row in chrome://settings was
not clickable. The reason was that sync_ui_util::GetStatusLabels
returned SYNC_ERROR, but no corresponding ActionType.
This CL changes back to returning PRE_SYNCED in this case, specifically
for pre-Unity. (It's important that the post-Unity UI continues to
treat this case as an error.)
(cherry picked from commit 6f6c4729944166f2236bcdaa067bf7743c13c773)
Bug: 977980
Change-Id: I6bfd116ee605dfbf1b673b2f8c0d9be05efb75df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674006
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671640}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676632
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#591}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix font size for prefilled values.
This is a better way to pin the fonts than http://crrev.com/669336.
Instead of pinning the fonts to the system font, they are actually
pinned to what LayoutThemeFontProvider::SystemFont maps to
-webkit-small-control. This creates even less jank on most sites
the rely on default fonts in input elements. Also the font sizes
are now pinned.
(cherry picked from commit 005563ec0a7e7b8b6d4b4bc20702f4eb900d128d)
Bug: 916838,951487
Change-Id: I2efb2eaf11276bc75052708f0c61a35ad9ae4c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670897
Commit-Queue: Dominic Battré <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671647}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676707
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#590}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Pin preview font-family to system font in different way
crrev.com/640884 pinned the preview font-family to the system font by modifying
-internal-autofill-previewed. This cause a UI flaw in the sense that the
preview state triggered a relayout of the entire page and moved content around.
A previewed input element looks like this:
<input type="text">
#shadow-root (user-agent)
<div pseudo="-internal-input-suggested" id="placeholder"
style="display: block! imporant;">suggested value</div>
<div>actual value</div>
</input>
This CL moves the "font-family: system-ui !important;" from selector
input:-internal-autofill-previewed (which applies to the entire <input>
element and is set to the <input> element via
HTMLFormControlElement::SetAutofillState) to
input::-internal-input-suggested (which only applies to the inner <div>).
The internal <div> does not re-layout the rest of the DOM. so the reflow is
gone.
As a side effect, the font-family is only set for <input> elements but not
for <textarea> or <select> elements, which should not be counter the reason for
which crrev.com/640884 was implemented. Chrome does not fill <textarea> elements
and <select> elements draw themselves entirely differently.
(cherry picked from commit 8427f5edd001bccb4c82582d4f7a005ac8e8ee8c)
Bug: 916838
Change-Id: I72fd7b1743e85513110c98f78a0074dc8fafd560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638541
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669336}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676706
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#589}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't show saving bubble on http auth, when it's not possible to save.
form_manager_ might be not in submitted state, because in line 71,
ProvisionallySaveHttpAuthForm might have returned false.
[email protected]
(cherry picked from commit ff0800a2187c008dca177ac9c4d57c3c4b3be0c4)
Bug: 976564, 976170, 602676
Change-Id: I7b64791b32bd7eb9cad62868b5d5ec29c10068f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667450
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671291}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677049
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#588}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Uses member variable for the callback of RemoveTrack()
This CL puts the callback of RemoveTrack() to a member variable rather
than passing as parameter to fix an issue that UserMediaClientImpl
sometimes cannot process request after MediaStreamVideoSource dies.
(cherry picked from commit 4db73adeca5ac20a3fa19cff034970fb3a34cc3a)
Bug: 972017, b/131272798
Test: Manually
Change-Id: I04dc594b23ce981f3443996be4a5ac3538770211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660394
Commit-Queue: Wei Lee <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669588}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677070
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#587}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Prevent font-loading promise rejection while shutting down the document
This fixes a crash bug where cancellation of font loading causes promise
rejection inside a ScriptForbiddenScope, when the loading is cancelled
inside Document::Shutdown().
To prevent this, this patch adds an early return to
RemoteFontFaceSource::NotifyFinished() when the document is not active.
This is a short term fix to be merged for M76.
(cherry picked from commit 172dccb9f76312aabc914be9dc0b8a93d6a20b75)
Bug: 960290
Change-Id: I9f8b18fe489c2224ebbf445ad25445b7769c3336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661313
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670005}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676939
Reviewed-by: Kunihiko Sakamoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#586}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[bfcache] Track permissions in the browser process.
It turns out that the renderer-side tracking doesn't cover all the use
cases we want to cover.
Move the tracking the browser side:
- Add an API for the browser code to notify us about the feature usage.
- Add a test for the new API.
- Move permission tracking logic into the browser process.
- Add a test for geolocation tracking.
[email protected], [email protected], [email protected], [email protected]
[email protected]
BUG=977885
(cherry picked from commit 5afc73e3e0b6605251b86e49abb0e02a2a7294ac)
(cherry picked from commit fc50b45ffa1d3ffcc502d0eaaae5eb880423a0e1)
Change-Id: I70f0412b9a3eff5b546757845efabb068584f52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651819
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Lowell Manners <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671572}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676626
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#585}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.45
[email protected]
Change-Id: I38f1fa8bda4b28ab9a5ca5edd26496e7d0f85ea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677626
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#584}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[GID] Address null dereference when registering for sync state updates
ProfileSyncService.get() can return null depending on configuration (for
example when sync is disabled from command line). IdentityDiscController
should check PSS reference for null before calling
addSyncStateChangedListener().
BUG=977626,976089
R=[email protected]
(cherry picked from commit 7352cc1f716775f1beb9ab5847f76ef986753408)
Change-Id: Ic04fbcfbe36b6074118823d94aac960bdcb8ff9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672182
Commit-Queue: Pavel Yatsuk <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671812}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677588
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#583}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[GID] Request sync state for IdentityDisc from ProfileSyncService
Currently sync state is requested from AndroidSyncSettings. This class
only reflects local Android sync settings and doesn't get updated if
sync is disabled for dasher account by domain administrator.
ProfileSyncService#canSyncFeatureStart is the correct method to check if
sync is enabled. Correspondingly IdentityDiscController should observe
sync state through ProfileSyncService.SyncStateChangedListener.
BUG=976089
R=[email protected],[email protected]
(cherry picked from commit 54e8a107380671475c43acf68733bbc24c66c277)
Change-Id: Ibe1913c6743d1c6438945f0391ac8a21bfb03f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663376
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670115}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677587
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#582}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix bug where tab hover card keyboard navigation did not work on Mac.
When keyboard navigating the tab strip on Mac pane_has_focus is not set to true so key events were hiding the tab hover cards when they shouldnt have been. This change instead ignores hiding cards on when updating the hover card if the tab strip or one of its children (excluding the new tab button) has focus.
(cherry picked from commit 620dfcf1b220f6404e38c431b0ed306ce10c13cd)
Bug: 910739, 974896
Change-Id: I306543684f448fa3e4ceac0f346a5b833f334b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650213
Commit-Queue: Caroline Rising <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669897}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677507
Reviewed-by: Caroline Rising <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#581}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Initialize CastMirroringServiceHost with extension web contents
When mirroring a desktop, initialize with the web contents for the
event page of the Media Router component extension. cl/252871392 makes
the corresponding change on the component extension side.
(cherry picked from commit 5f7c05e29711f79f9f50dc5d99060e8ff701b648)
Bug: 972874
Change-Id: I6f04c02a801035891b23ba257e4416d681705891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659237
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669798}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677505
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#580}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge M76] Fix callback error for existing window creation
Currently api chrome.app.window.create in case of already existing
window simply returned that window frame regardless of its state(i.e
even when it was not yet initialized properly). This CL fixes that.
(cherry picked from commit 942587e417bcea8a058d2968f231b8d8479d2278)
Bug: 943710
Change-Id: I41b21cde08b8b842a1cd09c5f34f953a17ab4e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656568
Commit-Queue: Anatoliy Potapchuk <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669449}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677047
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#579}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Suppress autofill on touchless devices
(cherry picked from commit 50566bd61df24fc13b3fbde3d04fe49dcb96d71a)
Bug: 971868
Change-Id: Icdfba2d851058b961cec6e7546d3c6fb0123fed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674615
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672106}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677252
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#578}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Creates User Actions for Infobar Messages
These will be used for a simple sequencing analysis.
[email protected]
(cherry picked from commit 3a9c950681edc8dca94beaa4d39aaeecfc74ca65)
Bug: 976066
Change-Id: I93df27f382e2ed5c630294742e473a1390c0e220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663013
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670134}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676882
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#577}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Records the time the InfobarBanner is visible.
[email protected]
(cherry picked from commit 1fa0cf6cb5ffc900b6b771ffb55d2b394d12bce5)
Bug: 976529
Change-Id: Iccc476bb744a6a714df8718de0f1a9f10c015937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666458
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671057}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676994
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#576}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Allow InfobarBanner to be dismissed mid presentation.
- Creates infobarBannerCurrentlyPresented property, which is now true
if a banner is currently presented.
- presentingInfobarBanner is now used only to indicate that the Banner
is mid presentation.
- If the banner is mid presentation, it gets dismissed on userEnteredTabSwitcher
because of crbug.com/977761.
- Updates the container unit_tests to use infobarBannerCurrentlyPresented
[email protected]
(cherry picked from commit 357928cbda995696de1963c26b7c126d34550b99)
Bug: 977017, 911864
Change-Id: Ic668f0723267e5da0f582cb6927c2b931ab0bbc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672764
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671838}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676993
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#575}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge M76] Reland "Fixed race condition during window creation"
This reverts commit b40a44367e5de45caa5d5534d6ef0f6e6f5a3507.
Reason for revert: Everything is safe, reverting back.
Original change's description:
> Revert "Fixed race condition during window creation"
>
> This reverts commit ed01dcb979e235d3f1511e3806a1cdf3059c8fdb.
>
> Reason for revert: This may cause undefined behavior during when window
> prematurely closes during creation. Reverting for further investigation.
>
> Original change's description:
> > Fixed race condition during window creation
> >
> > Currently browser was not waiting for renderer part of the navigation
> > before calling a callback on chrome.app.create. It assumed that
> > the mojo ipc will be handled quickly, which is not true in cases of
> > overloaded renderer(e.g kiosk app with many backgroud apps).
> >
> > Bug: 943710
> > Change-Id: I92effd2cd5daca8d95e1b7ad04bf47b6ef6dfb88
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655396
> > Commit-Queue: Anatoliy Potapchuk <[email protected]>
> > Reviewed-by: Ken Rockot <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#668576}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: I641f2432841d05e3ad6ef391f077ce480384d2a4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 943710
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656229
> Commit-Queue: Maksim Ivanov <[email protected]>
> Reviewed-by: Maksim Ivanov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#669214}
[email protected],[email protected],[email protected],[email protected]
(cherry picked from commit 46f2bfea098af67e4a7da9bc3ddd99443324232c)
Change-Id: I01f8c6fb3cebbcb42bf39e35da272271a425b87a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 943710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660502
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Maksim Ivanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669220}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676705
Cr-Commit-Position: refs/branch-heads/3809@{#574}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Finishes InfobarBanner presentation animation after an interaction.
If the user interacts with the Banner mid presentation we should finish
the presentation animation (meaning that completeTransition will be called)
so the user can safely interact with the Banner.
If completeTransition is not called and the user tries to dismiss the
banner or present an InfobarModal, the banner will freeze until
completeTransition gets called from the PropertyAnimator completion block.
This CL's creates plumbing between the InfobarBanner and the TransitionDriver
so the animation stops and finishes after an interaction with the Banner.
[email protected]
(cherry picked from commit 1eb6ffc9062afc4bfbad75569d12a2ea44cdd2f1)
Bug: 977017
Change-Id: I63b9593262cb15aca182af029a5a3fd19f8d2ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670393
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671505}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676991
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#573}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Makes InfobarBanner presentation interactive.
- Implements UIViewControllerTransitioningDelegate
interactionControllerForPresentation/Dismissal methods.
- InfobarBannerAnimator now conforms to UIViewControllerInteractiveTransitioning
and implements startInteractiveTransition.
- Uses an UIViewPropertyAnimator to animate instead of animateWithDuration.
After this change the UI won't be blocked when the banner is presented, and
the banner will respond to touches while being animated down.
[email protected]
(cherry picked from commit 5971d2b64340f4ca135bdf9241c96ce829bfd42d)
Bug: 977017
Change-Id: I75eb0484565927f86111efb48ea2e0975da150f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668236
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671055}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676880
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#572}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.44
[email protected]
Change-Id: I24a63e6aec2cf7c18f0f7df0250a0c3df7d13524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676988
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#571}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] Implement coordinator and mediator
This CL implements the coordinator and mediator for the
TabSelectionEditor component.
In addtion, this CL hooks up other components to create different
ViewHolders.
Change-Id: I6e5974409250e549ae4cc0b076e292e15b236050
Bug: 970287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664279
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674438
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#570}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Properly destroy members for TabGridDialog
The thumbnails in TabGridDialog was not released when TabGridDialog
was closed. This CL fixes this memory leak.
Bug: 977443
Change-Id: I5d27145ab022508f29f69b37af0ac9ddd2603913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670507
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671228}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674439
Cr-Commit-Position: refs/branch-heads/3809@{#569}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Blacklist grpc_core::InlinedVector for CFI cast check
grpc_core::InlinedVector has a few (reinterpret|static)_casts that look
benign but will trigger CFI bad cast check. I've tried to suppress the
check by adding "-fno-sanitize=cfi-..." when building the gRPC lib
(http://crrev.com/c/1660194), but it doesn't seem to have any effect on
the canary ChromeOS build. As suggested by pcc@, this CL blacklists the
whole inlined_vector.h file for CFI cast check.
For longer term, we will need to fix InlinedVector to prevent it from
casting the element before initializing it. This is tracked in github.
(cherry picked from commit f2e2b06d9b24c00d1b38fac10c0bc5a6cf940309)
Bug: 972108
Change-Id: Ic90631f9e66d15e1a3c8d073c99bfb69a6400103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665554
Reviewed-by: Peter Collingbourne <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670300}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676838
Reviewed-by: Yuwei Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#568}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Support Javascript Modal Dialogs in Touchless
With this change, JavascriptModalDialog can construct a touchless-
friendly dialog property model.
(cherry picked from commit c0c871435be2e61aed7d3faef58fd5792149e7e1)
Bug: 977633
Change-Id: I68ab94b80ac47beef46184167c2b011a63de90c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671048
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671815}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676830
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#567}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reset null dialog icons
Presently, we call .mutate() on a potentially null icon. In
these cases, we should instead clear the icon.
(cherry picked from commit 6a36402614ba44dbb9328e6c725731cdb1a56226)
Bug: 966909
Change-Id: I6181c72d29ef15dfd543affcd7b8b38a664eef95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676724
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#672142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677227
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#566}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[AW NS] Add more UMA for WebView callback counts (NS rollout regression analysis)
MERGE to M76
In addition to the existing callback counts in Android.WebView.Callback.Counts",
provide callback counts for:
- onPageStarted,
- onPageFinished,
- onLoadResource,
- onPageCommitVisible,
- shouldOverrideUrlLoading
It is useful to measure these callbacks as well in order to detect
any anomalies/differences in the network service implementation.
This would support analysis of user reported bugs such as
crbug.com/973901.
BUG=972166,945922
(cherry picked from commit 44c2e453de1d196e05b2d94ddf34260bdfd408f5)
Change-Id: Ifd132c9df8a35b6b9ad2ce1769cfc3c21a081ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667310
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Tim Volodine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670856}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677046
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#565}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix broken ADMX templates
Latest ADMX templates in dev and beta fail to load with error "Invalid
value '-1' for attribute minValue". This happens because the admx_writer
writes out a minValue of -1, but ADMX types are unsigned and negative
values are rejected. However, admx_writer.py actually checks for
negative 'minimum' values in line 283:
if 'minimum' in schema and schema['minimum'] >= 0:
min = schema['minimum']
So, you ask, how can a negative min value possibly slip in? Turns out,
schema['minimum'] was a string and '-1' >= 0 is true. The bug was in the
grit code that translates policy_templates.json. The code stringified
bools and ints. This CL fixes this and adds a regression test.
BUG=chromium:960274
TEST=Added regression test to policy_json_unittest.py and ran it.
Tested ADMX on Windows machine.
(cherry picked from commit 79b629e4d1d20a65749d4cdadcef1ab33360118f)
Change-Id: I71f5b471f1717c0ccadd67620aa5d4a1f6cc2863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669928
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lutz Justen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671747}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677045
Reviewed-by: Lutz Justen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#564}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Download Home V2 : Cleanup externally removed downloads
[email protected]
(cherry picked from commit 3bf50ad5026fa1237520a93d322598bd73a14ad9)
Bug: 976402
Change-Id: Icef1bce64612e489c575d4ede2d892d76383b529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669990
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671875}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676874
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#563}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make NetworkChangeNotifier::NetworkState ref counted as it's accessed on multiple threads
On computers with huge hosts files, setting and getting the DnsConfig can take
significant amounts of time. Prevent it being destroyed while being
accessed by making it ref counted. This doesn't completely fix the race related
to the global NetworkChangeNotifier pointer, but it reduces it to an insignificant
window.
(cherry picked from commit eb0b4ca2708ff471d7ecf311f3cbc7dc076859da)
Bug: 967414
Change-Id: I3dcca8b898f95ac3fe576a853615284b880679bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669432
Reviewed-by: Eric Orth <[email protected]>
Commit-Queue: Paul Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671045}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676785
Reviewed-by: Paul Jensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#562}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Plumb InputConnection#performPrivateCommand through AppHooks
See bug for context.
(cherry picked from commit ebbf6caf24022ec3b322f6258104773661e19c88)
Bug: 971279
Change-Id: Iabe2cef188c962b3a513c6d3b75d414b7ea49778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665192
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670943}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677146
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#561}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
When resuming playback that auto-fullscreens, provide user activation.
If you hit the home button and resume Chrome while playing a video,
the video resumes, but the fullscreen request doesn't have a gesture
token, so the autofullscreen fails.
This adds user activation to this fullscreen request which should be
safe given the user already supplied a gesture to play the video in the
first place.
(cherry picked from commit 0c3063f4ac9f5726a209593f02756042b64cf1e6)
Bug: 973593
Change-Id: I741209850e3242921d17f1fd4d0e07ee96849d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661665
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671022}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677144
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#560}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
[email protected]
Change-Id: I4675405e6f0579bfafdeeadb10c896c145d376b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676682
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#559}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge M76][NTP] Create a separate FRE feature to create a search shortcut.
Separated the feature to create a search shortcut for existing users
from one that creates a shortcut during the first run experience.
(cherry picked from commit 8e96d786e82b1f1517fa6ed989fcc048a7ff2fb6)
Bug: 962558
Change-Id: I850ed528e434d7af143304b782b580e70a2900d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668053
Reviewed-by: Kristi Park <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Kyle Milka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670961}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677011
Reviewed-by: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#558}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Devtools: Add performance histogram to track how long it takes for remote modules to be loaded from the devtools frontend."
This reverts commit f89ff9d807e0e838c9c0224797209154f84c7e9d.
Reason for revert: crbug.com/968425
Original change's description:
> Devtools: Add performance histogram to track how long it takes for remote modules to be loaded from the devtools frontend.
>
>
> Change-Id: Icc4249a00e04f008f8c1d1b5bda97a31333822e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610460
> Reviewed-by: Alex Ilin <[email protected]>
> Reviewed-by: Joel Einbinder <[email protected]>
> Commit-Queue: Jose Leal <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#663806}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 3e23615b10ee1bc286cf15d30a4343facc6a88c7)
Change-Id: If3bf03d9b44317b9a03cfc742caad097afedcf3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639668
Reviewed-by: Erik Luo <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#665793}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677007
Cr-Commit-Position: refs/branch-heads/3809@{#557}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[heap profiler] Make a separate Field trial to upload heap profiles
The Field trials for CPU and heap should be independent, otherwise enabling heap profiles would also require enabling of CPU, which is wrong.
BUG=972745
[email protected]
(cherry picked from commit 59107801a03de3a9891beca627f0f3eec4ecb086)
Change-Id: I0b91178c7b1ccddc70265694e6fef75015c5a9fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652306
Commit-Queue: Alexei Filippov <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670396}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677005
Reviewed-by: Alexei Filippov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#556}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
|request_initiator_site_lock| needs to account for loadDataWithBaseUrl.
When the browser process calculates the origin that a navigation will
commit, it needs to not only look at the |url| and |initiator_origin|
of the navigation (in CommonNavigationParams), but needs to also
consider loadDataWithBaseUrl which commits data: URL at an origin
indicted by |base_url_for_data_url|.
(cherry picked from commit 2a8300c15bd052c8c1bc9a12dfee08cc771bbb17)
Bug: 976253
Change-Id: I968fba61f26558c03edebf4b7ff999a500a6b14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666947
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671051}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677004
Reviewed-by: Daniel Xie <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#555}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[LayoutNG] Snap to pixels when painting text selections etc.
Also fix a lot of wrong baselines for LayoutNG. We should have been
more careful when rebaselining tests, and should have noticed this bug
when we first saw LayoutNG painted selections differently.
[email protected]
(cherry picked from commit 42a55d9e6aef513b00bbf37d7e6bfe8a2a89117b)
Bug: 967342
Change-Id: Ibd36dbfdfc8a98b7b86e3c74d8db725a98652da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674262
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676680
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#554}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Verify if model was updated ahead of handling omnibox suggestion.
Omnibox suggestion interactions are handled in a non-sequential manner:
each interaction can - and typically is - scheduled for execution.
Before that execution takes place, a number of asynchronous events can
take place, for example - a new suggestion list can be collected from the
autocomplete mechanism.
In such situation users may interact with suggestion that is about to be
removed from the model; in extreme situations this model may appear empty
by the time we reach this code, causing the application to crash.
This change extracts the portion of the code performing this action from
`updateSuggestionUrlIfNeeded` method and reuses it to locate suggestion
in `onSelect`, too.
(cherry picked from commit 6eb7a09c2de2774527f3ba5075e8043781aab5e4)
Bug: 976595
Change-Id: I8321767cbff01f53616ace4ee92c6984e4a9a49b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668052
Commit-Queue: Ender <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670970}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676984
Reviewed-by: Ender <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#553}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't skip fragment clip if there are other clips for composited layers
Composited layer under multicol is still not fully correctly
supported. Currently we don't allow fragmentation of composited layers,
and skip fragment clip for them. However, if there are other clips below
the fragment clip, we should not skip fragment clip to ensure the other
clips are correctly applied. This is still not fully correct (see the
comment in the code for details), but the result is less broken in many
cases. Hopefully we'll fully fix the issue in
CompositeAfterPaint+LayoutNG-box-fragments.
[email protected]
(cherry picked from commit 969ccc73d8cc74855a6637cb33c5050c6ab97004)
Bug: 976187
Change-Id: Ica9acc71f0d1204d6380f1bcac3e2159631d63e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670413
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671480}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676679
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#552}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't end() if XMLDocumentParser::ResumeParsing() triggers a detach
(cherry picked from commit 0cc4b93b57d8dd67c0b8008e2d686d74505ea57a)
Bug: 977520
Test: http/tests/navigation/xmhtml-location-change-crash.xhtml
Change-Id: Idbb8718db7de77ddf41dbc62bd102e884d0bfa12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674364
Commit-Queue: Nate Chapin <[email protected]>
Auto-Submit: Nate Chapin <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671872}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676671
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#551}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a flag to prevent document.open()/document.write() after document abort
This is how Firefox avoids incorrectly clearing the document and
cancelling a navigation if the document open steps are run after the
document is aborted in preparation for a navigation.
This behavior is not currently in the spec, but there is a proposal
to add it: https://github.com/whatwg/html/issues/4723
(cherry picked from commit 05dc5890291110e7f38f14c7118e74760234834d)
Bug: 973657
Test: fast/loader/document-write-after-location-change.html
Change-Id: I46d9fcaeb7aedcf845030020009eacbb26c7eed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667743
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670965}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676670
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#550}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[LayoutNG] Fix list-item marker logic
Update the list-item marker logic to reflect that list-style-image takes
precedence over list-style-type: none. Also adds a WPT correctness test.
(cherry picked from commit f1ec7c3633a4fe5138b3128ae69bbc2b498eb856)
Bug: 976937
Test: wpt/css/css-lists/list-type-none-style-image.html
Change-Id: I2255254f72e58d53671337ccb3f6a285cc515522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671896
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671772}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676728
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#549}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[css-flexbox] Clamp the cross-size by the min/max size
...when computing the main-axis size of a flex item.
As per this change:
https://drafts.csswg.org/css-flexbox/#change-2018-used-cross-size
R=[email protected], [email protected]
(cherry picked from commit 98124a48bf9c60d1605995278ec9a9e6aaadd1cf)
Bug: 972576
Change-Id: I11a1ac14e2e0e44e39fcd45d4568874da2dcfce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672014
Auto-Submit: Christian Biesinger <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671485}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676666
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#548}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Remove extra frame layout to fix border cropping issues.
The LinearLayout inside FrameLayout did not seem to work correctly.
However, making OpenLastTabView a LinearLayout and removing one
layer of views both simplified the layouts and fixed the border.
(cherry picked from commit 71fdd3880d61197b47b716b62fb0a5315ee76fed)
Bug: 970584
Change-Id: I8b23e20ea855ffac9816f2cf90c888ff98b2f475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666946
Commit-Queue: Justin DeWitt <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670605}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676744
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#547}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Media Keys: Don't fire a PlayPause event on pause when media is paused
This CL adds a new method to the MediaKeysListener API so that
MediaKeysListeners will know whether or not media is currently playing.
This is important for certain types of MediaKeysListeners which
currently receive OnPlay/OnPause events from the OS and turn those into
VKEY_MEDIA_PLAY_PAUSE events. When media is paused, we don't want an
OnPause event to do anything.
This is a temporary fix (I know how ridiculous that sounds) while we
wait for the MediaKeysListenerManager to be refactored, which depends
on crbug.com/949596 and crbug.com/974035.
(cherry picked from commit 271c6c3efd13bbe71e3fb92a093110831360d166)
Bug: 957415, 961308
Change-Id: I66c6815a47df05759a6f3a1ea586fa9f2f0005a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659709
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669296}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676725
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#546}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Move the last tab button below Most Likely.
* Moves the last tab button
* Removes the Chrome logo and the "welcome to chrome" text.
(cherry picked from commit 47ff9f32ee8337ea42114c1a12bf36588ce9b33e)
Bug: 970584
Change-Id: Ibdbc37308fd32365fb73d380e64f2cc7264a3256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664043
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670490}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676587
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#545}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Sync::USS] Clean corrupted password sync metadata from login database
During experimentation phase, passwords sync metadata got corrupted
due to a bug.
This CL is pumping up the database version and clean any
potentially corrupted sync metadata.
This is safe because the corrupted version hasn't reached Stable.
This CL only clears the sync metadata and doesn't remove any password
data. Users will then automatically go through the first sync
experience!
(cherry picked from commit ab7b35d908d05ea3182f42bb6f4353c863056e31)
Bug: 973053
Change-Id: Iecc604690522b22d4a419e247a65add171766879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653229
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Auto-Submit: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671658}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676704
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#544}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[AW NS] Allow loads when io_thread_client is null
MERGE to M76
This is to address recent issues with the network service roll-out.
Align the loading behavior with the old (non-network service) code path,
see go/wv-ns-behavior-differences item 4. When IoThreadClient is null we
currently abort loading with net::ERR_ABORTED, while in the old code
path this is allowed to go through.
This patch makes sure to not issue net::ERR_ABORTED when GetIoThreadClient()
returns null.
BUG=977784,841556
Change-Id: If47486587e2b39ff25c57db797cbb4372187b5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676624
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#543}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Added metrics for mixed autoupgrade type.
This adds metrics that log the resource type when starting a request
that was autoupgraded, when one fails, and when one receives a
response. This also updates the ResponseType enum in enums.xml to match
the enum defined in
third_party/blink/renderer/platform/loader/fetch/resource.h
(cherry picked from commit 44e5beb8486f0447640b032a5ae1762050e77f02)
Bug: 974008
Change-Id: Icf045b00dadc1de071d98618a36aa2771a7082e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658942
Commit-Queue: Carlos IL <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670974}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676604
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#542}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
AW: Set bg color to black when fullscreen in EvictFrameIfNecessary
In https://chromium-review.googlesource.com/c/chromium/src/+/1614798 we
added logic to set the background color to black for fullscreen webview
in OnRenderFrameMetadataChangedBeforeActivation. It turns out that on
pre-N Android, this is too late and misses the view being re-painted,
leaving a white background up until the next invalidation is forced.
This change in OnRenderFrameMetadataChangedBeforeActivation paralleled
the EvictFrameIfNecessary from OnFrameMetadataUpdated, but missed
other cases of EvictFrameIfNecessary.
In order to more exactly match the pre-surface-sync behavior, this CL
moves this workaround to a helper function and calls this from the
appropriate places.
(cherry picked from commit 42703f81c170eac824ef32388927b87eee8540f5)
Bug: 961223, 973365, 974692
Change-Id: I6067e4687fef918c97804634c32ad70be163182d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670359
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Khushal <[email protected]>
Auto-Submit: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671438}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676413
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#541}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
M76 merge [ios] Add logging when presenting active view controller
This CL adds logging for an NSInvalidArgumentException with the reason:
"Application tried to present modally an active controller
<BrowserViewController: 0x13e88d000>."
Code experiments showed that the referenced BrowserViewController is
the presenter not the presentee.
This CL logs the active VC which is attempting to be presented, the
active VC's presenting VC, and the active VC's parent VC. Hopefully,
these logs will help identify the user flow that causes this crash.
The bug has been elusive and there are no repro
steps. This bug only occurs in tablet.
The rationale for not preventing the crash is that it can leave the
user in an unusable UI state if the crash is prevented. This CL helps
to better understand this crash.
[email protected]
(cherry picked from commit 95c1a8763566cfab56d9b7fcc3edea90e54eed3c)
Bug: 959774
Change-Id: I37966f8cdce6c54e08dc9a1489d59672195dc46e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625275
Commit-Queue: edchin <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Nik Bhagat <[email protected]>
Reviewed-by: edchin <[email protected]>
Auto-Submit: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671014}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676240
Cr-Commit-Position: refs/branch-heads/3809@{#540}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add TextFragmentIdentifiers origin_trial_feature_name.
Add the origin trial feature ID for the TextFragmentIdentifiers feature.
Also add the feature to the NavigationOriginTrialFeatures list since
the feature has to stay active through a navigation.
(cherry picked from commit 4d08aa3a95b0d9063c484298b591779ab51ffbde)
Bug: 977585
Change-Id: I80d0bb752df52e388118ae6840e05c94229141c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669234
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Nick Burris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671701}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676238
Cr-Commit-Position: refs/branch-heads/3809@{#539}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add PolicyListMultipleSourceMergeList support for crOS
(cherry picked from commit e00e7019418c85046b119760dc34a58b447f87ee)
Bug: 969889
Change-Id: I0df8a98a007691a2153b67caeaea3e22ea7ccadd
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641988
Commit-Queue: Yann Dago <[email protected]>
Reviewed-by: Yann Dago <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#665672}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675907
Cr-Commit-Position: refs/branch-heads/3809@{#538}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix chrome doesn't resize with kwin problem.
(cherry picked from commit 638288fa679f29b3637b5aaad01c4dd57bbeec56)
Bug: 972050
Change-Id: I96387e0bccf1685cf4cd77d68b815aaba63f22e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666772
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670512}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676229
Reviewed-by: Peng Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#537}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Fix crash in omnibox shortcuts
Similar to CL 1596434, the root cause of the crash is a difference
between the width of the shortcuts collection view and the width the
shortcuts collection view is using to calculate its insets. Here, after
the device is rotated back to portrait mode, the width of the
collection view is still the landscape width, while it's using the
portrait width to calculate insets.
To fix this, this CL uses a different method. Instead of the collection
view centering itself, instead the popup view controller takes care of
that. It can then respond to the rotation and cell appearance events
and center the shortcuts view correctly.
In omnibox_popup_presenter, the [popup layoutIfNeeded] line was causing
issues because the popup would get laid out too early, causing it to
have the wrong safe area insets. Layout out the superview will also
cause the popup to layout, so explicitly layout out the popup shouldn't
be necessary.
(cherry picked from commit fdbb2db7304cc1fc340c4924147b2a659b44c1fd)
Bug: 961775
Change-Id: I9ff65ce2f42f11cac5b45b59a8f9df2bc5bb3d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658010
Commit-Queue: Robbie Gibson <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669181}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676126
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#536}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Don't fallback to google servers when fetching favicons in omnibox
When favicons are loaded, if there's no favicon, we currently fall back
to fetching it from a google server. This creates a visual flash when
the user first sees a synchronously retrieved default image, and then,
moments later, a favicon.
This CL disables this fallback. This means favicons are not shown for
unvisited sites now.
[email protected]
Bug: 964918
Change-Id: I53f0c05545703426b04d4ee57d264c8258c93f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675429
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#535}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disallow multi sign in option when device is locked to single user
If policy forces the device to lock to single user and reboot on sign out,
the effect is that multi sign in becomes impossible. This change removes
the option to sign in with another user from system tray.
BUG=b:77799573
TEST=Manual test
[email protected]
(cherry picked from commit ccf4aac9a4247bf6dfa95a8e4deb69da40c3a841)
Change-Id: I140605b14af8103c91493a53a878f10b1cf66bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631667
Commit-Queue: Igor <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675666
Reviewed-by: Igor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#534}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't show a favicon for search suggestions when DSE favicon is off.
Fix a bug that with "new popup ui" flag but without the DSE favicons
flag, the omnibox loads a favicon if it's available. It should fall
back to the search loupe icon.
(cherry picked from commit 3ab50fa76c464b4c3417a3c20d431b5fad34e417)
Bug: 973366
Change-Id: Id27dcb737f161c1047d8bebd2e1a6baf2abe87de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655473
Commit-Queue: Stepan Khapugin <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Auto-Submit: Stepan Khapugin <[email protected]>
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668470}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675606
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#533}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Fix a crash when holding cmd+W in incognito.
Fix a crash where the incognito BVC deallocs while the repeated cmd+w
events are still delivered.
tabs, at least 8. You can use shift+cmd+n to accelerate this. Now hold
Cmd+W. The tabs will close, and when the last tab is closed, the tab
switcher with no tabs will be shown. Previously this often crashed.
(cherry picked from commit cb903fe89f6e7c4d4085221fd762f75b150b616d)
Bug: 967637
Change-Id: Iebeacb08186ce31cc2781d70215a495f63dbc01e
Test: Use hardware keyboard. Close all tabs. Open multiple incognito
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658788
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Auto-Submit: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669238}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675607
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#532}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Apply reboot on sign out policy only for non-affiliated accounts
The policy is denying the multi-profile usage. To soften the effect of
the policy, we want initially to apply it only for non-affiliated accounts.
Later, if the need will appear we can add separate policy values to force
reboot for affiliated users too.
BUG=b:77799573
TEST=Unit tests pass.
(cherry picked from commit de3e6c1bbef32678d8be3c8575121e9dac175ca4)
Change-Id: If0ddc5f44ff587181016e449c31211a3b736e44d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638529
Commit-Queue: Igor <[email protected]>
Reviewed-by: Igor <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Reviewed-by: Lutz Justen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675646
Cr-Commit-Position: refs/branch-heads/3809@{#531}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fixes a crash on ChromeOS when reopening closed PWA.
In release this would cause PWA windows reopened by Ctrl+Shift+T to be
the wrong size.
This was caused by a mistaken assumption that we would only override
the bounds on popups.
(cherry picked from commit ffcbc089b9a34fb71d3cc1c1428ed876ef7998c5)
Bug: 972930
Change-Id: Icf3faf1eb0755691b78c87ead7bca5a791feda54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651533
Commit-Queue: Jay Harris <[email protected]>
Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667896}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673580
Cr-Commit-Position: refs/branch-heads/3809@{#530}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Polish the Animation for drop-to-merge in GTS
* Remove notifyDataSetChanged() calls.
* Add a grey background when the hovered card is zooming in.
Change-Id: I625dc1af3d7cea83d99e0622211b36abc488cbdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666270
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674434
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#529}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.43
[email protected]
Change-Id: I4c797e622099b89b8e874e289b86bb4f3d474868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672543
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#528}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
[email protected]
Change-Id: Ib780595d2d860cbc2405f9f578d8fdb0868897c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672762
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#527}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Dismisses InfobarBanner in BVC’s viewWillDissapear
[email protected]
(cherry picked from commit bf64de7d0d353ce9a248684f135d629220642a31)
Bug: 973877
Change-Id: I546ad0782c578607ae8af99524804d07fc35577b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660786
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670276}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674496
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#526}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland "Add a variation for "New tab" in GTS"
This is a reland of d7013b537db6073d07d541e3c4ccee003c7ca864.
Original change's description:
> Add a variation for "New tab" in GTS
>
> Have a different top toolbar layout for GTS when there are no open
> incognito tabs. This is now behind #enable-tab-grid-layout with
> parameter "Enable New Tab Variation".
>
> Bug: 974079
> Change-Id: I8aa972a64efa77a7cdad64b7481b45722d2e3132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659848
> Commit-Queue: Yue Zhang <[email protected]>
> Reviewed-by: Theresa <[email protected]>
> Reviewed-by: Yusuf Ozuysal <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#670731}
Change-Id: I6172570781595d9f6097c505676e06d274ecb7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668291
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670770}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674435
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#525}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a variation for "New tab" in GTS
Have a different top toolbar layout for GTS when there are no open
incognito tabs. This is now behind #enable-tab-grid-layout with
parameter "Enable New Tab Variation".
Bug: 974079
Change-Id: I8aa972a64efa77a7cdad64b7481b45722d2e3132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659848
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670731}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674433
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#524}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] Force toolbar in selection mode
This CL is a temporary way to force TabSelectionEditorToolbar always in
the selection mode with a back arrow as the navigation button.
Change-Id: Ie1223251846b919c258ac143250bab9e7860e8f8
Bug: 976813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666591
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670641}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674431
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#523}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Updates LocationBarMediator badgeState on WebState change.
Previously we were simply updating the BadgeUI, but the backing variable
for the badge state wasn't being updated.
Updating the badgeState also triggers an Update of the UI per line 171.
[email protected]
(cherry picked from commit 2ce74155e6976227e0bc21fe95500b22a47ba790)
Bug: 972113, 911864
Change-Id: Iaff8d95bde53df319ef957d8ad27040610b8f89f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648664
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669908}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674633
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#522}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Only add Infobar Badge as an accessibility item if shown
Fixes a bug where an accessibility element would be present for the
Infobar Badge even when it was not visible. This change adds and
removes the badge as an accessibility element when the badge is
being displayed/hidden.
(cherry picked from commit 6841ceba55d970693035f4a7a23dd8fbf9b7d5ad)
Bug: 972873
Change-Id: I618ee3f7b684cb479fc70fbafbd329b99e27e18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652045
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668962}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674645
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#521}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] align GetNSString call with params
IDS_IOS_SEND_TAB_TO_SELF_TARGET_DEVICE_ITEM_SUBTITLE_DAY is not
a parameterized string.
(cherry picked from commit 9b08207b3aa125835191035954a379bcf5c8acf0)
Bug: 976459
Change-Id: I4a60a73f0de2d6f272d805acb27c9a5551742845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666128
Auto-Submit: Jeffrey Cohen <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670627}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674475
Reviewed-by: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#520}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix stale thumbnail when animation is on
This CL fixes a regression introduced in https://crrev.com/c/1650508.
Bug: 972301
Change-Id: I9cc38010e74b373100db6209f4f16a2216eddad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669892
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671111}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674437
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#519}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make TabGroupModelFilter ignore unrelated didMoveTab calls
There is a moveTab call in tab restoring stage, and the didmoveTab call
caused by this call should be ignored by TabGroupModelFilter. This CL
fixes this issue.
Bug: 976874
Change-Id: Ifb8608e3ce0bdaf60017e112950211c00b772655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668349
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671013}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674436
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#518}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Record switch tab related event metric
This CL records switch tab related event metric for different UI
components, include switching in GTS, TabGridDialog, and TabStrip. These
metric include the following:
* MobileTabReturnedToCurrentTab, this is an user action, and it's only
recorded for GTS if user returns to same tab as before entering the
tab switcher.
* MobileTabSwitched.componentName, this is an user action, and it's
recorded for every component. If the previous selected tab is in
the same group as the currently selected one, we record that as
either switching from tab strip or tab grid dialog depends on the
active Ui. Otherwise, the switch is logged toward switching from GTS.
* Tabs.TabOffsetOfSwitch, this is an histogram, and it's recorded for
every component. The recording condition is the same as
MobileTabSwitched action.
In addtion, this CL records a "MobileExitsStackView" action when tab
switch is hidden.
Change-Id: I9e28d15e3755fa263742b4de383154b37e5fe5d9
Bug: 959881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660601
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670721}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674432
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#517}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix blank thumbnail in GTS with Tab-to-GTS animation off properly
When TabToGTSAnimation flag is off, the thumbnails are not showing.
http://crrev.com/c/1650334 was a partial fix before
http://crrev.com/c/1637979.
This CL fixes it after http://crrev.com/c/1637979 and
http://crrev.com/c/1643070.
Bug: 972301
Change-Id: I5a64e6e40495f41f0b4ad4a38c9567a96c6b8504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650508
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670574}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674430
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#516}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add UMA for drag-and-drop related behaviors
Bug: 974404
Change-Id: I4845752a2980bb34383c3a9612ff87111b0ad324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660099
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674429
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#515}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] Set up selectable layout and toolbar
This CL adds TabSelectionEditorLayout that is a SelectableListLayout,
and its visibility is controlled by TabSelectionEditorLayoutBinder, as
well as the click listeners for the toolbar buttons.
Change-Id: Ib3888cdf3eed9fa66c815c5196fbd460476ef224
Bug: 972299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649122
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Becky Zhou <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674428
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#514}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Properly destroy TabGridDialog and TabGridSheet
This is a follow-up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/1653835.
Properly destroy components in TabGroupUiCoordinator and
GridTabSwticherCoordinator.
Bug: 972217
Change-Id: Iadf02b18f74b5ef78c0a2aae56f208d5db4ba9b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660697
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669531}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674427
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#513}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Enable Drag-to-Ungroup in TabGridDialog
This CL enables dropping a tab on the ungroup bar in TabGridDialog to
move a tab out of group. It is behind the
TabGroupsAndroidUiImprovements flag.
Bug: 971841
Change-Id: If0bab7644431a1915e4c11c86db0a108fa60a244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649034
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674426
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#512}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Update GTS when tabs are closed in TabGridDialog
Tab info is not correctly updated in GTS when close happens in
TabGridDialog. This CL fixes this issue.
Bug: 973918
Change-Id: I16edadd757a19956aff2274f0d88000264c895b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659049
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668986}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674425
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#511}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Change TabGroupUi component flow for TabGroupsUiImprovement flag
This CL changes the UI component flow behind TabGroupUiImprovement flag
so that:
* See TabGridDialog instead of TabGridSheet in TabGroupUi components.
* Not see the create group button in GridTabSwitcher.
Bug: 972217
Change-Id: Ib06f35560a8046fe0e5dd762f14df3f877ec92e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653835
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668657}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674424
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#510}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] TabGridView extends SelectableItemView
This CL sets up SelectableItemView for TabSelectionEditor. All properties
for a SelectableItemView bind in TabGridViewBinder#onBindViewHolder(),
as well as its views update.
Change-Id: I427e2e45c3f93abcdc35fcd34291ba0d7eb29e16
Bug: 972276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648671
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668547}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674363
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#509}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] Hook up component through menu item
This CL hooks up the dummy implementation of TabSelectionEditor
component in GTS and adds a menu item "Group tabs..." in tab switch
menu for launching the component. This menu item is visible in tab
switcher when TabGroup is enabled.
Change-Id: I3142bdb851012a554686c86e8a759791775ff8a0
Bug: 971025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644996
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668089}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674362
Cr-Commit-Position: refs/branch-heads/3809@{#508}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Polish show/hide animation for TabGridDialog
This CL adds showing animation as scaling out of a card and hiding
animation as zooming into a card to TabGridDialog.
Bug: 969914
Change-Id: I2fecbd23af6f4ba90d72cce8a8cc876a9e224db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642020
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667989}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674361
Cr-Commit-Position: refs/branch-heads/3809@{#507}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Hide all drop-to-merge logic behind TabGroupUiImprovement flag
Currently some drop-to-merge logic are accessible without
TabGroupUiImprovement flag enbaled. This CL fixes this issue.
Bug: 972037
Change-Id: I88209346c78ce971e90fb43def5014c11a7eadc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649596
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667479}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674360
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#506}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Move GridTabSwitcherLayout to tab_ui feature folder
Bug: 971840
Change-Id: I8e105401276130c3d690c24e37228d80d18eddfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648939
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667263}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674359
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#505}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make setRootId() persistent
Currently, changes by setRootId() in Tab are not reflected in TabState
and will be lost when tabs are restored. This CL fixes this issue.
Bug: 971327
Change-Id: Ia7daf36d4feb23f79b9c364d1232090671a7b9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647134
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667239}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674358
Cr-Commit-Position: refs/branch-heads/3809@{#504}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make transition animation in Grid Tab Switcher closer to spec (2)
Updates in Tab-to-Grid transition animation:
- Do not show the selected blue border in the grid when the tab resizes
- Fade in the selected blue border along with the GTS final fading-in
Bug: 971522
Change-Id: If788855ce4659226900759517cf7f8e9ab536e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648835
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667204}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674357
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#503}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make transition animation in Grid Tab Switcher closer to spec
Updates in both Tab-to-Grid and Grid-to-Tab transition animations:
- Stops showing the tab decoration when the tab resizes
- Fade in/fade out the GTS in the background when the tab resizes
- Update interpolator for tab resizing
Updates in Tab-to-Grid transition animation:
- Duration of GTS final fading-in: 218ms -> 50ms
- Delay the fading-in of Tab Switcher top toolbar to the second half
of the animation
Bug: 971522
Change-Id: Ifc34437cb6691b18f0e4c63439b464b637927310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646741
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667193}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674356
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#502}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabGroupModelFilter] Add mergeListOfTabsToGroup API
This API is for manually group multiple tabs through the
TabSelectionEditor.
Change-Id: I8782eb2185e69b60b72ad61ef0fd3be8724ae210
Bug: 971872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649138
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#667031}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674355
Cr-Commit-Position: refs/branch-heads/3809@{#501}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a string for TabGridDialog Ungrouping
Bug: 971808
Change-Id: I39ede699705b8b717235d1b7267722c7319de49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648700
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666937}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674354
Cr-Commit-Position: refs/branch-heads/3809@{#500}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Update SelectableListLayout when Adapter had changed
Currently SelectableListLayout only updates its internal views (i.e.
EmptyView, LoadingView, RecyclerView, Toolbar.Search) on
AdapterDataObserver#onChanged(), which is a listener for
Adapter#notifyDataSetChanged(). For some Adapter that only uses the
specific change events (i.e. notifyItemRangeInserted,
notifyItemRangeRemoved, etc) the internal views never update.
This CL updates the internal views in the specific change event
listeners as well.
Change-Id: I6864ae57c749106d2eb02ab3f359b73d01de8fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647897
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666936}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674353
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#499}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make TabGridContainerViewBinderTest more strict and robust
On devices with Settings.Global.ANIMATOR_DURATION_SCALE set to 0 to
disable animations, we should not assert the starting state of an
animation because it ends immediately.
Bug: None
Change-Id: I29260abc5f349f5c337105bc50c4f2fdf53626d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646896
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666771}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674352
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#498}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add SelectableTabGridViewHolder
Change-Id: I7b9f5952f1cf16a2bc60699f8862ffe859f59837
Bug: 970267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643107
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666511}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674351
Cr-Commit-Position: refs/branch-heads/3809@{#497}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabSelectionEditor] Add strings
Change-Id: If3d333382233c155e4882e04fb3e9acbc14ea109
Bug: 970982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644525
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666458}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674350
Cr-Commit-Position: refs/branch-heads/3809@{#496}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Enable drop-to-merge in GTS
This CL enables dropping a tab on another tab to form a group. It is
behind the TabGroupsAndroidUiImprovements flag.
Bug: 963692
Change-Id: I1cb49a20459972af3c02bdc7c9ebb9480209de29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615606
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666450}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674349
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#495}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a soft cleanup stage for Grid Tab Switcher RecyclerView
Before the Grid Tab Switcher RecyclerView is fully cleared, add an
intermediate state where the thumbnails are released, but the Views are
kept.
Bug: 968822
Change-Id: I0f795773a73949daf7e04c8c6c51e682ed95cfe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643070
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666380}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674348
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#494}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Refactor TabGridViewHolder to support various item view types
This is the first CL for upstreaming TabSelectionEditor. This CL
refactors TabGridViewHolder to support creating different ViewHolders
for a RecyclerView based on the provided item view type.
Change-Id: I94aa3c92875b31b0f9f79d4ce0e0c56b43ef9392
Bug: 970087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642140
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666120}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674384
Cr-Commit-Position: refs/branch-heads/3809@{#493}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Optimize thumbnail capturing for Tab-to-Grid transition animation
Split the forced live thumbnail capturing out of the normal caching
path. The forced live thumbnail is captured as low-res, and won't be
saved to the cache. This makes it faster so that using it during
the Tab-to-Grid transition animation won't affect the frame rate too
much.
Bug: 968829
Change-Id: I32ffa8553b5aefb29944781404292a8b891d8d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637979
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#665691}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674345
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#492}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
IndexedDB: Bind version change transaction just before upgradeNeeded
(cherry picked from commit 15efe9aaea3e3a4109d835c9d28d0a4d7a7cffe0)
Bug: 972239
Change-Id: I2b94cffd8b9121702bbbe510372d5271edd1f627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661153
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Chase Phillips <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669771}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674385
Reviewed-by: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#491}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
IndexedDB: Use a local WeakPtr to connection during abort
Bug: 972239
(cherry picked from commit 85d1a1e1c3f9bf24cbf24735dbf8de8eb6915ba4)
Change-Id: Ifc22d6e51b945ed37b7f76a44d4ea095afbcb145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658768
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668933}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673441
Reviewed-by: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#490}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
[email protected]
Change-Id: I58b3b52d218395f11a1e38fdbd1ddbba261494b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673759
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#489}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
add a new chrome launch metrics source, WST for file
Previously, we have ShortcutSource.WEBAPK_SHARE_TARGET to show
chrome is launched as a result of user sharing text. As we
introduce the ability for WebAPK to receive file sharing,
we add ShortcutSource.WEBAPK_SHARE_TARGET_FILE to show
that chrome is launched as a result of binary file sharing.
Bug: 978039
(cherry picked from commit 17e2b41a09ffdc2887dbc6c6e168c162beb5ec1c)
Change-Id: Id21d055baad3e5ff1ddb55309d1e6b278f144117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668089
Commit-Queue: Henry Jian <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Peter Kotwicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671346}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673758
Cr-Commit-Position: refs/branch-heads/3809@{#488}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix toolbar_buttons container visibility issue after omnibox expansion animation
The issue is that because of the condition in
updateUrlExpansionAnimation(), toolbar_buttons container doesn't get hidden at
the end of animation after omnibox gets expanded. Hiding the container is
important since it prevents buttons from handling taps destined for omnibox's
(x) or microphone buttons.
Hiding or showing the container preserves visibility of individual buttons, that
is set in onBottomToolbarVisibilityChanged() and handleOmniboxInOverviewMode().
BUG=943453
R=[email protected]
(cherry picked from commit cdd025e59b74e4b2004454592d352d9ab3fdfa7a)
Change-Id: I4dca7bce86376c08ba9762831b5ac76a25041489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666689
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674325
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#487}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Crash] Investigate the crash in AppListClient
(cherry picked from commit 7a107220607cbd32481e38a85e82ac3bba16cac8)
Bug: 969810
Change-Id: I48acc58094ca38cc251cbeee83603ba1ecfad52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650537
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668484}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673133
Reviewed-by: Vladislav Kaznacheev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#486}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Need to be able to open Google services settings from incognito
Google services settings should be able to be opened from the incognito
mode.
(cherry picked from commit c88b2d61ea8a064bd7c88d1fc11d38b082446e60)
Bug: 967674
Change-Id: I9008c0159b7729c17a7fc703c5a61171d2dd85e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640555
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669094}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673756
Reviewed-by: Kariah Davis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#485}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Change progress bar hiding logic
Key events should not hide the progress bar. It should be shown for
at least 3 seconds. It should only hide when the page is fully loaded.
(cherry picked from commit 9421063d38db286fe7bee1aa337f47d3481db9a1)
Bug: 977021,b/135075564
Change-Id: I566905704eadfbea587f79765ec5e1d245bc2aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669324
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671031}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672779
Cr-Commit-Position: refs/branch-heads/3809@{#484}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] delete notifications when syncing is disabled.
(cherry picked from commit feae5579188fc8f187042a128daf5b1d9d45f8bc)
Bug: 973989
Change-Id: Ieeb9368624b5d6fb666e5aaef7648fef33c56db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659689
Commit-Queue: Jeffrey Cohen <[email protected]>
Reviewed-by: Tanya Gupta <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Auto-Submit: Jeffrey Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671106}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672945
Reviewed-by: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#483}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Improve TalkBack support.
(cherry picked from commit 880e1a5168b6595ce07a909404b4c91b397f8af9)
Bug: 977959
Bug: b/135203438
Bug: b/132337665
Change-Id: I3986904c234cd739689c50c49525327ba42b35ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669352
Auto-Submit: Jordan Demeulenaere <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Commit-Queue: Jordan Demeulenaere <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670870}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674153
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#482}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Propagating whether navigation is initiated by link to Password Manager.
This CL contains:
1.Propagating whether navigation was initiated by link click to browser process.
2. On Password Manager side, replacing has_user_gesture is replaced with
was_initiated_by_link_click, that reproduces the logic that was in the old
architecture
[email protected]
(cherry picked from commit 910bddb3933e65751f3ba1074ad26d3122066775)
Bug: 971283
Change-Id: I98f2f92bc29c840c572e61a11f0f740366351b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649359
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Vadym Doroshenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668839}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674023
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#481}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add type checks to V8HostDefinedOptions deserializer
[email protected]
(cherry picked from commit 4f04de5a33544e8954dfc9b2009a8ea96dfb73d7)
Bug: 973893
Change-Id: I81804eaa9874515e5549290b6776dfdda14e2c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668371
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Kouhei Ueno <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670784}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673129
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#480}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge "Fix the crash when calling ExternalDateTimeChooser::EndChooser() twice" to M76 branch
The original CL has been calling EndChooser in ResponseHandler in order to
set nullptr in |client_|. But, it has been causing a crash in cases EndChooser is
called from other callers. Because the first call of EndChooser already set
nullptr in |client_|, |client_| is nullptr in the second call.
This CL fixes the crash by removing the call of EndChooser from ResponseHandler.
(cherry picked from commit 62c8c6b32e6dbd61731f33e5bf400ae19386e76a)
Bug: 974646, 950157
TEST: WebViewTest.ExternalDateTimeChooserEndChooserShouldNotCrash
Change-Id: I4add312f150ed1c8ce93e0c0c738609d34397223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663652
Commit-Queue: Gyuyoung Kim <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670423}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673884
Reviewed-by: Gyuyoung Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#479}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.42
[email protected]
Change-Id: Ida3d36d1aa968a66675218001cb4defdcb1bf479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673127
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#478}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "[Merge to M76] Fix Android NTP kills by disallowing NTP process reuse before processing the NTP commit."
This reverts commit 140bb006bf4925caf171ab9510afaca87a663624.
Reason for revert: Breaking official build.
Original change's description:
> [Merge to M76] Fix Android NTP kills by disallowing NTP process reuse before processing the NTP commit.
>
> SiteInstance supports a class of "siteless" URLs that represent blank
> or placeholder documents, which normally do not "use up" their process
> (by leaving their site URL unassigned) and allow subsequent
> navigations to stay within the same process. Currently, these URLs
> include "about:blank" as well as chrome-native://newtab on Android
> (used as a placeholder when loading the native NTP to warm up the
> process for a subsequent navigation).
>
> Unfortunately, with Android NTP, a race is possible where the NTP
> placeholder process is told to commit chrome-native://newtab, but
> before we hear back the DidCommitProvisionalLoad IPC for
> chrome-native://newtab, a subsequent navigation to foo.com starts,
> reaches the ReadyToCommit stage, and locks the NTP process to foo.com.
> When the chrome-native://newtab commit is processed, we kill the
> renderer, since the foo.com process lock is not compatible with
> chrome-native://newtab.
>
> To fix this, this CL disallows reusing a process during the narrow
> window of time when it has a pending commit to a siteless URL like
> chrome-native://newtab (i.e., after CommitNavigation is sent, but
> before DidCommitProvisionalLoad is received). It's still fine to
> reuse the NTP process post-commit, which is expected to be the common
> case that requires the process reuse optimization.
>
> [email protected]
>
> (cherry picked from commit e2af10b0c5228b510583ef38d4218025a22f66f8)
>
> Bug: 970046
> Change-Id: I82c4fa964e3b0cc5ed400b7da9981573f7873d86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661271
> Reviewed-by: Steven Holte <[email protected]>
> Reviewed-by: Charlie Reis <[email protected]>
> Commit-Queue: Alex Moshchuk <[email protected]>
> Auto-Submit: Alex Moshchuk <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#670618}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672944
> Reviewed-by: Alex Moshchuk <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3809@{#473}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 970046
Change-Id: I02af19d7ea3b675d4102d9ab3fd53845d0bdc152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673597
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#477}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
WebSocket: stop removing an iframe in onerror from crashing
There was an issue that if the iframe owning a WebSocket was
synchronously removed in the onerror handler then it would crash the
render process. This was caused by unconditionally calling Close()
without checking the current state.
Fix it.
Also add a web platform test.
(cherry picked from commit 043af69d08dfa1e9f6c7675ee0fecb46625647b5)
Bug: 974667
Change-Id: Iaeb8f96cf600a2c052f06b5b59f4444b02615e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663681
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670061}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673644
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#476}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.41
[email protected]
Change-Id: I1d7748addd83c2167ef274b04140c308981f395b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673567
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#475}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.40
[email protected]
Change-Id: I4fc5fefb7d9b0e96da3beaccb8b4ca4aa79f7b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673124
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#474}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M76] Fix Android NTP kills by disallowing NTP process reuse before processing the NTP commit.
SiteInstance supports a class of "siteless" URLs that represent blank
or placeholder documents, which normally do not "use up" their process
(by leaving their site URL unassigned) and allow subsequent
navigations to stay within the same process. Currently, these URLs
include "about:blank" as well as chrome-native://newtab on Android
(used as a placeholder when loading the native NTP to warm up the
process for a subsequent navigation).
Unfortunately, with Android NTP, a race is possible where the NTP
placeholder process is told to commit chrome-native://newtab, but
before we hear back the DidCommitProvisionalLoad IPC for
chrome-native://newtab, a subsequent navigation to foo.com starts,
reaches the ReadyToCommit stage, and locks the NTP process to foo.com.
When the chrome-native://newtab commit is processed, we kill the
renderer, since the foo.com process lock is not compatible with
chrome-native://newtab.
To fix this, this CL disallows reusing a process during the narrow
window of time when it has a pending commit to a siteless URL like
chrome-native://newtab (i.e., after CommitNavigation is sent, but
before DidCommitProvisionalLoad is received). It's still fine to
reuse the NTP process post-commit, which is expected to be the common
case that requires the process reuse optimization.
[email protected]
(cherry picked from commit e2af10b0c5228b510583ef38d4218025a22f66f8)
Bug: 970046
Change-Id: I82c4fa964e3b0cc5ed400b7da9981573f7873d86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661271
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Auto-Submit: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670618}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672944
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#473}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
HTMLCanvasElement: Fix destruction involving SurfaceLayerBridge
HTMLCanvas element needs to clear out its own reference from the
SurfaceLayerBridge (observer_) on pre-finalizer as otherwise (in rare
cases) the SurfaceLayerBridge may call into an already dead object. This
is undefined behavior and may work, crash immediately, or worst case
crash way later when the garbage collector tries to iterate such a data
structure.
(cherry picked from commit bf2086cc336ee8650b0f606addd8707f11242fe5)
Bug: 971418, 976577
Change-Id: Ic0cc436e33b6f65e0ab85d2275422279d3d6c8fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666034
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Michael Lippautz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670457}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672844
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#472}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.39
[email protected]
Change-Id: I897397e079d0cac5f6da34ef50b39d9b56a21763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672605
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#471}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Unmount DriveFS on suspend and remount (if enabled) on resume.
FUSE doesn't cope well with attempting to freeze while an operation is
in flight. Avoid this by unmounting on suspend and remounting after
resuming.
(cherry picked from commit 1a04cc9ab191f936abc97b8ae2a7b45c19629225)
Bug: b:134792837
Change-Id: I4fa836b33f8a5b486e458f10228ae111d9dd1d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662208
Commit-Queue: Sam McNally <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669961}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666618
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#470}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] Delete contextual menu icon on mac
Delete icon accroding to UX mocks.
(cherry picked from commit 06b2c57b3128c50171fd72421fc99a9efa69d9b7)
Bug: 970897
Change-Id: Ib7d742469247029d20ddc4dc4fd655554178111a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666171
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Tina Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670525}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672569
Reviewed-by: Tina Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#469}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Prevent the execution of async startup code while shutting down.
Until recently, the actions of StartupBrowserCreator were synchronously
guarded by an IsShuttingDown() check in
ProcessSingletonNotificationCallback.
However, the following CL recently introduced an async task step:
https://chromium.googlesource.com/chromium/src/+/3a7f1a11c1d19c789aa3b34951da773ff8780763
That async tasks now makes it possible for a shutdown to begin after
the IsShuttingDown() check is made but before the StartupBrowserCreator
code actually starts running.
This fix moves the async task earlier, prior to the shutdown check
and the invocation of any code that relies on not being called in the
middle of shutting down.
This ensures that such code executes synchronously after the shutdown
check, as it was doing up until recently.
(cherry picked from commit 2ea3ca7556387703f7d7f44819591bc00ac2844a)
Bug: 961878,964529
Change-Id: I1fac121197850dd70f0e2713b089b15c306dcac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644500
Reviewed-by: Robert Liao <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: David Bienvenu <[email protected]>
Commit-Queue: Matt Siembor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666882}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669944
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#468}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Account for GraphicsLayer content offset when calling JankTracker.
CLM reported layout shifts on the basis of GraphicsLayer position, which
led to false positives when a layer expanded upwards or leftwards to
accomodate negative-overflow content.
A popular adblock detection script triggered this on several sites by
adding a 1x1 abs-pos at (-10000, -1000), when the <html> element was
composited (e.g. due to negative z-index fixed-pos descendants).
We now avoid this by taking GraphicsLayer::offset_from_layout_object_
into account for the purpose of layout shift detection.
[email protected]
(cherry picked from commit a9a047e8c9ebb56f5e41fd220695ff779055cb8d)
Bug: 966617
Change-Id: Ice9cb3ea2d86891a6c8dbccc2ab94ab89a5f3e0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661116
Reviewed-by: Bryan McQuade <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Steve Kobes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671587
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#467}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Partially deduplicate cookie SameSite deprecation messages in browser
[Merge to M76 release branch]
This CL adds partial deduplication of cookie SameSite deprecation
messages in the browser (RenderFrameHostImpl) before the IPC message
to the renderer to add the message to the console. It is hoped that this
pre-deduplication step will reduce the perf impact by decreasing the
volume of IPC messages caused by the cookie deprecation messages.
(cherry picked from commit fd40a019a62a91c85a1d473b1b21b110c6a2cc6a)
Bug: 971698
Change-Id: I50c5d6a3c2b96ae4d09b941f05e90351ee2ebcea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658888
Commit-Queue: Lily Chen <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670780}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671547
Reviewed-by: Lily Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#466}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge 76] Integrate unsized-media policy with origin trials
Setup a separate runtime flag for the unsized-media feature policy, and
make available via origin trial. Add a UseCounter to enable usage tracking for the trial.
Also, fix a typo in one of the related implementation files.
(cherry picked from commit 34e3a7b8585fa6337efe76918753cd3e1c877696)
Bug: 969059
Change-Id: If0fbea38d3979f98cdbf8d99dc1630459bef7053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638349
Reviewed-by: Luna Lu <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Jason Chase <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666822}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671247
Reviewed-by: Jason Chase <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#465}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Partially deduplicate SameSite cookie deprecation messages
[Merge to M76 release branch]
This adds the ability to request deduplication of console messages
in blink by adding a "discard_duplicates" parameter that specifies
whether duplicate messages should be discarded when adding a message
to ConsoleMessageStorage.
This is for the purpose of partially deduplicating SameSite cookie
deprecation messages to reduce console spam.
(cherry picked from commit ee28094c16e4909b08aea95498bc2787a5b8df40)
Bug: 971698
Change-Id: I2d056d7ed90f920e52cda1d98eb6a84ea55ceaec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646545
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Lily Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669406}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671167
Reviewed-by: Lily Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#464}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[AW NS] Implement proper cleanup for the case when input stream fails to open.
MERGE to M76
Depending on the scheme and custom request interception response the network
request can be restarted or completed when the |input_stream| in
AndroidStreamReaderURLLoader fails to open (i.e. it is null).
In the case when |input_stream| fails there are a number of cases listed below
when we can cleanup AndroidStreamReaderURLLoader immediately (*). In other cases
we need to keep AndroidStreamReaderURLLoader around, as the potential error
reporting can happen via the HTTP_NOT_FOUND header.
(*) Cases when input_stream fails to open and the AndroidStreamReaderURLLoader
is not needed anymore:
1. InterceptResponseDelegate :
- custom response, no restart required
2. ProtocolResponseDelegate :
- e.g. file:///android_asset/, restart required
3. InterceptResponseDelegate, intercept-only setting :
- used for external protocols, no restart, but completes immediately.
This patch provides a consistent implementation for handling those cases and
adds additional documentation where necessary.
Technical note:
Without this patch case 3 would still result in AndroidStreamReaderURLLoader
being cleaned up, although via an unnecessarily elaborate path. In particular
while trying to use the mojo pipe and getting a MOJO_RESULT_FAILED_PRECONDITION
(consumer handle closed) eventually yielding RequestComplete with
net::ERR_ABORTED.
BUG=841556,971249
(cherry picked from commit 7e37fe3e1f1659a4d5368768983e2a58475d9019)
Change-Id: I08c4ff252cc9be3d7700df25171f221dcb579be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645369
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670516}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671107
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#463}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[76 merge] M76 CT Log List Additions/Removals
Add newly Qualified CT Logs and remove 2018 CT Log shards.
(cherry picked from commit ca205798b0758e81d655be8a34f1df10e3b37e3f)
Bug: 962537, 859093, 888130, 796333, 801624
Change-Id: I4b0e5b772c1726af2cb7c633de038b0827453b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644898
Commit-Queue: Devon O'Brien <[email protected]>
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666475}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671021
Reviewed-by: Andrew Whalley <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#462}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[css-flexbox] Also skip non-flexbox items with percentages
The same percentage issue happens with regular blocks. See the
linked bug and associated testcase.
R=[email protected], [email protected]
(cherry picked from commit 780ca71745550f7ec29a5400e3596fc5c094a720)
Bug: 973924
Change-Id: I588353f0dcce4a446c08a8aa0f186c9ec2ee8949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667684
Commit-Queue: Christian Biesinger <[email protected]>
Auto-Submit: Christian Biesinger <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670606}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671053
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#461}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[spat nav] Don't report focus exitable when body is focused
The body can't be unfocused, so we shouldn't report that it can be,
and in any case unfocusing the body would not be useful.
(cherry picked from commit c120e4dda123dbcdd6fb2ec9acb4e96e398d832c)
Bug: 968157
Change-Id: Ie77bedeef0a70084eea1344d6c69ee3daaed916e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661069
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669883}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669084
Reviewed-by: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#460}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add nullity check to spatial navigation controller
The HTMLFormElement's formOwner can be null and we should
check before using it.
(cherry picked from commit b4cd421fa34c3ba3c9333b2980b6211ccdb3f35b)
Bug: 974327
Change-Id: I39339b9d43e1fedff0c50f25bcd7dfb69e2fb8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667788
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#671104}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669080
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#459}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Expose kSafeBrowsingExtendedReportingOptInAllowed pref in Java
This CL makes it possible to disable the checkbox for extended Safe
Browsing reporting from Java.
(cherry picked from commit 5a7e34ee664bd3035e14ce2b2d10a6599e1ae246)
Bug: 938902
Change-Id: I82eaa03094cd75cd3da4dc3235dfc7bd681d29f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660862
Commit-Queue: Alex Ilin <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670011}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669288
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#458}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.38
[email protected]
Change-Id: I4eebc8ce304e840a13245a96ca677913c1afceb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670394
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#457}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
[email protected]
Change-Id: Ib79846e9b9596611e08d910b682395a1ae24f471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669659
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#456}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Support the MaxConnectionsPerProxy Policy when using Network Service.
[email protected]
(cherry picked from commit 06e0b958e798acf6a9391b8d5e4e3077aca0fe81)
Bug: 972125
Change-Id: Iaf773b6b6acec9048c6695539a3a03147598602f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660966
Reviewed-by: Robbie McElrath <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670297}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669766
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#455}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Implement downloads pause/resume flow
This patch implements controls for downloads. The new UI exists as a
separate activity and is triggered by the download notification. The
UI is one-per download and contains the title of the affected
download, a pause/resume button, and a cancel button.
[email protected]
(cherry picked from commit 06d8dbc12c052594ca3b0faea49ffa7eeab0c6a7)
Bug: 969220
Change-Id: Id064a2b1a0b9159e3f9f8d1dba5badddd65920e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663056
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670130
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#454}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix NPE while recording AnswerType for Calculation suggestion.
Calculation suggestion is not like the others - it is not strictly an answer and does not
have a SuggestionAnswer attached. It is, however, processed by the AnswerSuggestionProcessor.
This change ensures no access to Answer structure is made by AnswerSuggestionProcessor
if any (currently only Calculator) of the managed Suggestion entries does not have an
associated SuggestionAnswer structure.
(cherry picked from commit 7e6f573075959c48473442687d61c714d0988d4b)
Bug: 976239
Change-Id: Iddfd0e90b901847a47628038e96851f3741d4ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664039
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Ender <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#670199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664594
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#453}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios/web] Suppress visibleItem during lastCommittedItem mismatch.
WKWebView is more aggressive than Chromium in updating the visible
URL, and there are many cases where the WKWebView URL has updated and
Chromium still displays the last committed item. Normally this is
managed by WKBasedNavigationManagerImpl last committed, but there are a
few periods during fast navigations where WKWebView URL has updated
and ios/web can't always verify what should be shown for the visible
item. More importantly, there are bugs in WkWebView where WKWebView's
URL and backForwardList.currentItem can fall out of sync. While those
bugs should be fixed, safeguard visibleItem by returning documentURL
in those untrusted situations.
Bug: 971740
(cherry picked from commit a11f4f77f56d7fbea2ddbb11e6a201ba8f59f8cb)
Change-Id: Iafaa274fc871203a08b71dfd4ec71b03119ee8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656095
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670180}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669577
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#452}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Mash cleanup: migrate LoginScreenClient from mojo to C++.
LoginScreenClient becomes a C++ interface, and mojom::LoginScreen can
now be removed.
LoginScreen's last two methods, ShowLoginScreen and ShowLockScreen,
are moved to the C++ interface, and since they're now synchronous,
calling code has to be rearranged slightly. The return values are
removed, because ShowLockScreen always returned true and while
ShowLoginScreen sometimes returned false, the calling code always
CHECKed that the value was true.
[email protected], [email protected]
(cherry picked from commit 2e4c22ee482152be1b09ddabbf877b0cfad4107e)
Bug: 958206,972950
Change-Id: I650d5cec4f9b01e97a093d9d6180dddb170c46e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643351
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#666980}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667785
Reviewed-by: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#451}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
AppCache: Mitigate bad traffic caused by invalid cached data.
This CL works around the following confluence of problems.
1) If a cached response contains a Last-Modified header,
AppCacheUpdateJob::URLFetcher::AddConditionalHeaders() adds an
If-Modified-Since header, so the server may return an HTTP 304 Not
Modified response. AppCacheUpdateJob::HandleUrlFetchCompleted() reuses
the existing cache entry when a 304 is received, even though the HTTP
specification mandates updating the cached headers with the headers in
the 304 response.
This deviation from the HTTP specification is Web-observable when
AppCache resources are served with Last-Modified and Cache-Control:
max-age headers. Specifically, if a server returns a 304 with a
Cache-Control: max-age header, the response stored in AppCache should be
updated to reflect the new cache expiration time. Instead, Chrome
ignores all the headers in the 304 response, so the Cache-Control:
max-age directive is discarded.
In other words, once a cached resource's lifetime expires, 304 responses
won't refresh its lifetime. Chrome gets stuck in a cycle where it sends
If-Modified-Since requests, the server responds with 304, and the
response headers are discarded.
2) The implementation of
AppCacheUpdateJob::UpdateURLLoaderRequest::OnReceiveResponse()
introduced in https://crrev.com/c/599359 did not populate |request_time|
and |response_time|. When the Network Service was enabled, caches got
populated with the default value of base::Time, which is the Windows
epoch. So, cached entries with max-age values below ~40 years will
require re-validation. https://crrev.com/c/1636266 fixed the cache
population bug, but did not address the incorrect times that have
already been written to users' disks.
The 1st problem, on its own, hasn't had a large impact. This is likely
because we have been advising sites to set max-age=31536000 (~1 year)
for immutable resources, and most AppCache caches have been getting
evicted before the entries' max-age expired. However, the 2nd problem
caused us to create a large number of expired cache entries, and the
unnecessary If-Modified-Since requests are causing noticeable levels of
traffic.
This CL introduces a workaround while a longer-term fix gets developed
and deployed. We'll consider all cache entries with invalid times to
have been created on Tue, Jan 29 2019. This is the day when M72 was
released to Chrome's Stable channel, and was chosen be cause M72 had the
first large Network Service deployment.
This CL was tested manually because the cost of developing an automated
test outweighs the benefits.
* Costs: AppCache doesn't support injecting a base::Clock, so the test would
have either required a lot of plumbing, or would not have tested the
exact bug scenario.
* Benefits: The code added here is a workaround. It will be replaced by
logic that updates the cache entry's headers when a 304 response is
received. Since the code has a short expected lifetime, it's unlikely
that an automated test will catch any regressions.
Tested: Manually, using the repro steps in https://crbug.com/972983#c3
Bug: 972983, 968179
(cherry picked from commit 20234641d9b26cc60123f5e9b5d2691fb311109f)
Change-Id: I68860ed28c4980e0a16297a243181995f5993ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661472
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Staphany Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#669559}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669873
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#450}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] Updated strings and their descriptions to be more clear.
(cherry picked from commit a4ce174b10b07f920c8ef9ea1888325985983101)
Bug: b/134768051
Change-Id: Ie01477ffe156285b4b7d31e2bcac31b9c2fe9952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666436
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Tanya Gupta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669177
Reviewed-by: Tanya Gupta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#449}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Permit dynamically disabling spatial navigation
This adds plumbing to update whether spatial navigation is
enabled at runtime.
(cherry picked from commit 5d5c37fd3e4e20e218a0a606101ecb1342aeb5c2)
Bug: 971658
Change-Id: I4c4e597f43e001f60d76283cfa3e6156e2c8c49f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664633
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670697}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669401
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#448}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Pass down the scoped access token to GCPW
Access token being passed to GCPW from chrome login UI is login scoped.
As part of chrome login UI, a down scoped access token is also generated.
A similar scoped token is also needed in chrome/credential_provider code.
R=rogerta, tienmai
(cherry picked from commit 24ba221ec694505920b501e8874ed100f1fecf26)
Bug: 971498
Change-Id: I8696947cc7d0b46d96f786af63b4c8a597328a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646496
Commit-Queue: Yusuf Sengul <[email protected]>
Reviewed-by: Tien Mai <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668389}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662996
Cr-Commit-Position: refs/branch-heads/3809@{#447}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.37
[email protected]
Change-Id: Ib364d1562af425ec5a78ff812e6ecf6a2d56f268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668492
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#446}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[CrOS Network] Fix <network-config> password functionality.
When configuring a Wi-Fi network and choosing the security type, the
password field would sometimes not display when it should have; e.g., if
the WEP security type is chosen, a password field would not always
appear.
This issue was caused by an issue with computed bindings; specifically,
the HTML template for this element defines a dom-if using:
<template is="dom-if"
if="[[configRequiresPassphrase_(type, security_)]]" restamp>
The configRequiresPassphrase_() function would then check |this.type|
and |this.security_| to make a determination of whether to show the
password field. The |this.security_| property was modified by another
element on the page, and each time the property changed, we would
re-assess whether the password section should be shown.
However, when this function was run, |this.security_| was actually the
*previous* value, from before the property was changed. According to
[1], configRequiresPassphrase_() should actually be taking the two
properties as parameters instead of relying on |this.*| within the
function itself. I converted to this format, and it fixed the issue.
Note: There are a lot of functions throughout WebUI which follow the
same pattern which caused the bug, but they don't seem to cause the same
bug here. It's possible that this is some sort of race condition in
Polymer's data binding code.
[1] https://polymer-library.polymer-project.org/2.0/docs/devguide/data-binding#annotated-computed
(cherry picked from commit 396fc6c8745eafc30a1d72124aa5709105da4641)
Bug: 976385
Change-Id: I0449da9465a08f2ce107ac43c32644921b5e368d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666508
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Auto-Submit: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670563}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668488
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#445}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Correct focus highlights on native surfaces.
* Replaces dialog menu's text/icon focus coloring code logic with styles
and resources.
* Adds text/icon focus coloring to more button.
* Adds text focus coloring to last tab button.
In the process, also adjusted fonts slightly:
* Replaced gray 700 + black coloring of dialog menu button text with
gray 900.
* Replaced gray 700 coloring of more button text with gray 900.
* Removed bold font from last tab button text.
(cherry picked from commit 67f4fd19de6dfdd4c2a8123654db47e42ce45f03)
Bug: 962507
TBR: [email protected]
Change-Id: I4ef82003380a2d272cb9f01add5cd5b681cfa4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627782
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#670208}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667786
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#444}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Mash cleanup: migrate more of mojom::LoginScreen to LoginScreen.
[email protected], [email protected]
(cherry picked from commit 9fe9cbe07154f4f081f47c2c33ed9f552f6ecb89)
Change-Id: I92c4525694b3092cb5eccac07977f8663c058c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639520
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#665694}
Bug: 972950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666456
Cr-Commit-Position: refs/branch-heads/3809@{#443}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Reduce binary size on M76.
Due to reliability issues the autofill_assistant feature module has been
disabled on the M76 branch. In the previous release M75 we mitigated the
additional footprint by removing some resolutions of the resources.
This patch removes these resources again, saving ~100k in binary size:
- Removed several icon densities.
- Converted pngs to webp.
For reference, here is the patch developed on the M75 branch:
http://crrev/c/1610070
Bug: 976226
Bug: b/133669491
Change-Id: I9f7dba8d70148b53e4f5ee96e7b6c8ae45139a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663413
Reviewed-by: Peter Wen <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Commit-Position: refs/branch-heads/3809@{#442}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disable Crostini backup by default
This is to be merged for M76.
(cherry picked from commit 8c7df39d6bc6aad4c93d2e4c9044be71d27588f8)
Bug: 970940
Change-Id: Ia048382db0c0a3cc668dd79f5495f3c6e12545ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654752
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Jason Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#668283}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666835
Cr-Commit-Position: refs/branch-heads/3809@{#441}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
