Publish DEPS for 73.0.3683.57

• DEPS[diff]

Incrementing VERSION to 73.0.3683.57

[email protected]

Change-Id: I98b4f1734c63224284e6f855cc62b1a18f64547d
Reviewed-on: https://chromium-review.googlesource.com/c/1490856
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#659}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

Safe Browsing: enable billing interstitial by default

This flips the kBillingInterstitial Feature (AKA "Trick to Bill") to
enabled-by-default, since Android WebView intends to launch it. This
should be the last platform depending on this code.

R=​[email protected]

Bug: 933807
Test: Manual - feature is on
Change-Id: If103d7b8b54745564347313bb953fa8faefa0f76
Reviewed-on: https://chromium-review.googlesource.com/c/1478945
Commit-Queue: Varun Khaneja <[email protected]>
Auto-Submit: Nate Fischer <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633888}(cherry picked from commit 1478d7795f974b62ec8db67a101e086cd6223b34)
Reviewed-on: https://chromium-review.googlesource.com/c/1490853
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#658}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/safe_browsing/features.cc[diff]

[IntersectionObserver] Assume non-zero opacity for unpainted iframes

Cherry-picked from:

https://chromium-review.googlesource.com/c/1478944

BUG=933694
[email protected]

Change-Id: I0a0aac1da5ab30ab09c1557e88387b1a2987bdf0
Reviewed-on: https://chromium-review.googlesource.com/c/1478944
Reviewed-by: Aleks Totic <[email protected]>
Commit-Queue: Stefan Zager <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633880}
Reviewed-on: https://chromium-review.googlesource.com/c/1490409
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#657}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/layout/layout_object.cc[diff]

[Audio Focus] Enable ducking for flash

Enable ducking for flash based videos.

BUG=931892

Change-Id: I68ee115d6a5938a86ca624b2cfa5295b9d95e43b
Reviewed-on: https://chromium-review.googlesource.com/c/1481588
Reviewed-by: Tommy Steimel <[email protected]>
Commit-Queue: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634380}(cherry picked from commit 1463f0e39ff18ad06ce0f0ee481254e8f8f490ca)
Reviewed-on: https://chromium-review.googlesource.com/c/1490514
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#656}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• media/base/media_switches.cc[diff]

[Audio Focus] Remove force duck abandon behaviour

If a force duck session abandons audio focus then we
should stop ducking it. It should not have the
custom behaviour.

BUG=931892

Change-Id: Ib6f1198e05179b5bede8cf23414729be0e4b286b
Reviewed-on: https://chromium-review.googlesource.com/c/1481587
Reviewed-by: Tommy Steimel <[email protected]>
Commit-Queue: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634371}(cherry picked from commit c1746cdb50c472568c79f7833e07fbb68fdc84c9)
Reviewed-on: https://chromium-review.googlesource.com/c/1490437
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#655}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• services/media_session/audio_focus_manager.cc[diff]
• services/media_session/audio_focus_manager.h[diff]
• services/media_session/audio_focus_manager_unittest.cc[diff]

Merge "Add a new policy source"

Merge into M73.

The new policy sources is used by the cloud policies that have high priority
than other policies.

Also do some other refactor:
1) Move the CloudPolicyOverridesMachinePolicy pref registy to policy component.
2) Delete policy_helper.h/cc because it's empty.
3) Make policy_ui_handler and policy_conversions share the same instance of
   PolicyStringMap.

Bug: 749530
Change-Id: Ie3a9c9ce87bd78bc9159582eae4d463616fd9aeb
Reviewed-on: https://chromium-review.googlesource.com/c/1488011
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635587}(cherry picked from commit cc28e52c5bb021297c330df0b69e56ea4307c0be)
Reviewed-on: https://chromium-review.googlesource.com/c/1489894
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#654}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/BUILD.gn[diff]
• chrome/browser/policy/configuration_policy_handler_list_factory.cc[diff]
• chrome/browser/policy/policy_conversions.cc[diff]
• chrome/browser/policy/policy_conversions.h[diff]
• chrome/browser/policy/policy_helpers.cc[Deleted - diff]
• chrome/browser/policy/policy_helpers.h[Deleted - diff]
• chrome/browser/prefs/browser_prefs.cc[diff]
• chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc[diff]
• chrome/browser/profiles/profile_io_data.cc[diff]
• chrome/browser/ui/webui/policy_ui_handler.cc[diff]
• chrome/browser/ui/webui/policy_ui_handler.h[diff]
• chrome/common/pref_names.cc[diff]
• chrome/common/pref_names.h[diff]
• components/policy/core/browser/browser_policy_connector.cc[diff]
• components/policy/core/common/policy_pref_names.cc[diff]
• components/policy/core/common/policy_pref_names.h[diff]
• components/policy/core/common/policy_types.h[diff]

Incrementing VERSION to 73.0.3683.56

[email protected]

Change-Id: Ic28d0e1a5e977a36cb2ce0e2e89b2d129b73e54e
Reviewed-on: https://chromium-review.googlesource.com/c/1489903
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#653}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

Revert "Reland "Android OOP-D: Enable by default""

This feature did not launch in M72, so leaving it as disabled by default
for M73.

This reverts commit ba5be349d4f0f8b516cc256f33e284af8e3fa1a6.

Bug: 732555
Change-Id: If854fa1dc27f2ee7fbd0b922d44a50d4103e94f0
Reviewed-on: https://chromium-review.googlesource.com/c/1490054
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#652}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/viz/common/features.cc[diff]

Explicitly disable DC overlay support on all except Intel GPUs

We ran into a user machine with AMD GPU that reports NV12 overlay cap.
This is a total surprise and we never tested overlays on non-Intel GPUs.

To be safe, let's turn off overlay support on all except Intel GPUs.

BUG=932879
TEST=manual
[email protected], [email protected]
[email protected]

(cherry picked from commit d15d1acd36c01860a7b00b1cc16457ab35ed687e)

Change-Id: I4e6edd558ac09679cc911c584a100655e99c59d0
Reviewed-on: https://chromium-review.googlesource.com/c/1487474
Commit-Queue: Zhenyao Mo <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635356}
Reviewed-on: https://chromium-review.googlesource.com/c/1489974
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#651}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• gpu/config/gpu_driver_bug_list.json[diff]
• gpu/config/gpu_util.cc[diff]
• gpu/config/gpu_workaround_list.txt[diff]
• gpu/ipc/service/direct_composition_surface_win.cc[diff]

Disable latency recovery for Android Surface Sync

CC's latency recovery can lead to signficant jank in cases where
latency can't effectively be recovered. This seems to happen in both
OOP-D and non-OOP-D, but to minimize risk, disabling in OOP-D only for
now. We should re-evaluate this feature and potentially rework or
remove it.

TBRing piman so that this change can begin baking over the weekend for
potential merge. Discussed this approach with sunnyps previously.

TBR=sunnyps
TBR=piman

Bug: 933846
Change-Id: Icbce2ef784d03adb3ce233e816b5fd1361191de4
Reviewed-on: https://chromium-review.googlesource.com/c/1485231
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634981}(cherry picked from commit 1e6ffca4acf3e7430d3217789b2c560a49e701fd)
Reviewed-on: https://chromium-review.googlesource.com/c/1490192
Cr-Commit-Position: refs/branch-heads/3683@{#650}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/render_widget.cc[diff]

Avoid Duplicate Surface Destruction in GarbageCollectSurfaces

Destroying surfaces has the potential to add other surfaces to
the |surfaces_to_destroy_| set. This can cause problems when
a surface is pending destruction (already pulled out of
|surfaces_to_destroy_|) and is then re-added to the list,
leading to a double deletion.

This change makes deletion robust against this pattern, in
order to have a merge-safe fix.

A future change will make surface destruction
idempotent, so we don't need to worry about these cases.

Bug: 934674
Change-Id: Ie08505ef37d4a6e2ca48462372e3e09d3d49bc58
Reviewed-on: https://chromium-review.googlesource.com/c/1484354
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634988}(cherry picked from commit d90cc9cc1b622f8008436509ed0441ef1769b24e)
Reviewed-on: https://chromium-review.googlesource.com/c/1490191
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#649}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/viz/service/frame_sinks/surface_synchronization_unittest.cc[diff]
• components/viz/service/surfaces/surface_manager.cc[diff]

Fall back to sw video decoding for sw compositing.

VideoResourceUpdater can't currently convert hw VideoFrame resources
into sw planes in sw comspositing mode, since it isn't given a
context provider to use for the conversion.  This CL causes it to
fall back to software video decoding in that case.

Note that adding support to VideoResourceUpdater isn't terribly
difficult, but might be crashy.  The rough sketch is here:
https://chromium-review.googlesource.com/c/chromium/src/+/1483680

Bug: 932879
Change-Id: I3b05e17fce40b9095de7eb6bc5ef64645a69a11b
Reviewed-on: https://chromium-review.googlesource.com/c/1484073
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Antoine Labour <[email protected]>
Auto-Submit: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635160}(cherry picked from commit fe857a644a3099f88c8fc4011a2ab153e54b8758)
Reviewed-on: https://chromium-review.googlesource.com/c/1489892
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#648}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/render_thread_impl.cc[diff]

Audio Player WebUI: reset the slider when advancing to next track

Bug: 930224
Change-Id: I64891852721f9f4319c90954a9423734f5d9a154
Reviewed-on: https://chromium-review.googlesource.com/c/1461501
Reviewed-by: Naoki Fukino <[email protected]>
Commit-Queue: Esmael El-Moslimany <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631159}(cherry picked from commit c0b4ebe0cc86d3b2f481217dd6e613cca8d0d475)
Reviewed-on: https://chromium-review.googlesource.com/c/1489485
Reviewed-by: Esmael El-Moslimany <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#647}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/test/data/webui/cr_elements/cr_slider_test.js[diff]
• ui/file_manager/audio_player/elements/audio_player.js[diff]
• ui/webui/resources/cr_elements/cr_slider/cr_slider.js[diff]

[DevTools] Do not reroute flatten protocol message in forwarding DTAH

For forwarding agent host we should first deliver the whole message
to the real recipient, who will then reroute it to the child session
if needed. This way we can debug child targets with flatten protocol
on remote devices.

[email protected]

(cherry picked from commit 9fb093fda100d55b3d4926e114dba6d1d01793db)

Bug: 921059
Change-Id: I66963171ee109fa4718149b373b4f475103700ec
Reviewed-on: https://chromium-review.googlesource.com/c/1478393
Commit-Queue: Dmitry Gozman <[email protected]>
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633583}
Reviewed-on: https://chromium-review.googlesource.com/c/1489535
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#646}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/devtools/devtools_session.cc[diff]

Remove the URL length limit on network::mojom::ProxyConfig::pac_url.

[email protected]

(cherry picked from commit db2fea3d79d30a7d0bbf68e5e6fe86e229a377b7)

Bug: 932907
Change-Id: I452a014dad0fdc002d4cd96c8f21f7c2ce11a553
Reviewed-on: https://chromium-review.googlesource.com/c/1480551
Auto-Submit: Eric Roman <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634363}
Reviewed-on: https://chromium-review.googlesource.com/c/1489479
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#645}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• services/network/proxy_config_service_mojo_unittest.cc[diff]
• services/network/public/cpp/proxy_config_mojom_traits.cc[diff]
• services/network/public/cpp/proxy_config_mojom_traits.h[diff]
• services/network/public/mojom/proxy_config.mojom[diff]

Correctly handle 'Copy to Chrome' when Chrome is running in multitasking mode.

This CL fixes 'Copy to Chrome' in multitasking mode when
kExternalFilesLoadedInWebState flag is enabled.

URL is set to completeURL (which is file:// URL) and virtualURL is
set to externalURL (which is chrome:// URL). This is necessary because
WebState knows how to render file URLs but can not render chrome:// URL.

The code was copied from UserAcrtivityHandler, so this CL can be
cherry-picked to M73. Code duplication cleanup will be done in a follow
up CL.

[email protected]

(cherry picked from commit 998c1103ecf3e86b16451a6272562d16edad429c)

Bug: 934789
Change-Id: I490cea33171b25ff73ef713c8610a64da9d8145f
Reviewed-on: https://chromium-review.googlesource.com/c/1484631
Commit-Queue: Mark Cogan <[email protected]>
Auto-Submit: Eugene But <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635222}
Reviewed-on: https://chromium-review.googlesource.com/c/1489472
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#644}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ios/chrome/app/application_delegate/url_opener.mm[diff]
• ios/chrome/app/application_delegate/url_opener_unittest.mm[diff]
• ios/chrome/app/application_delegate/user_activity_handler.mm[diff]

[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max

{Min,Max}PreferredLogicalWidth only constrains the size by the
min/max-width if it is a fixed value. However, ChildIntrinsicLogicalWidth
needs to constrain even for percentages and others.

R=​[email protected]

Bug: 935022
Change-Id: I3f5eff5e6f8e99484185635e44e3afa426c741fb
Reviewed-on: https://chromium-review.googlesource.com/c/1484854
Commit-Queue: Christian Biesinger <[email protected]>
Auto-Submit: Christian Biesinger <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635190}(cherry picked from commit 32a115f852866c5529f5243a595ab91a0570886a)
Reviewed-on: https://chromium-review.googlesource.com/c/1489415
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#643}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/layout/layout_flexible_box.cc[diff]
• third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap-005.html[Added - diff]

[css-flexbox] Shrink-to-fit sizing needs to take margins into account

Originally added in https://crrev.com/c/1327746

Also fixes a typo in one of the tests from that patch.

R=​[email protected]

Bug: 934936
Change-Id: Ib079171549853a21d5bcdd05dabb461c4a1e492c
Reviewed-on: https://chromium-review.googlesource.com/c/1483946
Auto-Submit: Christian Biesinger <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635176}(cherry picked from commit 9e55e3db0cc4178dcf891ea7787a872bcd33fcb2)
Reviewed-on: https://chromium-review.googlesource.com/c/1489414
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#642}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/layout/layout_flexible_box.cc[diff]
• third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap-003.html[diff]
• third_party/blink/web_tests/external/wpt/css/css-flexbox/flex-wrap-004.html[Added - diff]

Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted

When a shadow root with non-empty |adoptedStyleSheets| is inserted, we
should make sure that the |active_tree_scopes_| list is updated and the
tree scope is marked dirty so that style invalidation & recalc will
work.

Bug: 934340
Change-Id: I365936e4bcc0132c938fe4e200e208abac91d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/1482437
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634624}(cherry picked from commit 05bbbfd8e98c426b946e11dfa69b0618990651b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1484875
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#641}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/css/style_engine.cc[diff]
• third_party/blink/renderer/core/css/style_engine.h[diff]
• third_party/blink/renderer/core/dom/shadow_root.cc[diff]
• third_party/blink/web_tests/external/wpt/css/cssom/CSSStyleSheet-constructable.html[diff]

Refresh Public Suffix List to the latest version.

This updates from revision
5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08)

to revision
0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21)

Bug: 928091
Change-Id: I2c0582cbd3724211fca8990ded30232351290588
Reviewed-on: https://chromium-review.googlesource.com/c/1484301
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#635219}(cherry picked from commit e194b7e09ff8d09aaffcfa89331aa97916d683a8)
Reviewed-on: https://chromium-review.googlesource.com/c/1489242
Reviewed-by: Martijn Croonen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#640}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• net/base/registry_controlled_domains/effective_tld_names.dat[diff]
• net/base/registry_controlled_domains/effective_tld_names.gperf[diff]

Incrementing VERSION to 73.0.3683.55

[email protected]

Change-Id: Id8ba97eff236d090c89b652df4a0cae29caed034
Reviewed-on: https://chromium-review.googlesource.com/c/1489136
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#639}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

Update shortcurts' centering insets after the view is properly sized.

Shortcuts need to be centered. This is achieved by insetting the cells
with a computed amount. This computation used to happen in
-viewWillAppear:, but in some cases the containing table view cell is
not yet properly sized. So postpone this insetting to -viewDidAppear:

Bug: 931210
Change-Id: Ic66a273d5337a442ccb57fda30cf0d8c370052c3
Reviewed-on: https://chromium-review.googlesource.com/c/1475751
Auto-Submit: Stepan Khapugin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633692}(cherry picked from commit 618a7a0e1a572de5b65b036d69115d11fef67136)
Reviewed-on: https://chromium-review.googlesource.com/c/1488923
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#638}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_view_controller.mm[diff]

[Merge] Fix emoji drawing coordinate in vertical text

Due to issues we have with retrieving correct font metrics on Mac OS,
due to [1, 2] when computing the vertical origin for Emoji Color Emoji
we receive an incorrect vertical origin with a 0 y-value, which leads to
an emoji glyph being placed too high.

Fallback to retrieving the slightly inflated SkFont.getBounds when
SkPath + getBounds() returns an empty rectangle, as it does for Apple
Color Emoji.

Added emoji-vertical-origin-visual.html test as part of own tests, but
in the style of a WPT test. As far as I can tell, we cannot yet run
pixel tests as part of WPT but I do not see a way to verify our
rendering as a ref test.

[1] https://bugs.chromium.org/p/skia/issues/detail?id=8779
[2] https://bugs.chromium.org/p/skia/issues/detail?id=5328

Test: fast/text/emoji-vertical-origin-visual.html
Bug: 933264
Change-Id: I3487bf832b857764fb638a3f2df5803137d3fd66
Reviewed-on: https://chromium-review.googlesource.com/c/1480463
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Dominik Röttsches <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634836}(cherry picked from commit 0cce9e79536830a404c869d39be37875b3520bfc)
Reviewed-on: https://chromium-review.googlesource.com/c/1488771
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#637}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/platform/fonts/skia/skia_text_metrics.cc[diff]
• third_party/blink/web_tests/fast/text/emoji-vertical-origin-visual.html[Added - diff]
• third_party/blink/web_tests/platform/linux/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/mac-mac10.10/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/mac-mac10.11/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/mac-mac10.12/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/mac/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/win/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]
• third_party/blink/web_tests/platform/win7/fast/text/emoji-vertical-origin-visual-expected.png[Added - diff]

Merge to M73: Revert "Remove WalkAllDescendants from AXTreeSerializer"

This reverts commit ed81626c1f9783216c831147552ccd438e7cceab.

Reason for revert: This seems to be causing more crashes
on Android and Mac in particular, see crbug.com/916936

Original change's description:
> Remove WalkAllDescendants from AXTreeSerializer
>
> It's a performance bottleneck. It was originally added here:
> https://codereview.chromium.org/1195353002 - but the test
> added then still passes without this code. I tried reverting
> some other recent patches but I can't pinpoint what made it
> start working.
>
> I think we should try landing this change and watch out for
> new crashes / regressions.
>
> Bug: 489590, 579199
>
> Change-Id: I8fbdeec0f75a22ed12dc1733ec3e1502bad8f90f
> Reviewed-on: https://chromium-review.googlesource.com/c/1383053
> Commit-Queue: Dominic Mazzoni <[email protected]>
> Reviewed-by: David Tseng <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#618268}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 489590, 579199, 916936
Change-Id: I0076757e8ffdc9a83b6a4f4ec1b80946c091c7f2
Reviewed-on: https://chromium-review.googlesource.com/c/1467821
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631375}(cherry picked from commit 104d032865853a30b2697693963ba5e71d5ce3cf)
Reviewed-on: https://chromium-review.googlesource.com/c/1488317
Cr-Commit-Position: refs/branch-heads/3683@{#636}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ui/accessibility/ax_tree_serializer.h[diff]

Reland "Don't replace <wbr> elements with ObjectReplacementCharacter"

This is a reland of 055c835ef3ea00bd265073c80963f8f7d8e13692

Original change's description:
> Don't replace <wbr> elements with ObjectReplacementCharacter
> 
> <wbr> elements indicate to the browser that a long string might be
> broken into lines, for example in long URLs. Since most of the time the
> line is not broken on the <wbr> elements, users expect to be able to
> find-in-page text that have <wbr> in between. This CL makes it so that
> when we encounter <wbr> in find-in-page, we ignore it (so we combine
> the text before and after the wbr) and not add an object replacement
> character like we previously do.
> 
> Bug: 933684
> Change-Id: I8593225016e5a0bd8f7436c64a8fe099963c90bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1482271
> Reviewed-by: Yoshifumi Inoue <[email protected]>
> Commit-Queue: Rakina Zata Amni <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#634576}(cherry picked from commit 8f69d9cfbaadee9a83fb30e674aeaa24d8c0e962)
> Reviewed-on: https://chromium-review.googlesource.com/c/1484959
> Reviewed-by: Rakina Zata Amni <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#593}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

Bug: 933684
Change-Id: I9dbe4b468fbbaf73bc5100a1873d64f8932c6d6c
Reviewed-on: https://chromium-review.googlesource.com/c/1487756
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#635}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/editing/finder/find_buffer.cc[diff]

Incrementing VERSION to 73.0.3683.54

[email protected]

Change-Id: I6920b75cf9547e9436e165eb7ab85c3b59670d38
Reviewed-on: https://chromium-review.googlesource.com/c/1488120
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#634}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

arc: Fix ARC enabled state recording on browser shutdown

ArcSessionManager state is reset before final UMA recording happens on
browser shutdown, which result in missing Arc.State and incorrectly
recorded Arc.StateByUserType.

This CL adds fields to ArcSessionManager to persist state across
Shutdown() for UMA recording purposes.

Bug: 929583
Change-Id: I5fdf58ec60f9720599fa15c997cd2a23ed524fd9
Reviewed-on: https://chromium-review.googlesource.com/c/1481180
Commit-Queue: Shao-Chuan Lee <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Auto-Submit: Shao-Chuan Lee <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634549}(cherry picked from commit 09017c49ecaf13b8d47ef3b3d7443b923cb544e7)
Reviewed-on: https://chromium-review.googlesource.com/c/1486792
Reviewed-by: Shao-Chuan Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#633}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/chromeos/arc/arc_session_manager.cc[diff]
• chrome/browser/chromeos/arc/arc_session_manager.h[diff]

Add Google Xenon CT Logs

[M73] Google Xenon2019, 2020, 2021, 2022 CT Logs have all passed their
monitoring period and are being added to the list of Qualified Logs in
Chrome.

Bug: 833350
Change-Id: I1215184564eb08a573f7091d26b7f532d93ddba5
Reviewed-on: https://chromium-review.googlesource.com/c/1485017
Commit-Queue: Devon O'Brien <[email protected]>
Commit-Queue: Nick Harper <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634940}(cherry picked from commit 6dbb4b3e420a7225226bc290d712f99e32ab09fd)
Reviewed-on: https://chromium-review.googlesource.com/c/1487959
Reviewed-by: Andrew Whalley <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#632}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/certificate_transparency/data/log_list.json[diff]

[Merge to M73] Fix gn bootstrap build with --use-custom-libcxx

> The gn binary gets copied up one directory when bootstrapping.  It was failing
> to run since it couldn't find libc++.so which wasn't copied.  This CL copies
> libc++.so too and renames it to libc++.gn.so to not conflict with Chromium's
> libc++.so.
>
> Also rename README.md to README.chromium.md to not conflict with gn's README.md.
>
> BUG=807400
> R=thakis
>
> Change-Id: Idce60c7df7e8aaf134357f39347ee4dafe2a851e
> Reviewed-on: https://chromium-review.googlesource.com/c/1474847
> Auto-Submit: Thomas Anderson <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#632494}

BUG=807400
TBR=thakis
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I6518b00845f34c795effa3cf1165912e7431953c
Reviewed-on: https://chromium-review.googlesource.com/c/1488114
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#631}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• tools/gn/README.chromium.md[Renamed from tools/gn/README.md - diff]
• tools/gn/bootstrap/bootstrap.py[diff]
• tools/gn/bootstrap/libc++.ninja[diff]

Retire Symantec CT Logs

[M73] The Symantec Log, Symantec 'Sirius' Log, and Symantec 'Vega' Log are
being retired with an effective date of February 16, 2019 with a
timestamp of 1550275200.

Bug: 928879
Change-Id: I8f9a3da420acdda7739662481fe505bc7c46bf3e
Reviewed-on: https://chromium-review.googlesource.com/c/1481606
Reviewed-by: Andrew Whalley <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Commit-Queue: Andrew Whalley <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634675}(cherry picked from commit 8c69cffa96b4c8e488ca2da3ee7c728d608178d3)
Reviewed-on: https://chromium-review.googlesource.com/c/1488052
Cr-Commit-Position: refs/branch-heads/3683@{#630}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/certificate_transparency/data/log_list.json[diff]

[Merge to M73] Fix gn build on 'Build From Tarball' bot

> This is necessary to green-up the 'Build From Tarball' bot.  The bot is running
> Trusty, which has a system libstdc++ that's too old to support many of the
> features in base that gn relies on.
>
> Here's the story of why this is now necessary:
>
> 1. Chromium's gn was originally built with libc++ to get around this exact
>    issue.
> 2. gn was moved into a standalone repo.
> 3. The libc++ sources weren't copied into standalone gn, so their solution to
>    fix this issue was to pull Chromium's debian sysroot that has newer libstdc++
>    headers.
> 4. For whatever reason, the option to build with the sysroot was removed from
>    the public repository and now the bots have a step to pull the sysroot.
>
> This can be removed once Ubuntu Trusty reaches EOL, or when Chromium's
> infrastructure is upgraded from Trusty to Xenial, whichever comes second
> ideally.
>
> BUG=807400
> R=thakis
>
> Change-Id: I00901b3df4005f6ac098774822fffe12dd67e561
> Reviewed-on: https://chromium-review.googlesource.com/c/1460187
> Auto-Submit: Thomas Anderson <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#630291}

BUG=807400
TBR=thakis
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I68ab6a203f6fa706d88d7033c5df4bddafa283d4
Reviewed-on: https://chromium-review.googlesource.com/c/1488131
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#629}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• tools/gn/bootstrap/bootstrap.py[diff]
• tools/gn/bootstrap/libc++.ninja[Added - diff]

Fix ThumbnailProviderImpl destroy chain.

Add safety checks to the following classes to make sure they work better
during destroy:
- ThumbnailProviderImpl - Cancel all requests after destroy and do not
use any results given.
- BitmapCache - Do not add bitmaps to the cache after destroy (real
exception).
- ThumbnailDiskStorage - Do not take requests after destroy and do not
return results after destroy.

Bug: 934515
Change-Id: Id2bbac832fd4b9c81ae81ee806f66494eda59e16
Reviewed-on: https://chromium-review.googlesource.com/c/1482590
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634956}(cherry picked from commit b57f41d7655b73abcd7a375a4f4988521d55509a)
Reviewed-on: https://chromium-review.googlesource.com/c/1487957
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#628}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/android/java/src/org/chromium/chrome/browser/BitmapCache.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorage.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProviderImpl.java[diff]

Updating XTBs based on .GRDs from branch 3683

[email protected]

Change-Id: I56c0fb936aa8ac156f0b31a0e2ad287838295eeb
Reviewed-on: https://chromium-review.googlesource.com/c/1487795
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#627}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ash/strings/ash_strings_fa.xtb[diff]
• ash/strings/ash_strings_te.xtb[diff]
• ash/strings/ash_strings_th.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_ar.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_cs.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_de.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_et.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_hi.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_hr.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_it.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_iw.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_ja.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_ml.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_mr.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_ru.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_sk.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_te.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_vi.xtb[diff]
• chrome/app/resources/chromium_strings_te.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_cs.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_hi.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_kn.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/app/resources/generated_resources_th.xtb[diff]
• chrome/app/resources/google_chrome_strings_te.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_te.xtb[diff]
• components/policy/resources/policy_templates_bn.xtb[diff]
• components/policy/resources/policy_templates_ca.xtb[diff]
• components/policy/resources/policy_templates_de.xtb[diff]
• components/policy/resources/policy_templates_et.xtb[diff]
• components/policy/resources/policy_templates_fr.xtb[diff]
• components/policy/resources/policy_templates_hi.xtb[diff]
• components/policy/resources/policy_templates_iw.xtb[diff]
• components/policy/resources/policy_templates_kn.xtb[diff]
• components/policy/resources/policy_templates_mr.xtb[diff]
• components/policy/resources/policy_templates_pt-BR.xtb[diff]
• components/policy/resources/policy_templates_ta.xtb[diff]
• components/policy/resources/policy_templates_te.xtb[diff]
• components/policy/resources/policy_templates_th.xtb[diff]
• components/policy/resources/policy_templates_uk.xtb[diff]
• components/policy/resources/policy_templates_vi.xtb[diff]
• components/policy/resources/policy_templates_zh-CN.xtb[diff]
• components/strings/components_chromium_strings_te.xtb[diff]
• components/strings/components_google_chrome_strings_te.xtb[diff]
• components/strings/components_strings_ca.xtb[diff]
• components/strings/components_strings_pt-BR.xtb[diff]
• components/strings/components_strings_te.xtb[diff]
• ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_te.xtb[diff]
• remoting/resources/remoting_strings_te.xtb[diff]
• ui/strings/translations/ui_strings_ja.xtb[diff]

Allow toolbar texture capture while in tab switcher

Allow toolbar textures to be captured while in the tab switcher. Now
that the top toolbar does not contain any tab switcher views, we should
be able to safely capture textures while in the tab switcher. Allowing
textures to be captured helps ensure the texture is correct while
exiting the tab switcher.

This fixes:
 - toolbar shadow incorrectly shown when selecting NTP from tab switcher
 - incorrect texture after sequence of steps + scrolling NTP
 - incorrect texture after rotating device while in tab switcher

BUG=933726,925772,933266

Change-Id: I1845840980dd5495715d51d8362c65d6575087a7
Reviewed-on: https://chromium-review.googlesource.com/c/1480550
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634205}(cherry picked from commit 90f8b16ec54dc5165c23bfe12eb60c4bda893d5d)
Reviewed-on: https://chromium-review.googlesource.com/c/1487846
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#626}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java[diff]

HTTPS Previews (NavThrottle): Early return if navigation is a subframe

Bug: 934289
Change-Id: I8d6bf756ac11ba8b1849a8559a79262c285d33d2
Reviewed-on: https://chromium-review.googlesource.com/c/1481534
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634272}(cherry picked from commit e63cac9a818ec6551ebd63dfbe4affefd51f7e12)
Reviewed-on: https://chromium-review.googlesource.com/c/1487874
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#625}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/previews/previews_lite_page_browsertest.cc[diff]
• chrome/browser/previews/previews_lite_page_decider.cc[diff]

Add HTTPS Previews Pingback Observer to Init List

Bug: 934865
Change-Id: I92ebfc18b621b66aff1ab1d32ccb2bb7f44212c5
Reviewed-on: https://chromium-review.googlesource.com/c/1482945
Commit-Queue: Robert Ogden <[email protected]>
Commit-Queue: Ryan Sturm <[email protected]>
Auto-Submit: Robert Ogden <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634722}
Reviewed-on: https://chromium-review.googlesource.com/c/1487840
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#624}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/page_load_metrics/observers/previews_lite_page_redirect_metrics_observer.cc[diff]
• chrome/browser/page_load_metrics/page_load_metrics_initialize.cc[diff]

HTTPS Previews: Fix crash in PostNewNavigation

Bug: 933665
Change-Id: I99b895de5345808b3d5ca3fcf2f78fe39bf0177a
Reviewed-on: https://chromium-review.googlesource.com/c/1478933
Auto-Submit: Robert Ogden <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633734}(cherry picked from commit 62ecaddd6bc2546e88ec7f63eed639760cde3b54)
Reviewed-on: https://chromium-review.googlesource.com/c/1487838
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#623}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/previews/previews_lite_page_navigation_throttle.cc[diff]

Fixed a crash in AutoResumptionHandler

Bug: 931135
Change-Id: I0358a80dfd25ef009a93703663f6170160586e51
Reviewed-on: https://chromium-review.googlesource.com/c/1483359
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634887}(cherry picked from commit f66ab2619bc9d063d2a11ac50d8b153b73f00491)
Reviewed-on: https://chromium-review.googlesource.com/c/1487523
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#622}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/android/download/download_controller.cc[diff]
• components/download/public/common/auto_resumption_handler.h[diff]

[M73] Remove Observer on the DownloadItem when download finishes or gets canceled

See https://bugs.chromium.org/p/chromium/issues/detail?id=934786#c3 for
detailed analysis

R=nparker
[email protected]

(cherry picked from commit 9ae8c4566b6f1ac89021568f986787446c7660da)

Bug: 934786,907280
Change-Id: Ib53720fc1ea0d10ba7efbfe3b1192097448f694f
Reviewed-on: https://chromium-review.googlesource.com/c/1483930
Commit-Queue: Varun Khaneja <[email protected]>
Auto-Submit: Varun Khaneja <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634816}
Reviewed-on: https://chromium-review.googlesource.com/c/1487524
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#621}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc[diff]

Adding a 5 minute rule when users reload a preview

This rule will prevent Previews from being shown for 5 minutes after a
page is reloaded that was a Preview. This is behind a finch feature to
launch as an experiment.

(cherry picked from commit 31555f2d53337ffa9e2a282927eb895ef0861ee0)

Bug: 933566
Change-Id: Ied3be1779991023ef8a0ca469c0bb97d0c30f3f7
Reviewed-on: https://chromium-review.googlesource.com/c/1481804
Commit-Queue: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634529}
Reviewed-on: https://chromium-review.googlesource.com/c/1487796
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#620}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/previews/previews_ui_tab_helper.cc[diff]
• chrome/browser/previews/previews_ui_tab_helper.h[diff]
• components/previews/content/previews_decider_impl.cc[diff]
• components/previews/content/previews_decider_impl.h[diff]
• components/previews/content/previews_decider_impl_unittest.cc[diff]
• components/previews/core/previews_features.cc[diff]
• components/previews/core/previews_features.h[diff]
• tools/metrics/histograms/enums.xml[diff]

[Duet] Remove the delete all tabs button

Remove delete all tabs button by setting it to invisible.

Bug: 927106

Change-Id: I5854feb57f05d8f9a61685890088653052a2979d
Reviewed-on: https://chromium-review.googlesource.com/c/1469281
Commit-Queue: Pedro Amaral <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632452}(cherry picked from commit f3a09c20608d9e5277dd3dd61857f60d659d0ad9)
Reviewed-on: https://chromium-review.googlesource.com/c/1487834
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#619}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/TabSwitcherBottomToolbarCoordinator.java[diff]

Cancel JS url navigation when document.open() is called

Step 7 of https://html.spec.whatwg.org/#opening-the-input-stream
says "If document has a browsing context and there is an existing
attempt to navigate document's browsing context, then stop
document loading given document."

We current miss this step if the navigation is to a javascript url.

Bug: 638435
Change-Id: I632038e82234df65be349f27c350ac7e790608d5
Reviewed-on: https://chromium-review.googlesource.com/c/1437701
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627133}(cherry picked from commit 4b6c1ccdd1ec5df078905f511913a42f0b3bc5b0)
Reviewed-on: https://chromium-review.googlesource.com/c/1487705
Cr-Commit-Position: refs/branch-heads/3683@{#618}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/dom/document.cc[diff]
• third_party/blink/web_tests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document-open-cancels-javascript-url-navigation.html[Added - diff]

Fix DRP not retrying requests because of net errors

This CL plumbs OnComplete to DRP url loader throttle to act on the net errors.

Bug: 934293
Change-Id: I31bf231c80ab96e712f5a3e0a50314ec22cbb1d6
Reviewed-on: https://chromium-review.googlesource.com/c/1483735
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634897}(cherry picked from commit ba99441fab5cd1d963165234e97ac96263bff8e5)
Reviewed-on: https://chromium-review.googlesource.com/c/1487188
Reviewed-by: Daniel Xie <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#617}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/data_reduction_proxy/data_reduction_proxy_browsertest.cc[diff]
• components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.cc[diff]
• components/data_reduction_proxy/content/common/data_reduction_proxy_url_loader_throttle.h[diff]
• content/common/throttling_url_loader.cc[diff]
• content/common/throttling_url_loader.h[diff]
• content/public/common/url_loader_throttle.cc[diff]
• content/public/common/url_loader_throttle.h[diff]
• services/network/public/cpp/network_ipc_param_traits.h[diff]
• services/network/public/cpp/url_loader_completion_status.cc[diff]
• services/network/public/cpp/url_loader_completion_status.h[diff]
• services/network/url_loader.cc[diff]

Distinguish D-Bus timeouts when configuring printing via debugd.

Previously, if we failed to communicate with debugd, we gave ourselves a
single opaque error value. To better gain insight into these communication
errors, we add extra handling to the D-Bus callbacks to record specific
timeouts or non-responses.

R=​[email protected], [email protected], [email protected]

Bug: 929772
Change-Id: Ic56fff645c2fbc078559b4dc37b33f589415ef87
Reviewed-on: https://chromium-review.googlesource.com/c/1473823
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Kalvin Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634016}(cherry picked from commit b8067f28349b445f43f17a542a4554f2e06e357c)
Reviewed-on: https://chromium-review.googlesource.com/c/1483678
Cr-Commit-Position: refs/branch-heads/3683@{#616}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/chromeos/printing/printer_configurer.cc[diff]
• chrome/browser/chromeos/printing/printer_configurer.h[diff]
• chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js[diff]
• chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc[diff]
• chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc[diff]
• chromeos/dbus/debug_daemon_client.cc[diff]
• chromeos/dbus/debug_daemon_client.h[diff]
• tools/metrics/histograms/enums.xml[diff]

Reland "Fix deadlock due to child throttling"

Due to another optimization that I landed at the same time as the
original CL, one of the unit tests became invalid. This CL slightly
tunes the LocalSurfaceIds used in the original unittests.

A child should not be throttled if the parent is blocked on it.
Otherwise the parent is guaranteed to hit the deadline, causing jank.

[email protected]

Bug: 933610
Change-Id: Iff450c568a904d14c9f00fad24f5748a08c6a505
Reviewed-on: https://chromium-review.googlesource.com/c/1482949
Commit-Queue: Saman Sami <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634808}(cherry picked from commit 33f48e23588adee35dbdc8a71aa090a5842cb519)
Reviewed-on: https://chromium-review.googlesource.com/c/1487711
Cr-Commit-Position: refs/branch-heads/3683@{#615}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/viz/service/frame_sinks/surface_synchronization_unittest.cc[diff]
• components/viz/service/surfaces/surface.cc[diff]
• components/viz/service/surfaces/surface.h[diff]
• components/viz/service/surfaces/surface_dependency_tracker.cc[diff]
• components/viz/service/surfaces/surface_dependency_tracker.h[diff]

[Android] Restrict ptrace() operations to just the read ones needed by Crashpad.

This adds a new RestrictPtrace() syscall_parameter_restrictions helper, which
is then used by the Android baseline Seccomp policy. Desktop Linux and ChromeOS
do not permit ptrace in their Seccomp filters.

(cherry picked from commit 508a907c86936e23e978960bf235338943388bf0)

Bug: 933418
Change-Id: Iceaf2c5c0f3f09f3fa4823de2bf01dd13a64cf43
Reviewed-on: https://chromium-review.googlesource.com/c/1479092
Reviewed-by: Jorge Lucangeli Obes <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633894}
Reviewed-on: https://chromium-review.googlesource.com/c/1487519
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#614}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• sandbox/linux/seccomp-bpf-helpers/baseline_policy_android.cc[diff]
• sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc[diff]
• sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h[diff]
• sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc[diff]
• sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h[diff]
• sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc[diff]

[Merge to 73] [omnibox] Add flag, OmniboxUIExperimentUnboldSuggestionText

This CL adds a feature flag to experiment with unbolding
suggestion text in the omnibox.

[email protected]

(cherry picked from commit 9453dc9fd03ea3a86d5255e7da82bbcbcd018322)

Bug: 931836
Change-Id: I7ef5ced1a1e86f46e37e1695c7b3d20558e58b3c
Reviewed-on: https://chromium-review.googlesource.com/c/1475746
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632742}
Reviewed-on: https://chromium-review.googlesource.com/c/1487185
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#613}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/views/omnibox/omnibox_text_view.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

Incrementing VERSION to 73.0.3683.53

[email protected]

Change-Id: I24aaf8527750716b33eb63740e6975f748978a81
Reviewed-on: https://chromium-review.googlesource.com/c/1487518
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#612}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

[Merge to 73] [omnibox] Add a flag for changing display color of navigation suggestions.

This CL adds two chrome://flags flags for crrev.com/c/1475065.

[email protected]

(cherry picked from commit 4451d03fa88a9f49c7aeec05de24634f36cad839)

Bug: 931836
Change-Id: I513f988e36c853383c41f48b1ed0841a5ca10b60
Reviewed-on: https://chromium-review.googlesource.com/c/1481904
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634712}
Reviewed-on: https://chromium-review.googlesource.com/c/1487210
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#611}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/about_flags.cc[diff]
• chrome/browser/flag-metadata.json[diff]
• chrome/browser/flag_descriptions.cc[diff]
• chrome/browser/flag_descriptions.h[diff]
• tools/metrics/histograms/enums.xml[diff]

[Merge to 73] Omnibox: Improve implementation of blue loop blue query experiment.

Now this experiment is implemented in OmniboxTextView, which is more
of a "leaf node" code-wise.

Previously, the implementation of this was in AutocompleteProvider,
which is quite upstream, and may have unintended consequences.

Bug: 931836
Change-Id: I116d588b3e5a27d670c80e0120076b9b7b86af03
Reviewed-on: https://chromium-review.googlesource.com/c/1479300
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634250}(cherry picked from commit 9e5850932eb9d03ec0e95e5a7da9358bfb0d6be3)
Reviewed-on: https://chromium-review.googlesource.com/c/1487181
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#610}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/views/omnibox/omnibox_result_view.cc[diff]
• components/omnibox/browser/autocomplete_provider.cc[diff]

[Merge to 73] [omnibox] Add a flag for showing a blue search loop and search text.

This CL adds a chrome://flags flag for crrev.com/c/1474090.

[email protected]

(cherry picked from commit 3c0e70a0ad55077b66d3fea4dc4b82c00baa9633)

Bug: 931836
Change-Id: I1b37a28f6353c2452552116fe680fde2ca98ea48
Reviewed-on: https://chromium-review.googlesource.com/c/1478116
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634216}
Reviewed-on: https://chromium-review.googlesource.com/c/1487517
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#609}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/about_flags.cc[diff]
• chrome/browser/flag-metadata.json[diff]
• chrome/browser/flag_descriptions.cc[diff]
• chrome/browser/flag_descriptions.h[diff]
• tools/metrics/histograms/enums.xml[diff]

[Merge to 73] Omnibox: Experiment with bolding the user text in search suggestions

Currently, the "additional text" of search suggestions is bolded
instead of the "user text". This experiment swaps that to be more
consistent with navigational suggestions.

For example, with this experiment enabled, when the user types
"point reyes", and gets "point reyes weather" as a suggestion, the
"point reyes" part will be bolded instead of the "weather part".

[email protected]

(cherry picked from commit 39bded7f2212e91aaa691391961116b8be96e449)

Bug: 931836
Change-Id: I861f2d3edd5907680435b0991f105e68efb13968
Reviewed-on: https://chromium-review.googlesource.com/c/1478030
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633500}
Reviewed-on: https://chromium-review.googlesource.com/c/1487366
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#608}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/omnibox/browser/autocomplete_provider.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

[Merge to 73] Omnibox: Experiment with blue navigation titles and gray URLs

This experiment turns the titles of navigation suggestions blue and
navgiation URLs gray.

More technically, it sets navigation titles to have the same color as
URLs (conventionally blue), and sets URLs to have the same color as
dimmed text (conventionally gray).

There's also a second flag in this that turns both blue.

Bug: 931836
Change-Id: I6a3b41dfae243b9476c5cc0480c2a3d908f52d05
Reviewed-on: https://chromium-review.googlesource.com/c/1475065
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633344}(cherry picked from commit 8dbda97f9dd62183d2701fd80bfd81a5542e2ce7)
Reviewed-on: https://chromium-review.googlesource.com/c/1487364
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#607}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/views/omnibox/omnibox_result_view.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

[Merge to 73] [omnibox] Add a flag for showing a suffix on all search suggestions.

This CL adds a chrome://flags flag for crrev.com/c/1471003.

[email protected]

(cherry picked from commit 4f56e9fc672692d5dd7c0f857e4606726006a1a0)

Bug: 931836
Change-Id: Ie5f1009f889201c9fa7ed66cc81266875d00a591
Reviewed-on: https://chromium-review.googlesource.com/c/1475897
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633309}
Reviewed-on: https://chromium-review.googlesource.com/c/1487205
Cr-Commit-Position: refs/branch-heads/3683@{#606}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/about_flags.cc[diff]
• chrome/browser/flag-metadata.json[diff]
• chrome/browser/flag_descriptions.cc[diff]
• chrome/browser/flag_descriptions.h[diff]
• tools/metrics/histograms/enums.xml[diff]

[Merge to 73] [omnibox] Add a flag for showing a generic icon for search suggestions.

This CL adds a chrome://flags flag for crrev.com/c/1471247.

[email protected]

(cherry picked from commit 12527c8054c7682800cb80bc836fdd29d82dabd7)

Bug: 931836
Change-Id: I8ff931461f95e41ed7d31c30b681e1fd334899f4
Reviewed-on: https://chromium-review.googlesource.com/c/1476067
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633280}
Reviewed-on: https://chromium-review.googlesource.com/c/1487362
Cr-Commit-Position: refs/branch-heads/3683@{#605}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/about_flags.cc[diff]
• chrome/browser/flag-metadata.json[diff]
• chrome/browser/flag_descriptions.cc[diff]
• chrome/browser/flag_descriptions.h[diff]
• tools/metrics/histograms/enums.xml[diff]

[Merge to 73] Omnibox: Experiment with showing a blue search loop and search text

This experiment changes the generic vector icon for search to the same
color as RESULTS_TEXT_URL (generally blue).

It also changes the search terms presented in omnibox suggestions to
that color.

[email protected]

(cherry picked from commit 3ab063854fabbe71bdb963f6d1708167bcadf573)

Bug: 931836
Change-Id: I7e42c901a984e8762e9c969a219be91008dae7e0
Reviewed-on: https://chromium-review.googlesource.com/c/1474090
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632765}
Reviewed-on: https://chromium-review.googlesource.com/c/1487176
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#604}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/views/location_bar/location_bar_view.cc[diff]
• chrome/browser/ui/views/omnibox/omnibox_result_view.cc[diff]
• components/omnibox/browser/autocomplete_provider.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]
• components/omnibox/browser/omnibox_view.cc[diff]
• components/omnibox/browser/omnibox_view.h[diff]
• components/omnibox/browser/omnibox_view_unittest.cc[diff]

Omnibox: Experiment with a white background for the unfocused omnibox

Sets the unfocused omnibox background to the same color as the results
popup, which is conventionally white.

Also enables the location bar border stroke in this mode, which already
exists for high contrast mode.

Bug: 931836
Change-Id: I97e0a5c768c739f4f037d9e3abdb99115b14999d
Reviewed-on: https://chromium-review.googlesource.com/c/1474281
Reviewed-by: Kevin Bailey <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Auto-Submit: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632737}(cherry picked from commit a04e459e1cc1c2eec4f9052ebd5cfa8bca1856ec)
Reviewed-on: https://chromium-review.googlesource.com/c/1487471
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#603}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/views/location_bar/location_bar_view.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

Omnibox: Experiment with showing a generic icon for search suggestions

Instead of showing the Search Provider favicon in the omnibox, this
experiment shows a generic magnifying glass icon.

This also applies to the NTP, as the omnibox in the NTP has always had
the same icon as the omnibox showing a search suggestion.

Doing something different would require a more extensive change.

Bug: 931836
Change-Id: Ia16422b8e4c710b6d664d10c20a322b1083dd57a
Reviewed-on: https://chromium-review.googlesource.com/c/1471247
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632009}(cherry picked from commit 88cc4cb31eda4b1907bc735e4e415790b36ee0ed)
Reviewed-on: https://chromium-review.googlesource.com/c/1487202
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#602}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/omnibox/chrome_omnibox_client.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

Omnibox: Experiment with showing a suffix on all search suggestions

This adds a new feature flag called:
OmniboxUIExperimentShowSuffixOnAllSearchSuggestions

It shows a descriptive suffix like " - Google Search" or
" - Bing Search" on all search suggestions instead of just the first
one per cluster.

Bug: 931836
Change-Id: I58d3a7650c30c47d234f106e2b4f4c785220c25f
Reviewed-on: https://chromium-review.googlesource.com/c/1471003
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631894}(cherry picked from commit 4170da44891c86e50c7a32b9c8c9487fd34d2d44)
Reviewed-on: https://chromium-review.googlesource.com/c/1487198
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#601}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/omnibox/browser/autocomplete_controller.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

[ios] Check for non nil webState, not tab, for NewTabPageTabHelper.

Bug: 934294
Change-Id: I34eac982df5e4ce23a7e748debe9b118cd88afb4
Reviewed-on: https://chromium-review.googlesource.com/c/1481491
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634365}(cherry picked from commit 37f47c073277a4316b08498dab7685725e37ffb0)
Reviewed-on: https://chromium-review.googlesource.com/c/1486878
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#600}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]
• ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm[diff]

Search for persistent staging locations first.

BUG=914393

Change-Id: Ieda541820b186832423126516d878c836de2ffc6
Reviewed-on: https://chromium-review.googlesource.com/c/1475886
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632854}(cherry picked from commit 4a3246682168b0342bc293f327a663182e79ee4c)
Reviewed-on: https://chromium-review.googlesource.com/c/1486716
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#599}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/chrome_browser_main_mac.mm[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

MacPWAs: Fix race in NSRunningApplication isTerminated watching

It is possible for the NSRunningApplication to terminate before our
KVO is created. Handle this by adding NSKeyValueObservingOptionInitial
to the addObserver call.

With that change, termination can be observed within the addObserver
call. To avoid calling removeObserve from within addObserver (which
is not legal), post a task to call onTerminated, which will make the
callback, remove the observer, and release the object.

[email protected]

(cherry picked from commit 5d69a88ad359f3601c09cabd3b14f78cbf5220cb)

Bug: 929034
Change-Id: I9abba42c5b54ae31a98e6872d224b76aa1e56314
Reviewed-on: https://chromium-review.googlesource.com/c/1456347
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632483}
Reviewed-on: https://chromium-review.googlesource.com/c/1486680
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#598}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/web_applications/components/web_app_shortcut_mac.mm[diff]

Add null check for webcontents in MediaSessionImpl

This CL adds a null check to prevent a crash occurring in
MediaSessionImplParamBrowserTest.

[email protected]

(cherry picked from commit aaf7aa4e5b993a7b489ee81406cc5afde7701b2d)

Bug: 933742
Change-Id: Ia2d6eaf9a8a8c7ce1e165ad56d09ec3d6830730c
Reviewed-on: https://chromium-review.googlesource.com/c/1481081
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634708}
Reviewed-on: https://chromium-review.googlesource.com/c/1486677
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#597}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/media/session/media_session_impl.cc[diff]

Revert "Don't replace <wbr> elements with ObjectReplacementCharacter"

This reverts commit 055c835ef3ea00bd265073c80963f8f7d8e13692.

Reason for revert: Broke build due to dependency to non-merged commit

Original change's description:
> Don't replace <wbr> elements with ObjectReplacementCharacter
> 
> <wbr> elements indicate to the browser that a long string might be
> broken into lines, for example in long URLs. Since most of the time the
> line is not broken on the <wbr> elements, users expect to be able to
> find-in-page text that have <wbr> in between. This CL makes it so that
> when we encounter <wbr> in find-in-page, we ignore it (so we combine
> the text before and after the wbr) and not add an object replacement
> character like we previously do.
> 
> Bug: 933684
> Change-Id: I8593225016e5a0bd8f7436c64a8fe099963c90bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1482271
> Reviewed-by: Yoshifumi Inoue <[email protected]>
> Commit-Queue: Rakina Zata Amni <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#634576}(cherry picked from commit 8f69d9cfbaadee9a83fb30e674aeaa24d8c0e962)
> Reviewed-on: https://chromium-review.googlesource.com/c/1484959
> Reviewed-by: Rakina Zata Amni <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#593}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 933684
Change-Id: Idcbd3dac3aac932b21b9ca1d7e67c67afd7ddb66
Reviewed-on: https://chromium-review.googlesource.com/c/1486392
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#596}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/editing/finder/find_buffer.cc[diff]
• third_party/blink/renderer/core/editing/finder/find_buffer_test.cc[diff]

Incrementing VERSION to 73.0.3683.52

[email protected]

Change-Id: Ief1fd398537686f336429d21f7314627e2e43b86
Reviewed-on: https://chromium-review.googlesource.com/c/1485066
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#595}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

Resume recording Touch Bar text suggestions use.

I accidentally deleted it in r603741.

Bug: 717553
Change-Id: I65b9b9680d1f0a93850593445aa09d7e76d5af0d
Reviewed-on: https://chromium-review.googlesource.com/c/1448732
Auto-Submit: Sidney San Martín <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628058}(cherry picked from commit 4bfcb213b3ab550ed8cbf6a3d84328b87c157067)
Reviewed-on: https://chromium-review.googlesource.com/c/1485062
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#594}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/renderer_host/render_widget_host_view_cocoa.mm[diff]

Don't replace <wbr> elements with ObjectReplacementCharacter

<wbr> elements indicate to the browser that a long string might be
broken into lines, for example in long URLs. Since most of the time the
line is not broken on the <wbr> elements, users expect to be able to
find-in-page text that have <wbr> in between. This CL makes it so that
when we encounter <wbr> in find-in-page, we ignore it (so we combine
the text before and after the wbr) and not add an object replacement
character like we previously do.

Bug: 933684
Change-Id: I8593225016e5a0bd8f7436c64a8fe099963c90bb
Reviewed-on: https://chromium-review.googlesource.com/c/1482271
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634576}(cherry picked from commit 8f69d9cfbaadee9a83fb30e674aeaa24d8c0e962)
Reviewed-on: https://chromium-review.googlesource.com/c/1484959
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#593}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/editing/finder/find_buffer.cc[diff]
• third_party/blink/renderer/core/editing/finder/find_buffer_test.cc[diff]

Incrementing VERSION to 73.0.3683.51

[email protected]

Change-Id: Ibfe68b71610ae2115bea3b2de3d4c7148aca5942
Reviewed-on: https://chromium-review.googlesource.com/c/1485058
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#592}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

Disable Shape Detection Origin Trial

This reverts commit 935af3276e04fad6843fd4c35be113043c50ad41.

Bug: 646035
Change-Id: I32c86100fe0264153bfb38433fd65d25205368bc
Reviewed-on: https://chromium-review.googlesource.com/c/1476981
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633463}(cherry picked from commit 08a22e103c72ab419948b2eb6657bce43db98764)
Reviewed-on: https://chromium-review.googlesource.com/c/1484874
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#591}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/modules/shapedetection/barcode_detector.idl[diff]
• third_party/blink/renderer/modules/shapedetection/detected_barcode.idl[diff]
• third_party/blink/renderer/modules/shapedetection/detected_face.idl[diff]
• third_party/blink/renderer/modules/shapedetection/detected_text.idl[diff]
• third_party/blink/renderer/modules/shapedetection/face_detector.idl[diff]
• third_party/blink/renderer/modules/shapedetection/text_detector.idl[diff]
• third_party/blink/renderer/platform/runtime_enabled_features.json5[diff]

M73: Allow framesets to print again.

Framesets currently cannot be printed. This is because
blink::WebLocalFrameImpl::PrintBegin() has a DCHECK to prevent framesets
from being printed. As a result, the printing code changed to avoid
hitting this DCHECK. This lead to regressions in the real world, where
users can and may want to print framesets.

Since Chromium has been printing framesets for years in release builds
without too many complains, reverse this decision and do a partial
revert of r621062 and r621325. Also remove the DCHECK so printing and
Blink code stay aligned.

BUG=890056,920163,931784
[email protected]

Change-Id: I81e955603bfd7cb3e13abb306ee251ba0693fa3e
Reviewed-on: https://chromium-review.googlesource.com/c/1480431
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634045}(cherry picked from commit 0e5e2e77a02ec2ff425532f319e3f376e32ad8f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1484974
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#590}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/printing/renderer/print_render_frame_helper.cc[diff]
• third_party/blink/renderer/core/frame/web_local_frame_impl.cc[diff]

Incrementing VERSION to 73.0.3683.50

[email protected]

Change-Id: I0934348169b96900eaf8bf612b14ae75ef2e5bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1484826
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#589}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

[Merge M73][Extensions Bindings] Fix an issue with messaging + UserActivationV1

User gestures in extension API calls are curried in two ways:
- If there is a user gesture active during the initial API call, we
  will synthesize a user gesture during the callback
- If there is a user gesture active during an initial sent message,
  we will synthesize a user gesture when that message is received

With native bindings, we can end up hitting both of these code paths,
since one-time messages (like runtime.sendMessage) go through the
APIRequestHandler, which is responsible for keeping track of user
gestures in API calls' callbacks. However, synthesizing two user
gestures results in consuming the user gesture (for some reason that
isn't entirely clear, but likely has to do with how we reset the token
when a scoped user gesture is collected).

This creates a very interesting broken case for websites and content
scripts in the following scenario:
- User gesture triggers extension behavior
- Extension sends a message
- Extension receives a response
  * We create multiple scoped user gestures with native bindings, by
    the scenario described above.
- Web page tries to use user gesture

By the time the web page tries to use the user gesture, it has been
consumed, and the call will fail. In practice, this is not as rare as it
would seem to be - it can be triggered if an extension content script
listens to the 'mousedown' event and a page has a 'click' event handler,
since the response can be received prior to the mouseup triggering the
click event.

This is only an issue with UserActivationV1, since UserActivationV2
tracks gestures differently.

Fix this by having messaging APIs only create a single scoped user
gesture, rather than two. Also add regression tests for both the case of
an extension message and the case of an API call returning (which did
not trigger this behavior, but seemed like it could if flows changed).

Bug: 921141

[email protected]

(cherry picked from commit e80e6fc1e2f57077f1db8e34bb295978b9f72a9b)

Change-Id: I74817d8a341703b6ebed37e8dcf7506fdf56bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/1441494
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628965}
Reviewed-on: https://chromium-review.googlesource.com/c/1484822
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#588}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/extensions/extension_bindings_apitest.cc[diff]
• chrome/test/data/extensions/api_test/bindings/user_gesture_test.html[Added - diff]
• chrome/test/data/extensions/api_test/bindings/user_gesture_test.js[Added - diff]
• extensions/renderer/bindings/api_request_handler.cc[diff]
• extensions/renderer/bindings/api_request_handler.h[diff]

[M73 Merge]Fix Assistant ready screen style

Bug: 925166
Test: Manual test
Change-Id: I4e3a24023e711ed8888d8c0a9e8e6734424db8ef
Reviewed-on: https://chromium-review.googlesource.com/c/1439459
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626957}(cherry picked from commit 03e1fc57a69ebcfebc9424f9f267b12161a0e3c5)
Reviewed-on: https://chromium-review.googlesource.com/c/1484352
Reviewed-by: Yue Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#587}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/resources/chromeos/assistant_optin/setting_zippy.css[diff]

Revert "Accommodate hostname candidates in adddress family counting in RTCPeerConnectionHandler."

This reverts commit 856d82273201d6d259d1717c70f503a7cbfcf5c1.

Reason for revert: Break builds. The dependent CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1429969) is
not in this branch.

Bug: 935016

Original change's description:
> Accommodate hostname candidates in adddress family counting in RTCPeerConnectionHandler.
>
> Currently RTCPeerConnectionHandler::OnIceCandidate only considers
> candidates with literal IPv4 or IPv6 addresses as legitimate. Hostname
> candidates are now supported by WebRTC, notably when the mDNS
> concealment of local IPs is enabled.
>
> [email protected]
>
> (cherry picked from commit b37aa3f4620505029658d7f097da1cff4037b696)
>
> Bug: 930339
> Change-Id: Ia84328c39a5163f0816b7522421a56cc79aaf965
> Reviewed-on: https://chromium-review.googlesource.com/c/1472253
> Reviewed-by: Henrik Boström <[email protected]>
> Commit-Queue: Qingsi Wang <[email protected]>
> Auto-Submit: Qingsi Wang <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#632683}
> Reviewed-on: https://chromium-review.googlesource.com/c/1483811
> Reviewed-by: Seth Hampson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#582}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

[email protected],[email protected],[email protected]

Change-Id: I675db57f48ee559b88580f9d5d50a343bf77b81f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930339
Reviewed-on: https://chromium-review.googlesource.com/c/1484503
Reviewed-by: Seth Hampson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#586}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/media/webrtc/rtc_peer_connection_handler.cc[diff]

Make mDNS protection contingent on the media permission.

The mDNS protection was controlled by chrome://flags/
capture permission. After this CL, the mDNS protection is only enabled
when the flag is on and the media capture permission is not granted.

[email protected]

(cherry picked from commit e8debc1f947c844552d130b4b2e9998d73fc597f)

Bug: 930339
Change-Id: I00f5fe57c6d622e9c4988f7c13f61c77c0afeb96
Reviewed-on: https://chromium-review.googlesource.com/c/1465167
Commit-Queue: Qingsi Wang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634004}
Reviewed-on: https://chromium-review.googlesource.com/c/1483934
Reviewed-by: Seth Hampson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#585}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/media/webrtc/peer_connection_dependency_factory.cc[diff]
• content/renderer/media/webrtc/peer_connection_dependency_factory.h[diff]
• content/renderer/p2p/filtering_network_manager.cc[diff]
• content/renderer/p2p/filtering_network_manager.h[diff]
• content/renderer/p2p/filtering_network_manager_unittest.cc[diff]
• content/renderer/p2p/ipc_network_manager.cc[diff]
• content/renderer/p2p/ipc_network_manager.h[diff]
• content/renderer/p2p/ipc_network_manager_unittest.cc[diff]
• content/renderer/p2p/mdns_responder_adapter.cc[diff]

Merge to M73: Enable VP9 SVC SW fallback for all platforms.

[email protected]

Bug: chromium:933750
Change-Id: I9975d64abc2751c7887b76bb772b6aa38c43d94c
Reviewed-on: https://chromium-review.googlesource.com/c/1475406
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Sergey Silkin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634106}(cherry picked from commit 12ddd6c2d4929f8d72e225c976243822b8c28c1f)
Reviewed-on: https://chromium-review.googlesource.com/c/1479969
Cr-Commit-Position: refs/branch-heads/3683@{#584}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/media/webrtc/rtc_video_decoder_adapter.cc[diff]

Navi: Only the chevron icon should be flipped for RTL languages.

See screenshot in bug.

Bug: 932045
Change-Id: I2415c714fdff78dbecf9cb48b93154404d49a84d
Reviewed-on: https://chromium-review.googlesource.com/c/1480545
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634285}

Navi: Updated check icon direction and position to match RTL/LTR.

Screenshot in bug.

Bug: 932045
Change-Id: I135f3e63f5a62b4cbac30f5936678d5c8c764171
Reviewed-on: https://chromium-review.googlesource.com/c/1474830
Reviewed-by: Esmael El-Moslimany <[email protected]>
Commit-Queue: Hector Carmona <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632436}
Reviewed-on: https://chromium-review.googlesource.com/c/1483701
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#583}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html[diff]

Accommodate hostname candidates in adddress family counting in RTCPeerConnectionHandler.

Currently RTCPeerConnectionHandler::OnIceCandidate only considers
candidates with literal IPv4 or IPv6 addresses as legitimate. Hostname
candidates are now supported by WebRTC, notably when the mDNS
concealment of local IPs is enabled.

[email protected]

(cherry picked from commit b37aa3f4620505029658d7f097da1cff4037b696)

Bug: 930339
Change-Id: Ia84328c39a5163f0816b7522421a56cc79aaf965
Reviewed-on: https://chromium-review.googlesource.com/c/1472253
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Qingsi Wang <[email protected]>
Auto-Submit: Qingsi Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632683}
Reviewed-on: https://chromium-review.googlesource.com/c/1483811
Reviewed-by: Seth Hampson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#582}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/renderer/media/webrtc/rtc_peer_connection_handler.cc[diff]

Navi: Make cursor into a pointer when hovering over clickable options.

Bug: 934440
Change-Id: I3242df2f77fb92e289942e4967a4cb5c06092e19
Reviewed-on: https://chromium-review.googlesource.com/c/1481855
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Hector Carmona <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634440}(cherry picked from commit 857fd20ba2087763db1d610c039142d6c275fdbc)
Reviewed-on: https://chromium-review.googlesource.com/c/1483694
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#581}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html[diff]

TextControlElement should not change frame selection when detached

TextControlElement::SetSelectionRange() maintains its own selection
range cache, and changes FrameSelection when focused. However, there are
some cases where the document's focused element can be left detached,
resulting in TextControlElement to set invalid FrameSelection.

As fixing the the focus maintenance is more involved, this patch works
around that by stopping TextControlElement to set FrameSelection if it's
detached.

Bug: 927646
Change-Id: I824e2950c5cb38b87288f25120a7a0e32f8f78df
Reviewed-on: https://chromium-review.googlesource.com/c/1469402
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631580}(cherry picked from commit 89fd23887da1ef574a6fc97ab5f48d5b3e3dca4b)
Reviewed-on: https://chromium-review.googlesource.com/c/1483833
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#580}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/dom/container_node.cc[diff]
• third_party/blink/renderer/core/editing/frame_caret.cc[diff]
• third_party/blink/renderer/core/html/forms/text_control_element.cc[diff]
• third_party/blink/web_tests/fast/forms/select_detached_textarea_crash.html[Added - diff]

Merge: Reland 'Smart Lock: Clear stale ProximityMonitor on disconnect.'

The original commit (crrev.com/c/1479941) was reverted
(crrev.com/c/1480309) because of usage of unitialized memory.
Specifically, the MockProximityMonitor object had been deleted but was
then derefenced.

Patch 1 is the original commit, Patch 2 is the fix.

Original commit message:
UnlockManager was previously holding onto a stale
ProximityMonitor from its first connection. That meant
that if a disconnection and subsequent new connection
occurred, the old ProximityMonitor, with an old reference
to the previous connection (represented as a ClientChannel
object) was used. This always resulted in a Smart Lock
failure for a second connection, and occasionally, a crash.

In order to correctly reset the ProximityMonitor object,
the way that it is called had to be refactored (remove
completely unneeded ScreenLockBridge logic), in order to
consolidate calls to one place.

(cherry picked from commit 41ff5baab429ecc5a4d44a7aa31308748730826c)

Bug: 931929
Change-Id: If8d7b48efe0055b8d0afc2f4cd3954114c0b7a71
Reviewed-on: https://chromium-review.googlesource.com/c/1481613
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634330}
Reviewed-on: https://chromium-review.googlesource.com/c/1483397
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#579}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chromeos/components/proximity_auth/unlock_manager_impl.cc[diff]
• chromeos/components/proximity_auth/unlock_manager_impl.h[diff]
• chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc[diff]

[Merge 73] Remove the domain restriction for the doodle share link on the local NTP.
Change approved in https://crbug.com/934454#c4

This is due to the deprecation of the url shortener domains in favor of Firebase Durable Link (go/us-to-fdl) for creating 1P shortlinks at Google.

Bug: 896461
Change-Id: I38379161ed513518b7b9871eef7fa44e7ef0ccf2
Reviewed-on: https://chromium-review.googlesource.com/c/1460063
Commit-Queue: David Lu <[email protected]>
Reviewed-by: Kyle Milka <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631955}(cherry picked from commit e1c9e5b0140da0efb6906e187f3c60e004a22c04)
Reviewed-on: https://chromium-review.googlesource.com/c/1481803
Cr-Commit-Position: refs/branch-heads/3683@{#578}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/search_provider_logos/google_logo_api.cc[diff]
• components/search_provider_logos/google_logo_api_unittest.cc[diff]

[Global Media Controls] Re-add logic to update active session on focus

This CL re-adds the logic to update the active media session on focus
for platforms other than Mac. After further discussion with UX, it was
decided that the reasoning behind pulling this logic in
crrev.com/c/1450303 (user expectation) was only applicable to Mac OS X
users.

Bug: 932664
Change-Id: Ic148556f9b09ef942d43cfc0d80ecdd19f94c498
Reviewed-on: https://chromium-review.googlesource.com/c/1475807
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632851}(cherry picked from commit 94182563bd5c027f9c3c38bed6e14eeeb9c8aea9)
Reviewed-on: https://chromium-review.googlesource.com/c/1483257
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#577}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/media/session/media_session_impl.cc[diff]
• content/browser/media/session/media_session_impl_unittest.cc[diff]

[Peripheral] Flare as primary OOBE display

This CL allows the Flare touch device to be recognized as a primary
touch device on during the OOBE screen, by white-listing it for OOBE use
and blacklisting additional unused interfaces.

Bug: b/124839645
Test: manually

Signed-off-by: Kyle Williams <[email protected]>
Change-Id: I5f088c27b43eb2a3a3efb69c2ea2b4bb42800b81
Reviewed-on: https://chromium-review.googlesource.com/c/1479635
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Malay Keshav <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634415}(cherry picked from commit dac1c1425470787a5058d37e8b4892b6240972a7)
Reviewed-on: https://chromium-review.googlesource.com/c/1479814
Cr-Commit-Position: refs/branch-heads/3683@{#576}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc[diff]
• ui/events/ozone/evdev/event_device_info.cc[diff]
• ui/events/ozone/evdev/event_device_info_unittest.cc[diff]
• ui/events/ozone/evdev/event_device_test_util.cc[diff]
• ui/events/ozone/evdev/event_device_test_util.h[diff]

Don't register for a callback if already registered.

In an edge case, when RenderProcessHost notifies listeners about its
blocked state changing, the callback registers a new callback, which
then is called about the blocked state changing, which registers a
new callback, etc.

This fixes that by not registering a callback if one is already
registered.

BUG=933033, 891423
TEST=as in bug 933033

Change-Id: I6842e0afb11cee21c843106cac3a17431925a9a1
Reviewed-on: https://chromium-review.googlesource.com/c/1479851
Commit-Queue: Łukasz Anforowicz <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634228}(cherry picked from commit 08f72a6e57e80ac3a1a8dab49c9a3896c1e4dbf1)
Reviewed-on: https://chromium-review.googlesource.com/c/1483255
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#575}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/frame_host/navigation_handle_impl.cc[diff]

[Audio Focus] Stop ducking if paused

If the media session is paused then we should not
apply transient focus types (ducking, pausing). If
the session is resumed then we should reapply those
types.

BUG=931898

Change-Id: Iabcaae24f42e6b3012c8e5098830d1115aecfdca
Reviewed-on: https://chromium-review.googlesource.com/c/1473832
Reviewed-by: Tommy Steimel <[email protected]>
Commit-Queue: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632669}(cherry picked from commit af11f5c25e2b9559e13688fa68db888b1e3919be)
Reviewed-on: https://chromium-review.googlesource.com/c/1482946
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#574}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• services/media_session/audio_focus_manager.cc[diff]
• services/media_session/audio_focus_manager_unittest.cc[diff]

Do not crash on duplicate policy invalidation names.

Due to server side issue, the same invalidation name could be sent for
different kiosk apps, causing devices to constantly crash on signin
screen.
In order to not crash, we'll just silently stop receiving invalidations
for one of "duplicate" apps, log the error and add UMA stats to track
such behavior.

Bug: 783428
Test: Manual, trybots
Change-Id: I11fd3b249a44699ce585e675bf697bee893c8438
Reviewed-on: https://chromium-review.googlesource.com/c/1473990
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Sergey Poromov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#634143}(cherry picked from commit fb8a794cf5ef80b41bac0538d8384f430ddd1f55)
Reviewed-on: https://chromium-review.googlesource.com/c/1482899
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#573}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/policy/cloud/cloud_policy_invalidator.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

Do not wait for Gaia screen on MgS/ARC Kiosk auto-start.

The check was migrated from old webui waiting for OnSigninScreenReady()
However, OnGaiaScreenReady() might be called a couple of seconds later
then the login screen is actually shown, causing long-long delay for
Mgs/ArcKiosk auto-launch.

Bug: 902315
Test: Manual
Change-Id: I4919ab826bb31075db33d40d54bcb85227d84d54
Reviewed-on: https://chromium-review.googlesource.com/c/1470793
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Sergey Poromov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632561}(cherry picked from commit 55c07cbeaec79b93c7fd14fe66a2b9045b461474)
Reviewed-on: https://chromium-review.googlesource.com/c/1483026
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#572}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/chromeos/login/existing_user_controller.cc[diff]
• chrome/browser/chromeos/login/existing_user_controller.h[diff]
• chrome/browser/chromeos/login/existing_user_controller_auto_login_unittest.cc[diff]

HTTPS Previews: Keep original fragment unencoded in rewritten URL

This CL adds the fragment to the previews URL so that, if loaded, the
page scrolls correctly.
The fragment remains in the encoded URL so that if Chrome fallbacks, the
original page will still scroll as well.

Bug: 932841
Change-Id: I5566202c52a6ee5062419fa9d73e892a231f7e19
Reviewed-on: https://chromium-review.googlesource.com/c/1475708
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632963}
Reviewed-on: https://chromium-review.googlesource.com/c/1483251
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#571}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/previews/previews_lite_page_navigation_throttle.cc[diff]
• chrome/browser/previews/previews_lite_page_navigation_throttle_unittest.cc[diff]
• components/previews/content/previews_decider_impl.cc[diff]
• components/previews/content/previews_decider_impl_unittest.cc[diff]
• components/previews/core/previews_black_list.h[diff]
• components/previews/core/previews_lite_page_redirect.cc[diff]
• components/previews/core/previews_lite_page_redirect_unittest.cc[diff]
• components/previews/core/previews_logger.cc[diff]
• tools/metrics/histograms/enums.xml[diff]

Reorder GL implementations on Mac to not use EGL so early.

Since https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ EGL is
enabled on Mac but not used by default.  The disable_es3_gl_context workaround
removes the kGLImplementationDesktopGLCoreProfile GL implementation from the
list of allowed implementations which now defaults to using EGL when the
intention is that it falls back to a non-core desktop GL profile. Reorder the
implementations so that the fallback happens as expected.

BUG=918365

Change-Id: Ibf9ae089897f32508dd83fed41cfdc8412e9c7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1437060
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626096}(cherry picked from commit 12445b718fed85b698a777a2af2d3ce6b5f0d0de)
Reviewed-on: https://chromium-review.googlesource.com/c/1482567
Reviewed-by: Geoff Lang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#570}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ui/gl/init/gl_factory_mac.cc[diff]

[Merge 73][Extensions Click-to-Script] Fix a crash when revoking <all_urls>

Fix a crash in revoking extension permissions where the permissions to
be revoked didn't seem to be contained within the granted permissions.
This was caused because the <all_urls> URLPattern retrieved from
ExtensionPrefs (through calls to
ExtensionPrefs::GetRuntimeGrantedPermissions) isn't properly scheme-
restricted to avoid including chrome:-scheme patterns. As a result of
crrev.com/e13eb21898, URLPattern::Contains now properly checks schemes,
resulting in this contains check failing and triggering a CHECK()
failure.

As a workaround, hackily adjust the runtime-granted permissions
retrieved from ExtensionPrefs in ScriptablePermissionsModifier to
properly omit the chrome:-scheme from <all_urls> patterns (adding back
chrome://favicon separately). This logic mirrors that in
ParseHelper in permissions_parser.cc, which adds the patterns to the
extension permissions.

This isn't a great solution, since ExtensionPrefs should really not be
returning incorrect values for URLPatterns; however, it's the most
targeted and easiest to merge. Since this is for a crash, go with this
approach for now. A separate bug has been filed to fix ExtensionPrefs
behavior.

Add a regression test for the previously-crashing behavior.

Bug: 930062

[email protected]

(cherry picked from commit 971c1bddb75caa9d29a97190cd33dc847223808d)

Change-Id: I0813c2bc2a462a0ced48f2e1a265c1efe7f2fdea
Reviewed-on: https://chromium-review.googlesource.com/c/1471004
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632775}
Reviewed-on: https://chromium-review.googlesource.com/c/1482133
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#569}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/extensions/scripting_permissions_modifier.cc[diff]
• chrome/browser/extensions/scripting_permissions_modifier_unittest.cc[diff]

Incrementing VERSION to 73.0.3683.49

[email protected]

Change-Id: I3b6569a6fb61707db1bc2f9bfccb3c4fb68c138c
Reviewed-on: https://chromium-review.googlesource.com/c/1481126
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#568}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/VERSION[diff]

IDL compiler: Check if V8 value is callable for callback functions

According to the WebIDL spec[1], we have to check if the passed value
is callable or not before converting it to a native CallbackFunction
object.
Because we did not check it, and hit a crash error if a user
passes a non-callable object to a dictionary member, whose type is a
callback function.

This CL adds the check and throws an exception if the passed value
is not callable.


[1]https://heycam.github.io/webidl/#es-callback-function

Bug: 928720
Change-Id: I3b0bc3a75af46db13bb6428b3fd6ba1692a255ba
Reviewed-on: https://chromium-review.googlesource.com/c/1454071
Commit-Queue: Kentaro Hara <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Auto-Submit: Hitoshi Yoshida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630239}(cherry picked from commit a68807e1cbb03365f55c9d88eaa8924814974a17)
Reviewed-on: https://chromium-review.googlesource.com/c/1481283
Reviewed-by: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#567}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/bindings/scripts/v8_dictionary.py[diff]
• third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl[diff]
• third_party/blink/renderer/bindings/tests/idls/core/test_dictionary.idl[diff]
• third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc[diff]
• third_party/blink/renderer/bindings/tests/results/core/test_dictionary.h[diff]
• third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc[diff]
• third_party/blink/web_tests/bindings/idl-dictionary-unittest-expected.txt[diff]
• third_party/blink/web_tests/bindings/idl-dictionary-unittest.html[diff]

Add link-rel:prerender UseCounter UKM

It's usage is about 1.25%.
https://www.chromestatus.com/metrics/feature/timeline/popularity/918

Bug: 932212
Change-Id: I89a00142e398e8457e2d13518b09340db1715f75
Reviewed-on: https://chromium-review.googlesource.com/c/1475669
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633348}(cherry picked from commit f4b357fadcb97c3270965e656372738afe8a3215)
Reviewed-on: https://chromium-review.googlesource.com/c/1481798
Cr-Commit-Position: refs/branch-heads/3683@{#566}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc[diff]

Fix the logic for always accelerating canvases

Because HTMLCanvasElement::ShouldAccelerate always returned true if the
AlwaysAccelerate finch trial was running, it would never hit the path
where it creates a ContextProviderWrapper and checks that it is even
POSSIBLE to create an accelerated canvas.

This CL changes the logic of that function so that
features::kAlwaysAccelerateCanvas simply bypasses all of the other
heuristics, but still performs the check on the context provider.

Bug: 930559
Change-Id: If4d52b6696424488c468fcaa779793dbec9e689b
Reviewed-on: https://chromium-review.googlesource.com/c/1478484
Reviewed-by: enne <[email protected]>
Commit-Queue: Aaron Krajeski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633835}(cherry picked from commit a59e347ca879f2447f46384315fcbba229e2d953)
Reviewed-on: https://chromium-review.googlesource.com/c/1481595
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#565}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/core/html/canvas/html_canvas_element.cc[diff]

Clamp downstream throughput based on ECT

The downstream throughput is clamped on slow connections based on
current value of effective connection type (ECT). The logic is
behind a finch param.

Bug: 933432
Change-Id: Id0aa69a1f58bfc5c61b4d38c46b7a62e53fc971a
Reviewed-on: https://chromium-review.googlesource.com/c/1475706
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633573}(cherry picked from commit 2e18fd502352483cbe25a5562c48c6590f7a8dcd)
Reviewed-on: https://chromium-review.googlesource.com/c/1481990
Cr-Commit-Position: refs/branch-heads/3683@{#564}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• net/nqe/network_quality_estimator.cc[diff]
• net/nqe/network_quality_estimator.h[diff]
• net/nqe/network_quality_estimator_params.cc[diff]
• net/nqe/network_quality_estimator_params.h[diff]
• net/nqe/network_quality_estimator_unittest.cc[diff]

Fix crash on RevokeUserAllowExceptionsHard with network service on.

Bug: 930635
Change-Id: I95c6698e220d939b37abea3ea76d2ede7991f77e
Reviewed-on: https://chromium-review.googlesource.com/c/1478102
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633563}(cherry picked from commit 1966412a51e725860dd9f2988197211180371842)
Reviewed-on: https://chromium-review.googlesource.com/c/1481907
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#563}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/ssl/chrome_ssl_host_state_delegate.cc[diff]

Revert "Mac: Disable dark mode by default on beta"

This reverts commit 58a7ca6b88db211ff2be0e99a7e16ea79ac8002a.

Reason for revert: Launch approved.

Original change's description:
> Mac: Disable dark mode by default on beta
> 
> This is still in launch review, so let's turn it off for now.
> 
> Bug: 850098
> Change-Id: Ide8a15ff592bc781ffb08b2d62221f35d435e263
> Reviewed-on: https://chromium-review.googlesource.com/c/1452723
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#201}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850098
Change-Id: Iee442aefa8fa0b3e8464012952cc91e8f6fc2f11
Reviewed-on: https://chromium-review.googlesource.com/c/1481598
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#562}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ui/base/ui_base_features.cc[diff]

[Omnibox] Document Suggest Drive icon - make top/bottom lines in icon crisp.

Moving from left to middle in this screenshot:
https://screenshot.googleplex.com/HBMc8HiP71i
the right icon is the new favicon on the web interface.

Bug: 927045
Change-Id: Iccd95f9afe3bf81dea0ad42deb0346ded049ce3a
Reviewed-on: https://chromium-review.googlesource.com/c/1446859
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Travis Skare <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627604}(cherry picked from commit afb9e84a450b2222144028c3af6e59186507ade1)
Reviewed-on: https://chromium-review.googlesource.com/c/1479883
Cr-Commit-Position: refs/branch-heads/3683@{#561}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/omnibox/browser/vector_icons/drive_docs.icon[diff]

[Omnibox] Dedupe document results.

Bug: 888093
Change-Id: I448c5a807e524b32bcf5535c56932ee936a8c443
Reviewed-on: https://chromium-review.googlesource.com/c/1339139
Commit-Queue: Travis Skare <[email protected]>
Reviewed-by: Max Moroz <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632026}(cherry picked from commit 3248e67c7a2c35bafbae729029631d30c109d33c)
Reviewed-on: https://chromium-review.googlesource.com/c/1481596
Cr-Commit-Position: refs/branch-heads/3683@{#560}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/omnibox/browser/BUILD.gn[diff]
• components/omnibox/browser/DEPS[diff]
• components/omnibox/browser/autocomplete_match.cc[diff]
• components/omnibox/browser/autocomplete_match_unittest.cc[diff]
• components/omnibox/browser/document_provider.cc[diff]
• components/omnibox/browser/document_provider.h[diff]
• components/omnibox/browser/document_provider_unittest.cc[diff]
• components/omnibox/browser/omnibox_field_trial.cc[diff]
• components/omnibox/browser/omnibox_field_trial.h[diff]

Print Preview: Fix double sign in issues (M73)

(cherry picked from commit a6485b4f2b3ccaa739079b5cc60332b9e0204d1f)

Bug: 928858, 924889, 923914
Change-Id: Iadea7005f5d4b9ddfb18e0883c26f0d0f8865e89
Reviewed-on: https://chromium-review.googlesource.com/c/1454081
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629725}
Reviewed-on: https://chromium-review.googlesource.com/c/1480821
Cr-Commit-Position: refs/branch-heads/3683@{#559}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/browser/resources/print_preview/cloud_print_interface_js.js[diff]
• chrome/browser/resources/print_preview/data/destination_store.js[diff]
• chrome/browser/resources/print_preview/new/destination_dialog.js[diff]
• chrome/browser/resources/print_preview/new/destination_settings.html[diff]
• chrome/browser/resources/print_preview/new/destination_settings.js[diff]
• chrome/test/data/webui/print_preview/cloud_print_interface_stub.js[diff]
• chrome/test/data/webui/print_preview/destination_select_test.js[diff]
• chrome/test/data/webui/print_preview/destination_settings_test.js[diff]
• chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js[diff]

Fix openIn crashing when getting an external file to open.

The problem is URLLoader doesn't know chrome://external-file
So providing it with the actual file:// URL fixes the problem.

Bug: 928252
Change-Id: I1cda9cc076bd804a660aa46fdea84569bf7a5829
Reviewed-on: https://chromium-review.googlesource.com/c/1474686
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632691}(cherry picked from commit 520b45c6acd600ff1458b1b35c4be6ffd138ea27)
Reviewed-on: https://chromium-review.googlesource.com/c/1480271
Cr-Commit-Position: refs/branch-heads/3683@{#558}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ios/chrome/browser/tabs/tab.mm[diff]

Reland "[omnibox]: Initialize HistoryURLProvider earlier."

This is a reland of 6e200e4f600e2eb0258e244177aa9439ff0b6bb4

Original change's description:
> [omnibox]: Initialize HistoryURLProvider earlier.
> 
> This CL moves the HistoryURlProvider's initialization after the SearchProvider's
> but before the ZeroSuggestProvider's and ClipboardURLProvider's.
> 
> For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization
> last in the AutocompleteController's constructor. However, the zero suggest and
> clipboard URL providers take a reference of the history URL provider when
> initialized. To avoid setting these references to NULL, this CL moves the
> history URL provider's initialization before the other two's but keeps
> it after the search provider's for the reasons described in the other CL.
> 
> Bug: 932257
> Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17
> Reviewed-on: https://chromium-review.googlesource.com/c/1474383
> Reviewed-by: Mark Pearson <[email protected]>
> Commit-Queue: manuk hovanesian <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#632682}

Bug: 932257
Change-Id: If1dd04d838bc78f8f323280b4023fea551a80b3a
Reviewed-on: https://chromium-review.googlesource.com/c/1475249
Reviewed-by: manuk hovanesian <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632793}(cherry picked from commit 364c0486848f637297d55992783d77bfd1ca06d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1481058
Cr-Commit-Position: refs/branch-heads/3683@{#557}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/omnibox/browser/autocomplete_controller.cc[diff]

Fix crash on missing database

DeleteResourceIdsInBatch will return STATUS_OK if LazyOpen(false) can't
find a database. In this case db_ would be null and we shouldn't call
WriteBatch() to avoid crashing.

Bug: 931160
Change-Id: I745d475472a9a4d42387b886eae86ca669c74af6
Reviewed-on: https://chromium-review.googlesource.com/c/1474768
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633646}(cherry picked from commit 7f5bb07e152ef23a31577fd02f3439c597fe1977)
Reviewed-on: https://chromium-review.googlesource.com/c/1479997
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#556}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/service_worker/service_worker_database.cc[diff]

Check for host before invoking its function

This patch checks for the host before invoking a function call on it.

Bug: 931827
Change-Id: I14b478683238f0bb4cd55672abef5228f5b58e22
Component: RenderwidgetHostViewAura
Reviewed-on: https://chromium-review.googlesource.com/c/1470720
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Malay Keshav <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633381}(cherry picked from commit f799f9f7e0e52c664dac748eb36066947ccc9c34)
Reviewed-on: https://chromium-review.googlesource.com/c/1479837
Reviewed-by: Malay Keshav <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#555}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• content/browser/renderer_host/render_widget_host_view_aura.cc[diff]

Extend UAv2 transient activation expiry time to 5sec.

We dropped the expiry time from 30sec to 1sec before launching UAv2
to give it a try, because of a lack of consensus on an acceptable value;
see the discussion on UAv2 intent thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/nkTDR8AUlwM/xsPcojA5BAAJ

With UAv2 launch, we saw some minor regressions where the use cases
would work only with a longer delay.

Note that we originally planned for a longer (even infinity) expiry time
because:
- Pre-UAv2 Chrome had 10sec in certain cases.
- Some major browsers allow infinite delay in slow event handlers.

Bug: 932577
Change-Id: If35739aacce16c14528493c6586764c2dc853251
Reviewed-on: https://chromium-review.googlesource.com/c/1479415
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633956}(cherry picked from commit 9376d63fc9d7c717062e7e9ecbbdea6784237ed1)
Reviewed-on: https://chromium-review.googlesource.com/c/1480713
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#554}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/common/frame/user_activation_state.cc[diff]
• third_party/blink/common/frame/user_activation_state_unittest.cc[diff]
• third_party/blink/web_tests/fast/events/popup-blocking-timers6-expected.txt[diff]
• third_party/blink/web_tests/fast/events/popup-blocking-timers6.html[diff]

Traverse frames in OomIntervention ForciblyPurgeV8Memory

This CL traverses frames in OomIntervention ForciblyPurgeV8Memory
to maximize the memory impact.

[email protected]

Bug: 932336
Change-Id: Ifa167ec6a7f6ef9b4bfc3f9814850f60ec0d439a
Reviewed-on: https://chromium-review.googlesource.com/c/1481271
Reviewed-by: Yuzu Saijo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#553}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/controller/oom_intervention_impl.cc[diff]

Revert "Reslove merge conflict"

This reverts commit aac9abc3f4df9781862322def2310dba96bd5e90.

Reason for revert: Failure on beta
Bug: 934196

Original change's description:
> Reslove merge conflict
> 
> [email protected]
> 
> Change-Id: I7ebaa4bf0124aeda66646f58653f82856f0d5f91
> Reviewed-on: https://chromium-review.googlesource.com/c/1481175
> Reviewed-by: Yuzu Saijo <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#548}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

[email protected]

Change-Id: Ibdcaee78f034b3aefccb79777f24da887da44468
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1481142
Reviewed-by: Yuzu Saijo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#552}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/controller/oom_intervention_impl.cc[diff]
• third_party/blink/renderer/core/inspector/inspector_memory_agent.cc[diff]

Fix vote sending in NewPasswordFormManager.

[email protected]

(cherry picked from commit 7de6ea78202ed18e5f79b82d822015b6e9e0eb4f)

Bug: 831123, 928313
Change-Id: Ia89fc9c09dd7dd753a5e3e02cadebfa313f7577f
Reviewed-on: https://chromium-review.googlesource.com/c/1470237
Commit-Queue: Vadym Doroshenko <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632215}
Reviewed-on: https://chromium-review.googlesource.com/c/1479957
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#551}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/password_manager/core/browser/new_password_form_manager.cc[diff]
• components/password_manager/core/browser/new_password_form_manager_unittest.cc[diff]
• components/password_manager/core/browser/vote_uploads_test_matchers.h[diff]

Fix |form_may_be_submitted| in password_controller.

If DidNavigateMainFrame argument |form_may_be_submitted| is true then
PasswordManager will check the form that was submitted (if any) whether
the submission was successful. On other platforms this parameter is false
when there is link navigation or browser initiated navigation. On iOS
we don't have such logic to check, so this is correct to pass true always.

[email protected]

(cherry picked from commit 98a18bfd16f36a4bb364ec925d353088fd52857e)

Bug: 831123, 932107
Change-Id: Ib446e0e16525eb98887db7c7f147080721834cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1463449
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632196}
Reviewed-on: https://chromium-review.googlesource.com/c/1480453
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#550}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• ios/chrome/browser/passwords/password_controller.mm[diff]
• ios/web_view/internal/passwords/cwv_password_controller.mm[diff]

[Tango->FCM] Start invalidatior on Android as soon as Active account is available.

BUG=924957
[email protected]

(cherry picked from commit a7e2e28c28b9fbbd9480fa8c111538f81cfe774f)

Change-Id: Ic7d21e7df7243c8b8a7a95c8a33e8e3060c4e3c1
Reviewed-on: https://chromium-review.googlesource.com/c/1474661
Commit-Queue: Tatiana Gornak <[email protected]>
Reviewed-by: vitaliii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633093}
Reviewed-on: https://chromium-review.googlesource.com/c/1480452
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#549}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• components/invalidation/impl/fcm_invalidation_service.cc[diff]
• components/invalidation/impl/invalidation_switches.cc[diff]
• components/invalidation/impl/invalidation_switches.h[diff]

Reslove merge conflict

[email protected]

Change-Id: I7ebaa4bf0124aeda66646f58653f82856f0d5f91
Reviewed-on: https://chromium-review.googlesource.com/c/1481175
Reviewed-by: Yuzu Saijo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#548}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/blink/renderer/controller/oom_intervention_impl.cc[diff]
• third_party/blink/renderer/core/inspector/inspector_memory_agent.cc[diff]

sqlite: Upgrade from 3.26.0 to 3.27.1.

The upgrade lets us remove ~40 backports that we have accumulated since the
last release. It unfortunately also introduces one new patch, which is needed
to keep SQLite compiling with SQLITE_OMIT_WINDOWFUNC.

(cherry picked from commit d664d4a4adac34fccb9879380cf4863321c6a64a)

Bug: 930560
Change-Id: I4f5e1301581f443f8593ad7943663fd4f3484780
Reviewed-on: https://chromium-review.googlesource.com/c/1462202
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630942}
Reviewed-on: https://chromium-review.googlesource.com/c/1480822
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#547}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• third_party/sqlite/amalgamation/rename_exports.h[diff]
• third_party/sqlite/amalgamation/shell/shell.c[diff]
• third_party/sqlite/amalgamation/sqlite3.c[diff]
• third_party/sqlite/amalgamation/sqlite3.h[diff]
• third_party/sqlite/patches/0001-Modify-default-VFS-to-support-WebDatabase.patch[diff]
• third_party/sqlite/patches/0002-Virtual-table-supporting-recovery-of-corrupted-datab.patch[diff]
• third_party/sqlite/patches/0003-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch[diff]
• third_party/sqlite/patches/0004-fts3-Disable-fts3_tokenizer-and-fts4.patch[diff]
• third_party/sqlite/patches/0005-fuchsia-Use-dot-file-locking-for-sqlite.patch[diff]
• third_party/sqlite/patches/0006-Fix-compilation-with-SQLITE_OMIT_WINDOWFUNC.patch[Added - diff]
• third_party/sqlite/patches/0006-Fix-dbfuzz2-for-Clusterfuzz.patch[Deleted - diff]
• third_party/sqlite/patches/0007-Fix-dbfuzz2.c-compilation-errors-on-Windows.patch[Added - diff]
• third_party/sqlite/patches/0007-Fix-the-Makefile-so-that-it-honors-CFLAGS-when-build.patch[Deleted - diff]
• third_party/sqlite/patches/0008-Adjustments-to-the-page-cache-to-try-to-avoid-harmle.patch[Deleted - diff]
• third_party/sqlite/patches/0009-Remove-an-ALWAYS-from-a-branch-that-is-not-always-ta.patch[Deleted - diff]
• third_party/sqlite/patches/0010-Fix-a-problem-with-nested-CTEs-with-the-same-table.patch[Deleted - diff]
• third_party/sqlite/patches/0011-Fix-detection-of-self-referencing-rows-in-foreign-ke.patch[Deleted - diff]
• third_party/sqlite/patches/0012-Fix-a-segfault-caused-by-using-the-RAISE-function-in.patch[Deleted - diff]
• third_party/sqlite/patches/0013-Fix-for-an-assert-that-could-be-false.patch[Deleted - diff]
• third_party/sqlite/patches/0014-Fix-another-problem-found-by-Matthew-Denton-s-new-fu.patch[Deleted - diff]
• third_party/sqlite/patches/0015-Report-a-new-corruption-case.patch[Deleted - diff]
• third_party/sqlite/patches/0016-Avoid-a-buffer-overread-in-ptrmapPutOvflPtr.patch[Deleted - diff]
• third_party/sqlite/patches/0017-Improved-detection-of-cell-corruption-in-sqlite3Vdbe.patch[Deleted - diff]
• third_party/sqlite/patches/0018-Fix-a-segfault-in-fts3-prompted-by-a-corrupted-datab.patch[Deleted - diff]
• third_party/sqlite/patches/0019-Prevent-integer-overflow-from-leading-to-buffer-over.patch[Deleted - diff]
• third_party/sqlite/patches/0020-Add-extra-tests-for-database-corruption-inside-defra.patch[Deleted - diff]
• third_party/sqlite/patches/0021-Fix-an-off-by-one-error-on-a-Goto-in-the-code-genera.patch[Deleted - diff]
• third_party/sqlite/patches/0022-Fix-overread-on-corrupted-btree-key.patch[Deleted - diff]
• third_party/sqlite/patches/0023-Avoid-buffer-overreads-on-corrupted-database-files.patch[Deleted - diff]
• third_party/sqlite/patches/0024-Fix-integer-overflow-while-running-PRAGMA-integrity_.patch[Deleted - diff]
• third_party/sqlite/patches/0025-Improved-corruption-handling-while-balancing-pages.patch[Deleted - diff]
• third_party/sqlite/patches/0026-Avoid-reading-off-the-front-of-a-page-buffer-when-ba.patch[Deleted - diff]
• third_party/sqlite/patches/0027-Fix-MSAN-error-in-sqlite3VdbeRecordUnpack-on-a-corru.patch[Deleted - diff]
• third_party/sqlite/patches/0028-Fix-deleting-a-B-tree-entry-in-a-corrupt-database.patch[Deleted - diff]
• third_party/sqlite/patches/0029-Fix-sorting-results-with-SRT_EphemTab-and-a-LIMIT-cl.patch[Deleted - diff]
• third_party/sqlite/patches/0030-Fix-detection-of-orphaned-and-malformed-autoindexes.patch[Deleted - diff]
• third_party/sqlite/patches/0031-Fix-potential-buffer-overread.patch[Deleted - diff]
• third_party/sqlite/patches/0032-Fix-handling-negative-number-of-pages-database-field.patch[Deleted - diff]
• third_party/sqlite/patches/0033-Fix-corner-case-in-inserting-null-into-integer-prima.patch[Deleted - diff]
• third_party/sqlite/patches/0034-Fix-insert-infinite-recursion-on-some-corrupted-data.patch[Deleted - diff]
• third_party/sqlite/patches/0035-Fix-null-pointer-dereference-in-sqlite3ExprCompare.patch[Deleted - diff]
• third_party/sqlite/patches/0036-Fix-NEVER-that-is-sometimes-true.patch[Deleted - diff]
• third_party/sqlite/patches/0037-Initialize-extra-bytes-allocated-for-saved-cursor-po.patch[Deleted - diff]
• third_party/sqlite/patches/0038-Fix-leaks-caused-by-circular-references-in-vtable-sh.patch[Deleted - diff]
• third_party/sqlite/patches/0039-Fix-overly-large-malloc-on-btree-corruption.patch[Deleted - diff]
• third_party/sqlite/patches/0040-Fix-null-pointer-access-on-corrupted-index-key.patch[Deleted - diff]
• third_party/sqlite/src/Makefile.in[diff]
• third_party/sqlite/src/Makefile.msc[diff]
• third_party/sqlite/src/VERSION[diff]
• third_party/sqlite/src/autoconf/Makefile.msc[diff]
• third_party/sqlite/src/configure[diff]
• third_party/sqlite/src/ext/expert/expert1.test[diff]
• third_party/sqlite/src/ext/fts3/fts3.c[diff]
• third_party/sqlite/src/ext/fts3/fts3Int.h[diff]
• third_party/sqlite/src/ext/fts3/fts3_aux.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_expr.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_hash.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_icu.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_snippet.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_term.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_test.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_tokenize_vtab.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_unicode.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_unicode2.c[diff]
• third_party/sqlite/src/ext/fts3/fts3_write.c[diff]
• third_party/sqlite/src/ext/fts3/unicode/mkunicode.tcl[diff]
• third_party/sqlite/src/ext/fts3/unicode/parseunicode.tcl[diff]
• third_party/sqlite/src/ext/fts5/fts5.h[diff]
• third_party/sqlite/src/ext/fts5/fts5Int.h[diff]
• third_party/sqlite/src/ext/fts5/fts5_aux.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_buffer.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_config.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_expr.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_hash.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_index.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_main.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_storage.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_test_mi.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_test_tok.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_tokenize.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_unicode2.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_varint.c[diff]
• third_party/sqlite/src/ext/fts5/fts5_vocab.c[diff]
• third_party/sqlite/src/ext/fts5/test/fts5aa.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5ai.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5ak.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5circref.test[Added - diff]
• third_party/sqlite/src/ext/fts5/test/fts5corrupt3.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5interrupt.test[Added - diff]
• third_party/sqlite/src/ext/fts5/test/fts5tokenizer.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5umlaut.test[Added - diff]
• third_party/sqlite/src/ext/fts5/test/fts5unicode3.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5update.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5vocab.test[diff]
• third_party/sqlite/src/ext/fts5/test/fts5vocab2.test[diff]
• third_party/sqlite/src/ext/misc/amatch.c[diff]
• third_party/sqlite/src/ext/misc/closure.c[diff]
• third_party/sqlite/src/ext/misc/csv.c[diff]
• third_party/sqlite/src/ext/misc/dbdump.c[diff]
• third_party/sqlite/src/ext/misc/eval.c[diff]
• third_party/sqlite/src/ext/misc/fileio.c[diff]
• third_party/sqlite/src/ext/misc/fuzzer.c[diff]
• third_party/sqlite/src/ext/misc/json1.c[diff]
• third_party/sqlite/src/ext/misc/memstat.c[diff]
• third_party/sqlite/src/ext/misc/memtrace.c[Added - diff]
• third_party/sqlite/src/ext/misc/mmapwarm.c[diff]
• third_party/sqlite/src/ext/misc/nextchar.c[diff]
• third_party/sqlite/src/ext/misc/percentile.c[diff]
• third_party/sqlite/src/ext/misc/prefixes.c[Added - diff]
• third_party/sqlite/src/ext/misc/regexp.c[diff]
• third_party/sqlite/src/ext/misc/unionvtab.c[diff]
• third_party/sqlite/src/ext/misc/vfslog.c[diff]
• third_party/sqlite/src/ext/misc/zipfile.c[diff]
• third_party/sqlite/src/ext/rbu/rbu_common.tcl[diff]
• third_party/sqlite/src/ext/rbu/rbuvacuum2.test[diff]
• third_party/sqlite/src/ext/rbu/rbuvacuum3.test[Added - diff]
• third_party/sqlite/src/ext/rbu/sqlite3rbu.c[diff]
• third_party/sqlite/src/ext/rbu/sqlite3rbu.h[diff]
• third_party/sqlite/src/ext/rbu/test_rbu.c[diff]
• third_party/sqlite/src/ext/rtree/geopoly.c[diff]
• third_party/sqlite/src/ext/rtree/rtree.c[diff]
• third_party/sqlite/src/ext/rtree/rtree1.test[diff]
• third_party/sqlite/src/ext/rtree/rtree6.test[diff]
• third_party/sqlite/src/ext/rtree/rtreecirc.test[Added - diff]
• third_party/sqlite/src/ext/rtree/rtreefuzz001.test[Added - diff]
• third_party/sqlite/src/ext/session/changeset.c[diff]
• third_party/sqlite/src/ext/session/changesetfuzz.c[diff]
• third_party/sqlite/src/ext/session/session_speed_test.c[diff]
• third_party/sqlite/src/ext/session/sessionwor.test[diff]
• third_party/sqlite/src/ext/session/sqlite3session.c[diff]
• third_party/sqlite/src/ext/session/sqlite3session.h[diff]
• third_party/sqlite/src/main.mk[diff]
• third_party/sqlite/src/manifest[diff]
• third_party/sqlite/src/manifest.uuid[diff]
• third_party/sqlite/src/src/alter.c[diff]
• third_party/sqlite/src/src/analyze.c[diff]
• third_party/sqlite/src/src/attach.c[diff]
• third_party/sqlite/src/src/btree.c[diff]
• third_party/sqlite/src/src/btree.h[diff]
• third_party/sqlite/src/src/btreeInt.h[diff]
• third_party/sqlite/src/src/build.c[diff]
• third_party/sqlite/src/src/callback.c[diff]
• third_party/sqlite/src/src/dbstat.c[diff]
• third_party/sqlite/src/src/delete.c[diff]
• third_party/sqlite/src/src/expr.c[diff]
• third_party/sqlite/src/src/fkey.c[diff]
• third_party/sqlite/src/src/func.c[diff]
• third_party/sqlite/src/src/global.c[diff]
• third_party/sqlite/src/src/hash.c[diff]
• third_party/sqlite/src/src/insert.c[diff]
• third_party/sqlite/src/src/legacy.c[diff]
• third_party/sqlite/src/src/loadext.c[diff]
• third_party/sqlite/src/src/main.c[diff]
• third_party/sqlite/src/src/memdb.c[diff]
• third_party/sqlite/src/src/pager.c[diff]
• third_party/sqlite/src/src/parse.y[diff]
• third_party/sqlite/src/src/pcache1.c[diff]
• third_party/sqlite/src/src/pragma.c[diff]
• third_party/sqlite/src/src/pragma.h[diff]
• third_party/sqlite/src/src/prepare.c[diff]
• third_party/sqlite/src/src/printf.c[diff]
• third_party/sqlite/src/src/resolve.c[diff]
• third_party/sqlite/src/src/select.c[diff]
• third_party/sqlite/src/src/shell.c.in[diff]
• third_party/sqlite/src/src/sqlite.h.in[diff]
• third_party/sqlite/src/src/sqliteInt.h[diff]
• third_party/sqlite/src/src/tclsqlite.c[diff]
• third_party/sqlite/src/src/test1.c[diff]
• third_party/sqlite/src/src/test_journal.c[diff]
• third_party/sqlite/src/src/test_vfs.c[diff]
• third_party/sqlite/src/src/tokenize.c[diff]
• third_party/sqlite/src/src/treeview.c[diff]
• third_party/sqlite/src/src/trigger.c[diff]
• third_party/sqlite/src/src/update.c[diff]
• third_party/sqlite/src/src/util.c[diff]
• third_party/sqlite/src/src/vacuum.c[diff]
• third_party/sqlite/src/src/vdbe.c[diff]
• third_party/sqlite/src/src/vdbe.h[diff]
• third_party/sqlite/src/src/vdbeInt.h[diff]
• third_party/sqlite/src/src/vdbeapi.c[diff]
• third_party/sqlite/src/src/vdbeaux.c[diff]
• third_party/sqlite/src/src/vdbemem.c[diff]
• third_party/sqlite/src/src/vtab.c[diff]
• third_party/sqlite/src/src/walker.c[diff]
• third_party/sqlite/src/src/where.c[diff]
• third_party/sqlite/src/src/whereInt.h[diff]
• third_party/sqlite/src/src/wherecode.c[diff]
• third_party/sqlite/src/src/whereexpr.c[diff]
• third_party/sqlite/src/src/window.c[diff]
• third_party/sqlite/src/test/altercol.test[diff]
• third_party/sqlite/src/test/altertab.test[diff]
• third_party/sqlite/src/test/altertab2.test[diff]
• third_party/sqlite/src/test/altertab3.test[Added - diff]
• third_party/sqlite/src/test/autoindex1.test[diff]
• third_party/sqlite/src/test/bestindex3.test[diff]
• third_party/sqlite/src/test/btree02.test[diff]
• third_party/sqlite/src/test/conflict.test[diff]
• third_party/sqlite/src/test/corruptL.test[Added - diff]
• third_party/sqlite/src/test/cost.test[diff]
• third_party/sqlite/src/test/csv01.test[diff]
• third_party/sqlite/src/test/dbfuzz001.test[Added - diff]
• third_party/sqlite/src/test/dbfuzz2.c[diff]
• third_party/sqlite/src/test/e_select.test[diff]
• third_party/sqlite/src/test/eqp.test[diff]
• third_party/sqlite/src/test/fallocate.test[diff]
• third_party/sqlite/src/test/fkey8.test[diff]
• third_party/sqlite/src/test/fts3_common.tcl[diff]
• third_party/sqlite/src/test/fts3aa.test[diff]
• third_party/sqlite/src/test/fts3aux2.test[diff]
• third_party/sqlite/src/test/fts3corrupt4.test[diff]
• third_party/sqlite/src/test/fts3expr5.test[diff]
• third_party/sqlite/src/test/fts3fault.test[diff]
• third_party/sqlite/src/test/fts3fuzz001.test[Added - diff]
• third_party/sqlite/src/test/fts3snippet.test[diff]
• third_party/sqlite/src/test/fts4umlaut.test[Added - diff]
• third_party/sqlite/src/test/fuzz4.test[Added - diff]
• third_party/sqlite/src/test/fuzzcheck.c[diff]
• third_party/sqlite/src/test/fuzzdata7.db[diff]
• third_party/sqlite/src/test/fuzzdata8.db[Added - diff]
• third_party/sqlite/src/test/index6.test[diff]
• third_party/sqlite/src/test/indexexpr2.test[diff]
• third_party/sqlite/src/test/insert.test[diff]
• third_party/sqlite/src/test/insertfault.test[Added - diff]
• third_party/sqlite/src/test/join.test[diff]
• third_party/sqlite/src/test/join5.test[diff]
• third_party/sqlite/src/test/json101.test[diff]
• third_party/sqlite/src/test/lock_common.tcl[diff]
• third_party/sqlite/src/test/memdb1.test[diff]
• third_party/sqlite/src/test/misc1.test[diff]
• third_party/sqlite/src/test/misc7.test[diff]
• third_party/sqlite/src/test/normalize.test[diff]
• third_party/sqlite/src/test/ossfuzz.c[diff]
• third_party/sqlite/src/test/permutations.test[diff]
• third_party/sqlite/src/test/prefixes.test[Added - diff]
• third_party/sqlite/src/test/releasetest.tcl[diff]
• third_party/sqlite/src/test/resetdb.test[diff]
• third_party/sqlite/src/test/rowvalue4.test[diff]
• third_party/sqlite/src/test/select1.test[diff]
• third_party/sqlite/src/test/shell1.test[diff]
• third_party/sqlite/src/test/shell4.test[diff]
• third_party/sqlite/src/test/shmlock.test[Added - diff]
• third_party/sqlite/src/test/snapshot_fault.test[diff]
• third_party/sqlite/src/test/tabfunc01.test[diff]
• third_party/sqlite/src/test/tester.tcl[diff]
• third_party/sqlite/src/test/triggerC.test[diff]
• third_party/sqlite/src/test/triggerF.test[diff]
• third_party/sqlite/src/test/unionvtab.test[diff]
• third_party/sqlite/src/test/update2.test[diff]
• third_party/sqlite/src/test/vacuum-into.test[Added - diff]
• third_party/sqlite/src/test/vtabdrop.test[Added - diff]
• third_party/sqlite/src/test/wal.test[diff]
• third_party/sqlite/src/test/walfault2.test[Added - diff]
• third_party/sqlite/src/test/walvfs.test[Added - diff]
• third_party/sqlite/src/test/where7.test[diff]
• third_party/sqlite/src/test/where9.test[diff]
• third_party/sqlite/src/test/whereI.test[diff]
• third_party/sqlite/src/test/window1.test[diff]
• third_party/sqlite/src/test/with1.test[diff]
• third_party/sqlite/src/test/with3.test[diff]
• third_party/sqlite/src/test/zeroblob.test[diff]
• third_party/sqlite/src/tool/dbtotxt.c[Added - diff]
• third_party/sqlite/src/tool/dbtotxt.md[Added - diff]
• third_party/sqlite/src/tool/index_usage.c[Added - diff]
• third_party/sqlite/src/tool/lemon.c[diff]
• third_party/sqlite/src/tool/lempar.c[diff]
• third_party/sqlite/src/tool/mkpragmatab.tcl[diff]

Updating XTBs based on .GRDs from branch 3683

[email protected]

Change-Id: Ida8d3d61aed16a4d9933ea7154e32cf67b5d0de2
Reviewed-on: https://chromium-review.googlesource.com/c/1480695
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#546}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}

• chrome/android/java/strings/translations/android_chrome_strings_no.xtb[diff]
• components/policy/resources/policy_templates_pt-PT.xtb[diff]