Publish DEPS for 73.0.3683.48
Incrementing VERSION to 73.0.3683.48
[email protected]
Change-Id: Iedb79c1d85a706f8dd8a744a1e6032c7808b6385
Reviewed-on: https://chromium-review.googlesource.com/c/1480548
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#545}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Use FOS_FORCEFILESYSTEM when using IFileOpenDialog
This used to be a default option when using ::GetOpenFileName() but it
was not transferred over when upgrading to using the IFileDialog API.
Since some users liked the old behavior and it doesn't seem to have any
bad side-effects (it was used for years after all), this change ensure
that the FOS_FORCEFILESYSTEM option is used once again.
Bug: 930871
Change-Id: I6fc4669ccf13f28a8f029cd3bf10e27960e816ae
Reviewed-on: https://chromium-review.googlesource.com/c/1475889
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633290}(cherry picked from commit 9b22ed25f68c3436dd259dbf61fc119fdf405b0d)
Reviewed-on: https://chromium-review.googlesource.com/c/1479863
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#544}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}pdf: Set a default value for viewer-toolbar-dropdown.hideHeader
Without a default value, not setting an attribute results in a value of
undefined, which causes the corresponding binding to not be evaluated.
As a result the header was never shown.
Bug: 931522
Change-Id: I7dd6a716c230e8a207a7ae8b39a254d41a86cac2
Reviewed-on: https://chromium-review.googlesource.com/c/1475555
Auto-Submit: dstockwell <[email protected]>
Commit-Queue: dsinclair <[email protected]>
Reviewed-by: dsinclair <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633261}(cherry picked from commit 49b9f56aeb7f51da7715e815f74db3e764bcfb2d)
Reviewed-on: https://chromium-review.googlesource.com/c/1480294
Reviewed-by: dstockwell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#543}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "Postmortem states should not return errors until after user action."
This reverts commit 80f639d9948d8a356d9406d9fe0004e01b9d4007.
Reason for revert:
By disabling the UI in Cryptotoken, we inadvertently allowed TouchID to trigger when Cryptotoken was called. This has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1478390. Rather than merge that fix into m73 at this stage, we're opting to revert this merge and have this change be part of m74 instead.
Should be reverted along with https://chromium-review.googlesource.com/c/chromium/src/+/1473815.
Original change's description:
> Postmortem states should not return errors until after user action.
>
> Three error states (timeout, keyNotRegistered, and keyAlreadyRegistered)
> were previously considered 'postmortem' states. This meant that dialogs
> corresponding to these states would be shown after a request was finished
> and after a DOMException was sent to the RP.
>
> This CL changes those states to instead block resolution of the request
> until the user acknowledges the dialog, and then close the request.
>
> Reworded 'postmortem' references to 'awaiting user acknowledgement'
> to better reflect this behavior.
>
> Bug: 897757
> Change-Id: I04330f5a87ebbc960cd4c1e8d2c1b65fe97d9cd9
> Reviewed-on: https://chromium-review.googlesource.com/c/1428879
> Commit-Queue: Kim Paulhamus <[email protected]>
> Reviewed-by: Dmitry Gozman <[email protected]>
> Reviewed-by: Martin Kreichgauer <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#629782}(cherry picked from commit 0aa02f8093f51ad3cd22238e803839525fa23125)
> Reviewed-on: https://chromium-review.googlesource.com/c/1473972
> Reviewed-by: Kim Paulhamus <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#427}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 897757
Change-Id: I6313bd38def8b37a2538fa6a4af9f1f43b001a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1479636
Reviewed-by: Kim Paulhamus <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#542}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "[m73] fido: cancel pending authenticators while error UI is showing"
This reverts commit 6b4408bce40833688712b2e47eac98d38cde992f.
Reason for revert: Reverting a previously approved merge. Revert approved in https://bugs.chromium.org/p/chromium/issues/detail?id=897757#c17.
Original change's description:
> [m73] fido: cancel pending authenticators while error UI is showing
>
> r1428879 changed AuthenticatorImpl to not immediately resolve the request
> promise after an error occurs but wait for the UI to be dismissed first. As a
> side-effect, the FidoRequestHandler for the request handler for the request
> lives on while the UI is shown. I.e., external authenticators continue to
> accept inputs (and users can still complete the request successfully); and the
> Windows WebAuthn UI continues to be shown.
>
> This changes AuthenticatorImpl to cancel all pending authenticators immediately
> after an error has occurred. Also implements cancelling of U2F HID
> authenticators.
>
> Bug: 897757
> Change-Id: Ibd4800a3dcc5ac49b92bec0bfe13e6ca506122ba
> Reviewed-on: https://chromium-review.googlesource.com/c/1460480
> Reviewed-by: Kim Paulhamus <[email protected]>
> Commit-Queue: Martin Kreichgauer <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#630448}(cherry picked from commit 503a48173cead27c392fd28b3e1a902c503b73ea)
> Reviewed-on: https://chromium-review.googlesource.com/c/1473815
> Reviewed-by: Martin Kreichgauer <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#429}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 897757
Change-Id: I2d553adcd31f37c4c6234829d2bf47aa763b1772
Reviewed-on: https://chromium-review.googlesource.com/c/1479853
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#541}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[IndexedDB] Fixing ScopesLockManager ranges to compare correctly
Fixing the IndexedDB Lock comparison logic to use big endian numbers.
This makes them sort correctly using std::memcmp.
R=[email protected]
Bug: 924600
Change-Id: Id5629372957d2148f58b780fda060b8e16c68480
Reviewed-on: https://chromium-review.googlesource.com/c/1432876
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629317}(cherry picked from commit aa5ce7cfedc9fccd5db70849413a5a6a6845cff1)
Reviewed-on: https://chromium-review.googlesource.com/c/1479854
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#540}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Mark shadow trees for style collection update when inserted to document
When we attach shadow trees with non-empty |adoptedStyleSheets|, we
should update the active style sheet collection for that tree scope.
Otherwise, if there are no other stylesheets for that tree scope,
we will never mark the tree scope as dirty and thus have incorrect
style calculation for that tree scope.
Bug: 933578
Change-Id: Id7229b05440a51ac8e5d55570ed030b8cfb707d2
Reviewed-on: https://chromium-review.googlesource.com/c/1477623
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633666}(cherry picked from commit 5a0e3569032dae3573eb67fd5bf9ee998934df14)
Reviewed-on: https://chromium-review.googlesource.com/c/1480292
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#539}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Prevent more taps in the NTP if the underlying NTP hasn't committed.
Sometimes the underlying ios/web page used for the NTP (about://newtab)
takes a long time to load. Loading any page before the newtab is committed
will leave ios/web in a bad state. Block tapping on the omnibox until the
underlying NTP is committed.
See: crbug.com/925304 for more context. Remove this when ios/web supports
queueing multiple loads during this state.
Bug: 931306, 932662
Change-Id: Ia042ed4a3f59cd81252d2191b41f1f4feaf46f14
Reviewed-on: https://chromium-review.googlesource.com/c/1475792
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633449}(cherry picked from commit d1b69f24dd0ac61462a0c0830f3f817cdeb75a08)
Reviewed-on: https://chromium-review.googlesource.com/c/1480196
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#538}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Prevent more taps in the NTP if the underlying NTP hasn't committed.
Sometimes the underlying ios/web page used for the NTP (about://newtab)
takes a long time to load. Loading any page before the newtab is committed
will leave ios/web in a bad state. Additionally block any secondary toolbar
omnibox button taps until the underlying NTP is committed.
See: crbug.com/925304 for more context. Remove this when ios/web supports
queueing multiple loads during this state.
Bug: 931306, 932662
Change-Id: I9d45bfe0339ba6a8b49b26bdfdb98d50b6e8bb6f
Reviewed-on: https://chromium-review.googlesource.com/c/1474452
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632624}(cherry picked from commit 26e3fab0d9fb4df0321a15871c4ba1348ddc6b55)
Reviewed-on: https://chromium-review.googlesource.com/c/1479938
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#537}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Disable 'Save as HTML-only' on supervised accounts
[MERGE TO RELEASE BRANCH]
When trying to access a blocked webpage, the child user can press
Ctrl+S and save the error page (the one with the "Ask your Parent"
message).
If the child chooses to save the page as HTML-only (.html), the
downloaded source code is the one from the blocked page. The child
can then open the page locally and see the blocked content.
As a workaround, we are temporarily disabling the HTML-only download
of the blocked page for supervised users. They can still save the
page as MHTML, which works as expected.
AFTER THIS CL
Normal user (unaffected):
https://screenshot.googleplex.com/kipKMUOKA6r
Supervised user (normal page):
https://screenshot.googleplex.com/r3hQ6E1edx3
Supervised user (blocked page):
https://screenshot.googleplex.com/Jqba7rhiOf2
Bug: 928323
Change-Id: I7a82cfb9194a14070910716848228ddb1faeedff
Reviewed-on: https://chromium-review.googlesource.com/c/1460876
Commit-Queue: Felipe Cerqueira <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633691}(cherry picked from commit 7c36491294fe22b882dc17dc237eedced75b26a7)
[email protected],[email protected] # TBR for cherry-pick
Change-Id: I7a82cfb9194a14070910716848228ddb1faeedff
Reviewed-on: https://chromium-review.googlesource.com/c/1479970
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#536}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Reland "[Feed] Add pagination and ui config params."
This is a reland of aff3df13ce885fc145e8c23ea57e68e26554b763
Original change's description:
> [Feed] Add pagination and ui config params.
>
> Bug: 928772
> Change-Id: I8d939e8b6803c4d67b4cc24f19e47b695f84400e
> Reviewed-on: https://chromium-review.googlesource.com/c/1460073
> Commit-Queue: Sky Malice <[email protected]>
> Auto-Submit: Sky Malice <[email protected]>
> Reviewed-by: Gang Wu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#630384}(cherry picked from commit eb2bb5a4cde699da9a9688d26cb49304d54d84aa)
> Reviewed-on: https://chromium-review.googlesource.com/c/1473825
> Reviewed-by: Sky Malice <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#433}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
Bug: 928772
Change-Id: I7e6c358a55391c2f8e5e58078e1a4358cbedea65
Reviewed-on: https://chromium-review.googlesource.com/c/1479659
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#535}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Feed] Import feed@4cadd26bb73d8a74ec59fc6f8e7ed114d4c8e0ef
Changes for 3 issues in the Feed library (third_party/feed) are merged
to M73 in this CL:
- crbug.com/928772 - Add config USE_SECONDARY_PAGE_REQUEST.
- crbug.com/929920 - Fix ArrayIndexOutOfBoundsException crash.
- crbug.com/932237 - Clear ContentCache to save memory.
Bug: 928772, 929920, 932237
Change-Id: I914cc70ad8197b07a77a24b334c8fc13ffb1b1e7
Reviewed-on: https://chromium-review.googlesource.com/c/1479850
Reviewed-by: Pavel Yatsuk <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#534}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix scroll into view when inside a root scroller
This CL fixes the ScrollFocusedEditableIntoView method when the focused
element is inside a root scroller. This method is used to scroll an
editable input box into view on Android/ChromeOS when the user taps on
it and the virtual keyboard appears, potentially obscuring it.
The first fix is in LayoutBox::ScrollRectToVisibleRecursive. For this
use case we have a special option to avoid scrolling the layout
viewport that assumed it would always be the root LayoutView. We avoid
scrolling the layout view since ScrollFocusedEditableIntoView will
queue a smooth animation to scroll and zoom so we'd like to use that.
We still perform the ScrollRectToVisibleRecursive so that if the element
is obscured by other nested content it'll be put into view.
The second fix is in ComputeScaleAndScrollForEditableElementRects. This
method calculates how much scroll and zooming is needed. The results are
applied to the layout viewport correctly; however, the input is in
document coordinates. This means we're calculating the amount of scroll
incorrectly since the content space we care about is that of the root
scroller. If we have a root scroller, the document is guaranteed to be
unscrollable so document coordinates == frame coordinates. We can simply
adjust the coordinates by the root scroller's offset to get into the
scroller's content space.
Bug: 925245
Change-Id: I383a4a8e1a3a3c7fdd7cb894989a015a9eb25e5a
Reviewed-on: https://chromium-review.googlesource.com/c/1469071
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632377}(cherry picked from commit 591f624f187518342196be690c6b5d6efc3c0089)
Reviewed-on: https://chromium-review.googlesource.com/c/1479279
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#533}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS] Wrap long URLs on chrome://inspect page.
Long URLs can break the formatting of the chrome://inspect page, so wrap
them by breaking the URL string.
Bug: 931667
Change-Id: I0b6632cc56ca8ece0a1545ddcbf28ce3340270ff
Reviewed-on: https://chromium-review.googlesource.com/c/1476198
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Peter Lee <[email protected]>
Auto-Submit: Mike Dougherty <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633475}(cherry picked from commit 7487a10747df6ac68f25cbfbea173ea36cce961b)
Reviewed-on: https://chromium-review.googlesource.com/c/1479295
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#532}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix potential memory overrun in MapRasterCHROMIUM
ScopedTransferBufferPtr does an AllocUpTo which may return a valid
pointer to memory that is smaller than requested. MapRasterCHROMIUM
assumed that if the memory was valid then it was the size that was
requested, which is incorrect.
Bug: 917707
Change-Id: I304a52d6d98998f86ad5086ffb50abf3c048be61
Reviewed-on: https://chromium-review.googlesource.com/c/1461757
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: enne <[email protected]>
Auto-Submit: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631361}(cherry picked from commit b9e3a4fa2a0134b6ff6103f020304fcfd75ef514)
Reviewed-on: https://chromium-review.googlesource.com/c/1479292
Reviewed-by: enne <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#531}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Merge to release branch - fix for manifest not including ARCore entries
The required entries are not present in beta/stable channels.
This is a manual merge of the following commit:
f591b088d858e48666e32926cdb996315f24c142
Original CL can be found here:
https://chromium-review.googlesource.com/c/chromium/src/+/1473814
Bug: 932193
Change-Id: I634f57c3c485df2356f8281c15924cea00408462
Reviewed-on: https://chromium-review.googlesource.com/c/1477956
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#530}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix memory bloat in ThumbnailProviderImpl
It looks like an explicit destroy() method was added to BitmapCache but
it wasn't used in ThumbnailProviderImpl. This makes sure that when the
ThumbnailProvider is destroyed it frees up it's underlying cache instead
of waiting for the system to tell the application to trim/release
memory.
BUG=931438
Change-Id: Id9bc47777d84621938680a888645c152dfe16d3d
Reviewed-on: https://chromium-review.googlesource.com/c/1468803
Reviewed-by: Theresa <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631570}(cherry picked from commit 347a45f8dce4614c2f6aef43b8efa4147153ddeb)
Reviewed-on: https://chromium-review.googlesource.com/c/1478949
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#529}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}This is the cherry pick merge for the M73 branch which was approved here: http://crbug.com/933145
[Autofill Assistant] Fix tracking of element position.
Before this change, touchable areas made up of multiple elements would
suddenly shrink as the top element would leave the visible viewport.
With this change, touchable area remains stable as some elements leave
the visible viewport.
The issue was that, once elements left the visible viewport, their
position would be stripped out to 0. That interfered with the
computation visual areas.
Normal highlight:
https://screenshot.googleplex.com/Asn6PJSYwie.png
Scrolled, before change:
https://screenshot.googleplex.com/tJ1QMWogkhC.png
Scrolled, with change:
https://screenshot.googleplex.com/dG4Es8NLmUy.png
Bug: 806868
Change-Id: I40ccb61f8065964d88c9600c5d54df4a32d5ba19
Reviewed-on: https://chromium-review.googlesource.com/c/1472550
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Stephane Zermatten <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632189}(cherry picked from commit b91af7d4671d24221d168a7796ef0ac95759607e)
Reviewed-on: https://chromium-review.googlesource.com/c/1477899
Reviewed-by: Stephane Zermatten <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#528}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}This is the cherry pick merge for the M73 branch which was approved here: http://crbug.com/933146
[Autofill Assistant] Adjusted PR paddings and margins to align them with the UI.
This CL attempts to align the autofill assistant payment request sections with the rest of the UI.
Before: https://screenshot.googleplex.com/hWSmnjHFvek.png
After: https://screenshot.googleplex.com/qvVJ90qgV9C.png
Bug: 806868
Change-Id: I7f9af6963e8d4f1a0bc864d72e578cae252338a0
Reviewed-on: https://chromium-review.googlesource.com/c/1466986
Commit-Queue: Clemens Arbesser <[email protected]>
Reviewed-by: Stephane Zermatten <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631639}(cherry picked from commit bb9d2042215ec460988ec6e5cd6f2496970c76a0)
Reviewed-on: https://chromium-review.googlesource.com/c/1477898
Cr-Commit-Position: refs/branch-heads/3683@{#527}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS] Fix TabGridBottomToolbar rotation bug
TabGridBottomToolbar's layout is decided by 2 factors:
1. The selected page in TabGrid;
2. The screen size class.
If screen size class changes, TabGridBottomToolbar updates its layout
in its "traitCollectionDidChange:" delegate method. However, if TabGrid
is not displayed, the method won't get called by UIKit. But the method
"viewWillTransitionToSize:withTransitionCoordinator" of TabGrid is
always called whether it's visible or not, where the TabGrid will update
TabGridBottomToolbar.page.
This CL removes the early return in TabGridBottomToolbar.setPage, so
that it will always update its layout when the page is set, which solves
the problem of incorrect layout when screen rotates and TabGrid is
hidden.
This is a temporary fix for M73 RBS, and there are 2 options for
future plan:
1. Let UIKit fix the problem that "traitCollectionDidChange:" is not
called if UIView is hidden;
2. Turn TabGridBottomToolbar into a view controller and depends on its
"viewWillTransitionToSize:withTransitionCoordinator" to handle screen
rotations.
The option 2 is preferred since it also provides better encapsulation
for TabGrid.
Bug: 926863
Change-Id: Ibf094ba27c24770521bb923db313c1c3d7d06121
Reviewed-on: https://chromium-review.googlesource.com/c/1461833
Commit-Queue: Yi Su <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631129}(cherry picked from commit 977262e03bdaf3204e6d6f62b1a977690b5013ce)
Reviewed-on: https://chromium-review.googlesource.com/c/1477834
Reviewed-by: Yi Su <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#526}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}WebSocket: Fix cookie permissions check
Convert the URL to be checked from a WebSocket URL to an HTTP URL before
checking if cookie data from this origin can be shared with the
renderer. This is necessary because a page will never have a WebSocket
URL as its origin, but they are considered equivalent for permission
checks.
Also add a test that the Set-Cookie header is exposed to the inspector
protocol when it should be, and not otherwise.
BUG=924972
[email protected]
(cherry picked from commit e86d2b8e69c1834e2f4bd328bfbfe5ab8670496c)
Change-Id: Ic760bdec9caf1f1871ae64a57ea7fc0bf3c012ec
Reviewed-on: https://chromium-review.googlesource.com/c/1458401
Commit-Queue: Adam Rice <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631638}
Reviewed-on: https://chromium-review.googlesource.com/c/1478574
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#525}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}WebSocket: Toughen check for sending cookies to renderer
The browser includes cookie headers in those it sends to the renderer if
DevTools is open. Add a check that the renderer has access to cookie
data for that origin.
This CL only changes the non-network-service codepath. The network
service code path will changed in a followup CL.
BUG=924972
[email protected]
(cherry picked from commit 38df1661353c09b2bba3c929451249aa13d027b2)
Change-Id: Iaa9cd66ab805fa59a61b9f4ae192b4ef94c79962
Reviewed-on: https://chromium-review.googlesource.com/c/1439461
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629154}
Reviewed-on: https://chromium-review.googlesource.com/c/1478573
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#524}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix headers_text in WebSocketHandshakeResponse
In some cases |headers_text| in WebSocketHandshakeResponse would not match
|headers|. Ensure that they always match.
BUG=924972
[email protected]
(cherry picked from commit 7042886b1f9b986459336fe87916072a5afb0943)
Change-Id: I4ad2f45dd4aed4f6dc0cceb656f736e663046827
Reviewed-on: https://chromium-review.googlesource.com/c/1442350
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628266}
Reviewed-on: https://chromium-review.googlesource.com/c/1478572
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#523}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[chromite] Import chromite@00f5e172c82b771bac1139cdbfa12e100834fa5b
Needed to fix https://crbug.com/924155
$ git rev-parse origin/release-R73-11647.B
00f5e172c82b771bac1139cdbfa12e100834fa5b
$ git log d9b3a6a4..00f5e172 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 [email protected] SimpleChrome: remove lld-specific flags from gold builds
2019-01-22 [email protected] image_test: whitelist lib/firmware binaries in SymbolsTest
2019-01-25 [email protected] image_test: add PermissionTest.TestNoExecutableInFirmwareFolder
2019-02-06 [email protected] chromeos_config: Disable unittests in grunt P PFQ builder
2019-02-04 [email protected] portage_util: add yet more logging for chromeos-verison.sh failure.
2019-01-30 [email protected] repository: FetchAll -> RepairMissingRemotes.
2019-01-31 [email protected] config: Migrate asuka-release to use Skylab
2019-02-04 [email protected] BuildStore: Delete extraneous unittests
2019-01-18 [email protected] BuildStore: Redirect GetBuildStatus through BuildStore (part 2)
2019-01-28 [email protected] Fix commit_dump.json for Android branch selection
2019-01-25 [email protected] Point M73 Android PFQs at m73 branches
2019-01-25 [email protected] Reland "luci/net.py: Necessary fixes to make Buildbucketv2 calls."
2019-01-25 [email protected] Disable hwtest for ARCVM PFQ.
2019-01-25 [email protected] Revert "luci/net.py: Necessary fixes to make Buildbucketv2 calls."
2019-01-18 [email protected] luci/net.py: Necessary fixes to make Buildbucketv2 calls.
Bug: 924155
Change-Id: I31207af71fb8b1e644e08c682cbefabd056ab013
Reviewed-on: https://chromium-review.googlesource.com/c/1478454
Reviewed-by: George Burgess <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#522}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[TO 73] Roll src/third_party/ffmpeg/ 4b75b8bab..41268576a (2 commits)
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/4b75b8bab993..41268576ad9a
$ git log 4b75b8bab..41268576a --date=short --no-merges --format='%ad %ae %s'
2019-02-08 chcunningham avformat/mov.c: require tfhd to begin parsing trun
2019-02-08 chcunningham avformat/mov: validate chunk_count vs stsc_data
Created with:
roll-dep src/third_party/ffmpeg
Bug: 906384, 919573
TBR: [email protected]
Change-Id: Iaeefcddc5324bb48b3c74a0ebaae20a794266f1b
Reviewed-on: https://chromium-review.googlesource.com/c/1461682
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630604}(cherry picked from commit fddd017256d5d417d9a7359ec3724fccb3c24e45)
Reviewed-on: https://chromium-review.googlesource.com/c/1478472
Cr-Commit-Position: refs/branch-heads/3683@{#521}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}cros: ShelfView enable arrow key traversal for widget
Enable traversal for widget, this prevents breaking omnibox.
[email protected]
Bug: 925668
Change-Id: Ie3dce1ede5d431bd58f70853a0de2374114a4cc4
Reviewed-on: https://chromium-review.googlesource.com/c/1478308
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#520}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}SignedExchange: Close response body data pipe on integrity error
This fixes a bug where data pipe for response body was not closed when
Signed Exchange has payload integrity error.
SourceStreamToDataPipe::OnComplete() attempts to close the pipe by
resetting |pending_write_|. But if |source_| is a FilterSourceStream, it
still retains a reference to |pending_write_|. We should explicitly call
|pending_write_->Complete(0)| to free the pipe on error cases too.
Bug: 931955
Change-Id: I63b2470dbb92aa57016c5c71222bcdabe889fd34
Reviewed-on: https://chromium-review.googlesource.com/c/1470355
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632118}(cherry picked from commit 29c088b2b5af9090590276b5c9ed0f4bf238a2cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1477618
Reviewed-by: Kunihiko Sakamoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#519}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.47
[email protected]
Change-Id: I44a7e435aebe7017358ed83e7e3a58032ad083aa
Reviewed-on: https://chromium-review.googlesource.com/c/1478306
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#518}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android SurfaceSync: Work around throttling timing bug
Due to issues with child throttling logic, Android can easily get stuck
in a situation where we over-throttle, leading to dropped frames.
This workaround avoids this in most cases, by un-throttling not only
when a specific surface has been embedded, but also when the
immediately preceding one is embedded.
Bug: 898460
Change-Id: Iea6898dff192a85e4d1c46cce098fd37d8532967
Reviewed-on: https://chromium-review.googlesource.com/c/1476256
Auto-Submit: Eric Karl <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633347}(cherry picked from commit 0d498773e58c7a95ef7591eb23e167b24b38a359)
Reviewed-on: https://chromium-review.googlesource.com/c/1478398
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#517}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add gl_clear_broken workaround for ARM 12.0.04rel0
We've seen this on other 12.0.* drivers on Android N, so adding an
additional workaround to capture 12.0.04rel0.
[email protected]
(cherry picked from commit 76a9b39b3d0ee08e4bf22b4b1873ae6666d3e2e2)
Bug: 931527
Change-Id: I2fd2715bfeb03a3125bdd3135c6277d07660c3e2
Reviewed-on: https://chromium-review.googlesource.com/c/1475903
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Auto-Submit: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633160}
Reviewed-on: https://chromium-review.googlesource.com/c/1478265
Cr-Commit-Position: refs/branch-heads/3683@{#516}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Finish before ~Display on Android to avoid GPU hang
In certain cases, drivers hang when tearing down the Display. Finishing
before teardown appears to address this, and should have minimal impact
as we're during Display teardown so no frames are likely to be produced
soon.
We will hopefully replace this with a more targeted fix, but this
should allow us to test some theories.
[email protected]
(cherry picked from commit 18694c441a273cdff31f16dbf9aec33270abf449)
Bug: 899705
Change-Id: Ie93ee00dcb975b704dccc51ba37a6267bb2d9719
Reviewed-on: https://chromium-review.googlesource.com/c/1468681
Auto-Submit: Eric Karl <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632802}
Reviewed-on: https://chromium-review.googlesource.com/c/1478300
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#515}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Disable DriveFS by default.
Bug: 819822
Change-Id: I84722e0281f6db18a4a347fee9914fc34ebb8825
Reviewed-on: https://chromium-review.googlesource.com/c/1475560
Reviewed-by: Sergei Datsenko <[email protected]>
Commit-Queue: Sam McNally <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633023}(cherry picked from commit a077ed270f9d4b0ee266bd3cac8ce7ea7f1d408c)
Reviewed-on: https://chromium-review.googlesource.com/c/1478315
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#514}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Merge to release branch: [ios] Fix bad snapshot of Chromium pages
A recent CL caused a regression for snapshots of Chromium pages such as
"No internet" or "Site can't be reached". These pages are HTML injected
pages, and need to be snapshotted using |-drawViewHierarchyInRect:|.
Using |-renderInContext:| is buggy for WKWebView.
The previous CL removed an important check to see if the baseView is a
WKWebView, so that |-renderInContext:| is not used.
This CL brings back that check.
In the future, |kSnapshotDrawView| experiment should be turned on and
|-renderInContext:| will no longer be used for any views. Until then,
this fix is needed.
TEST=Turn on airplane mode, navigate to any page, enter/exit tab grid.
Ensure that the snapshot for the tab is free of unexpected markings.
Offending CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1395879
[email protected]
(cherry picked from commit fa9e0f0ae963c113e0dc39c942b4ca804ab21dbf)
Bug: 636188, 926837
Change-Id: Ie1eeaeb66766910456d7089a6035e0e5c0ca4147
Reviewed-on: https://chromium-review.googlesource.com/c/1476517
Reviewed-by: edchin <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633189}
Reviewed-on: https://chromium-review.googlesource.com/c/1478189
Cr-Commit-Position: refs/branch-heads/3683@{#513}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Don't show a sad tab over the NTP.
Don't layer the sad tab overlay over the NTP, since it doesn't matter of the web
process bails for about://newtab. Interestingly enough, this is a possible
outcome.
Bug: 932618
Change-Id: I9cc2afdb0e5ca6ac9de9a9e8ad91146574392e99
Reviewed-on: https://chromium-review.googlesource.com/c/1475793
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632729}(cherry picked from commit fad9d4a48fdc544c73a06c80a0d4c25c54bbbddd)
Reviewed-on: https://chromium-review.googlesource.com/c/1478260
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#512}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.46
[email protected]
Change-Id: I823228aacda94f04c063a2e5668edcee9f24b2f1
Reviewed-on: https://chromium-review.googlesource.com/c/1478290
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#511}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[DevTools] Escape '#' in request HTML previews
Bug: 930061
Change-Id: I768fa91d406f8d987fea16cb8a429e0d5119821d
Reviewed-on: https://chromium-review.googlesource.com/c/1464327
Reviewed-by: Joel Einbinder <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631380}(cherry picked from commit 19a660f847586dd64de525db4452a60c8f25c09d)
Reviewed-on: https://chromium-review.googlesource.com/c/1478086
Cr-Commit-Position: refs/branch-heads/3683@{#510}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Don't change compositor visibility when minimizing/restoring a windows window.
This broke chrome cast mirroring from a minimized browser window.
This changed in https://chromium-review.googlesource.com/c/1326621
Bug: 930429
Change-Id: I0e212da02b66eed3f4b6d64c0d37fb61f1a6e840
Reviewed-on: https://chromium-review.googlesource.com/c/1468762
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632387}(cherry picked from commit 0f7e7db01ec1f166e1c758ecd9ac812d1b28bc25)
Reviewed-on: https://chromium-review.googlesource.com/c/1477873
Reviewed-by: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#509}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] Throttle calls from task manager to ArcProcessService
ArcSharedSampler now keeps track of when the last refresh was,
and does not call ArcProcessService::RequestXXMemoryInfo more
than once every 2 seconds for apps, and 3 seconds for system
processes. This a temporary fix until we can reduce the CPU
usage of the ArcProcessService calls.
BUG= b:124694584, chromium:929359
TEST=Manually verify system_server memory usage in top
Change-Id: I002d21620d62890dd92db3116d855bc40d4d3586
Reviewed-on: https://chromium-review.googlesource.com/c/1477799
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Willie Koomson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633356}(cherry picked from commit e9c87f9f325448a1bc65810ca7b56e471248fffe)
Reviewed-on: https://chromium-review.googlesource.com/c/1478034
Reviewed-by: Elijah Taylor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#508}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge-M73] Fix display of login interstitial in popup windows
An HTTP Auth resource may trigger a blank login interstitial when the resource
meets a list of conditions. One of conditions is that the display mode of the
current web contents should not be kWebDisplayModeStandalone.
A previous CL (https://crrev.com/1323733002) changed popup windows to be
standalone windows. This caused popup windows to never show login interstitials.
This CL causes simple popup windows to no longer be treated as standalone
windows.
[email protected]
(cherry picked from commit fab7972220186b226d9b265408a3d88b0b0c95d1)
Bug: 928974
Change-Id: I7560aa268937942ad40c55afc637cae44d0a15b3
Reviewed-on: https://chromium-review.googlesource.com/c/1460404
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631433}
Reviewed-on: https://chromium-review.googlesource.com/c/1478110
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#507}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Autofill] Add dark mode Google Pay logo for Autofill suggestions
TBR=jochen
(cherry picked from commit 5f6002ace87c894d45accdbaed78a8b5549aa1bf)
Bug: 933406
Change-Id: If18e074621398ac7795523311c024821c7fb6ff1
Reviewed-on: https://chromium-review.googlesource.com/c/1468784
Reviewed-by: Fabio Tirelo <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632769}
Reviewed-on: https://chromium-review.googlesource.com/c/1477999
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#506}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix sampled-in inversion for UKM events.
There may be a follow-up CL that changes the class to have
only RandInt() accessed through a virtual method and thus remove
the non-deterministic part of the test. However, in order to merge
easily, this meat of this change is only the fix from "!=" to "=="
and a test to verify the correction.
Bug: 931710
Change-Id: Idfe0cef847148aa99b19974f29b53388d0141e2f
Reviewed-on: https://chromium-review.googlesource.com/c/1470943
Commit-Queue: Brian White <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631973}(cherry picked from commit 86b41b0b01681c710747c38e76913a128a72d7c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1478006
Reviewed-by: Brian White <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#505}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix hang in the renderer if the network process crashes while processing a cookie request.
[email protected]
(cherry picked from commit d80eb009c4f33152002dc1b18723aa6b26de95f5)
Bug: 932305
Change-Id: I3176382e360aa70944437d92bbbee7b9aa7cd0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1474838
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632725}
Reviewed-on: https://chromium-review.googlesource.com/c/1477766
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#504}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Create NetworkChangeNotifier in network process on Android
Previously, we were not creating a NetworkChangeNotifier in the network
process on Android. This change syncs the events from the browser
process to the network process using a similar mechanism to what ChromeOS
uses.
It is difficult to detect network changes directly in the network
process because some of the java side code depends on being in the
browser process. This includes dependencies on ApplicationStatus
(which only works in browser process), and requiring a thread with
a Looper, which would need to be created in the network process before
initializing the NetworkChangeNotifier, which makes startup of the
network process more complicated.
Merging to M73.
[email protected]
(cherry picked from commit fe37e8e0b6938172372670e4e71f06ef5277dcdd)
Bug: 929909
Change-Id: I67923318b7a2f911d325584711a370305826d4a3
Reviewed-on: https://chromium-review.googlesource.com/c/1469063
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Robbie McElrath <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632454}
Reviewed-on: https://chromium-review.googlesource.com/c/1477961
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#503}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix webrequest.onAuthRequired not getting fired with network service in incognito windows.
The problem was that WebRequestProxyingURLLoaderFactory::StartProxying was creating an IO thread map with the key being the incignito BrowserContext's ResourceContext. However WebRequestAPI::MaybeProxyAuthRequest was passing the parent (non-incognito)'s ResourceContext to the IO thread as the key.
[email protected]
(cherry picked from commit e958e2918e4cbb70f64dcbee6699a71cc31e9fe3)
Bug: 933138
Change-Id: I71311f22e039f645841dd5b54503876277cc3ae4
Reviewed-on: https://chromium-review.googlesource.com/c/1474648
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633166}
Reviewed-on: https://chromium-review.googlesource.com/c/1477957
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#502}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Whitelist "exception_info" crash key
Bug: 927144
Change-Id: I56fcca661e9fddafc200c19a882082235c71b01f
Reviewed-on: https://chromium-review.googlesource.com/c/1466283
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631249}(cherry picked from commit ee3aa610971981842f506cc4305b8202f88b5973)
Reviewed-on: https://chromium-review.googlesource.com/c/1477919
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#501}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}android: search arm and arm64 directories for native code
System webview fails to launch crashpad with an unsatisifed link error
because it is attempting to load 32-bit libraries in a 64-bit process.
This error only occurs with system webview on 64-bit arm devices. This
error doesn't occur when monochrome is the webview provider because
monochrome doesn't extract native libs, so the paths within the APK
are used. It doesn't occur on x86 family devices because the ABI names
match the extracted directory names.
Bug: 930342
Change-Id: Ib9a0597e277abd4fb7c8f3a5faf61a160292fe54
Reviewed-on: https://chromium-review.googlesource.com/c/1462418
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630664}(cherry picked from commit 102eb13461bc5341cbe0824165461dc19a836bcc)
Reviewed-on: https://chromium-review.googlesource.com/c/1474334
Cr-Commit-Position: refs/branch-heads/3683@{#500}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Maybe trigger LitePageRedirect previews on every redirect
Previously triggering was not being checked when the navigation's
PreviewState didn't have LITE_PAGE_REDIRECT set at the start of the
navigation.
This CL fixes the bug by including the NavigationThrottle on every
navigation and checking PreviewsState every time.
Includes bug fix in HTTPS Previews: Protect against tab_helper being
null
Bug: 931939
Change-Id: Ia147e610500ce936a5327cc4004fbd118dfbd2c6
Reviewed-on: https://chromium-review.googlesource.com/c/1473394
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632450}
Reviewed-on: https://chromium-review.googlesource.com/c/1477757
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#499}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Updating XTBs based on .GRDs from branch 3683
[email protected]
Change-Id: I089064fe555b6bd1e397c62a5b46e5766261a2c4
Reviewed-on: https://chromium-review.googlesource.com/c/1477994
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#498}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Ensure that we set a text/plain mimetype when a server delivers data with no mime_type and requested no sniffing.
[email protected]
(cherry picked from commit 496619cb4d63467f4f446fcfa1e25f9d0b70a4f0)
Bug: 932767
Change-Id: I83a1af0cd2ac1626492624dbfd6b6010fc70ca0a
Reviewed-on: https://chromium-review.googlesource.com/c/1476176
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632880}
Reviewed-on: https://chromium-review.googlesource.com/c/1477995
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#497}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Limit resource blocking hints by resource type
Add a field trial to limit resource blocking hints by
resource type. By default, resource blocking hints
would now apply to only raw resource types, Scripts and CSS.
Field trial allows us to additionally apply the
hints to images and/or other resource types.
Change-Id: I688bd228f11ddaad45e1db4976fa447c4c8fbad9
Bug: 926905
Reviewed-on: https://chromium-review.googlesource.com/c/1462138
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Doug Arnett <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632517}(cherry picked from commit 8df12b5c17d45b37b181f0985620a78d10f9339d)
Reviewed-on: https://chromium-review.googlesource.com/c/1477753
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#496}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Record metrics for 'Leave site?' dialog
The following user actions are recorded for the
'Leave site?' dialog:
- Signin_Signin_AbortAdvancedSyncSettings
- Signin_Signin_CancelAbortAdvancedSyncSettings
[email protected]
(cherry picked from commit 8a830ce8b8206cbfc635faadb90b4fe098bdcca2)
Bug: 931384
Change-Id: Ic8fe10bfbb20fb41f2d3524375a2913d744e491e
Reviewed-on: https://chromium-review.googlesource.com/c/1477073
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633087}
Reviewed-on: https://chromium-review.googlesource.com/c/1477857
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#495}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Merge M73: "Fix race with SwitchOutputDevice() and GetOutputDeviceInfoAsync()."
AudioRendererMixerInput wasn't expecting SwitchOutputDevice() to
occur before AudioRenderer initialization completes. When there's
a pending GODIA() call, a SOD() before that completes can kick us
onto the fake audio rendering path by aborting the GODIA() call.
The fix is to defer SOD() calls until we've completed GODIA() and
likewise defer GODIA() calls until we've completed SOD(). In the
event a SOD() call fails, the normal GODIA() process will kick
off using the old device_id.
I've also added some code to short circuit device changes when
switching to the "default" device, since internally we allow both
the empty string and the string "default".
BUG=930876
TEST=https://jsfiddle.net/2xng9bjr/1/ and new unittests.
R=chcunningham
Change-Id: I6db477660a0b936dda3a60e916ea7778bd7e7397
Reviewed-on: https://chromium-review.googlesource.com/c/1467911
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Auto-Submit: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631524}(cherry picked from commit 0249229a4a099db2e373c2cf93dc20688a5ac827)
Reviewed-on: https://chromium-review.googlesource.com/c/1477992
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#494}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Track eglMakeCurrent failure in GLContextEGL::ReleaseCurrent
Under lost device conditions, eglMakeCurrent can fail, even when releasing
the context. As we otherwise assume that we have correct bindings when
GLContext::IsCurrent returns true, we need to track the lost state to
ensure that after ReleaseCurrent, IsCurrent will return false.
Bug: 928693
Change-Id: I5bbf2616f872532c03da1e1beeade5c94d920b92
Reviewed-on: https://chromium-review.googlesource.com/c/1457675
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Auto-Submit: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629879}(cherry picked from commit c32e3445498b46fc68ee838bfbf6aa43f064c484)
Reviewed-on: https://chromium-review.googlesource.com/c/1477991
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#493}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Do not show the previews icon on broken HTTPS pages
This was in the original UX spec and I missed it :(
It caused the bug below since the VerboseStatusView does respect the
security level, but this did not.
On a side note, I've filed a bug for M74 to not allow previews on
broken HTTPS pages in the first place.
Bug: 929412
Change-Id: If9ad72584de62e6a51e4a6e676255d5e394ba9c3
Reviewed-on: https://chromium-review.googlesource.com/c/1474382
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632653}(cherry picked from commit 614019ada238cb6be8ed2f076bf1ad49762104fa)
Reviewed-on: https://chromium-review.googlesource.com/c/1477990
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#492}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Use the Previews Icon for the HTTPS Notification Infobar
Bug: 932350
Change-Id: Idf2dbca27379389212277cfc20543b9b387440b9
Reviewed-on: https://chromium-review.googlesource.com/c/1475196
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632663}(cherry picked from commit 60a0a0cce2145d58465ac4ffceb1294af7522205)
Reviewed-on: https://chromium-review.googlesource.com/c/1477950
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#491}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add PipeWire to the CFI blacklist
Add the WebRTC's PipeWire sources to the CFI blacklist as well as the SPA
(PipeWire sublibrary) includes. Without these blacklist entries any call
to the PipeWire will end with SIGILL crash similar to:
/usr/include/spa/param/format-utils.h:50:17: runtime error:
control flow integrity check for type 'unsigned int (struct spa_type_map
*, const char *)' failed during indirect function call
The cause is that the -fsanitize=cfi doesn't work when calling into functions
of a dlopen'ed shared library file without using -fsanitize-cfi-cross-dso or
adding the entries to the CFI blacklist.
Bug: 926115
Change-Id: Ied4d489b3e5b1bee5dfd0374417ab8cd40dcdbd6
Reviewed-on: https://chromium-review.googlesource.com/c/1466402
Reviewed-by: Peter Collingbourne <[email protected]>
Commit-Queue: Tomáš Popela <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632100}(cherry picked from commit 16d308d5a1c48842087592e53a631e2e5b3ce7cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1475430
Cr-Commit-Position: refs/branch-heads/3683@{#490}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Update Autofill card migration dialog to match Mac dark mode
1. Update tip message background color, the lightbulb color and remove
border in dark mode
2. Update uncheck text message background
3. Add a new header image
For patchset 9, also:
1. Update title color
2. Update checkmark and error icon color
3. Update tip message text color
Upload implementation screenshot in crbug.com/925993 comment #20
Bug: 932872
Change-Id: Ie5549029b19bf002e6a7470938dc465471123fee
Reviewed-on: https://chromium-review.googlesource.com/c/1468343
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632156}(cherry picked from commit 114eafa55f93c3b9119f54ba3899f51569f71def)
Reviewed-on: https://chromium-review.googlesource.com/c/1477930
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#489}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Show 'Leave site' dialog on close/reload
When the user tries to close the tab, reload the page or
navigate to a new URL during the sync opt-in flow,
the 'Leave site' dialog is shown.
Bug: 931384
Change-Id: I83f8f7233a48df55542d97d10f4a7401bf4711d0
Reviewed-on: https://chromium-review.googlesource.com/c/1470701
Reviewed-by: Dan Beam <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632950}(cherry picked from commit a85abf7dcb3da4bbb71877daec9b1aca7a4248c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1477893
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#488}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[E2ELatency] Fix E2E Latency measurement for FCM Invalidations
[email protected]
(cherry picked from commit e3916cbb576d77be2e25649fb1a8651dbf1a1b57)
Bug: 930703
Change-Id: I17d03d1fde4eef3f37f18c9c522414aa712be581
Reviewed-on: https://chromium-review.googlesource.com/c/1463359
Commit-Queue: Tatiana Gornak <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631213}
Reviewed-on: https://chromium-review.googlesource.com/c/1477855
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#487}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73]Ignore navigation in pending deletion frame triggered from proxy.
This is similar to:
* [common navigations]
(https://chromium-review.googlesource.com/c/chromium/src/+/1450256)
* [history navigations]
(https://chromium-review.googlesource.com/c/chromium/src/+/1462983)
* [same-document navigations]
(https://chromium-review.googlesource.com/c/chromium/src/+/1461023)
This one is about a navigation initiated using window.open to a frame in
a different process.
This patch is intented to be merged into M73.
(cherry picked from commit b3a21188281259f69c9fca92f552fa45fdd02feb)
Bug: 932087
Change-Id: Ie3a89e3e347d80aec40c9c5f45e086aa13e04a10
Reviewed-on: https://chromium-review.googlesource.com/c/1472624
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633107}
Reviewed-on: https://chromium-review.googlesource.com/c/1477119
Reviewed-by: Abdul Syed <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#486}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix incorrect translation of BottomBar when it's added
The bug was introduced by the following change:
https://chromium-review.googlesource.com/c/chromium/src/+/1404391
ChromeFullscreenManager#getBottomControlsOffset used
mControlsOffsetRatio before the change, and now it uses
mRendererBottomControlOffset.
This yield different results when called from
CustomTabBottomBarDelegate#onBottomControlsHeightChanged when bottom
bar is added: the mControlsOffsetRatio is 1.0 while non-zero bottom
controls offset had never been received at this point.
This CL restores old behavior of
CustomTabBottomBarDelegate#onBottomControlsHeightChanged.
Bug: 928903
Change-Id: I48903d95a72a932e22e3a8a8ffd5a5f7068faf4f
Reviewed-on: https://chromium-review.googlesource.com/c/1454927
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Auto-Submit: Pavel Shmakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629509}(cherry picked from commit e2c2cde451f968f2707c070bcb487ca5153b829b)
Reviewed-on: https://chromium-review.googlesource.com/c/1477892
Reviewed-by: Pavel Shmakov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#485}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Global Media Controls] Add metrics for focused vs unfocused control
This CL adds a new metric to track the focused state of WebContents
whose MediaSessionImpls receive user actions. This will allow us to
check how hardware media key handling affects users' ability to
control unfocused media.
[email protected]
(cherry picked from commit ee0d1da3c693110f71dd8988d037317c1c442c6e)
Bug: 930772
Change-Id: I3380348c9f0198d8caefed21ba4c545d5ec22af0
Reviewed-on: https://chromium-review.googlesource.com/c/1468600
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632228}
Reviewed-on: https://chromium-review.googlesource.com/c/1477780
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#484}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Tracing: Disable for processes without a TaskScheduler.
Tracing now gets enabled for all child processes as a
feature of the service_manager clientlib, and requires
a running TaskScheduler. There's processes that utilize
the service_manager clientlib without using a TaskScheduler,
like the nacl_loader which never got traced before and currently
can crash if tracing gets started; we now just exclude them
from tracing.
Bug: 925303
Change-Id: I890754b52e2416f951218e682fb8cde69732572c
Reviewed-on: https://chromium-review.googlesource.com/c/1460109
Reviewed-by: ssid <[email protected]>
Commit-Queue: oysteine <[email protected]>
Auto-Submit: oysteine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630985}(cherry picked from commit e644c4588ba1c8d058aa2370eacef1ba88360f29)
Reviewed-on: https://chromium-review.googlesource.com/c/1470740
Reviewed-by: oysteine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#483}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Disable Sync Passphrase options on supervised accounts
[MERGE TO RELEASE BRANCH]
Because Sync is required for supervision, supervised users shouldn't
be allowed to set a passphrase, so we disable the feature in the UI.
In addition, we hide the link to the Sync Dashboard, which is also
not accessible to supervised users.
Small fix: There's a transient state during start-up where the
the syncStatus variable is undefined. Fixed the SyncSetupCancel
UnifiedConsentDisabled test to account for that.
AFTER THIS CL (supervised user):
https://screenshot.googleplex.com/6rOLkCTetka
Bug: 924847
Change-Id: I89cb27597ce3ef6af295e98e308cb16b4a7354b5
Reviewed-on: https://chromium-review.googlesource.com/c/1449932
Commit-Queue: Felipe Cerqueira <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Henrique Grandinetti <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633108}(cherry picked from commit 37d2d04cbee95ac970786b33b500234915cfce74)
Reviewed-on: https://chromium-review.googlesource.com/c/1477813
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#482}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Sync UI: Don't allow setting a passphrase if !EncryptEverythingAllowed
[MERGE TO RELEASE BRANCH]
If EncryptEverythingAllowed() was false, then PeopleHandler already
skipped the call to EnableEncryptEverything(), but it did still call
SetEncryptionPassphrase(). That could get users into a weird state
where Sync stopped working.
This CL fixes the issue by also skipping the SetEncryptionPassphrase()
call in case EncryptEverythingAllowed() is false.
Bug: 924847
Change-Id: I3b606e3ea9d0a8f86b865b41eda233dd472cc1eb
Reviewed-on: https://chromium-review.googlesource.com/c/1439299
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627004}(cherry picked from commit 347c098c377ac412abd586ea2898e86b53c7a664)
Reviewed-on: https://chromium-review.googlesource.com/c/1477812
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#481}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS][MF][A11y] Fix iPad's keyboard Voice Over
|accessibilityViewIsModal| is not required on iPad since the view is not
above any keyboard view, and it is causing problems since the keyboard
view is a sibbling of it.
Bug: 932461
Change-Id: Ie1865460609da8b51705f10e7967ff47320d4ddf
Reviewed-on: https://chromium-review.googlesource.com/c/1475455
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632625}(cherry picked from commit 515c1251aca203e4afba53aa5a1182ab88b304f4)
Reviewed-on: https://chromium-review.googlesource.com/c/1477705
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#480}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[AW] Fix expiration date for the ShouldInterceptRequest.InterceptionType histogram
MERGE to M73
That histogram shows as expired now due to a typo in the expiration year,
this patch fixes the expiration date, so that the histogram data is
actually recorded.
BUG=841556,929788
[email protected],[email protected]
NOTRY=true
Change-Id: I727047305aca5a360a7e673b76aab31425fefe50
Reviewed-on: https://chromium-review.googlesource.com/c/1477597
Reviewed-by: Tim Volodine <[email protected]>
Commit-Queue: Tim Volodine <[email protected]>
Auto-Submit: Tim Volodine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#633242}(cherry picked from commit 1eeda56cdd207e0d0bba49745f1aa3441c8f4baf)
Reviewed-on: https://chromium-review.googlesource.com/c/1477268
Cr-Commit-Position: refs/branch-heads/3683@{#479}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}service worker: Limit the size of instrumentation log in ServiceWorkerContextClient
It could be very large and could be a source of out-of-memory.
Bug: 907311
Change-Id: I2fd3d00a0b9046ba1fe4d102204b5605dc35e49e
Reviewed-on: https://chromium-review.googlesource.com/c/1448000
Auto-Submit: Kenichi Ishibashi <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628240}(cherry picked from commit a1ca8df052b30de42c2657bd6cd260df3b67ad4f)
Reviewed-on: https://chromium-review.googlesource.com/c/1477137
Reviewed-by: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#478}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.45
[email protected]
Change-Id: Ief3aeb1b8fb513b333914ed65b09c41ba67f7288
Reviewed-on: https://chromium-review.googlesource.com/c/1476980
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#477}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] Fix crash for crOS Account Manager in Multi-Signin mode
ARC (and ArcAuthService) is not available for Secondary Profiles
participating in Multi-Signin. Skip ARC account migrations for those
Profiles. It will be retried when that Profile logs in as the Primary
Profile.
Bug: 929488
Change-Id: I6d5a6c85d78715b11c6c9f3bdc8fd55705c0870f
Reviewed-on: https://chromium-review.googlesource.com/c/1463561
Commit-Queue: Kush Sinha <[email protected]>
Reviewed-by: Lutz Justen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631657}(cherry picked from commit 8f6457744bfc0eedc66f20e65c9561f6a87ab3d3)
Reviewed-on: https://chromium-review.googlesource.com/c/1477064
Reviewed-by: Kush Sinha <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#476}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[signin] HTTP Proxy Authentication Required (407) treated as transient
[email protected]
(cherry picked from commit 96c01fe25d536bf646c6ff4621082572a9eb5d39)
Bug: 914672
Change-Id: Id35c53ad72f326ff6193cedad8022e175428ceb7
Reviewed-on: https://chromium-review.googlesource.com/c/1454521
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631206}
Reviewed-on: https://chromium-review.googlesource.com/c/1474939
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#475}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.44
[email protected]
Change-Id: Ia75006f77a8eaf0b2370a0ab52db7bb5a2d4b67e
Reviewed-on: https://chromium-review.googlesource.com/c/1476543
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#474}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Mac PWAs: Hide title bar when in HTML fullscreen mode
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=379141&signed_aid=XEdXybBj6M-C-Ta_Rx9_kQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=379142&signed_aid=9qfLtvxWFXJprh_Slbb6jA==&inline=1
Bug: 931031
Change-Id: I2cf4e2da26b0563018d1be6e010e832482454c3a
Reviewed-on: https://chromium-review.googlesource.com/c/1466161
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631711}(cherry picked from commit 0dcd2c9276f70659b548ab5e2d83130b8ac5649a)
Reviewed-on: https://chromium-review.googlesource.com/c/1475557
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#473}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.43
[email protected]
Change-Id: I5e3d92e7b0107318d3a51e1058aaf4ec0bde2863
Reviewed-on: https://chromium-review.googlesource.com/c/1476534
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#472}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Keep processes with service workers controlling clients at foreground priority.
A service worker may live in a process with no visible windows or no
windows at all. Normally the browser will consider these processes to
be in the background and lower their scheduling priority. The service
worker, however, may be controlling windows in other processes that are
visible. The service worker needs to be able to respond to FetchEvents
in a timely manner to keep ensure those other visible windows load
quickly.
Therefore, this CL adds an experiment to avoid backgrounding processes
with "active" service workers. Currently "active" means service workers
with at least one controlled client. This could keep more processes at
foreground priority than is strictly necessary, but the impact should be
limited since service workers will timeout and shut themselves down after
an idle period.
In the future we could enhance this mechanism by restricting it to service
workers controlling visible clients or clients known to be in other processes.
[email protected]
(cherry picked from commit f4fc4ce06a25918319082c8ef7e123e50e79c2c5)
Bug: 928904
Change-Id: I0945b0a8b4431535a3cd87bfc0d45aa48517eaa0
Reviewed-on: https://chromium-review.googlesource.com/c/1457196
Commit-Queue: Ben Kelly <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631252}
Reviewed-on: https://chromium-review.googlesource.com/c/1474038
Reviewed-by: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#471}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Cherry-pick "[iOS] Defend against nil WebState instead of DCHECKing."
The crash fixed in crrev.com/c/1448686 occurs in a different place, so
this fix can't be cherry-picked directly.
Bug: 925757
Change-Id: Id47321d2555605e1c1634080c7601b4d0f0b969d
Reviewed-on: https://chromium-review.googlesource.com/c/1476240
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#470}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Migrate Drive download paths to DriveFS when enabled.
Since policy can force the default downloads path to /special/drive-...,
also apply the migration when retrieving the default downloads path from
DownloadPrefs and support both Drive path styles in path rewriting for
the settings UI when DriveFS is enabled.
Bug: 931469
Change-Id: Id53507b68376c5bb6b43ec47ed4f5d7810f8bc9f
Reviewed-on: https://chromium-review.googlesource.com/c/1470351
Auto-Submit: Sam McNally <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632126}(cherry picked from commit 2450a7d343a7edb3e5f08e75d790099414a6baf9)
Reviewed-on: https://chromium-review.googlesource.com/c/1474955
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#469}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.42
[email protected]
Change-Id: I40cc03d09f402f6da2a6969e2b3cc744b250f224
Reviewed-on: https://chromium-review.googlesource.com/c/1476237
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#468}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Autofill] Add dark mode Google Pay logo for card upload/unmask
Bug: 924021
Change-Id: I6c2cad595bf0b16d29d229f8805306b8af179a60
Reviewed-on: https://chromium-review.googlesource.com/c/1468781
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631816}(cherry picked from commit cdf0f5ae32b06df9c7edd817690586050e4138cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1475911
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#467}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Propagate user activation state to RenderFrameHost clients.
UserActivationV2 calculates effective_transient_activation_state before
calling CanCreateWindow.
But it propagates params->mimic_user_gesture to clients, but it is not
valid value for user_gesture. This invalid value can confuse clients,
for example WebChromeClient#onCreateWindow webview api call.
R=[email protected]
Bug: 927254
Change-Id: I900a8f7f91a21f29bd54e3e8e0c74c41dfdd47fc
Reviewed-on: https://chromium-review.googlesource.com/c/1449392
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630912}(cherry picked from commit 32257a2574d134b80887790b16dec751eb86d50f)
Reviewed-on: https://chromium-review.googlesource.com/c/1474980
Cr-Commit-Position: refs/branch-heads/3683@{#466}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Prevent more taps in the NTP if the underlying NTP hasn't committed.
Sometimes the underlying ios/web page used for the NTP (about://newtab)
takes a long time to load. Loading any page before the newtab is committed
will leave ios/web in a bad state. Additionally block any most visited
action, the fake omnibox and voice search until the underlying NTP is committed.
See: crbug.com/925304 for more context. Remove this when ios/web supports
queueing multiple loads during this state.
Bug: 931306
Change-Id: Iff2c11eadaeed60407879d51b5b2577e606c8a18
Reviewed-on: https://chromium-review.googlesource.com/c/1464174
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631376}(cherry picked from commit 294dcbd8e808c97e258be614caa5663795e052a7)
Reviewed-on: https://chromium-review.googlesource.com/c/1475806
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#465}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}DevTools: persist tab order relatively to the untouched panels as well.
[email protected]
(cherry picked from commit 131f81dfc1d2cdfdfa3976cc851680bb445f206c)
Bug: 930212
Change-Id: I99100d4fd6fd952f29763de8b33ce277a85ffb58
Reviewed-on: https://chromium-review.googlesource.com/c/1471258
Reviewed-by: Alexei Filippov <[email protected]>
Commit-Queue: Alexei Filippov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631971}
Reviewed-on: https://chromium-review.googlesource.com/c/1475804
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#464}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix crash in ServiceWorkerNewScriptLoader::ResumeReadingBodyFromNet
It looks like the network_loader_ gets reset in CommitCompleted(), but
the binding may still send messages after that since this was bound with
mojo::MakeStrongBinding. The class will only be deleted after the remote
endpoint sees the connection closed, so it can send messages before
that.
Bug: 916098
Change-Id: I772ca9f03e4f9d5354278b8d36e73dff92195cda
Reviewed-on: https://chromium-review.googlesource.com/c/1473402
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632426}(cherry picked from commit bc4ba2e4032d25da85a94ce642731a249d753640)
Reviewed-on: https://chromium-review.googlesource.com/c/1475798
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#463}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix network service crash when --log-net-log flag isn't valid
Bug: 931502
Change-Id: I081a32b007d9dad40007b04821548df9ae5c3619
Reviewed-on: https://chromium-review.googlesource.com/c/1471022
Commit-Queue: Robbie McElrath <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631997}(cherry picked from commit 2ebfa978f4624099eef63ba5df39c828b8a68a9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1471455
Reviewed-by: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#462}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}mac: Fix multi-video flickering
Note the two following conditions:
1. The contents of an AVSampleBufferDisplayLayer will not necessarily
update in sync with the rest of the CALayer tree. This is because
its contents are updated using -[AVSampleBufferDisplayLayer
enqueueSampleBuffer:], not -[CALayer setContents:]. The latter will
respect the current CATransaction, the former, by design, does not.
2. When constructing the CALayer tree, it is not known for certain
from what cc::Layer or from what video stream a given CALayer
is getting its contents. There will be times when the CALayer tree
gets jumbled, and one/some/many CALayers re-use a CALayer that is
from completely different content. (Ordinarily we want to re-use
the CALayer corresponding to the same layer or tile as the previous
frame).
The jumbling in 2 above is an efficiency but not correctness issue
because tree updates are atomic. If we mis-match CALayers, then we'll
just update more state in more CALayers than perhaps we otherwise
could.
Except that because of 1 above, it is a correctness issue, because tree
updates are only mostly atomic.
Work around this by only using AVSampleBufferDisplayLayer if there is
exactly one single video element on screen. I would think this to be
the common case, but in the absence of UMAs for this, I can't say for
certain.
A more suitable long-term fix to this and to many other problems is to
actually plumb the layer (and quad) id down to the CALayer tree.
[email protected]
(cherry picked from commit c018409a74ebde7dc9919049e4c5fdd51bc4c8a5)
Bug: 923427
Change-Id: Idbc9068d9abce82aa78286874effdb7f776cde43
Reviewed-on: https://chromium-review.googlesource.com/c/1469643
Commit-Queue: ccameron <[email protected]>
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631813}
Reviewed-on: https://chromium-review.googlesource.com/c/1475794
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#461}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Don't scramble authenticator mojo message IDs.
They will be used in external tests.
Change-Id: I2fc4f2c6b9563775d4698dff2a1f2eab2153f2e0
Reviewed-on: https://chromium-review.googlesource.com/c/1465069
Commit-Queue: Kim Paulhamus <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631341}(cherry picked from commit f4ca0513087b083d9bc35a6201e98e898a005b63)
Reviewed-on: https://chromium-review.googlesource.com/c/1475818
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#460}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Navi: Use REM instead of PX to allow scaling the chooser with font.
Screenshot in bug.
Bug: 930650
Change-Id: I2a0e791832b902e43b874e8bae479afc15524141
Reviewed-on: https://chromium-review.googlesource.com/c/1467671
Commit-Queue: Hector Carmona <[email protected]>
Reviewed-by: Esmael El-Moslimany <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631826}(cherry picked from commit 58bc28bbb45402bd0b4cb1c083ccde7c9f62f820)
Reviewed-on: https://chromium-review.googlesource.com/c/1475817
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#459}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Navi: Fix 'Next' button styling for RTL languages.
Screenshot in bug.
Bug: 929609
Change-Id: I49e74bb8c02f503d1c91476ceee3d5262565cfa0
Reviewed-on: https://chromium-review.googlesource.com/c/1461690
Commit-Queue: Hector Carmona <[email protected]>
Reviewed-by: Esmael El-Moslimany <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631806}(cherry picked from commit 968db940f2b5dfd978b5d53ba5a0187777c1845d)
Reviewed-on: https://chromium-review.googlesource.com/c/1475816
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#458}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Remove background highlight from incognito badge
This change also adds AddedToWidget() to make sure the text colors are
set correctly. This override is already available and tested on trunk.
Bug: chromium:930833, chromium:931417
Change-Id: Ib110d5291477f7ae45e474539dfdba932e6a3cac
Reviewed-on: https://chromium-review.googlesource.com/c/1471212
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631917}(cherry picked from commit a89b8b27f5111db6e0527c17035caff2ba70d5f3)
Reviewed-on: https://chromium-review.googlesource.com/c/1471510
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#457}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[omnibox] Prevent re-addition of ellipsis to tail suggestions
Merged from 74.
The autocomplete code could re-apply the tail suggest ellipsis to a
set of suggestions. This change prevents the subsequent additions to
suggestions which already have it.
[email protected]
(cherry picked from commit dbb20f4749bc991d46ca66fe6f39c21bfab86b9b)
Bug: 931245
Change-Id: Id8e9309407a2f477ed57080bb6f6b2fd0b554348
Reviewed-on: https://chromium-review.googlesource.com/c/1466153
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Kevin Bailey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631526}
Reviewed-on: https://chromium-review.googlesource.com/c/1475633
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#456}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS] Fixed omnibox state being corrupted after presenting js alert
This CL fixes a bug where the omnibox state would be incorrect after
presenting a javascript alert in the middle of opening a new tab.
The root cause is that the omnibox focus methods are called in the
middle of a previous animation, so they were ignored. To fix this, we
store the expected final state of the omnibox, and set the state to that
after the animations finish.
Bug: 921390
Change-Id: Ibd4e8e857621344e4397153400e6dc4b43617c5c
Reviewed-on: https://chromium-review.googlesource.com/c/1434285
Commit-Queue: Robbie Gibson <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626618}(cherry picked from commit df5b958678c91506562ccea5088ebefe473fc785)
Reviewed-on: https://chromium-review.googlesource.com/c/1475435
Cr-Commit-Position: refs/branch-heads/3683@{#455}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[trusted types] Fix spurious crash when calling createHTML.
[email protected]
(cherry picked from commit a706124d1444e76d798090e5a776b1a88b6567cc)
Bug: 929601, 739170
Change-Id: Id70c05906fcb9d0d836641992b4d2d9f1c26b65f
Reviewed-on: https://chromium-review.googlesource.com/c/1458179
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Daniel Vogelheim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630261}
Reviewed-on: https://chromium-review.googlesource.com/c/1474659
Reviewed-by: Daniel Vogelheim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#454}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Record Signin_Signin_BackOnAdvancedSyncSettings
Bug: 922606
Change-Id: Ib0865fd8fcf40bb1240c5659fa4d4006666d69ec
Reviewed-on: https://chromium-review.googlesource.com/c/1470185
Reviewed-by: Hector Carmona <[email protected]>
Reviewed-by: Brian White <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632217}(cherry picked from commit d6918513107adad9beb8cebe0ddd65813a20b3a8)
Reviewed-on: https://chromium-review.googlesource.com/c/1475177
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#453}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Web MIDI: Make TaskService and MidiManagerWin integer-overflow-proof
TaskService and MidiManagerWin uses int to identify the instance,
but this change makes it int64_t and improve them to fail gracefully
without shutting-down the browser due to CHECK failures.
For practical use, the original int is enough and it's impossible
to overflow the instance ID unless attackers success to run their code
for several months on an occupied active processor.
[email protected]
(cherry picked from commit c3fe3dc27d10a53a54bb5231b6fce07318af952f)
Bug: 921581
Change-Id: I62c7cd737ab3d3969e372bb394e60381473eaa58
Reviewed-on: https://chromium-review.googlesource.com/c/1449483
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631175}
Reviewed-on: https://chromium-review.googlesource.com/c/1474888
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#452}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS][MF] Return when the keyboard is not found
Bug: 918522
Change-Id: I125e8d3477fa52b980b8d38a65a5a2360da425b7
Reviewed-on: https://chromium-review.googlesource.com/c/1461677
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630597}(cherry picked from commit e2a33966d669909e716bc8aa49f46cd16d5df22a)
Reviewed-on: https://chromium-review.googlesource.com/c/1474651
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#451}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS][MF] Fix incognito mode
Enables manual fallback in incognito by getting the original browser
state.
Fixes the double input view by resetting the reference to the view
when the keyboard hides on iPad.
Reverts: https://chromium.googlesource.com/chromium/src.git/+/15f7cf85bc1fb76e51e58cea68e6fc183aa5fbde
Bug: 923857, 923857, 905720
Change-Id: I253c4b25650cf6be184c59caa7285dc1ecdc8900
Reviewed-on: https://chromium-review.googlesource.com/c/1461080
Auto-Submit: Javier Ernesto Flores Robles <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Commit-Queue: edchin <[email protected]>
Reviewed-by: edchin <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630505}(cherry picked from commit 33c7e66efd47f8b36bba805ef5cab662d8eaa6bc)
Reviewed-on: https://chromium-review.googlesource.com/c/1475450
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#450}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.41
[email protected]
Change-Id: I333385f0eaf8a9ae7fde55754304a5c1122b30c6
Reviewed-on: https://chromium-review.googlesource.com/c/1474846
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#449}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Updating XTBs based on .GRDs from branch 3683
[email protected]
Change-Id: I8360c24d0a42ab270fa040e8a8af00dd0f904023
Reviewed-on: https://chromium-review.googlesource.com/c/1473844
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#448}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Print Preview: Fix destinations autoselect (M73)
Don't start the autoSelect if we have already selected a destination,
since the timeout is meant to be cleared in selectDestination.
(cherry picked from commit 230bb53ce8f32dad8472d6d2480eabb65c596008)
Bug: 927162
Change-Id: I1d953f71c4c4eb332523d749b41aad2262abfc32
Reviewed-on: https://chromium-review.googlesource.com/c/1441792
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628099}
Reviewed-on: https://chromium-review.googlesource.com/c/1471635
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#447}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[media] Add histograms to track CORS status of HLS manifests.
When converting pages to use an MSE-based player, only requests that
would not have opaque fetch() responses can be supported. These
histograms will help understand the risk of such a requirement.
Bug: 932298
Change-Id: I141202ec2ea07a35b67bbc9c8782a22662a1bb22
Reviewed-on: https://chromium-review.googlesource.com/c/1450442
Commit-Queue: Dan Sanders <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628962}(cherry picked from commit d80b184e521adb5ddbed93333ee130d841e8852c)
Reviewed-on: https://chromium-review.googlesource.com/c/1474972
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#446}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[iOS] Mitigate timing issues with Safe Browsing test.
Bug: 931826, 916806
Change-Id: Id48042e7f7c567e3174d9afa6f9fc09b2b85ae31
Reviewed-on: https://chromium-review.googlesource.com/c/1470717
Reviewed-by: Peter Lee <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Peter Lee <[email protected]>
Auto-Submit: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#632002}(cherry picked from commit ef54bb1eea2d6ec3e793579bc1bef8ff085cb68c)
Reviewed-on: https://chromium-review.googlesource.com/c/1474792
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#445}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 merge] assistant: fix demo mode oobe
We should not show oobe in demo mode. This patch fixes this bug.
[email protected]
Bug: 931534
Test: manual
Change-Id: Ie2e07dd027fe9866a203bd53b62aeb6b2b3c13bd
Reviewed-on: https://chromium-review.googlesource.com/c/1469653
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631807}(cherry picked from commit 11f6e7260c6c40a52af232d2482ff8b88e8205e5)
Reviewed-on: https://chromium-review.googlesource.com/c/1474490
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#444}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}SuperSize: Add --minimal-apks-file for measuring app bundles.
For this change, SuperSize is just measuring base-master.apk
We may want to have it measure more things in the future
(e.g. maybe pick another locale to include, or create symbols
for DFMs)
Other changes:
* Change -f to auto-detect .minimal.apks, and make it just
sniff based on file name rather than using "file".
Bug: 873714
Change-Id: I82331b1feb5897242a3144bb4bd62e3f3f4248b9
Reviewed-on: https://chromium-review.googlesource.com/c/1465684
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Samuel Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631365}(cherry picked from commit ce22e64eca2ddec32f5c448d0530da0d35a0241c)
Reviewed-on: https://chromium-review.googlesource.com/c/1474593
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#443}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android: Create size-info files for bundles
These files are needed by SuperSize to do binary size analysis.
Refactors logic for creating these apkbuilder->separated action
so that it can be used by both apks and aabs.
Tested that .info files produces by the modern .aab and .apk are
about the same size.
Bug: 873714
Change-Id: Icbe8aee1f05da29d787c92a9697f2b1b719f7f42
Reviewed-on: https://chromium-review.googlesource.com/c/1461349
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630803}(cherry picked from commit b838d837d6d6fa9610ab7c8b1176c2e67934ace1)
Reviewed-on: https://chromium-review.googlesource.com/c/1474592
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#442}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android: Fix ninja not noticing when signing keys change
When changing GN arg "use_signing_keys", rebuilding would not result in
a resigned apk.
Change fixes this by removing use of md5_check. Using md5_check is
generally only advantageous when one or more inputs are from outside
of the out/ directory, and thus can change when checkout out different
branches. Inputs to apkbuilder.py are entirely from within the out/
directory (except for the script itself, which doesn't change much).
Change-Id: Ic93d559cc2fffb2fabe8af7152038be76f1e71c0
Reviewed-on: https://chromium-review.googlesource.com/c/1435677
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Auto-Submit: Andrew Grieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626134}(cherry picked from commit 0c0c8e12df27006b00a997e9848ebd8e332235bc)
Reviewed-on: https://chromium-review.googlesource.com/c/1474591
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#441}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android: Write .jar.info files for bundle targets
These are needed by supersize.
Also makes a couple minor optimizations:
* Track .jar.info rather than .jar in merge_jar_info_files.py
* Make create_final_jar_info() a dep of the final android_apk group(),
rather than a dep of the create_apk() target.
Bug: 873714
Change-Id: I0ff452cbd19d07d6ee0a44c9b7def4e2c728ec3f
Reviewed-on: https://chromium-review.googlesource.com/c/1457430
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630021}(cherry picked from commit f5a9e0d7cee699402cd5e470bb20d33b70be154d)
Reviewed-on: https://chromium-review.googlesource.com/c/1474590
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#440}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android: Add build targets for bundle .apks file
These will be used by bots & diagnose_bloat.py for measuring binary
size.
Also updates related code in apk_operations.py:
* Makes --output-apks required for build-bundle-apks
* Adds --minimal for build-bundle-apks
* Logs bundletool commands when in verbose mode
Bug: 873714
Change-Id: I6fb4bcc366110cacfd8e1b772db4ea1e00f81cc9
Reviewed-on: https://chromium-review.googlesource.com/c/1456223
Reviewed-by: David Turner <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630017}
Reviewed-on: https://chromium-review.googlesource.com/c/1474335
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#439}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Bundles] apk_operations.py: Add flag to specify fake module installation.
This CL adds the '-f FAKE' flag to apk_operations.py. This complements
the '-m MODULE' flag, but performs fake bundle module install instead.
Changes:
* Always delete the fake module directories:
/data/local/tmp/modules/
/data/data/<package_name>/files/splitcompat/ (needs root)
* If -f flags is given:
* Constraints:
(1) '-f base' is illegal.
(2) Explicit '-m base' is required (prevents potential ambiguity
in the future).
(3) FAKE and MODULE must be disjoint.
* Print warning if command line flags not set up for fake modules.
This requires chrome/android/BUILD.gn to specify
command_line_flags_file = 'chrome-command-line',
which get passed to apk_operations.py: _InstallBundle() so it can
read the command line flags and check.
* Extract the FAKE module split APKs, then copy them to
/data/local/tmp/modules/.
* Update chrome/android/BUILD.gn to specify
which get passed to apk_operations.py: _InstallBundle() so that
it can check for '--fake-feature-module-install' in command line,
and print warning if missing.
Bug: 922051
Change-Id: I5bba49e1e7e66a4a00f1ed1ca4128a805d995e95
Reviewed-on: https://chromium-review.googlesource.com/c/1435515
Reviewed-by: Samuel Huang <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626222}(cherry picked from commit 561a644d6a75902fdb9f676deacf2f01178a0415)
Reviewed-on: https://chromium-review.googlesource.com/c/1474333
Cr-Commit-Position: refs/branch-heads/3683@{#438}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Teach resource_sizes.py about .minimal.apks files
Bug: 873714
Change-Id: I61144ba0e7bd3a8211e55b5febfc4ee592cf2095
Reviewed-on: https://chromium-review.googlesource.com/c/1456943
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Eric Stevenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629726}(cherry picked from commit d9a8ad6b51c3b431b73e6d0162da4d1ce2dc2931)
Reviewed-on: https://chromium-review.googlesource.com/c/1474430
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#437}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android: Stop measuring static initializers in resource_sizes.py
I don't think it's helpful to record this metric since we now have an
assertion / expectation file.
Moves all logic into assert_static_initializers.py
Bug: 873714
Change-Id: I2495262d30ac4aab1dd7f0c3c0d8c24792d68850
Reviewed-on: https://chromium-review.googlesource.com/c/1456653
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Eric Stevenson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629699}(cherry picked from commit a417ad30a7b7eed2107d3de35b8d376ba2af7049)
Reviewed-on: https://chromium-review.googlesource.com/c/1474332
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#436}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}android: Reduce chromium linker by 100 kiB
By carefully removing un-necessary libc++ and android_support
code, it is possible to reduce the size of the Chromium linker
to a slim 38 kiB!
This is achieved by using the quasi-magical |no_default_deps|.
See bug for more details.
BUG=931266
R=[email protected], [email protected], [email protected]
Change-Id: I1603d9ff44ae97bb4ae6213057687084866637b2
Reviewed-on: https://chromium-review.googlesource.com/c/1467101
Reviewed-by: Egor Pasko <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: David Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631315}(cherry picked from commit 3bbb6261e6f5f9ed6684ecb56ffbbc6b83631474)
Reviewed-on: https://chromium-review.googlesource.com/c/1474291
Cr-Commit-Position: refs/branch-heads/3683@{#435}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "[Feed] Add pagination and ui config params."
This reverts commit aff3df13ce885fc145e8c23ea57e68e26554b763.
Reason for revert: Fails to compile
../../chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedConfiguration.java:213: error: cannot find symbol
.put(ConfigKey.USE_SECONDARY_PAGE_REQUEST,
^
symbol: variable USE_SECONDARY_PAGE_REQUEST
location: @interface ConfigKey
1 error
Original change's description:
> [Feed] Add pagination and ui config params.
>
> Bug: 928772
> Change-Id: I8d939e8b6803c4d67b4cc24f19e47b695f84400e
> Reviewed-on: https://chromium-review.googlesource.com/c/1460073
> Commit-Queue: Sky Malice <[email protected]>
> Auto-Submit: Sky Malice <[email protected]>
> Reviewed-by: Gang Wu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#630384}(cherry picked from commit eb2bb5a4cde699da9a9688d26cb49304d54d84aa)
> Reviewed-on: https://chromium-review.googlesource.com/c/1473825
> Reviewed-by: Sky Malice <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#433}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
[email protected]
Change-Id: I5733d2c03a3f59883fce18d36a88ff68134dee9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 928772
Reviewed-on: https://chromium-review.googlesource.com/c/1474250
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#434}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Feed] Add pagination and ui config params.
Bug: 928772
Change-Id: I8d939e8b6803c4d67b4cc24f19e47b695f84400e
Reviewed-on: https://chromium-review.googlesource.com/c/1460073
Commit-Queue: Sky Malice <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630384}(cherry picked from commit eb2bb5a4cde699da9a9688d26cb49304d54d84aa)
Reviewed-on: https://chromium-review.googlesource.com/c/1473825
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#433}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Feed] Switch scheduler's request tracking to only last 30 seconds.
Previously we had a simple boolean that we hold onto if there was an
outstanding request or not. If there was, then no new request would be
started by the scheduler. If there was a bug in how we updated this
field then we would not make requests when we should.
This change switches that boolean to a timer based approach that waits
the same duration as our network stack should use for timing out. After
this threshold expires the scheduler will allow new requests.
There is a commented out DCHECK in the scheduler that will change as a
result of this. It should be re-enabled, but in a separate CL in case
it needs to be rolled back.
Bug: 928772
Change-Id: I575622463f0dfbb4efce3558b811c98239b5ee7b
Reviewed-on: https://chromium-review.googlesource.com/c/1435896
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625939}(cherry picked from commit 562cc41403a3e1e659f0b594119d6557dc466e77)
Reviewed-on: https://chromium-review.googlesource.com/c/1474095
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#432}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "DevTools: Fix focus when selecting to the left of treeitems"
This reverts commit 9a60a25d0462306a5dcaeb390fbbca9ea22cdb03.
Reason for revert: This broke a lot of focus related logic
in the Elements panel
Bug: 920518
Original change's description:
> DevTools: Fix focus when selecting to the left of treeitems
>
> The mousedown listener in ElementsTreeOutline was moving focus, but
> not consuming the event. The event then propagated to the treeoutline
> element itself, which stole focus.
>
> Change-Id: I2de2001175f4029cd94880297c460ff4c90b845a
> Reviewed-on: https://chromium-review.googlesource.com/c/1387688
> Reviewed-by: Pavel Feldman <[email protected]>
> Commit-Queue: Joel Einbinder <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#618423}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I1407655b9a6ca03a2f110f87b7b9d2f98795ef53
Reviewed-on: https://chromium-review.googlesource.com/c/1450512
Reviewed-by: Joel Einbinder <[email protected]>
Commit-Queue: Joel Einbinder <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628528}(cherry picked from commit bb79864925df7a5c7b61bcb1d35696e0fcbd6eb2)
Reviewed-on: https://chromium-review.googlesource.com/c/1473840
Cr-Commit-Position: refs/branch-heads/3683@{#431}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] [Dark mode] App Menu managed footer: update colors
Bug: 919102
Change-Id: I577e5c93736deb2f906727b367b89b4dba30d206
Reviewed-on: https://chromium-review.googlesource.com/c/1431294
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627148}(cherry picked from commit 282d43b635b859662ad3acf634adcdbc764a1d49)
Reviewed-on: https://chromium-review.googlesource.com/c/1473835
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#430}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[m73] fido: cancel pending authenticators while error UI is showing
r1428879 changed AuthenticatorImpl to not immediately resolve the request
promise after an error occurs but wait for the UI to be dismissed first. As a
side-effect, the FidoRequestHandler for the request handler for the request
lives on while the UI is shown. I.e., external authenticators continue to
accept inputs (and users can still complete the request successfully); and the
Windows WebAuthn UI continues to be shown.
This changes AuthenticatorImpl to cancel all pending authenticators immediately
after an error has occurred. Also implements cancelling of U2F HID
authenticators.
Bug: 897757
Change-Id: Ibd4800a3dcc5ac49b92bec0bfe13e6ca506122ba
Reviewed-on: https://chromium-review.googlesource.com/c/1460480
Reviewed-by: Kim Paulhamus <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630448}(cherry picked from commit 503a48173cead27c392fd28b3e1a902c503b73ea)
Reviewed-on: https://chromium-review.googlesource.com/c/1473815
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#429}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[TTS] Fix a crash recently introduced.
Protect against a null ContextualSearchManager when an Overlay
Panel is shown. The ContextualSearchTabHelper needs to check
for a null CSM before asking if it is active. If there's no CSM
then we don't need to update the hooks even though it can't be active.
BUG=930615
Change-Id: I1fe106a29978a007d80e908590a40526b696a73f
Reviewed-on: https://chromium-review.googlesource.com/c/1465164
Commit-Queue: Donn Denman <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631019}(cherry picked from commit 149172a63e0b725d2a34dc8c87218588b6ec7d43)
Reviewed-on: https://chromium-review.googlesource.com/c/1473974
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#428}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Postmortem states should not return errors until after user action.
Three error states (timeout, keyNotRegistered, and keyAlreadyRegistered)
were previously considered 'postmortem' states. This meant that dialogs
corresponding to these states would be shown after a request was finished
and after a DOMException was sent to the RP.
This CL changes those states to instead block resolution of the request
until the user acknowledges the dialog, and then close the request.
Reworded 'postmortem' references to 'awaiting user acknowledgement'
to better reflect this behavior.
Bug: 897757
Change-Id: I04330f5a87ebbc960cd4c1e8d2c1b65fe97d9cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1428879
Commit-Queue: Kim Paulhamus <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629782}(cherry picked from commit 0aa02f8093f51ad3cd22238e803839525fa23125)
Reviewed-on: https://chromium-review.googlesource.com/c/1473972
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#427}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}RELAND - tablet: Fix edge case with |defer_bounds_updates| set inappropriately.
This CL is meant as a low-risk fix of Issue 926602 to merge back to M73.
For the long term, it will be preferable to avoid maximizing windows
before snapping them. Then we might even be able to eliminate
|defer_bounds_updates| altogether (even though it existed before
anything about snapped windows carrying over from desktop to tablet).
[email protected], [email protected]
Test: ash_unittests TabletModeControllerTest.StartTablet*
Test: ash_unittests TabletModeControllerTest.DeferBoundsUpdatesForWindowsInOverview*
Test: ash_unittests TabletModeControllerTest.ProgrammaticallyStartSplitViewAndThenOverview
Bug: 926602
Change-Id: I0a068ffae314871c8466d1364bcd96f72b69d345
Reviewed-on: https://chromium-review.googlesource.com/c/1457235
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Avery Musbach <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#631462}
Reviewed-on: https://chromium-review.googlesource.com/c/1471013
Cr-Original-Commit-Position: refs/heads/master@{#632017}(cherry picked from commit be0bc55274e094e8a90b433480f0a2a834128978)
Reviewed-on: https://chromium-review.googlesource.com/c/1473396
Cr-Commit-Position: refs/branch-heads/3683@{#426}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Always use new tab in -openOrReuseTabInMode.
This is a temporary workaround for loading a webpage
when restoring the NTP from a cold start.
Bug: 931280
TEST: Kill app while on ntp, then 3d touch a new website. All 3d touch or today extension will now always open a new tab.
Change-Id: I5b244e8d95644e840260c9c740ed75ac754e96ad
Reviewed-on: https://chromium-review.googlesource.com/c/1465040
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631394}(cherry picked from commit 3c8472322fe0de999ed767f496fc3e926fc4b110)
Reviewed-on: https://chromium-review.googlesource.com/c/1473611
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#425}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Add more checks for nil last committed item.
Catch more edge cases where last committed item can be nil if
navigating when about://newtab is still loading.
Bug: 931273
TBR: sdefresne@
Change-Id: I29bdd0a5f8c5b6e9a098face36c87c6bc0b5ee13
Reviewed-on: https://chromium-review.googlesource.com/c/1469427
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631915}(cherry picked from commit 47f9015ce97a3af2ac58987d43841c7b2c2846ba)
Reviewed-on: https://chromium-review.googlesource.com/c/1473610
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#424}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[RELAND] Add metrics for Bluetooth adapter availability
This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1437721 which
was reverted due to a startup regression on Windows. The only change
in this CL is to disable it on Windows, pending resolution of
https://crbug.com/929375, and also downgrade the priority of sending
metrics to make it a post startup task.
[email protected],[email protected]
Bug: 907279
Change-Id: I3c3182901b2f8a753646405699697661c3a12c3b
Reviewed-on: https://chromium-review.googlesource.com/c/1460871
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Ken Buchanan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630521}(cherry picked from commit 881a29ab4ec46d558edaea2b21076a6fec551257)
Reviewed-on: https://chromium-review.googlesource.com/c/1473391
Cr-Commit-Position: refs/branch-heads/3683@{#423}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}third_party/ashmem: Use ASharedMemory_create() et al.
This CL modifies the implementation of third_party/ashmem/
to use the ASharedMemory function provided by libandroid.so
when possible (i.e. starting with API level 26).
This is in preparation for the future removal of the Ashmem
device from Android. The libandroid functions will provide
working alternatives, but pin/unpin will probably not work
anymore.
The current code will try to use Ashmem ioctls whenever
possible, i.e.:
- Perform runtime probing to determine the system's
current API level.
- If API level is below 26, do not change the way regions
are created / managed through the Ashmem device file
and ioctls.
- If API level is 26 or above, exclusively use the libandroid
functions related to ASharedMemory to create / size / protect
regions. Even if this currently wraps ashmem device open()
and ioctls(), this may change in a future Android release
but these APIs will keep working as intended.
- If API level is 26 or above, try to detect that the
Ashmem device is available, and if so, continue performing
pin / unpin on it. If this is not the case, these operations
become no-ops.
NOTE: A CL was uploaded to disable this explicitly by faking
a non-Ashmem device to verify that this didn't break our
unit tests. See patchset 8 at [1]
+ Remove ashmem_purge_all(), since it was unused.
+ Add ashmem_device_is_supported() since this must be surfaced
to avoid breaking one unit-test that checks for explicit
behaviour that cannot be supported in the future.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1450259/8
BUG=914650
R=[email protected]
Change-Id: Iffee23bf8bad8b68a3efdb2208c0a9494432731b
Reviewed-on: https://chromium-review.googlesource.com/c/1454628
Commit-Queue: David Turner <[email protected]>
Reviewed-by: Benoit L <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629603}(cherry picked from commit cf4ac4249a158533a0657378161fa7e5a8a9fdc7)
Reviewed-on: https://chromium-review.googlesource.com/c/1458447
Reviewed-by: David Turner <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#422}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Remove dependency for ContextualContentSuggestions.
Unified Consent project transformed to be just a UI refresh for the sync and other
Google services settings. This means that contextual suggestions should not include
cookies when unified consent is enabled.
Bug: 930139
Change-Id: Ica66230b4602b95101f0c5d2a6a60a9b844ea102
Reviewed-on: https://chromium-review.googlesource.com/c/1460931
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: Thomas Tangl <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631185}(cherry picked from commit eae5aac8a05ab5e5b788d26b67b3e6d5de485ada)
Reviewed-on: https://chromium-review.googlesource.com/c/1472579
Cr-Commit-Position: refs/branch-heads/3683@{#421}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Clicking 'Cancel' button during setup aborts sync
When the user clicks the 'Cancel' button during the sync setup,
instead of showing the 'Cancel sync?' dialog, sync is aborted
right away.
Bug: 931383
Change-Id: Id10076887626ccf3ae423d883da7888ef944edfb
Reviewed-on: https://chromium-review.googlesource.com/c/1467081
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Hector Carmona <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631401}(cherry picked from commit b1644441dbfa0aa52dbb031b26362170e2cc2bc7)
Reviewed-on: https://chromium-review.googlesource.com/c/1472712
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#420}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73] Ignore same-document navigation commit in pending deletion frame.
Similar to what is done with different-document navigations. If a
same-document navigation commits into a pending deletion frame, it needs
to be ignored.
Regression tests added.
(cherry picked from commit d983179ffc57406e0a700d870366a1474b23244a)
Bug: 930132
Change-Id: Ib905197d30a754c3ac77b510d58741f40755a80f
Reviewed-on: https://chromium-review.googlesource.com/c/1461023
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630709}
Reviewed-on: https://chromium-review.googlesource.com/c/1466642
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#419}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73] Make policy check independent of profile_ever_initialized
If a profile may have policy, but there's no "profile_requires_policy"
known_user attribute to confirm / negate this, require a policy check
regardless of whether the profile is assumed to have ever been
initialized.
Profiles that have not been used for several releases may require an
online sign-in as a side effect.
[email protected]
(cherry picked from commit 30d7d9228848c9088d3b1a8b4c37b866cf69e08e)
Bug: 731726, 928988
Test: browser_tests --gtest_filter=*UserCloudPolicyManagerTest*
Change-Id: Idbc98258a363ad51c3c940d580eb2d9c38e0ed03
Reviewed-on: https://chromium-review.googlesource.com/c/1464304
Commit-Queue: Pavol Marko <[email protected]>
Reviewed-by: Drew Wilson <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631397}
Reviewed-on: https://chromium-review.googlesource.com/c/1470766
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#418}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "Propagate definite height of single-line row flexboxes to child cross size"
This reverts commit 1e933299c93a4d64e672e26c7ecf53c16df605c5.
Reason for revert: Causes regressions on real websites (release blocker), see crbug.com/929690 and crbug.com/927066. We'll have to revisit this later :(
Original change's description:
> Propagate definite height of single-line row flexboxes to child cross size
>
> When we have a single-line definite height row flexbox with a column
> flexbox as its child, we always relayout all children of the column
> flexbox during LayoutLineItems with a zero-sized height being set.
> This patch leverages the definite height of the row flexbox in order to
> avoid a relayout of the column flexbox children.
>
> Bug: 703512
> Change-Id: I1f67efff3ebc67cdcce57dce2d2567e2abe13625
> Reviewed-on: https://chromium-review.googlesource.com/c/1306404
> Reviewed-by: Christian Biesinger <[email protected]>
> Commit-Queue: Andrew Comminos <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#607090}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 703512,929690
Change-Id: I13a99318e3e5161b94c15b3b141ea91fb91dbafd
Reviewed-on: https://chromium-review.googlesource.com/c/1469406
Reviewed-by: Andrew Comminos <[email protected]>
Commit-Queue: Christian Biesinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631762}(cherry picked from commit 53a0531205019b121c828420c4845cae3bcf4860)
Reviewed-on: https://chromium-review.googlesource.com/c/1471464
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#417}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Print Preview: Fix bug with multiple login, and add a test (M73)
Fix a bug where the Save to Google Drive destination in the dialog list
could still be the destination for the previous account, while loading
printers. This became obvious with the addition of the dropdown, which
displays a blank value if the printer does not match the active user.
Also add a test verifying multiple sign in behavior and the fix for
this bug.
(cherry picked from commit 4ac6fa253de590c7a8cc73000b180422e7990354)
Bug: 927677
Change-Id: Ic96f2d54f06ecba579e77138b136b536bd7847be
Reviewed-on: https://chromium-review.googlesource.com/c/1450539
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629355}
Reviewed-on: https://chromium-review.googlesource.com/c/1471213
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#416}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.40
[email protected]
Change-Id: Ia22db1092c1b10e612706da8fbc5f7a901ddeacd
Reviewed-on: https://chromium-review.googlesource.com/c/1471496
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#415}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Do not create app shims for sync'd PWAs on Mac
This CL ensures we do not spam the user's Application directory on Mac
when syncing down installed PWAs. This makes Mac behave the same as
Windows and Linux.
Bug: 929559
Change-Id: I31df57e7d8228b2a47cc362f258afeee2dc840ef
Reviewed-on: https://chromium-review.googlesource.com/c/1457698
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629935}(cherry picked from commit 225c5d4eaff75a19aa920da1402ef9161bf9efef)
Reviewed-on: https://chromium-review.googlesource.com/c/1470353
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#414}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.39
[email protected]
Change-Id: I9a866a7acd26fcba9d10340b2b79bc4aac16eccc
Reviewed-on: https://chromium-review.googlesource.com/c/1471386
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#413}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[omnibox] Prefer entity suggestions, even if not allowed to be default.
Also, refactor the logic to combine how we handle
allowed_to_be_default_match and how we handle entity suggestions. The
former was added in https://crrev.com/c/1174860. Then I added similar
entity suggestion handling but in a totally different way in
https://crrev.com/c/1376322.
When looking to update this logic to fix the issue in bug 922662, I
realized that these were doing very similar things despite going about
them in different ways. So this CL combines all the logic in the method
that chooses between two candidate matches.
[email protected]
(cherry picked from commit ccd68fee38a75ddcdde0eb3a4305c15f2b138b62)
Bug: 922662
Change-Id: I290573e4669360904bf049d252e4a4175ea6c499
Reviewed-on: https://chromium-review.googlesource.com/c/1403062
Commit-Queue: Justin Donnelly <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630506}
Reviewed-on: https://chromium-review.googlesource.com/c/1471245
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#412}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Omnibox: Add back vertical margin field trial
This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1257806
It adds back the vertical margin trial, but it no longer ties it to
kExperimentalUi. It's just set to 2 by default, to match the
pre-Refresh look as closely as possible.
This can be manually tested like this:
chrome
--force-fieldtrials=FakeStudy/FakeGroup
--force-fieldtrial-params=FakeStudy.FakeGroup:UIVerticalMargin/12
--enable-features="OmniboxUIExperimentVerticalMargin<FakeStudy"
Bug: 931332
Change-Id: Ic590f736b141a20bb10ee1e4d4f688d18d68910f
Reviewed-on: https://chromium-review.googlesource.com/c/1467345
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#631521}(cherry picked from commit c89a1ba6c84201b67ea1cfb97cb1d9eb58ffc6fd)
Reviewed-on: https://chromium-review.googlesource.com/c/1470993
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3704@{#5}
Cr-Original-Branched-From: f7257947b936a99eb7a3c74fa8c2252e364ab5ff-refs/heads/master@{#631506}(cherry picked from commit 05d7b89fa30f767e8614765a7d4ed2ffa97564aa)
Reviewed-on: https://chromium-review.googlesource.com/c/1471342
Cr-Commit-Position: refs/branch-heads/3683@{#411}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge 73] Omnibox: Add back kUIExperimentShowSuggestionFavicons flag
This is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1343366
It also no longer ties this flag to kExperimentalUi.
[email protected]
Bug: 931332, 900255
Change-Id: I0fbbdee836ed51a07d49676a60b8486795a4bd57
Reviewed-on: https://chromium-review.googlesource.com/c/1471393
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#410}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73] Do not use frame pending deletion for history navigation.
A frame pending deletion is not supposed to navigate anymore. The
function NavigationControllerImpl::FindFramesToNavigate must exclude
them.
Regression test added.
Bug was introduced in M73 by:
https://chromium-review.googlesource.com/c/chromium/src/+/1354922
--
After a navigation, the frame enters pending deletion and is moved to
RenderFrameHostManager::pending_delete_hosts. On the other side, after a
frame deletion, the frame is not moved at all. This is tricky, it
means the frame pending deletion is still reachable by walking through
the FrameTree among the current_frame_host().
(cherry picked from commit 03f761552fcfd7268e59a59726b17e1f848f46f1)
Bug: 930278
Change-Id: I81ed9da6cd0d67f49e13f9533df5a0b2283ecd60
Reviewed-on: https://chromium-review.googlesource.com/c/1462983
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631167}
Reviewed-on: https://chromium-review.googlesource.com/c/1471338
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#409}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Navi: Re-enable synthetic trials for onboarding.
Bug: 919705
Change-Id: Ic1d5c3d3ec28648494c8d927bedda4f3547422c5
Reviewed-on: https://chromium-review.googlesource.com/c/1465281
Auto-Submit: Hector Carmona <[email protected]>
Reviewed-by: Esmael El-Moslimany <[email protected]>
Commit-Queue: Hector Carmona <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631305}(cherry picked from commit 15c6b24ec93e122733704a9eb955b8569477a0ce)
Reviewed-on: https://chromium-review.googlesource.com/c/1471352
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#408}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Attempt to fix UAF in NetworkService during teardown.
A NetworkChangeManager was being destroyed before a
LoggingNetworkChangeObserver that was watching it. This usally didn't
actually cause any noticeable issues, because NetworkChangeNotifier
methods all null check when they're called, but in this case, if
there was a pending notification, it could still be run, and call into
the destroyed LoggingNetworkChangeObserver, apparently.
We should continue removing the null checks in the NCN API, at least
once it's only used in the network service process.
Bug: 924146
Change-Id: Ia41de8275a2aa035d66f3e79aa78eeed753a35e5
Reviewed-on: https://chromium-review.googlesource.com/c/1444237
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Paul Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627409}(cherry picked from commit 6bc03b00d3b46d31b88818a23a996fd37cab7e08)
Reviewed-on: https://chromium-review.googlesource.com/c/1471336
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#407}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.38
[email protected]
Change-Id: I4c5e336ded44121bd777dd403f568e3276a544a6
Reviewed-on: https://chromium-review.googlesource.com/c/1471248
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#406}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Updating XTBs based on .GRDs from branch 3683
[email protected]
Change-Id: Ibdab68d963ae4662dc8a2195c3d8e8f82bf4e0be
Reviewed-on: https://chromium-review.googlesource.com/c/1470910
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#405}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}cc: Plumb overlay_candidate for UIResources
[email protected]
(cherry picked from commit 42aea62378de18eeccbd15ab1a354f9f37429cd0)
Bug: 931079
Change-Id: Ia11314b8420f26960e60162f2f1f874bb8c9c982
Reviewed-on: https://chromium-review.googlesource.com/c/1466147
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631566}
Reviewed-on: https://chromium-review.googlesource.com/c/1471298
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#404}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Files app] Better handle null entry on VolumeManager
Change VolumeManagerImpl getVolumeInfo and getLocationInfo to not fail
with null entry and add log to try to identify where it happens.
No new test added because we couldn't determine in what exact condition
this happens.
Bug: 904658
Change-Id: I6a99f3b1c24604e696f860e59e2f54b648b77de7
Reviewed-on: https://chromium-review.googlesource.com/c/1466222
Commit-Queue: Luciano Pacheco <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631136}(cherry picked from commit 0c9bffad9fa501390d45798299248ac8dac4ed7c)
Reviewed-on: https://chromium-review.googlesource.com/c/1470283
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#403}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Feed] Import feed@82057fe34f6602efc131bf67fa8ec2174c6244f8
Changes for 2 issues in the Feed library (third_party/feed) are merged
to M73 in this CL:
- crbug.com/929432 - Quick hide/show blanked Feed.
- crbug.com/916791 - Removed slow proto processing from UI thread.
Bug: 929432, 916791
Change-Id: I4ed2e7a547f34d8d98a0b91259d755f069af5eda
Reviewed-on: https://chromium-review.googlesource.com/c/1470998
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#402}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Allow incoming intent redirects to submit forms w/o user gesture.
Requiring user gesture on form submission broke OAuth providers,
so this allows incoming intents bypass this restriction.
BUG=927509,839751
Change-Id: I4a46cf0b3bb3fad0f18211b2194dd823d0bdc897
Reviewed-on: https://chromium-review.googlesource.com/c/1456211
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629993}(cherry picked from commit ee1137870dddc0e2ab92be96bb9fad1d07872260)
Reviewed-on: https://chromium-review.googlesource.com/c/1470997
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#401}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Stop prefetching sub directories for SMB shares
Currently, when the File Manager is opened, a ReadDirectory is done for
each volume in the DirectoryTree to populate the sub directories. For
SMB Shares, we want to explicitly avoid this since a ReadDirectory may
require authentication (which may require prompting the user).
In order to avoid prompting the user until the user attempts to access
the share, we explicitly do not call .updateSubDirectories when creating
a VolumeItem for an SMB Share
[email protected]
(cherry picked from commit 11d3092b33025fcb835e1d752c345ecec3cf48d6)
Test: --gtest_filter=*FileManager*
Bug: 929942
Change-Id: I2987ec1245d8ad80600f3ff7dd91b466d19ad2a8
Reviewed-on: https://chromium-review.googlesource.com/c/1461550
Commit-Queue: Bailey Berro <[email protected]>
Auto-Submit: Bailey Berro <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631438}
Reviewed-on: https://chromium-review.googlesource.com/c/1470995
Reviewed-by: Bailey Berro <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#400}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[AW] Add UMA for measuring shouldInterceptRequest usage and intercepted url schemes
MERGE to M73
Add UMA for measuring whether the request was intercepted by the embedder
of Android WebView and if so which url scheme was intercepted.
Intercepted requests are requests for which the shouldInterceptRequest()
callback returned a non-null response.
In particular we are interested in the usage of "data:" scheme url
interception, because we are considering not allowing to intercept
this type of scheme.
BUG=841556,928728,929788
Change-Id: I1063605bda171e3e75f259c1539626212d79c4d7
Reviewed-on: https://chromium-review.googlesource.com/c/1459116
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Tobias Sargeant <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631378}(cherry picked from commit 3778f893c76248a57cbf0cc7434c633561783de0)
Reviewed-on: https://chromium-review.googlesource.com/c/1470765
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#399}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge to M73] Add sanity checks when setting work area for X11 displays
> Some X11 window managers have buggy _NET_WORKAREA implementations. For example,
> it's possible for the work area to only cover one display (which may not even be
> the primary display).
>
> We used to intersect the workarea with only the primary display, but this change
> adds some sanity checks in an attempt to handle some of these buggy cases.
>
> BUG=774232
> R=sky
>
> Change-Id: Ic193afd5cf95ff364b0e74fb547f6858d31ff7c4
> Reviewed-on: https://chromium-review.googlesource.com/c/1457462
> Commit-Queue: Scott Violet <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Auto-Submit: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#630353}
BUG=774232
TBR=sky
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: Ic018bc505984be59f5264e2ccc7b1563eb83d298
Reviewed-on: https://chromium-review.googlesource.com/c/1470745
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#398}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge to M73] Add a fallback path for SELECT window size when there's no available space
> Some buggy window managers on Linux (bug 774232) have an improperly set screen
> workarea that's empty on secondary displays. This CL adds a fallback path for
> this case to prevent rendering issues on select dropdowns.
>
> BUG=774232
>
> Change-Id: I7188418b2e737478307663652ccaef48594b1696
> Reviewed-on: https://chromium-review.googlesource.com/c/1455518
> Commit-Queue: Kent Tamura <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Auto-Submit: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#630215}
BUG=774232
TBR=tkent
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: I9cf9e2ccfccd7ca7e6adda60509b4e97adf64fc6
Reviewed-on: https://chromium-review.googlesource.com/c/1470742
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#397}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}cros: Disable explicit DMA fences
On Intel devices we noticed glitches when pageflipping that seem to
be caused by a race between GPU and display controller.
The glitches started appearing when we enabled explicit synchronization
for the primary plane.
Investigating further we discovered that we are currently inserting the
fence after GLRenderer draws all the contents, but before the bufferqueue
copies from the previous framebuffer, to the current framebuffer, to
implement partial swap. This means we can end up scanning out from an fb
while the GPU is copying parts of the previous fb to it.
This CL inverts the flag disable-explicit-dma-fences to a flag to enable
them, effectively disabling them by default while we fix the issue we
discovered.
Bug: 889530
Change-Id: Iea1e9d163228fc7df6389fbe730196af01ab3a51
Reviewed-on: https://chromium-review.googlesource.com/c/1462204
Reviewed-by: Daniele Castagna <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631272}(cherry picked from commit 787f41564acc6fbabed08976282b8907d6af7534)
Reviewed-on: https://chromium-review.googlesource.com/c/1470990
Cr-Commit-Position: refs/branch-heads/3683@{#396}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add base::mac::FilePathToNSURL().
This complements FilePathToNSString() and FilePathToCFURL().
Change-Id: Ibc79a1fadf17392425c4509bc1d08f5ac6f4da82
Reviewed-on: https://chromium-review.googlesource.com/c/1453111
Commit-Queue: Sidney San Martín <[email protected]>
Auto-Submit: Sidney San Martín <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629197}(cherry picked from commit deaee2981247ce0018f3b82921c838943bedc310)
Reviewed-on: https://chromium-review.googlesource.com/c/1470933
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#395}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Feed] Import feed@cd69cbf7c0d6108dbb52354ccb5504b3e005da46
Changes for 4 issues in the Feed library (third_party/feed) are merged to
M73 in this CL:
- crbug.com/929498 - Updated translations.
- crbug.com/928765 - Fixed a bug that would cause no content to show.
- crbug.com/928766 - Only load session objects if Feed is visible.
- crbug.com/927233 - Fix image loading on N- clients.
Bug: 929498, 928765, 928766, 927233
Change-Id: I0e56861b1567e5a3f7b9836eb442b50c1cbc55b9
Reviewed-on: https://chromium-review.googlesource.com/c/1470544
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#394}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge M73][NTP] Add browser_tests for search suggestions
Add browser_tests for search suggestion.
Also fix a bug introduced in https://crrev.com/c/1446789 causing
a impression to be counted even if it contained no suggestions.
Change-Id: I1a2395eb0e1e7be988609f9c45945c7a8e6de5c4
Reviewed-on: https://chromium-review.googlesource.com/c/1460103
Reviewed-by: Kristi Park <[email protected]>
Commit-Queue: Kyle Milka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630169}(cherry picked from commit edffc239fb6ee28e206d3f95989188238f17dbb9)
Reviewed-on: https://chromium-review.googlesource.com/c/1470731
Reviewed-by: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#393}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}This is the cherry pick merge for the M73 branch which was approved here: http://crbug.com/931611
[Autofill Assistant] Surface price to the user.
If the backend sends price information, it is now displayed in the client UI.
Screenshot after the change: https://screenshot.googleplex.com/baFaQoOMODb.png
Bug: 806868
Change-Id: I7b9b0f41fcd74a6eadf2696d3308b46f68bc46d5
Reviewed-on: https://chromium-review.googlesource.com/c/1466622
Auto-Submit: Clemens Arbesser <[email protected]>
Reviewed-by: Stephane Zermatten <[email protected]>
Commit-Queue: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631186}(cherry picked from commit 692429074870e5824a235fc103f74bb7ffbba803)
Reviewed-on: https://chromium-review.googlesource.com/c/1470156
Cr-Commit-Position: refs/branch-heads/3683@{#392}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Add empty view when results are empty.
Bug: 925374, 860467
Change-Id: Id11f7bf6c4648426b0a6c2b869700c1fe50dc8c9
Reviewed-on: https://chromium-review.googlesource.com/c/1449668
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628639}(cherry picked from commit a41c411537a46df0b67a657113c719a9904867f6)
Reviewed-on: https://chromium-review.googlesource.com/c/1470160
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#391}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Fix padding in single-selection mode.
TBR: tedchoc
Bug: 925371, 860467
Change-Id: I11f12c9f032c7e72b0a62eef62b739f7cbe6e1ee
Reviewed-on: https://chromium-review.googlesource.com/c/1445896
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627452}(cherry picked from commit 4f944c3ae6cc122236b9b0b62f04c3ba71f2cc77)
Reviewed-on: https://chromium-review.googlesource.com/c/1470159
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#390}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Plumb through the origin requesting the data.
TBR: twellington, tedchoc, yusuf
Bug: 925368, 860467
Change-Id: I930b7a36e47e5a3a41009df86188c11d00cfa856
Reviewed-on: https://chromium-review.googlesource.com/c/1439297
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627396}(cherry picked from commit 17c586cc95114d44371937793dac4997462d7946)
Reviewed-on: https://chromium-review.googlesource.com/c/1470158
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#389}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Better handling when only names are requested.
Bug: 925374, 860467
Change-Id: If11e171966d2bca09254ec5ff942c75556c0b490
Reviewed-on: https://chromium-review.googlesource.com/c/1436261
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626975}(cherry picked from commit 1d84cbe033265384397af87f7cf74796d101324e)
Reviewed-on: https://chromium-review.googlesource.com/c/1470195
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#388}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Remove feature guard and catch case where promise is not resolved.
Bug: 925367, 860467
Change-Id: I76a98b787e12e284996311561b8e35fb5f537c51
Reviewed-on: https://chromium-review.googlesource.com/c/1437179
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Auto-Submit: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626643}(cherry picked from commit abe187a14652477f06b1569cad323ac4720fa9d5)
Reviewed-on: https://chromium-review.googlesource.com/c/1470157
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#387}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Restrict contacts.select() API to main frame.
Bug: 926845, 860467
Change-Id: I0acc16a3acdc0dffec5521a4fa58a01851b4ca02
Reviewed-on: https://chromium-review.googlesource.com/c/1446352
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628306}(cherry picked from commit 7c09e600bd11660e978d937746f5a984e9f700d2)
Reviewed-on: https://chromium-review.googlesource.com/c/1470191
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#386}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Contacts Picker: Fix the Close button.
When selecting a contact and unselecting that contact, the Close
button would disappear. This CL fixes that (makes it always visible).
TBR: twellington
Bug: 925369, 860467
Change-Id: Ifb461bbfb34abaac0b8e4b8196ded7d5bb1f1bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1443019
Reviewed-by: Finnur Thorarinsson <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Auto-Submit: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627385}(cherry picked from commit 4bd486fa63de3ea1500a25c686ddd1cf1fa0bd40)
Reviewed-on: https://chromium-review.googlesource.com/c/1470190
Cr-Commit-Position: refs/branch-heads/3683@{#385}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix system hotkeys like cmd+` in app shims.
SystemHotkeyHelperMac, which just managed a SystemHotkeyMap, was never
initialized in app shim processes, and I didn't see a good place to
initialize it because it's private to /content. This change replaces
that class with a function that lazily constructs a SystemHotkeyMap.
The SystemHotkeyMap is now created synchronously on first use instead of
on a background thread ten seconds after startup. This gets rid of the
time after startup where system hotkeys aren't respected and simplifies
the code a bunch, but could jank the main thread if loading from disk is
slow. I'd favor janking the main thread during the first keyboard
shortcut instead of mis-routing it.
Bug: 919579
Change-Id: I78ab8dfaf7b9115ce32e1d2d3e1c27abb7f6a9b5
Reviewed-on: https://chromium-review.googlesource.com/c/1446847
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Auto-Submit: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629626}(cherry picked from commit 68442b1e5e31367493a120eced2560c974e60d40)
Reviewed-on: https://chromium-review.googlesource.com/c/1469501
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#384}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "Crash early if FindFamily DWriteFontProxy call fails"
This reverts commit 59cc57db11dbcfb8ff8bedea12db458fc7662067.
Reason for revert: We've got enough data from this CHECK. From the
stack, it is possible that renderer can continue the work if we
don't crash here.
Original change's description:
> Crash early if FindFamily DWriteFontProxy call fails
>
> Adding an assertion failure on a failed FindFamily DWriteFontProxy sync
> IPC call to gather more information on failing clients. Sync IPC calls
> should only be returning false in very rare cases, which would mean an
> error here. More discussion on this on the bug.
>
> Note to Crash reporting sheriffs: This will likely trigger
> additional crash reports, which we assume to be a subset of the
> crash reports collected for issue 561873.
>
> Bug: 922403
> Change-Id: I054e65e5f01ff646329a6174b908305519fef3d6
> Reviewed-on: https://chromium-review.googlesource.com/c/1412029
> Reviewed-by: Ken Rockot <[email protected]>
> Commit-Queue: Dominik Röttsches <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#625672}
# Not skipping CQ checks because original CL landed > 1 day ago.
[email protected], [email protected]
Bug: 922403, 928649
Change-Id: Ia2ae9be045d2a8680f1cceba6ed504d8ea7f0e1e
Reviewed-on: https://chromium-review.googlesource.com/c/1466432
Reviewed-by: Emil A Eklund <[email protected]>
Commit-Queue: Emil A Eklund <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631280}(cherry picked from commit 3a2148050b077994a633f477310358c5c1b0f8a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1468849
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#383}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Oilpan: Disable heap compaction for incremental marking
Disable heap compaction for incremental marking because crash in blink::HeapCompact::MovableObjectFixups::Relocate is not fixed.
Bug: 918064
Change-Id: I459ec394539e139c8586fdb131f613b9488dad37
Reviewed-on: https://chromium-review.googlesource.com/c/1460740
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630288}(cherry picked from commit 48136fb98ac7eaa90c3c67afd7727981a5e086d7)
Reviewed-on: https://chromium-review.googlesource.com/c/1469189
Reviewed-by: Keishi Hattori <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#382}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Merge of DevTools: fix old shadow dom in DOMLinkifier
Bug: 929561
Change-Id: I98ec6ea3cc6a6de1d82489a737cd5f51f9bc56f0
Reviewed-on: https://chromium-review.googlesource.com/c/1457919
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629953}(cherry picked from commit a62e482dc280ffa33572d9dc606cb61208192f5b)
Reviewed-on: https://chromium-review.googlesource.com/c/1468847
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#381}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Print Preview: ignore document isScalingDisabled (M73)
Using isScalingDisabled to set the availability disabled the scaling
section for all PDFs. This CL restores the previous behavior of
ignoring this value and showing the scaling section for all documents.
Bug: 929830
Change-Id: Ibab11edaa68d839aa40dac988d997acbac24e0fc
Reviewed-on: https://chromium-review.googlesource.com/c/1459776
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630152}(cherry picked from commit f936b2360d06d795a88b08ffc8da61079dd7bed5)
Reviewed-on: https://chromium-review.googlesource.com/c/1469401
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#380}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.37
[email protected]
Change-Id: I03c528498dbdb193c11472fa897db7da13fe0abe
Reviewed-on: https://chromium-review.googlesource.com/c/1468808
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#379}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Android OOP-D: Ensure watchdog not disabled until after sync teardown
This change ensures that we don't disable the GPU watchdog until after
the Browser's sync GPU object teardown completes. This prevents a GPU
hang from indefinitely blocking the browser.
[email protected]
(cherry picked from commit 40a44f136281fd1a919cc0e5e912e82bb9d0620a)
Bug: 930986
Change-Id: I45d71b0d665aaf9b580ccd88ac6c04e5de78ec85
Reviewed-on: https://chromium-review.googlesource.com/c/1465143
Commit-Queue: Eric Karl <[email protected]>
Commit-Queue: Khushal <[email protected]>
Auto-Submit: Eric Karl <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631024}
Reviewed-on: https://chromium-review.googlesource.com/c/1468782
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#378}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add a ForceNetworkInProcess policy to force networking to run in the browser process.
When network service experiment is off, this has no effect. When network service experiment is on, if this policy is enabled it will force the network service to run in the browser process. This is intended as a temporary work-around for 3rd party software that depends on networking calls being made in the main Chrome process.
[email protected]
(cherry picked from commit 27b3ebd2c64e4a868a8f4f3faffc85887533c9c0)
Bug: 883603, 930750
Change-Id: Ic78708bcf0590e8ca3b222a91004ea786af3d69d
Reviewed-on: https://chromium-review.googlesource.com/c/1465172
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631320}
Reviewed-on: https://chromium-review.googlesource.com/c/1468404
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#377}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73] fido: make register requests resolve on timeout when using the Win WebAuthn API
When U2F requests that go through the native WebAuthn API on Windows time out,
the modal OS dialog for the request gets dimissed but the JS request promise
never gets resolved because the originating tab fails the focus check in
sendResponseToActiveTabOnly(). This appears to be caused by a race between the
cryptotoken-side focus check racing against Windows dismissing its dialog after
receiving the WebAuthNCancelCurrentOperation() call.
As a workaround, skip the focus check for all register timeouts.
Bug: 930015
Change-Id: I8f44e44a4a26d499e6681331d808af58eabbb573
Reviewed-on: https://chromium-review.googlesource.com/c/1461331
Commit-Queue: Martin Kreichgauer <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630586}(cherry picked from commit 63c078d58f82adb7d28de8b71566424fa4ab7b2c)
Reviewed-on: https://chromium-review.googlesource.com/c/1467445
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#376}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge M73] apps: Fix accessing to profile from non-UI thread.
In order to define type of profile (supervised and child case), it is
required internally to request pref value that in general non-safe from
non-UI thread. This CL switch to resolving user type on UI thread.
TEST=Locally with DCHECK on + extra logging to confirm fix
(eve + nocturne).
BUG=930404
Change-Id: I6f84c6e33d1b6c807b7a077393a35b0b9a10736b
Reviewed-on: https://chromium-review.googlesource.com/c/1462417
Reviewed-by: Ben Wells <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631053}(cherry picked from commit 07072a5dbadb1b54bf8f1082b86f2652c0db91d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1467908
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#375}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix supervised user types starting in sync standalone transport
We've observed crash reports that may be related, but nevertheless
starting this feature during sync standalone transport is questionable.
We achieve so by removing SUPERVISED_USER types from "core" sync types
and instead considering them user types that always preferred (as long
as sync-the-feature is enabled) and of high priority (to avoid
behavioral differences wrt startup latency).
Together with ignoring two remaining deprecated types, "core" sync types
now become synonym of control types, so we get rid of the concept
altogether.
Bug: 923826
Change-Id: Ie653f1c43f892307d72655967d4d75f13c338741
Reviewed-on: https://chromium-review.googlesource.com/c/1454519
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629113}(cherry picked from commit fbf9d2ac7ba84c0a6bb915ccd7c161a1143499a1)
Reviewed-on: https://chromium-review.googlesource.com/c/1467103
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#374}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix crash in reportCompleteNotificationAction [M73 merge]
reportCompleteNotificationAction can be called without native, which resulted
in crashes. Changed to use CachedMetrics to only report when native is loaded.
I manually tested that this no longer crashes by killing the chrome process
before triggering the intent. Note that if Chrome is killed before native
is loaded, the metric won't be reported.
Bug: 930307
Change-Id: I88728029ae1c09a9197de9c1eb3c6d71086b99d6
Reviewed-on: https://chromium-review.googlesource.com/c/1461332
Reviewed-by: Carlos Knippschild <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630541}(cherry picked from commit eda43b1350ee4abd8e8e3ad6982223cb27f38f86)
Reviewed-on: https://chromium-review.googlesource.com/c/1466158
Reviewed-by: Dan H <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#373}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add about flag for Data Saver rebranding
Bug: 928891
Change-Id: Icdcf8774a6d6d52444a79c765ba6b353b0fffd45
Reviewed-on: https://chromium-review.googlesource.com/c/1455315
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629727}(cherry picked from commit c370394d88e15f115187143dec65e0b4bc63557c)
Reviewed-on: https://chromium-review.googlesource.com/c/1467141
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#372}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Disable highlight for Previews IPH
I added a helper method for this to allow for easier changes like this
down the road, if wanted for other features.
Bug: 930877
Change-Id: Iad809f2e94e85db57e661f610ce63be9619a2dff
Reviewed-on: https://chromium-review.googlesource.com/c/1465062
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#631027}(cherry picked from commit 9b58eaed9d581d271d15449aed9b855bcd7cb410)
Reviewed-on: https://chromium-review.googlesource.com/c/1466160
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#371}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Don't WarmupCompositor() for a compositor-never-visible RenderWidget.
Drop the SetNeverVisible() method on LayerTreeView and its associated
state, since SetVisible() is only called from RenderWidget now. It can
look at its own compositor_never_visible_ to manage things.
Skip StartCompositor() and WarmupCompositor() if the compositor should
never become visible. Previously we were still running WarmupCompositor
in this case, which created a wasted GpuProcessHost and
CompositorFrameSink.
We do this consistently by merging Start and Stop into a single
StartStopCompositor() method that early outs if never visible.
Then for optimization we don't call this method if only one of
frozen/hidden changes and the other would prevent being started
still. And on init we skip the method if it wouldn't be started.
R=[email protected]
NOPRESUBMIT=true
Bug: 927130
Change-Id: Ic6316450e8981bc485311d86bb4556fe89dacc60
Reviewed-on: https://chromium-review.googlesource.com/c/1455054
Commit-Queue: danakj <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629674}(cherry picked from commit 953af059bdfdcfe77ba3dd49d96d484d425b94a0)
Reviewed-on: https://chromium-review.googlesource.com/c/1464602
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#370}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.36
[email protected]
Change-Id: I9a28324afc43efeeb0c4ff9f8e595e52c2d9bee8
Reviewed-on: https://chromium-review.googlesource.com/c/1466190
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#369}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 merge] Settings WebUI: Tweak logic that shows sync cancel dialog.
The code was triggering a navigation from within a currentRouteChanged
observer, which triggers another round of observer notifications, which
resulted in observers getting in a weird state.
Unfortunately triggering a navigation from within such an observer is not
well suported from the routing mechanism (no such use case previously AFAIK).
Fixed by yielding first, such that all observers finish, before triggering
a new navigation.
Bug: 929026
Change-Id: Iee89af435bb2c8a7c738622abdc45d568173d07b
Reviewed-on: https://chromium-review.googlesource.com/c/1460398
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630287}(cherry picked from commit 74132fcd943d3e50e97cb71ae2ec9b95da3e064c)
Reviewed-on: https://chromium-review.googlesource.com/c/1463863
Cr-Commit-Position: refs/branch-heads/3683@{#368}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[midi] Stop calling back to MidiManager when it's already been destroyed
This is a speculative fix for a crash. When midi::MidiManagerAndroid
is destructed, notify that to the Java counterpart to avoid calling
methods on the destroyed instance.
Bug: 921349
Change-Id: I699cdf433af61e750709b7a132d464e6875764ad
Reviewed-on: https://chromium-review.googlesource.com/c/1420505
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629053}(cherry picked from commit aa649e688dd4b3909db7c44f66b5502e10d18bb3)
Reviewed-on: https://chromium-review.googlesource.com/c/1466209
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#367}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add hit test for TabGridBottomToolbar in transparent layout.
If the bottom toolbar of tab grid is not in compact layout or remote
tabs page, it is transparent and should not respond to tapping events
unless the new tab button is being tapped, so that user can tap the
tabs behind the toolbar.
Bug: 924106
Change-Id: Ie6406d23553bcb168053688f89c0a90fc2eee3ae
Reviewed-on: https://chromium-review.googlesource.com/c/1460443
Commit-Queue: edchin <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630607}(cherry picked from commit 7027a4bf04585c92836f85ede9a7490303c4d191)
Reviewed-on: https://chromium-review.googlesource.com/c/1466208
Reviewed-by: Yi Su <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#366}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.35
[email protected]
Change-Id: I21a8fc3a5d663d2740b5f01dec0ec254bb6e326b
Reviewed-on: https://chromium-review.googlesource.com/c/1465301
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#365}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Refresh ChromeVox CommandStore
1. make updates so that the ChromeVox menus are up to date (e.g. remove the prefix key command, remove the ChromeVox activate/deactivate command from the menus).
2. apply the |disallowOOBE| bit to appropriate commands; remove it from the help command.
3. add support for |disallowOOBE| to CommandHandler
Bug: 921803
Change-Id: Ia3ff73c90b2c4aa94a455ccd9cc15ec20f4c0a41
Reviewed-on: https://chromium-review.googlesource.com/c/1436016
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626259}(cherry picked from commit 89f913aec977870d461449e0e8ae00727db5121e)
Reviewed-on: https://chromium-review.googlesource.com/c/1464721
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#364}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Reland "Fix webRequest issues with redirects and extraHeaders listeners"
This is a reland of 11f8a9d470fe97e7ae5ed79ce313bc82a681a0c7
The original change didn't quite fix all instances of this crash, there
was still a way it could happen if events happened to be timed exactly
right, and webRequest listeners were set up exactly right. This fix
should be much more bulletproof. Instead of sending the header events
through the TrustedURLLoaderHeaderClient, I switched to having
TrustedURLLoaderHeaderClient send a per-loader client that handles the
header events. This allows each InProgressRequest to own it's header
client, so it can close the connection to the client, or pause messages,
which makes it a lot simpler to make sure we are getting the events
correctly.
See diff from Patchset 1 for diffs from the original change.
Original change's description:
> Fix webRequest issues with redirects and extraHeaders listeners
>
> This is an alternative fix for http://crbug.com/918761, since the
> original fix in http://crrev.com/c/1409915 caused some other issues and
> had to be reverted (see http://crbug.com/926606).
>
> There are two issues that this fixes, both have regression tests in
> this CL:
>
> (1) If a request using extraHeaders was redirected, it's possible the
> OnBeforeSendHeaders event can come in from //net before
> OnBeforeRequest has finished running on the newly redirected URL. This
> was the cause of the crash, because it could cause situations like:
> - request made to a.com
> - redirect to b.com
> - blocking listener running for OnBeforeRequest on b.com
> - //net sends OnBeforeSendHeaders for b.com
> - OnBeforeSendHeaders listener runs for b.com <- bad, should wait until
> we know if OnBeforeRequest will cancel/redirect the request
> - OnBeforeRequest finishes for b.com, may redirect the request and run
> OnBeforeSendHeaders again before the bogus one is done
>
> This is fixed by holding the OnBeforeSendHeaders event until we know
> OnBeforeRequest is finished, and canceling the old request if there is
> a redirect.
>
> (2) If a request without a listener using extraHeaders redirects to a
> request with a listener using extraHeaders, the listeners for the
> redirected request will not get the additional headers.
>
> This is fixed by always using the extraHeaders path if there is any
> extraHeaders listeners registered for the context.
>
> Bug: 918761
> Change-Id: I879ee6a78d34348fc15a80c27613b7ffbe66e749
> Reviewed-on: https://chromium-review.googlesource.com/c/1446367
> Reviewed-by: Ken Rockot <[email protected]>
> Commit-Queue: Clark DuVall <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#628905}
Bug: 918761
Change-Id: I4e6b47e981130ddebf25764fc0ba97ad1fda6c9c
Reviewed-on: https://chromium-review.googlesource.com/c/1457233
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630357}(cherry picked from commit d60317bbdadd68d3e636cc03a11c321737fdf7e2)
Reviewed-on: https://chromium-review.googlesource.com/c/1465121
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#363}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add InstallActivity to manifest, fix bug in ArCoreJavaUtils
InstallActivity entry needs to be placed in base module's manifest
as we do not refresh application context after successful AR module
installation.
Bug fix for incorrect callback being called on successful AR module
installation.
Bug: 926225
Change-Id: I45c448d89d3b5aa15b81c38ef9ffc60d5a0a6308
Reviewed-on: https://chromium-review.googlesource.com/c/1459797
Commit-Queue: Piotr Bialecki <[email protected]>
Auto-Submit: Piotr Bialecki <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630452}(cherry picked from commit 126551d32ed170f60a36e9ec7eae525e4521a894)
Reviewed-on: https://chromium-review.googlesource.com/c/1464659
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#362}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge M73] Revert "Fix OEM app position issue"
This CL breaks OEM folder support and make in general unusable.
Tried to verify new default apps set for caroline/kevin and found
this regression. Manually verified this revert and OEM folder is
back and stable.
Bug: 909611
Bug: 930418
Original change's description:
> Fix OEM app position issue
>
> Change:
> Sync the OEM app position if it is in a folder.
>
> Bug: 909611
> Change-Id: Ibc1a8363b94abb5413a509c298dd21aca4f766d5
> Reviewed-on: https://chromium-review.googlesource.com/c/1358005
> Commit-Queue: Weidong Guo <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#613869}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 909611
Change-Id: I5555873e08c555c4a1f944f04e7755bf7ba748ea
Reviewed-on: https://chromium-review.googlesource.com/c/1464601
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Auto-Submit: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630888}(cherry picked from commit b55e39032bdcc89a833e1f4dcef03b211cd2a744)
Reviewed-on: https://chromium-review.googlesource.com/c/1464656
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#361}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Add inline update infobar support
This adds the infobars that are required for the update inline UI flow.
The includes the following:
- Adding support for setting clickable link text to the
SimpleConfirmInfoBarBuilder.
- Adds a new UpdateStatusProvider observer called
UpdateInfoBarController that handles reflecting the current inline
update status as an infobar in the UI.
BUG=922712
Change-Id: Ifd39d1c67c908779b7d97bb43a497d037692ee4a
Reviewed-on: https://chromium-review.googlesource.com/c/1419178
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629224}(cherry picked from commit f5aead926c7636edf91d98a8c486823eb5900e09)
Reviewed-on: https://chromium-review.googlesource.com/c/1464653
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#360}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incognito icon: ensure glasses bridge gets its own path
This was causing a weird discontinuity in retina.
Bug: 924484
Change-Id: Idaefc7933a69fbb46cfbe8180e1df02161067d0b
Reviewed-on: https://chromium-review.googlesource.com/c/1450213
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628457}(cherry picked from commit e7a64da69a6d5209571bbbbc54bfbfb3d028c914)
Reviewed-on: https://chromium-review.googlesource.com/c/1464879
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#359}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Update incognito icon
See mock in attached bug. This adds a circle around the current icon
and tints the circle, leaving the current icon clear.
Bug: 924484
Change-Id: Ia6633bd658ca3a66e088e115b6e230fd625d464d
Reviewed-on: https://chromium-review.googlesource.com/c/1446315
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627736}(cherry picked from commit 3df986fcc465019e7528d133c93121b8e079be27)
Reviewed-on: https://chromium-review.googlesource.com/c/1464660
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#358}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}content[android]: Reset hardware accelerated crash tracking on GPU init.
The browser keeps a track of concurrent GPU process crashes before
context initialization succeeds, to detect GPU process instability and
fallback to a software mode, or crash in the case of Android.
Since this counter is only reset on successful context initialization,
it can create a scenario where if the GPU process is initialized
repeatedly but without context requests (likely if the app is
backgrounded and some code still requests a Gpu channel), the counter
will be hit sooner and crash the browser.
The change is meant to validate whether the above theory could be true
and fixes a spike in these intentional browser crashes for M72.
R=[email protected]
Bug: 927130
Change-Id: I9f1bdf13e07694b2ca3bebb3fa90334df8dcfc8a
Reviewed-on: https://chromium-review.googlesource.com/c/1453361
Reviewed-by: Bo <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629203}(cherry picked from commit 2bf6ad6c9aa4f5e723a69cd9817e7c3b9513f9e7)
Reviewed-on: https://chromium-review.googlesource.com/c/1464280
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#357}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Merge to M73] Fix handling of same-skeleton domains in IDN spoof checker
A previous fix for bug 898343 attempted to handle skeletons that are the same as their domains (e.g. test[.]net).
The fix introduced an early return which caused skeleton lookups to incorrectly match subtrings:
If a domain name contained a top domain as its prefix, spoof checker assumed a skeleton match without checking if it reached the end of the search string (i.e. the skeleton being looked up).
E.g. Skeleton of atést[.]net (atest[.]net) matched the skeleton of test[.]net (test[.]net).
This CL properly checks that all of the search string is consumed before returning a match.
[email protected]
(cherry picked from commit 3035169b30108df8004c43651a814cdfa22b70b7)
Bug: 925199
Change-Id: Ia548ea686915463e0f93e6bce1bad5721f324821
Reviewed-on: https://chromium-review.googlesource.com/c/1437716
Commit-Queue: Mustafa Emre Acer <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626867}
Reviewed-on: https://chromium-review.googlesource.com/c/1464427
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#356}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Downloads WebUI: update item using notifyPath to only rerender single item
Bug: 927117
Change-Id: I85f316034aaea958c18509a6a319feb9a5335476
Reviewed-on: https://chromium-review.googlesource.com/c/1450418
Commit-Queue: Esmael El-Moslimany <[email protected]>
Auto-Submit: Esmael El-Moslimany <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629356}(cherry picked from commit 2e6a3bddac0aff89c5ff415e9c1cd4da804280ef)
Reviewed-on: https://chromium-review.googlesource.com/c/1464642
Reviewed-by: Esmael El-Moslimany <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#355}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Resize BVC contentView webView as necessary.
Followup to crrev.com/c/1435965, update the contentView frame as well.
Bug: 848789
Change-Id: Iab1416e5a91fa1fbfd8bd73991759230e0ec99ab
Reviewed-on: https://chromium-review.googlesource.com/c/1446231
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627599}(cherry picked from commit 36ee6fa905a355d0ebabe821ae927cc77845b256)
Reviewed-on: https://chromium-review.googlesource.com/c/1464619
Cr-Commit-Position: refs/branch-heads/3683@{#354}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Move UpdateCompositedSelectionIfNeeded() after pre-paint.
This makes it safe to use property trees and LayerState
on GraphicsLayers.
Bug: 929028
Change-Id: I5b6ca533b0c3c4c30e5f6f75132064f0d4b7b987
Reviewed-on: https://chromium-review.googlesource.com/c/1459518
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630119}(cherry picked from commit 0d92c74421e51eb58c2ae3f66840ca275dee2e6a)
Reviewed-on: https://chromium-review.googlesource.com/c/1464599
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#353}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[ios] Always keep the webState view in the view hierarchy.
It seems when a WKWebView instance (in this case |contentView|) is quickly
removed and re-added to the view hierarchy the WebKit process may quickly
suspend and restore itself. This edge case leads to some webpages to failing
to properly load. (crbug.com/848789). Keeping the webState view always in the
view hierarchy seems to prevent this from happening.
This is a very similar fix to crbug.com/739390, which we thought was fixed in
iOS 11.3. The revert for this old fix happened a few milestones before 848789
was filed so it's likely they are related.
[email protected]
(cherry picked from commit cd633aff8c9423ed0fdf6199264b5aca9269bd1d)
Bug: 848789
Change-Id: Ia079fee20892e9faefe2ff0e10baa543cdfa7b1f
Reviewed-on: https://chromium-review.googlesource.com/c/1435965
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627127}
Reviewed-on: https://chromium-review.googlesource.com/c/1464423
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#352}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Settings WebUI: Delete Management page
Management page was punted to M74.
To ensure safety removing this page from branch:
remove it from master first, then merge this CL to branch.
Page could be reverted back in case chrome://management
will be not ready before M74 (which is unlikely, but could happen).
[email protected]
(cherry picked from commit 6864b393c8b5e36a6eb91eb0f277d0ea8f5b50d7)
Bug: 879146
Change-Id: I4ba7324de794d7422d52c6e2b6a5e16af58d2da9
Reviewed-on: https://chromium-review.googlesource.com/c/1443014
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Roman Aleksandrov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629134}
Reviewed-on: https://chromium-review.googlesource.com/c/1464302
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#351}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Global Media Controls] Add fieldtrial testing config for media keys
Bug: 929978
Change-Id: Ic338211bde15798dc88aed817d9030c7110e04aa
Reviewed-on: https://chromium-review.googlesource.com/c/1447259
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628014}(cherry picked from commit c3052fce896b4a7b72ffff54e29b08e800417492)
Reviewed-on: https://chromium-review.googlesource.com/c/1464204
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#350}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Tablet tabs should not have website themes
Tablet tabs are currently using the website theme color. This wasn't
an issue before because tablets didn't use colors but now that the
menu button is themed this is a problem. This CL makes it so tablets
ignore the website theme and just use default theming.
Bug: 929971
Change-Id: I06b1152245ff9547a4b6b71db291e0c175e08460
Reviewed-on: https://chromium-review.googlesource.com/c/1460400
Commit-Queue: Pedro Amaral <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630532}(cherry picked from commit ffa9a586ce722af68ba4b2e69b4572b9c7f76d85)
Reviewed-on: https://chromium-review.googlesource.com/c/1464323
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#349}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Simplifying Native Page Theming and Background Coloring
Native page theming and background colors are confusing. I believe
the correct behavior for native pages is to have theming be done
only based on incognito state which means we can use
TabThemeColorHelper#getDefaultColor() as the native page's theme color.
As for background color all BasicNativePages except for IncognitoNTP
have the background color set to modern_primary_color. IncognitoNTP
has it set to ntp_bg_incognito. So I made
BasicNativePage#getBackgroundColor() return modern_primary_color and
overrode that method in IncogitoNTP to return the ntp_bg_incognito color.
Bug: 927692
Change-Id: I85065739a27074949e7b4636d82d0ac11d6f021c
Reviewed-on: https://chromium-review.googlesource.com/c/1453551
Commit-Queue: Pedro Amaral <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629609}(cherry picked from commit 847f5c7a2b5f923a3cd18ccbb05c9a726669e9a8)
Reviewed-on: https://chromium-review.googlesource.com/c/1464322
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#348}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}cc: Disable translucent solid color layers in Mac.
This CL prevents the relaxation introduced in
https://crrev.com/c/1387385 from taking effect in Mac. The reason is
that solid color quads that are not fully opaque are not being displayed
with the right transparency in that OS. This is a temporary fix until
that bug is addressed.
Test: issue in bug is no longer seen on a macOS Sierra 10.12.6.
Bug: 922899
Change-Id: Id24b07e767ef89f75a2d961d16a6887a19c9835a
Reviewed-on: https://chromium-review.googlesource.com/c/1450875
Reviewed-by: enne <[email protected]>
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628869}(cherry picked from commit 48e2ce8019bf69e38fd6f2aedeb890567d189b93)
Reviewed-on: https://chromium-review.googlesource.com/c/1464279
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#347}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] Settings: Fix race condition in MainPageBehavior.
The race condition manifested when transitioning from a subpage to
another sibling subpage, and caused the showing-main-page event to
erroneously be fired after the subpage-expand event.
Bug: 928082
Change-Id: If66e0d0e62cda2d1310dddc067429ca6f7133368
Reviewed-on: https://chromium-review.googlesource.com/c/1459589
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630322}(cherry picked from commit fd4cbf5fef73648229cb186435f49db9e395d0cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1463920
Cr-Commit-Position: refs/branch-heads/3683@{#346}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] Reland "Disable managed UI for Unicorn accounts"
This is a reland of 27bdec41e1a04f12f59744b8450b63facbed98ae
Original change's description:
> Disable managed UI for Unicorn accounts
>
> Bug: 924836
> Change-Id: Ib03b926e770adcfe8678ee64ec2094c117724314
> Reviewed-on: https://chromium-review.googlesource.com/c/1436141
> Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
> Reviewed-by: Michael Wasserman <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#628790}
Bug: 924836
Change-Id: I5f92390bb9103d46eef5888bc64efd2ec2ee7a83
Reviewed-on: https://chromium-review.googlesource.com/c/1454228
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629263}(cherry picked from commit a445df3dabbf03b3b2b7cf1e70d93e3278335d0f)
Reviewed-on: https://chromium-review.googlesource.com/c/1464179
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#345}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix detection of UI language, measure Chrome resumes in wrong language
Having all translations for webview strings in the base module breaks
the use of current_detected_ui_locale_name as an indicator for the
current UI language. To fix this, move current_detected_ui_locale_name
into Chrome resources and, thus, prevent its translations being added
to base.
Furthermore, use the fixed current_detected_ui_locale_name to record
via UMA whether Chrome resumes in the wrong language. I.e. we support
the current system language but Chrome is not displayed in it. That can
happen if the user changes the language but the language split is not
installed in time.
Bug: 906082
Change-Id: I66de9ca528a1b716f693b7a74581c6e118d0b694
Reviewed-on: https://chromium-review.googlesource.com/c/1460176
Commit-Queue: Tibor Goldschwendt <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630545}
Reviewed-on: https://chromium-review.googlesource.com/c/1463982
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#344}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Previews] Fix issue with NoScript hiding LoFi at commit time
Bug: 929411
Change-Id: I4e25536f1ca51a5c8fbea87d8bd85e60b3fa99e5
Reviewed-on: https://chromium-review.googlesource.com/c/1457414
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Doug Arnett <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630030}(cherry picked from commit cc96634197b90370655726ef8446a6cb20be4d15)
Reviewed-on: https://chromium-review.googlesource.com/c/1464040
Reviewed-by: Doug Arnett <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#343}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Sync::USS] Fix outgoing bookmarks names on modern clients
Legacy clients expect non-empty "non_unique_name" by mangling the
bookmark titles (e.g. append a blank space to empty titles) before
committing them.
This CL is adding the corresponding mangling of bookmarks titles before
committing bookmarks from modern client for backward compatibility.
Bug: 930124
Change-Id: I4ddd8c5b7ff6867ebca9dab908aa28230f6d4649
Reviewed-on: https://chromium-review.googlesource.com/c/1461124
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Auto-Submit: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630424}(cherry picked from commit 7ea894b0c46af63716dabf6e3392664429b11508)
Reviewed-on: https://chromium-review.googlesource.com/c/1463864
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#342}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[Sync::USS] Fix bookmark duplication upon enabling sync
Legacy clients used to mangle with bookmark titles (e.g. by appending
a blank space to an empty title)
This CL makes sure that modern clients respect that when merging
remote and local bookmarks hierarchies.
In addition, this CL adds the unit test and integration test coverage
for that scenario!
Bug: 930124
Change-Id: Ia3907e22a651000e5d7645d614e0f7a482298503
Reviewed-on: https://chromium-review.googlesource.com/c/1459546
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630315}(cherry picked from commit 9cdf14568b4aaa89fd1d9ae194e13e64f18a3f4f)
Reviewed-on: https://chromium-review.googlesource.com/c/1463565
Cr-Commit-Position: refs/branch-heads/3683@{#341}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Call ServiceWorker deletion callback early in case of error
ServiceWorker deletion consists of two steps: unregistration and
deletion. If there is an error during unregistration, the deletion
might not occur. To catch this error and avoid waiting infinitely
for deletion, the error is reported immediately, ignoring all
remaining expected calls.
Bug: 927474
Change-Id: Ic71c8957e9cb6b78f4e2a54c25d450d74ef771bc
Reviewed-on: https://chromium-review.googlesource.com/c/1454549
Commit-Queue: Christian Dullweber <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629526}(cherry picked from commit 66524655c28ca718ad32d6b8f53c2bf064ebeaa4)
Reviewed-on: https://chromium-review.googlesource.com/c/1463450
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#340}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Lite Mode Rebrand: Fix up preference title
Found a much cleaner way to do this while fixing the bug.
Bug: 928682
Change-Id: Ic6fe40fff2394b9833bc36b15eb8217115a8bc47
Reviewed-on: https://chromium-review.googlesource.com/c/1455046
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629318}(cherry picked from commit 4bfc51c4e2d6b926fb85e32905c52bc12238b3e2)
Reviewed-on: https://chromium-review.googlesource.com/c/1463881
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#339}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[EoS] Fix background task scheduling
When we added a helper function to compute enabled state from the
variation the boolean condition was reversed, causing clients that
are enabled to cancel their background task (and not do any processing)
and the clients that are disabled to continue to do work.
Bug: 929371
Change-Id: I168b01644d0248c98a9af78cc7f674d541584fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1456985
Reviewed-by: Cathy Li <[email protected]>
Commit-Queue: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629762}(cherry picked from commit bec5437196321e1d980a981218bddcd9a90cdeee)
Reviewed-on: https://chromium-review.googlesource.com/c/1463919
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#338}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Remove spellcheck, SBER from opt-in dialog
- The bullet points for spellcheck and SBER are removed from
the opt-in dialog.
- All icons are removed (incl. added resources).
Screenshot before:
https://drive.google.com/file/d/1rwQxsSXduaKl6wlLabNZcWXqsI2_wYls/view?usp=sharing
Screenshot after:
https://drive.google.com/file/d/14hz94bX7SgwY621E5kZGCpfGaYlLqnEh/view?usp=sharing
Bug: 927423
Change-Id: Ie34e2b92ab21cc8053b2ac534a7b6caf1df1c3db
Reviewed-on: https://chromium-review.googlesource.com/c/1455949
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629721}(cherry picked from commit 3a8d214bdd9810a69ee786edeb8abfbba3e27aab)
Reviewed-on: https://chromium-review.googlesource.com/c/1463862
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#337}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[unified-consent] Do *not* enable Google services during opt-in
- Google services in the service client are marked as
not-supported, so they will *not* be turned on during opt-in.
- UrlKeyedAnonymizedDataCollection is still part of the opt-in
and will get turned on.
Note: This CL is kept small for an easy merge back. In a follow
up, all dead code will be removed.
Bug: 927423
Change-Id: Ia853cef207dbbe86360de45c8a6bfd4195d1b3d2
Reviewed-on: https://chromium-review.googlesource.com/c/1449598
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628312}(cherry picked from commit 74c7050aed4bfdcd82741715c25f76910f5d4438)
Reviewed-on: https://chromium-review.googlesource.com/c/1463448
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#336}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[M73 Merge] Settings WebUI: Fix managed UI header not showing up in Polymer 1.
The Polymer observer which updates the header visibility was not
executing on startup because |showingSubpage_| is initially undefined.
Worked fine in Polymer 2 because of different observer behavior
semantics.
Bug: 929834
Change-Id: I9061bf701d90411bf76e1dc2d12a3830ca6199be
Reviewed-on: https://chromium-review.googlesource.com/c/1459798
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630139}(cherry picked from commit 26efe9986211956e212cb415e1b4d1a2b0632a1f)
Reviewed-on: https://chromium-review.googlesource.com/c/1463880
Cr-Commit-Position: refs/branch-heads/3683@{#335}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Merge "Init MachineLevelUserCloudPolicyStore after enrollment failure."
Merge into M73.
Mark store as initialized if enrollment is failed and unblock Profile creation.
Bug: 929898
Change-Id: I18d43e82465f9c5748e5299552c24784d9d34a90
Reviewed-on: https://chromium-review.googlesource.com/c/1459981
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#630375}(cherry picked from commit a6f69c981c41dad44b3b741065e6cacebe3f556c)
Reviewed-on: https://chromium-review.googlesource.com/c/1463879
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#334}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}[vr] Request VR module on intent rather than on pre inflation startup
This fixes a bug where Chrome is left in the black state after resuming.
(cherry picked from commit d57bbe24a5a35d92f62411301cdf3441a2ec7f19)
Bug: 927031
Change-Id: I5c7bf3b0a4d0e3c2a0ee4f6fe7bac5193b80bf00
Reviewed-on: https://chromium-review.googlesource.com/c/1456220
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629593}
Reviewed-on: https://chromium-review.googlesource.com/c/1463819
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#333}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.34
[email protected]
Change-Id: Ia57e09a93c828f5a95ec7dada421b72fece5b5d8
Reviewed-on: https://chromium-review.googlesource.com/c/1462209
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#332}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Fix inconsistent title bar theme usage when GTK theme is set
This CL ensures we consistently use GTK theme colours for PWA windows.
Before this change the title bar colour would use the GTK theme but
the title text would not; resulting in unreadable text for dark GTK themes.
This CL adds BrowserFrame::ShouldIgnoreTheme() as an equivalent to
BrowserNonClientFrameView::ShouldPaintAsThemed(). The latter cannot be
used everywhere due to initialisation order dependencies.
Deduping these functions is done in a separate CL
https://chromium-review.googlesource.com/c/chromium/src/+/1453217
in the interest of keeping this CL merge friendly.
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378056&signed_aid=KLS7LkKg4N2vijhbrVDErQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378057&signed_aid=_AbZIHu6j7Hwm57_i9KhRA==&inline=1
Bug: 927381
Change-Id: I308d8c3c0606cb54ba708cee1ec89a620c1f9d6c
Reviewed-on: https://chromium-review.googlesource.com/c/1453558
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629488}(cherry picked from commit f4da398d29d532c95bc47fd444245e307a66a9fd)
Reviewed-on: https://chromium-review.googlesource.com/c/1460286
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#331}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Incrementing VERSION to 73.0.3683.33
[email protected]
Change-Id: I6756df0de1f3d6e2f705ca2e95c28d4260996876
Reviewed-on: https://chromium-review.googlesource.com/c/1462203
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#330}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}Revert "[vr] Request VR module on intent rather than on pre inflation startup"
This reverts commit 2ca05885b269ca6fab0ab5bb639ce78c6c6440ba.
Reason for revert: Breaking the official build: crbug.com/930563
Bug: 930563
Original change's description:
> [vr] Request VR module on intent rather than on pre inflation startup
>
> This fixes a bug where Chrome is left in the black state after resuming.
>
> (cherry picked from commit d57bbe24a5a35d92f62411301cdf3441a2ec7f19)
>
> Bug: 927031
> Change-Id: Idc26d76ceff7b9555bd551ab84fa6af039291ba2
> Reviewed-on: https://chromium-review.googlesource.com/c/1456220
> Auto-Submit: Tibor Goldschwendt <[email protected]>
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Tibor Goldschwendt <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#629593}
> Reviewed-on: https://chromium-review.googlesource.com/c/1460191
> Reviewed-by: Tibor Goldschwendt <[email protected]>
> Reviewed-by: Ben Mason <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3683@{#297}
> Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 927031
Change-Id: I3c3cbe6489e43db7d96448f03a58e6dcbc719d07
Reviewed-on: https://chromium-review.googlesource.com/c/1462421
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#329}
Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
