Publish DEPS for 73.0.3642.0
Update DEPS for 3642 branching
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: I26aadd0c6f1f5ca7bf4700f20b93b51466c58ac9
Reviewed-on: https://chromium-review.googlesource.com/c/1379270
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3642@{#1}
Cr-Branched-From: b61e60a96d2968a281ec14b38cc5708163d468d7-refs/heads/master@{#616996}Landing Recent QUIC changes until 5:20 PM, Dec 10, 2018 UTC-5
Add constant for Ethernet MTU.
Merge internal change: 224882175
https://chromium-review.googlesource.com/c/chromium/src/+/1378634
Enable partial delivery on the length field for HttpDecoder.
API change. Not affecting existing behavior.
Merge internal change: 224879495
https://chromium-review.googlesource.com/c/chromium/src/+/1378633
QuicConnection changes to fix a segfault during quic::QuicDispatcher::OnCanWrite(). Protected by existing flag --quic_restart_flag_quic_check_blocked_writer_for_blockage.
Merge internal change: 224583378
https://chromium-review.googlesource.com/c/chromium/src/+/1378625
Do not add disconnected QuicConnection to dispatcher's write blocked list. Protected by FLAGS_quic_reloadable_flag_quic_connection_do_not_add_to_write_blocked_list_if_disconnected.
Merge internal change: 224570824
https://chromium-review.googlesource.com/c/chromium/src/+/1378410
Change QuicTimeWaitListManager::SendOrQueuePacket() to be protected, and return bool indicating whether packet was sent or queued.
Merge internal change: 224515605
https://chromium-review.googlesource.com/c/chromium/src/+/1377515
STOP_SENDING on closed stream does not close connetion.
Merge internal change: 224510444
https://chromium-review.googlesource.com/c/chromium/src/+/1377322
Check that stream ID for MaybeIncreaseLargestPeerStreamId is not too big
Merge internal change: 224498905
https://chromium-review.googlesource.com/c/chromium/src/+/1377321
Third step towards variable length QUIC connection IDs. This CL changes the size of the QuicConnectionId class to allow storing longer connection IDs. It also changes clients who were calling sizeof(connection_id) to instead use connection_id.length()
Merge internal change: 224446552
https://chromium-review.googlesource.com/c/chromium/src/+/1377514
Second step towards variable length QUIC connection IDs. This CL makes QuicConnectionId a class that contains a uint64_t. The next step will be to start changing the implementation of that class.
Merge internal change: 224240712
https://chromium-review.googlesource.com/c/chromium/src/+/1377513
Use BoringSSL's QUIC hooks in //third_party/quic
Merge internal change: 224237363
https://chromium-review.googlesource.com/c/chromium/src/+/1376733
Add repro e2e tests for server silently closed IETF connections.
Merge internal change: 223974948
https://chromium-review.googlesource.com/c/chromium/src/+/1375151
Add fuzzer for QpackEncoderStreamSender and QpackEncoderStreamReceiver.
Merge internal change: 223866872
https://chromium-review.googlesource.com/c/chromium/src/+/1375434
If a V44 QUIC connection is closed post-handshake and has no termination packet, add it to time wait list with action=SEND_STATELESS_RESET. Protected by default true flag FLAGS_quic_reloadable_flag_quic_send_reset_for_post_handshake_connections_without_termination_packets.
Merge internal change: 223857778
https://chromium-review.googlesource.com/c/chromium/src/+/1374494
[email protected]
Change-Id: I74e98f997975e3bcb319d89889d7752fc48025dc
Reviewed-on: https://chromium-review.googlesource.com/c/1378642
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616996}Roll src-internal 5bdce7eedbcb..8948c805d145 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5bdce7eedbcb..8948c805d145
Created with:
gclient setdep -r src-internal@8948c805d145
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I7f23991c2b7a5e01e824529275eaa48f742829f6
Reviewed-on: https://chromium-review.googlesource.com/c/1379344
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616995}Reland CHECKs that verify bookmark USS invariants
Relands invariant-checking logic reverted in
https://chromium-review.googlesource.com/c/1378135 after having fixed
the issue with the root node, which may not be tracked if the sync
data was supplied by the USS migrator.
[email protected]
Bug: 915198
Change-Id: I2e3db80d14d8f4a07bc395e1fec46ff9af6a7b8c
Reviewed-on: https://chromium-review.googlesource.com/c/1378857
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616994}aw: Add DrawFunctor native init
[email protected]
Bug: 900969
Change-Id: I9c8156fb5880f5ee95c73590f326cbd70fc0e131
Reviewed-on: https://chromium-review.googlesource.com/c/1378976
Reviewed-by: Bo <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616993}Roll src/third_party/chromite 3017a40dda25..6ecafca75711 (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3017a40dda25..6ecafca75711
git log 3017a40dda25..6ecafca75711 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] parallel_emerge: Make sure _lock_fn is set before starting workers.
Created with:
gclient setdep -r src/third_party/chromite@6ecafca75711
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ia067eb38dc09cf3c27c1c9f4ce1c6a6a2d565943
Reviewed-on: https://chromium-review.googlesource.com/c/1379343
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616992}Roll src/third_party/skia 282ec5dc6ca7..2e6db18c4309 (1 commits)
https://skia.googlesource.com/skia.git/+log/282ec5dc6ca7..2e6db18c4309
git log 282ec5dc6ca7..2e6db18c4309 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] use font instead of paint
Created with:
gclient setdep -r src/third_party/skia@2e6db18c4309
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: If3311f576e2201a88f658ff4250ae654474096a2
Reviewed-on: https://chromium-review.googlesource.com/c/1379341
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616991}Roll Fuchsia SDK from 14998eedc6c9 to 7e4b71a4511f
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
[email protected]
Change-Id: I5c7b1ff2e705f88d69f281d51884363e50e76feb
Reviewed-on: https://chromium-review.googlesource.com/c/1379342
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616990}Roll src-internal e05a6999debe..5bdce7eedbcb (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e05a6999debe..5bdce7eedbcb
Created with:
gclient setdep -r src-internal@5bdce7eedbcb
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I8dd43edc7043817c68babdb0414fd3f3f7e01a59
Reviewed-on: https://chromium-review.googlesource.com/c/1379466
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616989}Roll src/third_party/skia d4962e7e07c0..282ec5dc6ca7 (1 commits)
https://skia.googlesource.com/skia.git/+log/d4962e7e07c0..282ec5dc6ca7
git log d4962e7e07c0..282ec5dc6ca7 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Roll third_party/externals/angle2 f307584255da..7139b434210c (1 commits)
Created with:
gclient setdep -r src/third_party/skia@282ec5dc6ca7
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Id92895dad9ddab84ed89af80c24983d639ebd01c
Reviewed-on: https://chromium-review.googlesource.com/c/1379465
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616988}Roll src/third_party/angle f307584255da..7139b434210c (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/f307584255da..7139b434210c
git log f307584255da..7139b434210c --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Print a warning on unexpected internal errors.
Created with:
gclient setdep -r src/third_party/angle@7139b434210c
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:914911
[email protected]
Change-Id: Idc2893e4d44b9806592fad7c1b8a203905ec4b5f
Reviewed-on: https://chromium-review.googlesource.com/c/1379388
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616987}[code coverage] Enable parallel fuzzing and increase memory cap.
In https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-code-coverage/1491,
sqlite3_ossfuzz_fuzzer runs out-of-memory (used: 4113Mb; limit: 4096Mb), and kept retrying, so
bump memory cap to 8192Mb because the Linux coverage bot has 204 GB memory.
TBR=inferno, mmoroz, liaoyuke
Change-Id: I65e7065fb5b10f4a6c0f145b57db533498239395
Reviewed-on: https://chromium-review.googlesource.com/c/1378661
Reviewed-by: Shuotao Gao <[email protected]>
Commit-Queue: Shuotao Gao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616986}Roll src/third_party/dawn e018292bed9c..28c1fba1c02e (1 commits)
https://dawn.googlesource.com/dawn.git/+log/e018292bed9c..28c1fba1c02e
git log e018292bed9c..28c1fba1c02e --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Validate CommmandBuffers aren't ended mid pass.
Created with:
gclient setdep -r src/third_party/dawn@28c1fba1c02e
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:914566,chromium:914641
[email protected]
Change-Id: I24d5b0e1608bb4bcdb9252dcf86c4bce87aaba37
Reviewed-on: https://chromium-review.googlesource.com/c/1379339
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616985}[FCP++] Replace priority queue with ordered set
In our current design of ImagePaintTiming, we use priority queue to sort the
records. The priority queue provides O(1) operation to find the largest and
last image in records. However, the current usage of priority queue has a design
problem. Priority queue depends on a comparison function to rank the entries.
The comparison function has an assumption that the properties involving
comparison remain constant during the whole life cycle. The current design has
violated this assumption.
In order to fix this issue, we use ordered set to replace priority queue.
Ordered set allows us to iterate on entries by order of size or time, whereas
priority queue doesn't allow iteration unless popping up the head entry.
The new design also has a detached_ids to record the nodes that are detached
from the DOM node. While looking up the largest and last image, the detached
image will be ignored until it's reattached.
Bug: 914933
Change-Id: I3728a375b4d622a8fa62911285e6b162504611e5
Reviewed-on: https://chromium-review.googlesource.com/c/1377726
Commit-Queue: Liquan (Max) Gu <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616984}DevTools: check filmStripModel for screenshots
filmStripModel may contain screenshots even if framesModel does
not contain frames.
[email protected]
Change-Id: I6ce986815fb6e330062759c54c2551b4c6a09a4e
Reviewed-on: https://chromium-review.googlesource.com/c/1379320
Reviewed-by: Alexei Filippov <[email protected]>
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616983}Roll src-internal 23491aaa17c0..e05a6999debe (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23491aaa17c0..e05a6999debe
Created with:
gclient setdep -r src-internal@e05a6999debe
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: If83854ff742b72a7b2ffca79313ae2e6e7de31d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379387
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616982}[AF] Fix reporting to Autofill.Wallet* diff histograms in Directory
This CL fixes how diff metrics are reported from wallet syncable
service. Unlike the USS implementation, it reported diff metrics on
every startup, leading to inconsistencies in number of samples (and also
to inconsistencies in the distribution of the values).
This CL makes sure we do not report on startup
(in MergeDataAndStartSyncing()) but only in real updates
(ProcessSyncChanges()).
Bug: 908905
Change-Id: I813cc9629febdecc3f10929a73345539e12eb842
Reviewed-on: https://chromium-review.googlesource.com/c/1373451
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616981}Roll src-internal fca921861bc5..23491aaa17c0 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fca921861bc5..23491aaa17c0
Created with:
gclient setdep -r src-internal@23491aaa17c0
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I96991ddd42588ab6708665d38a546b9c6cae2d76
Reviewed-on: https://chromium-review.googlesource.com/c/1379338
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616980}Roll src/third_party/chromite 62f4ccd8000d..3017a40dda25 (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62f4ccd8000d..3017a40dda25
git log 62f4ccd8000d..3017a40dda25 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] image_lib: always return directory path from LoopbackPartitions._Mount
Created with:
gclient setdep -r src/third_party/chromite@3017a40dda25
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I769e0c1889c42b99c326faec2594701f7a9ab60f
Reviewed-on: https://chromium-review.googlesource.com/c/1379337
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616979}Change QpackEncoderStreamSenderTests to use a mock delegate.
Since QpackEncoderStreamSender has been converted to use
QpackInstructionEncoder, it is guaranteed to call Delegate::Write() exactly once
per instruction sent. Document this in the header file. Also, this allows
tests to use a mock delegate, and have one expected call per instruction
encoded, which makes it easier to identify what fragment of the encoded data
belongs to each instruction.
This CL merges internal changes 222418576 and 225631270 by bnc.
Change-Id: Ibbb0d8c1c56711026e3e46eb2ecac503672f36ca
Reviewed-on: https://chromium-review.googlesource.com/c/1378577
Commit-Queue: Bence Béky <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616978}Roll Fuchsia SDK from 3747c1fea17d to 14998eedc6c9
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
[email protected]
Change-Id: I8aa40df0d64464213e449c84dd6c85f00a15f0bc
Reviewed-on: https://chromium-review.googlesource.com/c/1379386
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616977}Revert "Try capturing incorrect re-entrancy into DWriteFontProxy"
This reverts e630455cf22a85822e681f0c84134193aed73433.
The detection mechanism did not detect any crashes of this kind. While
it's still very likely that the crashes are caused by Mojo sync calls
reentrancy issues, the particular theory of this change did not seem to
match what's going on. We should perhaps try to capture the re-entrancy
of font calls at the Mojo level, or move the font calls to a separate
blocking thread to avoid interference with other Mojo calls.
Bug: 561873
Change-Id: If0a1ce3b20fdf1f12afe1440db5b7989659a5e47
Reviewed-on: https://chromium-review.googlesource.com/c/1378141
Commit-Queue: Dominik Röttsches <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616976}Roll src-internal e49b9b474823..fca921861bc5 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e49b9b474823..fca921861bc5
Created with:
gclient setdep -r src-internal@fca921861bc5
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I0c554e4dca2c2bab76e691fddc8fe36222758992
Reviewed-on: https://chromium-review.googlesource.com/c/1379385
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616975}Roll src/third_party/dawn 48485e36a80f..e018292bed9c (1 commits)
https://dawn.googlesource.com/dawn.git/+log/48485e36a80f..e018292bed9c
git log 48485e36a80f..e018292bed9c --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] WireAndFrontendFuzzer "wait" for all commands before freeing
Created with:
gclient setdep -r src/third_party/dawn@e018292bed9c
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:914620,chromium:914615
[email protected]
Change-Id: Ib1a2b27eb473d93b8f4fc1c274d5bd342fbc186c
Reviewed-on: https://chromium-review.googlesource.com/c/1378844
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616974}Roll src/third_party/skia 8b78d70b9a10..d4962e7e07c0 (1 commits)
https://skia.googlesource.com/skia.git/+log/8b78d70b9a10..d4962e7e07c0
git log 8b78d70b9a10..d4962e7e07c0 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Roll third_party/externals/angle2 a7af56be7a6c..f307584255da (2 commits)
Created with:
gclient setdep -r src/third_party/skia@d4962e7e07c0
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I2e8c612462323dd013f6054cbf2577094f3aee90
Reviewed-on: https://chromium-review.googlesource.com/c/1379336
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616973}Roll src-internal 2781da9c16d6..e49b9b474823 (4 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2781da9c16d6..e49b9b474823
Created with:
gclient setdep -r src-internal@e49b9b474823
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Id9510d283ce81444551520a8671f36441ab20e06
Reviewed-on: https://chromium-review.googlesource.com/c/1378843
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616972}Change parameter used to pass test expectations file paths
We are planning to remove the expectations_file parameter of the
telemetry.project_config.ProjectConfig class. We will be using the
new parameter, expectations_files instead.
[email protected]
Bug: chromium:835690
Change-Id: Id1137016018ff6fecee2022d4bc40c63915da0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1377179
Commit-Queue: Rakib Hasan <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616971}Roll AFDO from 73.0.3640.0_rc-r1 to 73.0.3641.0_rc-r1
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I49aaf434c12a553bf5c247a52bc749605cfc8d01
Reviewed-on: https://chromium-review.googlesource.com/c/1379335
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616970}Roll src-internal 930b50c1e83e..2781da9c16d6 (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/930b50c1e83e..2781da9c16d6
Created with:
gclient setdep -r src-internal@2781da9c16d6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I3d97450ae67bc02e63154644a27986c272804606
Reviewed-on: https://chromium-review.googlesource.com/c/1379334
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616969}Import wpt@4094d6ae8bba520103ebe4df08c60ea3f24a2fa4
Using wpt-import in Chromium c13111b74c4d84d72a05733de5317b5c8dd3c89c.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
6b1262920a "lazy-load: Increase timeout value to reduce flakes"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-align
NOAUTOREVERT=true
TBR=robertma
No-Export: true
Change-Id: I4da6168a110a66ea90a8ab49fe14387623556538
Reviewed-on: https://chromium-review.googlesource.com/c/1379318
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616968}Roll src/third_party/chromite 35c2661c2fba..62f4ccd8000d (4 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/35c2661c2fba..62f4ccd8000d
git log 35c2661c2fba..62f4ccd8000d --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] vm: GetImageDiskPartitionInfo returns a list now.
2018-12-15 [email protected] third_party: Add buildbucket generated proto bindings
2018-12-15 [email protected] cbuildbot: Pass -waituntilready to Tast.
2018-12-15 [email protected] chromeos_config: Specify enable_skylab for single model.
Created with:
gclient setdep -r src/third_party/chromite@62f4ccd8000d
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I55b28d0fb9f3205381695336bd87f135d53af47f
Reviewed-on: https://chromium-review.googlesource.com/c/1379333
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616967}Update V8 to version 7.3.157.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1cc5a5e6..b4e322e3
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I42b205454dbad5a74cbbafee6c6efac628068e52
Reviewed-on: https://chromium-review.googlesource.com/c/1379316
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616966}DevTools: properly dispose remote-debugging-pipe handles on Windows
CloseHandle method blocks indefinitely if file descriptor is blocked
on synchronous read.
This patch adds a CancelIoEx call to interrupt pending synchronous
read.
R=pfeldman
Change-Id: I90e838be58a6088fda8f927c9f06cfd832fc1adf
Reviewed-on: https://chromium-review.googlesource.com/c/1379314
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Andrey Lushnikov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616965}Roll src-internal 28343c4c9344..930b50c1e83e (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28343c4c9344..930b50c1e83e
Created with:
gclient setdep -r src-internal@930b50c1e83e
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I0ba5f31bf66a42bd04613748b4ebfe163d308da6
Reviewed-on: https://chromium-review.googlesource.com/c/1379332
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616964}Roll src/third_party/skia a1bded9a4f28..8b78d70b9a10 (1 commits)
https://skia.googlesource.com/skia.git/+log/a1bded9a4f28..8b78d70b9a10
git log a1bded9a4f28..8b78d70b9a10 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Update go_deps asset
Created with:
gclient setdep -r src/third_party/skia@8b78d70b9a10
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I011ff6e58d51576382f012bccd6941a3557ba2d0
Reviewed-on: https://chromium-review.googlesource.com/c/1378841
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616963}Replace a few occurrences of hardcoded kGoogleGrey100
Change-Id: I5e40d6af96f6d72ceefabb7af4ad3fac647e5c36
Reviewed-on: https://chromium-review.googlesource.com/c/1379085
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616962}Roll src/third_party/webrtc 94f107454e3e..adae52b58844 (4 commits)
https://webrtc.googlesource.com/src.git/+log/94f107454e3e..adae52b58844
git log 94f107454e3e..adae52b58844 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Roll chromium_revision 84fedb7e68..31225b9c5f (616714:616901)
2018-12-14 [email protected] Roll chromium_revision 6d37479eb8..84fedb7e68 (616603:616714)
2018-12-14 [email protected] Added new feature to print a text log to neteq_rtpplay
2018-12-14 [email protected] Revert "Switch to logdog binary provided by IMPLIED_CIPD_BINARIES"
Created with:
gclient setdep -r src/third_party/webrtc@adae52b58844
The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
BUG=chromium:None,chromium:None,chromium:b/116685514,chromium:755660
[email protected]
Change-Id: I04cb1cceee652c9ba5249358d331fe4b0f1bdf3e
Reviewed-on: https://chromium-review.googlesource.com/c/1379328
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616961}[code coverage] Remove libfuzzer_tests from fuzzer target list.
libfuzzer_tests is not a fuzzer, and was incorrectly added as a fuzzer target.
TBR=jbudorick
Change-Id: Ie10441735782b9a971087a23b86eff8fa991c732
Reviewed-on: https://chromium-review.googlesource.com/c/1379317
Commit-Queue: Shuotao Gao <[email protected]>
Reviewed-by: Abhishek Arya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616960}Roll Fuchsia SDK from f65ab9f9fe2a to 3747c1fea17d
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
[email protected]
Change-Id: If3b4af3e635cd0ffc07efff486c8cf9d932fdf18
Reviewed-on: https://chromium-review.googlesource.com/c/1379330
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616959}Re-enable support for sending HTTPS URLs via QUIC proxies, but only when
the finch param enable_quic_proxies_for_https_urls is set.
This effectively reverts
https://chromium-review.googlesource.com/c/chromium/src/+/1375112
and then fixes the underlying bug.
Bug: 914497,335275
Change-Id: Ief24db4226c9d063219ab7df20cf72f23973be23
Reviewed-on: https://chromium-review.googlesource.com/c/1377709
Commit-Queue: Ryan Hamilton <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616958}Roll src-internal 99e2e468c5b0..28343c4c9344 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99e2e468c5b0..28343c4c9344
Created with:
gclient setdep -r src-internal@28343c4c9344
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I9de06adfc185beb9863ba13e0f90db3ec13affff
Reviewed-on: https://chromium-review.googlesource.com/c/1379329
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616957}Import wpt@ac4274136e9a034628a3a469890c8e37babbc902
Using wpt-import in Chromium ca6fe49cee5878b633e2c4db369badee65d0ce26.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
6b1262920a "lazy-load: Increase timeout value to reduce flakes"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
TBR=robertma
No-Export: true
Change-Id: I6a26ab571eab85cfa59292330894276b1a300010
Reviewed-on: https://chromium-review.googlesource.com/c/1378911
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616956}Enable ProofTest.Verify.
Inspired by pkasting's email, I noticed this...
It seems to work these days. Maybe the BoringSSL switch? The bug has
some error coming out of NSS.
Bug: 514468
Change-Id: Ic0ba0af9b19019fea230e9ca171e2daf09fccbb2
Reviewed-on: https://chromium-review.googlesource.com/c/1378817
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616955}Use a wrapper for creating binary NetLog values.
This renames the "hex_encoded_bytes" parameter to "bytes" (Base64 encoded).
The motivation is to move towards a consistent approach for how binary data is encoded.
Bug: 657115
Change-Id: I4762ee774682a0376979d779ac1faa177d2b8701
Reviewed-on: https://chromium-review.googlesource.com/c/1378845
Commit-Queue: Ryan Hamilton <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616954}Initialize GL static bindings before dynamic bindings
Currently static bindings are initialized as side-effect of calling
MakeCurrent on the native GLContext implementation. When virtualized
contexts were enabled on Linux AMD, passthrough tests started failing
because of uninitialized static bindings presumably because MakeCurrent
is being skipped somehow due to interaction between ANGLE and
GLContextEGL.
Bug: 914976
Change-Id: I7366176a9f0a74e0f5a379eef3c230f0152b7310
Reviewed-on: https://chromium-review.googlesource.com/c/1378975
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616953}Roll src/third_party/angle 9a51daf61408..f307584255da (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/9a51daf61408..f307584255da
git log 9a51daf61408..f307584255da --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Use intent-filter to enforce that only a single ANGLE APK is present
Created with:
gclient setdep -r src/third_party/angle@f307584255da
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I9fdd4c746da1a43d77ec64b909644c27cad58513
Reviewed-on: https://chromium-review.googlesource.com/c/1379327
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616952}Roll src/third_party/pdfium 3de08dd61026..a0c36804be26 (12 commits)
https://pdfium.googlesource.com/pdfium.git/+log/3de08dd61026..a0c36804be26
git log 3de08dd61026..a0c36804be26 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Split part of xfa/fgas/BUILD.gn into xfa/fgas/layout/BUILD.gn.
2018-12-15 [email protected] Fix nits in CFX_TxtBreak and related code.
2018-12-15 [email protected] Avoid unnecessary list initialization in CJX_Object.
2018-12-15 [email protected] Remove most non-const reference parameters in CJX_Object.
2018-12-14 [email protected] Fix integer overflow in CFX_DIBBase::GetOverlapRect().
2018-12-14 [email protected] Give CFX_DIBBase::GetOverlapRect() a return value.
2018-12-14 [email protected] Break circular dependency between formfiller and pwl.
2018-12-14 [email protected] Remove non-const parameter in CXFA_ItemLayoutProcessor.
2018-12-14 [email protected] Merge CPWL_FontMap into CBA_FontMap.
2018-12-14 [email protected] Add CXFA_ItemLayoutProcessor::GotoNextContainerNodeSimple().
2018-12-14 [email protected] Get rid of some #defines in XFA code.
2018-12-14 [email protected] XFA: Avoid infinite recursion when deleting a ThisProxy object property.
Created with:
gclient setdep -r src/third_party/pdfium@a0c36804be26
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:914983,chromium:913566
[email protected]
Change-Id: Iec871196c04a7950c8d11dc53ef7bd2f59af2427
Reviewed-on: https://chromium-review.googlesource.com/c/1378840
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616951}Update V8 to version 7.3.156.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/199a74ed..1cc5a5e6
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I320c1455113764bab8d80df0fa1053107c1b624f
Reviewed-on: https://chromium-review.googlesource.com/c/1378912
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616950}Roll src/third_party/depot_tools c5ba34c644de..27c6e44188fb (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5ba34c644de..27c6e44188fb
git log c5ba34c644de..27c6e44188fb --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/depot_tools@27c6e44188fb
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I4a161a488b2af20b35b3c9e149be602277b4b2c5
Reviewed-on: https://chromium-review.googlesource.com/c/1379326
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616949}Roll src/third_party/dawn 8d7de591f4c9..48485e36a80f (1 commits)
https://dawn.googlesource.com/dawn.git/+log/8d7de591f4c9..48485e36a80f
git log 8d7de591f4c9..48485e36a80f --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Add StencilStateFaceDescriptor, in order to match web idl
Created with:
gclient setdep -r src/third_party/dawn@48485e36a80f
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I9e9217791c64e4d0c59b9527c1b966ad520bc2ed
Reviewed-on: https://chromium-review.googlesource.com/c/1378839
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616948}Chrome OS: Remove dead code of Host/Controller pairing screens.
Bug: 856337
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1fc6d0eff37bdb3f7c2175861782652ee028c4b2
Reviewed-on: https://chromium-review.googlesource.com/c/1114240
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Zachary Kuznia <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616947}Roll src-internal 1cb8f823840b..99e2e468c5b0 (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1cb8f823840b..99e2e468c5b0
Created with:
gclient setdep -r src-internal@99e2e468c5b0
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I7603e380b5480745c0f6905ae045886ed4d85dea
Reviewed-on: https://chromium-review.googlesource.com/c/1378838
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616946}Updating trunk VERSION from 3641.0 to 3642.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: I783b75703854c496a44b7a830ffb61b3fb08aeea
Reviewed-on: https://chromium-review.googlesource.com/c/1379116
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616945}Fix gradient background sizing
This is a hard-to-fix situation. We size generated background images
according to the tile size, which is a snapped rectangle sized according
to the destination values, in general. But then we compute a src rect
for image drawing using the unsnapped values, because that is best for
bitmap images where we want to pull out the most accurate src rect
possible. However, that source rect ends up larger than the tile size
due to rounding without the original offset in the layer (because now
we are working in image space).
The gradient painting code then sees that it has a src rect that is
larger than the tile size and hence the gradient image size. The code
thinks that we want to have some more pixels than the gradient
provides, which is true in some cases, and scales things to get those
extra pixels in the painted output. Hence empty pixels on the screen
when we really want the gradient to be filling the dest rect.
Changing the gradient painting code will break valid use cases. Changing
the tile size breaks things in a different way and doesn't really fix
the problem. So change the src rect computation to use snapped sizes
for generated content in an attempt to get a src that matches the tile
size.
[email protected]
Bug: 898950
Change-Id: I100575ad4f4fa3004fbc232a72c90b0032ccef4e
Reviewed-on: https://chromium-review.googlesource.com/c/1376814
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616944}Remove flattenhtml from Print Preview
With the update to GM2, locations in Print Preview that were using
inlined images have now been updated to iron-icons and .cr-icons, so
flattenhtml can be removed entirely in print_preview_resources.grd, and
replaced with preprocess in print_preview_resources_vulcanized.grd.
This requires modifying tools/grit/grit/node/include.py, to allow the
use of preprocess in <include>s.
Bug: None
Change-Id: If2b099b47ef136ff8487ea1cc812ce8f29d02036
Reviewed-on: https://chromium-review.googlesource.com/c/1377500
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616943}Roll src/third_party/perfetto 30fad333a22e..2ffa75e376e4 (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/30fad333a22e..2ffa75e376e4
git log 30fad333a22e..2ffa75e376e4 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Merge "Update Android.bp."
Created with:
gclient setdep -r src/third_party/perfetto@2ffa75e376e4
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I5b1f620776811d42b2d52a4bb0dc8a6fd9797c7f
Reviewed-on: https://chromium-review.googlesource.com/c/1379325
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616942}Update for RTCQuicStream.write() function.
Combines functionality of finish() into write() by adding a new
QuicStreamWriteParameters input parameter that includes a finish
boolean. This is consistent with the latest spec draft and also adds
symmetry between readInto() and write().
Bug: 874296
Change-Id: I0def0ca25587ebf00a4b179ce8e9e7a124c818f6
Reviewed-on: https://chromium-review.googlesource.com/c/1376720
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Steve Anton <[email protected]>
Commit-Queue: Seth Hampson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616941}Roll src/third_party/pdfium 1ab2757db271..3de08dd61026 (6 commits)
https://pdfium.googlesource.com/pdfium.git/+log/1ab2757db271..3de08dd61026
git log 1ab2757db271..3de08dd61026 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Remove some non-const references in CXFA_ItemLayoutProcessor.
2018-12-14 [email protected] Clean up FindBreakNode() inside CXFA_ItemLayoutProcessor.
2018-12-14 [email protected] Fix some nits in CXFA_NodeHelper.
2018-12-14 [email protected] Add comment to string_view_template.h about pass-by-value
2018-12-14 [email protected] Change XFA_GetElementByName() to take a WideStringView.
2018-12-14 [email protected] Pass ByteStringView by value
Created with:
gclient setdep -r src/third_party/pdfium@3de08dd61026
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I5496c8d080132c4cf3b253e3524b1b8b61a65a5b
Reviewed-on: https://chromium-review.googlesource.com/c/1378653
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616940}Roll src/third_party/skia af67819ee1d9..a1bded9a4f28 (9 commits)
https://skia.googlesource.com/skia.git/+log/af67819ee1d9..a1bded9a4f28
git log af67819ee1d9..a1bded9a4f28 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Roll third_party/externals/angle2 dfaccbc08abb..a7af56be7a6c (3 commits)
2018-12-14 [email protected] Fix stroked round capped circular arc batched with filled circle.
2018-12-14 [email protected] CG smoothing implies gamma blit.
2018-12-14 [email protected] [canvaskit] Canvas API for loading fonts
2018-12-14 [email protected] [canvaskit] Expose setVolatile (especially for animations)
2018-12-14 [email protected] Add another NVIDIA LSAN suppression.
2018-12-14 [email protected] Reduce the number of backend->pixelconfig GrCaps virtuals.
2018-12-14 [email protected] Avoid system fonts when fuzzing
2018-12-14 [email protected] protect against fuzz generated fLastMoveToIndex
Created with:
gclient setdep -r src/third_party/skia@a1bded9a4f28
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:b/119394958,chromium:901611,chromium:818769
[email protected]
Change-Id: I47033164a4df7fc2b617c556f07232bc1ee033b0
Reviewed-on: https://chromium-review.googlesource.com/c/1378836
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616939}DevTools: provide a way to fetch additional info for selected OM wrappers.
This patch exposes File wrapper details.
Change-Id: Ifad3ac3cbcad836729224ea4f5f3abc6a5f51a89
Reviewed-on: https://chromium-review.googlesource.com/c/1377341
Reviewed-by: Andrey Lushnikov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616938}Roll src/third_party/depot_tools 2eb7194395c7..c5ba34c644de (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2eb7194395c7..c5ba34c644de
git log 2eb7194395c7..c5ba34c644de --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/depot_tools@c5ba34c644de
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I136c50add4b97e15df1a45d8d6b3dc97a05be698
Reviewed-on: https://chromium-review.googlesource.com/c/1379024
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616937}Complete the screen capture color space plumbing.
Adds all remaining "plumbing" of color space information, throughout the
CopyOutputRequest execution pipeline and the FrameSinkVideoCapturer
pipeline. This ensures the color space being used to draw the original
RenderPass within the compositor is being specified in the metadata for
all result images.
DevTools: Remove a hack from the color picker tool, now that the color
space information for the screen capture frame is being provided.
browser_tests/content_browsertests changes: Multilple browser tests were
fixed as a result of this change revealing pre-existing bugs in the
tests: the web page layout of the color regions, how pixels were being
selected for analysis, and YUV→RGB color space conversion inaccuracies.
Blink layout tests: Rebased a number of layout test expectations, as the
the layout tests utilize the screen capture pipeline. I examined all of
these changed expectations to confirm near 0% change: Meaning that just
a tiny number of pixels in an image were imperceivably different because
of adding the missing color space info.
Bug: 758057, 8510131, 809835, 863103, 884170, 795132
Change-Id: I11056ddc4f501ee338dc3283397703747a395571
Reviewed-on: https://chromium-review.googlesource.com/c/1372894
Commit-Queue: Yuri Wiitala <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616936}Roll src-internal 9f1cdc9da7a6..1cb8f823840b (5 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f1cdc9da7a6..1cb8f823840b
Created with:
gclient setdep -r src-internal@1cb8f823840b
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:891313
[email protected]
Change-Id: I90eda2c4d44eb05a0d8c944808701c81c20ba57b
Reviewed-on: https://chromium-review.googlesource.com/c/1379022
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616935}GuestView: No TextInputManager when unattached
TextInputManager is created lazily the first time GetTextInputManager
is called on WebContents. Given that TextInputManager should only exist
for the outermost WebContents, there is no point in creating it for an
unattach guest WebContents only to clear it after attaching. Also, it
seems incorrect to try to access |text_input_manager_| for an unattached
guest WebContents.
Bug: 609846
Change-Id: I0b60a0a3160909f9d8c0b6a4c099c3f4769af0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1376090
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616934}Print Preview cleanup: Remove unnecessary MetricsContext subclasess.
Also convert MetricsContext to ES6 class syntax, and fix newly found linter
errors.
Bug: None
Change-Id: Icc4149d22f5c317d4a28ef633f584c43e7eab0d7
Reviewed-on: https://chromium-review.googlesource.com/c/1379179
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616933}Grit: Fix Polymer bindings when there are multiple url()s
Also moving all Polymer binding related testing to a separate test in
html_inline_unittest.py, including a new test case for this bug.
Bug: 914591
Change-Id: I463ada044f827ad3ca31566391984b20a275e993
Reviewed-on: https://chromium-review.googlesource.com/c/1374955
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616932}Remove a couple of stale comments about swapped-out RenderFrameHosts.
Bug: 357747
Change-Id: I384b2f3e484d7cb330417662df56f6371797e0ce
Reviewed-on: https://chromium-review.googlesource.com/c/1374041
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616931}ws: Queue input events on delivery, not dispatch.
Queue additional events generated by EventRewriters, as needed.
Refactor EventQueue to operate later, closer to EventSink delivery.
Eliminate HostEventQueue and [Test]HostEventDispatcher.
Use Shell via WSDelegate for EventInjector's display -> host lookup.
Update tests and setup code; add a queue unit test for host destruction.
Move content_browsertests' aura::TestScreen ownership to WMTestHelper.
TODO: Remove WindowTreeHost::event_sink(), use GetEventSink().
Alternate WIP sticky keys DCHECK workaround: https://crrev.com/c/1371878
Bug: 913549
Test: No SingleProcessMash sticky keys DCHECK, no input regressions.
Change-Id: I61d67af94fad0ed8414a7945160a7c231dca47a1
Reviewed-on: https://chromium-review.googlesource.com/c/1372629
Commit-Queue: Michael Wasserman <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616930}WebUI: Migrate 'Manage search engines' button to cr-link-row
Bug: 908325
Change-Id: Ifd84b8fcef8ed1ad074909cfecce6a7cfef31d52
Reviewed-on: https://chromium-review.googlesource.com/c/1376666
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616929}DevTools: allow resetting navigation history over protocol.
Change-Id: Iae6008c364972304b2233818ad64e62335605693
Reviewed-on: https://chromium-review.googlesource.com/c/1378851
Reviewed-by: Andrey Lushnikov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616928}Remove WebURLResponse::ExtraData
This is only used for effective_connection_type now, which
can easily move to InternalDocumentStateData.
Bug: 855189
Change-Id: Ic4ddd5268fa701513dee8a0759a153a35244294e
Reviewed-on: https://chromium-review.googlesource.com/c/1369942
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616927}[Android] Properly remove SuggestionSpan after composition
This CL:
1) Reads Spanned#SPAN_COMPOSING from Java side and propagate it to
Blink (SuggestionMarker).
2) Removes SuggestionMarker which has this flag after IME done with
composition.
We want to remove these SuggestionMarkers for
- InputConnection#commitText()
- InputConnection#setComposingText()
- InputConnection#finishComposing()
Note that before caret move event is covered by finishComposing().
Bug: 907928
Change-Id: I6245d7a2d43f54e7272d5abf6ea46b53f2f57ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1361727
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Shimi Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616926}Fix a race in headless virtual time & compositor tests
A lack of explicit start time for frame caused real time clock to
be used for frame start, which may cause next frame to be dropped
if its (virtual) timestamp is earlier.
Bug: 909043, 843734
Change-Id: I4a909be2e1e4f69f0834a87ffdb3d402c450adfc
Reviewed-on: https://chromium-review.googlesource.com/c/1379181
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616925}Minor changes to download protection to help diagnose crash
1. Add defensive check in DownloadProtectionService, in case it's being
deleted before the CheckClientDownloadRequest finishes.
2. Don't set item_ to nullptr anymore, always call RemoveObserver at
destruction. This will ensure that the destructor for
CheckClientDownloadRequest isn't being destroyed before the DownloadItem.
Bug: 915037
Change-Id: Ibd1ce1d2f11bee174b399a850ee86aa4a2808268
Reviewed-on: https://chromium-review.googlesource.com/c/1378853
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Nathan Parker <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616924}Send occlusion fraction to Wayland clients.
is sent to the Android side.
Bug: b/112668686
Bug: b/110011377
Test: Occlusion fraction changes upon remote surface losing focus and
Change-Id: Id622509a1eb504db945eb7c0b6c6db5256103d4d
Reviewed-on: https://chromium-review.googlesource.com/c/1179560
Commit-Queue: Eliot Courtney <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616923}Reland "Prevent restoring focus when the EndDrag minimizes the window""
Some gesture may minimize the window along with ending the drag,
but TabDragController::RestoreFocus in EndDragImpl() cancels
the minimization.
Previous CL was reverted due to test failures on release bot,
because sequence of touch events may not generate fling gesture
if it moves too fast. This CL introduces SimpleTestTickClock to
generate the fling gesture reliably.
[email protected]
Bug: 902897
Test: the new test case
Change-Id: I37cf7ce83a25d3fafbc9628515bae4c4185dabd6
Reviewed-on: https://chromium-review.googlesource.com/c/1379191
Reviewed-by: Jun Mukai <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616922}[skia] Temporarily disable Windows fuzzers
Change-Id: Id2a1cf299bfd2743106a05cba7fc3a60602dd4ad
Reviewed-on: https://chromium-review.googlesource.com/c/1379028
Commit-Queue: Jonathan Metzman <[email protected]>
Reviewed-by: Ben Wagner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616921}Roll src/third_party/chromite f15e4e6c0c9d..35c2661c2fba (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f15e4e6c0c9d..35c2661c2fba
git log f15e4e6c0c9d..35c2661c2fba --date=short --no-merges --format='%ad %ae %s'
2018-12-15 [email protected] cbuildbot/manifest_version.py: Use Gerrit autosubmit feature
Created with:
gclient setdep -r src/third_party/chromite@35c2661c2fba
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ibd8d7981c9069aa50ea3264f4c36fea9507ca46f
Reviewed-on: https://chromium-review.googlesource.com/c/1379224
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616920}Roll src/third_party/angle e1f742af18c5..9a51daf61408 (2 commits)
https://chromium.googlesource.com/angle/angle.git/+log/e1f742af18c5..9a51daf61408
git log e1f742af18c5..9a51daf61408 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Fix angle_apk build
2018-12-14 [email protected] Vulkan: Print the device id in the renderer string.
Created with:
gclient setdep -r src/third_party/angle@9a51daf61408
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I4e166fe516a77c2e72bb86bb57d233ad3d7bf982
Reviewed-on: https://chromium-review.googlesource.com/c/1378837
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616919}Import wpt@e183d8671bde035c7a0168a75119a5f80bd592cb
Using wpt-import in Chromium 40bbe3ee5fc19df9f86146f5d357aaf198d3dcce.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
6b1262920a "lazy-load: Increase timeout value to reduce flakes"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected]:
external/wpt/webrtc
NOAUTOREVERT=true
TBR=robertma
No-Export: true
Change-Id: I9a7268521df7e70187340a7bda8e0f7d9e8f4e70
Reviewed-on: https://chromium-review.googlesource.com/c/1379213
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616918}Roll src/third_party/perfetto 4447823aa71d..30fad333a22e (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/4447823aa71d..30fad333a22e
git log 4447823aa71d..30fad333a22e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Merge "profiling: Improve smoketest expectations."
Created with:
gclient setdep -r src/third_party/perfetto@30fad333a22e
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I327a35a69c9329c7290da5cda4a6afbd0ce040ea
Reviewed-on: https://chromium-review.googlesource.com/c/1379062
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616917}[Audio Focus] Observer should use request state
The AudioFocusObserver should use AudioFocusRequestState
instead of separate parameters for OnFocusGained/Lost. This
was not the case before because AFRS was added after the
observer.
We need this to expose the request id to clients so they
can get a MediaController that will only control a specific
session.
BUG=892771
Change-Id: I4f6e2e60de6dbc82f779ffbfec3d91628208c42d
Reviewed-on: https://chromium-review.googlesource.com/c/1363684
Commit-Queue: Becca Hughes <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616916}Update V8 to version 7.3.154.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a090245c..199a74ed
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I0b92d5c0b148d945c85e09383f623065226a448e
Reviewed-on: https://chromium-review.googlesource.com/c/1379048
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616915}Rename AXHostDelegate to AXActionHandler, part 2
Rename the files. The class was renamed in a separate CL to preserve
git history across the rename.
[email protected], [email protected], [email protected]
Bug: none
Test: compiles
Change-Id: Ib4d41840ab9c6146e0d6fcc34959c36153df8b32
Reviewed-on: https://chromium-review.googlesource.com/c/1379249
Reviewed-by: James Cook <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616914}viz: Always request presentation timestamp from clients.
Turn on CompositorFrameMetadata.request_presentation_feedback by
default. This would start sending presentation-feedback for every frame
submitted by a client. However, the presentation-feedback is now
included with the begin-frame messages (crrev.com/608235}, so there is
no longer an extra IPC per frame. There is one extra ipc that gets sent:
when the client submits the last frame, and does not want any more
begin-frames, it still receives a begin-frame carrying the
presentation-timestamp for the last submitted frame. But the cost of
this is small.
This now requires that submitted CompositorFrame has a valid token.
A viz::FrameTokenGenerator is introduced to facilitate creating the
tokens from the clients. A DCHECK() is also added in the serializer
to catch clients sending a CompositorFrame without a valid token.
After this stays in tree for a few days, a follow up CL will remove the
CompositorFrameMetadata.requested_presentation_feedback flag, and the
associated code.
TBR=fserb@ for third_party/blink changes.
TBR=Bo for android_webview/ changes.
TBR=oshima@ for ash/ and components/exo changes.
BUG=883592
Change-Id: I70b9b290cab5a31d6cc7597bd737402f9459c10f
Reviewed-on: https://chromium-review.googlesource.com/c/1375641
Commit-Queue: Sadrul Chowdhury <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616913}Add WebRTC-Audio-NetEqForceTargetDelayPercentile field trial to testing config
Bug: 912477
Change-Id: Ib3dc31223784bc8e1eb6d4aedcff30700782123a
Reviewed-on: https://chromium-review.googlesource.com/c/1365440
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Jakob Ivarsson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616912}Remove deprecated CustomFeedback flow for Android.
It was never launched and there are no plans to ramp it up
past the very, very old experiment.
BUG=913677
Change-Id: I66e22b3f16693a98104dcf56e5bb1dc8ac6fd786
Reviewed-on: https://chromium-review.googlesource.com/c/1372360
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616911}[DevTools] Move destructive buttons in DevTools > Application 4 tables
Destructive buttons in these tables are moved to the right to avoid
inadvertently clicked: LocalStorage, SessionStorage, IndexedDB > object
store, and Cookies. Note this is different from what the issue filer
was originally asking.
Bug: 892231
Change-Id: I112545afaf16c56651835c3097ce6ab58e7fa102
Reviewed-on: https://chromium-review.googlesource.com/c/1376491
Reviewed-by: Erik Luo <[email protected]>
Commit-Queue: Haihong Li (Harley) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616910}[PE] Fix DCHECK failure in scrolling background visual rect
Now use the same pixel snapping method for scrolling contents layer
used in CompositeLayerMapping to avoid the DCHECK failure. The scrolling
contents should originate from the pixel snapped clip rect.
Bug: 913843
Change-Id: Ibce87b324567f971516148f865608f00e80d4bee
Reviewed-on: https://chromium-review.googlesource.com/c/1378850
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616909}Remove unused variables
For CopyAndScaleSharedQuadState(), the scaling has been handled in
scaled_quad_to_target_transform. There is no need to pass in the x_scale and
y_scale.
Change-Id: I93b1d03a9bbbff33130cce0f4d72636fa1a52e46
Reviewed-on: https://chromium-review.googlesource.com/c/1379186
Reviewed-by: Sunny Sachanandani <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616908}[LayoutNG] A few small cleanups in flex code
- Don't use legacy when we don't have to
- Store NGBlockNode instead of NGLayoutInputNode
Bug: 845235
Change-Id: I99e48f7f69e4f53f0391e2cd542e117b501cb7d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379061
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616907}Roll src/third_party/webrtc 24779d82292e..94f107454e3e (1 commits)
https://webrtc.googlesource.com/src.git/+log/24779d82292e..94f107454e3e
git log 24779d82292e..94f107454e3e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Only use GetAudio events that correspond to an ssrc matching at least one incoming packet.
Created with:
gclient setdep -r src/third_party/webrtc@94f107454e3e
The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
BUG=chromium:b/116685514
[email protected]
Change-Id: I176c41c0807f7849c3b3683c7da42656969cc667
Reviewed-on: https://chromium-review.googlesource.com/c/1378649
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616906}Record metrics for connected gamepads
Update the Gamepad.ConnectedDevice histogram when a device is
connected with a vendor and product ID pair matching a known
USB or Bluetooth gaming peripheral.
If the connected device is not recognized as a known gamepad, the
ID is not recorded. If the data fetcher that enumerated the
device has an independent means of verifying whether a device is
a gamepad, record an enum representing the data fetcher to the
Gamepad.UnknownGamepad histogram.
BUG=786250
Change-Id: I7e7797ee1e99b2076aa331ee9e589d157016993b
Reviewed-on: https://chromium-review.googlesource.com/c/1299543
Commit-Queue: Matt Reynolds <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616905}Roll src/third_party/depot_tools a3773d1f30e1..2eb7194395c7 (4 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3773d1f30e1..2eb7194395c7
git log a3773d1f30e1..2eb7194395c7 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Roll recipe dependencies (trivial).
2018-12-14 [email protected] Roll recipe dependencies (trivial).
2018-12-14 [email protected] Roll recipe dependencies (trivial).
2018-12-14 [email protected] Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/depot_tools@2eb7194395c7
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I1add1fc4cb8df8ee07956ebffb95e5b971e8b201
Reviewed-on: https://chromium-review.googlesource.com/c/1379063
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616904}Roll src-internal e32ea3e80971..9f1cdc9da7a6 (5 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e32ea3e80971..9f1cdc9da7a6
Created with:
gclient setdep -r src-internal@9f1cdc9da7a6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ifa3ad86581fee797c9c619156d07bc7e13c8028a
Reviewed-on: https://chromium-review.googlesource.com/c/1378835
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616903}Update UI for Assistant optin flow
- Combined the get more screen and the ready screen.
- Updated strings and removed a button for voice match screen.
Bug: b/120666294
Test: Manual Test
Change-Id: Ieac56980f775752a32e9fda6d4646d1b2c6b7dcc
Reviewed-on: https://chromium-review.googlesource.com/c/1374747
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616902}Enable mojo video decoders by default on Linux desktop if use_vaapi is true
Already the case for ChromeOS, Mac and Win. And run the service
in the GPU process too. Except that here the gn arg use_vaapi
has to be true as well.
Note that this CL does not change the following:
- the gn arg 'use_vaapi' is still false by default on Linux,
see media/gpu/args.gni
- 'accelerated_video_decode' is still black listed on Linux,
see entry 48 in gpu/config/software_rendering_list.json
- it is still not possible to enable hw video decode from
about:flags, see chrome/browser/about_flags.cc
Also note that with this CL the ffmpeg and libvpx video decoders
are still selected thanks to media::DecoderSelector::SelectDecoder
in case vaapi fails to initialize.
Also see https://chromium-review.googlesource.com/c/chromium/src/+/1225275/
which was very similar but for ChromeOS.
Tested on Linux desktop with gn args:
- use_vaapi = true (default is false)
./out/release/chrome --ignore-gpu-blacklist --use-gl=desktop url_to_vp9_video
./out/release/chrome --ignore-gpu-blacklist --use-gl=egl url_to_vp9_video
-> MojoVideoDecoder was in use and VaapiVideoDecodeAccelerator runing in the
GPU process, through MojoVideoDecoderService
Bug: 522298
Change-Id: Ia19f9f3edc0af488a477a16001b7de4f4818b3b2
Reviewed-on: https://chromium-review.googlesource.com/c/1370717
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Julien Isorce <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616901}Have WebContentsImpl::GetURL call GetVisibleURL
This makes it more apparent that GetURL() == GetVisibleURL(). Before
this change they were exact duplicates of the same code.
Bug: None
Change-Id: If61b4b8660aecaeee5110f208e62d50f948b1422
Reviewed-on: https://chromium-review.googlesource.com/c/1378821
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616900}Disable TwoClientPasswordsSyncTest.SetPassphraseAndAddPassword (flaky)
TBR=hans
Bug: 915383
Change-Id: If4e475852268863bc2f854cfeb7c253ebf8b348d
Reviewed-on: https://chromium-review.googlesource.com/c/1379209
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616899}Reland "Find-in-page per block using FindBuffer"
This reverts commit 9c484a22d01e9482be2997dea811367505556a86.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Find-in-page per block using FindBuffer"
>
> This reverts commit 71e551ac476ec9b247be8f19c6eb696632d90cf4.
>
> Reason for revert: broke MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy on win7 tests dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73554
>
> [7424:304:1214/084019.035:FATAL:find_buffer.cc(27)] Check failed: start_position == PositionInFlatTree::FirstPositionInNode( *start_position.ComputeContainerNode()).
>
> Original change's description:
> > Find-in-page per block using FindBuffer
> >
> > This CL introduces FindBuffer, which Find-in-page will use to find
> > matches instead of using FindPlainText that uses TextIterator.
> >
> > Since find-in-page matches can't span multiple blocks, we are using
> > that fact to know where we can separate the text in the document.
> > FindBuffer collects text one block at a time, and then finds the match
> > in that block. We trigger FindBuffer text collection & finding many
> > times until it goes through everything. FindInPage uses TextSearcherICU
> > to find text, and uses flat-tree traversal, ComputedStyle, and
> > LayoutObject + NGOffsetMapping, whereas the previous way was to use
> > TextIterator.
> >
> > This CL also changes the way we handle newlines - newlines will be
> > saved as object replacement character/whitespaces for Find-in-page
> > purposes. Some tests that rely on newlines are deleted as a result.
> > Note:
> > This change is not user-visible because it is not possible to do a
> > Find-in-page from the UI with newlines.
> >
> > See doc for details:
> > https://docs.google.com/document/d/1D5q7ZMrLPfilXnIGI3SOL0mwdiQC7SQEtGWk-9ysbMg/edit?usp=sharing
> >
> > Bug: 868227
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> > Change-Id: Id5dd7e6c428f59442d02ec88ea0cec6eb4e64c22
> > Reviewed-on: https://chromium-review.googlesource.com/c/1282425
> > Commit-Queue: Rakina Zata Amni <[email protected]>
> > Reviewed-by: Elly Fong-Jones <[email protected]>
> > Reviewed-by: Xiaocheng Hu <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616701}
>
> [email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
>
> Change-Id: Ic06a33d1c630bb4423fc0963bc55b6af5e8ef865
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 868227
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1378407
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Reviewed-by: Hongchan Choi <[email protected]>
> Commit-Queue: Hongchan Choi <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616757}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ib48618ecfb9a0daa55cd0bd86bda4744a324d5cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868227
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1379086
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616898}chromeos: gets a bunch of MultiUserWindowManager related tests passing
MultiUserWindowManagerClientImpl, when running in single-process mash mode,
expects a MusClient. So, tests that end up using AshTestBase/Helper *and*
calling into MultiUserWindowManager need to ensure there is a MusClient.
This also adds some calls to FlushBindings() at key points to ensure ash has
completed processing. This is necessary as ash may change visibility of
registered windows.
BUG=910241
TEST=covered by tests
Change-Id: Ie7bcba3772284d0c2b53ab26b0e3ad50c3153928
Reviewed-on: https://chromium-review.googlesource.com/c/1378411
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616897}shelf: Press the shortcut in auto-hide shelf should do nothing.
changes in this cl:
- Do not process the event in ShelfView::ButtonPressed for auto-hide
shelf. Since for example we don't want to open the app window by tap
the shortcut in auto-hide shelf.
- Keep auto-hide shelf visible if tap inside the shelf when app list is
opened. This is used to make sure press the shortcut in the auto-hide
shelf when app list is opened can still open the corresponding app.
It works before since we can tap the shortcut in the auto-hide shelf
to open the app, but we fixed it in this cl.
Bug: 914189
Change-Id: I5cdc5e0164b8958e3ffdf03c9718ffab0c6a5ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1374147
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616896}Disable libc++ on android and rollback buildtools to 7d88270d
This CL
1. Reverts 9a085ba23156aba9ade0a08efd3d948f9527f01e
2. Rolls buildtools back to 7d88270de197ebe8b439ab5eb57a4a2a0bb810e0
3. Disables libc++ on Android
BUG=910864,846855,767901
TBR=thakis
CC=mmoroz
NOTRY=true
Change-Id: I44e3a504fa6b842099fef78371c7dfcf7921f2f5
Reviewed-on: https://chromium-review.googlesource.com/c/1379245
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616895}EphemeralTab: Close the panel on back key press
Back key press should close the ephemeral tab if shown,
not let the base tab go back. This CL handles it.
Bug: 914510
Change-Id: Id9b59f406480b3a25fe3e9733ba88753fe789600
Reviewed-on: https://chromium-review.googlesource.com/c/1377249
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616894}[ChromeDriver] Fix matching of input source types
When a Perform Actions command uses multiple input sources, the code
was looping through the sources in the forward direction, but was
looping through the source types in the backward direction, causing
mismatches and errors. This is now fixed. Also fixing inconsistent
property usages between key actions and pointer actions.
We are still dispatching action events in the wrong order (by source,
instead of by time). That will be fixed in a future CL.
Bug: chromedriver:1897
Change-Id: Iff9259b4deb81a60d3614968c2681ac543e3c3a5
Reviewed-on: https://chromium-review.googlesource.com/c/1379111
Commit-Queue: John Chen <[email protected]>
Reviewed-by: Lan Wei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616893}cros: fix a crash that occurs after removing a user
Clicking on the "remove user" button the second time would trigger an animation
and then start tearing down the widget tree for the user to be removed (as well
as the user menu bubble). To prevent these two actions from racing, we
immediately hide the user menu widget before starting the teardown. We also
check the widget state early in key/mouse event handlers to prevent crashes
that could happen due to events on an orphaned view that hasn't been deleted
yet.
Bug: 912658
Change-Id: Iccefd785b5a7c8c97829e973bb4f132c406cf58f
Reviewed-on: https://chromium-review.googlesource.com/c/1379219
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Quan Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616892}Fix find in page dialog title.
Title should now be announced when CTRL+F is pressed as well as when the
user presses ACCESSIBILITY_KEY+T.
Bug: 869703
Change-Id: If94076cfb7a09aac1965950fcb43e3cde649872b
Reviewed-on: https://chromium-review.googlesource.com/c/1376722
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616891}Rename AXHostDelegate to AXActionHandler
Because:
* There is no AXHost class
* Its primary method is PerformAction()
The file will be renamed in a follow-up CL to preserve git history.
[email protected]
[email protected]
Bug: none
Test: compiles
Change-Id: I269bdcbe4594a418ce3c4edd44a592c997504178
Reviewed-on: https://chromium-review.googlesource.com/c/1374872
Reviewed-by: James Cook <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616890}FrameLoadRequest should reuse origin instead of recreating it.
FrameLoadRequest is currently constructing the requestor origin from
the URL of the requestor document. However, constructing origins based
on URL is a lossy process and does not preserve precursor origin
information.
Since the requestor document is already passed in as a parameter, the
origin of the document should be used directly. This CL changes that.
It also fixes a bug in the GetDownloadPolicy method where origin
comparison is assigned to a boolean incorrectly.
Bug: 632514, 882053
Change-Id: Ibb386ef7ecddc0b5dcc5b9e2b83f7b5215fdc1e9
Reviewed-on: https://chromium-review.googlesource.com/c/1378587
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616889}Roll src/third_party/catapult 8964ef5af77b..2ce7ac89a3e9 (1 commits)
https://chromium.googlesource.com/catapult.git/+log/8964ef5af77b..2ce7ac89a3e9
git log 8964ef5af77b..2ce7ac89a3e9 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Fixing potential issues I found after merging CL 1375232
Created with:
gclient setdep -r src/third_party/catapult@2ce7ac89a3e9
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:835690
[email protected]
Change-Id: I2108c0e09ea37bd469162d90db4472914bfc41b8
Reviewed-on: https://chromium-review.googlesource.com/c/1378833
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616888}Tinting trash button to fix disabled state
Previously the trash icon wasn't tinted which made it look the same in
disabed and enabled state. This CL tints it. Also noticed the
accessibility strings were wrong so also fixed those.
Bug: 915171
Change-Id: I969ac8aec54e0d2f3860d11f0eb120d7b123b62a
Reviewed-on: https://chromium-review.googlesource.com/c/1378968
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616887}Revert "Fixes necessary to enable in-tree libc++ on Android"
This reverts commit bdfa3bb74e76d0da628f876469af1d94bd5bad83.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=910864#c14
Original change's description:
> Fixes necessary to enable in-tree libc++ on Android
>
> All that should be necessary after this change is to flip use_custom_libcxx to
> true on Android.
>
> BUG=846855
> R=thakis
>
> Change-Id: I386176970ea7f05a9dbd7f04a2254c3a14d5419b
> Reviewed-on: https://chromium-review.googlesource.com/c/1377501
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616799}
[email protected],[email protected]
Change-Id: I82ad36ccb2aadc760045644e208091dc4914f154
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846855
Reviewed-on: https://chromium-review.googlesource.com/c/1378881
Reviewed-by: Max Moroz <[email protected]>
Commit-Queue: Max Moroz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616886}DevTools: Code Folding
This adds the ability to collapse sections of code in the Sources and
Network panels.
https://i.imgur.com/CkREJEV.png
Bug: 328431
Change-Id: I88e44d86c7fd2e6dbf076cc734aa538836516cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1014386
Commit-Queue: Joel Einbinder <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616885}Revert "Prevent restoring focus when the EndDrag minimizes the window"
This reverts commit d9b555828b2f49b9b9d223384d98e7a1f43ec5d9.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Prevent restoring focus when the EndDrag minimizes the window
>
> Some gesture may minimize the window along with ending the drag,
> but TabDragController::RestoreFocus in EndDragImpl() cancels
> the minimization.
>
> Bug: 902897
> Test: the new test case
> Change-Id: I3b19ef228d69b141eee5f18fbf130cccb4745d6b
> Reviewed-on: https://chromium-review.googlesource.com/c/1377490
> Reviewed-by: Scott Violet <[email protected]>
> Commit-Queue: Jun Mukai <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616856}
[email protected],[email protected]
Change-Id: Ic047835d96904b59c6be0c47ce357af2a07e2856
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 902897
Reviewed-on: https://chromium-review.googlesource.com/c/1379168
Reviewed-by: Jun Mukai <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616884}WebUI: Remove web-animations polyfil dependency, where not needed.
After updating paper-tooltip to its latest version at r616028, a few
places that were previously importing the Web animations polyfil, no
longer need it.
Bug: 902959
Change-Id: I63d9a09ff3300d2e0c693fc7a24d2750c6b53c94
Reviewed-on: https://chromium-review.googlesource.com/c/1378813
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616883}Roll src/third_party/depot_tools c6a8d114b060..a3773d1f30e1 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c6a8d114b060..a3773d1f30e1
git log c6a8d114b060..a3773d1f30e1 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/depot_tools@a3773d1f30e1
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I52da05af058208a6ce3745fa24a15d4177757093
Reviewed-on: https://chromium-review.googlesource.com/c/1378650
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616882}Enable v2 hit testing with VizDisplayCompositor
This patch enables V2 viz hit testing (OOPIF hit testing with cc data)
with VizDisplayCompositor.
Bug: 901882
Change-Id: If8fc1483303e6081e985d02249de9e75959f4420
Reviewed-on: https://chromium-review.googlesource.com/c/1370464
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Commit-Queue: Xianda Sun <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616881}[Extensions] Remove linked_ptr from ManifestHandler[Registry]
Remove linked_ptrs from ManifestHandler and ManifestHandlerRegistry,
and tweak the ManifestHandlerRegistry interface to be more friendly
about passing ownership.
- Make ManifestHandlerRegistry::RegisterHandler() public, and explicitly
take ownership of the ManifestHandler.
- Register ManifestHandlers with
ManifestHandlerRegistry::RegisterHandler() directly, rather than going
through ManifestHandler::Register().
(The combination of these two changes makes for a less surprising
interface, where we do registry->RegisterHandler(make_unique<Handler>())
rather than (new Handler())->Register())
- Store ManifestHandlers in an unsorted vector in
ManifestHandlerRegistry, which serves only to maintain ownership.
Update the maps to only retain raw pointer references.
[email protected] (mechanical change to cast_extensions_api_provider.cc)
Bug: 914401
Change-Id: Ib53c44095e8b91ef768422ab9ecd8d71726da4a5
Reviewed-on: https://chromium-review.googlesource.com/c/1374389
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616880}Navi Onboarding: fix email provider default
Bug: 915187
Change-Id: Iee891e8b73f4c9ebea56282abc0dddf5be9db911
Reviewed-on: https://chromium-review.googlesource.com/c/1378674
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616879}Roll src/third_party/angle 70fd9b5d381e..e1f742af18c5 (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/70fd9b5d381e..e1f742af18c5
git log 70fd9b5d381e..e1f742af18c5 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] GL: Clean up workaround detection.
Created with:
gclient setdep -r src/third_party/angle@e1f742af18c5
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I41fcc0c2393e3aedaabf1d1b44af63eee536e7f9
Reviewed-on: https://chromium-review.googlesource.com/c/1378832
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616878}Delete debug::ThreadHeapUsageTracker, it's unused
Change-Id: Ic1e5048091f420d3ea68b552d6cde50a38b1c684
Reviewed-on: https://chromium-review.googlesource.com/c/1377375
Reviewed-by: Sigurður Ásgeirsson <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Vlad Tsyrklevich <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616877}Reland "Android notification: Introduce ChromeNotification/PendingIntentProvider."
This CL relands commit 1b5f509ea5d7043572f7fa6950863f54c4fd1740,
reverted in f8914c8150d9da36b057ec05358943d90456b2d8.
[email protected], [email protected]
Bug: 898269
Change-Id: Ide9c54dfb47f2468276577c9187657927f66333b
Reviewed-on: https://chromium-review.googlesource.com/c/1379188
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616876}Add Vulkan watchlist
This CL adds a Vulkan category to the watch lists and adds me to that.
Change-Id: I55f3415b2a1f2bf37da228314f617590a587b85e
Reviewed-on: https://chromium-review.googlesource.com/c/1378966
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Chris Blume <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616875}WebUI cleanup: Remove usage of CallJavascriptFunctionUnsafe from local_state/.
Bug: None
Change-Id: I92a944214c42b8df68d70f65fe7182bba7219b60
Reviewed-on: https://chromium-review.googlesource.com/c/1377507
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616874}[libFuzzer] Improve Windows documentation
Change-Id: I756482bb6f907c7e725f61a1f8d9cfc85dd423d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379189
Reviewed-by: Jonathan Metzman <[email protected]>
Reviewed-by: Abhishek Arya <[email protected]>
Commit-Queue: Jonathan Metzman <[email protected]>
Commit-Queue: Abhishek Arya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616873}Make sysroot builds reproducible
BUG=913061
R=thestig
CC=jeremya
Change-Id: I40da9ac1fea6f23ed2cc3bf8d9a121cd9ed2be5b
Reviewed-on: https://chromium-review.googlesource.com/c/1378965
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Jeremy Apthorp <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616872}[NTP] Move doodle logic and styling
Move css and js for NTP doodles into separate files.
Alphabetize resource lists in various places.
Bug: 903398
Change-Id: I7994c6785b52b757dd4196f2467e14800e6f385c
Reviewed-on: https://chromium-review.googlesource.com/c/1374835
Reviewed-by: Ramya Nagarajan <[email protected]>
Commit-Queue: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616871}Add UKM for download metrics
Also added GetDocumentCreatedEntryForSourceId() method in test_ukm_recorder
that can be shared among multiple places.
Bug: 881345
Change-Id: I295b9383be197c9c756bfe57c27f819dfcbb8640
Reviewed-on: https://chromium-review.googlesource.com/c/1327229
Commit-Queue: Yao Xiao <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Tommi <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Ojan Vafai <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616870}Roll src/third_party/dawn 08aa58f8d6ed..8d7de591f4c9 (1 commits)
https://dawn.googlesource.com/dawn.git/+log/08aa58f8d6ed..8d7de591f4c9
git log 08aa58f8d6ed..8d7de591f4c9 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Tell shaderc where to find SPIRV-Cross.
Created with:
gclient setdep -r src/third_party/dawn@8d7de591f4c9
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:915096
[email protected]
Change-Id: Ia4b74641dccd8b4842b2e01dee8de40f26e7f599
Reviewed-on: https://chromium-review.googlesource.com/c/1378828
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616869}WebUI: fix input labels for large minimum-font-size
Originally, cr-input's font-size, height, line-height are all set to 0.625rem,
but when the minimum-font setting changes, font-size is forced to not respect
"rem". This CL changes the height/line-height styling to be 1em, such that it
stays in sync with the label's actual font-size, instead of with rem, since
the original intention was for height/line-height to equal the exact font height
anyway.
Bug: 900135
Change-Id: I5a64114fad5d0b7455c6e577b04c3a26e21fbfba
Reviewed-on: https://chromium-review.googlesource.com/c/1376664
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616868}lazy-load: Increase timeout value to reduce flakes
The test is still a bit flaky after increasing the value to 400ms (
which did in fact reduce flakiness substantially). This CL will
increase the value even further (600ms) to further reduce the flakiness.
[email protected]
Bug: 915236
Change-Id: I1ad650ed14dbf9b054a966324ec033a4bd2f47f8
Reviewed-on: https://chromium-review.googlesource.com/c/1379105
Reviewed-by: Ehsan Karamad <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616867}Fuchsia: Add Connector C++ and JS library for injecting channels to JS.
The Connector JS library allows callers to create asynchronously-bound
ports which can be immediately written to. The Connector will
handle the details of connecting the JS and C++ ports together. All
details pertaining to the port's connected state are abstracted from
the JS side.
It will be used as the transport for cast.__platform__ APIs so that
they can communicate with other components outside the content
boundaries.
* Use shared memory for injected scripts so that renderers don't
have to store their own copies.
* Move some common test code to webrunner/common, including
the browser test base class and launcher.
Bug: 893236
Change-Id: I6e769ed3422a8acadd696b51021d3877323b416d
Reviewed-on: https://chromium-review.googlesource.com/c/1357655
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616866}Fix failing Previews ChromeDriver test
This test is flaky because Chrome is sometimes falling into the new
Previews UI experiment. Setting the flag to disable it fixes the problem
and was verified by running the test many times.
Bug: 913127
Change-Id: I9e465b8670d5382d7978ca952bcb7db1df583973
Reviewed-on: https://chromium-review.googlesource.com/c/1377176
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616865}Roll src/native_client 0ec1fb98e283..af5947d13e67 (1 commits)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ec1fb98e283..af5947d13e67
git log 0ec1fb98e283..af5947d13e67 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Disable sysroot for ASan GN builds
Created with:
gclient setdep -r src/native_client@af5947d13e67
The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:868204
[email protected]
Change-Id: Ib8d4949433d81a5ea22c795ef0bd1f850e1194e7
Reviewed-on: https://chromium-review.googlesource.com/c/1378651
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616864}Roll src-internal 67fbfe6310e6..e32ea3e80971 (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67fbfe6310e6..e32ea3e80971
Created with:
gclient setdep -r src-internal@e32ea3e80971
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iabd6d861c9fdd273ab5adba84053d8a016567e0b
Reviewed-on: https://chromium-review.googlesource.com/c/1378827
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616863}Convert AXAshWindowUtilsTest to SingleProcessMashTestBase
This eliminates some test setup boilerplate.
Bug: 911776
Test: ash_unittests
Change-Id: I3be7282776ed863031037d6059734f23ed38d303
Reviewed-on: https://chromium-review.googlesource.com/c/1379034
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616862}Add image codecs & me to WATCHLISTS
This CL adds a new WATCHLIST area called blink_image_codecs. It includes
both the decoders and encoders. It also included the perf tests for the
codecs.
This CL also adds me to that new blink_image_codecs watchlist.
Change-Id: I2db95a44386533a74d253cb3e18c7f436cb728d6
Reviewed-on: https://chromium-review.googlesource.com/c/1379031
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Chris Blume <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616861}Add zlib watchlist
This CL adds a zlib category to the watch lists and adds me to that
list.
Change-Id: I9dd1766c0e88f95696e70c3a7fa4d20d4ea4888e
Reviewed-on: https://chromium-review.googlesource.com/c/1379033
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Chris Blume <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616860}Dark Mode: update Settings loading shell
[email protected]
BUG=883049
Change-Id: Idf98a94cc1767abc897a546767361447ad637e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1377382
Commit-Queue: Dan Beam <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616859}Generalize reproducing docs for libFuzzer and AFL.
[email protected],[email protected]
Bug: 913684
Change-Id: I0c5c66ca6e378613038cbd5a8ff6205a6ed30cdd
Reviewed-on: https://chromium-review.googlesource.com/c/1378681
Reviewed-by: Max Moroz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616858}Fix a nit and delete dead code in chromeos::Printer.
Change-Id: I0832a4e8e539c4b2e1cdf57cf3977027884d4b91
Reviewed-on: https://chromium-review.googlesource.com/c/1374731
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616857}Prevent restoring focus when the EndDrag minimizes the window
Some gesture may minimize the window along with ending the drag,
but TabDragController::RestoreFocus in EndDragImpl() cancels
the minimization.
Bug: 902897
Test: the new test case
Change-Id: I3b19ef228d69b141eee5f18fbf130cccb4745d6b
Reviewed-on: https://chromium-review.googlesource.com/c/1377490
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616856}Make sure to fallback to VDA1 if mojo video decoder is disabled at buildtime
Also avoids a few ipc round trips when mojo video decoder is enabled
at buildtime but disabled at runtime.
Previously external_decoder_factory_->CreateVideoDecoders was still
called in that case.
Tested on Linux desktop with gn args:
- use_vaapi = true (default is false)
- enable_mojo_media = false (default is also false)
./out/release/chrome --ignore-gpu-blacklist --use-gl=desktop url_to_vp9_video
./out/release/chrome --ignore-gpu-blacklist --use-gl=egl url_to_vp9_video
-> GpuVideoDecoder (VDA1) was in use
Bug: 522298
Change-Id: Ia7566877f76da8d108d8993c57c6d29d745cfa8a
Reviewed-on: https://chromium-review.googlesource.com/c/1374741
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Julien Isorce <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616855}Roll Fuchsia SDK from dfca5b235ea8 to f65ab9f9fe2a
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
[email protected]
Change-Id: I06d7b7f0e94b1d8df70e74f20bcac63ba98ed071
Reviewed-on: https://chromium-review.googlesource.com/c/1378830
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616854}Rename NetLogEventType for connectivity probing.
This change also cleans up the annotation comments.
Bug: 913733
Change-Id: I9075c61bdcad9a041d758d4235cf82dade55b30e
Reviewed-on: https://chromium-review.googlesource.com/c/1374970
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616853}Revert "Android notification: Introduce ChromeNotification/PendingIntentProvider."
This reverts commit 1b5f509ea5d7043572f7fa6950863f54c4fd1740.
Reason for revert: Didn't update build file when move code back to chrome.
Original change's description:
> Android notification: Introduce ChromeNotification/PendingIntentProvider.
>
> The Android API didn't expose notification id/tag and the int flags to
> create Notification's PendingIntent, however we need to use these data
> when recording Chrome notification metrics.
>
> This CL adds wrapper class that contains these data.
> ChromeNotificationBuilder will use these wrapper class in the future to
> force metrics tracking and usage of NotificationManagerProxy.
>
> Also we setup a new component for notification.
>
> [email protected], [email protected]
>
> Bug: 898269
> Change-Id: I63e3976c729d71e761c8c6b5c0aead3763ba5e17
> Reviewed-on: https://chromium-review.googlesource.com/c/1358650
> Reviewed-by: Xing Liu <[email protected]>
> Reviewed-by: David Trainor <[email protected]>
> Reviewed-by: Tommy Nyquist <[email protected]>
> Commit-Queue: Xing Liu <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616783}
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ic33e9232084c76c318caece0b133480f26cf43b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898269
Reviewed-on: https://chromium-review.googlesource.com/c/1379058
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616852}Remove catalog::LoadDefaultCatalogManifest
It was only used in two unittest runners. This migrates them to use
generated code instead of parsing a manifest from JSON at runtime.
Bug: 895616
Change-Id: I25421806ff47a411197a91f2161ce7b09938d3d5
Reviewed-on: https://chromium-review.googlesource.com/c/1378676
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616851}Roll src/third_party/pdfium 623e636edcd5..1ab2757db271 (1 commits)
https://pdfium.googlesource.com/pdfium.git/+log/623e636edcd5..1ab2757db271
git log 623e636edcd5..1ab2757db271 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Pass WideStringViews by value.
Created with:
gclient setdep -r src/third_party/pdfium@1ab2757db271
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iea1a434bf104459b00b147a09870873df1ee2149
Reviewed-on: https://chromium-review.googlesource.com/c/1378648
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616850}[DevTools] Application > Service Workers, fix live script receiving time
Before this patch, current site's service worker receive time is Unix
epoch time. This patch fixes this problem.
About the test for this CL:
ServiceWorkerTestRunner.js is modified, so if the old problem (showing Unix epoch time)
persists, then DevTools tests service-workers-view.js and service-workers-redundant.js
would fail.
Bug: 767790
Change-Id: I65aeadddcf03d381f8366e1157d85ac182202e15
Reviewed-on: https://chromium-review.googlesource.com/c/1376311
Commit-Queue: Haihong Li (Harley) <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616849}Avoid float arithmetic when getting signal strength index
Signal strength reported from shill and max number of images should be
well in bounds that avoid int overflow.
BUG=904285
Change-Id: Ibc3cabde55d41064ce63dec4c61d1e62642f0c90
Reviewed-on: https://chromium-review.googlesource.com/c/1377717
Commit-Queue: Toni Baržić <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616848}Extensions: Implement "content_security_policy.extension_pages" manifest key.
This CL implements the "content_security_policy.extension_pages" manifest key.
This is part of allowing "content_security_policy" key to be specified as a
dictionary. In follow-ups, "content_security_policy.sandbox" and "content_security_policy.content_scripts" will be implemented.
BUG=914224
Change-Id: I1e3a3b1757d1417bf12c3f4fb2fa652fe8bc29e8
Reviewed-on: https://chromium-review.googlesource.com/c/1373253
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616847}Remove forced site support from TopSites
This change removes forced sites from TopSites/Impl and TopSitesCache.
Forced URLs are only used to store thumbnails from Most Likely sites,
and NTP thumbnails have been deprecated as of M69.
Bug: 893362
Change-Id: Ib35ad05ba7e9a8fd558e8a12fe6636c3f2695e7c
Reviewed-on: https://chromium-review.googlesource.com/c/1375097
Commit-Queue: Kristi Park <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616846}splitview: Move some functions from split_view_controller to other class.
Since they dont use class members move to split_view_utils or
screen_orientation_controller.
Test: builds
Bug: none
Change-Id: I11950bc60a60549609b72b7f187f992a6d92ee05
Reviewed-on: https://chromium-review.googlesource.com/c/1345431
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616845}Record FCP++ before user input.
This is an initial, experimental implementation to determine if
we should do a more complete implementation in the render process.
Previous privacy review for largest text/image paint: Privacy review: https://docs.google.com/document/d/1LJnD-INFo7UnvPyB6C-tzpJ3BLK9rYA2SbnwTcsyeTs/edit
Change-Id: Ica826e974fee39c5696230fd3d9ffdee42786da8
Bug: 915295
Reviewed-on: https://chromium-review.googlesource.com/c/1378409
Commit-Queue: Bryan McQuade <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616844}[chrome:omnibox] Remove option to hide rows when filtering.
Previously, filtering output had two modes: 1) highlighting matches, 2) hiding
non-matches. This CL removes the 2nd option as the 1st was deemed more useful.
Bug: 891303
Change-Id: I0df88f56cecb2498ae82b4870f20f3b7e92b2850
Reviewed-on: https://chromium-review.googlesource.com/c/1373872
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616843}Desktop Zero Suggest - Enable Two "Experimental" Features on Desktop
In particular:
- have the current URL show its title in the dropdown, not only the URL
(which is displayed twice, once as |contents| and once as |description|)
- display title before URL, as we do with as-you-type experiments these
days
We've been running with them enabled on desktop for 90+% of traffic;
they were both approved on the linked bug.
Regardless of what happens with desktop zerosuggest, it would be best
if the submitted code contained the intended defaults / configuration.
Bug: 692471
Change-Id: Icd527c689537e32a9e1dccd73ad30115bd32c402
Reviewed-on: https://chromium-review.googlesource.com/c/1376668
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616842}Roll src/third_party/catapult a382be45b72a..8964ef5af77b (1 commits)
https://chromium.googlesource.com/catapult.git/+log/a382be45b72a..8964ef5af77b
git log a382be45b72a..8964ef5af77b --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Changed average raster task times metric
Created with:
gclient setdep -r src/third_party/catapult@8964ef5af77b
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I837e6dc6ca443de87a7cb5eee838b73595b9c5be
Reviewed-on: https://chromium-review.googlesource.com/c/1378829
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616841}Revert "Remove missing security state workaround in CanAccessDataForOrigin()."
This reverts commit ec08cda18f9773396a600b2f974a9242df8b3be5.
Reason for revert: Caused renderer kills. See https://crbug.com/898281#c8.
Original change's description:
> Remove missing security state workaround in CanAccessDataForOrigin().
>
> - Remove an old workaround that was put in place before site isolation
> was on by default.
> - Fixed a test that depended on this behavior to pass.
>
> Bug: 898281, 600441
> Change-Id: I1f08a0d7af59514c84f7eebd5f48027758a0f63b
> Reviewed-on: https://chromium-review.googlesource.com/c/1374831
> Commit-Queue: Aaron Colwell <[email protected]>
> Reviewed-by: Charlie Reis <[email protected]>
> Reviewed-by: Alex Moshchuk <[email protected]>
> Reviewed-by: Marijn Kruisselbrink <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616524}
[email protected],[email protected],[email protected],[email protected]
Change-Id: Ic67afdbd498f1484ca728431427909a049985550
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898281, 600441
Reviewed-on: https://chromium-review.googlesource.com/c/1379032
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616840}Add a Mac UMA for other proccesses running from the binary.
BUG=914393
Change-Id: Ic680bc4ec2697c0211c8bfc09cff26591b50bc64
Reviewed-on: https://chromium-review.googlesource.com/c/1374436
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616839}[Remoting Windows installer] Set REINSTALL and REINSTALLMODE properties for reinstallation
We saw a few users having problem starting the host because the host service
has been removed while the native messaging host is still there. On other
platforms this can be fixed by reinstalling the host, but rerunning the MSI on
Windows does nothing unless it's an upgrade.
This CL adds the REINSTALL and REINSTALLMODE properties to the installer if the
user tries to rerun the MSI, so that the installer will forcibly reinstall all
files and services.
Bug: 911814
Change-Id: Ic25f3d54f2ff34ea61e7aeb7f9fa92b6255cc423
Reviewed-on: https://chromium-review.googlesource.com/c/1363900
Commit-Queue: Yuwei Huang <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616838}Separate tab switcher mode toolbar from browsing mode toolbar
Create a new TabSwitcherModeTTPhone view that is lazily inflated the
first time the user enters the tab switcher (except when Duet is
enabled, which doesn't have a top toolbar in the tab switcher).
Follow-up CLs will focus on applying MVC to the tab switcher toolbar and
improving code sharing between the tab switcher toolbar and duet.
BUG=897294
Change-Id: Ie930aaf281a8fbb805f784e500d505ea3e6db057
Reviewed-on: https://chromium-review.googlesource.com/c/1371069
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616837}Add UMA histogram to diagnose Android pak locale load failures.
See bug for context.
Bug: 914342
Change-Id: I3da1a6eb97cf57870e8a697747193e381a171c43
Reviewed-on: https://chromium-review.googlesource.com/c/1376412
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616836}GuestView: Replace CHECK with bad_message
If a MimeHandlerViewGuest and a guest WebContents are created without a proper
GuestViewManager in place (for the owner WebContents BrowserContext), we are currently
CHECK-ing the browser. It might be wise to simply destroy the GuestView and crash the
embedder process on a bad message instead.
Bug: 659750
Change-Id: Ie46ede5889ec9ce087fcb4d3fb9d98adb6300314
Reviewed-on: https://chromium-review.googlesource.com/c/1378810
Reviewed-by: Kevin McNee <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616835}[BlinkGenPropertyTrees] Clear client of CcLayer in GraphicsLayer destructor
This ensures that the cc layer won't be treated as a functional layer after
the GraphicsLayer (as the client of the cc layer) is destroyed.
Bug: 913464
Change-Id: I2c6481c0073c36aaf468dc11ae5b0e439b84cef0
Reviewed-on: https://chromium-review.googlesource.com/c/1377318
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616834}Add extra CHECK to collect more causes for WindowProxy::SetGlobalProxy crash
Also updated the audio test to not use the DummyPageHolder which is effectively a provisional frame,
that would otherwise always trigger the new CHECK.
BUG=897816
Change-Id: I6d8a807e9cf60d71e6c706568f98e4f327181734
Reviewed-on: https://chromium-review.googlesource.com/c/1364067
Commit-Queue: Alexei Filippov <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616833}IndexedDB: Rename WebIDBDatabaseError to IDBDatabaseError
Bug: 717812
Change-Id: I2dedd7a832f053c180e0735a60cd57bccec9f058
Reviewed-on: https://chromium-review.googlesource.com/c/1366380
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616832}[android] Track signin-in and sync browsing activity.
This CL extracts the recorder for sign-in and sync activity session durations
in a separate class that can be used on all platforms and moves it to
//components/sync. It then uses it to record sign-in and sync browsing activity
on both android and desktop.
This CL also adds the AndroidProfileSessionDurations profiled keyed service
that is used to ensure that the session duration is correctly tied to
profile initalization and shut down events.
Bug: 895900
Change-Id: I8b2fa6616e7b35f21dbcb63cdac87cd6d96c00a7
Reviewed-on: https://chromium-review.googlesource.com/c/1355126
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616831}[CSS Transitions] Add test for reparenting
As per https://github.com/w3c/csswg-drafts/issues/3309, any CSS
Transition on a reparented element should be cancelled, as it leaves and
then re-enters the Document. This already works on Chrome, Firefox, and
Safari but fails on Edge.
Bug: 902328
Change-Id: I097675a8146c8047417dd48193d0747216418cfb
Reviewed-on: https://chromium-review.googlesource.com/c/1374742
Reviewed-by: vmpstr <[email protected]>
Commit-Queue: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616830}Update V8 to version 7.3.153.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36e5bdd6..a090245c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Ie13d2e7f79ed6be2b903dbd7593bf0cddf3c53e5
Reviewed-on: https://chromium-review.googlesource.com/c/1378665
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616829}IndexedDB: Remove unnecessary uses of "using"
Bug: 717812
Change-Id: Ia4e44651b08bb293b175db0c3d92106ebb3f8043
Reviewed-on: https://chromium-review.googlesource.com/c/1366271
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616828}[Code Coverage] Fix invocation of run_web_tests
The flag --batch-size has been removed in https://crrev.com/c/1300236.
This CL removes the flag from coverage.py.
Bug: 915336
Change-Id: I22e5ccd5f10bf55795442f87deda767a4954fd32
Reviewed-on: https://chromium-review.googlesource.com/c/1378812
Commit-Queue: Robert Ma <[email protected]>
Commit-Queue: Max Moroz <[email protected]>
Reviewed-by: Max Moroz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616827}desktopCapture: avoid freezing at getting icon from an unresponsive window
We'll get window icons at starting the picker for each available window.
If there is any app window unresponsive, then the system call will block,
which will freeze the browser too.
This cl is to use SendMessageTimeout instead of original SendMessage, which
will returen when the target window is hung. (PS: we can still get its
icon by GetClassLong().)
Since the unresponsive window can't be captured, there is no need to show
it in the picker. It's reasonable to skip it in the window list, which will
be done in a seperate cl in webrtc.
Bug: 911110
Change-Id: Ib4e73d75d2012f75d7b969aea855a6de0b88a879
Reviewed-on: https://chromium-review.googlesource.com/c/1378670
Reviewed-by: Emircan Uysaler <[email protected]>
Commit-Queue: Weiyong Yao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616826}IndexedDB: Stop using WebIDBObservation
Bug: 717812
Change-Id: Ib9f9b6e4cd2fcd9ad1fdd8c7d83a314655f3ded8
Reviewed-on: https://chromium-review.googlesource.com/c/1366440
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616825}Reland "Stop creating net::URLRequestContext in the browser process when network service is enabled."
This is a reland of 2864f69f22b4c9398a49f059b72b28f9bece8fc3
Patchset 1->2 has the fix for not attempting to create the URLRequestContext in the browser in Clank.
Original change's description:
> Stop creating net::URLRequestContext in the browser process when network service is enabled.
>
> Bug: 837753
> Change-Id: I479666949f8c552e964ab86420ef080db9010d06
> Reviewed-on: https://chromium-review.googlesource.com/c/1367088
> Commit-Queue: John Abd-El-Malek <[email protected]>
> Reviewed-by: Matt Menke <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615995}
Bug: 837753
Change-Id: Id9429da79b53cc3dd2292affdb411cf1c055b1f3
Reviewed-on: https://chromium-review.googlesource.com/c/1376319
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616824}Move virtual/not-blink-gen-property-trees to virtual/stable
The virtual/not-blink-gen-property-trees directory is very similar to
the virtual/stable directory, but virtual/stable has a benefit where it
is not overridden by status=test features. Before this patch, the
virtual/not-blink-gen-property-trees ran with BlinkGenPropertyTrees.
Bug: 913464
Change-Id: I253c8eb49db2079757035f36d8e58244bae5a2c7
Reviewed-on: https://chromium-review.googlesource.com/c/1377290
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616823}[Payment Request][Desktop] Prevent use after free.
Before this patch, a compromised renderer on desktop could make IPC
methods into Payment Request in an unexpected ordering and cause use
after free in the browser.
This patch will disconnect the IPC pipes if:
- Init() is called more than once.
- Any other method is called before Init().
- Show() is called more than once.
- Retry(), UpdateWith(), NoupdatedPaymentDetails(), Abort(), or
Complete() are called before Show().
This patch re-orders the IPC methods in payment_request.cc to match the
order in payment_request.h, which eases verifying correctness of their
error handling.
This patch prints more errors to the developer console, if available, to
improve debuggability by web developers, who rarely check where LOG
prints.
After this patch, unexpected ordering of calls into the Payment Request
IPC from the renderer to the browser on desktop will print an error in
the developer console and disconnect the IPC pipes. The binary might
increase slightly in size because more logs are included in the release
version instead of being stripped at compile time.
Bug: 912947
Change-Id: Iac2131181c64cd49b4e5ec99f4b4a8ae5d8df57a
Reviewed-on: https://chromium-review.googlesource.com/c/1370198
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616822}Remove third_party/blink/renderer/platform/feature_policy/.
It is empty except for a DEPS file, as of
https://chromium.googlesource.com/chromium/src/+/32487da8d09caf3eb72b9c70f60887e2237f4751
Change-Id: I7a4c70c1fc48169a765ac8275b63a719ed9d2583
Reviewed-on: https://chromium-review.googlesource.com/c/1378489
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616821}Remove obsolete note about UMA Task Profiler from histgrams.xml.
Bug: None
Change-Id: Ic3f572c4b90626f8906a9db1e744ba17470169db
Reviewed-on: https://chromium-review.googlesource.com/c/1376091
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616820}Roll src/native_client 987c54ad6fe5..0ec1fb98e283 (1 commits)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/987c54ad6fe5..0ec1fb98e283
git log 987c54ad6fe5..0ec1fb98e283 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Update sysroot used by toolchain build
Created with:
gclient setdep -r src/native_client@0ec1fb98e283
The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:868204
[email protected]
Change-Id: I3f6a771a652c551b954a357d0bbb66ddfe221f4b
Reviewed-on: https://chromium-review.googlesource.com/c/1378825
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616819}Webview Fullsreen had incorrect scroll offsets.
When switching to the FullscreenView the native scroll offsets would get
forced to be 0,0 causing a scroll reset. Ensure that the FullscreenView
container has the correct matching native offsets when it is assigned
to be the active container view.
BUG=911486
Change-Id: I10ef65d7141df2c20ca1ea17099a4154d8be622a
Reviewed-on: https://chromium-review.googlesource.com/c/1372239
Reviewed-by: Bo <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616818}Remove WebWidget::IsPagePopup() and IsWebView().
Neither is used anymore after this CL. IsPagePopup was only used to
verify a cast from WebWidget to WebPagePopupImpl. We can change the
type from WebWidget to WebPagePopup though, in which case it's not
needed and we get more clear code in the process :)
IsWebView() can not be true if the WebViewImpl is no longer also a
WebWidget, so remove it since we are going to make it always false.
[email protected]
Change-Id: I040f5d62f1b88d825c8587104acdf0155bcef7f7
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1376092
Commit-Queue: danakj <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616817}Disable network_service_interactive_ui_tests, network_service_content_browsertests on ToTLinuxTSan
interactive_ui_tests and content_browsertests have extra shards on TSan,
but the network_service_ versions don't since they're disabled on the main
TSan bot for resource reasons. Rather than giving them more shards on the ToT
bot, make the ToT bot more like the main TSan and disable these two test suites
there too.
network_service_interactive_ui_tests used to take 30 min to run in the current
setup, network_service_content_browsertests took 45 min.
TBR=hans
Bug: 913704
Change-Id: Ib3c0755b58d51582d119365829e0cbbf53380120
Reviewed-on: https://chromium-review.googlesource.com/c/1378635
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616816}Revert "Bound the number of outstanding writes to SSLKEYLOGFILE."
This reverts commit c933b043df29281e31b82cadb274244f96a389f2.
Reason for revert: speculative revert, I think this breaks unit tests (http://crbug.com/915340).
Original change's description:
> Bound the number of outstanding writes to SSLKEYLOGFILE.
>
> Some AVs appear to be using this file, but pointing it to a pipe where
> they cannot keep up with writes. We should not build up an unbounded
> buffer, so just drop the entries past some very generous limit.
>
> Tested manually by bringing the limit down to 5 and pointing
> SSLKEYLOGFILE at a named pipe attached to a reader I had suspended (at
> which point it still took a lot of work to exceed the pipe's buffer
> to get to the Chrome-side limit).
>
> Additionally, do not block shutdown, in case the buggy AV has stopped
> reading from the pipe altogether.
>
> Bug: 566951, 914880
> Change-Id: I2c3bbf0f0762ea9f2b149df1856093efd614677b
> Reviewed-on: https://chromium-review.googlesource.com/c/1377187
> Reviewed-by: Ryan Sleevi <[email protected]>
> Reviewed-by: Adam Langley <[email protected]>
> Commit-Queue: David Benjamin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616784}
[email protected],[email protected],[email protected]
Change-Id: Ibb4b1d1380d26ba12a78ecd93e90331e20c82529
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 566951, 914880
Reviewed-on: https://chromium-review.googlesource.com/c/1378818
Reviewed-by: Glenn Hartmann <[email protected]>
Commit-Queue: Glenn Hartmann <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616815}Remove URLRequestContext access from MediaResourceGetterImpl
This required adding a new method to NetworkContext for retrieving the
auth credentials.
Bug: 915009
Change-Id: I846e4c8714b6831b354f3545c7496c8cf1c7dfb5
Reviewed-on: https://chromium-review.googlesource.com/c/1377186
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616814}Disable flaky ChromeVoxEventWatcherUnitTest.AlertDialogFeedback
[email protected]
Change-Id: Ie500171f0d0ff5af315e8c9bd36c82da8c58c503
Bug: 622387, 914455
Reviewed-on: https://chromium-review.googlesource.com/c/1378667
Reviewed-by: danakj <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616813}Remove thumbnail API from TopSites
NTP thumbnails have been deprecated as of M69. This change removes
thumbnail functionality from TopSites/Impl and TopSitesCache.
Bug: 893362
Change-Id: I52c6ec769a92891b500daf907c580ce861c31eee
Reviewed-on: https://chromium-review.googlesource.com/c/1364391
Commit-Queue: Kristi Park <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616812}Tracing: send stop tracing to late agents
To make the status of tracing agents and the tracing coordinator
consistent, we make the tracing coordinator ALWAYS send the last
start/stop tracing signal to agents when they register. This way, agents
can make sure their tracing status is the same as the coordinator
status.
If an agent registers after StopAndFlush is received by the
coordinator and the coordinator has already gathered trace data from all
agents with that label, we send a no-op recorder to the agent and
discard its data (we just want to let it know tracing is stopped). If
the coordinator is still gathering data, then an actual recorder is sent
and the agents data is collected.
Bug: 911839
Change-Id: If43ae0490fd5286b62a6ae2a9b235dea16275ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1372719
Commit-Queue: Ehsan Chiniforooshan <[email protected]>
Reviewed-by: oysteine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616811}Roll src/third_party/webrtc d96b275cd686..24779d82292e (15 commits)
https://webrtc.googlesource.com/src.git/+log/d96b275cd686..24779d82292e
git log d96b275cd686..24779d82292e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Missing packet send time should not cause BWE backoff.
2018-12-14 [email protected] Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
2018-12-14 [email protected] Revert "Reland "Default to dlopening the PipeWire.""
2018-12-14 [email protected] Use output_dir instead of output_name
2018-12-14 [email protected] Refactor creation of ColorSpace test data
2018-12-14 [email protected] Delete log severity LS_SENSITIVE
2018-12-14 [email protected] Roll chromium_revision 55b877610b..6d37479eb8 (615952:616603)
2018-12-14 [email protected] update luci-go client
2018-12-14 [email protected] Use unique_ptr in DataChannel PacketQueue
2018-12-13 [email protected] Remove unused cryptoparams.h header
2018-12-13 [email protected] Set LoggedIceCandidatePairEvent.transaction_id to default value if missing.
2018-12-13 [email protected] Adding fuzzing configuration files for Rtp Replay Fuzzing.
2018-12-13 [email protected] Reland "Default to dlopening the PipeWire."
2018-12-13 [email protected] Adding metrics for hostname candidate use.
2018-12-13 [email protected] Reorder methods and members of HdrMetadata
Created with:
gclient setdep -r src/third_party/webrtc@24779d82292e
The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
BUG=chromium:755660,chromium:682122,chromium:914264,chromium:None,chromium:894045,chromium:914164,chromium:None,chromium:None,chromium:682122
[email protected]
Change-Id: I5286b9abd8b5c2110cdcc85633079001b3689e71
Reviewed-on: https://chromium-review.googlesource.com/c/1378445
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616810}IndexedDB: Update IDBObserverChanges to stop using WebIDBObservation
Bug: 717812
Change-Id: I2bd4419ce86555ed0041d07a23adc31cdc0d4253
Reviewed-on: https://chromium-review.googlesource.com/c/1366478
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616809}Fix policy descriptions to mention windows machange that are mdm enrolled.
Bug: 874081
Change-Id: I05a860e2c9488db74f265492516d8d1322afa0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1377521
Reviewed-by: Julian Pastarmov <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616808}Fix malformed sizes data
Fixes the sizes.py script producing malformed data that couldn't be
converted to histograms. The conversion script expects metric dicts
that contain story dicts, but sizes was essentially only producing
metric dicts.
This pulls out the "identifier" value to be the story name since that
seems to be what the perf dashboard is doing automatically when
uploading in the old format.
Bug: 906685
Change-Id: Ie06f2ff477e3346059473863138478c261712772
Reviewed-on: https://chromium-review.googlesource.com/c/1377195
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616807}Roll src-internal 82e510e0a578..67fbfe6310e6 (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82e510e0a578..67fbfe6310e6
Created with:
gclient setdep -r src-internal@67fbfe6310e6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I7e729121738b63b5b18e4b4a357f9a38954e0021
Reviewed-on: https://chromium-review.googlesource.com/c/1378505
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616806}ProfileProvider: Add a perf events collector
Add PerfCollector as a MetricCollector for perf events. This code is copied
from the PerfProvider class.
Replace PerfProvider with ProfileProvider as the main CWP class registered
with ChromeOSMetricsProvider, and remove the PerfProvider code.
BUG=b:116527691
TEST=Unit tests pass
Change-Id: I132201ee98e4e50379a23996ff00e71310dc7f99
Reviewed-on: https://chromium-review.googlesource.com/c/1372177
Commit-Queue: Gabriel Marin <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616805}[Extensions] Enforce URLPatternSet is moved or deliberately copied
Remove the ability for URLPatternSet to be implicitly copied, and
instead require it to be either std::move()'d or Clone()'d. This
helps avoid unintentional or unnecessary copies, which can be
costly.
Followups will adjust more sites to accept URLPatternSet as a value
and encourage callers to std::move() the set in.
Bug: 908536
Change-Id: I3c6a51037202b213aaf6cea8762746f9eee5adab
Reviewed-on: https://chromium-review.googlesource.com/c/1362494
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616804}Android: Enable in-tree libc++ builds
BUG=767901
R=thakis
CC=pcc
Change-Id: I70b017a99fe139d3925d7318116e435f5b6223ac
Reviewed-on: https://chromium-review.googlesource.com/c/1377329
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616803}Added runner for sharding egtests .
Runner runs test using command:
xcodebuild test-without-building -xctestrun file.xctestrun \
-parallel-testing-enabled YES -parallel-testing-worker-count %d% \
-destination "destination" -resultBundlePath %output_path%
that allows to split tests between few clones of simulator
(`destination` parameter) and stores an entire output of the command
(session and diagnostic logs) in specified folder(`resultBundlePath`).
Change-Id: I0a50680bb6946d227ab19719c16cbecffc3f8456
Bug: 912323
Reviewed-on: https://chromium-review.googlesource.com/c/1330204
Commit-Queue: Maksym Onufriienko <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Sergey Berezin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616802}[CrOS MultiDevice] Remove cryptauth service.
Since the MultiDevice API flag has been enabled, the cryptauth service
class is no longer used. This CL removes the class and instances
where it is called.
Bug: 912743
Change-Id: Iadcb5cd38fa70f4c4bb3d842940992faf33761af
Reviewed-on: https://chromium-review.googlesource.com/c/1367103
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Regan Hsu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616801}lock_screen_apps::StateController: Remove app window on close
This fixes a memory leak in unit tests in SingleProcessMash where
shutdown timing is slightly different.
Bug: 914823
Change-Id: Id23bba801e331a433b9cfff65a18caa8e08220eb
Reviewed-on: https://chromium-review.googlesource.com/c/1377376
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616800}Fixes necessary to enable in-tree libc++ on Android
All that should be necessary after this change is to flip use_custom_libcxx to
true on Android.
BUG=846855
R=thakis
Change-Id: I386176970ea7f05a9dbd7f04a2254c3a14d5419b
Reviewed-on: https://chromium-review.googlesource.com/c/1377501
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616799}[AF] Debug logs in wallet_metadata sync for flaky integration test
To be reverted as soon as the issue is found.
Bug: 915229
Change-Id: I81e9d1f7fa23eee957df8256fa858e210af620c8
Reviewed-on: https://chromium-review.googlesource.com/c/1377438
Commit-Queue: Jan Krcal <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616798}Revert "[unified-consent] Add subpage for sync data type toggles"
This reverts commit c62a1965a1ecd3ef8701679df3fbf26186219569.
Reason for revert:
This CL fails CrSettingsPeoplePageSyncControlsTest.All test.
Original change's description:
> [unified-consent] Add subpage for sync data type toggles
>
> - Add advanced sync subpage for configuration of sync
> data types.
> - Add row "Manage sync" to sync_page that links to this subpage.
> - When the user goes through the sign-in flow to customize
> settings and navigates to the advanced sync page, sync
> doesn't start yet and the snackbar to cancel sync is shown.
> When the user leaves the sync and the advanced sync page,
> sync will start.
>
> Additional changes:
> - Change "Sync and personalization" to "Sync".
> - Change "Manage synced data on Google dashboard" to "Data from Chrome sync".
> - Rename people_page_sync_controls.js to people_page_sync_controls_test.js.
>
> Screenshots:
> https://drive.google.com/file/d/1DTa1gcdNc6WihGAawKzHseLEBgpFjegm/view?usp=sharing
> https://drive.google.com/file/d/1sn42U_nlkihUhRX2REY1XDBr5YmWxM7C/view?usp=sharing
>
> [email protected]
>
> Bug: 912598
> Change-Id: Id7b3f7121aac49fe643f3ef14726e98bc40b1ec6
> Reviewed-on: https://chromium-review.googlesource.com/c/1370282
> Reviewed-by: Thomas Tangl <[email protected]>
> Reviewed-by: Scott Chen <[email protected]>
> Commit-Queue: Thomas Tangl <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616704}
[email protected],[email protected],[email protected]
Change-Id: Ic24dd9daac4d33fceae69dddc0d2f495d22d8814
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912598
Reviewed-on: https://chromium-review.googlesource.com/c/1378629
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616797}[blinkpy] Make use of retry_with_patch
https://crrev.com/c/1371225 not only fixed the retry_summary.json file,
but alsoe made the new retry_with_patch_summary.json file available.
This CL switches to retry_with_patch_summary.json to more robustly
ignore flaky/unrelated failures.
Bug: 811976
Change-Id: Id87136a895d7c1d40cd2d4c0b6b9acdaeefdc617
Reviewed-on: https://chromium-review.googlesource.com/c/1378490
Reviewed-by: Quinten Yearsley <[email protected]>
Commit-Queue: Robert Ma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616796}Tweak loading-animation speed and motion curves
These are changed to decrease the minimum time that the loading
animation can take. It's also done to make it feel snappier.
Bug: chromium:912620
Change-Id: If8e792cccc1f9f01bbe86909ce581bffbf1a7c35
Reviewed-on: https://chromium-review.googlesource.com/c/1377344
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616795}Enable PWAs and RemoteMacViews by default
Some tests only work when app shims are disabled. Plumb this signal
through to ensure that we don't create an AppShimHost for these.
Bug: 851848
Change-Id: I9e921afd1a26d4102c06972faa34db93e479abc2
Reviewed-on: https://chromium-review.googlesource.com/c/1377720
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616794}[DevTools] Encode binary websocket messages as base64
Bug: 914963
Change-Id: I9c468b9cbcff5cc5fe90385e14a749532238c3d4
Reviewed-on: https://chromium-review.googlesource.com/c/1377182
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616793}[Autofill] Use UploadCardSource in GetDetails requests
This CL moves from using MigrationSource (which was only applicable to
local card migration) to the new UploadCardSource enum (which applies to
both local card migration and normal card upload scenarios).
Bug: 909782
Change-Id: Ieef04c38b405bcb3fc17cbbb90a2ad66852c8c1e
Reviewed-on: https://chromium-review.googlesource.com/c/1377870
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616792}Reland "assistant: replace most thread task runner with sequenced"
This is a reland of 000208ccbdafbc2716beecc9e86d8912bcb5df67
Updated one more place that slipped in during submit.
Original change's description:
> assistant: replace most thread task runner with sequenced
>
> Bug: None
> Test: locally build and run
> Change-Id: I8e77799bcc4f417faf7dff54f9e40ab7a46f3d1f
> Reviewed-on: https://chromium-review.googlesource.com/c/1372722
> Reviewed-by: Tao Wu <[email protected]>
> Commit-Queue: Xiaohui Chen <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615732}
Bug: None
Change-Id: I52be8dfa5de9f1b4a70a2995ab054f0843272164
Reviewed-on: https://chromium-review.googlesource.com/c/1377312
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616791}Add 10.13 slices for mac gpu tests
This adds 10.13 as an optional dimension for a bunch of 10.12 tests so that we start upgrading the machines
Bug: 914413
Change-Id: I3d96b2c67c6768bb598e79e277b8e64d74198c61
Reviewed-on: https://chromium-review.googlesource.com/c/1376653
Commit-Queue: Brad Hall <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616790}Removed use of -openURL: which has been deprecated in iOS 10
should be safe to use it unconditionally.
-openURL: options:completionHandler: is available for iOS 10+, so it
Change-Id: I684f721fac163f267db0a7890bd45c79a141ac05
Reviewed-on: https://chromium-review.googlesource.com/c/1377742
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Peter Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616789}Change font weight from MEDIUM to NORMAL
Bug: 897998
Change-Id: Iec88c09d093f47dd788673a669c18ffaf63af9b2
Reviewed-on: https://chromium-review.googlesource.com/c/1374978
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Jason Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616788}Move TypeId to experimental
TypeId is not quite ready yet. In particular TypeId instances created
for the same type in different components are not "equal".
This patch adds a test that will fail (thus DISABLED for now) and moves
the TypeId class to experimental to prevent people for using it for now.
Bug: 906125
Change-Id: I10f7707d70a66173676a50d7cf3d3a25f431f905
Reviewed-on: https://chromium-review.googlesource.com/c/1377738
Commit-Queue: Gabriel Charette <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616787}Roll src/native_client faaebac44b2e..987c54ad6fe5 (1 commits)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/faaebac44b2e..987c54ad6fe5
git log faaebac44b2e..987c54ad6fe5 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Run lastchange.py in DEPS hooks
Created with:
gclient setdep -r src/native_client@987c54ad6fe5
The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:868204
[email protected]
Change-Id: Iae2192202ef919618e40006fdd407e1dcca760af
Reviewed-on: https://chromium-review.googlesource.com/c/1378485
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616786}[MediaFling] Start a fresh session every time
When flinging videos, we should start a fresh session every time so that
the session state is cleaned up properly and we don't control previous
flinged videos.
Bug: 711860
Change-Id: I6be7e993f60294276e919cf4b2b7f5d19d176b07
Reviewed-on: https://chromium-review.googlesource.com/c/1371012
Commit-Queue: Zhiqiang Zhang <[email protected]>
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616785}Bound the number of outstanding writes to SSLKEYLOGFILE.
Some AVs appear to be using this file, but pointing it to a pipe where
they cannot keep up with writes. We should not build up an unbounded
buffer, so just drop the entries past some very generous limit.
Tested manually by bringing the limit down to 5 and pointing
SSLKEYLOGFILE at a named pipe attached to a reader I had suspended (at
which point it still took a lot of work to exceed the pipe's buffer
to get to the Chrome-side limit).
Additionally, do not block shutdown, in case the buggy AV has stopped
reading from the pipe altogether.
Bug: 566951, 914880
Change-Id: I2c3bbf0f0762ea9f2b149df1856093efd614677b
Reviewed-on: https://chromium-review.googlesource.com/c/1377187
Reviewed-by: Ryan Sleevi <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616784}Android notification: Introduce ChromeNotification/PendingIntentProvider.
The Android API didn't expose notification id/tag and the int flags to
create Notification's PendingIntent, however we need to use these data
when recording Chrome notification metrics.
This CL adds wrapper class that contains these data.
ChromeNotificationBuilder will use these wrapper class in the future to
force metrics tracking and usage of NotificationManagerProxy.
Also we setup a new component for notification.
[email protected], [email protected]
Bug: 898269
Change-Id: I63e3976c729d71e761c8c6b5c0aead3763ba5e17
Reviewed-on: https://chromium-review.googlesource.com/c/1358650
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616783}app_list: Fix SearchResultView crash
Fix the crash introduced in http://crrev.com/c/1351714 that deletes
the search-what-you-type result when showing the answer card. The
change to SearchResults model does not go through regular search
results update code path. Hence not handled properly. The CL fixes
the issue by making SearchResultView handle OnResultDestroying so
that its internal state is updated whenever underlying SearchResult
goes away.
Bug: 914891
Change-Id: Idc17516865333114e47b218d17d3629f50657f4a
Reviewed-on: https://chromium-review.googlesource.com/c/1378487
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616782}Used by reflection for test CCT dynamic module
Also updated used by reflection to be more explicit.
TBR=yfriedman
Bug: 908988
Change-Id: I7a4b07fd60dd99afcf07239b9723d41cab575828
Reviewed-on: https://chromium-review.googlesource.com/c/1378240
Commit-Queue: Sam Maier <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616781}WebUI: Add min-width to cr-action-menu
Bug: 619787
Change-Id: Ia998d22791573e4ae2cfb71039b15893165f32cb
Reviewed-on: https://chromium-review.googlesource.com/c/1377311
Commit-Queue: John Lee <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616780}cros: Remove data saver extension notification
Stop showing chromeos users a notification prompting them to install a
data saver extension the first time they connect with a cellular
connection. Extension was recently removed.
Remove flag 'enable-datasaver-prompt' and deprecate
prefs::kDataSaverPromptsShown.
Add more tests to validate that notifications are only shown once.
Bug: 914470, 910767
Change-Id: I0c7799d9a57fcb207fcea946a4454b4edc466ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1374581
Commit-Queue: Tony De Luna <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616779}Reland "tracing: Port ARC tracing agent to perfetto"
This is a reland of 624045587baefaab9fc7a601cacfc8488071381a with fixes
to the state reset logic in ArcTracingBridge and ArcTracingDataSource.
Original change's description:
> tracing: Port ARC tracing agent to perfetto
>
> Adds a new DataSource for the ARC++ system tracing agent.
> Each ArcTracingBridge registers with the data source and keeps track of
> its state, so that the data source can coordinate tracing between all
> the bridges.
>
> [email protected]
>
> Test: Manually capture a trace with and without perfetto backend.
> Bug: 900603
> Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3
> Reviewed-on: https://chromium-review.googlesource.com/c/1360736
> Reviewed-by: Eric Seckler <[email protected]>
> Reviewed-by: Yusuke Sato <[email protected]>
> Reviewed-by: oysteine <[email protected]>
> Reviewed-by: Tom Sepez <[email protected]>
> Commit-Queue: Eric Seckler <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615483}
[email protected]
Bug: 900603
Change-Id: I018a9493e660fa9654ad31da734866b3835786a0
Reviewed-on: https://chromium-review.googlesource.com/c/1374982
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: oysteine <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616778}Disable interactive_ui_tests: SwitchAccessTest for Mash
This feature does not work in Mash yet.
Bug: 897365
Change-Id: I1fe5bb6436a4df340ab093089f8eaf0139876da4
Reviewed-on: https://chromium-review.googlesource.com/c/1377377
Reviewed-by: Anastasia Helfinstein <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616777}Roll src/third_party/catapult afefc1c51fc4..a382be45b72a (1 commits)
https://chromium.googlesource.com/catapult.git/+log/afefc1c51fc4..a382be45b72a
git log afefc1c51fc4..a382be45b72a --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Allow the caller to specify tracing categories for adb_profile_chrome_startup
Created with:
gclient setdep -r src/third_party/catapult@a382be45b72a
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I02c33e9188afc3baba59f56d426876516c7c8aa9
Reviewed-on: https://chromium-review.googlesource.com/c/1378446
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616776}Extract theme and page properties for StatusView
Change-Id: I1f1c090a22cdb366fc67ab09afd65c80add1e489
Bug: 871798
Reviewed-on: https://chromium-review.googlesource.com/c/1372708
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616775}IndexedDB: Rename WebIDBNameAndVersion to IDBNameAndVersion
Bug: 717812
Change-Id: Iad2535883687a6302ebd96a092329c4f1fe91efd
Reviewed-on: https://chromium-review.googlesource.com/c/1364343
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616774}[iOS] Add coordinator for non-modal UIAlertController presentation.
This coordinator disables fullscreen while started and creates a
NonModalAlertPresentationController. The non-modal presentation is
achieved by adding a mask to the presentation container view and
forwarding touches that occur outside that mask to the BVC.
Also in this CL:
- Updates AlertCoordinator to define the lazy instantiation
selector in the Subclassing category.
- Updates some FullscreenUIElement selectors to be optional.
Bug: 674649
Change-Id: Ie0df9a993871ebe1a88fda9578093abc38da57c3
Reviewed-on: https://chromium-review.googlesource.com/c/1360273
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616773}RemoteMacViews: Make certificate and file dialogs better
The certificate and file selection dialogs have not been adapted to be
able to run across processes using mojo.
At present, these dialogs appear behind their expected window, and
appear in the Chrome process. Make this situation better by making
them appear in front of their window (and, in front of everything).
Because some of these positioning decisions are made before the
true window geometry has been communicated back to the browser process,
more aggressively push geometry changes to the in-browser-process
NSWindow.
Bug: 913303
Change-Id: Ife2fbddcd758ee0b028743a916d12cf8ce0f41f3
Reviewed-on: https://chromium-review.googlesource.com/c/1378017
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616772}Enforce maximum domain name length in DNS response parser
Bug: 811618
Change-Id: I57dc54e56e3a857f05b34dffdefcec634719e0d6
Reviewed-on: https://chromium-review.googlesource.com/c/1369638
Reviewed-by: Eric Orth <[email protected]>
Commit-Queue: Daniel McArdle <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616771}Update MediaKeysListener API to set specific keys to listen to
This CL updates the MediaKeysListener API to listen for a specific set
of keys instead of listening to all media keys and depending on a
response from the MediaKeysListener::Delegate to decide whether or not
to propagate.
The advantage of this change is that it allows the
MediaKeysListener::Delegate::OnMediaKeysAccelerator callback to be
called on the delegate's own thread for the Windows implementation.
Before, since the Windows implementation depends on a keyboard hook
which runs on a dedicated thread, it needed to immediately know the
delegate's response so that it would know whether or not to propagate
the key event. Now, the listener is already aware of which keys to
propagate and can immediately propagate (or not) and post a task to
the main thread to call delegate_->OnMediaKeysAccelerator
asynchronously.
Bug: 902379
Change-Id: Ib7cb27bd6bbcec382fb4a050166df19aa9131673
Reviewed-on: https://chromium-review.googlesource.com/c/1374832
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616770}Adding new captured sites autofill tests.
This cl stands up a subset of the tests first introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1150818.
Bug: 847905
Change-Id: If64de9d457513a87e9ef2ba2bd37376a59ee4831
Reviewed-on: https://chromium-review.googlesource.com/c/1377504
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Yiming Zhou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616769}Disable WebRtcGetUserMediaBrowserTest.ApplyConstraintsNonDevice/* on Win-ASAN
With VizDisplayCompositor being set to on by default, this test has begun
flaking on WIN-ASAN only.
As we'd like to identify other potential flakes I'm electing to temporarily
disble the test, rather than revert the feature flag. I'll begin looking at it
locally.
[email protected]
TEST=WebRtcGetUserMediaBrowserTest.ApplyConstraintsNonDevice/*
Bug: 915135
Change-Id: I6435c556a6f6b23defa1da6976195e5d4d5bb521
Reviewed-on: https://chromium-review.googlesource.com/c/1377608
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616768}Remove palmer from OWNERS in SSL and security UX.
I'm not working on SSL or security UX these days, and am not the best person to
review CLs or own bugs in those areas.
Change-Id: I428d3e89cb80d4a39fb80776d4a5c789a22a31c3
Reviewed-on: https://chromium-review.googlesource.com/c/1377211
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Adrienne Porter Felt <[email protected]>
Reviewed-by: Christopher Thompson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616767}Roll src/third_party/pdfium caacc5ffb136..623e636edcd5 (1 commits)
https://pdfium.googlesource.com/pdfium.git/+log/caacc5ffb136..623e636edcd5
git log caacc5ffb136..623e636edcd5 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Call GetGlyphWidth() fewer times in LoadCompositeFont().
Created with:
gclient setdep -r src/third_party/pdfium@623e636edcd5
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:906338
[email protected]
Change-Id: I2d697717edf417ce048fea16fdeb833b7760ef35
Reviewed-on: https://chromium-review.googlesource.com/c/1378205
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616766}Update V8 to version 7.3.144.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1962a66f..36e5bdd6
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Ieee0e3b520baacf6002f992c440630756f3ad03f
Reviewed-on: https://chromium-review.googlesource.com/c/1378232
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616765}[NTP] Allow testing of interactive Doodles
The Doodle team tests interactive doodles by running a local
demo and supplying the --google-base-url to Chrome. Substitute
'https://www.google.com' in the interactive doodle url with
the given url. Add the base url to the NTP's CSP child-src
directive.
Bug: 583290
Change-Id: Ib28bd6dd513ddcde073d516876c480e322367ad9
Reviewed-on: https://chromium-review.googlesource.com/c/1373886
Commit-Queue: Kyle Milka <[email protected]>
Reviewed-by: Ramya Nagarajan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616764}Reland "[vr] On-demand install VR DFM on N+"
This is a reland of 3e6d27f2d89227b59b81f75cb3a396a01512595c with fix for
x86 builders (which have VR disabled).
Original change's description:
> [vr] On-demand install VR DFM on N+
>
> This requires handling the case when Chrome is started from VR before
> the module is installed. For this, move code that is required to
> identify VR intents and prevent 2D UI showing up in headset back to the
> base module. Furthermore, request VR module install when entering Chrome
> from VR and set up VR appropriately once the module install was
> successful. If the module cannot be installed within a timeout (we need
> a timeout so that Daydream does not kick us out of VR because we don't
> active VR mode in time) close Chrome on smartphones or launch it in
> 2D-in-VR mode on standalones.
>
> NOTE: The VR DFM is still not activated in Monochrome. So, this change
> won't be active yet.
>
> Bug: 914494
> Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
> Reviewed-on: https://chromium-review.googlesource.com/c/1372227
> Reviewed-by: agrieve <[email protected]>
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Tibor Goldschwendt <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616442}
[email protected],[email protected]
Bug: 914494
Change-Id: I4be696bf60e61e57d3d405e9a594838157244abd
Reviewed-on: https://chromium-review.googlesource.com/c/1377427
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616763}Fix dependency error and re-land:
Embed all localized strings into GCPW dll directly to allow localization.
- Code that generates the strings to be embedded into an
executable in chrome/installer/util was adapted so that it could be
used generically anyone.
- Used this common code to embed the strings into gaia1_0.dll and use
them directly in code.
Bug: 908451
Change-Id: Icc9b29c46afc93f2684cfe22370db12386907014
Reviewed-on: https://chromium-review.googlesource.com/c/1352576
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Tien Mai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#616695}
Reviewed-on: https://chromium-review.googlesource.com/c/1378247
Cr-Commit-Position: refs/heads/master@{#616762}Fix a11y traits of TableViewTextHeaderFooterView.
TableViewTextHeaderFooterView has UIAccessibilityTraits of
UIAccessibilityTraitButton and UIAccessibilityTraitHeader, but it's
never used as a button. This CL removes the UIAccessibilityTraitButton.
Bug: 910258
Change-Id: Id04c72449e5e2cfa3ea85efe3b9ea2cd05c6e2b6
Reviewed-on: https://chromium-review.googlesource.com/c/1378131
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Yi Su <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616761}Revert "Disable failing WebXR tests"
This reverts commit 4a2f6274a5b91d1bcba93db4ee5756c6e6de5255.
Reason for revert: Reverted the CL causing failures, so re-enabling tests.
Original change's description:
> Disable failing WebXR tests
>
> Disables failing WebXR tests that are causing CQ issues. Will be
> re-enabled once the root cause is found and fixed.
>
> [email protected]
>
> Bug: 913161
> Change-Id: If50af30cc9e24ce917989a0b0ac210254ce503bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1372540
> Reviewed-by: Brian Sheedy <[email protected]>
> Commit-Queue: Brian Sheedy <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615670}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 913161
Change-Id: I309819ee2a135d8ec30cc424726daf4a4fa15a2f
Reviewed-on: https://chromium-review.googlesource.com/c/1377489
Reviewed-by: Bill Orr <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616760}Roll src-internal b94aa37fe30c..82e510e0a578 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b94aa37fe30c..82e510e0a578
Created with:
gclient setdep -r src-internal@82e510e0a578
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I4b3901193d2b00c4b2bd2d03e329ac33c5e0147a
Reviewed-on: https://chromium-review.googlesource.com/c/1378201
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616759}Remove web::WaitUntilWindowIdInjected test util.
WindowID is no longer injected so there is no need to wait for it.
Bug: 905939
Change-Id: Id1896eeb4a2e00f2f79e7f713443cbc80ac95b33
Reviewed-on: https://chromium-review.googlesource.com/c/1377339
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616758}Revert "Find-in-page per block using FindBuffer"
This reverts commit 71e551ac476ec9b247be8f19c6eb696632d90cf4.
Reason for revert: broke MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy on win7 tests dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73554
[7424:304:1214/084019.035:FATAL:find_buffer.cc(27)] Check failed: start_position == PositionInFlatTree::FirstPositionInNode( *start_position.ComputeContainerNode()).
Original change's description:
> Find-in-page per block using FindBuffer
>
> This CL introduces FindBuffer, which Find-in-page will use to find
> matches instead of using FindPlainText that uses TextIterator.
>
> Since find-in-page matches can't span multiple blocks, we are using
> that fact to know where we can separate the text in the document.
> FindBuffer collects text one block at a time, and then finds the match
> in that block. We trigger FindBuffer text collection & finding many
> times until it goes through everything. FindInPage uses TextSearcherICU
> to find text, and uses flat-tree traversal, ComputedStyle, and
> LayoutObject + NGOffsetMapping, whereas the previous way was to use
> TextIterator.
>
> This CL also changes the way we handle newlines - newlines will be
> saved as object replacement character/whitespaces for Find-in-page
> purposes. Some tests that rely on newlines are deleted as a result.
> Note:
> This change is not user-visible because it is not possible to do a
> Find-in-page from the UI with newlines.
>
> See doc for details:
> https://docs.google.com/document/d/1D5q7ZMrLPfilXnIGI3SOL0mwdiQC7SQEtGWk-9ysbMg/edit?usp=sharing
>
> Bug: 868227
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: Id5dd7e6c428f59442d02ec88ea0cec6eb4e64c22
> Reviewed-on: https://chromium-review.googlesource.com/c/1282425
> Commit-Queue: Rakina Zata Amni <[email protected]>
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Reviewed-by: Xiaocheng Hu <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616701}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ic06a33d1c630bb4423fc0963bc55b6af5e8ef865
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868227
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1378407
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616757}base: Disable JSONPerfTest.StressTest
Disable JSONPerfTest.StressTest as it is still timing out even after
increasing the timeout.
[email protected]
Bug: 906686
Change-Id: I67434e2405f86fd7f0fe9d82a901e618ac0b2b9e
Reviewed-on: https://chromium-review.googlesource.com/c/1378144
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616756}Remove webgl_conformance_gles_passthrough_tests from android-marshmallow-arm64-rel
This test suite is still run on the GPU FYI waterfall and android_angle_rel_ng
BUG=882580
Change-Id: Ifcfb5ff60b7cba84d09358206ab0fd4676a63394
Reviewed-on: https://chromium-review.googlesource.com/c/1378239
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616755}Tell shaderc where to find SPIRV-Cross.
Set a variable in build_overrides that gives the location of shaderc's
new SPIRV-Cross dependency. The variable will take a different value
for a dawn stand-alone build.
BUG=915096
Change-Id: Ied39c0b233de2c3e8ea29b576759c4c4eb8b0a61
Reviewed-on: https://chromium-review.googlesource.com/c/1378009
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Frank Henigman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616754}shelf: Adjust the order of GetShelfBackgroundType.
Use SHELF_BACKGROUND_SPLIT_VIEW when both splitview and overview are
active. The background of the shelf will also influence the radius
corner of the shelf.
Bug: 912409
Change-Id: I28643eface4a22422c24978686f7a50b01c7dba7
Reviewed-on: https://chromium-review.googlesource.com/c/1377431
Commit-Queue: Min Chen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616753}window-service: rename ServerWindow to ProxyWindow
And use the name 'proxy' in more places.
BUG=none
TEST=none
Change-Id: I84309d4fd898b9571df8b78e756ae02f54dcbd8a
Reviewed-on: https://chromium-review.googlesource.com/c/1377184
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616752}Reland "Reland "wm: Update nested activation handling""
This is a reland of 77fbe34018de545f5b733709a2afcb1391ef1364
with fix for the UAF.
Original change's description:
> Reland "wm: Update nested activation handling"
>
> This is a reland of ecde845099001740fee119a82d45664e622d0ade
>
> Original change's description:
> > wm: Update nested activation handling
> >
> > - DCHECK() and no-op if the nested activation wants to change
> > to a different active window other than the one being activated;
> > - Allow focus shift in nested activations as long as they don't
> > change the window to be activated
> >
> > Bug: 908524
> > Test: FocusControllerApiTest.ActivateWhileActivating
> > Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642
> > Reviewed-on: https://chromium-review.googlesource.com/c/1357017
> > Reviewed-by: Scott Violet <[email protected]>
> > Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
> > Commit-Queue: Xiyuan Xia <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616346}
>
> Bug: 908524, 914915
> Change-Id: Id0072941bfb0def54f093bcb771b2d8485c9b04e
> Reviewed-on: https://chromium-review.googlesource.com/c/1376726
> Reviewed-by: Scott Violet <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616496}
Bug: 908524, 914915
Change-Id: Id3786796d109cfdb7c4caf1529243af93830da69
Reviewed-on: https://chromium-review.googlesource.com/c/1378236
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616751}Remove the reference of ash from webui_login_view.cc
This file refers ash::Shell to register global accelerators,
but I believe this is not necessary. This CL removes that code
entirely.
Bug: 854346
Test: none
Change-Id: Ibd72da382d28e136daf571a7292fad7e875facfe
Reviewed-on: https://chromium-review.googlesource.com/c/1375876
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616750}[AF] Add test for the Wallet Sync Transport opt-in pref serialization
Bug: 914935
Change-Id: I52dde692e3f803cf5923090541371bec726667d5
Reviewed-on: https://chromium-review.googlesource.com/c/1378231
Reviewed-by: Tommy Martino <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616749}Allow extra tracing categories to be added to startup profiling
Depends on https://chromium-review.googlesource.com/c/catapult/+/1378200
to function.
Change-Id: Ie7056d2901cf88098de624a0e3bf6e3d061575d6
Reviewed-on: https://chromium-review.googlesource.com/c/1377345
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Mohamed Heikal <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616748}a11y: Include <memory> for std::unique_ptr in accessibility_alert_window.h
IWYU. This fixes the libstdc++ build after commit 1ed701bc4 ("Remove fake
alert AXObjWrapper object"):
In file included from ../../ui/views/accessibility/accessibility_alert_window.cc:5:
../../ui/views/accessibility/accessibility_alert_window.h:34:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
std::unique_ptr<aura::Window> alert_window_;
^~~~~~~~~~
../../ui/views/accessibility/accessibility_alert_window.h:34:3: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
Bug: 819294
Change-Id: I5e41e529fb5961ae2c93359328d437da40fa60fd
Reviewed-on: https://chromium-review.googlesource.com/c/1375119
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Raphael Kubo da Costa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616747}Add OAuth token as additional authentication for CloudPolicyClient
OAuth token (if set on the client) is passed in policy fetch and status
upload requests next to DMToken.
Additional authentication will be used for child user.
Bug: 839025
Test: CloudPolicyClientTest
Change-Id: I7332fae6ba9b290143ba8d2a5301ba56ad9c1880
Reviewed-on: https://chromium-review.googlesource.com/c/1376352
Commit-Queue: Aga Wronska <[email protected]>
Reviewed-by: Lutz Justen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616746}Remove SSLSocketParams::ignore_certificate_errors
As of https://chromium-review.googlesource.com/c/chromium/src/+/1343054,
it's no longer respected.
Bug: 347402
Change-Id: I3e964d5384a4adc20d121a56882b27197a85c49f
Reviewed-on: https://chromium-review.googlesource.com/c/1378241
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616745}[BlinkGenPropertyTrees] Fix SitePerProcessHitTestBrowserTest
This CL fixes the test:
SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture
Turning on BlinkGenPropertyTrees changes how OOPIFs are clipped in non
trivial clipping scenarios, such as border-radius. In this test, the
OOPIF has a border-radius. Prior to BGPT, the OOPIF would not be masked
correctly.
The fix here is to simply remove the failing ASSERT. It's simply
checking that events sent to the given point get routed to the iframe's
RenderWidgetHostView. With BGPT, we correctly perform masking so the hit
test realizes the result will be ambiguous and requires a hit test in
the renderer. Additional details are in the bug.
The ASSERT is unneeded as the InputEventAckWaiter will wait on the ACK
in the child RWHV so if it gets mis-routed the waiter will never awaken.
Bug: 912334
Change-Id: Iaf76181ed7e89971e445076905057ebde30abffb
Reviewed-on: https://chromium-review.googlesource.com/c/1374467
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616744}Remove the GCMAppHandler on DeviceSyncBase destruction
A use-after-free was observed in the GCMDriver's shutdown sequence
on accessing this GCMAppHandler, following Ken's earlier CL:
https://chromium.googlesource.com/chromium/src/+/ad3c758a491a0f08788acba07a859e66c42684b8
My hypothesis is that it caused the DeviceSyncBase to be destroyed prior
to the GCM Driver (which is a Profile-bound KeyedService), whereas it
would previously be destroyed after. This CL proposes a work-around by
removing itself from the GCM Driver on destruction.
This causes a new problem however - if Ken's CL were to be reverted, the
situation changes and we'd now have a potential use-after-free here. The
DeviceSync code needs to either stop using the GCMAppHandler for observing
Profile shutdown time, which has unintentional side-effects anyway, or
declare a dependency on the GCMProfileServiceFactory somewhere to make
sure destruction happens in the right order.
Bug: 914562
Change-Id: I0f1eb0c641936e188e3a93ce4f34b0f57ffc3125
Reviewed-on: https://chromium-review.googlesource.com/c/1378143
Reviewed-by: Jeremy Klein <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616743}cros mobile settings: show spinner when scanning
Change adds a spinner while scanning mobile networks to network details
page.
Bug: 804455
Change-Id: Ic0cf8cf79b510a039c3862fc8ee00d0137278345
Reviewed-on: https://chromium-review.googlesource.com/c/1375096
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Tony De Luna <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616742}Roll src/native_client 14b228f23bb8..faaebac44b2e (1 commits)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/14b228f23bb8..faaebac44b2e
git log 14b228f23bb8..faaebac44b2e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Update build_rev
Created with:
gclient setdep -r src/native_client@faaebac44b2e
The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I285f7b7e1f384be060514047b39f372d49c43ada
Reviewed-on: https://chromium-review.googlesource.com/c/1378202
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616741}Re-enable browser_tests on a bunch of mac bots.
We disabled browser_tests on all mac bots due to issue 828031.
Now that that's resolved, undo that.
In particular, re-enables browser_tests on Mac Asan.
Bug: 828031
Change-Id: Ic832455a962bb748afb34eebcbf95f0c52e00aca
Reviewed-on: https://chromium-review.googlesource.com/c/1377520
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616740}Roll src/third_party/perfetto 61804c04b375..4447823aa71d (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/61804c04b375..4447823aa71d
git log 61804c04b375..4447823aa71d --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Merge "perfetto-ui: Hide empty details pane & fix time by cluster query"
Created with:
gclient setdep -r src/third_party/perfetto@4447823aa71d
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ifdc323ce331af75a003ac9f8724d4ae79481b402
Reviewed-on: https://chromium-review.googlesource.com/c/1378203
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616739}Revert "Pausable Object Cleanup - XMLHttpRequest"
This reverts commit df0477e9ca0423600017a6e6fb566ff5784c7667.
Reason for revert: Workers don't support paused task queues
Original change's description:
> Pausable Object Cleanup - XMLHttpRequest
>
> The events dispatched by the XMLHttpRequestEventThrottle are attached
> to the kNetwork TaskQueue which is a pausable task queue.
>
> Verified progress events aren't received while an alert dialog is present.
>
> BUG=907125
>
> Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e
> Reviewed-on: https://chromium-review.googlesource.com/c/1368462
> Reviewed-by: Kentaro Hara <[email protected]>
> Reviewed-by: Alexander Timin <[email protected]>
> Commit-Queue: Dave Tapuska <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615143}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 907125
Change-Id: Idd2b19aa6d935a3c1e51bf1e03ebd34e0ae8dbd2
Reviewed-on: https://chromium-review.googlesource.com/c/1378198
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616738}Roll src/third_party/skia f6206f91b3c1..af67819ee1d9 (1 commits)
https://skia.googlesource.com/skia.git/+log/f6206f91b3c1..af67819ee1d9
git log f6206f91b3c1..af67819ee1d9 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Roll third_party/externals/angle2 828c59462fc1..dfaccbc08abb (1 commits)
Created with:
gclient setdep -r src/third_party/skia@af67819ee1d9
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ie7304f54615520a0e379333a886ddd3790057dfd
Reviewed-on: https://chromium-review.googlesource.com/c/1378195
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616737}[iOS] Add chrome://inspect webUI page.
Remove the Debug only "Log JS" switch from the Settings page.
Add a new chrome://inspect webUI page with a button to enable and
disable JavaScript console logging. Messages are still logged in the
same manner to the Xcode console, but will be moved to be displayed on
the chrome://inspect page in a follow-up CL.
The new UI of the chrome://inspect page can be seen here:
https://drive.google.com/file/d/1IdEHPYCaEhgNyRZ82_cygJVQVbhT5rNL/view?usp=sharing
Bug: 899851
Change-Id: I653c1e31f95cf15d5acfe453d92c56f5e5e0431e
Reviewed-on: https://chromium-review.googlesource.com/c/1363632
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616736}Add CloudManagementEnrollmentToken into policy template.
Even though we don't read this policy value from Pref service, we still
want to put it into policy_templates.json so that admin could find it in
the ADM/ADMX template.
Change-Id: I1fe1419f456256187e53bf360871f9b9a08bb2a8
Reviewed-on: https://chromium-review.googlesource.com/c/1374465
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616735}Do not invoke Drag() when neither mouse nor touch is pressed
Bug: 914527
Test: the new test case covers
Change-Id: Iab56b2aa9ec477542e22d7d684e24605f4934257
Reviewed-on: https://chromium-review.googlesource.com/c/1375110
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616734}Renamed persistent tab restore service.
In preparation for another CL which makes persitence dependent on a policy pref.
Bug: 869580
Change-Id: I5fa64297c9c6dbddf121703686c41f1a52bae1d8
Reviewed-on: https://chromium-review.googlesource.com/c/1378229
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Marc-André Decoste <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616733}IndexedDB: Remove WebIDBKeyPath
Bug: 717812
Change-Id: I45942eef81822ba0de88d60bbda9297e00587d4e
Reviewed-on: https://chromium-review.googlesource.com/c/1364342
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Chase Phillips <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616732}Use GetFactoryLocaleList in chromecast/ for Android Things N
Test: Flash Factory image, and hear bootup in french on AT1
Bug: 120666184
Change-Id: I30fe235ef33de5bbd8feae00cc49f53a0f770559
Reviewed-on: https://chromium-review.googlesource.com/c/1374461
Commit-Queue: Elvin L <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616731}CrOS Shelf: Fix RTL drag gesture
Before this CL, given the reverse X coordinates in RTL, a drag towards
one direction would cause the dragged view to move in the opposite
direction.
Bug: 913092
Change-Id: I7454d9161d91d459cedcccd1e8da0a2b10918655
Reviewed-on: https://chromium-review.googlesource.com/c/1373452
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616730}[android] Remove DCHECK from RefreshTokenIsAvailable.
RefreshTokenIsAvailable is now called for accounts that are only present
in the Gaia cookies and that were previously not seeded yet. This leads
to the DCHECK in |OAuth2TokenServiceDelegateAndroid::MapAccountIdToAccountName()|
being fired. This is unexpected as the code should simply return false in that
case (not crash).
This CL removes this DCHECK when MapAccountIdToAccountName is called from
RefreshTokenIsAvailable.
Bug: 915238
Change-Id: I863a822a5429f9aef54d78bcf39d573ebf647e84
Reviewed-on: https://chromium-review.googlesource.com/c/1378139
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616729}Video Wake Lock: move all logic to Blink and use mojo service.
This is implementing VideoWakeLock insideo core/html/media/ in Blink.
The component is created by the HTMLVideoElement and then reacts based
on internal events. When the wake lock state changes, it uses the wake
lock service to notify of the state change.
Two side notes:
- This is using the RemotePlaybackObserver/RemotePlaybackController that
were added to allow core/ to be notified of remote playback changes. It
allows to clarify a weird behavior that was in the browser
implementation.
- html_media_test_helper.{h,cc} files have been created to have a
central place for common html media mock, stubs, etc.
The audio wake lock is based on audibility, not on the element itself.
Whether it can or should be moved to Blink wasn't yet decided.
Associated design doc:
https://docs.google.com/document/d/1VNX6OIKodKg9-SWnY8eWiu2217b7FsgCECV2_wBap0U/edit?hl=en&pli=1#
Bug: 903793
Change-Id: I5f3f7fdfa345ef829f3efdc5689faef40b03f94c
Reviewed-on: https://chromium-review.googlesource.com/c/1375098
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616728}Add SequenceManager to field trial testing config
SequenceManager will be replacing MessageLoop soon so lets start testing
the new setup.
Bug: 891670
Change-Id: I1ddf44a3623b0ff281d88cb7a8a8231834d1276d
Reviewed-on: https://chromium-review.googlesource.com/c/1378134
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Brian White <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616727}Add chooser-exception-list-entry Polymer element
This change adds the chooser-exception-list-entry Polymer element to
site settings. This element will be used to display a chooser exception
in a row.
Design doc:
https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w
Bug: 854329
Change-Id: I4ac0d348a13180932af1d553b5640792f476999b
Reviewed-on: https://chromium-review.googlesource.com/c/1357610
Commit-Queue: Ovidio Henriquez <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616726}Remove use of WebWidget's IsWebView() and IsWebFrameWidget().
Use is-main-frame logic instead, which will remain true as we convert
the WebWidget for the main frame away from a WebView to a
WebFrameWidget.
This removes a dependency on WebWidget being-a WebView.
[email protected], [email protected]
Change-Id: I8af02679ba0aaff8ef638757e04a533b84ce364d
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1374463
Commit-Queue: danakj <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616725}Revert "Android OOP-D: Fix CursorAnchorInfoController updates"
This reverts commit fe193e30a172b63cc67222c5f353916e44e6db1e.
Reason for revert: Cause of https://crbug.com/913161
Original change's description:
> Android OOP-D: Fix CursorAnchorInfoController updates
>
> This chnage causes RenderWidget to invalidate its current
> LocalSurfaceId whenever it sends WidgetHostMsg_TextInputStateChanged,
> causing a new RenderFrameMetadata to be sent for the given frame.
>
> This ensures that CursorAnchorInfoController receives updates on any
> frame with a text change.
>
> Bug: 912309
> Change-Id: Ia1b0faa8bbb0208187d31f0024a17ffdd75bda16
> Reviewed-on: https://chromium-review.googlesource.com/c/1364164
> Commit-Queue: Eric Karl <[email protected]>
> Reviewed-by: Saman Sami <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#614729}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 912309
Change-Id: I9bcca12fc7a7040f6deffb1f098ba60486349062
Reviewed-on: https://chromium-review.googlesource.com/c/1376314
Commit-Queue: Eric Karl <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616724}Reland "[ios] Store TaskRunners instead of threads in WebThreadImpl."
This is a reland of 3d3f6bf113b71a9d0d2a259152581a5d65f76a22
The call to ResetGlobalsForTesting() has been moved from
TestWebThreadBundle to TestWebThread, as some unittests instantiate
TestWebThreads directly.
Original change's description:
> [ios] Store TaskRunners instead of threads in WebThreadImpl.
>
> Track thread states explicitly instead of simply checking
> whether a TaskRunner pointer exists or not.
>
> BUG=826465
>
> Change-Id: Id0f84e7eedc6b9f6568aec629abbb86f46979efa
> Reviewed-on: https://chromium-review.googlesource.com/c/1340827
> Reviewed-by: Rohit Rao <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Gabriel Charette <[email protected]>
> Commit-Queue: Rohit Rao <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616319}
Bug: 826465,914869
Change-Id: I522b1bb46464a17ade84a20857ee7db2cb713a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1377320
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616723}Call the client hints factory "client hints factory".
Jumbo builds failed when several files claimed to define
the g_previews_service_factory.
Change-Id: Id16f0c0c66da9fdb7c0d42afda611d672ab6da14
Reviewed-on: https://chromium-review.googlesource.com/c/1377441
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616722}Reland "Add default sanitizer options for Windows."
This reverts commit 5c249e73340e287d8a62776e4d7a70c6c093d5e9.
And removes the unsupported detect_stack_use_after_return option.
[email protected]
Change-Id: Iffcb4010725b9c2cec118eea48efcc01fb2a5fef
Reviewed-on: https://chromium-review.googlesource.com/c/1375932
Reviewed-by: Jonathan Metzman <[email protected]>
Commit-Queue: Abhishek Arya <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616721}[jumbo] Replace one of two colliding GetMainFrame with IsMainFrame()
There were two GetMainFrame() functions in chrome/browser which
clashed in jumbo (unity) builds. Since one of them is only
used to check if the current frame is the main frame, simplify
the code a bit.
Change-Id: I2d0b30d4ca2c18f202db709514c55c84a7eb350f
Reviewed-on: https://chromium-review.googlesource.com/c/1378140
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616720}Remove unnecessary DCHECK for FIP start position
The DCHECK is actually faulty, because the start position
can be the last position instead in some cases like <hr>
[email protected]
Bug: 868227
Change-Id: I9ee87d4cfd710e07742b9c8896583be060816c56
Reviewed-on: https://chromium-review.googlesource.com/c/1378153
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616719}chromeos: updates BrowserWithTestWindowTest for mash
makes it call to AshTestHelper to create MusClient. This also moves
creation slightly earlier as some tests may need MusClient earlier.
BUG=910241
TEST=covered by tests
Change-Id: I434716e8cbdf91a2af27330f53b7ddef331b6c82
Reviewed-on: https://chromium-review.googlesource.com/c/1377721
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616718}[Media Engagement] Fix preload bundling on Windows
Fix MEIPreload bundling on Windows to include it with
the Chromium installer.
BUG=180589
Change-Id: I530a859236f4f31f1f155b077366815de4badc7f
Reviewed-on: https://chromium-review.googlesource.com/c/1376100
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616717}Reland "Reland of: [code coverage] Add all fuzzer targets"
This is a reland of 80cee65bec02ee6edbd88670120867bc0af8e028
Original change's description:
> Reland of: [code coverage] Add all fuzzer targets
>
> Now with a fix for the issue in GenerateIsolates().
>
> R=jbudorick,stgao,liaoyuke
>
> > Change-Id: I78ffec6525cd1d808a4b431ae1e2729b76357d46
> > Reviewed-on: https://chromium-review.googlesource.com/c/1372917
> > Commit-Queue: Shuotao Gao <[email protected]>
> > Reviewed-by: Shuotao Gao <[email protected]>
> > Reviewed-by: John Budorick <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#615834}
>
> Change-Id: I4ae0ef2588026bb6e0e5501e9ff39a7852d89afa
> Reviewed-on: https://chromium-review.googlesource.com/c/1374777
> Reviewed-by: Yuke Liao <[email protected]>
> Reviewed-by: John Budorick <[email protected]>
> Commit-Queue: Roberto Carrillo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616169}
Change-Id: I360303f0c4ecb2b818c4ad6e936d3d4b1dfb1807
Bug: 914776
Reviewed-on: https://chromium-review.googlesource.com/c/1376321
Reviewed-by: Shuotao Gao <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Shuotao Gao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616716}[jumbo] Rename a GetBrowserContext function
There are several GetBrowserContext functions in content/browser
and in jumbo builds, base::BindRepeating did not know which
one to use. This renames one of them to make it clear for everyone,
including the compiler in jumbo builds.
Change-Id: Ifd35c418ae780c8e7874603c1e261cb3db02acf0
Reviewed-on: https://chromium-review.googlesource.com/c/1377740
Commit-Queue: Daniel Bratell <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616715}Roll src/third_party/angle 4a9f9b08b691..70fd9b5d381e (3 commits)
https://chromium.googlesource.com/angle/angle.git/+log/4a9f9b08b691..70fd9b5d381e
git log 4a9f9b08b691..70fd9b5d381e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Fix compile error in angle_white_box_perftests.
2018-12-14 [email protected] Clean up Windows DEF file generation.
2018-12-14 [email protected] Split angle_perftests into white and black box.
Created with:
gclient setdep -r src/third_party/angle@70fd9b5d381e
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I4fa4012650e517b1a5ee4a7cceb3bbe4a6e21a71
Reviewed-on: https://chromium-review.googlesource.com/c/1377622
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616714}Develop IdentityManager::Observer equivalent to GCMS::Observer::OnAddAccountToCookieCompleted
CL adds an equivalent hook to
GaiaCookieManagerService::Observer::OnAddAccountToCookieCompleted
in IdentityManager::Observer.
This is part of the effort to allow GCMS::Observer be replaced by
IdentityManager::Observer. No functionality changes expected.
The unittests aim at ensuring the hook is called through
Observers of IdentityManager in case of successful or failing session
merges.
BUG=903718
Change-Id: Id08c4515171f3c21e134c2c129593e8977bd7e11
Reviewed-on: https://chromium-review.googlesource.com/c/1376529
Commit-Queue: Antonio Gomes <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616713}[UserTiming] Fix mark-measure-return-null test
The test was incorrect per L2 spec: a void method 'returns' an undefined
value, not a null object. This CL changes the test to show how to
perform feature detection and compares L2 and L3 behavior.
Bug: 914441
Change-Id: Id7173b2693d5bd42013dcdd25266d64fa8956e6a
Reviewed-on: https://chromium-review.googlesource.com/c/1377129
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616712}Roll src-internal c31983dd3bae..b94aa37fe30c (4 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c31983dd3bae..b94aa37fe30c
Created with:
gclient setdep -r src-internal@b94aa37fe30c
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I06735d8dc57dac70805192b37c303d6d3f379490
Reviewed-on: https://chromium-review.googlesource.com/c/1378197
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616711}Add sensitiveValue to ParentAccessCodeConfig policy schema.
Bug: 1359893
Test: manually
Change-Id: I5291ee8542b9e21cdfe7ea3ca1d263e48b68ebf3
Reviewed-on: https://chromium-review.googlesource.com/c/1377069
Commit-Queue: Aga Wronska <[email protected]>
Reviewed-by: Lutz Justen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616710}Prevent tail call optimization in CrashBecauseThreadWasUnresponsive().
Tail call optimization prevents the address of
ThreadUnresponsive_UI/IO from appearing on the stack in recent builds
of Chrome. This prevents the crash server from correctly labelling
hang reports. This CL tweaks the code to prevent tail call
optimization. More details at https://crbug.com/905288#c10.
Bug: 905288
Change-Id: Ie26652d976692b7852ec970f1ade1953babe12c9
Reviewed-on: https://chromium-review.googlesource.com/c/1373878
Reviewed-by: Jesse Doherty <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616709}Cleanup arraysize usage in //storage
This CL cleanup arraysize usage in //storage with:
- Range based for-loops when iterating
- Replace with base::size()
Bug: 837308
Change-Id: Id4c9eedf4371b819e61d735b6cdbb68eeeb7594c
Reviewed-on: https://chromium-review.googlesource.com/c/1377474
Reviewed-by: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616708}rm legacy fontmetrics flag
Change-Id: Ie54911cd061d8343be0feabef8bad63fa6da9419
Reviewed-on: https://chromium-review.googlesource.com/c/1376732
Reviewed-by: Florin Malita <[email protected]>
Commit-Queue: Mike Reed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616707}[ChromeDriver] Add checking element_id format
Bug: chromedriver:2681
Change-Id: Ie9da49cfd5210891210e839ab1f7414580bebbba
Reviewed-on: https://chromium-review.googlesource.com/c/1377615
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Tatiana Buldina <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616706}Adding smaier@ to base/android/proguard/OWNERS
Change-Id: If7ff8242245dec1809d37b8088a8e016086a1625
Reviewed-on: https://chromium-review.googlesource.com/c/1378242
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Sam Maier <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616705}[unified-consent] Add subpage for sync data type toggles
- Add advanced sync subpage for configuration of sync
data types.
- Add row "Manage sync" to sync_page that links to this subpage.
- When the user goes through the sign-in flow to customize
settings and navigates to the advanced sync page, sync
doesn't start yet and the snackbar to cancel sync is shown.
When the user leaves the sync and the advanced sync page,
sync will start.
Additional changes:
- Change "Sync and personalization" to "Sync".
- Change "Manage synced data on Google dashboard" to "Data from Chrome sync".
- Rename people_page_sync_controls.js to people_page_sync_controls_test.js.
Screenshots:
https://drive.google.com/file/d/1DTa1gcdNc6WihGAawKzHseLEBgpFjegm/view?usp=sharing
https://drive.google.com/file/d/1sn42U_nlkihUhRX2REY1XDBr5YmWxM7C/view?usp=sharing
[email protected]
Bug: 912598
Change-Id: Id7b3f7121aac49fe643f3ef14726e98bc40b1ec6
Reviewed-on: https://chromium-review.googlesource.com/c/1370282
Reviewed-by: Thomas Tangl <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616704}[iOS] Option to prevent user interaction in settings
This CL adds an option to prevent the user interactions in the settings
panels backed with a TableView.
This feature already exists for the panels backed with a Collection.
Bug: 894791
Change-Id: I80abf7c5f8dc0ae1d1c6ae5177a6f55ec44ff1f1
Reviewed-on: https://chromium-review.googlesource.com/c/1373821
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Yi Su <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616703}Revert "Embed all localized strings into GCPW dll directly to allow localization."
This reverts commit 61e28c177145da085bdf576f2db782c5402213da.
Reason for revert: Broke compile on
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Win%20Builder/102191
../../chrome/credential_provider/gaiacp/gcp_utils.cc(46,10): fatal error: 'chrome/credential_provider/gaiacp/gaia_resources.h' file not found
#include "chrome/credential_provider/gaiacp/gaia_resources.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Looks like this is probably missing a gn dep to make sure the header
is generated by the time it is included.
Original change's description:
> Embed all localized strings into GCPW dll directly to allow localization.
>
> - Code that generates the strings to be embedded into an
> executable in chrome/installer/util was adapted so that it could be
> used generically anyone.
> - Used this common code to embed the strings into gaia1_0.dll and use
> them directly in code.
>
> Bug: 908451
> Change-Id: I6f40dc08aee8553358c775aeda82b8d0ed7a5db2
> Reviewed-on: https://chromium-review.googlesource.com/c/1352576
> Reviewed-by: Nico Weber <[email protected]>
> Reviewed-by: Greg Thompson <[email protected]>
> Reviewed-by: Roger Tawa <[email protected]>
> Commit-Queue: Tien Mai <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616695}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I8a26588d125713cd2a1c6c925a5adbbf91e47219
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908451
Reviewed-on: https://chromium-review.googlesource.com/c/1378405
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616702}Find-in-page per block using FindBuffer
This CL introduces FindBuffer, which Find-in-page will use to find
matches instead of using FindPlainText that uses TextIterator.
Since find-in-page matches can't span multiple blocks, we are using
that fact to know where we can separate the text in the document.
FindBuffer collects text one block at a time, and then finds the match
in that block. We trigger FindBuffer text collection & finding many
times until it goes through everything. FindInPage uses TextSearcherICU
to find text, and uses flat-tree traversal, ComputedStyle, and
LayoutObject + NGOffsetMapping, whereas the previous way was to use
TextIterator.
This CL also changes the way we handle newlines - newlines will be
saved as object replacement character/whitespaces for Find-in-page
purposes. Some tests that rely on newlines are deleted as a result.
Note:
This change is not user-visible because it is not possible to do a
Find-in-page from the UI with newlines.
See doc for details:
https://docs.google.com/document/d/1D5q7ZMrLPfilXnIGI3SOL0mwdiQC7SQEtGWk-9ysbMg/edit?usp=sharing
Bug: 868227
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Id5dd7e6c428f59442d02ec88ea0cec6eb4e64c22
Reviewed-on: https://chromium-review.googlesource.com/c/1282425
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616701}Remove some small uses of linked_ptr from google_apis/.
BUG=556939
Change-Id: I20214613329c368ccc6756f28300421148653fe7
Reviewed-on: https://chromium-review.googlesource.com/c/1376811
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616700}[WebMIDI] Remove content/renderer/media/midi
- Moves functionality in content::RendererWebMIDIAccessorImpl to
blink::MIDIAccessor, and functionality in
content::MidiSessionClientImpl to blink::MIDIDispatcher.
- Removes blink::WebMIDIAccessor and blink::WebMIDIAccessorClient.
- Replaces MockMIDIWebAccessor with a JS implementation of
midi::mojom::MidiSessionProvider and updates tests to use it.
Bug: 582328
Change-Id: I48fccfc20d85915450a0b738ad471edba18d3a8b
Reviewed-on: https://chromium-review.googlesource.com/c/1289955
Commit-Queue: Adithya Srinivasan <[email protected]>
Reviewed-by: agrieve <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616699}Guard against committing corrupt sync SESSIONS data
We don't currently know of scenarios where such condition would fail,
but since we've seen crashes in the wild, let's make sure future
versions of Chrome don't crash syncing instances of Chrome that run an
older version (M71).
Bug: 915133
Change-Id: I5f17af1cd3a0dc73298742cbd664fe8b0e193003
Reviewed-on: https://chromium-review.googlesource.com/c/1378093
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616698}[AF Wallet] Log has_converted() in AutofillProfile::operator<<
Bug: 915229
Change-Id: I62bffaca4e7d335d8ad60bc4fa90cb71b2553ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1377421
Commit-Queue: Jan Krcal <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616697}Verify permanent bookmarks are received in initial update
In order to debug why certain bookmarks remain untracked, let's
temporarily add CHECKs that require the presence of all permanent
bookmark nodes (except mobile bookmarks) in the initial sync.
Bug: 915198
Change-Id: Iace387e0818f2932e01b7ef7ac91529deff0f59d
Reviewed-on: https://chromium-review.googlesource.com/c/1378136
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616696}Embed all localized strings into GCPW dll directly to allow localization.
- Code that generates the strings to be embedded into an
executable in chrome/installer/util was adapted so that it could be
used generically anyone.
- Used this common code to embed the strings into gaia1_0.dll and use
them directly in code.
Bug: 908451
Change-Id: I6f40dc08aee8553358c775aeda82b8d0ed7a5db2
Reviewed-on: https://chromium-review.googlesource.com/c/1352576
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Tien Mai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616695}Roll src-internal af3970215f54..c31983dd3bae (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af3970215f54..c31983dd3bae
Created with:
gclient setdep -r src-internal@c31983dd3bae
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I4e6492d1f0651feba2ccd56d90affa4ad87a91ed
Reviewed-on: https://chromium-review.googlesource.com/c/1378193
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616694}Disable the three sync_integration_tests that fail under tsan and run suite on tsan bot.
Looks like all the protobuf issues went away, maybe due to #612796.
Only some tests still fail:
- TwoClientCustomPassphraseSyncTest.ClientsCanSyncDataWhenScryptEncryptionEnabledInOne
- EnableDisableSingleClientTest.DoesNotRedownloadAfterKeepDataWithStandaloneTransport
- SingleClientDirectorySyncTest.StopThenDisableDeletesDirectory
Disable them under tsan and run the suite on the tsan bot.
Bug: 852002,915219,843511,913704
Change-Id: I862a93a4669c2dbd57ded99c9704528201f687b9
Reviewed-on: https://chromium-review.googlesource.com/c/1377327
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616693}Make RunSegmenter code more compact
Use a template for the analogous Consume calls, simplify minimum
computation of three positions.
No functional changes.
Change-Id: I26873be937263b8bf524d54135b2e0607eec97ad
Reviewed-on: https://chromium-review.googlesource.com/c/1375712
Commit-Queue: Emil A Eklund <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616692}Roll src/third_party/dawn fd3717fa7cbc..08aa58f8d6ed (1 commits)
https://dawn.googlesource.com/dawn.git/+log/fd3717fa7cbc..08aa58f8d6ed
git log fd3717fa7cbc..08aa58f8d6ed --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Check if fence is nullptr in PostHandleQueueSignal
Created with:
gclient setdep -r src/third_party/dawn@08aa58f8d6ed
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:914808
[email protected]
Change-Id: I043c6aecb7c0f0b9cee7fa1d2d082ab570ee6285
Reviewed-on: https://chromium-review.googlesource.com/c/1378194
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616691}[Autofill Assistant] Forward action status.
With this patch, the client sends specific ProcessedActionStatus to the
server in the following cases:
- MANUAL_FALLBACK: when the action decides to switch to manual fallback,
such as when autofill fails
- INTERRUPT_FAILED: from WaitForDom, when an interrupt failed
- USER_ABORTED_ACTION: when the user aborted the script by closing
autobot
In the first two cases, this means that the client makes one extra call
to the server before giving up. The behavior shouldn't otherwise change.
It also fixes some cases where OTHER_ACTION_STATUS was returned instead
of ELEMENT_RESOLUTION_FAILED.
The goal of this change is to get a better idea of what's going on on
the client.
Bug: 806868
Change-Id: I5fcbb986e358a4cfdcc42df78e0bf86fe4e4731c
Reviewed-on: https://chromium-review.googlesource.com/c/1374981
Commit-Queue: Stephane Zermatten <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616690}Portals: Implement compositor pixel dumps for layout tests with Portals.
Bug: 865565
Change-Id: I47d687d9299354f15acf44a3960b3e2ad590f4df
Reviewed-on: https://chromium-review.googlesource.com/c/1366782
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Lucas Gadani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616689}Roll src/third_party/boringssl/src 0f5ecd3a8..4cce955d1
https://boringssl.googlesource.com/boringssl/+log/0f5ecd3a854546d943104e1f7421e489b7f4d5aa..4cce955d1487b5bd2b3c03ead986558649cdaadf
Bug: none
Change-Id: I82312272868986e735beb16c2be71059c4f0c396
Reviewed-on: https://chromium-review.googlesource.com/c/1376717
Reviewed-by: Steven Valdez <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616688}[DL]: Implement a budget interface in display locking.
This patch does a few things:
- Removes the debugging macro code since it's losing its value.
- Add a DisplayLockBudget with two implementations:
- Unyielding budget that never yields and finishes everything
- Strict yielding budget that always yields between every lifecycle phase.
- Pulls out the lifecycle state from the context to the budget
- Adds tests for the budgets.
The step after this would be to implement a yielding budget, which should
be a combination of strictly yielding logic with some sort of a deadline.
[email protected], [email protected]
Bug: 907619, 882663
Change-Id: Idc75abd2334ce7b5aa6b48714b5b720d3da81b42
Reviewed-on: https://chromium-review.googlesource.com/c/1372307
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: vmpstr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616687}Android: Delete unused .build_config entry: secondary_abi_java_libraries_list
Noticed it has a garbage value.
Change-Id: Iab81c23b149d895484c298dfe27f461adca8aa4a
Reviewed-on: https://chromium-review.googlesource.com/c/1377719
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616686}Android: Fix secondary_abi_loadable_modules ignored without secondary_abi_shared_libraries
Change-Id: If75c6f4d8c743caefe69442cddd713905095cf6a
Reviewed-on: https://chromium-review.googlesource.com/c/1377718
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616685}Removing flag `enable-improved-language-settings`'s metadata.
See https://crrev.com/c/1358703.
Bug: None
Change-Id: If7c6f7a6e9a939440e2ab9f84a15817fb7e694fd
Reviewed-on: https://chromium-review.googlesource.com/c/1375632
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Alexandre Frechette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616684}Import wpt@f378387ce241c01f959467cc4c755459fc705e30
Using wpt-import in Chromium dd855e255a25c75443d1ae9fa4f9fa9690f9cd8a.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
5a5cdf35a5 "Regression test for crbug.com/626744"
548e7b5e62 "Add quota usage details tests for all other storage backends."
a5fce755fd "Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html"
d8ec73bfb3 "Revert "Add quota usage details tests for all other storage backends.""
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/selectors
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: Ic8523a1aba586d5d4f25693da0b206a41228c99f
Reviewed-on: https://chromium-review.googlesource.com/c/1378018
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616683}[iOS] Create new AccountControlItem
This CL moves the existing AccountControlItem to Legacy and creates a
new AccountControlItem compatible with UITableView.
Bug: 894791
Change-Id: I22a6ececd54ebd030932ea977e29b8742f6f5501
Reviewed-on: https://chromium-review.googlesource.com/c/1373820
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616682}Add re-authentication support in Account Manager UI
Add support for re-authenticating signed out accounts in Chrome OS
Account Manager UI. This will be available in Settings > People > Google
accounts.
Bug: 833797, 904128
Change-Id: Icaf11def55570015131f0238fe92753fe635c070
Reviewed-on: https://chromium-review.googlesource.com/c/1375667
Commit-Queue: Kush Sinha <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616681}Fix crash if received corrupt sessions data
The codepath that verifies whether the client tag matches our
expectations via SessionSyncBridge should consider the fact that the
input data is corrupt.
Otherwise a CHECK failure is hit in
SessionStore::TabNodeIdToClientTag() and other various DCHECKs.
Bug: 915133
Change-Id: Ia7f39a1ccbe20cb34f47f9d86f5b682c3459b07f
Reviewed-on: https://chromium-review.googlesource.com/c/1377734
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616680}[Autofill Assistant] Expand bottom sheet when necessary.
Change-Id: Ieeb56d9dac080996b4855a3a3d86663f27483c74
Reviewed-on: https://chromium-review.googlesource.com/c/1377735
Commit-Queue: Jordan Demeulenaere <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616679}SigninManager should get LST from credential provider when possible
Bug: 907882
Change-Id: Icaf7f785bf05ab24ab098e91453df9d1fe787295
Reviewed-on: https://chromium-review.googlesource.com/c/1347787
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616678}[LayoutTest] Split animations-parsing.html into two tests
Currently it tests both style.animation and getComputedStyle.animation.
This CL splits the test into two tests, one for style.animation, and
the other one for getComputedStyle.animation such that each test is
minimal.
Bug: 772852
Change-Id: I3c3f43305497ffe9d91c4e3806efe2e65ff17806
Reviewed-on: https://chromium-review.googlesource.com/c/1378230
Reviewed-by: Stephen McGruer <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616677}Roll src/third_party/skia 59c9f1595ecd..f6206f91b3c1 (1 commits)
https://skia.googlesource.com/skia.git/+log/59c9f1595ecd..f6206f91b3c1
git log 59c9f1595ecd..f6206f91b3c1 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Add new method for calculating text atlas sizes
Created with:
gclient setdep -r src/third_party/skia@f6206f91b3c1
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Idd7e0f1f3f6073aee70301225889b2a81158dbdb
Reviewed-on: https://chromium-review.googlesource.com/c/1377605
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616676}Add helper library for implementing command-line tools
[email protected], [email protected], [email protected], [email protected]
Bug: 895891
Change-Id: I524a99ce20ca248a3d42f4df0f66da8aa1c8f084
Reviewed-on: https://chromium-review.googlesource.com/c/1369938
Commit-Queue: Sergiy Belozorov <[email protected]>
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616675}Roll src/third_party/perfetto 6de52dccd73c..61804c04b375 (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/6de52dccd73c..61804c04b375
git log 6de52dccd73c..61804c04b375 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Remove charge counter assertions in tests
Created with:
gclient setdep -r src/third_party/perfetto@61804c04b375
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:121001631
[email protected]
Change-Id: I7b724ba4f844303d6cfa5eed93811952ce807990
Reviewed-on: https://chromium-review.googlesource.com/c/1377606
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616674}Mac: Don't explicitly set high contrast appearances when forcing appearance
Despite these being perfectly kosher appearance names, the system returns
nil when you set them, which inadvertently turns on dark mode for high
contrast users if their system is in Mojave dark mode.
Since most of our high contrast interventions are at the views level,
regular Aqua appearance will do temporarily.
Bug: 913503
Change-Id: I13238eac68d2dfa4a0d4c828bdd3e98d37d0505a
Reviewed-on: https://chromium-review.googlesource.com/c/1374437
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616673}[android] use copy in dexsplitter instead of move
Without this, following command always re-run dexsplitter.py.
$ ninja -C out/android-rel/ -dexplain -v chrome_public_bundle__unsplit_dex__dexspliter
Also fix a typo.
Bug: 914707
Change-Id: Ia827d1b0f87c4993e2837af720febefe22cef85f
Reviewed-on: https://chromium-review.googlesource.com/c/1378150
Commit-Queue: agrieve <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616672}[android] specify collect library path in depfile
This is to fix error in
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927198065475228928/+/steps/compile_confirm_no-op/0/stdout
Without this, following command always re-run.
$ ninja -C out/Android_CFI/ -dexplain -v gen/tools/android/md5sum/md5sum_prepare_dist_library_dependencies.list
This CL specifies '../../third_party/llvm-build/Release+Asserts/lib/clang/8.0.0/lib/linux/libclang_rt.ubsan_standalone-arm-android.so' in deps instead of non-existing file 'libclang_rt.ubsan_standalone-arm-android.so' in deps.
Bug: 914264
Change-Id: I34e30ebcd81ff8c4e7cccb59295aca710a1cda81
Reviewed-on: https://chromium-review.googlesource.com/c/1378151
Reviewed-by: agrieve <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616671}[Autofill Assistant] Update the preference strings.
Autofill Assistant is a code name and this patch updates the preferences
related strings accordingly.
Bug: 806868
Change-Id: Id64506ef36c8396b7b0b4da4f5cd6fe7c4e217d2
Reviewed-on: https://chromium-review.googlesource.com/c/1377434
Reviewed-by: Stephane Zermatten <[email protected]>
Commit-Queue: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616670}[ios] add suggest password support in password controller
Hidden behind flag.
Bug: 886583
[ios] Add flag for iOS password generation
Bug: 886583
Change-Id: I008609e2eb4da4c1ea547c5ae7114f30846c67b3
Reviewed-on: https://chromium-review.googlesource.com/c/1373816
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: David Jean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616669}Add ellyjones@ to native theme owners
It'd be helpful to have an east coast owner, and Elly has a lot of expertise working with these files.
Change-Id: I928d52e7454d21b9b7b8d78f2b36b30a87655710
Reviewed-on: https://chromium-review.googlesource.com/c/1375031
Commit-Queue: Leonard Grey <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616668}[Extensions + Apps] Move the arcAppsPrivate API to platform_apps
Move the arcAppsPrivate API out of extensions code and into apps
code. This includes:
- The API schema (arc_apps_private.idl)
- The API features (from _*_features.json files)
- The API permission (from c/b/e/permissions/chrome_api_permissions.cc)
- The API implementation and tests (from c/b/chromeos/extensions/)
Additionally, this updates the namespace for the API implementation to
be ::chrome_apps::api, for uniformity with the other apps API
namespaces.
Bug: 877240
Change-Id: Ie0ec379984eea3e02222d5877f34e916a225d4bd
Reviewed-on: https://chromium-review.googlesource.com/c/1298227
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616667}[Tango->FCM] Fix reflection blocking.
GetID is called before AddAppHandler. This results into generation of the
ID which has nothing to do with Token, which is generated.
This behavior breaks the reflection blocking.
Bug: 915152
Change-Id: I3b3c37d47773b69400c7e3234b1265b4b9cc35fc
Reviewed-on: https://chromium-review.googlesource.com/c/1377733
Commit-Queue: Tatiana Gornak <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616666}Remove DiagnosticObserver::NotifySigninValueChanged() and its usage
The semantics of this observer method are strange and unclear, and
rather than fixing it up, we can just eliminate it as it is used only
in legacy code.
By removing this we can cleanup the API surface of SigninManager and
IdentityManager.
Bug: 913850
Change-Id: I7e7ebc455eaab208d57b91f7398055f62a915af5
Reviewed-on: https://chromium-review.googlesource.com/c/1373453
Commit-Queue: Sergio Villar <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616665}[iOS] Create TableViewAccountItem
This CL creates the equivalent of CollectionViewAccountItem for
TableView.
Bug: 894791
Change-Id: I8ab17481bf1a8d37a33dfaedf9e5dbf6ff9b9359
Reviewed-on: https://chromium-review.googlesource.com/c/1373838
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616664}Update V8 to version 7.3.143.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/886f3c63..1962a66f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I90baa856ffbe9cff9d233f9d21a7d13f4e8dee44
Reviewed-on: https://chromium-review.googlesource.com/c/1377580
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616663}[Locked Fullscreen] Disable additional keyboard shortcuts in locked fullscreen
The find bar and zoom commands in locked fullscreen mode expose an escape hatch
that can be used to exit the mode so we're disabling them.
Bug: 904637
Change-Id: I367635fde3bbcc5aa74aecc9cc25d5d39ca041c7
Reviewed-on: https://chromium-review.googlesource.com/c/1375733
Commit-Queue: Ivan Šandrk <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616662}[Autofill Assistant] After disabling the AA switch in the settings, onboarding must be shown again.
The current intended way the onboarding is supposed to work:
1) The user must see and agree to the ToS before AA starts
2) Initially, the AA switch is off, which will trigger the onboarding screen
3) When the onboarding is shown:
4) if the user disagrees, onboarding will be shown again (switch stays off)
5) if the user agrees, the AA switch is turned on and onboarding will not be shown the next time
6) If the user disables the AA switch, onboarding will be shown the next time (goto 3)
7) If the user disables and then enables the AA switch, onboarding will be shown only if the ToS have not been agreed to previously
Bug: 806868
Change-Id: I3e5fee33aa83a3e2ce9c080c29a660319f69a1c5
Reviewed-on: https://chromium-review.googlesource.com/c/1377736
Commit-Queue: Clemens Arbesser <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616661}Use StyleColor for the stop-color property
This changes the ComputedStyle storage for the stop-color property to be
a StyleColor rather than a plain color. This fixes explicit inheritance
for the property ('currentcolor' computes to itself).
It also means we'll properly pick up changes to 'color'.
Bug: 914728
Change-Id: I3c78a3615220b9149d1ea5102a6e5863526a6d51
Reviewed-on: https://chromium-review.googlesource.com/c/1377437
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616660}[Cronet] Add a couple certificates needed by crrev.com/613686
Without these CronetUrlRequestTest.testSSLCertificateError fails when
run using files from the Cronet package directory.
In a future change perhaps we should run tests in Chromium using these
file to detect these failures earlier.
Bug: 910760
Change-Id: I8ffd80eebcdf900914db56dec8167fc5f01202a5
Reviewed-on: https://chromium-review.googlesource.com/c/1377326
Commit-Queue: Paul Jensen <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616659}Make ToTLinuxTSan test list more similar to main waterfall TSan bot.
Stop running:
- browser_tests and derivative network_service_browser_tests (doesn't pass under tsan)
- headless_browsertests
Give content_browsertest 5 shards, give interactive_ui_tests 6 shards, give
net_unittests 4 shards
Bug: 913704
Change-Id: Ibc146a48b6a177e835e0354802b182843541ae6a
Reviewed-on: https://chromium-review.googlesource.com/c/1377518
Commit-Queue: Nico Weber <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Reviewed-by: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616658}Add Active Directory cache lifetime policies
Adds policies to control the lifetime of cached Active Directory Group
Policy Objects (GPOs) and cached authentication data. Both policies will
be used in the authpolicy daemon in Chrome OS. The caches reduce server
load (prevent unnecessary GPO downloads) and improve sign-in speed.
The policies apply to Active Directory managed Chrome OS devices only.
BUG=chromium:908342, chromium:912312
TEST=Tryjobs, tested on device that policies show up in chrome://policy
Change-Id: I2f2d68fb78816aa14c950accdf31e8008f072ec8
Reviewed-on: https://chromium-review.googlesource.com/c/1374979
Reviewed-by: Thiemo Nagel <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Lutz Justen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616657}Revert CHECKs that verify bookmark USS invariants
We see crashers in the wild immediately after the initial merge, so it
seems like the invariant is too strict, or there is a legit bug that
requires some more investigation.
In doubt, let's remove the CHECKs, recently introduced in
https://chromium-review.googlesource.com/c/1375738
Bug: 915198
Change-Id: I6146bcf92e3e984fdd0d0bea2b48711025b3765b
Reviewed-on: https://chromium-review.googlesource.com/c/1378135
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616656}[iOS] Factor out BrowserInterface
This CL refactors how BrowserViewInformation exposes interfaces to the app layer.
The primary change is to collect the per-state information (BVC, tab model, browser state) into a distinct BrowserInterface protocol, and then to vend the current, main, and incognito interfaces. The object doing the vending is still the BrowserViewWrangler, and the vending protocol is BrowserInterfaceProvider (this replaces BrowserViewInformation). BrowserViewWrangler is the concrete implementation of this protocol; it internally creates and manages BrowserCoordinators, which are the primary backing object for BrowserInterfaces. Stub test doubles of these protocols are provided to make testing less noxious.
There's a bunch of related furniture-moving to get this to hang together; none of it is especially tricky.
The overall goal is to shrink the API surface exposed to the app layer; BrowserInterface becomes that API surface, which makes changing it decoupled from any actual ui-layer refactorings. The first step in that shrinkage shows up in this CL as removing dependencies on BrowserCoordinator from app/. Another important step will be to remove explicit dependency on BrowserViewWrangler from app/; instead MainController will call a factory function and get an id<BrowserInterfaceProvider>.
Other assorted notes:
- BrowserViewWrangler now has an explicit -createMainTabModel method, instead of doing lazy init.
- MainController had its browserViewInformation property redundantly defined both in the BrowserLauncher protocol and in its own interface. No more.
- Internally, MainController now only explicitly refers to its BrowserWrangler instance when it has to, and uses its BrowserInterfaceProvider wherever possible.
- MainController's tab model setters were, in fact, obsolete, and are now gone.
- Rather than pass the storage switcher as a parameter into a BrowserViewWrangler method to handle switching the active BVC/coordinator/interface, instead the storage switcher is passed to the BVW on init, and switching the active interface is just a direct assignment through BrowserInterfaceProvider.
- Generally I think having code that does arbitrary switching from (what used to be) BVC A to BVC B is confusing and bug-prone, so MainController now just explicitly says "switch to incognito" or "switch to normal".
- The app state unit tests now need to attach a fake authentication service to the browser state.
- Using the stubs for the interfaces gets rid of some of the mocking in the app/ tests, but there's still plenty more to do.
- It turns out that url_opener_unittest didn't need an instance of MainController at all, and using a trivial stub of StartupInformation allows for an egregious "test-only" method on MainController to be removed. A bunch of very old-style code in url_opener_unittest.mm was updated as well.
Change-Id: I14c23c080dfcd27cfce5d926a8d72e688a672998
Reviewed-on: https://chromium-review.googlesource.com/c/1366332
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616655}Roll src-internal cba765d7e610..af3970215f54 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cba765d7e610..af3970215f54
Created with:
gclient setdep -r src-internal@af3970215f54
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I38cd8c6f9de1e7ccf1d01a06b26464bbb6c3e5a2
Reviewed-on: https://chromium-review.googlesource.com/c/1378192
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616654}Move kSavingBrowserHistoryDisabled to components.
This is in preperation for another change to use it in the tab restore service.
Bug: 869580
Change-Id: I217277b012f03337c57328435319d56ff0fbba49
Reviewed-on: https://chromium-review.googlesource.com/c/1377505
Commit-Queue: Marc-André Decoste <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616653}Disable the two blink_heap_unittests that fail under tsan and run suite on tsan bot.
Disables HeapTest.CrossThreadWeakPersistent and HeapTest.ThreadedStrongification
under TSan.
Bug: 843511,915200,831674,913704
Change-Id: I6ab71b83fa937f739a57452a97bd43ef6375bf2c
Reviewed-on: https://chromium-review.googlesource.com/c/1377517
Reviewed-by: Hans Wennborg <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616652}Add some DLOG(ERROR) messages when dropping GCM Driver requests on the floor
Change-Id: I6cd9d224ea99e0375a66f802dd9532ff2cdf020f
Reviewed-on: https://chromium-review.googlesource.com/c/1375992
Reviewed-by: Tatiana Gornak <[email protected]>
Commit-Queue: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616651}Migrate credit card VC.
This CL migrates the AutofillCreditCardCollectionViewController from
SettingsRootCollectionViewController, which is based on
MDCCollectionViewController, to SettingsRootTableViewController, which
is based on UITableViewController.
Bug: 894791
Change-Id: I0fe0e31782b01bdc8b5ad5ccdad739b07781d638
Reviewed-on: https://chromium-review.googlesource.com/c/1377413
Commit-Queue: Yi Su <[email protected]>
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616650}Disable shutdown controls during supervision transition screen.
When supervision transition screen is being displayed, we ask users not
to power off their devices, so we're disabling the shutdown button and
system tray.
Bug: 903851
Change-Id: I719c6a2ea53062a8fc220b3dbd9cb114a380ddcb
Reviewed-on: https://chromium-review.googlesource.com/c/1375670
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Bruno Santos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616649}[iOS] Refactor omnibox defocusing.
Makes the LocationBarCoordinator take care of transitioning between
"focused" and "defocused" states of the omnibox, which now really
correspond to "steady" and "edit" modes for the omnibox.
The only case where the textfield events still cause the edit->steady
transition is on iPad, where the software keyboard has a dismiss button.
This is now handled explicitly in OmniboxViewIOS by calling the
OmniboxFocuser (implemented by LBCoordinator).
Bug: 911633
Change-Id: I84de10d2d0a3852fb7ad21dc57890554e1e4ba75
Reviewed-on: https://chromium-review.googlesource.com/c/1367727
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616648}Import wpt@68a96eb7d42673d3d763d7c9f90c74fd0fc3b82a
Using wpt-import in Chromium 50d70b3d66c96ecaa4738eb863cb57566985e80c.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
5a5cdf35a5 "Regression test for crbug.com/626744"
548e7b5e62 "Add quota usage details tests for all other storage backends."
a5fce755fd "Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-multicol
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: I549045b05ed811bdb70171a745ee28d46ca84c4e
Reviewed-on: https://chromium-review.googlesource.com/c/1378016
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616647}Roll src/third_party/perfetto 1e68a63e5242..6de52dccd73c (2 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/1e68a63e5242..6de52dccd73c
git log 1e68a63e5242..6de52dccd73c --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Merge "cleanup: CHECK(false) -> FATAL("blah")"
2018-12-14 [email protected] Merge "profiling: Add heapprofd end to end test."
Created with:
gclient setdep -r src/third_party/perfetto@6de52dccd73c
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I3802d934235983aa682ffbb5d0ec54db92fda554
Reviewed-on: https://chromium-review.googlesource.com/c/1377579
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616646}Separate CCT dynamic module related tests from CustomTabActivityTests.
Bug: 904826
Change-Id: Icce53f66b5d6afefdc639a396a42b52f1b15a599
Reviewed-on: https://chromium-review.googlesource.com/c/1371879
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Commit-Queue: Anna Malova <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616645}Update V8 to version 7.3.140.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b396c875..886f3c63
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I57dc823394d02e4cba261240c8ec795d91da8526
Reviewed-on: https://chromium-review.googlesource.com/c/1378015
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616644}Revert "[Autofill Assistant] Remove the preference entry."
This reverts commit 79079bf20a69ea6f54a74d646e86dcc59223491e.
Reason for revert: Product decision to keep the old behavior.
Original change's description:
> [Autofill Assistant] Remove the preference entry.
>
> Before this patch, we would show a preference entry to enable/disable
> Autofill Assistant. The way onboarding works, this is no longer desired.
>
> This patch always removes the preference from the xml so that the patch
> is smaller and less controversial to be merged into the release branch.
>
> After this patch, enableing/disabling the feature will entirely be done
> during the onboarding flow.
>
> Bug: 806868
> Change-Id: I1b10f9cfb55e2d4cf320259f12ed7c3c9fb395c6
> Reviewed-on: https://chromium-review.googlesource.com/c/1368649
> Commit-Queue: Mathias Carlen <[email protected]>
> Reviewed-by: Theresa <[email protected]>
> Reviewed-by: Ganggui Tang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616266}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 806868
Change-Id: I15424cf58e431ae199321e6dff85cedcb3bb0d8e
Reviewed-on: https://chromium-review.googlesource.com/c/1377415
Reviewed-by: Mathias Carlen <[email protected]>
Commit-Queue: Mathias Carlen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616643}Roll src-internal 8302457ac6af..cba765d7e610 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8302457ac6af..cba765d7e610
Created with:
gclient setdep -r src-internal@cba765d7e610
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I374abc7e6b521697058fd5d052d4d4323d28994b
Reviewed-on: https://chromium-review.googlesource.com/c/1378190
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616642}Add early return to StringView match.
If the starting points, lengths and types are matching then
there is no reason to walk through and match the strings.
Change-Id: I7597bbb60dd5c26c15da601551a26eff16da9ac4
Reviewed-on: https://chromium-review.googlesource.com/c/1340313
Commit-Queue: Yuta Kitamura <[email protected]>
Reviewed-by: Yuta Kitamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616641}Fix presubmit to validate 'sensitiveValue'
This CL is a follow-up to CL:1343077 and updates the python schema
validator used during presubmit to allow 'sensitiveValue'. The c++
schema validator (schema.cc) already supports 'sensitiveValue'.
Bug: 905357
Change-Id: I7cbc4b60c248d28cc37d49893c33aa9c83034ec2
Reviewed-on: https://chromium-review.googlesource.com/c/1378129
Reviewed-by: Lutz Justen <[email protected]>
Commit-Queue: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616640}Serialize animation in the right order
Per spec:
https://drafts.csswg.org/css-animations/#animation
The name of the animation should be the end of the value list, to
avoid ambiguity when serializing/deserializing the animation.
This CL fixes the problem for both element.style and the
window.getComputedStyle. A wpt test is added.
Since this CL changes the output of an existing web API, an Intent to
Ship has been sent to blink-dev and 3 LGTMs has been granted.
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/KUelGRZP73Y/F4YxTGBOBwAJ
Bug: 772852
Change-Id: I88b06b57c68013d99c8c4fd4bd39bdfcf9b807fc
Reviewed-on: https://chromium-review.googlesource.com/c/1367935
Reviewed-by: Stephen McGruer <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616639}Revert "Add quota usage details tests for all other storage backends."
This reverts commit 548e7b5e622ad79155ff95ef26738d7a40fe9397.
Reason for revert: external/wpt/storage/estimate-usage-details-service-workers.https.tentative.window.html fails on Mac 10.13: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20(dbg)/7315
Original change's description:
> Add quota usage details tests for all other storage backends.
>
> IndexedDB test was included in parent CL.
>
> Bug: 904000
> Test:
> Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292
> Reviewed-on: https://chromium-review.googlesource.com/c/1334659
> Reviewed-by: Victor Costan <[email protected]>
> Reviewed-by: Joshua Bell <[email protected]>
> Commit-Queue: Jarryd Goodman <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616398}
[email protected],[email protected],[email protected]
Change-Id: Ibd83c1931cea3df81950eedcd4169585a68259ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 904000
Reviewed-on: https://chromium-review.googlesource.com/c/1377417
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616638}Roll src/third_party/perfetto 745aaf284105..1e68a63e5242 (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/745aaf284105..1e68a63e5242
git log 745aaf284105..1e68a63e5242 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] profiling: Actually flush TraceWriter.
Created with:
gclient setdep -r src/third_party/perfetto@1e68a63e5242
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:120963437
[email protected]
Change-Id: Id705b5b380c0b4f8df09bce1f687cd65b27bf87d
Reviewed-on: https://chromium-review.googlesource.com/c/1377308
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616637}fix: align rtl title in new style notification
New style notifications do not use a BoundedLabel for their title, which
renders RTL content right-aligned. Changed the aligment of the title
Label to gfx::ALIGN_TO_HEAD so that the behaviour is the same for title
and message.
Bug: 914437
Change-Id: I99a316c6166385aa4f58b52da7cf7a15a6d5d2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1375734
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Richard Knoll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616636}Revert "base: Disable some perf tests that are failing on Android"
This reverts commit 15a28138fef95c32556efa516aae023dfc6a47ed.
Reason for revert: The test timeout has been increased with https://chromium-review.googlesource.com/c/1353922, so let's see if these pass reliably now.
Original change's description:
> base: Disable some perf tests that are failing on Android
>
> The following perf tests are often timing out on Android:
>
> - JSONPerfTest.StressTest
> - ObserverListPerfTest/1.NotifyPerformance
> - ScheduleWorkTest.*
>
> This patch disables them on Android until they are be investigated.
>
> [email protected]
>
> Bug: 906686
> Change-Id: Iad78d71e1b3293a75834b06a2b7b4b13b7ac5e75
> Reviewed-on: https://chromium-review.googlesource.com/c/1349711
> Reviewed-by: Eric Seckler <[email protected]>
> Commit-Queue: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#610618}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 906686
Change-Id: I23a585253860366456fe7d8b7a27d5cd949840d9
Reviewed-on: https://chromium-review.googlesource.com/c/1377851
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616635}Roll src-internal 6e46779c9063..8302457ac6af (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e46779c9063..8302457ac6af
Created with:
gclient setdep -r src-internal@8302457ac6af
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I9c20af340533606264c620f148692d7e598db62e
Reviewed-on: https://chromium-review.googlesource.com/c/1378189
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616634}media/gpu/veaunittest: Initialize Ozone in global environment
The Ozone initialization and creation of the rendering thread was
performed before running each individual tests. This triggers a
CalledOnValidSequence() DCHECK in Debug builds when
AfterSandboxEntry() tries to start the DRM thread for the second time,
and Thread::Start() is called from a different thread that with the
first test.
Fix this by moving all Ozone initialization and the rendering thread to
the global test environment.
BUG=907767
TEST=Checked that VEA was passing on Cheza with --single-process-tests.
Change-Id: Ic9b52a31310b40c99368620ea78cf861d084032d
Reviewed-on: https://chromium-review.googlesource.com/c/1369755
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616633}Revert "Reland "Add console message in MixedContentChecker::HandleCertificateError""
This reverts commit 7b019e69abc493d78f885ead55889feac68d0f53.
Reason for revert: Causes flaky test (crbug.com/915134)
Original change's description:
> Reland "Add console message in MixedContentChecker::HandleCertificateError"
>
> This is a reland of dcfa99386d0b0f91107fdb8c248be833ba18fd25. The only diff is that the
> -expected.txt files for serviceworker/thorough/scheme-blob-* have been removed (context
> in crbug.com/914679)
>
> Original change's description:
> > Add console message in MixedContentChecker::HandleCertificateError
> >
> > Print console message when subresources are loaded over broken HTTPS.
> > Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing
> >
> > Bug: 587168
> > Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1306779
> > Commit-Queue: Livvie Lin <[email protected]>
> > Reviewed-by: Mustafa Emre Acer <[email protected]>
> > Reviewed-by: Yutaka Hirano <[email protected]>
> > Reviewed-by: Mike West <[email protected]>
> > Reviewed-by: Scott Violet <[email protected]>
> > Reviewed-by: Nate Chapin <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#614212}
>
> [email protected], [email protected], [email protected], [email protected], [email protected]
>
> Bug: 587168
> Change-Id: I9ecb83b0e6a5d48cdc9b769b971f5da81c82bb62
> Reviewed-on: https://chromium-review.googlesource.com/c/1366175
> Commit-Queue: Carlos IL <[email protected]>
> Reviewed-by: Carlos IL <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616470}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ifab143df9fdcc2c21b585990885c32e9daca4040
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 587168
Reviewed-on: https://chromium-review.googlesource.com/c/1377604
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616632}Fix uncleared highlight in search engine settings.
Search Engine settings has some early returns in its overriden method
"tableView:didSelectRowAtIndexPath:" that may cause uncleared highlight.
Bug: 914303
Change-Id: I86aa12169266ddada77668e5aa2739afcb775462
Reviewed-on: https://chromium-review.googlesource.com/c/1377432
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Yi Su <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616631}Roll src/third_party/dawn ff9562f7927b..fd3717fa7cbc (1 commits)
https://dawn.googlesource.com/dawn.git/+log/ff9562f7927b..fd3717fa7cbc
git log ff9562f7927b..fd3717fa7cbc --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Fix the build with only the OpenGL and Null backends enabled
Created with:
gclient setdep -r src/third_party/dawn@fd3717fa7cbc
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:914375
[email protected]
Change-Id: I399894c9c5044ab883e6da85e2323d464802433a
Reviewed-on: https://chromium-review.googlesource.com/c/1377994
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616630}PaymentRequest: Remove shipping_address_errors_ field
After 1280563 CL, our implementation doesn't overwrite the details
information each time. So, we can use details.shippingAddressErrors
directly instead of having a seperated field.
Bug: none
Change-Id: Ic1123fbb67a2f203b8c69c28de18ad172aed843d
Reviewed-on: https://chromium-review.googlesource.com/c/1374192
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616629}css-layout-api/auto-block-size-absolute.https.html flaky on Mac10.11
[email protected]
Bug: 913931
Change-Id: I7396cce1ede32708f7a3d328da9ff2e58c017733
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1378133
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616628}Create constants for TableViewSeparatorInset.
This CL creates 2 constants for TableViewSeparatorInset and remove
those in classes which extend ChromeTableViewController.
Bug: 894791
Change-Id: If336b07bb399e124c1716b7ebf8480d5ddc8e5ce
Reviewed-on: https://chromium-review.googlesource.com/c/1375740
Commit-Queue: Yi Su <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616627}Roll src/third_party/chromite 86cdce6fb00d..f15e4e6c0c9d (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/86cdce6fb00d..f15e4e6c0c9d
git log 86cdce6fb00d..f15e4e6c0c9d --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Update config settings by config-updater.
Created with:
gclient setdep -r src/third_party/chromite@f15e4e6c0c9d
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I01feb1006a0c92049e6c2aecc02be4107efa5e12
Reviewed-on: https://chromium-review.googlesource.com/c/1377307
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616626}Skip virtual/user-activation-v2/fast/events/middleClickAutoscroll-event-fired.html
Just as flaky as when run inside virtual/mouseevent_fractional/ , which
is already skipped? Disable this virtual version of the test as well.
[email protected]
Bug: 891155
Change-Id: Iba4400551dadb781e1650c4a948b977c823208b4
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1377433
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616625}Refactor "needs layout" check in LayoutImage
Move the conditions used to check if layout is needed when the intrinsic
size changes out into a new function, and call that from
LayoutImage::InvalidatePaintAndMarkForLayoutIfNeeded.
Replace open-coded HasRelativeLogicalWidth() with a call to that method.
Bug: 870599
Change-Id: Iae480326083eb493d58233378d95af8c1dd62f0a
Reviewed-on: https://chromium-review.googlesource.com/c/1373839
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616624}Virtual fast/scrolling/no-hover-during-scroll.html tests are flaky, too.
[email protected]
Bug: 914782
Change-Id: I8e15fa05ed7eea4c5e53c080928596555a4c890f
Reviewed-on: https://chromium-review.googlesource.com/c/1377850
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616623}TestBrowserThreadBundle to inherit from ScopedTaskEnvironment
This clarifies ownership of the ScopedTaskEnvironment (there is only one)
which makes it easier for the upcoming BrowserThreadScheduler work with
TestBrowserThreadBundle. Because we need BrowserUIThreadScheduler and
ScopedTaskEnvironment to share a SequenceManager.
Most of this change is mechanical, the interesting changes are in
test_browser_thread_bundle.h, test_browser_thread_bundle.cc and
views_test_base.cc.
[email protected]
Bug: 863341, 891670
Change-Id: I324665b19c6e89da42c05e7646ae41d9f1cd5e7b
Reviewed-on: https://chromium-review.googlesource.com/c/1352260
Reviewed-by: Alex Clarke <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: François Doray <[email protected]>
Commit-Queue: Alex Clarke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616622}Ignore adopted stylesheets from different document tree
If we adopt a subtree containing a shadowRoot that has
adoptedStyleSheets from one document to a different document, the
adoptedStyleSheets will be moved along with it. We want to ignore
the stylesheets that are constructed in a different document tree
when we're doing style calculation.
Draft spec: https://wicg.github.io/construct-stylesheets/
Bug: 807560
Change-Id: If36676e642b5d1b5c1c403c14cc24be8e670f153
Reviewed-on: https://chromium-review.googlesource.com/c/1377486
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616621}Delete remnants of ContentHint handling in WebRtcVideoCapturerAdapter
The |content_hint_| member is unused since
https://chromium-review.googlesource.com/c/chromium/src/+/1146564/.
Deletes wiring in MediaStreamVideoWebRtcSink, as a preparation for
replacing WebRtcVideoCapturerAdapter (a subclass of
cricket::VideoCapturer) with an implementation of
webrtc::VideoTrackSourceInterface.
Bug: 864529, webrtc:6353
Change-Id: I48972c63a6c69ceb859fb11fcad98d6faefac524
Reviewed-on: https://chromium-review.googlesource.com/c/1375720
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Niels Möller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616620}Use custom computed style instead of LayoutObjectIsNeeded.
Using display:none in the computed style in the UA shadow for native
appearance makes layout tree changes easier to detect than having to
know the LayoutObjectIsNeeded is going to return a different result.
This caused an issue in the WIP CL for unified computed style storage.
Bug: 914784
Change-Id: Icad9726c91972e9aca7566403cbe5650ea821c93
Reviewed-on: https://chromium-review.googlesource.com/c/1375736
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616619}Roll src/third_party/skia 1f9c73766d63..59c9f1595ecd (2 commits)
https://skia.googlesource.com/skia.git/+log/1f9c73766d63..59c9f1595ecd
git log 1f9c73766d63..59c9f1595ecd --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Update markdown files
2018-12-14 [email protected] Update go_deps asset
Created with:
gclient setdep -r src/third_party/skia@59c9f1595ecd
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ibd11ffaef725f012e61056159661d441fb7195d8
Reviewed-on: https://chromium-review.googlesource.com/c/1377991
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616618}[LayoutNG] Fix 'text-align' applied to 'white-space: pre-wrap'
This patch matches the behavior of 'text-align' applied to
'white-space: pre-wrap' and when the line wraps to the
current engine; do not include for 'justify' but do include
for other values.
Spec is not clear on this regard. An issue filed at:
https://github.com/w3c/csswg-drafts/issues/3440
It turned out that our tests cover the combination of the
properties only when lines do not wrap.
Because NGLineBreaker computes |has_only_trailing_spaces| as
part of the line breaking, the last lines and single lines
don't have such item. The difference caused the bug, but the
lack of tests prevented finding the problem. This patch adds
tests for this case.
Also, computing trailing space is moved to NGLineInfo as we
discovered it is needed in other cases too, with more cases
covered and with unit tests.
Bug: 913995
Change-Id: I49428f2dcf193e2b7a745431f82724308a17d90f
Reviewed-on: https://chromium-review.googlesource.com/c/1374331
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616617}Remove navigatorcontentutils tests in web_tests
Tests under third_party/blink/web_tests/http/tests/navigatorcontentutils
have been covered in /third_party/blink/web_tests/external/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.https.html,
I think we can just remove them.
Change-Id: I85e339ce5db478ef50dd6c4cf327a3fe8e3b9651
Reviewed-on: https://chromium-review.googlesource.com/c/1378011
Commit-Queue: Philip Jägenstedt <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616616}Introduce SyncUserSettingsMock
It's used in ProfileSyncServiceMock. This lets tests specify
expectations or default return values for user settings, which will
eventually let us get rid of the corresponding methods on
ProfileSyncService itself.
Bug: 884159
Change-Id: I58133291208a288d3766b5142da37e12e84c9baa
Reviewed-on: https://chromium-review.googlesource.com/c/1373690
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616615}[ios] add a password generation manager to ios
Just set the pipeline, hidden behind a flag for now.
Bug: 886583
Change-Id: I3b1b5f30400bef03e7070241c9f487b2b5ea1399
Reviewed-on: https://chromium-review.googlesource.com/c/1369771
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: David Jean <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616614}[iOS] Stop injecting __gCrWeb['windowId'].
Every frame creates a frameId in JavaScript which can be used to
uniquely identify the main frame. Thus the generation and injection of a
windowID is no longer necessary.
Bug: 905939
Change-Id: Icef30a79a1d87bb455e4fb9b2403df74ec5b47b9
Reviewed-on: https://chromium-review.googlesource.com/c/1365410
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616613}Roll src-internal 6c53b0a8c537..6e46779c9063 (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c53b0a8c537..6e46779c9063
Created with:
gclient setdep -r src-internal@6e46779c9063
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ife9596005ad361e5ad5046c5b8df40a148d4bece
Reviewed-on: https://chromium-review.googlesource.com/c/1377305
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616612}Remove always-true boolean from SyncLoadContext
Bug: n/a
Change-Id: Ifa81390181f4c1028910b1ad5051a4660ebe1964
Reviewed-on: https://chromium-review.googlesource.com/c/1377483
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616611}Add cpi to download_file_types.asciipb
Cpi files are executed by just a double-click on Windows. This CL causes
us to send pings for these files.
Bug: 914400
Change-Id: I15f6bfbd2deaa79459fc8f2b22ee6b8615d7454f
Reviewed-on: https://chromium-review.googlesource.com/c/1374669
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616610}Roll AFDO from 73.0.3637.0_rc-r1 to 73.0.3640.0_rc-r1
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Idab376584799d802d0aaead35912a6c9d6307b65
Reviewed-on: https://chromium-review.googlesource.com/c/1377993
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616609}Import wpt@e1d7b9d072492115b93c50288b5c6b8459efde2b
Using wpt-import in Chromium 14136a7a215e0ff2edcc807a7b99f1edd966587b.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
5a5cdf35a5 "Regression test for crbug.com/626744"
548e7b5e62 "Add quota usage details tests for all other storage backends."
a5fce755fd "Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-scoping
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: I7e2e4755b2aeb2de22197c9d83a52d05d45e3b3f
Reviewed-on: https://chromium-review.googlesource.com/c/1378012
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616608}Roll src-internal d484f4385ce6..6c53b0a8c537 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d484f4385ce6..6c53b0a8c537
Created with:
gclient setdep -r src-internal@6c53b0a8c537
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I14d89bed382081f4e64e4a8e08cd56f3caf2888e
Reviewed-on: https://chromium-review.googlesource.com/c/1377304
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616607}[AF] User server_id as key in AutofillDataModelChange for server data
This CL changes what is used as the key when notifying
AutofillDataModelChange for server credit cards / server profiles.
Instead of the GUID we need to notify server_id so that the
wallet_metadata sync bridge can properly react to notification of type
DELETE (the bridge needs the server_id of the data to generate the
storage key of the metadata that should get deleted).
Bug: 853688
Change-Id: Ie30a82fc8601fdf6e5428a40a00ce8f75263907e
Reviewed-on: https://chromium-review.googlesource.com/c/1375991
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616606}Rename {Get,Set}SelectionRange to {Get,Set}EditableSelectionRange.
Some implementation of TextInputClient interface, for example RWHVA, can
have text outside of an editable text field.
For those views, {Get, Set}SelectionRange is confusing names because
it's not clear whether they return selections outside of the editable
text field or not.
This CL renames them to {Get, Set}EditableSelectionRange to make it
clear that they returns only selections in an editable text field.
Bug: 901439, 908762
Test: Build.
Change-Id: I99e6140a635a61b755ebfa35efff2d306cec8d32
Reviewed-on: https://chromium-review.googlesource.com/c/1373932
Commit-Queue: Yuichiro Hanada <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616605}Update V8 to version 7.3.139.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/16d19c18..b396c875
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Iae303b065dffef83bebf1931df124c2260a4fca3
Reviewed-on: https://chromium-review.googlesource.com/c/1378010
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616604}RemoteMacViews: Fix crash when fullscreening PWA windows
This CL adds a simple null check before accessing the bridge_impl()
to check whether a fullscreen transition is in progress. This fixes
PWA windows crashing the browser process when the user fullscreens
the window.
bridge_impl() will be null for cross process PWA windows. Plumbing
the call through via bridge() doesn't fix the fullscreen behaviour.
Opened bug to track behavioural issue: https://crbug.com/915110
Bug: 913337
Change-Id: I060bcae3dfced784353a0210b2464d3749969dff
Reviewed-on: https://chromium-review.googlesource.com/c/1375299
Reviewed-by: ccameron <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616603}Changed the filename logo_tracker.h to logo_observer.h
LogoTracker has been merged into LogoService.
So only LogoObserver was left in the logo_tracker.h
Bug: 761829
Change-Id: I95aa1f4391ecfd66dcb436d5df76ab4e211a4a98
Reviewed-on: https://chromium-review.googlesource.com/c/1371305
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Kyle Milka <[email protected]>
Commit-Queue: Yeol Park <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616602}Roll src/third_party/libvpx/source/libvpx/ c62d9d568..18d260d13 (3 commits)
https://chromium.googlesource.com/webm/libvpx.git/+log/c62d9d568fc6..18d260d13f2b
$ git log c62d9d568..18d260d13 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 marpan vp8-mfqe: Increase initial frame# threshold
2018-12-13 marpan vp9-svc: On scene change: only reset TL in flexible mode.
2018-12-13 jingning Make the use of tpl model controlled by the encoder params
Created with:
roll-dep src/third_party/libvpx/source/libvpx
[email protected]
Change-Id: I2a449f99dfe6464e945a20b45354cf21e6db389a
Reviewed-on: https://chromium-review.googlesource.com/c/1377728
Reviewed-by: Tom Finegan <[email protected]>
Commit-Queue: Marco Paniconi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616601}Roll src/third_party/skia 42e7a7ed6511..1f9c73766d63 (1 commits)
https://skia.googlesource.com/skia.git/+log/42e7a7ed6511..1f9c73766d63
git log 42e7a7ed6511..1f9c73766d63 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Roll third_party/externals/angle2 91002266bd1e..828c59462fc1 (3 commits)
Created with:
gclient setdep -r src/third_party/skia@1f9c73766d63
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I4e149e3af51e37bb4a85f19f0f6b96690efdbbee
Reviewed-on: https://chromium-review.googlesource.com/c/1378070
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616600}websql: Add core WebSQL UseCounter to UKM.
Change-Id: I4d4e2a36aa6ed9f988aaa6602eabacb87ba5f741
Reviewed-on: https://chromium-review.googlesource.com/c/1365172
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616599}Support decoding special characters in Assistant deep links.
Previously, deep link utils failed to decode URL encoded characters
when parsing parameters. Now, it does.
Bug: b:121003131
Change-Id: I4263e9d50d20ddebcb9cb8e8ca14d009360c52ef
Reviewed-on: https://chromium-review.googlesource.com/c/1376801
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616598}Import wpt@1db8f79ee94cf257617cbf470c6dcf7e0bbdcab5
Using wpt-import in Chromium 06c0f4533cd4607334fe101cc74d04752cde1516.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
5a5cdf35a5 "Regression test for crbug.com/626744"
548e7b5e62 "Add quota usage details tests for all other storage backends."
a5fce755fd "Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected]:
external/wpt/webrtc
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: I258a1465ffd138a32efdb715a0cdad7d7288d882
Reviewed-on: https://chromium-review.googlesource.com/c/1377724
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616597}service worker: Remove a DCHECK from ServiceWorkerSubresourceLoader
Before this CL we had a DCHECK in OnFallback() to make sure
that the loader isn't the only one who has a reference to
|fallback_factory_|. The intent was to make sure that the
fallback factory lives long enough to handle the response,
but it turned out we wouldn't need to ensure that because
we don't need the request in that case.
Background context:
I hit this DCHECK while implementing PoC CL of generating
code cache in idle tasks.
Bug: 915081
Change-Id: Ia636edf31c6c1cf9b95ae0a3db9f913d578bd733
Reviewed-on: https://chromium-review.googlesource.com/c/1377487
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616596}Roll src/third_party/catapult 203676d4b186..afefc1c51fc4 (2 commits)
https://chromium.googlesource.com/catapult.git/+log/203676d4b186..afefc1c51fc4
git log 203676d4b186..afefc1c51fc4 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] fixing exceptions raised in benchmark_runner.py
2018-12-13 [email protected] Modifying telemetry so that test expectations files can be passed to Typ
Created with:
gclient setdep -r src/third_party/catapult@afefc1c51fc4
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:835690,chromium:835690
[email protected]
Change-Id: If55409ab5070ba6cb02281e698a3f30f54ea9a89
Reviewed-on: https://chromium-review.googlesource.com/c/1377301
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616595}[SuperSize] Refactor MapFileParserLld.Parse() using a filtering generator.
We wish to extract more symbols from Level 3 lines from .map files.
Some lines have |size == 0| (this can happen for symbols from assembly
sources), but we can approximate actual size from |address| difference
between successive lines. We call this approximation "span".
This CL refactors MapFileParserLld.Parse() by extracting some parsing
logic into a new generator MapFileParserLld.Tokenize(). Details:
* Tokenize() is a generator that:
* Consumes .map file lines and yields parsed fields.
* Applies a one-step lookhead, and maintains "next" and "current"
tokens from successive lines to compute "span" (some complication
exist).
* Skips Level 3 annotations ('$a', '$t.123', etc.), which also has
|size == 0| but produces no symbols, and so should be ignored for
"span" computation.
* Detects Thumb2 annotations '$t' and adjusts |address| accordingly.
* Add 2 new tests to LinkerMapParserTest:
* test_ParseArmAnnotation() for annotation parsing.
* test_Tokenize() to dump Tokenize() output, and compare against new
Tokenize.golden file.
As a refactoring CL, MapFileParserLld output remains unchanged. Actual
usage of "span" will be implemented in follow-ups.
Bug: 892648
Change-Id: Ia630027b85e45a234101396917ea4626b9dba1bc
Reviewed-on: https://chromium-review.googlesource.com/c/1377189
Reviewed-by: Samuel Huang <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616594}[pip] Pass root-window coordinate to WM_EVENT_SET_BOUNDS
This CL recalculates the bounds of pip window from screen
coordinate to root window coordinate before passing it to
WM_EVENT_SET_BOUNDS. Because it accepts root window coordinate.
Bug: b/120765496
Test: covered by unit tests. also tested manually. See bug for repro steps.
Change-Id: I1994e5591e0a907d5647cbb0f1ddd9e7d97a8c21
Reviewed-on: https://chromium-review.googlesource.com/c/1369761
Reviewed-by: Eliot Courtney <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616593}WebUI cleanup: Remove subset of neon-animation/ deps that are not used.
Bug: 902959
Change-Id: Ie32d26c532adef89fe33d082815003f6b6e61dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1377871
Reviewed-by: calamity <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616592}Roll src-internal 28124a4dfaf6..d484f4385ce6 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28124a4dfaf6..d484f4385ce6
Created with:
gclient setdep -r src-internal@d484f4385ce6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I57995648deed8f1003fbf0ec02f846a0ced69ca4
Reviewed-on: https://chromium-review.googlesource.com/c/1377303
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616591}Preload the zip archiver NaCl module on first login or after update.
Loading the module the first time causes a PNaCl translation, which is
cached for subsequent loads. Loading lazily causes a performance
regression the first time the user uses zip functionaility.
BUG=907032
Change-Id: Iba4ee63ec0f940a1bfaa4bbbf52801a5a5dbea5a
Reviewed-on: https://chromium-review.googlesource.com/c/1377953
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Anand Mistry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616590}Implement 'responseStart' performance timing as time-to-first-byte for HTTP/1.1 and HTTP/2
For HTTP/1.1, use the time immediately after the first packet from the
header was read by the parser. This behaviour is verified by the test
wpt/resource-timing/resource-timing.html.
For HTTP/2, use `recv_first_byte_time` reported by the SpdyStream.
For cached responses, use the time after load, but before parsing the
headers of the cached entry.
Bug: 568024
Change-Id: I4a6215596be38b1deb84a56924522ef7925a94d4
Reviewed-on: https://chromium-review.googlesource.com/c/1356234
Commit-Queue: Andrew Comminos <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616589}viz: Remove dead code after turning on presentation feedback.
After presentation-feedback is turned on by default for every frame in
crrev.com/591777, the following fields are no longer needed:
. SwapBuffersFlag for presentation-feedback.
. OutputSurfaceFrame::need_presentation_feedback.
The change to turn on the presentation-feedback every frame has been
in stable without issues. So remove the dead code no longer needed.
TBR=danakj@: mechanical changes in cc/ and content/browser/compositor
BUG=883592
Change-Id: Id4bbb3bae17c5e808095f6d2aecca0e66b295e3c
Reviewed-on: https://chromium-review.googlesource.com/c/1232513
Commit-Queue: Sadrul Chowdhury <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616588}sqlite: Build sqlite_shell on Windows.
The SQLite shell can be used to quickly run queries against our SQLite
build, making it handy for reproducing and debugging issues.
Bug: 910906
Change-Id: Ibb104c508aa7218b109cf63596b4c8987856d3b6
Reviewed-on: https://chromium-review.googlesource.com/c/1375614
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616587}CSS: Cleanup unused code and redundant test.
* Remove allow_rule_access_from_origin_ which is no longer used after
https://chromium-review.googlesource.com/c/chromium/src/+/1367331.
* Remove http/tests/security/cannot-read-cssrules-redirect.html which is
redundant with the WPT test
css/cssom/stylesheet-same-origin.sub.html, which is passing after
https://chromium-review.googlesource.com/c/chromium/src/+/1367331.
Bug: 911974
Change-Id: I5047589f84ab371680390433f2c3d1c430d6cf6b
Reviewed-on: https://chromium-review.googlesource.com/c/1372989
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616586}Roll src-internal c03cce959ec6..28124a4dfaf6 (5 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c03cce959ec6..28124a4dfaf6
Created with:
gclient setdep -r src-internal@28124a4dfaf6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ia9faee99c4a21bb692cd3321d1c16e69ef5f5abd
Reviewed-on: https://chromium-review.googlesource.com/c/1377362
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616585}Roll src/third_party/chromite 5f4970fb9456..86cdce6fb00d (7 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f4970fb9456..86cdce6fb00d
git log 5f4970fb9456..86cdce6fb00d --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] cbuildbot: SDKUprevStage: log the new SDK version as a step
2018-12-14 [email protected] dlc_setup: Script to copy DLC to output directory
2018-12-14 [email protected] Removed the unused drop_file from chromite/cbuildbot
2018-12-14 [email protected] chromiumos-sdk: Add BuildSDKBoardStage.
2018-12-14 [email protected] Add debugger configuration for VS Code
2018-12-14 [email protected] Import LUCI pRPC client
2018-12-14 [email protected] Add .style.yapf for status quo
Created with:
gclient setdep -r src/third_party/chromite@86cdce6fb00d
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I2820c7a9b3adc6cd3fbb1edc6b25974cb7ac27b4
Reviewed-on: https://chromium-review.googlesource.com/c/1377361
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616584}Roll src/third_party/angle bec398774ec6..4a9f9b08b691 (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/bec398774ec6..4a9f9b08b691
git log bec398774ec6..4a9f9b08b691 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] ES31: support ssbo as the operand of unary operator
Created with:
gclient setdep -r src/third_party/angle@4a9f9b08b691
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Iac05f76cfd2b4cca4fb6cdd02486c35f287170e3
Reviewed-on: https://chromium-review.googlesource.com/c/1377360
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616583}Updating trunk VERSION from 3640.0 to 3641.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: Ie707609000cf7a91fc2f8c3e68b70a161e704196
Reviewed-on: https://chromium-review.googlesource.com/c/1377323
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616582}Roll src/third_party/skia 21a7be0741ac..42e7a7ed6511 (1 commits)
https://skia.googlesource.com/skia.git/+log/21a7be0741ac..42e7a7ed6511
git log 21a7be0741ac..42e7a7ed6511 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] use SkFont for text
Created with:
gclient setdep -r src/third_party/skia@42e7a7ed6511
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ia4a7bb37687e1fa1b112264b69789db3abe4d352
Reviewed-on: https://chromium-review.googlesource.com/c/1377300
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616581}CSS: Use the response URL for base URL and type for security decisions.
Use ResourceResponse::ResponseUrl() to set the base URL, and use
ResponseResponse::GetType() to determine whether the resonse is
CORS-same-origin.
This CL has three web-exposed changes.
1. Use the response URL rather than the last request URL as the base URL
of the stylesheet. This aligns with the standard. See
https://github.com/whatwg/fetch/pull/146 and WPT results indicate
Firefox, Edge, and Safari use the response URL. This only matters if
the response came from a service worker, as the URLs only differ
when the service worker intercepts the request and responds with a
different URL via respondWith(fetch(other_url)).
This is covered by the WPT:
service-workers/service-worker/fetch-request-css-base-url.https.html
The test doesn't completely pass yet because the search query part of
the URL gets chopped off for FetchEvent.request.referrer, but the base
URL is correct.
Chrome Status: https://www.chromestatus.com/feature/5642183499579392
2. Consider A->B->A redirects to be cross-origin rather than
same-origin. Previously, this was considered same-origin. See the
discussion in https://github.com/whatwg/fetch/issues/737 and change
https://github.com/whatwg/fetch/pull/834.
This change makes the following WPT test pass:
css/cssom/stylesheet-same-origin.sub.html
It also affects the web test:
http/tests/security/cannot-read-cssrules-redirect.html
This test is updated to match the behavior change. It can be removed
later since it is redundant with the WPT test.
3. Consider load failures to be cross-origin rather than same-origin.
That is, accessing |styleSheet.rules| throws a SecurityError if the
load failed. This aligns with the specification:
- cssRules checks the `origin-clean` flag:
https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules
- This is set to true iff CORS-same-origin:
https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet
- CORS-same-origin is false on kError:
https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin
This change makes the following WPT test pass:
css/cssom/stylesheet-same-origin.sub.html
It also affects the web tests:
register-bypassing-scheme-partial.html
require-sri-for-style-blocked.php
These tests are updated to match the behavior change.
Chrome Status: https://www.chromestatus.com/feature/5642183499579392
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/7OSy00oxVpk/siufiQVBBwAJ
Bug: 911974
Change-Id: I9add3162596963eee66f60f339cfd9911bc151cd
Reviewed-on: https://chromium-review.googlesource.com/c/1367331
Commit-Queue: Joel Hockey <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616580}[WebUI] Promote settings-subpage-search to cr-search-field.
This CL migrates the search component that implements
CrSearchFieldBehavior into a shared component directory. This is
required for the activity log page under
chrome://extensions/?activity=<extension_id> to reuse the component for
searching through logs without having to create a duplicate component.
https://chromium-review.googlesource.com/c/chromium/src/+/1365031 will
be updated once this CL is submitted.
Bug: 915031
Change-Id: I0da16636757313a5687068630ad2b60310fb7ec5
Reviewed-on: https://chromium-review.googlesource.com/c/1375455
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Kelvin Jiang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616579}Roll src-internal b435194fb1a6..c03cce959ec6 (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b435194fb1a6..c03cce959ec6
Created with:
gclient setdep -r src-internal@c03cce959ec6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:856278
[email protected]
Change-Id: I06b58b33ea9c07ce2640e286112bc97d293264ee
Reviewed-on: https://chromium-review.googlesource.com/c/1377715
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616578}Update V8 to version 7.3.138.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a071121f..16d19c18
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Iba93e1a1d53ff35cc6ee63d25c42ec31315a6d62
Reviewed-on: https://chromium-review.googlesource.com/c/1377613
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616577}[Extensions] Don't allow overwriting ManifestHandlers
Currently, ManifestHandler::Register() and
ManifestHandlerRegistry::RegisterManifestHandler() allow registering a
new ManifestHandler with a key that has already been associated with
another ManifestHandler, overwriting the current entry.
Remove this behavior, and make ManifestHandlerRegistry DCHECK if a
handler is registered with an already-associated key. This is for a few
reasons:
- We never actually overwrite keys currently
- If we did overwrite a key, it would likely be a bug
- It's conceptually simpler
- It will make removing linked_ptrs from ManifestHandlerRegistry
simpler.
Bug: 914401
Change-Id: Ie15e9598cc65b8ce3c6b95a666addb41e54d8e0d
Reviewed-on: https://chromium-review.googlesource.com/c/1374115
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616576}Fix some nits in Chrome OS printing code.
Change-Id: Id09b588d5dc7f503ef867d9d040c2e175a2d879c
Reviewed-on: https://chromium-review.googlesource.com/c/1374527
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616575}Make webui/resources available for test data
In particular webui/resources/css/action_link.css is used
by FileManagerUITest. Previously this file was not loading
since it was not visible. Error revealed by
https://chromium-review.googlesource.com/c/chromium/src/+/1367331
Change-Id: I44cb066ba2887c30b0105427c0f4584ced8eb837
Reviewed-on: https://chromium-review.googlesource.com/c/1377488
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616574}[App Management] Make TestStore generic.
This CL makes the bookmarks TestStore generic, so that it can be
extended to create test stores for different store implementation
classes.
Bug: 906508
Change-Id: I80831d93c747e7b8964e3630719549277b9a0618
Reviewed-on: https://chromium-review.googlesource.com/c/1372969
Commit-Queue: Reka Norman <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616573}Reland: Remove fake alert AXObjWrapper object
Fixed ownership issues by observing aura::Env.
Original change:
Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit views::Widget.
[email protected]
Change-Id: Idd46cb2376b2f997e5d9f65d89b19f57663b08c3
Reviewed-on: https://chromium-review.googlesource.com/c/1376093
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616572}Roll src/third_party/pdfium 83f624293ac4..caacc5ffb136 (3 commits)
https://pdfium.googlesource.com/pdfium.git/+log/83f624293ac4..caacc5ffb136
git log 83f624293ac4..caacc5ffb136 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] Make CXFA_NodeHelper method names match style guide.
2018-12-14 [email protected] Use more spans in font loading code.
2018-12-14 [email protected] Move packet info from cxfa_document_parser.cpp to xfa_basic_data.cpp.
Created with:
gclient setdep -r src/third_party/pdfium@caacc5ffb136
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I0580c5daeb6a3f3b85cd86bc56ce0b7e5a18a2a1
Reviewed-on: https://chromium-review.googlesource.com/c/1377297
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616571}Navi: Fix mismatch in field trial
Bug: 874153
Change-Id: I4ce99a2d812bbd5ca30eb9431231470823e33636
Reviewed-on: https://chromium-review.googlesource.com/c/1377359
Commit-Queue: Hector Carmona <[email protected]>
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616570}Revert "Vaapi decode: split |decoder_|s GetRequiredNumOfPictures()"
This reverts commit 30fbb99c379e3aa5cd9db30649fdf370681ae334.
Reason for revert: Breaks ARC++ video playback with YouTube app.
Original change's description:
> Vaapi decode: split |decoder_|s GetRequiredNumOfPictures()
>
> This CL reduces the amount of PictureBuffers requested to be allocated
> by the |client_| when we are not |decode_using_client_picture_buffers_|.
> Instead, it "splits" the requested allocations into
> - the actual needed PictureBuffers (A)
> - the codec's requested reference frames (B) (a new method
> GetNumReferenceFrames() is added to AcceleratedVideoDecoder for this).
>
> This splitting saves a lot of memory, since we allocate A+B buffers
> instead of 2*(A+B). (B is 5 and A is 4-VP8, 4-12 H264/VP9)
>
> Test: crosvideo changing resolutions for each codec, v_d_a_unittest
> on nocturne (KBL) and caroline (SKL).
>
> Bug: 909926
> Change-Id: I1fce92863beddce0e8b221861cf156b9c3ad0c0f
> Reviewed-on: https://chromium-review.googlesource.com/c/1363807
> Reviewed-by: Hirokazu Honda <[email protected]>
> Commit-Queue: Miguel Casas <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615571}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 909926, 912295
Change-Id: Iac9941bdcaef1a7638518f835329ffb8be82233e
Reviewed-on: https://chromium-review.googlesource.com/c/1377480
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616569}Roll src/third_party/chromite 37614bc59ead..5f4970fb9456 (3 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/37614bc59ead..5f4970fb9456
git log 37614bc59ead..5f4970fb9456 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 [email protected] image_lib: extend LoopbackPartition to provide Mount/Unmount.
2018-12-13 [email protected] Update config settings by config-updater.
2018-12-13 [email protected] chromeos_config: Mark coral as non-important and enable skylab.
Created with:
gclient setdep -r src/third_party/chromite@5f4970fb9456
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ib77000d1fdfe4cab16fe512056f1ca2a1169ac7a
Reviewed-on: https://chromium-review.googlesource.com/c/1377716
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616568}Add Uninstall UI for Crostini Apps
Add UI to handle the "uninstall" menu option when right-clicking on a
Crostini app. This change brings up a confirmation dialog; if the user
confirms, it starts up the container and sends an uninstall message.
UI mocks https://docs.google.com/presentation/d/1akjEdjidRcMH54SK9zMmQVIPaPkwVuatXuKZLJKUqzA/edit
Several known bugs:
* chromium:909071
* chromium:909063
* chromium:898295
so this is behind a flag (CrostiniAppUninstallGui)
BUG=chromium:822514
TEST=Uninstalled multiple applications. Uninstalled applications at the same time for
queuing. Closed notifications while applications were uninstalling or queued. Installed
and uninstalled applications at the same time.
Change-Id: If5bb80cb867e55c3f082c40f89357f05db151985
Reviewed-on: https://chromium-review.googlesource.com/c/1275292
Commit-Queue: Ian Barkley-Yeung <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Anand Mistry <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616567}Add a UMA for same-originness of classic worker top-level scripts
To investigate when/how often there are "cross-origin" workers,
this CL adds a UMA to record same-originness of worker scripts
and its cross-origin reasons of classic worker top-level scripts.
Bug: 867302
Change-Id: I52c8caab6974d2db0b95e25115faba8045429902
Reviewed-on: https://chromium-review.googlesource.com/c/1149325
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616566}[ChromeDriver] Disable flaky testChromeStartRetryCount
Disable flaky chromedriver_py_tests test case
ZChromeStartRetryCountTest.testChromeStartRetryCount.
Bug: 899886
Change-Id: I1c1bd3450682d1f87108cc739a2471ba818fcec8
Reviewed-on: https://chromium-review.googlesource.com/c/1377333
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616565}Worker: Add hiroshige@ to core/workers/OWNERS
Bug: n/a
Change-Id: Ica0454a2c40826174d4300a9100b1a8714bcb75e
Reviewed-on: https://chromium-review.googlesource.com/c/1373374
Commit-Queue: Hiroki Nakagawa <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616564}[MediaFling] CAF Expanded controller implementation
This CL fills in the logic of the CAF expanded controller.
Previously the old controller talks via MediaRouter, which is not
recommended in the Cast world. Instead, in this CL, the
controller talks directly to the CastSession/RemoteMediaClient.
Also, the UI logic is greatly simplified due to this.
Bug: 711860
Change-Id: Ib16e1b5271835232fd8c0594c05c18c8a709a3dc
Reviewed-on: https://chromium-review.googlesource.com/c/1370496
Commit-Queue: Zhiqiang Zhang <[email protected]>
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616563}infra: Drop linux-goma-rbe-staging-rel to 40%
Seeing lots of infra failures still.
Previously it was stable at 50%. Dropping to a more conservative
40% to see what happens.
Bug: 911187
Change-Id: I4e629e2f5400193e950a47d633ee63cb27d13f1d
Reviewed-on: https://chromium-review.googlesource.com/c/1377473
Reviewed-by: smut <[email protected]>
Commit-Queue: Simon Que <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616562}Roll src/third_party/angle 91002266bd1e..bec398774ec6 (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/91002266bd1e..bec398774ec6
git log 91002266bd1e..bec398774ec6 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] tests:Fix memory leak in MipmapTest
Created with:
gclient setdep -r src/third_party/angle@bec398774ec6
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ibffaabe39ae38e03525b5c4b1750e483437930ab
Reviewed-on: https://chromium-review.googlesource.com/c/1377330
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616561}Adds Badging API support on Windows.
Explainer: https://github.com/WICG/badging/blob/master/explainer.md
The Windows 7 API for drawing badges on the taskbar requires that
we create a 16x16px bitmap which is rendered on the bottom right
corner of the taskbar icon.
Notes:
- This does not support numeric badges, only a '•' when
Badge.set called.
- The Windows 7 taskbar decoration API is limited in that it can
only display the decoration while the application is open,
which diverges from the spec, as the spec calls for a badge that
persists.
- There is some duplication and mess with the ChromeOS Badging
implementation. This has been left intentionally, as we're
trying to get it in for the M73 milestone, and will be cleaned up
in a future CL.
See https://bugs.chromium.org/p/chromium/issues/attachment?aid=371505&signed_aid=JfhG8iHpWlMp1bt1GRS6Eg==&inline=1
for an example of what badging looks like (note that the user's
profile icon is a burger, which is why it displays when there
is no badge).
Bug: 719176
Change-Id: I1267a3a37d11ac365348201facbd0bc1ea4deb36
Reviewed-on: https://chromium-review.googlesource.com/c/1353049
Commit-Queue: Jay Harris <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616560}Enable virtualized contexts on Linux AMD
A recent change to use SharedImage for WebGL has caused conformance
tests that copy from WebGL backbuffer to 2d canvas to fail on Linux
AMD bots which use native GL contexts.
It is speculated that this is due to flush ordering not working and
missing any other form of synchronization. SharedImages are created on
the raster decoder context instead of the WebGL context which might be
just enough to change context scheduling and cause these issues.
Bug: 914976
Change-Id: I3c4fb1dfe4d5839a647dde5dc9ca047c6d630a7f
Reviewed-on: https://chromium-review.googlesource.com/c/1377729
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616559}Remove ResourceFetcher::Create
The constructor is already public, so use it directly.
Bug: None
Change-Id: I2efb25cd9cd9cb8a69cf5ab787821a1c8a727866
Reviewed-on: https://chromium-review.googlesource.com/c/1375184
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616558}Refactor image_reader_utils.
Refactored DeleteAImageAsync() api to move gl fence creation and
exporting a sync fd from it to a separate function.
Bug: 891060
Change-Id: I181e8d032ca64f1cd9d0a6942fb33856b236f2a1
Reviewed-on: https://chromium-review.googlesource.com/c/1377212
Commit-Queue: vikas soni <[email protected]>
Reviewed-by: Chris Blume <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616557}Roll src/third_party/chromite e69db6685edf..37614bc59ead (2 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e69db6685edf..37614bc59ead
git log e69db6685edf..37614bc59ead --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Update config settings by config-updater.
2018-12-13 [email protected] Revert "cros_generate_update_payload: Switch update_engine to major version 2"
Created with:
gclient setdep -r src/third_party/chromite@37614bc59ead
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I9cd18f36a059d2ccf3992bc081f5333f40ec4e75
Reviewed-on: https://chromium-review.googlesource.com/c/1376930
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616556}WebUI: Add 1px of padding to 'Page number' input on PDF viewer to fix possible rounding errors
Bug: 908367
Change-Id: Iefa3b3841518338753ca0b29d0865bd3ffe432c7
Reviewed-on: https://chromium-review.googlesource.com/c/1373017
Commit-Queue: John Lee <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616555}DevTools: preserve panel tab order even when the panel is missing.
Bug: 771144
Change-Id: Ie7d18c9a51a0259d9db33259cd7ed857a5526de4
Reviewed-on: https://chromium-review.googlesource.com/c/1376994
Commit-Queue: Pavel Feldman <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616554}Roll src/third_party/pdfium 70e521463b71..83f624293ac4 (10 commits)
https://pdfium.googlesource.com/pdfium.git/+log/70e521463b71..83f624293ac4
git log 70e521463b71..83f624293ac4 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Split CXFA_Node::GetIntact().
2018-12-13 [email protected] Cleanup CFX_SystemHandler.
2018-12-13 [email protected] Remove unused CPDFSDK_FormFillEnvironment::GetLocalTime().
2018-12-13 [email protected] Use more variables to make code shorter.
2018-12-13 [email protected] Move XFA_ATTRIBUTEINFO and SCRIPTATTRIBUTEINFO to xfa_basic_data.h.
2018-12-13 [email protected] Fix some formatting and wording in fpdf_formfill.h
2018-12-13 [email protected] Sort cba_fontmap.cpp to match cba_fontmap.h.
2018-12-13 [email protected] Remove out param in CPDFSDK_FormFillEnvironment::GetPageViewRect().
2018-12-13 [email protected] Do IWYU for public/fpdf_fwlevent.h.
2018-12-13 [email protected] Build packets table via C Preprocessor.
Created with:
gclient setdep -r src/third_party/pdfium@83f624293ac4
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ie2c56388ac4b7be4bd7a4b8a96270f5c88f0c8f1
Reviewed-on: https://chromium-review.googlesource.com/c/1376932
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616553}Revert "Reland "wm: Update nested activation handling""
This reverts commit 77fbe34018de545f5b733709a2afcb1391ef1364.
Reason for revert: A test still fails with this.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/31030
Original change's description:
> Reland "wm: Update nested activation handling"
>
> This is a reland of ecde845099001740fee119a82d45664e622d0ade
>
> Original change's description:
> > wm: Update nested activation handling
> >
> > - NOTREACHED() and no-ope if the nested activation wants to change
> > to a different active window other than the one being activated;
> > - Allow focus shift in nested activations as long as they don't
> > change the window to be activated
> >
> > Bug: 908524
> > Test: FocusControllerApiTest.ActivateWhileActivating
> > Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642
> > Reviewed-on: https://chromium-review.googlesource.com/c/1357017
> > Reviewed-by: Scott Violet <[email protected]>
> > Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
> > Commit-Queue: Xiyuan Xia <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616346}
>
> Bug: 908524, 914915
> Change-Id: Id0072941bfb0def54f093bcb771b2d8485c9b04e
> Reviewed-on: https://chromium-review.googlesource.com/c/1376726
> Reviewed-by: Scott Violet <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616496}
[email protected],[email protected],[email protected]
Change-Id: I8fd98eca46991af0cd6a780f44f7912c5d6bad13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908524, 914915
Reviewed-on: https://chromium-review.googlesource.com/c/1377477
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616552}Roll src/third_party/depot_tools cfc9712bc80a..c6a8d114b060 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cfc9712bc80a..c6a8d114b060
git log cfc9712bc80a..c6a8d114b060 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/depot_tools@c6a8d114b060
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I87ccfebc949d53fab19dcfb0d690ab9ac98d7dbf
Reviewed-on: https://chromium-review.googlesource.com/c/1377336
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616551}Use new-tab-animation throbber for loading state
Makes use of the same nondeterministic animation during connecting and
loading. After loading finishes we transition to the previous loading
animation as a fade-out effect.
Bug: chromium:914166
Change-Id: I623bdd5d7bdb3e96fd56a2b224f9990a32036d2c
Reviewed-on: https://chromium-review.googlesource.com/c/1372565
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616550}[App Management] Add onAppChanged and onAppRemoved listeners.
This CL adds actions and reducers to handle the onAppChanged and
onAppRemoved events, as well as tests for these reducers.
Bug: 906508
Change-Id: I7b809e1030f33ea772a8d74343b45189f199f1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1375290
Commit-Queue: Reka Norman <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616549}Navi: Add field trial entry for NaviOnboarding for variations testing.
Bug: 874154
Change-Id: Ie3ba33e9cef640b6ef6917b7a475c3ad3636d40a
Reviewed-on: https://chromium-review.googlesource.com/c/1375371
Commit-Queue: Hector Carmona <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616548}Fix regression when showing open tasks in context menus.
When showing open tasks for files they should be displayed as "Open with XXX"
not just XXX.
This appears to be a regression introduced in
https://chromium-review.googlesource.com/1116878
Bug: 914737
Change-Id: I39c33575ceb215fe46c0fccc7ba218dae311ac40
Reviewed-on: https://chromium-review.googlesource.com/c/1377469
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Stuart Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616547}android: crazy_linker: Minor C++ cleanups.
A minor CL to mark move operations on misc. classes
as 'noexcept'. This is basic C++ hygiene but doesn't
affect the generated code since we don't use std::
containers in the crazy linker (but we might in
unit-tests).
BUG=NONE
[email protected], [email protected]
Change-Id: Icbe376be3172c7b39aef46f9cbb64c6f958f1cc2
Reviewed-on: https://chromium-review.googlesource.com/c/1376389
Reviewed-by: Egor Pasko <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616546}Add a boolean in QuicConnectivityProbingManager to track if probing is active.
We used to rely on the |network_| == kInvalidNetworkHandle check to determine if there's any active probing. This is preparing for probe server preferred address on non-Android platform where network_ may be invalid during active probing. No behavior change.
Bug: 913733
Change-Id: I280da06961b4faac0cf685ed9d994f37db4702f1
Reviewed-on: https://chromium-review.googlesource.com/c/1374792
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616545}Revert "Android OOP-D: Enable by default"
This reverts commit 78fdc19923ec39a49c7f80c9d5ea25f2b8879b6d.
Reason for revert: This is blocking the revert of a patch which is
causing issues in WebXr tests. See: https://bugs.chromium.org/p/chromium/issues/detail?id=913161
Original change's description:
> Android OOP-D: Enable by default
>
> Enable this feature by default as we prepare to roll to launch.
>
> Change-Id: I80bc0a1be124a2ae3cae9637de55cda5ef5e9203
> Reviewed-on: https://chromium-review.googlesource.com/c/1366866
> Reviewed-by: kylechar <[email protected]>
> Commit-Queue: Eric Karl <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615673}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ic7c77776b24c59f713f9c42bb14daff6197f708c
Reviewed-on: https://chromium-review.googlesource.com/c/1377213
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616544}Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html
Attempt to stabilize in Gecko.
Bug: 626744
Change-Id: Idfa06176948d1ffaf6ba8e65263bf5818ffd321b
Reviewed-on: https://chromium-review.googlesource.com/c/1375875
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616543}Network Error Logging: Add error types
Adds several error types that were covered by Domain Reliability but not
by NEL.
Bug: None
Change-Id: Ie7c1b829e9910b72ab0d5469cb1008b9a4e1799d
Reviewed-on: https://chromium-review.googlesource.com/c/1374154
Reviewed-by: Misha Efimov <[email protected]>
Commit-Queue: Lily Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616542}Fix DCHECK failure when cancelling out of Chrome GLS cause by an error message not being set when a failure occurs.
Change-Id: Ie4ff0a9429e2a9a90b7e094538981124e8a039e6
Reviewed-on: https://chromium-review.googlesource.com/c/1376725
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Tien Mai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616541}Roll src/third_party/webrtc f7f13e0742a9..d96b275cd686 (9 commits)
https://webrtc.googlesource.com/src.git/+log/f7f13e0742a9..d96b275cd686
git log f7f13e0742a9..d96b275cd686 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Refactor EncodeParameters usage, remove unused rtt/loss
2018-12-13 [email protected] Revert "Implement read-only codecPayloadType in RtpParameters"
2018-12-13 [email protected] Android: One weird trick for avoiding graphics deadlocks
2018-12-13 [email protected] Increase timeout of webrtc_perf_tests on Android to 1h15m
2018-12-13 [email protected] Create field trial for vp8 number of thread on iOS.
2018-12-13 [email protected] Sanitize candidates in ICE-level stats when necessary.
2018-12-12 [email protected] Roll chromium_revision 23962c3887..55b877610b (615838:615952)
2018-12-12 [email protected] Cleanup of RtpTransportControllerSend.
2018-12-12 [email protected] Implement read-only codecPayloadType in RtpParameters
Created with:
gclient setdep -r src/third_party/webrtc@d96b275cd686
The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
BUG=chromium:b/120481228,chromium:914452,chromium:None
[email protected]
Change-Id: If31091bccfac5903d85454cd9dab21b1e5b867e5
Reviewed-on: https://chromium-review.googlesource.com/c/1375401
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616540}Update V8 to version 7.3.136.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d373bc28..a071121f
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Ib18904be210a608fc17e971e0864fc44812e5a20
Reviewed-on: https://chromium-review.googlesource.com/c/1377177
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616539}Fix heap-use-after-free in aura::Env::last_mouse_location
BUG=910014
R=sky
Change-Id: If6e9ab3c33172793bbdc6ba820d0d5c77b1a330e
Reviewed-on: https://chromium-review.googlesource.com/c/1377134
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616538}[MediaFling] Add the skeleton of CAF expanded controller
This is part of the ExpandedControllerActivity to CAF
implementation. This CL only checks in the skeleton of the CAF
implementation of the expanded controller activity. The layout is
reused from the ExpandedControllerActivity so there's no UI
change.
The notification controller and the expanded controller activity
are now listeners to BaseSessionController so they both observe
the changes instead of relying on the session controller to
notify them.
The media route button layout is copied from
cast_controller_media_route_button.xml but with a different class
name because FullscreenMediaRouteButton is unsuitable for CAF.
Bug: 711860
Change-Id: I721890fbe159325203bf4368ccfd656db78f60f4
Reviewed-on: https://chromium-review.googlesource.com/c/1370393
Commit-Queue: Zhiqiang Zhang <[email protected]>
Reviewed-by: Thomas Guilbert <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616537}Remove disable-lock-screen-apps flag
Lock screen note taking has been launched for some time now, so we
shouldn't need the flag anymore.
BUG=None
Change-Id: Id73551c17f0912ac4a9c8107101cc9a2828eeb73
Reviewed-on: https://chromium-review.googlesource.com/c/1340528
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616536}Disable SwitchAccessAutoScanManagerTest for Mash
This feature does not work in Mash yet.
Bug: 897365
Change-Id: I193b892afccdceb17736a1c71b3794cdad2320b6
Reviewed-on: https://chromium-review.googlesource.com/c/1377334
Reviewed-by: Anastasia Helfinstein <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616535}Android: Enable bundle-specific native libraries
This change changes bundle builds to use _base.so native libraries
(libchrome_base.so or libmonochrome_base.so). These libraries will
initially be identical, but will diverge as native code is moved
from the main library to Android dynamic feature modules.
The required conditionals already exist in build configurations -
this change simply enables them.
A separate change has already been made to ensure official builders
upload symbols (for crashpad and for archiving).
BUG=874584
Change-Id: I314a53abfb4dfc04581b0d3fa25db345332b98e7
Reviewed-on: https://chromium-review.googlesource.com/c/1372314
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616534}Adds LitePageRedirect status/enabling support to interventions-internal
Bug: 880866
Change-Id: Id55ea142a79afbbe8f0663d628a6f9cab14108f9
Reviewed-on: https://chromium-review.googlesource.com/c/1374965
Commit-Queue: Doug Arnett <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616533}Chrome OS tests: Generalize JsConditionWaiter.
This Cl replaces JsConditionWaiter with more general TestConditionWaiter,
and removes some code duplication.
Bug: 880803
Change-Id: Iaa43837542305c1a7ed0ec0c5c761d7818db9d65
Reviewed-on: https://chromium-review.googlesource.com/c/1375713
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616532}Roll src-internal 5ec03d12df9c..b435194fb1a6 (4 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ec03d12df9c..b435194fb1a6
Created with:
gclient setdep -r src-internal@b435194fb1a6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I70f4dc15de18e2edefe38ccac9f4dc2169a24946
Reviewed-on: https://chromium-review.googlesource.com/c/1377369
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616531}infra: Add "Chromium Linux Goma RBE Prod" builder config
This builder uses the Goma RBE production cluster
Bug: 913249
Change-Id: Ica5dc6fa3a6073bb060445ecc4c1eeb1bd414b5d
Reviewed-on: https://chromium-review.googlesource.com/c/1375300
Reviewed-by: Ryan Tseng <[email protected]>
Commit-Queue: Simon Que <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616530}Add cthomp to security_state OWNERS
Change-Id: Ie7ce4941c6c3289cb48cb9bf1d345b9aa4878dc6
Reviewed-on: https://chromium-review.googlesource.com/c/1376650
Reviewed-by: Adrienne Porter Felt <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616529}[Media Controls] Use native media controls in Chrome OS video player
Hide default controls and use native controls.
Bug: 909963
Change-Id: Ifa40d499243244fbae8175a13f7bdcfacd8ca199
Reviewed-on: https://chromium-review.googlesource.com/c/1354262
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Jazz Xu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616528}Roll src/third_party/skia cb6b4bde0c2e..21a7be0741ac (3 commits)
https://skia.googlesource.com/skia.git/+log/cb6b4bde0c2e..21a7be0741ac
git log cb6b4bde0c2e..21a7be0741ac --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] fix roll
2018-12-13 [email protected] Roll third_party/externals/angle2 9b02506c852b..91002266bd1e (1 commits)
2018-12-13 [email protected] Re-land "Perform Vulkan resets in a background thread"
Created with:
gclient setdep -r src/third_party/skia@21a7be0741ac
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Id58eb59f42e848c0d1ecf4a32540f5ebaddebfa1
Reviewed-on: https://chromium-review.googlesource.com/c/1376875
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616527}Fix bounds for range browser test.
The previous test was pulling staticText nodes and applying BoundsForRange,
which doesn't have a defined behavior, so it's no wonder they started
failing. This forces inlineTextBox nodes by using a <p> instead of a <span>,
and adjusts the tests now that the inlineTextBox is being tested instead
of the staticText parent.
Bug: 908509
Change-Id: I0a8a6b91fd0c4b3212ea9f849fb4fc8d82bc3b1b
Reviewed-on: https://chromium-review.googlesource.com/c/1372310
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616526}Reland viz: Do not send hit-test data unless it has been updated.
Aggregation only occurs when new hit-test data has been
submitted.
[email protected]
[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 762251
Change-Id: Ibe35d794f449c391be99f91980d80976cf2e5f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1294838
Commit-Queue: Alexander Shah <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#616135}
Reviewed-on: https://chromium-review.googlesource.com/c/1376723
Cr-Commit-Position: refs/heads/master@{#616525}Remove missing security state workaround in CanAccessDataForOrigin().
- Remove an old workaround that was put in place before site isolation
was on by default.
- Fixed a test that depended on this behavior to pass.
Bug: 898281, 600441
Change-Id: I1f08a0d7af59514c84f7eebd5f48027758a0f63b
Reviewed-on: https://chromium-review.googlesource.com/c/1374831
Commit-Queue: Aaron Colwell <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616524}Revert "build: Default use_lld to true on ChromeOS."
This reverts commit 12b1bbff0b65f333ea2fa270259412cacbe056c3.
Reason for revert: Suspected cause of breakage on Google Chrome ChromeOS:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59619
Original change's description:
> build: Default use_lld to true on ChromeOS.
>
> As of https://chromium-review.googlesource.com/c/1372768 ChromeOS
> chrome is always linked with lld. Because ChromeOS's build system
> always overrides the value of use_lld this change should have no
> effect on official ChromeOS builds, but it should make ChromeOS on
> Linux more consistent with "real" ChromeOS.
>
> Bug: 701659
> Change-Id: I447e1b2dfb6cc970f2c2dd64d396b5ba58bc2ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/1377139
> Reviewed-by: Nico Weber <[email protected]>
> Commit-Queue: Peter Collingbourne <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616485}
[email protected],[email protected]
Change-Id: I5267fee85457ff624bd5a90b39c72a41b73d8853
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 701659
Reviewed-on: https://chromium-review.googlesource.com/c/1377712
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616523}Revert "Vaapi: Use GUARDED_BY() static annotations on decoder"
This reverts commit 99e2d9e3cdba89a15ebd4890b2de37336963a0b0.
Reason for revert: This breaks Video Playback on intel devices
Original change's description:
> Vaapi: Use GUARDED_BY() static annotations on decoder
>
> This CL introduces GUARDED_BY() static annotation on VaVDA; not all
> members variables need to be guarded, so it adds on a number of them
> a comment about on which thread it is used.
>
> Bug: 909547
> Change-Id: I437a82320795aebc56f77cd1254bb7c8c2f2f5da
> Reviewed-on: https://chromium-review.googlesource.com/c/1368590
> Reviewed-by: Hirokazu Honda <[email protected]>
> Commit-Queue: Miguel Casas <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616196}
[email protected],[email protected],[email protected]
Change-Id: I2e6496e9148f12d37f746a7d0b1e0e26cee70341
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 909547, 914954
Reviewed-on: https://chromium-review.googlesource.com/c/1377470
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616522}Roll src/third_party/depot_tools f423e051f343..cfc9712bc80a (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f423e051f343..cfc9712bc80a
git log f423e051f343..cfc9712bc80a --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Fix git cl format following removal of Rietveld.
Created with:
gclient setdep -r src/third_party/depot_tools@cfc9712bc80a
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:914150
[email protected]
Change-Id: Ife467339838320f06e482a3b0c9c2e2f50898dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1376931
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616521}Enable SII Data Uploads for Vulkan via WrappedSkImage
Adds support for initial data uploads to WrappedSkImage, allowing UI
to work with Vulkan.
Does not yet support ETC1 compressed textures, as Skia doesn't seem to
have a way to provide these. Will figure out how to get this working
in a follow-up.
Bug: 906794
Change-Id: Icf8894f7e7ed4ebedd9d7c31d0cce09f76e6aaf1
Reviewed-on: https://chromium-review.googlesource.com/c/1372529
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616520}Calculate focused node during serialization process.
The focused node cannot be calculated later because the
ArcAccessiblityNodeData and ArcAccessibilityWindowData structs will
be invalid.
Bug: 914106
Change-Id: Ia9b9b525dcd6dce4afe77cfc6fcc9868f62ed743
Reviewed-on: https://chromium-review.googlesource.com/c/1377171
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616519}Only show Tooltip on save UI for butter users
Bug: 914438
Change-Id: I8d2bfb4b9cbcafb7a0cc73bcb017c7a19259de4b
Reviewed-on: https://chromium-review.googlesource.com/c/1375457
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Jason Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616518}media: Suppress spurious gtest emission from SRC= pipeline fuzzer
From local inspection, it appears the only spurious
media_pipeline_integration_fuzzer gtest expectation failure emission is
when PipelineIntegrationTestBase::OnSeeked() is called with an
expectation of seek time of 0, but an actual seek time sometimes slightly > 0.
Since the FFmpegDemuxerStream start time logic and the decoder output
may both mess with the actual result of a seek to start time, this
change relaxes the seek time verification when fuzzing.
Also, this appears to be the last known spurious gtest emission from any
of the media*_pipeline_integration_fuzzers, so the general
"close_fd_mask=1" suppression is also removed from the fuzzer's
BUILD.gn target.
If other spurius gtest emissions occur, please file a new crbug so we
can target specific suppressions or fixes appropriately.
BUG=894460
[email protected]
[email protected]
Change-Id: I7e6ac3f3b8b27852cdb826371eccafcbc99b4ee9
Reviewed-on: https://chromium-review.googlesource.com/c/1377138
Commit-Queue: Matthew Wolenetz <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616517}gpu: Clarify definition of SurfaceHandle.
On mac, the AcceleratedWidget is now used as the SurfaceHandle.
So clarify the definition to make this less confusing.
BUG=none
Change-Id: I4b15b7e7028bd88c720e0a162afcde0b61060688
Reviewed-on: https://chromium-review.googlesource.com/c/1373882
Reviewed-by: Jonathan Backer <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616516}Add download_stats.cc to the directions for modifying download_file_types
It would be nice to have all the changes needed to modify
download_file_types.asciipb in one place, so we don't forget any.
Change-Id: I0a601d28ea6c7ce77cb5e4338746f01cd06ee4de
Reviewed-on: https://chromium-review.googlesource.com/c/1377143
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616515}DevTools: mimic DOMTokenList.toggle override in DOMExtension
Change-Id: If67b9b070d6ad59a68a54fe99ff0a601da4b4e1d
Reviewed-on: https://chromium-review.googlesource.com/c/1354780
Commit-Queue: Pavel Feldman <[email protected]>
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616514}Reland "[USB Enrollment] Add OOBE config key for enrollment token"
This is a reland of c8e45dc550a919031aeda2f0b2c34928f641fa4b
Reason for reland: CL was reverted due to flaky test.
Original change's description:
> [USB Enrollment] Add OOBE config key for enrollment token
>
> Added a code that would propagate enrollment token from OOBE config
> to EnrollmentScreen and start corresponding flow in EnrollmentHelper.
>
> Updated policy_testserver to reflect that USB-based enrollment
> uses attestation-based flow (although test server is not used in current
> browser_tests, they mock process on EnrollmentHelper level)
>
> Also updated configuration_keys.cc to fail on mismatched type for values,
> but only warn in case of extra keys in file.
>
> Bug: 854101
> Change-Id: I93be43dcb90c0b1b200549b3d4091f7d1194e694
> Reviewed-on: https://chromium-review.googlesource.com/c/1348891
> Commit-Queue: Denis Kuznetsov <[email protected]>
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Reviewed-by: Sergey Poromov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615123}
Bug: 854101
Change-Id: I826544c02d6cb49090da71a7e1e09bd8406d4143
TBR: [email protected]
TBR: [email protected]
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/1376390
Reviewed-by: Denis Kuznetsov <[email protected]>
Commit-Queue: Denis Kuznetsov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616513}Enqueue destroy shared image message under lock
Fix a potential bug where last_flush_id_ could be set out of order if
two threads call DestroySharedImage.
[email protected]
[email protected]
Bug: 870116, 914976, 882591
Change-Id: I974bff506211cafdc49440306203d6523cf614e5
Reviewed-on: https://chromium-review.googlesource.com/c/1376852
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616512}Remove HTMLResourcePreloader::CountPreloads() and GetDocument()
Simply not used.
Bug: 914690
Change-Id: I80779c7d7b2d4e8e8de410d451a78183931807a0
Reviewed-on: https://chromium-review.googlesource.com/c/1361946
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616511}Escape NetLog strings for SPDY debug_data.
Bug: 914874
Change-Id: I34695d179dd9132b9a1412ecdc2b0260cd3b886f
Reviewed-on: https://chromium-review.googlesource.com/c/1376850
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616510}Add myself to services/network/OWNERS
Change-Id: I7ad43524bc683b95227a150ec98ccdef662fa5b3
Reviewed-on: https://chromium-review.googlesource.com/c/1377310
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616509}Roll src/third_party/perfetto f8d555916230..745aaf284105 (5 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/f8d555916230..745aaf284105
git log f8d555916230..745aaf284105 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] profiling: clean up /proc/<pid>/cmdline parsing.
2018-12-13 [email protected] Merge "trace writer: Prevent overflowing a chunk's packet count"
2018-12-13 [email protected] Merge "trace_processor: fix nulls in non-string columns"
2018-12-13 [email protected] Merge "Don't open per-thread proc files in the initial ps scan"
2018-12-13 [email protected] Do not crash on failed wire message in debug
Created with:
gclient setdep -r src/third_party/perfetto@745aaf284105
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I39d9ed86af31830d1c0e034be15699fd9c534ef3
Reviewed-on: https://chromium-review.googlesource.com/c/1376215
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616508}Remove XmppUserSettings.test_server_domain
This functionality is unused.
Bug: None
Change-Id: Ie37b04dc82483439912ce7e8685537031c20fa98
Reviewed-on: https://chromium-review.googlesource.com/c/1376324
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616507}Demote BlinkGenPropertyTrees from experimental to test
BlinkGenPropertyTrees is causing crashes and we need to investigate
them before enabling this more widely.
Bug: 913464
Change-Id: Ic9782ab8986da7b48fee2dc7701adc53a901258d
Reviewed-on: https://chromium-review.googlesource.com/c/1377070
Commit-Queue: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616506}[CrOS MultiDevice] Update OWNERS files with correct component.
Also point to a single master OWNERS file.
Change-Id: I019063d57da599b4e25b5429e0882e0000baa4ee
Reviewed-on: https://chromium-review.googlesource.com/c/1370858
Reviewed-by: Dan Beam <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616505}DevTools: allow pausing page upon devtools open.
Bug: 672625
Change-Id: I16f1e5ffb64bc5dabbbc1e8096c5199cde6923c7
Reviewed-on: https://chromium-review.googlesource.com/c/1372658
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Pavel Feldman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616504}Prevent cast audio buffer pushes when the CmaWrapper is stopped.
When CmaWrapper is stopped, stop the timer for scheduled buffer pushes.
This prevents PushBuffer() from being called into an incorrect state.
changed blips using a connected device.
Bug: 910449, internal b/119413496
Test: Get multiple calls to the media pipeline on a cast device by rapidly sending volume
Change-Id: Iac61963d74aefc4c241ef8905b106d4ce7e315df
Reviewed-on: https://chromium-review.googlesource.com/c/1351718
Commit-Queue: Nate Steinbock <[email protected]>
Reviewed-by: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616503}[TaskScheduler]: Disable MergeBlockingNonBlockingPools from fieldtrial_testing_config.
The experiment regresses power.typical_10_mobile. Since we're only experimenting
on canary, I'm disabling it on testing config.
The current experiment doesn't have the exact same behavior as the change
that we eventually want to ship to higher channels. That is because running
the experiment forces us to keep the BlockingPool
alive, which causes more threads to be alive overall.
Bug: 903341
Change-Id: Ife4ce9d723f87b5f13cad59583dd423ae4bdfaeb
Reviewed-on: https://chromium-review.googlesource.com/c/1374157
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: François Doray <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616502}Closure compile import_controller_unittest
- remove import_controller_unittest.html
- add BUILD rules to auto-generate and compile this unittest
- update comments, remove unused functions, code re-format
- fix all Closure compile errors
No change in test behavior.
Bug: 914197
Change-Id: Ida12573fc640dcc97325b1240bedbbf970ff1f35
Reviewed-on: https://chromium-review.googlesource.com/c/1375301
Reviewed-by: Stuart Langley <[email protected]>
Commit-Queue: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616501}sqlite: Remove code for release 3.25.3.
Bug: 910906
Change-Id: Ie83ae3bdebb7128124628b876049f54ee77ab8e3
Reviewed-on: https://chromium-review.googlesource.com/c/1375616
Reviewed-by: Chris Mumford <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616500}IndexedDB: Stop using WebString and WebVector
A couple uses remain since other components in Blink use these
classes.
Bug: 717812
Change-Id: Ia32b6f2addb614d68a379809888edfbef46bca3a
Reviewed-on: https://chromium-review.googlesource.com/c/1361831
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616499}[App Management] Make main view a StoreClient.
This CL makes the app management main view a StoreClient, so that its
list of apps is linked to the apps in the Store.
Bug: 906508
Change-Id: Icb1c9755ced7a1bb8ed5e96bc12e7ecec1d87f42
Reviewed-on: https://chromium-review.googlesource.com/c/1372973
Commit-Queue: Reka Norman <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616498}Fixing a test issue with element visibility detection.
The captured sites automation framework waits for html page element
based on different visibility flags. One of these flag is 'on_top'. When
this flag is on, the framework calls the document.elementFromPoint function
to check that the target element function is not concealed behind
another element. The framework relies on this check to determine if a
page element is ready for interaction, or if the element is hidden
behind a progress UI or a warning popup.
document.elementFromPoint only acts on coordinates inside the current viewport. In other
words, this function only reports on elements visible on the screen. This
contradicts what I previously thought.
This fix scrolls a target element into view (if necessary) before
calling document.elementFromPoint to check if the target element is on
top. The fix also removes code that tries to deal with offscreen
elements.
Bug: 847905
Change-Id: If9640b0b48cb5e1cd60e94c74784a3a5ff841d6f
Reviewed-on: https://chromium-review.googlesource.com/c/1376809
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616497}Reland "wm: Update nested activation handling"
This is a reland of ecde845099001740fee119a82d45664e622d0ade
Original change's description:
> wm: Update nested activation handling
>
> - NOTREACHED() and no-ope if the nested activation wants to change
> to a different active window other than the one being activated;
> - Allow focus shift in nested activations as long as they don't
> change the window to be activated
>
> Bug: 908524
> Test: FocusControllerApiTest.ActivateWhileActivating
> Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642
> Reviewed-on: https://chromium-review.googlesource.com/c/1357017
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616346}
Bug: 908524, 914915
Change-Id: Id0072941bfb0def54f093bcb771b2d8485c9b04e
Reviewed-on: https://chromium-review.googlesource.com/c/1376726
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616496}Substitute AXNode::GetPosInSet() and AXNode::GetSetSize().
Only reflects updates to windows-specific code.
Substitute recently implemented AXNode functions for calculating
posinset and setsize.
Change-Id: Ic6a658a92e7846f4cd90b2667594a142fe95cbf7
Reviewed-on: https://chromium-review.googlesource.com/c/1368765
Commit-Queue: Akihiro Ota <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616495}Escape FTP lines logged to NetLog which may not be UTF-8.
Bug: 657116
Change-Id: I9b7eb9286b816f4ed993490c360f07e8b402ea9e
Reviewed-on: https://chromium-review.googlesource.com/c/1376989
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616494}Remove synchronous blocking from PipelineImpl::Stop() - take 3.
We should be able to avoid this with careful use of a trampoline
through the media thread after PipelineImpl::Stop() completes.
This is an updated version of the last CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1351791
PS#1 is the original change, latest PS is the fixed change.
The differences are as follows:
- We now disconnect the WebSurfaceLayerBridge from WMPI and preserve
it until after renderer shutdown -- otherwise layout tests don't
always get the last painted frame.
- When stopping the pipeline for HLS playback we now destruct the
DataSource and Demuxer at time of OnError(), rather than waiting until
the subsequent StartPipeline() call. This ensures the survive until
renderer stop completes.
BUG=521176, 905506, 909586, 909832
TEST=cq, layout tests, hls playback test.
Change-Id: Ifa895a6abf2b2ca2d51c126c31f210e594b261b0
Reviewed-on: https://chromium-review.googlesource.com/c/1351531
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616493}SPM: Disable ExtensionWebRequestApiTest.WebRequestTypes
Flaky in single_process_mash_browser_tests and fails multiple
times.
Bug: 914232
Change-Id: Ibfbca97573086223c973dbb9105e867cf82139c9
Reviewed-on: https://chromium-review.googlesource.com/c/1377196
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616492}Add Fields to App Struct
This CL adds optional fields to the app struct.
BUG=906508
Change-Id: I6fd79a95813d2c2d022c051de869b827178b251a
Reviewed-on: https://chromium-review.googlesource.com/c/1375192
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: calamity <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616491}shelf: Keep shelf visible if failed to drag up app list from it.
Bug: 882063
Change-Id: Id49140eb4e16fe2bef1e337cb67a5cf7cc8867d5
Reviewed-on: https://chromium-review.googlesource.com/c/1377169
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616490}FlushPendingWork if we destroyed_buffers
This is a speculative fix for https://crbug.com/911410.
With SharedImage, we need to FlushPendingWork to guarantee that
a DestroySharedImage is sent to the service side. This call was
introduced in https://crrev.com/c/chromium/src/+/1347355
Before this new CL, we would only FlushPendingWork if we were able to
clear all free_buffers_, clear all busy_buffers_, and destroyed_buffers
was set.
With this new slight change, we will FlushPendingWork if destroyed_buffers
was set, regardless if there are remaining free_buffers_ and
busy_buffers_.
This change is correct because free_buffers_ is LRU, busy_buffers_ is LRU,
and free_buffers_ are all older than busy_buffers_.
Bug: 911410
Change-Id: I416cd467139e03d55b46cf8476d539cd8d25d7e1
Reviewed-on: https://chromium-review.googlesource.com/c/1377190
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616489}Crash fix: Skia ImageInfo struct traits Read() should not CHECK().
A recent implementation of the mojo struct traits for SkImageInfo caused
Clusterfuzz to discover a crash: The root cause is that Clusterfuzz was
providing invalid inputs to StructTraits<...>::Read() (as it should),
but Read() should not be CHECK()-crashing the process on invalid inputs.
Instead, it should just return false, as is the interface contract.
[email protected]
Bug: 914235
Change-Id: Ibe0af638ebab11e161af6a154c22eaf4a50af695
Reviewed-on: https://chromium-review.googlesource.com/c/1376795
Reviewed-by: Yuri Wiitala <[email protected]>
Commit-Queue: Yuri Wiitala <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616488}Find result now announced by find bar in screen reader.
Bug: 862427
Change-Id: I3d752ef5f1c9f98c3886832dbaabf794153d8e68
Reviewed-on: https://chromium-review.googlesource.com/c/1374526
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616487}[DevTools] WebSQL grid shows error if a field is null
UI: ensure 'text' is string before accessing its field
Otherwise there is an error "TypeError: Cannot read property 'length'
of null"
Bug: 890580
Change-Id: Iecf705fc4c8956446dd695c673e6dcf7c3a1fe41
Reviewed-on: https://chromium-review.googlesource.com/c/1377145
Commit-Queue: Haihong Li (Harley) <[email protected]>
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616486}build: Default use_lld to true on ChromeOS.
As of https://chromium-review.googlesource.com/c/1372768 ChromeOS
chrome is always linked with lld. Because ChromeOS's build system
always overrides the value of use_lld this change should have no
effect on official ChromeOS builds, but it should make ChromeOS on
Linux more consistent with "real" ChromeOS.
Bug: 701659
Change-Id: I447e1b2dfb6cc970f2c2dd64d396b5ba58bc2ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1377139
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Peter Collingbourne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616485}[chrome:omnibox] Make boolean indicators copy-able.
The svg vector boolean indicators are not copyable through normal interaction
(e.g. select and press ctrl+c). This CL adds invisible (font size 0) true/false
text to each indicator for copying purposes.
This feature was initially added in CL 1271359, but was unintentionally removed
during refactors.
Bug: 891303
Change-Id: Id153b7aaefca7ec5797e33d8f20996772c1c9c0b
Reviewed-on: https://chromium-review.googlesource.com/c/1376718
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616484}[Android FRE Refactor] Do not launch Chrome when user aborts FRE 5/5
This CL removes the Intent-version of
CustomTabsConnection#sendFirstRunCallbackIfNecessary() whose usage was
removed in parts 3-4.
BUG=901954
Change-Id: I50c00d0688794fec304267e4cd9a4d6365e64d90
Reviewed-on: https://chromium-review.googlesource.com/c/1370888
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Peter Kotwicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616483}Work around Trichrome loading issue.
Android has started loading static shared libraries in a separate
classloader, which means that LibraryLoader can no longer access
non-public fields of NativeLibraries as they are not in the same APK
with the present Trichrome implementation.
We'll be moving to splitting the Trichrome Java code up along package
boundaries when we divide it properly which will avoid this problem, but
this small change works around the problem in the meantime.
Bug: 887078
Change-Id: Ifd0894d4bc2d5a732ffabd37045f2cac70ed6f55
Reviewed-on: https://chromium-review.googlesource.com/c/1376816
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616482}Do not send main resource data: urls to WebURLLoader
We can handle these in place, synchronously, which allows
to commit the navigation synchronously.
Handling main resources synchronously requires knowing
in advance the value of DocumentLoader::MainResourceIdentifier(),
which is now passed to FetchMainResource. Previously we used
the identifier in a separate task (due to going through async
WebURLLoader) and were able to retrieve it through GetResource().
Bug: 855189
Change-Id: I250464c173da87c936cd2b419857c36a7342a426
Reviewed-on: https://chromium-review.googlesource.com/c/1371022
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616481}Roll src-internal 05b396200126..5ec03d12df9c (13 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05b396200126..5ec03d12df9c
Created with:
gclient setdep -r src-internal@5ec03d12df9c
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I5fcf6229cbd8de10ed06f5feb4e6ed2db2d85dba
Reviewed-on: https://chromium-review.googlesource.com/c/1376911
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616480}Remove conditional check to avoid crash when main frame is detached
This was handling the case where the main frame was detached without
freezing the RenderWidget. Now that that should no longer happen, as
the FrameMsg_Delete call was removed from ~RenderFrameHostImpl, we
should not need this branch anymore, and a RenderWidget should always
be frozen when there is no frame (and no WebFrameWidget, currently)
around.
If something is strange then we'll see crashes start happening in
WebViewImpl::GetURLForDebugTrace() again, but we expect to not.
[email protected]
Change-Id: I4212622dbb8cbe5a6855d2d345490a5dbbf87683
Bug: 906340
Reviewed-on: https://chromium-review.googlesource.com/c/1377103
Commit-Queue: danakj <[email protected]>
Reviewed-by: Albert J. Wong <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616479}Revert "[vr] On-demand install VR DFM on N+"
This reverts commit 3e6d27f2d89227b59b81f75cb3a396a01512595c.
Reason for revert: Causing a compile failure on the builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/31519
VrIntentDelegate.java:55: error: cannot find symbol
int animation = VrDelegate.USE_HIDE_ANIMATION ? R.anim.stay_hidden : 0;
symbol: variable stay_hidden
location: class anim
1 error
Original change's description:
> [vr] On-demand install VR DFM on N+
>
> This requires handling the case when Chrome is started from VR before
> the module is installed. For this, move code that is required to
> identify VR intents and prevent 2D UI showing up in headset back to the
> base module. Furthermore, request VR module install when entering Chrome
> from VR and set up VR appropriately once the module install was
> successful. If the module cannot be installed within a timeout (we need
> a timeout so that Daydream does not kick us out of VR because we don't
> active VR mode in time) close Chrome on smartphones or launch it in
> 2D-in-VR mode on standalones.
>
> NOTE: The VR DFM is still not activated in Monochrome. So, this change
> won't be active yet.
>
> Bug: 914494
> Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
> Reviewed-on: https://chromium-review.googlesource.com/c/1372227
> Reviewed-by: agrieve <[email protected]>
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Tibor Goldschwendt <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616442}
[email protected],[email protected],[email protected]
Change-Id: I25c203f54e9b8be8371d882133b3123ef233adad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914494
Reviewed-on: https://chromium-review.googlesource.com/c/1377289
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616478}DevTools: Wait for the xhr panel to be shown before adding a breakpoint
Bug: 817780
Change-Id: I2e2f125ced1317cc135f4e8d5cdfd45141b9a003
Reviewed-on: https://chromium-review.googlesource.com/c/1370714
Reviewed-by: Erik Luo <[email protected]>
Reviewed-by: Joel Einbinder <[email protected]>
Commit-Queue: Joel Einbinder <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616477}[AF] Encode64 the account hash for the Wallet Sync Transport opt-in.
Bug: 914935
Change-Id: I40c9f26a39db803d961f227e4dd8ec06ce3b2b6d
Reviewed-on: https://chromium-review.googlesource.com/c/1376810
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616476}Remove wrong DCHECK in ~CdmPromiseAdapter()
We cannot guarantee that at destruction time all promises are already
fulfilled. Therefore change the DCHECK to a log.
Change-Id: Ie5ca92fa717760f774b0d7bf776ce21997f1ebf4
Reviewed-on: https://chromium-review.googlesource.com/c/1373139
Commit-Queue: Xiaohan Wang <[email protected]>
Reviewed-by: John Rummell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616475}WebUI: Update Network, Bluetooth, Connected devices sections to include padding on all the text
Bug: 686905
Change-Id: I2b56fab6601efe2daa11c2efde85dd309a6255ea
Reviewed-on: https://chromium-review.googlesource.com/c/1374966
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616474}Revert "Stop Disabling Web Usage for browsing data clearing on iOS 12"
This reverts commit 340b590451023790134cde96d82dfff9f64eb790.
Reason for revert: created problem for clear visited links
Original change's description:
> Stop Disabling Web Usage for browsing data clearing on iOS 12
>
> This should fix that clear browsing data doesn't work on cold start for
> NTP & Reading list.
>
> Bug: 900176, 632772
> Test:
> - Clear browsing data works as expected (cookie, visited links, etc..)
>
> Change-Id: I673bd354c1cbe46e7768ccfded1f858e3a19fad0
> Reviewed-on: https://chromium-review.googlesource.com/c/1350883
> Commit-Queue: Mohammad Refaat <[email protected]>
> Reviewed-by: edchin <[email protected]>
> Reviewed-by: Eugene But <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615251}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 900176, 632772
Change-Id: I3dd4b1d6e2007a5f4fbcadfae87942f4ef80536d
Reviewed-on: https://chromium-review.googlesource.com/c/1376315
Reviewed-by: Mohammad Refaat <[email protected]>
Reviewed-by: edchin <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616473}Revert using app windows for Feedback app links
CL https://chromium-review.googlesource.com/c/chromium/src/+/1320216
introduced opening links in the Feedback App in App Windows, which
caused a bunch of unexpected regressions.
This CL undoes this changeas it's no longer needed.
BUG=914405
TEST=Manual
Change-Id: Iebc3c0e3cd54c18c3bc9c5056248123c894f78f5
Reviewed-on: https://chromium-review.googlesource.com/c/1376107
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616472}Roll src/third_party/pdfium 4c91b17ead5c..70e521463b71 (3 commits)
https://pdfium.googlesource.com/pdfium.git/+log/4c91b17ead5c..70e521463b71
git log 4c91b17ead5c..70e521463b71 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Move fxjs/cfxjse_* files to fxjs/xfa.
2018-12-13 [email protected] Pass UFT8 ByteStringVies as arguments to {Get,Set}ObjectProperty().
2018-12-13 [email protected] Remove duplicate widestring literals from CXFA_*.cpp classes
Created with:
gclient setdep -r src/third_party/pdfium@70e521463b71
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ia2cfde356272ec8f2a553373bc03bbad35ea32df
Reviewed-on: https://chromium-review.googlesource.com/c/1376910
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616471}Reland "Add console message in MixedContentChecker::HandleCertificateError"
This is a reland of dcfa99386d0b0f91107fdb8c248be833ba18fd25. The only diff is that the
-expected.txt files for serviceworker/thorough/scheme-blob-* have been removed (context
in crbug.com/914679)
Original change's description:
> Add console message in MixedContentChecker::HandleCertificateError
>
> Print console message when subresources are loaded over broken HTTPS.
> Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing
>
> Bug: 587168
> Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8
> Reviewed-on: https://chromium-review.googlesource.com/c/1306779
> Commit-Queue: Livvie Lin <[email protected]>
> Reviewed-by: Mustafa Emre Acer <[email protected]>
> Reviewed-by: Yutaka Hirano <[email protected]>
> Reviewed-by: Mike West <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Nate Chapin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#614212}
[email protected], [email protected], [email protected], [email protected], [email protected]
Bug: 587168
Change-Id: I9ecb83b0e6a5d48cdc9b769b971f5da81c82bb62
Reviewed-on: https://chromium-review.googlesource.com/c/1366175
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616470}Roll src/third_party/libvpx/source/libvpx/ 418acaa0b..c62d9d568 (25 commits)
https://chromium.googlesource.com/webm/libvpx.git/+log/418acaa0bd06..c62d9d568fc6
$ git log 418acaa0b..c62d9d568 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 jzern update libwebm to libwebm-1.0.0.27-352-g6ab9fcf
2018-12-11 angiebird Replace mv_arr by pyramid_mv_arr
2018-12-11 marpan vp8: Fix to enabling MFQE
2018-12-11 angiebird Change interface of motion_compensated_prediction
2018-12-10 angiebird Move prepare_nb_full_mvs to vp9_mcomp.c
2018-12-11 deepa.kg Use undamped adjustment for rate correction factors
2018-12-10 jzern test/svc_end_to_end_test: fix SetConfig() signature
2018-12-10 jingning Clean up condition logics in rc_pick_q_and_bounds_two_pass()
2018-12-10 jianj Refactor svc_*_test.cc
2018-12-06 huisu Remove redundant code about motion vector test
2018-12-08 jzern test/svc_*_test: fix SetConfig() signature
2018-12-06 jianj vp9 svc: add test for scaling partition on 1080p crash.
2018-12-04 jianj vp9 screen: Update motion search offset when set to NSTEP.
2018-12-06 jzern test/*: use std::*tuple
2018-12-06 huisu Add enum definition for subpel search precision
2018-12-07 johann.koenig apply -Wextra to third_party/
2018-11-06 sdeng Add high bit Hadamard 32x32 avx2 implementation
2018-10-30 sdeng Add satd avx2 implementation
2018-12-05 angiebird Implement find_prev_nb_full_mvs
2018-12-05 angiebird Implement get_full_mv()
(...)
Created with:
roll-dep src/third_party/libvpx/source/libvpx
[email protected]
BUG=913246
Change-Id: Ia09fbe7274726dfbd8760522f4e34341d1c63f8b
Reviewed-on: https://chromium-review.googlesource.com/c/1377136
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Jerome Jiang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616469}Move Switch Access menu to appear next to selected element.
Bug: 864796
Change-Id: I37d7e874eba83b4abb9f7b59a4106240b579aa34
Reviewed-on: https://chromium-review.googlesource.com/c/1362240
Commit-Queue: Anastasia Helfinstein <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616468}cros: Don't use $('login-header-bar').signinUIState = FOO in OOBE
This CL is the first step towards removing the header bar dependency from OOBE
webUI.
Bug: 914548
Change-Id: I476c6515d9a29ea31f99bf889b70ae80a41c18f0
Reviewed-on: https://chromium-review.googlesource.com/c/1375030
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Quan Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616467}Make falures to stop RemoteTestServer fatal.
On Fuchsia test bots we observe that net_unittests flake sometimes
because they exceed the limit on number of test server instances. This
suggests that test server is not always stopped properly. This change
makes these issues more visible.
Bug: 913156
Change-Id: Idc14956659a461bf8851f0456416275e11ccc544
Reviewed-on: https://chromium-review.googlesource.com/c/1376609
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616466}Roll buildtools
BUG=846855
R=thakis
Change-Id: I6c1a1325b089b12e86268b14edbffe4b05a5e58f
Reviewed-on: https://chromium-review.googlesource.com/c/1374973
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616465}Move device::PostAsyncResults in to base::win
The PostAsyncResults function sets a base::OnceCallback as the
completion handler for an IAsyncOperation. Similar utilities were
implemented for //device/bluetooth and //services/shape_detection.
This change promotes the //device/bluetooth version into base::win
and refactors //services/shape_detection to use it.
[email protected]
Build file change.
Change-Id: Ie59f33a4cdb86eaf3ae0ddcfa47bd949f3ad471e
Reviewed-on: https://chromium-review.googlesource.com/c/1375395
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616464}[Blob] Removing & modifying unnecessary metrics
[email protected],[email protected]
Bug: 864328
Change-Id: I0726e315cd45d98d2490b64252b8c9dbc2b3d0bd
Reviewed-on: https://chromium-review.googlesource.com/c/1318441
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616463}dns: Reduce redundant comparisons in FindAddressListDeltaType()
In FindAddressListDeltaType(), always spend O(nxn) to compare two
AddressLists. If any match has occurred before, but the current does
not match, or vice versa, so these two AddressLists are definitely
DELTA_OVERLAP. The CL fixes it.
Change-Id: I44f0c3824eb8376949a59b433bf9154707a50d47
Reviewed-on: https://chromium-review.googlesource.com/c/1371684
Reviewed-by: Eric Orth <[email protected]>
Commit-Queue: Eric Orth <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616462}Implement ExtensionLocalizationPeer with data pipe
Previously ExtensionLocalizationPeer::OnStartLoadingResponseBody() passed the
pipe through the |original_peer_|. As we are moving body transfer from
RequestPeer::OnReceivedData to OnStartLoadingResponseBody, this CL implements
OnStartloadingResponseBody() and the following logic.
Bug: 907793
Change-Id: If85d788084ca089fd34ba9b17b016240ecd29214
Reviewed-on: https://chromium-review.googlesource.com/c/1358311
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616461}Roll src/third_party/depot_tools 7fa4fbc46829..f423e051f343 (2 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7fa4fbc46829..f423e051f343
git log 7fa4fbc46829..f423e051f343 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] [led] Update led to latest version.
2018-12-13 [email protected] Add a feature to specify branches to be re-based
Created with:
gclient setdep -r src/third_party/depot_tools@f423e051f343
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:914196,chromium:914926
[email protected]
Change-Id: Icfb8fe0b34863b5961a26bee277c9f5c144fa420
Reviewed-on: https://chromium-review.googlesource.com/c/1376872
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616460}[Autofill Sync] Do not show downstream prompt on CVC fields
This CL fixes a small bug where the opt-in prompt for Autofill Sync
Transport is shown on CVC and CC type fields. This is necessary because
these fields don't actually have suggestions available, so we hit a
DCHECK when the user opts in and we try to show them suggestions.
Bug: 914944
Change-Id: I38061b59699de623d0d828d1932dbfd1ad7aceee
Reviewed-on: https://chromium-review.googlesource.com/c/1376813
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616459}Roll src/third_party/angle 9b02506c852b..91002266bd1e (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/9b02506c852b..91002266bd1e
git log 9b02506c852b..91002266bd1e --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Use angle::Result and pass a context pointer to TransformFeedbackImpl
Created with:
gclient setdep -r src/third_party/angle@91002266bd1e
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I8490941ca7306511cfa45e769f430299bd12b3c3
Reviewed-on: https://chromium-review.googlesource.com/c/1376871
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616458}[CrOS MultiDevice] Remove the rest of BLE code from Instant Tethering.
Instant Tethering was originally built with its own BLE stack, but it
now uses the SecureChannel service for all Bluetooth communication. This
CL removes the remaining Bluetooth code from
//chromeos/components/tether.
Change-Id: I6aeacb66b5b3f10294d062d3146d058d1803b601
Reviewed-on: https://chromium-review.googlesource.com/c/1377172
Commit-Queue: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616457}Export BuiltinCategories
Otherwise I get undefined symbol errors when building a component build
(eg from libleveldatabase.so).
Change-Id: I991e813eb6a4fffda42d232fc17f56f28abb13a5
Reviewed-on: https://chromium-review.googlesource.com/c/1376410
Reviewed-by: Ehsan Chiniforooshan <[email protected]>
Commit-Queue: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616456}Clean up WebPagePopup APIs and move them from WebWidget to WebView.
This moves WebWidget::GetPagePopup() to WebView, as there is only 1
popup per view, not per widget. WebTest code was grabbing the popup
off the WebWidget and is changed to grab it from the WebView instead
when the WebWidget is for the main frame (which it always is right now
but we add conditions for correctness regardless).
WebViewImpl had a bunch of ways to close the current popup, and we
remove most of the redundant ways: HideSelectPopup() is removed.
HidePopups() is removed, and CancelPagePopup() is changed to replace
it.
SetLastHiddenPagePopup() is removed from the public API of WebViewImpl
as it is no longer used externally, and code inside changed to use the
variable directly.
WebPagePopupClient::ClosePopup() is renamed to CancelPopup() to give
consistent naming throughout the Cancel code.
WebViewTestProxy changed to defer WidgetClient() through to the
WebViewTestClient, like it does for other methods, and we pass the
ProxyWebWidgetClient to the WebViewTestClient for it to hand out,
instead of giving it null.
[email protected]
TBR=
Change-Id: Ibaddec943ead28153290cd03a3d94790ac5d4fe0
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1372657
Commit-Queue: danakj <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616455}Only consider first submit button in a form as default
Test: with ChromeVox and chrome://settings
Bug: 910792
Change-Id: I8531ee913be0c62e177f207d2f1ef28d4b28d4f3
Reviewed-on: https://chromium-review.googlesource.com/c/1374490
Commit-Queue: Aaron Leventhal <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616454}Tether: Upgrade severity of log "active host lost".
I observed this log while manually using Tether; this
will probably be a useful log when receiving user
feedback.
Change-Id: I8c3c0cd770b78efefb3f4c5ff556628a4d959c35
Reviewed-on: https://chromium-review.googlesource.com/c/1376870
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616453}Skip WebGL conformance tests that crash the GPU process on Android.
When the GPU process crashes, the test harness waits for 5 minutes before
marking the test as a timeout. This causes some shards to have a very long
runtime.
BUG=882580
[email protected]
Change-Id: Ib5ef722b3d921b877112491db3bad65131004724
Reviewed-on: https://chromium-review.googlesource.com/c/1376710
Reviewed-by: Geoff Lang <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616452}Update V8 to version 7.3.132.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d81c9cc2..d373bc28
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Ib97102868c8a9878c828cdcad417b020729793e2
Reviewed-on: https://chromium-review.googlesource.com/c/1376629
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616451}Add UMA labels to match WebRTC enum
To be submitted when to https://webrtc-review.googlesource.com/c/src/+/113321 is imported in Chrome.
Bug: chromium:914452
Change-Id: Ibea51d0e41687bd775085fa7198cc59d528e8eb7
Reviewed-on: https://chromium-review.googlesource.com/c/1374744
Reviewed-by: Steve Anton <[email protected]>
Commit-Queue: Jeroen de Borst <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616450}Roll src/third_party/skia c9b7c720ddd3..cb6b4bde0c2e (16 commits)
https://skia.googlesource.com/skia.git/+log/c9b7c720ddd3..cb6b4bde0c2e
git log c9b7c720ddd3..cb6b4bde0c2e --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Add dependency for fuchsia vulkan headers
2018-12-13 [email protected] Add blacklist for vulkan intel 405.
2018-12-13 [email protected] simplify fExternalCounter bookkeeping
2018-12-13 [email protected] make ctor and setter consistent -- just take the typeface param as is
2018-12-13 [email protected] [skottie] Add initial tracing
2018-12-13 [email protected] undef fontmetrics flag -- rely on clients to opt in
2018-12-13 [email protected] Add a test to imitate GIFImageDecoderTest.parseAndDecodeByteByByte
2018-12-13 [email protected] use SkFont for textToGlyphs
2018-12-13 [email protected] always check lock() result
2018-12-13 [email protected] remove dead code around SkPaint::breakText
2018-12-13 [email protected] make new ctor explicit
2018-12-13 [email protected] use font for measuring
2018-12-13 [email protected] Move textureType() method from GrSurfaceProxy to GrTextureProxy.
2018-12-13 [email protected] remove legacy pathref validation
2018-12-13 [email protected] minor docs example fix
2018-12-13 [email protected] add simpler constructor for SkFont
Created with:
gclient setdep -r src/third_party/skia@cb6b4bde0c2e
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:913930
[email protected]
Change-Id: I656a3af3be20500323eaf60ac407b6296e0024ed
Reviewed-on: https://chromium-review.googlesource.com/c/1376669
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616449}[CompositeAfterPaint] Fix frame overlay painting
For now frame overlays are implemented with GraphicsLayers.
Create foreign layers for them.
Change-Id: I489b4935f8a8e6f535d3aff4038cf281d700963d
Reviewed-on: https://chromium-review.googlesource.com/c/1371212
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616448}Refactor to support recording FCP++ before user input.
* update OnUserInput to report timing and extra info
* refactor FCP++ tracking in the dispatcher to make FCP++
metrics available before end of page load, so we can see
their values at the point we process initial user input
* remove FCP++ callbacks since these aren't needed (we
instead log these metrics in the OnComplete callback)
Max will follow this change with a change to log FCP++ metrics
in the OnUserInput callback.
Change-Id: I2245590bd1c5b8246cf1282544994d480765c9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1371085
Commit-Queue: Bryan McQuade <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Reviewed-by: Liquan (Max) Gu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616447}[PE] Avoid cache conflict when painting LocalFrameView outside of lifecycle
Rename LocalFrameView methods:
PaintWithLifecycleUpdate() -> PaintOutsideOfLifecycle()
PaintContents() -> PaintContentsOutsideOfLifecycle()
because they are special paints outside of lifecycle update (vs the
normal paint executed during lifecycle update).
They may conflict with normal painting about paint controller caching.
Previously in pre-CompositeAfterPaint we assumed no conflict by either
- using transient paint controller (through PaintRecordBuilder), or
- assuming the local frame root of the LocalFrameView doesn't have
graphics layers.
The above assumption was not always true. One case is the validation
message popup which may contain complex composited contents.
Add check for conflicting paints outside of lifecycle.
Add PaintArtifact::GetPaintRecord() and LocalFrameView::GetPaintRecord()
for fast path in CompositedAfterPaint.
Change-Id: I8222dd58cf5b8e1e86493476c02761e844675c01
Reviewed-on: https://chromium-review.googlesource.com/c/1374779
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616446}Use after free in WebXR mirroring
WebXR has a mirroring feature where a canvas may show a copy (perhaps a
few frames behind) of what was shown in the headset.
This was using a push model, where new frames were pushed to a mirroring
client, which would update the canvas. This ran into cleanup issues
during session termination, because garbage collection may be cleaning
up objects and there isn't a well-defined order for these objects to be
destroyed.
The fix is to change mirroring over to a pull model, where XRWebGLLayer
will pull new images from the XRWebGLDrawingBuffer/MirrorClient. This
helps because now we don't have lower-level non-garbage-collected
objects potentially calling into garbage collected objects during
destruction. We also now don't have GC objects calling into other GC
objects during destruction.
BUG=836984
Change-Id: I1631a0bb17db02574c1f69afcdc60330c9c3e36e
Reviewed-on: https://chromium-review.googlesource.com/c/1373885
Commit-Queue: Bill Orr <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Klaus Weidner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616445}Make AddLocalizedStringsBulk() calls consistent.
- Pass in a constexpr array when possible.
- Use base::size().
Change-Id: I1e3073520d8fa4e4e2b6daf2854adf65648dd1c8
Reviewed-on: https://chromium-review.googlesource.com/c/1374468
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616444}Cancel resource load if SB committed interstitials are enabled
With committed interstitials, SB-flagged navigations should be
cancelled so they trigger the WillFailRequest path in navigation
throttles. In a future CL, a navigation throttle will be added that
will create the interstitial (and display it).
Bug: 910794
Change-Id: If661d17a09cb6892bf5e5493c6bc2df1b2325525
Reviewed-on: https://chromium-review.googlesource.com/c/1371065
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616443}[vr] On-demand install VR DFM on N+
This requires handling the case when Chrome is started from VR before
the module is installed. For this, move code that is required to
identify VR intents and prevent 2D UI showing up in headset back to the
base module. Furthermore, request VR module install when entering Chrome
from VR and set up VR appropriately once the module install was
successful. If the module cannot be installed within a timeout (we need
a timeout so that Daydream does not kick us out of VR because we don't
active VR mode in time) close Chrome on smartphones or launch it in
2D-in-VR mode on standalones.
NOTE: The VR DFM is still not activated in Monochrome. So, this change
won't be active yet.
Bug: 914494
Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
Reviewed-on: https://chromium-review.googlesource.com/c/1372227
Reviewed-by: agrieve <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616442}ash: removes AshTestBase::RunAllPendingInMessageLoop()
I'm tired of using this and getting presubmit warnings.
BUG=none
TEST=none
Change-Id: If52cdc8dd86dd9a6adef70b4e8e7f1149922913a
Reviewed-on: https://chromium-review.googlesource.com/c/1376659
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616441}[CrOS MultiDevice] Remove remaining kMultiDeviceApi flags
Removing remaining kMultiDevice flags and associated code paths that
will no longer occur.
Bug: 912743
Change-Id: I169c667c22a9063668b7935ee87cc3f04b168df1
Reviewed-on: https://chromium-review.googlesource.com/c/1372464
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Regan Hsu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616440}[Autofill Sync] Make dropdown reappear after opt-in
Currently, the dropdown disappears upon selecting the new opt-in row.
Instead of hiding as we do with other suggestion types, we will now
fetch credit card suggestions again and re-show the dropdown.
Bug: 914609
Change-Id: I032c5a062a5251d442ad25ea85a99da41b3f9a77
Reviewed-on: https://chromium-review.googlesource.com/c/1374464
Commit-Queue: Tommy Martino <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616439}PWA Badging: Fix lifetime of BadgeServiceImpl.
This CL updates BadgeServiceImpl to extend FrameServiceBase so that the
service is destroyed when the RenderFrameHost instance it uses goes
away.
Bug: 913807
Change-Id: I6e8b35badafae4b31c71de5aa7987ac1353e8005
Reviewed-on: https://chromium-review.googlesource.com/c/1372535
Commit-Queue: Eric Stevenson <[email protected]>
Reviewed-by: Matt Giuca <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616438}Make pressing multi-button pass on wpt serve
In order to support pressing multi-button at the same time, we keep the
buttons that were pressed before in the modifiers when passing to
InputHandler::DispatchMouseEvent function. Also, we support back and
forward buttons.
This patch makes
wpt/pointerevents/pointerevent_pointermove_on_chorded_mouse_button.html
wpt/uievents/mouse/mouse_buttons_back_forward.html pass.
Bug: 913633
Change-Id: I525812abfa523644a573b25499bf7246a787f538
Reviewed-on: https://chromium-review.googlesource.com/c/1371031
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Joel Einbinder <[email protected]>
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Lan Wei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616437}[AdTagging] Enable AdTagging by default
AdTagging is now being dependend upon by OOM Intervention as of
M71 via field trial. Enabling by default in M73 and planning to
merge to M72.
Bug: 812219
Change-Id: I309a40f03fd9672005a4b6b367aa19c9fba130e0
Reviewed-on: https://chromium-review.googlesource.com/c/1358691
Commit-Queue: Josh Karlin <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616436}chromeos: Support accessibility automation under SingleProcessMash
Introduce AXAshWindowUtils to allow the accessibility subsystem to
convert between ash proxy windows and browser client windows while
serializing the AX node tree.
Support out-of-process clients like shortcut_viewer by skipping the
proxy conversion, since they use the AXHost mojo service and depend
on having the ash-side windows and widgets serialized.
One side effect of this change is that the entire ash desktop is
serialized with the first AXTreeUpdate when ChromeVox is enabled.
This does not seem to cause any issues in practice.
Bug: 911776
Test: added to ash_unittests
Change-Id: I7f988b57fad2548c4f3f16460d8a92ff967bad50
Reviewed-on: https://chromium-review.googlesource.com/c/1366280
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616435}Remove experimental warning for Web Bluetooth on Windows
Web Bluetooth has been available on Windows 10 and above since Chrome
70. This change removes the warning that this feature is experimental.
Bug: 419413
Change-Id: I009a07c93e80a164e47df11ae59479fc02dce57c
Reviewed-on: https://chromium-review.googlesource.com/c/1371036
Reviewed-by: Jeffrey Yasskin <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616434}Support weights in TrainingDataStorage.
Since we'll end up pushing many copies of the same (possibly
weighted) examples into TrainingDataStorage, support weights there
directly. This lets us de-duplicate them in the future, to save
both space and training time.
Note that TrainingData snapshots these weights, so that one may
continue to update the weights in TrainingDataStorage, without
affecting any outstanding references to them. This will allow us
to collect training data while training is in progress, without
requiring a copy of the storage.
This CL does not add the ability to de-duplicate identical
examples to TrainingDataStorage.
Change-Id: I207cb6d5c85ce83ba803f935adc300cfa284dd75
Reviewed-on: https://chromium-review.googlesource.com/c/1372272
Commit-Queue: Frank Liberato <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616433}Handle null GpuMemoryBuffer for WebXR
We may get null GpuMemoryBuffers in some cases, so we should
handle them without crashing or hanging presentation.
BUG=791815
Change-Id: Ic219bb678a4b1b852a7b299ac0083a5b10ee7a97
Reviewed-on: https://chromium-review.googlesource.com/c/1372475
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Klaus Weidner <[email protected]>
Commit-Queue: Bill Orr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616432}Make committed ssl interstitials testing config match GCL
Change-Id: Id1c84e0685e789fb50b44d61e161eab8c97f6d5b
Reviewed-on: https://chromium-review.googlesource.com/c/1376139
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616431}Update gtest_merge logic to parse outputs regardless of failure status.
When a bot times out, it may still output json results. This CL updates the
gtest_merge logic to always parse json results, if they exist.
Bug: 895027
Change-Id: I4c78e5f8a7270a100a97fb8d6f9ffe8f3cf30b83
Reviewed-on: https://chromium-review.googlesource.com/c/1330066
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616430}[Android WebAPK] Send share target information in WebAPK updates
This CL plumbs through share target information for WebAPK updates.
Chromium detects Web Manifest updates (including Web Manifest share
target updates) and requests an update.
Currently, depending on whether the Web Manifest is for an intranet
site, the updated WebAPK would either:
- no longer be able handle share intents (even if the Web Manifest
share target information was not deleted)
- be created with the same share intent handlers as the current WebAPK
(regardless of whether the Web Manifest share target information has
changed).
This CL plumbs through the share target information from
WebApkUpdateDataFetcher#onDataAvailable() to
WebApkUpdateManager::StoreWebApkUpdateRequestToFile()
BUG=912945
Change-Id: Ie416570533abc848eeb23de8c197b44f2a1fd028
Reviewed-on: https://chromium-review.googlesource.com/c/1369709
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616429}Move continue navigation callback to blink
This will make it easier to synchronously commit
navigations in blink until we are ready to stop using
WebURLLoader for main resources.
Bug: 855189
Change-Id: I097d65e83bf645b5ffd621fcf68d94d6280d15a1
Reviewed-on: https://chromium-review.googlesource.com/c/1359332
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616428}[Sync::USS] Add a CHECK if the parent of an added node isn't tracked
BookmarkModelObserverImpl gets notifiied when new bookmarks are added
to the local model.
Today, the observer simply ignores those events, however, this may cover
other bugs because the rest of the code would crash if a node
that should be tracked in missing.
We shouldn't tolerate those additions.
This CL, is adding a CHECK (for debugging purposes) that would be
switched to a DCHECK once it's confirmed that things are intact.
Bug: 516866
Change-Id: Ibc750a3bc135a0a9059ed539cbda1bcba775a03e
Reviewed-on: https://chromium-review.googlesource.com/c/1375719
Commit-Queue: Mikel Astiz <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616427}Fix Assistant timeout handling logic.
LibAssistant inconsistently delivers mic timeout resolution values on
interaction finished. We need to handle the case where the interaction
is thought to have resolved normally but actually contained no speech.
Also address some warmer welcome TODOs that were blocked by this
change.
Bug: b:120242181
Change-Id: If9cde244ca4393278972c5b67172d750c1564e9f
Reviewed-on: https://chromium-review.googlesource.com/c/1371219
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616426}hugepage_text: note that we now mlock things
CL 1371206 made us mlock hugepages. I think this deserves a callout in
docs, and tweaks to function names so they more accurately describe what
we're doing.
This CL does all of that.
No functional change is intended.
Bug: 913700
Test: Chrome still builds for falco, which runs this code.
Change-Id: If8dfe93e147bec47c100bb2eb58ba05625c9bcfd
Reviewed-on: https://chromium-review.googlesource.com/c/1374960
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: George Burgess <[email protected]>
Commit-Queue: George Burgess <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616425}[Mac] Use non-autoreleased mock object in ScopedBundleSwizzlerMac
The "release" call in the destructor might or might not destroy the
mock object, depending on current autorelease pool.
If we add to the picture the local autorelease pool (used in tests),
we no longer can name the class "Scoped".
The fix creates OCPartialMockObject without the helper function,
avoiding the autoreleasability.
Change-Id: Id17a1ef571246370f6e84cde60773f90d7d35cb0
Reviewed-on: https://chromium-review.googlesource.com/c/1375871
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616424}Split ui, test and app_framework out into shared_headers source sets
to effectively handle the cross dependencies.
Bug: 906201
Change-Id: Ife03605b49729d45834d470f5d4976f86c625343
Reviewed-on: https://chromium-review.googlesource.com/c/1376095
Commit-Queue: Lindsay Pasricha <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616423}Ensure move loop ends when TabDragController is destructed
Currently, in the unlikely/shouldn't happen case where a tab drag is
initiated when one is already active, the old tab drag controller is
freed, but doesn't ensure that the running move loop is ended.
This seems like it could be a piece of crbug/876493 puzzle, and cleaning
up the move loop seems correct either way, so let's do that.
Additionally, removes the blocking right click when move loop is active
on Mac. The crash we know how to repro is fixed by this change as well,
and the right click change wasn't effective at stopping crashes in the
wild.
Bug: 876493
Change-Id: I51443583cc101fec0cc80aa30d586098f78af23c
Reviewed-on: https://chromium-review.googlesource.com/c/1374770
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616422}Reland "Reland "base: Don't keep running tasks after nested run loop quits on iOS""
This reverts commit 5f534197944cdb2e4947e9aca7ceaee68ee3608d.
Reason for revert: This CL needs to be in the tree to keep ios-simulator green.
Original change's description:
> Revert "Reland "base: Don't keep running tasks after nested run loop quits on iOS""
>
> This reverts commit 6a988bfbbdae7880bd3fba26f96c120600a76db5.
>
> Reason for revert: should not have relanded
>
> Original change's description:
> > Reland "base: Don't keep running tasks after nested run loop quits on iOS"
> >
> > This reverts commit d0de086966fe7e05b6aa69d3ec69eedad2aa9e64.
> >
> > Reason for revert: broke ios-simulator bots
> >
> > Original change's description:
> > > Revert "base: Don't keep running tasks after nested run loop quits on iOS"
> > >
> > > This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.
> > >
> > > Reason for revert:
> > > Sheriff suspects this broke a handful of menu tests on macOS 10.12:
> > >
> > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564
> > >
> > > e.g.:
> > > WebViewTest.TestContextMenu
> > >
> > > Original change's description:
> > > > base: Don't keep running tasks after nested run loop quits on iOS
> > > >
> > > > The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> > > > to Delegate::DoWork in the following scenario:
> > > >
> > > > 1. Start a run loop and schedule DoWork.
> > > > 2. In DoWork, start a second run nested run loop which quits immediately.
> > > > 3. After the nested run loop quits, schedule another DoWork which quits the
> > > > original run loop.
> > > >
> > > > After step #3, the message pump would call DoWork again because the nested
> > > > run loop triggered the execution of the nesting deferred work source.
> > > >
> > > > This patch fixes the issue by checking whether the further work is allowed
> > > > before calling DoWork. Note that this check can't be done just for the nested
> > > > deferred work source, because in the flow above that source is what triggers
> > > > the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
> > > >
> > > > The patch also includes a fix to
> > > > WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> > > > following sequence in it (while a select menu is open):
> > > >
> > > > 1. Quit an outer run loop.
> > > > 2. Post a task onto an inner run loop to continue the test.
> > > >
> > > > The assumption here was that a select menu causes an inner run loop to
> > > > be active while the menu is open. This wasn't strictly correct: the
> > > > inner run loop is a native (CoreFoundation) run loop as opposed to a
> > > > base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> > > > This means that the Quit() in step #1 affects the same run loop as the
> > > > PostTask in step #2, i.e., the task is prevented from running.
> > > >
> > > > This patch changes the test to only quit the test run loop after the
> > > > posted task (which closes the select menu) has run.
> > > >
> > > > Bug: 891670
> > > > Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> > > > Reviewed-by: Mark Mentovai <[email protected]>
> > > > Commit-Queue: Sami Kyöstilä <[email protected]>
> > > > Cr-Commit-Position: refs/heads/master@{#615967}
> > >
> > > [email protected],[email protected]
> > >
> > > Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 891670
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1375382
> > > Reviewed-by: Elly Fong-Jones <[email protected]>
> > > Commit-Queue: Elly Fong-Jones <[email protected]>
> > > Cr-Commit-Position: refs/heads/master@{#616297}
> >
> > [email protected],[email protected],[email protected]
> >
> > Change-Id: I68d7b4687fd1f2a4906961f55b31038199089ff3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 891670
> > Reviewed-on: https://chromium-review.googlesource.com/c/1376249
> > Reviewed-by: Elly Fong-Jones <[email protected]>
> > Commit-Queue: Elly Fong-Jones <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616350}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: Ia05259cd2f2d60b41efdc7b73702da865680c1a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891670
> Reviewed-on: https://chromium-review.googlesource.com/c/1376250
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Commit-Queue: Elly Fong-Jones <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616352}
[email protected],[email protected],[email protected]
Change-Id: Ife24296aec35ef48231e2ae9f632898de8085d64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/1376734
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616421}Android: Remove sdk and sdk_path options
Since we are not building with Android Studio, using its sdk rather than
the checked-in one at //third_party/android_tools/sdk greatly improves
the editing experience and reduces issues using newer version of Android
Studio.
We no longer test with any --sdk-path or --sdk other than the default,
so rather than leaving the option untested, explicitly remove it.
Bug: 620034
Change-Id: I610a3d971168039ce40c6aef2f4e50cc4303f8aa
Reviewed-on: https://chromium-review.googlesource.com/c/1376649
Commit-Queue: Peter Wen <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616420}Consolidate use of LocalizedString and AddLocalizedStringsBulk in WebUI.
Change-Id: I02060210f0253fb64e2ec6488662c224841c2133
Reviewed-on: https://chromium-review.googlesource.com/c/1374406
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616419}Add support for weighted training examples.
TrainingData now supports an optional size_t count for each example
that's added to it, that represents the number of times this
example is in the set.
RandomForest and RandomTree support weighted examples. RandomForest
uses an approximate bagging method.
Change-Id: I054583a5aef54707880aea23a3f4d153502c3c07
Reviewed-on: https://chromium-review.googlesource.com/c/1362215
Commit-Queue: Frank Liberato <[email protected]>
Reviewed-by: Fredrik Hubinette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616418}Reland "Reland "allocator: Add Windows _aligned_* shims""
This is a reland of 7eae85ba6448aa3cf1e14d6557e1f77a86c7e49f. The original
revert picked the wrong CL, the windows ASan build doesn't use the
allocator shims, instead it appears that the build failure was actually due
to a VS toolchain update as noted in https://crbug.com/914947
Original change's description:
> Reland "allocator: Add Windows _aligned_* shims"
>
> This is a reland of 0ba5ea124ec9de7d786cf6f4fc4ab2847c8d785e with a
> missing #if DCHECK_IS_ON() added.
>
> Original change's description:
> > allocator: Add Windows _aligned_* shims
> >
> > On Windows we don’t currently hook the _aligned_* allocation APIs, this
> > can cause issues because _aligned_realloc can call HeapSize and cause
> > GWP-ASan crashes similar to bug 909720. Unfortunately the
> > _aligned_realloc API is different enough that it can not be implemented
> > using the standard POSIX shims, in particular because _aligned_malloc
> > and _aligned_free don't return valid allocation addresses, they are
> > offsets into allocations.
> >
> > I add new Windows platform-specific shims for _aligned_malloc,
> > _aligned_realloc, and _aligned_free and wire them in for all users of
> > the allocator shims. I implement these routines on top of the Windows
> > Heap* API and leave uncommon _aligned_* shims to crash to ensure that
> > any future uses immediately surface why their use fails.
> >
> > Bug: 912500, 896019
> > Change-Id: Ieaa50b816ab277a6ad4b80ee8519027343fa9878
> > Reviewed-on: https://chromium-review.googlesource.com/c/1367485
> > Reviewed-by: danakj <[email protected]>
> > Reviewed-by: Vitaly Buka <[email protected]>
> > Reviewed-by: Alexei Filippov <[email protected]>
> > Reviewed-by: Erik Chen <[email protected]>
> > Reviewed-by: Will Harris <[email protected]>
> > Reviewed-by: Sigurður Ásgeirsson <[email protected]>
> > Commit-Queue: Vlad Tsyrklevich <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616106}
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
>
> Bug: 912500, 896019
> Change-Id: I05aeb4bc9ef2974f967a81c53cb7bbbcc6e955f3
> Reviewed-on: https://chromium-review.googlesource.com/c/1374959
> Reviewed-by: Vlad Tsyrklevich <[email protected]>
> Commit-Queue: Vlad Tsyrklevich <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616171}
[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 912500, 896019
Change-Id: Ia832ac212e91d328121b260b0f597fc002ccc3f5
Reviewed-on: https://chromium-review.googlesource.com/c/1376032
Commit-Queue: Vlad Tsyrklevich <[email protected]>
Reviewed-by: Vitaly Buka <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616417}overview: Hide windows before minimizing.
It seems for arc apps this is needed, otherwise the minimize animation
will still play. Its also what HomeLauncherGestureHandler does.
Test: manual
Bug: 904134
Change-Id: Idaed19ed11fe9b15ed2d9aa1e461017503bd6149
Reviewed-on: https://chromium-review.googlesource.com/c/1376711
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616416}Updated SQLite LPM Fuzzer
Fixed two bugs (missed the word "FROM" in SELECT statements, which
stops the fuzzer from doing much of anything in SELECT, and one
incorrect type name). Also added NumericLiteral to LiteralValue,
so we can hit code handling floating point numbers.
Bug: 909886
Change-Id: I5d5825bd7b4e0277beb6e47d58b09d0fb12eeece
Reviewed-on: https://chromium-review.googlesource.com/c/1374913
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: Jonathan Metzman <[email protected]>
Commit-Queue: Matthew Denton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616415}diagnose_bloat.py: Stop on first build failure when building <= 2 builds
Change-Id: I1af7e15a66ce362eb8841f44e5739692cf8ec7c4
Reviewed-on: https://chromium-review.googlesource.com/c/1375389
Reviewed-by: Eric Stevenson <[email protected]>
Commit-Queue: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616414}[Sync::USS] Check all bookmarks are tracked before/after local deletions
We are receiving some unexpected crashes that suggest that some bookmark
nodes are not tracked.
The CL is introducing CHECKs before and after processing local deletions
that all syncable bookmark nodes are tracked.
After the root cause if uncovered, those CHECKs should be converted to
DCHECKs.
Bug: 516866
Change-Id: I19d9f2dbf7f49d1099f7f19bb6524e8727f1e6ac
Reviewed-on: https://chromium-review.googlesource.com/c/1375889
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616413}Settings edit dictionary page: Set dom-ifs before adding to word list
In Polymer 2, elements behind dom-ifs that are false no longer update,
so tabindex was not being set correctly for the first item added to the
list if the list had previously been emptied.
To fix this, ensure the dom-if is always set to true before adding new
items, and always set to false only after all items have been removed
from the list. This is done by making hasWords_ a property that is
updated manually, rather than a function that depends on words_.length.
Bug: 912523
Change-Id: I6afcd1a4c9c80fc0a122133fad3c825a4060b714
Reviewed-on: https://chromium-review.googlesource.com/c/1374493
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616412}Omnibox Cross-platform UI: Clean extra LocationBarModelDelegate methods.
Eliminates:
1. LocationBarModelDelegate::FailsMalwareCheck
2. LocationBarModelDelegate::FailsBillingCheck
Now that we have a general-purpose
LocationBarModelDelegate::GetSecurityInfo, we don't need more the more
specific methods.
This is generally a good thing, as the delegate should be limited only
to the code that you need the embedder to execute.
Any logic that can live in the LocationBarModel should not live in
LocationBarModelDelegate.
This CL does change the behavior slightly for
LocationBarModelDelegateIOS. Previously, FailsBillingCheck was always
false on iOS. Now, it's possible for us to display the empty string
for FailsBillingCheck if the status is MALICIOUS_CONTENT_STATUS_BILLING.
That being said, it appears that it's the BillingInterstitial is always
disabled on iOS anyways.
Bug: 912722
Change-Id: I6f17c385360f1f82f9ce1f2214b5fb919f0b4d72
Reviewed-on: https://chromium-review.googlesource.com/c/1369643
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616411}Use dedicated service account for code coverage builders.
[email protected]
BUG=914551
Change-Id: I33b44f9e79b906de31f4dc263f422c4140eaf903
Reviewed-on: https://chromium-review.googlesource.com/c/1375029
Reviewed-by: Roberto Carrillo <[email protected]>
Commit-Queue: Roberto Carrillo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616410}[Sync::USS] Check all bookmarks are tracked before/after remote updates
We are receiving some unexpected crashes that suggest that some bookmark
nodes are not tracked.
The CL is introducing CHECKs before and after processing remote updates
that all syncable bookmark nodes are tracked.
After the root cause if uncovered, those CHECKs should be converted to
DCHECKs.
Bug: 516866
Change-Id: Ieae3bbfcbd09f70fd4690be4cb2ce2601dac989a
Reviewed-on: https://chromium-review.googlesource.com/c/1375668
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616409}[CrOS MultiDevice] Move SecureMessageDelegate et. al to MultiDevice.
This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.
See go/multidevice-directory-structure-cleanup for details.
[email protected]
Bug: 912743
Change-Id: I14fe432d62e86219227554b4e454a975f2859e84
Reviewed-on: https://chromium-review.googlesource.com/c/1375370
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616408}Fix internal Previews URLs being shown in Omnibox Suggestions
The Previews team is rolling out a new feature that makes heavy use of
virtual URLs. In this case, the loaded URL contains a large hash and is
honestly ugly and should not be shown to the user. There are several
separate avenues that have been found to leak this URL into the History
DB where it then populates into Omnibox Suggestions. These are addressed
in three ways:
* Checking the URL in CanAddURLToHistory
* Using the virtual URL in top sites
* Clearing the redirect chain on applicable navigations
Please let me know if this would be better as separate CLs. This is
wrapped up into one because this will need to be merged into the M72
branch.
Bug: 914404
Change-Id: I91cd34a0077bbf1baae9a37a10e0e3ad526e7a0a
Reviewed-on: https://chromium-review.googlesource.com/c/1374205
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616407}Reland "pdf: Introduce content controller abstraction"
This is a reland of 6b4d81b2d610bba6e691389b2ef771db17c40498
Original change's description:
> pdf: Introduce content controller abstraction
>
> Primary motivation is to enable the plugin to be swapped out for the
> Ink-based PDF renderer in annotation mode.
>
> * An abstract `ContentController` class is added. This abstracts the
> logic that pdf_viewer used to communicate with the plugin so that
> the Ink component can replace it. Most plugin logic has been moved
> to `PluginController`, this also required adding many new APIs to
> `PDFViewer` to allow messages from the plugin to behave as before
> without exposing too much of `PDFViewer` private details. There are
> still some uses of `plugin.postMessage` that can be converted to
> `ContentController` APIs in future.
> * The PDF saving logic has been slightly rewritten using promises.
> Instead of storing only tokens, at save-request time a promise
> is created and associated with the token. When the save data
> becomes available (or is consumed) the promise is resolved.
>
> Bug: 902646
> Change-Id: Ic33b7c250eb54515564a3646283e3897419984af
> Reviewed-on: https://chromium-review.googlesource.com/c/1368845
> Commit-Queue: dstockwell <[email protected]>
> Reviewed-by: Henrique Nakashima <[email protected]>
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615028}
Bug: 902646,914596
Change-Id: I73e6dcc1b077ef824232ddb2817dee1dd4bc6429
Reviewed-on: https://chromium-review.googlesource.com/c/1375295
Reviewed-by: Henrique Nakashima <[email protected]>
Commit-Queue: dstockwell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616406}sheriff: mark some layout tests as maybe-timeout under MSAN
These tests are actually just slow under MSAN, but the expectation file
doesn't allow listing tests as slow only in specific configurations.
Bug: 914900
Change-Id: I511463d0983d875ff20786309b3453ad56d7da9c
Reviewed-on: https://chromium-review.googlesource.com/c/1376413
Reviewed-by: Wez <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616405}Add password change flow for when user changes their Gaia password.
The UI flow for GCPW is now as follows:
- "Reauth" is enabled for all gaia associated users
- After the user has signed in through gaia, if their gaia password does
not match their windows password, they will be asked to provide their
current windows password so that it can be changed to match the gaia
password.
- The same flow is applied to both logon types (reauth and add person)
- Removed a lot of code that is unnecssary for reauth calculation
- Refactored the flow of code so that WaitForLoginUI only returns the
authentication information gather through the GLS. This information
is passed onto OnUserAuthenticated to further process Windows specific
information used for logon.
Bug: 914924
Change-Id: I8103bb62620df7322089db734c5e177f0b59dd71
Reviewed-on: https://chromium-review.googlesource.com/c/1363908
Commit-Queue: Tien Mai <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616404}Fix viz features clusterfuzz issue
Viz features can call command line to look up switches, but this lead to
a clusterfuzz failure when command line is not initialized. This patch
fixes that issue.
Bug: 914255
Change-Id: I5d20d8dca7e331abc8db880cac0982cfc4d4432c
Reviewed-on: https://chromium-review.googlesource.com/c/1374112
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Commit-Queue: Xianda Sun <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616403}RandomForest trainer and model.
Change-Id: I40f8e2dbfa1b663f045460e49dfe457a382777ab
Reviewed-on: https://chromium-review.googlesource.com/c/1327604
Commit-Queue: Frank Liberato <[email protected]>
Reviewed-by: Fredrik Hubinette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616402}Roll src/third_party/ffmpeg/ 81f7d1dd5..0f7a61375 (7 commits)
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/81f7d1dd5fa4..0f7a61375b11
$ git log 81f7d1dd5..0f7a61375 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 thakis Suppress -Wstring-plus-int for ffmpeg.
2018-12-12 chcunningham lavf/mov: ensure only one tkhd per trak
2018-12-10 chcunningham lavf/mov: stop reading trun if fragment and stream index get out of sync
2018-11-29 liberato Use chromium's nasm.
2018-11-28 liberato local_asan_directory => relative...
2018-11-19 dalecurtis Fix find_patches.py to use long rev for blame, strip, and warn.
2018-10-15 liberato Make user instructions more visible.
Created with:
roll-dep src/third_party/ffmpeg
Bug: none
Change-Id: I0b036d0f038bc50265f2fdb90f191c6d25cef79a
Reviewed-on: https://chromium-review.googlesource.com/c/1376411
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616401}[ChromeDriver] Fixes for pause actions
Fix a bug in the processing of pause subtype of key actions, as reported
by [email protected]. Also factor out code that processes pause
actions to ensure consistency.
Bug: chromedriver:1897
Change-Id: I68af8f7025dc344683554f9954576a0ac568e4d7
Reviewed-on: https://chromium-review.googlesource.com/c/1376108
Reviewed-by: Lan Wei <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616400}[Sync::USS] Check the invariant: all syncable bookmark nodes are tracked
We are receiving some unexpected crashes that suggest that some bookmark
nodes are not tracked.
In order to narrow down the search space for the problem, this CL
introduces a code that check the invariant that all syncable nodes
are tracked and CHECKs that in the reasonable points in the life time
of the code.
The plan is to keep introducing those CHECKs in different spots in the
code until the root cause is found, after which all CHECKs should be
converted to DCHECKs.
Bug: 516866
Change-Id: I238d652b04c6121f17090a3b84401d2d84ef7216
Reviewed-on: https://chromium-review.googlesource.com/c/1375738
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616399}Add quota usage details tests for all other storage backends.
IndexedDB test was included in parent CL.
Bug: 904000
Test:
Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292
Reviewed-on: https://chromium-review.googlesource.com/c/1334659
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Commit-Queue: Jarryd Goodman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616398}DNR: Don't log EvaluateRequestTime.AllExtensions w/o any active rulesets.
This CL deprecates
Extensions.DeclarativeNetRequest.EvaluateRequestTime.AllExtensions2 and
introduces a new histogram in its place. Now it is no longer logged when there
are no active rulesets.
BUG=696822
Change-Id: I86894015c176a738881724893cef1f7204aa8466
Reviewed-on: https://chromium-review.googlesource.com/c/1372418
Reviewed-by: Istiaque Ahmed <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616397}Roll Fuchsia SDK from 438fd9563caa to dfca5b235ea8
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
[email protected]
Change-Id: I5ec5441075eab6e1cc05015b924edcc4d8e051e1
Reviewed-on: https://chromium-review.googlesource.com/c/1376272
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616396}[WebView Support Library] suppress lint warning
No change to logic.
This suppresses a lint warning (BanTargetApiAnnotation) which is
enforced in the AndroidX checkout (but not in Chromium). This is
required because this file is mirrored into AndroidX.
The intended resolution for this lint warning is to switch from
@TargetApi to @RequiresApi (which is not 1:1 compatible, but is
generally clearer). This is not currently possible in chromium, because
our lint doesn't seem to respect @RequiresApi like the AndroidX lint
config does.
[email protected], [email protected]
Bug: http://b/120770118
Test: Manually copied into AndroidX checkout and ran "./gradlew
Test: lintMinDVD" (with http://aosp/848808)
Change-Id: Iad8574bf3fefa0ab0181b5618eb8a31f4b9ed182
Reviewed-on: https://chromium-review.googlesource.com/c/1374911
Reviewed-by: Peter Wen <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616395}File Inputs: Don't generate change events when 'files' is set
The <input type=file> element generates "change" events when the user
interacts with the control to select files, exposed as the 'files'
property (a FileList). This property can be assigned to by script, and
should not generate a "change" event in such a case. It was
erroneously doing so, so fix it.
Bug: 792336
Change-Id: Iaa4297332e9c048daf7142aef3797fb59b0d5bcf
Reviewed-on: https://chromium-review.googlesource.com/c/1374791
Commit-Queue: Joshua Bell <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616394}tab dragging: merge into a minimized overview window.
Currently dragged tab(s) can't be merged into a browser window if it's
minimized and currently showing in overview, this CL makes the dragged
tab(s) be able to merge into such window.
Bug: 911306
Change-Id: I82f76bd0dbd96771216d80ad109491a28d3cfb46
Reviewed-on: https://chromium-review.googlesource.com/c/1362461
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Jun Mukai <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616393}Remove unsupported languages from Accept-Languages
This removes all unsupported languages from Accept-Languages when
the last supported language of the same family is removed.
Bug: 784740
Change-Id: I6c6c49787a2252799cf5b5103ce5b9ef0bb86093
Reviewed-on: https://chromium-review.googlesource.com/c/1363635
Commit-Queue: anthonyvd <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616392}Lock the mouse for pepper plugins via their frame.
Currently it always goes to the RenderWidget attached to the RenderView
however for an OOPIF that RenderWidget is frozen and should not be used
and in the future will not exist. Instead lock through the RenderWidget
for its local root.
[email protected], [email protected]
Change-Id: I0cf827ece3b2d6da94ee8e2046e79d90ce2950de
Bug: 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1374950
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Albert J. Wong <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616391}Correctly respect incognito mode for memlog.
A previous iteration of this code checked for the existence of an incognito
profile. That was incorrect, as it's possible for an incognito profile to exist
but not be used. This code now checks that there's a window associated with an
incognito profile.
Bug: 785068
Change-Id: I4e1550127bf2031fc6ffea1b3c59a1ec8b61a06b
Reviewed-on: https://chromium-review.googlesource.com/c/1374790
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616390}[AdTagging] Reduce rate of performance measurements in dry run
Bug: 914866
Change-Id: Icb0de875a9cb04ae6e5f671ab0069e6bd390d089
Reviewed-on: https://chromium-review.googlesource.com/c/1376098
Reviewed-by: Charlie Harrison <[email protected]>
Commit-Queue: Josh Karlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616389}cros: Strongly type int32_t types int fingerprint.mojom
Bug: 897226
Change-Id: I4a6baad5b39a76eb2e82d8e351ea8dfbd0f53438
Reviewed-on: https://chromium-review.googlesource.com/c/1292269
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616388}Navigation prediction: Enable on cell networks
This is behind a finch experiment.
Change-Id: Ib4704dcc74a4f8d8880264e486efdc4e3acd0216
Bug: 914503
Reviewed-on: https://chromium-review.googlesource.com/c/1350210
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Egor Pasko <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616387}Only copy the Elevation Service executable for Google Chrome builds.
BUG=180589,833687
Change-Id: I4af08c2124ea8857f2ad860c268913b87297da7a
Reviewed-on: https://chromium-review.googlesource.com/c/1373131
Reviewed-by: Sorin Jianu <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: S. Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616386}Enable InputDeviceEventObserver to receive batched updates.
On Android, we had a single system call forking into three different
InputDeviceEventObserver calls, which resulted in redundant updates in
InputDeviceChangeObserver. Batching multiple device updates into one avoids the
redundancy.
Bug: 904535
Change-Id: I04a56db23553ae2d1cbe97fffd97d03189665187
Reviewed-on: https://chromium-review.googlesource.com/c/1363636
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616385}[Cronet] Add documentation on runing native tests.
As part of this, refactor the checkout and build from the Android docs into
a common doc referenced by both Android and native.
Bug: 786559
Change-Id: Ibc6ebb299d878cd27c2d88af2d6366bf5b0aa5ce
Reviewed-on: https://chromium-review.googlesource.com/c/1363439
Commit-Queue: Caleb Raitto <[email protected]>
Reviewed-by: Paul Jensen <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616384}[CrOS MultiDevice] Move appropriate CryptAuth files to SecureChannel.
This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.
See go/multidevice-directory-structure-cleanup for details.
Bug: 912743
Change-Id: Ica14efe50b0c0c3ca85802fe969afff7e7d26f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1372052
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616383}Don't support completion query without fence support
This is copy-paste from GLES2Decoder
Bug: 914718
Change-Id: Ib451762b078c0a9552d22d33489b04c86abe5e70
Reviewed-on: https://chromium-review.googlesource.com/c/1376096
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616382}WindowService: makes SetWindowVisibility() return false on failure
In particular, ash has WindowObservers that override OnWindowVisibilityChanged()
and force the window visibility back to what it was. This patch makes the
WindowService deal with this.
BUG=910241
TEST=covered by tests
Change-Id: I4fcd26cd8283aa38ee157f0d9c7831af68e867db
Reviewed-on: https://chromium-review.googlesource.com/c/1375993
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616381}Implement bidi caret affinity basics
Design doc: http://bit.ly/2xVMjdc
This patch implements the basics of bidi caret affinity (*):
- Adds a runtime flag for bidi caret affinity
- Stop running bidi adjustments at the current sites:
- ComputeInlineBoxPosition/ComputeNGCaretPosition
- PositionForPoint
- SelectionController when setting range selection
- Make affinity adjustment in VisiblePosition constructor aware
of bidi affinity, so that it doesn't adjust affinity at bidi
boundaries
This patch removes the mismatching between visual and logical caret
positions.
(*) This is the same as described in Stage 1, steps 1 & 2 of the
implementation plan in the design doc.
Bug: 894651
Change-Id: If96a19c8b2d3f12bfdfee326f7d9b91aa350c2cc
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1292809
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616380}Refactor: Reformat background_scheduler to make functions more clearly part of namespace
They previously looked a bit like class member functions, so I was hoping this change could make this more clear.
Bug: 896479
Change-Id: I797008b96cdfe9c97f72d5818d1c2acd7c57d341
Reviewed-on: https://chromium-review.googlesource.com/c/1374694
Reviewed-by: Victor Costan <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Darwin Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616379}[autofill] Add fieldtrial config for AutofillMetadataUploads
Bug: 850606
Change-Id: Ida2508bd9fbab8f0b2ae88788272f5a10bf240a0
Reviewed-on: https://chromium-review.googlesource.com/c/1374769
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616378}Replace OfflineClock()->Now() with OfflineTimeNow()
This change is for consistency, and simplicity: most code doesn't need to access
OfflineClock() for more than the current time.
Bug: 906903
Change-Id: I34597e40c8e3a0d450867beb19ce602b8afd7d72
Reviewed-on: https://chromium-review.googlesource.com/c/1372270
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616377}Revert "[BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy"
This reverts commit 2dc0883db6f448313cddf6b925e02ba1ced06020.
Reason for revert: Flaky tests. See crbug.com/914657
Original change's description:
> [BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy
>
> This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it
> can point to a different URL than the one IE uses.
>
> Bug: 846316
> Change-Id: I52f91019aabcdd9b20163198195770fb52183e98
> Reviewed-on: https://chromium-review.googlesource.com/c/1361327
> Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
> Reviewed-by: Ramin Halavati <[email protected]>
> Reviewed-by: Julian Pastarmov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616039}
[email protected],[email protected],[email protected]
Change-Id: Ic9185269f075ca32e07c29baddc41cde9dadb452
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846316
Reviewed-on: https://chromium-review.googlesource.com/c/1376097
Reviewed-by: Hongchan Choi <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616376}Revert "wm: Update nested activation handling"
This reverts commit ecde845099001740fee119a82d45664e622d0ade.
Reason for revert:
EXPECT_DEATH_IF_SUPPORTED not working in NDEBUG without DCHECK.
Original change's description:
> wm: Update nested activation handling
>
> - NOTREACHED() and no-ope if the nested activation wants to change
> to a different active window other than the one being activated;
> - Allow focus shift in nested activations as long as they don't
> change the window to be activated
>
> Bug: 908524
> Test: FocusControllerApiTest.ActivateWhileActivating
> Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642
> Reviewed-on: https://chromium-review.googlesource.com/c/1357017
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616346}
[email protected],[email protected],[email protected]
Change-Id: I8fd73d291c7a6774b1f48049d618a232340e936e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908524
Reviewed-on: https://chromium-review.googlesource.com/c/1376137
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616375}[Fuchsia] Add a chromium.cast.ApplicationConfigManager interface.
This interface allows the Cast per-application configuration logic to be
isolated from the application-hosting logic in the Runner. The current
implementation of this interface is a stub in the app_config_manager
service.
In addition, this Cl adds a test-only implementation of this interface
directing cast requests to an embedded test server.
Bug: 901964
Change-Id: Ib635b3229eacab21bc4e307269a563ced26efc26
Reviewed-on: https://chromium-review.googlesource.com/c/1332713
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Reviewed-by: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616374}Stub Viz hit testing out of RenderWidgetHostInputEventRouterTest
We stubbed out the old hit testing path entirely so we could have
explicit control over the hit test results as the hit testing
implementation is irrelevant to the logic we want to test here.
When these tests were initially updated to work with Viz hit
testing, only the hit test data was stubbed out, not the hit testing
itself. This makes it necessary to understand the implementation of
Viz hit testing in order to construct the artificial hit test data
to have the hit testing produce the desired target.
We now stub out the Viz hit testing logic and just supply the desired
target.
Bug: 828422
Change-Id: Ib2ce7fd8a8e9c3236cf7c2d387bb241eb4771264
Reviewed-on: https://chromium-review.googlesource.com/c/1368463
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616373}MacPWAs: Detect when app shim fails to launch
Add a callback argument to web_app::MaybeLaunchShortcut which returns
the base::Process that was spawned.
Use this to close an AppShimHost if the shim process fails to launch.
If we do not close the AppShimHost, then the corresponding browser
windows will remain in a zombie state forever.
Subsequent patches will be adding more arguments to
web_app::MaybeLaunchShortcut to accommodate signing.
Bug: 913394
Change-Id: I645ef1dfd620b67e4af89ced999912b1391f02ca
Reviewed-on: https://chromium-review.googlesource.com/c/1373934
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: ccameron <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616372}Add XR JavaScript session logging
Adds logging to the WebXR JavaScript boilerplate used for WebXR browser
and instrumentation tests whenever a session request is attempted,
succeeds, or fails. Failure to get sessions is one of the more common
flake causes, so this will help give an initial idea of whether the
failures are due to the promise being rejected or something in the
implementation hanging.
Bug: 914589
Change-Id: Ibbd0aa7890638d6da8ac9037f4740516c74ab271
Reviewed-on: https://chromium-review.googlesource.com/c/1375394
Reviewed-by: Bill Orr <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616371}[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in gcm_driver
MessageLoop will go away, eventually.
BUG=891670
Change-Id: I345dbfa25629300eae218202d63d0ec666a252d5
Reviewed-on: https://chromium-review.googlesource.com/c/1352366
Reviewed-by: Jian Li <[email protected]>
Commit-Queue: Carlos Caballero <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616370}chromeos: adds ability for AshTestHelper to create MusClient
This is useful for tests targetting single-process-mash. This also
exposes a function on AshTestBase to create MusClient, which is useful
for tests outside of ash that still use AshTestBase. The later is needed
to ensure unit_tests work with SingleProcessMash.
BUG=910241
TEST=test only changes
Change-Id: I97d095b55eba1ba0f19fa59358a999436fd9dc73
Reviewed-on: https://chromium-review.googlesource.com/c/1375454
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616369}cros: Fix menu anchor bounds in RTL
Menu anchor bounds should be mirrored in RTL.
Bug: 909672
Change-Id: I3c0895087b08bbfb7baa93787f3ea77411160817
Reviewed-on: https://chromium-review.googlesource.com/c/1368777
Reviewed-by: Manu Cornet <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616368}Android: Ensure manifest contains proper library name for bundles.
BUG=874584
Android: Enable bundle-specific native libraries
This change changes bundle builds to use _base.so native libraries
(libchrome_base.so or libmonochrome_base.so). The required conditionals
already exist in build configurations - this change simply enables them.
A separate change has already been made to ensure official builders
upload symbols (for crashpad and for archiving).
BUG=874584
Change-Id: I65979e7cf6ce59ec841851136143c138b8acfaf6
Reviewed-on: https://chromium-review.googlesource.com/c/1374734
Reviewed-by: agrieve <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Christopher Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616367}Reenable ThreadLocalStorageTest.TLSDestructors
This test was disabled on debug incremental x64 builds due to a VS
incremental linker bug. We don't use VS's linker (and we don't have
incremental linking) so this bug is now irrelevant.
Bug: 251251
Change-Id: I2c36ffeb61ca41dd57860007edfda4978e004272
Reviewed-on: https://chromium-review.googlesource.com/c/1375429
Reviewed-by: kylechar <[email protected]>
Commit-Queue: Bruce Dawson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616366}Add src-side stuff for new ToTLinuxTSan bot.
TBR=hans
Bug: 913704
Change-Id: I924d54649f8d95ea0880e5273e4f7f1d11b4e7da
Reviewed-on: https://chromium-review.googlesource.com/c/1375435
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616365}Don't use MultiBufferDataSource for data:// URLs.
Using the network based path just increases memory usage and causes
worse performance since all reads are asynchronous. It also seems like
data:// URLs don't support range requests, so each read pulls in the
entire data stream again and again.
I'm not sure if data:// URLs not supporting range requests is a new
thing, or if they should be supporting this. Will ask loading team.
It's also unclear why MultiBuffer is breaking in this case, it's not
efficient, but it shouldn't be broken, so there's still some minor
investigation left to do there.
BUG=913681
TEST=linked bug plays correctly.
Change-Id: I3183ca0c5d8f3ecf09304cdcd1c77e55825a98d6
Reviewed-on: https://chromium-review.googlesource.com/c/1373020
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616364}wm: Fix bug with artificats when using WindowPreviewView.
These artificats were caused by some transient children which whose
bounds were placed outside of screen when minimized. These children
such as StatusBubble are really small and users of WindowPreviewView
are usually even smaller than normal window bounds, so just exclude them.
Also fix a bug with transient windows transforms not reset in
homeLauncherGestureHandler, it was contributing to these artificats too.
Test: manual
Bug: 844829
Change-Id: Ica69b195dfeb988c75f7b04649d60afe02c6b5bf
Reviewed-on: https://chromium-review.googlesource.com/c/1371067
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616363}Make TimeTicks::FromUptimeMillis available in ChromeOS builds of Chrome
This is necessary for https://chromium-review.googlesource.com/c/chromium/src/+/1362493
Bug: b:62353695
Change-Id: I690c7b55de1da52fac53b27681110cb873569ef7
Reviewed-on: https://chromium-review.googlesource.com/c/1374773
Reviewed-by: Christopher Morin <[email protected]>
Reviewed-by: Egor Pasko <[email protected]>
Reviewed-by: agrieve <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Willie Koomson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616362}Ensure subframe timings aren't included in FCP++ metrics.
This test ensures that no merging of FCP++ timings is done by the
PageLoadMetricsUpdateDispatcher.
This follows https://chromium-review.googlesource.com/c/chromium/src/+/1334944,
which introduced a bug that merged FCP++ timings from subframes. That CL
has since been reverted. This test ensures we won't regress again.
Change-Id: Idbafb732e16f044301cb3f2cb2ab014bae0d9089
Reviewed-on: https://chromium-review.googlesource.com/c/1354271
Reviewed-by: Timothy Dresser <[email protected]>
Commit-Queue: Bryan McQuade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616361}[DevTools] Audits: Update interface for setting Lighthouse flags
Bug: 914387
Change-Id: Ice3e79cc8527d687ffdfe87a22ddf8a459230ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1374196
Reviewed-by: Paul Irish <[email protected]>
Reviewed-by: Erik Luo <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616360}Revert "Speculative fixes for flakey ChromeVox tests using waitForCalm"
This reverts commit a164e645314a667c915ec6daefc7de162a6a6a08.
Reason for revert: <INSERT REASONING HERE>
Still flakes.
Original change's description:
> Speculative fixes for flakey ChromeVox tests using waitForCalm
>
> Bug: 622387
> Change-Id: Idddd32bf271f28fb5d22cbef54b4250e636e2f6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1372312
> Commit-Queue: Dominic Mazzoni <[email protected]>
> Reviewed-by: Dominic Mazzoni <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615963}
[email protected],[email protected]
Change-Id: I676dbeca80230947b717b2713413dfb7800c4401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 622387
Reviewed-on: https://chromium-review.googlesource.com/c/1376106
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616359}Fix memory leaks in FaceDetector and TextDetector on Windows
This code was previously using the ComPtr::GetAddressOf() method when
calling functions that output a COM object. This does not release its
reference to the object currently stored in the ComPtr. In at least one
instance, CreateWinBitmapWithPixelFormat(), this leads to a memory leak.
In other instances it is simply less readable than the alternative.
Bug: 914541
Change-Id: I3a18e2ffba4538926a915d64918b13483a4fb6a1
Reviewed-on: https://chromium-review.googlesource.com/c/1375111
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616358}[Chromecast] Clear the usage of VLOG in media/base folder.
-Replace VLOG(1) with LOG(INFO).
-Replace VLOG(2) with DVLOG.
BUG=internal b/73490388
Test=locally build.
Change-Id: I3d0659a1bd0e3297d48522f5cb73718e07a52bee
Reviewed-on: https://chromium-review.googlesource.com/c/1374968
Reviewed-by: Kenneth MacKay <[email protected]>
Commit-Queue: Ziyang Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616357}Pausable Object Cleanup - MediaDevices
Media devices are using the kMediaElementEvent task queue and this
task queue is already pausable so it isn't necessary that the object
implements pausing the tasks as well.
BUG=907125
Change-Id: I8ea61fad9fb85ec0b29009c5da527156773dbd01
Reviewed-on: https://chromium-review.googlesource.com/c/1372230
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616356}Remove PausableObjects from rtc peerconnection code.
RTCDataChannel used a timer to pause/resume. The timer is hooked up
to the kNetwork task queue which is the loading task queue.
Likewise the RTCPeerConnection object used a Async method runner which
wasn't necessary because it also uses the kNetwork task queue which
is pausable itself.
BUG=907125
Change-Id: I3cac8f9143aa4bfb7557f348cff052dc886b2c01
Reviewed-on: https://chromium-review.googlesource.com/c/1372224
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616355}Store account image in AccountInfo
In order to simplify the API of Identity Service, store
the account image into AccountInfo. The class gfx::Image
is a smart refcounted wrapper around the image data so it
is quite cheap to copy (though it is not thread-safe but
the class enforece this via DCHECK so incorrect use will
be caught by build with assertion checks enabled).
Bug: 914783
Change-Id: I75798e5ff95b2f300467391a4b354ba7256f39d0
Reviewed-on: https://chromium-review.googlesource.com/c/1375729
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616354}Fix threading and ordering issues for vibration effects
This CL addresses a threading issue where the vibration effect completion
callback was called on the polling thread instead of the thread that
requested the effect. Now a SequencedTaskRunner is passed along with the
callback to ensure the callback is run on the correct thread.
It also addresses an ordering issue when effects are queued using
Promises. Previously, if an effect completed successfully and triggered
another effect from its completion callback, the gamepad service would
still send a StopVibration command before starting the second effect. On
most gamepads, this is not noticeable due to the inertia of the vibration
actuator. However, on devices with more responsive actuators it may cause
short hiccups in vibration playback.
This CL fixes the ordering issue by scheduling a StopVibration task to
occur after all microtasks associated with the Promise callback are
completed. The scheduled task will only stop vibration if no other
vibration commands were sent to the actuator since the task was queued.
BUG=801717
Change-Id: I6507a409e6004bbe411210217b9873f29788ef7c
Reviewed-on: https://chromium-review.googlesource.com/c/1354483
Reviewed-by: Ovidio Henriquez <[email protected]>
Commit-Queue: Matt Reynolds <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616353}Revert "Reland "base: Don't keep running tasks after nested run loop quits on iOS""
This reverts commit 6a988bfbbdae7880bd3fba26f96c120600a76db5.
Reason for revert: should not have relanded
Original change's description:
> Reland "base: Don't keep running tasks after nested run loop quits on iOS"
>
> This reverts commit d0de086966fe7e05b6aa69d3ec69eedad2aa9e64.
>
> Reason for revert: broke ios-simulator bots
>
> Original change's description:
> > Revert "base: Don't keep running tasks after nested run loop quits on iOS"
> >
> > This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.
> >
> > Reason for revert:
> > Sheriff suspects this broke a handful of menu tests on macOS 10.12:
> >
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564
> >
> > e.g.:
> > WebViewTest.TestContextMenu
> >
> > Original change's description:
> > > base: Don't keep running tasks after nested run loop quits on iOS
> > >
> > > The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> > > to Delegate::DoWork in the following scenario:
> > >
> > > 1. Start a run loop and schedule DoWork.
> > > 2. In DoWork, start a second run nested run loop which quits immediately.
> > > 3. After the nested run loop quits, schedule another DoWork which quits the
> > > original run loop.
> > >
> > > After step #3, the message pump would call DoWork again because the nested
> > > run loop triggered the execution of the nesting deferred work source.
> > >
> > > This patch fixes the issue by checking whether the further work is allowed
> > > before calling DoWork. Note that this check can't be done just for the nested
> > > deferred work source, because in the flow above that source is what triggers
> > > the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
> > >
> > > The patch also includes a fix to
> > > WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> > > following sequence in it (while a select menu is open):
> > >
> > > 1. Quit an outer run loop.
> > > 2. Post a task onto an inner run loop to continue the test.
> > >
> > > The assumption here was that a select menu causes an inner run loop to
> > > be active while the menu is open. This wasn't strictly correct: the
> > > inner run loop is a native (CoreFoundation) run loop as opposed to a
> > > base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> > > This means that the Quit() in step #1 affects the same run loop as the
> > > PostTask in step #2, i.e., the task is prevented from running.
> > >
> > > This patch changes the test to only quit the test run loop after the
> > > posted task (which closes the select menu) has run.
> > >
> > > Bug: 891670
> > > Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> > > Reviewed-by: Mark Mentovai <[email protected]>
> > > Commit-Queue: Sami Kyöstilä <[email protected]>
> > > Cr-Commit-Position: refs/heads/master@{#615967}
> >
> > [email protected],[email protected]
> >
> > Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 891670
> > Reviewed-on: https://chromium-review.googlesource.com/c/1375382
> > Reviewed-by: Elly Fong-Jones <[email protected]>
> > Commit-Queue: Elly Fong-Jones <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616297}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: I68d7b4687fd1f2a4906961f55b31038199089ff3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891670
> Reviewed-on: https://chromium-review.googlesource.com/c/1376249
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Commit-Queue: Elly Fong-Jones <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616350}
[email protected],[email protected],[email protected]
Change-Id: Ia05259cd2f2d60b41efdc7b73702da865680c1a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/1376250
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616352}[AF] Adapt sync wallet bridge to the new wallet_metadata bridge
This CL makes the wallet_data bridge NOT write wallet metadata into the
DB if metadata is handled by the new USS bridge. This CL is part of a
new design for splitting responsibilities between the two bridges.
Bug: 853688
Change-Id: Ib9299af8c1440fbf911d2a9ebe3cfa069bc29853
Reviewed-on: https://chromium-review.googlesource.com/c/1375728
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616351}Reland "base: Don't keep running tasks after nested run loop quits on iOS"
This reverts commit d0de086966fe7e05b6aa69d3ec69eedad2aa9e64.
Reason for revert: broke ios-simulator bots
Original change's description:
> Revert "base: Don't keep running tasks after nested run loop quits on iOS"
>
> This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.
>
> Reason for revert:
> Sheriff suspects this broke a handful of menu tests on macOS 10.12:
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564
>
> e.g.:
> WebViewTest.TestContextMenu
>
> Original change's description:
> > base: Don't keep running tasks after nested run loop quits on iOS
> >
> > The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> > to Delegate::DoWork in the following scenario:
> >
> > 1. Start a run loop and schedule DoWork.
> > 2. In DoWork, start a second run nested run loop which quits immediately.
> > 3. After the nested run loop quits, schedule another DoWork which quits the
> > original run loop.
> >
> > After step #3, the message pump would call DoWork again because the nested
> > run loop triggered the execution of the nesting deferred work source.
> >
> > This patch fixes the issue by checking whether the further work is allowed
> > before calling DoWork. Note that this check can't be done just for the nested
> > deferred work source, because in the flow above that source is what triggers
> > the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
> >
> > The patch also includes a fix to
> > WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> > following sequence in it (while a select menu is open):
> >
> > 1. Quit an outer run loop.
> > 2. Post a task onto an inner run loop to continue the test.
> >
> > The assumption here was that a select menu causes an inner run loop to
> > be active while the menu is open. This wasn't strictly correct: the
> > inner run loop is a native (CoreFoundation) run loop as opposed to a
> > base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> > This means that the Quit() in step #1 affects the same run loop as the
> > PostTask in step #2, i.e., the task is prevented from running.
> >
> > This patch changes the test to only quit the test run loop after the
> > posted task (which closes the select menu) has run.
> >
> > Bug: 891670
> > Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> > Reviewed-by: Mark Mentovai <[email protected]>
> > Commit-Queue: Sami Kyöstilä <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#615967}
>
> [email protected],[email protected]
>
> Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891670
> Reviewed-on: https://chromium-review.googlesource.com/c/1375382
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Commit-Queue: Elly Fong-Jones <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616297}
[email protected],[email protected],[email protected]
Change-Id: I68d7b4687fd1f2a4906961f55b31038199089ff3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/1376249
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616350}Revert "Stop creating net::URLRequestContext in the browser process when network service is enabled."
This reverts commit 2864f69f22b4c9398a49f059b72b28f9bece8fc3.
Reason for revert: http://crbug.com/914724
Original change's description:
> Stop creating net::URLRequestContext in the browser process when network service is enabled.
>
> Bug: 837753
> Change-Id: I479666949f8c552e964ab86420ef080db9010d06
> Reviewed-on: https://chromium-review.googlesource.com/c/1367088
> Commit-Queue: John Abd-El-Malek <[email protected]>
> Reviewed-by: Matt Menke <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615995}
[email protected],[email protected]
Change-Id: I6506e560dea13058d0336e22c3fc4844ac57fa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837753, 914724
Reviewed-on: https://chromium-review.googlesource.com/c/1376101
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616349}Revert "[ios] Store TaskRunners instead of threads in WebThreadImpl."
This reverts commit 3d3f6bf113b71a9d0d2a259152581a5d65f76a22.
Reason for revert: This broke ios_chrome_unittest, more info in
crbug.com/914869
Original change's description:
> [ios] Store TaskRunners instead of threads in WebThreadImpl.
>
> Track thread states explicitly instead of simply checking
> whether a TaskRunner pointer exists or not.
>
> BUG=826465
>
> Change-Id: Id0f84e7eedc6b9f6568aec629abbb86f46979efa
> Reviewed-on: https://chromium-review.googlesource.com/c/1340827
> Reviewed-by: Rohit Rao <[email protected]>
> Reviewed-by: Sylvain Defresne <[email protected]>
> Reviewed-by: Gabriel Charette <[email protected]>
> Commit-Queue: Rohit Rao <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616319}
[email protected],[email protected],[email protected]
Change-Id: I1297465d60f4b3b5a76882b5e723080c9376a7dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826465
Reviewed-on: https://chromium-review.googlesource.com/c/1375890
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616348}Make MediaStreamDispatcherHost per-request instead of per-frame.
Instead of having RenderFrameHost own a single MSDH to handle all
requests from a frame, MSDH objects will be owned by a strong binding.
A consequence of this is that an additional requester ID is added to
requests to MediaStreamManager, so that an MSDH is able to cancel only
requests generated by it.
In practice, MSDH will continue to be per frame in most cases since
each frame normally makes a single request for an MSDH object.
This fixes a lifetime issue caused by the IO thread executing tasks
after the RenderFrameHost dies.
Drive-by: Fix some minor lint issues.
Bug: 912520
Change-Id: I52742ffc98b9fc57ce8e6f5093a61aed86d3e516
Reviewed-on: https://chromium-review.googlesource.com/c/1369799
Reviewed-by: Emircan Uysaler <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616347}wm: Update nested activation handling
- NOTREACHED() and no-ope if the nested activation wants to change
to a different active window other than the one being activated;
- Allow focus shift in nested activations as long as they don't
change the window to be activated
Bug: 908524
Test: FocusControllerApiTest.ActivateWhileActivating
Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642
Reviewed-on: https://chromium-review.googlesource.com/c/1357017
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616346}macOS: Make cmd+<numkey> always trigger as a numerical key.
On all keyboards, treat cmd + <number key> as the equivalent numerical key. This
is technically incorrect, since the actual character produced may not be a
numerical key, but this causes Chrome to match the expectations of users.
This mostly reverts Chrome to its historical behavior [and to match Safari],
except for the Dvorak-Left and Dvorak-Right layouts, which used to have the
opposite behavior.
Bug: 898638
Change-Id: Ia011def220a0e6b90f080aa3259751949f3dfc5f
Reviewed-on: https://chromium-review.googlesource.com/c/1372349
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616345}[ios] Remove WKWebViewSnapshots experiment
WKWebViewSnapshots experiment is enabled so it can be removed.
Bug: 885003
Change-Id: Ieb3089daee53b336871558e3f71abb0a9b4fed05
Reviewed-on: https://chromium-review.googlesource.com/c/1375615
Reviewed-by: edchin <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616344}Return used width/height for SVG <image>, <rect> and <foreignObject>
Per https://drafts.csswg.org/cssom/#resolved-values we should return the
"used value" for 'width' and 'height' on these elements [1].
This behavior was clarified in SVGWG GitHub issue #349 [2].
[1] And also on <svg>, but we don't support those properties there yet.
Tests added for that case too though.
[2] https://github.com/w3c/svgwg/issues/349
Bug: 772707
Change-Id: Ic7b6b148883d4380daadb41b62bddd02da55e1af
Reviewed-on: https://chromium-review.googlesource.com/c/1374291
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616343}Fix UAP in ImageBitmapLoader/FileReaderLoader
FileReaderLoader stores its client as a raw pointer, so in cases like
ImageBitmapLoader where the FileReaderLoaderClient really is garbage
collected we have to make sure to destroy the FileReaderLoader when
the ExecutionContext that owns it is destroyed.
Bug: 913970
Change-Id: I40b02115367cf7bf5bbbbb8e9b57874d2510f861
Reviewed-on: https://chromium-review.googlesource.com/c/1374511
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616342}Roll src/third_party/skia 5eb29448dfbd..c9b7c720ddd3 (1 commits)
https://skia.googlesource.com/skia.git/+log/5eb29448dfbd..c9b7c720ddd3
git log 5eb29448dfbd..c9b7c720ddd3 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] two pass convexity
Created with:
gclient setdep -r src/third_party/skia@c9b7c720ddd3
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:899689
[email protected]
Change-Id: I929a1b8452168904aac183e687a3761f34361261
Reviewed-on: https://chromium-review.googlesource.com/c/1375354
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616341}Migrate autofill_credit_card_edit VC.
This CL migrates the AutofillCreditCardCollectionViewController from
CollectionViewController, which is based on MDCCollectionViewController,
to ChromeTableViewController, which is based on UITableViewController.
This CL doesn't introduce any UI change.
Bug: 894791
Change-Id: Id31f7639caf532367e1edc320f570572fcfb77a2
Reviewed-on: https://chromium-review.googlesource.com/c/1375709
Commit-Queue: Yi Su <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616340}Revert "base: Don't keep running tasks after nested run loop quits on iOS"
This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.
Reason for revert: After revert of crrev.com/c/1375382 test
MessageLoopTypedTest.QuitNow/default_pump_backend_SequenceManager started to fail
on ios-simulator. See crbug.com/914842
Original change's description:
> base: Don't keep running tasks after nested run loop quits on iOS
>
> The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> to Delegate::DoWork in the following scenario:
>
> 1. Start a run loop and schedule DoWork.
> 2. In DoWork, start a second run nested run loop which quits immediately.
> 3. After the nested run loop quits, schedule another DoWork which quits the
> original run loop.
>
> After step #3, the message pump would call DoWork again because the nested
> run loop triggered the execution of the nesting deferred work source.
>
> This patch fixes the issue by checking whether the further work is allowed
> before calling DoWork. Note that this check can't be done just for the nested
> deferred work source, because in the flow above that source is what triggers
> the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
>
> The patch also includes a fix to
> WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> following sequence in it (while a select menu is open):
>
> 1. Quit an outer run loop.
> 2. Post a task onto an inner run loop to continue the test.
>
> The assumption here was that a select menu causes an inner run loop to
> be active while the menu is open. This wasn't strictly correct: the
> inner run loop is a native (CoreFoundation) run loop as opposed to a
> base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> This means that the Quit() in step #1 affects the same run loop as the
> PostTask in step #2, i.e., the task is prevented from running.
>
> This patch changes the test to only quit the test run loop after the
> posted task (which closes the select menu) has run.
>
> Bug: 891670
> Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615967}
[email protected],[email protected]
Change-Id: Ia58acd52d4b147c38c1bbaa20b0d84f85dd65ca5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670, 914842
Reviewed-on: https://chromium-review.googlesource.com/c/1375953
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616339}Reland "base: Don't keep running tasks after nested run loop quits on iOS"
This is a reland of 3ce69a991fd9ca03030738e324a1833c02462da0
Relanding the original patch with fixes for two WebViewTest context
menu tests. They had exactly the same problem as
WebContentsViewMacInteractiveTest: posting a task and then immediately
quitting the same run loop.
[email protected]
Original change's description:
> base: Don't keep running tasks after nested run loop quits on iOS
>
> The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> to Delegate::DoWork in the following scenario:
>
> 1. Start a run loop and schedule DoWork.
> 2. In DoWork, start a second run nested run loop which quits immediately.
> 3. After the nested run loop quits, schedule another DoWork which quits the
> original run loop.
>
> After step #3, the message pump would call DoWork again because the nested
> run loop triggered the execution of the nesting deferred work source.
>
> This patch fixes the issue by checking whether the further work is allowed
> before calling DoWork. Note that this check can't be done just for the nested
> deferred work source, because in the flow above that source is what triggers
> the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
>
> The patch also includes a fix to
> WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> following sequence in it (while a select menu is open):
>
> 1. Quit an outer run loop.
> 2. Post a task onto an inner run loop to continue the test.
>
> The assumption here was that a select menu causes an inner run loop to
> be active while the menu is open. This wasn't strictly correct: the
> inner run loop is a native (CoreFoundation) run loop as opposed to a
> base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> This means that the Quit() in step #1 affects the same run loop as the
> PostTask in step #2, i.e., the task is prevented from running.
>
> This patch changes the test to only quit the test run loop after the
> posted task (which closes the select menu) has run.
>
> Bug: 891670
> Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615967}
Bug: 891670
Change-Id: I48a33231223b25f1d206db7e918492033d3bda13
Reviewed-on: https://chromium-review.googlesource.com/c/1375989
Commit-Queue: Sami Kyöstilä <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616338}Reland "Set VizDisplayCompositor feature enabled on desktop platforms."
This is a reland of f1ef4405b08f701d2bdae9494e0cdf92506de98eS. Not
enabled on mac as it causes timeouts in webkit_layout_tests.
Original change's description:
> Set VizDisplayCompositor feature enabled on desktop platforms.
>
> In preparation for launching OOP-D on stable switch the
> VizDisplayCompositor feature from disabled to enabled by default. This
> is following with the finch best practices.
>
> This is a reland of https://crrev.com/c/1361930 which was reverted for
> flaky tests. Fixes have been landed for the flaky tests.
>
> Bug: 730193
> Change-Id: I7dd8869dc942f579a336bca1a2b383a9b2d42a93
> Reviewed-on: https://chromium-review.googlesource.com/c/1374207
> Reviewed-by: Jonathan Ross <[email protected]>
> Commit-Queue: Jonathan Ross <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616285}
Bug: 730193
Change-Id: I1eefea03b980e0b3d124e90a0deaa1a583008216
Reviewed-on: https://chromium-review.googlesource.com/c/1375639
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616337}Revert "Roll src/third_party/boringssl/src 0f5ecd3a8..3adb1e5a3"
This reverts commit fabd5b297470da8254c9da7c815e0e70419136d3.
Reason for revert: Breaks android-cronet builder.
BUG=914859
Original change's description:
> Roll src/third_party/boringssl/src 0f5ecd3a8..3adb1e5a3
>
> https://boringssl.googlesource.com/boringssl/+log/0f5ecd3a854546d943104e1f7421e489b7f4d5aa..3adb1e5a37d1fafecfa69f6c7ef7604b62770634
>
> Bug: none
> Change-Id: Iba3632425f088d9ba8c4b313bc6a73567742f4ab
> Reviewed-on: https://chromium-review.googlesource.com/c/1374059
> Commit-Queue: Steven Valdez <[email protected]>
> Reviewed-by: Steven Valdez <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616321}
[email protected],[email protected]
Change-Id: Ia5aefde286d862d848d12709ceda37e455ac5957
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/1375873
Reviewed-by: David Turner <[email protected]>
Commit-Queue: David Turner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616336}Switch from SkColorType to viz::ResourceFormat
This means less plumbing now that we are using SharedImage.
[email protected]
Change-Id: I7aa650779dd450be3a0d9f3a841291a71e795ce5
Reviewed-on: https://chromium-review.googlesource.com/c/1374403
Commit-Queue: Jonathan Backer <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616335}Reland "Reland "Disable the new tab-loading animation""
This reverts commit 6921bd825e416c7b412b454f60df8b183e906943.
Reason for revert: NOTE TO SHERIFFS: Both the revert and reland of this
CL is the culprit for FindIt flakes. Context:
This CL changes the duration of the tab-icon animation ("spinner"). This
likely has some effects on test loops that RunUntilIdle or similar, so a
pending request might either have happened or not before that loop gets
idle.
For instance: crbug.com/912543 had to be changed to ignore a favicon.ico
response. This flakiness could be reproduced by just changing
TabIcon::ShowingLoadingAnimation to "return false;" even though the test
does not have anything to do with Chrome's UI directly.
This reland will likely trigger crbug.com/914232 again, but the revert
triggered crbug.com/914644. It's not unlikely that they are both flaky
as they implicitly rely on tab-icon load time.
Bug: chromium:914232, chromium:914644
Original change's description:
> Revert "Reland "Disable the new tab-loading animation""
>
> This reverts commit ad12d44124812f22484eb4d123e4a3b4aaac93b9.
>
> Reason for revert:
> Findit found this to be the most likely culprit for the single_process_mash_browser_tests failures on various Linux bots:
> https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/30518
>
>
> Original change's description:
> > Reland "Disable the new tab-loading animation"
> >
> > This reverts commit 742b8857c4dd0ab4550f7b2c1f200ce5be406b9c.
> >
> > Reason for revert: Flaky tests should be fixed in r615470.
> >
> > Bug: chromium:912543, chromium:913135, chromium:913784
> >
> > Original change's description:
> > > Revert "Disable the new tab-loading animation"
> > >
> > > This reverts commit 355b8185716292a8f145c77168ee89148ecabf31.
> > >
> > > Reason for revert: Made several tests flaky: https://crbug.com/912543
> > >
> > > Original change's description:
> > > > Disable the new tab-loading animation
> > > >
> > > > Makes sure that a lot of animation-related code is bypassed when the
> > > > new-tab-animation flag is off. This should hopefully fix a couple of
> > > > performance regressions that have not yet been root caused so that they
> > > > don't go out with M72.
> > > >
> > > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
> > > > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1364212
> > > > Reviewed-by: Sidney San Martín <[email protected]>
> > > > Commit-Queue: Peter Boström <[email protected]>
> > > > Cr-Commit-Position: refs/heads/master@{#614199}
> > >
> > > [email protected],[email protected]
> > >
> > > Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1366359
> > > Reviewed-by: Jeffrey Yasskin <[email protected]>
> > > Commit-Queue: Jeffrey Yasskin <[email protected]>
> > > Cr-Commit-Position: refs/heads/master@{#614440}
> >
> > [email protected],[email protected],[email protected]
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
> > Change-Id: I3981455a00f743fae535de4626179dcceab9b2c4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1372236
> > Reviewed-by: Peter Boström <[email protected]>
> > Commit-Queue: Peter Boström <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#615581}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: Ib9599bb8fd44327ae756d3c9523049367409612c
> Bug: chromium:912543, chromium:913135, chromium:913784, chromium:912328, chromium:905745, chromium:905918, chromium:910265
> Reviewed-on: https://chromium-review.googlesource.com/c/1373832
> Commit-Queue: Friedrich Horschig [CET] <[email protected]>
> Reviewed-by: Friedrich Horschig [CET] <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615878}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:912543, chromium:913135, chromium:913784, chromium:912328, chromium:905745, chromium:905918, chromium:910265
Change-Id: Ib8083b1320f3e1cd5c878bd55d2a007af7bf719a
Reviewed-on: https://chromium-review.googlesource.com/c/1376030
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616334}OriginTrial: Check if interfaces are implemented by others
We use [NoInterfaceObject] for interfaces implemented by others,
but also for interfaces hidden from global objects.
In generating origin trials code, we skip all [NoInterfaceObject]
interfaces regardless they are implemented by others or not.
Thus if we have [OriginTrialEnabled] with [NoInterfaceObject],
we did not generate code of origin trials for the interface.
This CL checks if each interface is implemented, and try to
generate origin trials code if it is not implemented.
Bug: 914703
Change-Id: Ide7b9872b3bfb76eb28977413b2a08ff8d14c792
Reviewed-on: https://chromium-review.googlesource.com/c/1375196
Commit-Queue: Hitoshi Yoshida <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616333}Re-enable PasswordFormConversionUtilsTest
It no longer appears to be broken, it passes on the trybots
consistently without retries.
Bug: 187500
Change-Id: Ib0665503d3df78ad32a5a5067dd03b37cb3cb289
Reviewed-on: https://chromium-review.googlesource.com/c/1375666
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616332}Change P2PSocket Create to use unique_ptr instead of raw pointers.
Bug: 479898
Change-Id: I7b2e81837c72d72f7f45c6352ec0c79c460a0b9a
Reviewed-on: https://chromium-review.googlesource.com/c/1374671
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616331}Enforce TLS 1.3 downgrade on known_roots by default.
Bug: boringssl:226
Change-Id: I71a4097a86e45d3929466330b4891b1f6729e17a
Reviewed-on: https://chromium-review.googlesource.com/c/1372549
Commit-Queue: Steven Valdez <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616330}Remove --parent-profile command line flag.
I don't see this being used. Sending for review to get feedback
if this can simply be removed. I believe at least the locale
logic in this code path is broken on TOT and M71 with the
ChromeFeatureListCreator refactoring which requires the locale
to be available earlier.
Given code search finds no uses, I assume this is obsolete and
can just go away. Please confirm.
Bug: none
Change-Id: I63e290fb6f175852d415e32fa890873b8ca9ce7e
Reviewed-on: https://chromium-review.googlesource.com/c/1368065
Reviewed-by: Mattias Nissler <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Robert Shield <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616329}SPM: Disable LockScreenAppStateTest.AppWindowClosedBeforeBeingShown
Use-after-free problem when running under single process
mash due to subtle differences when Widget is backed by
DesktopNativeWidgetAura.
[email protected]
Bug: 914823
Change-Id: I3b02edadc5e8af61dc8170c50673d14ebd5c7291
Reviewed-on: https://chromium-review.googlesource.com/c/1376029
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616328}Run Dawn end2end tests on Linux GPU FYI and optional builders
This adds the Dawn end2end tests to the following builders:
- Linux FYI Debug (NVIDIA)
- Linux FYI GPU TSAN Release
- Linux FYI Release (AMD R7 240)
- Linux FYI Release (Intel HD 630)
- Linux FYI Release (NVIDIA)
- Optional Linux Release (Intel HD 630)
- Optional Linux Release (NVIDIA)
BUG=chromium:901830
Change-Id: I3a86f313aefe2bc5b087c0b75d345ef14ce94a4c
Reviewed-on: https://chromium-review.googlesource.com/c/1373810
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Corentin Wallez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616327}Android: Remove build_tools_version
Now that we use Android Studio's sdk, we are no longer tied to the build
tools version in third_party/android_tools. This way Android Studio no
longer needs to warn about obsolete build_tools_version every sync.
Bug: 620034
Change-Id: I4e7f2c68694b650ab96219c53563007670312ba8
Reviewed-on: https://chromium-review.googlesource.com/c/1375633
Reviewed-by: Eric Stevenson <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616326}Prefer using SyncService (the interface) over ProfileSyncService (the impl)
It's better to use the interface rather than the concrete implementation.
For one, this will make testing easier.
This CL trivially switches a bunch of uses of ProfileSyncService over to
SyncService. There are still many left.
Bug: 910518
Change-Id: I6890db739b3333c056c6b6631d2074a8fd3f2efe
Reviewed-on: https://chromium-review.googlesource.com/c/1375718
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616325}Import wpt@04c862e10e0774beb17dbf84d94743a788d94bfc
Using wpt-import in Chromium 745381ba737bfdc1a6f678fbbdb066a1f8045693.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: Iafee6062d40f76197412668c643340a425674176
Reviewed-on: https://chromium-review.googlesource.com/c/1375145
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616324}Revert "Reland of: [code coverage] Add all fuzzer targets"
This reverts commit 80cee65bec02ee6edbd88670120867bc0af8e028.
Reason for revert: Caused failures of deterministic-linux-dbg.
See https://crbug.com/914776
Original change's description:
> Reland of: [code coverage] Add all fuzzer targets
>
> Now with a fix for the issue in GenerateIsolates().
>
> R=jbudorick,stgao,liaoyuke
>
> > Change-Id: I78ffec6525cd1d808a4b431ae1e2729b76357d46
> > Reviewed-on: https://chromium-review.googlesource.com/c/1372917
> > Commit-Queue: Shuotao Gao <[email protected]>
> > Reviewed-by: Shuotao Gao <[email protected]>
> > Reviewed-by: John Budorick <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#615834}
>
> Change-Id: I4ae0ef2588026bb6e0e5501e9ff39a7852d89afa
> Reviewed-on: https://chromium-review.googlesource.com/c/1374777
> Reviewed-by: Yuke Liao <[email protected]>
> Reviewed-by: John Budorick <[email protected]>
> Commit-Queue: Roberto Carrillo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616169}
[email protected],[email protected],[email protected],[email protected]
Change-Id: Ide8ca9ec623ffd13cb8195b3915cab785eb66d70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1375433
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616323}[ios] Remove dead snapshot code
This removes snapshot_util files, which used to be used by
tab_strip pre-bijou. This also removes unused snapshot_constants.
Change-Id: I38a900fabcc3e8bd9f821a59ff84df0378e0b570
Reviewed-on: https://chromium-review.googlesource.com/c/1375613
Reviewed-by: edchin <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616322}Roll src/third_party/boringssl/src 0f5ecd3a8..3adb1e5a3
https://boringssl.googlesource.com/boringssl/+log/0f5ecd3a854546d943104e1f7421e489b7f4d5aa..3adb1e5a37d1fafecfa69f6c7ef7604b62770634
Bug: none
Change-Id: Iba3632425f088d9ba8c4b313bc6a73567742f4ab
Reviewed-on: https://chromium-review.googlesource.com/c/1374059
Commit-Queue: Steven Valdez <[email protected]>
Reviewed-by: Steven Valdez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616321}Add the Accept-Languages pref to chrome://translate-internals
Bug: None
Change-Id: Iaba1626b2db3ac753964855dc831e25828ecb132
Reviewed-on: https://chromium-review.googlesource.com/c/1368585
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: anthonyvd <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616320}[ios] Store TaskRunners instead of threads in WebThreadImpl.
Track thread states explicitly instead of simply checking
whether a TaskRunner pointer exists or not.
BUG=826465
Change-Id: Id0f84e7eedc6b9f6568aec629abbb86f46979efa
Reviewed-on: https://chromium-review.googlesource.com/c/1340827
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616319}Add myself to tracing WATCHLISTS
Change-Id: I7b5de045e8a5d6681a8fba88e53d0240cd60a74b
Reviewed-on: https://chromium-review.googlesource.com/c/1374956
Commit-Queue: Daniel Nicoara <[email protected]>
Reviewed-by: Daniel Nicoara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616318}[sheriff] web tests: mark no-hover-during-scroll flaky on linux
[email protected]
Bug: 914782
Change-Id: I16f33ff822c1398f7677d8f6f55d7ba216e16c48
Reviewed-on: https://chromium-review.googlesource.com/c/1375383
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616317}[Passwords] Add Fill on Account Select on HTTP Feature Flag
This change adds a feature flag for the Fill on Account Select on HTTP
experiment.
Bug: 914765
Change-Id: I23f7a5c96b5a81c1962b9f327913ac3a6061d697
Reviewed-on: https://chromium-review.googlesource.com/c/1375721
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616316}Revert "Set VizDisplayCompositor feature enabled on desktop platforms."
This reverts commit f1ef4405b08f701d2bdae9494e0cdf92506de98e.
Reason for revert: Mac timeouts in webkit_layout_tests
Original change's description:
> Set VizDisplayCompositor feature enabled on desktop platforms.
>
> In preparation for launching OOP-D on stable switch the
> VizDisplayCompositor feature from disabled to enabled by default. This
> is following with the finch best practices.
>
> This is a reland of https://crrev.com/c/1361930 which was reverted for
> flaky tests. Fixes have been landed for the flaky tests.
>
> Bug: 730193
> Change-Id: I7dd8869dc942f579a336bca1a2b383a9b2d42a93
> Reviewed-on: https://chromium-review.googlesource.com/c/1374207
> Reviewed-by: Jonathan Ross <[email protected]>
> Commit-Queue: Jonathan Ross <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616285}
[email protected],[email protected]
Change-Id: I091b87b72e83d8a99c4da7dd14b026711bbfac23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 730193
Reviewed-on: https://chromium-review.googlesource.com/c/1375634
Reviewed-by: kylechar <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616315}CPU scaling and color transform on CopyOutputRequest
Copy from SoftwareRenderer.
This fixes some unit tests and may be performant enough to small field
trial. There are still unit tests failing
(AuraWindowVideoCaptureDeviceBrowserTest), but I will address that in a
separate CL.
GLAndSoftwareCompositing*, WebContentsVideoCaptureDeviceBrowserTest*,
DevToolsVideoConsumerTest.SetMinAndMaxFramesChangesDimensions
content_browsertests now passing.
Bug: 911796
Change-Id: Ib933f4a6e5cebed4af3bf35c1b23cf97fe54540f
Reviewed-on: https://chromium-review.googlesource.com/c/1369631
Reviewed-by: Yuri Wiitala <[email protected]>
Reviewed-by: weiliangc <[email protected]>
Commit-Queue: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616314}Roll android_tools to pick up platform-tools 28.0.1.
Bug: 850652
Change-Id: I95436baa95af68546841a9bb978f8dbb0f233345
Reviewed-on: https://chromium-review.googlesource.com/c/1374358
Reviewed-by: Bo <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Commit-Queue: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616313}GN: Drop webgl2_compute_rendering_context_base.idl
If we support WebGL2ComputeContext, we have a dependency
WebGL2ComputeRenderingContext --(implements)-->
WebGL2ComputeRenderingContextBase --(implements)-->
WebGL{,2}RenderingContextBase
but otherwise, we don't have this dependency, because
we do not use WebGL2ComputeRenderingContext, and
hence we don't need WebGL2ComputeRenderingContextBase either.
This CL drops the idl file for WebGL2ComputeRendringContextBase
if we don't support it.
Bug: 914703
Change-Id: I5210ba25a296f3bc4c07a57cc22c9d801b2bc55b
Reviewed-on: https://chromium-review.googlesource.com/c/1375181
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616312}Regression test for crbug.com/626744
Bug: 626744
Change-Id: I4244c3f0316ceb55bc69655212f6677345b0a6cc
Reviewed-on: https://chromium-review.googlesource.com/c/1374988
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616311}[iOS][MF] Integration test for ipad
This test ensures suggestions are correctly reenabled and work after
dismissing an iPad popover.
Bug: 912558
Change-Id: Ieb6af602556d9b155901989f5ce30a9015e4b43e
Reviewed-on: https://chromium-review.googlesource.com/c/1374231
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Reviewed-by: Eric Noyau <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616310}Reland "[TaskScheduler]: Create no detach below initial capacity feature"
This is a reland of 3f40244cd1ae911072fdccc827fdf446e1a66005
Fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/1361441
Original change's description:
> [TaskScheduler]: Create no detach below initial capacity feature
>
> Under this experiment, scheduler workers are only detached if the pool is
> above its initial capacity (threads that are created to replace blocked threads).
>
> 2 options were considered:
> Option A: Detach only when over initial capacity.
>
> Option B: Detach only when over current capacity (includes currently blocked threads in capacity).
> This might better handle the following case: At any given time, there is at least 1 blocked thread.
> On top of that, some periodic work uses all worker every 30s or so. The current capacity will
> encompass for the blocked thread and avoid detaching it periodically.
>
> Option A was picked because it is more conservative. Initial capacity is smaller or
> equal to current capacity, so detaching is closer to current behavior. We want to avoid having
> too many threads that aren't used.
>
> Bug: 847501
> Change-Id: I0b116db54095767768b158d92f5f146249720b45
> Reviewed-on: https://chromium-review.googlesource.com/c/1348863
> Commit-Queue: Etienne Pierre-Doray <[email protected]>
> Reviewed-by: François Doray <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#612698}
Bug: 847501
Change-Id: I68a592151f965b8a297ece7cc192eeaf78a72cc8
Reviewed-on: https://chromium-review.googlesource.com/c/1374521
Commit-Queue: François Doray <[email protected]>
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616309}add SK_SUPPORT_LEGACY_FONTMETRICS_IN_PAINT flag to stage skia api change
Needs this to roll in first
https://skia-review.googlesource.com/c/skia/+/177063
Change-Id: I6ed43335c93e516f7a2f1fb7efc4756206e83bcc
Reviewed-on: https://chromium-review.googlesource.com/c/1374166
Reviewed-by: Florin Malita <[email protected]>
Reviewed-by: Mike Reed <[email protected]>
Commit-Queue: Mike Reed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616308}[Sync::USS] Fix crash when EstimateMemoryUsage in Bookmarks processor
BookmarkModelTypeProcessor::EstimateMemoryUsage()
should check bookmark_tracker_ for nullness before estimating the
memory usage.
The reason is if EstimateMemoryUsage() is called while the model is
being loaded, the bookmark_tracker_ wouldn't have been initialized yet.
Bug: 914745
Change-Id: I93f6ee0972022d4f72dcfdee5261f5efe51c5239
Reviewed-on: https://chromium-review.googlesource.com/c/1375124
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616307}[Improved Geo-language] Prepare for a new language code locator.
Abstracts away the current language code locator implementation.
Adds the boilerplate for a feature toggling between possible implementations.
Bug: 850947
Change-Id: I620c8f6ceb95cd45dab68222fb34fcaa1d44c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/1352683
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: anthonyvd <[email protected]>
Commit-Queue: Alexandre Frechette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616306}Roll src/third_party/catapult 368ebf1e07cb..203676d4b186 (1 commits)
https://chromium.googlesource.com/catapult.git/+log/368ebf1e07cb..203676d4b186
git log 368ebf1e07cb..203676d4b186 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] [wpr] Add --overwrite-existing and --skip-existing flags to httparchive.go
Created with:
gclient setdep -r src/third_party/catapult@203676d4b186
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:896280
[email protected]
Change-Id: Ib2d5f203bf9ddd45b704441ed4c54230477bf50f
Reviewed-on: https://chromium-review.googlesource.com/c/1375543
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616305}[SuperSize] Fix missing sizes in LinkerMapParserTest.test_Parser().
LinkerMapParserTest.test_Parser() creates an iterator of processed
test .map file. Previously this iterator was shared between calls to
(1) DetectLinkerNameFromMapFile(),
(2) .MapFileParser().Parse().
This causes a bug in the test: (2) requires a fresh iterator, and it
explicitly it skips the first line! Consequently, a number of section
sizes ({.interp, .ARM.exidx, .dynsyn}) were missing.
This CL fixes the test by creating fresh iterators for (1) and (2).
Also, the section sizes are sorted to reduce arbitrariness of dict
iteration.
Bug: 892648
Change-Id: Ib52f17b0446012fe37951c86409c450d59b57e4a
Reviewed-on: https://chromium-review.googlesource.com/c/1375610
Commit-Queue: agrieve <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616304}Avoid modifying Windows registry in RemoveProtocolHandler test
Writing to Windows registry requires elevated privileges and the test
fails on Windows 7 unless it's run as administrator (but in this case
all modifications stay in registry because the test doesn't do the
cleanup during its tear down).
Bug: 849660
Change-Id: I6cb8e9b2ba30e5bd9af2d8ede97c9bd62ccbc9ca
Reviewed-on: https://chromium-review.googlesource.com/c/1348115
Commit-Queue: Tomasz Moniuszko <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616303}[ios] Removes Browser and BrowserList.
BUG=None
Change-Id: I0cc964283d7b30c062aa208dc37f19ed1efe447e
Reviewed-on: https://chromium-review.googlesource.com/c/1323112
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616302}Update V8 to version 7.3.126.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/79b441fd..d81c9cc2
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I12790d36918de2d1cbb207170af5ca72b7a5641c
Reviewed-on: https://chromium-review.googlesource.com/c/1374916
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616301}fast/dynamic/window-resize-scrollbars-test.html times out sometimes.
[email protected]
Bug: 878226
Change-Id: I1619e8982f0daf7aa9b0c40dd594f5e78d69f14f
Reviewed-on: https://chromium-review.googlesource.com/c/1375732
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616300}import_controller_unittest: spell correct, remove, update @types
- spell correct impoter => importer
- remove @param {!DirectoryEntry} destination
- the affected functions don't have parameters
- fix obvious @type errors
- event listener functions receive an {!Event}
- arrays are @type {!Array<whatever>} for sure
- remove importer.CommandUpdate
- this @type does not exist in the code base
- importer.ImportControler => importer.ImportController
- add TODO to determine class @override types
- auto-format the code
Bug: 914197
Change-Id: Ib225ed6030e70c0676f04f4f730e72e6b48eec4b
Reviewed-on: https://chromium-review.googlesource.com/c/1375201
Commit-Queue: Noel Gordon <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616299}[s13n] Provide replacement API for PO2TS::set_all_credentials_loaded_for_testing
CL is another step forward eliminating all direct calls to PO2TS
APIs from AccountReconcilor unittests. Particularly, it adds a new
API to our testing infrastructure, IdentityTestEnvironment.
BUG=911641,910581
Change-Id: I1ff3a8f287fff0f5b4bfbffe2e2d6943ba36ec52
Reviewed-on: https://chromium-review.googlesource.com/c/1372426
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Commit-Queue: Antonio Gomes <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616298}Revert "base: Don't keep running tasks after nested run loop quits on iOS"
This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.
Reason for revert:
Sheriff suspects this broke a handful of menu tests on macOS 10.12:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564
e.g.:
WebViewTest.TestContextMenu
Original change's description:
> base: Don't keep running tasks after nested run loop quits on iOS
>
> The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call
> to Delegate::DoWork in the following scenario:
>
> 1. Start a run loop and schedule DoWork.
> 2. In DoWork, start a second run nested run loop which quits immediately.
> 3. After the nested run loop quits, schedule another DoWork which quits the
> original run loop.
>
> After step #3, the message pump would call DoWork again because the nested
> run loop triggered the execution of the nesting deferred work source.
>
> This patch fixes the issue by checking whether the further work is allowed
> before calling DoWork. Note that this check can't be done just for the nested
> deferred work source, because in the flow above that source is what triggers
> the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.
>
> The patch also includes a fix to
> WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the
> following sequence in it (while a select menu is open):
>
> 1. Quit an outer run loop.
> 2. Post a task onto an inner run loop to continue the test.
>
> The assumption here was that a select menu causes an inner run loop to
> be active while the menu is open. This wasn't strictly correct: the
> inner run loop is a native (CoreFoundation) run loop as opposed to a
> base::RunLoop, which can't be explicitly exited with RunLoop::Quit().
> This means that the Quit() in step #1 affects the same run loop as the
> PostTask in step #2, i.e., the task is prevented from running.
>
> This patch changes the test to only quit the test run loop after the
> posted task (which closes the select menu) has run.
>
> Bug: 891670
> Change-Id: I6fe21289205664c4e1b1469547495667c753f56d
> Reviewed-on: https://chromium-review.googlesource.com/c/1373754
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Sami Kyöstilä <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615967}
[email protected],[email protected]
Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/1375382
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616297}[iOS][MF] Reenable suggestions after popover is dismissed
Bug: 912558
Change-Id: I54285ad460395206bce9e1652444ed925acab40c
Reviewed-on: https://chromium-review.googlesource.com/c/1373759
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Reviewed-by: Eric Noyau <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616296}Protect supervision transition screens with feature flag.
Bug: 903851
Change-Id: I65e788e431c8a683a0f28b4b26a07cdd208e94fa
Reviewed-on: https://chromium-review.googlesource.com/c/1374309
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Bruno Santos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616295}[AF] Debug flaky sync_integration_tests with more debug info
CL to be reverted once the investigation is over.
Bug: 911953
Change-Id: Iae2e9f4c11ca3a8ecbe04b196c055206aa003b32
Reviewed-on: https://chromium-review.googlesource.com/c/1375731
Commit-Queue: Jan Krcal <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616294}Revert "Reland "allocator: Add Windows _aligned_* shims""
This reverts commit 7eae85ba6448aa3cf1e14d6557e1f77a86c7e49f.
Reason for revert:
Sheriff suspects this broke win-asan tests, specifically: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927275104247189904/+/steps/media_blink_unittests_on_Windows-10-15063/0/logs/WebMediaPlayerImplTest.LoadAndDestroy/0
e.g.:
#0 0x7ff7b62b2e1c in __asan_wrap_memmove C:\b\rr\tmph59meq\w\src\third_party\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_common_interceptors.inc:775
#1 0x7ff7bd0736f0 in _aligned_realloc C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\minkernel\crts\ucrt\src\appcrt\heap\align.cpp:622
#2 0x7ff7b68faf0e in av_realloc_f C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\..\..\third_party\ffmpeg\libavutil\mem.c:158
#3 0x7ff7b68ee92a in ffio_rewind_with_probe_data C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\..\..\third_party\ffmpeg\libavformat\aviobuf.c:1136
#4 0x7ff7b7a69966 in av_probe_input_buffer2 C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\..\..\third_party\ffmpeg\libavformat\format.c:304
#5 0x7ff7b68c8b40 in avformat_open_input C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\..\..\third_party\ffmpeg\libavformat\utils.c:573
#6 0x7ff7b37437f8 in media::FFmpegGlue::OpenContext C:/b/swarming/w/ir/cache/builder/src/out/Release_x64\..\..\media\filters\ffmpeg_glue.cc:117
Original change's description:
> Reland "allocator: Add Windows _aligned_* shims"
>
> This is a reland of 0ba5ea124ec9de7d786cf6f4fc4ab2847c8d785e with a
> missing #if DCHECK_IS_ON() added.
>
> Original change's description:
> > allocator: Add Windows _aligned_* shims
> >
> > On Windows we don’t currently hook the _aligned_* allocation APIs, this
> > can cause issues because _aligned_realloc can call HeapSize and cause
> > GWP-ASan crashes similar to bug 909720. Unfortunately the
> > _aligned_realloc API is different enough that it can not be implemented
> > using the standard POSIX shims, in particular because _aligned_malloc
> > and _aligned_free don't return valid allocation addresses, they are
> > offsets into allocations.
> >
> > I add new Windows platform-specific shims for _aligned_malloc,
> > _aligned_realloc, and _aligned_free and wire them in for all users of
> > the allocator shims. I implement these routines on top of the Windows
> > Heap* API and leave uncommon _aligned_* shims to crash to ensure that
> > any future uses immediately surface why their use fails.
> >
> > Bug: 912500, 896019
> > Change-Id: Ieaa50b816ab277a6ad4b80ee8519027343fa9878
> > Reviewed-on: https://chromium-review.googlesource.com/c/1367485
> > Reviewed-by: danakj <[email protected]>
> > Reviewed-by: Vitaly Buka <[email protected]>
> > Reviewed-by: Alexei Filippov <[email protected]>
> > Reviewed-by: Erik Chen <[email protected]>
> > Reviewed-by: Will Harris <[email protected]>
> > Reviewed-by: Sigurður Ásgeirsson <[email protected]>
> > Commit-Queue: Vlad Tsyrklevich <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#616106}
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
>
> Bug: 912500, 896019
> Change-Id: I05aeb4bc9ef2974f967a81c53cb7bbbcc6e955f3
> Reviewed-on: https://chromium-review.googlesource.com/c/1374959
> Reviewed-by: Vlad Tsyrklevich <[email protected]>
> Commit-Queue: Vlad Tsyrklevich <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616171}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ic0c79f51b2b539f8daedf735ae1adfaa63ed5340
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912500, 896019
Reviewed-on: https://chromium-review.googlesource.com/c/1375381
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616293}[build] Add pointer-compression gpu fyi bot for V8
This retires the concurrent-marking builder which has become obsolete since
concurrent marking is on by default. We instead use the same configurations
for the new pointer-compression builder.
The only difference is a different gn build flag. This change will break
the old builder, which is fine. We'll land a CL to change the builder name
shortly after.
[email protected]
Bug: v8:8421
Change-Id: Ic0b8f678189f24e3f0fa22fa80dae917f73f89ad
Reviewed-on: https://chromium-review.googlesource.com/c/1375126
Commit-Queue: Michael Achenbach <[email protected]>
Reviewed-by: Sergiy Belozorov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616292}Roll src/third_party/perfetto 1e1b0316d42d..f8d555916230 (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/1e1b0316d42d..f8d555916230
git log 1e1b0316d42d..f8d555916230 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Merge "service: Track writer registrations and target buffer associations."
Created with:
gclient setdep -r src/third_party/perfetto@f8d555916230
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I9b0aad8a3fa4b31b291df24d3b4ffb7e2e24340e
Reviewed-on: https://chromium-review.googlesource.com/c/1375541
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616291}[iOS] Move authentication cells to their folder
This CL moves the cells used by the authentication to their own folder.
It will allow the settings to use those cells later.
Bug: 894791
Change-Id: I2f09eaa853fe782d4400e6f3f5a549ad544a1666
Reviewed-on: https://chromium-review.googlesource.com/c/1373763
Reviewed-by: Jérôme Lebel <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616290}Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits)
https://skia.googlesource.com/skia.git/+log/a69b10312977..5eb29448dfbd
git log a69b10312977..5eb29448dfbd --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Roll third_party/externals/swiftshader 50dd2ce4e2e3..af3c1022c8d0 (1 commits)
Created with:
gclient setdep -r src/third_party/skia@5eb29448dfbd
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I499bc84af466a86b5f83142b0e08dbe9131ff624
Reviewed-on: https://chromium-review.googlesource.com/c/1375542
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616289}Include the request body when using the in memory driver.
Bug: 774054
Change-Id: I4251d752911818f4f5e499780815ef53fb30c640
Reviewed-on: https://chromium-review.googlesource.com/c/1374232
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616288}Roll src-internal 24ce372d6068..05b396200126 (8 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24ce372d6068..05b396200126
Created with:
gclient setdep -r src-internal@05b396200126
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:690583,chromium:896090,chromium:887535,chromium:895567,chromium:908285
[email protected]
Change-Id: I85f108879f114667615b2abef6f55af39a652639
Reviewed-on: https://chromium-review.googlesource.com/c/1374915
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616287}[Background Fetch] Pass request bodies to the Download Service.
Bug: 774054
Change-Id: Ia1c45819af4f60d52d3b661efcbbcbd77c58a143
Reviewed-on: https://chromium-review.googlesource.com/c/1373825
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616286}Set VizDisplayCompositor feature enabled on desktop platforms.
In preparation for launching OOP-D on stable switch the
VizDisplayCompositor feature from disabled to enabled by default. This
is following with the finch best practices.
This is a reland of https://crrev.com/c/1361930 which was reverted for
flaky tests. Fixes have been landed for the flaky tests.
Bug: 730193
Change-Id: I7dd8869dc942f579a336bca1a2b383a9b2d42a93
Reviewed-on: https://chromium-review.googlesource.com/c/1374207
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616285}Initial BackForwardCache implementation.
− Add the BackForwardCache feature. Disabled by default.
− On cross-process navigations, keep the old RenderFrameHost. Store it in a
|BackForwardCache| object.
− On history navigation, find the previous document in the BFCache and swap it
back if possible.
− The BackForwardCache works as a least recently used cache.
A basic cache eviction is implemented when it is full.
Major things that aren't supported yet:
- Freezing the frame in the BackForwardCache. They are still able to execute
JavaScript in the background. They can still interact using IPCs with the
browser process and causes crashes.
- Removing a RenderFrameHost from the BackForwardCache cleanly.
- Handling same-process navigations.
Bug: 914321
Change-Id: I1b83fe59dc4868b5a6093738d2f5c65f67d60a78
Reviewed-on: https://chromium-review.googlesource.com/c/1358434
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616284}Move ProxyDataTypeController to sync_sessions
Mechanical change without behavioral differences.
We have exactly one proxy datatype and it's about tabs from other
devices (PROXY_TABS). Let's avoid abstraction and move the controller
closer to the feature, under sync_sessions.
Follow-up patches may introduce additional custom logic that is
specific to tab sync.
Bug: 914747
Change-Id: I5afedff030bd455232836f0eb1fbcce6fcfa012b
Reviewed-on: https://chromium-review.googlesource.com/c/1374987
Reviewed-by: Jan Krcal <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616283}heap: Conservatively scan objects in construction
Switch to conservative scan for objects that have vtables and are currently
under construction.
The previous mechanism relied on (a) checking for an initialized vtable pointer
and (b) partial dispatch to already initialized member fields through using
Trace. The approach could not handle mixins as the virtual trace method could
not dispatch to the object inheriting from the currently constructed one.
We switch to conservatively scanning objects with vtables that are under
construction. The benefit is not having to rely on vtable setup and that it also
works during mixin construction. The drawback is being conservative which is
currently not a blocker as stack-scan is also conservative.
Bug: 911662
Change-Id: I08b2434ca1fb4015553899012aca7594332f87e1
Reviewed-on: https://chromium-review.googlesource.com/c/1361713
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Ulan Degenbaev <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616282}[AF Profile] Test merging non-verified and verified profiles
Tried to find a difference between USS and Directory for one particular
TODO but I did not succeed. It seems reasonable to make use of the work
and add some more integration tests.
Bug: 904390
Change-Id: Id96ed94fc9541a208915d194c6f9ae0b542c44c6
Reviewed-on: https://chromium-review.googlesource.com/c/1361244
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616281}[Reland #4] Use the SequenceManager in ScopedTaskEnvironment
A reland of https://crrev.com/c/1324391
This is necessary because we want content::TestBrowserThreadBundle to
own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment
and you can't have two SequenceManagers on the same thread.
This patch allows ScopedTaskEnvironment to optionally work with an
externally owned SequenceManager solving the problem.
This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk,
We now have the ability to mock time on the UI and IO threads.
HttpServiceTest had been changed because HttpServiceTest.MultipleRequests was
failing mysteriously on fuchsia on the bots only (not locally). IO_MOCK_TIME
seems to have fixed this.
SyncSchedulerImplTest has been changed to use MOCK_TIME because it was
flaky on Mac. This change required base::TimeTicks::Now() to be overridden.
These tests should now run faster which I understand was a historical problem
(see https://crbug.com/402212).
The chromeos test changes are needed because C++ requires a default constructor
to const construct an object. ScopedTaskEnvironment has a template vararg
constructor which due to a defect in the C++ standard isn't recognized for this
purpose. C++ will happily let you default construct a non-const object using
it however.
[email protected], [email protected], [email protected]
Bug: 863341, 891670, 913946, 911928
Change-Id: Ib7e58223b531cf85aded11b75bd09c47a0993391
Reviewed-on: https://chromium-review.googlesource.com/c/1371899
Reviewed-by: Alex Clarke <[email protected]>
Reviewed-by: Jan Krcal <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Alex Clarke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616280}v8binding: Dispatch MediaQueryListEvent even when paused
MediaQueryListEvent is expected to be dispatched even when the
execution context is paused at least in the case of print.
This patch gives an exemption to MediaQueryListEvent.
Bug: 914554
Change-Id: I361e0c514a8aa213c68010dee7f82feb341de052
Reviewed-on: https://chromium-review.googlesource.com/c/1375205
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616279}Add DCHECK when shutdown behavior is used to post to UI/IO threads on iOS.
The BLOCK_SHUTDOWN behavior is currently not respected for tasks posted
to the UI/IO threads. Indeed, nothing prevents the UI/IO run loop to
exit before all BLOCK_SHUTDOWN tasks have been processed.
Bug: 872372, 908348
Change-Id: If14cfa5af4ddef5a075f3113c74ab03ad30cd5d7
Reviewed-on: https://chromium-review.googlesource.com/c/1352347
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616278}Import wpt@483983d277f2997d59696ab3ef1c28e2bb77ad46
Using wpt-import in Chromium 912523f0f7bea33b9dd4817dcf4e182851361e77.
With Chromium commits locally applied on WPT:
8bb5e943be "Add WPT to verify that 1XX responses are used to provide responseStart timing"
618e62b560 "Align resource timing buffer full processing to spec PR 168 (take 3)"
1c633d483b "Snap the snapped_dest_rect for backgrounds"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/resource-timing
NOAUTOREVERT=true
TBR=kyleju
No-Export: true
Change-Id: Ifa17de4a0f464de26ded1ab17fcacc19141de482
Reviewed-on: https://chromium-review.googlesource.com/c/1375612
Reviewed-by: WPT Autoroller <[email protected]>
Commit-Queue: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616277}[Autofill Assistant] Default backend url.
Before this patch, autofill assistant was managed via a server-side
experiment and parameter for the url. This patch default enables the
feature since external callers are responsible for starting autofill
assistant via parameters. This simplifies the reasoning about the
responsibilities. This means the backend url is also added in this
patch and there is a single source of truth on the c++ side for it.
[email protected], [email protected]
Bug: 806868
Change-Id: I686f087e7c8625b962e6b6c80a2acba238f183f8
Reviewed-on: https://chromium-review.googlesource.com/c/1369792
Commit-Queue: Mathias Carlen <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Stephane Zermatten <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616276}Revert "Remove fake alert AXObjWrapper object"
This reverts commit 1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1.
Reason for revert: Causing crbug.com/914647
Original change's description:
> Remove fake alert AXObjWrapper object
>
> Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit aura::Window.
>
> [email protected]
>
> Bug: 888152
> Change-Id: I9e190a8e437a78c7e27ebfaab70ec20980dff32d
> Reviewed-on: https://chromium-review.googlesource.com/c/1368828
> Commit-Queue: David Tseng <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: James Cook <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616064}
[email protected],[email protected],[email protected]
Change-Id: I595218ff0b34290e10ec160d0445bc7d461936bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888152
Reviewed-on: https://chromium-review.googlesource.com/c/1375128
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616275}Update V8 to version 7.3.124.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/146487a6..79b441fd
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: I363f90e73938bf3fa167b9e5edc54445995b0cf6
Reviewed-on: https://chromium-review.googlesource.com/c/1375617
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616274}Revert "Reland: Move AXTreeSourceAura tests into AXTreeSourceViews tests"
This reverts commit 51e1e97e26579a5d26ff5263dbe08242f0aa983c.
Reason for revert: Blocks reversion of https://chromium-review.googlesource.com/c/chromium/src/+/1368828 , which is causing regressions. Sorry!
Original change's description:
> Reland: Move AXTreeSourceAura tests into AXTreeSourceViews tests
>
> Additional CLs have landed that resolve the memory leak in
> views_mus_unittests detected by LSAN.
>
> Original description:
> >AXTreeSourceAura doesn't exist any more. The tests exercise the
> >integration of AXRootObjWrapper with AXTreeSourceViews, so rename the
> >tests ot AXTreeSourceViewsRootTest.
> >
> >Note that the tests lived in //chrome/browser/ui/ash. If we need an
> >ash-specific tree source we could introduce an AXTreeSourceAsh either
> >in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash).
> >
> >Bug: 910672
> >Test: views_unittests
> >Reviewed-on: https://chromium-review.googlesource.com/c/1358972
> >Reviewed-by: David Tseng <[email protected]>
> >Commit-Queue: James Cook <[email protected]>
> >Cr-Commit-Position: refs/heads/master@{#613308}
>
> [email protected]
>
> Change-Id: Id4dc9b6dd7bedffb6cc1184ac0c1f1e36f51ffc1
> Reviewed-on: https://chromium-review.googlesource.com/c/1362193
> Reviewed-by: James Cook <[email protected]>
> Commit-Queue: James Cook <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616111}
[email protected],[email protected]
Change-Id: I319e63c00929140648028601365d8896fa55b7b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1375127
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616273}Disable TypeId.IdenticalTypesFromComponentAndStaticLibrary under ASAN.
This test seems to be failing on Android, probably due to the
way Asan instruments the binary, breaking some assumptions
made by the implementation.
BUG=914734
[email protected],[email protected],[email protected],[email protected]
[email protected]
Change-Id: I4ef9abd8ae64852757353cb322b1f88abc393860
Reviewed-on: https://chromium-review.googlesource.com/c/1375123
Reviewed-by: David Turner <[email protected]>
Commit-Queue: David Turner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616272}Roll src/third_party/perfetto 85d294307e70..1e1b0316d42d (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/85d294307e70..1e1b0316d42d
git log 85d294307e70..1e1b0316d42d --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Merge "profiling: Fix flush callback."
Created with:
gclient setdep -r src/third_party/perfetto@1e1b0316d42d
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ic0ca5d26a045e8cafe3156eb9ca41b56b6d566bd
Reviewed-on: https://chromium-review.googlesource.com/c/1375539
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616271}Revert "ARM64 capable toolchain hash"
This reverts commit dd8c7b26d4da856b36edba4b2d8dff5a786d3eb4.
Reason for revert: Breaks V8 compilation with msvc due to goma errors:
https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_win64_msvc_compile_rel/b8927261102998791312
Original change's description:
> ARM64 capable toolchain hash
>
> This updates Chrome to build with a toolchain based on VS 2017 15.9.3
> and the Windows 10.0.17763.132 SDK, with the ARM64 components included to
> support building for ARM64 for Win32. This adds about 400 MB to the package
> size, a bit less than a 50% increase.
>
> Packaging was done on a Windows Server 2016 VM, cleanly created for this
> purpose.
>
> The package was created by downloading VS 2017 Update 9.3, from
> https://www.visualstudio.com/vs/, and then running the installer like this:
>
> $ PATH_TO_INSTALLER.EXE ^
> --add Microsoft.VisualStudio.Workload.NativeDesktop ^
> --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
> --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
> --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
> --includeRecommended --passive
>
> Then Add or Remove Programs was used to modify the SDK to add the
> Debuggers package.
>
> Then the packaging script was run like this:
>
> python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17763.0
>
> This was tested on two VMs to ensure that the results are consistent.
>
> This should not significantly affect the x86 and x64 builds, although
> there may have been some STL and CRT changes that could cause changes.
>
> Bug: 893460
> Change-Id: I33dd5b915ffaf17f306d804f561d26bf82060b03
> Reviewed-on: https://chromium-review.googlesource.com/c/1342814
> Reviewed-by: Dirk Pranke <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Commit-Queue: Bruce Dawson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616123}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I17be21b124053a182157bfecd54d722f210e6171
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893460
Reviewed-on: https://chromium-review.googlesource.com/c/1375125
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616270}Stop using default_factory for AppCache and reduce RBPI::CreateDefaultURLLoaderFactoryBundle usage
* Stop using URLLoaderFactoryBundle::default_factory for AppCache,
this over-generalization has been causing a lot of confusions.
* Deprecate URLLoaderFactoryBundle::default_network_factory, which is
no longer needed after removing the default_factory == AppCache hack.
* This change also allows us to remove more RendererBlinkPlatformImpl::
CreateDefaultURLLoaderFactoryBundle callsites for most of
NetworkService-enabled cases, which was needed only when
default_factory was dropped (just to skip AppCache, which is no
longer needed), or for initial empty document cases (this is
still needed).
Bug: 891872
Change-Id: I9b58097430b76d96d96864043b63553e88e3066c
Reviewed-on: https://chromium-review.googlesource.com/c/1371310
Commit-Queue: Kinuko Yasuda <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616269}Reland "Disable system_health.common_desktop/multitab on Win 10"
This is a reland of 5a14fdf87276e7460ccd4d18a5eba301514bd3ad
Original change's description:
> Disable system_health.common_desktop/multitab on Win 10
>
> NOTRY=true
>
> Bug: 911214
> Change-Id: Ia853c50260f4a46835818ef4b364b4ee97091244
> Reviewed-on: https://chromium-review.googlesource.com/c/1367109
> Reviewed-by: Caleb Rouleau <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#614566}
[email protected]
NOTRY=true
Bug: 911214
Change-Id: I67dc1d3f3b1c797e23a580264726a1b9ffd1884a
Reviewed-on: https://chromium-review.googlesource.com/c/1375710
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Commit-Queue: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616268}Roll src/third_party/skia 5f47971ca8b7..a69b10312977 (2 commits)
https://skia.googlesource.com/skia.git/+log/5f47971ca8b7..a69b10312977
git log 5f47971ca8b7..a69b10312977 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Update markdown files
2018-12-13 [email protected] Roll third_party/externals/angle2 b08457df2325..9b02506c852b (1 commits)
Created with:
gclient setdep -r src/third_party/skia@a69b10312977
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I54a84dc4712106b2a7c079ab24b1e58db113de5c
Reviewed-on: https://chromium-review.googlesource.com/c/1375532
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616267}[Autofill Assistant] Remove the preference entry.
Before this patch, we would show a preference entry to enable/disable
Autofill Assistant. The way onboarding works, this is no longer desired.
This patch always removes the preference from the xml so that the patch
is smaller and less controversial to be merged into the release branch.
After this patch, enableing/disabling the feature will entirely be done
during the onboarding flow.
Bug: 806868
Change-Id: I1b10f9cfb55e2d4cf320259f12ed7c3c9fb395c6
Reviewed-on: https://chromium-review.googlesource.com/c/1368649
Commit-Queue: Mathias Carlen <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616266}Roll src/third_party/depot_tools 03640c7fe5d5..7fa4fbc46829 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03640c7fe5d5..7fa4fbc46829
git log 03640c7fe5d5..7fa4fbc46829 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Update documentation of `git new-branch`
Created with:
gclient setdep -r src/third_party/depot_tools@7fa4fbc46829
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I59face7d26123c21ab86788a5b0c725782d869e6
Reviewed-on: https://chromium-review.googlesource.com/c/1375537
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616265}[iOS] Update spacing in Settings' TableView
This CL changes the spacing in the Settings. In particular it changes:
- The estimated height for header/footer to avoid some constraints being
broken.
- The spacing displayed when there is no header/footer in a section.
- The spacing around the link footers.
Bug: 913538
Change-Id: Id634b2dc55ebed3daeffae78168a1f8fa08b4673
Reviewed-on: https://chromium-review.googlesource.com/c/1371388
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616264}Not show notifications on lockscreen when the setting is off
We shouldn't check the feature flag but the manager status.
Bug: b/111391270
Test: the modified tests cover, also did manual tests
Change-Id: Ie28c0cb05e5f14b51cc96104eb6dda14e01fc109
Reviewed-on: https://chromium-review.googlesource.com/c/1375178
Commit-Queue: Yoshiki Iguchi <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616263}import_controller_unittest: clean-up preamble and SetUp
- add standard JSDoc used elsewhere for window.metrics
- use local variable testFileSystem, to exchange 2 lines for 3
- volumeManager.getCurrentProfileVolumeInfo can return null so
add an assert that it's never null in these tests
No change in test behavior.
Tbr: sammc@
Bug: 914197
Change-Id: I2ea6314b57f55224f7c26050591bd551b6f56bb8
Reviewed-on: https://chromium-review.googlesource.com/c/1375199
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616262}Revert "Fixes cleanup check for non-parent owned windows"
This reverts commit d67a285fb96aae2681f64b57cb51d5b41d812d3c.
Reason for revert: Causes OverscrollNavigationOverlayTest.OverlayWindowSwap failure, e.g.:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/13565
Original change's description:
> Fixes cleanup check for non-parent owned windows
>
> NOTRY=true
> [email protected],[email protected]
>
> Change-Id: I8ca0b4f6d466d5ac45260d5fbd5a874565d17a92
> Reviewed-on: https://chromium-review.googlesource.com/c/1375113
> Reviewed-by: David Tseng <[email protected]>
> Commit-Queue: David Tseng <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616204}
[email protected]
Change-Id: I89c5b934602cf056b63b9fc4838332cddfcc7273
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1375122
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616261}Add SetSelection to InputConnection interface.
This CL adds SetSelection method to InputConnection interface. It
provides the same functionality of InputConnection.SetSelection in
Android's InputConnection interface.
Bug: 908800
Test: unit_tests
Change-Id: I8b4eb840e91b319ec196bce4a733868dc449db09
Reviewed-on: https://chromium-review.googlesource.com/c/1362778
Reviewed-by: Mattias Nissler <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Commit-Queue: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616260}Mark *media/controls/buttons-after-reset.html as flaky.
Virtual tests don't inherit the expectation line for the base test.
[email protected],[email protected]
Bug: 910452
Change-Id: I2ef42f13f9fb69b6c2f653eada9c49bfa1bd4e0b
Reviewed-on: https://chromium-review.googlesource.com/c/1374983
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616259}[signin] Use vanilla FakeProfileOAuth2TokenService in BrowserStateInfoUpdater tests
Bug: 913895
Change-Id: Ie371ec75dd7f4e843676cfc366a1a09ec4154c83
Reviewed-on: https://chromium-review.googlesource.com/c/1371897
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616258}Improve the identity::SetRefreshForXXXAccount() API
Replace the pointer to a token value by a const reference with empty
string as default value. Fixed also the documentation.
This is a follow-up of crrev.com/c/1349983
Change-Id: Ie07a0c346177a48589ebac5797b0e84e86cf347b
Reviewed-on: https://chromium-review.googlesource.com/c/1371877
Commit-Queue: Sergio Villar <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616257}Snav: Check null pointer in IsOffscreen()
document->body() can be null. So we should do null checking
before use it.
Bug: 912896
Change-Id: I84d6abe30b500cfe00de58d9ee1c23d9cdedadbc
Reviewed-on: https://chromium-review.googlesource.com/c/1373730
Reviewed-by: Hugo Holgersson <[email protected]>
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616256}Rename IdentityGetAuthTokenFunction::GetIdentityManager()
It should be named GetMojoIdentityManager() instead as it isn't
returning an identity::IdentityManager but a
identity::mojom::IdentityManager.
BUG: 910202
Change-Id: Ia8f7fc3023c9606d32c66dd4cd99a4deb3e7a0d2
Reviewed-on: https://chromium-review.googlesource.com/c/1363183
Commit-Queue: Sergio Villar <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616255}Simplify SyncStartupTracker: don't use Profile (just SyncService)
Previously, SyncStartupTracker checked Profile::IsSyncAllowed before
getting a SyncService from the factory, presumably to avoid creating it
in case it doesn't exist yet. However, in all places where it's
constructed, we do already have a SyncService around.
So this CL changes SyncStartupTracker to just take a SyncService. This
generally makes things simpler, and it'll ease testing since we can
now use TestSyncService instead of ProfileSyncServiceMock (and don't
have to go through the factory, but can instead just inject the
dependency directly).
Bug: 910518
Change-Id: Iae3d92f7605d42b97d51dcff3afc9dcc29666cad
Reviewed-on: https://chromium-review.googlesource.com/c/1367654
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616254}Roll src/third_party/depot_tools 62d2286c53b2..03640c7fe5d5 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/62d2286c53b2..03640c7fe5d5
git log 62d2286c53b2..03640c7fe5d5 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Extend documentation for `git map-branches`
Created with:
gclient setdep -r src/third_party/depot_tools@03640c7fe5d5
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Ia111d409a9b706d6689ae45eb9e1a10f1d8560ed
Reviewed-on: https://chromium-review.googlesource.com/c/1375535
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616253}Fix test name collision in http/tests/fetch/serviceworker
Tests in http/tests/fetch/serviceworker calls service_worker_test with
its script name. Unfortunately the name conflicts with
WorkerTestEnvironment.prototype.next_default_text_name. If no tests
exists in the script, the default name is used and that results in
a "duplicate test name" error. Rename the test name from
TESTNAME to TESTNAME-serviceworker.
Bug: 914679
Change-Id: Id2e40cc222609bb01e354fa4aa24cfdbba267724
Reviewed-on: https://chromium-review.googlesource.com/c/1375179
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616252}Add unit tests for arc::ArcClipboardBridge
Bug: b:65127875
Test: components_unittests --gtest_filter="ArcClipboardBridgeTest.*"
Change-Id: Ib881c82ee9e31e3362ef35319aa43b7ab24112e4
Reviewed-on: https://chromium-review.googlesource.com/c/1369549
Commit-Queue: Satoshi Niwa <[email protected]>
Reviewed-by: Daichi Hirono <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616251}Add unit test for MultiMenuButton (sub-menus)
This is the initial unit test for the sub-menu implementation. The test
checks that showing the main menu hosted by a menu-button doesn't cause
the sub-menu to display.
Change-Id: I279300d073a09a4f6a8ef848f84b2662769fcabf
Bug: 762662
Reviewed-on: https://chromium-review.googlesource.com/c/1375191
Commit-Queue: Noel Gordon <[email protected]>
Reviewed-by: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616250}Remove GetSyncService() from SyncClient
We have a weird cyclic dependency between sync controllers and the sync
service itself, because some datatypes (including most directory
datatypes) need interactions with ProfileSyncService.
Prior to this patch, the issue was hackily buried by exposing
SyncService in SyncClient, although the interface's purpose is to
inject dependencies for ProfileSyncService itself.
In the new approach, the dependency is made explicit in controllers'
constructors. This involves more boilerplate code but has one important
benefit: controllers have now access to SyncService at construction
time, which wasn't the case before because GetSyncService() couldn't be
called in the constructor (otherwise an infinite loop was entered).
This means that certain steps like registering a SyncServiceObserver
can be done right away, without artifically deferring it to an
arbitrary time (usually LoadModels()).
Bug: 882777
Change-Id: I82c7ec783c42360cccf687daa016974c73f38a5c
Reviewed-on: https://chromium-review.googlesource.com/c/1373834
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Hiroshi Ichikawa <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616249}service worker: XSLT: Use response URL for the base URL.
This aligns with the standard. See
https://github.com/whatwg/fetch/pull/146
Chrome Status: https://www.chromestatus.com/feature/4857368017895424
No intent to ship because it's a trivial change.
Bug: 914135
Change-Id: I229aec6f8473bb6b7cdc88429afa830bc6eb80ed
Reviewed-on: https://chromium-review.googlesource.com/c/1372109
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616248}Presubmit warning fixes in //content/renderer/media/stream
Refactored base::ThreadChecker to THREAD_CHECKER macros.
HTTPS-ified various links.
Converted typedefs to usings.
This CL has no functional changes.
Bug: 811386
Change-Id: I3152898ca646cfdea4a8773fd0c0ca9390421d52
Reviewed-on: https://chromium-review.googlesource.com/c/1356983
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616247}Split network::cors::CalculateResponseTainting into Blink and network variants.
Previously, Blink was using network::cors::CalculateResponseTainting,
by converting SecurityOrigin to url::Origin. This discarded info about
origins that are whitelisted by SecurityPolicy. So the response type
was becoming opaque when an extension requested a URL that it should
have access to according to the SecurityPolicy.
Originally it was thought that url::Origin was sufficient because
Blink's CalculateCorsFlag() was supposed to check whether the
origin has access when doing a CORS request.
However, it turns out the SecurityPolicy whitelist is expected to allow
cross-origin access even in no-CORS request mode, so CalculateCorsFlag()
wasn't effective.
The solution is to split network::cors::CalculateResponseTainting into
blink::CalculateResponseTainting and
network::cors::CorsURLLoader::CalculateResponseTainting. Blink's
version uses SecurityOrigin to check for access.
Bug: 914261
Change-Id: Iff56e3fc08f14b163d8fef425caeca42e1b6f3e0
Reviewed-on: https://chromium-review.googlesource.com/c/1375297
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616246}Use base::size() instead of arraysize
This swaps the deprecated 'arraysize' macro for base::size(), in the
//content/browser/dom_storage/ folder. No change to logic.
Bug: 837308
Change-Id: I97a5bc00da50a61dc0f41abe916fc97591b0869a
Reviewed-on: https://chromium-review.googlesource.com/c/1375176
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616245}UMA for TrackAudioRenderer and WebRTCAudioRenderer device status
To identify how device authorization timeouts affect WebRTC audio
rendering
Bug: 914323,913476
Change-Id: Id33846a5dd34be0f35a7a21c414e2df35bdcdd90
Reviewed-on: https://chromium-review.googlesource.com/c/1373760
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Max Morin <[email protected]>
Commit-Queue: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616244}Separate InputConnectionImpl tests to another file.
No behavioral change.
Test: unit_tests --gtest_filter=InputConnectionImpl*
Change-Id: I60fc32541c6d032d9454bfc5eaa903ac11c727ed
Reviewed-on: https://chromium-review.googlesource.com/c/1373731
Commit-Queue: Yuichiro Hanada <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616243}Worker: Add a new error reporting path for top-level worker script fetch
Before this CL, unhandled runtime exceptions on WorkerGlobalScope and errors on
off-the-main-thread top-level worker script fetch are reported to the parent
execution context in the same way. According to the HTML spec, this was wrong.
For unhandled runtime exceptions, if it's also unhandled by the parent execution
context, that should be propagated to the grandparent execution context and so
forth. See the "Runtime script errors" algorithm:
https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2
On the other hand, for script fetch erros, that should just dispatch an error
event at the worker object in the parent execution context:
"Queue a task to fire an event named error at worker."
https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model
This CL adds a new error reporting path for errors on top-level worker script
fetch (WorkerReportingProxy::DidFailToFetchClassicScript()). This change fixes
web_tests failures when off-the-main-thread worker script fetch is enabled. In
those tests, script fetch errors are treated as unhandled exceptions and the
test harness complains it.
Note that this change affects only off-the-main-thread worker script fetch.
On-the-main-thread worker script fetch correctly dispatches the error event
without the propagation before this change (see DedicatedWorker::OnFinished()).
Change-Id: I093dc024a817516b88d062bcefc978935320418d
Bug: 835717
Reviewed-on: https://chromium-review.googlesource.com/c/1370230
Commit-Queue: Hiroki Nakagawa <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616242}[OnionSoup] Move background_fetch.mojom to blink/public/mojom/
This moves background_fetch.mojom from:
blink/public/platform/modules/background_fetch/
to:
blink/public/mojom/background_fetch/
TBRing reviewers:
jochen: Please reviewing changes in chrome/browser/DEPS
[email protected]
Bug: 789854
Change-Id: I0c67ae8e944d4e2c4c91da2511f933e6e91b9f70
Reviewed-on: https://chromium-review.googlesource.com/c/1370898
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Leon Han <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Richard Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616241}Rename WorkerClassicScriptLoader::forbid_cross_origin_redirects_
Follow-up of
https://chromium-review.googlesource.com/1368460
because after that CL the flag forbids cross-origin responses
even if there are no "redirects" (i.e. when a ServiceWorker
returns a cross-origin response).
Bug: 861965
Change-Id: I0e338527273149101f67b6dfe663667cf674aaa7
Reviewed-on: https://chromium-review.googlesource.com/c/1374572
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616240}Delete class WebrtcDummyVideoCapturer
Replaced with a DummyVideoTrackSource.
Bug: webrtc:6353
Change-Id: I6da52f7f9ed0611862bcd631d52dadee11bbf014
Reviewed-on: https://chromium-review.googlesource.com/c/1373837
Reviewed-by: Lambros Lambrou <[email protected]>
Commit-Queue: Niels Möller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616239}Roll src-internal 08df4d8cf37c..24ce372d6068 (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08df4d8cf37c..24ce372d6068
Created with:
gclient setdep -r src-internal@24ce372d6068
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Idfe3a16aab887ec7cb761b9aad435011827f817c
Reviewed-on: https://chromium-review.googlesource.com/c/1375458
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616238}TraceArguments: IWYU to fix the libstdc++ build
Follow-up to eebbd7f63c5 ("Introduce base::trace_event::TraceArguments
helper class"). The libstdc++ build is currently failing, add a few missing
headers to fix it:
* <cmath> for std::isfinite() and std::isnan()
* <string.h> for memcpy()
Bug: 819294
Change-Id: I370aa3ef245c5a23375a679b2ada7cb124f938e0
Reviewed-on: https://chromium-review.googlesource.com/c/1373767
Reviewed-by: David Turner <[email protected]>
Reviewed-by: oysteine <[email protected]>
Commit-Queue: Raphael Kubo da Costa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616237}Roll src/third_party/skia 58fc5d19ad1b..5f47971ca8b7 (1 commits)
https://skia.googlesource.com/skia.git/+log/58fc5d19ad1b..5f47971ca8b7
git log 58fc5d19ad1b..5f47971ca8b7 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Update go_deps asset
Created with:
gclient setdep -r src/third_party/skia@5f47971ca8b7
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: If4460e124f3924bab0d8a959b331e96ed584828b
Reviewed-on: https://chromium-review.googlesource.com/c/1375530
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616236}Update WATCHLISTS for dominickn.
BUG=None
Change-Id: I797d7043167ef7cd89c67a7db3b2e0e137e952de
Reviewed-on: https://chromium-review.googlesource.com/c/1375193
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Alexey Baskakov <[email protected]>
Commit-Queue: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616235}[AF] Log more info to debug rare flakiness in sync integration tests
CL to be reverted once the investigation is over.
Bug: 911953
Change-Id: Ie76891b6cb140b6a1244e17e12f2884310669484
Reviewed-on: https://chromium-review.googlesource.com/c/1373846
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616234}disable coverage tests pending v8 changes
disables coverage tests that will have incorrect offsets until
upstream v8 changes are landed.
[email protected], [email protected], [email protected]
Bug: v8:8381
Change-Id: I085a8c7a1f594360175491990b22b797dcc679a1
Reviewed-on: https://chromium-review.googlesource.com/c/1370322
Commit-Queue: Michael Lippautz <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616233}Settings WebUI: Update spacing between buttons in settings box
BUG=911375
Change-Id: I91a98fb01833d2b6814b2aa4aaeeec0e5e624d71
Reviewed-on: https://chromium-review.googlesource.com/c/1374834
Commit-Queue: Toni Baržić <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616232}Allow pinning Drive directories with DriveFS enabled.
Bug: 127831
Change-Id: Ie1fdd22133e2898f3ba7718cebeeafdd8290023e
Reviewed-on: https://chromium-review.googlesource.com/c/1373095
Commit-Queue: Sam McNally <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616231}Fix Headers mutation with "request-no-cors" guard
https://github.com/whatwg/fetch/pull/833
Bug: 905677
Change-Id: Ie4141c2b900931ef88e7734cb152b6d28955999f
Reviewed-on: https://chromium-review.googlesource.com/c/1352075
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616230}Don't send FrameMsg_Delete from ~RenderFrameHostImpl
Instead, actively notify the renderer when events that delete frames, to
ensure the renderer-side state is in sync. The problem with deleting in
the destructor is:
- it can send double-deletes: safe, but somewhat wasteful
- it can send deletes for frames it's not supposed to: bad, because many
things randomly break if the main frame is detached before the view is
shut down.
Eventually, this entire logic needs to be overhauled to work at a
subtree level, rather than node by node, like it does today.
Bug: 838348
Change-Id: I8926a99a68aaefac598777132c40c60948c3b49c
Reviewed-on: https://chromium-review.googlesource.com/c/1366020
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616229}v8binding: Unify ScriptValue::ToWorldSafeScriptValue to WorldSafeV8Reference
Remove ScriptValue::ToWorldSafeScriptValue and replace its usage
with WorldSafeV8Reference.
Bug: 501866, 755520, 803478
Change-Id: I75f38dd4d4dd8c3730bec1e9d002fadaa236395b
Reviewed-on: https://chromium-review.googlesource.com/c/1373894
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616228}[auto] Update FlagExpectations for LayoutNG
Following bot results are included.
12523 12525 12526 12529 12532 12534 12551 12558 12562 12564
12566 12567 12570 12572 12575 12577 12578 12580 12582 12586
12589 12595 12598 12600
5 lines were removed and 3 lines were deflaked by consecutive
results since 12570.
[email protected], [email protected]
NOTRY=true
Bug: 591099
Change-Id: I44bb98fb69c27bad4a647ee547376ca06a2ca4e2
Reviewed-on: https://chromium-review.googlesource.com/c/1369493
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616227}Move constructable stylesheets layout test to WPT
We're shipping constructable stylesheets soon, so moving the layout
test to WPT now.
Draft spec: https://wicg.github.io/construct-stylesheets/index.html
Bug: 807560
Change-Id: I37b45b6bbb1b17da51fbc41fbac5f11caabc5070
Reviewed-on: https://chromium-review.googlesource.com/c/1375296
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616226}Resource Scheduler: Remove unused code
Remove code related to PrioritySupportedRequestsDelayable
and HeadPriorityRequestsDelayable.
This code has not been used for more than a year
(http://shortn/_OtbnhRNYpq), and there are no plans to
revive it.
Change-Id: Ifda912e4dd58c8084b6c3e53ce8cddd09bd8ada4
Reviewed-on: https://chromium-review.googlesource.com/c/1374794
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616225}[EoS] Fix regression in scrolling to a part of the ESP
The state serialization part of the back navigation feature occasionally
saved its state too early in the loading process, resulting in
"restoring" navigation to the top of the page.
This patch creates the tab observer only after loading is completed.
Additionally allows placeholder ntp categories to be rendered.
Bug: 914565, 914535
Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6
Reviewed-on: https://chromium-review.googlesource.com/c/1374869
Commit-Queue: Justin DeWitt <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616224}Roll src-internal 5e9a2988a80c..08df4d8cf37c (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e9a2988a80c..08df4d8cf37c
Created with:
gclient setdep -r src-internal@08df4d8cf37c
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I39c694d83bc7a7ed82bcee5b2de1d2e6104a2a98
Reviewed-on: https://chromium-review.googlesource.com/c/1375529
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616223}[MDC roll] Roll Material Internationalization to d8f32464ac97d5551c8db19de916170ae87cfa90
Roll Material Motion Animator to d300ae8ac3131b5ffde017ee2c1747bcc126e647
Roll Material Motion Transitioning to 78ac32badf9ca9c1ad497a6131ce2bd539094812
TBR=smut
Change-Id: If21014b47280db4fd6fb10e117cfb3df1ef0b4e8
Reviewed-on: https://chromium-review.googlesource.com/c/1375376
Reviewed-by: iOS Autoroller <[email protected]>
Commit-Queue: iOS Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616222}[OnionSoup] Remove typemapping for content::BackgroundFetchSettledFetch
This CL de-couple the typemapping between
blink.mojom.BackgroundFetchSettledFetch and
content::BackgroundFetchSettledFetch.
content::BGFetchSettledFetch is remained since CloneResponse() and
CloneRequest() is widely used.
This work is a preparation for moving background_fetch.mojom
Bug: 789854
Change-Id: Ia4bb10a04e9e3f1b2878c2f84bc81d3b4466a857
Reviewed-on: https://chromium-review.googlesource.com/c/1371214
Commit-Queue: Richard Li <[email protected]>
Reviewed-by: Leon Han <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616221}Update Crashpad to 761c6fe8be0e18da9bb13b8dbdb57b4bf7be054b
3ca07134305c roll googletest to b18d39
c56557ae4a4f [fuchsia][arm64][snapshot] remove NOTREACHEDs
109bece2c3bc Added support for running crashpad that is embedded inside
a dll
1a9209b581b9 [fuchsia] actually clean up lock file in release mode
9b6dde910185 [fuchsia] remove Fuchsia-specific code in
MoveFileOrDirectory
761c6fe8be0e Add Windows ARM64 support to Chromium crashpad
Bug: 893460
Change-Id: I6f3cb01cdd7c30ed1ee5e963faab7ee87975ded1
Reviewed-on: https://chromium-review.googlesource.com/c/1375372
Commit-Queue: Mark Mentovai <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616220}Roll src/third_party/skia 17c574a193ad..58fc5d19ad1b (1 commits)
https://skia.googlesource.com/skia.git/+log/17c574a193ad..58fc5d19ad1b
git log 17c574a193ad..58fc5d19ad1b --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Use SkFont in GPU drawing step 1
Created with:
gclient setdep -r src/third_party/skia@58fc5d19ad1b
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I90f7ab8cb16d881026428dde14c32d1e1b78c416
Reviewed-on: https://chromium-review.googlesource.com/c/1375451
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616219}[Power ML]: Move Smart Dim call to new TaskRunner
Move the call to perform Smart Dim ML inference to a separate
TaskRunner. Also, modify UserActivityManager such that the result of the
inference is acted upon via callback instead of sychronously.
This is in preparation for a possible move to using the ML service, which
runs asynchronous inference calls that we don't want to block on the UI
thread.
Bug: 893425
Test: Builds and boots, inference calls checked via logs on nocturne.
Change-Id: I809f96da227272ae8640534ca58cb2645d1e23db
Reviewed-on: https://chromium-review.googlesource.com/c/1354036
Commit-Queue: Prashant Malani <[email protected]>
Reviewed-by: Jia Meng <[email protected]>
Reviewed-by: Andrew Moylan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616218}Only {MockFileSystem}s have a populate() method
Bug: 913307
Change-Id: I3456ca59d276edde242a17f38f4868543b30ffcb
Reviewed-on: https://chromium-review.googlesource.com/c/1375190
Commit-Queue: Noel Gordon <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616217}[App Management] Add app management Store.
This CL implements the app management Store and StoreClient, and adds
an action and a reducer to handle the onAppsAdded event.
Bug: 906508
Change-Id: I8bd4635ae7048e862f378c41cb63b9fe1e3342c6
Reviewed-on: https://chromium-review.googlesource.com/c/1371304
Commit-Queue: Reka Norman <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616216}media/gpu/vaapi: Use GUARDED_BY annotation in the Vaapi Wrapper.
This CL adds the necessary checks to make sure that all access to the underlying
VAAPI library is thread-safe.
TEST=ran VDA and JDA tests on Nocturne
BUG=909547
Change-Id: Ibf1ee6a8f2d07e31c1142eb7629e9c0e903d00a8
Reviewed-on: https://chromium-review.googlesource.com/c/1353063
Commit-Queue: David Staessens <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616215}Record duration of ad videos
Add metrics on duration of ad videos to determine how many
videos would be affected if playback time was limited for ads.
Bug: 912336
Change-Id: I8b4650ac46d4ba92b4e19dcb97d51b0d8ef86f33
Reviewed-on: https://chromium-review.googlesource.com/c/1364072
Commit-Queue: John Delaney <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616214}Adds metrics for history manipulation intervention
This CL uses the skippable flag on a NavigationEntry to log various
metrics.
There is no functional change.
Test: content_browsertests --gtest_filter=*SkipOnBack*
Bug: 907167
Change-Id: I9dd0e993a5d2afda49888bea3439b06b5f03b12c
Reviewed-on: https://chromium-review.googlesource.com/c/1347491
Commit-Queue: Shivani Sharma <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616213}Add unit test for AXNode kLanguage attribute inheritance.
R=aboxhall,dmazzoni
BUG=911018
Change-Id: I711792152fde499cec875144fd401acfa5b5fb72
Reviewed-on: https://chromium-review.googlesource.com/c/1375294
Reviewed-by: Alice Boxhall <[email protected]>
Commit-Queue: Chris Hall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616212}Disable the use of QUIC proxies for https:// URLs.
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/858603
BUG=914497
Change-Id: I378b42b01367aca8642d49b682b121f6f8873786
Reviewed-on: https://chromium-review.googlesource.com/c/1375112
Reviewed-by: Brad Lassey <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Brad Lassey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616211}Enabling crc32 ARM instruction in zlib for ChromeOS.
Using the ARM crc32 instruction can boost the speed of gzip content
decompression, which can improve performances in cases where lots of
webpages are served using 'content-encoding: gzip'.
Expected to have ~50% decompression speed improvement on elm.
Bug: 848897, 810125
Change-Id: I9f090950209e6a68271c6926700b7335e14c7cbf
Reviewed-on: https://chromium-review.googlesource.com/c/1372548
Commit-Queue: Adenilson Cavalcanti <[email protected]>
Reviewed-by: Adenilson Cavalcanti <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616210}Roll src-internal 51c94e769f38..5e9a2988a80c (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51c94e769f38..5e9a2988a80c
Created with:
gclient setdep -r src-internal@5e9a2988a80c
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I3dff9a1a7b7cf4c26977dffe344253fb4fa5d6b7
Reviewed-on: https://chromium-review.googlesource.com/c/1375450
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616209}Remote Playback: create Controller/Observer to allow core/ to be notified of changes.
This will allow the video wake lock implementation in Blink to change its
behaviour depending on remote playback state and will allow the remote
playback overaly to be moved out of modules/media_controls/
Bug: 913668, 903793
Change-Id: I473254b8108e612c52bdb55f4bd880ab0441922f
Reviewed-on: https://chromium-review.googlesource.com/c/1374951
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616208}Use pkg-config to find libva on Linux
Otherwise build can fail or not use the wanted libva version
when the gn arg use_vaapi is set to true (default is false).
Bug: 913118
Change-Id: I17c9199d032473bd10f45ae798e1ed4c2212a129
Reviewed-on: https://chromium-review.googlesource.com/c/1368950
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Julien Isorce <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616207}Filter intent_helper apk in ArcIntentHelperBridge
ArcIntentHelperBridge offers ShouldChromeHandleUrl(const GURL& url) as a
way to early tell whether or not ARC has an installed app candidate that
could deal with a passed |url|. Currently AppsNavigationThrottle uses
this method as a pre-filter, done in Chrome-side whenever we wonder
whether or not query ARC, given the async nature of this query, we need
to double check that there are actual app candidates installed before
showing saying so to the user via the intent picker's omnibox icon.
This CL filters out intent_helper's apk package name as a candidate on
ArcIntentHelperBridge, it also verifies that the async query actually
return a valid installed app candidate before making changes to the
omnibox.
Bug: 914496
Test: Adding unit tests for this behavior, previous tests still pass.
Change-Id: I2f3da1c6b6bdc67938b8413a7c06e7a51e9e8474
Reviewed-on: https://chromium-review.googlesource.com/c/1372921
Reviewed-by: Yusuke Sato <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: David Jacobo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616206}Updating trunk VERSION from 3639.0 to 3640.0
# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]
Change-Id: I6e22b662cd03663d78c2171c8fb1c7217a03a421
Reviewed-on: https://chromium-review.googlesource.com/c/1375375
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616205}Fixes cleanup check for non-parent owned windows
NOTRY=true
[email protected],[email protected]
Change-Id: I8ca0b4f6d466d5ac45260d5fbd5a874565d17a92
Reviewed-on: https://chromium-review.googlesource.com/c/1375113
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616204}Fix typo in field_trial_params.h
constexpr FeatureParam<Enum>::Option[] kOptions[] = { ... } causes
a compile error. We don't need brackets after FeatureParam<Enum>::Option.
Change-Id: I4a64c253b22cc2e3cd219e1fb9fbe74e6038ae67
TBR: [email protected]
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/1375289
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616203}Mark gl-max-texture-dimensions test (passthrough) as flaky on Nexus 5X
This test has been flaking on the android-marshmallow-arm64-rel trybot
for a while e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/150428
[email protected]
Bug: 914631
Change-Id: I5e5f640ba8386296dda8dc8c7607ce50ec1a2236
Reviewed-on: https://chromium-review.googlesource.com/c/1374977
Reviewed-by: Sunny Sachanandani <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616202}Roll src/third_party/catapult 296353761198..368ebf1e07cb (1 commits)
https://chromium.googlesource.com/catapult.git/+log/296353761198..368ebf1e07cb
git log 296353761198..368ebf1e07cb --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] [devil] Add special system app removal logic
Created with:
gclient setdep -r src/third_party/catapult@368ebf1e07cb
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I0ed11c7d0fbb573334817e1abf0fd2f130520b21
Reviewed-on: https://chromium-review.googlesource.com/c/1375231
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616201}Roll src/third_party/perfetto b2b022870864..85d294307e70 (3 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/b2b022870864..85d294307e70
git log b2b022870864..85d294307e70 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] Merge "trace_processor: remove ulong column type"
2018-12-12 [email protected] Merge "Watchdog: deliver task time out SIGABRT to caller thread"
2018-12-12 [email protected] Merge "Fix mac build"
Created with:
gclient setdep -r src/third_party/perfetto@85d294307e70
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I2b2b90ee1ac39c97e7f11b7c9665bf2752446f4b
Reviewed-on: https://chromium-review.googlesource.com/c/1375249
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616200}Don't use unique_ptr for Assistant sub-controllers.
These sub-controllers should exist for AssistantController's entire
lifetime.
Bug: b:120794335
Change-Id: I44ac57c596ebc8f99a6d5148ffb7df748fc4ffb9
Reviewed-on: https://chromium-review.googlesource.com/c/1371200
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616199}Revert "pdf: Introduce content controller abstraction"
This reverts commit 6b4d81b2d610bba6e691389b2ef771db17c40498.
Reason for revert: Breaks navigation
Original change's description:
> pdf: Introduce content controller abstraction
>
> Primary motivation is to enable the plugin to be swapped out for the
> Ink-based PDF renderer in annotation mode.
>
> * An abstract `ContentController` class is added. This abstracts the
> logic that pdf_viewer used to communicate with the plugin so that
> the Ink component can replace it. Most plugin logic has been moved
> to `PluginController`, this also required adding many new APIs to
> `PDFViewer` to allow messages from the plugin to behave as before
> without exposing too much of `PDFViewer` private details. There are
> still some uses of `plugin.postMessage` that can be converted to
> `ContentController` APIs in future.
> * The PDF saving logic has been slightly rewritten using promises.
> Instead of storing only tokens, at save-request time a promise
> is created and associated with the token. When the save data
> becomes available (or is consumed) the promise is resolved.
>
> Bug: 902646
> Change-Id: Ic33b7c250eb54515564a3646283e3897419984af
> Reviewed-on: https://chromium-review.googlesource.com/c/1368845
> Commit-Queue: dstockwell <[email protected]>
> Reviewed-by: Henrique Nakashima <[email protected]>
> Reviewed-by: Demetrios Papadopoulos <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615028}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 902646
Change-Id: I1cfb8b83d4121f91c0e6085132b95eec4d6e4433
Reviewed-on: https://chromium-review.googlesource.com/c/1374962
Reviewed-by: Henrique Nakashima <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616198}DevTools: fix flickering, unwanted node highlight in Elements
Panel switching and page reloading could trigger re-focusing the
ElementsTreeOutline, producing unwanted node overlays.
In this CL
- Trees highlight nodes when selection changes (pre-Nov behavior),
instead of highlight on focusin
- Hide node highlight when focus moves to non-highlightable elements
- Console will use a custom method to select and ensure the node is
highlighted
Bug: 913084
Change-Id: I8b56b77c0aa8c34f5f7a819434510d549b139650
Reviewed-on: https://chromium-review.googlesource.com/c/1368770
Reviewed-by: Joel Einbinder <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616197}Vaapi: Use GUARDED_BY() static annotations on decoder
This CL introduces GUARDED_BY() static annotation on VaVDA; not all
members variables need to be guarded, so it adds on a number of them
a comment about on which thread it is used.
Bug: 909547
Change-Id: I437a82320795aebc56f77cd1254bb7c8c2f2f5da
Reviewed-on: https://chromium-review.googlesource.com/c/1368590
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616196}Roll src/third_party/depot_tools 143872d11b6f..62d2286c53b2 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/143872d11b6f..62d2286c53b2
git log 143872d11b6f..62d2286c53b2 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Roll recipe dependencies (nontrivial).
Created with:
gclient setdep -r src/third_party/depot_tools@62d2286c53b2
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I5a25cf0ab0deddb57639242a44301ddac65b922d
Reviewed-on: https://chromium-review.googlesource.com/c/1375449
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616195}Roll src/third_party/dawn 8d08d23a6642..ff9562f7927b (1 commits)
https://dawn.googlesource.com/dawn.git/+log/8d08d23a6642..ff9562f7927b
git log 8d08d23a6642..ff9562f7927b --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Implement 'baseVertex' in drawIndexed() on D3D12, Metal and Vulkan
Created with:
gclient setdep -r src/third_party/dawn@ff9562f7927b
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ia0a24cbee5979b765f921956393613c935bf59af
Reviewed-on: https://chromium-review.googlesource.com/c/1375233
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616194}import_controller_unittest: add a default metadata helper
Add a default metadata helper routine, and use it at call sites.
Bug: 914197
Change-Id: Ib1de53438db145e5f266db92cce35bef211c83f9
Reviewed-on: https://chromium-review.googlesource.com/c/1375170
Reviewed-by: Sam McNally <[email protected]>
Commit-Queue: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616193}Field Trial: Drop runtime flag for V8ContextSnapshot
Experiment and field trial for V8 context snapshot project
was done successfully, and we no longer need this flag.
The feature is enabled by default on Windows/MacOS/Linux.
This CL is essentially a revert of https://chromium-review.googlesource.com/c/chromium/src/+/645408/
Bug: 912157
Change-Id: I59d93bf3193ff4b5d81b1d9fb147b643f820568f
Reviewed-on: https://chromium-review.googlesource.com/c/1367066
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616192}Reland change to trigger autofill tests on main branch commit.
Bug: 885350
Change-Id: I705870f87c38460d7169c41ef954683c4838c239
Reviewed-on: https://chromium-review.googlesource.com/c/1374394
Reviewed-by: Stephen Martinis <[email protected]>
Reviewed-by: smut <[email protected]>
Reviewed-by: Sergey Berezin <[email protected]>
Commit-Queue: Yiming Zhou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616191}Make LoadIconFromExtension check Chrome-OS-ness
The icon loading helper functions, prior to both this CL and
http://crrev.com/c/1373450, called app_list image processing functions
unconditionally, which broke the build, as app_list is Chrome OS only.
The quick fix was to build app_icon_factory.cc conditionally, only for
Chrome OS. This was http://crrev.com/c/1373450
This fix is to make more of app_icon_factory.cc conditional on #ifdef
OS_CHROMEOS. The App Service isn't necessarily Chrome OS only.
A longer term possibility is to move the app_list image processing
function out of //chrome/browser/ui/app_list per se, and build it
unconditionally. This would be a user-visible change (in that extension
icons on desktop Chrome might look different), but arguably a change
that improves consistency. In any case, doing that is out of scope of
this CL. In the initial stage, the App Service aims to be a
user-invisible refactoring.
BUG=826982
Change-Id: Ic4fd3db27789117bb57e72e6b557b3e56b28fb7f
Reviewed-on: https://chromium-review.googlesource.com/c/1374889
Commit-Queue: Nigel Tao <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616190}Reenable low latency canvas2d pixel test after rebaselining
[email protected]
Bug: 914206
Change-Id: I9f1e5bbf513640fb9ec17d0b1d1cebe06a02d549
Reviewed-on: https://chromium-review.googlesource.com/c/1374360
Commit-Queue: Sunny Sachanandani <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616189}[Android WebAPK]: Add test for WebAPK share target updates
This CL:
- Adds a test to check that an update is requested when the
share target in the Web Manifest is updated.
- Adds parameter to WebApkTestHelper#register() to register a WebAPK
with share targets
- Refactors WebApkShareTargetUtilTest to register share targets via
WebApkTestHelper
BUG=913489
Change-Id: Ie8244f62e9c9855e97324591abfaaefb3421d420
Reviewed-on: https://chromium-review.googlesource.com/c/1369525
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616188}Roll src-internal e22735ae721d..51c94e769f38 (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e22735ae721d..51c94e769f38
Created with:
gclient setdep -r src-internal@51c94e769f38
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I9b89ac509f75ec9576c5afd5e386bef70a9a44a9
Reviewed-on: https://chromium-review.googlesource.com/c/1375230
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616187}Revert "Make sure TypeId works with components"
This reverts commit ac076988a89fe54e2101c05c9f0dac05677796d8.
Reason for revert: base_unittests failing on Win 7/10
Original change's description:
> Make sure TypeId works with components
>
> Make the dummy_var globally visible so that we only have one instance
> across all shared libraries, executables etc.
>
> Bug: 906125
> Change-Id: I0aba75171ea3f55aa5440eb73a11713ed952f5bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1367671
> Reviewed-by: Daniel Cheng <[email protected]>
> Reviewed-by: Gabriel Charette <[email protected]>
> Reviewed-by: Alex Clarke <[email protected]>
> Commit-Queue: Carlos Caballero <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616120}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I83f9b8d8c14b81317112d531cdd57b507149d324
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 906125, 914651
Reviewed-on: https://chromium-review.googlesource.com/c/1375293
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616186}Roll src/third_party/skia 9a1e3a852f05..17c574a193ad (3 commits)
https://skia.googlesource.com/skia.git/+log/9a1e3a852f05..17c574a193ad
git log 9a1e3a852f05..17c574a193ad --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] use font for measuring
2018-12-12 [email protected] Revert "Remove Android compile bots from CQ"
2018-12-12 [email protected] Generate debug information during link with Windows-Clang
Created with:
gclient setdep -r src/third_party/skia@17c574a193ad
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I1c6ab534372b65f83c820d1fbce28408af16d3b1
Reviewed-on: https://chromium-review.googlesource.com/c/1375250
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616185}[Duet] Three button tab switcher bottom toolbar
This CL makes the tab switcher bottom bar have three buttons:
close all tabs, new tab, and menu buttons.
Bug: 914039
Change-Id: Ibf3555e838d6c63327c197dd16b0a5529b02db3f
Reviewed-on: https://chromium-review.googlesource.com/c/1364069
Commit-Queue: Pedro Amaral <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616184}Roll src/third_party/chromite 89d93d297c3e..e69db6685edf (3 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/89d93d297c3e..e69db6685edf
git log 89d93d297c3e..e69db6685edf --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] cbuildbot: Add logic to build dependencies for tests with no build stage
2018-12-13 [email protected] Remove unused buildbot_waterfall_name from config settings dict
2018-12-13 [email protected] cros_chrome_sdk: Support for --require-exact-version
Created with:
gclient setdep -r src/third_party/chromite@e69db6685edf
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I8979fe6f59910cc241473208556534375b003f28
Reviewed-on: https://chromium-review.googlesource.com/c/1375251
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616183}Remove RenderFrameImpl::DidReceiveResponse
We already handle the main resource response during CommitNavigation.
The only missing bit was the fake "200" status code for data urls,
which we can set in BuildDocumentState.
This approach differs with existing one in the following cases:
1. Data urls committed as WebData (as opposite to a fake WebURLRequest)
don't get 200 currently. This seems like a bug - we should either mark
all data urls as 200, or none.
2. Due to browser-side navigation, DidReceiveResponse may encounter a
placeholder document loader for some outstanding requests (e.g. favicon from
previous load). This leads to using wrong alpn negotiated protocol and/or
status code, which is definitely a bug.
3. Test-only path which skips RenderFrameImpl entirely for subframes when
loading an html string - it does not set 200 for data urls. This is a
test-only issue, which is again fixed with the new approach.
Bug: 855189
Change-Id: I5e2d0e539f9e5c3ad1a8af1153390dff2bfb678b
Reviewed-on: https://chromium-review.googlesource.com/c/1272135
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616182}[Navi] Add missing metrics for remaining pages in onboarding workflow.
Metrics added for:
- Landing Page
- Set Default Browser Page
- Sign In Page
- Email Interstitial Page
Bug: 874154
Change-Id: I8c9098a343ec8be9dad3b20ec3b7cdc96660d51e
Reviewed-on: https://chromium-review.googlesource.com/c/1371245
Commit-Queue: Hector Carmona <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616181}Some cosmetic change for QUIC connection migration code.
Change the QuicConnectivityProbingManager::CancelProbing to take peer
address and enforce a strong match when cancel running probing. Also fix
some comments to prepare QuicConnectivityProbingManager to probe for
server preferred address. No behavior change.
Bug: 913733
Change-Id: I234e892c2839babd0bb0c76917db218976ca5179
Reviewed-on: https://chromium-review.googlesource.com/c/1373035
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Zhongyi Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616180}Manually add a domain to HSTS preload list that only supports TLS 1.3
Change-Id: I5a15ec0370715745a5dad30beccb059d8125babe
Reviewed-on: https://chromium-review.googlesource.com/c/1374873
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Nick Harper <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616179}Revert "viz: Do not send hit-test data unless it has been updated."
This reverts commit 5d1a299da673ba215bb76cb9cb116c0d46f05df0.
Reason for revert: cc_unittests failing on multiple builders
Original change's description:
> viz: Do not send hit-test data unless it has been updated.
>
> Aggregation only occurs when new hit-test data has been
> submitted.
>
> R=[email protected]
>
> Bug: 762251
> Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796
> Reviewed-on: https://chromium-review.googlesource.com/c/1294838
> Commit-Queue: Alexander Shah <[email protected]>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
> Reviewed-by: Avi Drissman <[email protected]>
> Reviewed-by: danakj <[email protected]>
> Reviewed-by: Tom Sepez <[email protected]>
> Reviewed-by: Ria Jiang <[email protected]>
> Reviewed-by: Robert Kroeger <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616135}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Icad5086a846890552af8734e315eeaa382923a8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762251, 914642
Reviewed-on: https://chromium-review.googlesource.com/c/1375291
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616178}media/gpu: Add MEDIA_GPU_EXPORT to CreatePlatformVideoFrame
CreatePlatformVideoFrame is build as a part of libmedia_gpu.so and is used in
video_decode_accelerator_tests as an exported function from libmedia_gpu.so.
Therefore, it must be marked by MEDIA_GPU_EXPORT.
[email protected]
BUG: None
TEST: Build video_decode_accelerator_tests for chromeos-linux
Change-Id: I9d1063a5e1023af5369c61e72c3d3f95f47b0102
Reviewed-on: https://chromium-review.googlesource.com/c/1375169
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616177}[Feed] Import feed@43c0099ed87741d143f5c7bde5b9213faa5364b4
Specifics:
+66,376 bytes main lib size
+483,416 bytes main dex size
+780,952 bytes normalized apk size
InstallSize:
+300,338 bytes APK size
+865,935 bytes Estimated installed size (Android Go)
+2,253,339 bytes Estimated installed size
InstallBreakdown (+2,253,335 bytes):
+2,802 bytes unwind_cfi (dev and canary only) size
+2,672 bytes Non-compiled Android resources size
+66,376 bytes Native code size
+593 bytes Package metadata size
+2,164,536 bytes Java code size
+16,356 bytes Compiled Android resources size
Dex:
+2,463 entries fields
+3,491 entries methods
+794 entries types
+1,732 entries strings
Bug: 912674, 911487
Change-Id: If33ad6a415ef64db8cd896b4ac10e7f205c65eef
Reviewed-on: https://chromium-review.googlesource.com/c/1374870
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Filip Gorski <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616176}[Extensions Click-to-Script] Pull site access into a separate section
In the chrome://extensions page, pull the "Site Access" controls into
a separate section below "Permissions", rather than being included
within it. Add a string to show when there are no control options for
site access. Update tests.
Bug: 914523
Change-Id: Ifde722f030001f116d00a5210df1e561c9889362
Reviewed-on: https://chromium-review.googlesource.com/c/1373881
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616175}Add //libassistant/* to protobuf_full
Allows //libassistant/* targets to depend on :protobuf_full for testing.
Bug: b/120635644
Change-Id: I3179729f81f6aadea9d95fe2aa7378f2f8291f5b
Reviewed-on: https://chromium-review.googlesource.com/c/1371189
Commit-Queue: Jordan Werthman <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616174}Roll src/third_party/depot_tools 3d7ef65eef5b..143872d11b6f (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d7ef65eef5b..143872d11b6f
git log 3d7ef65eef5b..143872d11b6f --date=short --no-merges --format='%ad %ae %s'
2018-12-13 [email protected] Update git recipes to use buildbucket API.
Created with:
gclient setdep -r src/third_party/depot_tools@143872d11b6f
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:902400
[email protected]
Change-Id: Id2facf0312e631d635838fe177cb51b07b0c5dae
Reviewed-on: https://chromium-review.googlesource.com/c/1375149
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616173}Apply correct ink drop ripple and highlight state after view resize
Only the active state was handled previously for the ink drop ripple,
and the visible state wasn't set at all on the highlight. This CL
handles all ink drop ripple cases and the highlight visible state.
BUG=905586,911770
R=mohsen
Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0
Reviewed-on: https://chromium-review.googlesource.com/c/1366492
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Mohsen Izadi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616172}Reland "allocator: Add Windows _aligned_* shims"
This is a reland of 0ba5ea124ec9de7d786cf6f4fc4ab2847c8d785e with a
missing #if DCHECK_IS_ON() added.
Original change's description:
> allocator: Add Windows _aligned_* shims
>
> On Windows we don’t currently hook the _aligned_* allocation APIs, this
> can cause issues because _aligned_realloc can call HeapSize and cause
> GWP-ASan crashes similar to bug 909720. Unfortunately the
> _aligned_realloc API is different enough that it can not be implemented
> using the standard POSIX shims, in particular because _aligned_malloc
> and _aligned_free don't return valid allocation addresses, they are
> offsets into allocations.
>
> I add new Windows platform-specific shims for _aligned_malloc,
> _aligned_realloc, and _aligned_free and wire them in for all users of
> the allocator shims. I implement these routines on top of the Windows
> Heap* API and leave uncommon _aligned_* shims to crash to ensure that
> any future uses immediately surface why their use fails.
>
> Bug: 912500, 896019
> Change-Id: Ieaa50b816ab277a6ad4b80ee8519027343fa9878
> Reviewed-on: https://chromium-review.googlesource.com/c/1367485
> Reviewed-by: danakj <[email protected]>
> Reviewed-by: Vitaly Buka <[email protected]>
> Reviewed-by: Alexei Filippov <[email protected]>
> Reviewed-by: Erik Chen <[email protected]>
> Reviewed-by: Will Harris <[email protected]>
> Reviewed-by: Sigurður Ásgeirsson <[email protected]>
> Commit-Queue: Vlad Tsyrklevich <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616106}
[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 912500, 896019
Change-Id: I05aeb4bc9ef2974f967a81c53cb7bbbcc6e955f3
Reviewed-on: https://chromium-review.googlesource.com/c/1374959
Reviewed-by: Vlad Tsyrklevich <[email protected]>
Commit-Queue: Vlad Tsyrklevich <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616171}[VK] Fix header file preprocessor comment.
Follow up on
https://chromium-review.googlesource.com/c/chromium/src/+/1368853/5/ui/keyboard/test/test_keyboard_ui.h#44
[email protected]
Change-Id: I076bc45e456ce0309cb36ce18ec93f23c2bc4622
Reviewed-on: https://chromium-review.googlesource.com/c/1375171
Reviewed-by: Darren Shen <[email protected]>
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616170}Reland of: [code coverage] Add all fuzzer targets
Now with a fix for the issue in GenerateIsolates().
R=jbudorick,stgao,liaoyuke
> Change-Id: I78ffec6525cd1d808a4b431ae1e2729b76357d46
> Reviewed-on: https://chromium-review.googlesource.com/c/1372917
> Commit-Queue: Shuotao Gao <[email protected]>
> Reviewed-by: Shuotao Gao <[email protected]>
> Reviewed-by: John Budorick <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615834}
Change-Id: I4ae0ef2588026bb6e0e5501e9ff39a7852d89afa
Reviewed-on: https://chromium-review.googlesource.com/c/1374777
Reviewed-by: Yuke Liao <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Roberto Carrillo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616169}Report the TTFB of SPDY headers as the time that the BufferedSpdyFramer received header metadata
Currently, we report `recv_first_byte_time` to a SpdyStream as the time
after all headers have been parsed. In the case of large headers that
span multiple packets, this is often incorrect. Use the time that the
BufferedSpdyFramer received the start of the HEADERS packet instead.
Bug: 568024
Change-Id: Ic5549acd380e70c8c073d3f1d6ef9243b31135d8
Reviewed-on: https://chromium-review.googlesource.com/c/1372471
Commit-Queue: Andrew Comminos <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616168}Consider NATIVE_OR_DRIVE_PATH when relaxing dialog restrictions.
If allowedPaths is NATIVE_PATH, in some circumstances, the value is
replaced by a more permissive allowedPaths (either NATIVE_OR_DRIVE_PATH
or ANY_PATH). However, if NATIVE_OR_DRIVE_PATH is used, no replacement
is considered. In the case of open file dialogs, this results in
NATIVE_OR_DRIVE_PATH being more restrictive than NATIVE_PATH (which is
relaxed to ANY_PATH). Apply the same transforms to allowedPaths when the
input is NATIVE_OR_DRIVE_PATH.
Change-Id: I2939a5647c781cce73c88f2f45d199288370279b
Reviewed-on: https://chromium-review.googlesource.com/c/1372481
Reviewed-by: Noel Gordon <[email protected]>
Commit-Queue: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616167}Validate release_count and output_size in a ScheduleImageDecode request.
This CL adds code to make sure that
a) ScheduleImageDecode requests are submitted in order, i.e., the
release_count of the sync tokens is strictly increasing and starts at >= 1.
b) The output_size parameter is at least 1x1.
Additionally, the overflow check for the output data size is removed as that
will be delegated to the ImageDecodeAcceleratorWorker later when it needs to
calculate the data size and allocate memory for the output.
Test: this CL adds unit tests for the validation code.
Bug: 868400
Change-Id: Ia3348668a9f8df982d2ed31729bfcd1382282cd0
Reviewed-on: https://chromium-review.googlesource.com/c/1368595
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616166}Rename chrome/browser/net/spdyproxy to chrome/browser/data_reduction_proxy
This proposal is to remove the nomenclature spdyproxy, since that can have
different meaning in //net.
Bug: 910667
Change-Id: I05ecfe6b09dd102ac7b42a1291b311037d1386c5
Reviewed-on: https://chromium-review.googlesource.com/c/1367083
Commit-Queue: Zhuoyu Qian <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616165}Add UMA for catalog loading:
1. Add UMA for which path caused the load, background, EoS, or NTP.
2. Add UMA for the outcome of the load, new catalog, unchanged, or failure.
Also add unit tests for the C++ side histograms.
Bug: 910429
Change-Id: I56e06b1dcc5b7f977fd3646e199767c1194c4c02
Reviewed-on: https://chromium-review.googlesource.com/c/1357211
Commit-Queue: Peter Williamson <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616164}Fix some nits in chromeos/system/devicetype.cc.
No need for else after return.
Change-Id: I22d37706292d023848380038eee4b2c996c63076
Reviewed-on: https://chromium-review.googlesource.com/c/1336445
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616163}Control windows lld-link thin archive flag with config("thin_archive")
We're trying to build a self-contained static library of V8, for
inclusion in a Cargo crate. This is part of the broader effort to make
Deno (https://github.com/denoland/deno) available as a crate.
Currently it's not possible to build 'fat' static libraries with
lld-link, because the `/llvmlibthin` flag is hard-coded into the
windows toolchain.
The equivalent on posix platforms, ar's `-T` flag, is managed by the
`thin_archive` config. This config is enabled by default, but it can be
explicitly removed from a target when necessary.
This patch changes places the `/llvmlibthin` flag under control of
config("thin_archive") also.
This causes static_library targets that use the thin_archive machinery
to not be thin archives on Windows either. There aren't many of these
targets, and this looks like a neutral-to-vaguely-good change for these
targets on Windows.
Change-Id: If756650146459c4029d7925592e32dbe74650edf
Reviewed-on: https://chromium-review.googlesource.com/c/1372633
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616162}Worker: Add japhet@ to core/workers/OWNERS
Bug: n/a
Change-Id: I7f6aa6003271345a0c4a3cfeda9e4d78b44baac8
Reviewed-on: https://chromium-review.googlesource.com/c/1373429
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616161}Explicitly output the list of flaked and failed tests to logs for iOS.
Currently, both flaked and failed tests are outputted on a per test case
basis to logs, in identical fashion, making it hard to tell if a test is
flaking or failing. Outputting these lists in the same way as we do
the "passed tests" list will make it easier to differentiate these two.
Change-Id: I7c0deaf749e4795b22033da4b5acea6c029242c3
Reviewed-on: https://chromium-review.googlesource.com/c/1374953
Reviewed-by: Sergey Berezin <[email protected]>
Commit-Queue: ericale <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616160}Make sure to CompleteDrag in FlingOrSwipe for PipWindowResizer.
Looks like in some rare cases, ET_GESTURE_SWIPE was being passed which
wasn't handled. This meant the PIP window would get stuck occassionally.
stuck
Test: tried swiping around a lot (see bug) and PIP window did not get
Bug: 910764
Change-Id: Ifc50ef6971a00e9dc6be4e48446819b42160f0ab
Reviewed-on: https://chromium-review.googlesource.com/c/1373411
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Commit-Queue: Eliot Courtney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616159}[android] Sort list of Java sources
Sort the Java source files in
chrome/android/java_sources.gni
Change-Id: I773baf11cefa2c7c923731ff0d1517b4225353e0
Reviewed-on: https://chromium-review.googlesource.com/c/1355306
Commit-Queue: Eric Willigers <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616158}Fix PWA caption button size on Linux
CC=alancutter
R=pkasting,sky
BUG=911770
Change-Id: I9c591be16ba1c38531834e3cd7e9998c5e3567d8
Reviewed-on: https://chromium-review.googlesource.com/c/1374354
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616157}[App Management] Refactor main view
This CL adds an app-management-item element, and creates shared constants,
css and vars files.
Bug: 906508
Change-Id: I29dce3a6745e8957ee1fb547cbe2e72290567f28
Reviewed-on: https://chromium-review.googlesource.com/c/1371308
Commit-Queue: Cecilia Ni <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Eric Willigers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616156}[LayoutNG] Exclude trailing preserved spaces when avoiding floats
This patch fixes an interoperability issue where trailing
preserved spaces should be excluded when avoiding floats.
All 4 implementations are interoperable on this regard.
This patch adds NGLineInfo::HasOverflow(), because knowing
whether the line has overflow or not is easy and fast,
while knowing the exact inline size excluding trailing
preserved spaces may involve reshaping.
Other cases also have interoperability problems, such as
`text-align` or `min-content`. I'll investigate them in
following patches.
Bug: 913995
Change-Id: Ibf13f1fcc28bbd99d44b56611141efa49d6d1c89
Reviewed-on: https://chromium-review.googlesource.com/c/1374329
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616155}[Media Controls] Use Gesturetap events over click events when tapping
Currently, the media controls rely on "click" events that happen as a
result of "gesturetap" events. This has a couple of issues, including
a bug where a website's handling of touch/gesture events prevented the
controls from appearing (since the gesturetap never reached the point
of invoking a click event), and having the video receive focus on tap
events instead of just click events.
This CL changes the controls to make use of gesturetap events as well.
In particular, the touch handling logic on MediaControlsImpl that used
to depend on click events (since it was using MouseEvent positioning)
has been updated to use WebGestureEvent positioning so that it can be
triggered via a gesturetap.
Bug: 913377
Change-Id: I1251aaf89753b0770f905edf61f7934100f9a6c6
Reviewed-on: https://chromium-review.googlesource.com/c/1371126
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616154}cros: Show login shelf guest button during enterprise enrollment
Bug: 587084
Change-Id: I629b9dd61ce126232bff3c48c3c84a657d9d4938
Reviewed-on: https://chromium-review.googlesource.com/c/1374673
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Quan Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616153}[Supersize] Add linker_map_parser_test.py and test_util.py.
We plan to update linker_map_parser.py to extract more Level 3 symbols
from .map files. As seen in crbug.com/892648, there are many cases that
need to be handled.
This CL adds linker_map_parser_test.py, which takes the identified
issues from Android Chrome's .map file as test cases. Details:
* Currently focus on ARM (32-bit) builds using LLD with ThinLTO.
* Similar to integration_test.py, the '--update' can be specified to
overwrite "golden" output files with current output.
* Add test_util.py to factor common code involving usage and
management of "golden" files.
* The initial Parser.golden is obtained from running the test for
unmodified linker_map_parser.py. This allows upcoming parser changes
to be tracked.
Bug: 892648
Change-Id: Ia8a4dbce4c235f2b08df2bb848409caffcedac32
Reviewed-on: https://chromium-review.googlesource.com/c/1373873
Commit-Queue: agrieve <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616152}Add background externs media_import_handler.js to the Closure BUILD
This change adds media_import_handler.js to the Closure BUILD and type
checks it and also the externs it uses. Immediate result: many Closure
compile errors since the types it uses do not have an externs file, or
the constructor signatures are incomplete or just plain wrong [1].
[1] importer.MediaImportHandler.ImportTask @extends TaskQueue.BaseTask
but the constructor signature in the externs file does not (Closure is
not silly, and spots that error). Next issue: TaskQueue.* doesn't have
an externs file, which one might use to fix the first error.
Typical fix would be to use Impl pattern, add three new externs files,
etc. The result would be a large, intrusive change. Simpler, type-safe
methods are sought and are readily available.
Closure externs can forward declare dependent class types, even define
their constructors, to allow the constructor signature of the class of
interest to be fully defined, complete with the dependent @param types
that Closure can enforce.
Use this fact in externs media_import_handler.js: forward declare, and
define the constructors / interfaces as needed, of the dependent types
namely, TaskQueue.*, DispositionChecker.*, that do not have an externs
file. Define importer.MediaImportHandler with @params for Closure type
checking.
What about the implementations? Simply update the implementation JSDoc
with one additional annotation line:
@return undefined
With that, Closure type-checks the constructor definition by comparing
it with the signatures defined in the externs file, and concludes that
it does match, that it does not "re-define" any externs file types.
No change in test behavior.
Bug: 914197
Change-Id: I15c02cd4ab83c19bef1882e77702e975fa1fdc2e
Reviewed-on: https://chromium-review.googlesource.com/c/1373893
Reviewed-by: Stuart Langley <[email protected]>
Commit-Queue: Noel Gordon <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616151}Roll src/third_party/angle b08457df2325..9b02506c852b (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/b08457df2325..9b02506c852b
git log b08457df2325..9b02506c852b --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] Cache valid draw modes with transform feedback.
Created with:
gclient setdep -r src/third_party/angle@9b02506c852b
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: Ib8bd9e3fbbe508a6055d9ef35bf4d9ee17d29a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1374752
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616150}Use RWHVA::GetSelectedText() to get selected text in RWHVA.
GetSelectionRange() and GetTextFromRange() will be changed to
return only selected text in editable text field.
To avoid breaking current behavior, this CL switches them to
GetSelectedText() which will continue to return all selected texts.
Bug: 901439, 908762
Test: content_browsertests
Change-Id: I9fbd5b8ba887fc52ac75e625908b754ebaa47426
Reviewed-on: https://chromium-review.googlesource.com/c/1373732
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616149}WebUI cleanup: Remove neon-animation and friends from non-CrOS builds.
In order to do so, also limit iron-dropdown and cr-searchable-drop-down
to ChromeOS builds (not used anywhere else).
Bug: 907333,902959
Change-Id: I71be4291aa8ba8e69b25dbba114593b52da08504
Reviewed-on: https://chromium-review.googlesource.com/c/1372054
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616148}Roll src/third_party/chromite 6f13ebdc542b..89d93d297c3e (6 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6f13ebdc542b..89d93d297c3e
git log 6f13ebdc542b..89d93d297c3e --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] Update config settings by config-updater.
2018-12-12 [email protected] auto_updater: Increase reboot timeout after rootfs update for AU tests.
2018-12-12 [email protected] cros_generate_update_payload: Switch update_engine to major version 2
2018-12-12 [email protected] cbuildbot: ChromiteTestStage: correct stage description
2018-12-12 [email protected] Stop using active_waterfall as signal for adding slave to CQ master
2018-12-12 [email protected] Update config settings by config-updater.
Created with:
gclient setdep -r src/third_party/chromite@89d93d297c3e
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I827b71fb9cc6ae674e1e6dbe2d949db0b4e527d9
Reviewed-on: https://chromium-review.googlesource.com/c/1374062
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616147}Add UMA call counters for APIs in WebViewChromium
Add the histogram WebView.ApiCall to count calls to
WebView APIs in WebViewChromium.java
Bug: 778422
Change-Id: If1ac5e4fbf6ca4f6066beaf66a52a5776280a5be
Reviewed-on: https://chromium-review.googlesource.com/c/1343104
Commit-Queue: Changwan Ryu <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616146}Fix crash in RunInfo::NumGraphemes
Fix crash in NumGraphemes when called with an invalid end char position.
Bug: 913975
Test: fast/text/international/ar_tab_selection_crash.html
Change-Id: I93a94ba04e3e02b10ac8ef4186cf606b7df5c859
Reviewed-on: https://chromium-review.googlesource.com/c/1374630
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616145}cros: Don't show Guest button during sync consent
This change involves exposing another OOBE state to views. For now,
it is piped through login-header-bar like the other states. We can
migrate this to using display_manager.js directly in the future.
Bug: 911038
Change-Id: I30013cf0c27b6a8691b09bdcfa0dae1709c36e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1370911
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Quan Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616144}Update network service content_browsertests filter with now-passing previews tests
Bug: 842233
Change-Id: I7844cb7c709b2121ada3803cc3a46c50094fe33f
Reviewed-on: https://chromium-review.googlesource.com/c/1374440
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616143}Wait for updated hit test data in test.
Add functionality to InertialGSUBubblingStopsWhenParentCannotScroll test
so that it waits for updated hit test data to arrive after scrolling the
renderer. The test waits for confirmation the scroll happened, however
it doesn't wait for confirmation that hit test data is updated
which is also required.
The test was flaky after enabling OOP-D because hit test data had the
OOPIF in the wrong spot and bubble up behaviour wasn't triggered. This
happens because hit test data aggregation is moved into the GPU process
and can arrive later.
Add HitTestTransformChangeObserver to make this possible. The class
waits for some change in the root to target transform for a FrameSinkId.
Bug: 912289
Change-Id: I9c8b7221e86114b3692f1616a389b6cdf70ed97b
Reviewed-on: https://chromium-review.googlesource.com/c/1374109
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616142}Add .gov domains to HSTS preload list from November registrations
Change-Id: Ifd9e9194c98c6e36f6c3db397a39f96943ef5e48
Reviewed-on: https://chromium-review.googlesource.com/c/1372670
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Nick Harper <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616141}Introduce AudioIOCallbackMetric for monitoring rendering performance
This change introduces AudioIOCallbackMetric struct to trace the
rendering performance of Platform's AudioDesitnation. Eventually this
will be connected to the WebAudio DevTool drawer.
The new change is specifically for "Render Capacity" in the design doc:
https://docs.google.com/document/d/1TRgzZwp6M7sWL06UO3GYktqrv9TUv4G0QK6Io6VYVzc/edit?pli=1#bookmark=id.iodlb1gx6qpr
Bug: 837323
Change-Id: I92edca6f0afb755c6514b548d6c45d69e9831340
Reviewed-on: https://chromium-review.googlesource.com/c/1372538
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616140}IndexedDB: Update Put() to take a std::unique_ptr<IDBValue>
Bug: 717812
Change-Id: I52e4267fa84c3dedc6a4041662427d9c968dc19f
Reviewed-on: https://chromium-review.googlesource.com/c/1364226
Commit-Queue: Chase Phillips <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616139}Revert "tracing: Port ARC tracing agent to perfetto"
This reverts commit 624045587baefaab9fc7a601cacfc8488071381a.
Reason for revert: This causes crashes when running telemetry on actual chromeos devices. I was specifically running on veyron-minnie. I don't know if this is the problem, but turning on DCHECKs shows this DCHECK hit:
#0 0x0000085def4c base::debug::StackTrace::StackTrace()
#1 0x000008564cc6 logging::LogMessage::~LogMessage()
#2 0x000006cfadce arc::(anonymous namespace)::ArcTracingDataSource::StartTracingOnUI()
#3 0x0000085f85ba base::debug::TaskAnnotator::RunTask()
#4 0x00000856d6ee base::MessageLoopImpl::RunTask()
#5 0x00000856db66 base::MessageLoopImpl::DoWork()
#6 0x0000085f5a34 base::MessagePumpLibevent::Run()
#7 0x00000856d364 base::MessageLoopImpl::Run()
#8 0x00000858aed6 base::RunLoop::Run()
#9 0x0000081eed22 ChromeBrowserMainParts::MainMessageLoopRun()
#10 0x0000062a24a2 content::BrowserMainLoop::RunMainMessageLoopParts()
#11 0x0000062a4234 content::BrowserMainRunnerImpl::Run()
#12 0x00000629ffb0 content::BrowserMain()
#13 0x0000081e4870 content::ContentMainRunnerImpl::RunServiceManager()
#14 0x0000081e45dc content::ContentMainRunnerImpl::Run()
#15 0x0000081e99c4 service_manager::Main()
#16 0x0000081e3352 content::ContentMain()
#17 0x0000056be61c ChromeMain
#18 0x0000ab8ef0a2 __libc_start_main
reverting your patch did in fact make things happy.
Original change's description:
> tracing: Port ARC tracing agent to perfetto
>
> Adds a new DataSource for the ARC++ system tracing agent.
> Each ArcTracingBridge registers with the data source and keeps track of
> its state, so that the data source can coordinate tracing between all
> the bridges.
>
> [email protected]
>
> Test: Manually capture a trace with and without perfetto backend.
> Bug: 900603
> Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3
> Reviewed-on: https://chromium-review.googlesource.com/c/1360736
> Reviewed-by: Eric Seckler <[email protected]>
> Reviewed-by: Yusuke Sato <[email protected]>
> Reviewed-by: oysteine <[email protected]>
> Reviewed-by: Tom Sepez <[email protected]>
> Commit-Queue: Eric Seckler <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#615483}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 900603
Change-Id: I723711488acdbe5c59cd6a70f1443c631b77d9b7
Reviewed-on: https://chromium-review.googlesource.com/c/1374796
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616138}Remove linked_ptr from extensions message rules.
BUG=556939
Change-Id: If65afd6e3c66bfda4e94a73624f473462de714d5
Reviewed-on: https://chromium-review.googlesource.com/c/1374161
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616137}Update V8 to version 7.3.123.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/da1d51ff..146487a6
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected]
Change-Id: Ia4925a07229d313f78fcc17838cf61d155da5041
Reviewed-on: https://chromium-review.googlesource.com/c/1374795
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616136}viz: Do not send hit-test data unless it has been updated.
Aggregation only occurs when new hit-test data has been
submitted.
[email protected]
Bug: 762251
Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796
Reviewed-on: https://chromium-review.googlesource.com/c/1294838
Commit-Queue: Alexander Shah <[email protected]>
Reviewed-by: Mitsuru Oshima (gardener - slow) <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Ria Jiang <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616135}Roll src-internal f70b3cf774f4..e22735ae721d (4 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f70b3cf774f4..e22735ae721d
Created with:
gclient setdep -r src-internal@e22735ae721d
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: Iecdecd7b050c92743155224de204c431f653ff40
Reviewed-on: https://chromium-review.googlesource.com/c/1374849
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616134}media/gpu/test: Allow file paths in jpeg decode accelerator unittest.
This CL removes a check from the jpeg decode accelerator unittest, that makes
the test fail if the "--jpeg_filenames" parameter contains a path rather than a
filename. This functionality is required when running tests from Tast.
e.g.: ./jpeg_decode_accelerator_unittest
--jpeg_filenames=/usr/local/share/tast/peach_pi-1280x720.jpg
TEST=JPEG decode accelerator unittest on nocturne
BUG=912413
Change-Id: I96e6f05148ad6bd0d623936f6c1ca3c626250dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1369756
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: David Staessens <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616133}In DSE, remove clang-format directives and re-format prepopulate lists
This is no-op CL to update to the new behavior of 'git cl format'
that puts each array initializer item on its own line. By removing
the clang-format directives, we can ensure that future changes will
benefit from the automatic formatting logic and adhere to standards.
Bug: 783890
Change-Id: I8887f8951acb6d35102b18f7eca9ab6ed88a77bf
Reviewed-on: https://chromium-review.googlesource.com/c/1374459
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616132}[Extensions + Apps] Move the pointerLock permission to platform_apps
Move the pointerLock permission out of extensions code and into apps
code. This is only a permission, and not a full API, and thus only
includes:
- The API features (from _*_features.json files)
- The API permission (from c/b/e/permissions/chrome_api_permissions.cc)
Bug: 877240
Change-Id: Ifb861abcd07eab07edd994acff04e75a26e40b20
Reviewed-on: https://chromium-review.googlesource.com/c/1374579
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616131}ozone: scenic: Hold resources in new object that's independent of VulkanSurface
This removes the need for a destruction callback on VulkanSurface. This also
means that we would keep the same session when surfaces are reshaped since that
creates an entirely new VulkanSurface.
This is only used for Fuchsia & SkiaRenderer + Vulkan as of this patch.
Bug: 861853
Test: run_content_shell \
--enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo
--enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \
--enable-raster-to-sk-image --use-raster-context-provider \
--force-gpu-rasterization --use-gl=swiftshader --no-sandbox \
--disable-gpu-sandbox
Change-Id: I84ed451df257cce2e1a2a471a1e6995e78fe3001
Reviewed-on: https://chromium-review.googlesource.com/c/1362475
Commit-Queue: Michael Spang <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616130}Allow the SnackbarManager to track the start/stop state of its tracking activity.
BUG=
Change-Id: I9c44256bcf0b164ea9dd9a15b985f67026a4cbb1
Reviewed-on: https://chromium-review.googlesource.com/c/1374148
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616129}Revert "[Explore sites]: Remove unneeded files and the title on the explore sites page."
This reverts commit ec3933dde96b9729202b8689431ff3b84b265f48.
Reason for revert: Will cause crash on canary
Original change's description:
> [Explore sites]: Remove unneeded files and the title on the explore sites page.
>
> Change-Id: Iee0486cc74130e4b28f60cf9ed9fbddca915e7e3
> Reviewed-on: https://chromium-review.googlesource.com/c/1374330
> Commit-Queue: Cathy Li <[email protected]>
> Reviewed-by: Justin DeWitt <[email protected]>
> Reviewed-by: Theresa <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#616091}
[email protected],[email protected],[email protected]
Change-Id: Ib0ea215990d9a3489f7028677fc4ffe47d04b4f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1374963
Reviewed-by: Cathy Li <[email protected]>
Commit-Queue: Cathy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616128}Roll src/third_party/skia d110245bb7f7..9a1e3a852f05 (18 commits)
https://skia.googlesource.com/skia.git/+log/d110245bb7f7..9a1e3a852f05
git log d110245bb7f7..9a1e3a852f05 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] Roll recipe dependencies (trivial).
2018-12-12 [email protected] start removing legacy paint calls
2018-12-12 [email protected] Roll third_party/externals/angle2 88faa6967431..b08457df2325 (2 commits)
2018-12-12 [email protected] Revert "we now cache GLSL shaders when we can't cache the binaries"
2018-12-12 [email protected] Blacklist 'deprecated' color test
2018-12-12 [email protected] make SK_SUPPORT_LEGACY_FONTMETRICS_IN_PAINT conditional
2018-12-12 [email protected] Add Windows MSVC arm64 builders
2018-12-12 [email protected] fix bookmaker
2018-12-12 [email protected] Use descriptive path name for win_toolchain on the bots
2018-12-12 [email protected] add gm calling textblob intercepts with spacing
2018-12-12 [email protected] we now cache GLSL shaders when we can't cache the binaries
2018-12-12 [email protected] Funtion to say if an SkFont has anti aliasing.
2018-12-12 [email protected] Revert "Perform Vulkan resets in a background thread"
2018-12-12 [email protected] Revert "fix for GrVkGpu not always unreffing all command pools"
2018-12-12 [email protected] Remove Android compile bots from CQ
2018-12-12 [email protected] convert bug fiddle into a GM
2018-12-12 [email protected] SkShaper per-line callback
2018-12-12 [email protected] Update expectations for internal bot
Created with:
gclient setdep -r src/third_party/skia@9a1e3a852f05
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]
Change-Id: I629fcc02bf9481ab6f3aacaa46fdfd6370f74303
Reviewed-on: https://chromium-review.googlesource.com/c/1374750
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616127}Roll src/third_party/perfetto ca5569f2c920..b2b022870864 (1 commits)
https://android.googlesource.com/platform/external/perfetto.git/+log/ca5569f2c920..b2b022870864
git log ca5569f2c920..b2b022870864 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 [email protected] Merge "profiling: Fix pprof mapping ids."
Created with:
gclient setdep -r src/third_party/perfetto@b2b022870864
The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
[email protected]
Change-Id: I26a848e91b54f2018141c9e791f1337ab50a2b53
Reviewed-on: https://chromium-review.googlesource.com/c/1374145
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616126}[Fuchsia] Fix test runner to shutdown forwarding socket
The runner script starts ssh port forwarding for the test server with
`ssh -O forward -R 0:localhost:<host_port>`. Then to stop it would run
`ssh -O cancel -R <device_port>:localhost:<host_port>`. That last
command succeed with exit code 0, but doesn't really cancel forwarding.
It appears to be a bug in ssh on the client side - it doesn't send
cancel-tcpip-forward command to sshd 🤷 . But, it works properly with
`-R 0:localhost:<host_port>`.
Bug: 913156
Change-Id: I0668258d21c60e3992e27486494bd8da26c674d0
Reviewed-on: https://chromium-review.googlesource.com/c/1374771
Reviewed-by: Kevin Marshall <[email protected]>
Commit-Queue: Kevin Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616125}
