Publish DEPS for 72.0.3626.96
Incrementing VERSION to 72.0.3626.96
[email protected]
Change-Id: Id8d898876cc9809ecd2ee28c608482e75be2a4f1
Reviewed-on: https://chromium-review.googlesource.com/c/1455456
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#836}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Ensure text control entrance when generating clipboard text
Blink uses TextIteratorInFlatTree for generating clipboard text, which
used to enter text controls by default. The TextIterator behavior was
changed crrev.com/c/1327962, causing an unexpected behavior change.
This patch explicitly sets the EntersTextControls flag when computing
clipboard text to recover the original behavior.
Bug: 927394
Change-Id: I1e8d30cc73e14d5695b985b2e5afa1591e019663
Reviewed-on: https://chromium-review.googlesource.com/c/1450445
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#628682}(cherry picked from commit c6bb24c14f1b19f356f75ea8a30a24cbd0a41ae1)
Reviewed-on: https://chromium-review.googlesource.com/c/1452342
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Abdul Syed <[email protected]>
Cr-Original-Original-Commit-Position: refs/branch-heads/3693@{#5}
Cr-Original-Original-Branched-From: 58322e3f2f0c240b91b56bc9039cd989b201b557-refs/heads/master@{#628647}(cherry picked from commit 38219800a60ad4fe47d4032bfbb76bb0d444ee4b)
Reviewed-on: https://chromium-review.googlesource.com/c/1455338
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3683@{#224}
Cr-Original-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}(cherry picked from commit 845a970e67819908b1dce793639af8d2a3e8eb0e)
Reviewed-on: https://chromium-review.googlesource.com/c/1455314
Cr-Commit-Position: refs/branch-heads/3626@{#835}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Fix homescreen longpress incognito icon
Tentative fix for crbug.com/927513 . Layering violation due to incognito
not being a webview concept. Layering fix in a follow up cl.
TBR=torne@
Bug=927513
Change-Id: I0a3e1e820429efc86b1333711f83400d34f3b233
Reviewed-on: https://chromium-review.googlesource.com/c/1452376
Reviewed-by: Mohamed Heikal <[email protected]>
Commit-Queue: Mohamed Heikal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628755}(cherry picked from commit 2f4608c43cdbdd03a8f1b7f5ff1201c904c3598c)
Reviewed-on: https://chromium-review.googlesource.com/c/1455067
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#834}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again"
This reverts commit 155c1f2bf45369bc7130c89b88c75c2d3c915410.
Bug: 927066
Change-Id: Icfa8248cf68dbffa581c4da7477f457a8ab8fd10
Reviewed-on: https://chromium-review.googlesource.com/c/1455112
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#833}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Fix blob URLs in the chrome.downloads API with network service enabled.
Long term the chrome.downloads implementation should probably resolve
blob URLs in the renderer process before sending the IPC to the browser,
as that is the only way to guarantee that the blob URL can resolve
correctly, but this fix should at least for most cases.
[email protected]
(cherry picked from commit f5534db9782f9bcb83e062e8bb6d341a458070a8)
Bug: 928307
Change-Id: I85b29c91ff1d89451811b30ea7a9f8d22f853ea2
Reviewed-on: https://chromium-review.googlesource.com/c/1452778
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628893}
Reviewed-on: https://chromium-review.googlesource.com/c/1455306
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#832}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.95
[email protected]
Change-Id: Ia416295b77403db13ce280de4327942e035d55e0
Reviewed-on: https://chromium-review.googlesource.com/c/1455299
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#831}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}cros: Update fingerprint lock screen graphic upon auth scan
[email protected]
(cherry picked from commit 3af29bd8fdc4859e137f944abb77bbd1ffc61474)
Bug: b/123518003
Change-Id: I9c1ee959603f0b152b7c247ca0637f73fcdfa85c
Reviewed-on: https://chromium-review.googlesource.com/c/1446787
Commit-Queue: Yulun Wu <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627583}
Reviewed-on: https://chromium-review.googlesource.com/c/1453373
Reviewed-by: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#830}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Remove filter touch event when obscured on most of the buttons
We may just want to filter security buttons instead of all the buttons
since based on user feedback, screen filter apps are popular, and
filtering most buttons becomes a user pain.
Bug: 928715
Change-Id: I82abec5b428299d1a86207e8c21b66288b6b009a
Reviewed-on: https://chromium-review.googlesource.com/c/1454229
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Becky Zhou <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#629195}(cherry picked from commit b44a405f60e5d1aebf18fc4c2266c1fc0ae454f3)
Reviewed-on: https://chromium-review.googlesource.com/c/1455042
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#829}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.94
[email protected]
Change-Id: I6545a0e7268a04758bc6e010033fa366ab83bc93
Reviewed-on: https://chromium-review.googlesource.com/c/1455018
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#828}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Reland "Add null check for delegate in MaybeSetupLoginPrompt"
This reverts commit 0a11055d7f5bf8e172a59cf8a3e39277e55fc1f2.
Reason for revert: Fixed compile error that resulted from merge.
Original change's description:
> Revert "Add null check for delegate in MaybeSetupLoginPrompt"
>
> This reverts commit 6eaeb5830d716fab779bada7c31f32e2424a903e.
>
> Reason for revert: Broke Android M72 build, see bug 928630.
>
> Original change's description:
> > Add null check for delegate in MaybeSetupLoginPrompt
> >
> > [email protected]
> >
> > (cherry picked from commit c3e6bb6867956bea3620b9f67a5a965f7562aad7)
> >
> > Bug: 921760
> > Change-Id: I7577e6e901463ef2823c415e672e749c284ff0ce
> > Reviewed-on: https://chromium-review.googlesource.com/c/1444137
> > Commit-Queue: Carlos IL <[email protected]>
> > Reviewed-by: David Benjamin <[email protected]>
> > Auto-Submit: Carlos IL <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#627226}
> > Reviewed-on: https://chromium-review.googlesource.com/c/1453577
> > Reviewed-by: Carlos IL <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/3626@{#818}
> > Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
>
> [email protected],[email protected]
>
> Change-Id: I8b75a8e05c9ee89b5f5835bf22e934dc8f73d453
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 921760
> Reviewed-on: https://chromium-review.googlesource.com/c/1454119
> Reviewed-by: Krishna Govind <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3626@{#822}
> Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[email protected],[email protected],[email protected]
Change-Id: I3bd610a54164c1f066697e5644115f58304014d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 921760
Reviewed-on: https://chromium-review.googlesource.com/c/1454766
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#827}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[SessionStorageS13N] Disabling onion soup
[email protected]
(cherry picked from commit b584e22552127d1edb167c83e047864f37808f5c)
TBR: [email protected]
Bug: 897581
Change-Id: I22fa2e787a7628a8a6cb40bec9aea166150a9d9a
Reviewed-on: https://chromium-review.googlesource.com/c/1447119
Commit-Queue: Daniel Murphy <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627703}
Reviewed-on: https://chromium-review.googlesource.com/c/1454091
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#826}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[Payment Request] Do not access mWebContents if it is destroyed.
This fixes the crash reported in http://crbug.com/915953#c8.
|shouldEnforceCanMakePaymentQueryQuota| is called inside the callback
for the asynchronous canMakePayment and hasEnrolledInstrument query. The
WebContents may be destroyed already when the callback triggers. It is
safer to return true in this case.
Bug: 915953
Change-Id: I306a4c8d8b52a4056879dd4d0975249c398e89d1
Reviewed-on: https://chromium-review.googlesource.com/c/1452696
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Danyao Wang <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#628920}(cherry picked from commit be6e0001855f7f1cfc26205d0ff5a2b5b324fcbd)
Reviewed-on: https://chromium-review.googlesource.com/c/1454227
Reviewed-by: Ben Mason <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3683@{#200}
Cr-Original-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}(cherry picked from commit 74c85a2d8ae494ed1ca33f9f75fd1068577ec2ab)
Reviewed-on: https://chromium-review.googlesource.com/c/1454801
Cr-Commit-Position: refs/branch-heads/3626@{#825}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.93
[email protected]
Change-Id: I35858b907ae65510eb0ab96173b830c2069641f0
Reviewed-on: https://chromium-review.googlesource.com/c/1454125
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#824}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.92
[email protected]
Change-Id: I7fb4d55614a51bf9f9de1ae65e9a2719cb20d77a
Reviewed-on: https://chromium-review.googlesource.com/c/1454120
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#823}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Revert "Add null check for delegate in MaybeSetupLoginPrompt"
This reverts commit 6eaeb5830d716fab779bada7c31f32e2424a903e.
Reason for revert: Broke Android M72 build, see bug 928630.
Original change's description:
> Add null check for delegate in MaybeSetupLoginPrompt
>
> [email protected]
>
> (cherry picked from commit c3e6bb6867956bea3620b9f67a5a965f7562aad7)
>
> Bug: 921760
> Change-Id: I7577e6e901463ef2823c415e672e749c284ff0ce
> Reviewed-on: https://chromium-review.googlesource.com/c/1444137
> Commit-Queue: Carlos IL <[email protected]>
> Reviewed-by: David Benjamin <[email protected]>
> Auto-Submit: Carlos IL <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#627226}
> Reviewed-on: https://chromium-review.googlesource.com/c/1453577
> Reviewed-by: Carlos IL <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3626@{#818}
> Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[email protected],[email protected]
Change-Id: I8b75a8e05c9ee89b5f5835bf22e934dc8f73d453
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 921760
Reviewed-on: https://chromium-review.googlesource.com/c/1454119
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#822}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Suppress finishPageLoadForTab:loadSuccess: crash.
WebStateObserver::PageLoaded can be called with empty navigation
manager because of crbug.com/899827. This CL suppresses the crash w/o
fixing the root cause so we can cherry-pick the change to M-72 branch.
[email protected]
(cherry picked from commit c372cda8412f5822420681a6beebb025efc1b094)
Bug: 813018
Change-Id: I4af77406b8c8b1fb958b14a35ab669536f55fd34
Reviewed-on: https://chromium-review.googlesource.com/c/1452169
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628853}
Reviewed-on: https://chromium-review.googlesource.com/c/1453757
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#821}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Reland: Do not call 'navigation committed' callback if there was no pending item to commit.
GetPendingItem can return null inside webView:didCommitNavigation:
This is due to crbug.com/925304, which allows to discard pending items
by another navigations prematurely.
If pending item is null, it means that Navigation Manager will not commit
that item and WebStateObservers can crash because they expect to have at
least one committed item.
This CL leaves navigation as "uncommitted" if there was no pending item
inside webView:didCommitNavigation:
Original CL: https://chromium-review.googlesource.com/c/1448683
[email protected], [email protected]
(cherry picked from commit 621ddc377ebc96f7ecd524a39956b911fd70d6f1)
(cherry picked from commit 0bfefb8c0a468b68a81ee5301f5d14004de66d3f)
Bug: 925304
Change-Id: I7852da807d183e87d1fd029d75ed63cde2287d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1450300
Commit-Queue: Eugene But <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#628537}
Reviewed-on: https://chromium-review.googlesource.com/c/1451219
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3683@{#148}
Cr-Original-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
Reviewed-on: https://chromium-review.googlesource.com/c/1453756
Cr-Commit-Position: refs/branch-heads/3626@{#820}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.91
[email protected]
Change-Id: I8d5c4a500c448c781e068f82d1b0ad148fb59354
Reviewed-on: https://chromium-review.googlesource.com/c/1453550
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#819}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Add null check for delegate in MaybeSetupLoginPrompt
[email protected]
(cherry picked from commit c3e6bb6867956bea3620b9f67a5a965f7562aad7)
Bug: 921760
Change-Id: I7577e6e901463ef2823c415e672e749c284ff0ce
Reviewed-on: https://chromium-review.googlesource.com/c/1444137
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627226}
Reviewed-on: https://chromium-review.googlesource.com/c/1453577
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#818}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.90
[email protected]
Change-Id: Icf18f90fe8171b9a305373464d2ce9f56a027d10
Reviewed-on: https://chromium-review.googlesource.com/c/1450886
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#817}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.89
[email protected]
Change-Id: I1856a8c30675db36896cd7c8aeaaffca3e255f02
Reviewed-on: https://chromium-review.googlesource.com/c/1450861
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#816}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[M72 Branch] Calls LoadIfNecessary() on WebState's Navigation Manager
This call sets up the necessary context for CRWWebController to actually
load the page. Otherwise, the page will not be loaded.
This change is M72 BRANCH ONLY, and a slightly different fix
http://crrev/c/1450876 is applied to trunk.
Note: This triggers some DCHECKs that are either innoculous, wrong,
unncessary, or some of the above.
Bug: 923252
Change-Id: I247307e8d2e76b955999ff0c44e3007c13451149
Reviewed-on: https://chromium-review.googlesource.com/c/1449736
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#815}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.88
[email protected]
Change-Id: I4060824ae3a8773d7c8cb2ed487f33d8eb46f740
Reviewed-on: https://chromium-review.googlesource.com/c/1450873
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#814}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Revert "Fix WebRequestProxyingURLLoaderFactory crash after redirect"
This reverts commit 066fecfb1d2b12aa2359ade87ef2f036437cfaec.
Reason for revert: This change had some unintended effects on the interaction of WebRequest and URLLoaderThrottles.
Original change's description:
> Fix WebRequestProxyingURLLoaderFactory crash after redirect
>
> When OnReceiveRedirect() is called, we expect to not receive any more
> events for that request until FollowRedirect() has been called and the
> request is restarted with the new URL. We were not clearing the
> bindings in this case, so the URLLoader was staying alive and calling
> OnBeforeSendHeaders() on the redirected URL. This could then result in
> OnBeforeSendHeaders() being called twice, once for the original request
> which gets redirected in //net, and once for the request in the correct
> flow when it gets restarted after FollowRedirect().
>
> I believe this is pretty similar to the issue described in
> http://crbug.com/882661, except this one has to do with normal
> redirects instead of webRequest generated redirects.
>
> The existing redirect tests catch this issue when using the
> 'extraHeaders' spec, so I made a version of them that runs with that
> enabled.
>
> Bug: 918761
> Change-Id: Ifa551400e85c13ea3a297fba02a05deb5ccb1821
> Reviewed-on: https://chromium-review.googlesource.com/c/1409915
> Reviewed-by: Ken Rockot <[email protected]>
> Commit-Queue: Clark DuVall <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#622685}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 918761, 926606
Change-Id: Ie8449c6fd6c94722ef8eb618ea1a16d429b74bbb
Reviewed-on: https://chromium-review.googlesource.com/c/1443913
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627183}(cherry picked from commit 6406a9f8b7e0fc834227eb64245e4a3f1ec44494)
Reviewed-on: https://chromium-review.googlesource.com/c/1450423
Cr-Commit-Position: refs/branch-heads/3626@{#813}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.87
[email protected]
Change-Id: I5752abbe1df9673837274e80610aa7efcecf4ee0
Reviewed-on: https://chromium-review.googlesource.com/c/1450433
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#812}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[cronet] exclude pyc files from deps of generate_javadoc.py
This is to fix compile noop failure in internal builder.
http://shortn/_t5pHTnebHY
Merging this back without normal approval as it only affects Cronet and not Chrome.
Bug: 914264
Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b
Reviewed-on: https://chromium-review.googlesource.com/c/1448085
Commit-Queue: Takuto Ikuta <[email protected]>
Commit-Queue: Paul Jensen <[email protected]>
Auto-Submit: Takuto Ikuta <[email protected]>
Reviewed-by: Paul Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#628219}(cherry picked from commit 28d16f987cf5db3f673abe7b2f052252b1b08031)
Reviewed-on: https://chromium-review.googlesource.com/c/1449814
Reviewed-by: Takuto Ikuta <[email protected]>
Reviewed-by: Misha Efimov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#811}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[Merge to M-72] Fix the bug that toggle CapsLock shortcut does not work after using
handwriting input
Handwriting/voice input or emoji generates fake pressing/releasing
key events. But pressing/releasing key events use different key code.
As result, the accelerator history fails to remove the fake pressing
event after receiving the fake releasing event.
In fact, key events with key code of ui::VKEY_PROCESSKEY have no effect
on accelerator processing. So in this CL, stop tracking those key events
in the accelerator history. Meanwhile, refactor the accelerator history
code.
[email protected]
Test: ash_unittests
Bug: 918317
Change-Id: Iafdc5658c93fc029942dbdc20571558ed84a3eb3
Reviewed-on: https://chromium-review.googlesource.com/c/1427439
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626832}(cherry picked from commit e1c534a395a54afc1ea6aa50a18531a80781b6ab)
Reviewed-on: https://chromium-review.googlesource.com/c/1448335
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#810}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[Merge to M-72] Fix the bug that toggle CapsLock shortcut does not work after using the
partial screenshot
In previous code, when the partial screenshot is triggered, all of key
events are stopped from propagation. As result, the release of the partial
screenshot accelerator is unknown to AcceleratorHistory. It would lead
to malfunction of the accelerators which rely on AcceleratorHistory,
such as toggle CapsLock shortcut.
This CL fixes the bug by updating AcceleratorHistory in the code block
which processes the partial screenshot accelerator.
[email protected]
Test: ash_unittests
Bug: 920032
Change-Id: Ie4f553a841869db82f2710329e7968aa058713f4
Reviewed-on: https://chromium-review.googlesource.com/c/1408221
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625273}(cherry picked from commit f93a5511e258669659d93b77fa96e773a6829fb1)
Reviewed-on: https://chromium-review.googlesource.com/c/1449167
Cr-Commit-Position: refs/branch-heads/3626@{#809}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.86
[email protected]
Change-Id: I0076cd2004b864684b8308bfa6767d7b1cc9d270
Reviewed-on: https://chromium-review.googlesource.com/c/1448334
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#808}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}cros: (MERGE to M72) Don't show Guest button during sync consent
This change involves exposing another OOBE state to views. For now,
it is piped through login-header-bar like the other states. We can
migrate this to using display_manager.js directly in the future.
[email protected]
(cherry picked from commit ea6644de938ffcd0011cdeb495aa4c45082928b4)
Bug: 911038
Change-Id: I30013cf0c27b6a8691b09bdcfa0dae1709c36e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1370911
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Quan Nguyen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#616144}
Reviewed-on: https://chromium-review.googlesource.com/c/1448706
Reviewed-by: Quan Nguyen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#807}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.85
[email protected]
Change-Id: If4d55c86d61890b566096000265fea8571c17cdf
Reviewed-on: https://chromium-review.googlesource.com/c/1447334
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#806}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Gracefully handle null pending item inside webView:didCommitNavigation:.
webView:didCommitNavigation: used to assume that pending item is
always valid and crashed on dereferencing null pointer. Pending item
should never be null inside webView:didCommitNavigation: but existing
ownership model is incorrect, so pending item could be distroyed before
committing.
This CL adds checks before dereferencing pending item to avoid the
crash. The real fix could be implemented by storing pending item in
NavigationContext object (crbug.com/925304).
[email protected]
(cherry picked from commit 010e2b264abf807d9d24f080816e657d6bbaa2ee)
Bug: 676458
Change-Id: Idf60e60cbe98111e8fed5d2903ae8bc8b8df3d90
Reviewed-on: https://chromium-review.googlesource.com/c/1444953
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627509}
Reviewed-on: https://chromium-review.googlesource.com/c/1447039
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#805}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.84
[email protected]
Change-Id: Idc47110a06fa7d614917205d3ec59d4ab188d637
Reviewed-on: https://chromium-review.googlesource.com/c/1446832
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#804}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Disable GPU Rasterization on Mali on Chrome OS
We observed a few rastering issue related to GPU Rasterization on Mali
devices (crbug.com/914097, crbug.com/915226)
This CL disables GPU Rasterization on Mali on Chrome OS while we investigate
further.
Bug: 845650, 914097, 915226
Test: Deploy to veyron_mickey, check crbug.com/914097 can't be reproduced
Change-Id: I53d6edc57db614e827b5cf7a44b2f306e2f747ff
Reviewed-on: https://chromium-review.googlesource.com/c/1446778
Reviewed-by: David McMahon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#803}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.83
[email protected]
Change-Id: I6a666f28fbdfe69ecb864653e78b06b5eabe21ff
Reviewed-on: https://chromium-review.googlesource.com/c/1444991
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#802}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}M72: Use GetDeviceScaleFactor to get scale factor for coord space transform
[email protected]
Use GetDeviceScaleFactor to get scale factor for coord space transform
The device scale factor is not properly applied in
CrossProcessFrameConnector::TransformPointToLocalCoordSpaceLegacy
We're using current_surface_scale_factor() which does not seem to
provide the correct value. We want GetDeviceScaleFactor().
Test: SitePerProcessInternalsHitTestBrowserTest.ScrollNestedLocalNonFastScrollableDiv
after crrev.com/c/1427607 landed
Bug: 923069
Change-Id: Iae748780d0657d7674cf4ba76a276ad03cc28a74
Reviewed-on: https://chromium-review.googlesource.com/c/1435834
Reviewed-by: Kevin McNee <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Jianpeng Chao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626115}(cherry picked from commit 2154953d9c64f9161ca1b4612973811f1721ccab)
Reviewed-on: https://chromium-review.googlesource.com/c/1443646
Cr-Commit-Position: refs/branch-heads/3626@{#801}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.82
[email protected]
Change-Id: I80687daf0f5492d928761a1d63c052ec82f0e55e
Reviewed-on: https://chromium-review.googlesource.com/c/1441504
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#800}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}NotificationViewMD:Call DisableNotification at end
In NotificationViewMD, users can disable a notification from inline
settings. When "Done" button is clicked, ToggleInlineSettings() might
call DisableNotification() to apply the setting.
After DisableNotification is called, there's no guarantee that
the notification view still exists. Therefore, it's better to call the
method at the end of ToggleInlineSettings.
In this case,
1. DisableNotification() triggers animation in UnifiedMessageListView
2. PreferredSizeChanged() cancels the animation and deletes all removed
notifications.
3. As |this| is already null, it crashes by use-after-free.
So calling DisableNotification() at the end is also important to make
the animation work properly.
This is M72 ReleaseBlock-Stable.
TEST=NotificationViewMDTest.TestDeleteOnDisableNotification
BUG=924922
Change-Id: I25d2d345b146b28d935f597d4e851f7caebac5a1
Reviewed-on: https://chromium-review.googlesource.com/c/1436282
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626306}(cherry picked from commit 457106a7156e0b9f03ba03092f6f6eed1b9e151b)
Reviewed-on: https://chromium-review.googlesource.com/c/1441652
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#799}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Add metrics for counting migrated dirty files.
We want to know how often we have to do migrations of dirty files that
may cause user's confusion.
BUG=chromium:923967
Change-Id: Ib44d221a64ea1d4af3f86944d7aec11c713f840f
Reviewed-on: https://chromium-review.googlesource.com/c/1425841
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Commit-Queue: Sergei Datsenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625958}(cherry picked from commit d2a9a5b5f1e59bee997ce01585ddcc59a354c17e)
Reviewed-on: https://chromium-review.googlesource.com/c/1440803
Reviewed-by: Sergei Datsenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#798}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Fixed UrlFetchRequestBase::WriteFileData memory bug.
UrlFetchRequestBase::WriteFileData was using an invalid
base::StringPiece object. This was because the StringPiece
passed to OnDataReceived is only guaranteed to be valid
for the duration of the call, but was being posted to
another task runner. This fixes this bug by creating a copy
of the file data.
[email protected]
(cherry picked from commit 657d0723d916d35d4605e4912b0bb3ad13f68777)
Bug: 905097
Change-Id: I335d4ddce29b21f4b7fcd6d686b1de20d3bdad47
Reviewed-on: https://chromium-review.googlesource.com/c/1431692
Reviewed-by: Stuart Langley <[email protected]>
Commit-Queue: Chris Mumford <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625428}
Reviewed-on: https://chromium-review.googlesource.com/c/1440129
Reviewed-by: Chris Mumford <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#797}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.81
[email protected]
Change-Id: Id380227b8bc04a7a164e761e1e05163376fad310
Reviewed-on: https://chromium-review.googlesource.com/c/1440541
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#796}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Fix redirects losing the |new_url| parameter from URLLoaderThrottle with network service if a webRequest extension is installed.
Since r622685, we always reset the target URLLoader inside WebRequestProxyingURLLoaderFactory::InProgressRequest on a redirect.. That means that we need to persist the new_url parameter to WebRequestProxyingURLLoaderFactory::InProgressRequest::FollowRedirect.
Bug: 925865
Change-Id: Ibc936685a084320852752123700bbb31cefab714
Reviewed-on: https://chromium-review.googlesource.com/c/1440064
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#795}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Fix chromium crash after setting up policy for device disable
In the condition when the device is disabled by policy it was referencing a yet
uninitialized LoginScreenClient leading to SYSSEGV and boot/login loop in
Chromebooks.
Bug: 884127
Change-Id: If99d945777e56cbc1299f5094afd32cee1872f3a
Reviewed-on: https://chromium-review.googlesource.com/c/1435436
Commit-Queue: Anatoliy Potapchuk <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626120}(cherry picked from commit 1453a24914de8e1684d19d52ca7bb65b1bebadb4)
Reviewed-on: https://chromium-review.googlesource.com/c/1440142
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#794}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}cros: Disable the discover app by default
This should have been disabled before launch. It is not ready for
release yet.
Bug: 925152
Change-Id: I155a7dc7814207b0c480c2ad1a1172a2093cff8d
Reviewed-on: https://chromium-review.googlesource.com/c/1440122
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#793}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.80
[email protected]
Change-Id: I6f449be9bdeaf8bb79ccb42ab1397c2321aab21c
Reviewed-on: https://chromium-review.googlesource.com/c/1438462
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#792}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.79
[email protected]
Change-Id: Iaafefc9040a8b4edc0311e86ec37e2cd93fa802e
Reviewed-on: https://chromium-review.googlesource.com/c/1437838
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#791}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.78
[email protected]
Change-Id: Icf913c039a635ee7ac9e41b9aff848ab92a99112
Reviewed-on: https://chromium-review.googlesource.com/c/1437797
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#790}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Incrementing VERSION to 72.0.3626.77
[email protected]
Change-Id: Ied55753fe4091ca71cd0f1c962dd3604bcf1f747
Reviewed-on: https://chromium-review.googlesource.com/c/1437955
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#789}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Support teeing form data in BytesConsumerTee.
This fixes a bug when a subresource request with a body that
is not a blob goes through a service worker. The body was being
dropped because BytesConsumerTee wasn't properly making the
bytes consumer for it.
It seems like this code path only gets taken NetworkService is
enabled.
Bug: 925225
Change-Id: I7154e903d03766c3dbce00b6514f54fdcef32f02
Reviewed-on: https://chromium-review.googlesource.com/c/1437615
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#788}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Merge M72: Update Flash plugin metadata versions to latest version.
https://helpx.adobe.com/security/products/flash-player/apsb19-01.html
BUG=412078
[email protected]
(cherry picked from commit b75533f2e8364afcf4750d408cbdd9db7b960995)
Change-Id: Iad791942c20144f56f7b892c43601ec7621d62a8
Reviewed-on: https://chromium-review.googlesource.com/c/1435754
Reviewed-by: Will Harris <[email protected]>
Commit-Queue: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625859}
Reviewed-on: https://chromium-review.googlesource.com/c/1435691
Cr-Commit-Position: refs/branch-heads/3626@{#787}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}[Merge to M-72] Fix a bug that may result in the wrong removal of an external display
Iterating through the new and current display list to figure out
which new ones where added and which ones were removed used to use
a different comparator than the one used to sort those lists.
This sometimes caused an external display to be removed then added
unnecessarily when going to docked mode.
This CL fixes this issue.
[email protected]
BUG=921275
TEST=Added new test that fails without the fix.
Change-Id: Ie2a9bd93588c00070d6f458946127d0c97c63a20
Reviewed-on: https://chromium-review.googlesource.com/c/1416331
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#623477}(cherry picked from commit e031e0c90ee6d1e57907c58caa9aa8986283ad57)
Reviewed-on: https://chromium-review.googlesource.com/c/1436205
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#786}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}Downloads: Fix timestamp deduplication for Windows
After deduplicating 100 filenames,
i.e. foo.jpg, foo (1).jpg, ... foo (100).jpg, Chrome uses an ISO 8601
timestamp.
This works on all platforms but Windows, as the default ISO 8601 format
contains colons, which is a forbidden character on Windows.
This CL changes this to use a delimiter-light version of ISO 8601 that
is still compliant with the spec.
It also changes to use local time instead of UTC time.
foo - 2018-10-11T215547.392.jpg
Bug: 135428
Change-Id: I2759240ee41341cb558b32e8f925742611c4debc
Reviewed-on: https://chromium-review.googlesource.com/c/1432882
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#625741}(cherry picked from commit 5ec480e936e17b17648a2be4831a8c9b7cfc0fb8)
Reviewed-on: https://chromium-review.googlesource.com/c/1435690
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#785}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
