Publish DEPS for 71.0.3578.21
Incrementing VERSION to 71.0.3578.21
[email protected]
Change-Id: I8b6441d5c240c582d4bb1b599e29f520eb17960a
Reviewed-on: https://chromium-review.googlesource.com/c/1297480
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#282}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Picture in Picture] Add resize handle for CrOS.
This change adds a UI affordance that the window is resizable and
draggable on ChromeOS. This adds a ResizeHandleButton made specifically
as the affordance.
This icon is on the edge of the window that points to the center of
the workspace screen. For example, if the window is on the bottom right
quadrant, the icon will be on the top left. In the case where the window
is on the bottom left quadrant, the icon replaces the close button. The
close button is then shifted to the top left corner.
Bug: 890113
Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
Reviewed-on: https://chromium-review.googlesource.com/c/1275526
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599090}(cherry picked from commit ccd3669d8798ee2013539723323bfd8d982b36a6)
Reviewed-on: https://chromium-review.googlesource.com/c/1297635
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#281}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix Audio Player expand/collapse button
Fix CSS selector for <track-info-panel> element, CSS uses a different
syntax for Polymer :host pseudo-element with attributes selector.
I used code search for all ":host" entries and only this file is using
the incorrect syntax.
There is no change in behaviour, only styles have changed.
Test: Checked manually/visually Audio Player.
Bug: 896056
Change-Id: Id93eb2460a8370dfc1e2488e335bdfac3c4067e7
Reviewed-on: https://chromium-review.googlesource.com/c/1295629
Commit-Queue: Luciano Pacheco <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601857}(cherry picked from commit 1633f13dd3afb2ae526f70f746cf548a10accfe6)
Reviewed-on: https://chromium-review.googlesource.com/c/1297211
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#280}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home V2: Maps errors to OfflineItemStates.
This CL implements a code path to make Java side known how OfflineItem
should be resumed.
OfflineItemState::FAILED: Cannot resume, no further user actions.
OfflineItemState::INTERRUPTED: Can resume, but need to restart from
beginning. Should hook to retry button.
OfflineItemState::PENDING/PAUSE still uses
DownloadUtils.isDownloadPending/isDownloadPause, when download can be
resumed in the middle.
[email protected]
(cherry picked from commit 32528739021da25e59182db41c1b09521a1aa432)
Bug: 895018,895013
Change-Id: I36a82cf3754093bfab85a623818d9e2392a6fc73
Reviewed-on: https://chromium-review.googlesource.com/c/1289677
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601713}
Reviewed-on: https://chromium-review.googlesource.com/c/1297583
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#279}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Improve app list transition animation triggered by dragging
Changes:
1. Avoid calculating and updating opacity for all apps for each dragging
update. Instead, calculate opacity of each row in current page and
only update changed apps. Also avoid button press on page switcher
during dragging to prevent opacity not being reset.
2. Clear search results after widget has been destroyed to avoid jank
during close animation.
Bug: 897384
Change-Id: Id0e848cc82f60740212467c64e05d032081ad45b
Reviewed-on: https://chromium-review.googlesource.com/c/1292386
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601755}(cherry picked from commit c50e7d35b8970e0d883044689d66ebe688f3f7b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1297579
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#278}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Adds missing OfflinePage downloads metrics reporting (M71 merge)
This change also splits the reporting of offline page counts between
prefetched and non-prefetched.
Bug: 896095, 894643
Change-Id: Ic3bfc53ecd2558df1b349af66bbe7d3f88bd6531
Reviewed-on: https://chromium-review.googlesource.com/c/1285750
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Carlos Knippschild <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601015}(cherry picked from commit 6195222c2431e6d83b569a4b5297c5d9be8ce890)
Reviewed-on: https://chromium-review.googlesource.com/c/1297303
Reviewed-by: Carlos Knippschild <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#277}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[HTS] Use smaller resource for incognito tab icon
Bug: 851166
[email protected]
(cherry picked from commit f7de3ed33a3ecf175b858be5358c8fe60e58d2ed)
Change-Id: Icbd81a2dc22e274173ddf8f9cf79820c077f56ba
Reviewed-on: https://chromium-review.googlesource.com/c/1286765
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601770}
Reviewed-on: https://chromium-review.googlesource.com/c/1297302
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#276}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Focus state should only be shown when navigating using keyboard
[email protected]
(cherry picked from commit 753cc316eb81dde076a3dd41d9255134287ea229)
Bug: 885219
Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b
Reviewed-on: https://chromium-review.googlesource.com/c/1290196
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Yue Cen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601267}
Reviewed-on: https://chromium-review.googlesource.com/c/1297397
Reviewed-by: Yue Cen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#275}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}CrOS shelf: indicator tweaks to match spec
* Reduce space to edge of screen.
* Draw the indicators as strokes, not rects, to be able to use "softer"
flags (stroke cap, etc.).
Bug: 880578
Change-Id: Ic4268766561d2d038589f5216d22084463f551d4
Reviewed-on: https://chromium-review.googlesource.com/c/1288505
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Manu Cornet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600923}(cherry picked from commit fba6372d7b290c76960bc8145ac8e816a3a12d57)
Reviewed-on: https://chromium-review.googlesource.com/c/1296932
Reviewed-by: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#274}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}CrOS shelf: some more 'old UI' cleanup
Change-Id: Ie294e13bd2b4eaf14343e328b0d5fb2b22a30251
Bug: 864701
Reviewed-on: https://chromium-review.googlesource.com/c/1278616
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Manu Cornet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599642}(cherry picked from commit c334b9d129837feaf35522148893176065fdaf8a)
Reviewed-on: https://chromium-review.googlesource.com/c/1296931
Reviewed-by: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#273}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Set WebUsbAllowDevicesForUrls policy to future
This change updates the WebUsbAllowDevicesForUrls policy entry in
policy_templates.json to have the future property set to true.
This prevents the policy from being in documentation and the
generated ADMX and linux.json file until the policy is visible
in Site settings.
Design document:
https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w
Bug: 854329, 897887
Change-Id: Ib2c9a04fd992d8c6c88a52ec9c954a48ff9a673d
Reviewed-on: https://chromium-review.googlesource.com/c/1262082
Commit-Queue: Ovidio Henriquez <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601277}(cherry picked from commit 2faba286f45587d104c80dceee4c2084e3eab5b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1297058
Reviewed-by: Ovidio Henriquez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#272}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71 merge] assistant: Add a11y heading to query log
This cl adds a11y heading to query log in the AssistantQueryView.
[email protected]
Bug: b/113734499
Test: tested on EVE
Change-Id: I5dcca50ef2b6a28e050b3dc462437c60036c56d7
Reviewed-on: https://chromium-review.googlesource.com/c/1285051
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600932}(cherry picked from commit 16d5b646681fd0ce56f40ada889ef72b253bf0cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1297186
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#271}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Hide Assistant UI on deactivation.
Previously we hid Assistant on widget deactivation. Then we removed
that logic to instead use an event handler that dismissed Assistant on
press.
We actually need both since Assistant widget can be deactivated w/o a
press event, such as happens when opening feedback via Alt+Shift+i.
Bug: b:117990949
Change-Id: I75338ef112f5cef3445bf88903adaef2ccd56c48
Reviewed-on: https://chromium-review.googlesource.com/c/1292604
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601372}(cherry picked from commit 61ee8f21fe8b46464e50f7afd0beadf21f3d8259)
Reviewed-on: https://chromium-review.googlesource.com/c/1294836
Cr-Commit-Position: refs/branch-heads/3578@{#270}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Canvas lowLatency: add UseCounter
This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to
complement said experiment, see the feature entry in
https://www.chromestatus.com/feature/6360971442388992
[email protected]
(cherry picked from commit b045388d3008951278d3a277bd3cfee16063c94d)
Bug: 895907
Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36
Reviewed-on: https://chromium-review.googlesource.com/c/1293557
Reviewed-by: Fernando Serboncini <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601605}
Reviewed-on: https://chromium-review.googlesource.com/c/1296676
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#269}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cherry pick r601765 to M71
This cl merges the following cl to M71:
https://chromium-review.googlesource.com/c/1294398
The cherry pick is locally built and tested on M71. Gerrit cherry pick was not possible
since the fling browsertests landed before r601765 caused merge conflicts.
This cl only picks the fix that is added to render_widget_host_view_child_frame.cc
and leaves fling_browsertests.cc untouched to resolve the conflict.
[email protected],[email protected]
Bug: 897901
Change-Id: I7f3f8b581ddbd78c3de538b87c40c1e535f2dfd3
Reviewed-on: https://chromium-review.googlesource.com/c/1297077
Reviewed-by: Sahel Sharify <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#268}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[WebAuthN] Enable M70 Features By Default
This change enables the WebAuthN M70 Features "WebAuthenticationUI",
"WebAuthenticationTouchId" and "WebAuthenticationCableWin" by default.
Relevant Launch Bugs:
- TouchId: https://crbug.com/837392
- UI and CableWin: https://crbug.com/873195
[email protected]
Bug: 897765
Change-Id: I3693fbd28c0b11978a045c7fa9f68c9e4995c1a0
Reviewed-on: https://chromium-review.googlesource.com/c/1288795
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600862}(cherry picked from commit 6bc8e4216954d736db67110a247bac5846c2c68e)
Reviewed-on: https://chromium-review.googlesource.com/c/1296672
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#267}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M-71] (Reland) Hide option to remap internal search when no internal KB is connected
To avoid confusion when there is no internal keyboard connected:
- We should not show the option to remap the internal "Search"
key since that key doesn't exist.
- We should also avoid labeling the options to remap the external
meta keys as "External Meta" or "External Command", and just say
"Meta" or "Command" as "External" here is redundant.
[email protected]
BUG=890522, 890950
TEST=Expanded existing tests.
Reviewed-on: https://chromium-review.googlesource.com/c/1253022
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599409}
Change-Id: I3136efe54d2544423e4dd9b23fe8ffabffe3caf0
Reviewed-on: https://chromium-review.googlesource.com/c/1292890
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601403}(cherry picked from commit 65be235102ddcdc7158ad31f5d0e8e1de9f92fce)
Reviewed-on: https://chromium-review.googlesource.com/c/1296997
Cr-Commit-Position: refs/branch-heads/3578@{#266}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Make metadata only observe syncing wallet changes
When Wallet sync is inactive, we can't rely on the cards being present.
The Wallet Metadata sync integration relies on Wallet data to prune
no-longer relevant metadata entries.
This CL changes the metadata syncable service to only do this pruning of
old metadata entries when we're sure that the wallet data bridge is
running.
Bug: 890709
Change-Id: Iaad482326ae0b147bf343d71e95c3bbe3e413d99
Reviewed-on: https://chromium-review.googlesource.com/c/1273297
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Commit-Queue: Florian Uunk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601590}(cherry picked from commit 8bb9f4d3c815d1f6dd4c5dffcd912e72de4aec29)
Reviewed-on: https://chromium-review.googlesource.com/c/1296507
Reviewed-by: Florian Uunk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#265}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Disable resident key credential creation and usage.
Prevents create() calls where requireResidentKey = true.
Also disables resident credentials in getAssertion calls entirely until
they can be fully and properly supported. (Previously, if an empty list
was passed to getAssertion() and resident credentials for
that RP existed, then a random single credential would be passed back.)
Bug: 896404
Change-Id: Ic6efcb99891825f929efba616ff5cf5788236a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1287089
Commit-Queue: Kim Paulhamus <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600858}(cherry picked from commit e2c6c8b623a895e42ab4c5cd8fc9329d31ed9f49)
Reviewed-on: https://chromium-review.googlesource.com/c/1296544
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#264}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}extensions/tcp_socket: Fix crash on disconnect with Connect/Listen pending (M71 merge)
Bug: 882585
Change-Id: Ic740f1ccd310ba5fc23f7bbb6f6bb40d6a3c59c2
Reviewed-on: https://chromium-review.googlesource.com/c/1287069
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Maks Orlovich <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600887}(cherry picked from commit 9566887be99d822632aa4429afb768406f749a23)
Reviewed-on: https://chromium-review.googlesource.com/c/1296617
Reviewed-by: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#263}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix touch action filter for double-tap-drag zoom
The touch action filter currently relies on checking the
GestureScrollBegin event for whether we need to filter or not. It
assumes a pinch-zoom will cause a GSB with a pointer_count == 2 and so
pinch-zoom is filtered in that way, since we always bracket GesturePinch
events between a GSB and a GestureScrollEnd.
However, this breaks down for double-tap-drag zoom (i.e. double tap but
hold and drag the second tap to zoom). In this case, the pointer_count
is 1 so we don't filter it.
In this CL, we remove the bracketing of pinch gestures in the
double-tap-drag zoom case and allow activating the filter at
GesturePinchBegin. We must now track in the TouchActionFilter whether
we've seen a GestureScrollBegin so that we know whether to apply and
remove the filtering at GesturePinchBegin/GesturePinchEnd.
Bug: 865090
Change-Id: I25e426f6f48dbf0ebcecfbddee5e2d8cbcc40504
Reviewed-on: https://chromium-review.googlesource.com/c/1279236
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Timothy Dresser <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600937}(cherry picked from commit d713bb2e97b0a7ef30473414d3324ecd3abdecaf)
Reviewed-on: https://chromium-review.googlesource.com/c/1296325
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#262}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[unified-consent] Disable off-by-default services during rollback
When the user opted into unified consent and then the feature is
rolled back, all off-by-default services are disabled.
Bug: 894504
Change-Id: I50adddb41cab7c38162344a538eef52e04dfa999
Reviewed-on: https://chromium-review.googlesource.com/c/1280445
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600746}(cherry picked from commit 52590937509617eb2637f22ad5110aa62cd6978e)
Reviewed-on: https://chromium-review.googlesource.com/c/1296530
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#261}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Dice] Fix title in user menu when offline
The profile card title in the user menu is
fixed for non-syncing users that are offline.
Bug: 897078
Change-Id: I041cf8296d0ab8b77f0bd8b082cf8f03e418828f
Reviewed-on: https://chromium-review.googlesource.com/c/1290913
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601153}(cherry picked from commit 101f247d6ce97ca5ce8bc400c55b88a632852ecf)
Reviewed-on: https://chromium-review.googlesource.com/c/1296493
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#260}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Only stop datatypes that are actually running
We have this check in ModelAssociationManager::Stop, so it makes sense
to add it to ModelAssociationManager::StopDatatype too.
Bug: 894852
Change-Id: If5f472ea74cba7bbe60f796b1255c8e54d65a069
Reviewed-on: https://chromium-review.googlesource.com/c/1290149
Commit-Queue: Florian Uunk <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601514}(cherry picked from commit 37b83cf92779c09cf759bd280e78e6087efb5231)
Reviewed-on: https://chromium-review.googlesource.com/c/1296529
Reviewed-by: Florian Uunk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#259}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[ios] Removed promo cell when searching bookmarks on root
Bug: 894031
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib7d7e07e198043f8aacbbf78eef30a496be6550d
Reviewed-on: https://chromium-review.googlesource.com/c/1288530
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: David Jean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601071}(cherry picked from commit 7297c666761a307315eb2357cc5c68aa2cce70dd)
Reviewed-on: https://chromium-review.googlesource.com/c/1295812
Cr-Commit-Position: refs/branch-heads/3578@{#258}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Do not use GetFirstResponderSubview on iOS 10.
When a WKWebView is displaying a PDF, the first responder is not in the view hierarchy (but a class adhering to UIResponder).
Bug: 882470
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6f9e993e740541b7cf009b1d11e16183b409fdae
Reviewed-on: https://chromium-review.googlesource.com/c/1284438
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600620}(cherry picked from commit 9cdf6a5127883a95220d7b3c9da0cb8b8b251871)
Reviewed-on: https://chromium-review.googlesource.com/c/1296054
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#257}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iaa32edb380537b449b59d37e227ca4e897d2b716
Reviewed-on: https://chromium-review.googlesource.com/c/1296053
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#256}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}media/gpu/VAAPI: Enable HW JPEG decoding on Grunt.
This change removes the "Mesa Gallium driver" from the blacklist in the vaapi
JPEG decoder.
TEST=ran VDA tests on Grunt
Bug: 828119
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95
Reviewed-on: https://chromium-review.googlesource.com/c/1256462
Commit-Queue: David Staessens <[email protected]>
Reviewed-by: Pawel Osciak <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599559}(cherry picked from commit 5fd4b78a787129ec952da757b4195ebc81e37c57)
Reviewed-on: https://chromium-review.googlesource.com/c/1295610
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#255}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.20
[email protected]
Change-Id: I06eac4df3fc0664a743d2880faf1c258f79ac97e
Reviewed-on: https://chromium-review.googlesource.com/c/1295274
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#254}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove dead code for migration flow
Code regarding the dialog pending view is useless now since we've
changed the design.
Previously dialog would change to a pending state with all checkboxes
and buttons disabled after the user clicks the save button. And after
5 secs a close button would show.
New design is to dismiss the dialog directly.
Bug: 852904
Change-Id: Idb0ab56f80431a8c26a6bd178ef864bcc16887f0
Reviewed-on: https://chromium-review.googlesource.com/c/1282037
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599857}(cherry picked from commit a67ec2b65e3411fb1cf87900f820e54143827a5c)
Reviewed-on: https://chromium-review.googlesource.com/c/1295590
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#253}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix a crash when long clicking suggestions in the omnibox.
I've never been able to repro, but to me this looks like long
clicking while we're in the middle of tearing down the activity somehow.
The quick bandaid fix is to catch the BadToken exception, but hopefully
we'll be able to do something more graceful with the MVC refactor.
This moves the logic to the Coordinator to avoid the 3 delegate calls
and minimize it to one (and reduces the business logic in the view).
NOPRESUBMIT=true
BUG=881074
Change-Id: I611648abcfa9ba87c2fe0ecd63e212f1985e1834
Reviewed-on: https://chromium-review.googlesource.com/c/1278957
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599349}(cherry picked from commit 09ab59fc28f60d8c6a2c5b94f5429cf783ae0877)
Reviewed-on: https://chromium-review.googlesource.com/c/1295180
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#252}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Defer widget creation until surface has come content.
A shell surface widget needs be created when the surface has a content,
(https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=63840f211efada36274cae7ade3003a2dc88c74b&l=475)
but it can be created without content if a client requested maximize/fullscreen/minimize state upon creation.
This is necessary since xdg (or gtk3 wayland client) seems to have an issue if we configure before the content
is created, and it stops updating frames, even if we sends new configure events later.
Bug: 892291
Test: Covered by unit tests. Also tested manually. See bug for repro step.
Change-Id: I115ec6540a0ec2fc5258c020bd05c4be623f85da
Reviewed-on: https://chromium-review.googlesource.com/c/1278986
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601382}(cherry picked from commit 369947b42b81eb4edc41d3b7cdf20a9cd8ce6bb1)
Reviewed-on: https://chromium-review.googlesource.com/c/1293999
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#251}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}🛃 Protect against disk read in queryIntentActivities
Bug: 894160
Change-Id: Idd2daa239adee9245690aaa8ae258437bf16c41f
Reviewed-on: https://chromium-review.googlesource.com/c/1275431
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599152}(cherry picked from commit 5275c3572a1a4f0255f17e3c50d20465922cfd1e)
Reviewed-on: https://chromium-review.googlesource.com/c/1295149
Reviewed-by: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#250}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to M71: Speculative fix for crash at ChromeAppListModelUpdater::OnItemUpdated
Bug: 894583
Change-Id: I7c1011ab2f8acffbe93b7523c6839f481f733ae7
Reviewed-on: https://chromium-review.googlesource.com/c/1279203
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599371}(cherry picked from commit 4d5af77655d2d5bec62549bd9360679645355cc5)
Reviewed-on: https://chromium-review.googlesource.com/c/1279348
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#4}
Cr-Original-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}(cherry picked from commit 16f1dabf14796c11b1f767bf412b3351dd9d1b16)
Reviewed-on: https://chromium-review.googlesource.com/c/1294839
Cr-Commit-Position: refs/branch-heads/3578@{#249}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to M71: Fix DCHECK failure in AppListView::GetAppListTransitionProgress()
Bug: 894582
Change-Id: I08b1740c9e653bb6f3aa5c57653643888d13e630
Reviewed-on: https://chromium-review.googlesource.com/c/1279239
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#599402}(cherry picked from commit 39face36234ad96435a8bc205cc5fa4b7b4e0f6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1279299
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#5}
Cr-Original-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}(cherry picked from commit 55b93a05865ed6848d4e85ec7f84c2cda1ee4098)
Reviewed-on: https://chromium-review.googlesource.com/c/1294837
Cr-Commit-Position: refs/branch-heads/3578@{#248}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to M71: Follow up to fix 1 px gap of app list
The original change fixed the bounds for app list window, but not for
its parent, so the issue is not fixed entirely. Fix it for the parent
window in this CL.
Bug: 884889
Change-Id: I6a48bae85fd3d89957d58a4aabf270c7df288d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1282386
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#600054}(cherry picked from commit 3cabcd8f9b4649870eccf0674a9d07df56bd0291)
Reviewed-on: https://chromium-review.googlesource.com/c/1287046
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3575@{#6}
Cr-Original-Branched-From: 16ca0c3f9db962f3a061a30a2d5d27cf9c77253c-refs/heads/master@{#597882}(cherry picked from commit efe4bb9b77874ce4d94c53da7d40d5a06fd5691c)
Reviewed-on: https://chromium-review.googlesource.com/c/1294872
Cr-Commit-Position: refs/branch-heads/3578@{#247}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.19
[email protected]
Change-Id: Ie487c829376c82dc84e711ccce6cee2716514ff7
Reviewed-on: https://chromium-review.googlesource.com/c/1294871
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#246}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Removes EnableSurfaceLayerForVideoMS flag."
This is a reland of 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5
Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
>
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
>
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Reviewed-by: Emircan Uysaler <[email protected]>
> Reviewed-by: Fady Samuel <[email protected]>
> Reviewed-by: Mounir Lamouri <[email protected]>
> Reviewed-by: Frank Liberato <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#599492}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
Bug: 746182
Change-Id: Ic55d683279bf7cc01b8cc57b560ba22a8cb055f6
Reviewed-on: https://chromium-review.googlesource.com/c/1284434
Commit-Queue: CJ DiMeglio <[email protected]>
Reviewed-by: CJ DiMeglio <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600832}(cherry picked from commit 892404731a96d57c5162ae52a0fe978ecff80fbf)
Reviewed-on: https://chromium-review.googlesource.com/c/1294694
Cr-Commit-Position: refs/branch-heads/3578@{#245}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Roll ICU to b029971f from ccad447.
This roll has two changes:
https://chromium.googlesource.com/chromium/deps/icu.git/+log/ccad447..b029971
One is for the timezone database update to 2018f and the other is
to fix a memory misalignment on ARM.
[email protected],[email protected]
Bug: 896322,473288
Test: See the bug and ICU CL descriptions.
Change-Id: I5802783e20637bc2dfa6950abe680a85e42e6c4c
Reviewed-on: https://chromium-review.googlesource.com/c/1293045
Reviewed-by: Jungshik Shin <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601449}(cherry picked from commit 6896452489369a7edb61f1ff4354217023fd1372)
Reviewed-on: https://chromium-review.googlesource.com/c/1294693
Cr-Commit-Position: refs/branch-heads/3578@{#244}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Smart Lock: Display the enterprise controlled state of sign-in pref.
R=[email protected]
Bug: 894598
Test: none
Change-Id: I85bfe11dda29295d45c609851222bd40fff98ef7
Reviewed-on: https://chromium-review.googlesource.com/c/1283486
Commit-Queue: James Hawkins <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600800}(cherry picked from commit 0b3eda72f5cf23bd2c78368de0a584ce3466e2f8)
Reviewed-on: https://chromium-review.googlesource.com/c/1294672
Reviewed-by: James Hawkins <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#243}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix regression which caused Assistant chips to shrink.
For Assistant, we use a horizontal BoxLayout which relies on
GetHeightForWidth to determine chip size. By removing this method
override we will no longer respect kPreferredHeightDip.
Screenshot in the bug.
Bug: b:117991892
Change-Id: Ic6b889a477b262290285ad5e61c3922ee43ceb6f
Reviewed-on: https://chromium-review.googlesource.com/c/1292608
Commit-Queue: David Black <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601360}(cherry picked from commit 0c15a3ce3054300efdaca196c3cca693805e9f3b)
Reviewed-on: https://chromium-review.googlesource.com/c/1294296
Cr-Commit-Position: refs/branch-heads/3578@{#242}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Removes EnableSurfaceLayerForVideoMS flag."
This reverts commit d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469.
Reason for revert: Should not have been merged.
Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
>
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
>
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <[email protected]>
> Reviewed-by: Chris Harrelson <[email protected]>
> Reviewed-by: Emircan Uysaler <[email protected]>
> Reviewed-by: Fady Samuel <[email protected]>
> Reviewed-by: Mounir Lamouri <[email protected]>
> Reviewed-by: Frank Liberato <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
> Reviewed-on: https://chromium-review.googlesource.com/c/1294203
> Reviewed-by: CJ DiMeglio <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3578@{#224}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[email protected]
Change-Id: I21efdbe1bbb0c1cf357de327042273f9d3a7b210
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 746182
Reviewed-on: https://chromium-review.googlesource.com/c/1294749
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#241}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[iOS] Moving up the sign in buttons inside the safe area
Adding a fix that should have been committed with crrev.com/1286659
When the OK button layout is updated, the container layout should be
updated too.
[email protected]
(cherry picked from commit 6ccb6aee8e61a18e7e74f2baa15d961f6ba05576)
Bug: 897105
Change-Id: I80a22e755d3255b4ce2c5f637280a3ac7576f1a5
Reviewed-on: https://chromium-review.googlesource.com/c/1290978
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601137}
Reviewed-on: https://chromium-review.googlesource.com/c/1294533
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#240}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[iOS] Moving up buttons in sign-in and first-run views inside the safe area
The sign-in/firstrun buttons is moved inside the safe area (related to
the iPhone X like).
The patch has been tested with rotation.
** Before **
- First run:
https://drive.google.com/open?id=1Ig3SCaKTeCZkf3KfCnRHfPpAA9mZdLSB
- Sign-in with first run:
https://drive.google.com/open?id=1arrBQ44c9kj7_R8xIykEfxLcJZjfTlZT
- Sign-in portrait:
https://drive.google.com/open?id=17UlTFkc416iU72LeMFgg9PoEG-gRVXCc
- Sign-in landscape:
https://drive.google.com/open?id=1pqC00vqx6AtHDJHXSxc_0yZ2Qr_1O66l
** After **
- First run:
https://drive.google.com/open?id=1c6rJtftJInGlNgLTj19jmsbzgRf3hQZv
- Sign-in with first run:
https://drive.google.com/open?id=19GRHlX6HdyO5HnPkVDzKCbxfcwSsyFyn
- Sign-in portrait:
https://drive.google.com/open?id=187VDZsNLMzI50q4RLi2eAaLsXs7aZ6Zm
- Sign-in landscape:
https://drive.google.com/open?id=1Q_WCYA8-JMI5cRtshLKAjFIXk9vLaNEn
[email protected]
(cherry picked from commit c15023d8e63cd0389a73fbb711a4e9c18345e0cb)
Bug: 864225
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I33478974bbb0de2180ab842eb07321dcf5140ed0
Reviewed-on: https://chromium-review.googlesource.com/c/1286659
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601082}
Reviewed-on: https://chromium-review.googlesource.com/c/1294532
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#239}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71][AF] Use 'Manage...' as footer string when popup type is unspecified
Bug: 893592
Change-Id: I619bb47295302ba74301c327372206269c12bf23
Reviewed-on: https://chromium-review.googlesource.com/c/1293729
Commit-Queue: Fabio Tirelo <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601618}(cherry picked from commit 65c419d84ae1f69966f168f4b298b3a4dfd30495)
Reviewed-on: https://chromium-review.googlesource.com/c/1294413
Cr-Commit-Position: refs/branch-heads/3578@{#238}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Turn off signin-allowed toggle after sign-out from dialog
When a sync user confirms to sign out after trying to turn
off the signin-allowed toggle, the toggle is now turned off.
Additional change:
- The code related to the sign-out dialog in settings is
extracted into its own element and refactored.
Bug: 892745
Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8
Reviewed-on: https://chromium-review.googlesource.com/c/1280542
Reviewed-by: Scott Chen <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600997}(cherry picked from commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3)
Reviewed-on: https://chromium-review.googlesource.com/c/1294511
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#237}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Explore sites]: Use TileGridLayout from suggestions to render ESP grid.
This fixes issues on smaller screens or "Large" displays where the 4th column is cut off
Bug: 896492
Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b
Reviewed-on: https://chromium-review.googlesource.com/c/1287253
Commit-Queue: Cathy Li <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601258}(cherry picked from commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b)
Reviewed-on: https://chromium-review.googlesource.com/c/1294473
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#236}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Show sign-out dialog when signin-allowed is toggled off
This CL changes the behavior of the signin-allowed toggle
on the privacy page:
- When the user is syncing and tries to turn the toggle off,
the toggle remains on and the sign-out dialog is opened.
- When the user turns off sync, they can normally use the
toggle.
TBR= [email protected], [email protected]
Bug: 892745
Change-Id: If606532345645ae91a93212abc8ba7e521db56ed
Reviewed-on: https://chromium-review.googlesource.com/c/1278637
Reviewed-by: Thomas Tangl <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599538}(cherry picked from commit a75477ad4731366a27e14849c7d64af556b028ec)
Reviewed-on: https://chromium-review.googlesource.com/c/1294509
Cr-Commit-Position: refs/branch-heads/3578@{#235}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] aw: Delay onPageStarted until navigation commit
This CL only moves onPageStarted of *renderer initiated* navigation to
navigation commit. Browser initiated navigations are not changed.
WebContentsObserver.didFinishNavigation is navigation commit, which is
where onPageStarted of successful navigation is called. On error,
onPageStarted is called from AwContentsClientBridge.onReceivedError.
In order to distinguish between browser-initiated and renderer-initiated
navigations, need to plumb the bool to all of these call sites.
* Add new parameter to java WebContentsObserver.didFinishNavigation
which requires updating a bunch of overrides.
* Add isRendererInitiated to java NavigationParams.
* Use ui::PageTransitionIsWebTriggerable to approximate
renderer-initiated.
New bool in AwWebResourceRequest is optional because there are code
paths that do not have this information, and do not need it.
Other changes:
* Update WebContentsObserverProxy::DidFinishNavigation to return the
base url if it is not empty. This ensures the new onPageStarted uses
the same url as before.
* Change LoadUrl calls to PageTransition.TYPED. This matches expectation
better and make ui::PageTransitionIsWebTriggerable work.
* Do not call didFailLoad, which calls onPageFinished, if navigation did
not commit. This can happen for downloads.
* Also add isDownload to WebContentsObserver.didFinishNavigation. This
is important for suppressing onPageStarted and onPageFinished for
downloads due to content-disposition: attachment
* Add tests for all of the cases discussed here
Bug: 896022
(cherry picked from commit 5f9a4bfa44393e287226b14a06bb1620e92c1228)
Change-Id: Ia30f733a9f4b0684683fe5594305a72b611f0442
Reviewed-on: https://chromium-review.googlesource.com/c/1270096
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600787}
Reviewed-on: https://chromium-review.googlesource.com/c/1294470
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#234}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Avoid a crash with a hacky null check in GetURLForDebugTrace().
This is called when there's no frame for the WebWidget, which is bad.
Since this is a problem in M71, here's something small for an easy
merge. I have a better fix for at least one case where this can happen
in a follow-up, in which I'll revert this hack.
[email protected]
[email protected]
(cherry picked from commit 4b494160abc4a0d39170a8dac94e3cbb9873719b)
Change-Id: Icbffcad6a0fe74bf1ae47e1d51c65aba844ccc5e
Bug: 896836
Reviewed-on: https://chromium-review.googlesource.com/c/1292711
Reviewed-by: enne <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601339}
Reviewed-on: https://chromium-review.googlesource.com/c/1294407
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#233}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Remove notifications after OOBE setup flow
At present, if a user turns down MultiDevice setup in OOBE, they will
see a notification prompting them to go through our regular setup flow.
In order to avoid spamming people with unwanted notifications, this CL
keeps track of if/when the user saw setup flow in OOBE and prevents
future setup prompting notifications if they have.
(cherry picked from commit 9bc3529fa3e30165627cdb56d378c207dd118c8c)
Bug: 892829, 884401
Change-Id: I231a25d7879b37912c8594998578eea9afadbf5e
Reviewed-on: https://chromium-review.googlesource.com/c/1275432
Commit-Queue: Jordy Greenblatt <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Stefan Kuhne <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600833}
Reviewed-on: https://chromium-review.googlesource.com/c/1289166
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#232}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Web Audio: fix two bugs in audibility detection in BaseAudioContext.
Fixing the following issues:
- take into account AudioContext stopping;
- removes 10 seconds limitation.
Bug: 897451
Change-Id: I63b22fc20ded193cd032e30722ab35571adba56c
Reviewed-on: https://chromium-review.googlesource.com/c/1292378
Commit-Queue: Mounir Lamouri <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601415}(cherry picked from commit 1a0371469a2941c5d37464900be4404ceae55215)
Reviewed-on: https://chromium-review.googlesource.com/c/1294033
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#231}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cc: Rate limit raster metric queries.
Since queries for measuring GPU side raster duration is too expensive,
rate limit the tiles for which we measure this metric to 1%.
R=[email protected]
Bug: 894200,896821
Change-Id: I0713e537447a8ca7ebec30747314810e1a881d6e
Reviewed-on: https://chromium-review.googlesource.com/c/1292110
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601319}(cherry picked from commit e898b99eac0cf5db379cf8c7e216d772095a7448)
Reviewed-on: https://chromium-review.googlesource.com/c/1294397
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#230}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}gpu: Fix raster implementation error for no flush result available query
The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being
handled, and as a result we were doing a check before the result was
available and causing a flush.
R=[email protected]
Bug: 896830,894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e
Reviewed-on: https://chromium-review.googlesource.com/c/1289958
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601003}(cherry picked from commit da82bcce69bf5384435976a1945c9cb3270c5abb)
Reviewed-on: https://chromium-review.googlesource.com/c/1294396
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#229}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cc: Avoid acquiring the context lock if unnecessary.
Acquiring the context lock marks the context as busy and can delay
cleanup of gpu memory. Avoid acquiring it if there are no pending raster
queries.
R=[email protected]
Bug: 896260, 894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I91b9ea85ef11b0b31e9d14599800efb0d2ca00e0
Reviewed-on: https://chromium-review.googlesource.com/c/1287931
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600824}(cherry picked from commit 5d4e09620ff79ac668c72ad3677f993b75e617ce)
Reviewed-on: https://chromium-review.googlesource.com/c/1294394
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#228}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland gpu: Add UMA metric for measuring total raster task duration.
Add an UMA metric which reports the accumulated time for a raster task
including the time from raster worker thread and the GPU main thread.
The GPU side timer takes care of only measuring time slices when the
decoder is processing commands.
[email protected], [email protected], [email protected]
BUG: 894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7ed515daba4b5bdc701a20e5ff33dc770d170b2b
Reviewed-on: https://chromium-review.googlesource.com/c/1283487
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600158}(cherry picked from commit cd8fbb77cfa164eef66378204a588443af9bb875)
Reviewed-on: https://chromium-review.googlesource.com/c/1294393
Cr-Commit-Position: refs/branch-heads/3578@{#227}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix: variations service not processing studies on ChromeOS.
This is caused by not setting chrome channel before initializing FeatureList in
early startup, which was introduced in CL (https://crbug.com/1173163). In this
CL, we make GetChannel() call the SetChannel() if the channel hasn't been set
yet.
Bug: 896416
Change-Id: Id89c199779074d762f1d16edc711fedaaab66694
Reviewed-on: https://chromium-review.googlesource.com/c/1287850
Commit-Queue: Xi Han <[email protected]>
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601119}(cherry picked from commit 94b2aa6c3148710e35d788a2bcb2617caff0f05d)
Reviewed-on: https://chromium-review.googlesource.com/c/1294389
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#226}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Override stub path before PreEarlyInitDBus
Otherwise install attributes are not loaded on the linux Chrome OS
build.
TEST=manual
Bug: 848615, 729596
Change-Id: I445b2b337b707822459c076058610f49f02767ab
Reviewed-on: https://chromium-review.googlesource.com/c/1264643
Commit-Queue: Roman Sorokin <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599138}(cherry picked from commit b80ea1c80ef7c8ec439c14def8120498fc35eda8)
Reviewed-on: https://chromium-review.googlesource.com/c/1294207
Cr-Commit-Position: refs/branch-heads/3578@{#225}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Removes EnableSurfaceLayerForVideoMS flag.
Because the conditions in which we turn on surfaces for videos have grown
more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
it has been decided that special-casing MS videos was no longer required.
Bug: 746182
Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
Reviewed-on: https://chromium-review.googlesource.com/c/1250095
Commit-Queue: CJ DiMeglio <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Reviewed-by: Fady Samuel <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1294203
Reviewed-by: CJ DiMeglio <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#224}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix --log-net-log when Network Service is enabled.
[email protected]
(cherry picked from commit 2b9260e4750165fb9b3683c745ce1ec6d6511139)
Bug: 894801
Change-Id: Ieb17a626284296b6f86f4cf9add2fca4359f7d8a
Reviewed-on: https://chromium-review.googlesource.com/c/1285649
Commit-Queue: Eric Roman <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600592}
Reviewed-on: https://chromium-review.googlesource.com/c/1293997
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#223}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Change the Lite Page strings
It was agreed that we should use "provided" instead of "delivered".
Bug: 896774
Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990
Reviewed-on: https://chromium-review.googlesource.com/c/1289293
Reviewed-by: Doug Arnett <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600865}(cherry picked from commit c0c61543e8740e61b22be6f0f0d1943b09bd8ba7)
Reviewed-on: https://chromium-review.googlesource.com/c/1294229
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#222}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver"
This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7.
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=896603
Original change's description:
> Network Service: Convert port_forwarding_controller.cc to mojo host resolver
>
> Bug: 874651
> Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d
> Reviewed-on: https://chromium-review.googlesource.com/1184306
> Reviewed-by: Andrey Kosyakov <[email protected]>
> Reviewed-by: Matt Menke <[email protected]>
> Commit-Queue: Jun Cai <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#585658}
[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 874651, 896603
Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee
Reviewed-on: https://chromium-review.googlesource.com/c/1292824
Commit-Queue: Jun Cai <[email protected]>
Reviewed-by: Jun Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813)
Reviewed-on: https://chromium-review.googlesource.com/c/1294192
Cr-Commit-Position: refs/branch-heads/3578@{#221}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download location android: Check SD card before showing location dialog.
This CL checks if the user has SD card. Don't show download location
dialog if user don't have SD card.
[email protected]
(cherry picked from commit 64cf7d9d47c095cf87f5aebf9be56a72c87049f3)
Bug: 896873
Change-Id: I157b8958669c0692247f7cf3798f32867675b11c
Reviewed-on: https://chromium-review.googlesource.com/c/1290509
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601365}
Reviewed-on: https://chromium-review.googlesource.com/c/1294189
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#220}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updated Media Router icons to new Material Design versions.
Bug: 892797
Change-Id: I6aee5aafb1f68f6eabc37adab8fd91b5ea11cd29
Reviewed-on: https://chromium-review.googlesource.com/c/1278139
Commit-Queue: John Williams <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600561}(cherry picked from commit ceaf65fa2f12145c42c1d3f30134844c3efef8e2)
Reviewed-on: https://chromium-review.googlesource.com/c/1294017
Cr-Commit-Position: refs/branch-heads/3578@{#219}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Don't show the selection widget for the first overview item if...
... the selection widget is already active or the filter string is empty.
Bug: 893384
[email protected]
Change-Id: I793e083991ef60361a4ca3056347a4023919b240
Reviewed-on: https://chromium-review.googlesource.com/c/1292713
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601346}(cherry picked from commit e5ab1b23536ec86f675c3c2987bb660af8c3ac0d)
Reviewed-on: https://chromium-review.googlesource.com/c/1293998
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#218}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix About Chrome license string
Fixes the placeholder to match the version in chromium_strings.grd.
Bug: 895201
Change-Id: I31e1aec017661597cad41f9d9a1fff6601000b3a
Reviewed-on: https://chromium-review.googlesource.com/c/1288908
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601272}(cherry picked from commit bd09de18c9172758d6635562690b45176f254e9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1294015
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#217}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Hide Play Store in Demo Mode behind a flag
Hides Play Store in Demo Mode by default, because it doesn't show the
right view yet.
To test Play Store in Demo Mode after this CL, use the flag:
--show-play-in-demo-mode
[email protected]
Bug: 885370
Change-Id: I7119a208742caf3fd2884ac73176a9bbc19a2bde
Reviewed-on: https://chromium-review.googlesource.com/c/1277841
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600120}(cherry picked from commit 25063a81633ec3d1abac7717502911384cd5ebf6)
Reviewed-on: https://chromium-review.googlesource.com/c/1291210
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#216}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[EoS] Fix the blacklist application
Some sites were being added to the blacklist properly, but not filtered
out when doing the join against the blacklist table. This happened
because the sites in our database did not consistently end with "/",
but sometimes a "/" got added before we put the site into the blacklist.
The fix here is to pass all sites through GURL and get the spec after
parsing, so they will be consistent.
Bug: 893845
Change-Id: Id705aab833da546c57950fad115c694b96c5fd24
Reviewed-on: https://chromium-review.googlesource.com/c/1281176
Reviewed-by: Dmitry Titov <[email protected]>
Commit-Queue: Peter Williamson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600037}(cherry picked from commit f5f3e4589bce29e58ca0c2df2285374087881da9)
Reviewed-on: https://chromium-review.googlesource.com/c/1293994
Reviewed-by: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#215}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[EoS] Site Blacklisting part 3 - Remove sites from the UI.
When the user chooses the "remove" item from the long press menu,
remove the site from the UI. It is already being removed from the database.
Bug: 893845
Change-Id: Icbd8292475983f4c263113043a001d11f3f09521
Reviewed-on: https://chromium-review.googlesource.com/c/1278955
Commit-Queue: Peter Williamson <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599438}(cherry picked from commit a564f6e01d3486288673b7f63e679e004108f067)
Reviewed-on: https://chromium-review.googlesource.com/c/1294013
Reviewed-by: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#214}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[EoS] Site blacklisting part 2
Make sure sites in the blacklist are not returned as part of a catalog get
operation. This builds upon Site blacklisting part 1.
Bug: 893845
Change-Id: I38686753167bbcb8e9f9d75d6c323bda813cab31
Reviewed-on: https://chromium-review.googlesource.com/c/1274058
Commit-Queue: Peter Williamson <[email protected]>
Reviewed-by: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599325}(cherry picked from commit da6c8bfcbd9edb1a2dfa29642124c3b762c05894)
Reviewed-on: https://chromium-review.googlesource.com/c/1293993
Reviewed-by: Peter Williamson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#213}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Use preferred language in extension i18n
When localizing an extension, prioritize the user's preferred language
over the application locale.
Normally, these are the same. In some cases, they differ. For example,
the user may choose to display Chrome in "en-CA" (the intl.app_locale
pref), but because we don't have translations for that, the actual
UI locale is "en-GB".
This CL makes extensions try to use the user's preferred locale for i18n
("en_CA"), falling back to the UI locale ("en_GB") if no locale
directory is found for the preferred locale.
This change also updates the "current_locale" manifest key to reflect
the user's preferred locale, or the UI locale if intl.app_locale is
unset.
Note: Like the application locale, the preferred locale is only set at
startup (and in certain situations in CrOS). If the user changes their
intl.app_locale pref, they have to restart Chrome before extensions are
re-localized, just like before.
[email protected]
(cherry picked from commit 693d01a674be72cb5ee4bf1f0c622189e7e05b37)
Bug: 874225
Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d
Reviewed-on: https://chromium-review.googlesource.com/c/1244666
Commit-Queue: Michael Giuffrida <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600619}
Reviewed-on: https://chromium-review.googlesource.com/c/1292727
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#212}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Picture in Picture] Fix controls timer issue
PiP was having issues with hiding the controls because
we have a timer that will hide the controls. This timer
gets reset every time we interact with it. In one case
we actually stop the timer so it does not hide the controls
anymore.
BUG=897246
Change-Id: I4965b5c6cae0047ee0260131a16c9b346003bcec
Reviewed-on: https://chromium-review.googlesource.com/c/1292518
Reviewed-by: apacible <[email protected]>
Commit-Queue: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601302}(cherry picked from commit 00813839676fa207768ccc4f6b810e20f3cbf3a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1294011
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#211}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] Revert "Updated AllowedUILocales to handle preferred languages."
This reverts commit 75d0995fa069994cee37b7ba3c940c6927e7d91b.
Reason for revert: Causes DCHECK crashes on sign-in
Original change's description:
> Updated AllowedUILocales to handle preferred languages.
>
> Updated AllowedUILocales to limit not only the ui locales but also the
> available preferred languages. Renamed AllowedUILocales to AllowedLanguages to
> better indicate that.
>
> Bug: 579660, 876494, 894406
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3
> Reviewed-on: https://chromium-review.googlesource.com/c/1256570
> Commit-Queue: Zakhar Voit <[email protected]>
> Reviewed-by: Sergey Poromov <[email protected]>
> Reviewed-by: David Roger <[email protected]>
> Reviewed-by: Steven Bennetts <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#597559}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 579660
Change-Id: I6107a6668abde445d972a97e63dca93446b0ab0d
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/c/1278761
Reviewed-by: Alexander Hendrich <[email protected]>
Commit-Queue: Alexander Hendrich <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599503}(cherry picked from commit ca7c8b17ae5f868bc878c61e1d3018c9c9f08e13)
Reviewed-on: https://chromium-review.googlesource.com/c/1293909
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#210}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Show Previews UI at commit for Client LoFi
With the new UI in the Omnibox, showing the UI after a sometimes
significant delay whenever a lofi image is loadedis not a good user
experience. This moves the decision to show the UI to commit time.
Bug: 896476
Change-Id: I26b2ccaf9278435c3ccdfab508937d38fa64660c
Reviewed-on: https://chromium-review.googlesource.com/c/1289086
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Scott Little <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601199}(cherry picked from commit 7de62d0d6c829cf0ce0bd0e1ee46a4e9c4b943db)
Reviewed-on: https://chromium-review.googlesource.com/c/1293763
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#209}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to 71: Fixes potential crash when toggling accessibility services
Bug: 887235,890907
Change-Id: Id5aed4e8030ae0d8db02d369bf61772444b441ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286905
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600924}(cherry picked from commit 01a2d8ab84c37ee250db4fe0314776b81b0cf24a)
Reviewed-on: https://chromium-review.googlesource.com/c/1293759
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#208}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}chrome_features: Set Usbguard feature flag to disabled by default.
This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475
BUG=chromium:889118
Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <[email protected]>
Reviewed-by: Mattias Nissler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600780}(cherry picked from commit 6ef2e17aadaad1ecdf9055f645f885b16fce85d9)
Reviewed-on: https://chromium-review.googlesource.com/c/1288897
Cr-Commit-Position: refs/branch-heads/3578@{#207}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Use hairline for Explore on Content cards
BUG=896814
Change-Id: I07d4e0895862874347422661d7a3963e25216440
Reviewed-on: https://chromium-review.googlesource.com/c/1289514
Reviewed-by: Becky Zhou <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600994}(cherry picked from commit a54e2a65d1591101b5291af395243476012cbc0c)
Reviewed-on: https://chromium-review.googlesource.com/c/1293753
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#206}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Strengthen MITIGATION_DLL_SEARCH_ORDER on non-component builds."
This reverts commit 58443848dec954f3ae041db1f70e0342df460c6b
(just the policy setting on browser process).
Reason for revert: breaks some third party CAPI providers.
BUG=880835
Original change's description:
> Strengthen MITIGATION_DLL_SEARCH_ORDER on non-component builds.
>
> Also, add this mitigation to the browser process.
>
> BUG=870463
>
> Change-Id: I1e749a4ede0b41cca69f60262fd878c57ed35564
> Reviewed-on: https://chromium-review.googlesource.com/1162581
> Reviewed-by: Penny MacNeil <[email protected]>
> Commit-Queue: Will Harris <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#581067}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 870463
Change-Id: I2ae97b0955cc5d1196ab002e02285da05b3a4d35
Reviewed-on: https://chromium-review.googlesource.com/c/1292370
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Commit-Queue: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601318}(cherry picked from commit 432f4e5b65bcea622a49e2df274d72fd9c581d84)
Reviewed-on: https://chromium-review.googlesource.com/c/1293558
Reviewed-by: Steven Valdez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#205}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Tango->FCM] Drop all registrations on instanceID token change.
[email protected]
(cherry picked from commit d3fd9ec3b8ac2c23914c64f7b3516807c166e6cb)
Bug: 895080
Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16
Reviewed-on: https://chromium-review.googlesource.com/c/1278762
Commit-Queue: Tatiana Gornak <[email protected]>
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600794}
Reviewed-on: https://chromium-review.googlesource.com/c/1293458
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#204}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}mac: fix restoring minimized windows
This change:
1) Has BridgedNativeWidgetHostImpl notify the owning Widget when it becomes
minimized
2) Has session restore not activate minimized browser windows when selecting
a restored tab
3) Has session restore not show a newly created browser window if it's
minimized
restore save; without this change, the widget will not get saved as minimized.
window. On Mac, showing/activating a window implies de-minimizing it, so this
is required to avoid de-minimizing saved minimized windows, but I think it is
necessary on other platforms as well.
Test steps:
1) Start Chromium
2) Create a second browser window (cmd-n) and minimize it
3) In the first window, chrome://restart
Before this change, both browser windows appear after restart; after this
change, the first window appears and the second stays minimized.
Note that there is a graphical glitch when first restoring a window that is
minimized this way: the window paints as blank for a few frames while running
the deminiaturize animation.
Bug: 888218
Change-Id: I8ac121408336a7d6aeedd2b27cd2c9c9d20a18f2
Reviewed-on: https://chromium-review.googlesource.com/c/1268396
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599961}(cherry picked from commit 129abeac557646a4c99fdc9f27b00989b7fd36c1)
Reviewed-on: https://chromium-review.googlesource.com/c/1293551
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#203}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Android] Prevent Accessory from forcing InfoBar open
Before the keyboard accessory was visible on password fields only,
it was correct to suppress the InfobarContainer until the accessory
disappeared.
Now that the accessory can disappear while keeping the keyboard open,
the Infobar would be shown with an open keyboard. This CL fixes this
unwanted state by checking keyboard visibility explicitly.
This is an intermediate solution until crrev/c/1286426 lands.
Bug: 895779
Change-Id: I1d24b5c71ce094102e9860cd415277d9570c19df
Reviewed-on: https://chromium-review.googlesource.com/c/1286820
Commit-Queue: Friedrich Horschig [CEST] <[email protected]>
Reviewed-by: Ioana Pandele <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600777}(cherry picked from commit 060d3ad528fe0339b94211e58350b547cb0d9b63)
Reviewed-on: https://chromium-review.googlesource.com/c/1292561
Reviewed-by: Friedrich Horschig [CEST] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#202}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[ios] Fix bookmarks Edit button / Animation bugs
- Fixed Edit button to be disabled when seaching and no results.
- Fixed problem with background during search.
- Fixed clunky animation by closing search controller first.
Bug: 893559,893687,894031
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6846006abf82d2e6ef1b6a9d783f6824d27df076
Reviewed-on: https://chromium-review.googlesource.com/c/1276646
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: David Jean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599634}(cherry picked from commit 1a168223668906d8682d1bb309b54d408387d1b8)
Reviewed-on: https://chromium-review.googlesource.com/c/1292875
Cr-Commit-Position: refs/branch-heads/3578@{#201}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Support dynamic language change in PIN setup.
[email protected]
(cherry picked from commit 3a128abfe40dedecf137b4a45dce9759ad624c24)
Bug: 896645
Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02
Reviewed-on: https://chromium-review.googlesource.com/c/1290200
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601274}
Reviewed-on: https://chromium-review.googlesource.com/c/1293183
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#200}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Update PIN setup element to new look.
This Cl changes layout of PIN setup input/keyboard to match new specs.
This changes behavior both in First Run and in Settings UI.
[email protected]
(cherry picked from commit 76e77ff0012c21a18f341a2b95627f456fd43433)
Bug: 884667,890685
Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1286199
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600632}
Reviewed-on: https://chromium-review.googlesource.com/c/1293182
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#199}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Integrate Discover PIN setup into First run UI.
[email protected]
(cherry picked from commit 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a)
Bug: 852553
Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
Reviewed-on: https://chromium-review.googlesource.com/c/1250136
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599137}
Reviewed-on: https://chromium-review.googlesource.com/c/1293181
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#198}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Integrate PIN setup into Discover UI
[email protected]
(cherry picked from commit f479db8f992be027ddc9b715919df65ad4e40bb6)
Bug: 852553
Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
Reviewed-on: https://chromium-review.googlesource.com/c/1249496
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599130}
Reviewed-on: https://chromium-review.googlesource.com/c/1293180
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#197}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Adding WebRTC.Audio.JitterBufferFullPerMinute to metrics.
Bug: 896193
Change-Id: I046d763c004b2fafa66df76704489a1ab5d5821d
Reviewed-on: https://chromium-review.googlesource.com/c/1286415
Commit-Queue: Minyue Li <[email protected]>
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600745}(cherry picked from commit 774ca8ad2fa4431905e40c1ad40d2870c3c9fe8d)
Reviewed-on: https://chromium-review.googlesource.com/c/1292873
Cr-Commit-Position: refs/branch-heads/3578@{#196}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Zip Archiver: Auto-detect and decode filenames when it's ShiftJIS.
Some third-party archivers generate ZIP files which claim file names
are coded in CP437 but actually put file names in other coding system.
This change attempts to guess which encoding system they are, and
decodes the file and directory names.
Not all detected encodings are supported by the TextDecoder. There is
also coding name difference between CED and TextDecoder. By this reason
the set of encodings to be handled is whitelisted and translated by a
mapping. We can simply add mappings to support other encodings.
We also assume that all the files are coded in the uniform coding
system, so as to stabilize the automated coding system detection.
[email protected]
(cherry picked from commit f3b6430b37261dd5180011eba64f4d5cb494fc9d)
Bug: 846195
Test: browser_tests --gtest_filter='*ZipFiles*FilesAppBrowserTest*' --gtest_also_run_disabled_tests
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I284c189431d4fbac5554fb62507f1646517d279d
Reviewed-on: https://chromium-review.googlesource.com/c/1251684
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Anand Mistry <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600696}
Reviewed-on: https://chromium-review.googlesource.com/c/1293092
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#195}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Unified: Fix tray icon padding & network icon size
This CL adds 2dip padding between tray icons & fix WiFi icon padding.
WiFi icon is also used in network detailed view, so we have to set the
custom padding by checking IconType.
TEST=manual
BUG=885233
Change-Id: I5848007a1c71af54bba29105bcef7e063f7b6cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1286237
Commit-Queue: Tetsui Ohkubo <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600645}(cherry picked from commit d7a963df511af578c24bf87a66b879883b339547)
Reviewed-on: https://chromium-review.googlesource.com/c/1293054
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#194}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.18
[email protected]
Change-Id: I27c0ea1ee91b65cf4055dfcf5af9f7a518f2b7d6
Reviewed-on: https://chromium-review.googlesource.com/c/1292388
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#193}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[merge-m71] cros: Fix menus getting squished
Menu bounds do not fit new wider options if the menu options are added
after the menu is initially drawn, and the width of the new options
exceeds {screen_width - original_menu_origin.x}. This makes wide menu
options unusable in some cases because the menu does not widen to
accommodate the new items.
Regression started: r573978
Test case:
1. Show a website with link[1] on the far right side of the screen:
https://www.google.com/chromebook/
2. Right click to show a menu on one of the links in the toolbar.
The menu should be wide enough to show all contents of the menu.
[1]Step 1 must have a link as the source of the menu because
links use arc::OpenWithMenu, which can add wider ("Open with ...")
options to a context menu. These options are added after the menu
is drawn because we show the menu before arc calls back with the new
menu options.
[email protected]
(cherry picked from commit be913dcb4d9dc61efbc9ff9c8bb9ef14b75ed61b)
Test: MenuControllerTest.GrowingMenuMovesLaterallyNotVertically
Bug: 882662
Change-Id: Ic848fdb545bbdd05f874041bf1044adb7bd1d094
Reviewed-on: https://chromium-review.googlesource.com/c/1262397
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600563}
Reviewed-on: https://chromium-review.googlesource.com/c/1292658
Cr-Commit-Position: refs/branch-heads/3578@{#192}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix animation issue when activating second app window from shelf
Changes:
When an active window exists, clicking on shelf item to activate another
window should not run slide down animation.
Bug: 896908
Change-Id: Ifd037b139da44bac3d05c3c88dd5c7f044f7d898
Reviewed-on: https://chromium-review.googlesource.com/c/1292050
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601287}(cherry picked from commit 5decbd7f8c532a356c617a518f6737d506161f02)
Reviewed-on: https://chromium-review.googlesource.com/c/1293177
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#191}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix freezing app list after duplicate swipe from bezel
Background:
Two times of continuous swipe up from bezel breaks scroll event in app
list because second scroll begin event will be consumed by shelf layout
manager, which makes subsequent scroll events go into shelf layout
manager instead of app list.
Changes:
Avoid consuming the scroll event when launcher is visible.
Bug: 896934
Change-Id: I46c9ad8f43a15160b890e5a6d4485dbb3e6bed3d
Reviewed-on: https://chromium-review.googlesource.com/c/1291788
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601237}(cherry picked from commit 129b9edb08a25a3ca990ce5d9ac5d7e1bec99bf1)
Reviewed-on: https://chromium-review.googlesource.com/c/1293176
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#190}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Disable blur for suggestion chip and folder icon in clamshell mode"
This is a reland of ae60a1346789c0fa6dfb6ed8f93c814a16dd2c2a
Original change's description:
> Disable blur for suggestion chip and folder icon in clamshell mode
>
> Changes:
> 1. Destroy layer for suggestion chip in clamshell mode.
> 2. Set blur to 0 for folder icon in clammshell mode.
> 3. Avoid recreation of suggestion chip views after update.
>
> Bug: 896525
> Change-Id: I4cb84c06f5e0ed5a0cc70c0c2338028573bd7017
> Reviewed-on: https://chromium-review.googlesource.com/c/1287709
> Reviewed-by: Xiyuan Xia <[email protected]>
> Commit-Queue: Weidong Guo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#600819}
[email protected]
Bug: 896525
Change-Id: Idd17312d89e759f65a7f4fb5db125f89b96bd9af
Reviewed-on: https://chromium-review.googlesource.com/c/1290133
Commit-Queue: Weidong Guo <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601213}(cherry picked from commit 1a8346a53e0fddbd788c40e849fd2feb731a98bc)
Reviewed-on: https://chromium-review.googlesource.com/c/1293175
Cr-Commit-Position: refs/branch-heads/3578@{#189}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}make touch adjustment bound in dip
Previous CL crrev.com/c/1279204 changed the touch adjustment bound to
CSS pixel; however, kMaxAdjustmentSize is a bound on the finger size
in case noisy drivers or errant touches causing degenerate hit-tests
that hit too many elements. The bound should be in dip so it's
corresponding to a physical size.
Therefore, kMaxAdjustmentSize should be in unscaled dip, and we need to
convert it to scaled physical pixel to compare with touch_area, which is
in root frame coordinates (scaled physical pixel).
Bug: 894961
Change-Id: Ib515e55fd027ba7c17db7488d872be82b91f954a
Reviewed-on: https://chromium-review.googlesource.com/c/1287201
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601192}(cherry picked from commit 1db3dc04678b2815a8e86612961385ac3814ad0a)
Reviewed-on: https://chromium-review.googlesource.com/c/1293040
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#188}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Added back the download settings IPH
Bug: 896480
Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a
Reviewed-on: https://chromium-review.googlesource.com/c/1286826
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601375}(cherry picked from commit afd0fb4b16a6d425403ce11bbbeb78e4fb2ef83a)
Reviewed-on: https://chromium-review.googlesource.com/c/1293039
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#187}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.17
[email protected]
Change-Id: I5a280260153ab49288f217c8c46f119bd585b621
Reviewed-on: https://chromium-review.googlesource.com/c/1292380
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#186}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M-71][Payment Request] Show status bar.
Before this patch, Android Oreo and newer blacked-out the status bar, so
the time and battery icon, for example, were not visible during
payment.
This patch sets the payment dialogs status bar icon color to be either
white or black, depending on the status bar background color. These
changes apply to Android Oreo and newer only.
After this patch, the status bar icons are always visible during
payment.
Bug: 890183
Change-Id: Ia478ec9461b05bd4cb2993fd11b301a9ec0f4704
Reviewed-on: https://chromium-review.googlesource.com/c/1286744
Commit-Queue: Rouslan Solomakhin <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600950}(cherry picked from commit ec03f7206545d70cbf95f629ab16529694d722ee)
Reviewed-on: https://chromium-review.googlesource.com/c/1292445
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#185}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Feed] Add UMA for content and journal storage
Bug:896541
Change-Id: Ic1055a756eea05d5399d93e805ca9389b89805cc
Reviewed-on: https://chromium-review.googlesource.com/c/1287952
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601009}(cherry picked from commit fef091fe0acafc20619453a4d3381bca16b30d4a)
Reviewed-on: https://chromium-review.googlesource.com/c/1292962
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#184}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Quick fix for crash during phone parsing.
This CL fixes out of range access, when by some reasons during the
phone parsing, libphonenumber returns that national code is longer that
the parsed string. Probably the reasons are some incorrect treating of
non-ASCII characters.
[email protected]
Bug: 895578
Change-Id: I2f0a7622453191778907a8f54e74e35a1484765b
Reviewed-on: https://chromium-review.googlesource.com/c/1286136
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600366}(cherry picked from commit fd86da2f030895099c2f5b59b1f64a71eacc327c)
Reviewed-on: https://chromium-review.googlesource.com/c/1292871
Cr-Commit-Position: refs/branch-heads/3578@{#183}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Implement automatic reading of Assistant card responses.
https://docs.google.com/document/d/1dzjfTfiTf_wVq_cwH85i2VQWDjKWt3ZsiqokZg21jjw/edit?usp=sharing
Bug: b/117274233
Change-Id: I9ac16364a62cb8f55925dc8d5d04fdc5ce425ae9
Reviewed-on: https://chromium-review.googlesource.com/c/1277844
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Leo Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600128}(cherry picked from commit 7ae9eb4e3df28f5ebb83284285fb0d7dd8c6828d)
Reviewed-on: https://chromium-review.googlesource.com/c/1292821
Cr-Commit-Position: refs/branch-heads/3578@{#182}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to M71: Change home launcher gesture slide down/up animation
Changes:
1. Duration from 600ms to 350ms.
2. Tween type from linear to fast_out_slow_in
Bug: 884386
Change-Id: Id095124d2259ca211df004d6365b96aabfa57601
Reviewed-on: https://chromium-review.googlesource.com/c/1290143
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601007}(cherry picked from commit 0a50d4f55f4db0d2de5d1310dc8dfaed14386828)
Reviewed-on: https://chromium-review.googlesource.com/c/1292889
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#181}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.16
[email protected]
Change-Id: I1d4bb2bd701083e3757212d5e6f18e5631f3cae5
Reviewed-on: https://chromium-review.googlesource.com/c/1292373
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#180}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id26e07b64275a1de8e0e544cd13e84cbd48f7ed9
Reviewed-on: https://chromium-review.googlesource.com/c/1292832
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#179}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[merge to 71] applist: Fix flinging mechanics on shelf and applist.
Previously the fling in the wrong direction would do the same as a fling
in the right direction. (ex. flinging down when dragging up from the
shelf would show the home launcher as well)
[email protected]
(cherry picked from commit fda66958076676797695f7139241b3f669d8a72c)
Test: ash_unittests HomeLauncherModeGestureHandlerTest.Fling*
Bug: 896510
Change-Id: I0a366eaab679e5e041947a07e80bd82ab495a8af
Reviewed-on: https://chromium-review.googlesource.com/c/1289073
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600860}
Reviewed-on: https://chromium-review.googlesource.com/c/1292817
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#178}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[MutlideviceSettings] Gate multidevice settings for guest profiles
This CL fixes issue with settings page crashing in guest profiles.
Bug: 896870
Change-Id: I39f4df84843e723b25300fefb8936c7839c3bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/1289952
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Azeem Arshad <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601308}(cherry picked from commit 68c4c258148ed1da7dd45128b172aad7aad39a83)
Reviewed-on: https://chromium-review.googlesource.com/c/1292440
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#177}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] [NTP] Separate internal custom link updates from user changes
Merge: Resolved some conflicts in most_visited_sites.* due to
https://chromium-review.googlesource.com/c/chromium/src/+/1272137
that being in M71.
When a default URL scheme is updated after URL validation, it is counted
as a user action. This causes "Undo" to revert the URL scheme update
instead of the user's add/update action.
Add an additional parameter to CustomLinksManager::UpdateLink in order
to distinguish between internal and user changes. Internal changes will
not update the previous state that is restored when
CustomLinksManager::UndoAction is called.
(cherry picked from commit adf056599a25e3d59d1272de431aae24b549f927)
Bug: 896143
Change-Id: I643679fab5e546fac7e41214af6ff8a4ba9c8b53
Reviewed-on: https://chromium-review.googlesource.com/c/1287259
Commit-Queue: Kristi Park <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600988}
Reviewed-on: https://chromium-review.googlesource.com/c/1292395
Reviewed-by: Kristi Park <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#176}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71][Extensions] Remove the webstore API feature
The chrome.webstore API is used (exclusively) for inline install, which
is deprecated and to be removed in M71. [1] Remove the webstore entry
from the extensions features files; this will result in chrome.webstore
being undefined for all JS contexts.
[1] https://blog.chromium.org/2018/06/improving-extension-transparency-for.html
Bug: 895868
[email protected]
(cherry picked from commit 0d2282fa4c56aa7cef16b58c1fac6777874fbdc8)
Change-Id: Idce382e5dd967a22ba779204d63e1ec509493ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1283485
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600906}
Reviewed-on: https://chromium-review.googlesource.com/c/1292394
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#175}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Resource Scheduler: Add UMA to record request queuing time
Resource Scheduler: Add UMA to record request queuing time broken
down by request loading priority
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I120b9f0b549c76d1f36920c051014afe71462db2
Bug: 895486
Reviewed-on: https://chromium-review.googlesource.com/c/1280145
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600493}(cherry picked from commit 7e9d89741c43a0e36b4df64f250035c71943395b)
Reviewed-on: https://chromium-review.googlesource.com/c/1292718
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#174}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add default port for the gopher: scheme.
KURL parsing uses known_ports.cc for supporting known ports for standard
schemes. GURL uses its own version, which leads to mismatch in behavior.
This CL adds gopher's default port to known_ports.cc, however a follow
up patch should just remove gopher support in general.
Bug: 894426
Change-Id: I9cde04bef34be39337cdb9f2a584de576d0b15ea
Reviewed-on: https://chromium-review.googlesource.com/c/1279408
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Nasko Oskov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599812}(cherry picked from commit 116094fb693556d5a8aff336aa6d635490546fcf)
Reviewed-on: https://chromium-review.googlesource.com/c/1292715
Reviewed-by: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#173}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge Approved M71: Simplifies Tap/Long-Press handling in AppsGridView
These events were being sent up to AppListView, then back to
AppsGridView. In reality, these events can all be handled before
letting them pass through, just based on the nearest tile.
Bug: 893216
Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8
Reviewed-on: https://chromium-review.googlesource.com/c/1286129
Commit-Queue: Kevin Strohbehn <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600611}(cherry picked from commit 62162751f2e30bac3c591068326e6a2df5c69ebe)
Reviewed-on: https://chromium-review.googlesource.com/c/1292594
Cr-Commit-Position: refs/branch-heads/3578@{#172}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix bottom margin for NTP and FeedNTP on older Android versions
On pre-N versions, the layout parameters can be ignored if we don't
declare a root the inflated view. Updating the layout parameters only
after view is attached to window.
[email protected]
Bug: 895229
Change-Id: I671b83bbf6e72b9cbabb84e80636d68ba45c5dad
Reviewed-on: https://chromium-review.googlesource.com/c/1282105
Commit-Queue: Becky Zhou <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600137}(cherry picked from commit 7cc75426ff63222465a9b318d6ec5097568c970b)
Reviewed-on: https://chromium-review.googlesource.com/c/1292569
Reviewed-by: Becky Zhou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#171}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Don't search for spellchecker markers at spellcheck-disabled positions
SelectionController's HitTestResultIsMisspelled() unconditionally
searches for spellcheck markers under the hit test position, which can
be saved if spellchecking is already disabled there.
This is also a workaround attempt for the crashes in crbug.com/886589,
since the patch reduces the possibility to reach the crash site.
Bug: 886589
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iee1ac5c1e44ea3a3452663cae078d6b7125fed38
Reviewed-on: https://chromium-review.googlesource.com/c/1284349
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600285}(cherry picked from commit f8dffbdd48ee6ca3fdc950550c371664f44a5624)
Reviewed-on: https://chromium-review.googlesource.com/c/1292524
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#170}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download home : Fixed paused/pending state
This CL fixes
1 - Paused downloads showing up as failed after browser restart
2 - Pending for network downloads showing up as failed
Bug: 894159
Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49
Reviewed-on: https://chromium-review.googlesource.com/c/1284889
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600630}(cherry picked from commit 7f79b8adc667c1af926293cab8d4550b9a810292)
Reviewed-on: https://chromium-review.googlesource.com/c/1292520
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#169}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Add ftruncate64 to audio sandbox policy.
Audio sandbox policy currently allows ftruncate syscall; adding ftruncate64
used on x86 systems.
This fix solves browser_tests failures on 32 bit Linux bots. With ftruncate64
blocked, IPC between audio process and renderer was failing leading to audio
render errors.
Bug: 890850
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6b09429c018468e0eb037498514df048fe79d520
Reviewed-on: https://chromium-review.googlesource.com/c/1282407
Commit-Queue: Marina Ciocea <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600555}(cherry picked from commit 7dc9dfa0d23947d676cdaed77b0df1a937ec77c2)
Reviewed-on: https://chromium-review.googlesource.com/c/1292470
Reviewed-by: Marina Ciocea <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#168}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Don't dismiss Assistant when using virtual keyboard.
Assistant UI is hidden when tapping outside of the widget. We should
also check if the user is interacting with the virtual keyboard to avoid
closing Assistant UI while the user is typing.
Bug: b:117833352
Change-Id: I95437c4bd495321cf41c8add6d4ab283b771a442
Reviewed-on: https://chromium-review.googlesource.com/c/1287262
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600947}(cherry picked from commit 48e70bb9b3a30302938be9422343785c86b8889b)
Reviewed-on: https://chromium-review.googlesource.com/c/1291770
Cr-Commit-Position: refs/branch-heads/3578@{#167}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix merge time window limit method
Bug: 896064
Change-Id: I85c969a456b81f71fa067901161fa7dae6adc08c
Reviewed-on: https://chromium-review.googlesource.com/c/1285609
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Henrique Grandinetti <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600233}(cherry picked from commit 523efee95e3d68b8719b3a1c83051aa63aa6b10d)
Reviewed-on: https://chromium-review.googlesource.com/c/1291249
Cr-Commit-Position: refs/branch-heads/3578@{#166}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top.
Bug: 896044
Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1285119
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600198}(cherry picked from commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688)
Reviewed-on: https://chromium-review.googlesource.com/c/1292449
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#165}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Make subframe widgets implicitly capture mouse events on MouseDown
Frame-level capture of mouse events implicitly happens when a MouseDown
is targeted to an element in a subframe. Currently this does not work
across frames in different processes because the browser process does
not receive a notification about capture being active.
This patch adds that notification in order to initiate widget-level
capture in that case.
Bug: 888342, 647378
Change-Id: I26f55b2690e9ecfbd0243a9a610541abdff3b575
Reviewed-on: https://chromium-review.googlesource.com/c/1271588
Commit-Queue: Ken Buchanan <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599408}(cherry picked from commit 3561c3c6f73f447b803ef49b8c2f86c181e7edb7)
Reviewed-on: https://chromium-review.googlesource.com/c/1292272
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#164}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Update fingerprint failed animation to be less blurry.
[email protected]
(cherry picked from commit e84c59ddf06bb12d1927fd85f83d6b90cf71a6a7)
Bug: 895995
Change-Id: Ibf2bc2ced1f502004b0ceac3830a2773ddac7ab9
Reviewed-on: https://chromium-review.googlesource.com/c/1284397
Reviewed-by: Quan Nguyen <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600140}
Reviewed-on: https://chromium-review.googlesource.com/c/1291838
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#163}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}desktop-pwas: Ignore same-document navigations when retrieving icons
Some pages could perform same-document navigations e.g. push/popState
while we download icon. Since these navigations are still in the same
document it should be safe to ignore them and continue with the
installation.
Changes WebAppIconDownloader to ignore same-document navigations and
continue downloading the icons.
Bug: 889660
Change-Id: I120ba6f38a5aa0a803fa82615cd8bd73412bbb67
Reviewed-on: https://chromium-review.googlesource.com/c/1287330
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Reviewed-by: calamity <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600652}(cherry picked from commit a8226af635e2356a6b6048848e5f308e094c5f34)
Reviewed-on: https://chromium-review.googlesource.com/c/1292000
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#162}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix histogram ExploreSites.ClickedNTPCategoryIndex bucket count.
[email protected]
(cherry picked from commit 20db1c792df7838120597da8d046806bb81cbf63)
Bug: 896481
Change-Id: I6e7d05e5673971d2b132e75dcaf1dfe7a858357a
Reviewed-on: https://chromium-review.googlesource.com/c/1287290
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Dmitry Titov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600588}
Reviewed-on: https://chromium-review.googlesource.com/c/1291989
Reviewed-by: Dmitry Titov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#161}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Bug fixes for Previews Omnibox UI
There's a few bug fixes in this CL but it seems ok to lump them
together since each bug is in a separate file.
CustomTabActivity.java - don't show AMP UI on a Preview
ToolbarManager.java - also update Previews UI on commit
ToolbarModel.java - explicity remove the scheme from Previews
Bug: 896478
Change-Id: Id8353a8787481bf4fcbfa322994d8b0ec998d6df
Reviewed-on: https://chromium-review.googlesource.com/c/1287289
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600779}(cherry picked from commit 0331f4532275dea229a4897041267ae2bffbcc2b)
Reviewed-on: https://chromium-review.googlesource.com/c/1291773
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#160}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Add a CHECK to non-DICE signin that it's only used for force-signin"
This reverts commit 44256192f2b9b62dc2cb5cc7a51804fe63637d35.
Reason for revert: still need to handle the case where an existing profile is locked
BUG=896136
Original change's description:
> Add a CHECK to non-DICE signin that it's only used for force-signin
>
> All other use cases are meanwhile migrated or disabled
>
> R=[email protected]
>
> Change-Id: Ieff03c3a46a9ef8fec5c9de8a1aa041a97d9afbf
> Reviewed-on: https://chromium-review.googlesource.com/1148211
> Reviewed-by: Mihai Sardarescu <[email protected]>
> Commit-Queue: Jochen Eisinger <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#577827}
[email protected], [email protected]
(cherry picked from commit a563e29ee53b9b2f5e8a35da7c52f96310636a02)
Change-Id: I3b7c538682784f57f5142c43ff4bd6c78c14685b
Reviewed-on: https://chromium-review.googlesource.com/c/1286278
Commit-Queue: Jochen Eisinger <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600501}
Reviewed-on: https://chromium-review.googlesource.com/c/1291550
Cr-Commit-Position: refs/branch-heads/3578@{#159}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix crash OverrideUIString() is called before resource bundle is initialized.
The crash is caused by the callback UIStringOverrider::OverrideUIString() in
ApplyUIStringOverrides() is called before resource bundle is initialized. In
this CL, we checks whether the resource bundle has been initialized or not. If
not, we cache the UI strings to be override in a map owned by the
VariationsFieldTrialCreator, and override these UI strings once the full browser
starts.
Bug: 893707
Change-Id: Ia23bc46a5e13a20ab784ff48d565ce1438a6aa0b
Reviewed-on: https://chromium-review.googlesource.com/c/1274001
Commit-Queue: Xi Han <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600564}(cherry picked from commit a05ca5eacd980157446dae74edf55ec506f6fa5f)
Reviewed-on: https://chromium-review.googlesource.com/c/1291356
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#158}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Tweak vertical padding for MD incognito NTP
Always use 32dp padding in the one column layout. It looks odd on some
devices when 72dp padding is used.
BUG=896204
Change-Id: I6deddf3b35609b45fd29ba2c79293cfea2594708
Reviewed-on: https://chromium-review.googlesource.com/c/1286877
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600442}(cherry picked from commit 1ba097be0993d31205e98958a0e3523872bd57ab)
Reviewed-on: https://chromium-review.googlesource.com/c/1291351
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#157}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[signin] Allow dasher accounts to abort signin
Dasher accounts generally are not allowed to signout, because they may
have synced data that belongs to their administrator, and this data must
not leave their account.
The intended way to remove a dasher account from Chrome is to delete the
associated profile.
Due to this restriction, aborting signin was not possible for a dasher
account, even though the UI was shown. This results in a bad user
experience where the user clicks on the "cancel" button, but signin is
actually not cancelled.
The fix implemented here is to allow the user to signout without deleting
the profile. This is acceptable because the data has not been synced yet.
[email protected]
(cherry picked from commit d14095e5e734d2e01b434eeb45e79f9e0d9451bc)
Bug: 864761, 804360
Change-Id: Iffbcde87ee242ada2815cd13d0bf8c660726d900
Reviewed-on: https://chromium-review.googlesource.com/c/1278734
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599610}
Reviewed-on: https://chromium-review.googlesource.com/c/1291391
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#156}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Android] Suppress tap sound on empty keyboard accessory bar
This fixes on of the funniest bugs so far: when tapping the empty bar of
the keyboar accessory, a tap sound would be emitted. Tapping multiple
times or sliding would be interpreted as multiple quick taps and emit a
weird buzzing noise.
By suppressing the sound effect, the element is still tappable for
accessibility purposes but the sound isn't audible anymore. This only
affects the empty space in the bar - the key icon or other buttons are
still emitting the tap sound to confirm a successful interaction.
Bug: 895767
Change-Id: I4477417edc99324420f88b7a688afe21eee1e9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1288534
Reviewed-by: Ioana Pandele <[email protected]>
Commit-Queue: Friedrich Horschig [CEST] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600723}(cherry picked from commit d5f79a75aec45e299eeab35bdea54477ee924513)
Reviewed-on: https://chromium-review.googlesource.com/c/1290912
Reviewed-by: Friedrich Horschig [CEST] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#155}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix coordinate conversions in TouchExplorationController
- Touch event comes with coordinate where its origin is its root window
host.
Hardware. Confirm that ChromeVox works well on it, e.g. you can
activate an element on the screen, etc.
Bug: 887222
Test: Enable spoken feedback on touch controller of Hangout Meet
Change-Id: I6bd6b50f13405c493659ad91f24d35974d5c72ce
Reviewed-on: https://chromium-review.googlesource.com/c/1282688
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600612}(cherry picked from commit 25073f6cc9aa1a025b594d81b69be6e0ed2aa312)
Reviewed-on: https://chromium-review.googlesource.com/c/1290232
Reviewed-by: Yuki Awano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#154}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Show AudioService information on chrome://media-internals.
* Adds capability of showing general audio information on chrome://media-internals in a key-value format.
* Shows states of AudioService features (enabled/disabled).
* Fixes JS presubmit errors: Use $(id) instead of getElementById(id), and use camelCase for variables.
[email protected]
(cherry picked from commit e7e5291585f6e626df6cab7bfe5981ad088fe027)
Bug: 895741
Change-Id: I35db3a3ab175586aa7e493ca1acccb1ac7ffa824
Reviewed-on: https://chromium-review.googlesource.com/c/1283020
Reviewed-by: Olga Sharonova <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Henrik Grunell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600682}
Reviewed-on: https://chromium-review.googlesource.com/c/1290273
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#153}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Experiment to use on device safe browsing for data saver users
Currently, there is a protocol between data saver server and
Chrome for checking malicious URLs. This CL adds an experiment
to deprecate that protocol and let Chrome use on-device safe
browsing checks for data saver users. Note that the CL
only affects HTTP URLs. HTTPS URLs were always checked using
on-device lists.
Bug: 891464
Change-Id: I7286ee8624203fcaa175dad2aa06ff0e7a8806f0
Reviewed-on: https://chromium-review.googlesource.com/c/1283939
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600235}(cherry picked from commit c073209954ab8bd9893bbeeaa0ff9c526ed2d560)
Reviewed-on: https://chromium-review.googlesource.com/c/1290773
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#152}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[FileSystem] Remove operation ptr after write is complete
This behavior was accidentally lost when onion souping and caused a
memory leak.
[email protected]
(cherry picked from commit f59319ec24cd5040e017540148387e4258f75545)
Bug: 891018, 787281
Change-Id: Ib41155660b72548582f809e75c7ca3c596234b65
Reviewed-on: https://chromium-review.googlesource.com/c/1284391
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Adithya Srinivasan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600377}
Reviewed-on: https://chromium-review.googlesource.com/c/1290770
Cr-Commit-Position: refs/branch-heads/3578@{#151}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Adjust bubble dialog bounds if splitscreen is active.
When a dialog is added to a window that's currently showig in
splitscreen, we should adjust the dialog bounds to show the dialog
aligned within its own side of the split, rather than across the divider
bar.
Note the divider is still placed on top of the snapped windows and its
transient children if they are placed in default container.
Bug: 878268
[email protected]
(cherry picked from commit 205c143746dbf1d37c1eb3c8371b512bfbfe9303)
Reviewed-on: https://chromium-review.googlesource.com/c/1274197
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#598827}
Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332
Reviewed-on: https://chromium-review.googlesource.com/c/1280674
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599693}
Reviewed-on: https://chromium-review.googlesource.com/c/1290270
Cr-Commit-Position: refs/branch-heads/3578@{#150}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Disable the home launcher animation when tab-dragging starts/ends.
Also disable other windows hide/show animation when tab-dragging process
starts/ends.
Bug: 888173
[email protected]
Change-Id: Iee22d20832cefd61ad7ebdea30b5a65e75b9f204
Reviewed-on: https://chromium-review.googlesource.com/c/1282162
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600552}(cherry picked from commit c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2)
Reviewed-on: https://chromium-review.googlesource.com/c/1290517
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#149}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Fix the crash when fling a tab out of a window.
Bug: 895649
[email protected]
Change-Id: I4f4f94639ef7d4a68b37163451afc5eb1dcc77ec
Reviewed-on: https://chromium-review.googlesource.com/c/1285086
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600554}(cherry picked from commit 93f94cdf73f0e0c901a987b1a6b89db844d11aaa)
Reviewed-on: https://chromium-review.googlesource.com/c/1290516
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#148}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Fix MessageListView crash on update during close."
This is a reland of 987d8bc9ecb65c60f8ebec3527546e9a9d35d2ca
Original change's description:
> Fix MessageListView crash on update during close.
>
> MessageListView crashes when a notification is updated during the
> UnifiedSystemTray is closing. Like other views::Widget methods,
> SynthesizeMouseMoveEvent() should not be called during the widget is
> closing.
>
> See the bug for the asan trace.
>
> TEST=manual
> BUG=894070
>
> Change-Id: I9ffba0f73260542ebf21b2aef572af1f68e5c40b
> Reviewed-on: https://chromium-review.googlesource.com/c/1276225
> Commit-Queue: James Cook <[email protected]>
> Reviewed-by: James Cook <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#598768}
[email protected]
Bug: 894070
Change-Id: I8d7517dc27fc98b4a5a2d7ee3e7fc5afd4a932eb
Reviewed-on: https://chromium-review.googlesource.com/c/1282046
Commit-Queue: Tetsui Ohkubo <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600247}(cherry picked from commit f8fa0e8b6c41d27c42bec146c5d0f60bce4f890b)
Reviewed-on: https://chromium-review.googlesource.com/c/1290575
Cr-Commit-Position: refs/branch-heads/3578@{#147}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove "OS update successful." notification.
We have been showing the notification after successful ext4
migration. This notification is getting less useful since most
users have already migrated to ext4, and we hear several feedback
reports that the notification was shown at unexpected timing.
Let's remove the notification as a simple fix and a clean-up.
(Removing the notification was approved by PM.)
Bug: 894707
Test: Manually confirmed that the notification was not shown after migration on Kevin.
Change-Id: Ide3237a57a127974eed6f1619fc5e096f911f72a
Reviewed-on: https://chromium-review.googlesource.com/c/1278666
Commit-Queue: Naoki Fukino <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599568}(cherry picked from commit b671af6d8b890524426dbed9609f694c8a6f16c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1290050
Reviewed-by: Naoki Fukino <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#146}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Disable Welcome app by default
This disables Welcome App on selected devices.
[email protected]
(cherry picked from commit 41183d85d5310492ca1dc4e672d2b2f5a6215e66)
Bug: 894095
Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170
Reviewed-on: https://chromium-review.googlesource.com/c/1287184
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600616}
Reviewed-on: https://chromium-review.googlesource.com/c/1290204
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#145}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: Disable Discover app by default
This disables Discover App.
[email protected]
(cherry picked from commit 1b0ab6e535bdf0c2e0a7198ef717a0020757bd33)
Bug: 894095
Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd
Reviewed-on: https://chromium-review.googlesource.com/c/1286462
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600473}
Reviewed-on: https://chromium-review.googlesource.com/c/1290203
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#144}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge to M71: Blends Shelf into Launcher to help fix FPS on low-end devices
[email protected]
Bug: 883032
Change-Id: Ib65bc5fb61f0526d9ccc688769f1f68284f3bfeb
Reviewed-on: https://chromium-review.googlesource.com/c/1269860
Commit-Queue: Kevin Strohbehn <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600151}(cherry picked from commit 6b5ed95e9cd9a4eb475c87c9e729a569d274d8a8)
Reviewed-on: https://chromium-review.googlesource.com/c/1290146
Cr-Commit-Position: refs/branch-heads/3578@{#143}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Use ARGB8888 for a dummy buffer for protected content playbkack on ARC++"
This reverts commit eb0d6e13f58c24e88d9c40121981fb861303c45c.
Reason for revert: This CL causes a crash on AMD device, b/117398307
Original change's description:
> Use ARGB8888 for a dummy buffer for protected content playbkack on ARC++
>
> We have specified R8 format for a dummy buffer for protected content playback
> on ARC++.
> R8 format is not supported on exynos device. It leads crash on the devices.
> ARGB8888 should be used instead, which is widely supported on all Chrome OS
> device.
>
> BUG=chromium:787660, chromium:887658
> TEST=No crash on peach_pit and Protected content playback on veyron_minnie and eve
>
> Change-Id: Ia550277ad30a0e0fd814106a1610b59a1a86bb03
> Reviewed-on: https://chromium-review.googlesource.com/1242564
> Commit-Queue: Hirokazu Honda <[email protected]>
> Reviewed-by: Pawel Osciak <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#593842}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:787660, chromium:887658
Change-Id: I7cc4e8607b0dd267f73a2f32879abae74f9fa24e
Reviewed-on: https://chromium-review.googlesource.com/c/1282505
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599824}(cherry picked from commit e67d13c840a98ac22ff70bf45835847b130f0ac5)
Reviewed-on: https://chromium-review.googlesource.com/c/1290429
Cr-Commit-Position: refs/branch-heads/3578@{#142}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.15
[email protected]
Change-Id: Icaf754691124a3671c9593ca7168c193983ebe68
Reviewed-on: https://chromium-review.googlesource.com/c/1290330
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#141}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Ensure the intent picker is not created when Chrome is the only app candidate.
The IntentPickerBubbleView is provided with a list of app candidates to
display to the user for them to choose to open a link. If Chrome can
handle a link, it is included in the list of candidates, but it is
erased in IntentPickerBubbleView::Init(); users use an independent
button in the UI to open the link in Chrome.
This led to a browser crash bug in the ArcExternalProtocolHandler,
where it was possible for Chrome to be the only candidate available,
e.g. in the case of a geo:// URI scheme link. On clicking a geo:// link
on a Chrome OS devices with Play enabled and no Android apps available
to handle the geo:// URI scheme, the intent picker would try and
select the 0th index app candidate during its initialization, but this
would be null since the only candidate (Chrome) was erased.
This CL fixes the bug by not creating the intent picker at all if the
only app candidate is Chrome. The external protocol dialog can only be
triggered if Chrome originally decided it couldn't handle the URL, so in
this case we simply fall back to the Chrome OS standard dialog (which
says that Chrome OS can't handle the URL).
BUG=893042
Change-Id: I171d547e51a4dfb37d51c3e71a88a8c84539a8fa
Reviewed-on: https://chromium-review.googlesource.com/c/1280090
Commit-Queue: Dominick Ng <[email protected]>
Reviewed-by: David Jacobo <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599773}(cherry picked from commit 3929b82ef77743c8f0e5d775b2b04eb5f3de95f0)
Reviewed-on: https://chromium-review.googlesource.com/c/1290249
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#140}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I55ac7e518cb6831475eb638b24a683be691ac9a4
Reviewed-on: https://chromium-review.googlesource.com/c/1290135
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#139}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix on-screen keyboard issue when search box is focused
Background:
In some devices like nocturne, on-screen keyboard pops up when launcher
is focused. When launcher is focused, search box textfield will be the
initial focused view. SearchBoxViewBase::ContentsChanged() gets called
to activate the search box, which triggers the on-screen keyboard.
Change:
Avoid activate the search box when new contents are empty string.
Bug: 895249
Change-Id: I32b0f5a76037b5287d1b179fa20140101ce4f853
Reviewed-on: https://chromium-review.googlesource.com/c/1284754
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600577}(cherry picked from commit 65827fc5fd5431bba046c01fd7102d563bb65d71)
Reviewed-on: https://chromium-review.googlesource.com/c/1290189
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#138}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] Hide the keyboard when interacting with the shelf.
When using the floating keyboard, it tends to be placed near the bottom
of the screen. This blocks the shelf and is annoying when you need to
interact with it (e.g. tapping on the status area to bring up quick
settings).
We'll hide the virtual keyboard when tapping/clicking anywhere on the
shelf. Since "hide virtual keyboard when user does something" seems to
be a common pattern, we add a new method in KeyboardController called
HideKeyboardImplicitlyByUser to represent such situations. It's
different to the other ways of hiding the keyboard in two ways:
1) It doesn't hide the a11y (locked) keyboard.
2) It doesn't activate the "transient blur" feature. So when something
focuses right after the keyboard hides, it doesn't pop up again.
It also nicely mirrors HideKeyboard(Explicitly)ByUser, which we will
rename in a follow up patch.
Bug: 893859
Change-Id: I9ba597b3f4b836566da89b7d559808bee80e0dc8
Reviewed-on: https://chromium-review.googlesource.com/c/1282514
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600216}(cherry picked from commit ad3bb52111ddc5896b0343ea891a4817de901298)
Reviewed-on: https://chromium-review.googlesource.com/c/1290049
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#137}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Files app: Select My files when there are no volumes"
This reverts commit 103069350367d5c2cf85897e99e899b77a82f6b8.
Reason for revert: Undoing speculative revert
The CL was not the culprit
Original change's description:
> Revert "Files app: Select My files when there are no volumes"
>
> This reverts commit 6f65bd26330cf709e4a4c4eb60876de5849f94d5.
>
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
>
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
>
> Bug: 896219
>
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161, 884967, 894799
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <[email protected]>
> > Reviewed-by: Sam McNally <[email protected]>
> > Commit-Queue: Luciano Pacheco <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#600282}
>
> [email protected],[email protected],[email protected]
>
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161, 884967, 894799
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <[email protected]>
> Reviewed-by: Christos Froussios <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#600376}
[email protected],[email protected],[email protected],[email protected]
Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896219, 893161, 884967, 894799
Reviewed-on: https://chromium-review.googlesource.com/c/1286853
Reviewed-by: Christos Froussios <[email protected]>
Commit-Queue: Christos Froussios <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600429}
Reviewed-on: https://chromium-review.googlesource.com/c/1287350
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#136}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Make old time limit locks not be applied to the Chromebook
Bug: 895911
Change-Id: Icc76882b0b90e02800ef86a50bf73227db0c56b3
Reviewed-on: https://chromium-review.googlesource.com/c/1283829
Commit-Queue: Henrique Grandinetti <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Aga Wronska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600206}(cherry picked from commit 851744a387cdfe5583de935baaaf2c36e1f8c726)
Reviewed-on: https://chromium-review.googlesource.com/c/1289589
Cr-Commit-Position: refs/branch-heads/3578@{#135}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Make touch adjustment range upperbound respect zoom_factor
We used to have the touch adjustment range as 32dip in diameter (16dip
in radius) for Android. After the zoom-for-dsf change, the pointerevent
width & height became in physical pixel. It makes the actually range in
dip much smaller on Android.
This CL changes the adjustment range to be 32 CSS pixel, and apply the
zoom_factor before compare with the pointerevent width&height.
On Android, there is no ctrl +/- page zoom, so CSS pixel is dip. There
is no change in behavior.
On Desktop (aura), the adjustment upperbound is affected as it wasn't
consider zooming before but now it does. Therefore, the bound will be
affected by zoom_factor.
On aura, there wasn't an upper bound for adjustment range before the
unified touch adjustment change, which means the adjustment range is
always the pointerevent width & height (physical pixel not changed).
When we zoom in, the upper bound is increased, but the adjustment range
will follow the finger size. So I think it's ok to make the bound
changing with zooming as well on aura.
Bug: 894961
Change-Id: I466d6b187359f13c82c62860086cb9eeef8cb2a5
Reviewed-on: https://chromium-review.googlesource.com/c/1279204
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600126}(cherry picked from commit e08cca3a55e90a852284e196cb3b1212252d08f3)
Reviewed-on: https://chromium-review.googlesource.com/c/1289681
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#134}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] cros: Notify CloudExternalDataPolicyObserver when policy doesn't exist
When the policy doesn't exist, an "OnExternalDataCleared" call could
be fired to notify clients, in case they still keep the old data from
a previous policy. It should be a no-op for clients that do not store
policy data.
Bug: 889108
Change-Id: I6061f3be1b650f026ea88f8d353b710fb0b3b16d
Reviewed-on: https://chromium-review.googlesource.com/c/1266695
Reviewed-by: Sean Kau <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600430}(cherry picked from commit 4e7690999538a6f27ddfed2d67c113470db82036)
Reviewed-on: https://chromium-review.googlesource.com/c/1289692
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#133}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}UserSessionManager: Ensure EasyUnlockService is non-null.
[email protected]
(cherry picked from commit 8fc0be764127f0ad6f08206bb04f08a0b602eb36)
Bug: 895937
Change-Id: I7eec1edce0fe9dd2c8e444b51dcd81fe34bcc1ed
Reviewed-on: https://chromium-review.googlesource.com/c/1287433
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600792}
Reviewed-on: https://chromium-review.googlesource.com/c/1289670
Cr-Commit-Position: refs/branch-heads/3578@{#132}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.14
[email protected]
Change-Id: I37555921010a06af6d57a8c4f7637384836ca40e
Reviewed-on: https://chromium-review.googlesource.com/c/1288852
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#131}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Make Instant Tethering work with legacy hosts before hosts update."
This is a reland of 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587
Now correctly waiting for DeviceSyncClient to be ready.
Original change's description:
> Make Instant Tethering work with legacy hosts before hosts update.
>
> The phone side flags and enrollment will be slower than the ChromeOS
> rollout. In order to avoid breaking Instant Tethering in the meantime,
> look for cases where:
>
> 1) There are no host devices reporting BETTER_TOGETHER_HOST support.
> 2) There is at least one host device reporting INSTANT_TETHER_HOST
> support.
>
> In this scenario, the only possiblity is that this host device has not
> reenrolled yet after receiving the new flags.
>
> Bug: 893769
> Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d
> Reviewed-on: https://chromium-review.googlesource.com/c/1277272
> Commit-Queue: Jeremy Klein <[email protected]>
> Reviewed-by: Kyle Horimoto <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#599058}
[email protected]
(cherry picked from commit 30d5a4ef08748d8639b8fe00eb2fef8c00023256)
Bug: 893769
Change-Id: I89aff002fe1235f08aa690ef7f8374aa4100e858
Reviewed-on: https://chromium-review.googlesource.com/c/1278542
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Jeremy Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600074}
Reviewed-on: https://chromium-review.googlesource.com/c/1289301
Cr-Commit-Position: refs/branch-heads/3578@{#130}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download home : Added max width for image and video
This CL adds a max width for image and videos to handle screens that
are too wide such as phone in landscape and tablets.
Bug: 890526
Change-Id: Icd8acbe0177761c2fd684d2ab2421419857e7be9
Reviewed-on: https://chromium-review.googlesource.com/c/1282203
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600478}(cherry picked from commit be45ae1485ef9d379246999db5376dda87a9a1ca)
Reviewed-on: https://chromium-review.googlesource.com/c/1289298
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#129}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[ios] Check for nullptr NavigationItem before updating URL.
Bug: 893154
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8af1dc06fe5fe531235a0545bdca933b9e70e6ce
Reviewed-on: https://chromium-review.googlesource.com/c/1284911
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600535}(cherry picked from commit 5a42dbe4f55f2b7dc246733366d798f8a228e1bb)
Reviewed-on: https://chromium-review.googlesource.com/c/1289094
Reviewed-by: Danyao Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#128}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71]Fix NTP Omnibox suggestions not working with WKHTTPSystemCookieStore
Create a work around to force getAllCookies: completion handler to be executed
as soon as possible.
Workaround description and reasoning on the document:
https://docs.google.com/document/d/1aPNO5p44T-LMQT1Mocdll-SG7xq_9DIjb4N0oOTHZUs
Bug: 894540, 885218
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I94090ed1b6b6aa1dce3f764bfa46bc1d700ddf4d
Reviewed-on: https://chromium-review.googlesource.com/c/1281685
Commit-Queue: Mohammad Refaat <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600078}(cherry picked from commit 2a0b0bdb7bde74c10b3f7fdf15b41dec33c78273)
Reviewed-on: https://chromium-review.googlesource.com/c/1289087
Cr-Commit-Position: refs/branch-heads/3578@{#127}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Surface Synchronization: Use system default deadline for child throttling
If a child surface's activation is throttled then use the system default
deadline as the lower bound for the throttling. This ensures that even if a
child does not have activation dependencies, it will still be throttled
by at least the system default deadline.
This CL also adds some debugging methods and comments on FrameDeadline.
Bug: 672962, 890767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If675908fb2657d5d83b5717339a4060e1eb95f77
Reviewed-on: https://chromium-review.googlesource.com/c/1284050
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600093}(cherry picked from commit 0cfa6cbaddb75c5cf9e739c1a6d70eea27267cf8)
Reviewed-on: https://chromium-review.googlesource.com/c/1289292
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#126}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Surface Synchronization: Child Sync Immediately Activates if Deadline in Past
Prior to this CL, if a child initiates a synchronization event and submits a
CompositorFrame with a deadline in the past then the CompositorFrame will
immediately activate, but the surface will not be marked and so future
CompositorFrames to the same surface will result in blocking until embedding
or deadline again and again.
This could slow down activation and skew deadline duration reporting. This CL
marks a surface such that additional CompositorFrames submitted to the surface
will not block on embedding.
Bug: 672962, 890767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia942e39266ac11dd20cea3f3ae4a087511a98c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1281885
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Saman Sami <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599983}(cherry picked from commit e525f7cabf63e659eebd885cf2e71fc44582f1de)
Reviewed-on: https://chromium-review.googlesource.com/c/1289291
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#125}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Surface synchronization: Don't report blocked duration of throttled children"
This reverts commit d15ba9ba6125299a43b06567b07c3f29484764be.
Reason for revert: This doesn't seem to solve the deadline reporting bug. This was a speculative fix that didn't fix the issue.
Original change's description:
> Surface synchronization: Don't report blocked duration of throttled children
>
> A child can be "throttled" for an arbitrary length of time if it is never
> embedded. This skews blocked duration metrics. Simply don't report those
> metrics if a surface is blocked on a parent.
>
> Bug: 890767
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I3c8a8494a5b1e5a973b2e5c2b61cffe5c2b76f6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1274591
> Commit-Queue: Fady Samuel <[email protected]>
> Reviewed-by: Saman Sami <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#598886}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 890767
Change-Id: I3b1188d49a1301681391d526abaa25dcabf69f79
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1281083
Reviewed-by: Fady Samuel <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599716}(cherry picked from commit cc0e9d5ea923e32bd066ce1ebe87674164768ebf)
Reviewed-on: https://chromium-review.googlesource.com/c/1289289
Cr-Commit-Position: refs/branch-heads/3578@{#124}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Sort eligible devices before returning them.
This CL sorts returned devices from most-recently-updated to
least-recently-updated. This increases the likelihood that users who go
through multi-device setup will set up the correct device, since usually
the most-recently-updated the device is the one that users want to set.
[email protected]
(cherry picked from commit a26626104593ec9d9afe92b5abc1b46d084bdc29)
Bug: 870133
Change-Id: I954f3bde8ccb62c1f796ec62e8f12af65012e528
Reviewed-on: https://chromium-review.googlesource.com/c/1285769
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600426}
Reviewed-on: https://chromium-review.googlesource.com/c/1289088
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#123}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}gpu: Expand oopr workaround to fallback to ES2 to all android.
The change [1] meant to apply this workaround to all Android devices
but missed removing the gl_renderer filter.
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1272451
R=[email protected]
Bug: 860021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I48537a12e14035eff7b8699f5a43c402f490e6cc
Reviewed-on: https://chromium-review.googlesource.com/c/1280552
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599718}(cherry picked from commit dfa5a2b92da3543c5740a0c11725a0e52287cb8c)
Reviewed-on: https://chromium-review.googlesource.com/c/1289080
Reviewed-by: Khushal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#122}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Enforce policy host restrictions in regard to the same-origin policy.
Bug: 774731
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I811af3256766f6cd7b4466b6b894067e74f652fd
Reviewed-on: https://chromium-review.googlesource.com/c/1050806
Commit-Queue: Nick Peterson <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599859}(cherry picked from commit 87ecb1020c7b4dca81261e9d6dec5f07f42541dc)
Reviewed-on: https://chromium-review.googlesource.com/c/1288899
Cr-Commit-Position: refs/branch-heads/3578@{#121}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}fix policy for feed-prefetch
Previously, prefetch articles were showing notification on download, and
showing up in the wrong place in Downloads. I verified the fix locally.
Bug: 895906
Change-Id: I893ec8232f40d1f4a27ee7b89e860c39ca9b3cfe
Reviewed-on: https://chromium-review.googlesource.com/c/1283849
Reviewed-by: Justin DeWitt <[email protected]>
Commit-Queue: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600049}(cherry picked from commit 170cfae650a7a13704181cf9388f6fd5200541f3)
Reviewed-on: https://chromium-review.googlesource.com/c/1288902
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#120}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Initialize compositor in RenderWidget::Init() and pass it to WebWidget
Previously the WebWidgets would each ask RenderWidget to initialize
the compositor at different points in its initialization. WebPagePopup
would do so after the widget was initialized, where as local root frames
would do so before it was initialized (but importantly, after for_oopif_
was set - so really in the middle of initialization). WebView would
do so before any initialization of RenderWidget. This made for 3
different ordering interactions of compositor initialization and
RenderWidget initialization.
Notably, compositor initialization goes through RenderWidget, and
depends on that class. So using it before it's initialized is..
troublesome.
This removes the WebWidgetClient::InitializeLayerTreeView() method,
and has RenderWidget always initialize a compositor (since we always
composite them now, thanks Always Forced Compositing Mode!). That
allows RenderWidget to control the order of its initialization
internally, so it is not used before it is initialized (or, at least
not in this case.. there may be more to untangle).
We add WebWidget::SetLayerTreeView() instead, which goes out to
the WebWidget when the RenderWidget is being initialized, since
the WebWidget is initialized first and passed to RenderWidget.
This helps detangle the SimCompositor and FrameTestHelpers a bit,
we no longer need 2 LayerTreeViews in SimTest - one in SimCompositor
and one in TestWebViewClient. Instead we use the singular one in
TestWebViewClient, and pass through the SimCompositor as the
LayerTreeViewDelegate to it, so that it can implement callbacks
from the compositor. Now the FrameTestHelpers must set the
LayerTreeView on the various WebWidgets that it creates, either
WebViewImpl or WebFrameWidgetImpls.
[email protected], [email protected], [email protected], [email protected]
[email protected]
(cherry picked from commit 17216f4d474e76a18eb2d0aacea4e3a771ccae09)
Bug: 889759
Change-Id: I0e1b3ebf4132874d1151a6a770a02a1a40b650b1
Reviewed-on: https://chromium-review.googlesource.com/c/1271793
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Albert J. Wong <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600165}
Reviewed-on: https://chromium-review.googlesource.com/c/1288896
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#119}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Leave nested settings pages if no host is set
Some edge cases are leading the user to the settings subpage without a
host set. Because the subpage is designed for a set host, we want to
route the user to the main settings page (i.e. the 'Connected Devices'
section of the basic page) when this occurs.
This CL routes the user to the main page when a page content data
update reveals no host while they are on the any page below the main
page.
[email protected]
(cherry picked from commit 5d6c5454385f30e67843a8c7e91eae9f719b1b3b)
Bug: 884401
Change-Id: Icf8aeb1f2c3b2a226f6f597135fa7ed2f96569f9
Reviewed-on: https://chromium-review.googlesource.com/c/1285209
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Jordy Greenblatt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600254}
Reviewed-on: https://chromium-review.googlesource.com/c/1288714
Cr-Commit-Position: refs/branch-heads/3578@{#118}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[jumbo] Merge two identical kFaviconsPerCategoryImage constants
In some jumbo build experiments (not official) there was an
identical constant in two explore_sites files. In jumbo builds
many cc files are merged into one translation unit for much
faster compilation.
This moves the constant to a header where it can be reused.
Change-Id: Id460645a39d69999bf2227c25651d1149f1a6d6c
Reviewed-on: https://chromium-review.googlesource.com/c/1275895
Commit-Queue: Justin DeWitt <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600172}(cherry picked from commit 8c97247e25f177b4fadb9b8158706e4914cfaaff)
Reviewed-on: https://chromium-review.googlesource.com/c/1288569
Reviewed-by: Daniel Bratell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#117}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Elide relying party url shown on WebAuthN UI modal
Currenly, relying party id shown on webauthN modal is neither elided nor
lined wrapped when the width of the url extends the modal width. Change
it so that url is elided with maximum of 20 characters.
Bug: 893258
Change-Id: I37c8829526e73681b265f83db4847e9e85841e7d
Reviewed-on: https://chromium-review.googlesource.com/c/1285079
Commit-Queue: Jun Choi <[email protected]>
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600230}(cherry picked from commit 3ed8811f3a0249c0e34e9f5804c90f5831cce519)
Reviewed-on: https://chromium-review.googlesource.com/c/1288035
Reviewed-by: Jun Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#116}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}UKM Page load metrics observer: Fix crash when logging load timing
Fix crash when logging resource load timing metrics for the
main frame request in UKM page load metrics observer.
This is a tentative fix.
Change-Id: I70358e646fd64cad6e9e8258bec7c43c51633d78
Bug: 894789
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/1279942
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599862}(cherry picked from commit be0a422b05df963e4cd314accf03b6813c0b29ae)
Reviewed-on: https://chromium-review.googlesource.com/c/1288077
Cr-Commit-Position: refs/branch-heads/3578@{#115}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Tighten up IsCrostiniAllowedForProfile
This CL adds to IsCrostiniAllowedForProfile checks to disable Crostini
for incognito, guest, and lock screen profiles. We had previously added
these checks in https://crrev.com/c/1029934, but they were removed in
https://crrev.com/c/1058738 when we mistakenly thought that the primary
profile check would encompass these. Unlike before, this CL disables
Crostini entirely, not just the UI, to make the behaviour easier to
understand.
The incorrect logic was leading to a crash when opening a downloaded
file, via the notification, from an incognito profile.
Bug: 895015
Change-Id: I1c99e06ff2f03e1eaa0196dc2e3cb5f8b4678ea4
Reviewed-on: https://chromium-review.googlesource.com/c/1282086
Reviewed-by: Nicholas Verne <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600245}(cherry picked from commit 2cb5ccf5fd4ed25d4baab916f49dc5603f34467f)
Reviewed-on: https://chromium-review.googlesource.com/c/1288090
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#114}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Feed] Unify the UMA metrics prefix for all Feed metrics
Since Feed is not launching yet, This is a good time to unify Feed's
UMA metrics prefix.
Bug: 895610
Change-Id: Ie90a77496f968973020e3352986c8fd1b4b5d4aa
Reviewed-on: https://chromium-review.googlesource.com/c/1281916
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600203}(cherry picked from commit be7a71d4ba4a8c399c02606f9ce3e752468ae714)
Reviewed-on: https://chromium-review.googlesource.com/c/1287950
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#113}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add AllowWakeLocks policy to control system wake locks
Adds a new policy, AllowWakeLocks, that can be used to disable wake
locks entirely.
The existing AllowScreenWakeLocks policy merely demotes screen wake
locks to system wake locks. If AllowWakeLocks is set to false, all wake
locks should be disabled.
Note that AllowScreenWakeLocks will now be ignored when AllowWakeLocks
is set to false.
Bug: 894645
Change-Id: I3d153801dcd9ed1f6fbf7339cdd4e7173552338c
Reviewed-on: https://chromium-review.googlesource.com/c/1278347
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Commit-Queue: Rahul Chaturvedi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599220}(cherry picked from commit 1f44cfc204b0ab23e1beb7cbcb1ece99ea4197cb)
Reviewed-on: https://chromium-review.googlesource.com/c/1287549
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#112}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Smart Lock: Do not start multiple auth attempts.
EasyUnlockService previously re-instantiated an EasyUnlockAuthAttempt
every time the user profile picture was tapped or clicked. This was
unnecessary, and caused situations where the account's cryptohome
could not be decrypted.
[email protected]
(cherry picked from commit faf0b7f8bab4d4b321646a98d32186db9d7a5479)
Bug: 896045
Change-Id: I959ed3209caeb8d83519c8300d863a6288984740
Reviewed-on: https://chromium-review.googlesource.com/c/1285118
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600190}
Reviewed-on: https://chromium-review.googlesource.com/c/1287629
Cr-Commit-Position: refs/branch-heads/3578@{#111}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.13
[email protected]
Change-Id: Ic3cb3e48852467fc5e228c7f252fd5a53d69a889
Reviewed-on: https://chromium-review.googlesource.com/c/1287313
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#110}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS Powerwash screen: update icon and illustration.
[email protected]
(cherry picked from commit afc97ac06f5d3677c1016d1530c1e196844e2432)
Bug: 894280
Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
Reviewed-on: https://chromium-review.googlesource.com/c/1278211
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599141}
Reviewed-on: https://chromium-review.googlesource.com/c/1287509
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#109}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Change-Id: Ie1856ad8e917fd4cff237274ec4b33052a37894e
Reviewed-on: https://chromium-review.googlesource.com/c/1286668
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#108}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] Reland "[VK] Hide the virtual keyboard when we enter window overview mode."
This is a reland of a643a13e0bc16fd0cab3a143ba841567efa7c67c
Changed it to use HideKeyboardByUser instead of
HideKeyboardImplicitlyBySystem as we do not want to reshow the VK
if there's focus (see description of HideKeyboardImplicitlyBySystem).
A "proper" fix is to actually allow clients to specify whether an input
field should bring up the VK (like inputmode="none" in HTML). Then we
can just remove this special case code.
[email protected], [email protected]
Original change's description:
> [VK] Hide the virtual keyboard when we enter window overview mode.
>
> When we enter window overview mode (e.g. by dragging the top of an app),
> we need to hide the virtual keyboard because:
>
> 1) It blocks the overview mode UI for no reason.
> 2) The previews of windows have blank space at the bottom because that's
> where the keyboard is.
>
> Bug: 893856
> Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2
> Reviewed-on: https://chromium-review.googlesource.com/c/1278565
> Commit-Queue: Darren Shen <[email protected]>
> Reviewed-by: James Cook <[email protected]>
> Reviewed-by: Xiaoqian Dai <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#599561}
Bug: 893856
Change-Id: Ibe9a1873cda3972520c75338db1b108d6274e005
Reviewed-on: https://chromium-review.googlesource.com/c/1280098
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599603}(cherry picked from commit 8bc834f93ba33d416dc61fb9841b2aa92f091bbb)
Reviewed-on: https://chromium-review.googlesource.com/c/1287329
Cr-Commit-Position: refs/branch-heads/3578@{#107}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Manually load the original page when ReloadType::ORIGINAL_REQUEST_URL
This is a manual workaround so that HTTPS Server Previews can be team
fooded in 71 and will need to be merged back into the M71 branch.
This checks if the user is on a preview page and is reloading via
clicking the "load original" UI and if so, loads the orignal page.
Bug: 864187
Change-Id: I2c8ed4edba98f30f398675c38d7f89d3848a0212
Reviewed-on: https://chromium-review.googlesource.com/c/1280853
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599699}
Reviewed-on: https://chromium-review.googlesource.com/c/1287295
Cr-Commit-Position: refs/branch-heads/3578@{#106}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Disallow libjpeg_turbo downscaling of images with non-whole MCUs.
This CL changes JpegImageDecoder so that it doesn't advertise that it
can support smaller decode sizes if the original size cannot fit a whole
number of MCUs in both dimensions. This is done to prevent artifacts
from showing up when downscaling certain images.
dark line at the bottom.
[email protected]
(cherry picked from commit 8b9172a61f4e507b2eef30b2af438d2c19c0992d)
Test: opened the JPEG attached to the bug and verified that there is no
Bug: 890745
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I884edcefc4bbd0612e621109c24aedc09cad3452
Reviewed-on: https://chromium-review.googlesource.com/c/1274845
Reviewed-by: Leon Scroggins <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Khushal <[email protected]>
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600115}
Reviewed-on: https://chromium-review.googlesource.com/c/1287075
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#105}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove service name and refactor data use update to metrics service
This CL does a bunch of steps to make the servicification easy to do.
1. Removes the usage of ServiceName in data_use_measurement
2. Refactors the data use update to metrics service to not take service
name and instead send if the data use is from metrics component.
3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
ChromeDataUseMeasurement is introduced that does the posting to UI thread
(from io_thread.cc). This helps in servicification since there won't be
thread hop. This also helps when CDUA classes are removed, and
ChromeDataUseMeasurement can be there without dependency.
Bug: 808498
Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
Reviewed-on: https://chromium-review.googlesource.com/c/1272256
Commit-Queue: rajendrant <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599113}(cherry picked from commit dce70a031f697342a52b900211aa0ba7eceab082)
Reviewed-on: https://chromium-review.googlesource.com/c/1286861
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#104}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Clear the clipboard to claim ownership of it before updating it.
Bug: 879729
Change-Id: I8a7296b344c42115a7fade7d965a6b38f0688f59
Reviewed-on: https://chromium-review.googlesource.com/c/1281239
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Jamie Walch <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599742}(cherry picked from commit 7ca4f32144d3c96bc6bc8ec5d057702540b04a3c)
Reviewed-on: https://chromium-review.googlesource.com/c/1287179
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#103}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix Assistant timer notification crash.
The timer notification fires a deep link to initiate a text query
within Assistant to stop the firing timer.
The pending query was set before the view was fully initialized so
view state was not in sync with model state.
When this happened, we would eventually try promote the pending query
view to be the committed query view, but the pending query view did
not exist.
To fix this, we need to sync view state with the model state to ensure
that a pending query view always exists when there is a pending query
in the interaction model.
Bug: b:117771379
Change-Id: I7ad05836c95ffdd8973f11fae67051603dbfa76f
Reviewed-on: https://chromium-review.googlesource.com/c/1281169
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600095}(cherry picked from commit ae8140f1d1ed3c09d85964fabb0551d651f2501a)
Reviewed-on: https://chromium-review.googlesource.com/c/1286971
Cr-Commit-Position: refs/branch-heads/3578@{#102}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Modify Assistant DialogPlate icons and shift greeting label.
Per request from UI/UX folks, enlarging DialogPlate icons sizes to
24dip and adjusting left inset for voice input modality layout container.
Note that the vector icon files themselves were also updated per request
in the bug to ensure consistency of internal padding.
Also per request, the greeting label is shifted up by 4dip.
See bug for discussion/screenshots.
Bug: b:112313532
Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea
Reviewed-on: https://chromium-review.googlesource.com/c/1276947
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599074}(cherry picked from commit ddbc8a4da719464b3ebdbdae529019bc64964738)
Reviewed-on: https://chromium-review.googlesource.com/c/1286970
Cr-Commit-Position: refs/branch-heads/3578@{#101}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Move response processing out of UiElementContainerView.
This CL moves processing logic out of UiElementContainerView and into
AssistantResponseProcessor which is owned by
AssistantInteractionController.
The controller will now initiate processing of the Assistant response
before it is finalized. This cleans up the view logic considerably as
well as provides better synchronization of animations since processing
will have already occurred prior to the stage initiating a change.
Bug: b:117344968, b:116751668
Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd
Reviewed-on: https://chromium-review.googlesource.com/c/1265820
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599073}(cherry picked from commit 74869ac201a1859b4acc0bc0e0b14304f99843fb)
Reviewed-on: https://chromium-review.googlesource.com/c/1286893
Cr-Commit-Position: refs/branch-heads/3578@{#100}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Use circular focus rings for ToolbarActionView
Before this change, a square focus ring was recently added to make sure
that text set using chrome.browserAction.setBadgeText was not clipped by
the focus ring.
This new focus-ring style unfortunately looks very out of place, so this
change just removes the FocusRing::SetPath call so that it matches the
ink-drop style (and focus-ring style) of all toolbar buttons.
Obscuring the badge text is not too bad here since the text is clearly
visible when the view is not in focus and only partially occluded with
the focus ring present.
Bug: chromium:895263
Change-Id: I210893c84c138944f12923a1b844c833134ff7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281904
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600050}(cherry picked from commit 2c50b9cde47adf41c7ff5bfaa35239f77f563d26)
Reviewed-on: https://chromium-review.googlesource.com/c/1287195
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#99}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "cros: Hide Discover OOBE screen for public sessions"
This reverts commit 06905a7db74e034c7ed19d0ba66d8497ed2905a5.
Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1250136 should be merged first.
Original change's description:
> cros: Hide Discover OOBE screen for public sessions
>
> Bug: 895031
> Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174
> Reviewed-on: https://chromium-review.googlesource.com/c/1281165
> Reviewed-by: Alexander Alekseev <[email protected]>
> Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533)
> Reviewed-on: https://chromium-review.googlesource.com/c/1286896
> Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3578@{#87}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[email protected]
Change-Id: Ib25c70a6f2b44f3620b863b0e08e9fb691944cd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895031
Reviewed-on: https://chromium-review.googlesource.com/c/1287194
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#98}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Move strings for Safety information into OS_CHROMEOS block
Bug: 894790
Change-Id: I67d67ee8849e97195fe8e5bf82f83b8f809145a6
Reviewed-on: https://chromium-review.googlesource.com/c/1281236
Reviewed-by: Michael Giuffrida <[email protected]>
Commit-Queue: Zachary Kuznia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600041}(cherry picked from commit 74ad2ce2bf9b22cffb607ce774960950d341f5cd)
Reviewed-on: https://chromium-review.googlesource.com/c/1287175
Reviewed-by: Zachary Kuznia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#97}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[m71] Enable UsePaintRecordForImageSkia for CrOS on M71
We have UsePaintRecordForImageSkia feature enabled for all platforms
post m72. But this flag needs to be enabled for CrOS on m71 as ui-GPU
rasterization for CrOS is being enabled in this milestone.
The master branch change can be found here:
https://chromium-review.googlesource.com/c/chromium/src/+/1279068
Bug: 894901
Change-Id: Iffc5ba99727aa155b7a6237ccab917fe6d7e0659
Component: Images, vector icons, Chrome OS
Reviewed-on: https://chromium-review.googlesource.com/c/1281237
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#96}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Log AudioService features to the WebRTC log.
Example log line:
AudioService: AudioStreams=enabled, OutOfProcess=enabled, LaunchOnStartup=enabled, Sandbox=enabled, ApmInAudioService=enabled
Bug: 888971
Change-Id: I17cb7b1acafa7ff41c5fe9de67ed176c9008c7a7
Reviewed-on: https://chromium-review.googlesource.com/c/1278752
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Reviewed-by: Tommi <[email protected]>
Commit-Queue: Henrik Grunell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599591}(cherry picked from commit d0852575f8d42bcf45ad26d0c46bda23b025693d)
Reviewed-on: https://chromium-review.googlesource.com/c/1286664
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#95}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Fix animation not displaying when switching between users
Only happens where there are 2+ users (ie, user list is used).
OnImageDecoded is supposed to use the animation playback type that was
set in SetAnimationEnabled. However, UpdateForUser calls SetImage which
updates image_->playback() to kFirstFrameOnly. This means that
OnImageDecoded cannot use image_->playback() as the playback type set
by SetAnimationEnabled.
[email protected]
(cherry picked from commit 484a185167ad7b93dde4613e4d883fc7504c6787)
Bug: 894771
Change-Id: I47ac6daa1e8780e58abdabf59a7642ca4b9dcc43
Reviewed-on: https://chromium-review.googlesource.com/c/1277699
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599731}
Reviewed-on: https://chromium-review.googlesource.com/c/1287034
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#94}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.12
[email protected]
Change-Id: I432f0ee0d7fd69e8af6f66908c1571abed4ec5b7
Reviewed-on: https://chromium-review.googlesource.com/c/1286746
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#93}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Update UI for unsupported Android OS and make Jelly Bean unsupported."
This reverts commit 601b3e3a12f9cd79a051aab197278eb3daa6f79d.
Reason for revert: Breaks Chrome Custom Tabs.
Original change's description:
> Update UI for unsupported Android OS and make Jelly Bean unsupported.
>
> This CL updates the UI to show a badge icon in the app menu icon
> whenever the user is running Chrome on a currently unsupported Android
> version. This badge in the app menu is only displayed once, until the
> user taps the app menu icon. If the user does in fact get a new version,
> the badge state is reset, and will be shown again. The current behavior
> for out of date users stays the same as before (once per cold start).
>
> In addition, a new menu item is displayed at the top of the menu that
> explains that Chrome is unable to update. Nothing happens when you tap
> the menu item in the case of an unsupported OS version.
>
> The new menu item and the new warning message in About Chrome will
> always be displayed when the user is in this state, regardless of
> whether the app menu has already been tapped (which removes the badge).
>
> This CL also updates the UI in Settings - About Chrome to show a new
> message and a warning icon when the user is running Chrome on an
> unsupported version of the Android OS.
>
> By default, Jelly Bean is considered unsupported after this CL, but this
> can be overridden from the variations framework.
>
> It is possible to use command line flags or chrome://flags for
> testing the different states, though that does not impact the
> About Chrome screen.
>
> Binary-Size: This CL adds new assets and the minimal code required.
> Bug: 847940
> Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6
> Reviewed-on: https://chromium-review.googlesource.com/c/1243167
> Commit-Queue: Tommy Nyquist <[email protected]>
> Reviewed-by: Theresa <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#599369}(cherry picked from commit 5423fd8ab9355223e880007e08c1df4fcd3208fe)
> Reviewed-on: https://chromium-review.googlesource.com/c/1279959
> Reviewed-by: Tommy Nyquist <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3578@{#15}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 847940
Change-Id: Iec0d8b4c07f123597f4883d1be3f14c3207e7c05
Reviewed-on: https://chromium-review.googlesource.com/c/1286281
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#92}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[jumbo] fixup after recent headless network service work
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
which introduced a namespace clash between ::network and ::headless::network.
Also, rename one of two kProductName's.
[email protected]
Bug: 838291,792676
Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
Reviewed-on: https://chromium-review.googlesource.com/c/1277992
Commit-Queue: Mostyn Bramley-Moore <[email protected]>
Reviewed-by: Daniel Bratell <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599150}(cherry picked from commit ed8c927801fdf271cff29cb95a46546cef0a9239)
Reviewed-on: https://chromium-review.googlesource.com/c/1286663
Reviewed-by: Mostyn Bramley-Moore <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#91}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix scaling bug with OfflineContentProvider thumbnails in DHv2
The download home v2 glue incorrectly scaled thumbnails coming back from
OfflineContentProviders. This isn't a huge bug (yet) because most
requests and results are square, so the aspect ratio doesn't change.
However it will quickly become an issue once downloads are ported over.
Bug: 892415
Change-Id: I5f65ca7f3b8fff0e37e6e410636bb170491f1166
Reviewed-on: https://chromium-review.googlesource.com/c/1277678
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599435}(cherry picked from commit b718ee2c334a87472745aba9a7b9b0ace342d58b)
Reviewed-on: https://chromium-review.googlesource.com/c/1286528
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#90}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Fix UsageTimeLimitProcessor to handle state properly when usage time limit takes
effect immediately.
Bug: 895036
Change-Id: Icfa7364e8217e4df9904154bf1372328187bd4a6
Reviewed-on: https://chromium-review.googlesource.com/c/1279368
Reviewed-by: Aga Wronska <[email protected]>
Reviewed-by: Rahul Chaturvedi <[email protected]>
Commit-Queue: Henrique Grandinetti <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599467}(cherry picked from commit dbe0d3e4b99d5884ff5231fc45412661a4421fea)
Reviewed-on: https://chromium-review.googlesource.com/c/1286709
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#89}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[merge to 71] applist: Allow swiping up on shelf to show applist when autohide.
[email protected]
(cherry picked from commit c035b3ff56f31954c6ac938d5e250d00b4d7a561)
Test: manual
Bug: 881483, 891366
Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21
Reviewed-on: https://chromium-review.googlesource.com/c/1279356
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599778}
Reviewed-on: https://chromium-review.googlesource.com/c/1286898
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#88}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Hide Discover OOBE screen for public sessions
Bug: 895031
Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174
Reviewed-on: https://chromium-review.googlesource.com/c/1281165
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599853}(cherry picked from commit ed95e624b7279a87a1eff8d7b69e3cb559dfd533)
Reviewed-on: https://chromium-review.googlesource.com/c/1286896
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#87}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M-71] Add flag for tablet mode double tap to zoom
The flag tracks a feature that is enabled by default,
which allows us to disable double-tap-to-zoom in the
future if we need to.
[email protected]
BUG=895574
TEST=Disable the feature and expect double-tap-to-zoom
to stop working in tablet mode.
Change-Id: Ia3bafbb96ecd2fb55186b1fae388d955e34efb2f
Reviewed-on: https://chromium-review.googlesource.com/c/1281884
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599998}(cherry picked from commit 4f567e69a4674d29906515febe3d6fc2738da0fb)
Reviewed-on: https://chromium-review.googlesource.com/c/1286880
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#86}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Switch Android SMS to prod endpoint by default
Bug: 881664
Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d
Reviewed-on: https://chromium-review.googlesource.com/c/1279426
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Jeremy Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599792}(cherry picked from commit bbe547af1bca45c9bd728d90c1e6685fc314f001)
Reviewed-on: https://chromium-review.googlesource.com/c/1286874
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#85}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Change "Cancel" to "No thanks" in OOBE
On the start setup page of OOBE, change the text of the cancel button to
read "No thanks" instead of "Cancel".
Screenshots:
OOBE: https://drive.google.com/open?id=1QjHg1_v1QFg1tph986Xi2igPUYG8nJlneA
post-OOBE: https://drive.google.com/open?id=1-hxQjU-WVMi8sAWNAZB-7LyrcX3F5ju5bQ
Bug: 893353
Change-Id: I748f282b392bccfe17bd14f8bc036cca786bb8f9
Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice*
Reviewed-on: https://chromium-review.googlesource.com/c/1272067
Commit-Queue: Josh Nohle <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599860}(cherry picked from commit 8c257639f2961de4ea8c5673514191e7b95ab377)
Reviewed-on: https://chromium-review.googlesource.com/c/1286873
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#84}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Skip other interceptors after SignedExchangeRequestHandler started handling the request
Currently when both service-worker-servicification and network-service are not
enabled, the internally redirected request doesn't go to the service worker.
But when service-worker-servicification or network-service is enabled, the
internally redirected request goes to the service worker.
We may support service worker integration, like FetchEvent's preloadResponse in
future. But we don't have plan to support service worker integration without
service-worker-servicification.
To make this behavior consistent, this CL makes
NavigationURLLoaderImpl::URLLoaderRequestController skip sending the redirected
request of signed exchange to the service worker.
Bug: 894755
Change-Id: I6f22819655169b4d3c30de0aa269911111c45586
Reviewed-on: https://chromium-review.googlesource.com/c/1278433
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599815}(cherry picked from commit 0fd45315adaa2d4a801d27af02e04aa257751d51)
Reviewed-on: https://chromium-review.googlesource.com/c/1286010
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#83}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Allow disconnect window to be moved after local user input
Per feedback reports we have received, the disconnect window positioning
logic is frustrating for users who are providing remote support via Me2Me.
This CL updates the logic so that we only place the dialog in the center
of the screen until we see local user input. At that point we honor the
placement of the dialog unless a monitor change event occurs. At that
point we place it above the taskbar which is less obtrusive but still
visible.
Bug: 896026
Change-Id: Ib40155e8207aec5e3d653695718204194e34cd44
Reviewed-on: https://chromium-review.googlesource.com/c/1285450
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Joe Downing <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600226}(cherry picked from commit 18bb64123afeb4240cce687d04c361da0d7acbaa)
Reviewed-on: https://chromium-review.googlesource.com/c/1286189
Reviewed-by: Joe Downing <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#82}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Consume the back button press only when ARC IME shows.
Bug: 894362, 845079
Test: The back button works as history back when ARC IME doesn't show up.
Change-Id: Ibffbf39f02f9bc3c75c42b4091dce442046d48e2
Reviewed-on: https://chromium-review.googlesource.com/c/1278511
Commit-Queue: Yusuke Sato <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599350}(cherry picked from commit 820d766b0b830323ba7dabbfbae4123fd47fd3e8)
Reviewed-on: https://chromium-review.googlesource.com/c/1285492
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#81}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71]Set kAppType of Settings and Discover apps to CHROME_APP.
The kAppType of browser based custom apps are set based on the
|app_name|, which is not set for the internal apps like Settings and
Discover. Rewrite it for these two apps in corresponding window manager
to make sure both of them can have the correct app type now.
calamity@ is doing a refactoring of the system apps here
(https://docs.google.com/document/d/16CRTWFjU8Ohrn9aSTPuDJcbqh1z7E4wKwyEWstInRh0/edit#),
which will fix all these related issues in long term.
[email protected]
(cherry picked from commit cb343f3c5acf70010afafa8c498ff5104a533493)
Bug: 877723
Change-Id: Iaaf9fb4998a1416bae4a8c6fa5582d1ff2235326
Reviewed-on: https://chromium-review.googlesource.com/c/1258090
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: calamity <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599245}
Reviewed-on: https://chromium-review.googlesource.com/c/1285694
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#80}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71]Cancel the menu animation if it is partial shown in tablet mode too.
We used a callback SetShowMenuAnimationDone to start the
|pre_shutdown_timer_| if the PowerButtonMenuScreenView has been full
shown (opacity reaches its final opacity), but didn't stop it if
UseTabletBehavior is true when power button up.
Then if menu animation has been started
(power_button_menu_timer_ run out of) but not finished
(pre_shutdown_timer_ hasn't been started) and UseTabletBehavior is true
when power button up. We did nothing in this case. This will cause the
|pre_shutdown_timer_| to be started and finally trigger power off when
the menu shown animation finished.
This cl tried to fix the issue by calling ScheduleShowHideAnimation(false)
too if UseTabletBehavior. This will cancel the menu shown animation to make
sure its opacity will not achieve its final shown opacity then the callback
SetShowMenuAnimationDone will not be called.
Turn screen off too in this case.
[email protected]
(cherry picked from commit 3a8fc6341bebc496fd7ac2344c8314fb5b3d82b2)
Bug: 894192
Change-Id: Id744597e53229384fd01279e489d9099c83be67b
Reviewed-on: https://chromium-review.googlesource.com/c/1277914
Commit-Queue: Min Chen <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599724}
Reviewed-on: https://chromium-review.googlesource.com/c/1285729
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#79}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.11
[email protected]
Change-Id: Ib43ac51515d81ef6e03e1630d849195471f897d9
Reviewed-on: https://chromium-review.googlesource.com/c/1285630
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#78}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download home v2: Fix issue in storage summary.
Currently removing an ongoing download may hit assertion in
StorageSummaryProvider, this is due to a bug in onItemUpdated that we
increase the total storage based on old item instead of the new item.
[email protected]
(cherry picked from commit 12be1cb28b79d4398dc06bfbfb12d415d2aa2160)
Bug: 892328
Change-Id: I64cda81662290df049f74aa3f1893c7a0984c043
Reviewed-on: https://chromium-review.googlesource.com/c/1284705
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600167}
Reviewed-on: https://chromium-review.googlesource.com/c/1285354
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#77}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id2a6c20032079b2186a7c0cb4b1bbcb71fcf3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/1285525
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#76}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix scaling/rounding of icons on ExploreSitesPage.
[email protected]
(cherry picked from commit 372bd912ae02545a4c6d2ad6519b389ff3fa9ce8)
Bug: 895045
Change-Id: I2f542536bf61d8953d88f42959ee47f07e73150e
Reviewed-on: https://chromium-review.googlesource.com/c/1279364
Reviewed-by: Peter Williamson <[email protected]>
Commit-Queue: Dmitry Titov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599466}
Reviewed-on: https://chromium-review.googlesource.com/c/1285522
Reviewed-by: Dmitry Titov <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#75}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix touchable insets for Avatar/Cast toolbar icons
An earlier refactoring set zero-insets for touchable AvatarToolbarButton
instead of insets for TOOLBAR_BUTTON. This API was confusing to use so
SetLayoutInsets was changed and renamed to SetLayoutInsetDelta to make
it easier to use. Callers no longer need to include the call to
GetLayoutInsets(TOOLBAR_BUTTON).
CastToolbarButton having incorrect ink-drops was not a regression but
has always used a 16dp icon in both touchable and non-touchable modes.
This change also calls SetInsetDelta to make up for the missing 8dp.
Bug: chromium:895519
Change-Id: I30595913dfb8a19358d198d9f4e0dbcb37993117
Reviewed-on: https://chromium-review.googlesource.com/c/1281903
Reviewed-by: Bret Sepulveda <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599765}(cherry picked from commit 019423bf4be51d4547a2309741eb666a39a7b718)
Reviewed-on: https://chromium-review.googlesource.com/c/1285321
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#74}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Explore Sites] Adding UMA to capture the result of the ImageDecoder service.
Change-Id: I1a5cca85ac14fcec14a6536b57d8bfa5db211fd6
Reviewed-on: https://chromium-review.googlesource.com/c/1277525
Commit-Queue: Jonathan Freed <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599237}(cherry picked from commit 0ad8cbec6313fb12f99d972f39a97ff15b3ad212)
Reviewed-on: https://chromium-review.googlesource.com/c/1284812
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#73}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Explore Sites] Fixing SQL query to gather icons for category tiles.
Previously, the SQL query included site icons that were NULL or empty,
resulting in category tiles often having less than 4 site icons present.
This fix skips the empty icons, and grabs the next non-empty ones.
Change-Id: I314c78f1797769e598640d06162811e1672c2449
Reviewed-on: https://chromium-review.googlesource.com/c/1279155
Reviewed-by: Peter Williamson <[email protected]>
Commit-Queue: Jonathan Freed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599347}(cherry picked from commit cdef2348b6eb0a979565e00b1ac130f3e38612b7)
Reviewed-on: https://chromium-review.googlesource.com/c/1285097
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#72}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Fixed bugs
1 - Download home looks black on tablets for certain views such as storage
header, date header etc. This is fixed by adding the default background
color to the main view, which was also present in old download home.
2 - Share crashes when there is no activity to handle it. Fixed it by
wrapping with an intent chooser intent.
3 - Changed images on tablets to use fixed 240dp width instead of
going full screen.
Bug: 889723
Change-Id: Ib9d582f7f81debd2b588dc901ddfede36829ef33
Reviewed-on: https://chromium-review.googlesource.com/c/1278143
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599760}(cherry picked from commit e16fa738b757f7cf0c680b80a5a38140b51bc084)
Reviewed-on: https://chromium-review.googlesource.com/c/1285096
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#71}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add more detailed error message for unsupported SMB mounts
- Adds a message to provide users with a more detailed error message
when SMB mounting to a file server that doesn't support SMBv2 or later.
Bug: chromium:887127
Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274608
Reviewed-by: Zentaro Kavanagh <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Bailey Berro <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599353}(cherry picked from commit a44b1caabf20abe59ed91c3f1067146681a804ff)
Reviewed-on: https://chromium-review.googlesource.com/c/1285088
Reviewed-by: Bailey Berro <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#70}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add deadline to Find-in-page idle tasks
In some cases such as multiple frame webpages, idle task might never
execute or take a noticably long time to execute. This might lead to
incorrect number of find-in-page result and not highlighting matches
because the scoping is never trigerred. This CL adds a deadline to
scoping idle tasks to ensure all scoping happens in a timely manner.
Bug: 890622,893465
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8ec998d4c2f42377361c1f7b95c1497a80368ef6
Reviewed-on: https://chromium-review.googlesource.com/c/1270196
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599562}(cherry picked from commit 0df2607f9809b189f7b7177df1d19d7cf8429f3c)
Reviewed-on: https://chromium-review.googlesource.com/c/1285149
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#69}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.10
[email protected]
Change-Id: Ia5538f26befee9d5452cd0280e85b53af2f1cf27
Reviewed-on: https://chromium-review.googlesource.com/c/1284731
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#68}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Remove unneeded "Add fingerprint" button on OOBE
This code is only used in OOBE so it is safe to just remove it.
[email protected]
(cherry picked from commit 35bbced8e213548eb81b8a9b7d31c8bccdde1119)
Bug: 890367
Change-Id: I54130cc3c115c1a1356a045f443a8a19962686f8
Reviewed-on: https://chromium-review.googlesource.com/c/1279162
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599381}
Reviewed-on: https://chromium-review.googlesource.com/c/1284692
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#67}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge Do not disable guest mode when BrowserSignin override ForceBrowesrSignin without a forced value.
Merge the patch into M71.
Bug: 894212
Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3
Reviewed-on: https://chromium-review.googlesource.com/c/1274196
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599247}(cherry picked from commit df7614ec9e3c573b71afb3aea7b9d3db54d518bb)
Reviewed-on: https://chromium-review.googlesource.com/c/1284729
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#66}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[AF] Updates the subtitle for the Autofill Payment Methods settings toggle
Bug: 892220
Change-Id: I0aa186011149b4c53697fcfa0a62d3ee60dbe956
Reviewed-on: https://chromium-review.googlesource.com/c/1278885
Commit-Queue: Fabio Tirelo <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599254}(cherry picked from commit 22a175cbcd669cd3d64f2b76f6c1f7d7b2527fc1)
Reviewed-on: https://chromium-review.googlesource.com/c/1284690
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#65}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Update setup flow buttons
Update the multi-device setup flow button bar to include the
following buttons: Back, Cancel, Forward. Set the buttons
on each page to conform to the following specs (sans padding):
https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view.
Screenshots with this patch applied:
start screen: https://drive.google.com/open?id=1QlWKjesaBpt0ZtNQ_vONBqu1czUWiezz
start screen (OOBE): https://drive.google.com/open?id=1kh9UNYjLaSbP-zE0U89sniZSb9Sbhk8fMw
password screen: https://drive.google.com/open?id=1olKePztZ9pqxPHupVCdrwEBZ1pyfzLA_
success screen: https://drive.google.com/open?id=1zpZfnowdpOvge8nteqsjBHuUin_I9HgW
Bug: 889574
Change-Id: I7a0834b58b6f2458e5ab6641aa5b323cb5fc32fe
Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice*
Reviewed-on: https://chromium-review.googlesource.com/c/1254760
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Josh Nohle <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599737}(cherry picked from commit 8057370b7dfbaea35dd7f19dd9ad49a109a78b89)
Reviewed-on: https://chromium-review.googlesource.com/c/1284444
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#64}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Temporarily disable separate URLLoaderFactories for extensions.
Disabling separate URLLoaderFactories for extensions should help ensure
that things are stable in M71, while we work on a real fix for
https://crbug.com/894766 in M72.
This CL can be seen as a manual, minimal revert of r596378.
[email protected]
(cherry picked from commit b4013627cedb0d1ceab9db55ea93e401ad764a18)
Bug: 894766
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I1cad01be3789b335be00399432d82ef74266a5ab
Reviewed-on: https://chromium-review.googlesource.com/c/1279170
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599434}
Reviewed-on: https://chromium-review.googlesource.com/c/1284534
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#63}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Don't clear brand for regular cros sessions.
If the brand code persisted in local prefs is empty, reinitialize to correct.
Bug: 846033, 893451
Change-Id: I49cc299374d8530d3a46aee93cb7cb2518ff1dee
Reviewed-on: https://chromium-review.googlesource.com/c/1272447
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599645}(cherry picked from commit 5d80e3087f51f96491f2a53df786447aa6458287)
Reviewed-on: https://chromium-review.googlesource.com/c/1284532
Reviewed-by: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#62}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71 merge] assistant: Check status before starting service
This cl checks the |allowed_status| before starting assistant service.
[email protected]
Bug: b/117371953
Test: manual.
Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77
Reviewed-on: https://chromium-review.googlesource.com/c/1278345
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599075}(cherry picked from commit 2a789a6e4d2c639cfe39db5b7b19edd6a0837ad6)
Reviewed-on: https://chromium-review.googlesource.com/c/1284431
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#61}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Don't try RemoveTemporarySession test if license server not available.
BUG=894422
TEST=test passes on Windows
Change-Id: I3907fecda3642f542db153e68ce12cb33c074402
Reviewed-on: https://chromium-review.googlesource.com/c/1278467
Commit-Queue: Xiaohan Wang <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599065}(cherry picked from commit 44229dd3259f368779bfc384620e127c0c0abba9)
Reviewed-on: https://chromium-review.googlesource.com/c/1284389
Reviewed-by: John Rummell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#60}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[clear-browsing-data] Change history string for 'sync is paused' state
When sync is paused, the string for the history checkbox is changed from
"Clears history and autocompletions in the address bar. Your account may
have other forms of browsing history at myactivity.google.com."
to "Clears history and autocompletions in the address bar."
Bug: 893696
Change-Id: I1aba27b8902b39bc2e28e8e66e564a58327fcc33
Reviewed-on: https://chromium-review.googlesource.com/c/1280672
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599712}(cherry picked from commit 6861eea1bcb6308d3b4bd31331114b015bc6bb2c)
Reviewed-on: https://chromium-review.googlesource.com/c/1284369
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#59}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[clear-browsing-data] Clean up code for dialog
Clean up code for clear browsing data dialog.
Changes:
- Remove template elements and add hidden
attribute instead
- Clean up tests
- Remove argument from strings ($1 -> #)
Bug: 893696
Change-Id: I0650a0a6fe0bd08884480f6eb4b53e379ba4ebba
Reviewed-on: https://chromium-review.googlesource.com/c/1276771
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599643}(cherry picked from commit 59736b137039d41772096577d9db14e0b9719eb9)
Reviewed-on: https://chromium-review.googlesource.com/c/1284330
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#58}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add ResizeObserver use counter
Bug: 612962, 895543
Change-Id: I794b3010dd4d234f81be025987cda38b134aae4e
Reviewed-on: https://chromium-review.googlesource.com/c/1279355
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599491}(cherry picked from commit 230b55644cf60b11bb6ae6c32adac7f9a317d1a9)
Reviewed-on: https://chromium-review.googlesource.com/c/1284068
Reviewed-by: Aleks Totic <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#57}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download home v2: Show storage used by downloads.
This CL changes the storage string to [storage used by download] of
[total disk size].
[email protected]
(cherry picked from commit ef9df5c57de0fe56c3ddd6f332e0e5995fedf750)
Bug: 892328
Change-Id: I6516c89e4f6bf71101c56b43171375a037cc36bf
Reviewed-on: https://chromium-review.googlesource.com/c/1277917
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599703}
Reviewed-on: https://chromium-review.googlesource.com/c/1284210
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#56}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Fling bubbles from OOPIF properly" without the tests.
This cl relands the following cl after excluding the added tests.
https://chromium-review.googlesource.com/c/chromium/src/+/1278963
This gives the solution more time to bake on ToT without getting
reverted due to flaky tests.
Meanwhile I will work on the tests to deflake them.
[email protected],[email protected]
Bug: 884728, 249063
Change-Id: Icc1e32ffe493f85d0ee74b0aff37ccdf078d0e8f
Reviewed-on: https://chromium-review.googlesource.com/c/1281687
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599781}(cherry picked from commit abad21884e5be40e670eab118997d665be5a7618)
Reviewed-on: https://chromium-review.googlesource.com/c/1284066
Reviewed-by: Sahel Sharify <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#55}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] Initialize test UrlValidityChecker in InstantService and simplify UrlValidityChecker testing
Fix crashes caused by |url_checker_for_testing_| not being initialized
properly.
Additionally, construct UrlValidityChecker with NoDestructor instead of
a global LazyInstance. We prefer to leak singletons to avoid
unnecessary work at shutdown. Also simplify UrlValidityChecker by
passing TickClock, which provides cleaner timeout and duration testing.
Bug: 894742
Change-Id: I468f76e07dc6f551a8515d8416d0c67f5f2035a1
Reviewed-on: https://chromium-review.googlesource.com/c/1277959
Commit-Queue: Kristi Park <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599377}(cherry picked from commit 8c7eeb6df92a1d9d33cd68f60bfe51ecaaeeb723)
Reviewed-on: https://chromium-review.googlesource.com/c/1284063
Reviewed-by: Kristi Park <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#54}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}ozone: evdev: Add quirk to force USB 0x18d1:0x5030 as internal
This adds a quirk to force this device as internal so that it behaves
correctly in tablet mode.
Bug: b/116723180
Test: please
Change-Id: Ica3ace1098daf090e843ffb03bb27ef07d5144a1
Reviewed-on: https://chromium-review.googlesource.com/c/1280845
Reviewed-by: Kevin Schoedel <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Michael Spang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599732}(cherry picked from commit 1d6ccd829e124f99252cd0f73de12810e0678aa4)
Reviewed-on: https://chromium-review.googlesource.com/c/1283944
Reviewed-by: Michael Spang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#53}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Print Preview Refresh: Fix enter key blocked in pages input (M71)
Bug: 894350
Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3
Reviewed-on: https://chromium-review.googlesource.com/c/1278534
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599291}(cherry picked from commit aa730994107b1bef054c04a2ee339fdfe637a55e)
Reviewed-on: https://chromium-review.googlesource.com/c/1284056
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#52}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
This is the bug fixing for previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1253317
v8::HandleScope was not named.
Bug: 894069
Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
Reviewed-on: https://chromium-review.googlesource.com/c/1278548
Commit-Queue: Yuki Yamada <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599110}(cherry picked from commit f93617e5eb9f06935b07002223f33d164f517909)
Reviewed-on: https://chromium-review.googlesource.com/c/1283751
Cr-Commit-Position: refs/branch-heads/3578@{#51}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Accessibility fixes for removing users on views-login
- Fix the label for the remove user button so it reads "Remove user"
- After hitting remove user read the warning message
- Increase the contrast for the remove user button.
[email protected]
(cherry picked from commit 7984efe9dd999941fda9cd2cec44aa1338abb483)
Bug: 787489
Change-Id: I2003aaa0b63cda33e1a23ceb4b4d2bd55fbd531f
Reviewed-on: https://chromium-review.googlesource.com/c/1278140
Commit-Queue: Jacob Dufault <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599403}
Reviewed-on: https://chromium-review.googlesource.com/c/1284061
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#50}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}cros: Remove shadow around fingerprint setup in OOBE
[email protected]
(cherry picked from commit 35e8f5efa327894c3af8fbd54d68de78be020b05)
Bug: 893386
Change-Id: Id6de56514183945879f4cf6ffdca7ad7beeae3d7
Reviewed-on: https://chromium-review.googlesource.com/c/1279189
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599389}
Reviewed-on: https://chromium-review.googlesource.com/c/1284060
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#49}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "[DevTools] removed Breakpoint._currentState"
This reverts commit 9c39f918d0601422526a5b2f9d7798dfa553b67d.
Reason for revert: break breakpoint in minified sources.
Original change's description:
> [DevTools] removed Breakpoint._currentState
>
> Current state on breakpoint shared between different models is hack
> that should never work.
>
> R=[email protected]
>
> Bug: none
> Change-Id: I60a0e5774c47c38a0f5f251f9e9d5f2437ceb9b4
> Reviewed-on: https://chromium-review.googlesource.com/1179262
> Reviewed-by: Andrey Lushnikov <[email protected]>
> Commit-Queue: Andrey Lushnikov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#583934}
[email protected], [email protected]
(cherry picked from commit 0d7737c74fc25f1fdd71138cb1765913d5a7adcb)
Bug: chromium:893364
Change-Id: Id6a170405c0d07658ff5741142dc2b35b7f89c6b
Reviewed-on: https://chromium-review.googlesource.com/c/1281688
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599774}
Reviewed-on: https://chromium-review.googlesource.com/c/1283936
Cr-Commit-Position: refs/branch-heads/3578@{#48}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Dont crash on integer overflow
Simply return an empty buffer and log an error.
Bug: 894941
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I02a70afb3f326c1a9a8b845f7bc8d1aa84cb5dad
Reviewed-on: https://chromium-review.googlesource.com/c/1281692
Commit-Queue: Ted Meyer <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599833}(cherry picked from commit fd1b40954eec2e50f861deb8b8f50a20099ff76b)
Reviewed-on: https://chromium-review.googlesource.com/c/1283935
Reviewed-by: Ted Meyer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#47}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Use generic view holders for lowend device
Bug: 892331
Change-Id: Ib8870f281bbd40cb4742ac6984a1fd245d429c78
Reviewed-on: https://chromium-review.googlesource.com/c/1277869
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599447}(cherry picked from commit 1a9e94fdc5b75ec7df4f2155d05429bf689c765c)
Reviewed-on: https://chromium-review.googlesource.com/c/1283990
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#46}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Added metrics for autoupgraded resources and websockets.
Added histograms that log start/failure/response code for autoupgraded
resources, and start/failure/connection success for autoupgraded
websockets. Metrics for form submissions will come in a later CL.
Bug: 893685
Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2
Reviewed-on: https://chromium-review.googlesource.com/c/1275295
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599743}(cherry picked from commit c750a81e9fdfc847c674dd74f8f4795760bb1931)
Reviewed-on: https://chromium-review.googlesource.com/c/1283931
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#45}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] cros: Whitelist kRlzPingDelay in kForwardSwitches
This is for the convenience of testing rlz ping. The normal waiting
time is 24 hours and it's unrealistic for testing team.
Bug: 894331
Change-Id: Ia5d6d38bc05221672d4ae4a0b6da4e221aaa0607
Reviewed-on: https://chromium-review.googlesource.com/c/1270012
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599256}(cherry picked from commit 8ce1b79ba1ca42736a671d94474c58a9fa1a1a3f)
Reviewed-on: https://chromium-review.googlesource.com/c/1283991
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#44}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Fixed close button behavior on tablets
The close button shouldn't be show on the tablets which was broken.
Bug: 894625
Change-Id: I4f9740132a329d2e62d43b8dc0ef858780a21c91
Reviewed-on: https://chromium-review.googlesource.com/c/1278165
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599422}(cherry picked from commit 8d4e0742142f383556c0ecd71d53c270e301b2dd)
Reviewed-on: https://chromium-review.googlesource.com/c/1283989
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#43}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Media Controls] Fix the size of the overlay play button as 72x72px
This CL removes the code that dynamically sets the overlay play button
size based on the video size. Instead, this just sets the button at
72px by 72px. This solves *most* cases of a bug where the loading
spinner was slightly off-center on certain sizes.
Bug: 894866, 877113
Change-Id: I96ccda8921ffddddf009fa0b7ee28907201a966f
Reviewed-on: https://chromium-review.googlesource.com/c/1278860
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599547}(cherry picked from commit 53e727daf255777aa6ad6feb3d8188ec70db52e0)
Reviewed-on: https://chromium-review.googlesource.com/c/1283552
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#42}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix accessibility support for MD incognito NTP
Use TextViewWithClickableSpan for the subtitle text so that it responds
to accessibility events when the learn more link is appended to the end.
Also update the XML to make the root view focusable instead of the
scroll view, which fixes an issue where focus was previously going to a
child of the ScrollView instead of the container.
BUG=894844,757017
Change-Id: I737d3aa8cbe03064caa95065a6ce07ba41e6194e
Reviewed-on: https://chromium-review.googlesource.com/c/1278797
Commit-Queue: Theresa <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599287}(cherry picked from commit 6cde412bcda48ec89b3689b1b1f37671a09508cc)
Reviewed-on: https://chromium-review.googlesource.com/c/1283479
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#41}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[PE] Don't paint outline on foreground layer
"Background" of the foreground layer:
A foreground layer is created for a composited scrolling element with
composited negative-z-order descendants. It's actually another scrolling
contents layer which paints non-composited normal and positive-z-order
descendants, while the original scrolling contents layer paints the
scrolling background and descendants below the composited
negative-z-order layer. The foreground layer and the scrolling contents
layer both scroll and use the contents property tree state.
Previously we mistakenly painted outline on the foreground layer (and
on the main layer). The bug had existed before SPv175 when we could see
an extra outline scrolling with the contents. In SPv175, we saw an error
message saying that the outline's chunk's clip state escaped the layer's
clip state, and the foreground layer was fully raster invalidated on
each scroll. Not sure how the clip-escaping broke rendering.
[email protected]
(cherry picked from commit 89879ac0cab5651b77aa9dd512f9544dc7454b63)
Bug: 886997,892855
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9ad7db2baa526f085676f13c429460c4ff46322c
Reviewed-on: https://chromium-review.googlesource.com/c/1278990
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599412}
Reviewed-on: https://chromium-review.googlesource.com/c/1283477
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#40}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71][Payment Handler] Preserve device bottom keys.
Before this patch, launching a Payment Handler CCT would show a black
patch on device bottom keys. The keys were still there, but the
foreground and background were the same color. This happened only on
Oreo and Pie. Nougat and earlier versions continued to work OK.
This patch disables windowLightNavigationBar in the style of the
DimmingDialog, which dims the background behind the Payment Handler CCT.
This property is available in API versions 28 and higher.
After this patch, launching a Payment Handler CCT shows the navbar
buttons.
[email protected]
(cherry picked from commit f8d653adaf46fc8671ca130dca7f5a40e390a5f5)
Bug: 890183
Change-Id: I42126f434f928f80355c849c3a2fd3d1e6e85b13
Reviewed-on: https://chromium-review.googlesource.com/c/1259364
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599550}
Reviewed-on: https://chromium-review.googlesource.com/c/1283473
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#39}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Make DataPipeBytesConsumer support ReadableStream loading better.
This CL fixes some edge condition interactions when being loaded as
a ReadableStream. In particular, it:
1. Properly distinguishes between the end of the DataPipe and a closed
DataPipe with bytes left to be read. A ReadableStream that is not
actively draining the pipe could get closed too early.
2. Responses must support explicit completion in order to handle error
conditions properly. This CL makes DataPipeBytesConsumer wait
for an explicit signal before closing.
3. Service worker navigation preload is updated to provide the explicit
completion signals.
Bug: 894815
Change-Id: I2b5d61f9fe4a6f17c37e8a728b2f081debe6d936
Reviewed-on: https://chromium-review.googlesource.com/c/1278910
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Ben Kelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599739}(cherry picked from commit 2e178e0de8ca17d871fcdf56a79915bf7ebd7671)
Reviewed-on: https://chromium-review.googlesource.com/c/1283412
Reviewed-by: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#38}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Track number of received invalidations per datatype for Chrome Sync.
[email protected]
(cherry picked from commit 5279e0fe22b8430feb5d0a13d5a387111b0d42c1)
Bug: 894764
Change-Id: If190cdf6396b567c9ab5e983d67d4f25b20d501b
Reviewed-on: https://chromium-review.googlesource.com/c/1278787
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Tatiana Gornak <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599500}
Reviewed-on: https://chromium-review.googlesource.com/c/1283022
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#37}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add custom cursor image size to UseCounter ukm whitelist
This API is being used for abuse.
[email protected]
Bug: 880863
Change-Id: I122e23f589d62eecc01a4418db3573c53779de7f
Reviewed-on: https://chromium-review.googlesource.com/c/1275165
Reviewed-by: Bryan McQuade <[email protected]>
Commit-Queue: Charlie Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599314}(cherry picked from commit 6072eb20a5d5007d5cc0a9ca316f7b23b95c660f)
Reviewed-on: https://chromium-review.googlesource.com/c/1283389
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#36}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
it return 0 planes for single-plane multiplanar formats. We obviously
cannot have a multiplanar format with 0 planes, so add a workaround at
the fake-ioctl level. Implement it as a case-switch for future-proofing
against other workarounds we will likely have to add.
Also add a few recommendations in v4l2_device.cc against the temptation
to spare some memory by using an appropriately-sized array of
v4l2_planes: it turns out libv4l2 also likes to write above the number
of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
result in memory corruption DCHECKS being raised.
BUG=893661
TEST=Checked that VDA unittest was passing on both hana and nyan_big.
Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
Reviewed-on: https://chromium-review.googlesource.com/c/1275727
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Kuang-che Wu <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599135}(cherry picked from commit 029544dab67d79059b7610a92890091520ef7603)
Reviewed-on: https://chromium-review.googlesource.com/c/1282087
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#35}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Roll AFDO from 71.0.3576.0_rc-r1 to 71.0.3577.0_rc-r1"
This reverts commit 6fb1a0860e442c7f9707c2003d219cb03b3dff81.
Reason for revert: crbug.com/894728 . The plan is to not revert this
on master, since we'll probably roll past the regression. As it
stands, this is the 'final' profile for m71, though, and a 9%
speedometer regression isn't acceptable when yesterday's profile
appears just fine. :)
Original change's description:
> Roll AFDO from 71.0.3576.0_rc-r1 to 71.0.3577.0_rc-r1
>
> This CL may cause a small binary size increase, roughly proportional
> to how long it's been since our last AFDO profile roll. For larger
> increases (around or exceeding 100KB), please file a bug against
> [email protected]. Additional context: https://crbug.com/805539
>
> Please note that, despite rolling to chrome/android, this profile is
> used for both Linux and Android.
>
> The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> [email protected]
>
> Change-Id: Ic2facf850ac74d8087cc599ce0a9a7351b330ce3
> Reviewed-on: https://chromium-review.googlesource.com/c/1275868
> Reviewed-by: chromium-autoroll <[email protected]>
> Commit-Queue: chromium-autoroll <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#598701}
Bug: 894728
Change-Id: I03686edca0cda64e161a32ea5a21ba84ea993eaa
Reviewed-on: https://chromium-review.googlesource.com/c/1279231
Reviewed-by: George Burgess <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#34}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS OOBE: Change Update screen illustration.
[email protected]
(cherry picked from commit bd35effdb85b3df315a8e3f7eeb02d591af5241e)
Bug: 894268
Change-Id: I8e31bb4dfeb294b3893fd1df800f03420a5fd09b
Reviewed-on: https://chromium-review.googlesource.com/c/1278058
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599431}
Reviewed-on: https://chromium-review.googlesource.com/c/1282447
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#33}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.9
[email protected]
Change-Id: I113db5c1f4d9c63d9ecdd5e208f0aad0d4720162
Reviewed-on: https://chromium-review.googlesource.com/c/1282284
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#32}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71 Merge] Properly filter out transient Crostini windows from the shelf
Transient Crostini windows are supposed to be filtered from the shelf,
but we are checking for a transient parent on window Init, which is
before it actually gets set. This was causing a UAF on profile switching
as MultiUserWindowManagerChromeOS::SetWindowOwner() is not supposed to
be called with transient windows.
Bug: 845843
Change-Id: Iec7b48cb03fff22775c31ce08c398ba750836463
Reviewed-on: https://chromium-review.googlesource.com/c/1266475
Commit-Queue: Timothy Loh <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599038}(cherry picked from commit bf10ece3f79ead0ff1d488ae3b61fbc559e6f3c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1282083
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#31}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib7a1b57578d95348d17771d629e4cbabbf022c93
Reviewed-on: https://chromium-review.googlesource.com/c/1282108
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#30}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add Android Messages usage info in notifications settings.
This CL adds a special note under messages for android entry
in notification permissions to indicate usage in ChromeOS multidevice
features. This note will be displayed whenever the messages
sync feature is enabled. Please refer screenshot:
https://screenshot.googleplex.com/VnGZ1qApzHk.png
Bug: 845706
Change-Id: Ibcbe706cf9c579d980e4440825b8bc70b64466df
Reviewed-on: https://chromium-review.googlesource.com/c/1260503
Commit-Queue: Azeem Arshad <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599078}(cherry picked from commit b9d0776816b987172184af69d6de4a09def7dca6)
Reviewed-on: https://chromium-review.googlesource.com/c/1281911
Cr-Commit-Position: refs/branch-heads/3578@{#29}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Android: Ensure single TabWebContentsObserver per Tab
TabWebContentsObserver is TabWebContentsUserData which is created
for the first active WebContents for a given Tab, and finally
destroyed together with the Tab. There was a bug creating
multiple instances of the observer for every new active WebContents.
This left an instance for old WebContents undestroyed, and caused
a reported bug for already nulled out WebContents references
while handling an event that should not have been triggered.
This CL makes sure there will be a single TabWebContentsObserver
for Tab.
[email protected]
Bug: 894353
Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312
Reviewed-on: https://chromium-review.googlesource.com/c/1278426
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Jinsuk Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599109}(cherry picked from commit e0a45684f1cc9e125daed78cb74c7939415ebadc)
Reviewed-on: https://chromium-review.googlesource.com/c/1282082
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#28}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If040f9fe1c2d5001480fd53b3960a34da2f2fbf4
Reviewed-on: https://chromium-review.googlesource.com/c/1281343
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#27}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Chrome OS: allow scrolling on the Error screen.
[email protected]
(cherry picked from commit e33d6c078151a3157ff8affdb6dddd1d493f4c81)
Bug: 895000
Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59
Reviewed-on: https://chromium-review.googlesource.com/c/1279385
Commit-Queue: Alexander Alekseev <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599470}
Reviewed-on: https://chromium-review.googlesource.com/c/1281173
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#26}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Revert webrtc unpinning."
This reverts commit ffea867e22a9c0a65b595257a5d061667255b3a8.
Reason for revert: The WebRTC M71 branch has been fixed, so re-pin to it. Tested OK locally syncing deps and building with this revert. Here's the fixed WebRTC M71 branch: https://webrtc.googlesource.com/src/+log/branch-heads/71
Original change's description:
> Revert webrtc unpinning.
>
> Speculative fix that the webrtc m71 branch is out-of-sync with src.git
> and the cause of build failures.
>
> R=[email protected], [email protected]
>
> Bug: 895012
> Change-Id: Ibd19f2371b6eda5d915ce4ebf9ba377e507ff0c6
> Reviewed-on: https://chromium-review.googlesource.com/c/1279345
> Reviewed-by: Krishna Govind <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3578@{#6}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 895012
Change-Id: I4fe1be11eb845e36f752d05687bb7acf7af2b267
Reviewed-on: https://chromium-review.googlesource.com/c/1280666
Reviewed-by: Michael Moss <[email protected]>
Reviewed-by: Tommi <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#25}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[merge to 71] applist: Add fling to home launcher swipe to show/hide.
We can now fling to show or hide launcher. Uses same threshold as in
app list view. Also change app list show/hide from a shelf button to use
longer animation, to match ux spec.
[email protected]
(cherry picked from commit 31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76)
Test: ash_unittests HomeLauncherGestureHandlerTest.Fling*
Bug: 888617
Change-Id: I73de8ad6fdeace7f9ef34124eb2e5741e92b3371
Reviewed-on: https://chromium-review.googlesource.com/c/1279296
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599484}
Reviewed-on: https://chromium-review.googlesource.com/c/1280554
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#24}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Explore sites]: Add more horizontal spacing to tiles.
Bug: 894927,867488
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Cathy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599339}(cherry picked from commit 3eb4d6ca0ac677ba2dff5ae0670f79c2c4e7728f)
Reviewed-on: https://chromium-review.googlesource.com/c/1281048
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#23}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen.
Links can't be opened like they usually would be in OOBE, because there's no
browser to open them in. This CL creates a webview modal which is displayed
when the user clicks on one of the two "Learn More" links in the MultiDevice
OOBE screen, and loads it with the appropriate URL.
Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png
Bug: 893349
Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127
Reviewed-on: https://chromium-review.googlesource.com/c/1275296
Commit-Queue: Ryan Hansberry <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599084}(cherry picked from commit cfebc9e310c9fd4494d0944b3133745224aa01f9)
Reviewed-on: https://chromium-review.googlesource.com/c/1280846
Reviewed-by: Ryan Hansberry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#22}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Fling bubbles from OOPIF properly."
This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516
Sample Failed Step: content_browsertests
Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF
Original change's description:
> Fling bubbles from OOPIF properly.
>
> While we are bubbling a scroll sequence GFS is sent to the fling controllers
> of both the oopif and the bubbling target. The fling controller of the oopif
> calls progressFling and generates a GSU with inertial phase, the GSU gets acked
> immediately before getting sent to the renderer since we are in bubbling mode.
> Then the oopif's fling controller receives the unconsumed GSU ack and generates
> a GSE to complete the scrolling sequence on the oopif. The bubbling target's
> fling controller receives and processes the GFS and generates GSUs which are
> sent to the target's renderer.
>
> If the GSE generated by the oopif's fling controller gets bubbled before
> the GFS, the bubbling target gets reset and the target does not receive the
> GFS. This cl fixes the issue by making sure that the events generated by the
> oopif's fling controller are not bubbled to the target. Also in case of
> GFS bubbling, the GFC should also get sent to the bubbling target to make
> sure that the fling controller in charge of flinging receives the GFC.
>
>
> Bug: 884728, 249063
> Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
> Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0
> Reviewed-on: https://chromium-review.googlesource.com/c/1274193
> Reviewed-by: Kevin McNee <[email protected]>
> Reviewed-by: Charlie Reis <[email protected]>
> Commit-Queue: Charlie Reis <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#599001}
Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884728, 249063, 894703
Reviewed-on: https://chromium-review.googlesource.com/c/1278536
Cr-Original-Commit-Position: refs/heads/master@{#599094}(cherry picked from commit bb03212f2a4bd93f4f87da036a5f9eaeb2256466)
Reviewed-on: https://chromium-review.googlesource.com/c/1280621
Reviewed-by: Sahel Sharify <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#21}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix radio button bug on sync_page.html
The second radio button in the passphrase section
was not visibly checked on selection.
To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.
Additional change:
- Remove aria-label attribute because the visible text
is used automatically as radio button title.
Bug: 894385
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Thomas Tangl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599157}(cherry picked from commit 9b00f3499c1dc74c8e0419384a69f041ebcd2442)
Reviewed-on: https://chromium-review.googlesource.com/c/1280547
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#20}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[aw] Add callback to proxy override methods
Add an optional callback to proxy override methods introduced in change
https://chromium-review.googlesource.com/c/chromium/src/+/1148384
This adds an optional callback developers can use to know when the
changes have been made to the network settings, since the methods are
not synchronous with the UI thread.
Bug: 851995
Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
Reviewed-on: https://chromium-review.googlesource.com/c/1258770
Commit-Queue: Laís Minchillo <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599166}(cherry picked from commit e2dd9b16afe9c2808aaa11566aa54fa854282db2)
Reviewed-on: https://chromium-review.googlesource.com/c/1280604
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#19}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove chrome://flags/#enable-ephemeral-flash-permission.
Bug: 892156
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599317}(cherry picked from commit 6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1280263
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#18}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown
[email protected], [email protected], [email protected]
(cherry picked from commit 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13)
Bug: 894752, 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908
Reviewed-by: Tatiana Gornak <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Tatiana Gornak <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599206}
Reviewed-on: https://chromium-review.googlesource.com/c/1280202
Cr-Commit-Position: refs/branch-heads/3578@{#17}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Feed] Wire the logging report with the logging bridge
Wired most of the UMA logging, there are two methods in the bridge not
connected since it is new UMA, will do in next CL.
Bug: 831641
Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e
Reviewed-on: https://chromium-review.googlesource.com/c/1275130
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599089}(cherry picked from commit ab5a1ef3e0e0069c84adc62075ae09afbd612c78)
Reviewed-on: https://chromium-review.googlesource.com/c/1280122
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#16}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Update UI for unsupported Android OS and make Jelly Bean unsupported.
This CL updates the UI to show a badge icon in the app menu icon
whenever the user is running Chrome on a currently unsupported Android
version. This badge in the app menu is only displayed once, until the
user taps the app menu icon. If the user does in fact get a new version,
the badge state is reset, and will be shown again. The current behavior
for out of date users stays the same as before (once per cold start).
In addition, a new menu item is displayed at the top of the menu that
explains that Chrome is unable to update. Nothing happens when you tap
the menu item in the case of an unsupported OS version.
The new menu item and the new warning message in About Chrome will
always be displayed when the user is in this state, regardless of
whether the app menu has already been tapped (which removes the badge).
This CL also updates the UI in Settings - About Chrome to show a new
message and a warning icon when the user is running Chrome on an
unsupported version of the Android OS.
By default, Jelly Bean is considered unsupported after this CL, but this
can be overridden from the variations framework.
It is possible to use command line flags or chrome://flags for
testing the different states, though that does not impact the
About Chrome screen.
Binary-Size: This CL adds new assets and the minimal code required.
Bug: 847940
Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6
Reviewed-on: https://chromium-review.googlesource.com/c/1243167
Commit-Queue: Tommy Nyquist <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599369}(cherry picked from commit 5423fd8ab9355223e880007e08c1df4fcd3208fe)
Reviewed-on: https://chromium-review.googlesource.com/c/1279959
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#15}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
