Publish DEPS for 71.0.3578.27
Incrementing VERSION to 71.0.3578.27
[email protected]
Change-Id: I8c897b9c8265dfb47da6186d302e1d0f43636d34
Reviewed-on: https://chromium-review.googlesource.com/c/1303885
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#361}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Use SurfaceLayer in kOnDemand mode if player starts in PIP.
When the SurfaceLayerMode is kOndemand, WMPI would wait until
entering PIP before switching to SurfaceLayer. However, it
missed the case where it started in PIP mode from a previous player.
This CL adds a check to see if the client is already in PIP mode,
and switches to SurfaceLayer immediately if so.
Bug: 891619
Change-Id: If1d75982ebcfb3c633814fd8247470a8a595c3ef
Reviewed-on: https://chromium-review.googlesource.com/c/1300093
Reviewed-by: Fredrik Hubinette <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602883}(cherry picked from commit 702d721db7ac886392fb32774292c56cfe8d10fe)
Reviewed-on: https://chromium-review.googlesource.com/c/1303913
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#360}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.26
[email protected]
Change-Id: I5c9ab570a5b8deba10a6d9dc232f1f6ef3188464
Reviewed-on: https://chromium-review.googlesource.com/c/1303876
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#359}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Always show mediastream video if Picture-in-Picture
This CL makes sure that a mediastream video always get painted if it is
in Picture-in-Picture.
Bug: 893062
Change-Id: I0bf5fbe744a98155135dcade83e6ba7646d2f6b3
Reviewed-on: https://chromium-review.googlesource.com/c/1299003
Commit-Queue: François Beaufort <[email protected]>
Reviewed-by: Emircan Uysaler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602865}(cherry picked from commit 0c7cd64aec528b8355ed040fe502ffc8c7dee33c)
Reviewed-on: https://chromium-review.googlesource.com/c/1303335
Reviewed-by: François Beaufort <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#358}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.25
[email protected]
Change-Id: I6ac8a3f140a5e4f69215d1eeceaf20437cb4e9b5
Reviewed-on: https://chromium-review.googlesource.com/c/1303557
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#357}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add UMA collection to Previews Omnibox UI
Adds a new histogram "Previews.OmniboxAction" with suffixes for each
previews type. Enum buckets are the different actions that can take
place.
Bug: 896921
Change-Id: I2578a297247ad9ac75a7b14c07dbdf053c7eb048
Reviewed-on: https://chromium-review.googlesource.com/c/1289959
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Megan Jablonski <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602582}(cherry picked from commit 2a9a6167fc9a70a2b3b1fa736d53de74250cbb0c)
Reviewed-on: https://chromium-review.googlesource.com/c/1302855
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#356}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Clear previews_freshness_ on new navigations
This ensures that an old previews_freshness_ won't be shown on the
wrong page.
Bug: 898570
Change-Id: I19cb1ab9916eae9b80fb4ca8d260cd18ebd66a97
Reviewed-on: https://chromium-review.googlesource.com/c/1298245
Reviewed-by: Doug Arnett <[email protected]>
Commit-Queue: Robert Ogden <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602528}(cherry picked from commit 581a8b2ca2e36c1a7b7b9df884474cbaa14a2b05)
Reviewed-on: https://chromium-review.googlesource.com/c/1302700
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#355}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[reland] Allow loading SwiftShader after sandbox init on Mac
We could blacklist WebGL based on GL version, which is after creating a context.
Right now this will trigger a failure and GPU process will exit and then
relaunch with SwiftShader mode, which pre-load SwiftShader before sandbox init.
So users will not notice, but this GPU process exit and relaunch is less optimal
and unnecessary.
BUG=897914
TEST=manual
[email protected]
[email protected],[email protected],[email protected]
(cherry picked from commit cc960d8aaa22026ba9684de674b99e73c09be387)
Change-Id: I94cb687f9c4484084f27c78ed7fb16b123593579
Reviewed-on: https://chromium-review.googlesource.com/c/1298481
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602556}
Reviewed-on: https://chromium-review.googlesource.com/c/1303049
Cr-Commit-Position: refs/branch-heads/3578@{#354}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Always notify MRUIBase when a route is created
When a route is created, MRUIBase should get notified to reset
|current_route_request_|. This was previously not done for presentation
routes with the assumption the dialog gets closed immediately, which
isn't true for the Views dialog yet. So this CL makes MRUIBase always
get notified.
Bug: 898569
Change-Id: I6254fd6179ab791963f542a908ec905ac87150cc
Reviewed-on: https://chromium-review.googlesource.com/c/1298426
Reviewed-by: Brandon Tolsch <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602614}(cherry picked from commit 5f6e1f270909b1dc20234f572ece2496e0dcaec8)
Reviewed-on: https://chromium-review.googlesource.com/c/1302868
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#353}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Set cancel callback in CastRemotingConnector only if the dialog is open
Set a callback to close the remoting permission dialog only if the dialog
was actually opened. This prevents an unintended early exit from
StopRemoting() that results in remoting not actually getting stopped.
Bug: 890856,898616
Change-Id: I487559fafe921fcc42205b6aa2b7ca887d517559
Reviewed-on: https://chromium-review.googlesource.com/c/1298189
Reviewed-by: Yuri Wiitala <[email protected]>
Commit-Queue: Yuri Wiitala <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602586}(cherry picked from commit c2ca1bc1f6cf9a6ecdcb38c9d682d23fbb8cb2e9)
Reviewed-on: https://chromium-review.googlesource.com/c/1302956
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#352}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove duplicate jsoncpp from OpenVR
OpenVR by default includes its own jsoncpp. However, we have one
in third_party already, so we don't need OpenVR's copy.
BUG=780987,790814,896087
Change-Id: Iac57998856ac72b36b6b731b3860ca67ae7c3f45
Reviewed-on: https://chromium-review.googlesource.com/c/1294669
Reviewed-by: Klaus Weidner <[email protected]>
Commit-Queue: Bill Orr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602033}(cherry picked from commit 2f969bff5532233afff5564f947b453b5dac6be6)
Reviewed-on: https://chromium-review.googlesource.com/c/1302859
Reviewed-by: Bill Orr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#351}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[m 71]Set the correct pixel size on RecordPaintCanvas for CanvasImageSource
When initializing a RecordPaintCanvas, the size set should be in pixels.
Right now we are setting the DIP size which is resulting in PaintOps
that are outside the clip bounds to be rejected all together.
This patch also adds a DCHECK to ensure that the clip bounds set on the
canvas matches the expected pixel size of the rasterized image.
Bug: 896203
Change-Id: I10cf95bc656950c217d3ae464f277a0cb7140063
Component: CanvasImageSource
Reviewed-on: https://chromium-review.googlesource.com/c/1296687
Commit-Queue: Malay Keshav <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602477}(cherry picked from commit 4b414bd7617c09120faf6371c481e083eedcbef2)
Reviewed-on: https://chromium-review.googlesource.com/c/1302953
Reviewed-by: Malay Keshav <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#350}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Make CORB exceptions for plugins resilient to NetworkService crashes.
[email protected]
(cherry picked from commit ce4487b7a0d0ef150b5edea19f2db53668dd7d0f)
Bug: 891904, 891891
Change-Id: I1e05b2527ff7f2e2c452525fa3a460dedc96e9f5
Reviewed-on: https://chromium-review.googlesource.com/c/1263555
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602020}
Reviewed-on: https://chromium-review.googlesource.com/c/1302658
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#349}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge M71: Removes unnecessary layers to improve FPS in launcher
Bug: 897892
Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b
Reviewed-on: https://chromium-review.googlesource.com/c/1292891
Commit-Queue: Kevin Strohbehn <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602143}(cherry picked from commit 7544927ece4358db0c3600dc9147a5a683cf3a87)
Reviewed-on: https://chromium-review.googlesource.com/c/1299960
Cr-Commit-Position: refs/branch-heads/3578@{#348}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[MERGE] macviews: fix menu closure when click hits a parent menu
This change:
1) Has MenuController reset the closure animation once ::Cancel runs, since it
is legal for the MenuController to remain alive after ::Cancel (in fact this
is how submenus work);
2) Has the menu closure animation in ::RepostEventAndCancel() target the active
submenu instead of the root submenu when closing the outermost menu.
into invisibility but in fact only the outermost one is really dismissed,
leaving the other menu windows with invisible mouse capture.
Bug: 893085,897045
Change-Id: I839710cc525856b14bd3995707ab253cb3258f5f
Reviewed-on: https://chromium-review.googlesource.com/c/1293792
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601696}(cherry picked from commit edbe0951624f7920397dd7fd0d77cc76781842c4)
Reviewed-on: https://chromium-review.googlesource.com/c/1302107
Cr-Commit-Position: refs/branch-heads/3578@{#347}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge M71: Check for null loadUrlParams
[email protected]
(cherry picked from commit b631428297f40748fd0e12e258bbb776e19ab852)
Bug: 897670
Change-Id: Ib5f7892332b8f6129fd9e5822aef096574856dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1294834
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601751}
Reviewed-on: https://chromium-review.googlesource.com/c/1302106
Reviewed-by: Jian Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#346}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Update Document Style and Layout beforing getting style's filter quality
Bug: 888458
Change-Id: Ib17eff8795d8daaa2e67f3c478f71079a52b9d5a
Reviewed-on: https://chromium-review.googlesource.com/c/1283488
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Fernando Serboncini <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602398}(cherry picked from commit 371eb5a301557fbbe2edcccad9ba7d4796c7d89b)
Reviewed-on: https://chromium-review.googlesource.com/c/1301836
Reviewed-by: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#345}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[signin] Add refresh token events to signin-internals page
This CL adds information about token events in the chrome://signin-internals
page. This is needed to allow developers to debug issues when the Google
auth state if changed by the browser (either due to Mirror or Dice).
A follow-up CL will add the source for the refresh token events.
Bug: 896182
Change-Id: Ie70e3e647947aa771572ed47992e2d0c59bea361
Reviewed-on: https://chromium-review.googlesource.com/c/1286460
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601129}(cherry picked from commit 21a49480e295d2a0ffce148498c1dc46d8d91f14)
Reviewed-on: https://chromium-review.googlesource.com/c/1301519
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#344}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Check frame existence before using it in AutofillAgent
Bug: 897341
Change-Id: I311db2e8f685bae5aa2b218750ddaf6b7a4c02f0
Reviewed-on: https://chromium-review.googlesource.com/c/1296170
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Olivier Robin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602283}(cherry picked from commit 8172a9170b2a622b05a66e89f2d2818133f24d6d)
Reviewed-on: https://chromium-review.googlesource.com/c/1301438
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#343}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[iOS] Change preferred content size category check on iOS 10
This CL changes the way the util is checking for the "accessibility"
categories on iOS 10.
Developed directly on branch as support for iOS 10 is dropped on master.
Bug: 895804
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icb2554bf8d900d36b7598ee4596e152c54eee082
Reviewed-on: https://chromium-review.googlesource.com/c/1297416
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#342}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Unified: Round corners of inline settings."
This reverts commit 446e74224f0d0a799a4db71588650808945873d0.
Reason for revert: regression for popups https://crbug.com/898094
Original change's description:
> Unified: Round corners of inline settings.
>
> In UnifiedSystemTray, a notification can have different radii for the
> top and the bottom corners. This CL applies custom mask to ink drop of
> NotificationViewMD so that these corners are properly painted even in
> inline settings.
>
> TEST=manual
> BUG=878772
>
> Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584
> Reviewed-on: https://chromium-review.googlesource.com/c/1195258
> Reviewed-by: Yoshiki Iguchi <[email protected]>
> Commit-Queue: Tetsui Ohkubo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#598609}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 878772,898094
Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5
Reviewed-on: https://chromium-review.googlesource.com/c/1298529
Reviewed-by: Tetsui Ohkubo <[email protected]>
Commit-Queue: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602642}(cherry picked from commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b)
Reviewed-on: https://chromium-review.googlesource.com/c/1300816
Cr-Commit-Position: refs/branch-heads/3578@{#341}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Ash: Show managed icon only when in public session mode.
The managed device icon in the system tray should only be shown while
in the public session mode, unlike the "managed" indicator shown in the
unified system tray bubble.
Bug: 895718
Test: manually tested with public session on an enrolled device
Change-Id: Ic86be2a42e5d3a0be89cf5eb6c80aab14bec0f32
Reviewed-on: https://chromium-review.googlesource.com/c/1288093
Commit-Queue: Tatsuhisa Yamaguchi <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601845}(cherry picked from commit 81202dfd67e345928943f7bf52a83e7a85308776)
Reviewed-on: https://chromium-review.googlesource.com/c/1298093
Reviewed-by: Tatsuhisa Yamaguchi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#340}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix text input on ARC++ Kiosk apps.
We changed IsInArcAppWindow() to use the window property,
aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window.
It makes text input on ARC++ Kiosk apps stop working.
This CL adds a temporary workaround for this situation. Ideally,
IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app
correctly.
Bug: 891825
Test: Can type text on Wikipedia kiosk app.
Change-Id: I594aa5c0730704b9ad922441187297bd707de20a
Reviewed-on: https://chromium-review.googlesource.com/c/1291289
Commit-Queue: Yusuke Sato <[email protected]>
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2)
Reviewed-on: https://chromium-review.googlesource.com/c/1300813
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#339}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.24
[email protected]
Change-Id: I7a535ec10918923ae56504ddd91fc20f182a1eaf
Reviewed-on: https://chromium-review.googlesource.com/c/1300776
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#338}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Turn off WKHTTPSystemCookieStore for M71
This cl is to be merged to M71
Change-Id: Ic2d3ab3afd52217f1dc06ca15bc67cfdb920f42d
Reviewed-on: https://chromium-review.googlesource.com/c/1299734
Commit-Queue: Mohammad Refaat <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602884}(cherry picked from commit 6e1c2a39da3f8d7e08ab1683f71b22db27856ead)
Reviewed-on: https://chromium-review.googlesource.com/c/1300216
Cr-Commit-Position: refs/branch-heads/3578@{#337}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Work around reversed word range in DocumentMarkerController::FirstMarkerAroundPosition
There are some crashes in the function due to legacy implemetation of
StartOfWord() creating invalid/legacy positions, which lead to reversed
word ranges.
This patch adds handling of reversed word ranges so that we don't crash,
before switching StartOfWord() to proper implementation.
Bug: 886589
Change-Id: I8ad988247c6e4ab4a4a7cf90675d7df5f326f56f
Reviewed-on: https://chromium-review.googlesource.com/c/1298018
Reviewed-by: Nektarios Paisios <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602474}(cherry picked from commit f791c69656cc2bf00fda9e0209235f888d708966)
Reviewed-on: https://chromium-review.googlesource.com/c/1300334
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#336}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix typo in Texture sampler state tracking for shared images
We need to track the texture's sampler state to correctly restore it
after changes (e.g. during copies).
The SharedImageBackingFactoryGLTexture code improperly set wrap_r
instead of wrap_t.
[email protected]
Bug: 892826
Change-Id: I5b95084e2039a221ce3ff6f599b5a2b0098c614b
Reviewed-on: https://chromium-review.googlesource.com/c/1297982
Commit-Queue: Jonathan Backer <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602683}
Reviewed-on: https://chromium-review.googlesource.com/c/1300095
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#335}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M-71] Fix browser permission bubble positioning
This CL fixes two issues regarding the browser
permission bubble dialogs:
- Switching in / out of tablet mode changes the
browser top controls size, and position. If a
permission bubble is shown, its position will
be broken.
- We should not allow top-chrome to hide while a
permission bubble is visible, not until the user
dismisses it.
[email protected], [email protected]
BUG=896970, 897227
TEST=Added new browser test.
Change-Id: I979fe067531811165b5443f6f28c922c74251e21
Reviewed-on: https://chromium-review.googlesource.com/c/1292720
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601971}(cherry picked from commit 47f2f5286b6e7a0d715bfb6cf563d26fefd5fe80)
Reviewed-on: https://chromium-review.googlesource.com/c/1299921
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#334}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Translate Manual Trigger] Made `prepareTranslateMenuItem` inline.
Bug: 883456
Change-Id: I990f680aeb7cb7c18571abc63c09573bcc6f3b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1297486
Commit-Queue: Alexandre Frechette <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602414}(cherry picked from commit 41f25f6609915ad5eafc1532a81d2f7368ea38fc)
Reviewed-on: https://chromium-review.googlesource.com/c/1299663
Reviewed-by: anthonyvd <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#333}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Translate Manual Trigger] Add metrics tracking interaction with manual translate.
Bug: 883456
Change-Id: I48aab1bb09fe5527cc6ad07a9c3ccadc87224055
Reviewed-on: https://chromium-review.googlesource.com/c/1291784
Commit-Queue: Alexandre Frechette <[email protected]>
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602145}(cherry picked from commit 620aa393765f737ff0dae2bd7d8bf8f9b907b201)
Reviewed-on: https://chromium-review.googlesource.com/c/1299662
Reviewed-by: anthonyvd <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#332}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Translate Manual Trigger] Added logic to check for manual translation availability and to (manually) initiate a translation.
Change-Id: I2fdd9832a72fa1700190d4f7ee93365f29579b32
Bug: 883456
Reviewed-on: https://chromium-review.googlesource.com/c/1281086
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Michael Martis <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Alexandre Frechette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601970}(cherry picked from commit 703b0c073a87b387efb0e7f095a6cbf1a2f56adf)
Reviewed-on: https://chromium-review.googlesource.com/c/1299661
Reviewed-by: anthonyvd <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#331}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Print Preview: Fix duplex defaults (M71)
Check the internals of the duplex capability, instead of only checking
for its existence, to determine whether to display the duplex checkbox.
Pull default value from the printer if it is available.
Currently a speculative fix, as have not been able to identify a
printer which sets the duplex capability field but does not actually
support duplex.
Bug: 896244
Change-Id: Iebafc3878a1e7658b821465439ee172c479ce413
Reviewed-on: https://chromium-review.googlesource.com/c/1290145
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601790}(cherry picked from commit b0f2b8367cee08dee6f6f7c62c56c7e462877ca1)
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/1299783
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#330}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[AF] Log if in iframe for Autofill.FormEvents.Address/CreditCard histograms
Bug: 881364
Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210
Reviewed-on: https://chromium-review.googlesource.com/c/1277575
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599813}(cherry picked from commit 5adf72795f09b91efa82732add8df0c8e519daf4)
Reviewed-on: https://chromium-review.googlesource.com/c/1299779
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#329}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] Fix the issue that whiskers keyboard is disabled incorrectly.
Refactoring of the internal input events blocker in
TabletModeController.
The input events should only be blocked if 1) we're currently in tablet
mode or 2) we're currently in clamshell mode but the lid is flipped over,
i.e., we are in laptop mode because of an attached external mouse.
Bug: b/118049922, 887042
Test: Newly added test and existing tests passed.
Also manually tested on convertible/clamshell/tablet devices
[email protected]
(cherry picked from commit 20a76ff5b7298d2e97f9dcb9faee7915677dda57)
Change-Id: I93d963cfab2ae14bd1cad19675f0ed4fed88c1b0
Reviewed-on: https://chromium-review.googlesource.com/c/1297577
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602370}
Reviewed-on: https://chromium-review.googlesource.com/c/1299777
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#328}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Handle input size error codes when evaluating key handles
Some security keys will respond with the length of the key handle
as an error response instead of an ISO7816 error code. Handle
these errors by treating them as an invalid length error so
further key handles can still be evaluated.
Bug: 898008
Change-Id: I9d604c2012b7eb452e6476e8ced38e51ebd316d4
Reviewed-on: https://chromium-review.googlesource.com/c/1296050
Commit-Queue: Casey Piper <[email protected]>
Reviewed-by: Kim Paulhamus <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602039}(cherry picked from commit 9a9f7aa17fcb035f167bd5385ca70575be043fa4)
Reviewed-on: https://chromium-review.googlesource.com/c/1299775
Reviewed-by: Jun Choi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#327}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Skip downloading by using a flag in ResourceResponse
When NetworkService/ServiceWorkerServicification is on, MimeSniffingThrottle is
used for responses from service workers. Previously, downloading is skipped when
any of throttles handle the response, so using MimeSniffingThrottle undesirably
prevented downloading. This CL is to make downloading work properly when a
service worker serves the response.
Also, when a response is NOT served from ResourceDispatcherHost,
DownloadManagerImpl needs to be created in NavigationRequest. Currently it
happens only when NetworkService is on. This CL adds a condition where S13nSW is
on and a service worker serves the response there.
[email protected]
Bug: 896696
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I222d8148cf65d15492393ebcd6ed582deb14022f
Reviewed-on: https://chromium-review.googlesource.com/c/1290434
Commit-Queue: Makoto Shimazu <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601901}(cherry picked from commit 0885b0f00f3e198e81a9a00ad8363ea48aa4d355)
Reviewed-on: https://chromium-review.googlesource.com/c/1299773
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#326}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Moved the title of migration bubble from body to title container.
Bug: 898662
Change-Id: I39e0595288a4d9441fc2452b2d47b4f430a4d0cb
Reviewed-on: https://chromium-review.googlesource.com/c/1298083
Commit-Queue: Siyu An <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602527}(cherry picked from commit b1405602455dfaeab4b96ef56836fe5d7525a7b5)
Reviewed-on: https://chromium-review.googlesource.com/c/1299542
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#325}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Update the local card migration bubble upon privacy request (F Option)
Changed the title, and added a body text.
Uploaded a screenshot in the bug. Note that the body text color is
incorrect (should be Google Grey 700) due to crbug.com/896891.
Bug: 898662
Change-Id: I5bf1cf07c6c86bb5a985811485edcb61d14d2610
Reviewed-on: https://chromium-review.googlesource.com/c/1294722
Reviewed-by: Bret Sepulveda <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602451}(cherry picked from commit 573604e22396782df6023dad6ff386a98d2bdf97)
Reviewed-on: https://chromium-review.googlesource.com/c/1299541
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#324}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Canvas LowLatency: wire lowLatency in getContextAttributes()
This CL wires |lowLatency| in WebGL's getContextAttributes(),
and adds LayoutTests entries wherever appropriate.
Also cleans up the {} in canvas_rendering_context.cc (adds or
removes them where appropriate).
Bug: 895918
Change-Id: I08872f45cbadbf0772c92a761dee15243bd4f17a
Reviewed-on: https://chromium-review.googlesource.com/c/1294301
Reviewed-by: Kai Ninomiya <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601943}(cherry picked from commit 9e9987d9eb2925d5454685a7374455d5aebae9a7)
Reviewed-on: https://chromium-review.googlesource.com/c/1299438
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#323}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Canvas LowLatency: make getContext() idempotent
Canvas.getContext() method is idempotent, i.e. successive calls return
the same context over and over. When the context is lowLatency, however,
we think it's an OffscreenCanvas context and fail. This CL fixes
that and adds a LayoutTest to verify the new functionality.
Bug: 895551
Change-Id: I1ae140080915a277eb45ac01486e6c7c1464aefa
Reviewed-on: https://chromium-review.googlesource.com/c/1294090
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601652}(cherry picked from commit f352608ae26967ef5adc15397f451652aabc2a3a)
Reviewed-on: https://chromium-review.googlesource.com/c/1299437
Reviewed-by: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#322}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove checkbox if migration dialog has only one card
And also remove card index since we are not using index
for checkbox status update.
Bug: 898596
Change-Id: I60513831b0392c469d62dfd45a15719670662272
Reviewed-on: https://chromium-review.googlesource.com/c/1287434
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602144}(cherry picked from commit a68a330f7c1a210c5277219d63fd55074163afd2)
Reviewed-on: https://chromium-review.googlesource.com/c/1299538
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#321}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove CORS scheme check temporarily
The scheme check added at
https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c caused some
issues on WebView. This change deletes the check temporarily.
[email protected]
(cherry picked from commit 14314b070e1e92dcae7fe4ccfa4531c6a128060e)
Bug: 898589
Change-Id: I6126b3b25f8700fc0547fa2c70b62bd183cc5e23
Reviewed-on: https://chromium-review.googlesource.com/c/1298828
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602736}
Reviewed-on: https://chromium-review.googlesource.com/c/1299436
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#320}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reduce scale size of HTS tab switcher tab
This patch reduces the size of a tab in the horizontal tab switcher to
90% of its previous size. The goal of this change is to make tabs on
each side more 'tappable'.
[email protected]
(cherry picked from commit 75670c658e16694a6fe845e0d32268e8c17efff5)
Bug: 880610
Change-Id: Ia0092aa5739f7ed11518eb5d0129dcfdf9e2cf9e
Reviewed-on: https://chromium-review.googlesource.com/c/1286752
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600567}
Reviewed-on: https://chromium-review.googlesource.com/c/1299340
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#319}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Don't clip the fullscreen/maximized window
Overlay doesn't work if the window is clipped. This removes
the clipping if the window is fullscreen/maximzied.
This is short term fix for m71. I'll investigate
if we can remove this in m73.
Bug: b/117679678
Test: covered by unittest
Change-Id: I39d79461a42d86e2e9e5f9f282b6c8f391daf3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1297151
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Malay Keshav <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602038}(cherry picked from commit b83d06cf340a0867ef039038f7edb407c9debb0d)
Reviewed-on: https://chromium-review.googlesource.com/c/1299204
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#318}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[AF] Make wallet controllers for USS/Directory consistent
This CL makes the old Directory controller react to the toggle in
Payments methods as well.
Bug: 898141
Change-Id: I09918c9aace663376f7beb0ed0cd5f2ef3854b0e
Reviewed-on: https://chromium-review.googlesource.com/c/1296598
Commit-Queue: Jan Krcal <[email protected]>
Reviewed-by: Florian Uunk <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602272}(cherry picked from commit 45399d3227c76eec24f57e98c2dfcdeb8378f12a)
Reviewed-on: https://chromium-review.googlesource.com/c/1299158
Cr-Commit-Position: refs/branch-heads/3578@{#317}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Add UKM audibility timer in AudioContextManagerImpl
This CL implements the audibility timer for multiple AudioContexts
in AudioContextManagerImpl. The "started" event triggers the
tracking and the "stopped" event triggers the calculation of
elapsed time followed by UKM data record.
Bug: 896944
Change-Id: Id1f635df4783247aca3656d07c02af907ffd72e4
Reviewed-on: https://chromium-review.googlesource.com/c/1289695
Commit-Queue: Mounir Lamouri <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601446}(cherry picked from commit 2d95973e289887c5cf6082544adf72af309e230d)
Reviewed-on: https://chromium-review.googlesource.com/c/1298999
Cr-Commit-Position: refs/branch-heads/3578@{#316}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Background Fetch] Fix match() crash.
Calling `match` was causing crashes in debug mode due to accessing
base::Optional<>::value without initialization. Calling match with
an unmatched request was crashing due to hitting a DCHECK. This returns
undefined now as per the spec.
(cherry picked from commit 2fa238e3ac6f79fe0e11c8a1065fed41b4ac4a1e)
Bug: 896768
Change-Id: I5d82e68ddca157a240ceaaec8990d2553366fbbb
Reviewed-on: https://chromium-review.googlesource.com/c/1289269
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601541}
Reviewed-on: https://chromium-review.googlesource.com/c/1299153
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#315}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}CrOS shelf: use translation for auto-hide instead of altering size
[email protected]
(cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e)
Bug: 891416,886622,888205,887733,881684,822477
Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4
Reviewed-on: https://chromium-review.googlesource.com/c/1290056
Commit-Queue: Manu Cornet <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602201}
Reviewed-on: https://chromium-review.googlesource.com/c/1298945
Reviewed-by: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#314}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Fix broken states in WebRTC text logging.
* Removes the log state CHANNEL_CLOSING, which is actually not a log state.
* Adds channel_is_closing_ flag instead.
This way, it's possible to check in WebRtcLoggingHandlerHost::StoreLogInDirectory and WebRtcLoggingHandlerHost::DoUploadLogAndRtpDumps if the log is in closed state or not when channel is closing to avoid multiple upload/store attempts.
Multiple stores/uploads could happen if channel is closing and a store or upload operation has been issued around the same time.
Bug: 807547
Change-Id: I5e41d5a02095044582c06037d440d22a2edc0be2
Reviewed-on: https://chromium-review.googlesource.com/c/1296538
Reviewed-by: Tommi <[email protected]>
Commit-Queue: Henrik Grunell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602104}(cherry picked from commit 66f33f95303da57e20743c1b45f7fe08fcee4c96)
Reviewed-on: https://chromium-review.googlesource.com/c/1298953
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#313}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge to M71] NetworkCertLoader: Don't notify observers when shutting down
Avoid sending out updates to NetworkCertLoader's Observers when the
browser is being shut down.
[email protected]
(cherry picked from commit 68160a59d6a5aaf62bf6d8348358e9a9a1b618ac)
Bug: 894867
Test: chromeos_unittests --gtest_filter=*NetworkCertLoader*
Change-Id: Idff4a45f575c594c1c68ca1139ed0ab37f985acc
Reviewed-on: https://chromium-review.googlesource.com/c/1280424
Commit-Queue: Pavol Marko <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600307}
Reviewed-on: https://chromium-review.googlesource.com/c/1298714
Reviewed-by: Pavol Marko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#312}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland "Enable camera blob stream when needed"
This is reland of 10f4b93635e12f9fa0cba1641a10938ca38ed448.
It addressed the issue in capture_unittests.
Original change's description:
> Since blob stream needs higher resolution, it causes higher cpu
loading
> to require higher resolution and resize to smaller resolution.
> In hangout app, we don't need blob stream. Enabling blob stream when
> needed can save a lot of cpu usage.
>
> BUG=b:114676133
> TEST=manually test in apprtc and CCA. make sure picture taking still
> works in CCA.
>
> Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c
> Reviewed-on: https://chromium-review.googlesource.com/c/1261242
> Commit-Queue: Heng-ruey Hsu <[email protected]>
> Reviewed-by: Ricky Liang <[email protected]>
> Reviewed-by: Xiaohan Wang <[email protected]>
> Reviewed-by: Robert Sesek <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#601492}
[email protected], [email protected], [email protected], [email protected]
BUG=b:114676133
TEST=run capture_unittests.
(cherry picked from commit 5490b51fa2daca93e1ae37426871262e62d1bdd6)
Change-Id: I977a4eade8d7f7ddc6188c4ce4a659d675e89d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1295753
Reviewed-by: Heng-ruey Hsu <[email protected]>
Reviewed-by: Ricky Liang <[email protected]>
Commit-Queue: Heng-ruey Hsu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601854}
Reviewed-on: https://chromium-review.googlesource.com/c/1297858
Cr-Commit-Position: refs/branch-heads/3578@{#311}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.23
[email protected]
Change-Id: Idbfd6d8bd2d35a308a9c77cb8dd22caa4d6c5bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1298556
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#310}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Updating XTBs based on .GRDs from branch 3578
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id1bcb15e66f05a9ef4135cd88d79a7f2a32751ca
Reviewed-on: https://chromium-review.googlesource.com/c/1298480
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#309}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Disable InputPane API for controlling on virtual keyboard on M71
We received many crash reports because we tried to access the COM
events when the input method class for windows is in the process of
been destructed. We will fix it in M72, so we need to disable the
InputPane on M70.
[email protected]
(cherry picked from commit 058c8d57e8b1d28ab2fb77605692472bec955a5c)
Bug: 873649
Change-Id: Ie8211b8241d887326dc111bf5ffe4085b866468c
Reviewed-on: https://chromium-review.googlesource.com/c/1281822
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Lan Wei <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601994}
Reviewed-on: https://chromium-review.googlesource.com/c/1298494
Reviewed-by: Lan Wei <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#308}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Offline pages : Fixed received_bytes for OfflineItem conversion
Fixed the received_bytes field for offline pages to OfflineItem conversion.
Also added all the missing fields to the conversion unit tests.
Bug: 897841
Change-Id: I823a84bc36a9d07c2f955f756c91412d22fa59ae
Reviewed-on: https://chromium-review.googlesource.com/c/1294404
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Carlos Knippschild <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602110}(cherry picked from commit 9b1829c578c6680cfedba88bcbffee23508a0249)
Reviewed-on: https://chromium-review.googlesource.com/c/1298084
Cr-Commit-Position: refs/branch-heads/3578@{#307}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Update Clear Tab home tile in-product help string for accessibility
BUG=898529
[email protected]
Change-Id: Iff27d791065c04700d379cf3d60b1210ac24d477
Reviewed-on: https://chromium-review.googlesource.com/c/1298453
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#306}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Drop reference to articles from Clear Tab IPH
Not all users have suggested articles, so for technical accuracy we're
dropping "and view suggested articles" from the clear tab in-product
help string.
BUG=898598
[email protected]
Change-Id: I75861c97cae32dd5a18007a0017815b4f0ab6e18
Reviewed-on: https://chromium-review.googlesource.com/c/1297287
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#305}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Proactively sync device metadata after API calls.
Any successful call to the SetSoftwareFeatureState() API function should
result in a change to the "enabled_features" field of the
ExternalDeviceInfo message returned by CryptAuth.
Indeed, once SetSoftwareFeatureState() completes, CryptAuth issues a GCM
tickle to all devices on the same GAIA account, telling each of these
devices that new data is available to sync. Unfortunately, GCM is flaky;
sometimes it takes a long time for the tickle to arrive to devices, and
sometimes the tickle does not arrive at all.
This resulted in bugs where users would attempt to change a feature's
state (e.g., when setting a phone as the multi-device host), the network
call would succeed, but no GCM tickle would arrive, resulting in clients
being stuck waiting for new device metadata to arrive.
This CL fixes that issue by proactively requesting a sync as soon as the
SetSoftwareFeatureState() completes.
Bug: 892349
Change-Id: I7d7bd610a4a997c398e0aecd1450b050fa1e9429
Reviewed-on: https://chromium-review.googlesource.com/c/1285692
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601998}(cherry picked from commit adedcd1dee83500692045e89f1e2e1360497111f)
Reviewed-on: https://chromium-review.googlesource.com/c/1298397
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#304}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Add Shutdown() handling in MultiDevice KeyedServices.
This ensures that connections to our Mojo services are disconnected,
which will result in the Shutdown() code added in this CL will run:
https://chromium-review.googlesource.com/c/chromium/src/+/1274886
Bug: 884066
Change-Id: Ifb4fad53fc9d1a693ae83099dc43ee9908303ea7
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/1277588
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Jeremy Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599080}(cherry picked from commit f49ce435169672969142e5da5303def870e7fd98)
Reviewed-on: https://chromium-review.googlesource.com/c/1298350
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#303}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Fixed a bug where full width images don't span full
Fixed a bug where images don't go beyond 300dp on phones even on portrait
which was introduced in CL :
https://chromium-review.googlesource.com/c/chromium/src/+/1282203
Bug: 898248
Change-Id: Ie749bfc3ebbbee8c861466d37c5742348591b90b
Reviewed-on: https://chromium-review.googlesource.com/c/1295870
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602016}(cherry picked from commit cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31)
Reviewed-on: https://chromium-review.googlesource.com/c/1298360
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#302}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Download Home : Fixed layout inflate crash
This CL fixes a crash for API 19 when inflating layout for in-progress items.
We remove the selectableItemBackground attribute from the XML which fixes
the issue. However, with this change, the pause/resume button doesn't
provide user feedback on tap. We most likely have to implement our
own selectable item background for this.
Bug: 896808
Change-Id: I0156802c862fd11357d6a5179c42e8977896b847
Reviewed-on: https://chromium-review.googlesource.com/c/1294728
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602021}(cherry picked from commit 27d7615e9fa1f0c610b3f4d7c13a844013f4c4be)
Reviewed-on: https://chromium-review.googlesource.com/c/1298396
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#301}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Make Smart Lock work with legacy hosts
Make SmartLock work after clients (chromebooks) update but before legacy
hosts (phones) update. The phone side flags and enrollment will be
slower than the ChromeOS rollout. In order to avoid breaking SmartLock
in the meantime, look for cases where:
1) There are no host devices reporting BETTER_TOGETHER_HOST support.
2) There is at least one host device reporting EASY_UNLOCK_HOST support.
In that case, the legacy SmartLock settings will be available in
chrome://settings/lockScreen, fully capable of enabling/disabling.
Bug: 895585
Change-Id: Iff0ebb46fac2a43f6af32b09182a621ca43b54fa
Reviewed-on: https://chromium-review.googlesource.com/c/1287045
Reviewed-by: Michael Giuffrida <[email protected]>
Reviewed-by: Ryan Hansberry <[email protected]>
Reviewed-by: James Hawkins <[email protected]>
Commit-Queue: Josh Nohle <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602025}(cherry picked from commit a1be702d178b1e35e430786f4fce23b621d2cc75)
Reviewed-on: https://chromium-review.googlesource.com/c/1298353
Cr-Commit-Position: refs/branch-heads/3578@{#300}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}DisableExtensions now uninstalls them
This is to remain consistent in how the Chrome Cleanup Tool removes other force installed extensions. They interact badly with administrator permissions and so removing them entirely is cleaner than simply disabling like we do with normally installed extensions when the cleanup tool detects UwS.
Change-Id: I1b6b814d521e78edccd7c603f1eae3ef7a9a6c5f
Reviewed-on: https://chromium-review.googlesource.com/c/1278852
Reviewed-by: Joe Mason <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Commit-Queue: Preston Carpenter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600059}(cherry picked from commit 29c8bbfe2e81471ba503af1c03015f0315089b93)
Reviewed-on: https://chromium-review.googlesource.com/c/1298337
Cr-Commit-Position: refs/branch-heads/3578@{#299}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[CrOS MultiDevice] Update Instant Tethering item (multi-device subpage).
Before this CL, the multi-device settings displayed Instant Tethering
settings using exactly the same mechanism used by the network settings.
However, this is undesirable because (1) it does not display the
"prohibited" icon when a device administrator prohibits the feature and
(2) it does not display the correct text as a label for the item.
This CL changes the settings subpage to use the same infrastructure as
the rest of the features. As a result, this also requires that
TetherService be updated; previously, TetherService was responsible for
changing the "enabled" user pref itself, but now it needs to support that
mode as well as responding to changes of the "enabled" pref.
Bug: 896324, 884830
Change-Id: I083a8e8e07725130058db35ee540dd6ad733d421
Reviewed-on: https://chromium-review.googlesource.com/c/1297594
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Jeremy Klein <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602199}(cherry picked from commit 6b1ff066b5f169587b4693f0b295745383e10ea2)
Reviewed-on: https://chromium-review.googlesource.com/c/1298293
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#298}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Improves ChromeVox behavior in Assistant.
This CL:
- Stops ChromeVox from speaking when the mic is opened for Assistant.
- No longer focuses ActionView when switching to voice input modality.
(cherry picked from commit a41583b2aed1c4c90ab42c3364b0224d78c8b4b9)
Bug: b:116139555, b:116143886
Change-Id: Ibdd316f6ed83b856adeaae7fd3ddd3796951348f
Reviewed-on: https://chromium-review.googlesource.com/c/1263564
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#602070}
Reviewed-on: https://chromium-review.googlesource.com/c/1297475
Cr-Commit-Position: refs/branch-heads/3578@{#297}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71 merge] Removes ContextMenuManager from observing lifecycle events during onDestroy to keep from leaking UI memory.
This is merge to M71 of change 430670dac53f00a90e237e28fb883667e0b08756
in third_party/feed. The change addresses memory leak in Feed library.
BUG=896912
[email protected]
Change-Id: I6372d8ca0a61efd9e39def4cf02b735ee5a65be9
Reviewed-on: https://chromium-review.googlesource.com/c/1297455
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#296}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Incrementing VERSION to 71.0.3578.22
[email protected]
Change-Id: Ibd12bde758a638e88c88b4ce20a0fcd2b327a9c3
Reviewed-on: https://chromium-review.googlesource.com/c/1298176
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#295}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Update chip styles to snowflake approved values
Merge to Release Branch: 3578
Update the chip colors/styles to be the snowflake approved styles. This
currently includes changing the background color, the text color and the
stroke color for chip states.
This patch also updates the padding for the chip list in downloads home
v2 to match spec.
BUG=893915
[email protected]
(cherry picked from commit 32e4962e1ede46d0938db54b9285b5e43266814f)
Change-Id: I7f298542cbe630f6d6b2f02f104b4b5f71f0ba85
Reviewed-on: https://chromium-review.googlesource.com/c/1278987
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Becky Zhou <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600021}
Reviewed-on: https://chromium-review.googlesource.com/c/1298127
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#294}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71]Update key icon in password infobars
The old icon can be completely removed once the generation popup
is removed.
Bug: 891323
Change-Id: I6bba6c657f2c442365141d64e01077387f4b0ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1280667
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Ioana Pandele <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601068}(cherry picked from commit f5538255834dbd325f0ed6d5b305138776fa50ca)
Reviewed-on: https://chromium-review.googlesource.com/c/1297267
Reviewed-by: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#293}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Remove separators in new Downloads Home v2
Remove date and filter type separators from the new downloads home UI.
BUG=893918
Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59
Reviewed-on: https://chromium-review.googlesource.com/c/1277967
Commit-Queue: David Trainor <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599791}(cherry picked from commit 64e736bc34f843037e2fbe89449aa06790c1c0b2)
Reviewed-on: https://chromium-review.googlesource.com/c/1298118
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#292}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}M71: S13nServiceWorker: Make the provider host for externalfile scheme navigations.
This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme
when ServiceWorkerServicification or NetworkService is enabled.
It's the same fix as the non-servicification path, done in r528590.
Bug: 895187,896157
Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd
Reviewed-on: https://chromium-review.googlesource.com/c/1286021
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600336}(cherry picked from commit c2997950ca4bf61f062e4efef8909feadfe9d911)
Reviewed-on: https://chromium-review.googlesource.com/c/1297147
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#291}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Enable echo canceller bit for devices that support it in AudioManagerCras.
This CL reverts crrev.com/595745 so that only devices that are
intended to support system echo cancellation by default report that.
To enable experimentation, this CL enables the experimental echo
cancellation bit on all CrOS devices, and enables the default system
echo cancellation bit only on devices that (correctly) report support.
Bug: 896702
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4211b93c096226651f3993dd462f10f05c9ab8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1288451
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Reviewed-by: Max Morin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601935}(cherry picked from commit e19a4276faaca3173a43d29806842596c98c9546)
Reviewed-on: https://chromium-review.googlesource.com/c/1298012
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#290}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71][UMA] Handle missing DMServer entry through re-registration
This CL adds UMA to the re-registration flow to observe number of
triggered, successful and unsuccessful re-registrations attempts.
DD: go/handle-purged-user-sessions
(cherry picked from commit 2adccbd760c8cc930df3594ea218831cb68abadf)
Bug: 870616
Change-Id: Ic963d321fb84cac55a61571b49e4a41554872589
Reviewed-on: https://chromium-review.googlesource.com/c/1283026
Commit-Queue: Alexander Hendrich <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601893}
Reviewed-on: https://chromium-review.googlesource.com/c/1298011
Reviewed-by: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#289}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[Merge M71] Handle missing DMServer entry through re-registration
This CL handles the scenario of DMServer reporting a 410 status code
(missing/unknown/purged client ID) by trying background
re-registration. If this fails, the user is marked as requiring an
online sign-in.
DD: go/handle-purged-user-sessions
Bug: 870616
Change-Id: I4a4c2370c36f5464752029d755d23221cd064b0e
Reviewed-on: https://chromium-review.googlesource.com/c/1227939
Commit-Queue: Alexander Hendrich <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#600359}
(cherry picked from commit 3a845098f5f445e54eef1f66581377f7a8a70806)
[email protected], [email protected], [email protected],
[email protected]
Change-Id: I4a4c2370c36f5464752029d755d23221cd064b0e
Reviewed-on: https://chromium-review.googlesource.com/c/1297971
Reviewed-by: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#288}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}[M71] Fix audio stream creation UAF.
This code assumes that the WebContents owning a RenderFrameHost
outlives the RenderFrameHost, since otherwise RenderFrameHost would
have a dangling |delegate_| pointer. This is apparently false, so
this CL makes sure the RenderFrameAudio{In,Out}putStreamFactory
refers to the ForwardingAudioStreamFactory by a weak pointer.
Test: In addition to CQ, AudioPlayerBrowserTest.ChangeTracks was
repeated 1000 times locally with CrOS/ASAN to ensure it didn't flake.
Bug: 897043
Change-Id: I77925403e95ba8edc7cfaa5db23dc8fe5fd70f93
Reviewed-on: https://chromium-review.googlesource.com/c/1293572
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Olga Sharonova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601885}(cherry picked from commit df7a24e4781cb1aa5f853eab24effea1b4328e2a)
Reviewed-on: https://chromium-review.googlesource.com/c/1298010
Reviewed-by: Max Morin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#287}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge-71 [Autofill] Add strikes when CC save ignored/denied/fails
This is a retry/relanding of
https://chromium-review.googlesource.com/c/chromium/src/+/1269524,
but with the browsertest additions removed, because something is causing
them to be flaky on Win7 builds. Despite making progress, the original
CL has already been reverted twice, so I'd like to land this portion of
it so if it's reverted in the future, only the browsertests (done as a
subsequent CL) will be reverted instead of this big 18-file thing.
[email protected]
(cherry picked from commit bb15c8040b58a4e7d9d3adf7729ebf9904d82e28)
Bug: 884817
Change-Id: I05983ff8b13c7dbac25e615bba8a5d1fa7cc0819
Reviewed-on: https://chromium-review.googlesource.com/c/1294429
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#601720}
Reviewed-on: https://chromium-review.googlesource.com/c/1297727
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#286}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Merge-71 [Autofill] Clear strikes when autofill data wiped out
Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings (chrome://settings ->
Clear Browsing Data -> Advanced -> Autofill Form Data).
[email protected]
(cherry picked from commit aec3d51c69233971e8f90a76121b9de5ef1a3f35)
Bug: 884817
Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c
Reviewed-on: https://chromium-review.googlesource.com/c/1277842
Commit-Queue: Anne Lim <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600648}
Reviewed-on: https://chromium-review.googlesource.com/c/1297265
Cr-Commit-Position: refs/branch-heads/3578@{#285}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Reland: Update UI for unsupported Android OS and make Jelly Bean unsupported.
This CL updates the UI to show a badge icon in the app menu icon
whenever the user is running Chrome on a currently unsupported Android
version. This badge in the app menu is only displayed once, until the
user taps the app menu icon. If the user does in fact get a new version,
the badge state is reset, and will be shown again. The current behavior
for out of date users stays the same as before (once per cold start).
In addition, a new menu item is displayed at the top of the menu that
explains that Chrome is unable to update. Nothing happens when you tap
the menu item in the case of an unsupported OS version.
The new menu item and the new warning message in About Chrome will
always be displayed when the user is in this state, regardless of
whether the app menu has already been tapped (which removes the badge).
This CL also updates the UI in Settings - About Chrome to show a new
message and a warning icon when the user is running Chrome on an
unsupported version of the Android OS.
By default, Jelly Bean is considered unsupported after this CL, but this
can be overridden from the variations framework.
It is possible to use command line flags or chrome://flags for
testing the different states, though that does not impact the
About Chrome screen.
(cherry picked from commit 3c02e5982f4c5cb6c548078951ee709f9403a5e4)
Binary-Size: This CL adds new assets and the minimal code required.
Bug: 847940
Change-Id: I0d8653c8ac93f80241c70283effe2105e20af190
Reviewed-on: https://chromium-review.googlesource.com/c/1289470
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#600964}
Reviewed-on: https://chromium-review.googlesource.com/c/1297643
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#284}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}Revert "Download Home V2: Maps errors to OfflineItemStates."
This reverts commit fe3131be6097f49f3f8e361835d10ca8d1aa8a2b.
Reason for revert: Causes build failure, because branch is missing this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1281422
Original change's description:
> Download Home V2: Maps errors to OfflineItemStates.
>
> This CL implements a code path to make Java side known how OfflineItem
> should be resumed.
>
> OfflineItemState::FAILED: Cannot resume, no further user actions.
>
> OfflineItemState::INTERRUPTED: Can resume, but need to restart from
> beginning. Should hook to retry button.
>
> OfflineItemState::PENDING/PAUSE still uses
> DownloadUtils.isDownloadPending/isDownloadPause, when download can be
> resumed in the middle.
>
>
> [email protected]
>
> (cherry picked from commit 32528739021da25e59182db41c1b09521a1aa432)
>
> Bug: 895018,895013
> Change-Id: I36a82cf3754093bfab85a623818d9e2392a6fc73
> Reviewed-on: https://chromium-review.googlesource.com/c/1289677
> Commit-Queue: Shakti Sahu <[email protected]>
> Reviewed-by: Min Qin <[email protected]>
> Reviewed-by: David Trainor <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#601713}
> Reviewed-on: https://chromium-review.googlesource.com/c/1297583
> Reviewed-by: Xing Liu <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3578@{#279}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[email protected],[email protected],[email protected]
Change-Id: I0eab61730672a4d2b0d338425616f22f67e544ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895018, 895013
Reviewed-on: https://chromium-review.googlesource.com/c/1297648
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#283}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
