Publish DEPS for 71.0.3558.0

• DEPS[diff]

Update DEPS for 3558 branching

# This is an automated release commit.
# Do not revert without consulting [email protected].
NOAUTOREVERT=true
[email protected]

Change-Id: Ida8f76d6beb0bd1e36a94e07dc31e492fbcbe847
Reviewed-on: https://chromium-review.googlesource.com/1237874
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3558@{#1}
Cr-Branched-From: 6afac0314ce61cca7fc900430635233932547f72-refs/heads/master@{#593042}

• DEPS[diff]

fix some TabDragController test for Mash

This CL fixes a part of UI tests of TabDragController.
- some cases RootWindow is wanted to set/clear/check the window
  properties when Mash is enabled, those test expectations
  should be fixed.
- some tests expect Ash style organization of window, checking
  root window pointer to exist in a particular display.
  Unfortunately some of this isn't fully fixed due to an issue
  of crbug.com/885312
- BrowserFrameMash's change is needed for IsWindowPositionManaged()
  which is called on some test cases. This is basically what
  BrowserFrameAsh does.

BUG=885312
TEST=interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: Ic2e76a7e25d5104b32a3449fb45f047deab4b0dd
Reviewed-on: https://chromium-review.googlesource.com/1232685
Commit-Queue: Jun Mukai <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593042}

• chrome/browser/ui/views/frame/browser_frame_mash.cc[diff]
• chrome/browser/ui/views/frame/browser_frame_mash.h[diff]
• chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc[diff]

Fix DCHECK when entering fullscreen on Linux with the GTK theme

Also fixes a logic error in opaque_browser_frame_view_layout.cc introduced by
e831694.

BUG=882854,887598
R=pkasting
CC=​iclelland

Change-Id: I5b1b6eb4d737ecbed3102d046b06cacdef7cddaa
Reviewed-on: https://chromium-review.googlesource.com/1236267
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593041}

• chrome/browser/ui/libgtkui/nav_button_provider_gtk.cc[diff]
• chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc[diff]

Refactor chromeos GN test configs. Consolidate vm_sanity_test's targets.

We're planning on adding more non-gtest tests. The cleanup here will make
that simpler/easier.

Bug: 876587
Change-Id: Ie23bd9ed1e38a3dc9df90a087cd8637557683c8a
Reviewed-on: https://chromium-review.googlesource.com/1227148
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593040}

• build/config/chromeos/rules.gni[diff]
• chromeos/BUILD.gn[diff]
• testing/test.gni[diff]

[GTK] Fix menu background color regression

Regressed after 9c5131ad426872a1c931a6e3a27bbd4c469b7721.  This caused the menu
background to always render white even though the text colors would still be
styled using the system theme.  This caused illegible text when the menu
background was supposed to be dark.

R=pkasting
TBR=sky

Change-Id: I39b836e0941cbfc033515fe3891ecd42d89d73a4
Reviewed-on: https://chromium-review.googlesource.com/1237519
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593039}

• ui/views/controls/menu/menu_scroll_view_container.cc[diff]
• ui/views/controls/menu/menu_scroll_view_container.h[diff]

Fix JS cookie access failing or hanging after network process crashes.

Bug: 887680
Change-Id: I249e640a559e550b879370f2f02d2437e52ac93b
Reviewed-on: https://chromium-review.googlesource.com/1236282
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Chong Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593038}

• content/browser/frame_host/render_frame_message_filter.cc[diff]
• content/browser/frame_host/render_frame_message_filter.h[diff]
• content/browser/network_service_restart_browsertest.cc[diff]

DevTools: make shared worker connect pausable..

..otherwise we ignore connection event when we paused at shared worker
initialization.
This bug was introduced by workers refactoring [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1205802

[email protected]

Bug: chromium:775132
Change-Id: I1d7c68d0c6339eaae4bd74c7a1953273f5ce8f2b
Reviewed-on: https://chromium-review.googlesource.com/1237249
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593037}

• chrome/test/data/workers/debug_shared_worker_initialization.js[diff]
• third_party/blink/renderer/core/exported/web_shared_worker_impl.cc[diff]
• third_party/blink/renderer/core/workers/shared_worker_global_scope.cc[diff]
• third_party/blink/renderer/core/workers/shared_worker_global_scope.h[diff]
• third_party/blink/renderer/core/workers/worker_global_scope.cc[diff]
• third_party/blink/renderer/core/workers/worker_global_scope.h[diff]
• third_party/blink/renderer/devtools/front_end/Tests.js[diff]

Network Service crash fix in network::mojom::SSLPrivateKeyProxy::Sign

This CL protects calling Sign() on a private key that is null. The key
can become null in two cases.  The first case is if |network_service_client_|
is null during OnCertificateRequested(). The second case is if
HandleSSLPrivateKeyError() is called.

In both cases, after this CL, if |ssl_private_key_| is null, we just call
the sign callback with net::ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY.

Bug: 887539
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0e2563f00d73ff0659786e85a041567ceeaaea48
Reviewed-on: https://chromium-review.googlesource.com/1237396
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Doug Turner <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593036}

• services/network/url_loader.cc[diff]

[CrOS MultiDevice] DeviceReenroller: Remove self as observer in dtor

Because DeviceReenroller is a DeviceSyncClient::Observer, it should
remove itself as an observer in the destructor.

Bug: 887557, 887758
Change-Id: I318ee3a3a9f3b7df6cef1bfb362049a6687b9436
Reviewed-on: https://chromium-review.googlesource.com/1237536
Commit-Queue: Josh Nohle <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593035}

• chromeos/services/multidevice_setup/device_reenroller.cc[diff]

canvas: rename unit test file

This CL renames the file hosting CanvasResourceDispatcherTest, to comply
with the class (and functionality) inside.
s/offscreen_canvas_frame_dispatcher_test.cc/canvas_resource_dispatcher_test.cc/
Stumbled upon this mismatch during crrev.com/c/1228859.

Bug: 878801
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib653677f7994de4f0e0178df3a7403a70abd1b99
Reviewed-on: https://chromium-review.googlesource.com/1237180
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Miguel Casas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593034}

• third_party/blink/renderer/platform/BUILD.gn[diff]
• third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher_test.cc[Renamed from third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc - diff]

Adjust Dialog Layout

This CL changes the layout of local card migration according to the
mock: go/autofill-paradise

1) Change title label view layout.

2) Change the width of content_container top / bottom border to 0

3) Adjust image bottom border

Uploaded a new screenshot in bug.

Bug: 852904
Change-Id: I1bf1a1745ac6cbd579da4f680a9552ac159b4ddc
Reviewed-on: https://chromium-review.googlesource.com/1208936
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593033}

• chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc[diff]
• chrome/browser/ui/views/autofill/migratable_card_view.cc[diff]

Fix crash when running NetworkService out of process on Android

SimpleIndex uses an ApplicationStatusListener to know when to write the
cache to disk. This is used in the network service, and when network
service is run out of process, this causes a crash since
ApplicationStatusListener should only be used from the main process.

To fix this, I changed ApplicationStatusListener to have a SetCallback
interface, that can then have an implementation in the network service.
If the cache is being created in the network service, we can pass the
network service implementation of ApplicationStatusListener. The
NetworkServiceClient will then notify network service of status changes
from the main process.

Bug: 881572
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I1824e8e8c13f4294fd3a500545714c13a90db08b
Reviewed-on: https://chromium-review.googlesource.com/1225606
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593032}

• base/android/application_status_listener.cc[diff]
• base/android/application_status_listener.h[diff]
• base/android/application_status_listener_unittest.cc[diff]
• chrome/browser/android/ntp/content_suggestions_notifier_service.cc[diff]
• chrome/browser/metrics/thread_watcher_android.cc[diff]
• chrome/browser/offline_pages/android/load_termination_listener_impl.cc[diff]
• components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc[diff]
• components/data_use_measurement/core/data_use_measurement.cc[diff]
• content/browser/memory/memory_monitor_android.cc[diff]
• content/browser/network_service_browsertest.cc[diff]
• content/browser/network_service_client.cc[diff]
• content/browser/network_service_client.h[diff]
• content/browser/renderer_host/compositor_impl_android.cc[diff]
• content/browser/renderer_host/media/video_capture_manager.cc[diff]
• net/disk_cache/disk_cache.cc[diff]
• net/disk_cache/disk_cache.h[diff]
• net/disk_cache/simple/simple_backend_impl.cc[diff]
• net/disk_cache/simple/simple_backend_impl.h[diff]
• net/disk_cache/simple/simple_index.cc[diff]
• net/disk_cache/simple/simple_index.h[diff]
• net/http/http_cache.cc[diff]
• net/http/http_cache.h[diff]
• net/url_request/url_request_context_builder.cc[diff]
• net/url_request/url_request_context_builder.h[diff]
• services/network/network_context.cc[diff]
• services/network/network_context.h[diff]
• services/network/network_service.cc[diff]
• services/network/network_service.h[diff]
• services/network/public/cpp/network_param_android.typemap[Added - diff]
• services/network/public/cpp/network_param_mojom_traits.cc[diff]
• services/network/public/cpp/network_param_mojom_traits.h[diff]
• services/network/public/cpp/typemaps.gni[diff]
• services/network/public/mojom/network_param.mojom[diff]
• services/network/public/mojom/network_service.mojom[diff]

Prevents horrid flicker from occuring during app list close

Drag closed from FULLSCREEN_SEARCH
Drag closed from HALF_SEARCH
Drag closed from PEEKING
Drag closed from FULLSCREEN_ALL_APPS

Bug: 885909
Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80
Test: Manually tested scenarios:
Reviewed-on: https://chromium-review.googlesource.com/1237395
Commit-Queue: Kevin Strohbehn <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593031}

• ash/app_list/views/app_list_view.cc[diff]

More OfflineItemModel implementation

This CL makes OfflineItemModel inherit from DownloadUIModel

Bug: 881499
Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db
Reviewed-on: https://chromium-review.googlesource.com/1237134
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593030}

• chrome/browser/download/download_item_model.cc[diff]
• chrome/browser/download/download_item_model.h[diff]
• chrome/browser/download/download_ui_model.h[diff]
• chrome/browser/download/notification/download_item_notification.cc[diff]
• chrome/browser/download/notification/download_item_notification.h[diff]
• chrome/browser/download/notification/download_item_notification_unittest.cc[diff]
• chrome/browser/download/notification/download_notification_manager.cc[diff]
• chrome/browser/download/notification/download_notification_manager.h[diff]
• chrome/browser/download/offline_item_model.cc[diff]
• chrome/browser/download/offline_item_model.h[diff]
• chrome/browser/download/offline_item_model_manager.cc[diff]
• chrome/browser/download/offline_item_model_manager.h[diff]
• chrome/browser/download/offline_item_model_manager_factory.cc[diff]
• chrome/browser/ui/views/download/download_item_view.cc[diff]
• chrome/browser/ui/views/download/download_item_view.h[diff]
• chrome/browser/ui/views/download/download_shelf_view.cc[diff]

FrameLoader: consume transient user activation earlier

The main reason is alignment between start and commit navigation paths,
so that we can later call CommitNavigation directly from StartNavigation.

As a side effect, this patch also ensures that we consume the
activation for any navigation attempt, even if is was ignored
due to frame detach or some other reason.

Bug: 855189
Change-Id: Ib705c0f20d567341d88e0fc3097ebc4246dcfeff
Reviewed-on: https://chromium-review.googlesource.com/1232200
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593029}

• content/renderer/render_frame_impl.cc[diff]
• third_party/blink/public/web/web_local_frame_client.h[diff]
• third_party/blink/renderer/core/exported/local_frame_client_impl.cc[diff]
• third_party/blink/renderer/core/exported/local_frame_client_impl.h[diff]
• third_party/blink/renderer/core/frame/local_frame_client.h[diff]
• third_party/blink/renderer/core/loader/document_loader.cc[diff]
• third_party/blink/renderer/core/loader/document_loader.h[diff]
• third_party/blink/renderer/core/loader/empty_clients.cc[diff]
• third_party/blink/renderer/core/loader/empty_clients.h[diff]
• third_party/blink/renderer/core/loader/frame_loader.cc[diff]

Introduce FidoBlePairingDelegate

Implement FidoBlePairingDelegate which handles
  a) Caching BLE Pin code when user inputs the pin code via WebAuthN UI.
  b) Handling logic of BluetoothDevice::RequestPinCode() and
     BluetoothDevice::RequestPasskey().

Bug: 877344
Change-Id: I10585c98ad9517b168824119ff2f50a67ff8f0c6
Reviewed-on: https://chromium-review.googlesource.com/1228777
Commit-Queue: Jun Choi <[email protected]>
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593028}

• device/BUILD.gn[diff]
• device/fido/BUILD.gn[diff]
• device/fido/ble/fido_ble_pairing_delegate.cc[Added - diff]
• device/fido/ble/fido_ble_pairing_delegate.h[Added - diff]
• device/fido/ble/fido_ble_pairing_delegate_unittest.cc[Added - diff]

Roll src/third_party/chromite 6dd0074561b7..cae258d6b7d4 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6dd0074561b7..cae258d6b7d4


git log 6dd0074561b7..cae258d6b7d4 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@cae258d6b7d4

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I703b62628bc17c4c92c98df2a7f6d0220fec6c92
Reviewed-on: https://chromium-review.googlesource.com/1236470
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593027}

• DEPS[diff]

Roll src-internal 477dda58e6d7..8c9d5d0fbbbc (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/477dda58e6d7..8c9d5d0fbbbc


Created with:
  gclient setdep -r src-internal@8c9d5d0fbbbc

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I6498530abdf479756afa6ad1583b60a402c4be65
Reviewed-on: https://chromium-review.googlesource.com/1237473
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593026}

• DEPS[diff]

[Video Capture, UMA] Distinguish out of memory from buffer pool max count exceeded

Currently, failures to obtain a video capture buffer from the buffer pool are
logged all in one bucket. This CL splits the failures into out of memory vs.
buffer pool max count exceeded.

To enable this, the CL changes the interface of media::VideoCaptureBufferPool to
return a result code that breaks out failure cases instead of having a single
failure path.

Bug: 878943
Change-Id: I0a74a8034e936ea02a1ead26a6cb5d916e05e288
Reviewed-on: https://chromium-review.googlesource.com/1220192
Commit-Queue: Christian Fremerey <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Yuri Wiitala <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593025}

• content/browser/media/capture/desktop_capture_device_unittest.cc[diff]
• content/browser/media/capture/screen_capture_device_android_unittest.cc[diff]
• content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc[diff]
• content/browser/renderer_host/media/video_capture_controller_unittest.cc[diff]
• media/capture/content/android/thread_safe_capture_oracle.cc[diff]
• media/capture/mojom/video_capture_types.mojom[diff]
• media/capture/mojom/video_capture_types_mojom_traits.cc[diff]
• media/capture/video/chromeos/mock_video_capture_client.cc[diff]
• media/capture/video/chromeos/mock_video_capture_client.h[diff]
• media/capture/video/fake_video_capture_device.cc[diff]
• media/capture/video/fake_video_capture_device_unittest.cc[diff]
• media/capture/video/mock_video_capture_device_client.h[diff]
• media/capture/video/video_capture_buffer_pool.h[diff]
• media/capture/video/video_capture_buffer_pool_impl.cc[diff]
• media/capture/video/video_capture_buffer_pool_impl.h[diff]
• media/capture/video/video_capture_device.cc[diff]
• media/capture/video/video_capture_device.h[diff]
• media/capture/video/video_capture_device_client.cc[diff]
• media/capture/video/video_capture_device_client.h[diff]
• media/capture/video/video_capture_device_unittest.cc[diff]
• media/capture/video/win/video_capture_device_mf_win_unittest.cc[diff]
• media/capture/video_capture_types.h[diff]
• services/video_capture/shared_memory_virtual_device_mojo_adapter.cc[diff]
• tools/metrics/histograms/enums.xml[diff]

Clean up some Safe Browsing histograms

Erase some expired histograms (or update the expiration_date attribute).

Bug: 884868,871505
Change-Id: I10241e2baad43c6960c04a7571a0ef8f9e5c68fe
Reviewed-on: https://chromium-review.googlesource.com/1229499
Commit-Queue: Jialiu Lin <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593024}

• chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc[diff]
• chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc[diff]
• components/safe_browsing/password_protection/metrics_util.cc[diff]
• components/safe_browsing/password_protection/metrics_util.h[diff]
• components/safe_browsing/password_protection/password_protection_service.cc[diff]
• components/safe_browsing/password_protection/password_protection_service.h[diff]
• components/safe_browsing/password_protection/password_protection_service_unittest.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

Roll src/third_party/depot_tools 0c22dec277af..7e301cfffe7f (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c22dec277af..7e301cfffe7f


git log 0c22dec277af..7e301cfffe7f --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] [gclient] Use canonical URLs in solutions
2018-09-20 [email protected] Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@7e301cfffe7f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161
[email protected]

Change-Id: I7ef130a75c80922136ed2ef11732730b0b890ff0
Reviewed-on: https://chromium-review.googlesource.com/1236472
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593023}

• DEPS[diff]

Take ownership of NTP voice search metrics

Bug: None
Change-Id: Ia2261537611e93c2f970d86fd003d230a583180a
Reviewed-on: https://chromium-review.googlesource.com/1237386
Commit-Queue: Kyle Milka <[email protected]>
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593022}

• tools/metrics/histograms/histograms.xml[diff]

[iOS] Updating GetSyncErrorDescriptionForBrowserState() API

Replacing GetSyncErrorDescriptionForBrowserState() by
GetSyncErrorDescriptionForSyncSetupService().

Browser state is not always available. This patch is to prepare for
crrev.com/c/1231333

Bug: 849754
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iec560ea22b8e8344cca29de036aef299e8e7b667
Reviewed-on: https://chromium-review.googlesource.com/1234155
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593021}

• ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm[diff]
• ios/chrome/browser/ui/settings/settings_collection_view_controller.mm[diff]
• ios/chrome/browser/ui/settings/sync_utils/sync_util.h[diff]
• ios/chrome/browser/ui/settings/sync_utils/sync_util.mm[diff]

Fix shelf icons for crostini and internal apps with SingleProcessMash

The controllers in chrome were observing the wrong aura::Env instance.

Bug: 887156
Test: manual
Change-Id: Ib7e978a4ea7014c2fad65ee6afb73e40311117c7
Reviewed-on: https://chromium-review.googlesource.com/1236559
Reviewed-by: Michael Wasserman <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593020}

• chrome/browser/ui/ash/launcher/DEPS[diff]
• chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc[diff]
• chrome/browser/ui/ash/launcher/internal_app_window_shelf_controller.cc[diff]

chrome://net-internals: Remove netlog & polled data viewing & importing.

This information can be viewed using chrome://net-export to save a log,
and viewing the log with the external netlog_viewer project:
https://chromium.googlesource.com/catapult/+/master/netlog_viewer/

Bug: 678391
Change-Id: I911d21002c1615f85de02ef2982ddb4abd935a16
Reviewed-on: https://chromium-review.googlesource.com/1228483
Commit-Queue: Matt Mueller <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593019}

• chrome/browser/resources/net_internals/alt_svc_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/alt_svc_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/bandwidth_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/bandwidth_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/browser_bridge.js[diff]
• chrome/browser/resources/net_internals/capture_status_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/capture_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/capture_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/details_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/dns_view.html[diff]
• chrome/browser/resources/net_internals/dns_view.js[diff]
• chrome/browser/resources/net_internals/events_tracker.js[Deleted - diff]
• chrome/browser/resources/net_internals/events_view.css[Deleted - diff]
• chrome/browser/resources/net_internals/events_view.html[diff]
• chrome/browser/resources/net_internals/events_view.js[diff]
• chrome/browser/resources/net_internals/halted_status_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/horizontal_scrollbar_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/http_cache_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/http_cache_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/import_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/import_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/index.html[diff]
• chrome/browser/resources/net_internals/index.js[diff]
• chrome/browser/resources/net_internals/loaded_status_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/log_grouper.js[Deleted - diff]
• chrome/browser/resources/net_internals/log_util.js[Deleted - diff]
• chrome/browser/resources/net_internals/log_view_painter.js[Deleted - diff]
• chrome/browser/resources/net_internals/main.css[diff]
• chrome/browser/resources/net_internals/main.js[diff]
• chrome/browser/resources/net_internals/modules_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/modules_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/mouse_over_help.js[Deleted - diff]
• chrome/browser/resources/net_internals/prerender_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/prerender_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/proxy_view.html[diff]
• chrome/browser/resources/net_internals/proxy_view.js[diff]
• chrome/browser/resources/net_internals/quic_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/quic_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/reporting_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/reporting_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/resizable_vertical_split_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/socket_pool_wrapper.js[Deleted - diff]
• chrome/browser/resources/net_internals/sockets_view.html[diff]
• chrome/browser/resources/net_internals/sockets_view.js[diff]
• chrome/browser/resources/net_internals/source_entry.js[Deleted - diff]
• chrome/browser/resources/net_internals/source_filter_parser.js[Deleted - diff]
• chrome/browser/resources/net_internals/source_row.js[Deleted - diff]
• chrome/browser/resources/net_internals/source_tracker.js[Deleted - diff]
• chrome/browser/resources/net_internals/spdy_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/spdy_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/status_view.css[Deleted - diff]
• chrome/browser/resources/net_internals/status_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/table_printer.js[Deleted - diff]
• chrome/browser/resources/net_internals/time_util.js[Deleted - diff]
• chrome/browser/resources/net_internals/timeline_data_series.js[Deleted - diff]
• chrome/browser/resources/net_internals/timeline_graph_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/timeline_view.css[Deleted - diff]
• chrome/browser/resources/net_internals/timeline_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/timeline_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/top_bar_view.html[Deleted - diff]
• chrome/browser/resources/net_internals/top_bar_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/top_mid_bottom_view.js[Deleted - diff]
• chrome/browser/resources/net_internals/util.js[diff]
• chrome/browser/ui/webui/net_internals/net_internals_ui.cc[diff]
• chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc[diff]
• chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.h[diff]
• chrome/test/data/webui/BUILD.gn[diff]
• chrome/test/data/webui/net_internals/bandwidth_view.js[Deleted - diff]
• chrome/test/data/webui/net_internals/dns_view.js[diff]
• chrome/test/data/webui/net_internals/events_view.js[Deleted - diff]
• chrome/test/data/webui/net_internals/log_util.js[Deleted - diff]
• chrome/test/data/webui/net_internals/log_view_painter.js[Deleted - diff]
• chrome/test/data/webui/net_internals/main.js[diff]
• chrome/test/data/webui/net_internals/net_internals_test.js[diff]
• chrome/test/data/webui/net_internals/prerender_view.js[Deleted - diff]
• chrome/test/data/webui/net_internals/timeline_view.js[Deleted - diff]

Mark various unused Safe Browsing histograms as deprecated.

Bug: 673607, 728827, 725336, 705809
Change-Id: Ia1418bba1f6ab0956637de3677a2f0fbef48adc9
Reviewed-on: https://chromium-review.googlesource.com/1233356
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593018}

• tools/metrics/histograms/histograms.xml[diff]

NUX Onboarding: create landing page skeleton.

This CL also adds a helper function to check if the NUX onboarding feature
should be force-enabled on non-win/non-branded builds. This will make
testing and development for the feature much easier. There will be follow-up
CLs to transition all NUX contents to be behind this flag instead of the
build flags.

To test this, add --enable-features=NuxOnboardingForceEnabled

Bug: 874142
Change-Id: I0c1ae6d396901b0a7cbb1c13fe158b488ff0e14c
Reviewed-on: https://chromium-review.googlesource.com/1229502
Reviewed-by: Hector Carmona <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Scott Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593017}

• chrome/browser/browser_resources.grd[diff]
• chrome/browser/resources/welcome/onboarding_welcome/welcome.html[Added - diff]
• chrome/browser/ui/BUILD.gn[diff]
• chrome/browser/ui/webui/welcome/nux_helper.cc[Added - diff]
• chrome/browser/ui/webui/welcome/nux_helper.h[Added - diff]
• chrome/browser/ui/webui/welcome_ui.cc[diff]

Use stability of the browser process to decide whether or not to start background tracing on Android

We use the crash dump uploader to check if we had any browser crash
dumps from the previous sessions, or if we uploaded browser crash dumps
in previous session. Chrome tracing delegate uses this information to
make sure browser is stable before starting background tracing.

BUG=882741

Change-Id: Idc55b90f76e2739c054777e01ea39ce7ba5a131d
Reviewed-on: https://chromium-review.googlesource.com/1220191
Reviewed-by: oysteine <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593016}

• chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java[diff]
• chrome/browser/crash_upload_list/crash_upload_list_android.cc[diff]
• chrome/browser/crash_upload_list/crash_upload_list_android.h[diff]
• chrome/browser/tracing/chrome_tracing_delegate.cc[diff]

generate_buildbot_json.py: Better handle printed lines

This CL changes the tests for generate_buildbot_json.py to capture all
printed lines. It requires tests to assert about the contents of these
printed lines, and then clear them.

It also adds a --verbose flag to the main script, which is passed when
checking the configs.

Also fixes a test for swarming mixins and how they interact with certain
classes of tests.

Bug: 886993
Change-Id: I047d74689d72f35bc7d19c8da338c070a8a5d9a5
Reviewed-on: https://chromium-review.googlesource.com/1237239
Commit-Queue: Stephen Martinis <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593015}

• testing/buildbot/PRESUBMIT.py[diff]
• testing/buildbot/generate_buildbot_json.py[diff]
• testing/buildbot/generate_buildbot_json_unittest.py[diff]

Remove some unused methods on LoFiDecider.

Bug: 721403
Change-Id: I56ab262ba7349e6261816e99fe01fe1d39e0e79a
Reviewed-on: https://chromium-review.googlesource.com/1237252
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593014}

• components/data_reduction_proxy/content/browser/content_lofi_decider.cc[diff]
• components/data_reduction_proxy/content/browser/content_lofi_decider.h[diff]
• components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc[diff]
• components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc[diff]
• components/data_reduction_proxy/core/common/lofi_decider.h[diff]

Propagate updates of dipslay to WindowTreeHostMus

So far the display ID was recognizesed on creation of a toplevel,
but moving across displays isn't considered well.

This CL recognizes the timing of a window moving to another
display, and let WindowTreeHostMus updates its own display ID
properly.

BUG=866947
TEST=the new test case covers

Change-Id: I1e859f879a919674e90875a74434bb73e94edd73
Reviewed-on: https://chromium-review.googlesource.com/1234857
Commit-Queue: Jun Mukai <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593013}

• ash/ws/window_service_delegate_impl_unittest.cc[diff]
• content/renderer/mus/renderer_window_tree_client.cc[diff]
• content/renderer/mus/renderer_window_tree_client.h[diff]
• services/ws/client_root.cc[diff]
• services/ws/public/mojom/window_tree.mojom[diff]
• services/ws/test_change_tracker.cc[diff]
• services/ws/test_change_tracker.h[diff]
• services/ws/test_window_tree_client.cc[diff]
• services/ws/test_window_tree_client.h[diff]
• ui/aura/mus/window_tree_client.cc[diff]
• ui/aura/mus/window_tree_client.h[diff]

Reduce code redundancy by calling MakeMultipleFramesPacket().

MakeMultipleFramesPacket() method has already existed but not all packet makers were using it. This CL cleans up the redudant code. No behavior change.

Change-Id: Ic1379d9cf97c2c776be826608d04f7f013e39600
Reviewed-on: https://chromium-review.googlesource.com/1236928
Commit-Queue: Renjie Tang <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593012}

• net/quic/quic_test_packet_maker.cc[diff]

Roll src/native_client b64cb7b68093..9f85491d8830 (1 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/b64cb7b68093..9f85491d8830


git log b64cb7b68093..9f85491d8830 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Whitespace to trigger additional builds.


Created with:
  gclient setdep -r src/native_client@9f85491d8830

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:861512
[email protected]

Change-Id: Ib74c016615152c02dea0c08364c6e443524349f8
Reviewed-on: https://chromium-review.googlesource.com/1237353
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593011}

• DEPS[diff]

Fix the folder icon issue on first row

This is a follow up CL of go/cgcl/1194340 to fix the same issue when
blur is not enabled.

Bug: 878162
Change-Id: Ia6c3b6942b4304a12bfa3049e0b37252a4deae8f
Reviewed-on: https://chromium-review.googlesource.com/1237403
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Weidong Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593010}

• ash/app_list/views/apps_grid_view.cc[diff]

DNR: Cleanup ruleset manager unittests.

Cleanup ruleset manage unittests by removing the need to use net::URLRequest.
Also, make WebRequestInfo movable.

BUG=696822

Change-Id: I0a0d93406b67ff1a9338b470ef68b03062ae22fd
Reviewed-on: https://chromium-review.googlesource.com/1235331
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593009}

• chrome/browser/extensions/api/declarative_net_request/ruleset_manager_unittest.cc[diff]
• extensions/browser/api/web_request/web_request_info.cc[diff]
• extensions/browser/api/web_request/web_request_info.h[diff]

Roll src/third_party/pdfium 4bf804086c4f..e65756725f82 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/4bf804086c4f..e65756725f82


git log 4bf804086c4f..e65756725f82 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Make some methods const in XFAJSEmbedderTest


Created with:
  gclient setdep -r src/third_party/pdfium@e65756725f82

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: Iee59439218814050299cdd2615982e0fd5eb505d
Reviewed-on: https://chromium-review.googlesource.com/1236485
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593008}

• DEPS[diff]

[VK] Add browser tests for navigation.

There are some rules for showing/hiding the virtual keyboard when
navigating to a new page / tab. Added some tests to make sure we don't
regress these scenarios.

Bug: 849995
Change-Id: I2fee098943b6073a0d1c1f8b86cdf1a3b35455e5
Reviewed-on: https://chromium-review.googlesource.com/1233097
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593007}

• chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc[diff]

Fix compile error when DEBUG_AUDIONODE_REFERENCES is on

The return type of size() was recently changed from size_t to
unsigned.  Adjust printf string for that.

Bug: 887639
Test: Doesn't affect any test
Change-Id: I371ee874bc4e3af6fd9891f059ce6423fdd498a8
Reviewed-on: https://chromium-review.googlesource.com/1236269
Reviewed-by: Hongchan Choi <[email protected]>
Commit-Queue: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593006}

• third_party/blink/renderer/modules/webaudio/audio_node.cc[diff]

Roll src/third_party/perfetto 7397af8da50b..97f63244f536 (1 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/7397af8da50b..97f63244f536


git log 7397af8da50b..97f63244f536 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Make all mithril components class components


Created with:
  gclient setdep -r src/third_party/perfetto@97f63244f536

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I01d82904e216a765f5cb28950f8b579a0da14eff
Reviewed-on: https://chromium-review.googlesource.com/1237356
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593005}

• DEPS[diff]

cros: Fix networkingPrivate.getNetworks IDL validation error

The IDL file did not fully specify all of the output.

Bug: 887688
Change-Id: I5ee75419006a27504e978164379acf7c024988db
Reviewed-on: https://chromium-review.googlesource.com/1237374
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593004}

• extensions/common/api/networking_private.idl[diff]

Revert "Android OOP-D: DisplayScheduler should only report draw-inducing damage"

This reverts commit 60d359fd3bd0bbe1089cf24c196187b3c03fcd65.

Reason for revert: This logic could still be flaky (what if we go invisible after deferring commits), and isn't needed after https://chromium-review.googlesource.com/c/chromium/src/+/1184376, so let's revert.

Original change's description:
> Android OOP-D: DisplayScheduler should only report draw-inducing damage
> 
> Currently DisplayScheduler reports damage to SurfaceManager in any case
> where a damaged surface ID damages the display. While these cases will
> trigger a draw when visible, they don't necessarily trigger a draw
> in any defined timeframe. This can lead to issues. Consider:
> 
> 1) Display 1 is not visible, embeds surface A.
> 2) Surface A sends CF 1, we don't immediately ack as we will wait for
>    Display 1 to draw.
> 3) Display 2 becomes visible, embeds surface A with a new surface ID.
> 4) Display 2 will never update, as no new frames will be produced for
>    surface A as the renderer is continually waiting on the ack for
>    CF 1.
> 
> By having DisplayScheduler report no damage if invisible, we always
> ack frames in a timely manner. This may allow a renderer to produce
> some extra frames when its display is invisible, but this should be
> limited as the renderer itself receives visibility notifications and
> won't get additional BeginFrames once visibility is fully processed.
> 
> Bug: 875895
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I272de950d8e4d4c819c445dc8162ac360afb80a1
> Reviewed-on: https://chromium-review.googlesource.com/1182862
> Reviewed-by: Fady Samuel <[email protected]>
> Commit-Queue: Eric Karl <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#584917}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 875895
Change-Id: Idefad0b80d08b3c9fecf655b27b3c6ffb85eca10
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1232335
Reviewed-by: Eric Karl <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593003}

• components/viz/service/display/display_scheduler.cc[diff]
• components/viz/service/display/display_scheduler_unittest.cc[diff]
• components/viz/service/surfaces/surface_observer.h[diff]

[ios] Deletes legacy c/b/ui/ntp/recent_tabs files

- Deletes legacy recent_tabs files.
- Modifies recent_tabs_table_coordinator_test to work with the new coordinator.
(Deletes tableVC related asserts, since a coordinator shouldn't be tied to a VC)
- Renames RecentTabsHandsetViewControllerCommand to RecentTabsPresentationDelegate.h
and moves it to its own file.
- Renames LegacyRecentTabsTableViewControllerDelegate to RecentTabsTableViewControllerDelegate.

Bug: 807330
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea5b2aa8c32bdac7c6f8070cf721d8ad0991962a
Reviewed-on: https://chromium-review.googlesource.com/1235278
Reviewed-by: edchin <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593002}

• ios/chrome/browser/ui/browser_view_controller.mm[diff]
• ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn[diff]
• ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.h[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.mm[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.h[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller_delegate.h[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_coordinator_unittest.mm[Renamed from ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator_unittest.mm - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.h[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.h[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm[Deleted - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_presentation_delegate.h[Added - diff]
• ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller_delegate.h[Added - diff]
• ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm[diff]
• ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.h[diff]
• ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.h[diff]
• ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm[diff]
• ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm[diff]

ws: Add touch selection controller support for pointer watcher.

Allows ws clients to close touch ui on events outside their windows.

Add a new PointerWatcher plumbing to [Mus]ViewsDelegate.
Wires up watchers to the Mus-only PointerWatcherEventRouter.
(ui/views/mus/* is not allowed as a dependency of ui/views/*)

Destroy the touch selection ui on PointerWatcher mouse events.

Bug: 884394, 887725
Test: Mouse events outside the KSV window close KSV text touch ui.
Change-Id: I0e41da4d03719001191f7d5ab669bcc1805bd63c
Reviewed-on: https://chromium-review.googlesource.com/1232955
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593001}

• ui/base/touch/touch_editing_controller.h[diff]
• ui/views/mus/mus_views_delegate.cc[diff]
• ui/views/mus/mus_views_delegate.h[diff]
• ui/views/touchui/touch_selection_controller_impl.cc[diff]
• ui/views/touchui/touch_selection_controller_impl.h[diff]
• ui/views/views_delegate.cc[diff]
• ui/views/views_delegate.h[diff]

'Card saved' text is now not bold when clicked on.

After saving a card locally, we see a "Card saved" text animation. When the text is clicked on, the icon is highlighted and the text looks bold and clunky. This CL makes the text look normal.

Before: https://screenshot.googleplex.com/Jt3omKZ7RY9
After: https://screenshot.googleplex.com/jAMgKyYs3RQ


Bug: 881320
Change-Id: I604c981fad7171c88d93d95d9029a2aa0a70484e
Reviewed-on: https://chromium-review.googlesource.com/1236271
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Manas Verma <[email protected]>
Cr-Commit-Position: refs/heads/master@{#593000}

• chrome/browser/ui/views/page_action/page_action_icon_view.cc[diff]

Rename IntentHandler.isIntentChromeOrFirstParty to notSecureIsIntentChromeOrFirstParty

Bug: 832124
Change-Id: If17c7e3cdd5143e2014176feb5bcfda60a8da4fe
Reviewed-on: https://chromium-review.googlesource.com/1236755
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592999}

• chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/browserservices/BrowserSessionDataProvider.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java[diff]

Roll src-internal b20563f5defb..477dda58e6d7 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b20563f5defb..477dda58e6d7


Created with:
  gclient setdep -r src-internal@477dda58e6d7

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I80a4f6e091ed5b7a14ae26c2479bd2d087ffd4ab
Reviewed-on: https://chromium-review.googlesource.com/1237355
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592998}

• DEPS[diff]

Roll src/third_party/depot_tools 9cba9ffdfdc6..0c22dec277af (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9cba9ffdfdc6..0c22dec277af


git log 9cba9ffdfdc6..0c22dec277af --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Roll recipe dependencies (trivial).
2018-09-20 [email protected] Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@0c22dec277af

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I5beae3f74292c7d2764e31d90c1f9071a14ac96d
Reviewed-on: https://chromium-review.googlesource.com/1236892
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592997}

• DEPS[diff]

Roll src/third_party/skia 268707284dcd..32f12aca36e0 (9 commits)

https://skia.googlesource.com/skia.git/+log/268707284dcd..32f12aca36e0


git log 268707284dcd..32f12aca36e0 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] roll zilb
2018-09-20 [email protected] remove pin in SkColor4f::premul()
2018-09-20 [email protected] progress on canvaskit page
2018-09-20 [email protected] Fix bzl missing include dir.
2018-09-20 [email protected] Fix bzl formatting.
2018-09-20 [email protected] Properly align inside GrTextBlob.
2018-09-20 [email protected] Revert "add getAlphaf() to pixmap/bitmap"
2018-09-20 [email protected] Check for valid input to text draw.
2018-09-20 [email protected] add getAlphaf() to pixmap/bitmap


Created with:
  gclient setdep -r src/third_party/skia@32f12aca36e0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]

Change-Id: I3e41b0438287af85d040e23dda800d378310b59b
Reviewed-on: https://chromium-review.googlesource.com/1236891
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592996}

• DEPS[diff]

Avoid sending desktop automation events on nodes that aren't in the tree.

It's not uncommon to get an event fired on a View whose ancestor Window
is invisible, so it's not actually in a reachable part of the
accessibility tree. Suppress sending events in those cases (but still
serialize tree changes to be safe).

This eliminates a lot of harmless but annoying warnings from
automation_node.js like
"Got locationChanged event on unknown node: 10; this: 311"

Bug: none
Change-Id: I4cc127f74d57953c9a4f6b5ecd44902a368730ca
Reviewed-on: https://chromium-review.googlesource.com/1225950
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592995}

• chrome/browser/ui/aura/accessibility/automation_manager_aura.cc[diff]
• ui/accessibility/ax_tree_serializer.h[diff]

Log UMA for session restoration time.

Bug: 877671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1ab57a336a1cccd169f311c1d64db813cd4a1250
Reviewed-on: https://chromium-review.googlesource.com/1232615
Commit-Queue: Eugene But <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592994}

• ios/web/navigation/wk_based_navigation_manager_impl.h[diff]
• ios/web/navigation/wk_based_navigation_manager_impl.mm[diff]
• ios/web/web_state/web_state_unittest.mm[diff]

Remove LocationBar/UrlBar references from SuggestionView.

This converts the custom view tracking logic with just static/
explicit offsets.  This view no longer is under the crazy development
that made the custom tracking somewhat reasonable.  It is now just
overly complicated and more difficult to reason about.  Phone converted
to static offsets a while ago, so this unifies it with tablets.

BUG=883143

Change-Id: I6076501bee54f052a372be97aaab97686f44497b
Reviewed-on: https://chromium-review.googlesource.com/1228985
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592993}

• chrome/android/java/res/values-sw600dp/dimens.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestionsList.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java[diff]

Check web_contents before getting navigation ID

When password protection verdict comes back from Safe Browsing backend,
it is possible that the web_contents has already gone. Therefore, we
need to check if web_contents is still valid before getting navigation
ID from it.

Bug: 885359
Change-Id: I3c80a8f2a3158ad3c459317e4d4954aa60f6d1f9
Reviewed-on: https://chromium-review.googlesource.com/1236816
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592992}

• chrome/browser/safe_browsing/chrome_password_protection_service.cc[diff]

Roll src/third_party/catapult b0768af22643..6f7c60dde99f (1 commits)

https://chromium.googlesource.com/catapult.git/+log/b0768af22643..6f7c60dde99f


git log b0768af22643..6f7c60dde99f --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Fix report_template.Static()


Created with:
  gclient setdep -r src/third_party/catapult@6f7c60dde99f

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:870324
[email protected]

Change-Id: Ibc8513b6446fca3dbbc0996caf339432e2e1004e
Reviewed-on: https://chromium-review.googlesource.com/1236890
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592991}

• DEPS[diff]

Do not use the attestation flow to get an EID

Instead, simply rely on the DBUS call to compute an EID. This removes
the possibility that this observer and the AttestationPolicyObserver
both start concurrent flows.

BUG=chromium:886938
TEST=unit_tests --gtest_filter=*EnrollmentPolicyObserverTest*

Change-Id: Id26d78440bd10ca7121764431179b618469cf6fa
Reviewed-on: https://chromium-review.googlesource.com/1234373
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yves Arrouye <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592990}

• chrome/browser/chromeos/attestation/enrollment_policy_observer.cc[diff]
• chrome/browser/chromeos/attestation/enrollment_policy_observer.h[diff]
• chrome/browser/chromeos/attestation/enrollment_policy_observer_unittest.cc[diff]

Settings: turn off spellcheck for profile name inputs

Bug: 881745
Change-Id: I46d30ba82182ce47d9f78a9765db76fba835febf
Reviewed-on: https://chromium-review.googlesource.com/1237258
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Esmael El-Moslimany <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592989}

• chrome/browser/resources/md_user_manager/create_profile.html[diff]
• chrome/browser/resources/settings/people_page/manage_profile.html[diff]

Add scrolling to SwitchAccess context menu

Bug: 864796
Change-Id: Ic975c0b63742476415a995e74a351e746908468f
Reviewed-on: https://chromium-review.googlesource.com/1231741
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Zach Helfinstein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592988}

• chrome/browser/resources/chromeos/switch_access/automation_manager.js[diff]
• chrome/browser/resources/chromeos/switch_access/context_menu_manager.js[diff]
• chrome/browser/resources/chromeos/switch_access/panel.html[diff]

cros: Fix accessibility issue of the disabled auth message

Works for both tabbing and reverse tabbing. Chromevox announces
"Time's up" and "Come back at xxx" separately.

Bug: 870459
Change-Id: Icdf76ba4a24ba3a2de48dfea7e2698ea7df4c114
Reviewed-on: https://chromium-review.googlesource.com/1228482
Commit-Queue: Wenzhao (Colin) Zang <[email protected]>
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592987}

• ash/login/ui/lock_contents_view_unittest.cc[diff]
• ash/login/ui/lock_screen_sanity_unittest.cc[diff]
• ash/login/ui/login_auth_user_view.cc[diff]
• ash/login/ui/login_test_utils.cc[diff]
• ash/login/ui/login_test_utils.h[diff]

[Android WebAPK] Introduce APK which shows splash screen in WebAPK 3/X

This CL introduces NewSplashWebApk.apk The logic for displaying the
splash screen earlier will be implemented in NewSplashWebApk.apk
Once everything is ready we will switch the server over.

This CL also refactors WebappSplashScreenController in order to share code
with NewSplashWebApk.apk

Design doc:
https://docs.google.com/document/d/1ZvpZPAIxLl_ElyMWOkDybOhCFzYk0Di4WgpLVSJdEu8/edit?usp=sharing

BUG=817263

Change-Id: Id0561eede51fa7c2d293b321cfdcae755f1e03cf
Reviewed-on: https://chromium-review.googlesource.com/1201348
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592986}

• chrome/android/BUILD.gn[diff]
• chrome/android/java/res/values-sw600dp/dimens.xml[diff]
• chrome/android/java/res/values-v17/styles.xml[diff]
• chrome/android/java/res/values/colors.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappSplashScreenController.java[diff]
• chrome/android/webapk/libs/common/BUILD.gn[diff]
• chrome/android/webapk/libs/common/res_splash/layout/webapp_splash_screen_large.xml[Renamed from chrome/android/java/res/layout/webapp_splash_screen_large.xml - diff]
• chrome/android/webapk/libs/common/res_splash/layout/webapp_splash_screen_no_icon.xml[Renamed from chrome/android/java/res/layout/webapp_splash_screen_no_icon.xml - diff]
• chrome/android/webapk/libs/common/res_splash/layout/webapp_splash_screen_small.xml[Renamed from chrome/android/java/res/layout/webapp_splash_screen_small.xml - diff]
• chrome/android/webapk/libs/common/res_splash/values-sw600dp/dimens.xml[Added - diff]
• chrome/android/webapk/libs/common/res_splash/values-v17/styles.xml[Added - diff]
• chrome/android/webapk/libs/common/res_splash/values/colors.xml[Added - diff]
• chrome/android/webapk/libs/common/res_splash/values/dimens.xml[Added - diff]
• chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkMetaDataUtils.java[Added - diff]
• chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/splash/SplashLayout.java[Added - diff]
• chrome/android/webapk/shell_apk/BUILD.gn[diff]
• chrome/android/webapk/shell_apk/h2o/AndroidManifest.xml[Added - diff]
• chrome/android/webapk/shell_apk/new_splash_manifest_config.json[Added - diff]
• chrome/android/webapk/shell_apk/res_h2o/values-v17/styles.xml[Added - diff]
• chrome/android/webapk/shell_apk/res_h2o/values/colors.xml[Added - diff]
• chrome/android/webapk/shell_apk/shell_apk_version.gni[diff]
• chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java[diff]
• chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/SplashActivity.java[Added - diff]

Print Preview refresh: Fix radio and checkbox ripple sizing issues

Default ripple size of 40px is 2px larger than the desired height for
a print preview settings section/row of settings section. Reduce
ripple size to match this limitation.

For copies' collate box, remove unnecessary margin that caused the
number input to shift when the checkbox appeared. Also reduce the
default size for number inputs, since neither should exceed 3 digits,
and ensure the inline margin is always large enough for the ripple
regardless of font size.

Bug: 885013, 885026, 886551
Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9
Reviewed-on: https://chromium-review.googlesource.com/1235204
Reviewed-by: Scott Chen <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592985}

• chrome/browser/resources/print_preview/new/copies_settings.html[diff]
• chrome/browser/resources/print_preview/new/number_settings_section.html[diff]
• chrome/browser/resources/print_preview/new/print_preview_shared_css.html[diff]

Print Preview Refresh: Fix some advanced settings polish bugs

Bug: 887397, 886663, 886908
Change-Id: I904a9c647c676185ce98faecd16cf815bff10e5f
Reviewed-on: https://chromium-review.googlesource.com/1236839
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592984}

• chrome/browser/resources/print_preview/new/advanced_options_settings.html[diff]
• chrome/browser/resources/print_preview/new/advanced_settings_item.html[diff]
• chrome/browser/resources/print_preview/new/print_preview_shared_css.html[diff]

Update test filter mojo.fyi.chromeos.network_browser_tests.filter

ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange
was renamed and started failing since:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/35102

[email protected]

Bug: 882610
Change-Id: I7caef8a59d7447d8d2420c6cff13f93e68311c1b
Reviewed-on: https://chromium-review.googlesource.com/1236284
Reviewed-by: Chong Zhang <[email protected]>
Commit-Queue: Chong Zhang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592983}

• testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter[diff]

Update the third_party docs with more on how licenses are checked.

We don't actually have much (if any) documentation on how we
do the proper generation of credits and display licenses in Chrome;
this CL attempts to fill the gap.

[email protected]

Change-Id: I99c76055784475de436bef3628a0c4b191bc953a
Reviewed-on: https://chromium-review.googlesource.com/1162964
Commit-Queue: Dirk Pranke <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592982}

• docs/adding_to_third_party.md[diff]

Disable a few more tests

These seems to be flaky in content_browsertests in single process
mash mode.

Bug: 874089, 887711
Change-Id: Iee0aeb5ed0c502c692eade56dfd4ae8f3248137d
Reviewed-on: https://chromium-review.googlesource.com/1237377
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592981}

• testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter[diff]

[Media Controls] Move doubletap handling to MediaControlsImpl

This CL removes the doubletap handling logic out of the overlay play
button and onto MediaControlsImpl. This allows us to shrink the overlay
play button down to only be the clickable area for play/pause,
simplifying the event handling logic and removing zoom calculations
that were crashing.

As a side effect, this CL also fixes an issue where the user couldn't
doubletap to fast-forward/rewind without first showing the controls.

Bug: 884770, 827535
Change-Id: Ic5ff2b911d631bb10d10ac60a3b2e199ac2c3b01
Reviewed-on: https://chromium-review.googlesource.com/1235326
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592980}

• third_party/WebKit/LayoutTests/media/controls/click-on-side-of-video-is-propagated.html[Renamed from third_party/WebKit/LayoutTests/media/controls/click-on-side-of-overlay-play-button-is-propagated.html - diff]
• third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html[diff]
• third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html[diff]
• third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html[diff]
• third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html[diff]
• third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html[diff]
• third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html[diff]
• third_party/WebKit/LayoutTests/media/controls/remove-on-click-does-not-crash.html[diff]
• third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html[diff]
• third_party/WebKit/LayoutTests/media/media-controls.js[diff]
• third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-overlay-scroll-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-zoom-controls-expected.txt[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.cc[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.h[diff]
• third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css[diff]

Print Preview: Adjust more settings padding and set links actionable

Fixing 2 bugs:
(1) When "More settings" is expanded, margin should be 16px
(2) Make links actionable so hand pointer shows up

Bug: 887071, 887228
Change-Id: Iccb185f7e75e6a6fd87eac45b9b0a9f21dae15ca
Reviewed-on: https://chromium-review.googlesource.com/1236501
Reviewed-by: Hector Carmona <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592979}

• chrome/browser/resources/print_preview/new/link_container.html[diff]
• chrome/browser/resources/print_preview/new/more_settings.html[diff]
• chrome/browser/resources/print_preview/new/more_settings.js[diff]

CrOS shelf: conditionally blur the shelf background

Delegate the decision to blur the shelf to the shelf layout manager,
and do not blur it unless there is an active session (e.g. login
screen).

Cache whether the background is currently blurred to avoid unnecessary
updates.

Bug: 883558
Change-Id: I6bc881f8133a0363260f88efd4225fb072009fc0
Reviewed-on: https://chromium-review.googlesource.com/1227813
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592978}

• ash/shelf/shelf_layout_manager.cc[diff]
• ash/shelf/shelf_layout_manager.h[diff]
• ash/shelf/shelf_widget.cc[diff]

Disable FrameSizeChange tests on Android KitKat. They're flaky.

BUG=778245
TEST=none
TBR=xhwang

Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a
Reviewed-on: https://chromium-review.googlesource.com/1237265
Reviewed-by: Dale Curtis <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592977}

• chrome/browser/media/encrypted_media_browsertest.cc[diff]

OWNERS files: removing mathp@ from a few places.

Also, adding gogerald@ to components/payments OWNERS


Bug: None
Change-Id: Id20aa0198de1363d640ddddf2438155717a82eba
Reviewed-on: https://chromium-review.googlesource.com/1236233
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Mathieu Perreault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592976}

• chrome/android/java/src/org/chromium/chrome/browser/autofill/OWNERS[diff]
• chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS[diff]
• chrome/browser/android/payments/OWNERS[diff]
• chrome/browser/search/OWNERS[diff]
• chrome/browser/search/suggestions/OWNERS[diff]
• chrome/browser/ui/autofill/OWNERS[diff]
• components/autofill/OWNERS[diff]
• components/payments/OWNERS[diff]
• components/test/data/autofill/OWNERS[diff]

[Extensions] Re-enabling the ContentScriptIsolatedWorlds API test.

The test passes locally and on the trybots now.

Bug: 163097
Change-Id: I0d7207a2548a568c33241d30ed1bbd7ea2cb4d6a
Reviewed-on: https://chromium-review.googlesource.com/1236922
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Benjamin Ackerman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592975}

• chrome/browser/extensions/content_script_apitest.cc[diff]

Add new owners

Both emaxx@ and drcrash@ at this time ar the only people working on
this code and familiar with it. Other owners have moved on or are
not available, and we end up in reviews like for CL:1234373 where
upstream owners declare themselves incompetent to review.

BUG=None
TEST=None

Change-Id: I3913bc9692a2668bab599eb0f08fc11b8457adc6
Reviewed-on: https://chromium-review.googlesource.com/1237251
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yves Arrouye <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592974}

• chrome/browser/chromeos/attestation/OWNERS[diff]

[VK] Change how VirtualKeyboard.ContainerBehavior is recorded.

We move the recording of InputMethod.VirtualKeyboard.ContainerBehavior
to the end of ShowKeyboard, so we get a sample every time a floating
or docked keyboard is shown. We also account for users switching
between the two modes, as switching requires hiding and showing the
virtual keyboard.

See the bug for more about why this is needed.

Bug: 887248
Change-Id: Icd8b2fbf826a0dba7b32cabb6c7b9afcdde3fcdd
Reviewed-on: https://chromium-review.googlesource.com/1235266
Reviewed-by: Yuichiro Hanada <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592973}

• ui/keyboard/keyboard_controller.cc[diff]

Add autotest API for launching an app from the launcher

BUG=chromium:849438
TEST=tast run vm.CrostiniStartEverything

Change-Id: I51963c9f4fe7b5aa9fd42e2c040410a974376f58
Reviewed-on: https://chromium-review.googlesource.com/1235199
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Jeffrey Kardatzke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592972}

• chrome/browser/extensions/api/autotest_private/autotest_private_api.cc[diff]
• chrome/browser/extensions/api/autotest_private/autotest_private_api.h[diff]
• chrome/common/extensions/api/autotest_private.idl[diff]
• chrome/test/data/extensions/api_test/autotest_private/test.js[diff]
• extensions/browser/extension_function_histogram_value.h[diff]
• tools/metrics/histograms/enums.xml[diff]

WebView: Remove URLRequestContextGetter from AwMetricsServiceClient

It's been unused since commit a5febff94dd70a488bd1 and null since
6bd4db44ab539859b70c.

BUG=546754

Change-Id: Idbffc047f67d3c424a2d6557e50dac8be9d9cee4
Reviewed-on: https://chromium-review.googlesource.com/1236695
Reviewed-by: Bo <[email protected]>
Commit-Queue: Paul Miller <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592971}

• android_webview/browser/aw_browser_main_parts.cc[diff]
• android_webview/browser/aw_metrics_service_client.cc[diff]
• android_webview/browser/aw_metrics_service_client.h[diff]

Add android_webview to ServiceWorkerServicification fieldtrial testing config.

It was just not added earlier as an oversight. Shipping this feature
would affect android webview.

Bug: 881225
Change-Id: Ib101582496db28bbd23239ce71abd547faadcf22
Reviewed-on: https://chromium-review.googlesource.com/1235474
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592970}

• testing/variations/fieldtrial_testing_config.json[diff]

cros: UI for unlocking with an external binary.

See the bug for more details.

Bug: 887070
Change-Id: I4218ffc18f64462c79be31d453d5198003c5d540
Reviewed-on: https://chromium-review.googlesource.com/1235124
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592969}

• ash/login/login_screen_controller.cc[diff]
• ash/login/login_screen_controller.h[diff]
• ash/login/login_screen_controller_unittest.cc[diff]
• ash/login/mock_login_screen_client.cc[diff]
• ash/login/mock_login_screen_client.h[diff]
• ash/login/ui/lock_contents_view.cc[diff]
• ash/login/ui/lock_contents_view_unittest.cc[diff]
• ash/login/ui/lock_screen_sanity_unittest.cc[diff]
• ash/login/ui/login_auth_user_view.cc[diff]
• ash/login/ui/login_auth_user_view.h[diff]
• ash/login/ui/login_auth_user_view_unittest.cc[diff]
• ash/public/cpp/ash_features.cc[diff]
• ash/public/cpp/ash_features.h[diff]
• ash/public/interfaces/login_screen.mojom[diff]
• chrome/browser/chromeos/login/lock/views_screen_locker.cc[diff]
• chrome/browser/chromeos/login/lock/views_screen_locker.h[diff]
• chrome/browser/chromeos/login/ui/login_display_host_mojo.cc[diff]
• chrome/browser/chromeos/login/ui/login_display_host_mojo.h[diff]
• chrome/browser/ui/ash/login_screen_client.cc[diff]
• chrome/browser/ui/ash/login_screen_client.h[diff]

Revert "Add crash logging for accessibility unserialization error"

This reverts commit 8cca7c63e1f481ff505daadf2de9f36e313b4261.

Reason for revert: We deliberately added a browser crash,
enabling us to catch an important bug. Revert this to
eliminate the browser crash and re-enable code to reset
the renderer when it gets in a bad state (now much less often).

Original change's description:
> Add crash logging for accessibility unserialization error
>
> [email protected]
>
> Bug: 870661
> Change-Id: If82429da90259c3af73c4fa424d3bba5e6a09a00
> Reviewed-on: https://chromium-review.googlesource.com/1174862
> Reviewed-by: Dominic Mazzoni <[email protected]>
> Commit-Queue: Dominic Mazzoni <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#583175}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870661, 884934
Change-Id: I5329cd8b306c705e85b26acb8a9b35fcdfbcd426
Reviewed-on: https://chromium-review.googlesource.com/1234261
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592968}

• content/browser/accessibility/accessibility_ipc_error_browsertest.cc[diff]
• content/browser/accessibility/browser_accessibility_cocoa.mm[diff]
• content/browser/accessibility/browser_accessibility_manager.cc[diff]
• content/browser/accessibility/browser_accessibility_manager_unittest.cc[diff]

Fix attempt at the bug below.

Bug: 886594
Change-Id: Ief40291ee0d4ce308efeb887af36eae97f3df164
Reviewed-on: https://chromium-review.googlesource.com/1236929
Reviewed-by: Frank Liberato <[email protected]>
Reviewed-by: Bo <[email protected]>
Commit-Queue: Andrei Pascovici <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592967}

• content/browser/android/dialog_overlay_impl.cc[diff]

FrameMetrics: Reduce FrameMetrics reporting frequency

Enabling FrameMetrics caused 5-20% regression on rendering.
(ref: https://bugs.chromium.org/p/chromium/issues/detail?id=876709).
The FrameMetrics reports back to Tracing for each CompositorFrame
submission with the following data:
https://docs.google.com/document/d/1P1OKg3s5V2TwE8nTxLay01rn6JmpLgKDY00myyDuINs/edit?usp=sharing

Reporting stats summary for each frame is not very interesting,
So I reduced the frequency of FrameMetrics reporting to each second.

Bug: 881863, 880560

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I96ce7d5bed824aa8d86fa00311136362081df019
Reviewed-on: https://chromium-review.googlesource.com/1226012
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Yi Xu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592966}

• ui/latency/frame_metrics.cc[diff]
• ui/latency/frame_metrics_unittest.cc[diff]

Adds std::move so we don't drop the scoped_refptr on the wrong thread.

Bug: 884589
Change-Id: Id7a1b04a2b533584637f0fee425144acb0b8d79a
Reviewed-on: https://chromium-review.googlesource.com/1237236
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: CJ DiMeglio <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592965}

• content/renderer/media/media_factory.cc[diff]

Roll WebGL 7ca87fb..6d2f3f4

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7ca87fb..6d2f3f4

Tbr: [email protected]
Bug: 563816, 878545
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Change-Id: I8c8b57fef830f85f26b231a6a22576d8f9159e0f
Reviewed-on: https://chromium-review.googlesource.com/1225605
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592964}

• DEPS[diff]
• content/test/gpu/gpu_tests/webgl_conformance_revision.txt[diff]

Move IsFileQuarantined() to a test-only build target

This will simplify future refactoring where QuarantineFile() is moved to
an OOP service but not IsFileQuarantined().

This CL includes no functional change.

Bug: 870998
Change-Id: Ic30bf70b119e37de88baa374a4791678df80d393
Reviewed-on: https://chromium-review.googlesource.com/1228782
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592963}

• chrome/browser/download/download_browsertest.cc[diff]
• chrome/test/BUILD.gn[diff]
• chrome/test/ppapi/ppapi_filechooser_browsertest.cc[diff]
• components/download/quarantine/BUILD.gn[diff]
• components/download/quarantine/DEPS[diff]
• components/download/quarantine/common_linux.cc[Added - diff]
• components/download/quarantine/common_linux.h[Renamed from components/download/quarantine/quarantine_constants_linux.h - diff]
• components/download/quarantine/common_mac.h[Added - diff]
• components/download/quarantine/common_mac.mm[Added - diff]
• components/download/quarantine/common_win.cc[Added - diff]
• components/download/quarantine/common_win.h[Added - diff]
• components/download/quarantine/quarantine.cc[diff]
• components/download/quarantine/quarantine.h[diff]
• components/download/quarantine/quarantine_linux.cc[diff]
• components/download/quarantine/quarantine_linux_unittest.cc[diff]
• components/download/quarantine/quarantine_mac.mm[diff]
• components/download/quarantine/quarantine_mac_unittest.mm[diff]
• components/download/quarantine/quarantine_win.cc[diff]
• components/download/quarantine/test_support.cc[Added - diff]
• components/download/quarantine/test_support.h[Added - diff]
• components/download/quarantine/test_support_linux.cc[Added - diff]
• components/download/quarantine/test_support_mac.mm[Added - diff]
• components/download/quarantine/test_support_win.cc[Added - diff]

Add a histogram recording how cache_storage hits kErrorStorage.

[email protected], [email protected]

Bug: 886898
Change-Id: I7519c327419c81b5eeb9dd83ac17850114a3795f
Reviewed-on: https://chromium-review.googlesource.com/1234636
Commit-Queue: Ben Kelly <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Reviewed-by: Robert Kaplow (sloooow) <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592962}

• content/browser/BUILD.gn[diff]
• content/browser/cache_storage/cache_storage.cc[diff]
• content/browser/cache_storage/cache_storage_cache.cc[diff]
• content/browser/cache_storage/cache_storage_cache_unittest.cc[diff]
• content/browser/cache_storage/cache_storage_histogram_utils.cc[Added - diff]
• content/browser/cache_storage/cache_storage_histogram_utils.h[Renamed from content/browser/cache_storage/cache_storage_histogram_macros.h - diff]
• content/browser/cache_storage/cache_storage_operation.cc[diff]
• content/browser/cache_storage/cache_storage_scheduler.cc[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

Update declarative_content.json docs

Update declarative_content.json docs for minor language and formatting

Bug: none
Change-Id: I254f52f83b42844559da1277070e53ba060153c0
Reviewed-on: https://chromium-review.googlesource.com/1225859
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Meggin Kearney <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592961}

• chrome/common/extensions/api/declarative_content.json[diff]

Roll src/third_party/skia 7b11354810a9..268707284dcd (16 commits)

https://skia.googlesource.com/skia.git/+log/7b11354810a9..268707284dcd


git log 7b11354810a9..268707284dcd --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] [skottie] GM exercising external font loading
2018-09-20 [email protected] send SkPMColor::toPMColor() through Sk4f_toL32()
2018-09-20 [email protected] Disable LCD text when drawing SkPictureImageFilter content
2018-09-20 [email protected] Always use portable fonts in image filter test
2018-09-20 [email protected] add interp-in-premul case to GM
2018-09-20 [email protected] Add new PolyUtils benches
2018-09-20 [email protected] SkDocument:  Factories now located in SkPDFDocument.h and SkXPSDocument.h
2018-09-20 [email protected] SkPDF: draw persepctive rectangles
2018-09-20 [email protected] Some SkPM4f cleanup
2018-09-20 [email protected] Remove SkAutoTCallIProc.
2018-09-20 [email protected] have SkConvertPixels use SkColorSpaceXformSteps
2018-09-20 [email protected] Roll third_party/externals/angle2 d511948b9f82..52ea49706fd7 (1 commits)
2018-09-20 [email protected] Fix/simplify equal_pixels
2018-09-20 [email protected] Document headers: IWYU
2018-09-20 [email protected] Use new build targets in continuous build of skottie and debugger.
2018-09-20 [email protected] Remove (unused) GrBlend.cpp, and some GrColor helpers


Created with:
  gclient setdep -r src/third_party/skia@268707284dcd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:878874,chromium:884150
[email protected]

Change-Id: Ic7fa8bc7070238dfbb1d7c014446989ed87ecfaa
Reviewed-on: https://chromium-review.googlesource.com/1236881
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592960}

• DEPS[diff]

Report Crostini usage asynchronously via DeviceStatusCollector

Add a user policy for Crostini usage logging which is disabled by
default.
If this policy is active, log a time window for the last app launch
and the used Termina version in prefs.
Report these in DeviceStatusCollector.

Bug: 844468, 883634
Test: Run unit and browser tests.
Change-Id: I90ba296c9284b987829f8907283873c8213fad9f
Reviewed-on: https://chromium-review.googlesource.com/1221947
Commit-Queue: Alex Oldemeier <[email protected]>
Reviewed-by: Bartosz Fabianowski <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592959}

• chrome/browser/chromeos/BUILD.gn[diff]
• chrome/browser/chromeos/crostini/crostini_manager.cc[diff]
• chrome/browser/chromeos/crostini/crostini_manager.h[diff]
• chrome/browser/chromeos/crostini/crostini_pref_names.cc[diff]
• chrome/browser/chromeos/crostini/crostini_pref_names.h[diff]
• chrome/browser/chromeos/crostini/crostini_reporting_util.cc[Added - diff]
• chrome/browser/chromeos/crostini/crostini_reporting_util.h[Added - diff]
• chrome/browser/chromeos/crostini/crostini_reporting_util_unittest.cc[Added - diff]
• chrome/browser/chromeos/crostini/crostini_util.cc[diff]
• chrome/browser/chromeos/policy/device_status_collector.cc[diff]
• chrome/browser/chromeos/policy/device_status_collector.h[diff]
• chrome/browser/chromeos/policy/device_status_collector_browsertest.cc[diff]
• chrome/browser/policy/configuration_policy_handler_list_factory.cc[diff]
• chrome/browser/ui/views/crostini/crostini_installer_view.cc[diff]
• chrome/common/pref_names.cc[diff]
• chrome/test/BUILD.gn[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• components/policy/proto/device_management_backend.proto[diff]
• components/policy/resources/policy_templates.json[diff]
• tools/metrics/histograms/enums.xml[diff]

Fix Omnibox disappears on loading itunes app URL

The problem is we discard the last committed item, if the request was
blocked, instead we should only discard that when the last item was not
native view.

Bug: 881690
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a
Reviewed-on: https://chromium-review.googlesource.com/1234953
Commit-Queue: Mohammad Refaat <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592958}

• ios/web/web_state/ui/crw_web_controller.mm[diff]

Roll src-internal d8dcf93795bb..b20563f5defb (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8dcf93795bb..b20563f5defb


Created with:
  gclient setdep -r src-internal@b20563f5defb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: Id355f77748012995e160a11e54d4a93a10657a4c
Reviewed-on: https://chromium-review.googlesource.com/1236484
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592957}

• DEPS[diff]

Roll src/third_party/catapult 3d81f7cc222b..b0768af22643 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/3d81f7cc222b..b0768af22643


git log 3d81f7cc222b..b0768af22643 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Fix /api/report/template
2018-09-20 [email protected] Add force commit to SharedPrefs
2018-09-20 [email protected] Add function to run benchmark both locally and on swarming.


Created with:
  gclient setdep -r src/third_party/catapult@b0768af22643

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:887579,chromium:863390
[email protected]

Change-Id: I0052555ff9d1cd652448e2b3af79e37681de72e0
Reviewed-on: https://chromium-review.googlesource.com/1236883
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592956}

• DEPS[diff]

Sync metrics protos with google3

Bug: internal b/115749837
Change-Id: I4f0b21097081415956f1b386f68916b50fd8de82
Reviewed-on: https://chromium-review.googlesource.com/1235289
Commit-Queue: Yi-Chun Gina Ko <[email protected]>
Commit-Queue: Ilya Sherman <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592955}

• third_party/metrics_proto/README.chromium[diff]
• third_party/metrics_proto/cast_logs.proto[diff]
• third_party/metrics_proto/system_profile.proto[diff]

Move test-launcher-* args for sanitizer tests src-side.

Bug: 794372
Change-Id: I6b6d81ab0c72fd1b781d03e242f78ddef24fef95
Reviewed-on: https://chromium-review.googlesource.com/1235015
Reviewed-by: Stephen Martinis <[email protected]>
Commit-Queue: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592954}

• testing/buildbot/chromium.clang.json[diff]
• testing/buildbot/chromium.memory.json[diff]
• testing/buildbot/waterfalls.pyl[diff]

Use AshUIControls for UI tests with no browser

LoginCursorTest.CursorHidden and OobeTest.Accelerator are still
crashing even after the refactoring of UIControls and aura::Env.
Actually, these tests do not require browser windows therefore
UIControlsOzone is created with nullptr WindowTreeHost which is
not expected.

Thinking about that, such test cases actually do controls for
the UI within Ash -- therefore AshUIControls should be used.

Test: interactive_ui_tests with --enable-features=SingleProcessMash
Bug: 883523
Change-Id: I3d6e1ecb569551a7eacfce979c4b543771f19fc6
Reviewed-on: https://chromium-review.googlesource.com/1236842
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592953}

• chrome/test/base/in_process_browser_test.cc[diff]

[layoutng] Simplify constraint space construction

Now that constraint spaces are stack allocated, there's no point in
having the builder be separate from the constructor. We can avoid some
duplication and just directly initialize the members from the builder.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5470a1be7e0f6e82f93af3fa263cc642e1d8cfbe
Reviewed-on: https://chromium-review.googlesource.com/1235216
Commit-Queue: Christian Biesinger <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592952}

• third_party/blink/renderer/core/layout/ng/ng_constraint_space.cc[diff]
• third_party/blink/renderer/core/layout/ng/ng_constraint_space.h[diff]
• third_party/blink/renderer/core/layout/ng/ng_constraint_space_builder.cc[diff]
• third_party/blink/renderer/core/layout/ng/ng_constraint_space_builder.h[diff]

Omnibox Triage Process - clarify unknown scope issues

I think this codifies the results of our discussion.

Is this the right place to put this content?  Do I need reminders of
it elsewhere (i.e., in the status or owners sections)?

Change-Id: Icfeb6551515727f02d0cb83450008ad77ed0275d
Reviewed-on: https://chromium-review.googlesource.com/1232523
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592951}

• components/omnibox/bug-triage.md[diff]

[Feed] Add Java side storage integration

Enable content and journal storage in FeedProcessScopeFactory.java.
Also fix type mismatch issue in Journal bridge, and handle empty
content mutation case.

Bug: 887116

Change-Id: I9333beb9141aab7a96e87d90baa8bef788b0b5e4
Reviewed-on: https://chromium-review.googlesource.com/1234263
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592950}

• chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedJournalBridge.java[diff]
• chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedJournalStorage.java[diff]
• chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java[diff]
• chrome/android/junit/src/org/chromium/chrome/browser/feed/FeedJournalStorageTest.java[diff]
• components/feed/core/feed_content_database.cc[diff]

Add NoHoverAfterLayoutChange to base::Feature

Add NoHoverAfterLayoutChange to base::Feature, so that we can run finch
experiment on this feature to see if there is any performance
improvement.

Bug: 877132
Change-Id: Id1048757f7f48bc1be68787347d5594644b9ac38
Reviewed-on: https://chromium-review.googlesource.com/1234036
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Pavel Feldman <[email protected]>
Commit-Queue: Lan Wei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592949}

• content/child/BUILD.gn[diff]
• content/child/runtime_features.cc[diff]
• third_party/blink/public/platform/web_runtime_features.h[diff]
• third_party/blink/renderer/platform/exported/web_runtime_features.cc[diff]
• ui/events/blink/blink_features.cc[diff]
• ui/events/blink/blink_features.h[diff]

Roll src/third_party/chromite 713f53360e2e..6dd0074561b7 (5 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/713f53360e2e..6dd0074561b7


git log 713f53360e2e..6dd0074561b7 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] manifest_version: Commit new buildspecs.
2018-09-20 [email protected] metadata_lib: Pretty print metadata.json
2018-09-20 [email protected] CIDB: Update readme docs.
2018-09-20 [email protected] CIDB: Add branch column to buildtable.
2018-09-20 [email protected] signing: Add Mock Signer commands for Firmware signers


Created with:
  gclient setdep -r src/third_party/chromite@6dd0074561b7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I11cbc35a8669774dfc8e435c11a130e04becf0c7
Reviewed-on: https://chromium-review.googlesource.com/1236483
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592948}

• DEPS[diff]

Remove Field Trial Support for Material Refresh

Material refresh is now on by default.

BUG=876090

Change-Id: I308da4d0ed5a4df6dc7104a573ed9063151caab0
Reviewed-on: https://chromium-review.googlesource.com/1229175
Commit-Queue: Robert Liao <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592947}

• ui/base/material_design/material_design_controller.cc[diff]

Migrate DomainReliabilityMonitor to NetworkConnectionTracker

This migrates DomainReliabilityMonitor from NetworkChangeManager to
NetworkConnectionTracker, which works with the network service enabled.

Bug: 887027
Change-Id: Icc22466c2272bdc45978218d1443c77810e7f663
Reviewed-on: https://chromium-review.googlesource.com/1234855
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592946}

• components/domain_reliability/BUILD.gn[diff]
• components/domain_reliability/DEPS[diff]
• components/domain_reliability/monitor.cc[diff]
• components/domain_reliability/monitor.h[diff]
• components/domain_reliability/monitor_unittest.cc[diff]
• components/domain_reliability/service_unittest.cc[diff]

Media Router: Delete MediaRouterActionPlatformDelegate.

r591131 unified code to close the overflow menu from the ui/layer, deleting
MediaRouterActionPlatformDelegate::CloseOverflowMenuIfOpen, removing the need
for a delegate. This CL removes the delegate interface and its implementations.
It should have no behavior change.

BUG=None

Change-Id: I54bba038673c6fbba2b84aa17ad63f4c9ed7e229
Reviewed-on: https://chromium-review.googlesource.com/1229776
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Derek Cheng <[email protected]>
Commit-Queue: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592945}

• chrome/browser/ui/BUILD.gn[diff]
• chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.h[Deleted - diff]
• chrome/browser/ui/cocoa/toolbar/media_router_action_platform_delegate_cocoa.mm[Deleted - diff]
• chrome/browser/ui/toolbar/media_router_action.cc[diff]
• chrome/browser/ui/toolbar/media_router_action.h[diff]
• chrome/browser/ui/toolbar/media_router_action_platform_delegate.h[Deleted - diff]
• chrome/browser/ui/toolbar/media_router_action_unittest.cc[diff]
• chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.cc[Deleted - diff]
• chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.h[Deleted - diff]

FrameMetrics: Adding comments for AddFrameProduced and AddFrameDisplayed

Change-Id: Ie83fb3f96f0d914a002fdcb9461066a2a29f5abe
Reviewed-on: https://chromium-review.googlesource.com/1231376
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Yi Xu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592944}

• ui/latency/frame_metrics.h[diff]

Make ServerWindow responsible for interior resize handle event routing.

Bug: 883072
Change-Id: I24380dc595a7446e463422848916b73845945861
Reviewed-on: https://chromium-review.googlesource.com/1227357
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592943}

• services/ws/server_window.cc[diff]
• services/ws/server_window_unittest.cc[diff]
• ui/aura/client/aura_constants.cc[diff]
• ui/aura/client/aura_constants.h[diff]

Roll src/third_party/angle 52ea49706fd7..4ce287e04201 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/52ea49706fd7..4ce287e04201


git log 52ea49706fd7..4ce287e04201 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Change the name of the opt'ed-in app from maps to cubey.


Created with:
  gclient setdep -r src/third_party/angle@4ce287e04201

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
[email protected]

Change-Id: I17c7fff9689dbdccf4e92a0e8b1baa24f65d03c1
Reviewed-on: https://chromium-review.googlesource.com/1236882
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592942}

• DEPS[diff]

[Cast Harmony] Re-enable MRDCV browsertest.

You can't run Views browsertests on Mac when views browser windows are disabled.

[email protected]

Bug: 883976
Change-Id: I4d318db3f58743f543e278f744e3926d6e9076e4
Reviewed-on: https://chromium-review.googlesource.com/1237151
Reviewed-by: mark a. foltz <[email protected]>
Commit-Queue: mark a. foltz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592941}

• chrome/browser/ui/views/media_router/media_router_dialog_controller_views_browsertest.cc[diff]
• chrome/test/BUILD.gn[diff]

mac: Remove unused cocoa bookmarks code.

Bug: 832676
Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b
Reviewed-on: https://chromium-review.googlesource.com/1236177
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592940}

• chrome/app/nibs/BUILD.gn[diff]
• chrome/app/nibs/BookmarkBarFolderWindow.xib[Deleted - diff]
• chrome/browser/ui/BUILD.gn[diff]
• chrome/browser/ui/bookmarks/bookmark_drag_drop.h[diff]
• chrome/browser/ui/cocoa/bookmarks/OWNERS[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_state.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_util.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.h[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell.mm[Deleted - diff]
• chrome/browser/ui/cocoa/bookmarks/bookmark_tree_browser_cell_unittest.mm[Deleted - diff]
• chrome/browser/ui/cocoa/browser_window_cocoa.h[diff]
• chrome/browser/ui/cocoa/browser_window_cocoa.mm[diff]
• chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm[diff]
• chrome/browser/ui/cocoa/browser_window_controller.h[diff]
• chrome/browser/ui/cocoa/browser_window_controller.mm[diff]
• chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm[diff]
• chrome/browser/ui/cocoa/browser_window_controller_private.mm[diff]
• chrome/browser/ui/cocoa/browser_window_controller_unittest.mm[diff]
• chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm[diff]
• chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm[diff]
• chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm[diff]
• chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc[diff]
• chrome/test/BUILD.gn[diff]

Reset screen time based on the timestamp of last screen time reset.

Bug: 882588
Change-Id: I4f12426d6e2027640a6645cac9bd6b62b1a34fc5
Reviewed-on: https://chromium-review.googlesource.com/1232478
Reviewed-by: Rahul Chaturvedi <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592939}

• chrome/browser/chromeos/child_accounts/screen_time_controller.cc[diff]

Revert "Revert "[css-tables] Force layout when colgroups are removed or added""

Fixes an uninitialised variable caught by MSAN.

This reverts commit 66a74d2f7e1b369ce086c3c41ee089d72f3d0018.

Change-Id: I1e896476fe201fb05072970220bab5c3b20588a2
Reviewed-on: https://chromium-review.googlesource.com/1233746
Commit-Queue: David Grogan <[email protected]>
Reviewed-by: Emil A Eklund <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592938}

• third_party/WebKit/LayoutTests/external/wpt/css/css-tables/width-distribution/computing-column-measure-2.html[Added - diff]
• third_party/blink/renderer/core/layout/layout_table.cc[diff]
• third_party/blink/renderer/core/layout/layout_table.h[diff]

Revert "[ios] Fix VoiceOver Issues in Tabgrid"

This reverts commit fbe67a9526a8ada8ab37b2ce9e7b66dd5a39cdae.

Reason for revert: Breaks TabSwitcherTransitionTestCase\testRotationsWhileSwitcherIsNotActive

Original change's description:
> [ios] Fix VoiceOver Issues in Tabgrid
> 
> - Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page.
> - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable.
> 
> Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45
> 
> Bug: 880079
> Change-Id: I0696786292bec375af9d5326a790700000114559
> Reviewed-on: https://chromium-review.googlesource.com/1221474
> Commit-Queue: Chris Lu <[email protected]>
> Reviewed-by: Mark Cogan <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#592818}

[email protected],[email protected]

Change-Id: Idb378ca1c1a1405275975e47956ac94d09865ab1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880079
Reviewed-on: https://chromium-review.googlesource.com/1237174
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592937}

• ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm[diff]

cc: Send early DidNotProduceFrame if draw isn't expected

Send an early DidNotProduceFrame if the scheduler uses a late deadline,
and no new frame is expected.  The DisplayScheduler uses this as a
signal to draw if other producers have submitted frames.

This is intended as a short-term fix to solve smoothness issues with
surface for video with 30fps videos.  Ideally the DisplayCompositor will
have some followups as well so that one client that is slow to respond
will not cause smoothness issues with another client.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icf2f067dd08836de24ea5d0cdc896dc433062d5c
Bug: 874676
Reviewed-on: https://chromium-review.googlesource.com/1211917
Commit-Queue: Sunny Sachanandani <[email protected]>
Reviewed-by: enne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592936}

• cc/scheduler/scheduler.cc[diff]
• cc/scheduler/scheduler.h[diff]
• cc/scheduler/scheduler_unittest.cc[diff]

Omnibox: Disable Steady State Elisions by default for 71+.

Bug: NONE
Change-Id: Ibb8098e156f63a43b82b25d4ba84f43002d27911
Reviewed-on: https://chromium-review.googlesource.com/1236927
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592935}

• components/omnibox/browser/omnibox_field_trial.cc[diff]
• testing/variations/fieldtrial_testing_config.json[diff]

Variations: Ignore seed when using test config

Chrome uses IsFetchingEnabled() to enable getting the seed under any of
these conditions:
  • is_chrome_branded
  • --variations-server-url
  • g_should_fetch_for_testing

Chrome also enables the test config if none of these conditions are met:
  • fieldtrial_testing_like_official_build
  • is_chrome_branded
  • --disable-field-trial-config
  • --force-fieldtrials
  • --variations-server-url
(See VariationsFieldTrialCreator::SetupFieldTrials().)

So by default (is_chrome_branded=false), the seed will be disabled and
the test config will be enabled. In the released builds
(is_chrome_branded=true), the seed will be enabled and the test config
will be disabled. But depending on flags and build args, it's possible
to enable both. The same experiment in both places will then be added
twice, hitting a DCHECK in FeatureList::RegisterFieldTrialOverride().

WebView shares the same conditions for enabling the test config, but
before this change, would always use the seed as well, since WebView
doesn't call IsFetchingEnabled().

BUG=884827

Change-Id: I3b8281a3a44ebbae894e744fc0a84d6d1f94a0d4
Reviewed-on: https://chromium-review.googlesource.com/1228913
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592934}

• components/variations/service/variations_field_trial_creator.cc[diff]
• components/variations/service/variations_field_trial_creator_unittest.cc[diff]

[Duet] Fix accessibility button issues

This patch fixes some ambiguous wording for light/dark mode icons in
favor of incognito/normal and flips the incorrect accessibility text
labels.

This patch also makes buttons with no drawable invisible so
accessibility does not try to focus them.

Bug: 887001, 887010
Change-Id: Ie7ae4461035064d3aeac5c929fc9f3eb1296bbcd
Reviewed-on: https://chromium-review.googlesource.com/1235203
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592933}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java[diff]

Roll src-internal a7a0a5198543..d8dcf93795bb (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7a0a5198543..d8dcf93795bb


Created with:
  gclient setdep -r src-internal@d8dcf93795bb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I0b32a37c27b13416ab8e6dc6e70d5086f3e69258
Reviewed-on: https://chromium-review.googlesource.com/1236481
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592932}

• DEPS[diff]

[AdsMetrics] Remove unused metric, PageLoad.Clients.Ads.All.ResourceTypeWhenNoFrameFound

Removes a metric that showed the resources loaded in non-ad
frames. This was never referenced so it's time to remove it.

Bug: 884233
Change-Id: Icc3522b515d757f4b58c30edcf7373da98453423
Reviewed-on: https://chromium-review.googlesource.com/1233937
Commit-Queue: Josh Karlin <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592931}

• chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc[diff]
• chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

remove 16-byte alignment from deflate_state::crc0

We noticed recently on the Skia tree that if we build Chromium's zlib
with GCC, -O3, -m32, and -msse2, deflateInit2_() crashes.  Might also
need -fPIC... not sure.

I tracked this down to a `movaps` (16-byte aligned store) to an address
that was only 8-byte aligned.  This address was somewhere in the middle
of the deflate_state struct that deflateInit2_()'s job is to initialize.

That deflate_state struct `s` is allocated using ZALLOC, which calls any
user supplied zalloc if set, or the default if not.  Neither one of
these has any special alignment contract, so generally they'll tend to
be 2*sizeof(void*) aligned.  On 32-bit builds, that's 8-byte aligned.

But because we've annotated crc0 as zalign(16), the natural alignment of
the whole struct is 16-byte, and a compiler like GCC can feel free to
use 16-byte aligned stores to parts of the struct that are 16-byte
aligned, like the beginning, crc0, or any other part before or after
crc0 that happens to fall on a 16-byte boundary.  With -O3 and -msse2,
GCC does exactly that, writing a few of the fields with one 16-byte
store.

The fix is simply to remove zalign(16).  All the code that manipulates
this field was actually already using unaligned loads and stores.  You
can see it all right at the top of crc_folding.c, CRC_LOAD and CRC_SAVE.

This bug comes from the Intel performance patches we landed a few years
ago, and isn't present in upstream zlib, Android's zlib, or Google's
internal zlib.

It doesn't seem to be tickled by Clang, and won't happen on 64-bit GCC
builds: zalloc is likely 16-byte aligned there.  I _think_ it's possible
for it to trigger on non-x86 32-bit builds with GCC, but haven't tested
that.  I also have not tested MSVC.

The moved comment is entirely to appease git cl format.

Change-Id: Ie2d8eb9ddefa1e35e6d21ee4b29797f6949b0687
Reviewed-on: https://chromium-review.googlesource.com/1236613
Reviewed-by: Leon Scroggins <[email protected]>
Commit-Queue: Mike Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592930}

• third_party/zlib/deflate.h[diff]

assistant: disable logging to stderr

Bug: b:115397214
Test: locally build and test
Change-Id: Ia7ccdd15906bb195e766f5a93db9e0ed2c0039ca
Reviewed-on: https://chromium-review.googlesource.com/1220812
Reviewed-by: Muyuan Li <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592929}

• chromeos/services/assistant/utils.cc[diff]

Support exclusion of x?x?x?hdpi resources.

A downstream project wants to exclude hdpi and higher density resources,
so I figured I'd land support here to reduce rebase burden.

Change-Id: I780b09703f822f455912ac9a119acb3dd56112bb
Reviewed-on: https://chromium-review.googlesource.com/1234221
Reviewed-by: agrieve <[email protected]>
Reviewed-by: Bo <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592928}

• android_webview/system_webview_apk_tmpl.gni[diff]
• build/android/gyp/compile_resources.py[diff]
• build/config/android/internal_rules.gni[diff]
• build/config/android/rules.gni[diff]
• chrome/android/chrome_public_apk_tmpl.gni[diff]

Update Field Trails with AppLauncherRefresh expirement

Create a field trail entry before experimenting with 50% Beta

Bug: 850760
Change-Id: Ie2796f43a0443ac8bc8a77ac2db8057b32d989d2
Reviewed-on: https://chromium-review.googlesource.com/1234356
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592927}

• testing/variations/fieldtrial_testing_config.json[diff]

Roll src/third_party/perfetto e6dfe41ffa6e..7397af8da50b (1 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/e6dfe41ffa6e..7397af8da50b


git log e6dfe41ffa6e..7397af8da50b --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Merge "Add performance debug mode"


Created with:
  gclient setdep -r src/third_party/perfetto@7397af8da50b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: Ib7a81bba65f5872420a79431273549ac288d1889
Reviewed-on: https://chromium-review.googlesource.com/1236482
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592926}

• DEPS[diff]

Removes redundant media:: prefixes within media namespace in media/gpu/vaapi directory.

Bug: no bug
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If0f518894dd1264931e224f5103f2d6f75e343cd
Reviewed-on: https://chromium-review.googlesource.com/1236674
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Madeleine Barowsky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592925}

• media/gpu/vaapi/h264_encoder.h[diff]
• media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc[diff]
• media/gpu/vaapi/vaapi_jpeg_encode_accelerator.h[diff]
• media/gpu/vaapi/vaapi_video_encode_accelerator.cc[diff]
• media/gpu/vaapi/vp8_encoder.h[diff]

Update Crashpad to 688dcfa22ee906f83d49b905b69c7c53347c92d9

9ae453628f50 android: handle RELRO sharing by the Chromium linker
688dcfa22ee9 android: handle modules loaded from zipfiles

Change-Id: Ib295fb1e0f0571c38f9bf5603eda349b9f8e15da
Reviewed-on: https://chromium-review.googlesource.com/1236467
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Joshua Peraza <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592924}

• third_party/crashpad/README.chromium[diff]
• third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.cc[diff]
• third_party/crashpad/crashpad/snapshot/elf/elf_image_reader.h[diff]
• third_party/crashpad/crashpad/snapshot/linux/process_reader_linux.cc[diff]
• third_party/crashpad/crashpad/util/linux/memory_map.cc[diff]
• third_party/crashpad/crashpad/util/linux/memory_map.h[diff]
• third_party/crashpad/crashpad/util/linux/memory_map_test.cc[diff]

Poke GPU watchdog a few more times during context destruction.

We still see a bit of hang at buffer_manager() destruction, which is the
beginning of ContextGroup destruction. So we add a few pokes in context
destruction before the ContextGroup destruction.

BUG=749046
TEST=crash reports go down
[email protected]

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4726e63f2cf4fa5c1471a25ef65f8d8ac9411c09
Reviewed-on: https://chromium-review.googlesource.com/1237114
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592923}

• gpu/command_buffer/service/context_group.h[diff]
• gpu/command_buffer/service/gles2_cmd_decoder.cc[diff]

Add the "Lite" string to the Previews UI in CCT

This adds the string in the URLBar display text. See mock linked in the
bug.

Also changes the string name in the grd file since it's now used in
more than just the verbose status.

Bug: 886947
Change-Id: I41df81c607a5641e8c663b192423559ba5e84ba8
Reviewed-on: https://chromium-review.googlesource.com/1234533
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Doug Arnett <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592922}

• chrome/android/java/res/layout/custom_tabs_toolbar.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarDataProvider.java[diff]
• chrome/android/java/strings/android_chrome_strings.grd[diff]

Throw exception upon trying to play invalid worklet animations

Currently we are printing out a console message upon trying to play an
invalid worklet animation, e.g. no-keyframe effect. Rather, an exception
should be thrown.

Note that regular animations accept effects without any keyframes, but
it currently does not make much sense in our implementation of worklet
animation.

It's a little bit strict to throw ATM, but once our implementation is
able to support it we can remove this exception.

Bug: 882939
Change-Id: Ia63b67b70adeb132f5df2c8679935551ec3ac1d7
Reviewed-on: https://chromium-review.googlesource.com/1225091
Reviewed-by: Majid Valipour <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592921}

• third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-with-invalid-effect.html[Added - diff]
• third_party/blink/renderer/modules/animationworklet/worklet_animation.cc[diff]
• third_party/blink/renderer/modules/animationworklet/worklet_animation.h[diff]
• third_party/blink/renderer/modules/animationworklet/worklet_animation.idl[diff]
• third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc[diff]

Roll src/third_party/depot_tools a5ac303c5308..9cba9ffdfdc6 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5ac303c5308..9cba9ffdfdc6


git log a5ac303c5308..9cba9ffdfdc6 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Add the crcmod wheel for gsutil, to get it to shut up.
2018-09-20 [email protected] Suppress URLErrors when uploading metrics.


Created with:
  gclient setdep -r src/third_party/depot_tools@9cba9ffdfdc6

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:875100,chromium:887540
[email protected]

Change-Id: I9e8794867feb346151dffeb261dc9f16089db3c5
Reviewed-on: https://chromium-review.googlesource.com/1236880
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592920}

• DEPS[diff]

[Explore Sites] Adding URL fetcher for Explore Sites.

This will be used to fetch the data from our API endpoint. It is only a fetcher
and does not do any processing of the data that is downloaded.

Bug: 867488
Change-Id: Ic7506af2523632c1173333ddf2a1f2183b27f72f
Reviewed-on: https://chromium-review.googlesource.com/1229013
Commit-Queue: Jonathan Freed <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592919}

• chrome/browser/BUILD.gn[diff]
• chrome/browser/android/explore_sites/catalog.proto[diff]
• chrome/browser/android/explore_sites/explore_sites_fetcher.cc[Added - diff]
• chrome/browser/android/explore_sites/explore_sites_fetcher.h[Added - diff]
• chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc[Added - diff]
• chrome/browser/android/explore_sites/explore_sites_types.h[diff]
• chrome/browser/android/explore_sites/ntp_json_fetcher.cc[diff]
• chrome/browser/android/explore_sites/url_util.cc[diff]
• chrome/browser/android/explore_sites/url_util.h[diff]
• chrome/browser/android/explore_sites/url_util_experimental.cc[Added - diff]
• chrome/browser/android/explore_sites/url_util_experimental.h[Added - diff]
• chrome/test/BUILD.gn[diff]

Fix 64 bit truncation errors in blink/core/html

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I14b8c97a5c749acef25b7b343cb5952c6d2dad25
Reviewed-on: https://chromium-review.googlesource.com/1234219
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592918}

• third_party/blink/renderer/core/html/canvas/image_data_test.cc[diff]
• third_party/blink/renderer/core/html/custom/custom_element.h[diff]
• third_party/blink/renderer/core/html/custom/custom_element_reaction_queue.h[diff]
• third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc[diff]
• third_party/blink/renderer/core/html/custom/custom_element_registry.h[diff]
• third_party/blink/renderer/core/html/custom/v0_custom_element_callback_queue.h[diff]
• third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.cc[diff]
• third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.h[diff]
• third_party/blink/renderer/core/html/forms/date_time_edit_element.cc[diff]
• third_party/blink/renderer/core/html/forms/date_time_edit_element.h[diff]
• third_party/blink/renderer/core/html/forms/date_time_fields_state.cc[diff]
• third_party/blink/renderer/core/html/forms/email_input_type.cc[diff]
• third_party/blink/renderer/core/html/forms/external_popup_menu.cc[diff]
• third_party/blink/renderer/core/html/forms/file_input_type.cc[diff]
• third_party/blink/renderer/core/html/forms/form_controller.cc[diff]
• third_party/blink/renderer/core/html/forms/form_controller.h[diff]
• third_party/blink/renderer/core/html/forms/form_data.cc[diff]
• third_party/blink/renderer/core/html/forms/html_input_element.cc[diff]
• third_party/blink/renderer/core/html/forms/html_select_element.cc[diff]
• third_party/blink/renderer/core/html/forms/html_select_element.h[diff]
• third_party/blink/renderer/core/html/forms/range_input_type.cc[diff]
• third_party/blink/renderer/core/html/html_dimension.cc[diff]
• third_party/blink/renderer/core/html/html_element.cc[diff]
• third_party/blink/renderer/core/html/html_embed_element.cc[diff]
• third_party/blink/renderer/core/html/html_frame_set_element.h[diff]
• third_party/blink/renderer/core/html/html_link_element.cc[diff]
• third_party/blink/renderer/core/html/html_object_element.cc[diff]
• third_party/blink/renderer/core/html/html_plugin_element.cc[diff]
• third_party/blink/renderer/core/html/html_slot_element.cc[diff]
• third_party/blink/renderer/core/html/html_slot_element.h[diff]
• third_party/blink/renderer/core/html/imports/html_import_loader.cc[diff]
• third_party/blink/renderer/core/html/imports/html_imports_controller.h[diff]
• third_party/blink/renderer/core/html/media/html_media_element.cc[diff]
• third_party/blink/renderer/core/html/media/media_fragment_uri_parser.cc[diff]
• third_party/blink/renderer/core/html/parser/atomic_html_token.h[diff]
• third_party/blink/renderer/core/html/parser/background_html_input_stream.cc[diff]
• third_party/blink/renderer/core/html/parser/background_html_input_stream.h[diff]
• third_party/blink/renderer/core/html/parser/css_preload_scanner.cc[diff]
• third_party/blink/renderer/core/html/parser/html_document_parser.cc[diff]
• third_party/blink/renderer/core/html/parser/html_formatting_element_list.cc[diff]
• third_party/blink/renderer/core/html/parser/html_formatting_element_list.h[diff]
• third_party/blink/renderer/core/html/parser/html_meta_charset_parser.cc[diff]
• third_party/blink/renderer/core/html/parser/html_meta_charset_parser.h[diff]
• third_party/blink/renderer/core/html/parser/html_preload_scanner.h[diff]
• third_party/blink/renderer/core/html/parser/html_source_tracker.cc[diff]
• third_party/blink/renderer/core/html/parser/html_srcset_parser.cc[diff]
• third_party/blink/renderer/core/html/parser/html_token.h[diff]
• third_party/blink/renderer/core/html/parser/html_tokenizer.cc[diff]
• third_party/blink/renderer/core/html/parser/html_tokenizer.h[diff]
• third_party/blink/renderer/core/html/parser/text_resource_decoder.cc[diff]
• third_party/blink/renderer/core/html/parser/text_resource_decoder.h[diff]
• third_party/blink/renderer/core/html/parser/xss_auditor.cc[diff]
• third_party/blink/renderer/core/html/parser/xss_auditor.h[diff]
• third_party/blink/renderer/core/html/time_ranges.cc[diff]
• third_party/blink/renderer/core/html/track/automatic_track_selection.cc[diff]
• third_party/blink/renderer/core/html/track/cue_timeline.cc[diff]
• third_party/blink/renderer/core/html/track/loadable_text_track.cc[diff]
• third_party/blink/renderer/core/html/track/loadable_text_track.h[diff]
• third_party/blink/renderer/core/html/track/text_track.cc[diff]
• third_party/blink/renderer/core/html/track/text_track_cue_list.cc[diff]
• third_party/blink/renderer/core/html/track/text_track_cue_list.h[diff]
• third_party/blink/renderer/core/html/track/text_track_list.cc[diff]
• third_party/blink/renderer/core/html/track/vtt/buffered_line_reader_test.cc[diff]
• third_party/blink/renderer/core/html/track/vtt/vtt_parser.cc[diff]
• third_party/blink/renderer/core/html/track/vtt/vtt_scanner.cc[diff]
• third_party/blink/renderer/core/html/track/vtt/vtt_scanner.h[diff]

Roll src/third_party/chromite 0086f7aa8400..713f53360e2e (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0086f7aa8400..713f53360e2e


git log 0086f7aa8400..713f53360e2e --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] chromeos_config: Allow multiple sharded tests on one board.


Created with:
  gclient setdep -r src/third_party/chromite@713f53360e2e

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: Ic33e7ad5529fbd83eb0a3992bf40307feea5737d
Reviewed-on: https://chromium-review.googlesource.com/1236479
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592917}

• DEPS[diff]

history: adds minimal memory dump information for history

Before I add more exhaustive information I want to make sure I'm on the right
track. This adds the count of the number of outstanding requests to add a
page (url and other information) that haven't been processed yet.

BUG=807009
TEST=none

Change-Id: Ieb18fe74e9e91fe4f99eb1a791b04367c60cfd0d
Reviewed-on: https://chromium-review.googlesource.com/1234240
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592916}

• base/trace_event/memory_infra_background_whitelist.cc[diff]
• components/history/core/browser/history_service.cc[diff]

[PaintTouchActionRects] Fix some frame throttling tests

This test changes expectation for some frame throttling tests with
PaintTouchActionRects enabled. The behavior is slightly different in the
unit test and the comments explains why.

Bug: 881890
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
Change-Id: I0e6fdeebcbe016675ee082f38d8da66ce30abbeb
Reviewed-on: https://chromium-review.googlesource.com/1237056
Commit-Queue: Xida Chen <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592915}

• third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc[diff]
• third_party/blink/renderer/core/scheduler/frame_throttling_test.cc[diff]

Smart Lock: Remove the setup/disable button in lockScreen settings.

When multidevice flags are turned on. This is a stop-gap measure to
prevent users from running through the deprecated Smart Lock setup flow
when in the new multidevice world.

[email protected]

Bug: 881924
Test: none
Change-Id: Ifec2bd324e55592f14a50fe6cb5331496f010eff
Reviewed-on: https://chromium-review.googlesource.com/1236840
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: James Hawkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592914}

• chrome/browser/resources/settings/people_page/lock_screen.html[diff]
• chrome/browser/resources/settings/people_page/lock_screen.js[diff]

Speculative fix for flakiness of MemoryPressureLoadsNotAllTabs.

The test flakily crashes with an unknown callstack (the crash is not
reproducible locally).  The speculation is that the crash is related
to dereferencing a null base::MemoryPressureMonitor::Get().  If this is
indeed the case, then the crash should be fixed by using
base::test::FakeMemoryPressureMonitor in the test (rather than directly
dispatching a memory pressure notification from the test).

Bug: 887545
Change-Id: Ib922ebe4c7f85ec028f4bb202f2357c71e20687a
Reviewed-on: https://chromium-review.googlesource.com/1236502
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592913}

• chrome/browser/sessions/session_restore_browsertest.cc[diff]

Highlight filename in filepaths detected by Chrome Cleanup Tool.

Highlight the file name with strong tag, so that users can scan the list easily.

Bug: crbug.com/883737
Change-Id: Iaccf05983efe0414ce39fe35c1c89be4b4102d12
Reviewed-on: https://chromium-review.googlesource.com/1231835
Commit-Queue: Che-yu Wu <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Reviewed-by: proberge <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592912}

• chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html[diff]
• chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js[diff]
• chrome/browser/resources/settings/chrome_cleanup_page/items_to_remove_list.html[diff]
• chrome/browser/resources/settings/chrome_cleanup_page/items_to_remove_list.js[diff]
• chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc[diff]
• chrome/test/data/webui/settings/chrome_cleanup_page_test.js[diff]

Update WebAuthn two error strings.

Replace "We couldn't verify your identity on this device" with the
string “Your identity couldn’t be verified”.

Bug: 887390
Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3
Reviewed-on: https://chromium-review.googlesource.com/1236002
Reviewed-by: Martin Kreichgauer <[email protected]>
Reviewed-by: Jun Choi <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592911}

• chrome/app/generated_resources.grd[diff]

[Feed] Enable existing test and add new tests

+ Parameterized some more tests in NewTabPageTest
+ Add some tests for FeedNewTabPage on the header views

Bug: 860055
Change-Id: Ie86d67d4e852117eb4074db9c522bbc219d5d4dc
Reviewed-on: https://chromium-review.googlesource.com/1227178
Commit-Queue: Becky Zhou <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592910}

• chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java[diff]
• chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPageMediator.java[diff]
• chrome/android/feed/feed_java_sources.gni[diff]
• chrome/android/java/res/layout/personalized_signin_promo_view_modern_content_suggestions.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PersonalizedPromoViewHolder.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/feed/FeedNewTabPageTest.java[Added - diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java[diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/NewTabPageTestUtils.java[diff]
• chrome/test/data/android/render_tests/NewTabPageTest.focus_fake_box.Nexus_5-19.png[Added - diff]
• chrome/test/data/android/render_tests/NewTabPageTest.sign_in_promo.Nexus_5-19.png[Added - diff]

Cleanup a speculative fix for a crash

The fix did not work and the issue turned out to be something else. Cleaning up
most of the changes made in master@{#591833}.

Bug: 878359
Change-Id: I5432523622a82743d1c67e2768f70b437e580a22
Reviewed-on: https://chromium-review.googlesource.com/1236838
Reviewed-by: James MacLean <[email protected]>
Commit-Queue: Ehsan Karamad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592909}

• extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.cc[diff]

[CrOS MultiDevice] Block false Settings error from ambiguous listener.

The settings-multidevice-setup-page listens for the event 'close'
as a proxy for the password prompt being confirmed. However, the
event type 'close' is ubiquitous to cr-dialog so it also fires when
the forget device dialog is closed on the subpage, which causes the
assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)"
in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to
fail.

This CL only calls onPasswordPromptDialogClose_ if the close event came
from the MultiDevice page's password prompt and stops the event's
propagation.

Bug: 887160
Change-Id: I5740061c8f9e08ee5ba9e8d99862bcec6b0a6677
Reviewed-on: https://chromium-review.googlesource.com/1235321
Commit-Queue: Jordy Greenblatt <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Hector Carmona <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592908}

• chrome/browser/resources/settings/multidevice_page/multidevice_page.html[diff]
• chrome/browser/resources/settings/multidevice_page/multidevice_page.js[diff]
• chrome/test/data/webui/settings/multidevice_page_tests.js[diff]

[SuperSize] HTML Viewer: Fix indents in .html files.

Changing 4-indent to 2-indent. Also:
- Make <style> and <script> tags indent from start of line.
- Fix several missing ';' in JS.

Bug: 880671
Change-Id: Iddda84bbdcf5040935d27643925aebb1433580c7
Reviewed-on: https://chromium-review.googlesource.com/1237141
Commit-Queue: Samuel Huang <[email protected]>
Reviewed-by: Eric Stevenson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592907}

• tools/binary_size/libsupersize/static/index.html[diff]
• tools/binary_size/libsupersize/static/milestones.html[diff]

Revert "Install app to first available position in app list"

This reverts commit e39c47e5986f7927d7330d923364aae8a4a5d861.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Install app to first available position in app list
> 
> Changes:
> 1. Calculate the first available position in AppListModelUpdater for
>    newly added item.
> 2. Add test coverage.
> 
> Bug: 883939
> Test: AppListSyncableServiceTest.FirstAvailablePosition
> Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319
> Reviewed-on: https://chromium-review.googlesource.com/1231193
> Commit-Queue: Weidong Guo <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Reviewed-by: Steven Bennetts <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#592539}

[email protected],[email protected],[email protected]

Change-Id: I03fc07c2f963eb2e569e170d8175a47c7f174fe1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 883939
Reviewed-on: https://chromium-review.googlesource.com/1237144
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592906}

• ash/app_list/views/apps_grid_view.cc[diff]
• ash/public/cpp/app_list/app_list_config.cc[diff]
• ash/public/cpp/app_list/app_list_config.h[diff]
• chrome/browser/ui/BUILD.gn[diff]
• chrome/browser/ui/app_list/app_context_menu_unittest.cc[diff]
• chrome/browser/ui/app_list/app_list_model_updater.cc[Deleted - diff]
• chrome/browser/ui/app_list/app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc[diff]
• chrome/browser/ui/app_list/arc/arc_app_item.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_item.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_item.h[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/crostini/crostini_app_item.cc[diff]
• chrome/browser/ui/app_list/crostini/crostini_app_model_builder.cc[diff]
• chrome/browser/ui/app_list/extension_app_item.cc[diff]
• chrome/browser/ui/app_list/internal_app/internal_app_item.cc[diff]
• chrome/browser/ui/app_list/internal_app/internal_app_item.h[diff]
• chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.h[diff]

Give content_shell message headers include guards

This is in preparation for jumbo compiling content/shell.

IPC headers generate code by being included multiple times with
different macros. This requires careful juggling of inclusions
and jumbo is not careful with when headers are included. In most
of the code this has already been solved by adding include guards
but not in content/shell until this patch.

Bug: 886902
Change-Id: I84644fba628a827dfd7825d97844aacca3a9cd8e
Reviewed-on: https://chromium-review.googlesource.com/1233743
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592905}

• content/shell/common/layout_test/OWNERS[diff]
• content/shell/common/layout_test/layout_test_messages.cc[diff]
• content/shell/common/layout_test/layout_test_messages.h[diff]
• content/shell/common/shell_messages.cc[diff]
• content/shell/common/shell_messages.h[diff]

[GM2] Take pixel offsets into account when drawing toolbar top stroke

BUG=877647
R=pkasting

Change-Id: I37b7d06209890a59262b0363c30fc70e809329ed
Reviewed-on: https://chromium-review.googlesource.com/1194674
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592904}

• chrome/browser/ui/views/frame/browser_non_client_frame_view.cc[diff]
• chrome/browser/ui/views/frame/browser_non_client_frame_view.h[diff]
• chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc[diff]
• chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm[diff]
• chrome/browser/ui/views/frame/browser_root_view.cc[diff]
• chrome/browser/ui/views/frame/browser_root_view.h[diff]
• chrome/browser/ui/views/frame/browser_view.cc[diff]
• chrome/browser/ui/views/frame/browser_view.h[diff]
• chrome/browser/ui/views/frame/glass_browser_frame_view.cc[diff]
• chrome/browser/ui/views/frame/opaque_browser_frame_view.cc[diff]
• chrome/browser/ui/views/tabs/tab_strip.cc[diff]

Use NotFoundError instead of InvalidPointerId

This cl follows the new pointerevent spec which
uses more common WebIDL specified exception
NotFoundError instead of defining new
InvalidPointerId exception.

Bug: 885321
Change-Id: I28e946ffcb96c9fb4f70c76a4b9c09be620f981d
Reviewed-on: https://chromium-review.googlesource.com/1231990
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Ella Ge <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Navid Zolghadr <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592903}

• third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual.html[diff]
• third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual.html[diff]
• third_party/blink/renderer/core/dom/dom_exception.cc[diff]
• third_party/blink/renderer/core/dom/element.cc[diff]
• third_party/blink/renderer/platform/bindings/exception_code.h[diff]

WebView: Configure entropy providers

This is in preparation to enable permanent-consistency and GWS-visible
variations experiments in WebView.

For experiments which must keep the same group across runs, there are
"entropy providers" used to generate deterministic, pseudorandom group
assignments. Chrome has 2 providers: the "low entropy provider" is
seeded by kMetricsLowEntropySource; the "default entropy provider",
seeded by both the low entropy source, and also the UMA client ID, if
it's available. (If UMA is disabled, Chrome will have no client ID.)

WebView uses GMS to determine whether UMA is enabled, which is very
slow. So only use the low entropy provider in WebView, and seed it with
the low entropy source. (Before this change, WebView's provider was
seeded with the client ID, which has too many random bits, and blocked
enabling GWS-visible experiments.)

Since WebView no longer uses the client ID as an entropy source, we
don't need to load the ID so early in startup, so remove the code for
pre-loading the ID. It will only be loaded later, asynchronously, in
AwMetricsServiceClient.

AwFieldTrialCreator must call into MetricsStateManager to get these
entropy providers. But WebView's MetricsStateManager is owned by
AwMetricsServiceClient, which was not initialized until after
AwFieldTrialCreator. So initialize AwMetricsServiceClient sooner, and
within AwMetricsServiceClient, create the MetricsStateManager before the
asynchronous call, so that AwFieldTrialCreator can use it immediately.

AwFieldTrialCreator is now initialized with a null
URLRequestContextGetter. This is fine because this field is unused since
commit a5febff94dd70a488bd1. It will be removed in a separate change.

BUG=866722

Change-Id: I31451924e97406db8a9f3efadcab6402a07007ea
Reviewed-on: https://chromium-review.googlesource.com/1227531
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592902}

• android_webview/browser/aw_browser_context.cc[diff]
• android_webview/browser/aw_browser_main_parts.cc[diff]
• android_webview/browser/aw_field_trial_creator.cc[diff]
• android_webview/browser/aw_metrics_service_client.cc[diff]
• android_webview/browser/aw_metrics_service_client.h[diff]
• android_webview/java/src/org/chromium/android_webview/AwMetricsServiceClient.java[diff]
• android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java[diff]

Roll src/native_client 6f1149defa9e..b64cb7b68093 (1 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/6f1149defa9e..b64cb7b68093


git log 6f1149defa9e..b64cb7b68093 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Whitespace change to kick off jobs


Created with:
  gclient setdep -r src/native_client@b64cb7b68093

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:646142
[email protected]

Change-Id: I0c6dfd24a7afeaa433697cb30527f180e1460a94
Reviewed-on: https://chromium-review.googlesource.com/1236879
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592901}

• DEPS[diff]

DevTools: Accessibility.getFullAXTree protocol method

This will allow Puppeteer to expose snapshots of the accessibility tree.

Bug: 887173

Change-Id: I296e68bb8e8a99f165b1a3356fd0b56c76334a0e
Reviewed-on: https://chromium-review.googlesource.com/1235307
Commit-Queue: Joel Einbinder <[email protected]>
Reviewed-by: Alice Boxhall <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592900}

• third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getFullAXTree-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-getFullAXTree.js[Added - diff]
• third_party/blink/renderer/core/inspector/browser_protocol.pdl[diff]
• third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc[diff]
• third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.h[diff]
• third_party/blink/renderer/modules/modules_initializer.cc[diff]

Create isolation target for WebView CTS tests and capture gn-paths arg in pydeps.

The isolation target will be used by swarming, the gn-paths arg was not being
captured in pydeps files generated with build/print_python_deps.py, but it is
needed by the isolation target to properly locate its depenencies.

Bug: 803245
Change-Id: I15bf4c8f7d1cd24a6ce1fcb4b44aeeff42786943
Reviewed-on: https://chromium-review.googlesource.com/1234340
Commit-Queue: Andrew Luo <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Reviewed-by: agrieve <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592899}

• PRESUBMIT.py[diff]
• android_webview/test/BUILD.gn[diff]
• android_webview/tools/run_cts.pydeps[Added - diff]
• build/print_python_deps.py[diff]

Roll src/third_party/pdfium 1605351382db..4bf804086c4f (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/1605351382db..4bf804086c4f


git log 1605351382db..4bf804086c4f --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Roll testing/corpus/ 2ddedb263..19feefee4 (1 commit)
2018-09-20 [email protected] Validate some image data in CPDF_Image::InitJPEG().
2018-09-20 [email protected] Use pdfium::Optional with FPDF_Doc_Save().
2018-09-20 [email protected] Change CFX_FixedBufGrow to take a size_t.


Created with:
  gclient setdep -r src/third_party/pdfium@4bf804086c4f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I73411b5d1adbe4914baf64e152077917cd9dd55d
Reviewed-on: https://chromium-review.googlesource.com/1236480
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592898}

• DEPS[diff]

Re-enable MediaEngagementAutoplayBrowserTest.UsePreloadedData_Allowed

It was disabled on all Linux platforms due to failures on Chrome OS
in SingleProcessMash browser_tests.

Instead, disable all MediaEngagement browser_tests via filter file
for SingleProcessMash. There's a fix in-flight for renderer
embedding in this mode, so I expect to re-enable them shortly.

Bug: 884589, 883706, 881574
Change-Id: If6257ea160c7ba83c9bb322941001ce5ab1cc1b7
Reviewed-on: https://chromium-review.googlesource.com/1236836
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592897}

• chrome/browser/media/media_engagement_autoplay_browsertest.cc[diff]
• testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter[diff]

[signin] Fix first party URL in GaiaAuthFetcher

Bug: 882107
Change-Id: Ie36e139d17b03bfd75f3b1cec9d557ec5513b084
Reviewed-on: https://chromium-review.googlesource.com/1236214
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592896}

• google_apis/gaia/gaia_auth_fetcher.cc[diff]
• google_apis/gaia/gaia_auth_fetcher_unittest.cc[diff]

Disable TCPSocketTest.BeforeConnectCallback on Fuchsia.

This test fails becasue MSG_PEEK is not implemented.

Bug: 887587
Change-Id: I6e1ba04afc1f34a11352ba0280dfc33c4436affa
Reviewed-on: https://chromium-review.googlesource.com/1235210
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Scott Graham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592895}

• net/socket/socket_posix.cc[diff]
• testing/buildbot/filters/fuchsia.net_unittests.filter[diff]

Update clang update docs.

- mention chromium.clang tot waterfall
- linux cfi bot is now on luci

Bug: 731417
Change-Id: I01b4b01ac35741f66a63f23af78a09d9c1e83495
Reviewed-on: https://chromium-review.googlesource.com/1237113
Reviewed-by: Nodir Turakulov <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592894}

• docs/updating_clang.md[diff]

Suppress Flaky WebGL2 test

deqp/data/gles3/shaders/conversions.html
on Win Nvidia GL passthrough

[email protected]

Bug: 887578
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id07d0302853e6f6340e305508098ab756611e28b
Reviewed-on: https://chromium-review.googlesource.com/1236507
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592893}

• content/test/gpu/gpu_tests/webgl2_conformance_expectations.py[diff]

Add more functionality to MinMaxSize.

It can now constrain the min/max sizes to a value, and also adjust them
to be at least as large as some value.

Also added an assignment operator for LayoutUnit. There are cases where
we want to set min and max to the same value.

Updated ComputeMinAndMaxContentContribution() implementation to use this
new functionality.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I251c523213539acc9e508efebf701ed8f64e4265
Reviewed-on: https://chromium-review.googlesource.com/1236000
Reviewed-by: Christian Biesinger <[email protected]>
Reviewed-by: Aleks Totic <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592892}

• third_party/blink/renderer/core/layout/min_max_size.cc[diff]
• third_party/blink/renderer/core/layout/min_max_size.h[diff]
• third_party/blink/renderer/core/layout/ng/ng_length_utils.cc[diff]

[CrOS MultiDevice] DeviceReenroller: Don't store local device metadata as ref

The helper function
DeviceReenroller::GetSupportedFeaturesForLocalDevice() is currently
storing a local variable as a const ref. This is breaking
chromeos_unittests when the following `gn args` are used:

    ffmpeg_branding = "ChromeOS"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    use_vaapi = true

Bug: 887557
Change-Id: Iaa805f645b5cefc2ab93ca46e595886e5e00e6dc
Tested: chromeos_unittests with gn args listed above
Reviewed-on: https://chromium-review.googlesource.com/1236512
Commit-Queue: Josh Nohle <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592891}

• chromeos/services/multidevice_setup/device_reenroller.cc[diff]

Roll src-internal 84df59e3758f..a7a0a5198543 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84df59e3758f..a7a0a5198543


Created with:
  gclient setdep -r src-internal@a7a0a5198543

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: I9b9aba6098e3d90973dbff06e8c79fea170ed68a
Reviewed-on: https://chromium-review.googlesource.com/1236478
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592890}

• DEPS[diff]

Roll src/third_party/depot_tools f837545214f5..a5ac303c5308 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f837545214f5..a5ac303c5308


git log f837545214f5..a5ac303c5308 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 [email protected] Roll recipe dependencies (trivial).
2018-09-19 [email protected] Roll recipe dependencies (trivial).
2018-09-19 [email protected] Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@a5ac303c5308

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


[email protected]

Change-Id: If57dd96856740a4bbcbc96f8733961ea938d35c0
Reviewed-on: https://chromium-review.googlesource.com/1236878
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592889}

• DEPS[diff]

[DevTools] Fix isolated world crash by always adding a SecurityOrigin

Bug: 879219
Change-Id: I6cf01b36326a8b7727a870f2f7e2d061774d1c5b
Reviewed-on: https://chromium-review.googlesource.com/1226797
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592888}

• third_party/WebKit/LayoutTests/http/tests/inspector-protocol/page/createIsolatedWorld-fetch-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/inspector-protocol/page/createIsolatedWorld-fetch.js[Added - diff]
• third_party/blink/renderer/core/inspector/inspector_page_agent.cc[diff]

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /device.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

[email protected]

Bug: 874080
Change-Id: I1bad5e82040c40aa770c36d3825dfc14dd9aad0f
Reviewed-on: https://chromium-review.googlesource.com/1191813
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Etienne Pierre-Doray <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592887}

• device/base/device_monitor_linux.cc[diff]
• device/serial/serial_device_enumerator_linux.cc[diff]
• device/serial/serial_device_enumerator_mac.cc[diff]
• device/serial/serial_device_enumerator_win.cc[diff]

Explicitly check for absolute position containment when setting a dirty bit.

This patch does two things:
1. Explicitly checks for absolute position object containment where before
   it was checking for the equivalence of the position attribute. My
   suspicion is that this is the intent of the check.
2. Makes the paint layer creation or deletion only set the paint property
   update instead of a subtree update, since it seems that the initial
   intent was that the local border box properties existence may change.

[email protected], [email protected]

Change-Id: I9d93020a6f68213b1e4b49731c7b0e0d80c65681
Reviewed-on: https://chromium-review.googlesource.com/1235128
Commit-Queue: vmpstr <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592886}

• third_party/blink/renderer/core/layout/layout_box_model_object.cc[diff]

ozone: Enable vulkan by default (reland)

Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on
ozone as well to make sure we have build coverage.

Fix chromium.memory/Linux Chromium OS ASan LSan Tests issue by breaking
unnecessary dependency on //gpu/vulkan/init.

Bug: 887110
Test: compile
Change-Id: I298704cf3b199c5c4ecf5173e137293650c5734a
Reviewed-on: https://chromium-review.googlesource.com/1235286
Commit-Queue: Michael Spang <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592885}

• components/viz/common/BUILD.gn[diff]
• components/viz/common/gpu/vulkan_in_process_context_provider.cc[diff]
• gpu/vulkan/features.gni[diff]
• gpu/vulkan/init/vulkan_factory.cc[diff]

Roll Fuchsia SDK from 348d1979e484 to df9325278da7


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
[email protected]

Change-Id: I422477c3b77a2c1901728108133d8d5df482f182
Reviewed-on: https://chromium-review.googlesource.com/1236477
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592884}

• build/fuchsia/linux.sdk.sha1[diff]
• build/fuchsia/mac.sdk.sha1[diff]

Pointer lock: test crash recovery in oopif cases.

Since a RenderWidgetHostView is destroyed when a renderer process crashes, it
is necessary to null-check it before de-referencing it.
This CL is based on nick@'s CL: https://chromium-review.googlesource.com/c/chromium/src/+/956624

Bug: 859215
Change-Id: I029d3615fee56c9cd2287ee816b269338802937c
Reviewed-on: https://chromium-review.googlesource.com/1234873
Commit-Queue: Lucas Gadani <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592883}

• content/browser/pointer_lock_browsertest.cc[diff]
• content/browser/web_contents/web_contents_impl.cc[diff]
• content/browser/web_contents/web_contents_impl.h[diff]

Revert "Revert "ozone/drm: Use minigbm mmap for modeset buffers""

This reverts commit 57af92033303243ba4e0578ad97aedcb903e8c2d.

After bisecting the changes between the failing and passing pfq runs,
the CL responsible for fixing desktopui_MashLogin was CL:1215947 and
not the revert of "Use minigbm mmap for modeset buffers"

BUG=b:78892556

Change-Id: I07908ca894d9132073c1846277d3e32fa1e7d4a8
Reviewed-on: https://chromium-review.googlesource.com/1235202
Reviewed-by: Daniel Nicoara <[email protected]>
Commit-Queue: Drew Davenport <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592882}

• ui/ozone/common/linux/gbm_buffer.h[diff]
• ui/ozone/common/linux/gbm_wrapper.cc[diff]
• ui/ozone/platform/drm/gpu/mock_gbm_device.cc[diff]
• ui/ozone/platform/drm/gpu/screen_manager.cc[diff]

Fix 873811 by guarding v8_session_ for calls via V8Inspector::Channel.

v8_session_ starts out being a nullptr, and the constructor
of InspectorSession initializes it. However, this initialization
involves calling inspector->connect which calls the inspector
session (this) with sendResponse / flushProtocolNotifications.

This PR tries to resolve it by guarding v8_session_ for the
V8Inspector::Channel methods.

Bug: 873811
Change-Id: I8142eb61f9a8f6fb003b9baa0b6222730234ccae
Reviewed-on: https://chromium-review.googlesource.com/1235054
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Johannes Henkel <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592881}

• third_party/blink/renderer/core/inspector/inspector_session.cc[diff]

Fixed the issue that switching modality from voice input to text input cancel the conversation.

Bug: b:114302330
Change-Id: I2e295a6ac8b3e78ecc92dd7bfba20b2e673cd04e
Reviewed-on: https://chromium-review.googlesource.com/1212094
Commit-Queue: Li Lin <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#592880}

• ash/assistant/assistant_interaction_controller.cc[diff]
• ash/assistant/assistant_interaction_controller.h[diff]
• chromeos/services/assistant/assistant_manager_service_impl.cc[diff]
• chromeos/services/assistant/assistant_manager_service_impl.h[diff]
• chromeos/services/assistant/fake_assistant_manager_service_impl.cc[diff]
• chromeos/services/assistant/fake_assistant_manager_service_impl.h[diff]
• chromeos/services/assistant/public/mojom/assistant.mojom[diff]
• chromeos/services/assistant/test_support/mock_assistant.h[diff]