Publish DEPS for 68.0.3440.59
Incrementing VERSION to 68.0.3440.59
[email protected]
Change-Id: I7260fcde941e2fd7fbcb4eddf7e7617203b7aa16
Reviewed-on: https://chromium-review.googlesource.com/1132403
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#644}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Don't throw away bits when computing Blink heap magic.
Bug: 860721
Change-Id: I8d32e43efa102d257360c2886aa1701298e3c91e
Reviewed-on: https://chromium-review.googlesource.com/1132082
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#643}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.58
[email protected]
Change-Id: Ia0f8418372bc232b9ceef9932715794a103e077f
Reviewed-on: https://chromium-review.googlesource.com/1132397
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#642}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}arc: Make SET_REPORTING_CONSENT false for managed users
Keep usage & diagnostics false during ARC setup if the user does not
see the ARC ToS dialog due to all relevant settings being managed,
even if usage & diagnostics is enabled for the device.
Note that this is a squashed patch of the following three commits:
commit 25a10afd2e5303a00b5f19d2cdd1b5a735723e44
commit c59e0e374abf33db3b17cd269be347a200e7ed64
commit 7da098a199b64a48665d57352e390acc48bfc09d
Bug: b/73338614, 859104, 855448
Test: Opt in to ARC with managed and unmanaged users
Change-Id: I5fbe412d8cd7e3e0ca0ee77c325ba0903e677414
Signed-off-by: Josh Horwich <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/1121212
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#641}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Record UKMs if a manual save fallback is offered to the user
This CL introduce a UKM metric that tells us if a manual fallback for password
saving was offered, which means that the user typed a not yet stored credential
into a password form. The purpose of this is to see whether we see such sites
where manual fallback is offered but form submissions are not observed.
[email protected]
(cherry picked from commit 061f70757acaab80075714aaa2f93c532e26c38c)
Bug: 732846
Change-Id: If2bce7b0e7219f84880110218b8ea6d1d955c165
Reviewed-on: https://chromium-review.googlesource.com/1126932
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572797}
Reviewed-on: https://chromium-review.googlesource.com/1131940
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#640}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix DCHECK in WebFormElementObserverImpl
The WebFormElementObserverImpl made an incorrect but also totally unnecessary
cast of a Node to an HTMLElement. This edge case was discovered by the fuzzer
where a form was inside an <svg> element, whose style attribute was changed,
but which could not be casted to HTMLElement.
[email protected]
(cherry picked from commit 5ce8880baa741c8e31cfd47ede17490128590488)
Bug: 861571
Change-Id: I62c8238e25ef39e662dc154a1f2bd772667ec52f
Reviewed-on: https://chromium-review.googlesource.com/1128973
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573458}
Reviewed-on: https://chromium-review.googlesource.com/1131939
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#639}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[M68] Disable cold mode spellchecker
Cold mode spellchecker was introduced in M68 as a bug fix to some
spellcheck completeness issues. For risk control, it is implemented
behind a flag.
Now that we found many related crashes in M68 and M69, it turns out
that cold mode spellchecker is not ready to be pushed to the stable
channel. Hence, this patch disables it by default on M68.
It will remain enabled by default in M69 for more observation.
Bug: 716642, 856376, 859056, 859443
Change-Id: I8984de679d0c7c0de61123f50dabc535b2b3c3fb
Reviewed-on: https://chromium-review.googlesource.com/1124021
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#638}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Change-Id: I83d783bf54312c713855925e35dcc7d1af9e931e
Reviewed-on: https://chromium-review.googlesource.com/1131930
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#637}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Merge to 3440] Fix re-entrancy caused by RenderFrameHostImpl::DispatchBeforeUnload.
The method, on certain conditions, would simulate receiving a
OnBeforeUnloadACK() IPC. This would immediately call back into the unload
handler, which had just called RenderFrameHostImpl::DispatchBeforeUnload.
The problematic series of events is as follows:
1) TabStripModel::CloseWebContentses tries to close many tabs.
2) This calls RunUnloadListenerBeforeClosing() on each tab.
3) UnloadListener will call RenderFrameHostImpl::DispatchBeforeUnload, which
on certain conditions will synchronously call OnBeforeUnloadACK().
4) This calls back into TabStripModel, mutating internal state.
5) The implementation of TabStripModel::CloseWebContentses relies on the
assumption that there is no re-entrancy. This manifests itself as a buffer
overrun when (1) calls SendDetachWebContentsNotifications, which then
passes inconsistent data to the observers.
Bug: 851400
Change-Id: I2080875f5d8d118c93addbe66503cb02b8b2966f
Reviewed-on: https://chromium-review.googlesource.com/1101846
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568534}(cherry picked from commit 907fe4acf7dc713ed05e1608663444b2278de1f6)
Reviewed-on: https://chromium-review.googlesource.com/1129400
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#636}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix feature policy construction in proxies.
When a proxy for a newly-created frame is created in an existing
renderer, the Feature-Policy header and container policy need to be
applied after the origin is set. Previously, setting the proxy's origin
(as the last step in frame navigation) would reuse the feature policy
which was created during frame initialization without taking into
account either the HTTP header or the new origin's relationship to the
parent frame.
This CL ensures that the remote frame stores a copy of the initial
feature policy header, which it can use to reconstruct the correct
policy when the origin is set. The
FeaturePolicy::CreateFromPolicyWithOrigin method, which was used to
replicate an existing policy with an updated origin, is removed, as it
appears to never be the right behaviour.
[email protected]
(cherry picked from commit bd2a91ac57dcfe16ce53877c776843a6cf1f8216)
Bug: 852102
Change-Id: I3e5137737a5aac102f247aa52ede842f1210f53f
Reviewed-on: https://chromium-review.googlesource.com/1124931
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573149}
Reviewed-on: https://chromium-review.googlesource.com/1131926
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#635}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Merge of DevTools: restore pointer events in HTML preview
- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
iframe when tabbing via keyboard.
Bug: 849204
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569093}(cherry picked from commit 122037b2541bf0932fd6fbcb29a98d487525c4ec)
Reviewed-on: https://chromium-review.googlesource.com/1132014
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#634}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Mac merge into M68] Merge 2 CLs into M68 and resolve conflict
[Mac] Collect detached code signatures when analyzing DMG files.
A detached signature is created by codesign(1) when the signed artifact
is not Mach-O, so the resulting signature cannot be placed in the
LC_CODE_SIGNATURE command. Instead, the signature is detached into the
_CodeSignature/CodeSignature file on-disk.
This also updates the testing codesign certificate used for the
safe_browsing/mach_o test data, since new test data needed to be generated.
The existing test data were not re-signed with it, however.
Bug: 826761
Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
Reviewed-on: https://chromium-review.googlesource.com/1101842
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569101}
[Mac] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()
This could occur if a detached code signature file is shorter than its
typical prologue.
Bug: 826761
Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
Reviewed-on: https://chromium-review.googlesource.com/1114925
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#570530}
(cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)
[email protected], [email protected], [email protected]
Bug: 826761
Change-Id: Ie33179f80ca0de57ed3383d2c3de0a0a3385efc6
Reviewed-on: https://chromium-review.googlesource.com/1131717
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#633}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Pass variation headers for Omnibox Searches.
Variation headers will only be added to URL requests to Google servers.
Variation headers will be passed for the following navigations:
- Text search from the Omnibox
- Back-forward navigation to search pages loaded from omnibox text search
- Reload of the search page
Headers will *not* be passed for the following navigations:
- QR code scanner search
- Voice Search
- Bookmarks
- Search by image
- NTP tiles and articles
- History navigations
- Learn More on Incognito
- Recent Tab navigation
- Reading List article load
[email protected]
(cherry picked from commit 1ce01901eba7a11541dc1a7eac0aa6fd70ac953d)
Bug: 831976
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28be85db0a38b64f933d0b57746b474aeecbf546
Reviewed-on: https://chromium-review.googlesource.com/1069335
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#563386}
Reviewed-on: https://chromium-review.googlesource.com/1131690
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#632}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I860b7606174179866afb673c6d3d2bc101a9f33f
Reviewed-on: https://chromium-review.googlesource.com/1131534
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#631}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[signin] Re-use existing signin tabs
Previously, each sign-in request was processed in a new tab.
This was a problem because a mis-behaving extension could make many
signin request, and trigger the creation of many new tabs.
This CL mitigates the bug by reusing an existing signin tab if available.
Note that this does not completely address the problem, because the
signin tab is given the focus, and thus a misbehaving extension is still
able to constantly bring a signin tab into focus, as well as constantly
reopening the signin tab when it is closed.
[email protected]
(cherry picked from commit cd0d663fee8a8506e94f2849b8b82d096601dcf3)
Bug: 856513
Change-Id: I077054857c311a319408d63dfc2bdf56567c4f11
Reviewed-on: https://chromium-review.googlesource.com/1124691
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572802}
Reviewed-on: https://chromium-review.googlesource.com/1131118
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#630}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Merge "custom-element: Do not crash by Get(NewTarget, "prototype") failure." to M68 branch
https://html.spec.whatwg.org/multipage/dom.html#html-element-constructors
> 7. Let prototype be Get(NewTarget, "prototype"). Rethrow any exceptions.
As the specification says, we should rethrow. Removing a v8::TryCatch
instance in V8HTMLConstructor::HtmlConstructor() works as "rethrow".
Bug: 854887
Change-Id: I6b2d6ae829453270fe4437a87e65528525c64990
Reviewed-on: https://chromium-review.googlesource.com/1124129
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572167}(cherry picked from commit 8381e35ca626c9853c6207de30828b7c3039430c)
Reviewed-on: https://chromium-review.googlesource.com/1130576
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#629}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert Ozone initialization changes.
This reverts most of commit a51e3935c81c5572eb1439a1f8d83c9184f3f128.
The thread configuration for --enable-features=Mus doesn't exist anymore
and fixing mus introduced a different race for the non-mus configuration.
Since mus is no longer the plan of record, revert the initialization
order changes but keep logging and code cleanup.
Bug: 840474
Change-Id: Ifec0e3dd9601e3895d0549109be5d10387f3b8b4
Reviewed-on: https://chromium-review.googlesource.com/1101139
Reviewed-by: Robert Kroeger <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567794}(cherry picked from commit b33fd39c100223d0d8aecdec3308228b41642514)
Reviewed-on: https://chromium-review.googlesource.com/1130854
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#628}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.57
[email protected]
Change-Id: I2444369579f8efae0d7e2bc027de6e2b8a1ae46a
Reviewed-on: https://chromium-review.googlesource.com/1130696
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#627}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Reland: "Download: Fix an issue that download percentage can move backwards."
On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.
Instead, we should keep the slice info when resume with an error.
[email protected], [email protected], [email protected]
(cherry picked from commit 1dba58736239a49120531e98631010925aaafffa)
Bug: 837128
Change-Id: I59ddb7ff57551beb862884febe2de3f3ee9e1359
Reviewed-on: https://chromium-review.googlesource.com/1130349
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573547}
Reviewed-on: https://chromium-review.googlesource.com/1130816
Cr-Commit-Position: refs/branch-heads/3440@{#626}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[M68] Replace MtpManager's ReadDirectory() with ReadDirectoryEntryIds().
[email protected]
BUG=858899
Replace MtpManager's ReadDirectory() with ReadDirectoryEntryIds().
MediaTransferProtocolDaemonClient currently provides a low-level
ReadDirectoryEntryIds() method, and MtpManager does the translation to
the high-level ReadDirectory() method that MTPDeviceTaskHelper
understands.
Change MtpManager's ReadDirectory() method to ReadDirectoryEntryIds(),
so it acts more like a pass-through. Make MTPDeviceTaskHelper handle the
translation.
BUG=769630
Change-Id: I5154bd4beac0b6ab15579f166cdf8b8add6a7dac
Reviewed-on: https://chromium-review.googlesource.com/1080214
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#565441}(cherry picked from commit 44663e8f02729bf01d296ce86087f87168420713)
Reviewed-on: https://chromium-review.googlesource.com/1130735
Reviewed-by: Anand Mistry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#625}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[M68] Align GetFileInfo() between MtpManager and MtpDaemonClient.
[email protected]
BUG=858899
Align GetFileInfo() between MtpManager and MtpDaemonClient.
MediaTransferProtocolDaemonClient currently provides a low-level
GetFileInfo() method, and MtpManager does the translation to the
high-level GetFileInfo() method that MTPDeviceTaskHelper understands.
Change MtpManager's GetFileInfo() from the high-level method to the
low-level method, so it acts more like a pass-through. Make
MTPDeviceTaskHelper handle the translation.
BUG=769630
Change-Id: I21e20b71d333a1ee7173071f04aaf2e37dd61844
Reviewed-on: https://chromium-review.googlesource.com/1080212
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#565413}(cherry picked from commit 3d7f15c742e7aff293b9b2065837bf98cb3a042b)
Reviewed-on: https://chromium-review.googlesource.com/1130715
Reviewed-by: Anand Mistry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#624}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Weaken a precondition for client_ in DocumentThreadableLoader destructor
Having a non-null client_ in DocumentThreadableLoader destructor
generally means UaF, so we have a CHECK there.
In the detached case, the loader is held by self-referencing
DetachedClient, but SelfKeepAlive in DetachedClient is forcibly
cancelled on worker thread termination. This is a safe pattern, so we
should ignore this case.
[email protected]
(cherry picked from commit 8ec0126d926388c03016100db87d1dd3454fdf34)
Bug: 837511
Change-Id: I451ccddc0f72c2b0d0ec05c707b983e18547feae
Reviewed-on: https://chromium-review.googlesource.com/1127509
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572959}
Reviewed-on: https://chromium-review.googlesource.com/1130555
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#623}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert "[Mac merge M68] Collect detached code signatures when analyzing DMG files."
This reverts commit 5cfa9fabbdba23376ff7d8776d3f0b735c80e728.
Reason for revert: breaking continuous build due to merge conflicts
Original change's description:
> [Mac merge M68] Collect detached code signatures when analyzing DMG files.
>
> A detached signature is created by codesign(1) when the signed artifact
> is not Mach-O, so the resulting signature cannot be placed in the
> LC_CODE_SIGNATURE command. Instead, the signature is detached into the
> _CodeSignature/CodeSignature file on-disk.
>
> This also updates the testing codesign certificate used for the
> safe_browsing/mach_o test data, since new test data needed to be generated.
> The existing test data were not re-signed with it, however.
>
> [email protected]
>
> (cherry picked from commit 0b82d4cd3484d173e7f1ec20a0de062663a20d06)
>
> Bug: 826761
> Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
> Reviewed-on: https://chromium-review.googlesource.com/1101842
> Reviewed-by: Ken Rockot <[email protected]>
> Reviewed-by: Gayane Petrosyan <[email protected]>
> Reviewed-by: Varun Khaneja <[email protected]>
> Reviewed-by: Jialiu Lin <[email protected]>
> Commit-Queue: Robert Sesek <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#569101}
> Reviewed-on: https://chromium-review.googlesource.com/1129551
> Cr-Commit-Position: refs/branch-heads/3440@{#617}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[email protected],[email protected],[email protected],[email protected],[email protected]
Change-Id: Ibc7eee944f549df3d8138796a507d9074e5a4401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826761
Reviewed-on: https://chromium-review.googlesource.com/1130139
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#622}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert "[Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()"
This reverts commit aa78d07711cb1d94bf0bf9c098662babc0a10a86.
Reason for revert: breaking build because of merge conflict
Original change's description:
> [Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()
>
> This could occur if a detached code signature file is shorter than its
> typical prologue.
>
> [email protected]
>
> (cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)
>
> Bug: 826761
> Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
> Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
> Reviewed-on: https://chromium-review.googlesource.com/1114925
> Commit-Queue: Robert Sesek <[email protected]>
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#570530}
> Reviewed-on: https://chromium-review.googlesource.com/1129552
> Cr-Commit-Position: refs/branch-heads/3440@{#618}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[email protected],[email protected]
Change-Id: Ib92f5384942ca257ab98c6f3cfb010cc2afe6860
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826761
Reviewed-on: https://chromium-review.googlesource.com/1130119
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#621}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert "Download: Fix an issue that download percentage can move backwards."
This reverts commit 1917d9a9ab35eadaa2ddb37932224159567cd110.
Reason for revert: Some testing function is modified, so I need to revert this CL,
and then revert the one on trunk, then checking in a new one without the test.
Original change's description:
> Download: Fix an issue that download percentage can move backwards.
>
> On certain Android devices, when disconnecting from WIFI, the network
> code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
> auto download resumption. And we erase the data downloaded by parallel
> requests, so the download percentage will go backwards.
>
> Instead, we should keep the slice info when resume with an error.
>
> [email protected]
>
> (cherry picked from commit 30c71bacdda42e40654870f46d6e3278bcac113b)
>
> Bug: 837128
> Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
> Reviewed-on: https://chromium-review.googlesource.com/1112754
> Reviewed-by: David Trainor <[email protected]>
> Reviewed-by: Min Qin <[email protected]>
> Commit-Queue: Xing Liu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#571286}
> Reviewed-on: https://chromium-review.googlesource.com/1129206
> Reviewed-by: Xing Liu <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#615}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[email protected],[email protected],[email protected]
Change-Id: Ibafda7c82f4eaed9b6f38b3a28fa93e0404c7f6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837128
Reviewed-on: https://chromium-review.googlesource.com/1129939
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#620}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Reland "[vr] Tune scroll event stream"
This is a reland of 0e9a15da019624f9e5d6a3aba35b0102175da5c0
In this reland, I've combined the change with https://crrev.com/c/1124405
since the smoothing in the original CL was actually just a scaling.
Original change's description:
> [vr] Tune scroll event stream
>
> This change applies three heuristics to make trackpad scrolling feel
> smoother. We increase the frequency at which we submit scroll events to
> the platform, we also decrease the scroll scale factor (to make the
> scrolls less jumpy), and we do some simple filtering of our scroll
> values.
>
> I pair-programmed much of this change with asimjour@ and he wrote the
> initial code to interpolate events in the android ui gesture target.
>
> Bug: 859075
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
> Reviewed-on: https://chromium-review.googlesource.com/1120425
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Ian Vollick <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#571535}
(cherry picked from commit 98c28a6f258f58f00ef7caec2c8048b886d40df4)
Bug: 859075
Change-Id: Ib1a9f801c6930b709624233d8e00aeabc59f576d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1124908
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Amirhossein Simjour <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572364}
Reviewed-on: https://chromium-review.googlesource.com/1129626
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#619}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()
This could occur if a detached code signature file is shorter than its
typical prologue.
[email protected]
(cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)
Bug: 826761
Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
Reviewed-on: https://chromium-review.googlesource.com/1114925
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570530}
Reviewed-on: https://chromium-review.googlesource.com/1129552
Cr-Commit-Position: refs/branch-heads/3440@{#618}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Mac merge M68] Collect detached code signatures when analyzing DMG files.
A detached signature is created by codesign(1) when the signed artifact
is not Mach-O, so the resulting signature cannot be placed in the
LC_CODE_SIGNATURE command. Instead, the signature is detached into the
_CodeSignature/CodeSignature file on-disk.
This also updates the testing codesign certificate used for the
safe_browsing/mach_o test data, since new test data needed to be generated.
The existing test data were not re-signed with it, however.
[email protected]
(cherry picked from commit 0b82d4cd3484d173e7f1ec20a0de062663a20d06)
Bug: 826761
Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
Reviewed-on: https://chromium-review.googlesource.com/1101842
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569101}
Reviewed-on: https://chromium-review.googlesource.com/1129551
Cr-Commit-Position: refs/branch-heads/3440@{#617}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}WebView: Fix CloseGuard error in VariationsSeedLoader
The WebView requesting a variations seed opens a file descriptor to
receive the seed. We should close it after the request.
BUG=857223
Change-Id: I594067ce0c33bed2137bc39e5c133ba22bca0c04
Reviewed-on: https://chromium-review.googlesource.com/1117707
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571354}(cherry picked from commit 9aeb746195fa8bf7131c270af2c41c9b605bb894)
Reviewed-on: https://chromium-review.googlesource.com/1129479
Reviewed-by: Paul Miller <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#616}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Download: Fix an issue that download percentage can move backwards.
On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.
Instead, we should keep the slice info when resume with an error.
[email protected]
(cherry picked from commit 30c71bacdda42e40654870f46d6e3278bcac113b)
Bug: 837128
Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
Reviewed-on: https://chromium-review.googlesource.com/1112754
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571286}
Reviewed-on: https://chromium-review.googlesource.com/1129206
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#615}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[NTP Button] Moves native calls to post native initialization
> The variations check was previously happening before native
was initialized
> Moves the check to after the native library is ready
(cherry picked from commit 7b01abd45df53a2fd46ca5fe8811898b5f5d0d75)
Bug: 847129
Change-Id: Ied97f2b9038c9cff5851f20e76339a61151a9677
Reviewed-on: https://chromium-review.googlesource.com/1076377
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Daniel Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562633}
Reviewed-on: https://chromium-review.googlesource.com/1128451
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#614}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Cancel system touches when context menu is displayed
The system touches need to be cancelled whenever the context menu is
shown in order to prevent webview interaction after the context menu is
displayed.
Wait until the context menu element is available before determining if
the element supports a displyed context menu.
Bug: 853298
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I15bd7d4148f83646763504dd8370dce49e37dff3
Reviewed-on: https://chromium-review.googlesource.com/1104989
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568512}(cherry picked from commit 0e46d0b168129d2e7c5ab6ca21fb88524e498f21)
Reviewed-on: https://chromium-review.googlesource.com/1129280
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#613}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[iOS] Add additional Context Menu metrics.
The ContextMenu.DelayedElementDetails metric ensures that all awaiting
requests are eventually processed by either the user cancelling or by
the DOM element details being returned.
The ContextMenu.CancelSystemTouches metric logs that the system touches
were cancelled. This value should match the number of Context Menus
shown, otherwise a user could continue to interact with the page after
the Context Menu has been displayed.
Bug: 817517, 856234
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4dc5d9d14eba12c06ca034b80c037bd673230878
Reviewed-on: https://chromium-review.googlesource.com/1102994
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568450}(cherry picked from commit 9781ec3860643f79d510ead331b0d74c21c10a13)
Reviewed-on: https://chromium-review.googlesource.com/1129279
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#612}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Typed URLs] Avoid sending history backend notifications after a DB error
Before this CL, there was a race condition in addressing DB errors in
HistoryBackend. When HistoryBackend::DatabaseErrorCallback got called,
it immediately notified TypedURLSyncBridge and posted a task to kill the
database. Before the database gets really killed, some other tasks can
run such as tasks from the expirer that result in the bridge being
notified about history deletions. The bridge does not expect backend
notifications after being notified about DB error (which makes sense).
This CL resolves this bug and delays the notification to the bridge so
that it happens synchronously with killing the DB.
The conflict in the unit-test was a trivial one (the context where the
new test is appended has changed).
[email protected]
(cherry picked from commit 40f00aa570a7a330acd74192ebacc840e9ca9d58)
Bug: 853395
Change-Id: I03d1a5c49254184e430c1619049e66895bf6dcfe
Reviewed-on: https://chromium-review.googlesource.com/1105821
Commit-Queue: Jan Krcal <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568554}
Reviewed-on: https://chromium-review.googlesource.com/1128096
Reviewed-by: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#611}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.56
[email protected]
Change-Id: I53622fbee5857a0ab2a82a30fbd2aa39cec0153d
Reviewed-on: https://chromium-review.googlesource.com/1128602
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#610}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.55
[email protected]
Change-Id: I3fbde36520a223a40f0ae5403ecb425dcec1ce78
Reviewed-on: https://chromium-review.googlesource.com/1128414
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#609}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[M68] [ServiceWorker] Stop observing EmbeddedWorkerInstance once it's gone away
This CL is a combination of the 2 previous commits on trunk, both of
them aim to avoid use-after-free behavior on the raw pointer of an
EmbeddedWorkerInstance.
After the 1st CL landed on trunk, it turns out that it did not fix the
problem completely and caused regressions like issue 856969, then we
have the 2nd CL give a complete solution.
The 1st one:
"
[ServiceWorker] Avoid using stale pointer of EmbeddedWorkerInstance
We're saving the raw pointer of an EmbeddedWorkerInstance in a
base::ScopedObserver member of ServiceWorkerRegisterJob, but, the
EmbeddedWorkerInstance is not guaranteed to outlive the
ServiceWorkerRegisterJob, it may get destroyed and lead to a situation
that ServiceWorkerRegisterJob holds a stale pointer, which could lead
to crash.
This CL lets ServiceWorkerRegisterJob listen OnDetached() from the
EmbeddedWorkerInstance so it can be aware that the EmbeddedWorkerInstanc
pointer is going to be stale and should be removed from the source list
of base::ScopedObserver.
This fix should be safe enough now, but in longer term we'll try to
remove EmbeddedWorkerInstance::Listener interface and let
EmbeddedWorkerInstance talk directly to its owner ServiceWorkerVersion,
then let ServiceWorkerRegisterJob observe the ServiceWorkerVersion it's
manipulating to get OnScriptLoaded() notification.
BUG=854063,855394
Change-Id: I9c5a46beda1aafff32a86b9055be2b53d50fda97
Reviewed-on: https://chromium-review.googlesource.com/1112904
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569906}
(cherry picked from commit 26f26cd82a8159dff52fdef10b0a7ebb84c48040)
"
The 2nd one:
"
[ServiceWorker] Stop observing EmbeddedWorkerInstance once it's gone away
This CL adds a function OnDestroyed() into
EmbeddedWorkerInstance::Listener interface, so that
ServiceWorkerRegisterJob can stop observing EmbeddedWorkerInstance once
it's gone away.
BUG=856969,856330
Change-Id: I3acc9143f9ea2f8f24ab0aac465f29f97fdf9906
Reviewed-on: https://chromium-review.googlesource.com/1118006
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#571417}
(cherry picked from commit 1c81791b45c09b52614f85a7016425b71da32c4d)
"
BUG=854063,856969
Change-Id: I91c68d8edba41f6f7725903288fd12ec7574c538
Reviewed-on: https://chromium-review.googlesource.com/1128469
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#608}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.54
[email protected]
Change-Id: I1886764b963cd6befdbd959b7eec4fa4ab2d939a
Reviewed-on: https://chromium-review.googlesource.com/1128405
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#607}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Stop streams associated to removed devices in MediaDevicesManager.
This fixes a bug where removing a device did not result in stopping all
its associated streams.
A unit test for this requires a minor refactoring to remove the
MediaStreamManager dependency from MediaDevicesManager, and will be
provided in a follow-up CL. This CL is deliberately simple in order to
make merging easier.
Bug: 856658
Change-Id: I84ef2856195cc7650bb08992d2095f8f853e9ea9
Reviewed-on: https://chromium-review.googlesource.com/1124323
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572176}(cherry picked from commit 0fe699a8dfc9c3a6cc0203759561284d634f4a57)
Reviewed-on: https://chromium-review.googlesource.com/1125959
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#606}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Do not delete the media ContextProvider inside the lost context callback
Currently the GpuVideoAcceleratorFactoriesImpl will check for context
loss every time it tries to use the GL context, and destroy it
immediately if it sees a loss. This is problematic if the
ContextProvider is still on the callstack, which it is if we're inside
the context loss callback. Instead, leave the ContextProvider alive
until the GpuVideoAcceleratorFactoriesImpl stops being used.
[email protected], [email protected]
(cherry picked from commit 3071401e1b0257d029a6560a9fa8c3c1f695f839)
Bug: 849131
Change-Id: I8ec66671b4bbf5d426cb5fb184653a5863de9fd9
Reviewed-on: https://chromium-review.googlesource.com/1104777
Commit-Queue: danakj <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568256}
Reviewed-on: https://chromium-review.googlesource.com/1128214
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#605}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Merge to M68: Bubble logical scrolling from OOPIFs.
[email protected],[email protected],[email protected]
Bubble logical scrolling from OOPIFs.
Currently, ScrollManager::BubblingScroll only bubbles logical scrolls
from an iframe when the parent is a local frame. Now, when bubbling
reaches a local root, we send an IPC to the parent's process to
continue bubbling from the frame owner element.
(cherry picked from commit e21d23b8427576ae3877a2d1616fec42dc861ed1)
Bug: 852932
Change-Id: I312aed8eea353957b7d77cea3caad60a2c3493d6
Reviewed-on: https://chromium-review.googlesource.com/1106279
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571484}
Reviewed-on: https://chromium-review.googlesource.com/1128211
Reviewed-by: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#604}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Merge "Fix LoginUIserviceLoginPopupTest.ShowLoginPop test on Beta."
The old sign-in page requres component extensions. The unittest needs
to create the ExtensionService before loading the page.
Bug: 859438
Change-Id: I22296316346ee0f7e780babd6125cf388e920d03
Reviewed-on: https://chromium-review.googlesource.com/1125210
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572597}(cherry picked from commit 215bd7442d675352b423caf39ff6087b62fe8459)
Reviewed-on: https://chromium-review.googlesource.com/1127936
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#603}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Catch java.lang.IllegalArgumentException in parsing baae64
BUG=829628
[email protected]
(cherry picked from commit 7880981a0cc24217dc87675bb12b216d02f4141d)
Change-Id: I054c8a40cf065d0c2f42bd8de9e5de6fed3fb9e9
Reviewed-on: https://chromium-review.googlesource.com/1059155
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#561876}
Reviewed-on: https://chromium-review.googlesource.com/1127881
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#602}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.53
[email protected]
Change-Id: Ic05fbd55bf3e0934c7f2c7b0474c896a4856d17b
Reviewed-on: https://chromium-review.googlesource.com/1127270
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#601}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.52
[email protected]
Change-Id: I329dd454c01eb13d3d748854badf7464723a1c0f
Reviewed-on: https://chromium-review.googlesource.com/1126601
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#600}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Surface synchronization: Remove check in LayerTreeImpl
We still get the occasional surface invariants violations in the wild and
we don't necessarily want to crash the renderer in this case. We will already
log things appropriately.
Bug: 672962, 828741
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I262850f2cf704cd59366da6dd4d154227aab5220
Reviewed-on: https://chromium-review.googlesource.com/1112491
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569781}(cherry picked from commit e59b611ddde7200d14b873183bc1ac48f5747a41)
Reviewed-on: https://chromium-review.googlesource.com/1126500
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#599}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}android: Retry detached requests on network change.
Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.
Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Commit-Queue: Benoit L <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571173}(cherry picked from commit 0c88d2db535f6c407afb185e8eb40edca2b10f13)
Reviewed-on: https://chromium-review.googlesource.com/1125759
Reviewed-by: Benoit L <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#598}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Make mime handlers inherit the session storage of their embedders.
Mime handlers create a nested WebContents to contain the mime handler
extension. Currently, these run with a separate session storage
namespace, resulting in session storage being cleared if a tab recreates
a mime handler, such as due to a reload. Change mime handler WebContents
creation to inherit the session storage namespaces of their embedders so
the session storage behaves similarly to iframes within a single tab.
[email protected]
(cherry picked from commit 69a3377d60d1418a44a599b87210881d1f5fc59b)
Bug: 819761
Change-Id: I3b4f653836190ed86572eb12cdbeef3fbc157683
Reviewed-on: https://chromium-review.googlesource.com/1116633
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570814}
Reviewed-on: https://chromium-review.googlesource.com/1124736
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#597}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.51
[email protected]
Change-Id: I6887bece3a85c681b1c34b78eeaf89c543e2f345
Reviewed-on: https://chromium-review.googlesource.com/1125441
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#596}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Merge M68] Extensions: Show file access toggle for activeTab extensions.
r548269 disallowed implicit file url access for extensions with activeTab. This
CL ensures that the file access toggle is visible for extensions using the
activeTab permission, hence providing a way for these extensions to be used on
file urls.
BUG=850643
TEST=Install an extension with activeTab permission. (E.g.
https://chrome.google.com/webstore/detail/page-redder/difbeimhegehkihppkgdlpongficimep?hl=en).
Ensure that "Allow access to file URLs" checkbox is shown for the extension.
[email protected]
Change-Id: I777c8edb29666343f2e5a6e7a1a06a32746178a8
Reviewed-on: https://chromium-review.googlesource.com/1096352
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#566610}(cherry picked from commit 396ced81d62743154629327f121a407db5969e49)
Reviewed-on: https://chromium-review.googlesource.com/1124909
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#595}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Keep reference to child ComputedStyle on stack.
Apparently, the ComputedStyle on a child may change during
LayoutBlock::ComputeBlockPreferredLogicalWidths. We used to keep a
reference to the ComputedStyle on the stack before [1]. Re-introducing
scoped_refptr here.
The reduced test exposed a DCHECK problem tracked by 389648. Instead of
adding an almost identical new test, with another TestExpections line,
we add writing-mode to the existing test which would expose the ASAN
issue as well.
[1] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c
Bug: 853538, 389648
Change-Id: I5cb09c8cd9a7ae6d0621758f4690fce2abbb8096
Reviewed-on: https://chromium-review.googlesource.com/1117697
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571199}(cherry picked from commit b0a9cfb77595d3291e9d94beaa0ca3fef68bd76b)
Reviewed-on: https://chromium-review.googlesource.com/1125179
Cr-Commit-Position: refs/branch-heads/3440@{#594}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}ozone: Add low pressure filter for touchscreen
To prevent poor quality touches on hana, add a filter for low pressure
touches, such as those generated by a pencil. Finger presses are above
the chosen threshold and aren't affected. If a contact ever exceeds the
presure threshold, all remaining events for that contact are sent.
CQ-DEPEND=CL:1093584
BUG=b:69232663
TEST=manual testing on hana with pressure filter enabled
Change-Id: Ic2d56eb656e318ee46744ef37f6055d8573a2261
Reviewed-on: https://chromium-review.googlesource.com/1096126
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Commit-Queue: Sean O'Brien <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569415}(cherry picked from commit e5ba742d9cdff72d0d600440ceb03f018feee1f6)
Reviewed-on: https://chromium-review.googlesource.com/1125039
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#593}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Payments] Open new foreground tab triggered by user in payment handler window in browser
[email protected]
(cherry picked from commit fdadc5fd459664599074bb8557528a1b8814c65d)
Bug: 856743
Change-Id: Icee41ddd6bd4d593ae19b12ac601644d0a004be1
Reviewed-on: https://chromium-review.googlesource.com/1115803
Commit-Queue: Ganggui Tang <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570796}
Reviewed-on: https://chromium-review.googlesource.com/1125087
Cr-Commit-Position: refs/branch-heads/3440@{#592}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Hide incognito switch when incognito is not enabled
In cases where incognito is disabled due to a policy, we should
not see the incognito switch button at all for horizontal tab switcher.
This is in line with having the related menu item for incognito being
disabled
BUG=859160
Change-Id: I6bc19ce27fedc12fc18a9f91f5a7b433c7fb6c82
Reviewed-on: https://chromium-review.googlesource.com/1123405
Commit-Queue: Yusuf Ozuysal <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572045}(cherry picked from commit 3339971f2bff1bdfefd16fdf28d2528b61b8dfc5)
Reviewed-on: https://chromium-review.googlesource.com/1125040
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#591}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert "[vr] Tune scroll event stream"
This reverts commit 7b648651b1ac5f0a40a118ffb39249b09ea92724.
Reason for revert: did not address scrolling issues.
Original change's description:
> [vr] Tune scroll event stream
>
> This change applies three heuristics to make trackpad scrolling feel
> smoother. We increase the frequency at which we submit scroll events to
> the platform, we also decrease the scroll scale factor (to make the
> scrolls less jumpy), and we do some simple filtering of our scroll
> values.
>
> I pair-programmed much of this change with asimjour@ and he wrote the
> initial code to interpolate events in the android ui gesture target.
>
> (cherry picked from commit 0e9a15da019624f9e5d6a3aba35b0102175da5c0)
>
> Bug: 859075
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
> Reviewed-on: https://chromium-review.googlesource.com/1120425
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Ian Vollick <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#571535}
> Reviewed-on: https://chromium-review.googlesource.com/1123463
> Reviewed-by: Ian Vollick <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#584}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[email protected]
Change-Id: I5ba9707aea9dbde21910358df0e599a21085f715
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1124821
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#590}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6de2a304bb0c543c008d58a0a6ee22bdafb12759
Reviewed-on: https://chromium-review.googlesource.com/1124673
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#589}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[AF][IOS] Aligns the credit card save infobar icon with the title label
- Replaces the credit card save infobar icon with a new one with smaller
intrinsic padding so it can be better aligned with the title text.
- Also adjusts the line height of the labels in the infobar.
- New PNGs are pngcrushed.
TBR=mathp
Bug: 854246
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6
Reviewed-on: https://chromium-review.googlesource.com/1111013
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569508}(cherry picked from commit 7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3)
Reviewed-on: https://chromium-review.googlesource.com/1124819
Reviewed-by: Moe Ahmadi (slow July 3) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#588}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}VR: remove fullscreen toast on standalones
Bug: 854181
Change-Id: Id2418b88928fcd998e67bed8f011f2dcbb4cc8f5
Reviewed-on: https://chromium-review.googlesource.com/1106293
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569036}(cherry picked from commit d2e9c37af31979c907e2a497eb72e1d89b0f34ab)
Reviewed-on: https://chromium-review.googlesource.com/1124700
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#587}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}ozone: Allow multiple delay filters for touchscreen
In order to allow more than one touch filter to delay the reporting of
touches, make the existing filter keep track of its own filter state.
BUG=b:69232663
TEST=manual testing with filters enabled
Change-Id: Idfc68fea22574becd920cdd599dd2e90e19bd04d
Reviewed-on: https://chromium-review.googlesource.com/1093584
Reviewed-by: Michael Spang <[email protected]>
Commit-Queue: Sean O'Brien <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567844}(cherry picked from commit b42a277d0612b3d982941cb144d4b7b00bbf96f4)
Reviewed-on: https://chromium-review.googlesource.com/1120756
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#586}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix InitializeOnAudioThread race.
It may race with ShutdownOnAudioThread when running the audio service
out of process.
Bug: 854816
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2ccd4254f4c4f0f70ffb2180c3a586e35ce1baed
Reviewed-on: https://chromium-review.googlesource.com/1109683
Reviewed-by: Henrik Grunell <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570029}(cherry picked from commit 75c63f8b8f1f19874867ac05a60c4ebe89496e1a)
Reviewed-on: https://chromium-review.googlesource.com/1124479
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#585}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[vr] Tune scroll event stream
This change applies three heuristics to make trackpad scrolling feel
smoother. We increase the frequency at which we submit scroll events to
the platform, we also decrease the scroll scale factor (to make the
scrolls less jumpy), and we do some simple filtering of our scroll
values.
I pair-programmed much of this change with asimjour@ and he wrote the
initial code to interpolate events in the android ui gesture target.
(cherry picked from commit 0e9a15da019624f9e5d6a3aba35b0102175da5c0)
Bug: 859075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
Reviewed-on: https://chromium-review.googlesource.com/1120425
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571535}
Reviewed-on: https://chromium-review.googlesource.com/1123463
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#584}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.50
[email protected]
Change-Id: Ia0878fb0ce8dcb7ee93004313effc94a5ca1c3ec
Reviewed-on: https://chromium-review.googlesource.com/1123622
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#583}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Avoid unnecessary SharedBuffer data segmentation
When constructing SharedBuffers from flat data, we currently defer to
SharedBuffer::AppendInternal() -- which splits the source into segments.
This is unnecessary overhead (because SharedBuffer can already track a
single flat slab in buffer_), and can generate even more churn
downstream for clients which require a flattened data view (we're
effectively splitting then reassembling the data source for no reason).
Update SharedBuffer's flat data constructors to store all the data
contiguously in buffer_ (similar to SharedBuffer::AdoptVector).
Bug: 853500
Change-Id: I523f23859e62c76225c8d5345005c5bd7911d9c3
Reviewed-on: https://chromium-review.googlesource.com/1113661
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hajime Hoshi <[email protected]>
Commit-Queue: Florin Malita <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570385}(cherry picked from commit ce42a9d24c7aac91d073851e2ed4fc3180a8384d)
Reviewed-on: https://chromium-review.googlesource.com/1123037
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#582}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix a crash on early releases of macOS 10.10.
So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.
Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571123}(cherry picked from commit f44f7dc221536b3d72c76322f17dc04fc04d892d)
Reviewed-on: https://chromium-review.googlesource.com/1123176
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#581}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Media Controls: Fix sizing issues with medium and large breakpoints
This CL updates the sizing-medium and sizing-large CSS class rules to
reduce the sizes. This update makes sizing-large mostly useless, but to
avoid making this change too complex for merging into M68, we are
updating the CSS rules in the simplest way and have added a followup
cleanup task to remove the sizing-large CSS class and other redundant
CSS rules.
Bug: 857145
Change-Id: Ifd80ff7137221f4ca86d0c27f7c4042ec569ef06
Reviewed-on: https://chromium-review.googlesource.com/1117315
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571190}(cherry picked from commit b5073e2a388dd2ab9445c8101ab0ca265eaa79fc)
Reviewed-on: https://chromium-review.googlesource.com/1123116
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#580}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1a50f0752ba631fdfa36280b6a8645d715a59491
Reviewed-on: https://chromium-review.googlesource.com/1122975
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#579}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.49
[email protected]
Change-Id: I9d097f4955b9ba09c28e3e3c60abf4315146c6f9
Reviewed-on: https://chromium-review.googlesource.com/1121896
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#578}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.48
[email protected]
Change-Id: I2de2957426223c01b8c09fb4d46e713ef8640e40
Reviewed-on: https://chromium-review.googlesource.com/1121528
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#577}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Merge M68][Extensions] Update captureVisibleTab permission checks
tabs.captureVisibleTab() is interesting. It used to work with every
URL ever, and just checked for if activeTab or <all_urls> was present.
However, this led to some issues where the extension could capture pages
it shouldn't be able to, such as https://crbug.com/810220.
Changing this to only allow access to pages that the extension had
explicit access to also broke important use cases. For instance, taking
screenshots of chrome:-scheme pages is important for filing bugs,
tracking features, etc. This similarly broke use cases for other URLs
that extensions don't have full access to, like other extensions' pages.
An exception was added for chrome:-scheme pages, but this was
insufficient for other cases.
Adjust the permissions check to allow page capture of otherwise-
restricted pages if the extension has activeTab granted. We require
activeTab (rather than either <all_urls> or activeTab) because it gives
a stronger guarantee that the user wants the extension to run on the
given site.
Note: this does not allow any other action on these restricted pages;
only capturing the page is permitted.
The new behavior enforces the following permission requirements for
the host types:
<arbitrary web page>: activeTab OR <all_urls>
file:-scheme page: (activeTab OR <all_urls>) AND
explicit file access from chrome://extensions.
Pages restricted by enterprise policy: blocked
Extension's own page: activeTab OR <all_urls>
Another extension's page: activeTab
chrome:-scheme page: activeTab
Support for IPv6 pages and pseudo urls is dependent on these being
properly supported with activeTab, which will be pursued in a followup.
Bug: 839857
[email protected]
(cherry picked from commit 955451dfb49b6cf59dc805737773e944701f9202)
Change-Id: Ied3a71732cd5d41ad16f9b459f6fda9b1815edaf
Reviewed-on: https://chromium-review.googlesource.com/1102902
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568471}
Reviewed-on: https://chromium-review.googlesource.com/1121380
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#576}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.47
[email protected]
Change-Id: Id1269ec2bc6d109d400c9507e061a6c13bd0650c
Reviewed-on: https://chromium-review.googlesource.com/1121518
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#575}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Media Controls] Update sizing CSS to new specs
This CL makes some changes to the media controls sizing. It changes the
small threshold to go up to 740px instead of 640px, it changes the
overlay play button size calculation to be smaller, and it changes the
icons to be smaller in the medium threshold.
Bug: 854361
Change-Id: Ic73d254361ffbb5b60bb974253d1abb48a8a04ce
Reviewed-on: https://chromium-review.googlesource.com/1107244
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569044}(cherry picked from commit 8b04a2116d5522871b7110eb0a9d75d044e6cee0)
Reviewed-on: https://chromium-review.googlesource.com/1119372
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#574}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Discard tab immediately without waiting for LogMemory().
LogMemory() calls memory::OomMemoryDetails::Log(), which is an async
call and may take a long time (only 60% returns < 1s, 10% returns > 5s).
When we're running out of memory, we need to discard tab faster.
BUG=850545
Change-Id: Ia652b2a80f968b0e437904bb6bc2c7c131c1958d
Reviewed-on: https://chromium-review.googlesource.com/1097038
Reviewed-by: Cheng-Yu Lee <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: François Doray <[email protected]>
Commit-Queue: Cheng-Yu Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567891}(cherry picked from commit 9f5206473f137a0ea67c645b5d9798059393c08f)
Reviewed-on: https://chromium-review.googlesource.com/1121176
Cr-Commit-Position: refs/branch-heads/3440@{#573}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Media Controls] Prevent the overlay enclosure from being 0x0
This CL adds CSS to make the overlay enclosure the size of the video
to prevent it from defaulting to 0x0. This fixes a bug where once the
overlay cast button disappeared (due to the hide timer), the user was
unable to bring it back by tapping on the overlay enclosure (since
there was nothing to tap on).
Bug: 853855
Change-Id: If4504b84c023cf7f52620ce7d58a71a5522be587
Reviewed-on: https://chromium-review.googlesource.com/1105516
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568644}(cherry picked from commit 47ae9e57670b0bbf3501bb8de627ea3d660cc713)
Reviewed-on: https://chromium-review.googlesource.com/1121156
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#572}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix passing host name property through shill Manager interface.
https://android-review.googlesource.com/c/platform/system/connectivity/shill/+/181040
replaced the "HostName" property in the shill Manager interface with a new
"DHCPProperty.Hostname" property. However, the migration was partially done,
which has been fixed by CL:1102152. This CL updates the code on the Chrome side
accordingly.
(back ported from commit bfad34f4f4251c94ae82b8b602d293968c9927f9)
Bug: 852035
Change-Id: Ib0d7fc7e82f13b9f77cda13324702f610d952f61
Reviewed-on: https://chromium-review.googlesource.com/1104312
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Ben Chan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568092}
Reviewed-on: https://chromium-review.googlesource.com/1121038
Cr-Commit-Position: refs/branch-heads/3440@{#571}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}users_private: Do not use profile for other users
GetProfileByUser() will return null for a non logged in user, so do not
use IsOwnerProfile() to set is_owner.
This also fixes behavior in ChromeUserManagerImpl where the active user
was not correctly set as the owner when kStubCrosSettings is set
because UserManagerBase::UserLoggedIn is calling
RegularUserLoggedInAsEphemeral() instead of RegularUserLoggedIn() for
non owners, and the logic to set the user as the owner was in
RegularUserLoggedIn().
[email protected]
(cherry picked from commit ef47cfb48bba0688ced57d91b1059f03dc82b99a)
Bug: 856441
Change-Id: I085d46accb3c97c1b6ee5615b838a5de796e3f8b
Reviewed-on: https://chromium-review.googlesource.com/1118921
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571341}
Reviewed-on: https://chromium-review.googlesource.com/1120947
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#570}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Merge "Don't show popup sign in window for locked profile or guest/system profile" into 68.
Bug: 855378
Change-Id: I4c14ad013f891f6abe76604321c52e97cecaf874
Reviewed-on: https://chromium-review.googlesource.com/1115433
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570793}(cherry picked from commit 0e92e3bf71e2feaf49a7b87b98488ca80c535d35)
Reviewed-on: https://chromium-review.googlesource.com/1120465
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#569}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[signin] Reconcilor handles invalidated cookies
Invalidated cookies were not handled correctly. This CL adds proper
support for them.
[email protected], treib
(cherry picked from commit 4d83639996b796350efcedbfd861cc9c520af524)
Bug: 854799
Change-Id: Iad3ee729172a7e44d737b25fb665f0009d78de84
Reviewed-on: https://chromium-review.googlesource.com/1110218
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570825}
Reviewed-on: https://chromium-review.googlesource.com/1120170
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#568}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[signin] AccountReconcilor use different Gaia sources for Dice/Mirror
The Gaia server needs to be able to distinguish between Dice and Mirror
calls.
This CL sets a new different source for Dice calls.
[email protected]
(cherry picked from commit f3c2edb0419a7f53628f98d3f82e9fdfdbd73087)
Bug: 854743
Change-Id: Id697d5aad326283b0002c6ce76dde4e619b9885e
Reviewed-on: https://chromium-review.googlesource.com/1109898
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569681}
Reviewed-on: https://chromium-review.googlesource.com/1120167
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#567}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.46
[email protected]
Change-Id: I4152845d8b0a2d733c7878f1196e6575af1ccc88
Reviewed-on: https://chromium-review.googlesource.com/1119409
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#566}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Change-Id: I73205dd3b8e94815861c7b72f73772a422cc0cc7
Reviewed-on: https://chromium-review.googlesource.com/1119381
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#565}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Change our ellipsize in FramebustBlockInfoBar.
When using a layout with ellipsize=start on old versions of Android a
crash can result. This is a speculative fix that changes the way we
ellipsize to "middle" to workaround this crash.
BUG=834959
Change-Id: I0330d9eee82400983e4407bb8a558e322cbf4482
Reviewed-on: https://chromium-review.googlesource.com/1107169
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Anita Woodruff <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570121}(cherry picked from commit 1242f8a4d3058caf32df6545a86cf9bf25aa0699)
Reviewed-on: https://chromium-review.googlesource.com/1119266
Reviewed-by: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#564}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[PE] Don't fragment painting layer of repeating table header/footer in paged media
Previously, to let the painting layer of a repeating table header/footer
in paged media initiate multi-fragment painting, we created fragments
in the painting layer. This caused several problems:
- The fragments didn't have proper fragment clips, causing non-fragmented
contents to be painted multiple times. It's also not feasible to create
fragment clips for the forced fragments on the painting layer because
we couldn't insert them into the clip tree.
- The previous "if (paint_info.FragmentToPaint(layout_table_section_))
return;" in TableSectionPainter caused nested repeating header/footer
not repeated.
Now don't fragment painting layer of repeating table header/footer in
paged media. Instead, let the repeating table header/footer repeat by
itself when needed.
[email protected]
(cherry picked from commit cf69822f0cdf24a24cce2f92fdfe029ba2cf7dfb)
Bug: 852773
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1172a334b5021eb7e987404bb72d9b841a4d39d4
Reviewed-on: https://chromium-review.googlesource.com/1112578
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569901}
Reviewed-on: https://chromium-review.googlesource.com/1119083
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#563}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix CTS webkit.WebViewHostSideStartupTest#testStrictMode
This patch only fix one violation caused by
WebViewChromiumFactoryProvider.initialize()
[email protected]
(cherry picked from commit 47262f5240d73f57606389365f499d334a931c0d)
Bug: 857121
Change-Id: Ida7d2b3df4e0e7c96f69e42e0b766dde976b2c3a
Reviewed-on: https://chromium-review.googlesource.com/1117268
Commit-Queue: Tao Bai <[email protected]>
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570931}
Reviewed-on: https://chromium-review.googlesource.com/1117841
Reviewed-by: Tao Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#562}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.45
[email protected]
Change-Id: I2ca230368c67d5ce5f754162a7ae7613eecb092c
Reviewed-on: https://chromium-review.googlesource.com/1117616
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#561}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}chrome.bluetoothSocket: Fix regression in send()
In https://crrev.com/c/997098, params_ was changed to a local variable,
but it needs to last longer than that since net::WrappedIOBuffer may use
the data after the local variable goes out of scope.
This CL changed it back to be an instance variable.
[email protected]
(cherry picked from commit c5c6320f80159dc41dffc3cfbf0298925c7dcf1b)
Bug: 851799
Change-Id: I392f8acaef4c6473d6ea4fbee7209445aa09112e
Reviewed-on: https://chromium-review.googlesource.com/1103676
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568137}
Reviewed-on: https://chromium-review.googlesource.com/1117649
Reviewed-by: Miao-chen Chou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#560}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Updating XTBs based on .GRDs from branch 3440
[email protected]
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9ef1c4feface6438102c3889958159535d192dac
Reviewed-on: https://chromium-review.googlesource.com/1117470
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#559}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}SecondaryUiMd on by default for CrOS
Enables Harmony dialog styling by default on Chrome OS dialogs. Also
see launch bug crbug.com/839559.
Bug: 783540
Test: Summon any dialog (blockers of 783540) that has been Harmonized.
Verify that it has the Harmonious styling.
Change-Id: I2c9340d33d0d404edec2b110fe4dd9d6727bc645
Reviewed-on: https://chromium-review.googlesource.com/1072727
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Greg Levin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568576}(cherry picked from commit db0e213a037aabba4e00d21c8e180af33e7a74ca)
Reviewed-on: https://chromium-review.googlesource.com/1117519
Reviewed-by: Greg Levin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#558}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix AXTreeSourceAuraTest.Accessors when Harmony is on.
When Harmony is enabled textfields have an additional child in the form
of the focus ring, so the expectation needed to be updated.
Merging to M-68 because this fixes a test which is broken by
https://chromium-review.googlesource.com/1072727
Bug: 846410
Change-Id: I0b807d7f69c97eed7bc56e9520f51d3a845fba76
Reviewed-on: https://chromium-review.googlesource.com/1103586
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568166}(cherry picked from commit d5010c9c9cff2a30d9d495d9c7a953da308ffa45)
Reviewed-on: https://chromium-review.googlesource.com/1117499
Reviewed-by: Greg Levin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#557}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Fix SadTabViewInteractiveUITest suite for Chrome OS when Refresh is on.
The test assumed BlueButton would always be used for dialog buttons,
but LabelButton is used in Harmony (which Refresh implies).
Merging to M-68 because this fixes a test which is broken by
https://chromium-review.googlesource.com/1072727
Bug: 846410
Change-Id: Id7fb8f66cc0abb120fdb81294c4d00c3faf060ae
Reviewed-on: https://chromium-review.googlesource.com/1105457
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568272}(cherry picked from commit 3183d7ced9505e878652100378d62d20a8228d47)
Reviewed-on: https://chromium-review.googlesource.com/1117518
Reviewed-by: Greg Levin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#556}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}settings: Internet: Fix configure button spacing and vis
This CL:
* Hides the 'configure' button for non secure WiFi networks (there is
nothing to configure).
* Fixes the spacing for the 'connect' and 'disconnect' buttons.
[email protected]
(cherry picked from commit 17573c429dad1deee0c668f3933efc21e6b61a3a)
Bug: 826242,838868
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id447a929234b90bfa4064a5daa88e5df6e95a4a4
Reviewed-on: https://chromium-review.googlesource.com/1089469
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#566131}
Reviewed-on: https://chromium-review.googlesource.com/1117464
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#555}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Mark ProxyChangeListener as @UsedByReflection.
A number of WebView applications in the wild use reflection to call the
proxy change broadcast receiver directly as a hack to allow them to set
an application-local proxy setting. The reflection code used searches
for ProxyChangeListener by name, so fails with proguard obfuscation
enabled for the monochrome APK. Mark the relevant classes/methods as
@UsedByReflection to ensure they don't get renamed, because while it's
not good that applications do this, there is no supported API to achieve
the same thing either, and it appears to be a commonly repeated piece of
code.
[email protected]
(cherry picked from commit 0f71a543910198ee5b4104ea0066494a3fcba309)
Bug: 851995
Change-Id: I6174181491f57fd71fece91c98ae8b96f36b425f
Reviewed-on: https://chromium-review.googlesource.com/1112564
Reviewed-by: Paul Jensen <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570479}
Reviewed-on: https://chromium-review.googlesource.com/1117331
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#554}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.44
[email protected]
Change-Id: I70b29584237cb55917bcf053d35bd2cbf135c8ac
Reviewed-on: https://chromium-review.googlesource.com/1117033
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#553}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Use shared bold fontlist delta to avoid re-deriving it.
[email protected]
(cherry picked from commit 46300153b2ec876a63795f76c2d5040fbcfaf6c0)
Bug: 843368
Change-Id: I300f2793ee70f93275be20aa77d24296d7da05d1
Reviewed-on: https://chromium-review.googlesource.com/1087317
Reviewed-by: Dave Schuyler <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Travis Skare <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#565133}
Reviewed-on: https://chromium-review.googlesource.com/1117122
Cr-Commit-Position: refs/branch-heads/3440@{#552}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Incrementing VERSION to 68.0.3440.43
[email protected]
Change-Id: Idfd15493de1646572c9d359bff11f8437d20d065
Reviewed-on: https://chromium-review.googlesource.com/1116979
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#551}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Disable state-preserving TPM firmware update.
The test team found an issue where cryptohomed fails to deal with the
state the TPM is in for the case when the update installation gets
interrupted and recovery is invoked to retry and complete the update.
Disable device-state preserving updates for now until the issue is
resolved.
BUG=chromium:854576
TEST=Triggering TPM firmware update via chrome://chrome will not invoke the device state preserving update flow.
Change-Id: I4ac4d325bfbf953cfa14a501e871a3f9f59c699c
Reviewed-on: https://chromium-review.googlesource.com/1111998
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Mattias Nissler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570020}(cherry picked from commit bcbd174038035d8c59e45a067b8bea0c16168b40)
Reviewed-on: https://chromium-review.googlesource.com/1116998
Reviewed-by: Mattias Nissler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#550}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Revert "M68 Reland "Remove blink::CallExtraOrCrash" (includes fixed)"
This reverts commit e6880fe75a2995b99bce58a418113685b5f76fe9.
Reason for revert: Breaks continuous release bots, blocking beta release.
Original change's description:
> M68 Reland "Remove blink::CallExtraOrCrash" (includes fixed)
>
> This is functionally the same as the original cherry-pick
> 17254140a1f41e6057fcb22885c6178fa82affad but with compile fixes.
>
> Also removed
> virtual/outofblink-cors/http/tests/fetch/chromium/call-extra-crash-tee.html
> and
> virtual/outofblink-cors/http/tests/fetch/chromium/release-handle-crash.html
> from SlowTests as these tests are not run in M68.
>
> Original description:
>
> CallExtraOrCrash is a function to call into V8 Extras and crash if it
> fails. Unfortunately, calling into V8 Extras can fail under normal
> conditions such as stack overflow and Worker destruction, causing a lot
> of unnecessary crashes. Remove CallExtraOrCrash.
>
> This is a stopgap change designed to be mergable to version 68. It
> avoids major code restructuring but as a result lacks robust
> encapsulation.
>
> The general strategy is to pass a boolean pointer to functions in
> ReadableStreamOperations that call into V8 Extras. If the internal call
> fails, the boolean is set to true, and the call returns a default value.
>
> BodyStreamBuffer keeps the boolean as member variable. Once a call to a
> V8 extra function fails, the boolean is set and no more calls will be
> made. This is to avoid us taking action based on information that is
> incorrect.
>
> For Tee() and the from-stream version of the BodyStreamBuffer
> constructor, we use an ExceptionState object instead. In these cases, it
> is straightforward to pass through ExceptionState object from the Blink
> bindings. This allows the failure to be propagated safely back to
> Javascript.
>
> Conversely, DefaultReaderRead() has been switched from using
> ExceptionState to using an error-signalling bool. This is because its
> callers do not have access to a real ExceptionState object. Previously
> callers used a NonThrowableExceptionState, but this was not suitable as
> DefaultReaderRead() can throw.
>
> BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so
> some degree of encapsulation has been retained.
>
> 7 new layout tests exercise each of the deterministically reachable
> crashes, using stack overflows. Because they depend on stack layout and
> whether DCHECKs are enabled, they only hit the crashes in particular
> environments.
>
> [email protected], [email protected], [email protected]
>
> (cherry picked from commit 035ce793d12dbd436c609823f7160364110c9775)
>
> Bug: 829790, 849312, 853977
> Change-Id: I730a6c42da773afd9653bb2985916ffe92bb81c6
> Reviewed-on: https://chromium-review.googlesource.com/1114404
> Reviewed-by: Adam Rice <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#522}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 829790, 849312, 853977, 856902
Change-Id: Ib1207919c376d7e1fe2c392d506dfc56085dc461
Reviewed-on: https://chromium-review.googlesource.com/1116838
Reviewed-by: Juan Antonio Navarro Pérez <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#549}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[M68] Change device_id member to be by value in InputIPC.
Bug: 854589
Change-Id: Ic3df198b77eb5dca4ebd85c637d47c162a5e58bd
Reviewed-on: https://chromium-review.googlesource.com/1107807
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568884}(cherry picked from commit 59ea0fee3d75487dbac0581cea0991a1ad0d77df)
Reviewed-on: https://chromium-review.googlesource.com/1116579
Reviewed-by: Max Morin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#548}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}Rename the ExperimentalHardwareEchoCancellation origin trial
Renaming it to ExperimentalHardwareEchoCancellation2, so that new
tokens don't trigger the old behaviour in older versions of Chrome.
The runtime flag retains its name, since that's user controlled.
Bug: 854577, 846270
Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131
Reviewed-on: https://chromium-review.googlesource.com/1106338
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Oskar Sundbom <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568821}(cherry picked from commit 65a07689aec111f6af8a2de242765647f95a0f09)
Reviewed-on: https://chromium-review.googlesource.com/1116578
Reviewed-by: Henrik Grunell <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#547}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}M68: service worker: Check for shutdown in ServiceWorkerContentSettingsProxyImpl.
context_ is a weak ptr and if shutdown is happening resource_context()
is null.
Bug: 851829
Change-Id: Ie1353b4fd583f88cc791227e2afd9ba27c3d39eb
Reviewed-on: https://chromium-review.googlesource.com/1111766
Reviewed-by: Makoto Shimazu <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569847}(cherry picked from commit 682d85240a60b8f846802e0eee600cef48159f3b)
Reviewed-on: https://chromium-review.googlesource.com/1116298
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#546}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}[Merge to M68]Enable arrow key in PowerButtonController instead of PowerButtonMenuScreenView.
[email protected]
The contents view of |menu_widget_| in PowerButtonController will be updated
when showing menu, which means the destructor of PowerButtonMenuScreenView
will not be called when DismissMenu. This will cause the arrow key traversal
enabled value in FocusManager will not be restored correctly. Move the logic from
PowerbuttonMenuScreenView into PowerButtonController to make sure the value
can be restored correctly if dismiss the menu.
(cherry picked from commit a71ca1b7e6979ad89f6ae64c290422797df11b54)
Bug: 846639
Change-Id: I32ceebb8e81cf19e3fed119af0ccee3bd8c55638
Reviewed-on: https://chromium-review.googlesource.com/1114309
Commit-Queue: Min Chen <[email protected]>
Reviewed-by: Qiang Xu <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570323}
Reviewed-on: https://chromium-review.googlesource.com/1116193
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#545}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
