Publish DEPS for 68.0.3440.70

• DEPS[diff]

Incrementing VERSION to 68.0.3440.70

[email protected]

Change-Id: I5bfa09fbbd27367cf7427a1c9ad3409fc65c3e75
Reviewed-on: https://chromium-review.googlesource.com/1142596
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#718}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

assistant: disable assistant on M68.

This fixes crash due to assistant initialization timing.

Bug: 850762
Test: Manual
Change-Id: I5bd2a81f5f8a93e8f3d6f1745bf330f7a7c11260
Reviewed-on: https://chromium-review.googlesource.com/1130546
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#717}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/BUILD.gn[diff]
• chrome/browser/ui/BUILD.gn[diff]
• chromeos/assistant/assistant.gni[diff]

Enable enterprise.reportingPrivate API on Stable.

Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8
Bug: 826298
Reviewed-on: https://chromium-review.googlesource.com/1141050
Reviewed-by: Devlin <[email protected]>
Commit-Queue: Georges Khalil <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575854}(cherry picked from commit 0eae27d80e7499c5740580c960c6bf73c81c9865)
Reviewed-on: https://chromium-review.googlesource.com/1142664
Reviewed-by: Georges Khalil <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#716}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/common/extensions/api/_permission_features.json[diff]

Disable glClear on Mali T720 12.1.01alp0

glClear appears to crash on this device. Enabling the "gl_clear_broken"
workaround.

[email protected]

(cherry picked from commit 3c98e778faedf80d25556f9f2dc985985ca31c99)

BUG: 860418
Change-Id: I06ff00e2aa7523b43e283bcdc09b2d36ceacf4e4
Reviewed-on: https://chromium-review.googlesource.com/1137784
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: Eric Karl <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#576163}
Reviewed-on: https://chromium-review.googlesource.com/1142531
Reviewed-by: Eric Karl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#715}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• gpu/config/gpu_driver_bug_list.json[diff]

Incrementing VERSION to 68.0.3440.69

[email protected]

Change-Id: Ie9b44779b4417d950e589e758161bacb28b0c0f3
Reviewed-on: https://chromium-review.googlesource.com/1142042
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#714}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

fix build error, file was moved

Bug: 864889
Change-Id: Ica61026c2ebcc02e6424f8f6665baf1be133c4ff
Reviewed-on: https://chromium-review.googlesource.com/1141986
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#713}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/offline_pages/core/model/store_thumbnail_task_unittest.cc[diff]

DevTools: Restore colorpicker functionality on pre-m67 custom palettes

Bug:851311

Change-Id: Ia13bc1f082b69f37ee8ca65ac467cea166c11a2b
Reviewed-on: https://chromium-review.googlesource.com/1120951
Commit-Queue: Andrey Lushnikov <[email protected]>
Reviewed-by: Andrey Lushnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572146}(cherry picked from commit 426c0fc678846f56a905eca26feb182b34742bf6)
Reviewed-on: https://chromium-review.googlesource.com/1140461
Reviewed-by: Paul Irish <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#712}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/devtools/front_end/color_picker/Spectrum.js[diff]

desktop-pwas: Don't check offline state for Desktop PWAs

Cherry pick of c1c7c251887831a406eb9a94f24ae7084c59abca for 68

FindMatchingUrlHandler checks if the Chrome app supports offline and if
not returns no matching URL handlers. This is done in order to avoid
redirecting links to apps that don't support offline.

Unfortunately, this offline check causes problems for Desktop PWAs.
Desktop PWAs use FindMatchingUrlHandler to decide if a URL belongs to an
app. Because of the check in FindMatchingUrlHandler, it seems as if no
URLs belong to the app.

To solve the issue, we introduce separate methods to be used by
Bookmark Apps and Platform Apps. The Platform Apps method checks
for offline and the Bookmark Apps one does not.

[email protected],[email protected],[email protected]


Bug: 850626
Change-Id: I7560be15df73c51f040db2796dbce0fa3ca758fe
Reviewed-on: https://chromium-review.googlesource.com/1140342
Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#711}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/apps/platform_app_navigation_redirector.cc[diff]
• chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc[diff]
• chrome/browser/extensions/extension_util.cc[diff]
• chrome/common/extensions/api/url_handlers/url_handlers_parser.cc[diff]
• chrome/common/extensions/api/url_handlers/url_handlers_parser.h[diff]

Incrementing VERSION to 68.0.3440.68

[email protected]

Change-Id: I44c7096fe996676684d53341c0128173afad4544
Reviewed-on: https://chromium-review.googlesource.com/1141268
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#710}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Adjust out-of-flow position for rtl container with left-hand scrollbar

Cherry-picked from:

https://chromium-review.googlesource.com/1125335

BUG=832569
[email protected],[email protected]

Change-Id: I7d2f26800ed5a410b0cca9bb61bf7529c2298536
Reviewed-on: https://chromium-review.googlesource.com/1141213
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#709}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/fast/block/rtl-abs-pos-container-with-scrollbar-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/fast/block/rtl-abs-pos-container-with-scrollbar.html[Added - diff]
• third_party/blink/renderer/core/layout/layout_box.cc[diff]

[M68 branch] Add Lao/Thai spoofable entries

    U+0E1E (พ) => w
    U+0E9E (ພ) => w
    U+0E9F (ຟ) => w

    U+0EA3 (ຣ) => s
    U+0EAE (ຮ) => s

    U+0E1A (บ) => u
    U+0E9A (ບ) => u

    Note that U+0E1F(ฟ) and U+0E23 (ร) were added a while ago.

BUG=833143
TEST=components_unittests --gtest_filter=*IDN*
[email protected],[email protected]

Change-Id: I882e7d272cdca1d80aa23be94b4d7906ff8653c1
Reviewed-on: https://chromium-review.googlesource.com/1058710
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562565}
Reviewed-on: https://chromium-review.googlesource.com/1141215
Reviewed-by: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#708}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/url_formatter/idn_spoof_checker.cc[diff]
• components/url_formatter/top_domains/test_domains.list[diff]
• components/url_formatter/top_domains/test_skeletons.gperf[diff]
• components/url_formatter/url_formatter_unittest.cc[diff]

Incrementing VERSION to 68.0.3440.67

[email protected]

Change-Id: Ie92f43660a68bec131a78911cbd83e8751879083
Reviewed-on: https://chromium-review.googlesource.com/1141224
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#707}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[Merge M68][Autofill] Modify origin to only keep settings or empty.

Since the only use Autofill has for the origin is checking whether
is is equal to the settings origin, the only values we should keep
are the settings origin and empty.

I'll prepare a follow-up CL where this string is changed to an enum.

[email protected]

Change-Id: I6f1a5647670d4e5228be4d625db650cab38dcc5a
Reviewed-on: https://chromium-review.googlesource.com/1136933
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575306}
Reviewed-on: https://chromium-review.googlesource.com/1140929
Cr-Commit-Position: refs/branch-heads/3440@{#706}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java[diff]
• components/autofill/core/browser/autofill_profile.cc[diff]
• components/autofill/core/browser/autofill_profile_unittest.cc[diff]
• components/autofill/core/browser/autofill_test_utils.cc[diff]
• components/autofill/core/browser/autofill_test_utils.h[diff]
• components/autofill/core/browser/credit_card.cc[diff]
• components/autofill/core/browser/credit_card_unittest.cc[diff]
• components/autofill/core/browser/form_data_importer.cc[diff]
• components/autofill/core/browser/form_data_importer_unittest.cc[diff]
• components/autofill/core/browser/personal_data_manager.cc[diff]
• components/autofill/core/browser/personal_data_manager.h[diff]
• components/autofill/core/browser/personal_data_manager_unittest.cc[diff]
• components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc[diff]
• components/autofill/core/browser/webdata/autofill_profile_syncable_service.h[diff]
• components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc[diff]
• components/autofill/core/browser/webdata/web_data_service_unittest.cc[diff]

M68: service worker: Gate eager CacheStorage setup behind a feature flag.

This will enable us to disable the optimization via a field trial kill
switch if needed.

(cherry picked from commit c25fea4b813655a45ff64a1d6f523504733b9e02)

Bug: 854905
Change-Id: Ic312cbedd7685761a45fee986061767b14295afa
Reviewed-on: https://chromium-review.googlesource.com/1139457
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575566}
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/1140338
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#705}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/service_worker/embedded_worker_instance.cc[diff]
• content/browser/service_worker/embedded_worker_instance_unittest.cc[diff]
• content/renderer/service_worker/embedded_worker_instance_client_impl.cc[diff]
• third_party/blink/common/BUILD.gn[diff]
• third_party/blink/common/features.cc[Added - diff]
• third_party/blink/public/common/BUILD.gn[diff]
• third_party/blink/public/common/features.h[Added - diff]

M68: service worker: Eagerly provide CacheStoragePtr at worker startup.

Most service workers will need CacheStoragePtr in a performance
sensitive way. We discovered there is slowness using InterfaceProvider
to get the ptr on first use after worker startup.

(cherry picked from commit d1d43314ace95237cea594fd77a262dfdffb1e4b)

Bug: 854905
Change-Id: Iefcd8910d1b8b6ba1cfcc4df79c213abde0f9e3a
Reviewed-on: https://chromium-review.googlesource.com/1124130
Commit-Queue: Matt Falkenhagen <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572544}
TBR: shimazu, kinuko
Reviewed-on: https://chromium-review.googlesource.com/1140337
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#704}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/renderer_host/render_process_host_impl.h[diff]
• content/browser/service_worker/embedded_worker_instance.cc[diff]
• content/browser/service_worker/embedded_worker_instance.h[diff]
• content/browser/service_worker/embedded_worker_instance_unittest.cc[diff]
• content/common/service_worker/service_worker_provider.mojom[diff]
• content/public/browser/render_process_host.h[diff]
• content/public/test/mock_render_process_host.cc[diff]
• content/public/test/mock_render_process_host.h[diff]
• content/renderer/service_worker/embedded_worker_instance_client_impl.cc[diff]
• content/renderer/service_worker/embedded_worker_instance_client_impl.h[diff]
• third_party/blink/public/web/web_embedded_worker.h[diff]
• third_party/blink/renderer/modules/cache_storage/cache_storage.cc[diff]
• third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc[diff]
• third_party/blink/renderer/modules/exported/web_embedded_worker_impl.h[diff]
• third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.cc[diff]
• third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope.h[diff]
• third_party/blink/renderer/modules/serviceworkers/service_worker_thread.cc[diff]
• third_party/blink/renderer/modules/serviceworkers/service_worker_thread.h[diff]
• third_party/blink/renderer/modules/serviceworkers/web_embedded_worker_impl_test.cc[diff]
• third_party/blink/renderer/platform/mojo/revocable_interface_ptr.h[diff]

Throttle url download requests from a RenderFrame

RenderFrameImpl::DownloadUrl() can be abused to trigger a large number
of download to overwhelm the browser process.
This CL rate limits the number of download to a maximum of 10 per second.

Bug: 860045
Change-Id: I490ae3a99eb59aef709b9f1e6be5eb0f787354f4
Reviewed-on: https://chromium-review.googlesource.com/1132485
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574078}(cherry picked from commit a13cb2a1020b933c070d9db84fbc48dae5b0e1c6)
Reviewed-on: https://chromium-review.googlesource.com/1140457
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#703}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/renderer/render_frame_impl.cc[diff]
• content/renderer/render_frame_impl.h[diff]
• content/renderer/render_frame_impl_browsertest.cc[diff]

Fix a crash that startForeground is not called after startForegroundService() call

[email protected]
BUG=826998

(cherry picked from commit c0b4e54e9b2f8ba5b3fa2d9a647c11b1bac67d1b)

Change-Id: Ifcd496ae29831730b1a960478ad42eea8246c2ef
Reviewed-on: https://chromium-review.googlesource.com/1128564
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574215}
Reviewed-on: https://chromium-review.googlesource.com/1141053
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#702}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java[diff]

[Video Capture Win] Fallback to DirectShow when MediaFoundation offers no video format

Devices like Pinnacle Dazzle are listed in DirectShow with their video
formats while listed in MediaFoundation with no available video format
at all.

This makes the capture factory fallback to DirectShow implementation
when it contains at least one video format and its MediaFoundation
counterpart has none.

[email protected]

(cherry picked from commit 3772661191b045df5ed2df7aa6fde0a787967fae)

Bug: 862395
Change-Id: I5d02f97971d4cf98372e12bb96c0b7ad9cc6d9c3
Reviewed-on: https://chromium-review.googlesource.com/1137817
Commit-Queue: Christian Fremerey <[email protected]>
Reviewed-by: Christian Fremerey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575667}
Reviewed-on: https://chromium-review.googlesource.com/1141051
Cr-Commit-Position: refs/branch-heads/3440@{#701}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• media/capture/video/win/video_capture_device_factory_win.cc[diff]
• media/capture/video/win/video_capture_device_factory_win.h[diff]
• media/capture/video/win/video_capture_device_factory_win_unittest.cc[diff]

VR: fix autofill popup size

Break SetAlertDialogSize into to methods. One to set the relative
size to the main content, another one to set the absolute size.
Also added comment to hosted_platform_ui to clarify the size of
the rectangle in the model.

Bug: 863071
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
Reviewed-on: https://chromium-review.googlesource.com/1132140
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574688}(cherry picked from commit 9d07f06bb5c43657ce38efc57039e36287eac2a6)
Reviewed-on: https://chromium-review.googlesource.com/1140554
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#700}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/android/vr/vr_shell_gl.cc[diff]
• chrome/browser/vr/model/hosted_platform_ui.h[diff]
• chrome/browser/vr/ui.cc[diff]
• chrome/browser/vr/ui.h[diff]

Fix <select> popup width

Fix typo in calculation of AnchoredPopupWindow's width.

Bug: 862594
Change-Id: I0f79ca75c1d3c003d24dcba835fb6925b8d1dab5
Reviewed-on: https://chromium-review.googlesource.com/1136723
Reviewed-by: Bo <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574999}(cherry picked from commit 73221c336f865b79a8738f12f623d11568e28b0f)
Reviewed-on: https://chromium-review.googlesource.com/1140933
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#699}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ui/android/java/src/org/chromium/ui/widget/AnchoredPopupWindow.java[diff]

Check against null frame_ in GetCanonicalUrlForSharing

Bug: 852350
Change-Id: Ib6c4cc79572d3dad22f663ec61a20bc54f5d7a8f
Reviewed-on: https://chromium-review.googlesource.com/1117847
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574651}(cherry picked from commit dd341220c263993037559e62938d54d5cf091a2c)
Reviewed-on: https://chromium-review.googlesource.com/1140517
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#698}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/frame_host/render_frame_host_impl.cc[diff]
• content/browser/frame_host/render_frame_host_impl_browsertest.cc[diff]

[Pwd List] Fix Display Of Passwords

This change fixes a bug when re-rendering the list of passwords after a
password store mutation. This bug could give the impression that a wrong
password was deleted.

Bug: 862119
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I13f42a18567f84e191e99a2beb6d00ee7e82e682
Reviewed-on: https://chromium-review.googlesource.com/1138233
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575474}(cherry picked from commit 3f2d86f2d225af1bc3acf4f50c6887c65a5b2678)
Reviewed-on: https://chromium-review.googlesource.com/1140853
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#697}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js[diff]
• chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js[diff]
• chrome/test/data/webui/settings/settings_passwords_section_browsertest.js[diff]

More granular UseCounter for document.open()

[email protected]

(cherry picked from commit 136369cac7fc33a14bea3c6650af8ac3bbaf6813)

Bug: 859691
Change-Id: I9f1fbb3dac9b794dcf1f069447096c8559e03d5b
Reviewed-on: https://chromium-review.googlesource.com/1123202
Commit-Queue: Timothy Gu <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Hayato Ito <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572316}
Reviewed-on: https://chromium-review.googlesource.com/1140205
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#696}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/fast/dom/Document/document-open-use-counters-0args.html[Added - diff]
• third_party/WebKit/LayoutTests/fast/dom/Document/document-open-use-counters-1arg.html[Added - diff]
• third_party/WebKit/LayoutTests/fast/dom/Document/document-open-use-counters-2args-replace.html[Added - diff]
• third_party/WebKit/LayoutTests/fast/dom/Document/document-open-use-counters-2args.html[Added - diff]
• third_party/WebKit/LayoutTests/fast/dom/Document/document-open-use-counters-3args.html[Added - diff]
• third_party/blink/public/platform/web_feature.mojom[diff]
• third_party/blink/renderer/core/dom/document.cc[diff]
• third_party/blink/renderer/core/dom/document.idl[diff]
• tools/metrics/histograms/enums.xml[diff]

Fix crash: db is null on database failure (M68 merge)

(cherry picked from commit f88ccb0851d0259fec2a4e37d59d0ba3caa1b99d)

Bug: 860228
Change-Id: I8ea5f1f39b8d9a62b5f2a4c608e9a1054d0fb297
Reviewed-on: https://chromium-review.googlesource.com/1129466
Commit-Queue: Dan H <[email protected]>
Reviewed-by: Carlos Knippschild <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575105}
Reviewed-on: https://chromium-review.googlesource.com/1140736
Cr-Commit-Position: refs/branch-heads/3440@{#695}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/offline_pages/core/model/cleanup_thumbnails_task.cc[diff]
• components/offline_pages/core/model/cleanup_thumbnails_task_unittest.cc[diff]
• components/offline_pages/core/model/get_thumbnail_task.cc[diff]
• components/offline_pages/core/model/get_thumbnail_task_unittest.cc[diff]
• components/offline_pages/core/model/has_thumbnail_task.cc[diff]
• components/offline_pages/core/model/has_thumbnail_task_unittest.cc[diff]
• components/offline_pages/core/model/store_thumbnail_task.cc[diff]
• components/offline_pages/core/model/store_thumbnail_task_unittest.cc[diff]

Merge to M68: Support beforeunload handlers for OOPIFs.

Currently, when a frame navigates, or a tab closes, we only run
beforeunload handlers in the affected frame, but not in its
cross-process subframes.  This can cause data loss in those subframes.
For example, if a subframe contains an editable Google Doc or Office
Online doc with unsaved changes, it uses beforeunload to prompt the
user about losing those changes.

This CL introduces support to dispatch beforeunload handlers to
cross-process subframes.  We now dispatch multiple
FrameMsg_BeforeUnload IPCs and wait for all of them to receive
beforeunload ACKs before proceeding with a navigation or tab close.
This is done for browser-initiated navigations, renderer-initiated
navigations, and when closing a tab or browser.

For more details and design discussions, see
https://docs.google.com/document/d/1XmwjGNUl_PF9OgDTs0JsRe0iuGrtEk6mzDYGkkbqHKg/edit#

A few notable tradeoffs and compromises in this initial CL:

- We send one IPC per local root (roughly) and let Blink process
  same-site descendants.

- Cross-site beforeunload handlers run in parallel; we only guarantee
  ordering among same-site frames.  This is similar to how we handle
  unload handlers.

- For now, we always send the beforeunload IPC to a navigating frame.
  For subframes, we only send it if the subframe has registered a
  beforeunload handler.

- Renderer-initiated navigations still execute the navigating frame's
  beforeunload before notifying the browser process about the
  navigation.  The browser process then additionally executes any
  cross-site subframe beforeunload handlers, if needed.  This avoids
  an extra IPC roundtrip.

- beforeunload in window.close() is not yet supported.  This is
  essentially a renderer-initiated tab close, and it expects to
  synchronously set window.closed after executing beforeunload
  handlers in all subframes.  Supporting this is left to a future CL.

- Blink currently implements an intervention to limit the number of
  beforeunload dialogs shown to at most one per navigation.  To
  support this with OOPIFs, similar support is added on the browser
  side in RFHI::OnRunBeforeUnloadConfirm().  More followup work will
  be needed here with renderer-initiated navigations and with
  recording metrics.

Change-Id: I0b1f86c119a548ee16d34eff229705748f9560be
Bug: 853021
Reviewed-on: https://chromium-review.googlesource.com/1121586
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575133}
Reviewed-on: https://chromium-review.googlesource.com/1137839
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#694}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/chrome_site_per_process_browsertest.cc[diff]
• chrome/browser/ui/tabs/tab_strip_model.cc[diff]
• chrome/browser/unload_browsertest.cc[diff]
• content/browser/frame_host/navigator_impl.cc[diff]
• content/browser/frame_host/render_frame_host_impl.cc[diff]
• content/browser/frame_host/render_frame_host_impl.h[diff]
• content/browser/frame_host/render_frame_host_impl_browsertest.cc[diff]
• content/browser/renderer_host/render_view_host_impl.cc[diff]
• content/browser/web_contents/web_contents_impl.cc[diff]
• content/browser/web_contents/web_contents_impl.h[diff]
• content/public/browser/web_contents.h[diff]
• content/renderer/render_frame_impl.cc[diff]

sql: Disable very long running ScopedCriticalAction's on iOS.

We are currently marking all critical actions as iOS long running
tasks, even tasks with delays.  Because some tasks have long delays,
we always use the maximum 3 minutes before the system suspends us.

This should be reverted once crbug.com/861889 is fixed and delayed
long running tasks are not marked as iOS-critical until they begin
running.

Bug: 861889
Change-Id: I3654ac9b5d94b5d52abef14a79253bd8a9290077
Reviewed-on: https://chromium-review.googlesource.com/1129829
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573770}(cherry picked from commit 19ba5438485d0a4abdab60f495921559fcad9e53)
Reviewed-on: https://chromium-review.googlesource.com/1140553
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#693}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• sql/initialization.cc[diff]

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

Bug: 845111
Change-Id: Id329dd842aaa7b65d29257d54cef8922db84f993
Reviewed-on: https://chromium-review.googlesource.com/1139053
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#692}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc[diff]

Revert "Pass current tab as opener when opening new tab"

This reverts commit 6bdafce48e5663385945c942cb5fbbf5e4edc3f7.

Reason for revert: This CL is breaking the child ordering of tabs creating with Long Press on a link -> Open in a New Tab. They are now opened after the last page opened with ToolsMenu -> Open New Tab. See crbug.com/859508

Original change's description:
> Pass current tab as opener when opening new tab
>
> Pass the current tab as the opener when opening a new tab.
> This allow selection the previous current tab when the
> tab is closed via "pull-to-close" action or via the new
> "close" action in the UI refresh.
>
> The current tab is passed when tab is opened via ([*]
> denotes that this behaviour is added by this CL):
> - open tab in background
> - "New Tab" menu action [*]
> - captive portal detection [*]
> - search by image [*]
>
> Bug: 661988
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79
> Reviewed-on: https://chromium-review.googlesource.com/1068680
> Reviewed-by: Eugene But <[email protected]>
> Reviewed-by: Mark Cogan <[email protected]>
> Commit-Queue: Sylvain Defresne <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#561427}

[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 661988, 859508
Change-Id: I14e6f2350bad216381224aaf3319018e1c1ffdf1
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1124279
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572173}(cherry picked from commit 5cf2911fabed50b4b13f648f3ff7f53c641c895c)
Reviewed-on: https://chromium-review.googlesource.com/1139953
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#691}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/chrome/app/application_delegate/url_opener_unittest.mm[diff]
• ios/chrome/app/main_controller.mm[diff]
• ios/chrome/browser/ui/browser_view_controller.h[diff]
• ios/chrome/browser/ui/browser_view_controller.mm[diff]

Eliminate unnecessary bounds change request

* ClientControlled do not have to have a new bounds when
  window is moved to another tree beucase the bounds will
  be controlled by a client. (window_positioning_utility.cc)
* Update bounds locally when the window is added to another display.
* Do not move the display if the bounds is set by geometry change.
  This scenario isn't important right now and will be fixed by
  neww api.

(cherry picked from commit caf225a5b277397876aa62a44eb20effe52681ac)

Bug: 862791, b/110171997
TEST: will be covered by a unit test in a separate CL.
Change-Id: I2be5748661c680fb35bdaa1d25a2bd209edc4a7d
Reviewed-on: https://chromium-review.googlesource.com/1134419
Reviewed-by: Dominik Laskowski <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574737}
Reviewed-on: https://chromium-review.googlesource.com/1139574
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#690}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/wm/client_controlled_state.cc[diff]
• ash/wm/client_controlled_state.h[diff]
• ash/wm/client_controlled_state_unittest.cc[diff]
• ash/wm/window_positioning_utils.cc[diff]
• components/exo/client_controlled_shell_surface.cc[diff]

Incrementing VERSION to 68.0.3440.66

[email protected]

Change-Id: I4013603ff16c17af78f405fc5298eaf8255b8a2c
Reviewed-on: https://chromium-review.googlesource.com/1139311
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#689}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Remove not-tablet short circuit in DeviceFormFactor

This patch removes an early return from
DeviceFormFactor#detectScreenWidthBucket that will allow tablets to
return their screen width "bucket". This should prevent tablets from
trying to load phone resources in certain cases.

[email protected]

(cherry picked from commit 126cbe2f37715218e257506cad07091d3261941d)

Bug: 850096
Change-Id: I41868ed5ff582e86b9fb979d1e1a31f215e9d135
Reviewed-on: https://chromium-review.googlesource.com/1125205
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: agrieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573368}
Reviewed-on: https://chromium-review.googlesource.com/1139077
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#688}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ui/android/java/src/org/chromium/ui/base/DeviceFormFactor.java[diff]

Merge M68: Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb18-24.html

BUG=412078
[email protected]

(cherry picked from commit e233c1d178562ac6171d190f1e4d9ec9a94ac11e)

Cq-Include-Trybots: luci.chromium.try:closure_compilation;master.tryserver.chromium.linux:closure_compilation
Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69
Reviewed-on: https://chromium-review.googlesource.com/1135713
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574705}
Reviewed-on: https://chromium-review.googlesource.com/1139051
Cr-Commit-Position: refs/branch-heads/3440@{#687}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/resources/plugin_metadata/plugins_linux.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_mac.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_win.json[diff]

arc: bluetooth: Fix a bug where we never send cached device as intended

SendCached.*() never works as our imagination goes.
Cached found devices are always ignored in SendDevices().

Also sends out paired devices in SendCachedDevicesFound(). A paired
device can still have different UUIDs from last time we report to
Android, which should get the latest UUID list as long as it's scanning.
As a matter of fact, the secure client test needs to know the updated
UUIDs on a paired device in order to figure out which one to connect to.

This has an impact on crbug/853037 and crbug/841041 also, as devices are
always paired before connected in BlueZ.

BUG=b:78593133,chromium:853037,chromium:841041
TEST=Confirm from logs that UUIDs are updated even for paired devices
[email protected]

(cherry picked from commit 69e6a7872f1de61abdaee62d873f12a4c8340e6e)

Change-Id: I6f1dae8be9bb1eb9b0d8cb5c2a146ec07d4ee099
Reviewed-on: https://chromium-review.googlesource.com/1105559
Commit-Queue: Qiyu Hu <[email protected]>
Reviewed-by: Luis Hector Chavez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568505}
Reviewed-on: https://chromium-review.googlesource.com/1138434
Reviewed-by: Miao-chen Chou <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#686}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc[diff]
• chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.h[diff]

Adjust frame pixel width in phantom window

Since the width is given in pixels which is correct
only on the display with the same DSF, the width needs to
be multiplied by phanton window scale / source scale.

BUG=861967
TEST=Manual. See bug for repro step.

Change-Id: Ib073bb705d8998cf07f41f9d646f0c23828b48de
Reviewed-on: https://chromium-review.googlesource.com/1130595
Reviewed-by: Jun Mukai <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573550}(cherry picked from commit 4596251cd724b6b2769537558c5fdb3d7f16c413)
Reviewed-on: https://chromium-review.googlesource.com/1138895
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#685}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/frame/default_frame_header.cc[diff]

Extend SW fallback for VP9 SVC to all platforms.

Initially the fallback was only applied to Windows. But we found
recently that the issue affects ChromeOS as well.

This extends the software fallback to all platforms since we are not
aware about any HW which can reliably decode VP9 SVC.

[email protected]

Bug: 863378
Change-Id: Ie96ffea9f35ae5ce3c1247a1bdf0d6f28f5235c8
Reviewed-on: https://chromium-review.googlesource.com/1133390
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574275}(cherry picked from commit 10acfe9a013ab9382993eb4641aaeaad99711bdd)
Reviewed-on: https://chromium-review.googlesource.com/1138833
Cr-Commit-Position: refs/branch-heads/3440@{#684}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/renderer/media/webrtc/rtc_video_decoder.cc[diff]

Fall back to SW decoding if VP9 SVC is detected.

VP9 DXVA decoders don't have SVC support. They fail to decode high
spatial layers.

Fall back to software decoding if input bitstream has more than one
spatial layer.

[email protected]

Bug: 863378
Change-Id: Ie35ea58afd7b4cf6887f4fa88bb28cf9e59b454d
Reviewed-on: https://chromium-review.googlesource.com/1074694
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Silkin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#563567}(cherry picked from commit baa63d79ec8713a3c338e7def0dfe5cd594e804a)
Reviewed-on: https://chromium-review.googlesource.com/1137853
Cr-Commit-Position: refs/branch-heads/3440@{#683}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/renderer/media/webrtc/rtc_video_decoder.cc[diff]

Incrementing VERSION to 68.0.3440.65

[email protected]

Change-Id: Ib145bfe980d1ccd1c3bb5659ee009c1ee6d8fd26
Reviewed-on: https://chromium-review.googlesource.com/1138755
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#682}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Fix m68 build.

"Don't crash on null peer handler" (9f4ae0a) landed as an unmodified
cherry-pick into m68. Unfortunately, one of the referenced enums changed
from 'enum' to 'enum class' between m68 and m69. This updates m68 to use
the 'enum' which exists in that branch.

Bug: chromium:855161
Change-Id: I9db71ed3398f3364f652ba6f11b50fc0b2bcf44c
Reviewed-on: https://chromium-review.googlesource.com/1138352
Reviewed-by: Ben Wagner <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#681}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc[diff]

[Merge to 3440] Add the LSEnvironment variable MallocNanoZone=0.

There appears to be a bug in Launch Services that causes MallocNanoZone=1 to
always be set by default for all applications [this affects applications
launched by Finder, and on restart, but not applications launched from the
Terminal]. I filed https://bugreport.apple.com/web/?problemID=42181038 to track
this.

MallocNanoZone causes libMalloc to use the nano malloc zone by default [affects
allocations <= 256 bytes]. The implementation of nano malloc never frees memory.
See https://bugs.chromium.org/p/chromium/issues/detail?id=861939#c6 for more
details.

This has been observed to cause > 1GB of wasted memory in the browser process.
Possibly a lot more when added up across all processes.

To test this:
1) Build Chrome with patch.
2) Run
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister
-f <path_to_chrome>
3) Launch Chrome from Finder
4) Use "vmmap <pid>" to observe whether there is a MALLOC_NANO summary.

Bug: 861939
Change-Id: I740bcbb006e4ce641d0dde6f6e53dcf4f032ff0b
Reviewed-on: https://chromium-review.googlesource.com/1137131
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#575108}(cherry picked from commit b32a54d5896276f5f7be79e120e410e1e2537c63)
Reviewed-on: https://chromium-review.googlesource.com/1138294
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#680}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/app/app-Info.plist[diff]
• chrome/app/helper-Info.plist[diff]

Roll FreeType for m68.

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/9e345c911714ed62250be13d03d72e25d91fbc77..62b55f8e51ea8b2b244d8e2ccff5c6aa2170260c

Pick up fuzzer fixes.

BUG=chromium:859303

Change-Id: Ia298dcdf8339e3310b0b64f01c1a3cb180e5d572
Reviewed-on: https://chromium-review.googlesource.com/1138349
Reviewed-by: Ben Wagner <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#679}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• DEPS[diff]

Return itself as target if View doesn't have valid InputTargetClient.

When a RenderWidgetHostViewBase doesn't have a valid InputTargetClient
in rare cases on Mac, fallback to early return itself as the target.

Bug: 859492
Change-Id: If473238b947ab2d13512c3ae8d5a818da71584dc
Reviewed-on: https://chromium-review.googlesource.com/1127358
Commit-Queue: Ria Jiang <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573395}(cherry picked from commit 4670914de3558c1487b86dcbff46c3e6c046e43e)
Reviewed-on: https://chromium-review.googlesource.com/1138517
Reviewed-by: Ria Jiang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#678}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/renderer_host/render_widget_targeter.cc[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Change-Id: Ic949dbee7030e656b3ebd34e13a0e13935a3c17b
Reviewed-on: https://chromium-review.googlesource.com/1138536
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#677}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/strings/components_strings_ko.xtb[diff]

[Merge-M68] [Autofill] Allow crowdsourcing of big forms

This CL increases |kMaxFieldsOnTheForm| to 100 in |FormStructure::IsMalformed|.
It allows to crowdsource more forms. See the bug for details. Later the
parameter will be increased even more and will be finchable.

UMA histogram is introduced to monitor the size of forms Autofill has to process.

TODO: Finch-controlled threshold and UKM metric.

Bug: 857454
Change-Id: I50c1382dd36e2c707cd34f1a4f139413d9ea6026
Reviewed-on: https://chromium-review.googlesource.com/1131457
Reviewed-by: Roger McFarlane <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#574150}

Change-Id: Ic53976ddf92e963119909339ec495938820e4abd
Reviewed-on: https://chromium-review.googlesource.com/1137815
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#676}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/autofill/core/browser/form_structure.cc[diff]
• components/autofill/core/browser/form_structure_unittest.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

Don't crash on null peer handler

This is a mitigation of a crash with an unknown cause, which
seems to be causing peer_handler_ to be NULL at an unexpected time.

It returns a rejected promise instead of crashing.

Bug: chromium:855161
Change-Id: Icbb4f42780ae0969ad4d0eff2ef1e9f66a129c11
Reviewed-on: https://chromium-review.googlesource.com/1128972
Commit-Queue: Harald Alvestrand <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573462}(cherry picked from commit 6266d795bb329bae876f9568040eee40aa840d0e)
Reviewed-on: https://chromium-review.googlesource.com/1137895
Reviewed-by: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#675}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc[diff]

Incrementing VERSION to 68.0.3440.64

[email protected]

Change-Id: I25849d52eb293860506321008c2d3120842496d5
Reviewed-on: https://chromium-review.googlesource.com/1137887
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#674}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Incrementing VERSION to 68.0.3440.63

[email protected]

Change-Id: I90ab636078079946fc8c878abccc36a0bffe1d5c
Reviewed-on: https://chromium-review.googlesource.com/1137874
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#673}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Incrementing VERSION to 68.0.3440.62

[email protected]

Change-Id: I45878ebbe2614d88c6687bb7e2a0a59ce3fbafb2
Reviewed-on: https://chromium-review.googlesource.com/1137220
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#672}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

M68: Make the Cloud Print service process listen for WM_QUIT.

The Windows base::MessagePumpUI used to process WM_QUIT, but r553653
changed it to ignore WM_QUIT. This CL adds EnableWmQuit() methods to
MessagePumpForUI and MessageLoopForUI on Windows. The Cloud Print
service process can then call EnableWmQuit() for its MessagePumpForUI
to get the old behavior.

BUG=860827
[email protected]

(cherry picked from commit 23e212e0f9b0d23d39b8958bd44d5b7a0408cb60)

Change-Id: Ie9d9c4c8e2dd205f3ec24cb10be364d0653a7f97
Reviewed-on: https://chromium-review.googlesource.com/1128327
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Wez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573620}
Reviewed-on: https://chromium-review.googlesource.com/1137030
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#671}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• base/message_loop/message_loop.cc[diff]
• base/message_loop/message_loop.h[diff]
• base/message_loop/message_loop_unittest.cc[diff]
• base/message_loop/message_pump_win.cc[diff]
• base/message_loop/message_pump_win.h[diff]
• chrome/service/service_main.cc[diff]

Remove CHECK for IPC message queue size

This CHECK was added to diagnose the leaks covered by
https://crbug.com/813045 which are now well understood.
No longer needed.

[email protected], [email protected]

(cherry picked from commit 8984dbc30e230260f717ac1dc02f8774d6f05a2e)

Bug: 826432,813045
Change-Id: I691f4c9a4c4cd9bc5b8823cfae2d9c8bc3cfeabe
Reviewed-on: https://chromium-review.googlesource.com/1124663
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572259}
Reviewed-on: https://chromium-review.googlesource.com/1136983
Cr-Commit-Position: refs/branch-heads/3440@{#670}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ipc/ipc_mojo_bootstrap.cc[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I47578a87ed2bd4c9a0f9aa4bb22b1dcdf863131d
Reviewed-on: https://chromium-review.googlesource.com/1136894
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#669}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_ja.xtb[diff]
• components/policy/resources/policy_templates_lt.xtb[diff]
• components/policy/resources/policy_templates_ta.xtb[diff]
• content/app/strings/translations/content_strings_pt-PT.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb[diff]

Fix incorrect return in finally block losing exceptions.

Returning in a finally block causes exceptions to be discarded. There's
no reason to log a UMA stat for the performance of a startup that threw
an exception (since we're going to crash the app anyway), so just take
it entirely outside the finally block and invert the condition to only
record the UMA stat if mFactory.hasStarted().

Also adjust another place that had the same pattern without the "return"
to match, as again there's no need to log the UMA stat when there's an
exception.

[email protected]

(cherry picked from commit 8d96473d6b6ef429cdeeb80ae682e8daa5c74a29)

Bug: 862662
Change-Id: Ie6d24cee5bb9342016c364244256c8b73a8184f7
Reviewed-on: https://chromium-review.googlesource.com/1133332
Commit-Queue: Richard Coles <[email protected]>
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#574941}
Reviewed-on: https://chromium-review.googlesource.com/1136871
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#668}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java[diff]
• android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java[diff]

Remove incorrect DCHECK from WindowPerformance::RegisterEventTiming

Clusterfuzz tells us that GetFrame() could be null when
WindowPerformance::RegisterEventTiming is called, so this CL removes
the DCHECK and bails out early instead.

Bug: 861627
Change-Id: Ic109e8153a80832324d9c3cf27e1bed957d2b1c2
Reviewed-on: https://chromium-review.googlesource.com/1131226
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573769}(cherry picked from commit 3641b5fb4b522a40423e8eaaebdd0150d316f44b)
Reviewed-on: https://chromium-review.googlesource.com/1136752
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#667}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/core/timing/window_performance.cc[diff]

Fix bogus event timestamps across all platforms.

First Input Delay was reporting bogus values in > 0.0006% of cases.
The data suggests that this is due to invalid event timestamps.

Bug: 861855
Change-Id: Ib3e6bb22348546f60dc6b98c6955e8620e87672b
Reviewed-on: https://chromium-review.googlesource.com/1129843
Commit-Queue: Timothy Dresser <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573878}(cherry picked from commit aacf8c02f2478af54fae69058cfecd846fd95138)
Reviewed-on: https://chromium-review.googlesource.com/1136615
Reviewed-by: Timothy Dresser <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#666}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ui/events/event_utils.cc[diff]

Media Controls: Keep more overlay play button events in node

This CL undoes some of crrev.com/c/1067514, which kept fewer events in
node for the overlay play button to fix a menu issue. Instead of
allowing all non-play/pause-causing events through, we are only going
to allow non-play/pause-causing "click" events through. This keeps the
original issue fixed while also fixing a new issue where outer divs
could preventDefault on certain touch events to prevent the overlay
play button from receiving a "click" event.

Bug: 858846
Change-Id: I1c10e188529edd1219cee42ded5865442becb8f8
Reviewed-on: https://chromium-review.googlesource.com/1130826
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573896}(cherry picked from commit 88dd2a898975364085c5566a30b82a62efd79984)
Reviewed-on: https://chromium-review.googlesource.com/1136751
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#665}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html[Added - diff]
• third_party/WebKit/LayoutTests/media/media-controls.js[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc[diff]

[signin] Clear mobile device ID on Sync signout

The device ID was no longer cleared on mobile.
However this is still needed, because it is sent to Sync.
This CL restores the right behavior.

TBR=droger
(cherry picked from commit 7a84e2bf1510ddf73cae1809793bad2e5e5a90cc)

Bug: 855957
Change-Id: Idac22c1ddc2dfa1b8bb68f69051d619b8c8dbe19
Reviewed-on: https://chromium-review.googlesource.com/1129222
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573670}
Reviewed-on: https://chromium-review.googlesource.com/1136304
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#664}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/signin/core/browser/signin_client.cc[diff]
• components/signin/core/browser/signin_client.h[diff]
• components/signin/core/browser/signin_manager.cc[diff]
• components/signin/core/browser/signin_manager.h[diff]

[signin] Add device_id parameter to Dice requests

Cherry-picking notes: fixed a broken include in
password_autofill_agent_browsertest.cc.

The device_id is wired-up to Dice, going through ProfileIOData to get
it on the IO thread.
When Sync is enabled, the device ID is cleared on Sync signout.
When Sync is disabled, the device ID is cleared on web signout.

A new device ID is also created immediately when the device ID is
cleared, because it cannot be created lazily on the IO thread.

TBR=droger
(cherry picked from commit 8a009d444d3d980d697e31c3cceb65c5250c27b2)

Bug: 855957
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4fc6487e16961747899638554c1e496d1dabde2c
Reviewed-on: https://chromium-review.googlesource.com/1115219
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572950}
Reviewed-on: https://chromium-review.googlesource.com/1136298
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#663}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/BUILD.gn[diff]
• chrome/browser/profiles/profile_io_data.cc[diff]
• chrome/browser/profiles/profile_io_data.h[diff]
• chrome/browser/signin/chrome_signin_helper.cc[diff]
• chrome/browser/signin/dice_browsertest.cc[diff]
• chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc[diff]
• chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h[diff]
• chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc[diff]
• chrome/renderer/autofill/password_autofill_agent_browsertest.cc[diff]
• chrome/test/BUILD.gn[diff]
• components/signin/core/browser/dice_header_helper.cc[diff]
• components/signin/core/browser/dice_header_helper.h[diff]
• components/signin/core/browser/signin_client.cc[diff]
• components/signin/core/browser/signin_client.h[diff]
• components/signin/core/browser/signin_header_helper.cc[diff]
• components/signin/core/browser/signin_header_helper.h[diff]
• components/signin/core/browser/signin_header_helper_unittest.cc[diff]
• components/signin/core/browser/test_signin_client.cc[diff]
• components/signin/core/browser/test_signin_client.h[diff]

Add metrics for the current prefilled usernames fix

crrev.com/c/1007723 introduced a fix to allow the password
manager to recognize some cases when username fields are prefilled with
values that are meant as placeholders and autofill credentials
for those cases.

This CL adds metrics to help assess the effect of that fix.

[email protected]

(cherry picked from commit 609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c)

Bug: 860161
Change-Id: I4475ed757fc41b4e162b00a7e3b6ab830c496932
Reviewed-on: https://chromium-review.googlesource.com/1122977
Commit-Queue: Ioana Pandele <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573667}
Reviewed-on: https://chromium-review.googlesource.com/1136043
Cr-Commit-Position: refs/branch-heads/3440@{#662}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/renderer/autofill/password_autofill_agent_browsertest.cc[diff]
• components/autofill/content/renderer/password_autofill_agent.cc[diff]
• components/autofill/content/renderer/password_autofill_agent.h[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

Incrementing VERSION to 68.0.3440.61

[email protected]

Change-Id: I3933c82da72204fcf0e7284ac1e1fb1dd03f7137
Reviewed-on: https://chromium-review.googlesource.com/1136014
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#661}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[Image Capture, Android] Fix for "UnknownError: platform error"

Fixes an issue where takePhoto would occasionally fail due to a Java object
being released too early.

In particular, an ImageReader instance is created and its Surface object is
held on to and used asynchronously while the ImageReader goes out of scope and
may get garbage collected. The fix is to hold on to the ImageReader instance
for as long as the Surface may be used.

Bug: 846576
Change-Id: Icb0e3b247a1a75af8ce86c44774960c2b036083b
Reviewed-on: https://chromium-review.googlesource.com/1117854
Reviewed-by: Emircan Uysaler <[email protected]>
Commit-Queue: Christian Fremerey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571574}(cherry picked from commit 356a67ed5facf20d6a52748444bb580fe73dc329)
Reviewed-on: https://chromium-review.googlesource.com/1135353
Reviewed-by: Christian Fremerey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#660}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java[diff]

[Image Capture, Android] Fix for "Check failed: false. |callback_id| not found"

Fixes a race condition that can lead to a crash when taking a photo via the
image capture web API on Android.

Bug: 846576
Change-Id: I0008391acfd4fd1f84db1d403d33c0dc31410294
Reviewed-on: https://chromium-review.googlesource.com/1117845
Reviewed-by: Emircan Uysaler <[email protected]>
Commit-Queue: Christian Fremerey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571538}(cherry picked from commit 5481b4c6fa6dcbddca13d3f67175f651c1e75b33)
Reviewed-on: https://chromium-review.googlesource.com/1135352
Reviewed-by: Christian Fremerey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#659}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• media/capture/video/android/video_capture_device_android.cc[diff]

Pass variation headers for Omnibox Searches.

Variation headers will only be added to URL requests to Google servers.

Variation headers will be passed for the following navigations:
- Text search from the Omnibox
- Back-forward navigation to search pages loaded from omnibox text search
- Reload of the search page

Headers will *not* be passed for the following navigations:
- QR code scanner search
- Voice Search
- Bookmarks
- Search by image
- NTP tiles and articles
- History navigations
- Learn More on Incognito
- Recent Tab navigation
- Reading List article load

[email protected]

(cherry picked from commit 1ce01901eba7a11541dc1a7eac0aa6fd70ac953d)

Bug: 831976
Change-Id: I0c0c1f46592003c21f0fc11eacfd16767a864477
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1069335
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#563386}
Reviewed-on: https://chromium-review.googlesource.com/1131690
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3440@{#632}
Cr-Original-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
Reviewed-on: https://chromium-review.googlesource.com/1135436
Reviewed-by: Kariah Davis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#658}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/chrome/browser/ui/location_bar/BUILD.gn[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm[diff]
• ios/chrome/test/fakes/fake_url_loader.h[diff]
• ios/chrome/test/fakes/fake_url_loader.mm[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Change-Id: I7876b1895971c086ad25fc4c77243f8464db76d7
Reviewed-on: https://chromium-review.googlesource.com/1135576
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#657}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/policy/resources/policy_templates_nl.xtb[diff]

Fix Android B&R and GLS check boxes for consumers

We changed the enterprise/edu default so that unless the corresponding
policies are explicitly set to "let the user decide," Android B&R and
GLS are disabled and the corresponding check boxes are grayed out.

Unfortunately, the policy handler code that implements this logic runs
for consumer users as well. Consumers have no policies set, so the new
default behavior kicks in, disabling and graying out the Android B&R
and GLS check boxes.

This CL fixes consumer behavior by only controlling B&R and GLS if the
ArcEnabled policy is set. Since this policy is unset for consumers, they
are shielded from the new behavior. Some enterprise users may also have
the policy unset, but ArcEnabled unset or false for enterprise users
means ARC++ is disabled, so B&R and GLS are N/A anyway.

[email protected]

(cherry picked from commit 0248c495fd24353a1e9feba0981fddd554a7ac08)

Bug: 849867
Test: ArcServicePolicyHandlerTest and manual verification
Change-Id: Id3b785e4cde02716d54391607a64fac58604ed88
Reviewed-on: https://chromium-review.googlesource.com/1120177
Commit-Queue: Bartosz Fabianowski <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571879}
Reviewed-on: https://chromium-review.googlesource.com/1134483
Reviewed-by: Josh Horwich <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#656}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc[diff]
• chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h[diff]
• chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc[diff]
• chrome/browser/policy/policy_browsertest.cc[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• components/policy/resources/policy_templates.json[diff]

Do not skip chrome sign-in form in the renderer process.

Chrome sign-in passwords shouldn't be saved, so Chrome sign-in form
sholdn't be skipped. On CL
https://chromium-review.googlesource.com/c/chromium/src/+/979932 it was
implemented skipping this form in the renderer process. As result
password hash can't be saved. This CL implements skipping such form
in the browser process. As positive side effects, it adds checking
whether to save a password in ShowManualFallbackForSaving, that
avoids to show manual fallback for sync credentials for any form.

Bug:852205

[email protected]

(cherry picked from commit 7a9340678c5ceb4c06abc270beea92aa0c999957)

Change-Id: I4d749aecdb57dab03b7928f551f41c015490da56
Reviewed-on: https://chromium-review.googlesource.com/1120342
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572585}
Reviewed-on: https://chromium-review.googlesource.com/1135309
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#655}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/renderer/autofill/password_autofill_agent_browsertest.cc[diff]
• components/autofill/content/common/autofill_types.mojom[diff]
• components/autofill/content/common/autofill_types_struct_traits.cc[diff]
• components/autofill/content/common/autofill_types_struct_traits.h[diff]
• components/autofill/content/renderer/password_autofill_agent.cc[diff]
• components/autofill/content/renderer/password_form_conversion_utils.cc[diff]
• components/autofill/core/common/password_form.cc[diff]
• components/autofill/core/common/password_form.h[diff]
• components/password_manager/core/browser/password_manager.cc[diff]
• components/password_manager/core/browser/password_manager_unittest.cc[diff]
• components/password_manager/sync/browser/sync_credentials_filter.cc[diff]
• components/password_manager/sync/browser/sync_credentials_filter_unittest.cc[diff]

Revert "Pass variation headers for Omnibox Searches."

This reverts commit f0f24f13f01c9ac3ed6ef4045537d3ac785ae77f.

Reason for revert: Breaks beta compilation

Original change's description:
> Pass variation headers for Omnibox Searches.
> 
> Variation headers will only be added to URL requests to Google servers.
> 
> Variation headers will be passed for the following navigations:
> - Text search from the Omnibox
> - Back-forward navigation to search pages loaded from omnibox text search
> - Reload of the search page
> 
> Headers will *not* be passed for the following navigations:
> - QR code scanner search
> - Voice Search
> - Bookmarks
> - Search by image
> - NTP tiles and articles
> - History navigations
> - Learn More on Incognito
> - Recent Tab navigation
> - Reading List article load
> 
> [email protected]
> 
> (cherry picked from commit 1ce01901eba7a11541dc1a7eac0aa6fd70ac953d)
> 
> Bug: 831976
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I28be85db0a38b64f933d0b57746b474aeecbf546
> Reviewed-on: https://chromium-review.googlesource.com/1069335
> Reviewed-by: Stepan Khapugin <[email protected]>
> Reviewed-by: Peter Lee <[email protected]>
> Commit-Queue: Eugene But <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#563386}
> Reviewed-on: https://chromium-review.googlesource.com/1131690
> Reviewed-by: Eugene But <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#632}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831976
Change-Id: Iddbd4d578cfae45706b214e5de2ff9f4ffe2efaa
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1134786
Reviewed-by: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#654}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/chrome/browser/ui/location_bar/BUILD.gn[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm[diff]
• ios/chrome/test/fakes/fake_url_loader.h[diff]
• ios/chrome/test/fakes/fake_url_loader.mm[diff]

Migrate Services Data Use to Traffic Annotations

Network traffic annotations provides an unique hash for each component that
creates the URLRequest. This CL records data use against the hashes, so that
no client change is needed when new services are added. New service names
could be independently added in enums.xml.

Different conditions upstream/downstream, app state in background/foreground
are added as suffixes to the histogram. Notably, network connection type
(cellular/non-cellular) is not added as suffix.

This CL also deprecates the histograms DataUse.AllServices.BackgroundKB
and DataUse.MessageSize.AllServices.* histograms.

[email protected]

(cherry picked from commit a0242d8885e006ee2daa4663802114af0002eab1)

Bug: 843715
Change-Id: Iecffb840afa1880bd383972c30e82925b519c18b
Reviewed-on: https://chromium-review.googlesource.com/1114061
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Eric Roman <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: rajendrant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571754}
Reviewed-on: https://chromium-review.googlesource.com/1134727
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#653}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/data_use_measurement/content/content_url_request_classifier.cc[diff]
• components/data_use_measurement/content/content_url_request_classifier.h[diff]
• components/data_use_measurement/core/data_use_measurement.cc[diff]
• components/data_use_measurement/core/data_use_measurement.h[diff]
• components/data_use_measurement/core/data_use_measurement_unittest.cc[diff]
• components/data_use_measurement/core/data_use_network_delegate_unittest.cc[diff]
• components/data_use_measurement/core/url_request_classifier.h[diff]
• net/traffic_annotation/network_traffic_annotation.h[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

Do not optimize base::debug::Alias().

Optimization is already disabled for MSVC, do the same thing for Clang
too.

BUG=861636
TEST=Run dump_syms against chrome (w/ symbol_level=3, use_thin_lto=true,
use_lld=true) and manually checked the output.

Change-Id: Ia275e2310ccb8e70a2392d95ca4acadf2f218b01
Reviewed-on: https://chromium-review.googlesource.com/1128693
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573365}(cherry picked from commit a31f26075580e73b05da1bb1d899b5edec38cea8)
Reviewed-on: https://chromium-review.googlesource.com/1134607
Reviewed-by: Ryo Hashimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#652}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• base/debug/alias.cc[diff]

Incrementing VERSION to 68.0.3440.60

[email protected]

Change-Id: I4edf9c19c79a908c28259c16b8f5101535565b81
Reviewed-on: https://chromium-review.googlesource.com/1134214
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#651}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Change-Id: Id75bbcc2e46e5f12ec5866df450942e099f04f39
Reviewed-on: https://chromium-review.googlesource.com/1134501
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#650}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/app/resources/generated_resources_da.xtb[diff]
• components/strings/components_strings_pt-BR.xtb[diff]
• ui/strings/translations/ui_strings_en-GB.xtb[diff]

Merge to M68: Android accessibility: skip the root element when it has no title

This change was originally landed in r432621 - the idea is that when a page
has no title, there's no reason we should allow the user to swipe to the
root element.

For some reason in r514252 this was inverted as part of making it possible
to jump to the last element on a page, but the new logic doesn't make
sense. Restore it to the previous behavior.

Bug: 661793, 660090, 801292
Change-Id: Iba81d0429a04845f093c5f07449c26fa8514bda4
Reviewed-on: https://chromium-review.googlesource.com/1097953
Reviewed-by: Alice Boxhall <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#566868}(cherry picked from commit a953ec895d88d23a76772b9ff5cce1a4a84348c8)
Reviewed-on: https://chromium-review.googlesource.com/1134101
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#649}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/accessibility/browser_accessibility_android.cc[diff]
• content/test/data/accessibility/html/isInteresting-expected-android.txt[diff]

This cl merges https://chromium-review.googlesource.com/1112776 to m68.

I manually cherry picked 4b32e5d123858b92e02524bff9a3ecc16ccd692e
and compiled locally after resolving the merge conflict in
GestureListenerManagerImpl.java

[email protected],[email protected],[email protected]

Change-Id: Icb74a6fac4577cf7e071d612c6a503479d845244
Reviewed-on: https://chromium-review.googlesource.com/1134192
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#648}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• android_webview/java/src/org/chromium/android_webview/AwContents.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTestUtils.java[diff]
• content/browser/android/content_ui_event_handler.cc[diff]
• content/browser/renderer_host/render_widget_host_view_android.cc[diff]
• content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java[diff]
• content/public/android/java/src/org/chromium/content/browser/GestureListenerManagerImpl.java[diff]
• content/public/android/java/src/org/chromium/content/browser/JoystickHandler.java[diff]
• content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java[diff]
• ui/android/event_forwarder.cc[diff]
• ui/android/event_forwarder.h[diff]
• ui/android/java/src/org/chromium/ui/base/EventForwarder.java[diff]
• ui/events/android/gesture_event_android.cc[diff]
• ui/events/android/gesture_event_android.h[diff]
• ui/events/blink/blink_event_util.cc[diff]

Download location: Fix ANR issue.

Currently download location feature may access disk on main thread to
retrieve download directories.

This CL moves this operation to a background thread.

Also, the Android API to retrieve directories may cause issue if
multiple asynchrounous tasks are fired on certain device. In this CL,
we introduced a glue layer between Android API and chrome to manage
unreliable API behavior.

[email protected]

(cherry picked from commit 6bd45c89d07e02baf433f24a53aba83efae05a74)

Bug: 844107
Change-Id: Ic9dcabea48895a705079029f9fa260ce6efbfec3
Reviewed-on: https://chromium-review.googlesource.com/1116247
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571371}
Reviewed-on: https://chromium-review.googlesource.com/1134082
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#647}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/download/DirectoryOption.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadDirectoryProvider.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadLocationDialog.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadDirectoryAdapter.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadLocationPreference.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadLocationPreferenceAdapter.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadPreferences.java[diff]
• chrome/android/java_sources.gni[diff]

[Merge M68] Android process binding fixes

* Add back boostForPendingView logic accidentally removed in r554797
* Send updates when frame depth changes, which was missing in r546622.
  Note this fix is limited to OS_ANDROID to maintain the desktop
  workaround for crbug.com/560446
* Also improve testCrossDomainNavigationDoNotLoseImportance to also
  log the calling stack on failure.

(cherry picked from commit 07fe724b57d94ce25bbb520410e5b596f856d826)

Bug: 861826
Change-Id: I0757647a81228a9bfc5fda02d775f62fb6bee723
Reviewed-on: https://chromium-review.googlesource.com/1128573
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573540}
Reviewed-on: https://chromium-review.googlesource.com/1133777
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#646}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/renderer_host/render_process_host_impl.cc[diff]
• content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java[diff]
• content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java[diff]

VR: fix rendering of permission popups in presentation mode

Bug: 856727
Change-Id: Ic1cdbe5a46f5c559713f29a217243a30347eeb89
Reviewed-on: https://chromium-review.googlesource.com/1127147
Commit-Queue: Aldo Culquicondor <[email protected]>
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572820}(cherry picked from commit 10380658b5506f3251d989186f18ab904e8bb9ec)
Reviewed-on: https://chromium-review.googlesource.com/1132325
Cr-Commit-Position: refs/branch-heads/3440@{#645}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java[diff]
• chrome/browser/android/vr/vr_shell.cc[diff]
• chrome/browser/android/vr/vr_shell.h[diff]
• chrome/browser/android/vr/vr_shell_gl.cc[diff]

Incrementing VERSION to 68.0.3440.59

[email protected]

Change-Id: I7260fcde941e2fd7fbcb4eddf7e7617203b7aa16
Reviewed-on: https://chromium-review.googlesource.com/1132403
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#644}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Don't throw away bits when computing Blink heap magic.

Bug: 860721
Change-Id: I8d32e43efa102d257360c2886aa1701298e3c91e
Reviewed-on: https://chromium-review.googlesource.com/1132082
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#643}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/platform/heap/heap_page.h[diff]

Incrementing VERSION to 68.0.3440.58

[email protected]

Change-Id: Ia0f8418372bc232b9ceef9932715794a103e077f
Reviewed-on: https://chromium-review.googlesource.com/1132397
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#642}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

arc: Make SET_REPORTING_CONSENT false for managed users

Keep usage & diagnostics false during ARC setup if the user does not
see the ARC ToS dialog due to all relevant settings being managed,
even if usage & diagnostics is enabled for the device.

Note that this is a squashed patch of the following three commits:
commit 25a10afd2e5303a00b5f19d2cdd1b5a735723e44
commit c59e0e374abf33db3b17cd269be347a200e7ed64
commit 7da098a199b64a48665d57352e390acc48bfc09d

Bug: b/73338614, 859104, 855448
Test: Opt in to ARC with managed and unmanaged users
Change-Id: I5fbe412d8cd7e3e0ca0ee77c325ba0903e677414
Signed-off-by: Josh Horwich <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/1121212
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#641}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/chromeos/arc/arc_session_manager.cc[diff]
• chrome/browser/chromeos/arc/arc_util.cc[diff]
• chrome/browser/chromeos/arc/arc_util.h[diff]
• chrome/browser/chromeos/arc/arc_util_unittest.cc[diff]
• chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc[diff]
• components/arc/arc_prefs.cc[diff]
• components/arc/arc_prefs.h[diff]

Record UKMs if a manual save fallback is offered to the user

This CL introduce a UKM metric that tells us if a manual fallback for password
saving was offered, which means that the user typed a not yet stored credential
into a password form. The purpose of this is to see whether we see such sites
where manual fallback is offered but form submissions are not observed.

[email protected]

(cherry picked from commit 061f70757acaab80075714aaa2f93c532e26c38c)

Bug: 732846
Change-Id: If2bce7b0e7219f84880110218b8ea6d1d955c165
Reviewed-on: https://chromium-review.googlesource.com/1126932
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572797}
Reviewed-on: https://chromium-review.googlesource.com/1131940
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#640}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/password_manager/core/browser/DEPS[diff]
• components/password_manager/core/browser/password_form_metrics_recorder.cc[diff]
• components/password_manager/core/browser/password_form_metrics_recorder.h[diff]
• components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc[diff]
• components/password_manager/core/browser/password_manager.cc[diff]
• components/password_manager/core/browser/password_manager_unittest.cc[diff]
• tools/metrics/ukm/ukm.xml[diff]

Fix DCHECK in WebFormElementObserverImpl

The WebFormElementObserverImpl made an incorrect but also totally unnecessary
cast of a Node to an HTMLElement. This edge case was discovered by the fuzzer
where a form was inside an <svg> element, whose style attribute was changed,
but which could not be casted to HTMLElement.

[email protected]

(cherry picked from commit 5ce8880baa741c8e31cfd47ede17490128590488)

Bug: 861571
Change-Id: I62c8238e25ef39e662dc154a1f2bd772667ec52f
Reviewed-on: https://chromium-review.googlesource.com/1128973
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573458}
Reviewed-on: https://chromium-review.googlesource.com/1131939
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#639}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/core/exported/web_form_element_observer_impl.cc[diff]

[M68] Disable cold mode spellchecker

Cold mode spellchecker was introduced in M68 as a bug fix to some
spellcheck completeness issues. For risk control, it is implemented
behind a flag.

Now that we found many related crashes in M68 and M69, it turns out
that cold mode spellchecker is not ready to be pushed to the stable
channel. Hence, this patch disables it by default on M68.

It will remain enabled by default in M69 for more observation.

Bug: 716642, 856376, 859056, 859443
Change-Id: I8984de679d0c7c0de61123f50dabc535b2b3c3fb
Reviewed-on: https://chromium-review.googlesource.com/1124021
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#638}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/platform/runtime_enabled_features.json5[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Change-Id: I83d783bf54312c713855925e35dcc7d1af9e931e
Reviewed-on: https://chromium-review.googlesource.com/1131930
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#637}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/strings/components_strings_ru.xtb[diff]

[Merge to 3440] Fix re-entrancy caused by RenderFrameHostImpl::DispatchBeforeUnload.

The method, on certain conditions, would simulate receiving a
OnBeforeUnloadACK() IPC. This would immediately call back into the unload
handler, which had just called RenderFrameHostImpl::DispatchBeforeUnload.

The problematic series of events is as follows:
  1) TabStripModel::CloseWebContentses tries to close many tabs.
  2) This calls RunUnloadListenerBeforeClosing() on each tab.
  3) UnloadListener will call RenderFrameHostImpl::DispatchBeforeUnload, which
     on certain conditions will synchronously call OnBeforeUnloadACK().
  4) This calls back into TabStripModel, mutating internal state.
  5) The implementation of TabStripModel::CloseWebContentses relies on the
     assumption that there is no re-entrancy. This manifests itself as a buffer
     overrun when (1) calls SendDetachWebContentsNotifications, which then
     passes inconsistent data to the observers.

Bug: 851400
Change-Id: I2080875f5d8d118c93addbe66503cb02b8b2966f
Reviewed-on: https://chromium-review.googlesource.com/1101846
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568534}(cherry picked from commit 907fe4acf7dc713ed05e1608663444b2278de1f6)
Reviewed-on: https://chromium-review.googlesource.com/1129400
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#636}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/frame_host/render_frame_host_impl.cc[diff]

Fix feature policy construction in proxies.

When a proxy for a newly-created frame is created in an existing
renderer, the Feature-Policy header and container policy need to be
applied after the origin is set. Previously, setting the proxy's origin
(as the last step in frame navigation) would reuse the feature policy
which was created during frame initialization without taking into
account either the HTTP header or the new origin's relationship to the
parent frame.

This CL ensures that the remote frame stores a copy of the initial
feature policy header, which it can use to reconstruct the correct
policy when the origin is set. The
FeaturePolicy::CreateFromPolicyWithOrigin method, which was used to
replicate an existing policy with an updated origin, is removed, as it
appears to never be the right behaviour.

[email protected]

(cherry picked from commit bd2a91ac57dcfe16ce53877c776843a6cf1f8216)

Bug: 852102
Change-Id: I3e5137737a5aac102f247aa52ede842f1210f53f
Reviewed-on: https://chromium-review.googlesource.com/1124931
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573149}
Reviewed-on: https://chromium-review.googlesource.com/1131926
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#635}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/site_per_process_browsertest.cc[diff]
• third_party/blink/common/feature_policy/feature_policy.cc[diff]
• third_party/blink/public/common/feature_policy/feature_policy.h[diff]
• third_party/blink/renderer/core/execution_context/security_context.cc[diff]
• third_party/blink/renderer/core/execution_context/security_context.h[diff]
• third_party/blink/renderer/core/exported/web_remote_frame_impl.cc[diff]
• third_party/blink/renderer/core/exported/web_remote_frame_impl.h[diff]

Merge of DevTools: restore pointer events in HTML preview

- Restores pointer events (including scrolling) to HTML preview.
- Prevents accidentally focusing inputs/links inside the preview
  iframe when tabbing via keyboard.

Bug: 849204
Change-Id: Iea5dc6117decbe1d9e746139dd5974a8bfb45c62
Reviewed-on: https://chromium-review.googlesource.com/1107250
Reviewed-by: Dmitry Gozman <[email protected]>
Commit-Queue: Erik Luo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569093}(cherry picked from commit 122037b2541bf0932fd6fbcb29a98d487525c4ec)
Reviewed-on: https://chromium-review.googlesource.com/1132014
Reviewed-by: Erik Luo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#634}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/devtools/front_end/network/RequestHTMLView.js[diff]
• third_party/blink/renderer/devtools/front_end/network/requestHTMLView.css[diff]

[Mac merge into M68] Merge 2 CLs into M68 and resolve conflict

[Mac] Collect detached code signatures when analyzing DMG files.

A detached signature is created by codesign(1) when the signed artifact
is not Mach-O, so the resulting signature cannot be placed in the
LC_CODE_SIGNATURE command. Instead, the signature is detached into the
_CodeSignature/CodeSignature file on-disk.

This also updates the testing codesign certificate used for the
safe_browsing/mach_o test data, since new test data needed to be generated.
The existing test data were not re-signed with it, however.

Bug: 826761
Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
Reviewed-on: https://chromium-review.googlesource.com/1101842
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569101}


[Mac] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()

This could occur if a detached code signature file is shorter than its
typical prologue.

Bug: 826761
Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
Reviewed-on: https://chromium-review.googlesource.com/1114925
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#570530}
(cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)

[email protected], [email protected], [email protected]

Bug: 826761
Change-Id: Ie33179f80ca0de57ed3383d2c3de0a0a3385efc6
Reviewed-on: https://chromium-review.googlesource.com/1131717
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#633}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/safe_browsing/download_protection/check_client_download_request.cc[diff]
• chrome/browser/safe_browsing/download_protection/check_client_download_request.h[diff]
• chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc[diff]
• chrome/common/safe_browsing/archive_analyzer_results.h[diff]
• chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc[diff]
• chrome/services/file_util/public/mojom/safe_archive_analyzer_param_traits.h[diff]
• chrome/test/BUILD.gn[diff]
• chrome/test/data/safe_browsing/dmg/generate_test_data.sh[diff]
• chrome/test/data/safe_browsing/mach_o/Makefile[diff]
• chrome/test/data/safe_browsing/mach_o/README[diff]
• chrome/test/data/safe_browsing/mach_o/codesign.crt[diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Info.plist[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/MacOS/test-bundle[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/PkgInfo[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Resources/Base.lproj/MainMenu.nib[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeDirectory[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements-1[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeResources[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeSignature[Added - diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.h[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer_unittest.cc[Added - diff]
• chrome/utility/safe_browsing/mac/dmg_iterator.h[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.h[diff]
• chrome/utility/safe_browsing/mac/hfs_unittest.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.h[diff]
• chrome/utility/safe_browsing/mac/read_stream_unittest.cc[diff]
• components/safe_browsing/proto/csd.proto[diff]
• tools/metrics/histograms/histograms.xml[diff]

Pass variation headers for Omnibox Searches.

Variation headers will only be added to URL requests to Google servers.

Variation headers will be passed for the following navigations:
- Text search from the Omnibox
- Back-forward navigation to search pages loaded from omnibox text search
- Reload of the search page

Headers will *not* be passed for the following navigations:
- QR code scanner search
- Voice Search
- Bookmarks
- Search by image
- NTP tiles and articles
- History navigations
- Learn More on Incognito
- Recent Tab navigation
- Reading List article load

[email protected]

(cherry picked from commit 1ce01901eba7a11541dc1a7eac0aa6fd70ac953d)

Bug: 831976
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28be85db0a38b64f933d0b57746b474aeecbf546
Reviewed-on: https://chromium-review.googlesource.com/1069335
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: Peter Lee <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#563386}
Reviewed-on: https://chromium-review.googlesource.com/1131690
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#632}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/chrome/browser/ui/location_bar/BUILD.gn[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm[diff]
• ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm[diff]
• ios/chrome/test/fakes/fake_url_loader.h[diff]
• ios/chrome/test/fakes/fake_url_loader.mm[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I860b7606174179866afb673c6d3d2bc101a9f33f
Reviewed-on: https://chromium-review.googlesource.com/1131534
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#631}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/components/strings/ash_components_strings_da.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_ca.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_hi.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_id.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_pt-BR.xtb[diff]
• chrome/app/resources/generated_resources_ta.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb[diff]
• components/policy/resources/policy_templates_es.xtb[diff]
• components/policy/resources/policy_templates_fr.xtb[diff]
• components/policy/resources/policy_templates_hi.xtb[diff]
• components/policy/resources/policy_templates_id.xtb[diff]
• components/policy/resources/policy_templates_pt-BR.xtb[diff]
• components/policy/resources/policy_templates_zh-CN.xtb[diff]
• components/policy/resources/policy_templates_zh-TW.xtb[diff]
• components/strings/components_strings_pt-BR.xtb[diff]
• components/strings/components_strings_te.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_mr.xtb[diff]
• remoting/resources/remoting_strings_pt-BR.xtb[diff]
• ui/accessibility/extensions/strings/accessibility_extensions_strings_pl.xtb[diff]
• ui/strings/translations/ui_strings_en-GB.xtb[diff]
• ui/strings/translations/ui_strings_mr.xtb[diff]

[signin] Re-use existing signin tabs

Previously, each sign-in request was processed in a new tab.
This was a problem because a mis-behaving extension could make many
signin request, and trigger the creation of many new tabs.

This CL mitigates the bug by reusing an existing signin tab if available.
Note that this does not completely address the problem, because the
signin tab is given the focus, and thus a misbehaving extension is still
able to constantly bring a signin tab into focus, as well as constantly
reopening the signin tab when it is closed.

[email protected]

(cherry picked from commit cd0d663fee8a8506e94f2849b8b82d096601dcf3)

Bug: 856513
Change-Id: I077054857c311a319408d63dfc2bdf56567c4f11
Reviewed-on: https://chromium-review.googlesource.com/1124691
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572802}
Reviewed-on: https://chromium-review.googlesource.com/1131118
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#630}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/signin/dice_tab_helper.cc[diff]
• chrome/browser/signin/dice_tab_helper.h[diff]
• chrome/browser/signin/dice_tab_helper_unittest.cc[diff]
• chrome/browser/signin/signin_ui_util_unittest.cc[diff]
• chrome/browser/ui/signin_view_controller.cc[diff]

Merge "custom-element: Do not crash by Get(NewTarget, "prototype") failure." to M68 branch

https://html.spec.whatwg.org/multipage/dom.html#html-element-constructors
> 7. Let prototype be Get(NewTarget, "prototype"). Rethrow any exceptions.

As the specification says, we should rethrow. Removing a v8::TryCatch
instance in V8HTMLConstructor::HtmlConstructor() works as "rethrow".

Bug: 854887
Change-Id: I6b2d6ae829453270fe4437a87e65528525c64990
Reviewed-on: https://chromium-review.googlesource.com/1124129
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hitoshi Yoshida <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572167}(cherry picked from commit 8381e35ca626c9853c6207de30828b7c3039430c)
Reviewed-on: https://chromium-review.googlesource.com/1130576
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#629}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/custom-elements/cereactions-with-exception-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/custom-elements/cereactions-with-exception.html[Added - diff]
• third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc[diff]

Revert Ozone initialization changes.

This reverts most of commit a51e3935c81c5572eb1439a1f8d83c9184f3f128.
The thread configuration for --enable-features=Mus doesn't exist anymore
and fixing mus introduced a different race for the non-mus configuration.
Since mus is no longer the plan of record, revert the initialization
order changes but keep logging and code cleanup.

Bug: 840474
Change-Id: Ifec0e3dd9601e3895d0549109be5d10387f3b8b4
Reviewed-on: https://chromium-review.googlesource.com/1101139
Reviewed-by: Robert Kroeger <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567794}(cherry picked from commit b33fd39c100223d0d8aecdec3308228b41642514)
Reviewed-on: https://chromium-review.googlesource.com/1130854
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#628}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc[diff]
• ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h[diff]
• ui/ozone/platform/drm/host/gpu_thread_observer.h[diff]
• ui/ozone/public/ozone_platform.cc[diff]

Incrementing VERSION to 68.0.3440.57

[email protected]

Change-Id: I2444369579f8efae0d7e2bc027de6e2b8a1ae46a
Reviewed-on: https://chromium-review.googlesource.com/1130696
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#627}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Reland: "Download: Fix an issue that download percentage can move backwards."

On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.

Instead, we should keep the slice info when resume with an error.

[email protected], [email protected], [email protected]

(cherry picked from commit 1dba58736239a49120531e98631010925aaafffa)

Bug: 837128
Change-Id: I59ddb7ff57551beb862884febe2de3f3ee9e1359
Reviewed-on: https://chromium-review.googlesource.com/1130349
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#573547}
Reviewed-on: https://chromium-review.googlesource.com/1130816
Cr-Commit-Position: refs/branch-heads/3440@{#626}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/download/internal/common/download_item_impl.cc[diff]

[M68] Replace MtpManager's ReadDirectory() with ReadDirectoryEntryIds().

[email protected]
BUG=858899

Replace MtpManager's ReadDirectory() with ReadDirectoryEntryIds().

MediaTransferProtocolDaemonClient currently provides a low-level
ReadDirectoryEntryIds() method, and MtpManager does the translation to
the high-level ReadDirectory() method that MTPDeviceTaskHelper
understands.

Change MtpManager's ReadDirectory() method to ReadDirectoryEntryIds(),
so it acts more like a pass-through. Make MTPDeviceTaskHelper handle the
translation.

BUG=769630

Change-Id: I5154bd4beac0b6ab15579f166cdf8b8add6a7dac
Reviewed-on: https://chromium-review.googlesource.com/1080214
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#565441}(cherry picked from commit 44663e8f02729bf01d296ce86087f87168420713)
Reviewed-on: https://chromium-review.googlesource.com/1130735
Reviewed-by: Anand Mistry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#625}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/media_galleries/chromeos/mtp_device_task_helper.cc[diff]
• chrome/browser/media_galleries/chromeos/mtp_device_task_helper.h[diff]
• components/storage_monitor/test_media_transfer_protocol_manager_chromeos.cc[diff]
• components/storage_monitor/test_media_transfer_protocol_manager_chromeos.h[diff]
• services/device/media_transfer_protocol/media_transfer_protocol_manager.cc[diff]
• services/device/media_transfer_protocol/media_transfer_protocol_manager.h[diff]
• services/device/media_transfer_protocol/mtp_device_manager.cc[diff]
• services/device/media_transfer_protocol/mtp_device_manager.h[diff]
• services/device/public/mojom/mtp_manager.mojom[diff]

[M68] Align GetFileInfo() between MtpManager and MtpDaemonClient.

[email protected]
BUG=858899

Align GetFileInfo() between MtpManager and MtpDaemonClient.

MediaTransferProtocolDaemonClient currently provides a low-level
GetFileInfo() method, and MtpManager does the translation to the
high-level GetFileInfo() method that MTPDeviceTaskHelper understands.

Change MtpManager's GetFileInfo() from the high-level method to the
low-level method, so it acts more like a pass-through. Make
MTPDeviceTaskHelper handle the translation.

BUG=769630

Change-Id: I21e20b71d333a1ee7173071f04aaf2e37dd61844
Reviewed-on: https://chromium-review.googlesource.com/1080212
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#565413}(cherry picked from commit 3d7f15c742e7aff293b9b2065837bf98cb3a042b)
Reviewed-on: https://chromium-review.googlesource.com/1130715
Reviewed-by: Anand Mistry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#624}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/media_galleries/chromeos/mtp_device_task_helper.cc[diff]
• chrome/browser/media_galleries/chromeos/mtp_device_task_helper.h[diff]
• components/storage_monitor/test_media_transfer_protocol_manager_chromeos.cc[diff]
• components/storage_monitor/test_media_transfer_protocol_manager_chromeos.h[diff]
• services/device/media_transfer_protocol/media_transfer_protocol_manager.cc[diff]
• services/device/media_transfer_protocol/media_transfer_protocol_manager.h[diff]
• services/device/media_transfer_protocol/mtp_device_manager.cc[diff]
• services/device/media_transfer_protocol/mtp_device_manager.h[diff]
• services/device/public/mojom/mtp_manager.mojom[diff]

Weaken a precondition for client_ in DocumentThreadableLoader destructor

Having a non-null client_ in DocumentThreadableLoader destructor
generally means UaF, so we have a CHECK there.

In the detached case, the loader is held by self-referencing
DetachedClient, but SelfKeepAlive in DetachedClient is forcibly
cancelled on worker thread termination. This is a safe pattern, so we
should ignore this case.

[email protected]

(cherry picked from commit 8ec0126d926388c03016100db87d1dd3454fdf34)

Bug: 837511
Change-Id: I451ccddc0f72c2b0d0ec05c707b983e18547feae
Reviewed-on: https://chromium-review.googlesource.com/1127509
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572959}
Reviewed-on: https://chromium-review.googlesource.com/1130555
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#623}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/core/loader/document_threadable_loader.cc[diff]
• third_party/blink/renderer/core/loader/document_threadable_loader.h[diff]

Revert "[Mac merge M68] Collect detached code signatures when analyzing DMG files."

This reverts commit 5cfa9fabbdba23376ff7d8776d3f0b735c80e728.

Reason for revert: breaking continuous build due to merge conflicts

Original change's description:
> [Mac merge M68] Collect detached code signatures when analyzing DMG files.
> 
> A detached signature is created by codesign(1) when the signed artifact
> is not Mach-O, so the resulting signature cannot be placed in the
> LC_CODE_SIGNATURE command. Instead, the signature is detached into the
> _CodeSignature/CodeSignature file on-disk.
> 
> This also updates the testing codesign certificate used for the
> safe_browsing/mach_o test data, since new test data needed to be generated.
> The existing test data were not re-signed with it, however.
> 
> [email protected]
> 
> (cherry picked from commit 0b82d4cd3484d173e7f1ec20a0de062663a20d06)
> 
> Bug: 826761
> Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
> Reviewed-on: https://chromium-review.googlesource.com/1101842
> Reviewed-by: Ken Rockot <[email protected]>
> Reviewed-by: Gayane Petrosyan <[email protected]>
> Reviewed-by: Varun Khaneja <[email protected]>
> Reviewed-by: Jialiu Lin <[email protected]>
> Commit-Queue: Robert Sesek <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#569101}
> Reviewed-on: https://chromium-review.googlesource.com/1129551
> Cr-Commit-Position: refs/branch-heads/3440@{#617}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

[email protected],[email protected],[email protected],[email protected],[email protected]

Change-Id: Ibc7eee944f549df3d8138796a507d9074e5a4401
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826761
Reviewed-on: https://chromium-review.googlesource.com/1130139
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#622}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/safe_browsing/download_protection/check_client_download_request.cc[diff]
• chrome/browser/safe_browsing/download_protection/check_client_download_request.h[diff]
• chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc[diff]
• chrome/common/safe_browsing/archive_analyzer_results.h[diff]
• chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc[diff]
• chrome/services/file_util/public/mojom/safe_archive_analyzer_param_traits.h[diff]
• chrome/test/data/safe_browsing/dmg/generate_test_data.sh[diff]
• chrome/test/data/safe_browsing/mach_o/Makefile[diff]
• chrome/test/data/safe_browsing/mach_o/README[diff]
• chrome/test/data/safe_browsing/mach_o/codesign.crt[diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Info.plist[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/MacOS/test-bundle[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/PkgInfo[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Resources/Base.lproj/MainMenu.nib[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeDirectory[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements-1[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeResources[Deleted - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeSignature[Deleted - diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.h[diff]
• chrome/utility/safe_browsing/mac/hfs_unittest.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.h[diff]
• chrome/utility/safe_browsing/mac/read_stream_unittest.cc[diff]
• components/safe_browsing/proto/csd.proto[diff]
• tools/metrics/histograms/histograms.xml[diff]

Revert "[Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()"

This reverts commit aa78d07711cb1d94bf0bf9c098662babc0a10a86.

Reason for revert: breaking build because of merge conflict

Original change's description:
> [Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()
> 
> This could occur if a detached code signature file is shorter than its
> typical prologue.
> 
> [email protected]
> 
> (cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)
> 
> Bug: 826761
> Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
> Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
> Reviewed-on: https://chromium-review.googlesource.com/1114925
> Commit-Queue: Robert Sesek <[email protected]>
> Reviewed-by: Jialiu Lin <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#570530}
> Reviewed-on: https://chromium-review.googlesource.com/1129552
> Cr-Commit-Position: refs/branch-heads/3440@{#618}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

[email protected],[email protected]

Change-Id: Ib92f5384942ca257ab98c6f3cfb010cc2afe6860
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 826761
Reviewed-on: https://chromium-review.googlesource.com/1130119
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#621}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/test/BUILD.gn[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.h[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer_unittest.cc[Deleted - diff]
• chrome/utility/safe_browsing/mac/dmg_iterator.h[diff]

Revert "Download: Fix an issue that download percentage can move backwards."



This reverts commit 1917d9a9ab35eadaa2ddb37932224159567cd110.

Reason for revert: Some testing function is modified, so I need to revert this CL,
and then revert the one on trunk, then checking in a new one without the test.

Original change's description:
> Download: Fix an issue that download percentage can move backwards.
>
> On certain Android devices, when disconnecting from WIFI, the network
> code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
> auto download resumption. And we erase the data downloaded by parallel
> requests, so the download percentage will go backwards.
>
> Instead, we should keep the slice info when resume with an error.
>
> [email protected]
>
> (cherry picked from commit 30c71bacdda42e40654870f46d6e3278bcac113b)
>
> Bug: 837128
> Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
> Reviewed-on: https://chromium-review.googlesource.com/1112754
> Reviewed-by: David Trainor <[email protected]>
> Reviewed-by: Min Qin <[email protected]>
> Commit-Queue: Xing Liu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#571286}
> Reviewed-on: https://chromium-review.googlesource.com/1129206
> Reviewed-by: Xing Liu <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#615}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

[email protected],[email protected],[email protected]

Change-Id: Ibafda7c82f4eaed9b6f38b3a28fa93e0404c7f6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837128
Reviewed-on: https://chromium-review.googlesource.com/1129939
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#620}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/download/internal/common/download_item_impl.cc[diff]
• components/download/internal/common/download_item_impl_unittest.cc[diff]

Reland "[vr] Tune scroll event stream"

This is a reland of 0e9a15da019624f9e5d6a3aba35b0102175da5c0

In this reland, I've combined the change with https://crrev.com/c/1124405
since the smoothing in the original CL was actually just a scaling.

Original change's description:
> [vr] Tune scroll event stream
>
> This change applies three heuristics to make trackpad scrolling feel
> smoother. We increase the frequency at which we submit scroll events to
> the platform, we also decrease the scroll scale factor (to make the
> scrolls less jumpy), and we do some simple filtering of our scroll
> values.
>
> I pair-programmed much of this change with asimjour@ and he wrote the
> initial code to interpolate events in the android ui gesture target.
>
> Bug: 859075
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
> Reviewed-on: https://chromium-review.googlesource.com/1120425
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Ian Vollick <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#571535}

(cherry picked from commit 98c28a6f258f58f00ef7caec2c8048b886d40df4)

Bug: 859075
Change-Id: Ib1a9f801c6930b709624233d8e00aeabc59f576d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1124908
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Amirhossein Simjour <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572364}
Reviewed-on: https://chromium-review.googlesource.com/1129626
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#619}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java[diff]
• chrome/browser/android/vr/android_ui_gesture_target.cc[diff]
• chrome/browser/android/vr/android_ui_gesture_target.h[diff]
• chrome/browser/android/vr/vr_controller.cc[diff]

[Mac merge M68] Fix crash in safe_browsing::dmg::AnalayzeDMGFile()

This could occur if a detached code signature file is shorter than its
typical prologue.

[email protected]

(cherry picked from commit b899c92d17aeeb7d002d555558eb8fffd0177ce5)

Bug: 826761
Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature
Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52
Reviewed-on: https://chromium-review.googlesource.com/1114925
Commit-Queue: Robert Sesek <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570530}
Reviewed-on: https://chromium-review.googlesource.com/1129552
Cr-Commit-Position: refs/branch-heads/3440@{#618}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/test/BUILD.gn[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.h[diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer_unittest.cc[Added - diff]
• chrome/utility/safe_browsing/mac/dmg_iterator.h[diff]

[Mac merge M68] Collect detached code signatures when analyzing DMG files.

A detached signature is created by codesign(1) when the signed artifact
is not Mach-O, so the resulting signature cannot be placed in the
LC_CODE_SIGNATURE command. Instead, the signature is detached into the
_CodeSignature/CodeSignature file on-disk.

This also updates the testing codesign certificate used for the
safe_browsing/mach_o test data, since new test data needed to be generated.
The existing test data were not re-signed with it, however.

[email protected]

(cherry picked from commit 0b82d4cd3484d173e7f1ec20a0de062663a20d06)

Bug: 826761
Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94
Reviewed-on: https://chromium-review.googlesource.com/1101842
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Jialiu Lin <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569101}
Reviewed-on: https://chromium-review.googlesource.com/1129551
Cr-Commit-Position: refs/branch-heads/3440@{#617}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/safe_browsing/download_protection/check_client_download_request.cc[diff]
• chrome/browser/safe_browsing/download_protection/check_client_download_request.h[diff]
• chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc[diff]
• chrome/common/safe_browsing/archive_analyzer_results.h[diff]
• chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc[diff]
• chrome/services/file_util/public/mojom/safe_archive_analyzer_param_traits.h[diff]
• chrome/test/data/safe_browsing/dmg/generate_test_data.sh[diff]
• chrome/test/data/safe_browsing/mach_o/Makefile[diff]
• chrome/test/data/safe_browsing/mach_o/README[diff]
• chrome/test/data/safe_browsing/mach_o/codesign.crt[diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Info.plist[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/MacOS/test-bundle[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/PkgInfo[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/Resources/Base.lproj/MainMenu.nib[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeDirectory[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeRequirements-1[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeResources[Added - diff]
• chrome/test/data/safe_browsing/mach_o/shell-script.app/Contents/_CodeSignature/CodeSignature[Added - diff]
• chrome/utility/safe_browsing/mac/dmg_analyzer.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.cc[diff]
• chrome/utility/safe_browsing/mac/dmg_test_utils.h[diff]
• chrome/utility/safe_browsing/mac/hfs_unittest.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.cc[diff]
• chrome/utility/safe_browsing/mac/read_stream.h[diff]
• chrome/utility/safe_browsing/mac/read_stream_unittest.cc[diff]
• components/safe_browsing/proto/csd.proto[diff]
• tools/metrics/histograms/histograms.xml[diff]

WebView: Fix CloseGuard error in VariationsSeedLoader

The WebView requesting a variations seed opens a file descriptor to
receive the seed. We should close it after the request.

BUG=857223

Change-Id: I594067ce0c33bed2137bc39e5c133ba22bca0c04
Reviewed-on: https://chromium-review.googlesource.com/1117707
Commit-Queue: Paul Miller <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571354}(cherry picked from commit 9aeb746195fa8bf7131c270af2c41c9b605bb894)
Reviewed-on: https://chromium-review.googlesource.com/1129479
Reviewed-by: Paul Miller <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#616}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java[diff]

Download: Fix an issue that download percentage can move backwards.

On certain Android devices, when disconnecting from WIFI, the network
code will report NETWORK_TIMEOUT before NETWORK_DISCONNECT and trigger
auto download resumption. And we erase the data downloaded by parallel
requests, so the download percentage will go backwards.

Instead, we should keep the slice info when resume with an error.

[email protected]

(cherry picked from commit 30c71bacdda42e40654870f46d6e3278bcac113b)

Bug: 837128
Change-Id: I002c69ac4d5e1c33133e4dbddd44c3c5173a494e
Reviewed-on: https://chromium-review.googlesource.com/1112754
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571286}
Reviewed-on: https://chromium-review.googlesource.com/1129206
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#615}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/download/internal/common/download_item_impl.cc[diff]
• components/download/internal/common/download_item_impl_unittest.cc[diff]

[NTP Button] Moves native calls to post native initialization

> The variations check was previously happening before native
   was initialized
> Moves the check to after the native library is ready

(cherry picked from commit 7b01abd45df53a2fd46ca5fe8811898b5f5d0d75)

Bug: 847129
Change-Id: Ied97f2b9038c9cff5851f20e76339a61151a9677
Reviewed-on: https://chromium-review.googlesource.com/1076377
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Daniel Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562633}
Reviewed-on: https://chromium-review.googlesource.com/1128451
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#614}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java[diff]

Cancel system touches when context menu is displayed

The system touches need to be cancelled whenever the context menu is
shown in order to prevent webview interaction after the context menu is
displayed.

Wait until the context menu element is available before determining if
the element supports a displyed context menu.

Bug: 853298
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I15bd7d4148f83646763504dd8370dce49e37dff3
Reviewed-on: https://chromium-review.googlesource.com/1104989
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568512}(cherry picked from commit 0e46d0b168129d2e7c5ab6ca21fb88524e498f21)
Reviewed-on: https://chromium-review.googlesource.com/1129280
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#613}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/web/web_state/ui/crw_context_menu_controller.mm[diff]

[iOS] Add additional Context Menu metrics.

The ContextMenu.DelayedElementDetails metric ensures that all awaiting
requests are eventually processed by either the user cancelling or by
the DOM element details being returned.

The ContextMenu.CancelSystemTouches metric logs that the system touches
were cancelled. This value should match the number of Context Menus
shown, otherwise a user could continue to interact with the page after
the Context Menu has been displayed.

Bug: 817517, 856234
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4dc5d9d14eba12c06ca034b80c037bd673230878
Reviewed-on: https://chromium-review.googlesource.com/1102994
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568450}(cherry picked from commit 9781ec3860643f79d510ead331b0d74c21c10a13)
Reviewed-on: https://chromium-review.googlesource.com/1129279
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#612}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ios/chrome/browser/context_menu/context_menu_egtest.mm[diff]
• ios/web/web_state/ui/crw_context_menu_controller.mm[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

[Typed URLs] Avoid sending history backend notifications after a DB error

Before this CL, there was a race condition in addressing DB errors in
HistoryBackend. When HistoryBackend::DatabaseErrorCallback got called,
it immediately notified TypedURLSyncBridge and posted a task to kill the
database. Before the database gets really killed, some other tasks can
run such as tasks from the expirer that result in the bridge being
notified about history deletions. The bridge does not expect backend
notifications after being notified about DB error (which makes sense).

This CL resolves this bug and delays the notification to the bridge so
that it happens synchronously with killing the DB.

The conflict in the unit-test was a trivial one (the context where the
new test is appended has changed).

[email protected]

(cherry picked from commit 40f00aa570a7a330acd74192ebacc840e9ca9d58)

Bug: 853395
Change-Id: I03d1a5c49254184e430c1619049e66895bf6dcfe
Reviewed-on: https://chromium-review.googlesource.com/1105821
Commit-Queue: Jan Krcal <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568554}
Reviewed-on: https://chromium-review.googlesource.com/1128096
Reviewed-by: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#611}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/history/core/browser/history_backend.cc[diff]
• components/history/core/browser/history_backend_unittest.cc[diff]

Incrementing VERSION to 68.0.3440.56

[email protected]

Change-Id: I53622fbee5857a0ab2a82a30fbd2aa39cec0153d
Reviewed-on: https://chromium-review.googlesource.com/1128602
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#610}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Incrementing VERSION to 68.0.3440.55

[email protected]

Change-Id: I3fbde36520a223a40f0ae5403ecb425dcec1ce78
Reviewed-on: https://chromium-review.googlesource.com/1128414
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#609}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[M68] [ServiceWorker] Stop observing EmbeddedWorkerInstance once it's gone away

This CL is a combination of the 2 previous commits on trunk, both of
them aim to avoid use-after-free behavior on the raw pointer of an
EmbeddedWorkerInstance.
After the 1st CL landed on trunk, it turns out that it did not fix the
problem completely and caused regressions like issue 856969, then we
have the 2nd CL give a complete solution.

The 1st one:
"
[ServiceWorker] Avoid using stale pointer of EmbeddedWorkerInstance

We're saving the raw pointer of an EmbeddedWorkerInstance in a
base::ScopedObserver member of ServiceWorkerRegisterJob, but, the
EmbeddedWorkerInstance is not guaranteed to outlive the
ServiceWorkerRegisterJob, it may get destroyed and lead to a situation
that ServiceWorkerRegisterJob holds a stale pointer, which could lead
to crash.

This CL lets ServiceWorkerRegisterJob listen OnDetached() from the
EmbeddedWorkerInstance so it can be aware that the EmbeddedWorkerInstanc
pointer is going to be stale and should be removed from the source list
of base::ScopedObserver.

This fix should be safe enough now, but in longer term we'll try to
remove EmbeddedWorkerInstance::Listener interface and let
EmbeddedWorkerInstance talk directly to its owner ServiceWorkerVersion,
then let ServiceWorkerRegisterJob observe the ServiceWorkerVersion it's
manipulating to get OnScriptLoaded() notification.

BUG=854063,855394

Change-Id: I9c5a46beda1aafff32a86b9055be2b53d50fda97
Reviewed-on: https://chromium-review.googlesource.com/1112904
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#569906}
(cherry picked from commit 26f26cd82a8159dff52fdef10b0a7ebb84c48040)
"

The 2nd one:
"
[ServiceWorker] Stop observing EmbeddedWorkerInstance once it's gone away

This CL adds a function OnDestroyed() into
EmbeddedWorkerInstance::Listener interface, so that
ServiceWorkerRegisterJob can stop observing EmbeddedWorkerInstance once
it's gone away.

BUG=856969,856330

Change-Id: I3acc9143f9ea2f8f24ab0aac465f29f97fdf9906
Reviewed-on: https://chromium-review.googlesource.com/1118006
Commit-Queue: Han Leon <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#571417}
(cherry picked from commit 1c81791b45c09b52614f85a7016425b71da32c4d)
"

BUG=854063,856969

Change-Id: I91c68d8edba41f6f7725903288fd12ec7574c538
Reviewed-on: https://chromium-review.googlesource.com/1128469
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#608}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/service_worker/embedded_worker_instance.cc[diff]
• content/browser/service_worker/embedded_worker_instance.h[diff]
• content/browser/service_worker/service_worker_register_job.cc[diff]
• content/browser/service_worker/service_worker_register_job.h[diff]

Incrementing VERSION to 68.0.3440.54

[email protected]

Change-Id: I1886764b963cd6befdbd959b7eec4fa4ab2d939a
Reviewed-on: https://chromium-review.googlesource.com/1128405
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#607}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Stop streams associated to removed devices in MediaDevicesManager.

This fixes a bug where removing a device did not result in stopping all
its associated streams.

A unit test for this requires a minor refactoring to remove the
MediaStreamManager dependency from MediaDevicesManager, and will be
provided in a follow-up CL. This CL is deliberately simple in order to
make merging easier.

Bug: 856658
Change-Id: I84ef2856195cc7650bb08992d2095f8f853e9ea9
Reviewed-on: https://chromium-review.googlesource.com/1124323
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572176}(cherry picked from commit 0fe699a8dfc9c3a6cc0203759561284d634f4a57)
Reviewed-on: https://chromium-review.googlesource.com/1125959
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#606}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/renderer_host/media/media_devices_manager.cc[diff]
• content/browser/renderer_host/media/media_devices_manager.h[diff]

Do not delete the media ContextProvider inside the lost context callback

Currently the GpuVideoAcceleratorFactoriesImpl will check for context
loss every time it tries to use the GL context, and destroy it
immediately if it sees a loss. This is problematic if the
ContextProvider is still on the callstack, which it is if we're inside
the context loss callback. Instead, leave the ContextProvider alive
until the GpuVideoAcceleratorFactoriesImpl stops being used.

[email protected], [email protected]

(cherry picked from commit 3071401e1b0257d029a6560a9fa8c3c1f695f839)

Bug: 849131
Change-Id: I8ec66671b4bbf5d426cb5fb184653a5863de9fd9
Reviewed-on: https://chromium-review.googlesource.com/1104777
Commit-Queue: danakj <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568256}
Reviewed-on: https://chromium-review.googlesource.com/1128214
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#605}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc[diff]
• content/renderer/media/gpu/gpu_video_accelerator_factories_impl.h[diff]
• content/renderer/render_thread_impl.cc[diff]

Merge to M68: Bubble logical scrolling from OOPIFs.

[email protected],[email protected],[email protected]

Bubble logical scrolling from OOPIFs.

Currently, ScrollManager::BubblingScroll only bubbles logical scrolls
from an iframe when the parent is a local frame. Now, when bubbling
reaches a local root, we send an IPC to the parent's process to
continue bubbling from the frame owner element.

(cherry picked from commit e21d23b8427576ae3877a2d1616fec42dc861ed1)

Bug: 852932
Change-Id: I312aed8eea353957b7d77cea3caad60a2c3493d6
Reviewed-on: https://chromium-review.googlesource.com/1106279
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571484}
Reviewed-on: https://chromium-review.googlesource.com/1128211
Reviewed-by: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#604}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/DEPS[diff]
• content/browser/frame_host/render_frame_host_impl.cc[diff]
• content/browser/frame_host/render_frame_host_impl.h[diff]
• content/browser/frame_host/render_frame_proxy_host.cc[diff]
• content/browser/frame_host/render_frame_proxy_host.h[diff]
• content/browser/site_per_process_browsertest.cc[diff]
• content/common/DEPS[diff]
• content/common/frame_messages.h[diff]
• content/renderer/render_frame_impl.cc[diff]
• content/renderer/render_frame_impl.h[diff]
• content/renderer/render_frame_proxy.cc[diff]
• content/renderer/render_frame_proxy.h[diff]
• content/test/data/frame_tree/page_with_iframe_in_scrollable_div.html[Added - diff]
• third_party/blink/public/BUILD.gn[diff]
• third_party/blink/public/platform/web_scroll_types.h[Added - diff]
• third_party/blink/public/web/web_frame_client.h[diff]
• third_party/blink/public/web/web_remote_frame.h[diff]
• third_party/blink/renderer/core/exported/local_frame_client_impl.cc[diff]
• third_party/blink/renderer/core/exported/local_frame_client_impl.h[diff]
• third_party/blink/renderer/core/exported/web_remote_frame_impl.cc[diff]
• third_party/blink/renderer/core/exported/web_remote_frame_impl.h[diff]
• third_party/blink/renderer/core/frame/frame.h[diff]
• third_party/blink/renderer/core/frame/local_frame.cc[diff]
• third_party/blink/renderer/core/frame/local_frame.h[diff]
• third_party/blink/renderer/core/frame/local_frame_client.h[diff]
• third_party/blink/renderer/core/frame/remote_frame.cc[diff]
• third_party/blink/renderer/core/frame/remote_frame.h[diff]
• third_party/blink/renderer/core/input/scroll_manager.cc[diff]
• third_party/blink/renderer/core/loader/empty_clients.h[diff]
• third_party/blink/renderer/platform/scroll/scroll_types.h[diff]

Merge "Fix LoginUIserviceLoginPopupTest.ShowLoginPop test on Beta."

The old sign-in page requres component extensions. The unittest needs
to create the ExtensionService before loading the page.

Bug: 859438
Change-Id: I22296316346ee0f7e780babd6125cf388e920d03
Reviewed-on: https://chromium-review.googlesource.com/1125210
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572597}(cherry picked from commit 215bd7442d675352b423caf39ff6087b62fe8459)
Reviewed-on: https://chromium-review.googlesource.com/1127936
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#603}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/ui/webui/signin/login_ui_service_unittest.cc[diff]

Catch java.lang.IllegalArgumentException in parsing baae64

BUG=829628
[email protected]

(cherry picked from commit 7880981a0cc24217dc87675bb12b216d02f4141d)

Change-Id: I054c8a40cf065d0c2f42bd8de9e5de6fed3fb9e9
Reviewed-on: https://chromium-review.googlesource.com/1059155
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#561876}
Reviewed-on: https://chromium-review.googlesource.com/1127881
Reviewed-by: Tatiana Gornak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#602}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/sync/android/java/src/org/chromium/components/sync/notifier/InvalidationPreferences.java[diff]

Incrementing VERSION to 68.0.3440.53

[email protected]

Change-Id: Ic05fbd55bf3e0934c7f2c7b0474c896a4856d17b
Reviewed-on: https://chromium-review.googlesource.com/1127270
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#601}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Incrementing VERSION to 68.0.3440.52

[email protected]

Change-Id: I329dd454c01eb13d3d748854badf7464723a1c0f
Reviewed-on: https://chromium-review.googlesource.com/1126601
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#600}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Surface synchronization: Remove check in LayerTreeImpl

We still get the occasional surface invariants violations in the wild and
we don't necessarily want to crash the renderer in this case. We will already
log things appropriately.

Bug: 672962, 828741
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I262850f2cf704cd59366da6dd4d154227aab5220
Reviewed-on: https://chromium-review.googlesource.com/1112491
Reviewed-by: Saman Sami <[email protected]>
Commit-Queue: Fady Samuel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569781}(cherry picked from commit e59b611ddde7200d14b873183bc1ac48f5747a41)
Reviewed-on: https://chromium-review.googlesource.com/1126500
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#599}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• cc/trees/layer_tree_impl.cc[diff]

android: Retry detached requests on network change.

Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.

Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Commit-Queue: Benoit L <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571173}(cherry picked from commit 0c88d2db535f6c407afb185e8eb40edca2b10f13)
Reviewed-on: https://chromium-review.googlesource.com/1125759
Reviewed-by: Benoit L <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#598}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/android/customtabs/detached_resource_request.cc[diff]

Make mime handlers inherit the session storage of their embedders.

Mime handlers create a nested WebContents to contain the mime handler
extension. Currently, these run with a separate session storage
namespace, resulting in session storage being cleared if a tab recreates
a mime handler, such as due to a reload. Change mime handler WebContents
creation to inherit the session storage namespaces of their embedders so
the session storage behaves similarly to iframes within a single tab.

[email protected]

(cherry picked from commit 69a3377d60d1418a44a599b87210881d1f5fc59b)

Bug: 819761
Change-Id: I3b4f653836190ed86572eb12cdbeef3fbc157683
Reviewed-on: https://chromium-review.googlesource.com/1116633
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570814}
Reviewed-on: https://chromium-review.googlesource.com/1124736
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#597}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• content/browser/web_contents/web_contents_impl.cc[diff]
• extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc[diff]

Incrementing VERSION to 68.0.3440.51

[email protected]

Change-Id: I6887bece3a85c681b1c34b78eeaf89c543e2f345
Reviewed-on: https://chromium-review.googlesource.com/1125441
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#596}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[Merge M68] Extensions: Show file access toggle for activeTab extensions.

r548269 disallowed implicit file url access for extensions with activeTab. This
CL ensures that the file access toggle is visible for extensions using the
activeTab permission, hence providing a way for these extensions to be used on
file urls.

BUG=850643
TEST=Install an extension with activeTab permission. (E.g.
https://chrome.google.com/webstore/detail/page-redder/difbeimhegehkihppkgdlpongficimep?hl=en).
Ensure that "Allow access to file URLs" checkbox is shown for the extension.
[email protected]

Change-Id: I777c8edb29666343f2e5a6e7a1a06a32746178a8
Reviewed-on: https://chromium-review.googlesource.com/1096352
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#566610}(cherry picked from commit 396ced81d62743154629327f121a407db5969e49)
Reviewed-on: https://chromium-review.googlesource.com/1124909
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#595}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc[diff]
• extensions/common/manifest_handlers/permissions_parser.cc[diff]

Keep reference to child ComputedStyle on stack.

Apparently, the ComputedStyle on a child may change during
LayoutBlock::ComputeBlockPreferredLogicalWidths. We used to keep a
reference to the ComputedStyle on the stack before [1]. Re-introducing
scoped_refptr here.

The reduced test exposed a DCHECK problem tracked by 389648. Instead of
adding an almost identical new test, with another TestExpections line,
we add writing-mode to the existing test which would expose the ASAN
issue as well.

[1] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c

Bug: 853538, 389648
Change-Id: I5cb09c8cd9a7ae6d0621758f4690fce2abbb8096
Reviewed-on: https://chromium-review.googlesource.com/1117697
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571199}(cherry picked from commit b0a9cfb77595d3291e9d94beaa0ca3fef68bd76b)
Reviewed-on: https://chromium-review.googlesource.com/1125179
Cr-Commit-Position: refs/branch-heads/3440@{#594}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/fast/text-autosizing/table-inflation-crash.html[diff]
• third_party/blink/renderer/core/layout/layout_block.cc[diff]

ozone: Add low pressure filter for touchscreen

To prevent poor quality touches on hana, add a filter for low pressure
touches, such as those generated by a pencil.  Finger presses are above
the chosen threshold and aren't affected.  If a contact ever exceeds the
presure threshold, all remaining events for that contact are sent.

CQ-DEPEND=CL:1093584
BUG=b:69232663
TEST=manual testing on hana with pressure filter enabled

Change-Id: Ic2d56eb656e318ee46744ef37f6055d8573a2261
Reviewed-on: https://chromium-review.googlesource.com/1096126
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Michael Spang <[email protected]>
Commit-Queue: Sean O'Brien <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569415}(cherry picked from commit e5ba742d9cdff72d0d600440ceb03f018feee1f6)
Reviewed-on: https://chromium-review.googlesource.com/1125039
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#593}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/chromeos/login/chrome_restart_request.cc[diff]
• ui/events/event_switches.cc[diff]
• ui/events/event_switches.h[diff]
• ui/events/ozone/BUILD.gn[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder.cc[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder.h[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder_unittest.cc[diff]
• ui/events/ozone/evdev/touch_filter/low_pressure_filter.cc[Added - diff]
• ui/events/ozone/evdev/touch_filter/low_pressure_filter.h[Added - diff]

[Payments] Open new foreground tab triggered by user in payment handler window in browser

[email protected]

(cherry picked from commit fdadc5fd459664599074bb8557528a1b8814c65d)

Bug: 856743
Change-Id: Icee41ddd6bd4d593ae19b12ac601644d0a004be1
Reviewed-on: https://chromium-review.googlesource.com/1115803
Commit-Queue: Ganggui Tang <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570796}
Reviewed-on: https://chromium-review.googlesource.com/1125087
Cr-Commit-Position: refs/branch-heads/3440@{#592}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc[diff]
• chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h[diff]

Hide incognito switch when incognito is not enabled

In cases where incognito is disabled due to a policy, we should
not see the incognito switch button at all for horizontal tab switcher.
This is in line with having the related menu item for incognito being
disabled

BUG=859160

Change-Id: I6bc19ce27fedc12fc18a9f91f5a7b433c7fb6c82
Reviewed-on: https://chromium-review.googlesource.com/1123405
Commit-Queue: Yusuf Ozuysal <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#572045}(cherry picked from commit 3339971f2bff1bdfefd16fdf28d2528b61b8dfc5)
Reviewed-on: https://chromium-review.googlesource.com/1125040
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#591}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java[diff]

Revert "[vr] Tune scroll event stream"

This reverts commit 7b648651b1ac5f0a40a118ffb39249b09ea92724.

Reason for revert: did not address scrolling issues.

Original change's description:
> [vr] Tune scroll event stream
> 
> This change applies three heuristics to make trackpad scrolling feel
> smoother. We increase the frequency at which we submit scroll events to
> the platform, we also decrease the scroll scale factor (to make the
> scrolls less jumpy), and we do some simple filtering of our scroll
> values.
> 
> I pair-programmed much of this change with asimjour@ and he wrote the
> initial code to interpolate events in the android ui gesture target.
> 
> (cherry picked from commit 0e9a15da019624f9e5d6a3aba35b0102175da5c0)
> 
> Bug: 859075
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
> Reviewed-on: https://chromium-review.googlesource.com/1120425
> Reviewed-by: Michael Thiessen <[email protected]>
> Commit-Queue: Ian Vollick <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#571535}
> Reviewed-on: https://chromium-review.googlesource.com/1123463
> Reviewed-by: Ian Vollick <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3440@{#584}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

[email protected]

Change-Id: I5ba9707aea9dbde21910358df0e599a21085f715
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1124821
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#590}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java[diff]
• chrome/browser/android/vr/android_ui_gesture_target.cc[diff]
• chrome/browser/android/vr/android_ui_gesture_target.h[diff]
• chrome/browser/android/vr/vr_controller.cc[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6de2a304bb0c543c008d58a0a6ee22bdafb12759
Reviewed-on: https://chromium-review.googlesource.com/1124673
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#589}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/strings/ash_strings_sv.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_sv.xtb[diff]
• components/policy/resources/policy_templates_es.xtb[diff]
• components/strings/components_strings_bn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_bn.xtb[diff]

[AF][IOS] Aligns the credit card save infobar icon with the title label

- Replaces the credit card save infobar icon with a new one with smaller
  intrinsic padding so it can be better aligned with the title text.
- Also adjusts the line height of the labels in the infobar.
- New PNGs are pngcrushed.

TBR=mathp

Bug: 854246
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6
Reviewed-on: https://chromium-review.googlesource.com/1111013
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569508}(cherry picked from commit 7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3)
Reviewed-on: https://chromium-review.googlesource.com/1124819
Reviewed-by: Moe Ahmadi (slow July 3) <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#588}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• components/resources/default_100_percent/autofill/infobar_autofill_cc.png[diff]
• components/resources/default_200_percent/autofill/infobar_autofill_cc.png[diff]
• components/resources/default_300_percent/autofill/infobar_autofill_cc.png[diff]
• ios/chrome/browser/ui/autofill/save_card_infobar_view.mm[diff]

VR: remove fullscreen toast on standalones

Bug: 854181
Change-Id: Id2418b88928fcd998e67bed8f011f2dcbb4cc8f5
Reviewed-on: https://chromium-review.googlesource.com/1106293
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569036}(cherry picked from commit d2e9c37af31979c907e2a497eb72e1d89b0f34ab)
Reviewed-on: https://chromium-review.googlesource.com/1124700
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#587}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java[diff]

ozone: Allow multiple delay filters for touchscreen

In order to allow more than one touch filter to delay the reporting of
touches, make the existing filter keep track of its own filter state.

BUG=b:69232663
TEST=manual testing with filters enabled

Change-Id: Idfc68fea22574becd920cdd599dd2e90e19bd04d
Reviewed-on: https://chromium-review.googlesource.com/1093584
Reviewed-by: Michael Spang <[email protected]>
Commit-Queue: Sean O'Brien <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567844}(cherry picked from commit b42a277d0612b3d982941cb144d4b7b00bbf96f4)
Reviewed-on: https://chromium-review.googlesource.com/1120756
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#586}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ui/events/ozone/evdev/touch_event_converter_evdev.cc[diff]
• ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc[diff]
• ui/events/ozone/evdev/touch_filter/edge_touch_filter.cc[diff]
• ui/events/ozone/evdev/touch_filter/edge_touch_filter.h[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder.cc[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder.h[diff]
• ui/events/ozone/evdev/touch_filter/false_touch_finder_unittest.cc[diff]

Fix InitializeOnAudioThread race.

It may race with ShutdownOnAudioThread when running the audio service
out of process.

Bug: 854816
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2ccd4254f4c4f0f70ffb2180c3a586e35ce1baed
Reviewed-on: https://chromium-review.googlesource.com/1109683
Reviewed-by: Henrik Grunell <[email protected]>
Commit-Queue: Max Morin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570029}(cherry picked from commit 75c63f8b8f1f19874867ac05a60c4ebe89496e1a)
Reviewed-on: https://chromium-review.googlesource.com/1124479
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#585}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• media/audio/mac/audio_manager_mac.cc[diff]
• media/audio/mac/audio_manager_mac.h[diff]
• media/audio/win/audio_manager_win.cc[diff]

[vr] Tune scroll event stream

This change applies three heuristics to make trackpad scrolling feel
smoother. We increase the frequency at which we submit scroll events to
the platform, we also decrease the scroll scale factor (to make the
scrolls less jumpy), and we do some simple filtering of our scroll
values.

I pair-programmed much of this change with asimjour@ and he wrote the
initial code to interpolate events in the android ui gesture target.

(cherry picked from commit 0e9a15da019624f9e5d6a3aba35b0102175da5c0)

Bug: 859075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
Reviewed-on: https://chromium-review.googlesource.com/1120425
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571535}
Reviewed-on: https://chromium-review.googlesource.com/1123463
Reviewed-by: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#584}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/AndroidUiGestureTarget.java[diff]
• chrome/browser/android/vr/android_ui_gesture_target.cc[diff]
• chrome/browser/android/vr/android_ui_gesture_target.h[diff]
• chrome/browser/android/vr/vr_controller.cc[diff]

Incrementing VERSION to 68.0.3440.50

[email protected]

Change-Id: Ia0878fb0ce8dcb7ee93004313effc94a5ca1c3ec
Reviewed-on: https://chromium-review.googlesource.com/1123622
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#583}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Avoid unnecessary SharedBuffer data segmentation

When constructing SharedBuffers from flat data, we currently defer to
SharedBuffer::AppendInternal() -- which splits the source into segments.

This is unnecessary overhead (because SharedBuffer can already track a
single flat slab in buffer_), and can generate even more churn
downstream for clients which require a flattened data view (we're
effectively splitting then reassembling the data source for no reason).

Update SharedBuffer's flat data constructors to store all the data
contiguously in buffer_ (similar to SharedBuffer::AdoptVector).

Bug: 853500
Change-Id: I523f23859e62c76225c8d5345005c5bd7911d9c3
Reviewed-on: https://chromium-review.googlesource.com/1113661
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Hajime Hoshi <[email protected]>
Commit-Queue: Florin Malita <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#570385}(cherry picked from commit ce42a9d24c7aac91d073851e2ed4fc3180a8384d)
Reviewed-on: https://chromium-review.googlesource.com/1123037
Reviewed-by: Florin Malita <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#582}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/blink/renderer/platform/shared_buffer.cc[diff]
• third_party/blink/renderer/platform/shared_buffer_test.cc[diff]

Fix a crash on early releases of macOS 10.10.

So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.

Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571123}(cherry picked from commit f44f7dc221536b3d72c76322f17dc04fc04d892d)
Reviewed-on: https://chromium-review.googlesource.com/1123176
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#581}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm[diff]

Media Controls: Fix sizing issues with medium and large breakpoints

This CL updates the sizing-medium and sizing-large CSS class rules to
reduce the sizes. This update makes sizing-large mostly useless, but to
avoid making this change too complex for merging into M68, we are
updating the CSS rules in the simplest way and have added a followup
cleanup task to remove the sizing-large CSS class and other redundant
CSS rules.

Bug: 857145
Change-Id: Ifd80ff7137221f4ca86d0c27f7c4042ec569ef06
Reviewed-on: https://chromium-review.googlesource.com/1117315
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#571190}(cherry picked from commit b5073e2a388dd2ab9445c8101ab0ca265eaa79fc)
Reviewed-on: https://chromium-review.googlesource.com/1123116
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#580}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/media/controls/overlay-play-button-resizes-with-video.html[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.png[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.png[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-zoom-controls-expected.png[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.cc[diff]
• third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css[diff]

Updating XTBs based on .GRDs from branch 3440

[email protected]

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1a50f0752ba631fdfa36280b6a8645d715a59491
Reviewed-on: https://chromium-review.googlesource.com/1122975
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#579}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• ash/strings/ash_strings_da.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_hi.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_no.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_fil.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_hi.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_ja.xtb[diff]
• chrome/app/resources/generated_resources_ms.xtb[diff]
• chrome/app/resources/generated_resources_nl.xtb[diff]
• chrome/app/resources/generated_resources_ta.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/app/resources/generated_resources_zh-CN.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb[diff]
• components/policy/resources/policy_templates_gu.xtb[diff]
• components/policy/resources/policy_templates_hi.xtb[diff]
• components/policy/resources/policy_templates_te.xtb[diff]
• components/strings/components_strings_de.xtb[diff]
• components/strings/components_strings_hi.xtb[diff]
• components/strings/components_strings_te.xtb[diff]
• ios/chrome/app/strings/resources/ios_chromium_strings_hi.xtb[diff]
• ios/chrome/app/strings/resources/ios_google_chrome_strings_hi.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_sw.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_te.xtb[diff]
• ui/strings/translations/ui_strings_en-GB.xtb[diff]

Incrementing VERSION to 68.0.3440.49

[email protected]

Change-Id: I9d097f4955b9ba09c28e3e3c60abf4315146c6f9
Reviewed-on: https://chromium-review.googlesource.com/1121896
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#578}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

Incrementing VERSION to 68.0.3440.48

[email protected]

Change-Id: I2de2957426223c01b8c09fb4d46e713ef8640e40
Reviewed-on: https://chromium-review.googlesource.com/1121528
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#577}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[Merge M68][Extensions] Update captureVisibleTab permission checks

tabs.captureVisibleTab() is interesting. It used to work with every
URL ever, and just checked for if activeTab or <all_urls> was present.
However, this led to some issues where the extension could capture pages
it shouldn't be able to, such as https://crbug.com/810220.

Changing this to only allow access to pages that the extension had
explicit access to also broke important use cases. For instance, taking
screenshots of chrome:-scheme pages is important for filing bugs,
tracking features, etc. This similarly broke use cases for other URLs
that extensions don't have full access to, like other extensions' pages.
An exception was added for chrome:-scheme pages, but this was
insufficient for other cases.

Adjust the permissions check to allow page capture of otherwise-
restricted pages if the extension has activeTab granted. We require
activeTab (rather than either <all_urls> or activeTab) because it gives
a stronger guarantee that the user wants the extension to run on the
given site.

Note: this does not allow any other action on these restricted pages;
only capturing the page is permitted.

The new behavior enforces the following permission requirements for
the host types:
<arbitrary web page>: activeTab OR <all_urls>
file:-scheme page: (activeTab OR <all_urls>) AND
                   explicit file access from chrome://extensions.
Pages restricted by enterprise policy: blocked
Extension's own page: activeTab OR <all_urls>
Another extension's page: activeTab
chrome:-scheme page: activeTab

Support for IPv6 pages and pseudo urls is dependent on these being
properly supported with activeTab, which will be pursued in a followup.

Bug: 839857

[email protected]

(cherry picked from commit 955451dfb49b6cf59dc805737773e944701f9202)

Change-Id: Ied3a71732cd5d41ad16f9b459f6fda9b1815edaf
Reviewed-on: https://chromium-review.googlesource.com/1102902
Reviewed-by: Karan Bhatia <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568471}
Reviewed-on: https://chromium-review.googlesource.com/1121380
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#576}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/extensions/active_tab_unittest.cc[diff]
• chrome/common/extensions/permissions/permissions_data_unittest.cc[diff]
• extensions/common/permissions/permissions_data.cc[diff]

Incrementing VERSION to 68.0.3440.47

[email protected]

Change-Id: Id1269ec2bc6d109d400c9507e061a6c13bd0650c
Reviewed-on: https://chromium-review.googlesource.com/1121518
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#575}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/VERSION[diff]

[Media Controls] Update sizing CSS to new specs

This CL makes some changes to the media controls sizing. It changes the
small threshold to go up to 740px instead of 640px, it changes the
overlay play button size calculation to be smaller, and it changes the
icons to be smaller in the medium threshold.

Bug: 854361
Change-Id: Ic73d254361ffbb5b60bb974253d1abb48a8a04ce
Reviewed-on: https://chromium-review.googlesource.com/1107244
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#569044}(cherry picked from commit 8b04a2116d5522871b7110eb0a9d75d044e6cee0)
Reviewed-on: https://chromium-review.googlesource.com/1119372
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#574}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/media/controls/overlay-play-button-resizes-with-video.html[diff]
• third_party/WebKit/LayoutTests/media/controls/resizing-changes-css-class.html[diff]
• third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/mac-retina/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.png[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Deleted - diff]
• third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-of-video-outline-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.cc[diff]
• third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css[diff]

Discard tab immediately without waiting for LogMemory().

LogMemory() calls memory::OomMemoryDetails::Log(), which is an async
call and may take a long time (only 60% returns < 1s, 10% returns > 5s).
When we're running out of memory, we need to discard tab faster.

BUG=850545

Change-Id: Ia652b2a80f968b0e437904bb6bc2c7c131c1958d
Reviewed-on: https://chromium-review.googlesource.com/1097038
Reviewed-by: Cheng-Yu Lee <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: François Doray <[email protected]>
Commit-Queue: Cheng-Yu Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#567891}(cherry picked from commit 9f5206473f137a0ea67c645b5d9798059393c08f)
Reviewed-on: https://chromium-review.googlesource.com/1121176
Cr-Commit-Position: refs/branch-heads/3440@{#573}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• chrome/browser/memory/oom_memory_details.cc[diff]
• chrome/browser/memory/oom_memory_details.h[diff]
• chrome/browser/resource_coordinator/tab_manager.cc[diff]
• chrome/browser/resource_coordinator/tab_manager.h[diff]
• chrome/browser/ui/sad_tab.cc[diff]

[Media Controls] Prevent the overlay enclosure from being 0x0

This CL adds CSS to make the overlay enclosure the size of the video
to prevent it from defaulting to 0x0. This fixes a bug where once the
overlay cast button disappeared (due to the hide timer), the user was
unable to bring it back by tapping on the overlay enclosure (since
there was nothing to tap on).

Bug: 853855
Change-Id: If4504b84c023cf7f52620ce7d58a71a5522be587
Reviewed-on: https://chromium-review.googlesource.com/1105516
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Becca Hughes <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#568644}(cherry picked from commit 47ae9e57670b0bbf3501bb8de627ea3d660cc713)
Reviewed-on: https://chromium-review.googlesource.com/1121156
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#572}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

• third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt[diff]
• third_party/WebKit/LayoutTests/hdr/video-canvas-alpha-expected.txt[diff]
• third_party/WebKit/LayoutTests/media/controls/controls-cast-overlay-slow-fade.html[diff]
• third_party/WebKit/LayoutTests/media/media-controls.js[diff]
• third_party/WebKit/LayoutTests/media/video-canvas-alpha-expected.txt[diff]
• third_party/WebKit/LayoutTests/media/video-remove-insert-repaints-expected.txt[diff]
• third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-fixed-scrolling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/video-opacity-overlay-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/layers-inside-overflow-scroll-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/overflow-compositing-descendant-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/scroll-ancestor-update-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/load-video-in-reflection-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/self-painting-layers-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/compositing/video-frame-size-change-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-overlay-cast-dark-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/controls/video-overlay-cast-light-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/track/track-cue-rendering-horizontal-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/track/track-cue-rendering-vertical-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-aspect-ratio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-colorspace-yuv420-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-colorspace-yuv422-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-replaces-poster-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-compositing-descendant-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-ancestor-update-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-overlay-cast-dark-rendering-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-overlay-cast-light-rendering-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/track/track-cue-rendering-horizontal-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/track/track-cue-rendering-vertical-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-aspect-ratio-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-colorspace-yuv420-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-colorspace-yuv422-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-replaces-poster-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.10/media/track/track-cue-rendering-vertical-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/video-surface-layer/media/track/track-cue-rendering-vertical-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-fixed-scrolling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/video-opacity-overlay-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/layers-inside-overflow-scroll-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/overflow-compositing-descendant-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/load-video-in-reflection-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/self-painting-layers-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/video-frame-size-change-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/track/track-cue-rendering-vertical-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-aspect-ratio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-colorspace-yuv420-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-colorspace-yuv422-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-poster-scale-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-replaces-poster-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[Added - diff]
• third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-fixed-scrolling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/geometry/video-opacity-overlay-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/layers-inside-overflow-scroll-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/overflow/scroll-ancestor-update-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/reflections/load-video-in-reflection-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/self-painting-layers-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/video-frame-size-change-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/video-overlay-cast-dark-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/controls/video-overlay-cast-light-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/track/track-cue-rendering-horizontal-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/track/track-cue-rendering-vertical-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-aspect-ratio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-colorspace-yuv420-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-colorspace-yuv422-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-poster-scale-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-replaces-poster-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/media/video-zoom-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-frame-accurate-seek-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win7/media/track/track-cue-rendering-vertical-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/win7/virtual/video-surface-layer/media/track/track-cue-rendering-vertical-expected.txt[Added - diff]
• third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css[diff]