Publish DEPS for Chromium 67.0.3396.56

• DEPS[diff]

Incrementing VERSION to 67.0.3396.56

[email protected]

Change-Id: Ib62d4b5526070cb3c6fea67a752895566ee8c378
Reviewed-on: https://chromium-review.googlesource.com/1069610
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#682}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Handle web modal dialogs being unexpectedly closed by -[NSWindow close].

These dialogs have no titlebar, so it should be "impossible" for this
to occur, but crashes in https://crbug.com/825809 suggest it can.
Possibly it happens via code injection or a third party tool.

Add handling and test coverage.

Bug: 825809
Change-Id: Ic856de62ae15ee82ac1346ba6098f2c48daf6d19
Reviewed-on: https://chromium-review.googlesource.com/1068569
Commit-Queue: Sidney San Martín <[email protected]>
Reviewed-by: Sidney San Martín <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560544}(cherry picked from commit 9905c3ff1cc0bf4d604601d8d167599a8946b21f)
Reviewed-on: https://chromium-review.googlesource.com/1067650
Cr-Commit-Position: refs/branch-heads/3396@{#681}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm[diff]
• chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm[diff]

Limit MSAA to 4x on Android devices

These devices tend to be hi-dpi, and low-power. 8x MSAA has also been
seen to trigger various bugs, and impacts performance on some devices.

Bug: 797243, 730303
Change-Id: I41f1ef387009f1f63dff82ecb1f3737d3a0c22aa
Reviewed-on: https://chromium-review.googlesource.com/1013279
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Kai Ninomiya <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550873}(cherry picked from commit 687cb227f2d9a18d632a2657773b0a52889b1c49)
Reviewed-on: https://chromium-review.googlesource.com/1069422
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#680}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• gpu/config/gpu_driver_bug_list.json[diff]

[Nav Experiment] Allow back/forward navigation to WebUI URL.

Cherry-pick to refs/branch-heads/3396.

This is to handle an edge case where on the second back navigation to a
WebUI URL from a web URL, |backForwardList.currentItem.URL| becomes the
WebUI URL instead of the placeholder URL. This is incorrectly classified
as a renderer-initiated app-specific load. The early exit causes no
NavigationContext to be created, which leads to nullptr deferences in
|webView:didCommitNavigation| and |webView:didFinishNavigation|.

Also added nullptr checks for NavigationContext in general.

[email protected]

Bug: 838585,818813
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1e2225adac2cc639e4f6a51bdcb4dece03d96648
Reviewed-on: https://chromium-review.googlesource.com/1044875
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556489}(cherry picked from commit 4ebe29d3d16d74fea153a8bfa01af0985a3d03de)
Reviewed-on: https://chromium-review.googlesource.com/1069372
Reviewed-by: Danyao Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#679}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/chrome/browser/ui/webui/web_ui_egtest.mm[diff]
• ios/web/web_state/ui/crw_web_controller.mm[diff]

Downloads : Fixed NPE

Added a protection against a crash occuring during clicking of menu items
in Download home. The possible reason could be that DownloadItemView can
have a null |mItem| until a onBindViewHolder call is received from the
RecyclerView after the creation through onCreateViewHolder. Hence we
should have null checks inside the DownloadItemView against |mItem|.

Bug: 834918
Change-Id: I76b8a08465da575b9ce364859f827ea3ff053bb5
Reviewed-on: https://chromium-review.googlesource.com/1058369
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558567}(cherry picked from commit e00f4dc4bd361540c7f9facc32702e9efa655a3a)
Reviewed-on: https://chromium-review.googlesource.com/1069310
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#678}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java[diff]

gles2_cmd_decoder: Allow GL_BGRA_EXT in CopyTexImage2D

The GL_EXT_texture_format_BGRA8888 only calls out two entry points
that accept the new GL_BGRA_EXT internalformat:

    Accepted by the <format> and <internalformat> parameters of TexImage2D
    and the <format> parameter of TexSubImage2D:

        GL_BGRA_EXT                                     0x80E1

Some drivers seem to silently allow the format in CopyTexImage2D, but
others throw GL_INVALID_ENUM.  We allow this for clients, by taking
the existing TexImage2D+TexCopySubImage path when internalformat is
GL_BGRA_EXT.

Bug: 834006
Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3
Reviewed-on: https://chromium-review.googlesource.com/1036467
Commit-Queue: Kristian H. Kristensen <[email protected]>
Reviewed-by: Antoine Labour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555264}(cherry picked from commit f1fde8494e5740945e9a7e50fb86e296a09ea1ad)
Reviewed-on: https://chromium-review.googlesource.com/1067716
Reviewed-by: Kristian H. Kristensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#677}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• gpu/command_buffer/service/gles2_cmd_decoder.cc[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h[diff]
• gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc[diff]

[Media Controls] Propagate unhandled overlay play button click events

This CL allows click events on the overlay play button to be
propagated if they do not cause a play/pause. This fixes an issue where
sites that dismissed menus on tap would fail since they would not be
able to see the event being fired.

Bug: 841207
Change-Id: Ib045bb81acc259f932b6adcad1875b5408957f4f
Reviewed-on: https://chromium-review.googlesource.com/1067514
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560375}(cherry picked from commit 259b9dd2958a439531dca094106cb3f2d06e332e)
Reviewed-on: https://chromium-review.googlesource.com/1067740
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#676}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/media/controls/click-on-side-of-overlay-play-button-is-propagated.html[Added - diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.h[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h[diff]
• third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc[diff]

[Merge M67] app_launcher: Fix race condition creating OEM folder.

This fixes one more race condition for OEM folder creation where it is
created on demand on ash side first. This also fixes issue when OEM
folder may appear in ash as normal folder. Plus does refactoring by
discarding passing redundant oem_folder_id.

[email protected]

(cherry picked from commit 4decb912159aee0557f3170703ce1bde01951d51)

Test: Manually
Bug: 839024
Change-Id: I3844e8fbf24fc12c806f25f7c87973eebe167d02
Reviewed-on: https://chromium-review.googlesource.com/1060166
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559122}
Reviewed-on: https://chromium-review.googlesource.com/1066464
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#675}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/app_list/app_list_controller_impl.cc[diff]
• ash/app_list/app_list_controller_impl.h[diff]
• ash/app_list/model/app_list_folder_item.cc[diff]
• ash/app_list/model/app_list_folder_item.h[diff]
• ash/app_list/model/app_list_model.cc[diff]
• ash/app_list/model/app_list_model_unittest.cc[diff]
• ash/public/interfaces/app_list.mojom[diff]
• chrome/browser/ui/app_list/app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/app_list_syncable_service.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/chrome_app_list_model_updater.h[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.cc[diff]
• chrome/browser/ui/app_list/test/fake_app_list_model_updater.h[diff]
• ui/app_list/test/app_list_test_model.cc[diff]
• ui/app_list/test/app_list_test_model.h[diff]
• ui/app_list/views/folder_header_view_unittest.cc[diff]

Merge to M67: Add policy to control app install event logging

Rather than sharing a policy with ARC++ status reporting, this
should be controlled by its own policy.

TBR: [email protected]

(cherry picked from commit d4d93a771895e2998dcde22205bf2fcd48af85c2)

Bug: 843590
Test: AppInstallEventLogManagerWrapperTest
Change-Id: I06910add1cca28f44cf21a57c3eca909a9c88f7c
Reviewed-on: https://chromium-review.googlesource.com/1061532
Commit-Queue: Bartosz Fabianowski <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559626}
Reviewed-on: https://chromium-review.googlesource.com/1065814
Reviewed-by: Bartosz Fabianowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#674}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper.cc[diff]
• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper.h[diff]
• chrome/browser/chromeos/policy/app_install_event_log_manager_wrapper_unittest.cc[diff]
• chrome/browser/policy/configuration_policy_handler_list_factory.cc[diff]
• chrome/browser/prefs/browser_prefs.cc[diff]
• chrome/common/pref_names.cc[diff]
• chrome/common/pref_names.h[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• components/policy/resources/policy_templates.json[diff]
• tools/metrics/histograms/enums.xml[diff]

MHTML serialization needs to handle remote frames in <object> tag.

[email protected]

(cherry picked from commit b623dcf4da0f889b9964c564cc5792c334b9e74e)

Bug: 842411
Change-Id: Ie0205e6e801048c1316ca46da4a4993fd1e009f4
Reviewed-on: https://chromium-review.googlesource.com/1060470
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559618}
Reviewed-on: https://chromium-review.googlesource.com/1068509
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#673}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/download/save_page_browsertest.cc[diff]
• chrome/test/data/save_page/cross-site-object.htm[Added - diff]
• chrome/test/data/save_page/svg.svg[diff]
• testing/buildbot/filters/mash.browser_tests.filter[diff]
• third_party/blink/renderer/core/exported/web_frame_serializer.cc[diff]

Incrementing VERSION to 67.0.3396.55

[email protected]

Change-Id: I4dded8534392c2005d4d4cecb8b39c954429c98d
Reviewed-on: https://chromium-review.googlesource.com/1067962
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#672}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Merge to M67: Remove frame traversal in TextFinder::UpdateFindMatchRects().

Since find-in-page now works on a per-frame basis in the renderer, TextFinder
should not be doing any frame traversal. This also fixes a crash where
TextFinder attempted to access a remote frame during this traversal.

Bug: 840790
Change-Id: If14a17ab8e75c3de56985d53ef4700d3831df3ae
Reviewed-on: https://chromium-review.googlesource.com/1058133
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558917}(cherry picked from commit 44c3d02af75b7c03dc585fab91d9c029cc8528f3)
Reviewed-on: https://chromium-review.googlesource.com/1067950
Cr-Commit-Position: refs/branch-heads/3396@{#671}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/editing/finder/text_finder.cc[diff]
• third_party/blink/renderer/core/editing/finder/text_finder.h[diff]

Merge to M67: Fix CursorManager crash on Android.

Tooltips aren't used on Android, and neither are CursorManagers. This CL
removes a CursorManager null-dereference in
RenderWidgetHostViewChildFrame that occurs on Android.

Bug: 842410
Change-Id: I737d7c4ab6a5befda660a9df5598469ac2802fe6
Reviewed-on: https://chromium-review.googlesource.com/1057993
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: James MacLean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559054}(cherry picked from commit dc521ff9228af3d93e206fca9cd149acf392e839)
Reviewed-on: https://chromium-review.googlesource.com/1067952
Cr-Commit-Position: refs/branch-heads/3396@{#670}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/render_widget_host_view_child_frame.cc[diff]

Merge to M67: Return empty hit-test result when the local main frame is not valid.

When we do async hit-testing for OOPIF, we can be trying to do
hit-testing when the local main frame is not valid anymore. Add null
check for that and return empty hit-test result in that case; it would
then be handled in RenderWidgetInputHandler::GetFrameSinkIdAtPoint [1].

[1] https://cs.chromium.org/chromium/src/content/renderer/input/render_widget_input_handler.cc?type=cs&g=0&l=194

Bug: 842458
Change-Id: Ic6a90de54840973a8262ea88472ae9d295c6f773
Reviewed-on: https://chromium-review.googlesource.com/1058343
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Ria Jiang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558794}(cherry picked from commit b344dd9cf8f51d1051774f79e789185798a81afe)
Reviewed-on: https://chromium-review.googlesource.com/1067951
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#669}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/exported/web_view_impl.cc[diff]

Updating XTBs based on .GRDs from branch 3396

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8a485d0c772c59ce78cd48374f43f2813f993912
Reviewed-on: https://chromium-review.googlesource.com/1068099
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#668}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/components/strings/ash_components_strings_fa.xtb[diff]
• ash/components/strings/ash_components_strings_mr.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_iw.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_pl.xtb[diff]
• chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_es.xtb[diff]
• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb[diff]
• chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb[diff]
• components/policy/resources/policy_templates_id.xtb[diff]
• components/strings/components_strings_iw.xtb[diff]
• components/strings/components_strings_pl.xtb[diff]
• ui/strings/translations/ui_strings_fa.xtb[diff]

Fix Linux proxy settings retrieval.

Only the environment variables were being consulted and not the desktop environment's settings.

[email protected]

(cherry picked from commit cd032fb6004648637d75ac7e3c8677c7e2612811)

Bug: 843942
Change-Id: I22c850717565b219f8ac0dc7566085cccc81af08
Reviewed-on: https://chromium-review.googlesource.com/1066562
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Eric Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560054}
Reviewed-on: https://chromium-review.googlesource.com/1067789
Reviewed-by: Eric Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#667}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• net/proxy_resolution/proxy_config_service_linux.cc[diff]
• net/proxy_resolution/proxy_config_service_linux.h[diff]

Update shelf visibility when display configuration changes.

Shelf is supposed to be hidden on secondary diaplay on lock and login
screens. To reporduce the bug external display needs to be set as primary
screen and then attached while on lock screen. In that case external
monitor is first added as secondary and later set as primary. Shelf
visibility was not updated for the new secondary disply after the primary
display was changed.

Similar bug was also present for login screen. To fix it removing the early
return from ShelfLayoutManager::UpdateVisibilityState was needed. The issue
that required early return is already fixed.

[email protected]

(cherry picked from commit 8af5e106aa826f15b44303af358312d3a7e35c96)

Bug: 824504
Change-Id: I2e3b8e9d6427e3496e72651ba4be1bab538fe25c
Reviewed-on: https://chromium-review.googlesource.com/1052488
Commit-Queue: Aga Wronska <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559922}
Reviewed-on: https://chromium-review.googlesource.com/1067492
Reviewed-by: Aga Wronska <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#666}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/shelf/shelf_controller.cc[diff]
• ash/shelf/shelf_layout_manager.cc[diff]
• ash/shelf/shelf_layout_manager.h[diff]
• ash/shelf/shelf_unittest.cc[diff]

Make renderer use random initial RequestID (instead of 0).

We speculate that some RDH_INVALID_REQUEST_ID kills are caused by having
a renderer process restarted after a crash reuse the same RequestID as
the renderer process from before the crash.  This CL changes the initial
RequestID used by a renderer - before this CL it was always initialized
to 0, after this CL it will be initialized to a random number.  After
this CL the probability of using the same RequestID after restarting a
crashed renderer should drop.

The range of the initial, random RequestID is chosen so that
- The likelyhood of hitting a duplicate is low.
- The work required to overflow the RequestID remains high.

[email protected]

(cherry picked from commit 3538dd4e99019f0c737de06b52477722a5c26c73)

Bug: 614281
Change-Id: I48d21cda1efa3a3e6559726d7fa776bdbb4b05dd
Reviewed-on: https://chromium-review.googlesource.com/1064312
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559629}
Reviewed-on: https://chromium-review.googlesource.com/1067736
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#665}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/renderer/loader/resource_dispatcher.cc[diff]

Merge to M67: Prevent OOPIF resize events from firing after load

OOPIFs will fire resize event handlers immediately after load, because
of the event being triggered in WebFrameWidgetImpl::Resize when the
frame's initial size information is received. This breaks some embedded
frames who assume that it will fire only when the frame actually
changes size.

Bug: 826457
Change-Id: I73de6ff8a81e94a1fd4ad9f7ff6d9ce4df755d7d
Reviewed-on: https://chromium-review.googlesource.com/1064825
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Ken Buchanan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559747}
Reviewed-on: https://chromium-review.googlesource.com/1067486
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#664}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/site_per_process_browsertest.cc[diff]
• content/test/data/page_with_resize_handler.html[Added - diff]
• third_party/blink/renderer/core/frame/web_frame_widget_impl.cc[diff]

Add DigiCert Yeti to Trusted CT Logs

[67 merge] The following CT Logs have passed their monitoring period an are being
added as trusted Logs in Chrome:

DigiCert Yeti2018, Yeti2019, Yeti2020, Yeti2021, Yeti2022

[email protected]
[email protected]

(cherry picked from commit 4508ef53b34e90e445e60dda8fd45f50e89d84dc)

Bug: 796333
Change-Id: I83f7238ed90f2e370c7cf1fe196b6f48862f7d10
Reviewed-on: https://chromium-review.googlesource.com/1058686
Commit-Queue: Ryan Sleevi <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559734}
Reviewed-on: https://chromium-review.googlesource.com/1067509
Reviewed-by: Andrew Whalley <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#663}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• net/data/ssl/certificate_transparency/log_list.json[diff]

[IndexedDB] Fixing early destruction of connection during forceclose

Patch is as small as possible for merging.

Bug: 842990
Change-Id: I9968ffee1bf3279e61e1ec13e4d541f713caf12f
Reviewed-on: https://chromium-review.googlesource.com/1062935
Commit-Queue: Daniel Murphy <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559383}(cherry picked from commit 28044cb7ef4488e7278c2b80f0e3a2c3707d03b6)
Reviewed-on: https://chromium-review.googlesource.com/1067057
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#662}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/indexed_db/indexed_db_database.cc[diff]
• content/browser/indexed_db/indexed_db_transaction.cc[diff]
• content/browser/indexed_db/indexed_db_transaction.h[diff]

Avoid the spare renderer on low-memory devices

[email protected]

(cherry picked from commit 9836bd6629206bbb3f18ef59cf133f22ac6c74e7)

Bug: 843775
Change-Id: I60add18fa51dbdfd61b80c904ce36315b2085f18
Reviewed-on: https://chromium-review.googlesource.com/1065062
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560137}
Reviewed-on: https://chromium-review.googlesource.com/1066089
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#661}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/renderer_host/render_process_host_impl.cc[diff]

[M-67] Make TouchOptimizedUi disabled by default

On M-67, this feature will be enabled only for tablet
devices.

BUG=842291

Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1
Reviewed-on: https://chromium-review.googlesource.com/1066803
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#660}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/base/material_design/material_design_controller.cc[diff]

Surface synchronization: Prevent LatencyInfo from accumulating across surfaces

The LatencyInfo vector in CompositorFrameMetadata can accumulate without bound
when allocating new surfaces. In order to track latency, we carry LatencyInfo
objects across surfaces. The new surface grabs the LatencyInfo objects from
the previous surface.

We used to check if the new Surface has too many LatencyInfos and if not,
grab all LatencyInfos from the previous Surface and we don't check again.
The previous Surface might have a large number of LatencyInfo objects
accumulated, and will accumulate further with every new surface allocated
for a given FrameSink.

The fix is to verify the LatencyInfo vector AFTER taking the items from
the previous surface.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6814fd3657b7b0a9e9d275013e661b176095e740
Bug: 834421, 672962
Reviewed-on: https://chromium-review.googlesource.com/1064810
Commit-Queue: Fady Samuel <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559668}(cherry picked from commit d1564e4226387f17c349e4d8a20cbd3ff8a08dc5)
Reviewed-on: https://chromium-review.googlesource.com/1067056
Reviewed-by: Fady Samuel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#659}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/viz/service/frame_sinks/surface_synchronization_unittest.cc[diff]
• components/viz/service/surfaces/surface.cc[diff]
• components/viz/test/compositor_frame_helpers.cc[diff]
• components/viz/test/compositor_frame_helpers.h[diff]

ozone: Use modifiers for modeset buffers

Modesetting with an x-tiled buffer and then pageflipping to y-tiled
buffers on 3 different crtcs is allowed to fail and indeed does on
APL devices.

This CL makes sure the modeset buffers are allocated with the same
modifiers we allocate buffers for the buffer queue.

Bug: 819692
Test: pyro with 2 external monitors
Change-Id: I392cfecbf598b096947af55c793148933ee83025
Reviewed-on: https://chromium-review.googlesource.com/1054447
Commit-Queue: Daniele Castagna <[email protected]>
Reviewed-by: Kristian H. Kristensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557700}(cherry picked from commit 7745e347500159727d17a3c8c901621da7fb06de)
Reviewed-on: https://chromium-review.googlesource.com/1067032
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#658}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/ozone/platform/drm/gpu/drm_overlay_validator.cc[diff]
• ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc[diff]
• ui/ozone/platform/drm/gpu/drm_thread.cc[diff]
• ui/ozone/platform/drm/gpu/drm_window_unittest.cc[diff]
• ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc[diff]
• ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h[diff]
• ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc[diff]
• ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h[diff]
• ui/ozone/platform/drm/gpu/scanout_buffer.h[diff]
• ui/ozone/platform/drm/gpu/screen_manager.cc[diff]
• ui/ozone/platform/drm/gpu/screen_manager_unittest.cc[diff]

[Android WebView] Lower minidump generation fraction to 1% for Stable

To avoid hitting the cap on the number of uploaded crash reports per day
we lower the fraction of uploaded reports from 100% for Beta to 1% for
Stable.
Note that there should be at least one Beta version with the new lowered
fraction since we do not want to re-push Beta just for this change.

Bug: 831167
Change-Id: Id681e95e7d6d5ff4e417ec4bf19adbf2f4d74656
Reviewed-on: https://chromium-review.googlesource.com/1065676
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#657}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc[diff]

Opus: Make sure HB_gain is not NaN

Crashdumps indicate that HB_gain can become NaN. When the gain is
applied to the input signal all samples become NaN, which causes the
crashes described in chromium:826914.

Changes:
- Check if HB_gain becomes NaN and then set it to 1 (no high-band
attenuation).

If this CL does not fix the issue it should be reverted.
If this CL does fix the issue we should investigate further.

[email protected]

(cherry picked from commit bb4347a94920a5e30e036633c9140c9b7471bff1)

Bug: chromium:826914
Change-Id: Idfcee178715180faf57a3d26918e941b99a09071
Reviewed-on: https://chromium-review.googlesource.com/1061499
Reviewed-by: Felicia Lim <[email protected]>
Reviewed-by: Henrik Andreasson <[email protected]>
Commit-Queue: Gustaf Ullberg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559432}
Reviewed-on: https://chromium-review.googlesource.com/1065916
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#656}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/opus/README.chromium[diff]
• third_party/opus/src/src/opus_encoder.c[diff]

[ForeignObject] Don't allow <foreignObject> to composite in SPv1 mode.

This reduces the instance of broken content due to the fundamental
compositing bug.

Bug: 844538

[email protected]

(cherry picked from commit 1112dc78a874f228a78a7ab4d484e32e46f360f1)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie8841d3cccf58d4b7760366bb6537cfdb3c55d82
Reviewed-on: https://chromium-review.googlesource.com/1066403
Reviewed-by: Tien-Ren Chen <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#560094}
Reviewed-on: https://chromium-review.googlesource.com/1067238
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#655}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/compositing/foreign-object-not-composited.html[Added - diff]
• third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc[diff]

Incrementing VERSION to 67.0.3396.54

[email protected]

Change-Id: I3238a470c4729095319319ee86b0cf8a016c9c8e
Reviewed-on: https://chromium-review.googlesource.com/1067104
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#654}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Incrementing VERSION to 67.0.3396.53

[email protected]

Change-Id: Iea3229d34d88513e626ffd377fa6ac9e0b1a7bd1
Reviewed-on: https://chromium-review.googlesource.com/1067093
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#653}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Disable Google Analytics in the File Manager

This is a small fix that disables Google Analytics in the File Manager
by removing the call to resolve the callback. Calling the Deferred
object in any way causes an XHR request that causes the file picker to
turn white, so not calling it leaves the Filter unresolved which means
the Analytics server is never contacted (and hence the bug doesn't
happen).

Tbr: [email protected]
Bug: 842880,844280
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie525a88689985d2df1028fc1ba87f954fe158caf
Reviewed-on: https://chromium-review.googlesource.com/1065530
Commit-Queue: Sasha Morrissey <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559818}(cherry picked from commit 25af83ddf8c991a6adeee3d05dfb0c06a1cd6d64)
Reviewed-on: https://chromium-review.googlesource.com/1065692
Reviewed-by: Sasha Morrissey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#652}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/file_manager/file_manager_jstest.cc[diff]
• ui/file_manager/file_manager/common/js/metrics.js[diff]

Incrementing VERSION to 67.0.3396.52

[email protected]

Change-Id: If158996c770412216a358d4b330ddbb84b25e7ba
Reviewed-on: https://chromium-review.googlesource.com/1066893
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#651}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

[Omnibox] fix to OmniboxTextView to improve CharTypedToRepaintLatency

This Cl potentially fixes a regression in CharTypedToRepaintLatency UMA
by restoring a shortcut for one line (non-wrapping) answers.

Change-Id: I93d264610f73dfab9db10c81c4ba198adab14c90
Reviewed-on: https://chromium-review.googlesource.com/1014412
Commit-Queue: Dave Schuyler <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#551220}(cherry picked from commit 50b5f88ff4598c87d34b11658ee62d9c5f4840e6)
Reviewed-on: https://chromium-review.googlesource.com/1066870
Reviewed-by: Dave Schuyler <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#650}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/views/omnibox/omnibox_text_view.cc[diff]
• chrome/browser/ui/views/omnibox/omnibox_text_view.h[diff]

[M67 merge] Fix regression for intent picker UI

IntentPickerBubbleView is not saving the user's preference when they
decide to "Stay in Chrome" + "Remember my choice". This is a regression
that appeared in M67.

This CL specials case AppType::INVALID to handle saving user's
preference, previously proposed to add a new AppType::NATIVE_CHROME but
that sounds wrong given this enum lists non-cros app sources.

Besides that we need to make sure that the preference is communicated
to ARC via AddPreferredPackage and honored within ArcNavigationThrottle,
this can be achieved by adding a new enum PreferredPlatform that will
help DidLaunchPreferredArcApp to be more explicit.

(cherry picked from commit I383a926ae613ffe48f4dcd3a478ac124aefe4947)

Bug: 841971
Test: Build.
Change-Id: I405f2202b94e666768f9770e1e2edd0fbc9ec224
Reviewed-on: https://chromium-review.googlesource.com/1066597
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#649}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h[diff]
• chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc[diff]
• chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h[diff]

M67 merge: cros: Fix Shortcut Viewer labels for non-Qwerty layout

Currently for non-Qwerty keyboard layout, Shortcut Viewer returns
incorrect keys. This cl fixes the bug by creating a reverse mapping from
dom_code to {dom_key, key_code}.

[email protected],[email protected]

Bug: 841670
Test: manually.
Change-Id: Ib75bf84b34c0b03bf5501fab0586db8e750478bc
Reviewed-on: https://chromium-review.googlesource.com/1058080
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Kevin Schoedel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559200}(cherry picked from commit e5495df1a9e81b3f87bd652929d71feb379a7a8d)
Reviewed-on: https://chromium-review.googlesource.com/1066333
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#648}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.h[diff]
• ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc[diff]

specify the initial bounds for exo::ShellSurface

[email protected]

(cherry picked from commit 17c449d11bf1440e414bb66a6168ad599219034a)

Bug: b/77472684
Change-Id: I23a9d55eb778cc9e3e38babcf77efdbd5fcfb699
Reviewed-on: https://chromium-review.googlesource.com/1008402
Commit-Queue: Jun Mukai <[email protected]>
Reviewed-by: David Reveman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550696}
Reviewed-on: https://chromium-review.googlesource.com/1066671
Reviewed-by: Jun Mukai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#647}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• components/exo/BUILD.gn[diff]
• components/exo/client_controlled_shell_surface.cc[diff]
• components/exo/client_controlled_shell_surface_unittest.cc[diff]
• components/exo/shell_surface_base.h[diff]

Chrome OS: Fix crash with auto connect notifier.

Also add checks to StubNotificationDisplayService test util class to
catch this in the future (checks match NotificationDisplayServiceImpl
production code).

[email protected]

(cherry picked from commit e03299eab652bf51b73541f8bd52178c913f6439)

Bug: 843692
Change-Id: Iebb64687dadf6eb50bffea80e946e8dd3336bac9
Reviewed-on: https://chromium-review.googlesource.com/1062653
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559307}
Reviewed-on: https://chromium-review.googlesource.com/1066499
Cr-Commit-Position: refs/branch-heads/3396@{#646}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/notifications/stub_notification_display_service.cc[diff]
• chrome/browser/ui/ash/auto_connect_notifier.cc[diff]

[ForeignObject] Hit test foreignObject PaintLayers during normal flow tree walk

Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1060333,
hit testing needs to look at content under <foreignObject> during normal-flow
painting.

This CL also includes a revert of some of the code in these CLs:
https://chromium-review.googlesource.com/c/chromium/src/+/974568
https://chromium-review.googlesource.com/c/chromium/src/+/1055788

Tests were left, as was code in GeometryMapper, which may have other applications
in optimizing hit testing elsewhere.

Bug:842668

[email protected]

(cherry picked from commit c183d574e98671f43fab8445c6904d28065a64a5)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iba38221cd47db4eb146b6c556ce76c9205785ea1
Reviewed-on: https://chromium-review.googlesource.com/1062960
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Tien-Ren Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559752}
Reviewed-on: https://chromium-review.googlesource.com/1066455
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#645}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/blink/renderer/core/layout/layout_object.cc[diff]
• third_party/blink/renderer/core/layout/layout_object.h[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_container.cc[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.cc[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.h[diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_root.cc[diff]
• third_party/blink/renderer/core/layout/svg/svg_layout_support.cc[diff]
• third_party/blink/renderer/core/layout/svg/svg_layout_support.h[diff]
• third_party/blink/renderer/core/paint/paint_layer.cc[diff]
• third_party/blink/renderer/core/paint/paint_layer.h[diff]
• third_party/blink/renderer/core/paint/paint_layer_painter.cc[diff]

Re-land: [ForeignObject] Paint foreign objects during the foreground phase of normal-flow

This reverts commit c9bd830453b2fb8dd5ac8f1a99ca01e3ead52df8.

[email protected], [email protected]

(cherry picked from commit 9aad3d0744f18ac3179315266a44b82087860cc6)

Bug: 842668
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0a81342c4d545c41af1ce48d442c26dd89f34902
Reviewed-on: https://chromium-review.googlesource.com/1064732
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559702}
Reviewed-on: https://chromium-review.googlesource.com/1066452
Cr-Commit-Position: refs/branch-heads/3396@{#644}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-paints-before-rect-expected.html[Added - diff]
• third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-paints-before-rect.html[Added - diff]
• third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/transform-foreign-object-expected.txt[diff]
• third_party/WebKit/LayoutTests/paint/invalidation/svg/transform-foreign-object-expected.txt[diff]
• third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/zoom-foreignObject-expected.png[diff]
• third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/svg/zoom-foreignObject-expected.png[Added - diff]
• third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object.h[diff]
• third_party/blink/renderer/core/paint/README.md[diff]
• third_party/blink/renderer/core/paint/box_painter.cc[diff]
• third_party/blink/renderer/core/paint/paint_layer_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_container_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_foreign_object_painter.cc[diff]
• third_party/blink/renderer/core/paint/svg_foreign_object_painter.h[diff]
• third_party/blink/renderer/platform/graphics/paint/cull_rect.h[diff]

Remove preload from BottomSheetController

The preload functionality causes more problems than it solves. Content
that wants to delay loading until the sheet is opened can do so using
events provided by the BottomSheetObserver. This fixes a race
condition in EoC that would cause the sheet to peek before being
requested.

[email protected]

(cherry picked from commit 4cade243ff8535fcbb772e063a77468d6e18e37e)

Bug: 834923,843267
Change-Id: If5c35e22a502e42f6bc591784b4fb8343e713eff
Reviewed-on: https://chromium-review.googlesource.com/1060353
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559173}
Reviewed-on: https://chromium-review.googlesource.com/1066316
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#643}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCoordinator.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsMediator.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java[diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java[diff]

Skip ScopedMakeCurrent if context IsCurrent().

ui::ScopedMakeCurrent can crash during stub destruction, so we skip
it if the (shared) context is already current.

Bug: 839605
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifaa73ecc84bb335b1e154f38139a41b6ee37cdb9
Reviewed-on: https://chromium-review.googlesource.com/1055879
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558033}(cherry picked from commit b137b49a6d891520bae4babd2a2faac2a482d702)
Reviewed-on: https://chromium-review.googlesource.com/1066152
Reviewed-by: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#642}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• media/gpu/android/surface_texture_gl_owner.cc[diff]

Return color to the microphone tab indicator.

BUG=843075
[email protected]

Change-Id: Iccb161d3d584cf434ae20b5ec91134b04996c999
Reviewed-on: https://chromium-review.googlesource.com/1062411
Reviewed-by: Sidney San Martín <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559268}(cherry picked from commit 6680bbcc64b208500b1fc8c21cb22aa8805ad686)
Reviewed-on: https://chromium-review.googlesource.com/1066114
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#641}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm[diff]
• chrome/browser/ui/cocoa/tabs/tab_view.h[diff]
• chrome/browser/ui/cocoa/tabs/tab_view.mm[diff]

Android: Fix OS's large font setting not being respected

[email protected]

(cherry picked from commit 79f2c11e512e01b101356b733afda3ef32fce5a7)

Bug: 834191
Change-Id: I3a0d79f4d281e426d41951080eb4551b646aab92
Reviewed-on: https://chromium-review.googlesource.com/1054731
Commit-Queue: agrieve <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557927}
Reviewed-on: https://chromium-review.googlesource.com/1066170
Reviewed-by: agrieve <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#640}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java[diff]

[Modern] Fixes inconsistent suggestion view layouts for RTL

The delete button's size is always accounted for when
  laying out suggestion views

Adds padding to the omnibox text when voice search is disabled for RTL

See crbug link for photos.

[email protected]

Bug: 833342
Change-Id: I2b35be70d4296abf7eae318d5dccea4d0201c91f
Reviewed-on: https://chromium-review.googlesource.com/1054201
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Daniel Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559196}(cherry picked from commit be361679741d438622661563385216230b7db437)
Reviewed-on: https://chromium-review.googlesource.com/1066071
Cr-Commit-Position: refs/branch-heads/3396@{#639}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/res/layout/new_tab_page_layout.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java[diff]

Use ListPopupWindow when Android version < N

There are devices that have problem with the new implementation of
DropdownPopupWindow on Android M. At this point, it looks to be too
late to find a proper solution that we can merge back to 67. Therefore,
I change the condition so that all devices < N use the old
implementation of DropdownPopupWindow based on ListPopupWindow.

Bug: 838736
Change-Id: Idfe1c00f609e1a911e09381401eff344131e28d0
Reviewed-on: https://chromium-review.googlesource.com/1055477
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558420}(cherry picked from commit c2f78d17249bb8fe0b8ec074379c77eed10975a3)
Reviewed-on: https://chromium-review.googlesource.com/1066070
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#638}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java[diff]

[Custom Tabs] Handle InflateException for RemoteViews bottom bar.

This follows the best practice outlined in the whitepaper at
https://youtu.be/lrHJhKEtQEI.

Bug: 839648
Change-Id: Ic578859515ae2e1fdd13bf7966c544fe2490ffcf
Reviewed-on: https://chromium-review.googlesource.com/1051244
Commit-Queue: Bernhard Bauer <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557836}(cherry picked from commit 3c635e89030dc460a7fe03766eb968dfe4ca66fa)
Reviewed-on: https://chromium-review.googlesource.com/1065891
Reviewed-by: Bernhard Bauer <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#637}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java[diff]

[M67] Handle null FILE* in CompressAndSaveBitmap

This might be causing the crashes seen in the associated bug. In any
case, it is a good idea to handle the failure, because the reasons why
that FILE* can be null are beyond Chrome's control.

Bug: 838639
Change-Id: I700266840c1447c0b999aa91a361bfba3ff2710b
Reviewed-on: https://chromium-review.googlesource.com/1060057
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559194}(cherry picked from commit 6abe484c9ba102324b9d92f27dfeb3a7e05034bc)
Reviewed-on: https://chromium-review.googlesource.com/1065930
Reviewed-by: Vaclav Brozek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#636}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• content/browser/web_contents/web_contents_android.cc[diff]

Fix failing test in ModuleEventSinkImpl

Tbr: [email protected]
Bug: 839572
Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74
Reviewed-on: https://chromium-review.googlesource.com/1043155
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#555891}(cherry picked from commit f28e1c437fc0236bba7fd3336e57cac1bdc01748)
Reviewed-on: https://chromium-review.googlesource.com/1065570
Cr-Commit-Position: refs/branch-heads/3396@{#635}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc[diff]

Retrieve module information on a background task in ModuleEventSinkImpl

Retrieving this information requires IPC to the remote process, which
is blocking and thus must not be done on the UI thread.

But the ModuleEventSinkImpl instance must still live on the UI thread,
because thats where the RenderProcessHost instance lives. The
RenderProcessHost must be accessed to get the handle to the remote
process inside the ModuleEventSinkImpl::Create() factory function.

To make the process handle available from the background task, it is
now duplicated and passed to the task via the PostTaskWithTraits()
call.

This is a cherry-pick of
https://chromium-review.googlesource.com/c/chromium/src/+/1058339
on branch 3396.

Tbr: [email protected]
Bug: 832286
Change-Id: Ia56499dfec96cfb0cc32863233b3265133a31034
Reviewed-on: https://chromium-review.googlesource.com/1065251
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#634}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/chrome_browser_main_win.cc[diff]
• chrome/browser/chrome_content_browser_client.cc[diff]
• chrome/browser/conflicts/module_event_sink_impl_win.cc[diff]
• chrome/browser/conflicts/module_event_sink_impl_win.h[diff]
• chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc[diff]

[Merge to M67] Reland "Revive WorkerThreadableLoader for sync XHR again"

[email protected]

This reverts commit 4b00991ee27817b60b2a142261bd1d89ca253615.

Reason for revert: It is easy to fix the test failure.

Original change's description:
> Revert "Revive WorkerThreadableLoader for sync XHR again"
>
> This reverts commit 14b1861dc42443535a48b97c09126f1f59cd4088.
>
> Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html:
>
> FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n"
>
> Original change's description:
> > Revive WorkerThreadableLoader for sync XHR again
> >
> > The cl "5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c" which made ThreadableLoader
> > use DocumentThreadableLoader for sync loading from worker thread had broken
> > existing site. https://crbug.com/840348
> >
> > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't
> > support CORS after redirect.
> >
> > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously()
> > support it. So This CL revives WorkerThreadableLoader for sync XHR.
> >
> > Bug: 840348, 706331
> > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537
> > Reviewed-on: https://chromium-review.googlesource.com/1060793
> > Commit-Queue: Tsuyoshi Horo <[email protected]>
> > Reviewed-by: Kinuko Yasuda <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#559023}
>
> [email protected],[email protected]
>
> Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 840348, 706331
> Reviewed-on: https://chromium-review.googlesource.com/1061894
> Reviewed-by: Łukasz Anforowicz <[email protected]>
> Commit-Queue: Łukasz Anforowicz <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#559101}

[email protected],[email protected],[email protected]

(cherry picked from commit b1e172c8d0e85286f9025f291c3fc3e719bc30ff)

Change-Id: I6d078b4124defec2f9d7514b95eed00ff6f685f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840348, 706331
Reviewed-on: https://chromium-review.googlesource.com/1061435
Commit-Queue: Tsuyoshi Horo <[email protected]>
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559107}
Reviewed-on: https://chromium-review.googlesource.com/1064652
Cr-Commit-Position: refs/branch-heads/3396@{#633}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt[diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt[diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/sync-cors-after-redirect-on-worker-worker.js[Added - diff]
• third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html[Added - diff]
• third_party/blink/renderer/core/loader/threadable_loader.cc[diff]

Incrementing VERSION to 67.0.3396.51

[email protected]

Change-Id: Id83e37970a42807dbda199bb23d2c5ca729daa94
Reviewed-on: https://chromium-review.googlesource.com/1064920
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#632}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Merge M67: Update Flash plugin metadata versions to latest version.

https://helpx.adobe.com/security/products/flash-player/apsb18-16.html

BUG=412078
[email protected]

(cherry picked from commit 2e16f1a05975a96e4e19ec97374bb4a7b0c0c8e0)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d26a113f5d32e8fbbaab006b160065146954f4e
Reviewed-on: https://chromium-review.googlesource.com/1065075
Commit-Queue: Will Harris <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559710}
Reviewed-on: https://chromium-review.googlesource.com/1064474
Cr-Commit-Position: refs/branch-heads/3396@{#631}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/resources/plugin_metadata/plugins_linux.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_mac.json[diff]
• chrome/browser/resources/plugin_metadata/plugins_win.json[diff]

[Merge M67] app_launcher: Prevent empty folders in app list.

Fix issue when in some cases (usually reproducible on next user login)
folders are rendered blank.

[email protected]

(cherry picked from commit 65c26bd27a6315ed72e179b8a338f35572cf440c)

Test: Locally
Bug: 838750
Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453
Reviewed-on: https://chromium-review.googlesource.com/1045518
Commit-Queue: Yury Khmel <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556260}
Reviewed-on: https://chromium-review.googlesource.com/1064893
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#630}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/app_list/app_list_controller_impl.cc[diff]

Set the Incompatible Applications Help URL via field trial param

Bug: 717696
Change-Id: I454fe19234a10f0665399cc5f3cae0d4abe1d471
Reviewed-on: https://chromium-review.googlesource.com/1011408
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550777}(cherry picked from commit f456bf440c225e8452675700265c5079de491a11)
Reviewed-on: https://chromium-review.googlesource.com/1065151
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#629}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc[diff]

Fixed normalization of certificate subject for in-file certificates

Bug: 819793
Change-Id: Ic42c128ba5f30208332f17100d24a61ee320c3db
Reviewed-on: https://chromium-review.googlesource.com/1012190
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550677}(cherry picked from commit 09b6721be468564b084ce2647de8082c1cc88c26)
Reviewed-on: https://chromium-review.googlesource.com/1065150
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#628}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/conflicts/module_info_util_win.cc[diff]
• chrome/browser/conflicts/module_info_util_win.h[diff]
• chrome/browser/conflicts/module_info_util_win_unittest.cc[diff]

[Merge to M67]Focus on power button menu when it is invoked.

[email protected]

Focus on power button menu instead of "Power off" item when menu is opened.
This is used to make sure PowerButtonMenuView can still handle the key events
when menu is opened. Since we still need ESCAPE to dismiss the menu and TAB or
direction keys to navigate between menu items.

(cherry picked from commit b013458806a073a78d15d153763f2655daea91df)

Bug: 842336
Change-Id: I4d951e6d520dd28e88362c85e25ef156a1252f30
Reviewed-on: https://chromium-review.googlesource.com/1056294
Commit-Queue: Min Chen <[email protected]>
Reviewed-by: Qiang Xu <[email protected]>
Reviewed-by: Dan Erat <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558493}
Reviewed-on: https://chromium-review.googlesource.com/1064547
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#627}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/system/power/power_button_controller.cc[diff]
• ash/system/power/power_button_controller_unittest.cc[diff]
• ash/system/power/power_button_menu_view.cc[diff]

Fixing getBottomBrowserControlsHeight() typo

I introduced a typo when landing:
https://chromium-review.googlesource.com/c/chromium/src/+/1041218.
This CL fixes that typo.

Bug: 840398
Change-Id: I69d638e7e0e3284518dd198bb2ad455417c7cc2a
Reviewed-on: https://chromium-review.googlesource.com/1048171
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Pedro Amaral <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556875}(cherry picked from commit 535ef248ffed6b0f89b97a9974166a04fc1ed015)
Reviewed-on: https://chromium-review.googlesource.com/1063065
Reviewed-by: Pedro Amaral <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#626}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java[diff]

Merge "Correct extension API permission ID order for kEnterpriseReportingPrivate" to 67.

Change the order to match the enum.xml.

[email protected]

(cherry picked from commit 10b0efd3ec717635143eb07ef6bbb39655e189a5)

Bug: 843141
Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8
Reviewed-on: https://chromium-review.googlesource.com/1059579
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558733}
Reviewed-on: https://chromium-review.googlesource.com/1064722
Reviewed-by: Owen Min <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#625}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• extensions/common/permissions/api_permission.h[diff]

Make download.default_directory read only in settingsPrivate

[email protected]

(cherry picked from commit 4a95aa30d879ea1a8a4ad34f6557c38bc222c542)

Bug: 836362
Change-Id: I677cffed597ce6dc50247916055bd3182d4a206e
Reviewed-on: https://chromium-review.googlesource.com/1041567
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558802}
Reviewed-on: https://chromium-review.googlesource.com/1064743
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#624}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/extensions/api/settings_private/prefs_util.cc[diff]
• chrome/test/data/extensions/api_test/settings_private/test.js[diff]

[tools/perf] Option --output-deps outputs deps to a json file

Bug: 834659
Change-Id: I5df0bc9b923c7a780de896f71cc68443902de12b
Reviewed-on: https://chromium-review.googlesource.com/1031991
Reviewed-by: Ned Nguyen <[email protected]>
Commit-Queue: Vovo Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#554325}(cherry picked from commit e8323033c5ff5755abe6e45ba05060c5a5d90111)
Reviewed-on: https://chromium-review.googlesource.com/1061653
Cr-Commit-Position: refs/branch-heads/3396@{#623}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• tools/perf/fetch_benchmark_deps.py[diff]
• tools/perf/fetch_benchmark_deps_unittest.py[diff]

[Media Controls] Only act as audio element when controls are enabled

This CL prevents video tags from acting as audio tags when the controls
are not enabled. This fixes a bug where video tags with only audio were
showing the audio controls background despite the controls being
hidden.

Bug: 843101
Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e
Reviewed-on: https://chromium-review.googlesource.com/1062225
Reviewed-by: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#559218}(cherry picked from commit 00c3cffbbeff11db315ac4d74bb274558a9f26d6)
Reviewed-on: https://chromium-review.googlesource.com/1064472
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#622}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/media/controls/video-does-not-act-as-audio-tag-with-controls-hidden.html[Added - diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.cc[diff]
• third_party/blink/renderer/modules/media_controls/media_controls_impl.h[diff]

Fix a crash due to NullPointerException

This NullPointerException should be really rare. There is a fix on
the way, for now we just catch the exception to prevent crash.

[email protected]

(cherry picked from commit fafa35cb9b4463b6cac89a61990b8e388488e8eb)

Bug: 842059
Change-Id: Ie130d887d303e7f08504b8c783ae43b87ed31ccf
Reviewed-on: https://chromium-review.googlesource.com/1057427
Reviewed-by: Amirhossein Simjour <[email protected]>
Commit-Queue: Biao She <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558398}
Reviewed-on: https://chromium-review.googlesource.com/1063993
Reviewed-by: Biao She <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#621}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java[diff]

ReadableStreamBytesConsumer should check read results

ReadableStreamBytesConsumer expected that the results from
ReadableStreamReaderDefaultRead should be Promise<Object> because that
is provided from ReadableStream provided by blink, but it's possible to
inject arbitrary values with the promise assimilation.

This CL adds additional checks for such injection.

[email protected]

(cherry picked from commit 7712d138374a92c4d2f3b05cdc86d1a7a523702b)

Bug: 840320
Change-Id: I7b3c6a8bfcf563dd860b133ff0295dd7a5d5fea5
Reviewed-on: https://chromium-review.googlesource.com/1049413
Commit-Queue: Yutaka Hirano <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#556751}
Reviewed-on: https://chromium-review.googlesource.com/1062992
Reviewed-by: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#620}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-stream-with-broken-then.any.js[Added - diff]
• third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer.cc[diff]

Incrementing VERSION to 67.0.3396.50

[email protected]

Change-Id: I703ad5a8e04655c2fccfa8cf1479d208d8b059a2
Reviewed-on: https://chromium-review.googlesource.com/1062814
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#619}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

[Merge to M67]Chrome OS bluetooth filtering

1. For LE devices check the service UUID to determine if it supports HID
or security key, and whitelist those who does.
2. For classic and dual mode devices, whitelist devices which have
non-empty name because device could have an unknown or even known type and
still also provide audio/HID functionality.

(cherry picked from commit 81c120ab94da8c089f9c44d81d72065f06f68868)

Bug: 831218
TBR: [email protected], [email protected]
Change-Id: Id7e5a8ae418c45212773fa846555721ea88cb18a
Reviewed-on: https://chromium-review.googlesource.com/1033965
Reviewed-by: Rahul Chaturvedi <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Xiaoyin Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557390}
Reviewed-on: https://chromium-review.googlesource.com/1063109
Reviewed-by: Xiaoyin Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#618}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ash/system/bluetooth/tray_bluetooth_helper_unittest.cc[diff]
• device/bluetooth/chromeos/bluetooth_utils.cc[diff]

Fix crash due to invalid Window entry on Mac

A few users have invalid Window entries in TabRestoreServiceHelper when
deleting history. These entries are created when individual tabs are
restored from a closed window. This is only possible on Mac.
It is fixed by adjusting the selected_tab_index after a deletion.

Bug: 840508
Change-Id: I429d117df8cf06ee1613220112901590f129d529
Reviewed-on: https://chromium-review.googlesource.com/1049976
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558744}(cherry picked from commit 2f7f86fca7f7c06fa0a64f236d79f258bd33c954)
Reviewed-on: https://chromium-review.googlesource.com/1062845
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#617}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/sessions/tab_restore_browsertest.cc[diff]
• components/sessions/core/tab_restore_service_helper.cc[diff]

Correctly update notification delegate for Chrome OS mojo notifications.

When a notification was updated (same ID, new properties), the
appearance --- title, image, etc. --- was updated, but the old delegate
wasn't replaced with the new delegate. Fix that and add a test.

[email protected]

(cherry picked from commit 070b773c468f3aeed645334f53850175512e8b08)

Bug: 840105
Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3
Reviewed-on: https://chromium-review.googlesource.com/1056091
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558315}
Reviewed-on: https://chromium-review.googlesource.com/1062651
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#616}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/browser/notifications/chrome_ash_message_center_client.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos.cc[diff]
• chrome/browser/notifications/notification_platform_bridge_chromeos_unittest.cc[Added - diff]
• chrome/test/BUILD.gn[diff]

M67: Printing: Read the color setting from the system dialog on Windows.

BUG=843212
[email protected]

(cherry picked from commit 0c4f392def5d8c7c77cdf8a9c20385be3ef2f4f9)

Change-Id: Iab38833fabfe1c6729c76419d50e39cfe7eb098a
Reviewed-on: https://chromium-review.googlesource.com/1060384
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558875}
Reviewed-on: https://chromium-review.googlesource.com/1062187
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#615}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• printing/print_settings_initializer_win.cc[diff]
• printing/printing_context_win_unittest.cc[diff]

Refresh Rect bounds when WindowCoordinate < 0

When the View is partially outside of the Window, the rectangle
bounds should be recalculated with the assumption that the View
is started from the edges.
This will make sure that Autofill popup shows up on top/bottom
of the correct input field, when input fields doesn't fit inside
the Window.

Bug: 828759
Change-Id: I253fc9febe93e90058f95923a18cdfe5363d2186
Reviewed-on: https://chromium-review.googlesource.com/1044529
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Amirhossein Simjour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#557953}(cherry picked from commit 4abbf57b822cd7ca226fda78c510b9e435e3bc90)
Reviewed-on: https://chromium-review.googlesource.com/1061985
Reviewed-by: Amirhossein Simjour <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#614}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/android/java/src/org/chromium/ui/widget/ViewRectProvider.java[diff]

[tools/perf] Add option --output-deps to output deps to stdout

The output is used by CrOS autotest telemetry_runner to upload
dependencies to DUT.

Bug: 834659
Change-Id: I5845fa293e07b35bdcb27030da7fc87ca5b61505
Reviewed-on: https://chromium-review.googlesource.com/1025612
Commit-Queue: Achuith Bhandarkar <[email protected]>
Reviewed-by: Ned Nguyen <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#553559}(cherry picked from commit e6b675d6797927ddcf9378edd53f55d5bd48d591)
Reviewed-on: https://chromium-review.googlesource.com/1059067
Cr-Commit-Position: refs/branch-heads/3396@{#613}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• tools/perf/fetch_benchmark_deps.py[diff]
• tools/perf/fetch_benchmark_deps_unittest.py[diff]

Incrementing VERSION to 67.0.3396.49

[email protected]

Change-Id: Ia8578c6d9cc4d1298dd2df039d59098826b0a92e
Reviewed-on: https://chromium-review.googlesource.com/1060309
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#612}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• chrome/VERSION[diff]

Stop progress indicator if download is replaced.

[email protected]

(cherry picked from commit 44d4d2b99af0b76adc1c9678b70fc3f89805727e)

Bug: 842781
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I001fbaf3d100e173252aacde7b3cc4f28e28fa31
Reviewed-on: https://chromium-review.googlesource.com/1058378
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558699}
Reviewed-on: https://chromium-review.googlesource.com/1060079
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#611}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/chrome/browser/download/download_manager_tab_helper.mm[diff]
• ios/chrome/browser/download/download_manager_tab_helper_unittest.mm[diff]

Disable Display Zoom by default on M67

This patch disables display zoom by default on M67 to find a better user
experience during the transition and also to prevent the breaking of any
kiosk stations.

Bug: 839458
Change-Id: I367f27d7904d380a295d9435077ab379db25bb94
Component: Display zoom, flag
Reviewed-on: https://chromium-review.googlesource.com/1056215
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#610}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ui/display/display_switches.cc[diff]

Crash on unexpected URL change.

[email protected]

(cherry picked from commit ba1815a412382038e41adc189134fcb1b75784aa)

Bug: 841105
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4471a98cdef13e54b790ebcd565d59c67dba8bfd
Reviewed-on: https://chromium-review.googlesource.com/1054196
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#558760}
Reviewed-on: https://chromium-review.googlesource.com/1060377
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#609}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}

• ios/web/features.mm[diff]
• ios/web/public/features.h[diff]
• ios/web/web_state/ui/crw_web_controller.mm[diff]